[00:10:54] *** exmensa <exmensa!exmensa@66.43.202.238> has joined #scummvm
[00:31:22] <snover> rsn8887: i’m not sure exactly what your branch strategy is. you have an `upstream` branch that tracks scummvm master branch?
[00:41:00] *** dtcrshr <dtcrshr!~datacrush@unaffiliated/datacrusher> has quit IRC (Quit: Saindo)
[01:06:58] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[01:09:57] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 268 seconds)
[01:09:57] *** Strangerke_ is now known as Strangerke
[01:15:11] *** waltervn <waltervn!~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl> has quit IRC (Quit: Leaving)
[01:17:32] *** WooShell <WooShell!~Markus@ipbcc071f7.dynamic.kabel-deutschland.de> has quit IRC (Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you.)
[01:24:46] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has joined #scummvm
[01:25:32] *** lavosspawn <lavosspawn!~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de> has joined #scummvm
[01:36:55] *** Littleboy <Littleboy!~littleboy@c-73-186-252-231.hsd1.ma.comcast.net> has joined #scummvm
[01:36:55] *** ChanServ sets mode: +o Littleboy
[01:51:41] *** Farmboy0 <Farmboy0!~quassel@xoreos/farmboy0> has quit IRC (Remote host closed the connection)
[02:04:37] *** gk_-1wm_- <gk_-1wm_-!~su@50.118.213.31> has joined #scummvm
[02:04:38] *** gk_-1wm_- <gk_-1wm_-!~su@50.118.213.31> has left #scummvm
[02:09:19] *** dreammaster <dreammaster!~dreammast@c-73-149-116-247.hsd1.vt.comcast.net> has joined #scummvm
[02:09:19] *** ChanServ sets mode: +o dreammaster
[02:14:30] <m-kiewitz> oh oh oh
[02:22:49] <m-kiewitz> snover: there is currently an active ebay paypal discount code
[02:22:57] <m-kiewitz> only valid for another 40 minutes sadly
[02:23:01] <m-kiewitz> i didn't see it earlier
[02:23:06] <m-kiewitz> $10 off $50 purchases
[02:23:08] <snover> thanks, i still don’t buy physical items though :)
[02:23:33] <m-kiewitz> well it's valid for anything
[02:30:23] <m-kiewitz> oh nice gold rush (Apple IIgs) for $85
[02:33:58] <m-kiewitz> if only waltervn would be here :(
[02:51:58] <snover> man. git is so nice sometimes. i mysteriously broke walking in lsl7, but i did so much rebasing today on this branch i had no clue what might have happened. a quick `git diff working at {one dot day.ago}..working engines/sci/` and i found the answer.
[02:54:22] <snover> all hail the reflog.
[03:27:48] *** gk_-1wm <gk_-1wm!~su@209.73.151.42> has joined #scummvm
[03:27:50] *** gk_-1wm <gk_-1wm!~su@209.73.151.42> has left #scummvm
[03:39:27] <rsn8887> snover: yes. I managed to do it. Since it might be a while until the whole Vita port branch is merged, do you want me to make a new PR for my shader menu code?
[03:40:27] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has quit IRC (Ping timeout: 240 seconds)
[03:40:36] <snover> it’s up to you.
[03:40:56] <rsn8887> snover: It adds a new tab for shader selection. Right now this is only used by the (yet to be merged) Vita backend. But my code is simply adding getSupportedShaders, getShader and setShader functions to OSystem and GraphicsManager (and ModularBackend)
[03:41:32] <rsn8887> snover: The tab is hidden unless the backend has the new feature kFeatureShaders.
[03:41:59] <rsn8887> It will allow users to select shaders in combination with scalers for example for scanline overlays etc.
[03:42:26] <rsn8887> There should be zero impact on current ports, but future possibility for many backends to implement shaders.
[03:42:27] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has joined #scummvm
[03:42:27] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has quit IRC (Changing host)
[03:42:27] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has joined #scummvm
[03:42:49] <snover> ok. i don’t think i know enough to give any useful feedback.
[03:42:58] <rsn8887> I guess I will simply create the PR and if someone is interested they can merge it.
[03:44:14] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm
[03:46:26] *** SylvainTV <SylvainTV!~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr> has quit IRC (Read error: Connection reset by peer)
[03:47:02] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has quit IRC (Ping timeout: 240 seconds)
[03:47:42] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)
[03:47:43] *** m-kiewitz <m-kiewitz!~m_kiewitz@scummvm/undead/m-kiewitz> has quit IRC (Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.)
[03:48:21] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has joined #scummvm
[03:48:21] *** ChanServ sets mode: +o TMM
[03:52:20] *** GitHub120 <GitHub120!~GitHub120@192.30.252.41> has joined #scummvm
[03:52:20]
<GitHub120> [scummvm] rsn8887 opened pull request #910: SDL: added shader menu (hidden if no shaders) (master...upstream) https://git.io/vyTfX
[03:52:20] *** GitHub120 <GitHub120!~GitHub120@192.30.252.41> has left #scummvm
[04:07:30] <Lightkey> The Dagger of Amon Ra continues on twitch.tv/gogcom now :-)
[04:10:14] <Lightkey> "what's Tex Murphy doing with that guy?"
[04:39:57] <Lightkey> "oh, there is actually collision in this game! he wants to go by, move, move!"
[04:40:45] <Lightkey> at least it continued when she got out of the way instead of hanging like in The Colonel's Bequest :-)
[04:42:08] *** GitHub50 <GitHub50!~GitHub50@192.30.252.40> has joined #scummvm
[04:42:08]
<GitHub50> [scummvm] rsn8887 closed pull request #910: SDL: added shader menu (hidden if no shaders) (master...upstream) https://git.io/vyTfX
[04:42:08] *** GitHub50 <GitHub50!~GitHub50@192.30.252.40> has left #scummvm
[04:42:46] <rsn8887> Nevermind, I will make that pull request only as part of the vita branch. I think it will create a nightmare to merge if I duplicate once within and once outside the vita branch
[05:30:34] *** GitHub132 <GitHub132!~GitHub132@192.30.252.34> has joined #scummvm
[05:30:34] <GitHub132> scummvm/master 985f8a3 Paul Gilbert: TITANIC: Fixes for coordinates init in CStarPoints1
[05:30:34] <GitHub132> scummvm/master e107003 Paul Gilbert: TITANIC: Some preliminary cleanup of star control interfaces
[05:30:34] *** GitHub132 <GitHub132!~GitHub132@192.30.252.34> has left #scummvm
[05:40:59] *** dreammaster <dreammaster!~dreammast@c-73-149-116-247.hsd1.vt.comcast.net> has quit IRC ()
[05:57:36] *** Littleboy <Littleboy!~littleboy@c-73-186-252-231.hsd1.ma.comcast.net> has quit IRC (Quit: Être dans le vent, une ambition de feuille morte.)
[06:04:25] *** lavosspawn <lavosspawn!~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 255 seconds)
[06:09:22] *** snover <snover!~snover@unaffiliated/snover> has quit IRC (Ping timeout: 255 seconds)
[06:10:17] *** omer_mor_ <omer_mor_!~Omer@46-117-132-33.bb.netvision.net.il> has joined #scummvm
[06:11:03] *** _sev_ <_sev_!~sev@scummvm/undead/sev> has joined #scummvm
[06:11:03] *** ChanServ sets mode: +o _sev_
[06:11:05] *** kurtwr2 <kurtwr2!~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net> has joined #scummvm
[06:11:34] *** user10 <user10!~Thunderbi@leoseb.ujf-grenoble.fr> has joined #scummvm
[06:14:22] *** wjp_ <wjp_!~wjp@hmm.wantstofly.org> has joined #scummvm
[06:15:17] *** erdic_ <erdic_!~erdic@unaffiliated/motley> has joined #scummvm
[06:15:26] *** snover <snover!~snover@unaffiliated/snover> has joined #scummvm
[06:15:26] *** ChanServ sets mode: +o snover
[06:16:40] *** tsoliman <tsoliman!~tsoliman@cpe-65-30-8-1.wi.res.rr.com> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** user9 <user9!~Thunderbi@leoseb.ujf-grenoble.fr> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** aquadran <aquadran!aquadran@scummvm/undead/aquadran> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** _sev <_sev!~sev@scummvm/undead/sev> has quit IRC (Ping timeout: 260 seconds)
[06:16:41] *** erdic <erdic!~erdic@unaffiliated/motley> has quit IRC (Ping timeout: 260 seconds)
[06:16:45] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has quit IRC (Ping timeout: 240 seconds)
[06:16:45] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has quit IRC (Ping timeout: 240 seconds)
[06:16:45] *** kurtwr <kurtwr!~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
[06:16:46] *** wjp <wjp!~wjp@hmm.wantstofly.org> has quit IRC (Ping timeout: 240 seconds)
[06:16:46] *** balrog <balrog!~balrog@unaffiliated/balrog> has quit IRC (Ping timeout: 240 seconds)
[06:16:46] *** tsoliman_ <tsoliman_!~tsoliman@cpe-65-30-8-1.wi.res.rr.com> has joined #scummvm
[06:16:46] *** user10 is now known as user9
[06:16:48] *** erdic_ is now known as erdic
[06:16:56] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has joined #scummvm
[06:16:56] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has quit IRC (Changing host)
[06:16:56] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has joined #scummvm
[06:17:52] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm
[06:18:21] *** balrog <balrog!~balrog@unaffiliated/balrog> has joined #scummvm
[06:18:32] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has joined #scummvm
[06:18:32] *** ChanServ sets mode: +o TMM
[06:18:54] *** aquadran <aquadran!aquadran@scummvm/undead/aquadran> has joined #scummvm
[06:18:54] *** ChanServ sets mode: +o aquadran
[06:20:08] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[06:23:22] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[06:39:37] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[06:41:15] *** aquadran <aquadran!aquadran@scummvm/undead/aquadran> has quit IRC (Ping timeout: 260 seconds)
[06:41:54] *** aquadran <aquadran!aquadran@scummvm/undead/aquadran> has joined #scummvm
[06:41:54] *** ChanServ sets mode: +o aquadran
[06:42:22] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[06:42:27] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has quit IRC (Ping timeout: 240 seconds)
[06:42:34] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has joined #scummvm
[06:42:34] *** Dominus <Dominus!~dominus@188-22-99-141.adsl.highway.telekom.at> has quit IRC (Changing host)
[06:42:34] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has joined #scummvm
[06:42:41] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[06:46:02] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[07:01:36] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has joined #scummvm
[07:12:09] *** exmensa_ <exmensa_!~exmensa@66.43.202.238> has joined #scummvm
[07:14:16] *** exmensa <exmensa!exmensa@66.43.202.238> has quit IRC (Ping timeout: 260 seconds)
[07:27:38] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[07:30:22] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[07:52:59] *** Begasus <Begasus!~begasus@ptr-4p6jpinfpnimmuv8qdr.18120a2.ip6.access.telenet.be> has joined #scummvm
[09:02:22] *** Lightkey <Lightkey!~Darklock@p200300764C04547722CF30FFFE083718.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 240 seconds)
[09:16:21] *** Lightkey <Lightkey!~Darklock@p200300764C04544022CF30FFFE083718.dip0.t-ipconnect.de> has joined #scummvm
[09:25:21] *** waltervn <waltervn!~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl> has joined #scummvm
[09:25:21] *** ChanServ sets mode: +o waltervn
[09:25:38] <waltervn> morning
[09:26:35] *** vinayakvivek <vinayakvivek!uid121616@gateway/web/irccloud.com/x-unxmldopifdlibpk> has joined #scummvm
[09:35:13] *** LittleToonCat <LittleToonCat!~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net> has quit IRC (Remote host closed the connection)
[09:49:32] *** ny00123 <ny00123!~ny00123@89-139-182-239.bb.netvision.net.il> has joined #scummvm
[09:58:29] *** Begas_VBox <Begas_VBox!~Begasus@d54c3c8c2.access.telenet.be> has joined #scummvm
[10:10:19] <Begasus> morning
[10:10:56] *** Vampire0_ is now known as Vampire0
[10:11:31] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Quit: Verlassend)
[10:11:50] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #scummvm
[10:11:57] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Remote host closed the connection)
[10:12:13] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm
[10:12:26] *** Vampire0_ is now known as Vampire0
[10:18:15] *** jamm <jamm!~jam@unaffiliated/jamm> has joined #scummvm
[10:42:42] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has quit IRC (Ping timeout: 240 seconds)
[11:08:06] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[11:11:22] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[11:26:33] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[11:28:25] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 255 seconds)
[11:28:25] *** Strangerke_ is now known as Strangerke
[11:46:07] *** Netmage <Netmage!~Netmage@pD9E639E1.dip0.t-ipconnect.de> has joined #scummvm
[11:50:20] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has quit IRC (Read error: Connection reset by peer)
[12:02:17] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[12:04:04] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 260 seconds)
[12:04:05] *** Strangerke_ is now known as Strangerke
[12:36:10] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Read error: Network is unreachable)
[12:36:40] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[12:37:58] *** jamm <jamm!~jam@unaffiliated/jamm> has quit IRC (Read error: Connection reset by peer)
[12:52:03] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has joined #scummvm
[12:52:03] *** ChanServ sets mode: +o TMM
[13:01:49] *** WooShell <WooShell!~Markus@ipbcc071f7.dynamic.kabel-deutschland.de> has joined #scummvm
[13:27:59] *** wjp_ is now known as wjp
[13:28:16] *** ChanServ sets mode: +o wjp
[13:46:50] *** Netmage <Netmage!~Netmage@pD9E639E1.dip0.t-ipconnect.de> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
[13:55:40] <WooShell> good meowning =^.^=
[14:01:06] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has joined #scummvm
[14:07:19] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm
[14:32:00] *** eriktorbjorn <eriktorbjorn!~d91tan@h136n7.blg-stadsnat.ias.bredband.telia.com> has quit IRC (Read error: Connection reset by peer)
[14:36:38] *** eriktorbjorn <eriktorbjorn!~d91tan@h136n7.blg-stadsnat.ias.bredband.telia.com> has joined #scummvm
[14:36:38] *** ChanServ sets mode: +o eriktorbjorn
[14:38:59] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has quit IRC (Quit: Leaving.)
[14:43:24] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has joined #scummvm
[14:53:17] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[14:56:17] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 268 seconds)
[14:56:17] *** Strangerke_ is now known as Strangerke
[15:00:12] *** ST1 <ST1!~ScottT@203-227-181-180.cpe.skymesh.net.au> has quit IRC (Quit: Leaving.)
[15:02:08] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has quit IRC (Quit: Leaving.)
[15:08:28] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has quit IRC (Ping timeout: 255 seconds)
[15:10:31] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has joined #scummvm
[15:14:51] *** ST <ST!~ScottT@203-227-181-180.cpe.skymesh.net.au> has joined #scummvm
[15:14:51] *** ChanServ sets mode: +o ST
[15:32:04] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has quit IRC (Quit: Leaving.)
[15:34:12] *** eriktorbjorn <eriktorbjorn!~d91tan@h136n7.blg-stadsnat.ias.bredband.telia.com> has quit IRC (Ping timeout: 240 seconds)
[15:34:42] *** eriktorbjorn <eriktorbjorn!~d91tan@h136n7.blg-stadsnat.ias.bredband.telia.com> has joined #scummvm
[16:12:46] *** Netmage <Netmage!~Netmage@pD9E639E1.dip0.t-ipconnect.de> has joined #scummvm
[16:22:01] *** Farmboy0 <Farmboy0!~quassel@p5DD10E5D.dip0.t-ipconnect.de> has joined #scummvm
[16:22:01] *** Farmboy0 <Farmboy0!~quassel@p5DD10E5D.dip0.t-ipconnect.de> has quit IRC (Changing host)
[16:22:01] *** Farmboy0 <Farmboy0!~quassel@xoreos/farmboy0> has joined #scummvm
[16:29:57] *** Styrbjorn <Styrbjorn!~tommy@c83-251-150-0.bredband.comhem.se> has joined #scummvm
[16:37:10] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Read error: Network is unreachable)
[16:37:35] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[16:46:17] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[16:47:35] *** m_kiewitz <m_kiewitz!~m_kiewitz@x4d03c8ff.dyn.telefonica.de> has joined #scummvm
[16:47:35] *** m_kiewitz <m_kiewitz!~m_kiewitz@x4d03c8ff.dyn.telefonica.de> has quit IRC (Changing host)
[16:47:35] *** m_kiewitz <m_kiewitz!~m_kiewitz@scummvm/undead/m-kiewitz> has joined #scummvm
[16:47:35] *** ChanServ sets mode: +o m_kiewitz
[16:48:44] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 260 seconds)
[16:48:44] *** Strangerke_ is now known as Strangerke
[16:53:24] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has joined #scummvm
[17:14:04] *** Deledrius__ <Deledrius__!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[17:17:02] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[17:19:10] *** ajax16384 <ajax16384!~User@109.60.130.33> has joined #scummvm
[17:19:11] *** ChanServ sets mode: +o ajax16384
[17:27:32] *** LittleToonCat <LittleToonCat!~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net> has joined #scummvm
[17:28:15] *** Netmage <Netmage!~Netmage@pD9E639E1.dip0.t-ipconnect.de> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
[17:32:47] <snover> good day
[17:34:41] <wjp> morning
[17:36:52] <snover> thanks again for the reviews :)
[17:39:17] <wjp> sure; sorry it's taking so long
[17:45:40] *** Deledrius__ is now known as Deledrius
[17:56:21] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has quit IRC (Ping timeout: 268 seconds)
[17:56:24] *** peterkohaut <peterkohaut!~peterkoha@188-167-125-162.dynamic.chello.sk> has joined #scummvm
[18:02:22] *** Cheeseness <Cheeseness!~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net> has joined #scummvm
[18:02:59] *** SylvainTV <SylvainTV!~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr> has joined #scummvm
[18:02:59] *** ChanServ sets mode: +o SylvainTV
[18:03:18] *** phyber_ <phyber_!phyber@unaffiliated/phyber> has joined #scummvm
[18:03:25] *** phyber <phyber!phyber@unaffiliated/phyber> has quit IRC (Read error: Connection reset by peer)
[18:03:47] *** frankyboy_ <frankyboy_!~franky@ppp109-252-73-89.pppoe.spdop.ru> has joined #scummvm
[18:04:12] *** phyber_ is now known as phyber
[18:16:53] <snover> no worries. it doesn’t block anything on my side :)
[19:02:49] *** Littleboy <Littleboy!~littleboy@c-73-186-252-231.hsd1.ma.comcast.net> has joined #scummvm
[19:02:49] *** ChanServ sets mode: +o Littleboy
[19:28:17] <rsn8887> I have been looking at aspect correction some more and I think it could definitely be improved. Currently AR, if enabled, kicks i. For ANY game that runs in a screen mode with 200 lines or 400 lines. However I am pretty sure that some games such as Dreamweb should have it disabled even though they run in 200 lines, and other games that don't use 200 lines probably should have it enabled if they or
[19:28:17] <rsn8887> iginally ran on a platform with rectangular pixels. Also the AR currently only stretches 200-240 but it should be able to stretch any resolution to any ratio depending on the original games pixel height/width ratio
[19:30:47] <rsn8887> But then the menu is currently designed to display well in 320x240 or twice those resolutions. This is opening a can of worms of legacy stuff. So I will stop working on it and focus on other things.
[19:31:47] <rsn8887> But it could be a summer of code to fix that and make the menu more robust or work at any resolution.
[19:35:52] <rsn8887> In the vita port I implemented AR as a simple hardware stretch to 4:3 it works well, is fast, distorts the menu only slightly, but a better name for it would be "force 4:3 aspect" I think that name is much more clear in general because it describes what is being done. Compared to the old name which is nebulous.
[19:37:34] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 255 seconds)
[19:42:27] <rsn8887> For example rear touch support on the Vita it would be awesome to use touch without the hand and fingers getting in the way of graphics.
[20:00:30] <Henke37> really, the whole system is coupled the wrong way around
[20:00:45] <Henke37> the game engine dictates when the graphics get updated
[20:01:16] <Henke37> which makes the emulator gui depedent on when the game engine feels like updating
[20:01:25] <Henke37> except, it doesn't even work like that at all
[20:01:57] <Henke37> when emulator ui is shown, the entire game engine is paused. by means of spinning up an inner main loop
[20:04:47] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has left #scummvm ("Net.LinkToMyPersonalAge")
[20:08:04] *** jamm <jamm!~jam@unaffiliated/jamm> has joined #scummvm
[20:18:51] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[20:27:48] *** LyTchet <LyTchet!~alexandre@host-95-182-129-150.dynamic.voo.be> has joined #scummvm
[20:29:27] *** dreammaster <dreammaster!~dreammast@c-73-149-116-247.hsd1.ma.comcast.net> has joined #scummvm
[20:29:27] *** ChanServ sets mode: +o dreammaster
[20:43:37] *** GitHub14 <GitHub14!~GitHub14@192.30.252.42> has joined #scummvm
[20:43:37] <GitHub14> scummvm/master 77d232f Martin Kiewitz: AGI: always stop sound/music, when calling restore/save since 2.272...
[20:43:37] *** GitHub14 <GitHub14!~GitHub14@192.30.252.42> has left #scummvm
[20:54:37] *** macdude22 <macdude22!~macdude22@2604:2d80:4035:8b5a:5d32:b341:dd6b:363f> has joined #scummvm
[20:58:34] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-khsukjjsmoyuqbdo> has quit IRC (Ping timeout: 255 seconds)
[20:59:15] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-rszokezqclvzekps> has joined #scummvm
[21:03:31] *** GitHub181 <GitHub181!~GitHub181@192.30.252.42> has joined #scummvm
[21:03:31] <GitHub181> scummvm/master 16d21cd Paul Gilbert: TITANIC: Fix CStarPoints2 initialization
[21:03:31] *** GitHub181 <GitHub181!~GitHub181@192.30.252.42> has left #scummvm
[21:16:44] *** LyTchet <LyTchet!~alexandre@host-95-182-129-150.dynamic.voo.be> has quit IRC ()
[21:19:42] *** rsn8887 <rsn8887!Elite19032@gateway/shell/elitebnc/x-rtkgfuqneosjzzbk> has quit IRC (Ping timeout: 240 seconds)
[21:19:43] <snover> m_kiewitz: do you have an idb easily at hand for jones CD and can tell me whether or not kRandom includes code for getting/setting the RNG for 0-arg and 1-arg variants?
[21:19:51] <snover> RNG seed*
[21:19:53] *** rsn8887 <rsn8887!Elite19032@gateway/shell/elitebnc/x-xueuvdxrfznuvrra> has joined #scummvm
[21:20:22] *** jamm <jamm!~jam@unaffiliated/jamm> has quit IRC (Ping timeout: 240 seconds)
[21:22:12] <snover> i checked lsl1vga and it isn’t there, so think it doesn’t show up until sci1late, but would like to be a little more certain about it than i am
[21:23:33] <snover> (lighthouse does the 0-arg call, so i figured i might as well figure out exactly where it started to exist and use the correct version guard)
[21:28:50] *** ny00123 <ny00123!~ny00123@89-139-182-239.bb.netvision.net.il> has quit IRC (Quit: Leaving)
[21:29:02] *** ny00123 <ny00123!~ny00123@89-139-182-239.bb.netvision.net.il> has joined #scummvm
[21:30:04] <m_kiewitz> snover: please do not change anything on that level for anything sci16
[21:30:28] <m_kiewitz> im petty sure i already went through on very long investigation on kRandom some years ago because of some issue
[21:30:41] <m_kiewitz> and you simply can NOT simply check 1 or 2 interpreters in that case
[21:31:06] <m_kiewitz> you need to exactly identify when a change happened, then verify that it didn't also happened on a one off before that (which also happens)
[21:31:10] <m_kiewitz> otherwise you will break stuff
[21:32:19] <m_kiewitz> which is also a pain in the ... to figure out, because there are so many versions
[21:36:34] <wjp> (kRandom in jonescd and lsl1sci are identical)
[21:37:06] <snover> ok, i won’t change it for sci16, but i will say 0-arg just goes to an error() so couldn’t be broken, and 1-arg does the wrong thing in sci1late/1.1 if it’s ever actually used there
[21:37:25] <snover> wjp: thanks
[21:39:39] <snover> not that i know that anyone would be able to ever notice this, especially in sci32 since the rng seed became a 32-bit number but the VM can only get 16 bits of it
[21:44:32] *** GitHub78 <GitHub78!~GitHub78@192.30.252.42> has joined #scummvm
[21:44:32] <GitHub78> scummvm/master 27a0f43 Eugene Sandulenko: DIRECTOR: Move utility functions to util.cpp
[21:44:32] *** GitHub78 <GitHub78!~GitHub78@192.30.252.42> has left #scummvm
[21:45:29] <m_kiewitz> snover: did they keep that exact "get random number in range" code in sci32?
[21:46:11] <snover> i assume so, i didn’t check that part, or if i did it was a long time ago and i forgot :)
[21:47:12] <m_kiewitz> well it would be interesting
[21:47:26] <m_kiewitz> they calculated the range in a specific way and exactly that is needed for some sci16 games
[21:47:47] <m_kiewitz> but it was also a bit weird, so maybe they changed it and then it would have to get adjusted accordingly
[21:48:04] <m_kiewitz> back then it was a pita to get for example the door codes working in larry 5 because of that
[21:48:20] *** lavosspawn <lavosspawn!~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de> has joined #scummvm
[21:49:10] <m_kiewitz> although what's wrong about the 1-argc thing?
[21:50:43] <snover> it’s supposed to set the seed from argv[0] but it does nothing
[21:51:31] <m_kiewitz> yes, we also don't use the exact same method of creating random numbers, that was done intentionally
[21:51:48] <m_kiewitz> we just get the random numbers from ScummVMs RNG if I remember correctly
[21:52:46] <m_kiewitz> so even if we used the seed, there wouldn't really be a point to it, because the games wouldn't get the same random numbers anyway
[21:53:51] <m_kiewitz> it seems with argc not being 1 or 2, it actually would have returned the seed
[21:54:03] <m_kiewitz> what does sci32 do?
[21:54:06] *** Tkachov <Tkachov!Tkachov@gateway/shell/fnordserver.eu/x-jonodqcqdnpvdzkz> has quit IRC (Read error: Connection reset by peer)
[21:54:56] <m_kiewitz> does lighthouse read the seed and set it later?
[21:55:55] <snover> good question
[21:56:05] <snover> i got a little ahead of myself
[21:56:21] <m_kiewitz> there are also 2 kRandom workarounds for Torin right now, what does Torin do? sadly the one adding those didn't mention what the scripts do :(
[21:56:44] <snover> also a good question that i was wondering about.
[21:56:53] <snover> i mean, i can say from the disassembly that sci32 returns the low 16 bits of the seed
[21:57:41] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Read error: Network is unreachable)
[21:58:01] <snover> but i don’t know yet exactly why lighthouse is using it. and i guess i need to work on save games a little more, since the lighthouse ones are broken once you go past the first area.
[21:58:04] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[21:58:41] <m_kiewitz> and the scripts are calling it that way? and they save the seed?
[21:59:07] <m_kiewitz> in theory they could use that feature to get the same numbers back several times
[21:59:16] <snover> yeah, that was the conclusion i jumped to :)
[21:59:43] <snover> but i need several minutes to figure out what room i was in when it did that, so i can verify that it sets it
[21:59:57] <m_kiewitz> well, for sci16 i'm not really sure, if it would be a wise choice to allow no parameters via signatures
[22:00:22] <m_kiewitz> because it's quite obviously never used and if we wanted to be that accurate, we would have to allow any type of parameter because sierra did the same
[22:00:40] <m_kiewitz> you could have called it with kRandom(object, integer, integer, object) and it would have returned the seed too
[22:01:06] <m_kiewitz> sci32 needs to investigated of course
[22:01:15] <m_kiewitz> did that code stay like that for all of sci32?
[22:03:56] <snover> sec, diffing
[22:05:59] <m_kiewitz> wow, Torin's Passage looks basically perfect now
[22:06:25] <m_kiewitz> "Lycentia knocks Torin out", who's Lycentia?
[22:06:55] <snover> the antagonist
[22:07:15] <m_kiewitz> oh i see, and when does that guy/girl knock Torin out?
[22:07:34] <snover> unfortunately, i have no idea. i didn’t add those workarounds
[22:07:41] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Read error: Network is unreachable)
[22:08:03] <m_kiewitz> either it was really kRandom(), or had some garbage data on top
[22:08:03] <snover> try just navigating to that room from the debugger i guess
[22:08:10] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[22:09:06] <m_kiewitz> no idea how to get her to punch Torin
[22:17:02] <m_kiewitz> hmm in case lighthouse would really need that functionality, we would probably have to find a way with that seed
[22:17:23] <m_kiewitz> right now Common::RandomSource uses a uin32 as seed, so no way for a script to save it
[22:23:13] <wjp> well
[22:23:25] <wjp> there's a lot of potential reg_t tricks if it's important enough
[22:24:30] <wjp> (and, oh, workarounds for not fully implemented functionality? :-( )
[22:25:51] *** ajax16384 <ajax16384!~User@109.60.130.33> has quit IRC (Read error: Connection reset by peer)
[22:25:59] *** Tkachov <Tkachov!Tkachov@gateway/shell/fnordserver.eu/x-olpqmloylibamhnv> has joined #scummvm
[22:27:01] <snover> sorry, i had to go lay down for a minute.
[22:28:37] <snover> functionally, it looks like everything is the same for all of sci32, except that argc=3 gets dropped in sci3
[22:28:59] <snover> and is effectively a no-op if it is ever called
[22:31:07] <snover> the RNG seed in SSCI is 32-bits, and it also takes only the low 16 bits for the VM, so it looks like that shouldn’t cause an incompatibility
[22:34:13] <snover> though… i am wedded to much to my fully filled out SQ6 IDB :) for lighthouse the 32-bit accumulator means the entire seed would fit into it
[22:34:18] <m_kiewitz> snover: we got 2 workarounds for torin, one is for cycleDone and I only see this code for cycleDone:
[22:34:19] <m_kiewitz> code_04db: push2
[22:34:19] <m_kiewitz> pTos waitMin
[22:34:19] <m_kiewitz> pTos waitMax
[22:34:19] <m_kiewitz> callk Random, $4
[22:34:27] <m_kiewitz> and that should work I guess?
[22:34:39] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-rszokezqclvzekps> has quit IRC (Ping timeout: 260 seconds)
[22:34:58] *** Deledrius_ <Deledrius_!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has joined #scummvm
[22:35:08] *** frankyboy_ <frankyboy_!~franky@ppp109-252-73-89.pppoe.spdop.ru> has quit IRC (Remote host closed the connection)
[22:35:21] <snover> i really need to look at the lighthouse game script and see where it is storing this value, since i still think it would get truncated eventually
[22:35:22] <snover> m_kiewitz: yeah
[22:35:30] <m_kiewitz> wjp: we still have no idea for what situation those workarounds were added
[22:35:30] <snover> those workarounds don’t make a lot of sense to me either
[22:35:50] <m_kiewitz> wjp: at least the cycleDone makes no sense to me, but maybe there is another version of Torin, idk
[22:36:24] <snover> i mean, if lighthouse calls kRandom argc=1, even in SSCI3, that can still only be a 16-bit value
[22:36:43] <snover> i’m gonna stop talking in circles and find the correct game script…:)
[22:36:55] <m_kiewitz> maybe thoses cases are script bugs then?
[22:37:10] <m_kiewitz> if they only got 16 bits of the seed, they couldn't reproduce the values anyway
[22:37:42] *** Deledrius <Deledrius!~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e> has quit IRC (Ping timeout: 240 seconds)
[22:37:49] <wjp> snover: do you see any calls with argc == 1 in Lighthouse?
[22:38:00] <snover> wjp: yeah, that is how this whole thing started.
[22:38:11] <snover> er
[22:38:11] <m_kiewitz> and what's that argument?
[22:38:11] <snover> no
[22:38:12] <snover> sorry
[22:38:15] <snover> aaaaa
[22:38:17] <snover> !
[22:38:19] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has joined #scummvm
[22:38:19] <m_kiewitz> ?!?!
[22:38:21] <snover> i saw an argc=0 and it crashed on it
[22:38:23] <wjp> I only see 0 and 2
[22:38:33] <m_kiewitz> where are the argc=0?
[22:38:39] <m_kiewitz> script?
[22:38:53] <wjp> rm447::init
[22:38:59] <m_kiewitz> is it doing anything with _acc?
[22:39:59] <m_kiewitz> super LightRoom, $4
[22:39:59] <m_kiewitz> push0
[22:39:59] <m_kiewitz> callk Random, $0
[22:40:00] <m_kiewitz> o_O
[22:40:06] <m_kiewitz> looks like a script bug
[22:40:14] <m_kiewitz> callk Random, $0
[22:40:14] <m_kiewitz> push1
[22:40:14] <m_kiewitz> pushi $171 ; 369, nextRoom
[22:40:14] <m_kiewitz> callb export000_5, $2
[22:40:22] *** omer_mor_ <omer_mor_!~Omer@46-117-132-33.bb.netvision.net.il> has quit IRC (Ping timeout: 240 seconds)
[22:40:42] <m_kiewitz> but well, we can just accept no arguments and return NULL_REG
[22:41:26] <m_kiewitz> snover: sci32 doesn't use kRandom() to init the RNG?
[22:42:19] <snover> i’m not sure, i never looked for that. if it ever did that it would’ve just been silently ignored by the existing kRandom code
[22:42:21] <m_kiewitz> maybe a SCI dev thought it would
[22:42:30] <m_kiewitz> really weird
[22:44:18] <snover> i guess i caused a lot of confusion for nothing. sorry :(
[22:44:38] <m_kiewitz> nah we should really change signatures and open it up
[22:45:00] <m_kiewitz> and you aren't the SCI developer who called it like that anyway :P
[22:45:30] <m_kiewitz> you should really verify the range calculation in sci32 though and if it's really 100% the same
[22:45:43] <m_kiewitz> because if they changed it, that could cause some tiny minor issue somewhere
[22:46:12] *** heroux <heroux!~heroux@gateway02.insomnia247.nl> has joined #scummvm
[22:46:27] *** ny00123 <ny00123!~ny00123@89-139-182-239.bb.netvision.net.il> has quit IRC (Quit: Leaving)
[22:47:41] <snover> mov eax, [esp+4+high]; sub eax, [esp+4+low]; inc eax;
[22:47:46] <snover> so, the same
[22:49:40] <snover> there is not that reverse order thing from longbow/kq5cd, though i don’t know if it ever gets triggered
[22:51:07] <m_kiewitz> that depends on how the RNG returned the numbers depending on the range
[22:52:06] <m_kiewitz> hmm if we only had a debugger for the original sci32 for testing those edge cases out
[22:59:41] <wjp> do we have a compiler for sci32 scripts?
[22:59:49] <wjp> or assembler
[23:00:21] <m_kiewitz> i doubt it. we could change scripts manually of course.
[23:00:43] <m_kiewitz> snover: shall i change up kRandom accordingly?
[23:02:04] <snover> m_kiewitz: sorry, I am apparently confused today :) you are speaking of changing the kernel signature?
[23:02:14] <m_kiewitz> yes and a tiny bit of code
[23:02:41] <m_kiewitz> i will pobably add a warning for kRandom() calls (without parameters)
[23:02:50] <m_kiewitz> so that we see when this happens
[23:03:42] <snover> Sounds OK to me. Seems lighthouse just needs to be script patched to remove the bogus call
[23:03:57] <snover> And I have not seen it anywhere else yet
[23:05:12] <m_kiewitz> i will also remove the workarounds for torin
[23:09:02] *** Begas_VBox <Begas_VBox!~Begasus@d54c3c8c2.access.telenet.be> has quit IRC (Quit: Vision[0.9.8]: i've been blurred!)
[23:10:07] *** Begas_VBox <Begas_VBox!~Begasus@d54c3c8c2.access.telenet.be> has joined #scummvm
[23:10:32] <snover> OK.
[23:10:52] *** heroux <heroux!~heroux@gateway02.insomnia247.nl> has quit IRC (Ping timeout: 255 seconds)
[23:24:31] <m_kiewitz> snover: shall I actually return the seed for those cases?
[23:24:36] <m_kiewitz> or just return NULL_REG?
[23:24:59] <m_kiewitz> it's difficult, I guess we should expect all of those calls to be script bugs first of all
[23:25:16] <snover> Might as well do what ssci did since we can
[23:26:27] <m_kiewitz> i have no clue why kRandom is inside kmath.cpp, btw. I would expect it inside kmisc.cpp
[23:26:51] *** heroux <heroux!~heroux@gateway02.insomnia247.nl> has joined #scummvm
[23:27:05] <waltervn> wjp: I add SCI2 support to scis a few years ago, but I doubt anyone has tried it besides me...
[23:27:08] <waltervn> *added
[23:28:13] <waltervn> make that 5 years ago, yikes. Time really does fly
[23:44:02] <waltervn> looks like my ISP is having trouble again... sigh
[23:49:25] *** cody56 <cody56!~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de> has joined #scummvm
[23:50:39] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm
[23:52:16] *** lavosspawn <lavosspawn!~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 255 seconds)
[23:53:51] *** ST <ST!~ScottT@203-227-181-180.cpe.skymesh.net.au> has quit IRC (Quit: Leaving.)
[23:57:42] *** waltervn <waltervn!~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl> has quit IRC (Quit: Leaving)
[23:58:34] *** ST <ST!~ScottT@203-227-181-180.cpe.skymesh.net.au> has joined #scummvm
[23:58:34] *** ChanServ sets mode: +o ST