February 17, 2017 
< | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | >
February 17, 2017 [00:01:54] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Remote host closed the connection)[00:04:38] *** erdic <erdic!~erdic@unaffiliated/motley> has quit IRC (Remote host closed the connection)[00:06:05] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has quit IRC (Read error: Connection reset by peer)[00:06:43] *** Farmboy0 <Farmboy0!~quassel@xoreos/farmboy0> has quit IRC (Remote host closed the connection)[00:07:42] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has joined #scummvm[00:08:43] *** erdic <erdic!~erdic@unaffiliated/motley> has joined #scummvm[00:14:10] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Remote host closed the connection)[00:30:00] <snover> m_kiewitz: do you happen to have disassembly for SCI01 and earlier available that you could search quickly to tell me of a function that calls lofsa/lofss? something’s a little broken in the disassembler and i don’t know quite which one it is[00:30:22] <m_kiewitz> wait, what?[00:31:22] <m_kiewitz> aren't those VM opcodes?[00:31:25] <snover> yeah[00:31:38] <m_kiewitz> tell me of a function that calls lofsa/lofss??[00:31:47] * m_kiewitz is confused[00:31:52] <snover> a script object method that uses one of those opcodes[00:32:09] <snover> sorry, i see how that was a badly worded question[00:32:09] <m_kiewitz> ah i thought you meant SCI01 or earlier interpreter disassembly[00:33:22] <m_kiewitz> kq4 early has that opcode in basically every single script[00:34:05] <m_kiewitz> i don't have many reversed game scripts though[00:34:12] <m_kiewitz> i can also look inside my script patch archive[00:34:41] <m_kiewitz> still why do you need sci01/sci0? I'm pretty sure the current code works fine for those[00:34:50] <snover> if it’s all over the place there, i should be able to find it quickly. i probably should have even just stuck a breakpoint in the debugger and checked that way, duh :)[00:35:13] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has joined #scummvm[00:35:15] <m_kiewitz> im not sure if the other kq4 versions use it that many times too[00:35:18] <m_kiewitz> but i would guess so[00:35:22] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has quit IRC (Remote host closed the connection)[00:35:38] <snover> m_kiewitz: i’m unsure if the third argument passed to findOffset is correct. it’s off by one when it comes time to look up the offset in SCI3[00:35:58] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has joined #scummvm[00:36:09] <snover> retval seems to point to the expected place in SCI3, but i dunno if that’s true for sci0 too, so i gotta check it.[00:36:34] <snover> the VM works OK, just the disassembler seems to have this problem, so i presume findOffset is valid and the input is wrong[00:36:41] <m_kiewitz> why not keep the current code for sci<=1.1?[00:37:15] <snover> i will end up doing that if retval turns out to be wrong in sci0[00:37:25] <m_kiewitz> sci16 is a nightmare, there were all sorts of changes, so when you change such code for every version, you risk that there is some sci version that does it differently[00:37:44] <m_kiewitz> anyway[00:38:04] <m_kiewitz> in kq4 early even the room25::init method has lofsa opcodes[00:38:32] <m_kiewitz> it does a few kLoads and then after a few more opcodes it uses lofsa[00:38:53] <m_kiewitz> it comes almost right after a "class Fwd"[00:39:57] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has quit IRC (Ping timeout: 240 seconds)[00:40:06] <wjp> snover: at a glance I think the disasm is using the position of the opcode itself, but the vm the position after the opcode?[00:40:22] <m_kiewitz> oh right, and there is for example sci0early, which was used for the early kq4 versions and the early larry 2 version, but you are kinda lucky, because it was also used by sierra's first SCI xmas card greetings[00:40:43] <m_kiewitz> so you should definitely check if your changes work with that one too[00:41:12] <wjp> snover: other opcodes are using retval.getOffset() instead of pos.getOffset() for pc-relative things[00:41:21] <m_kiewitz> all collections do not include those versions, i was lucky and got possibly the very first king's quest 4 version on floppies[00:41:27] <wjp> snover: (in the disassembler)[00:41:56] <snover> wjp: yeah, that sounds about right. so i think it’s right to change this to use retval. but i wanted to make sure by verifying output because i am bad at this :)[00:42:24] <m_kiewitz> snover: i can test your change for that king's quest 4 version[00:42:49] <snover> m_kiewitz: more luckily, the lofs handling is the same from sci0 early through sci01[00:43:06] <snover> according to detectLofsType[00:43:22] <snover> KQ4 from the collection identifies lofs type as early sci0[00:43:36] <snover> kq collection*[00:44:08] <wjp> snover: this should be a pretty safe change I think[00:44:16] <m_kiewitz> that's just lofs type, there is also sci0early[00:44:29] <m_kiewitz> i mean sci0early as SCI version[00:44:56] <m_kiewitz> sci0 early versions of those games are definitely on none of the collection CDs[00:45:22] <snover> m_kiewitz: findOffset only uses the detectLofsType when deciding what to do[00:45:55] <m_kiewitz> i would still prefer actually testing it[00:46:14] <wjp> ... testing what?[00:47:32] <m_kiewitz> if everything still works for sci0early games?[00:48:07] <m_kiewitz> collections typically contain king's quest 4 0.000.502, which is SCI0LATE[00:48:19] <m_kiewitz> which is version 1.006.004[00:48:43] <wjp> sure, by all means test the disassembler, but it's just a small mismatch between VM and disassembler for LofsType == 0_EARLY[00:48:46] <m_kiewitz> latest kq4 sci0early was interpreter 0.000.274, version 1.000.111[00:50:08] <m_kiewitz> im not arguing it for not changing it, im simply saying that such changes should get tested with at the very least one game per SCI version[00:50:30] <wjp> changes to debugging output?[00:51:37] <m_kiewitz> I don't understand? So you are saying that the debugger - that we use - is not important enough to test it?[00:52:13] <m_kiewitz> it's not like testing would take days[00:52:17] <wjp> 00:48 < wjp> sure, by all means test the disassembler[00:53:00] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has joined #scummvm[00:53:00] <m_kiewitz> "... but it's just a small mismatch"[00:53:06] <wjp> yes[00:53:06] <wjp> it is[00:53:30] *** WooShell <WooShell!~Markus@ipbcc071f7.dynamic.kabel-deutschland.de> has quit IRC (Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you.)[00:53:36] <m_kiewitz> yes, but some small change may still introduce some issue.[00:53:39] * wjp sighs[00:53:40] <wjp> so test it[00:54:49] <rsn8887> wjp: no no it does make sense![00:55:14] <rsn8887> WarpMouseInWindow is not called at all times, that is why a processMouseEvent is needed.[00:56:00] <wjp> processMouseEvent is just a small step of the pipeline[00:56:10] <rsn8887> JoyAxisMotion is changing event.type because it treats a JoyAxis event as a mousemove.[00:56:34] <rsn8887> and that works perfectly fine everywhere[00:56:36] <wjp> processMouseEvent mainly fills the Common::Event structure to prepare it for returning it from pollEvent[00:56:59] <snover> wjp: as it turns out, sci0 doesn’t even follow this code path in the disassembler. the opcode format for that version of SCI is Script_SRelative[00:57:01] <wjp> JoyAxisMotion returns the generated mouse motion event back to pollEvent, which returns it to the event handler[00:57:33] <wjp> rsn8887: your code prepares the event in handleKbdMouse, but then drops it[00:57:55] <rsn8887> wjp: which is good. But what if NO JoyAxisMotion is generated. The user is holding the stick in one position without changing it. Then handleKbdMouse deals with that[00:58:07] <wjp> yes, but it doesn't generate an event[00:58:09] <rsn8887> wjp: hu? where is it dropped?[00:58:20] <wjp> in pollEvent[00:58:32] <wjp> handleKbdMouse returns this event, but pollEvent completely ignores it[00:59:54] <rsn8887> well SDLEventSource::pollEvent doesn't do anything with it, but it is now a mouse event that will be processed by the EventHandler that called pollEvent[01:00:02] <wjp> no[01:00:06] <rsn8887> why not?[01:00:19] <wjp> pollEvent will either overwrite it or return false[01:00:45] <rsn8887> oh no that would indeed be terrible. Where is that overwrite?[01:01:04] <wjp> that's the whole functionality of pollEvent[01:01:08] <m_kiewitz> snover: you have checked qfg2?[01:01:46] <rsn8887> wjp: I don't see any overwrite?[01:02:42] <rsn8887> pollEvent is doing stuff with the SDL event ev, but nothing with the common event, event?[01:03:17] <wjp> rsn8887: the function of pollEvent is to see if there is an event available. If it is, it returns true and fills the event argument. If there isn't, it returns false[01:03:41] <wjp> the input event is uninitialized and unused[01:03:58] <wjp> so if you fill event at the very beginning, pollEvent will ignore it[01:04:38] <rsn8887> wjp: Ah so I should return true![01:04:43] <rsn8887> This might explain the problem.[01:04:58] <rsn8887> so if handleKbdMouse creates an event, then pollEvent should return true.[01:06:03] <rsn8887> wjp: thanks I think that is the problem. Now it is just a matter of returning true.[01:06:27] <rsn8887> at the right time[01:10:19] <rsn8887> handleKbdMouse(event);[01:10:19] <rsn8887> if event.type=COMMON::MOUSEEVENT {[01:10:19] <rsn8887> return true;[01:10:21] <rsn8887> }[01:10:28] <rsn8887> should do the trick.[01:11:00] <wjp> only if you also initialize it to something else otherwise, and replace the = by ==, but it might be cleaner to make handleKbdMouse also return true if it produces an event[01:12:54] <rsn8887> ok will do I think this will finally fix this.[01:13:17] <rsn8887> I didn't realize the important "return false" at the very end of pollEvent. Thanks for the help![01:14:08] <wjp> you're welcome[01:17:41] <rsn8887> wjp: now the delay in handleKbdMouse also becomes really important to allow pollEvent to poll the other stuff even if the user is holding the stick.[01:18:22] <rsn8887> also all the other handle* members are bool (for a reason)[01:19:17] <wjp> snover: I suppose that SRelative might now actually be outdated with your lofsa changes?[01:22:22] <snover> wjp: i’m not sure i understand. which usage would be outdated?[01:23:35] <wjp> I'm not entirely sure; but from a distance it looks like your lofsa/lofss output changes look like they might also work for LofsType SCI0_EARLY[01:23:49] <wjp> (in the Script_Offset case)[01:24:35] <wjp> so I was wondering if the opcode format could just be changed to Script_Offset for all versions (dropping it from script_adjust_opcode_formats)[01:24:49] <rsn8887> wjp: Ok I fixed handleKbdMouse to return true when it generates an event, and then pollEvent also returns true if that is the case. will test it tonight and then make PR later[01:24:55] <wjp> rsn8887: great[01:25:33] <snover> wjp: oh. well, potentially, i suppose. the difference between the two appears to be that Script_SRelative params are signed and Script_Offset are unsigned[01:25:51] <snover> other than that, they do seem to be identical[01:27:50] <wjp> the signedness is a good point[01:28:31] <wjp> readPMachineInstruction of course already handled that in the vm[01:28:52] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm[01:31:04] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)[01:32:01] <wjp> (and do ignore my suggestion about script_adjust_opcode_formats; I'd forgotten that wasn't debugger-only :-) )[01:33:55] <snover> :) brains can only retain so many facts, and you’ve got a lot of them in there[01:34:41] <wjp> but is the SRelative case then giving wrong output?[01:35:36] <wjp> or maybe I should just go to bed and let you fix this in peace :-)[01:36:43] <snover> :) it appears to be including the offset from retval so is correct[01:37:18] <snover> it might be worthwhile to change it to use findOffset too[01:37:49] <wjp> the improved output would be nice[01:38:40] <criezy> wjp: does it seem sensible to you to return false from handleJoyAxisMotion just before the call to processMouseEvent() if axis is equal to 0 (and thus the event type not set)?[01:39:10] <wjp> criezy: at first glance, yes, but I haven't thought about it too much[01:40:47] <criezy> It's probably not a good idea to make a change after midnight anyway (at least in my case).[01:41:02] <criezy> So I am keeping that for this weekend when I will have a bit more time to look at it.[01:41:17] <criezy> And when my brain might actually be in working order.[01:45:04] <criezy> In particular I was wondering if it should not return false in all cases since that function actually never moves the mouse (as far as I can see) and it is only moved in handleKbdMouse.[01:46:12] <wjp> mhm, if we change handleKbdMouse to return a mouse motion event, it might indeed be pointless[01:53:03] *** dreammaster <dreammaster!~dreammast@c-73-149-116-247.hsd1.ma.comcast.net> has joined #scummvm[01:53:03] *** ChanServ sets mode: +o dreammaster[01:57:10] *** bgK <bgK!~bgk@rbx1-fr.quadhost.net> has quit IRC (Ping timeout: 256 seconds)[02:03:37] *** m_kiewitz <m_kiewitz!~m_kiewitz@scummvm/undead/m-kiewitz> has quit IRC (Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.)[02:04:01] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #scummvm[02:04:12] *** GitHub117 <GitHub117!~GitHub117@192.30.252.42> has joined #scummvm[02:04:12] <GitHub117> [scummvm] rsn8887 opened pull request #906: SDL: More fixes to jerky analog joystick pointer (master...upstream) https://git.io/vD94E[02:04:12] *** GitHub117 <GitHub117!~GitHub117@192.30.252.42> has left #scummvm[02:04:40] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[02:07:37] *** bgK <bgK!~bgk@rbx1-fr.quadhost.net> has joined #scummvm[02:07:37] *** ChanServ sets mode: +o bgK[02:12:41] *** rsn8887_ <rsn8887_!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has joined #scummvm[02:12:42] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has quit IRC (Read error: Connection reset by peer)[02:17:09] *** rsn8887_ <rsn8887_!~rsn8887@ip-129-15-64-254.wireless-pat.ou.edu> has quit IRC (Ping timeout: 260 seconds)[02:19:49] *** exmensa <exmensa!~exmensa@66.43.202.238> has joined #scummvm[02:19:51] *** SylvainTV <SylvainTV!~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr> has quit IRC (Read error: Connection reset by peer)[02:21:38] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm[02:22:16] *** Henke37 <Henke37!~Henrik@81-227-16-59-no133.bredband.skanova.com> has quit IRC (Quit: ERR_SHUTDOWN)[02:22:46] *** exmensa_ <exmensa_!exmensa@66.43.202.238> has quit IRC (Ping timeout: 268 seconds)[02:23:41] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 245 seconds)[02:23:41] *** Strangerke_ is now known as Strangerke[02:35:46] *** |Cable| <|Cable|!~cable@33.138.117.91.dynamic.reverse-mundo-r.com> has quit IRC (Ping timeout: 264 seconds)[02:40:03] *** GitHub117 <GitHub117!~GitHub117@192.30.252.40> has joined #scummvm[02:40:03] <GitHub117> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD9EY[02:40:03] <GitHub117> scummvm/master 899585d Paul Gilbert: TITANIC: Remove old debug code[02:40:03] *** GitHub117 <GitHub117!~GitHub117@192.30.252.40> has left #scummvm[02:47:28] *** |Cable| <|Cable|!~cable@33.138.117.91.dynamic.reverse-mundo-r.com> has joined #scummvm[03:09:42] *** GitHub0 <GitHub0!~GitHub0@192.30.252.42> has joined #scummvm[03:09:42] <GitHub0> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD9zI[03:09:42] <GitHub0> scummvm/master 216e57a Paul Gilbert: TITANIC: Renamings for CGameObject & CGameState methods[03:09:42] *** GitHub0 <GitHub0!~GitHub0@192.30.252.42> has left #scummvm[03:35:18] *** GitHub120 <GitHub120!~GitHub120@192.30.252.45> has joined #scummvm[03:35:18] <GitHub120> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD9gu[03:35:18] <GitHub120> scummvm/master d56e4e4 Paul Gilbert: TITANIC: Further renamings for CGameObject[03:35:18] *** GitHub120 <GitHub120!~GitHub120@192.30.252.45> has left #scummvm[03:36:35] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has quit IRC (Ping timeout: 240 seconds)[03:43:09] *** GitHub17 <GitHub17!~GitHub17@192.30.252.41> has joined #scummvm[03:43:09] <GitHub17> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD92J[03:43:09] <GitHub17> scummvm/master 314c795 Paul Gilbert: TITANIC: Cleanup of movie flags[03:43:09] *** GitHub17 <GitHub17!~GitHub17@192.30.252.41> has left #scummvm[03:55:10] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm[03:56:40] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[04:02:44] *** GitHub161 <GitHub161!~GitHub161@192.30.252.41> has joined #scummvm[04:02:44] <GitHub161> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD9am[04:02:44] <GitHub161> scummvm/master cb9ebfc Paul Gilbert: TITANIC: Fix compiler warning[04:02:44] *** GitHub161 <GitHub161!~GitHub161@192.30.252.41> has left #scummvm[04:20:08] *** travis-ci <travis-ci!~travis-ci@ec2-54-226-228-231.compute-1.amazonaws.com> has joined #scummvm[04:20:09] <travis-ci> scummvm/scummvm#2705 (master - 899585d : Paul Gilbert): The build has errored.[04:20:09] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/c0d155db9723...899585d478ef[04:20:09] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/202472911[04:20:09] *** travis-ci <travis-ci!~travis-ci@ec2-54-226-228-231.compute-1.amazonaws.com> has left #scummvm[04:27:33] *** Littleboy <Littleboy!~littleboy@c-73-186-252-231.hsd1.ma.comcast.net> has quit IRC (Quit: Être dans le vent, une ambition de feuille morte.)[04:44:32] *** deepbook5broo <deepbook5broo!~gk.1wm.su@2a03:4a80:2:2d4:2d4:e830:6db2:a7d4> has joined #scummvm[04:44:33] *** deepbook5broo <deepbook5broo!~gk.1wm.su@2a03:4a80:2:2d4:2d4:e830:6db2:a7d4> has left #scummvm[05:00:44] <snover> uch. travis.[05:02:34] *** Unseen2 <Unseen2!snowcat@snowcat.de> has quit IRC (Read error: Connection reset by peer)[05:03:21] *** Unseen2 <Unseen2!snowcat@snowcat.de> has joined #scummvm[05:04:45] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #scummvm[05:05:28] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 255 seconds)[05:13:13] <snover> uch. sci engine.[05:14:10] <snover> this bitmap error is weird. the VM appears to send a View object that should be displaying an actual view, not a bitmap[05:15:06] <snover> and, it calls kAddScreenItem for the view right before this call to kSetNowSeen.[05:22:34] <snover> well, looks like my clever code deduplication when updating screen items isn’t quite right, since who would reuse an ID for something that used to be a bitmap and now is a view?! :)[05:31:32] <snover> i am completely baffled that this is the first time this bug happened[05:37:48] *** GitHub35 <GitHub35!~GitHub35@192.30.252.34> has joined #scummvm[05:37:48] <GitHub35> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vD9Mm[05:37:48] <GitHub35> scummvm/master 46076c0 Paul Gilbert: TITANIC: Fix operation of Phonograph play button[05:37:48] *** GitHub35 <GitHub35!~GitHub35@192.30.252.34> has left #scummvm[05:52:19] *** dreammaster <dreammaster!~dreammast@c-73-149-116-247.hsd1.ma.comcast.net> has quit IRC ()[05:59:34] *** LittleToonCat <LittleToonCat!~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net> has quit IRC (Remote host closed the connection)[06:10:29] *** ST1 <ST1!~ScottT@203-227-181-180.cpe.skymesh.net.au> has joined #scummvm[06:10:46] *** ST <ST!~ScottT@203-227-181-180.cpe.skymesh.net.au> has quit IRC (Disconnected by services)[06:24:08] *** travis-ci <travis-ci!~travis-ci@ec2-54-226-228-231.compute-1.amazonaws.com> has joined #scummvm[06:24:09] <travis-ci> scummvm/scummvm#2709 (master - cb9ebfc : Paul Gilbert): The build has errored.[06:24:09] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/314c795d21ce...cb9ebfcb1c1e[06:24:09] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/202487236[06:24:09] *** travis-ci <travis-ci!~travis-ci@ec2-54-226-228-231.compute-1.amazonaws.com> has left #scummvm[06:48:14] *** rsn8887 <rsn8887!~rsn8887@ip68-97-13-84.ok.ok.cox.net> has joined #scummvm[06:50:53] *** rsn8887 <rsn8887!~rsn8887@ip68-97-13-84.ok.ok.cox.net> has quit IRC (Remote host closed the connection)[06:53:36] *** rsn8887 <rsn8887!~rsn8887@ip68-97-13-84.ok.ok.cox.net> has joined #scummvm[06:54:18] <snover> well, phant2 is completable.[06:56:01] <snover> gotta fix some bugs with the computer interface but otherwise i didn’t notice any more problems[07:04:16] <snover> oh wait, that’s a lie. i also had to force all property setters to set the view update flag. the _mustSetViewVisible stuff for sci3 isn’t quite working correctly yet.[07:08:29] *** waltervn <waltervn!~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl> has joined #scummvm[07:08:29] *** ChanServ sets mode: +o waltervn[07:13:21] *** rsn8887 <rsn8887!~rsn8887@ip68-97-13-84.ok.ok.cox.net> has quit IRC (Remote host closed the connection)[07:19:37] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm[07:21:08] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)[08:32:30] *** m_kiewitz <m_kiewitz!~m_kiewitz@x4d03d1f2.dyn.telefonica.de> has joined #scummvm[08:32:30] *** m_kiewitz <m_kiewitz!~m_kiewitz@x4d03d1f2.dyn.telefonica.de> has quit IRC (Changing host)[08:32:30] *** m_kiewitz <m_kiewitz!~m_kiewitz@scummvm/undead/m-kiewitz> has joined #scummvm[08:32:30] *** ChanServ sets mode: +o m_kiewitz[09:05:58] *** Lightkey <Lightkey!~Darklock@p200300764C2EBF9422CF30FFFE083718.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 258 seconds)[09:19:15] *** Lightkey <Lightkey!~Darklock@p200300764C2EBF0222CF30FFFE083718.dip0.t-ipconnect.de> has joined #scummvm[09:23:08] *** Axy <Axy!~Mia@unaffiliated/mia> has quit IRC (Read error: Connection reset by peer)[09:28:05] *** Mia <Mia!~Mia@85.110.63.74> has joined #scummvm[09:28:05] *** Mia <Mia!~Mia@85.110.63.74> has quit IRC (Changing host)[09:28:05] *** Mia <Mia!~Mia@unaffiliated/mia> has joined #scummvm[10:02:31] *** Polynomial-C <Polynomial-C!~Poly-C@gentoo/developer/Polynomial-C> has quit IRC (Remote host closed the connection)[10:03:42] *** _sev|work <_sev|work!~sev@scummvm/undead/sev> has joined #scummvm[10:03:42] *** ChanServ sets mode: +o _sev|work[10:21:57] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[10:22:11] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #scummvm[10:24:45] *** t0by <t0by!~t0by@unaffiliated/t0by> has joined #scummvm[10:24:45] *** ChanServ sets mode: +v t0by[10:49:09] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has quit IRC (Quit: Ex-Chat)[11:19:32] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #scummvm[11:20:51] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[11:33:55] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has joined #scummvm[11:33:55] *** ChanServ sets mode: +o TMM[11:34:16] *** bgK <bgK!~bgk@rbx1-fr.quadhost.net> has quit IRC (Ping timeout: 255 seconds)[11:36:08] *** bgK <bgK!~bgk@2001:41d0:2:599c::2a60:8434> has joined #scummvm[11:36:08] *** ChanServ sets mode: +o bgK[11:46:59] *** kurtwr <kurtwr!~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net> has joined #scummvm[11:48:25] *** ny00123 <ny00123!~ny00123@bzq-79-182-43-200.red.bezeqint.net> has quit IRC (Quit: Leaving)[11:48:41] *** ny00123 <ny00123!~ny00123@bzq-79-182-43-200.red.bezeqint.net> has joined #scummvm[12:20:54] *** D0SFreak <D0SFreak!~D0SFreak@172.56.5.239> has joined #scummvm[12:27:35] *** NuSuey <NuSuey!uid3556@gateway/web/irccloud.com/x-wuhbafglvhnjnyhs> has joined #scummvm[13:02:06] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has joined #scummvm[13:04:21] *** omer_mor_ <omer_mor_!~Omer@46-117-132-33.bb.netvision.net.il> has quit IRC (Ping timeout: 240 seconds)[13:12:09] *** ajax16384 <ajax16384!~User@109.60.138.138> has joined #scummvm[13:12:09] *** ChanServ sets mode: +o ajax16384[13:24:31] *** kurtwr <kurtwr!~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 255 seconds)[13:33:52] *** jamm <jamm!~jam@unaffiliated/jamm> has joined #scummvm[13:49:11] *** ny00123 <ny00123!~ny00123@bzq-79-182-43-200.red.bezeqint.net> has quit IRC (Quit: Leaving)[14:21:04] *** LittleToonCat <LittleToonCat!~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net> has joined #scummvm[14:26:15] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm[14:40:07] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has quit IRC (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/)[14:42:58] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm[14:46:45] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has left #scummvm[14:53:23] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm[14:54:30] *** user9 <user9!~Thunderbi@leoseb.ujf-grenoble.fr> has quit IRC (Quit: user9)[14:54:58] *** user9 <user9!~Thunderbi@leoseb.ujf-grenoble.fr> has joined #scummvm[14:56:39] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has quit IRC (Client Quit)[15:01:04] *** Dominus <Dominus!~dominus@194-166-17-105.adsl.highway.telekom.at> has joined #scummvm[15:01:04] *** Dominus <Dominus!~dominus@194-166-17-105.adsl.highway.telekom.at> has quit IRC (Changing host)[15:01:04] *** Dominus <Dominus!~dominus@unaffiliated/dominus> has joined #scummvm[15:18:56] *** exmensa_ <exmensa_!exmensa@66.43.202.238> has joined #scummvm[15:21:04] *** exmensa <exmensa!~exmensa@66.43.202.238> has quit IRC (Ping timeout: 255 seconds)[15:30:01] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm[15:52:38] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has joined #scummvm[15:54:18] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-tesfbgsfoagcgoka> has quit IRC (Ping timeout: 268 seconds)[15:54:28] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-lhijijfpusdkbchs> has joined #scummvm[15:59:08] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-lhijijfpusdkbchs> has quit IRC (Ping timeout: 260 seconds)[16:08:02] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has quit IRC (Read error: Connection reset by peer)[16:14:14] *** heroux <heroux!sandroco@gateway/shell/insomnia247/x-rnjjqldbfxwtdeju> has joined #scummvm[16:17:56] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has joined #scummvm[16:32:52] *** rsn8887 <rsn8887!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Quit: Leaving...)[16:53:58] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has quit IRC (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/)[16:58:42] *** ajax16384 <ajax16384!~User@109.60.138.138> has quit IRC (Quit: Leaving)[17:09:41] *** Littleboy <Littleboy!~littleboy@c-73-186-252-231.hsd1.ma.comcast.net> has joined #scummvm[17:09:41] *** ChanServ sets mode: +o Littleboy[17:19:07] *** kurtwr <kurtwr!~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net> has joined #scummvm[17:21:34] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #scummvm[17:23:03] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)[17:32:46] *** rsn8887 <rsn8887!Elite19032@gateway/shell/elitebnc/x-lsystfjuhdbvwvig> has joined #scummvm[17:39:22] *** WooShell <WooShell!~Markus@ipbcc071f7.dynamic.kabel-deutschland.de> has joined #scummvm[17:39:24] <WooShell> meow =^.^=[17:42:18] *** ajax16384 <ajax16384!~User@109.60.130.33> has joined #scummvm[17:42:18] *** ChanServ sets mode: +o ajax16384[17:45:29] *** dtcrshr <dtcrshr!~datacrush@2801:88:f7a:100:cd0e:4045:cabe:7462> has joined #scummvm[17:45:29] *** dtcrshr <dtcrshr!~datacrush@2801:88:f7a:100:cd0e:4045:cabe:7462> has quit IRC (Changing host)[17:45:29] *** dtcrshr <dtcrshr!~datacrush@unaffiliated/datacrusher> has joined #scummvm[17:49:10] *** t0by <t0by!~t0by@unaffiliated/t0by> has quit IRC (Quit: Bye!)[17:54:43] *** ced117 is now known as ced117s[17:54:45] *** ced117s is now known as ced117[17:55:14] *** rsn8887_ <rsn8887_!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has joined #scummvm[17:57:21] *** rsn8887_ <rsn8887_!~rsn8887@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Client Quit)[18:05:31] *** _sev|work <_sev|work!~sev@scummvm/undead/sev> has quit IRC (Quit: This computer has gone to sleep)[18:07:58] *** delme_ <delme_!~delme@ip-129-15-64-253.wireless-pat.ou.edu> has joined #scummvm[18:08:36] <delme_> Hello[18:09:11] *** delme_ <delme_!~delme@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Client Quit)[18:17:44] *** delme_ <delme_!~delme@ip-129-15-64-253.wireless-pat.ou.edu> has joined #scummvm[18:18:10] <delme_> Hello[18:19:26] <delme_> Hello?[18:24:46] <snover> yes, your messages are received[18:25:11] *** delme_ <delme_!~delme@ip-129-15-64-253.wireless-pat.ou.edu> has quit IRC (Quit: Leaving...)[18:30:27] *** _sev|work <_sev|work!~sev@scummvm/undead/sev> has joined #scummvm[18:30:27] *** ChanServ sets mode: +o _sev|work[18:49:30] *** NuSuey <NuSuey!uid3556@gateway/web/irccloud.com/x-wuhbafglvhnjnyhs> has quit IRC (Quit: Connection closed for inactivity)[18:50:26] <omer_mor> hey snover[18:50:30] <snover> hi omer_mor[18:50:59] <omer_mor> your working branch seems very advanced compared to trunk[18:51:03] <snover> it is[18:51:17] <omer_mor> any plans on how to start bringing your stuff in?[18:51:33] *** _sev|work <_sev|work!~sev@scummvm/undead/sev> has quit IRC (Quit: This computer has gone to sleep)[18:51:43] <snover> i’m unable to land mostly anything until PR 882 lands.[18:51:44] *** GitHub100 <GitHub100!~GitHub100@192.30.252.45> has joined #scummvm[18:51:44] <GitHub100> [scummvm] sev- pushed 3 new commits to master: https://git.io/vDQJ1[18:51:44] <GitHub100> scummvm/master e48dd54 Eugene Sandulenko: DIRECTOR: Added Events debug channel, more debug output in Lingo[18:51:44] <GitHub100> scummvm/master c5295a1 Eugene Sandulenko: DIRECTOR: Fix script references for D3 (now for real)[18:51:44] <GitHub100> scummvm/master fb79925 Eugene Sandulenko: DIRECTOR: Beutify debug output[18:51:44] *** GitHub100 <GitHub100!~GitHub100@192.30.252.45> has left #scummvm[18:53:26] <snover> so i am at the mercy of the requested reviewers to either say “it’s OK to land now without a review“ or it actually gets reviewed[18:53:29] <omer_mor> the bounds-checking PR[18:53:37] <snover> yes[18:53:50] <omer_mor> it's been in review for quite some time now[18:53:53] <snover> yes[18:53:57] <omer_mor> :/[18:55:10] <omer_mor> after that PR do you think you'll be ready to start testing SCI32?[18:55:22] <omer_mor> publicly, that is[18:55:25] <snover> i rebase everything against master on a pretty regular basis so it’s not like there will be some huge future effort to bring things back up to date[18:55:54] <snover> most of the SCI32 games will be ADGF_TESTING for the next release[18:56:48] <snover> someone that likes QFG4 needs to play QFG4, I tried to run through it but having to wait for the day/night cycle and not having a clear path through the game makes it annoying to test[19:01:44] *** Farmboy0 <Farmboy0!~quassel@p5DD10B67.dip0.t-ipconnect.de> has joined #scummvm[19:01:44] *** Farmboy0 <Farmboy0!~quassel@p5DD10B67.dip0.t-ipconnect.de> has quit IRC (Changing host)[19:01:44] *** Farmboy0 <Farmboy0!~quassel@xoreos/farmboy0> has joined #scummvm[19:04:16] *** bgK <bgK!~bgk@2001:41d0:2:599c::2a60:8434> has quit IRC (Ping timeout: 255 seconds)[19:07:06] * _sev is so sick of great multitudes of fake Russian bot accounts "liking" ScummVM page on Facebook[19:07:28] <_sev> all is scam and potentially spam or could be used for some sort of wicked propaganda... sigh[19:07:29] *** bgK <bgK!~bgk@rbx1-fr.quadhost.net> has joined #scummvm[19:07:29] *** ChanServ sets mode: +o bgK[19:10:48] <_sev> oh, looks that I can rmove them[19:21:10] <wjp> snover: in Object::locateVarSelector, for getSciVersion > 1_LATE and <= 2_1_LATE, it reads obj->getVariable(1) entries from _baseVars. Does that necessarily match the size the subspan gets in Object::init ?[19:26:21] <snover> wjp: looking…[19:27:59] <snover> it looks like it. the _variables size is taken from offset 2, and variable 1 would be initialised from offset 2[19:28:14] <snover> according to object.cpp:98 on my working branch[19:28:23] <snover> and object.cpp:78[19:29:27] <snover> so that original line in locateVarSelector seems…questionable[19:30:48] <snover> wjp: did you notice this working on some related problem, or just stumbled upon it?[19:33:28] <wjp> oh, your comments above reminded me to read through your bounds PR[19:33:40] <snover> ah. :)[19:34:14] <snover> i’m looking through the history to see why someone thought this needed to be done, but unfortunately several times i have done this i just run into the freesci commit[19:34:27] <snover> hopefully that won’t happen this time…[19:35:00] <wjp> there's always https://github.com/wjp/freesci-archive too :-)[19:39:25] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has quit IRC (Quit: Ex-Chat)[19:42:12] <snover> yeah. ran into the freesci commit again.[19:43:03] <snover> i also need to figure out a faster way to use git blame.[19:43:55] <wjp> gitk has a nice "show origin of this line" in its context menu[19:44:38] <wjp> and if that doesn't show a relevant patch, you can easily repeat it on the previous version of that line[19:47:21] <snover> reading the manpage has me onto something referred to as the pickaxe, git log -S 'string to look for'[19:48:44] <snover> combine with the -p flag, see the diffs only from commits that contain that string[19:51:00] <snover> or, git blame -C to make it not show commits that were just copying or moving a line to another line[19:51:48] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has joined #scummvm[19:54:01] <snover> but, i guess i should also install gitk and test that out for a while too sometime :)[19:55:06] <snover> anyway, it came from lskovlun with a commit message “SCI1.1 support”[19:59:15] <snover> i guess the other thing that’s different here for sci1.1-2.1 is that the count is always getting retrieved from a class object instead of potentially from an instance object, though i am not sure if that matters[20:00:00] <wjp> for a SciSpan<uint16>, did getUint16*At(2) read at byte 2 or byte 4?[20:00:48] <snover> 4[20:01:20] <snover> fwiw, since that PR i’ve changed this code to use more containers and fewer pointers[20:01:52] <snover> because things like that were confusing, and sci3 can’t do shared memory[20:03:22] <wjp> ok, so you can probably ignore a few of my pending comments then[20:04:08] <wjp> you know, this PR is pretty big :-)[20:04:16] * wjp is at 20% or so[20:04:18] <snover> yeah :|[20:07:36] <wjp> this findBlockSCI0 blockSize is confusing me[20:08:01] <wjp> every block type seems to get its size in a different way in Script::load[20:10:40] *** Strangerke_ <Strangerke_!~Strangerk@cable-85.28.84.13.coditel.net> has joined #scummvm[20:10:51] <snover> wjp: you mean the exportTable, synonymTable, localsTable stuff?[20:11:18] <wjp> yeah[20:12:37] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 240 seconds)[20:12:37] *** Strangerke_ is now known as Strangerke[20:12:45] <wjp> _numExports _seems_ to be read from the same place as where findBlockSCI0 is reading its blockSize[20:12:57] <wjp> but the former is in uint16's, and the latter in bytes?[20:13:31] <snover> yeah, i think there was a confusion originally since the exports block is right after the script header[20:15:43] <snover> though, actually, what i am thinking of applies to sci1.1+, not sci0[20:19:43] <snover> wjp: i had hoped the comment there would unconfuse things, but i seem to have trouble writing unconfused prose lately[20:20:04] <snover> the block header is { uint16 type, uint16 size }, and then the export block is { uint16 numExports, uint16 export, … }[20:20:59] <snover> and the value returned by findBlockSCI0 points to the start of the block, not the start of the block data[20:21:11] <wjp> yeah, the comment does explain it[20:21:48] <snover> so exportTable[0] is the block type, exportTable[1] the block size in bytes, exportTable[2] the number of exports. ok, good.[20:22:33] <snover> i don’t love that the exports table is so unique, but it was that way when i got here, i swear ;-)[20:22:51] *** Strangerke <Strangerke!~Strangerk@cable-85.28.84.13.coditel.net> has quit IRC (Ping timeout: 240 seconds)[20:23:12] <wjp> except it was apparently broken before?[20:25:18] <snover> i vaguely remember that now, yeah.[20:25:55] <snover> you’d never notice that the number of exports was accidentally too large so long as no script tried to call an out of bounds export[20:29:04] <snover> it’s worth rechecking that to make sure that *i* didn’t screw it up though[20:29:19] <snover> pretty sure it’s correct[20:29:48] <snover> yeah, it is correct now.[20:45:01] *** diehumblex <diehumblex!uid209517@gateway/web/irccloud.com/x-hjvdrumvfkpjhcqy> has joined #scummvm[20:45:31] *** D0SFreak <D0SFreak!~D0SFreak@172.56.5.239> has quit IRC (Ping timeout: 255 seconds)[20:47:11] <wjp> clazzzzz[20:47:37] <snover> heh heh.[20:50:21] <waltervn> I seem to have those first two words as 'unknown' in the scis SCI1.1 code (https://github.com/waltervn/scis/blob/master/sci11.c#L97). I'll have to look at that some time. Not that anyone is using scis anyway. :)[20:55:35] <wjp> (halfway!)[20:59:59] <snover> (phew!)[21:00:44] *** girafe <girafe!~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr> has joined #scummvm[21:10:26] *** TMM <TMM!~hp@fsf/member/pdpc.professional.tmm> has joined #scummvm[21:10:27] *** ChanServ sets mode: +o TMM[21:16:56] *** salty-horse <salty-horse!~salty-hor@unaffiliated/salty-horse> has joined #scummvm[21:16:56] *** ChanServ sets mode: +o salty-horse[21:17:28] *** GitHub189 <GitHub189!~GitHub189@192.30.252.42> has joined #scummvm[21:17:28] <GitHub189> [scummvm] waltervn pushed 1 new commit to master: https://git.io/vDQzZ[21:17:28] <GitHub189> scummvm/master d405e9e Walter van Niftrik: ADL: Implement hires6 action opcode 0x0b[21:17:28] *** GitHub189 <GitHub189!~GitHub189@192.30.252.42> has left #scummvm[21:21:31] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has quit IRC (Ping timeout: 255 seconds)[21:25:57] *** jamm <jamm!~jam@unaffiliated/jamm> has quit IRC (Ping timeout: 240 seconds)[21:26:18] *** GitHub86 <GitHub86!~GitHub86@192.30.252.45> has joined #scummvm[21:26:18] <GitHub86> [scummvm] waltervn pushed 1 new commit to master: https://git.io/vDQ2U[21:26:18] <GitHub86> scummvm/master fee0b81 Walter van Niftrik: ADL: Fix hires6 action opcode 0x0c[21:26:18] *** GitHub86 <GitHub86!~GitHub86@192.30.252.45> has left #scummvm[21:28:42] <wjp> ok, enough for now[21:31:36] <wjp> minor stuff only so far, and a couple of unrelated things which happened to show up in or near the diff[21:34:41] <wjp> I could probably be convinced to play through QfG4 this weekend[21:39:08] <snover> excellent. my evil plan is working.[21:39:15] <snover> :-)[21:56:02] <snover> clazzzzz.[22:00:09] *** lubomyr <lubomyr!~kvirc@93.178.246.84> has quit IRC (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/)[22:11:20] *** ajax16384 <ajax16384!~User@109.60.130.33> has quit IRC (Read error: Connection reset by peer)[22:11:39] <Lightkey> The Colonel's Bequest stream on twitch.tv/gogcom nao[22:12:33] *** D0SFreak <D0SFreak!~D0SFreak@172.98.67.126> has joined #scummvm[22:15:58] <Lightkey> using ScummVM even :-)[22:16:53] *** RLP__ <RLP__!~D0SFreak@c-73-7-33-53.hsd1.ga.comcast.net> has joined #scummvm[22:18:40] *** D0SFreak <D0SFreak!~D0SFreak@172.98.67.126> has quit IRC (Ping timeout: 255 seconds)[22:23:07] <Lightkey> "uh.. I seem to have broken the game"[22:23:54] <snover> RIP :|[22:26:03] <Lightkey> "Didn't Alfred teach you anything?!" :-D[22:35:35] *** dhewg <dhewg!~dhewg@adiza.nexticom.net> has quit IRC (Ping timeout: 240 seconds)[22:37:30] <snover> https://zetafleet.com/i/58a76e8d2417a.jpg[22:37:35] <snover> (not the demo!)[22:37:50] *** RLP__ <RLP__!~D0SFreak@c-73-7-33-53.hsd1.ga.comcast.net> has quit IRC (Read error: Connection reset by peer)[22:38:37] *** D0SFreak <D0SFreak!~D0SFreak@c-73-7-33-53.hsd1.ga.comcast.net> has joined #scummvm[22:42:20] *** delme_ <delme_!~delme@ip-129-15-64-254.wireless-pat.ou.edu> has joined #scummvm[22:43:10] *** delme_ <delme_!~delme@ip-129-15-64-254.wireless-pat.ou.edu> has quit IRC (Client Quit)[22:43:36] *** dhewg <dhewg!~dhewg@212.63.210.87> has joined #scummvm[22:43:36] *** ChanServ sets mode: +o dhewg[22:44:03] <snover> https://zetafleet.com/i/58a770176a5d9.jpg[22:44:06] <snover> 👍[22:44:45] <snover> did not expect this to come together nearly as easily as this[22:49:06] *** salty-horse <salty-horse!~salty-hor@unaffiliated/salty-horse> has quit IRC (Quit: Leaving)[22:54:42] <wjp> nice :-)[22:57:18] *** dhewg <dhewg!~dhewg@212.63.210.87> has quit IRC (Ping timeout: 260 seconds)[23:05:09] *** dhewg <dhewg!~dhewg@212.63.210.87> has joined #scummvm[23:05:09] *** ChanServ sets mode: +o dhewg[23:16:50] *** dhewg <dhewg!~dhewg@212.63.210.87> has quit IRC (Ping timeout: 240 seconds)[23:18:21] *** dhewg <dhewg!~dhewg@adiza.nexticom.net> has joined #scummvm[23:18:21] *** ChanServ sets mode: +o dhewg[23:33:51] *** Henke37 <Henke37!~Henrik@81-227-16-59-no133.bredband.skanova.com> has joined #scummvm[23:36:42] <rsn8887> I made a new PR to fix the remaining problems with analog joystick mouse control. Is there anything else I should do? Or should I just wait for any comments to appear on it?[23:36:53] <rsn8887> https://github.com/scummvm/scummvm/pull/906[23:44:16] <wjp> I think criezy mentioned he would have a look this weekend[23:46:00] *** omer_mor <omer_mor!~Omer@46-117-132-33.bb.netvision.net.il> has joined #scummvm[23:53:24] <Lightkey> fourth time he had to reload the game already[23:55:35] <_sev> rsn8887: qould it be possible to follow our code formatting conventions?[23:56:56] <rsn8887> _sev: But I only made changes to the existing code, do you want me to reformat the whole thing, or only my changes?[23:57:28] <_sev> rsn8887: 99% of our changes are not following it, while the rest of the current code does[23:58:07] <_sev> rsn8887: for instance: _km.x/_km.multiplier -> _km.x / _km.multiplier[23:58:31] <_sev> _km.y_vel+=_km.multiplier; -> _km.y_vel += _km.multiplier;[23:59:06] <_sev> float analogY=(float) (_km.y_vel * vel_to_axis); -> float analogY = (float)(_km.y_vel * vel_to_axis);[23:59:24] <_sev> if (magnitude >= deadZone)[23:59:25] <_sev> {[23:59:25] <rsn8887> _sev: Ah I see, let me fix that really quick.[23:59:31] <_sev> etc