April 22, 2014 
< | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | 29 | 30 | >
April 22, 2014 NOTICE: This channel is no longer actively logged.
[00:10:11] *** apetro___ has quit IRC[00:56:16] *** vertein has quit IRC[01:28:58] *** jwennmacher has quit IRC[01:43:16] *** jwennmacher has joined #jasig-uportal[01:46:06] <jwennmacher> @tlev. Thanks! I think UP_AGGR_PORTLET_MAPPING unique key is a combination of portlet_name and portlet_fname right now. Now sure why the error in the logs now.[01:54:56] *** colinclark has joined #jasig-uportal[01:59:04] *** drewwills has left #jasig-uportal[02:02:14] *** lfuller has quit IRC[02:43:48] *** jsittler has quit IRC[02:51:24] *** cbw has joined #jasig-uportal[02:51:46] *** cbw has left #jasig-uportal[03:32:54] *** colinclark has quit IRC[08:47:23] *** jgribonvald has joined #jasig-uportal[11:12:30] *** jgribonvald has quit IRC[13:22:32] *** apetro__ has joined #jasig-uportal[13:28:38] *** apetro__ has quit IRC[13:36:55] *** apetro__ has joined #jasig-uportal[14:46:29] *** vertein has joined #jasig-uportal[14:46:43] *** colinclark has joined #jasig-uportal[15:21:16] <apetro__> The Tips portlet/region/thing looks pretty silly when a portlet is in maximized mode. Is this a known issue? http://cl.ly/image/0y2o433Q291r[15:22:01] <apetro__> (Or, heaven forefend, a regression introduced by Favorites?)[16:29:54] <tlev> hmm, i don't think that would be something from introducing favorites, but that does look strange[16:30:08] <tlev> i wonder if we hard code the location of the top of the chrome in max mode[17:23:34] *** drewwills has joined #jasig-uportal[17:30:49] *** lfuller has joined #jasig-uportal[17:40:39] *** goldmantx has joined #jasig-uportal[17:52:33] *** colinclark has quit IRC[17:58:16] <jwennmacher> @apetro/@tlev. I think this is a side effect of customize region and pre-content being rendered when a portlet is in maximized mode. It seems to me that customize should not be (I think there is a Jira about that). Unsure about pre-content. That is less clear.[17:59:29] *** goldmantx1 has joined #jasig-uportal[18:01:16] *** goldmantx has quit IRC[18:01:46] *** drewwills1 has joined #jasig-uportal[18:03:53] *** drewwills has quit IRC[18:08:25] *** vcrowley has joined #jasig-uportal[18:08:28] *** vcrowley has left #jasig-uportal[18:15:30] *** drewwills1 has quit IRC[18:17:25] *** drewwills has joined #jasig-uportal[18:29:49] *** colinclark has joined #jasig-uportal[18:35:10] *** jsittler has joined #jasig-uportal[18:43:47] *** goldmantx1 has quit IRC[18:50:20] *** goldmantx has joined #jasig-uportal[19:56:07] <tlev> did a little research[19:56:20] <tlev> on the issue with the precontent region[19:56:23] <tlev> http://snag.gy/VzS5D.jpg[19:56:42] <tlev> there is also an issue with styling on a sidebar when you go to tablet[19:59:19] *** goldmantx1 has joined #jasig-uportal[20:00:37] <jwennmacher> Did you write up Jiras?[20:00:44] <tlev> not yet[20:00:51] <tlev> that was going to be my next step[20:01:58] *** goldmantx has quit IRC[20:04:11] <tlev> created https://issues.jasig.org/browse/UP-4069[20:16:49] *** goldmantx1 has quit IRC[20:20:07] <tlev> oh, i might have found out why. in regions.xsl we are using col-sm and in respondr.xsl we are using col-md. going to test that out[20:22:43] <drewwills> jwennmacher and tlev -- there is a pull request on customize in focused mode, and I think we reached a consensus on how to deal with it -- namely, remove customize... but also cull those portlets in the structure transform[20:23:01] <drewwills> i was hoping maybe to finalize that myself this week[20:23:19] <tlev> I think i'm talking about another issue[20:24:07] <drewwills> probably... i'm responding to something from about 145 minutes ago... just read it though[20:24:23] <tlev> yeah, the max mode with massive chrome window[20:25:08] <tlev> That actually is a sidebar region thing with the precontent region I believe, not customize. i'll have a PR soon. :)[20:25:26] <drewwills> cool[20:26:01] <drewwills> fwiw I weighed in on hrs-portlets pull #18: https://github.com/Jasig/hrs-portlets/pull/18[20:27:11] <drewwills> side-bar left (either sidebar) should not show up at all if there's nothing in it[20:34:41] <tlev> i agree[20:35:19] *** goldmantx has joined #jasig-uportal[20:36:46] <drewwills> that's one of the "rules for regions" -- if there's no content (portlets) in a region, the div that defines/wraps it isn't even present on the page[20:44:58] <tlev> Yes. Its just a problem with mixing in col-md and col-sm.[20:50:53] <tlev> PR: https://github.com/Jasig/uPortal/pull/304[20:51:19] <vertein> I like your janky scribbling on your pull request. :)[20:51:29] <tlev> i thought you might.[20:51:42] <vertein> I don't know which comment was more snarky[20:53:21] *** jsittler has quit IRC[20:54:06] <tlev> ps: those screen shots is me just putting favorites in the sidebar just to have something there.[20:54:48] *** jsittler has joined #jasig-uportal[20:56:30] *** goldmantx1 has joined #jasig-uportal[20:56:38] *** goldmantx has quit IRC[21:01:06] <tlev> found the issue with maximized as well. looks like we are not wrapping the single portlet in a div.row-fluid div.col-md-12, but tips are[21:01:53] *** jwennmacher1 has joined #jasig-uportal[21:05:23] *** jwennmacher has quit IRC[21:47:00] <tlev> PR for max window state w/ pre-content region: https://github.com/Jasig/uPortal/pull/306[22:02:02] *** goldmantx1 has quit IRC[22:02:02] *** jwennmacher1 has quit IRC[22:02:26] *** jsittler has quit IRC[22:07:41] *** jsittler has joined #jasig-uportal[22:07:41] *** goldmantx has joined #jasig-uportal[22:17:27] *** jwennmacher has joined #jasig-uportal[23:57:52] *** tlev has quit IRC