February 15, 2017 
< | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | >
February 15, 2017 [00:03:02] *** Camel <Camel!Camel@gateway/web/irccloud.com/x-oxprsfnuvtuwuiag> has joined #gerrit[00:04:21] *** zwliew <zwliew!zwliew@gateway/shell/panicbnc/x-ngzliqangtudxzee> has joined #gerrit[00:05:02] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 252 seconds)[00:05:25] *** pamaury <pamaury!~pamaury@rockbox/developer/pamaury> has joined #gerrit[00:06:49] *** Camel <Camel!Camel@gateway/web/irccloud.com/x-oxprsfnuvtuwuiag> has quit IRC (Client Quit)[00:11:57] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-bqzbfxkdgtqpucre> has joined #gerrit[00:25:05] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[00:38:53] *** dimtruck is now known as zz_dimtruck[00:39:38] *** zz_dimtruck is now known as dimtruck[00:43:48] *** pamaury <pamaury!~pamaury@rockbox/developer/pamaury> has quit IRC (Ping timeout: 240 seconds)[00:55:24] *** synx <synx!hornd@2600:3c00::f03c:91ff:fedf:3d6> has joined #gerrit[00:55:48] *** synx is now known as Guest9309[01:25:02] *** aqua^c <aqua^c!~aqua@114.111.60.64> has joined #gerrit[01:36:13] *** dimtruck is now known as zz_dimtruck[01:50:05] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 252 seconds)[01:55:02] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[02:18:24] *** zz_dimtruck is now known as dimtruck[02:18:53] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-bqzbfxkdgtqpucre> has quit IRC (Quit: Connection closed for inactivity)[03:01:10] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 268 seconds)[03:03:04] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[03:03:12] *** Guest9309 is now known as synx[03:03:16] *** synx <synx!hornd@2600:3c00::f03c:91ff:fedf:3d6> has quit IRC (Changing host)[03:03:16] *** synx <synx!hornd@unaffiliated/synx/x-4957395> has joined #gerrit[03:16:18] *** dimtruck is now known as zz_dimtruck[03:34:42] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #gerrit[03:34:58] *** zz_dimtruck is now known as dimtruck[03:37:28] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[04:04:33] *** pzd_ <pzd_!~pzd@2620:149:6:1435:5a9c:fcff:fe0e:9790> has joined #gerrit[04:05:28] *** kscd_ <kscd_!~quassel@login2.physik.fu-berlin.de> has joined #gerrit[04:06:19] *** Juri_Agarin <Juri_Agarin!~ajaalto@130.233.41.50> has joined #gerrit[04:06:55] *** jkt_ <jkt_!~jkt@kde/jkt> has joined #gerrit[04:06:55] *** cj__ <cj__!~cjac@moonunit.colliertech.org> has joined #gerrit[04:06:57] *** draynium_ <draynium_!U2FsdGVkX1@ma.sdf.org> has joined #gerrit[04:07:28] *** kscd <kscd!~quassel@login2.physik.fu-berlin.de> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** jkt <jkt!~jkt@kde/jkt> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** cj <cj!~cjac@moonunit.colliertech.org> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** pzd <pzd!~pzd@2620:149:6:1435:5a9c:fcff:fe0e:9790> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** Gaga <Gaga!~ajaalto@kekkonen.niksula.hut.fi> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** marlinc <marlinc!~marlinc@1.0.0.127.13.204.167.185.in-addr.arpa> has quit IRC (Ping timeout: 255 seconds)[04:07:28] *** draynium <draynium!U2FsdGVkX1@ma.sdf.org> has quit IRC (Ping timeout: 255 seconds)[04:11:58] *** marlinc <marlinc!~marlinc@1.0.0.127.13.204.167.185.in-addr.arpa> has joined #gerrit[04:35:13] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-exwlwkuncposxogs> has joined #gerrit[04:45:58] *** Pursuit <Pursuit!~Pursuit@cpe-23-240-99-179.socal.res.rr.com> has joined #gerrit[05:01:19] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[05:05:35] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)[05:32:30] *** dimtruck is now known as zz_dimtruck[06:12:22] *** Pursuit <Pursuit!~Pursuit@cpe-23-240-99-179.socal.res.rr.com> has quit IRC (Ping timeout: 264 seconds)[06:22:01] *** Pursuit <Pursuit!~Pursuit@cpe-23-240-99-179.socal.res.rr.com> has joined #gerrit[06:23:23] *** zz_dimtruck is now known as dimtruck[06:34:50] *** dimtruck is now known as zz_dimtruck[06:48:53] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-exwlwkuncposxogs> has quit IRC (Quit: Connection closed for inactivity)[07:01:44] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[07:06:36] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)[07:07:50] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 268 seconds)[07:08:36] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[07:32:47] *** lliigg <lliigg!~Linus@88.131.56.168> has left #gerrit ("Leaving")[07:43:39] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[07:44:41] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[08:17:57] *** zz_dimtruck is now known as dimtruck[08:19:05] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[08:27:53] *** dimtruck is now known as zz_dimtruck[08:38:12] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[08:38:21] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[08:39:00] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[08:41:20] *** aqua^c <aqua^c!~aqua@114.111.60.64> has quit IRC ()[08:45:15] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[09:02:14] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[09:07:08] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 258 seconds)[09:18:51] *** zz_dimtruck is now known as dimtruck[09:27:15] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[09:27:41] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 252 seconds)[09:28:25] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[09:28:36] *** dimtruck is now known as zz_dimtruck[09:30:25] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Read error: Connection reset by peer)[09:30:41] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[09:32:22] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[09:35:21] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)[09:36:13] *** lqi <lqi!~lqi@qt/lqi> has quit IRC ()[09:40:09] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[09:45:35] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)[09:50:24] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[09:50:34] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #gerrit[09:51:06] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)[10:19:30] *** zz_dimtruck is now known as dimtruck[10:25:34] *** askb <askb!~askb@60-240-105-249.static.tpgi.com.au> has quit IRC (Quit: Leaving)[10:29:25] *** dimtruck is now known as zz_dimtruck[10:33:51] *** ssbarnea <ssbarnea!~ssbarnea@88.97.26.43> has joined #gerrit[11:20:16] *** zz_dimtruck is now known as dimtruck[11:20:47] <electrofelix> zaro: using DEVELOPMENT_BECOME_ANY_ACCOUNT auth allows for an admin account with the password 'secret', I didn't think that existed when you wanted to use ldap for auth?[11:30:06] *** dimtruck is now known as zz_dimtruck[11:33:53] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #gerrit[11:35:17] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 252 seconds)[11:36:28] *** pamaury <pamaury!~pamaury@rockbox/developer/pamaury> has joined #gerrit[11:37:15] *** xmj <xmj!~xmj@freebsd/developer/xmj> has left #gerrit[11:41:45] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has joined #gerrit[11:52:10] *** ssbarnea <ssbarnea!~ssbarnea@88.97.26.43> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[11:56:19] *** ssbarnea <ssbarnea!~ssbarnea@88.97.26.43> has joined #gerrit[12:21:01] *** zz_dimtruck is now known as dimtruck[12:21:57] *** istarilucky <istarilucky!~rlucca@187.108.42.203> has joined #gerrit[12:30:55] *** dimtruck is now known as zz_dimtruck[12:32:08] *** jkt_ is now known as jkt[12:36:20] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has quit IRC (Read error: Connection reset by peer)[12:37:06] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has joined #gerrit[12:38:42] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-ebmvtmixncofuths> has joined #gerrit[12:58:52] *** istarilucky1 <istarilucky1!~rlucca@187.108.42.203> has joined #gerrit[13:00:05] *** istarilucky <istarilucky!~rlucca@187.108.42.203> has quit IRC (Ping timeout: 240 seconds)[13:07:44] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has quit IRC (Ping timeout: 256 seconds)[13:09:53] *** pamaury <pamaury!~pamaury@rockbox/developer/pamaury> has quit IRC (Ping timeout: 252 seconds)[13:13:31] *** pamaury <pamaury!~pamaury@rockbox/developer/pamaury> has joined #gerrit[13:21:25] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has joined #gerrit[13:21:49] *** zz_dimtruck is now known as dimtruck[13:31:41] *** dimtruck is now known as zz_dimtruck[13:34:36] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 240 seconds)[13:36:08] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[14:22:32] *** zz_dimtruck is now known as dimtruck[14:32:27] *** dimtruck is now known as zz_dimtruck[14:41:51] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[14:42:05] *** cj__ is now known as cj[14:46:08] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)[14:48:53] *** zwliew_ <zwliew_!uid161395@gateway/web/irccloud.com/x-ebmvtmixncofuths> has quit IRC (Quit: Connection closed for inactivity)[15:23:17] *** zz_dimtruck is now known as dimtruck[15:26:47] *** qchris_ <qchris_!~xanthalan@212-197-138-61.adsl.highway.telekom.at> has joined #gerrit[15:30:23] *** qchris__ <qchris__!~xanthalan@62-46-158-95.adsl.highway.telekom.at> has quit IRC (Ping timeout: 240 seconds)[15:33:12] *** dimtruck is now known as zz_dimtruck[15:33:51] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[15:36:35] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[15:41:11] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[16:03:12] *** zz_dimtruck is now known as dimtruck[16:03:18] *** istarilucky <istarilucky!~rlucca@189.112.127.230> has joined #gerrit[16:06:11] *** istarilucky1 <istarilucky1!~rlucca@187.108.42.203> has quit IRC (Ping timeout: 268 seconds)[16:31:10] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #gerrit[16:31:57] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 240 seconds)[16:42:17] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[16:43:27] *** stpierre <stpierre!~cstpierr@lopsa/member/stpierre> has joined #gerrit[16:46:36] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)[16:46:50] <stpierre> we have a custom label added to gerrit (2.13.5) that's not working quite as we expect: https://paste.fedoraproject.org/558961/17343814/[16:46:54] <stpierre> this is supposed to work as a final approval -- once all verification and code review is complete, this gives the submitter one last chance to approve it before zuul merges the change[16:46:57] <stpierre> and it *mostly* works like that[16:47:02] <stpierre> but if i manually flag someone for review, then suddenly gerrit decides that their Approval vote is *required*. it shows the review as "Blocked on Approved label," and in the list of reviews it looks like they've given it Approval -1 (which is of course impossible)[16:47:20] <stpierre> why is it behaving like this? and how do we get the behavior we want and expect (and had on Gerrit 2.9 until we upgraded)?[17:09:44] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has joined #gerrit[17:09:58] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 255 seconds)[17:16:12] *** Vampire0 <Vampire0!~Vampire@jEdit/Vampire> has joined #gerrit[17:17:16] *** Vampire0_ <Vampire0_!~Vampire@jEdit/Vampire> has quit IRC (Ping timeout: 260 seconds)[17:54:25] *** Siamaster <Siamaster!~Siamaster@85.235.16.11> has joined #gerrit[17:58:28] *** Siamaster <Siamaster!~Siamaster@85.235.16.11> has quit IRC (Ping timeout: 240 seconds)[18:03:22] <stpierre> anyone have any ideas? ^[18:05:19] <electrofelix> stpierre: it's possible there is a bug added into the UI javascript at some point - I recall submitting a patch to fix a similar issue back in 2012[18:08:14] <electrofelix> stpierre: the fix is present in the history but it looks like that area of the code was overhauled so entirely possible it's been reintroduced[18:10:36] <electrofelix> stpierre: or now need a different function[18:15:08] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 260 seconds)[18:16:06] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit[18:22:34] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[18:26:20] <electrofelix> stpierre: I suspect that the bug was re-introduced somewhere in https://gerrit.googlesource.com/gerrit/+/beb0b84af8881d57296abb038f26779a2dbc7d2c/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java#152[18:27:02] <stpierre> exciting[18:27:31] * stpierre has no familiarity with the Gerrit codebase, and i took that one Java class 17 years ago, so this should be fun.... :)[18:28:27] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[18:29:07] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[18:30:30] <electrofelix> my bet is that setting the 'approved' and 'rejected' variables to 0 and then changing that to the the correct values if the current label score is not '0' `if (ai.value() != 0) {` followed by comparing subsequently scores means that if 0 is the minimum value of a label it is the returned by the call 'v.intValue()' and the rejected variable is still 0 at that point, so it looks like the change has been rejected in the UI[18:31:28] <stpierre> ah[18:32:54] <electrofelix> I wonder if the two initial values could be set to null (my java is rusty too), or the block that does `if (v.intValue() == approved) { ... } else if (v.intValue() == rejected) { ..}` just also needs to be surrounded with a `if (ai.value() != 0) { ... }` check to skip checking approvals if the score given is currently 0.[18:33:45] <electrofelix> presumably the latter would be acceptable, but I'd have to do some testing locally to reproduce and then compare behaviour and I haven't built Gerrit since circa 2012 ;-)[18:34:13] <stpierre> that gives me a lot to start on -- thanks[18:34:34] <stpierre> i'll have to see if i can find 10 spare minutes this afternoon and try those approaches out[18:35:43] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[18:40:31] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[18:42:49] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[18:44:56] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[18:47:45] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 268 seconds)[19:59:01] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[20:00:01] *** jdahlin <jdahlin!uid736@gateway/web/irccloud.com/x-gzjgfklpgnsdoyfr> has joined #gerrit[20:02:20] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[20:02:56] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[20:10:48] <electrofelix> zaro: regarding your response yesterday, am I missing something about enabling a dev option? I thought 'admin' only existed for DEVELOPMENT_BECOME_ANY_ACCOUNT?[20:12:28] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[20:14:28] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[20:35:39] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Remote host closed the connection)[20:43:13] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[20:44:43] *** hashar <hashar!~sempitern@mediawiki/hashar> has joined #gerrit[20:48:12] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)[20:52:42] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[20:57:01] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[21:17:05] *** ldnunes <ldnunes!~ldnunes_@189.114.111.135> has quit IRC (Quit: Leaving)[21:42:23] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has joined #gerrit[21:47:49] *** venmx <venmx!~pactadmin@cpc8-camd15-2-0-cust699.20-2.cable.virginm.net> has quit IRC (Ping timeout: 268 seconds)[21:49:43] *** ssbarnea <ssbarnea!~ssbarnea@88.97.26.43> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[22:24:24] *** istarilucky <istarilucky!~rlucca@189.112.127.230> has quit IRC (Remote host closed the connection)[22:27:02] *** askb <askb!~askb@60-240-105-249.static.tpgi.com.au> has joined #gerrit[22:42:39] *** dimtruck is now known as zz_dimtruck[22:47:50] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[22:52:01] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[22:56:34] *** zz_dimtruck is now known as dimtruck[23:32:00] *** hashar <hashar!~sempitern@mediawiki/hashar> has quit IRC (Read error: Connection reset by peer)[23:34:16] *** lqi <lqi!~lqi@qt/lqi> has joined #gerrit[23:38:16] *** lqi <lqi!~lqi@qt/lqi> has quit IRC (Ping timeout: 245 seconds)[23:41:36] *** stpierre <stpierre!~cstpierr@lopsa/member/stpierre> has quit IRC (Quit: Konversation terminated!)[23:55:19] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has quit IRC (Ping timeout: 258 seconds)[23:56:15] *** stryx` <stryx`!~stryx@unaffiliated/stryx/x-3871776> has joined #gerrit