February 21, 2018 
< | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | >
February 21, 2018 [00:01:24] *** in3o_ <in3o_!~in3o@163.53.214.110> has joined #chromium[00:01:31] *** in3o <in3o!~in3o@163.53.214.110> has quit IRC (Read error: Connection reset by peer)[00:03:21] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has quit IRC (Quit: fredw)[00:08:06] *** suhdood <suhdood!~Thaelim@2600:380:551d:73e4:38d4:d43c:dc98:cca2> has quit IRC (Remote host closed the connection)[00:14:58] *** jrmuizel <jrmuizel!~jrmuizel@corp-nat.fw1.untrust.tor1.mozilla.com> has quit IRC (Remote host closed the connection)[00:19:48] *** dgrogan <dgrogan!dgrogan@nat/google/x-vrlkvhgzafbdcinh> has quit IRC (Ping timeout: 240 seconds)[00:23:13] *** Pinkamena_D <Pinkamena_D!~Pinkamena@pool-71-187-3-123.nwrknj.fios.verizon.net> has quit IRC (Ping timeout: 248 seconds)[00:27:45] *** mizu_no__ <mizu_no__!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has joined #chromium[00:28:24] *** ellyjones <ellyjones!~unpriv-fr@104.132.34.80> has quit IRC (Ping timeout: 260 seconds)[00:29:58] *** ellyjones <ellyjones!unpriv-fre@nat/google/x-tsgsaghmyvaqzldq> has joined #chromium[00:29:58] *** ChanServ sets mode: +v ellyjones[00:30:58] *** orbyt_ <orbyt_!~orbyt@204.14.152.19> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[00:31:12] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 260 seconds)[00:31:47] *** dgrogan <dgrogan!dgrogan@nat/google/x-uauvgvcjussimcma> has joined #chromium[00:31:47] *** ChanServ sets mode: +v dgrogan[00:32:38] *** orbyt_ <orbyt_!~orbyt@204.14.152.19> has joined #chromium[00:32:41] *** orbyt_ <orbyt_!~orbyt@204.14.152.19> has quit IRC (Client Quit)[00:48:49] *** gvso <gvso!~gvso@130.58.167.39> has joined #chromium[00:58:57] *** gyuyoung <gyuyoung!~gyuyoung@114.206.230.69> has quit IRC (Ping timeout: 248 seconds)[01:00:02] *** weez17 <weez17!~isaac@unaffiliated/weez17> has quit IRC (Remote host closed the connection)[01:00:45] *** weez17 <weez17!~isaac@unaffiliated/weez17> has joined #chromium[01:04:45] *** mizu_no__ <mizu_no__!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[01:05:45] *** AaronMT <AaronMT!~textual@2607:fea8:3de0:cb7:b42a:6cee:af54:1f11> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[01:06:43] *** leiz <leiz!~leiz@104.132.53.78> has joined #chromium[01:27:00] *** dominickn <dominickn!~dominickn@104.132.133.92> has joined #chromium[01:31:46] *** al-damiri <al-damiri!uid142631@gateway/web/irccloud.com/x-zeanebmdzbmgzmob> has quit IRC (Quit: Connection closed for inactivity)[01:43:24] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on https://build.chromium.org/p/chromium/builders/Android/builds/81932 "Android" from 5e8e47a25833e640f088923a0df80e30551acf53: agl at chromium dot org,baileyberro@chromium.org,govind@chromium.org,machenbach@chromium.org,nharper@chromium.org,pbos@chromium.org,pwnall@chromium.org,rch@chromium.org (:RyanHamilton),takumif at chromium dot org,tommycli@chromium.org)[01:50:27] <trungl-bot> Tree closed by chongz at chromium dot org: Tree is closed (Android "compile" exception)[01:51:14] *** OnkelTem <OnkelTem!~onkeltem@unaffiliated/fantomas> has quit IRC (Ping timeout: 260 seconds)[01:52:17] *** llorephie <llorephie!~llorephie@2001:470:5a32::9ea> has joined #chromium[01:56:38] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[01:59:31] <trungl-bot> Tree opened by tommycli at google dot com: Tree is open (Android "compile" exception looks like it's just a hung bot)[02:00:36] *** OnkelTem <OnkelTem!~onkeltem@unaffiliated/fantomas> has joined #chromium[02:01:32] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has joined #chromium[02:03:46] *** llorephie <llorephie!~llorephie@2001:470:5a32::9ea> has quit IRC (Remote host closed the connection)[02:15:42] *** lnostdal <lnostdal!~lnostdal@gateway/tor-sasl/lnostdal> has quit IRC (Ping timeout: 255 seconds)[02:28:42] *** lnostdal <lnostdal!~lnostdal@gateway/tor-sasl/lnostdal> has joined #chromium[02:29:19] *** chongz <chongz!6884014c@gateway/web/freenode/ip.104.132.1.76> has quit IRC (Quit: Page closed)[02:40:52] *** gyuyoung <gyuyoung!~gyuyoung@218.155.144.178> has joined #chromium[02:40:58] *** AtumT <AtumT!~IRC@177.157.108.62.dynamic.adsl.gvt.net.br> has quit IRC (Remote host closed the connection)[02:52:45] *** llorephie <llorephie!~llorephie@2001:470:5a32::9ea> has joined #chromium[02:57:26] *** jsbell <jsbell!jsbell@nat/google/x-azzikvaedlpnbagw> has quit IRC (Quit: There's no place like home...)[03:05:05] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[03:10:22] *** llorephie <llorephie!~llorephie@2001:470:5a32::9ea> has quit IRC (Remote host closed the connection)[03:13:23] *** zng <zng!~zng@ool-18ba49be.dyn.optonline.net> has quit IRC (Ping timeout: 256 seconds)[03:16:45] *** orbyt_ <orbyt_!~orbyt@172.92.5.20> has joined #chromium[03:17:07] *** zng <zng!~zng@ool-18ba49be.dyn.optonline.net> has joined #chromium[03:31:10] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has joined #chromium[03:31:38] *** zergut <zergut!uid221522@taskhive/translator/zergut> has joined #chromium[03:33:47] *** Pinkamena_D <Pinkamena_D!~Pinkamena@69.136.102.83> has joined #chromium[03:35:41] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[03:40:46] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has joined #chromium[03:44:21] *** lnostdal <lnostdal!~lnostdal@gateway/tor-sasl/lnostdal> has quit IRC (Ping timeout: 255 seconds)[03:59:12] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has quit IRC (Ping timeout: 255 seconds)[04:00:59] *** unixpickle <unixpickle!~alex@c-24-5-87-159.hsd1.ca.comcast.net> has joined #chromium[04:05:10] *** pspace <pspace!~bountyx@76-14-117-81.rk.wavecable.com> has joined #chromium[04:07:48] *** tkent <tkent!~Adium@2401:fa00:4:1002:cd93:72ca:a5c5:d615> has quit IRC (Ping timeout: 240 seconds)[04:13:25] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has joined #chromium[04:18:08] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[04:19:07] *** multi_io_ <multi_io_!~olaf@x55b67150.dyn.telefonica.de> has quit IRC (Ping timeout: 256 seconds)[04:21:05] *** multi_io <multi_io!~olaf@x5ce35ba8.dyn.telefonica.de> has joined #chromium[04:28:54] *** him-cesjf <him-cesjf!~himcesjf@unaffiliated/himcesjf> has joined #chromium[04:34:59] *** tonikitoo <tonikitoo!uid37558@gateway/web/irccloud.com/x-yasoocqxqzclqdmy> has quit IRC (Quit: Connection closed for inactivity)[04:38:00] *** pspace <pspace!~bountyx@76-14-117-81.rk.wavecable.com> has quit IRC (Quit: Peace and love.)[04:47:12] *** saint_dogbert <saint_dogbert!~Ident@unaffiliated/phobos-anomaly/x-6744724> has joined #chromium[04:49:18] *** litherum <litherum!~litherum@17.202.139.214> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[04:51:44] *** raynold <raynold!uid201163@gateway/web/irccloud.com/x-nivpxhwpspmpvkws> has joined #chromium[05:10:16] *** mel00010 <mel00010!~mel00010@128-223-223-3-wireless.uoregon.edu> has joined #chromium[05:30:40] *** tkent <tkent!~Adium@2401:fa00:4:1002:2848:f75f:e604:a8e1> has joined #chromium[05:52:33] *** floown <floown!~quassel@151.177.73.86.rev.sfr.net> has joined #chromium[05:52:33] *** floown <floown!~quassel@151.177.73.86.rev.sfr.net> has quit IRC (Changing host)[05:52:33] *** floown <floown!~quassel@unaffiliated/fanchon> has joined #chromium[06:20:44] *** jzeus <jzeus!~jzeus@68.21.148.158> has quit IRC (Ping timeout: 260 seconds)[06:25:39] *** gyuyoung <gyuyoung!~gyuyoung@218.155.144.178> has quit IRC (Remote host closed the connection)[06:33:21] *** mel00010 <mel00010!~mel00010@128-223-223-3-wireless.uoregon.edu> has quit IRC (Ping timeout: 248 seconds)[06:36:33] *** gyuyoung <gyuyoung!~gyuyoung@218.155.144.178> has joined #chromium[06:43:14] *** fordfrog <fordfrog!~fordfrog@gentoo/developer/fordfrog> has joined #chromium[06:53:24] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has joined #chromium[06:57:44] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has quit IRC (Client Quit)[06:59:48] *** saint_dogbert <saint_dogbert!~Ident@unaffiliated/phobos-anomaly/x-6744724> has quit IRC (Ping timeout: 265 seconds)[07:00:20] *** ajax16384 <ajax16384!~User@109.60.138.138> has joined #chromium[07:06:13] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has quit IRC (Ping timeout: 268 seconds)[07:09:09] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has joined #chromium[07:18:43] *** unixpickle <unixpickle!~alex@c-24-5-87-159.hsd1.ca.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[07:19:46] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has joined #chromium[07:26:41] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has quit IRC (Ping timeout: 256 seconds)[07:28:54] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has joined #chromium[07:38:39] *** himcesjf_ <himcesjf_!~himcesjf@unaffiliated/himcesjf> has joined #chromium[07:39:05] *** him-cesjf <him-cesjf!~himcesjf@unaffiliated/himcesjf> has quit IRC (Disconnected by services)[07:39:10] *** himcesjf_ is now known as him-cesjf[07:39:11] *** armax00 <armax00!~armax00@pdpc/supporter/student/armax00> has joined #chromium[07:45:15] *** Gurkenglas <Gurkenglas!~Gurkengla@dslb-094-223-133-187.094.223.pools.vodafone-ip.de> has joined #chromium[07:47:28] *** ome <ome!uid36537@gateway/web/irccloud.com/x-xljinafogzrauikt> has joined #chromium[07:52:00] *** LocaMocha <LocaMocha!bocaneri@about/linux/staff/sauvin> has joined #chromium[07:58:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "gclient runhooks" on https://build.chromium.org/p/chromium.chromiumos/builders/chromeos-amd64-generic-rel/builds/6967 "chromeos-amd64-generic-rel" from c73131b27ee62fb6c669349b18c9b609fc16af4a: chromeos-commit-bot at chromium dot org)[08:00:58] *** zergut <zergut!uid221522@taskhive/translator/zergut> has quit IRC (Quit: Connection closed for inactivity)[08:02:37] *** orbyt_ <orbyt_!~orbyt@172.92.5.20> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[08:04:04] *** dominickn <dominickn!~dominickn@104.132.133.92> has quit IRC (Quit: dominickn)[08:05:57] *** Pinkamena_D <Pinkamena_D!~Pinkamena@69.136.102.83> has quit IRC (Ping timeout: 240 seconds)[08:08:27] *** msisov <msisov!~msisov@82-181-140-110.bb.dnainternet.fi> has joined #chromium[08:11:38] *** alexg__ <alexg__!~alex@47.63.48.248> has joined #chromium[08:26:05] *** HerbY_NL2 <HerbY_NL2!~HerbY_NL2@utwks61469.ewi.utwente.nl> has joined #chromium[08:48:26] *** alexg__ <alexg__!~alex@47.63.48.248> has quit IRC (Ping timeout: 252 seconds)[08:57:01] *** yn_ <yn_!~yano@freenode/staff-emeritus/yano> has joined #chromium[08:57:39] *** poutine <poutine!~poutine@dont.leave.your.anus.exposed> has quit IRC (Excess Flood)[08:57:39] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-jeihlsaeuerpthxm> has quit IRC (Quit: Connection closed for inactivity)[08:57:40] *** nyquist <nyquist!sid12461@gateway/web/irccloud.com/x-ahxspuuqzauhsvxj> has quit IRC (Ping timeout: 374 seconds)[08:57:40] *** kereliuk_ <kereliuk_!sid238052@gateway/web/irccloud.com/x-dlqentecksszetnm> has quit IRC (Ping timeout: 374 seconds)[08:57:40] *** Brisk-Branded <Brisk-Branded!~Andrew@165.227.217.42> has quit IRC (Quit: ZNC 1.7.x-git-876-42939c9 - https://znc.in)[08:57:40] *** yn <yn!~yano@freenode/staff-emeritus/yano> has quit IRC (Remote host closed the connection)[08:57:40] *** miklcct <miklcct!quasselcor@vps.miklcct.com> has quit IRC (Remote host closed the connection)[08:57:48] *** poutine <poutine!~poutine@dont.leave.your.anus.exposed> has joined #chromium[08:57:52] *** Brisk-Branded <Brisk-Branded!~Andrew@165.227.217.42> has joined #chromium[08:57:53] *** kereliuk_ <kereliuk_!sid238052@gateway/web/irccloud.com/x-vhtgpiehlhrkfdxf> has joined #chromium[08:57:54] *** nyquist <nyquist!sid12461@gateway/web/irccloud.com/x-bsyzlybyenwswccb> has joined #chromium[08:57:59] *** miklcct <miklcct!quasselcor@vps.miklcct.com> has joined #chromium[08:59:10] *** orbyt_ <orbyt_!~orbyt@172.92.5.20> has joined #chromium[08:59:15] *** orbyt_ <orbyt_!~orbyt@172.92.5.20> has quit IRC (Client Quit)[09:06:00] *** h3artbl33d <h3artbl33d!~h3artbl33@89.163.146.73> has joined #chromium[09:11:04] *** h3artbl33d <h3artbl33d!~h3artbl33@89.163.146.73> has quit IRC (Ping timeout: 260 seconds)[09:20:45] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has quit IRC (Ping timeout: 264 seconds)[09:27:23] *** alexg__ <alexg__!~alex@57.red-83-32-130.dynamicip.rima-tde.net> has joined #chromium[09:43:56] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has joined #chromium[09:49:47] *** ome <ome!uid36537@gateway/web/irccloud.com/x-xljinafogzrauikt> has quit IRC (Quit: Connection closed for inactivity)[09:54:21] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has quit IRC (Ping timeout: 264 seconds)[09:54:40] *** hajimehoshi <hajimehoshi!~hajimehos@2401:fa00:4:1002:910d:62c4:d3e0:f3f2> has quit IRC (Remote host closed the connection)[09:55:39] *** Haxxa <Haxxa!~Harrison@180-150-30-18.NBN.mel.aussiebb.net> has joined #chromium[09:58:10] *** kus <kus!~kus@pool-96-234-34-194.nwrknj.fios.verizon.net> has joined #chromium[10:01:31] *** claudiodesouza <claudiodesouza!~claudiode@194.73.46.50> has joined #chromium[10:03:36] *** sdefresne <sdefresne!sdefresne@nat/google/x-suqsscfzwttssmjo> has quit IRC (Ping timeout: 252 seconds)[10:10:56] *** msisov <msisov!~msisov@82-181-140-110.bb.dnainternet.fi> has quit IRC (Ping timeout: 252 seconds)[10:10:57] *** ome <ome!uid36537@gateway/web/irccloud.com/x-fjzuqhjpysxduvpf> has joined #chromium[10:11:50] *** dominickn <dominickn!~dominickn@59.167.234.214> has joined #chromium[10:12:05] *** gyuyoung <gyuyoung!~gyuyoung@218.155.144.178> has quit IRC (Ping timeout: 276 seconds)[10:14:02] <trungl-bot> Tree opened by kolos at google dot com: Tree is open (infra flakiness?)[10:28:33] *** dominickn <dominickn!~dominickn@59.167.234.214> has quit IRC (Quit: dominickn)[10:31:58] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[10:32:46] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has joined #chromium[10:32:57] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has quit IRC (Client Quit)[10:37:35] *** SerialSmile <SerialSmile!~SerialSmi@83.102.198.25> has joined #chromium[10:44:25] *** gotadachi <gotadachi!~gotadachi@124x34x155x150.ap124.ftth.ucom.ne.jp> has quit IRC (Read error: Connection reset by peer)[10:44:51] *** gotadachi <gotadachi!~gotadachi@124x34x155x150.ap124.ftth.ucom.ne.jp> has joined #chromium[10:53:58] *** zergut <zergut!uid221522@taskhive/translator/zergut> has joined #chromium[11:05:20] *** daynaskully <daynaskully!~dskull@unaffiliated/daynaskully> has quit IRC (Ping timeout: 265 seconds)[11:08:34] *** carewolf <carewolf!carewolf@nat/digia/x-iqrnuxyfmyuuxcqq> has joined #chromium[11:09:28] *** daynaskully <daynaskully!~dskull@unaffiliated/daynaskully> has joined #chromium[11:11:26] *** tunekey <tunekey!~tunekey@unaffiliated/tunekey> has quit IRC (Ping timeout: 252 seconds)[11:21:01] <lizeb> Seems that the cros bot is generally unhappy[11:21:08] <lizeb> See https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/chromeos-amd64-generic-rel/[11:22:30] *** neozaru <neozaru!~neozaru@176-152-123-98.abo.bbox.fr> has joined #chromium[11:25:10] *** neozaru <neozaru!~neozaru@176-152-123-98.abo.bbox.fr> has quit IRC (Max SendQ exceeded)[11:26:27] *** neozaru <neozaru!~neozaru@176-152-123-98.abo.bbox.fr> has joined #chromium[11:39:30] <claudiodesouza> Hi[11:39:38] <claudiodesouza> good morning[11:42:24] <claudiodesouza> I'm working in this code, that basically involves some IO operations (e.g. UpdateCredential, GetLoginDetails), and I would like to be able to test the code, without actually carrying out the operations... just to see if the general flow is correct[11:44:08] <claudiodesouza> what is the advised the way to go about this situations, without injecting some ugly handler, that is only there for testing purposes?[11:55:18] <lizeb> Hi, I don't know which part of the code you're referring to specifically, but the general pattern is actually to inject custom handlers for testing[11:55:39] <lizeb> There are quite a bit of examples like that in the code, which part are you looking at?[12:01:57] *** msisov <msisov!~msisov@82-181-140-110.bb.dnainternet.fi> has joined #chromium[12:03:16] <claudiodesouza> I was looking into usb_device.h but I'm not sure if I'm going to go ahead with this CL[12:03:21] <claudiodesouza> thanks anyway[12:04:05] *** aris <aris!~Mutter@220-244-240-131.static.tpgi.com.au> has joined #chromium[12:04:48] *** aris <aris!~Mutter@220-244-240-131.static.tpgi.com.au> has quit IRC (Client Quit)[12:14:53] <trungl-bot> Tree opened by kolos at google dot com: Tree is open (tried to fix chromeos-amd64-generic-rel, https://chromium-review.googlesource.com/c/chromium/src/+/928342)[12:17:00] *** AtumT <AtumT!~IRC@177.157.108.62.dynamic.adsl.gvt.net.br> has joined #chromium[12:44:09] *** AfroThundr <AfroThundr!~AfroThund@h122.170.135.40.static.ip.windstream.net> has quit IRC (Ping timeout: 268 seconds)[12:49:46] *** ome <ome!uid36537@gateway/web/irccloud.com/x-fjzuqhjpysxduvpf> has quit IRC (Quit: Connection closed for inactivity)[12:51:34] *** raynold <raynold!uid201163@gateway/web/irccloud.com/x-nivpxhwpspmpvkws> has quit IRC (Quit: Connection closed for inactivity)[12:58:23] *** tonikitoo <tonikitoo!uid37558@gateway/web/irccloud.com/x-rfqqmseandeaehal> has joined #chromium[13:03:08] *** fsod <fsod!~fs@2a00:801:e0:30:2d49:ce4e:8cc3:ae47> has quit IRC (Ping timeout: 276 seconds)[13:14:52] *** fsod <fsod!~fs@2a00:801:e0:30:b94e:993d:44e1:12c5> has joined #chromium[13:19:13] *** kus <kus!~kus@pool-96-234-34-194.nwrknj.fios.verizon.net> has quit IRC (Remote host closed the connection)[13:20:25] *** rcombs <rcombs!rcombs@irc.rcombs.me> has quit IRC (Quit: ZNC - http://znc.in/ZNC)[13:20:41] *** SirCmpwn <SirCmpwn!znc@irc.sircmpwn.com> has quit IRC (Ping timeout: 255 seconds)[13:21:02] *** Ex6TenZ <Ex6TenZ!~Ex6TenZ@193.180.164.58> has joined #chromium[13:22:10] *** rcombs <rcombs!rcombs@irc.rcombs.me> has joined #chromium[13:23:19] *** zergut <zergut!uid221522@taskhive/translator/zergut> has quit IRC (Quit: Connection closed for inactivity)[13:27:35] *** yn_ is now known as yn[13:29:21] *** Gurkenglas <Gurkenglas!~Gurkengla@dslb-094-223-133-187.094.223.pools.vodafone-ip.de> has quit IRC (Ping timeout: 256 seconds)[13:35:46] *** SirCmpwn <SirCmpwn!znc@irc.sircmpwn.com> has joined #chromium[13:50:45] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[13:50:52] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[13:51:26] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[13:52:53] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has joined #chromium[13:55:48] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Ping timeout: 240 seconds)[13:56:09] *** zergut <zergut!uid221522@taskhive/translator/zergut> has joined #chromium[14:00:59] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has quit IRC (Quit: fredw)[14:20:55] *** SerialSmile <SerialSmile!~SerialSmi@83.102.198.25> has quit IRC (Quit: Leaving)[14:24:39] *** HerbY_NL2 <HerbY_NL2!~HerbY_NL2@utwks61469.ewi.utwente.nl> has quit IRC (Quit: Leaving)[14:37:38] *** gvso <gvso!~gvso@130.58.167.39> has quit IRC (Quit: Leaving)[14:51:27] *** babu <babu!~Sudarsana@134.191.232.70> has quit IRC (Ping timeout: 248 seconds)[14:54:15] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has joined #chromium[14:58:02] *** in3o_ is now known as in3o[15:02:39] *** gyuyoung <gyuyoung!~gyuyoung@114.206.230.69> has joined #chromium[15:06:30] *** donofrio <donofrio!~donofrio@host-232.subnet-17.med.umich.edu> has quit IRC (Remote host closed the connection)[15:07:22] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has quit IRC (Ping timeout: 260 seconds)[15:15:02] *** claudiodesouza <claudiodesouza!~claudiode@194.73.46.50> has quit IRC (Quit: Lost terminal)[15:18:49] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has joined #chromium[15:21:20] *** msisov <msisov!~msisov@82-181-140-110.bb.dnainternet.fi> has quit IRC (Remote host closed the connection)[15:26:02] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has quit IRC (Ping timeout: 276 seconds)[15:27:10] *** felda <felda!~felda@donger/pfsense> has joined #chromium[15:29:36] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has joined #chromium[15:30:59] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has quit IRC (Quit: YuGiOhJCJ)[15:33:49] *** AfroThundr <AfroThundr!~AfroThund@h122.170.135.40.static.ip.windstream.net> has joined #chromium[15:36:15] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has quit IRC (Remote host closed the connection)[15:36:17] *** alexg__ <alexg__!~alex@57.red-83-32-130.dynamicip.rima-tde.net> has quit IRC (Ping timeout: 256 seconds)[15:36:46] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has joined #chromium[15:37:57] *** claudiodesouza <claudiodesouza!~claudiode@194.73.46.50> has joined #chromium[15:44:58] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has joined #chromium[15:46:54] *** babu <babu!Sudarsana@nat/intel/x-yywlbooujrxdmsgx> has joined #chromium[15:47:07] *** gvso <gvso!~gvso@130.58.167.39> has joined #chromium[15:47:21] *** dtatulea <dtatulea!~dtatulea@192.31.14.13> has quit IRC (Read error: Connection reset by peer)[15:58:58] *** gvso <gvso!~gvso@130.58.167.39> has quit IRC (Remote host closed the connection)[16:06:23] *** jrmuizel <jrmuizel!~jrmuizel@corp-nat.fw1.untrust.tor1.mozilla.com> has joined #chromium[16:06:27] *** litherum <litherum!~litherum@c-98-248-209-113.hsd1.ca.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[16:13:18] *** vitallium <vitallium!~vitallium@ip-86-110-182-234.spark-rostov.ru> has joined #chromium[16:15:43] *** saint_dogbert <saint_dogbert!~Ident@unaffiliated/phobos-anomaly/x-6744724> has joined #chromium[16:28:02] *** rohan <rohan!Elite18302@facebook/platform/rohan> has quit IRC (Remote host closed the connection)[16:29:36] *** categat <categat!~categat@212.83.150.224> has joined #chromium[16:35:48] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has joined #chromium[16:38:08] *** rhns <rhns!~rhns@modemcable186.64-37-24.static.videotron.ca> has joined #chromium[16:39:54] *** him-cesjf <him-cesjf!~himcesjf@unaffiliated/himcesjf> has quit IRC (Quit: Quit)[16:43:52] <claudiodesouza> what does it mean when you have a CL and its reviewer puts a comment saying stampety-stamp[16:44:09] <ellyjones> it means they approve[16:44:17] <ellyjones> they are "stamping" your CL with their approval[16:44:23] <ellyjones> (but haven't reviewed it in detail)[16:44:59] <Torne> when you do enough code reviews you get whimsical[16:45:04] <claudiodesouza> All reviewers have approved my CL, but I don't think they realise I do not have user right to submit it to the commit queue[16:45:09] <ellyjones> indeed[16:45:15] <ellyjones> claudiodesouza: well, ask someone nicely to submit it :)[16:45:24] <Torne> If it's been reviewed by appropriate people you *should* actually have that power[16:45:26] <maxmorin> I'll CQ+2 it[16:45:34] <Torne> unless that changed in gerrit?[16:45:36] <maxmorin> or you can try if it works first I guess[16:45:37] <Torne> it used to work[16:45:37] <claudiodesouza> maxmorin: cheers mate[16:45:39] <ellyjones> Torne: non-committers can't +2 even with all the approvals, I think[16:45:43] <Torne> huh.[16:45:45] <maxmorin> hmm, where did my + go?[16:45:54] <ellyjones> [x-files music plays][16:46:07] *** rohan <rohan!Elite18302@gateway/shell/elitebnc/x-gwpqqprhhmhvstho> has joined #chromium[16:46:07] *** rohan <rohan!Elite18302@gateway/shell/elitebnc/x-gwpqqprhhmhvstho> has quit IRC (Changing host)[16:46:07] *** rohan <rohan!Elite18302@facebook/platform/rohan> has joined #chromium[16:46:09] <claudiodesouza> I'm trying myself, but I'm almost sure it won't work[16:46:27] <Torne> maxmorin: you aren't on google nat and you aren't identified to a nick by the look of it, so it doesn't believe you[16:46:34] <claudiodesouza> only full committers[16:46:39] <claudiodesouza> there you go[16:47:00] <Torne> huh. that seems unfortunate[16:47:01] <claudiodesouza> maxmorin: may I please have your help on this[16:47:05] <maxmorin> yep[16:47:14] <Torne> that worked in rietveld :/[16:48:24] <claudiodesouza> maxmorin: cheers mate... this CL is finally (hopefully) done[16:50:51] *** NightMonkey <NightMonkey!~NightMonk@pdpc/supporter/professional/nightmonkey> has joined #chromium[16:52:49] *** ajax16384 <ajax16384!~User@109.60.138.138> has quit IRC (Read error: Connection reset by peer)[16:54:57] *** daynaskully is now known as dskull[16:57:53] *** hta <hta!~hta@188.113.88.47> has joined #chromium[17:04:44] *** Croepha <Croepha!~Croepha@45.55.252.156> has quit IRC (Quit: So long, and thanks for all the fish...)[17:07:46] *** AaronMT <AaronMT!~textual@2607:fea8:3de0:cb7:51e1:87a:7b6f:3a54> has joined #chromium[17:07:50] *** n35xdxb0 <n35xdxb0!~n35xdxb0@cpc130684-camd16-2-0-cust846.know.cable.virginm.net> has quit IRC (Ping timeout: 256 seconds)[17:08:27] *** Gurkenglas <Gurkenglas!~Gurkengla@94.223.133.187> has joined #chromium[17:08:34] *** Burek <Burek!~Burek@77.239.70.189> has joined #chromium[17:15:07] *** jam_ <jam_!~jam@104.132.1.92> has quit IRC ()[17:17:34] *** ajax16384 <ajax16384!~User@109.60.130.33> has joined #chromium[17:23:03] *** Pinkamena_D <Pinkamena_D!~Pinkamena@165.230.224.91> has joined #chromium[17:32:19] *** him-cesjf <him-cesjf!~himcesjf@unaffiliated/himcesjf> has joined #chromium[17:38:16] *** infernix <infernix!nix@unaffiliated/infernix> has quit IRC (Ping timeout: 252 seconds)[17:38:54] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-aphgbnpwudqwkfng> has joined #chromium[17:42:34] *** litherum <litherum!~litherum@17.202.139.214> has joined #chromium[17:48:40] *** RT|Chatzilla <RT|Chatzilla!~chatzilla@reactos/tester/RT> has quit IRC (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])[17:50:30] *** donofrio <donofrio!~donofrio@host-232.subnet-17.med.umich.edu> has joined #chromium[17:55:32] *** seventh <seventh!seventh@69.167.41.182> has joined #chromium[17:57:49] *** jrmuizel <jrmuizel!~jrmuizel@corp-nat.fw1.untrust.tor1.mozilla.com> has quit IRC (Remote host closed the connection)[17:57:51] *** Ex6TenZ <Ex6TenZ!~Ex6TenZ@193.180.164.58> has quit IRC (Quit: G⃒j⃒o⃒r⃒ E⃒n⃒ E⃒n⃒d⃒r⃒i⃒n⃒g⃒... D⃒r⃒e⃒p⃒ D⃒e⃒g⃒ S⃒e⃒l⃒v⃒)[18:01:18] *** raynold <raynold!uid201163@gateway/web/irccloud.com/x-xusacppziqkacswb> has joined #chromium[18:01:29] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has quit IRC (Ping timeout: 255 seconds)[18:07:37] *** infernix <infernix!nix@unaffiliated/infernix> has joined #chromium[18:11:05] *** n35xdxb0 <n35xdxb0!~n35xdxb0@cpc130684-camd16-2-0-cust846.know.cable.virginm.net> has joined #chromium[18:19:16] *** dave0x6d <dave0x6d!uid190567@gateway/web/irccloud.com/x-zbvweihgaxqcjwne> has quit IRC (Quit: Connection closed for inactivity)[18:19:53] *** gvso <gvso!~gvso@130.58.167.39> has joined #chromium[18:23:58] *** saint_dogbert <saint_dogbert!~Ident@unaffiliated/phobos-anomaly/x-6744724> has quit IRC (Quit: Konversation terminated!)[18:31:45] *** joedow <joedow!joedow@nat/google/x-gppnbqcfwarroykm> has quit IRC (Remote host closed the connection)[18:32:12] *** joedow <joedow!joedow@nat/google/x-kienhfgmjjvspsjp> has joined #chromium[18:32:12] *** ChanServ sets mode: +v joedow[18:38:57] *** bsheedy <bsheedy!bsheedy@nat/google/x-rnsylppdmaolgblk> has joined #chromium[18:38:57] *** ChanServ sets mode: +v bsheedy[18:39:07] *** phryk_ is now known as phryk[18:45:33] *** AfroThundr <AfroThundr!~AfroThund@h122.170.135.40.static.ip.windstream.net> has quit IRC (Ping timeout: 256 seconds)[18:49:59] *** rnk <rnk!~rnk@104.133.9.83> has quit IRC (Quit: Leaving)[18:54:05] *** claudiodesouza <claudiodesouza!~claudiode@194.73.46.50> has quit IRC (Quit: Lost terminal)[19:02:57] *** jsbell <jsbell!jsbell@nat/google/x-apdwjzsmrzqzupud> has joined #chromium[19:02:57] *** ChanServ sets mode: +v jsbell[19:10:32] *** grkblood <grkblood!967da67a@gateway/web/freenode/ip.150.125.166.122> has joined #chromium[19:12:39] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has joined #chromium[19:13:43] <grkblood> I'm attempting to simulate a network outage while using socketio (websockets) by enabling "Offline" under the network tab in the devtools. I have a listener for a socketio 'disconnect' that key on the connection dieing. Whenever I enable "Offline" though this doesn't happen. Is "Offline" truly offline?[19:14:37] <grkblood> If I kill my socketio server the listener will trigger[19:17:39] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has quit IRC (Ping timeout: 255 seconds)[19:19:03] *** robliao_ <robliao_!robliao@nat/google/x-drazvrnlgxxfyatz> has joined #chromium[19:19:03] *** ChanServ sets mode: +v robliao_[19:30:40] *** lnostdal_ <lnostdal_!~lnostdal@gateway/tor-sasl/lnostdal> has joined #chromium[19:34:51] *** Pinkamena_D <Pinkamena_D!~Pinkamena@165.230.224.91> has quit IRC (Ping timeout: 256 seconds)[19:36:54] *** markanini <markanini!uid58839@gateway/web/irccloud.com/x-gggxdtkeeufvrhux> has joined #chromium[19:42:57] *** litherum_ <litherum_!~litherum@17.237.11.189> has joined #chromium[19:44:43] *** butterthebuddha <butterthebuddha!~butterthe@ec2-13-228-73-171.ap-southeast-1.compute.amazonaws.com> has quit IRC (Max SendQ exceeded)[19:44:58] *** butterthebuddha <butterthebuddha!~butterthe@ec2-13-228-73-171.ap-southeast-1.compute.amazonaws.com> has joined #chromium[19:46:56] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has quit IRC (Quit: fredw)[19:47:40] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has joined #chromium[19:54:19] *** jrmuizel <jrmuizel!~jrmuizel@corp-nat.fw1.untrust.tor1.mozilla.com> has joined #chromium[19:54:52] *** ivali <ivali!~em@unaffiliated/ivali> has joined #chromium[19:54:57] *** ivali is now known as ivali728[19:59:24] *** fordfrog <fordfrog!~fordfrog@gentoo/developer/fordfrog> has quit IRC (Quit: Leaving)[19:59:48] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has quit IRC (Ping timeout: 252 seconds)[20:00:52] *** Gurkenglas <Gurkenglas!~Gurkengla@94.223.133.187> has quit IRC (Read error: Connection reset by peer)[20:03:16] *** himcesjf_ <himcesjf_!~himcesjf@unaffiliated/himcesjf> has joined #chromium[20:03:18] *** him-cesjf <him-cesjf!~himcesjf@unaffiliated/himcesjf> has quit IRC (Ping timeout: 240 seconds)[20:05:37] *** himcesjf_ is now known as him-cesjf[20:08:57] *** ivali728 is now known as ivali[20:21:44] *** Pinkamena_D <Pinkamena_D!~Pinkamena@69.136.102.83> has joined #chromium[20:21:47] *** carewolf <carewolf!carewolf@nat/digia/x-iqrnuxyfmyuuxcqq> has quit IRC (Ping timeout: 276 seconds)[20:25:38] *** tdresser <tdresser!~tdresser@2620:15c:0:11:7df6:e982:1b3e:8850> has quit IRC (Quit: Leaving.)[20:29:42] *** LocaMocha <LocaMocha!bocaneri@about/linux/staff/sauvin> has quit IRC (Ping timeout: 256 seconds)[20:30:54] *** Squishy_ <Squishy_!~textual@139-60-195-128.uinta.ngl.ninja> has joined #chromium[20:31:46] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has quit IRC (Quit: YuGiOhJCJ)[20:40:23] *** litherum <litherum!~litherum@17.202.139.214> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[20:41:05] *** litherum_ <litherum_!~litherum@17.237.11.189> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[20:47:26] *** gvso <gvso!~gvso@130.58.167.39> has quit IRC (Remote host closed the connection)[20:55:40] *** seventh <seventh!seventh@69.167.41.182> has quit IRC (Remote host closed the connection)[21:00:27] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has joined #chromium[21:03:44] *** ajax16384 <ajax16384!~User@109.60.130.33> has quit IRC (Read error: Connection reset by peer)[21:05:57] *** mthiesse <mthiesse!~mthiesse@2620:15c:0:1:a50c:610a:daf5:ccdb> has joined #chromium[21:06:13] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has joined #chromium[21:09:31] <mthiesse> android_n5x_swarming_rel appears to be in a bad state[21:12:29] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has quit IRC (Ping timeout: 276 seconds)[21:12:46] *** ivali <ivali!~em@unaffiliated/ivali> has quit IRC (Ping timeout: 252 seconds)[21:14:35] <mthiesse> troopers: ^[21:15:01] <mthiesse> https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/[21:16:41] *** virmaha <virmaha!d05b0122@gateway/web/freenode/ip.208.91.1.34> has joined #chromium[21:17:24] <virmaha> Hello. Have a simple query. In this https://chromium.googlesource.com/chromium/src/tools/grit/+/master , what's the difference between 'commit' and 'cr-mirrored-commit' ?[21:19:06] <Torne> this repository isn't a "real" separate project[21:19:14] <Torne> it's a subset of the main chromium repository created by a robot[21:19:34] <Torne> so "commit" is the sha1 of the commit created by the robot in the project that only contains tools/grit[21:19:48] <Torne> and cr-mirrored-commit is the sha1 of the "real" commit that was made in teh src/ repo that it's a copy of[21:20:05] <Torne> you generally don't want to be looking at or touching the subset projects[21:20:13] <Torne> almost always what you want is the "src" repo itself[21:20:40] <Torne> https://chromium.googlesource.com/infra/infra/+/master/infra/services/gsubtreed <- here's the thing that makes the subtree repositories if you want to know more about it[21:21:46] <virmaha> err,thanks for your explanation. Let me give you a concrete example so my understanding is clear[21:22:19] <virmaha> I got cef's branch 3029. In chrmium\Deps folder, I see a dependency as[21:22:26] <virmaha> (Var("chromium_git")) + '/breakpad/breakpad/src.git@10162f61e9ca4992e7851c69c7b8c6eddaab9e8e',[21:22:46] <virmaha> If I cd into breakpad/src directory, and do git log, it shows[21:22:50] <Torne> right - breakpad is an actual separate repository[21:22:57] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has quit IRC (Ping timeout: 240 seconds)[21:22:58] <virmaha> git log commit 10162f61e9ca4992e7851c69c7b8c6eddaab9e8e (HEAD) Author: Scott Graham <scottmg at chromium dot org>[21:23:01] <Torne> it's maintained separately outside the main repo, and pulled in via the DEPS file[21:23:05] <virmaha> https://chromium.googlesource.com/breakpad/breakpad/+/88e5b2c8806bac3f2c80d2fe80094be5bd371601[21:23:10] <Torne> tools/grit is *not* a separate repository pulled in via deps[21:23:16] <Torne> it's just a normal subdirectory of the main repository[21:23:27] <Torne> it just happens that for *other* reasons, there is *also* a seprate repsoitory for tools/grit[21:23:38] <Torne> whcih is created by the gsubtreed robot copying commits from the main src repo[21:23:55] <Torne> if you are just checking out and building a normal chromium thing then there is no reason to ever look at the src/tools/grit repo[21:23:57] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has joined #chromium[21:24:10] <virmaha> ah okay..I think it was my mistake that I gave tools/grit example. I mainly need help with breakpad example (which I can then extrapoltate to other deps)[21:24:24] <Torne> well, breakpad and other actual separate repos do not have the separate commit and cr-mirrored-commit[21:24:28] <Torne> because they aren't mirrored )[21:24:42] <virmaha> https://chromium.googlesource.com/breakpad/breakpad/+/88e5b2c8806bac3f2c80d2fe80094be5bd371601 has cr-mirrored-commit field[21:24:53] <Torne> again, though, youa re looking at the wrong repository[21:25:02] <virmaha> which is same as one which I see in git log commit 10162f61e9ca4992e7851c69c7b8c6eddaab9e8e (HEAD)[21:25:02] <Torne> that's breakpad/breakpad.git[21:25:12] <Torne> deps refers to breakpad/breakpad/src.git which is a different repo[21:25:35] <Torne> we have a confusing mess of many many repositories only some of which are checked out by a normal chromium build[21:25:39] <virmaha> :s[21:25:40] <Torne> and many of which have very similar names, and similar contents[21:25:51] <virmaha> err, so where can I find /breakpad/breakpad/src.git@10162f61e9ca4992e7851c69c7b8c6eddaab9e8e online?[21:26:08] <Torne> here: https://chromium.googlesource.com/breakpad/breakpad/src[21:26:16] <Torne> in the place that has the same path :)[21:26:36] <virmaha> yes, Isaw that :D but I can't find the commit 10162..[21:26:54] <Torne> https://chromium.googlesource.com/breakpad/breakpad/src/+/10162f61e9ca4992e7851c69c7b8c6eddaab9e8e[21:27:36] <virmaha> :o how did you reach that from https://chromium.googlesource.com/breakpad/breakpad/src[21:27:45] <Torne> i copypasted the sha1 from your message into the url[21:27:52] <Torne> :)[21:28:04] <Torne> it's not necessarily going to be in the history of master[21:28:11] <Torne> we branch the deps repositories as well sometimes[21:28:14] <virmaha> haha okay :D ah that's what[21:28:16] <Torne> so it might be in teh history of a completely different branch[21:28:25] <Torne> looking for them by hand is silly :)[21:28:40] <Torne> gitiles (our web repo browser there) supports most git log query syntaxes just fine[21:28:57] <Torne> most things you can specify as a revision/range for the git command line will work if you stick them after the /+/[21:28:57] <virmaha> so how did chromium use that commit?[21:29:04] <Torne> what do you mean how did it use it?[21:29:08] *** mel00010 <mel00010!~mel00010@2607:8400:2404:2:d655:62ab:4893:49e5> has joined #chromium[21:29:12] <Torne> it specified that sha1, so that's the sha1 that it fetched[21:29:15] <virmaha> correct me if I am wrong[21:29:32] <virmaha> breakpad/src had main master branch and say one other branch fix_bugs[21:29:50] <virmaha> on fix_bugs branch, commmit was made https://chromium.googlesource.com/breakpad/breakpad/src/+/10162f61e9ca4992e7851c69c7b8c6eddaab9e8e[21:30:25] <virmaha> and somehow cef decided I need 10162commit from fix_bugs branch in my chromium build[21:30:32] <Torne> it's not "somehow"[21:30:38] <Torne> it uses what is written in DEPS[21:30:49] <Torne> DEPS is a checked in file in the main repo that specifies the exact required versions of all subprojects[21:30:53] <virmaha> branch is not written[21:30:57] <Torne> it doesn't matter[21:31:06] <Torne> the version there is just what it's going to pass to "git checkout"[21:31:17] <Torne> it is always an exact SHA1, not a branch name, because we want it to be specific[21:31:20] <virmaha> ah got it[21:31:26] <Torne> if it was a branch name it would check out different things depending when you synced[21:31:29] <Torne> because branches move :)[21:31:43] <Torne> it downloads all the branches when it clones the repository, is all[21:31:46] <Torne> the same as git normally does[21:31:58] <Torne> so anything referenced by any branch is there to potentially be checked out already[21:32:01] <virmaha> so cef thought, okay - the commit 10162 on fix_bugs branch is perfect for us. Let's add the sha1 to our DEPS file since we are happy with all the code in fix_bugs branch upto commit 10162[21:32:21] <Torne> well it's unlikely CEF did this, this is probably just our deps file[21:32:28] <Torne> we pin all our dependencies to exact versions[21:32:29] <virmaha> ah yes[21:32:33] <virmaha> chromium deps[21:32:40] <Torne> and then when we want to update them we just send a change to change the sha1[21:32:55] <virmaha> so you don't worry about branch[21:32:56] <Torne> this is like git submodules or other similar things, but implemented manually with a tool on top of git (namely gclient)[21:33:04] <Torne> yah, the branches don't matter for pulling stuff in[21:33:11] <Torne> the branches are used by the people developing *the other repository*[21:33:13] <virmaha> I see[21:33:16] <Torne> chromium can pull in anything it wants[21:33:43] <virmaha> so chromium can pull in any commit living on any branch and put it in DEPS if it thinks it's good enough[21:33:49] <Torne> yep[21:34:02] <virmaha> gotcha, makes sense now[21:34:07] <Torne> with things like breakpad that are maintained by us and primarily exist to be pulled into chromium the branch structure often matches the chromium branch structure[21:34:18] <Torne> so in the breakpad repo you'l see there are branches named after chromium versions[21:34:24] <Torne> which are the version of breakpad intended for that chromium version[21:34:34] <Torne> but in other repositories it's not like that, because the project might not be something we maintain[21:34:36] <virmaha> I see[21:34:48] <Torne> ultimately it doesn't matter for the purposes of syncing[21:35:02] <Torne> so now while you're here i should mention another thing which si that branch 3029 is incredibly old and has tons of known security issues[21:35:13] <Torne> so you should't use it at all for anythign :)[21:35:14] *** zergut <zergut!uid221522@taskhive/translator/zergut> has quit IRC (Quit: Connection closed for inactivity)[21:35:37] <Torne> that's chrome 58, which is from nearly a year ago[21:35:46] <virmaha> hehe thanks. Yeah well, we are using cef and using external repos which chromium uses as git submodules[21:35:48] <Torne> current stable is 64 (branch 3282) and you shouldn't use anythign older than that[21:36:02] <virmaha> 3029 was first..then we upgraded to 3202[21:36:41] <Torne> yeah, well, you need to upgrade more ;)[21:37:05] <Torne> there's a new version every six weeks and it's pretty important to keep up because every version really is a security update[21:37:44] <virmaha> haha yeah I am taking over the project from other dev[21:37:53] <virmaha> but never used git hence the confusion[21:38:07] <virmaha> but thanks a ton for your help :D[21:38:18] <virmaha> rarely*[21:39:21] <virmaha> oh Torne, one more question[21:39:22] <Torne> well, gclient here is our own invention that isn't quite a normal git thing so it's often confusing to people :)[21:39:25] <virmaha> what's the difference betweeb[21:39:30] <virmaha> https://chromium.googlesource.com/breakpad/breakpad/src/+/10162f61e9ca4992e7851c69c7b8c6eddaab9e8e[21:39:38] <virmaha> and[21:39:39] <virmaha> https://chromium.googlesource.com/breakpad/breakpad/+/88e5b2c8806bac3f2c80d2fe80094be5bd371601[21:40:01] <virmaha> gclient sync is all I've ever used :P[21:40:26] <Torne> that's another case where gsubtreed is creating a repository based on a subdirectory of another repository[21:41:04] *** mel00010 <mel00010!~mel00010@2607:8400:2404:2:d655:62ab:4893:49e5> has quit IRC (Remote host closed the connection)[21:41:20] <virmaha> :S okay[21:41:28] *** mel00010 <mel00010!~mel00010@2607:8400:2404:2:d655:62ab:4893:49e5> has joined #chromium[21:41:34] <Torne> every commit in breakpad/breakpad.git gets read when it's created, and anything in teh "src" subdirectory of that repo gets copied into the separate breakpad/breakpad/src.git repo[21:41:41] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has joined #chromium[21:41:42] <Torne> which makes it a new commit, with a new sha1[21:42:00] <Torne> so the cr-mirrored-commit line is added to the commit message so that people can see where it was mirrored from[21:42:10] <Torne> breakpad/breakpad.git is the "real" repository that contains all of breakpad[21:42:28] <Torne> breakpad/breakpad/src.git is an "old" thing that chromium used to use to pull in just the 'src' subdirectory[21:42:33] <Torne> but we've stopped doing that now because it's confusing[21:42:43] <Torne> and current versions of chromium just check out the real repository[21:45:12] <virmaha> ahaaaa[21:45:15] <virmaha> that clears it up[21:45:19] <virmaha> thanks a ton Torne[21:45:21] <virmaha> ![21:45:44] *** drewmcmillan <drewmcmillan!~drewmcmil@drm6.pip.aber.ac.uk> has joined #chromium[21:45:45] <Torne> so yeah, there used to be a DEPS entry that pulled breakpad/breakpad/src into third_party/breakpad/src[21:45:53] <Torne> now there's a DEPS entry that pulls breakpad/breakpad into third_party/breakpad[21:46:00] <Torne> so all the files in src end up in the exact same place :)[21:46:06] <Torne> but now all the rest of the breakpad repo is also there[21:46:16] <virmaha> gotcha[21:46:18] <virmaha> perfect[21:46:20] <Torne> and it no longer relies on this subtree repository[21:46:38] *** kiltzman <kiltzman!~k1ltzman@95.215.47.208> has quit IRC (Ping timeout: 256 seconds)[21:47:19] *** mizu_no_oto_work <mizu_no_oto_work!~textual@c-24-60-15-130.hsd1.ma.comcast.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[21:48:58] *** kiltzman <kiltzman!~k1ltzman@185.117.75.189> has joined #chromium[21:48:59] *** kiltzman <kiltzman!~k1ltzman@185.117.75.189> has quit IRC (Max SendQ exceeded)[21:49:35] *** kiltzman <kiltzman!~k1ltzman@185.117.75.189> has joined #chromium[21:49:36] *** kiltzman <kiltzman!~k1ltzman@185.117.75.189> has quit IRC (Max SendQ exceeded)[21:50:05] *** kiltzman <kiltzman!~k1ltzman@185.117.75.189> has joined #chromium[21:53:32] *** mel00010 <mel00010!~mel00010@2607:8400:2404:2:d655:62ab:4893:49e5> has quit IRC (Ping timeout: 276 seconds)[21:55:55] *** mel00010 <mel00010!~mel00010@2607:8400:2404:2:d655:62ab:4893:49e5> has joined #chromium[22:01:50] *** tunekey <tunekey!~tunekey@unaffiliated/tunekey> has joined #chromium[22:04:24] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has joined #chromium[22:17:56] *** thakis_ <thakis_!~thakis@ool-4571e8ab.dyn.optonline.net> has joined #chromium[22:21:27] *** jwerner <jwerner!~jwerner@104.132.1.74> has quit IRC (Ping timeout: 240 seconds)[22:28:00] *** jwerner <jwerner!~jwerner@104.132.1.74> has joined #chromium[22:29:35] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has joined #chromium[22:37:57] *** thakis_ <thakis_!~thakis@ool-4571e8ab.dyn.optonline.net> has quit IRC (Quit: thakis_)[22:39:26] *** claudiodesouza <claudiodesouza!~claudiode@2.125.238.16> has quit IRC (Quit: Lost terminal)[22:43:30] *** Burek <Burek!~Burek@77.239.70.189> has quit IRC (Quit: Leaving)[22:54:31] *** orbyt_ <orbyt_!~orbyt@172.92.5.20> has joined #chromium[23:00:08] *** claudiodesouza <claudiodesouza!~claudiode@90.199.230.54> has joined #chromium[23:04:56] *** ehsan <ehsan!~ehsan@2620:101:80f2:224:80de:ca54:fc2:3fb3> has quit IRC (Ping timeout: 276 seconds)[23:09:07] *** drewmcmillan <drewmcmillan!~drewmcmil@drm6.pip.aber.ac.uk> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[23:13:12] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has quit IRC (Quit: fredw)[23:22:27] *** felda <felda!~felda@donger/pfsense> has quit IRC (Quit: Somehow this is cryptic1's fault!)[23:22:58] <tommycli> Anyone know why no new Canary releases have come out in the last few days?[23:37:17] *** drewmcmillan <drewmcmillan!~drewmcmil@drm6.pip.aber.ac.uk> has joined #chromium[23:41:46] *** AaronMT <AaronMT!~textual@2607:fea8:3de0:cb7:51e1:87a:7b6f:3a54> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[23:42:00] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on https://build.chromium.org/p/chromium/builders/Android/builds/81973 "Android" from aad20baa13d651187bdb56593cf63ac9bb2830ed: depot-tools-chromium-autoroll at skia-buildbots dot google.com.iam.gserviceaccount.com,jdufault@google.com,katie@chromium.org,mmoss@google.com,sanfin@chromium.org,scottchen@chromium.org,tbansal@chromium.org,thomasanderson@chromium.org)[23:50:10] *** dominickn <dominickn!~dominickn@104.132.133.92> has joined #chromium[23:52:04] <trungl-bot> Tree opened by chongz at chromium dot org: Tree is open (Android "compile" exception looks like a hung bot again)[23:53:49] *** fredw <fredw!~Thunderbi@mar75-2-81-56-69-222.fbx.proxad.net> has joined #chromium[23:54:04] *** drewmcmillan <drewmcmillan!~drewmcmil@drm6.pip.aber.ac.uk> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[23:59:33] *** RT|Chatzilla <RT|Chatzilla!~chatzilla@reactos/tester/RT> has joined #chromium