[00:13:14] *** maschmid has quit IRC
[00:18:58] *** cbrock has quit IRC
[02:11:54] *** aslak has quit IRC
[05:15:09] *** mbg has quit IRC
[05:15:18] *** mbg has joined #weld-dev
[06:53:56] *** rruss has joined #weld-dev
[06:57:42] *** magesh has joined #weld-dev
[07:23:34] *** mbg has quit IRC
[07:23:39] *** mbg has joined #weld-dev
[07:26:57] *** mbg has quit IRC
[07:27:11] *** mbg has joined #weld-dev
[08:04:26] *** pchowaniec has joined #weld-dev
[08:26:20] *** alesj has joined #weld-dev
[08:28:42] *** maschmid has joined #weld-dev
[08:29:15] *** ge0ffrey has joined #weld-dev
[08:36:55] *** epbernard has joined #weld-dev
[08:40:04] *** epbernard is now known as emmanuel
[08:53:44] <alesj> stuartdouglas: did you find out why incontainer is running instead of embedded?
[09:13:41] *** magesh1 has joined #weld-dev
[09:15:53] *** magesh has quit IRC
[09:29:19] <ge0ffrey> alesj: I am here (I created https://github.com/weld/core/pull/130 )
[09:29:50] *** stuartdouglas has quit IRC
[09:30:14] *** stuartdouglas has joined #weld-dev
[09:30:21] <alesj> ge0ffrey: is there a way we could add some reasonable test for it?
[09:30:45] <ge0ffrey> alesj: idunno, it's pretty deep in the architecture
[09:32:08] <alesj> ge0ffrey: wouldn't we just need some resources hirearchy, wherre the parent had beans.xml?
[09:32:12] <alesj> or whatever the issue was
[09:32:18] <ge0ffrey> it's a small fix, but it took me a couple of hours to find and fix correctly (because of url escaping vs file escaping issues). But the classloader way is just so wrong.
[09:32:42] <ge0ffrey> alesj: not really, just ask it what's the url for "/org" and it's wrong
[09:33:00] <ge0ffrey> in the old code
[09:33:04] <stuartdouglas> ge0ffrey: have you tested that on windows?
[09:33:13] <stuartdouglas> if (name.endsWith("/") is a bit sus
[09:33:36] <ge0ffrey> stuartdouglas: no. but that name isn't a file, is't a URL
[09:33:49] <stuartdouglas> ah
[09:34:13] <ge0ffrey> so if File.toURI().toURL() works properly, that shouldn't matter... but a test on windows can't hurt of course ;)
[09:34:49] <ge0ffrey> it's probably faster too
[09:35:16] <ge0ffrey> I tested with spaces etc (java class files can't contain them but resources can)
[09:35:43] <ge0ffrey> and $ too
[09:36:14] <ge0ffrey> spaces should be encoded, $ should not: and that's happens
[09:37:47] *** oskutka has joined #weld-dev
[10:27:34] *** mkouba has joined #weld-dev
[10:29:24] *** rruss has quit IRC
[10:39:58] *** mkouba has quit IRC
[10:58:55] *** pmuir has joined #weld-dev
[10:58:55] *** pmuir has quit IRC
[10:58:55] *** pmuir has joined #weld-dev
[11:11:53] *** mkouba has joined #weld-dev
[11:28:40] *** aslak has joined #weld-dev
[11:40:40] *** stuartdouglas has quit IRC
[11:40:40] *** emmanuel has quit IRC
[11:43:30] *** stuartdouglas has joined #weld-dev
[11:43:30] *** emmanuel has joined #weld-dev
[12:07:28] *** jbossbot has quit IRC
[12:07:53] *** dmlloyd has quit IRC
[12:11:08] *** emmanuel has quit IRC
[12:17:53] *** jbossbot has joined #weld-dev
[12:19:14] *** dmlloyd has joined #weld-dev
[12:26:05] *** epbernard has joined #weld-dev
[12:26:05] *** epbernard is now known as emmanuel
[12:54:16] *** alesj is now known as alesj_lunch
[13:53:36] *** rmartinelli has joined #weld-dev
[13:59:05] *** maschmid has quit IRC
[14:03:59] *** maschmid has joined #weld-dev
[14:19:40] *** mbg|away has joined #weld-dev
[14:41:42] *** maschmid has quit IRC
[14:49:15] *** maschmid has joined #weld-dev
[15:22:25] *** alesj_lunch is now known as alesj
[15:28:08] *** emmanuel has quit IRC
[15:41:25] *** pchowaniec has left #weld-dev
[16:10:00] *** mbg has quit IRC
[16:16:33] *** mbg|away is now known as mbg
[16:16:33] *** mbg has joined #weld-dev
[16:21:42] *** mbg has quit IRC
[16:33:44] *** epbernard has joined #weld-dev
[16:33:44] *** epbernard is now known as emmanuel
[17:06:45] *** aslak has quit IRC
[17:06:54] *** aslak has joined #weld-dev
[17:07:13] *** aslak has quit IRC
[17:09:38] *** aslak has joined #weld-dev
[17:10:52] *** mbg has joined #weld-dev
[17:16:10] *** mkouba has quit IRC
[17:23:50] *** cbrock has joined #weld-dev
[17:26:57] *** alesj has quit IRC
[17:27:09] *** oskutka has quit IRC
[18:03:29] *** mbg has quit IRC
[18:06:14] *** mbg has joined #weld-dev
[18:19:38] *** maschmid has quit IRC
[18:24:23] *** kevinpollet has joined #weld-dev
[19:01:34] *** maschmid has joined #weld-dev
[19:18:26] *** magesh1 has left #weld-dev
[19:20:27] *** emmanuel has quit IRC
[19:24:47] *** emmanuel has joined #weld-dev
[19:49:36] *** emmanuel has quit IRC
[20:37:06] *** kevinpollet has quit IRC
[20:38:48] *** ge0ffrey has quit IRC
[21:23:58] *** alesj has joined #weld-dev
[21:31:39] *** kevinpollet has joined #weld-dev
[21:37:23] *** kevinpollet has quit IRC
[21:39:56] *** kevinpollet has joined #weld-dev
[22:34:58] *** maschmid has quit IRC
[22:58:09] *** kevinpollet has quit IRC
[23:05:17] *** mbg has quit IRC
[23:10:51] *** aslak has quit IRC
[23:11:23] *** aslak has joined #weld-dev
[23:11:23] *** aslak has joined #weld-dev
[23:16:23] *** aslak has quit IRC
[23:16:51] *** aslak has joined #weld-dev
[23:53:05] *** pmuir has quit IRC
[23:53:47] <alesj> stuartdouglas: any chance you could look into embedded vs. incontainer tests today?
[23:54:13] <alesj> or, what else is stopping us form moving the master to arq-upgrade branch?
[23:55:57] *** alesj has quit IRC
[23:58:15] *** sbryzak has quit IRC
[23:58:18] *** sbryzak_ has joined #weld-dev





top