[00:12:31] <alesj> stuartdouglas: WELD-811
[00:12:33] <jbossbot> jira [WELD-811] Hierarchy injection is not working with external annotation type. [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/WELD-811
[00:12:54] <stuartdouglas> alesj: I have a feeling that may be fixed
[00:13:08] <stuartdouglas> as part of one of the other issues I fixed
[00:13:26] <alesj> ah, ok
[00:14:01] <stuartdouglas> actually I am not 100% sure
[00:14:40] <alesj> hmmm, how could we check/test this ...
[00:15:00] <stuartdouglas> by writing a test that uses an extension to modify the type
[00:15:04] <stuartdouglas> there are a few there already
[00:16:15] <stuartdouglas> alesj: struberg The latest weld 1.1.2 seems to be heaps faster at running @ViewAccessScoped
[00:16:45] <stuartdouglas> the problem was that in previous versions the observer method performance was terrible in some cases
[00:16:45] <alesj> stuartdouglas: so it should already work? ? if there are tests ...
[00:17:00] <stuartdouglas> as it looked up the method using reflection ever time
[00:17:05] <stuartdouglas> alesj: no tests
[00:17:45] <alesj> "there are a few there already" ? :-)
[00:17:59] <stuartdouglas> A few that do something similar (i.e. modify the annotated type)
[00:18:00] <struberg> stu will test it once its out
[00:18:49] <stuartdouglas> alesj: I think this may actually be a bug in his wrapAnnotatedType method
[00:19:09] <stuartdouglas> the code is correct in not looking at superclass annotated types
[00:19:25] <stuartdouglas> because the user provided annotated type is supposed to have all the annotation information
[00:20:31] <alesj> this looks like some converastion stuff again, which is always a pita to test ...
[00:20:42] <stuartdouglas> conversation?
[00:21:21] <stuartdouglas> alesj: oh, you mean the guy that randomly added a comment to the jira about some issue that he was having?
[00:21:31] <alesj> yes :-)
[00:22:06] <stuartdouglas> just delete it, JIRA is not a support forum :-) I doubt it is a bug, he probably has something wrong in his setup
[00:22:34] <alesj> :-)
[00:23:46] <alesj> stuartdouglas: can you then add the "wrong-code" comment on the real issue
[00:23:57] <alesj> i already deleted this random post :-)
[00:25:29] *** struberg has quit IRC
[00:30:51] *** struberg has joined #weld-dev
[00:35:56] *** struberg has quit IRC
[01:22:00] *** alesj has quit IRC
[04:39:21] *** sbryzak has quit IRC
[04:51:25] *** sbryzak has joined #weld-dev
[04:51:25] *** sbryzak has joined #weld-dev
[05:31:10] *** bobmcw has quit IRC
[05:36:41] *** iphands has quit IRC
[06:19:53] *** stuartdouglas has quit IRC
[07:03:56] *** stuartdouglas has joined #weld-dev
[08:07:51] *** mbg has joined #weld-dev
[08:21:49] *** magesh has joined #weld-dev
[08:50:19] *** emmanuel has joined #weld-dev
[09:43:44] *** aslak has joined #weld-dev
[09:47:53] *** struberg has joined #weld-dev
[09:51:22] *** oskutka has joined #weld-dev
[09:54:37] *** kevinpollet has joined #weld-dev
[10:08:26] *** mbg has quit IRC
[10:14:19] *** alesj has joined #weld-dev
[10:49:36] *** emmanuel has quit IRC
[10:56:56] *** alesj has quit IRC
[11:08:05] *** alesj has joined #weld-dev
[11:34:06] *** pmuir has joined #weld-dev
[11:34:06] *** pmuir has quit IRC
[11:34:07] *** pmuir has joined #weld-dev
[11:43:47] *** epbernard has joined #weld-dev
[11:43:47] *** epbernard is now known as emmanuel
[12:05:01] *** jharting has joined #weld-dev
[12:19:29] *** kevinpollet has quit IRC
[13:37:18] *** emmanuel has quit IRC
[13:39:36] *** emmanuel has joined #weld-dev
[13:41:20] *** kevinpollet has joined #weld-dev
[14:14:49] *** epbernard has joined #weld-dev
[14:14:53] *** emmanuel has quit IRC
[14:19:36] *** rmartinelli has joined #weld-dev
[14:30:57] *** sbryzak has quit IRC
[14:47:23] *** sbryzak has joined #weld-dev
[14:52:19] *** bobmcw has joined #weld-dev
[14:58:38] *** aslak has quit IRC
[15:24:02] *** sbryzak has quit IRC
[15:30:41] *** mbg has joined #weld-dev
[16:08:34] *** rruss has joined #weld-dev
[16:14:07] *** aslak has joined #weld-dev
[16:40:55] *** epbernard is now known as emmanuek
[16:41:00] *** emmanuek is now known as emmanuel
[16:49:48] *** alesj1 has joined #weld-dev
[16:49:48] *** alesj has quit IRC
[16:57:43] *** magesh has left #weld-dev
[17:05:13] *** alesj1 is now known as alesj
[17:19:58] *** emmanuel has quit IRC
[17:31:20] *** epbernard has joined #weld-dev
[17:31:21] *** epbernard is now known as emmanuel
[17:40:42] *** kevinpollet has quit IRC
[18:00:11] *** alesj has quit IRC
[18:12:42] *** oskutka has quit IRC
[18:18:00] *** kevinpollet has joined #weld-dev
[18:30:46] *** jharting has quit IRC
[19:14:41] *** kevinpollet has quit IRC
[19:14:58] *** kevinpollet has joined #weld-dev
[19:36:26] *** kevinpollet has quit IRC
[19:36:47] *** kevinpollet has joined #weld-dev
[19:58:58] *** kevinpollet has quit IRC
[20:47:44] *** kevinpollet has joined #weld-dev
[20:51:14] *** bobmcw has quit IRC
[20:55:25] *** kevinpollet_ has joined #weld-dev
[20:55:25] *** kevinpollet has quit IRC
[20:55:25] *** kevinpollet_ is now known as kevinpollet
[21:27:21] *** mbg has quit IRC
[21:27:41] *** kevinpollet has quit IRC
[21:27:43] *** balunasj has joined #weld-dev
[21:37:47] *** mbg has joined #weld-dev
[21:50:01] *** alesj has joined #weld-dev
[21:58:14] *** oskutka has joined #weld-dev
[22:24:47] *** pmuir has quit IRC
[22:27:23] *** pmuir has joined #weld-dev
[22:27:30] *** pmuir has quit IRC
[23:01:22] *** rmartinelli has quit IRC
[23:33:42] *** rruss has quit IRC
[23:48:04] <stuartdouglas> alesj: how did you go with weld?
[23:49:18] <alesj> stuartdouglas: not yet done, got distracted with EAP and the dmlloyd "abused" me for AS7 :-)
[23:49:30] <alesj> tomorrow morning is gonna be release time
[23:49:34] <stuartdouglas> ok
[23:49:50] <alesj> some super legacy AS6 stuff, which I probably promissed Shelly in 1934
[23:49:56] <alesj> and then Weld
[23:50:36] <alesj> you can poke around any issues till then if you think something can/should be still fixed
[23:50:55] <alesj> stuartdouglas: i'll ping you before i start releasing
[23:51:05] <stuartdouglas> ok
[23:51:14] <alesj> it worked the last time, but i'll check for sure, if all things are in place
[23:57:12] *** rruss has joined #weld-dev





top