July 6, 2011  
1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | 29 | 30 | 31

[00:00:36] <aslak> alesj, arq-final-snapshot, surefire 2.9, as7 remote profile worked for me, if you ignore the as7 issues
[00:01:18] <alesj> aslak: didn't you say remote is not cut for all testsuite?
[00:01:46] <aslak> ?
[00:02:18] <alesj> or was that for AS6?
[00:02:26] <alesj> or i just missunderstood
[00:02:44] <aslak> the only difference between remote and managed is if arq starts it
[00:04:27] <aslak> not sure what you are refering to.. or what i was refering to.. :)
[00:04:34] <stuartdouglas> The problem with AS6 was that it ran out of memory
[00:04:39] <stuartdouglas> AS7 does not have that problem
[00:04:44] <aslak> oh yea, true
[00:05:20] <stuartdouglas> I would not worry about the AS7 testing, it passes the TCK on AS7 and the weld internal tests on AS6 I think that is enough
[00:05:38] <stuartdouglas> At least for now
[00:06:30] <aslak> stuartdouglas, cdi tck?
[00:06:36] <stuartdouglas> yes
[00:06:50] <aslak> stuartdouglas, did you end up using that adaptor with only contianer support etc ?
[00:07:04] <stuartdouglas> yes
[00:07:17] <stuartdouglas> the adaptor just uses arq to start and stop the container
[00:07:18] <stuartdouglas> and deploy
[00:07:29] <aslak> cool
[00:08:07] <aslak> stuartdouglas, made the Maven Plugin v. for Arq Containers on saturday.. seemed to work quite smooth using just the containers
[00:08:39] <stuartdouglas> what do you mean?
[00:08:51] <aslak> https://github.com/arquillian/arquillian-maven/blob/master/plugin/src/main/java/org/jboss/arquillian/maven/BaseCommand.java#L119
[00:12:52] <aslak> stuartdouglas, basically another example of using just the Containers part of Arq, not involving Tests.. that's all :)
[00:13:04] <stuartdouglas> ah
[00:13:14] <aslak> (i think that's what we spoke about for the adaptor as well)
[00:13:20] <aslak> atleast what i was trying to communicate
[00:13:38] <stuartdouglas> aslak: incidentally are there any plans to allow you to run a heap of different test classes against a single deployment?
[00:13:49] <aslak> stuartdouglas, yes
[00:13:52] <stuartdouglas> e.g. say I wanted to just deploy my whole app once and then run all the tests
[00:13:58] <aslak> yes
[00:14:33] <aslak> you should be allowed to deploy sub 'suites' where the whole suite use the same deployments
[00:17:30] <aslak> alesj, stuartdouglas any of you guy have any comments for this: http://community.jboss.org/thread/168990
[00:21:37] <alesj> aslak: it depends on how easy/difficult it is to disable Weld' scopes
[00:21:43] <alesj> or how would you do this?
[00:21:58] <stuartdouglas> aslak: in the AS7 JMX runner the scope setup is handled by the AS7 weld integration
[00:22:08] <alesj> scan the test classes, and complain if the bean contains excluded scope?
[00:22:44] <stuartdouglas> disabling application scope would be problematic I think
[00:22:53] <aslak> stuartdouglas, i know, the point here is exposing a user api for handling it
[00:23:06] <aslak> yea, but request / session etc should be doable
[00:23:44] <stuartdouglas> https://github.com/stuartwdouglas/jboss-as/blob/master/weld/src/main/java/org/jboss/as/weld/arquillian/WeldContextSetup.java
[00:23:57] <stuartdouglas> that is how it is currently setup in the AS7 JMX runner
[00:24:01] <aslak> mm
[00:24:20] <aslak> stuartdouglas, that is assuming the test wants all scopes active
[00:26:03] <aslak> alesj, disable as in not activate. weld does that all the time and has apis for injecting them so that shouldn't be a problem
[00:26:24] <aslak> alesj, of course being inside a Servlet request and doing the same is a different story but
[00:26:50] <alesj> stuartdouglas: any idea about the failing interceptor order tests?
[00:27:05] <alesj> testOrder(org.jboss.weld.tests.interceptors.interceptorsOrderWithExclusions.InterceptorOrderTest): expected:<2> but was:<4>
[00:28:20] <stuartdouglas> alesj: I will have a look
[00:29:43] *** aslak has quit IRC
[00:31:53] <stuartdouglas> alesj: I can see what the problem is
[00:32:01] <alesj> stuartdouglas: ParserTest looks strange as well
[00:32:07] <alesj> so simple, yet it fails
[00:32:56] <stuartdouglas> alesj: AS7 uses a custom parser
[00:33:20] <alesj> for beans.xml?
[00:33:24] <alesj> stuartdouglas: ^
[00:33:44] <alesj> stuartdouglas: what's the iceptor order issue?
[00:33:48] <stuartdouglas> yes, although it is basically a copy of the weld one
[00:34:17] <alesj> it looks like it cannot handle whitespace in beans.xml
[00:34:48] <alesj> let me check ...
[00:35:07] <stuartdouglas> alesj: the interceptors are being called in the wrong order, the CDI interceptors are being run before method level interceptors
[00:36:04] <alesj> AS or Weld bug? if bug at all
[00:36:15] <stuartdouglas> AS
[00:39:06] <alesj> hmmm, how do we force current parser to ignore whitespace?
[00:39:09] <alesj> stuartdouglas: ^
[00:39:33] <alesj> as it looks previous parser did that
[00:39:33] <stuartdouglas> what is the actual error it is throwing?
[00:39:58] <alesj> assertNotNull
[00:40:05] <alesj> where the actual injected bean is null
[00:40:13] <stuartdouglas> The current parser was a fork of the weld one
[00:40:19] <alesj>    public void testWhitespaceInXml(Cow cow)
[00:40:22] <alesj> cow == null
[00:40:28] <stuartdouglas> but as we are using a different sax parser impl in as7
[00:40:32] <alesj> as Cow is an alternative
[00:40:42] <stuartdouglas> it needed a minot change, as some of the properties were not supported
[00:40:46] <alesj> although, i would first expect for validation to fail
[00:40:48] <alesj> not get null in
[00:42:31] <alesj> stuartdouglas: where the <class> for alt is split into 2 lines
[00:42:35] <alesj>       <class>
[00:42:35] <alesj>       org.jboss.weld.tests.parser.Cow</class>
[00:42:49] <alesj> and it looks like it doesn't know how to read this
[00:43:10] <alesj> while i don't see why it doesn't already fail at validation ...
[00:43:53] <stuartdouglas> that is very odd
[00:45:38] *** cbrock has quit IRC
[00:59:47] <alesj> stuartdouglas: OK, few failures are due to DefaultDS no longer being there
[01:00:31] <stuartdouglas> I think it is to late to fix that interceptor ordering failure
[01:00:43] <stuartdouglas> I don't think it will be a big issue anyway
[01:00:56] <stuartdouglas> and I will fix it for 7.1
[01:01:07] <alesj> should we tweak the tests then?
[01:01:12] <alesj> or simply exclude them?
[01:01:26] <stuartdouglas> exclude
[01:02:04] <stuartdouglas> You will only see the problem when you are combing method level @Interceptors interceptors with CDI interceptors
[01:02:12] <stuartdouglas> which I don't think will be very common
[01:04:02] <alesj> mvn clean install -Pjbossas7-remote -Dtest=org.jboss.weld.tests.enterprise.EjbDescriptorLookupTest
[01:04:26] <alesj> WELD-000088 Observer method must be static or local business method:  [method] public org.jboss.weld.tests.enterprise.Capercaillie.observe(Feed) on public@RequestScoped @Stateful class org.jboss.weld.tests.enterprise.Capercaillie
[01:05:47] <stuartdouglas> alesj: That is because we are only a web profile implementation
[01:06:39] <stuartdouglas> alesj: Actually I think the test is bogus
[01:07:05] <stuartdouglas> observe is defined on a remote interface
[01:25:38] <alesj> stuartdouglas: it does looks suspicious
[01:25:57] <stuartdouglas> what other failures where there?
[01:27:30] <alesj> org.jboss.weld.tests.interceptors.ejb.EnterpriseBeanInterceptionTest
[01:27:54] <alesj> ion(21)-127.0.0.1) Failed: org.jboss.weld.tests.interceptors.ejb.EnterpriseBeanInterceptionTest.testInterceptors: java.lang.NoClassDefFoundError: org/jboss/interceptor/spi/model/InterceptionModel
[01:28:17] <stuartdouglas> ok, don't worry about that to much
[01:28:31] <stuartdouglas> it is trying to use jboss interceptors classes that are not exposed to the deployment
[01:28:54] <stuartdouglas> we can adjust the test to have a Dependencies: manifest entry
[01:28:57] <stuartdouglas> anything else?
[01:29:08] <alesj> let me re-run things
[01:29:27] <alesj> the failures are Aslak' email
[01:30:00] <alesj> http://pastebin.com/hVhi1fgf
[01:30:02] <alesj> stuartdouglas: ^
[01:30:54] <alesj> org.jboss.weld.tests.enterprise.EnterpriseBeanTest
[01:31:16] <alesj> same: Caused by: org.jboss.weld.exceptions.DefinitionException: WELD-000088 Observer method must be static or local business method:  [method] public org.jboss.weld.tests.enterprise.Capercaillie.observe(Feed) on public@RequestScoped @Stateful class org.jboss.weld.tests.enterprise.Capercaillie
[01:31:35] <stuartdouglas> I think that is bogus
[01:31:43] <alesj> how come we didn't see this one before?
[01:32:01] <alesj> "or local business method" ? which is not
[01:32:05] <alesj> as it's on remote
[01:32:14] <stuartdouglas> not sure, probably a problem with the AS6 integration
[01:34:23] <alesj> stuartdouglas: testRequestContextLifecycle(org.jboss.weld.tests.event.tx.TxEventTest): 404 Not Found for http://localhost:8080/test//home.jsf
[01:35:55] <stuartdouglas> not really sure about that one
[01:36:30] <alesj> race condition?
[01:36:45] <stuartdouglas> doubt it
[01:36:54] <stuartdouglas> there is a double // in the url
[01:37:16] <stuartdouglas> I would need to run it
[01:37:19] <stuartdouglas> give me a sec
[01:37:27] <alesj> let me remove it, and re-run
[01:37:29] <alesj> ah :-)
[01:37:42] <alesj> can you check that ParseTest?
[01:37:43] <stuartdouglas> the server log will be the interesting bit
[01:39:37] <alesj> nope, same:
[01:39:38] <alesj> testRequestContextLifecycle(org.jboss.weld.tests.event.tx.TxEventTest): 404 Not Found for http://localhost:8080/test/home.jsf
[01:39:42] <alesj> with one /
[01:41:23] <stuartdouglas> alesj: what was in the server log?
[01:41:39] <stuartdouglas> A 404 implies a problem with the web container, rather than with weld
[01:42:08] <alesj> console log doesn't show anything
[01:42:23] <stuartdouglas> can you give me a pastebin of the full output?
[01:42:52] <stuartdouglas> alesj: maybe the ShrinkWrap behavoiur has changed
[01:43:20] <stuartdouglas> TxEventTest and ParserTest all use addAs*(Package, String, String)
[01:43:57] <alesj> i see CDI/Weld service being used
[01:43:59] <stuartdouglas> alesj: Actually in TxEventTest web.xml and faces-config.xml are being added into / instead of /WEB-INF
[01:44:03] <alesj> hence beans.xml should be recognized
[01:44:19] <stuartdouglas> which is why it is failing
[01:45:36] <alesj> hmmm, fixed that ? still failing
[01:45:49] <stuartdouglas> server log?
[01:46:33] <alesj> http://pastebin.com/7QBpHrCd
[01:47:13] <stuartdouglas> alesj: home.xhtml would be added using addAsWebResource
[01:47:16] <stuartdouglas> not addAsResource
[01:48:27] <alesj> uh, this SW stuff is confusing :-)
[01:48:41] <stuartdouglas> I know, and the api changes every release
[01:48:46] <alesj> cool, it works now
[01:49:50] <alesj> testNonContextual(org.jboss.weld.tests.nonContextual.ExampleTest): org/jboss/metadata/validation/ValidationException
[01:49:58] <alesj> ok, same ? impl details
[01:50:05] <stuartdouglas> same as the other NoClassDefFoundError
[01:50:41] <alesj> can you check ParserTest?
[01:52:07] <alesj> stuartdouglas: who should provide Logger injection?
[01:52:17] <stuartdouglas> what do you mean?
[01:52:33] <stuartdouglas> logger injection is not part of the spec
[01:53:02] <alesj> org.jboss.weld.tests.decorators.stackoverflow.StackOverFlowTest
[01:53:10] <alesj> SecurePaymentService
[01:53:25] <alesj> ah, ok, i see
[01:53:29] <alesj> LogFacatory
[01:53:32] <stuartdouglas> the LogFacatory
[01:53:39] <alesj> wrong name :-)
[01:53:47] <alesj> Faca ?
[01:55:04] <stuartdouglas> alesj: I can't get either your or aslak's arq-upgrade branch to build
[01:55:27] <alesj> TxEventTest issue?
[01:55:51] <stuartdouglas> alesj: what version of ARQ are you building it against?
[01:56:06] <alesj> ah, that
[01:56:08] <stuartdouglas> package org.jboss.arquillian.container.test.api does not exist
[01:56:23] <alesj> i built my own 1.0.0.Final-SNAPSHOT
[01:56:29] <alesj> of Arq-core
[01:56:31] <stuartdouglas> from where?
[01:56:38] <stuartdouglas> I have the latest arq core
[01:56:47] <stuartdouglas> and that is still giving me the issues
[01:57:17] <stuartdouglas> hmm, maybe I need to add some additional depenedencies
[01:58:02] <alesj> i simply grabed latest arq-core
[01:58:04] <alesj> build it
[01:58:11] <alesj> and it worked
[02:01:58] <alesj> stuartdouglas: 02:03:33,576 ERROR [org.jboss.osgi.framework.internal.BundleManager] (MSC service thread 1-3) Cannot find bundle associated with module: deployment.arquillian-service:main
[02:02:08] <alesj> for testExceptionPhaseListener(org.jboss.weld.tests.contexts.conversation.exceptionInPhaseListener.ClientConversationContextTest)
[02:02:18] <stuartdouglas> I don't think that would be the issue
[02:02:41] <stuartdouglas> alesj: stuff is being added to the wrong place again
[02:02:44] <stuartdouglas> in that test
[02:05:49] <alesj> i see
[02:06:27] *** johnament has joined #weld-dev
[02:14:07] <alesj> stuartdouglas: what exactly do we need new release for AS7?
[02:14:27] <stuartdouglas> for the proxy name fix and the interceptors fix that is in my branch
[02:14:41] <alesj> you mean the 888
[02:14:47] <stuartdouglas> WELD-888
[02:14:49] <jbossbot> jira [WELD-888] Interceptors not resolvable from a WAR-module which is part of an EAR-deployment [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/WELD-888
[02:15:05] <stuartdouglas> yes, although there is more to it that that
[02:15:14] <alesj> testAllOnBean(org.jboss.weld.tests.builtinBeans.ee.EEResourceProducerFieldPassivationCapableTest): Error looking up java:comp/UserTransaction in JNDI
[02:15:14] <alesj>   testResource(org.jboss.weld.tests.builtinBeans.ee.EEResourceProducerFieldPassivationCapableTest): Error looking up java:comp/UserTransaction in JNDI
[02:15:14] <alesj>   testEntityManager(org.jboss.weld.tests.builtinBeans.ee.EEResourceProducerFieldPassivationCapableTest): Error looking up java:comp/UserTransaction in JNDI
[02:15:14] <alesj>   testEntityManagerFactory(org.jboss.weld.tests.builtinBeans.ee.EEResourceProducerFieldPassivationCapableTest): Error looking up java:comp/UserTransaction in JNDI
[02:15:14] <alesj>   testRemoteEjb(org.jboss.weld.tests.builtinBeans.ee.EEResourceProducerFieldPassivationCapableTest): Error looking up java:comp/UserTransaction in JNDI
[02:15:16] <stuartdouglas> basically interceptor resolition is non-deterministic
[02:16:27] <alesj> testUTInjectedByResource(org.jboss.weld.tests.resources.ResourceTest)
[02:17:08] <alesj> stuartdouglas: any idea why UT is not found in that test?
[02:18:02] <stuartdouglas> probably because jar deployments don't have a java:comp ns
[02:18:06] <stuartdouglas> or something like that
[02:19:00] <alesj>    @Resource
[02:19:00] <alesj>    UserTransaction userTransaction;
[02:19:06] <alesj> should this be resolveable?
[02:20:04] <stuartdouglas> alesj: That is kind of an odd one, because it has that mappedName thing
[02:20:12] <stuartdouglas> can you post the full server log?
[02:20:42] <alesj> stuartdouglas: http://pastebin.com/63PP3x8w
[02:22:35] <stuartdouglas> alesj: not sure about that one, I would say it is something to do with it being a jar deployment, rather than a war or ear
[02:23:19] <alesj> why NPE, and not assertion?>
[02:23:41] <alesj> as it looks like "consumer" bean is already null
[02:24:56] <stuartdouglas> alesj: This looks the same as the web xml parsing one
[02:24:58] <alesj> I've changed it to .war and it works now
[02:25:21] <alesj> web xml parsing one?
[02:25:23] <stuartdouglas> I think that the CDI test enricher is not injection into methods from jar deployments
[02:25:27] <stuartdouglas> or something like that
[02:25:40] <stuartdouglas> oops, beans.xml parsing one
[02:26:21] <stuartdouglas> cause I just looked at the UserTransaction code and @Resource should work no matter what
[02:27:41] <alesj> stuartdouglas: where does persistmce.xml have to be? in .war
[02:27:49] <alesj> WEB-INF/classes/META-INF?
[02:27:54] <stuartdouglas> yes
[02:28:28] <alesj> how do i tell SW to put it there?
[02:28:54] <stuartdouglas> addAsResource("META-INF/persistence.xml")
[02:29:37] <alesj>             .addAsManifestResource(
[02:29:37] <alesj>                   EEResourceProducerFieldPassivationCapableTest.class.getPackage(),
[02:29:37] <alesj>                   "persistence.xml", "persistence.xml")
[02:29:46] <alesj> stuartdouglas: ^ would this also work?
[02:30:00] <stuartdouglas> I think that would go /META-INF
[02:30:11] <stuartdouglas> rather than /WEB-INF/classes/META-INF
[02:31:00] <alesj> yeah, looks like it
[02:31:09] <alesj>             .addAsResource(
[02:31:09] <alesj>                   EEResourceProducerFieldPassivationCapableTest.class.getPackage(),
[02:31:09] <alesj>                   "persistence.xml", "META-INF/persistence.xml")
[02:31:11] <alesj> let me try this
[02:32:04] <alesj> yup, works
[02:32:16] <alesj> i think i have them all, except ParseTest
[02:33:20] <stuartdouglas> change parse test to a war and see if it works
[02:39:13] <alesj> [INFO] BUILD SUCCESS
[02:39:16] <alesj> :-)
[02:40:52] <alesj> stuartdouglas: ^
[02:40:56] <stuartdouglas> nice
[02:41:04] <alesj> yeah, thanks for helping
[02:41:40] <alesj> tomorrow i'll see how it goes against AS6
[02:42:01] <stuartdouglas> I'll probably have to do some kind of release today for AS7
[02:42:12] <alesj> that's fine
[02:42:17] <alesj> i'll push this in
[02:42:23] <alesj> into my arq-upgrade branch
[02:42:30] <alesj> i already merged your 888
[02:42:58] <stuartdouglas> why haven't you been merging your fixes into upstream?
[02:43:00] <alesj> heck, you can even do 1.1.2.Final if you like
[02:43:07] <stuartdouglas> I don't have permission
[02:43:15] <alesj> ah, true
[02:44:16] <alesj> where do i need to change this?
[02:44:39] <alesj> i guess in weld context for github
[02:44:44] <stuartdouglas> yes
[02:46:02] <alesj> ok, pushed to my arq-upgrade branch
[02:48:43] <stuartdouglas> alesj: what is the commit sha1 of the arq you were working against?
[02:49:12] <alesj> let me check
[02:49:44] <alesj> Skywalker:arquillian-core alesj$ git log
[02:49:44] <alesj> commit cd408afddadb81d288f11b10748a9031399cdea1
[02:49:44] <alesj> Author: Aslak Knutsen <aslak at redhat dot com>
[02:49:44] <alesj> Date:   Wed Jun 29 22:59:52 2011 +0200
[02:49:44] <alesj>     ARQ-495 Update ServletProtocol to use RemoteLoadableExtension, this allows the Extension to be loaded InContainer and the ServletCommandService can be registered.
[02:49:46] <jbossbot> jira [ARQ-495] ServletProtocol does not use RemoteLoadableExtension so CommandService is not registered [Resolved (Done) Bug, Major, Aslak Knutsen] https://issues.jboss.org/browse/ARQ-495
[02:49:46] <alesj> stuartdouglas: ^
[02:51:13] <stuartdouglas> alesj: where did that come from?
[02:51:19] <stuartdouglas> I can't even check that out
[02:51:59] <stuartdouglas> alesj: hang on
[02:52:06] <stuartdouglas> wrong arq checkout
[02:52:23] <stuartdouglas> thats better
[02:53:22] <alesj> stuartdouglas: i added you to weld intergattors
[02:53:28] <alesj> you should have pull&push now
[02:53:29] <stuartdouglas> alesj: are you going to push the arq-upgrade branch to upstream/master?
[02:53:33] <stuartdouglas> cool, thanks
[02:53:57] <alesj> i would like to run things against AS6 first
[02:53:59] <stuartdouglas> actually it has a snapshot dep on arquillian
[02:54:16] <alesj> but i think you can still cut 1.1.2.Final
[02:54:19] <alesj> hmmm ? uf
[02:54:21] <stuartdouglas> I think I am going to have to release from my master
[02:54:40] <alesj> that snapshot is pita
[02:54:58] <alesj> what about if you then release 1.1.2.CR1?
[02:55:06] <stuartdouglas> Is it possible to release with a SNAPSHOT dep?
[02:55:13] <alesj> and we'll go to Final once that snapshot is resolved
[02:55:16] <alesj> good question
[02:55:24] <alesj> i doubt it is
[02:55:27] <stuartdouglas> only 1 way to find out I suppose
[02:55:34] <alesj> at least, it shoulfn't be allowed
[02:55:44] <stuartdouglas> although the snapshot is scope test
[02:55:48] <stuartdouglas> so maybe it is
[02:56:01] <alesj> as it makes release non-re-produceable
[02:56:52] <stuartdouglas> In that case what about doing 1.1.2.CR1 as all the commits before the arq-upgrade branch?
[02:58:17] <alesj> before?
[02:58:21] <stuartdouglas> alesj: ^
[02:58:32] <stuartdouglas> As in 754a2c0b58b1c082eac7
[02:58:37] <alesj> i would do it on current state of that branch
[02:58:42] <stuartdouglas> plus a cherry pick of WELD-888
[02:58:44] <jbossbot> jira [WELD-888] Interceptors not resolvable from a WAR-module which is part of an EAR-deployment [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/WELD-888
[02:59:19] <alesj> b/c of that snapshot dep?
[02:59:19] <stuartdouglas> alesj: but that has a snapshot dep, and the tests don't pass
[02:59:27] <stuartdouglas> cause of the surefire issue
[02:59:35] <alesj> remote test pass
[02:59:40] <alesj> tests
[02:59:51] <alesj> managed don't
[03:02:04] <stuartdouglas> alesj: I think the only real option at this stage is to release a special AS7 version
[03:02:29] <alesj> ok, that's fine by me
[03:04:00] <alesj> stuartdouglas: i'm off to bed, it's 3am ? half asleep already
[03:04:15] <stuartdouglas> ok
[03:04:26] <alesj> a custom AS7 version is fine by me
[03:04:41] <alesj> and it's probably gonna work for GF as well?
[03:04:47] <stuartdouglas> yes, it should
[03:04:49] <alesj> and I don't see why not for AS6, right?
[03:05:00] <stuartdouglas> of course, there are no SPI changes
[03:05:06] <alesj> it just won't be so super tested
[03:05:18] <alesj> but it does fix a few nasty bugs we missed before
[03:05:21] <stuartdouglas> I am still going to run AS6 incontainer, AS7 tck
[03:05:27] <alesj> ok, cool
[03:05:40] <alesj> tty in the morning then
[03:05:46] <stuartdouglas> alesj: I am just cherry picking out the non ARQ upgrade commits
[03:05:56] <stuartdouglas> do you want me to push this to upstream when I am done?
[03:06:07] <stuartdouglas> and then the arq upgrade branch can be rebased on it?
[03:06:07] <alesj> sure
[03:06:25] <alesj> sounds good
[03:06:40] <alesj> ok, off ...
[03:06:44] <alesj> ttyl
[03:06:52] *** alesj has quit IRC
[03:07:27] <stuartdouglas> night
[04:14:27] <jbossbot> git [core] push master 940dc75.. Pete Muir Add TX to login example
[04:14:27] <jbossbot> git [core] push master 2b8a908.. Stuart Douglas AS7 version
[04:14:27] <jbossbot> git [core] push master 35f993b.. Stuart Douglas Change proxy name generation
[04:14:27] <jbossbot> git [core] push master 7bff2bd.. Ales Justin [WELD-834]; decode special chars
[04:14:28] <jbossbot> jira [WELD-834] URLScanner can not handle paths containing spaces [Open (Unresolved) Bug, Major, Ales Justin] https://issues.jboss.org/browse/WELD-834
[04:14:29] <jbossbot> git [core] push master 4e1cdb9.. Ales Justin [WELD-849]; fix vendor info
[04:14:30] <jbossbot> jira [WELD-849] Change vendor from sfwk.org to Red Hat for Weld artifacts [Resolved (Done) Task, Major, Ales Justin] https://issues.jboss.org/browse/WELD-849
[04:14:30] <jbossbot> git [core] push master 1a6dbf1.. Ales Justin [WELD-879, WELD-906]; fix container order
[04:14:31] <jbossbot> jira [WELD-879] Tomcat 7 container is identified as Tomcat 6 [Open (Unresolved) Bug, Major, Ales Justin] https://issues.jboss.org/browse/WELD-879
[04:14:32] <jbossbot> jira [WELD-906] Jetty 7.2+ container incorrectly identified as Jetty 7 container [Open (Unresolved) Bug, Minor, Ales Justin] https://issues.jboss.org/browse/WELD-906
[04:14:33] <jbossbot> git [core] push master e1c5202.. Ales Justin [WELD-915]; fix NPE
[04:14:33] <jbossbot> jira [WELD-915] NPE at org.jboss.weld.util.Beans.mergeInQualifiers(Beans.java:924) [Resolved (Done) Bug, Major, Ales Justin] https://issues.jboss.org/browse/WELD-915
[04:14:34] <jbossbot> git [core] push master 17a09d7.. Ales Justin [WELD-886]; make lock per instance
[04:14:35] <jbossbot> jira [WELD-886] AbstractContext creationLock deadlock [Open (Unresolved) Bug, Major, Ales Justin] https://issues.jboss.org/browse/WELD-886
[04:14:36] <jbossbot> git [core] push master a9eed3a.. Ales Justin [WELD-913]; fix setApplication
[04:14:36] <jbossbot> jira [WELD-913] SeamApplicationWrapper doesn't implement setApplication() correctly [Open (Unresolved) Bug, Major, Shane Bryzak] https://issues.jboss.org/browse/WELD-913
[04:14:37] <jbossbot> git [core] push master e4d16de.. Ales Justin [WELD-919]; ignore cid if nocid key is present.
[04:14:38] <jbossbot> jira [WELD-919] Conversation propagation token that negates the "cid" parameter [Open (Unresolved) Feature Request, Major, Ales Justin] https://issues.jboss.org/browse/WELD-919
[04:14:39] <jbossbot> git [core] push master 19c4100.. Ales Justin Fix url pattern.
[04:14:39] <jbossbot> git [core] push master d58728c.. Ales Justin Ignore empty path info.
[04:14:40] <jbossbot> git [core] push master d559ec9.. Ales Justin [WELD-834]; fix white space handling, so it also works on OSX.
[04:14:41] <jbossbot> git [core] push master da259d1.. Ales Justin Use AS6.1-SNAPSHOT, workaround weird AS6.1 behavior with logging.properties.
[04:14:42] <jbossbot> git [core] push master 0aaf813.. Ales Justin Expose url path decoding.
[04:14:42] <jbossbot> git [core] push master cf982de.. Stuart Douglas WELD-916 Remove references to weld extensions
[04:18:26] <jbossbot> git [core] push 1.1.2.AS7 10bd0c9.. Stuart Douglas [maven-release-plugin] prepare release 1.1.2.AS7
[04:18:27] <jbossbot> git [core] push 1.1.2.AS7 URL: http://github.com/weld/core/compare/0000000...40b7b85
[05:50:23] *** johnament has quit IRC
[06:13:50] *** magesh has joined #weld-dev
[07:46:23] *** aslak has joined #weld-dev
[07:46:23] *** aslak has joined #weld-dev
[08:04:41] *** epbernard has joined #weld-dev
[08:04:41] *** epbernard is now known as emmanuel
[08:17:32] *** mbg has quit IRC
[09:39:23] *** aslak has quit IRC
[09:39:56] *** aslak has joined #weld-dev
[10:09:00] *** alesj has joined #weld-dev
[10:15:08] *** ctomc has joined #weld-dev
[10:18:21] <alesj> stuartdouglas: nice, 1.1.2.AS7 :-)
[10:18:31] <stuartdouglas> Morning alesj
[10:18:40] <stuartdouglas> that made it into AS7
[10:18:48] <stuartdouglas> I also fixed the interceptor ordering thing
[10:18:55] <alesj> cool
[10:19:09] <alesj> i can enable the tests then?
[10:19:10] <stuartdouglas> and pushed it about 5 minutes before the final pre-tag
[10:19:17] <alesj> :-)
[10:19:36] <stuartdouglas> I did not push any of the ARQ upgrade stuff to master, only the bug fixes
[10:19:53] <alesj> but is there anything custom to AS7, or i guess this release should work for all?
[10:20:03] <stuartdouglas> we you will need to rebase arq-upgrade on top of upstream
[10:20:09] <stuartdouglas> no, there is no custom AS7 stuff
[10:24:16] <alesj> http://pastebin.com/Pc5JBWwr
[10:24:17] <alesj> stuartdouglas: ^
[10:24:29] <alesj> any idea why it fails ? or is it expected to fail?
[10:24:36] <alesj> aka needs manual merge
[10:24:45] <stuartdouglas> alesj: what is the result of git status?
[10:24:57] <stuartdouglas> sometimes when you rebase a branch on top of a cherry pick
[10:25:09] <stuartdouglas> you get a empty commit in the rebase
[10:25:11] <alesj> Skywalker:core alesj$ git st
[10:25:11] <alesj> # Not currently on any branch.
[10:25:11] <alesj> # Unmerged paths:
[10:25:11] <alesj> #   (use "git reset HEAD <file>..." to unstage)
[10:25:11] <alesj> #   (use "git add/rm <file>..." as appropriate to mark resolution)
[10:25:19] <stuartdouglas> and you just have to skip it
[10:25:24] <stuartdouglas> just skip it
[10:25:38] <stuartdouglas> there may be a few of them
[10:25:51] <stuartdouglas> git rebase --skip
[10:25:51] <alesj> ok, let me skip it
[10:26:23] <alesj> CONFLICT (content): Merge conflict in environments/servlet/core/src/main/java/org/jboss/weld/environment/servlet/jsf/WeldApplicationFactory.java
[10:26:23] <alesj> Failed to merge in the changes.
[10:26:23] <alesj> Patch failed at 0009 [WELD-913]; fix setApplication
[10:26:24] <jbossbot> jira [WELD-913] SeamApplicationWrapper doesn't implement setApplication() correctly [Open (Unresolved) Bug, Major, Shane Bryzak] https://issues.jboss.org/browse/WELD-913
[10:26:32] <alesj> i guess i should skip this as well?
[10:27:14] <alesj> ok, after 3 skips, it looks like it merged now
[10:27:22] <alesj> how to test if it merged properly?
[10:32:35] <alesj> stuartdouglas: ^
[10:32:53] <stuartdouglas> alesj: 3 skips sounds about right
[10:32:57] <stuartdouglas> I did 3 cherry picks
[10:37:16] <alesj> stuartdouglas: so, you're saying the iceptor order should be fine now
[10:37:35] <alesj> i'll enable back the tests, and re-run the whole stuff
[10:37:37] <stuartdouglas> yes
[10:55:24] *** emmanuel has quit IRC
[11:06:00] <alesj> stuartdouglas: ok, iceptor order tests all pass
[11:06:15] <alesj> stuartdouglas: btw, did you manage to run 112AS7 against AS6?
[11:07:17] <stuartdouglas> alesj: yes
[11:07:21] <stuartdouglas> full pass
[11:09:15] <alesj> nice
[11:38:02] *** pmuir has joined #weld-dev
[12:35:01] *** alesj has quit IRC
[12:47:27] *** alesj has joined #weld-dev
[12:49:58] *** alesj has quit IRC
[12:50:30] *** alesj has joined #weld-dev
[14:03:08] *** emmanuel has joined #weld-dev
[14:45:06] *** magesh has left #weld-dev
[14:47:34] *** kevinpollet has joined #weld-dev
[16:19:12] *** alesj has quit IRC
[16:43:47] *** ctomc has quit IRC
[16:50:10] *** balunasj has joined #weld-dev
[16:52:31] *** mbg has joined #weld-dev
[17:00:34] *** ctomc has joined #weld-dev
[17:10:44] *** kevinpollet_ has joined #weld-dev
[17:10:44] *** kevinpollet has quit IRC
[17:10:44] *** kevinpollet_ is now known as kevinpollet
[17:11:04] *** kevinpollet has quit IRC
[18:23:24] *** emmanuel has quit IRC
[18:23:28] *** epbernard has joined #weld-dev
[18:23:28] *** epbernard is now known as emmanuel
[18:23:56] *** cbrock has joined #weld-dev
[20:43:02] *** bobmcw has quit IRC
[21:58:57] *** pmuir has quit IRC
[22:08:23] *** mbg has quit IRC
[22:09:06] *** mbg has joined #weld-dev
[22:38:47] *** maschmid has joined #weld-dev
[23:11:59] *** johnament has joined #weld-dev
[23:21:47] *** emmanuel has quit IRC
[23:31:11] *** jbott has joined #weld-dev
[23:31:12] *** maxiphone has joined #weld-dev
[23:31:30] <maxiphone> #startmeeting
[23:31:31] <jbott> Meeting started Wed Jul  6 21:35:19 2011 UTC.  The chair is maxiphone. Information about MeetBot at http://wiki.debian.org/MeetBot.
[23:31:31] <jbott> Useful Commands: #action #agreed #help #info #idea #link #topic.
[23:32:06] <maxiphone> #action mojavelinux buys beer
[23:32:12] <maxiphone> #endmeeting
[23:32:25] <jbott> Meeting ended Wed Jul  6 21:36:02 2011 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
[23:32:25] <jbott> Minutes:        http://transcripts.jboss.org/meeting/irc.freenode.org/weld-dev/2011/weld-dev.2011-07-06-21.35.html
[23:32:25] <jbott> Minutes (text): http://transcripts.jboss.org/meeting/irc.freenode.org/weld-dev/2011/weld-dev.2011-07-06-21.35.txt
[23:32:25] <jbott> Log:            http://transcripts.jboss.org/meeting/irc.freenode.org/weld-dev/2011/weld-dev.2011-07-06-21.35.log.html
[23:51:11] <mbg> aslak: you should set up an #arquillian channel :)
[23:52:09] *** maxiphone has quit IRC
[23:52:47] <johnament> mbg: that's #jbosstesting
[23:54:04] <mbg> johnament: ah! thanks. now I remember
[23:59:21] *** johnament has quit IRC

top