[00:34:25] *** bobmcw has quit IRC [00:48:35] *** aamonten has quit IRC [01:36:19] *** rcernich has quit IRC [02:21:40] *** PeteRoyle has quit IRC [02:28:36] *** lanceball has quit IRC [02:40:18] *** PeteRoyle has joined #switchyard [02:52:55] *** kcbabo has joined #switchyard [03:53:35] *** aamonten has joined #switchyard [05:11:29] <aamonten> kcbabo: hi [05:25:49] *** kcbabo has quit IRC [05:27:02] *** aamonten has quit IRC [05:31:58] *** dbevenius has joined #switchyard [05:32:38] *** aamonten has joined #switchyard [05:33:07] *** magesh has joined #switchyard [05:54:15] *** aamonten has quit IRC [05:55:50] *** dbevenius has quit IRC [06:27:18] *** PeteRoyle has quit IRC [07:38:53] *** tcunning has quit IRC [08:08:56] *** magesh has left #switchyard [08:12:30] *** magesh has joined #switchyard [08:13:52] *** magesh has quit IRC [08:16:58] *** magesh has joined #switchyard [09:03:22] *** dbevenius has joined #switchyard [09:32:19] *** aslak has joined #switchyard [10:27:31] *** PeteRoyle has joined #switchyard [11:33:37] *** magesh1 has joined #switchyard [11:35:14] *** magesh has quit IRC [12:33:13] *** aslak is now known as aslak_afk [12:45:21] *** kcbabo has joined #switchyard [13:11:46] *** rbalent has joined #switchyard [13:11:46] *** rbalent has joined #switchyard [13:16:26] *** tcunning has joined #switchyard [13:18:54] <magesh1> kcbabo: Hi, good morning! [13:19:12] <kcbabo> magesh1: hey magesh, good evening [13:19:27] <magesh1> kcbabo: I sent in the updated pull that fixes all app deployments except smooks [13:20:22] <magesh1> kcbabo: Have a spin and let me know if all goes fine [13:20:23] <kcbabo> magesh1: any idea what the issue is with smooks? [13:20:38] <magesh1> kcbabo: https://issues.jboss.org/browse/SWITCHYARD-306 [13:20:46] <kcbabo> magesh1: I'm not sure we ever tested that with AS7 now that I think about it [13:21:11] <magesh1> kcbabo: Looks like the update in modules still did not fix it [13:21:23] <magesh1> kcbabo: I will need more time to investigate [13:21:41] <kcbabo> magesh1: ok, so no change there w/r/t Beta3 vs. CR1 [13:22:50] <magesh1> kcbabo: :) yeah [13:23:03] <kcbabo> magesh1: ok, no worries there then [13:23:11] <kcbabo> magesh1: great work - I'll take it for a spin in a sec [13:23:38] <magesh1> kcbabo: I am waiting for you to push [13:23:55] <magesh1> kcbabo: Will be awaiting your results eagerly [13:29:47] *** magesh1 is now known as magesh [13:34:52] *** antollinim has joined #switchyard [13:43:14] *** GitHub84 has joined #switchyard [13:43:14] <GitHub84> [core] kcbabo pushed 1 new commit to master: http://bit.ly/kRXYT6 [13:43:14] <GitHub84> [core/master] [SWITCHYARD-238] - Updated AS7 to CR1 - Magesh Kumar B [13:43:14] *** GitHub84 has left #switchyard [13:44:23] <magesh> kcbabo: Really? :) [13:45:04] <kcbabo> magesh: worked for me? did I miss something? [13:45:21] <magesh> kcbabo: No, just kidding [13:45:28] <magesh> kcbabo: You noticed that a failed deployment on startup fails every other deployment in White Rabbit? [13:45:38] <kcbabo> magesh: ah, sorry ? caffeine deprived at the moment [13:45:54] <kcbabo> magesh: that I didn't notice ? what's going on with that? [13:46:19] <magesh> kcbabo: I think it is bug in theirs, could you please verify that for me? [13:46:38] <kcbabo> magesh: sure, I can give it a whirl [13:46:47] <magesh> kcbabo: Awesome, thanks! [13:51:54] <kcbabo> magesh: thanks for taking care of this on your day off :-) [13:52:55] <magesh> kcbabo: Don't mention it, it was my pleasure all along [13:53:39] <magesh> kcbabo: If you push that release too then I will be at peace! [13:53:53] <kcbabo> magesh: working on it ? deployed core first [13:54:23] <magesh> kcbabo: If I am at peace then I can tackle the Lion next week ;) [13:54:37] <kcbabo> magesh: hehe ? he's on vacation, so it should be no contest [13:54:52] <magesh> kcbabo: Reminds me of the Lion and the Rabbit story http://www.storyarts.org/library/nutshell/stories/lion.html [13:55:00] <magesh> kcbabo: :-D [13:56:48] <kcbabo> magesh: that sounds about right :-) [14:17:42] <magesh> kcbabo: the AS7 startup is a bug [14:18:48] <kcbabo> magesh: which startup? [14:19:04] <kcbabo> magesh: or are yo referring to the failed deployment? [14:19:30] <magesh> kcbabo: failed deployment on startup fails every other deployment in White Rabbit https://issues.jboss.org/browse/AS7-783 [14:19:40] <kcbabo> magesh: ah, okie dokie [14:19:46] <kcbabo> magesh: hopefully that's fixed in CR2 ;-) [14:20:24] <magesh> kcbabo: Are you waiting for the CR1 download via maven? [14:20:39] <kcbabo> magesh: what do you mean? [14:21:05] <magesh> kcbabo: You did not say anything abou the release pull request, lol [14:21:38] <kcbabo> magesh: I pushed all your changes and deployed. I even kicked the release build on Hudson and the latest SNAPSHOT build contains CR1 now ... [14:21:39] <kcbabo> https://hudson.qa.jboss.com/hudson/job/SwitchYard-Release/ [14:22:05] *** aamonten has joined #switchyard [14:22:39] <magesh> kcbabo: Awesome, I did not see any notifications here [14:22:59] <magesh> kcbabo: Sorry about that [14:23:19] <kcbabo> magesh: I think maybe we need to set it up [14:23:23] <kcbabo> magesh: in github [14:23:53] <magesh> kcbabo: ;) you read my mind [14:24:28] <magesh> kcbabo: This still is open https://github.com/jboss-switchyard/release/pull/11 [14:25:02] <aamonten> kcbabo: hi, the daily build will now include as7cr1? [14:25:24] * magesh have whisky in the morning kcbabo [14:25:32] <aamonten> kcbabo: magesh answered my question :P [14:26:11] <magesh> aamonten: :) [14:28:10] <magesh> kcbabo: Keith? [14:30:30] <kcbabo> yep, it includes CR1 [14:30:31] <kcbabo> gotta run [14:30:34] *** kcbabo has quit IRC [14:33:06] <magesh> aamonten: As Keith said maybe it is a github thing, I am downloading the distro [14:41:23] <aamonten> magesh: ok, will download the distro [14:54:27] <magesh> aamonten: I confirm it is CR1 [14:56:44] *** magesh has left #switchyard [14:59:40] <aamonten> magesh: nice, thanks! [15:36:50] *** lanceball has joined #switchyard [15:40:19] *** jgraham_ has joined #switchyard [16:06:32] *** errantepiphany has joined #switchyard [16:06:38] *** dbevenius has quit IRC [16:22:12] *** kcbabo has joined #switchyard [16:48:06] <errantepiphany> brb [16:48:09] *** errantepiphany has left #switchyard [16:56:02] *** rcernich has joined #switchyard [17:08:13] <kcbabo> rcernich: hey rob, how you doin'? [17:08:24] <rcernich> kcbabo: better [17:08:34] <kcbabo> rcernich: great [17:08:42] <kcbabo> rcernich: feel like handling a pull request? [17:08:43] <rcernich> kcbabo: thanks for asking [17:08:48] <rcernich> kcbabo: sure [17:08:57] <kcbabo> rcernich: k, one sec [17:11:39] <kcbabo> rcernich: this one would be good: [17:11:41] <kcbabo> https://github.com/jboss-switchyard/components/pull/167 [17:11:55] <kcbabo> rcernich: do you have a rough idea of how we do it? [17:12:01] *** errantepiphany has joined #switchyard [17:12:04] <rcernich> kcbabo: no idea [17:12:09] <kcbabo> rcernich: :-) [17:12:18] <kcbabo> rcernich: ok, so it's errantepiphany 's pull request [17:12:28] <kcbabo> rcernich: very straightforward change [17:12:38] <kcbabo> rcernich: but first, you need to get your environment setup [17:12:48] <kcbabo> rcernich: I recommend having a separate workspace to handle pull requests [17:12:59] <errantepiphany> kcbabo, rcernich: Ummm, what are we talking about? [17:13:15] <kcbabo> rcernich: so go to a new directory and clone this repo: [17:13:15] <kcbabo> git at github dot com:jboss-switchyard/components.git [17:13:31] <kcbabo> errantepiphany: nothing, just that you messed everything up and rcernich is gonna fix it [17:13:37] <errantepiphany> kcbabo: f*ck. [17:13:43] <kcbabo> errantepiphany: he's going to take your pull request :-) [17:13:46] <kcbabo> errantepiphany: that's all [17:13:53] <errantepiphany> kcbabo: ah. 1st time? [17:13:56] <kcbabo> errantepiphany: yep [17:14:19] <errantepiphany> kcbabo: well be gentle. ;) [17:14:29] <kcbabo> rcernich: then you will want to create a branch to review and build the pull request [17:14:33] <kcbabo> errantepiphany: always :-) [17:14:51] <kcbabo> rcernich: git checkout -b SWITCHYARD-324 [17:15:37] <kcbabo> rcernich: then pull the changes in like this: [17:15:37] <kcbabo> git pull https://github.com/errantepiphany/switchyard-components.git SWITCHYARD-324 [17:15:53] <kcbabo> rcernich: at that point, you have a topic branch setup with david's changes in it [17:16:04] *** jgraham_ has quit IRC [17:16:06] <kcbabo> rcernich: you can then do a "mvn clean install checkstyle:check" to make sure everything is legit [17:16:23] <kcbabo> rcernich: generally a good idea to eyeball the code real quick [17:16:38] <kcbabo> rcernich: and if the build passes then you can go ahead and merge the change into your master and push [17:17:08] <rcernich> kcbabo: let me see if i've got this straight [17:17:23] <rcernich> kcbabo: clone the switchyard repo [17:17:37] <rcernich> kcbabo: create a branch in that repo to pull the changes [17:17:51] <rcernich> kcbabo: pull the changes into that branch [17:18:06] <rcernich> kcbabo: test the changes [17:18:15] <rcernich> kcbabo: merge branch back into master [17:18:22] <rcernich> kcbabo: does that summarize it? [17:18:39] <kcbabo> rcernich: yep, you got it [17:18:49] <kcbabo> rcernich: here's a cheat sheet in case you get stuck [17:18:51] <kcbabo> git clone git at github dot com:jboss-switchyard/components.git [17:18:51] <kcbabo> cd components [17:18:51] <kcbabo> git checkout -b SWITCHYARD-324 [17:18:51] <kcbabo> git pull https://github.com/errantepiphany/switchyard-components.git SWITCHYARD-324 [17:18:51] <kcbabo> mvn clean install checkstyle:check [17:18:51] <kcbabo> git rebase master [17:18:52] <kcbabo> git checkout master [17:18:52] <kcbabo> git merge SWITCHYARD-324 [17:18:53] <kcbabo> git push origin master [17:18:56] <rcernich> kcbabo: and all this is done in the switchyard repo, not my repo [17:19:03] <kcbabo> rcernich: that's correct [17:19:17] <rcernich> kcbabo: hope i don't screw up ;) [17:19:20] <errantepiphany> rcernich: I'm sure kcbabo wants to to grok the process, but there is a "hidden" cheat sheet on every pull request page. Just click on the "i" (for "i"nformation) to the left of the "This pull request can be automatically merged." text in green. [17:19:30] <errantepiphany> s/wants to to/wants you to/ [17:19:35] <kcbabo> rcernich: in theory, you could do this all out of one local repository, but that can get dicey [17:19:46] <kcbabo> errantepiphany: cheater! [17:19:49] <errantepiphany> kcbabo: hahaha [17:20:01] <kcbabo> rcernich: one thing to keep in mind [17:20:14] <rcernich> kcbabo: i think i've messed up enough local repos for one week;) [17:20:17] <kcbabo> rcernich: did you notice the "git rebase master" before switching back to the master branch? [17:20:19] <errantepiphany> rcernich: Yeah, kcbabo is right in that's it's a Good Idea to have 2 local repos. One for your work, and one just for the purpose of pulling in and pushing others' changes. [17:20:23] <rcernich> kcbabo: i'll stick to the script [17:20:43] <kcbabo> rcernich: there are times when commits go out of order in the pull request queue [17:20:55] <rcernich> kcbabo: k [17:21:08] <kcbabo> rcernich: if the parent of the pull request is different than the parent of upstream tip, then you'll get a merge commit [17:21:14] <kcbabo> rcernich: merge commits are the devil [17:21:22] <kcbabo> rcernich: harmless, but quite unsightly [17:21:53] <kcbabo> rcernich: so what that "git rebase master" does is it rebases the commit you just pulled down onto the tip of the upstream master repository [17:22:08] <kcbabo> rcernich: in this case, you are cloning the upstream master in the first step, so you know it's up-to-date [17:22:19] <rcernich> kcbabo: right [17:22:30] <kcbabo> rcernich: in the future, you will always want to make sure you pull from upstream master before processing a pull request [17:22:37] <kcbabo> rcernich: that's it [17:22:44] <kcbabo> rcernich: I'll be around if things go crazy [17:23:20] <rcernich> kcbabo: so, for future, pull master first, then branch, then pull changes? [17:23:36] <rcernich> kcbabo: and what is the difference between pulling and rebasing? [17:24:45] <errantepiphany> kcbabo: Never heard back from Jiri on https://issues.jboss.org/browse/SWITCHYARD-296 . I think we can close it as non-reproducible... Thoughts? [17:25:23] <kcbabo> rcernich: pulling is bringing down changes from another repository [17:25:35] <kcbabo> rcernich: rebasing is taking a commit and moving it [17:25:50] <errantepiphany> kcbabo: Also, can you please close: https://issues.jboss.org/browse/SWITCHYARD-323 ? thx. [17:26:02] <kcbabo> rcernich: you can actually pull with a rebase, which basically means "pull all the current stuff down from repository 'x' and put my commit(s) on top of them" [17:26:36] <kcbabo> errantepiphany: crap, thought I did that. sorry. [17:26:51] <errantepiphany> kcbabo: no worries, Mr. Process. ;) [17:26:59] <kcbabo> errantepiphany: :-) [17:27:12] <rcernich> kcbabo: ok, i'll try to understand this better afterward [17:27:41] <kcbabo> errantepiphany: not sure what's up with 296 ? [17:28:24] <errantepiphany> kcbabo: I used his XML in his jira, and couldn't reproduce it. Maybe I'll give him another couple days before closing it. [17:28:59] <kcbabo> errantepiphany: sounds good [17:52:19] *** aslak_afk is now known as aslak [18:00:53] <kcbabo> rcernich: oh, one other thing [18:01:12] <kcbabo> rcernich: never, ever, never ever ever use the "-f" flag when pushing to upstream master [18:01:21] <rcernich> kcbabo: makes sense [18:01:35] <kcbabo> rcernich: it's fine for your own branch on your own repository [18:01:46] <kcbabo> rcernich: because that's essentially disposable [18:01:51] <kcbabo> rcernich: upstream master is not :-) [18:02:29] *** GitHub60 has joined #switchyard [18:02:29] <GitHub60> [components] rcernich pushed 1 new commit to master: http://bit.ly/k0NoU4 [18:02:29] <GitHub60> [components/master] SWITCHYARD-324: Auto-start BPM processes if processActionType property is unspecified - David Ward [18:02:29] *** GitHub60 has left #switchyard [18:03:00] <kcbabo> rcernich: thanks for that [18:03:15] <rcernich> kcbabo: hopefully i did it correctly [18:03:20] <kcbabo> rcernich: if the build breaks now, it's one month of free beers for everyone on the team at your expense [18:03:27] <rcernich> kcbabo: almost screwed the pooch [18:03:32] <rcernich> kcbabo: ok:D [18:04:00] <rcernich> kcbabo: i almost forgot to switch back to master [18:04:52] <errantepiphany> rcernich, kcbabo: remember there's a quickstarts pull request associated with that jira too. ;) [18:05:06] <rcernich> ok [18:05:07] <kcbabo> rcernich: round 2 ! [18:06:06] <kcbabo> rcernich: when you're done with that, you should be able to mark the JIRA as resolved as well [18:06:07] <kcbabo> https://issues.jboss.org/browse/SWITCHYARD-324 [18:06:18] <rcernich> kcbabo: looking at it now [18:08:41] <aamonten> kcbabo: rcernich: also free beer for community contributors? [18:09:10] <kcbabo> aamonten: hehe ? why not, it's on rob's dime :-) [18:13:29] *** GitHub74 has joined #switchyard [18:13:29] <GitHub74> [quickstarts] rcernich pushed 1 new commit to master: http://bit.ly/kDOi8s [18:13:29] <GitHub74> [quickstarts/master] SWITCHYARD-324: Auto-start BPM processes if processActionType property is unspecified - David Ward [18:13:29] *** GitHub74 has left #switchyard [18:14:12] <rcernich> kcbabo, aamonten: i guess i better make doubly sure i don't hork it up:) [18:14:31] <kcbabo> rcernich: personally, I'm hoping that you fail [18:14:44] <kcbabo> rcernich: but that's what the prospect of free beer does to me [18:15:48] <aamonten> kcbabo: Im looking at jira for a new issue to work on.. [18:15:56] <aamonten> kcbabo: any on mind? [18:16:26] <kcbabo> aamonten: I'm just going through them myself today to get caught up [18:16:30] <rcernich> kcbabo: :) [18:18:24] <aamonten> kcbabo: ok, let me know.. mean while I will start to work on the spring component [18:20:32] <rcernich> kcbabo: so now that i've processed all pull requests associated with that issue, do i need to do anything with the issue itself? [18:21:00] <kcbabo> rcernich: mark it as resolved and just note in the comment that you pushed the pull request [18:21:18] <rcernich> kcbabo: k [18:28:36] <kcbabo> aamonten: you know arqullian, right? [18:29:04] <kcbabo> aamonten: I seem to remember that you have a little noble award on your .org avatar :-) [18:29:12] <aamonten> kcbabo: yes.. got a reward for contribution to arquillian, a huge badge :) [18:29:18] <kcbabo> aamonten: very impressive [18:29:43] <kcbabo> aamonten: magesh was working on getting an AS7 test running in our release build [18:29:49] <kcbabo> aamonten: we already have one for AS6 [18:29:58] <kcbabo> aamonten: it's using the remote mode and not embedded [18:30:19] <kcbabo> aamonten: anyhoo, magesh has some work here, but I think he said that the test doesn't actually run for some reason [18:30:20] <kcbabo> https://github.com/mageshbk/release/commit/54ece059bf0198f17a85ed58cd48e0fc5cc146f9 [18:30:32] <kcbabo> aamonten: here's a link to his branch: [18:30:32] <kcbabo> https://github.com/mageshbk/release/tree/SWITCHYARD-271 [18:30:52] <aamonten> kcbabo: ok, will give it a try :) [18:35:33] <errantepiphany> kcbabo, rcernich: FYI, this is still out there, and goes along with the other pull request that was handled: https://github.com/jboss-switchyard/quickstarts/pull/47 ... ;) [18:36:08] <kcbabo> errantepiphany: that's already been committed [18:36:13] <kcbabo> errantepiphany: https://github.com/jboss-switchyard/quickstarts/commits/master [18:36:27] <kcbabo> errantepiphany: pull request didn't auto-close because the rebase probably changed the parent [18:36:35] <kcbabo> errantepiphany: github doesn't detect that for some reason [18:36:44] <kcbabo> errantepiphany: but you bring up a good point .... [18:36:58] <kcbabo> rcernich: you forgot to close the pull request - you owe us all beer for a month [18:37:23] <kcbabo> rcernich: I was gonna let you slide, but errantepiphany would have none of it [18:37:40] <errantepiphany> hahaha [18:40:36] <kcbabo> errantepiphany: I guess rob's gone out to purchase the beer [18:41:02] <kcbabo> I'll be back in a bit [18:41:07] *** kcbabo is now known as babo_afk [18:41:16] *** aamonten is now known as aamonten_Afk [18:49:45] <rcernich> errantepiphany: can you help me out with this pull request closure issue? [18:50:03] <errantepiphany> rcernich: what do you mean? [18:50:26] <rcernich> errantepiphany: what you and keith were talking about a few minutes ago [18:51:55] <errantepiphany> rcernich: I assume he means just go here: https://github.com/jboss-switchyard/quickstarts/pull/47 and click on "comment and close" [18:52:08] *** rbalent has quit IRC [18:52:50] <rcernich> errantepiphany: ahh, so the code was merged fine, but the pull request itself was left open? [18:54:01] <errantepiphany> rcernich: Yup. I don't fully understand it, but that's what he was saying. [18:54:17] <rcernich> errantepiphany: great. thanks! [18:55:18] <errantepiphany> rcernich: np [18:59:22] *** aslak has quit IRC [18:59:45] *** aslak has joined #switchyard [19:00:44] *** aslak has quit IRC [19:23:06] *** antollinim__ has joined #switchyard [19:23:52] *** antollinim has quit IRC [19:32:46] *** lanceball is now known as lance_afk [19:57:10] *** babo_afk is now known as kcbabo [20:02:10] <rcernich> kcbabo: you left out the step about closing the pull request [20:02:21] <rcernich> kcbabo: :) [20:02:49] <rcernich> kcbabo: i just closed the request, i hope that was ok [20:03:31] <kcbabo> rcernich: yeah, that's fine [20:03:46] <rcernich> kcbabo: cool, i was worried for a second;) [20:03:52] <kcbabo> rcernich: it happened because during your push you did the rebase [20:04:00] <kcbabo> rcernich: I'm guessing anyway [20:04:11] <kcbabo> rcernich: which caused the parent of the commit you were pushing to change [20:04:16] <kcbabo> rcernich: which is the right thing to do [20:04:22] <rcernich> kcbabo: i did a rebase on both [20:04:35] <kcbabo> rcernich: yes, but it had no effect on one [20:04:40] <rcernich> kcbabo: hmm [20:04:56] <kcbabo> rcernich: rebase takes a commit and puts in on top of the current tip, yeah? [20:05:09] <rcernich> kcbabo: right [20:05:12] <kcbabo> rcernich: so if the commit is already on top of the current tip, it's a NOP [20:05:28] <kcbabo> rcernich: so one of those commits was a nop and the other had the parent adjusted [20:05:30] <rcernich> kcbabo: so if the tip has been updated since the pull was issued, you get some changes [20:05:35] <kcbabo> rcernich: exactly [20:05:49] <rcernich> kcbabo: ahh, ok [20:06:07] <kcbabo> rcernich: or if the submitted didn't rebase before issuing the pull request :-) [20:06:25] <kcbabo> rcernich: in any case, github will automatically close the pull request when it detects a commit [20:06:40] <kcbabo> rcernich: but in the case where the parent commit changes as part of a rebase, it doesn't do it for some reason [20:06:47] <rcernich> kcbabo: and if the pull request had conflicts with the new baseline, that's where the merge *ell comes in [20:06:49] <kcbabo> rcernich: that's why you had to close it yourself [20:07:02] <rcernich> kcbabo: cool, i'll add that to my notes [20:07:09] <kcbabo> rcernich: right, but the person issuing the pull request should sort all that out [20:07:28] <kcbabo> rcernich: if you get merge activity or merge conflicts, I would talk to the submitter on IRC real quick to see what's up [20:08:21] <rcernich> kcbabo: ok, makes sense [20:08:43] <rcernich> kcbabo: does that happen very often? [20:09:44] <kcbabo> rcernich: rebase parent or merge conflicts [20:09:56] <kcbabo> rcernich: former is reasonably common with our amount of activity [20:10:01] <kcbabo> rcernich: latter is not so comment [20:10:03] <kcbabo> common [20:11:04] <rcernich> kcbabo: cool, just curious [20:36:49] *** aslak has joined #switchyard [20:54:02] *** lance_afk is now known as lanceball [20:54:10] *** antollinim__ is now known as antollinim_afk [21:03:08] *** aamonten_Afk is now known as aamonten [21:19:50] *** aamonten has quit IRC [21:20:21] *** aamonten has joined #switchyard [21:21:43] <aamonten> kcbabo: do you know if magesh is going to continue working on the issue? I have to run now so will continue sunday or monday [21:22:17] <kcbabo> aamonten: I think he is off on Monday, so it won't be til Tuesday that he looks again [21:26:40] *** kcbabo has quit IRC [21:29:09] *** kcbabo has joined #switchyard [21:29:15] <kcbabo> ok, not sure what happened there [21:31:40] <aamonten> aamonten: ok, then I will continue working on it :) [21:32:01] <aamonten> kcbabo: ^^ [21:32:12] <kcbabo> aamonten: that would be great, thanks [21:32:24] <kcbabo> aamonten: sometimes an extra set of eyes helps [21:32:52] <aamonten> kcbabo: sure! .. but now birthday celebration :) [21:33:02] <kcbabo> aamonten: happy birthday! [21:33:34] <aamonten> kcbabo: thanks dude, I celebrate today but it's first on Monday [21:34:10] <aamonten> kcbabo: so please make a huge party over there.. July 4 :) [21:34:20] <kcbabo> aamonten: hehe ? if you insist :-) [21:40:48] *** bobmcw has joined #switchyard [21:45:07] *** aamonten has quit IRC [21:47:14] <kcbabo> rcernich: if you're bored, I've got another set of pull requests for you :-) [21:47:16] <kcbabo> rcernich: https://issues.jboss.org/browse/SWITCHYARD-202 [21:48:18] <rcernich> kcbabo: ok [21:53:36] <rcernich> kcbabo: ok, got a question on the pull [21:54:02] <rcernich> kcbabo: for this one, do i pull from https://github.com/kcbabo/core/tree/SWITCHYARD-202 [21:54:42] <rcernich> kcbabo: or from https://github.com/kcbabo/core.git [21:55:32] <rcernich> kcbabo: never mind [21:58:28] <kcbabo> rcernich: k :-) [21:59:42] *** bobmcw has quit IRC [22:00:57] *** GitHub165 has joined #switchyard [22:00:58] <GitHub165> [core] rcernich pushed 1 new commit to master: http://bit.ly/j36IsL [22:00:58] <GitHub165> [core/master] SWITCHYARD-202 fix NPEs when activator or implementation are not found - Keith Babo [22:00:58] *** GitHub165 has left #switchyard [22:04:20] <rcernich> kcbabo: ok, since i already have a components repo, i'm guessing i need to pull master before processing the pull request [22:05:33] <kcbabo> rcernich: you should do it as a habit [22:05:57] <kcbabo> rcernich: in this case, it's not really necessary because no other commits have gone in [22:06:14] <kcbabo> rcernich: but I always do it as part of my process [22:09:05] *** tcunning has quit IRC [22:19:06] <kcbabo> rcernich: hey rob, I messed up [22:19:16] <kcbabo> rcernich: there's a checkstyle error in the pull request I sent [22:19:24] <rcernich> kcbabo: ok [22:19:28] <kcbabo> rcernich: I'm never gonna hear the end of this one [22:19:29] <rcernich> kcbabo: in components? [22:19:34] <kcbabo> rcernich: nah, in core [22:19:37] <kcbabo> rcernich: already pushed it [22:19:55] <kcbabo> rcernich: go ahead and deploy components and I'll clean it up later tonight [22:19:55] <rcernich> kcbabo: i didn't see any errors when i ran the test [22:20:06] <kcbabo> rcernich: did you do "checkstyle:check" ? [22:20:27] <rcernich> kcbabo: ugh, i've been doing checkstyle:checkstyle, doh! [22:20:35] <kcbabo> rcernich: no worries, it's my bad [22:20:45] <kcbabo> rcernich: anyway, you can push the components pull and I'll fix it up later [22:20:51] <rcernich> kcbabo: i'm trying to clean up my config [22:20:53] <kcbabo> rcernich: thanks for taking care of it [22:21:02] <kcbabo> rcernich: I have to run now but I'll be back online later [22:21:04] <kcbabo> cya [22:21:11] <kcbabo> have a good 4th! [22:21:15] <rcernich> kcbabo: ditto! [22:21:16] *** kcbabo has quit IRC [22:25:29] *** rbalent has joined #switchyard [22:29:22] <rcernich> errantepiphany: can i ask you a quick git question? [22:41:01] *** GitHub130 has joined #switchyard [22:41:02] <GitHub130> [components] rcernich pushed 1 new commit to master: http://bit.ly/iSQTlN [22:41:02] <GitHub130> [components/master] SWITCHYARD-202 updated camel tests based on method change in Deployment - Keith Babo [22:41:02] *** GitHub130 has left #switchyard [22:43:30] *** rcernich is now known as rcernich_brb [23:17:31] <errantepiphany> rcernich_brb: what's up? [23:19:51] *** antollinim_afk is now known as antollinim [23:21:17] *** antollinim has left #switchyard