[04:29:33] *** mbg has quit IRC
[05:07:51] *** stan8688 has joined #seam-dev
[05:39:23] *** stan8688 has quit IRC
[06:28:44] *** lightguard_jp has joined #seam-dev
[07:25:21] *** stuartdouglas_ has joined #seam-dev
[07:25:35] *** stuartdouglas has quit IRC
[07:26:53] *** stuartdouglas_ is now known as stuartdouglas
[07:40:03] *** lightguard_jp has quit IRC
[07:48:30] *** lightguard_jp has joined #seam-dev
[08:22:31] *** oskutka has joined #seam-dev
[08:25:07] *** maxandersen has joined #seam-dev
[08:27:35] *** lightguard_jp has quit IRC
[08:45:07] *** adamw1pl has joined #seam-dev
[09:06:22] *** shervin_a has joined #seam-dev
[09:24:19] *** kpiwko has joined #seam-dev
[10:39:34] *** marekn has joined #seam-dev
[10:48:44] *** pmuir has joined #seam-dev
[10:59:17] *** aslak has joined #seam-dev
[10:59:17] *** aslak has quit IRC
[10:59:17] *** aslak has joined #seam-dev
[11:03:44] <pmuir> hey stuart
[11:04:45] <pmuir> stuartdouglas: ^^^
[11:06:07] <adamw1pl> pmuir: I created the two issues I mentioned plus a new one (w/ testcases), I saw stuart already fixed one (WELD-768, WELD-769, WELD-770)
[11:06:09] <jbossbot> jira [WELD-768] Calling a bean method in a @AppScoped bean constructor causes NPE [Open, Major, Unassigned] https://jira.jboss.org/browse/WELD-768
[11:06:09] <jbossbot> jira [WELD-769] Intercepting a method in a bean where another method is final causes a VerifyError [Resolved, Major, Stuart Douglas] https://jira.jboss.org/browse/WELD-769
[11:06:10] <jbossbot> jira [WELD-770] Intercepting a bean with constructor injection causes an InstantiationException [Open, Major, Unassigned] https://jira.jboss.org/browse/WELD-770
[11:06:21] <pmuir> thanks adamw1pl
[11:06:30] <pmuir> was going to ask him if he is picking up the others too
[11:07:01] <adamw1pl> np :)
[11:07:17] <stuartdouglas> hey
[11:09:03] <stuartdouglas> pmuir: I will look at the others as well
[11:09:12] <pmuir> ok thanks stuyart
[11:09:16] <pmuir> agreed about Solder
[11:09:19] <pmuir> i am sorting jira now
[11:09:38] <stuartdouglas> Are you happy for me to push? I did not have permission on the old weldx repo
[11:10:19] <pmuir> just continue to send pull requests I think
[11:10:28] <pmuir> i'll do the same
[11:10:33] <pmuir> and we can merge the other persons...
[11:10:55] <stuartdouglas> ok
[11:15:29] *** adamw1pl has left #seam-dev
[11:15:37] *** adamw1pl has joined #seam-dev
[11:21:35] <pmuir> stuartdouglas: https://jira.jboss.org/browse/SOLDER
[11:22:18] <stuartdouglas> cool
[11:29:46] <stuartdouglas> I think there will always be some funkiness when you invoke virtual methods in the constructor
[11:30:16] <stuartdouglas> as the proxy constructor will call super()
[11:30:22] <stuartdouglas> which then calls the virtual method
[11:30:32] <stuartdouglas> which then delegates the call to the bean instance
[11:31:18] <stuartdouglas> Actually the proxy probably should not start delegating until after the constructor has finished
[11:52:23] <stuartdouglas> pmuir: adamw1pl: I have looked into those bugs, I should be able to fix them tomorrow
[11:52:37] <adamw1pl> great :)
[11:52:37] <adamw1pl> es
[11:52:46] <adamw1pl> esp the one with the constructor injection is a pain
[11:52:48] <stuartdouglas> I have to change the proxies so they don't start delegating until after the constructor has finished
[11:53:04] <adamw1pl> so when's beta3 out and will it work with CR1? ;)
[11:53:45] <stuartdouglas> maybe, thats more of a pmuir question
[11:53:52] <stuartdouglas> it depends if the SPI changes again
[12:16:57] *** antoine_sd has joined #seam-dev
[12:19:25] *** antoine_sd has left #seam-dev
[12:19:31] *** shervin_a has quit IRC
[12:52:14] *** jharting has joined #seam-dev
[13:03:05] *** jharting has quit IRC
[13:16:23] *** plenyi has joined #seam-dev
[13:19:52] *** pmuir has quit IRC
[13:30:14] *** pmuir has joined #seam-dev
[13:35:09] *** plenyi has quit IRC
[13:36:07] *** jharting has joined #seam-dev
[13:49:26] *** antoine_sd has joined #seam-dev
[14:06:55] *** antoine_sd has quit IRC
[14:08:26] *** antoine_sd has joined #seam-dev
[14:34:22] *** emmanuel has joined #seam-dev
[14:36:24] *** pmuir has quit IRC
[14:38:20] *** pmuir has joined #seam-dev
[15:32:54] *** tsurdilo has joined #seam-dev
[16:02:15] *** tsurdilo has quit IRC
[16:03:00] *** jharting has quit IRC
[16:04:04] *** tsurdilo has joined #seam-dev
[16:04:33] *** tsurdilo has quit IRC
[16:04:54] *** tsurdilo has joined #seam-dev
[16:05:54] *** maxandersen has quit IRC
[16:06:08] *** maxandersen has joined #seam-dev
[16:10:10] *** oskutka has quit IRC
[16:21:40] *** mbg has joined #seam-dev
[16:36:14] *** marekn has left #seam-dev
[16:40:33] *** lincolnthree has joined #seam-dev
[16:41:24] *** adamw1pl has quit IRC
[16:42:07] *** lincolnthree has quit IRC
[16:44:57] *** lincolnthree has joined #seam-dev
[17:26:44] *** maxandersen has quit IRC
[17:26:58] *** maxandersen has joined #seam-dev
[17:48:48] *** lightguard_jp has joined #seam-dev
[18:10:45] <pmuir> hopefully the spi will change ;-)_
[18:10:55] *** pmuir has quit IRC
[18:16:59] *** kpiwko has quit IRC
[18:17:18] *** kpiwko has joined #seam-dev
[18:21:29] *** kpiwko has quit IRC
[18:29:59] *** tsurdilo has quit IRC
[18:37:38] *** antoine_sd has quit IRC
[18:42:57] *** tsurdilo has joined #seam-dev
[18:46:46] *** bleathem has joined #seam-dev
[18:55:32] <lincolnthree> lightguard_jp: you have a logo
[18:55:32] <lincolnthree> http://seamframework.org/Seam3/CatchModule
[18:56:03] <lightguard_jp> lincolnthree: lol
[18:56:22] <lincolnthree> ?
[18:56:30] <lightguard_jp> Looks like they're all the same
[18:56:33] <lincolnthree> yep
[18:56:35] <lightguard_jp> bummer
[18:56:38] <lincolnthree> consistency :)
[18:56:47] <lightguard_jp> True
[19:30:29] *** emmanuel has quit IRC
[20:05:03] <lightguard_jp> Solder doesn't have all the same changes as weld extensions
[20:05:15] <lincolnthree> changes?
[20:05:20] <lightguard_jp> Looks like solder is older than extensions
[20:05:33] <lightguard_jp> https://github.com/weld/extensions/commit/63a26ce413478152483692cfd1d56b1da42d474f
[20:05:34] <jbossbot> git [extensions] 63a26ce.. LightGuard Adding a ForwardingInjectionPoint...
[20:05:36] <lightguard_jp> Isn't in Solder
[20:05:39] <lincolnthree> ah
[20:05:58] <lincolnthree> i'd file an issue for it in SOLDER
[20:06:05] <lincolnthree> it probably got missed
[20:06:16] <lincolnthree> SEAMSOLDER-1
[20:06:20] <lincolnthree> SOLDER-1
[20:06:21] <jbossbot> jira [SOLDER-1] ELResolver assumes flat deployment structure [Open, Major, Unassigned] https://jira.jboss.org/browse/SOLDER-1
[20:17:54] *** maxandersen has quit IRC
[21:18:20] *** antoine_sd has joined #seam-dev
[21:25:04] <lightguard_jp> lincolnthree: Looks like forge is on a roll over the past couple of days
[21:25:15] <lincolnthree> Yeah, thanks to mike
[21:25:21] <lincolnthree> he's been chugging while ive been on holiday
[21:25:24] <lincolnthree> :)
[21:28:54] <lightguard_jp> Looks like Dan has been busy with Catch stuff too
[21:43:44] *** Nik_ has joined #seam-dev
[22:09:42] *** Nik_ has quit IRC
[22:29:07] *** mojavelinux has joined #seam-dev
[22:31:37] *** antoine_sd has quit IRC
[22:48:30] <lightguard_jp> stuartdouglas: Are you there?
[23:12:20] *** bdlink has joined #seam-dev
[23:12:20] *** bdlink has quit IRC
[23:16:34] <lightguard_jp> mbg: or Nik: Is there a reason why Solder doesn't use the security manager for reflection operations like setting things accessible?
[23:19:21] <mbg> lightguard_jp: none that I can think of
[23:20:44] <mojavelinux> yeah, I think it's just an oversight
[23:21:11] <mojavelinux> Weld has a very nice approach to secure reflection access  that we can migrate into Solder
[23:29:23] <lightguard_jp> mojavelinux: That's the SecureReflections class?
[23:29:35] <mojavelinux> yep
[23:31:43] <lightguard_jp> Does it all boil down to SimpleProxyServices and ClassFileUtils that actually check and do the action?
[23:40:48] <lightguard_jp> I don't see access checks anywhere save SimpleProxyServices and ClassFileUtils
[23:43:27] <mojavelinux> what we really need are some tests that break when privileges are not granted...we are sort of just putting on extra padding and hoping for the best atm
[23:45:03] <lightguard_jp> It looks like it was there at one point, but not anymore





top