[00:01:42] *** jpav has quit IRC
[00:03:10] *** danflo has quit IRC
[00:04:59] *** danflo has joined #jbosstools
[00:09:23] *** danflo has quit IRC
[00:21:35] *** danflo has joined #jbosstools
[00:22:11] *** bfitzpat has quit IRC
[00:34:40] *** danflo has quit IRC
[00:59:59] *** rruss has joined #jbosstools
[01:00:25] *** tomwells has joined #jbosstools
[01:31:56] *** myarboro has quit IRC
[01:35:55] *** rruss has quit IRC
[01:48:54] *** ldimaggi has joined #jbosstools
[02:14:53] *** myarboro has joined #jbosstools
[02:39:23] *** rruss has joined #jbosstools
[02:46:23] *** myarboro has quit IRC
[02:58:04] *** Elisha has quit IRC
[02:58:10] *** Elisha has joined #jbosstools
[03:01:16] *** sflanigan has quit IRC
[03:01:44] *** sflanigan has joined #jbosstools
[03:12:34] *** rcernich has quit IRC
[03:13:19] *** rruss has quit IRC
[03:24:13] *** akazakov has quit IRC
[04:19:43] *** bgeorges has joined #jbosstools
[04:51:35] *** amitev2 has joined #jbosstools
[04:54:50] *** amitev has quit IRC
[05:23:26] *** rruss has joined #jbosstools
[05:43:16] *** ldimaggi has quit IRC
[06:08:19] *** jwulf has quit IRC
[08:10:53] *** koentsje has joined #jbosstools
[08:22:53] *** koentsje has quit IRC
[08:23:14] *** koentsje has joined #jbosstools
[08:34:09] *** jpeterka has joined #jbosstools
[08:49:22] *** jpeterka has quit IRC
[08:57:11] *** tomwells has quit IRC
[09:14:12] *** jpeterka has joined #jbosstools
[09:18:37] *** bgeorges has quit IRC
[09:23:32] *** psrna has joined #jbosstools
[09:23:56] *** adietisheim has joined #jbosstools
[09:23:56] *** ChanServ sets mode: +o adietisheim
[09:24:34] *** nicoulaj has joined #jbosstools
[09:33:26] *** amitev2 is now known as amitev
[09:42:31] *** rruss has quit IRC
[09:48:24] *** rruss has joined #jbosstools
[09:55:47] *** tfennelly has joined #jbosstools
[09:55:47] *** ChanServ sets mode: +o tfennelly
[09:57:35] *** lzoubek has joined #jbosstools
[09:57:35] *** ChanServ sets mode: +o lzoubek
[10:04:01] *** maxandersen has joined #jbosstools
[10:04:01] *** ChanServ sets mode: +o maxandersen
[10:04:13] <maxandersen> incredible - freenode let me login today!
[10:09:35] *** dmaliarevich has joined #jbosstools
[10:18:31] *** dpalmer has joined #jbosstools
[10:22:29] *** gbrown has joined #jbosstools
[10:24:45] *** mgoldmann has joined #jbosstools
[10:29:52] *** rruss has quit IRC
[11:03:38] <maxandersen> koentsje: nice colors! :)
[11:04:16] <koentsje> maxandersen: thx, they are supposedly the same as in the normal console...
[11:04:50] <maxandersen> koentsje: so how is this mapped/done ? ascii color codes or is it an ascii code mapped to a color ?
[11:05:17] *** fbricon has joined #jbosstools
[11:05:17] *** ChanServ sets mode: +o fbricon
[11:06:20] <fbricon> maxandersen:  shouldn't you change the chan's topic?
[11:06:53] <maxandersen> I guess I should now i'm actually on work ;) ?you do know you got op rights too ? :)
[11:07:02] <koentsje> maxandersen, they are ansi codes that the runtime sends; until now i disabled the colours when forge was started but i implemented a filter that is able to recognize these ansi codes and i map the proper ansi code to the eclipse colour
[11:07:08] 
[11:07:23] <fbricon> maxandersen: try again
[11:07:36] <maxandersen> fbricon: ?
[11:07:47] <fbricon> link is f* up
[11:07:50] <maxandersen> koentsje: does ascii color codes actually define a specific color ?
[11:08:09] <maxandersen> ah..
[11:08:20] 
[11:08:21] <koentsje> maxandersen, btw i needed this ansi filter to be able to solve your issue JBIDE-8912
[11:08:26] <jbott> Bug: [JBIDE-8912] forge console have bad editing [Open, Major, (forge), koen.aers] https://issues.jboss.org/browse/JBIDE-8912
[11:08:35] <koentsje> they are not ascii codes but ansi codes :)
[11:08:44] <maxandersen> koentsje: a double whammy ;)
[11:08:50] <koentsje> maxandersen, and yes they define a specific colour
[11:09:10] <maxandersen> koentsje: okey - so its RGB encoded or ?
[11:09:35] * maxandersen wonders since its years since ascii/ansi art was cool to do ;)
[11:09:52] <koentsje> maxandersen, no it's just code 30 is black, code 31 is red, etc
[11:10:26] <koentsje> maxandersen, i just used the SWT.COLOR_RED for 31 etc
[11:10:32] <maxandersen> koentsje: okey ;)
[11:18:26] *** kkhan has joined #jbosstools
[11:23:44] *** amitev2 has joined #jbosstools
[11:25:06] *** amitev has quit IRC
[12:14:46] <maxandersen> adietisheim: boing
[12:22:10] <maxandersen> adietisheim: how did it go with openshift express REST API ? sounded like there were mismatches between how it formatted its output and responses ?
[12:25:06] <adietisheim> maxandersen: pong
[12:25:31] <adietisheim> maxandersen: was actually false alarm. had errors in my test data I had copied over from a real request
[12:25:44] <adietisheim> maxandersen: but there are actually invalid json part being responded
[12:25:47] <adietisheim> maxandersen: in general
[12:26:06] <adietisheim> maxandersen: but I work around it by cleaning the json with regexp's before parsing. works fine
[12:26:12] <maxandersen> adietisheim: so dmr won't be able to parse it ?
[12:26:23] <maxandersen> adietisheim: sounds dirty.
[12:26:25] <adietisheim> maxandersen: if I dont 'sanitize' it wont, right
[12:26:30] <adietisheim> maxandersen: well, I have no other choice
[12:26:47] <maxandersen> adietisheim: so ruby and borwsers json parsers are more tolerant?
[12:26:48] <adietisheim> maxandersen: separated it into a single class so removing it once they fix should be easy
[12:27:01] <adietisheim> maxandersen: looks like they're more tolerant
[12:27:02] <maxandersen> adietisheim: did you talk to the openshift guys about it ?
[12:27:05] <adietisheim> maxandersen: yup
[12:27:15] <maxandersen> adietisheim: what did they say ?
[12:27:19] <adietisheim> maxandersen: jim jag actually confirmed and promised to fix
[12:27:50] <maxandersen> adietisheim: so how come they are actually able to generate invalid json ? thought libraries did that these days so hard to get wrong ;)
[12:28:03] <adietisheim> maxandersen: it's because they actually encode recursively and at some point a json object is wrapped into quotes and the quotes in it escaped
[12:28:48] <adietisheim> maxandersen: so I get something like this: "anObject" : "{ \"nestedProp\": }"
[12:28:54] <adietisheim> maxandersen: which is clearly invalid
[12:29:11] <adietisheim> maxandersen: should be "anObject" : { "nestedProp": ... }
[12:29:24] <adietisheim> maxandersen: json objects are never quoted, only strings and property-names are
[12:29:39] <adietisheim> maxandersen: the json spec is pretty much clear about it
[12:31:03] <maxandersen> adietisheim: but "weird string with \"strings\" in it " is ok ?
[12:31:07] <adietisheim> maxandersen: I clean it with the following class: http://anonsvn.jboss.org/repos/jbosstools/trunk/as/plugins/org.jboss.ide.eclipse.as.openshift.core/src/org/jboss/ide/eclipse/as/openshift/core/internal/response/JsonSanitizer.java
[12:31:17] <adietisheim> maxandersen: sure
[12:31:21] <adietisheim> maxandersen: since it's a string
[12:31:39] <adietisheim> maxandersen: but a json object ({ ... }) shall not quoted
[12:31:52] <maxandersen> adietisheim: okey - but that class will remove such quoting...
[12:31:57] <adietisheim> maxandersen:  and the properties in this json obj neither
[12:31:58] <maxandersen> fyi ;)
[12:32:08] <adietisheim> maxandersen: hum, that class?
[12:32:32] <adietisheim> maxandersen: ah
[12:32:35] <adietisheim> maxandersen: understood you
[12:32:37] <maxandersen> QUOTED_JSON_OBJECT_PATTERN in your JSonSanitizer
[12:32:40] <adietisheim> maxandersen: yup, right..
[12:32:46] <adietisheim> maxandersen: bug in my impl then$
[12:32:48] <maxandersen> matches \"blah\" no matter where it is.
[12:32:58] <maxandersen> no unit tests ?!!?!?! :) :)
[12:33:13] <adietisheim> maxandersen: sure there are a lot, but not testing this case
[12:33:50] <adietisheim> maxandersen: there are a lot: http://anonsvn.jboss.org/repos/jbosstools/trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/
[12:34:01] <adietisheim> maxandersen: but I dont test your case.. right
[12:34:23] <maxandersen> adietisheim: if the above is the only bug they got then expanding the RE to match the whole property/value pattern would work.
[12:34:45] <adietisheim> maxandersen: yup, right. good hint, thanks
[12:35:02] <maxandersen> anyway, just a cautious warning - not sure if it will actually ever occur.
[12:35:24] <maxandersen> but if its a user controlled string, i.e. the name/description of something then quotes happens ;)
[12:36:06] <adietisheim> maxandersen: yup, you're completely right. did not think at it
[12:36:38] <adietisheim> maxandersen: fix would is very easy indeed
[12:43:45] *** amitev2 is now known as amitev
[12:46:42] <adietisheim> maxandersen: hum, according to their bug they would report the value this way: '\"aStringWithA\\"Quote\"' which should become valid with my current regexp '"aStringWithA\"Quote"'. What would be sanitized incorrectly would be something they would (which they dont, since their bug is due to erroneous recursive marshalling) report invalidly: '\"aStringWithA\"Quote\"' -> ' "aStringWithA"Quote"'
[12:47:42] <maxandersen> adietisheim: if they do it that way then yes - hard part becomes if they fix this after we release ;)
[12:48:20] <adietisheim> maxandersen: true. hum, guess need some testing then so make sure I can handle both ways
[12:48:38] <maxandersen> adietisheim: if you only replaced quotes if you found the first match to be on property : \"?\" then you would be able to handle both.
[12:48:51] <adietisheim> maxandersen: true :)=
[12:49:25] <adietisheim> maxandersen: doing an issue
[12:49:31] <adietisheim> maxandersen: creating
[12:49:53] <maxandersen> adietisheim: :) I need to grab some food?.thinking about slides for jbug makes me hungry
[12:50:16] 
[12:57:49] <adietisheim> maxandersen: hum, still not sure, since the outer regexp would not match any longer if they fix.
[12:58:01] <adietisheim> maxandersen: but I created the issue and will verify + make a test
[12:58:05] <adietisheim> maxandersen: https://issues.jboss.org/browse/JBIDE-9748
[12:58:09] <jbott> Bug: [JBIDE-9748] Openshift service: JSonSanitizer should be able to handle valid json objects with escaped quotes [Open, Major, (JBossAS/Servers), adietish] https://issues.jboss.org/browse/JBIDE-9748
[12:58:12] *** vpakan has joined #jbosstools
[13:32:08] <adietisheim> maxandersen: added some tests for the sanitizer: it works with valid json with quotes in a string value :)
[13:32:45] <adietisheim> maxandersen: http://anonsvn.jboss.org/repos/jbosstools/trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/JsonSanitizerTest.java
[13:35:11] *** yradtsevich has joined #jbosstools
[13:35:11] *** ChanServ sets mode: +o yradtsevich
[13:40:33] *** koentsje has quit IRC
[13:40:40] *** rmartinelli has joined #jbosstools
[13:43:43] *** balunasj has joined #jbosstools
[14:11:24] *** maxandersen has quit IRC
[14:17:41] *** maxandersen has joined #jbosstools
[14:17:52] *** maxandersen has joined #jbosstools
[14:17:52] *** ChanServ sets mode: +o maxandersen
[14:24:50] *** danflo has joined #jbosstools
[14:26:52] *** ldimaggi has joined #jbosstools
[14:27:20] *** myarboro has joined #jbosstools
[14:41:17] * fbricon goes Office -> Train -> Home
[14:48:48] *** fbricon has quit IRC
[14:51:02] *** rruss has joined #jbosstools
[14:55:17] *** kkhan is now known as kabir_afk
[15:07:07] *** ldimaggi has quit IRC
[15:17:53] *** ldimaggi has joined #jbosstools
[15:19:42] *** ldimaggi has quit IRC
[15:19:58] *** ldimaggi has joined #jbosstools
[15:24:24] *** xcoulon has joined #jbosstools
[15:24:35] <xcoulon> hi everyone
[15:26:06] <maxandersen> heya xcoulon
[15:32:08] *** koentsje has joined #jbosstools
[15:33:00] *** ldimaggi has quit IRC
[15:40:37] *** ldimaggi has joined #jbosstools
[15:50:26] *** rcernich has joined #jbosstools
[15:50:27] *** bfitzpat has joined #jbosstools
[15:50:27] *** ChanServ sets mode: +o bfitzpat
[16:09:02] *** balunasj is now known as balunasj_mtg
[16:09:16] *** jpav has joined #jbosstools
[16:09:17] *** jpav has joined #jbosstools
[16:20:40] *** fbricon has joined #jbosstools
[16:20:40] *** ChanServ sets mode: +o fbricon
[16:54:51] * fbricon is Materializing JRE System Library [J2SE-1.5]
[16:55:16] <fbricon> only maxandersen can understand :-)
[16:55:30] <maxandersen> :)
[17:07:33] *** rruss has quit IRC
[17:17:00] *** dmaliarevich has quit IRC
[17:37:58] *** xcoulon has quit IRC
[17:46:17] *** ron has joined #jbosstools
[17:51:20] *** adietisheim has quit IRC
[17:52:53] *** lzoubek has left #jbosstools
[17:59:35] *** fbricon is now known as fbricon_out
[18:11:32] *** dpalmer has quit IRC
[18:12:18] *** ron has quit IRC
[18:13:34] *** dgolovin has joined #jbosstools
[18:13:34] *** ChanServ sets mode: +o dgolovin
[18:26:54] *** nicoulaj has quit IRC
[18:31:05] <maxandersen>  /join #forge
[18:31:36] *** tfennelly has quit IRC
[18:37:16] * fbricon_out almost got punched on the way home from kindergarten
[18:37:26] *** fbricon_out is now known as fbricon
[18:38:16] <fbricon> note to self : get the street name *before* calling the cops or they'll drop the call
[18:39:26] <maxandersen> fbricon: wtf?
[18:39:43] <maxandersen> fbricon: I tell you - france is a dangerous place ;)
[18:39:49] <fbricon> note to self: don't try to intervene on a domestic fight when you're with a kid
[18:40:44] <fbricon> maxandersen: a guy was mad at his wife, dragging her out of the car onto the concrete
[18:41:07] <fbricon> he didn't quite appreciate when I try to prevent him to hurt her
[18:41:13] <fbricon> *tried
[18:41:27] * maxandersen and his 15 or so classmates got chased through the streets of paris 20 years ago by a group of 30 or so group of "parisians" because we said we didnt want to pay them to walk on the sidewalk
[18:41:39] <fbricon> and he got a little mader when I tried to call the cops
[18:41:51] <maxandersen> fbricon: what was the end result?
[18:42:41] *** akazakov has joined #jbosstools
[18:42:58] *** ChanServ sets mode: +o akazakov
[18:46:54] <fbricon> maxandersen: the guys wanted to punch me, but the fact Zach was here, probably stopped him
[18:47:39] <fbricon> 2 other guys tried to stop him from hurting his wife.
[18:48:12] <fbricon> Since the cops dropped my call and the guys seemed to have the situation under control, I took my son away
[18:48:57] <fbricon> Lulu told me she saw the cops were at the scene later on
[18:50:04] * fbricon 's heart racing a bit
[18:50:10] *** tfennelly has joined #jbosstools
[18:50:11] *** ChanServ sets mode: +o tfennelly
[18:50:56] <maxandersen> fbricon: crazy stuff
[18:51:02] <fbricon> yeah
[18:51:17] *** psrna has quit IRC
[18:51:24] *** rruss has joined #jbosstools
[18:52:50] <fbricon> if I meet him on the kindergarten way next time, I think he'll want me to be his punching ball. He's bigger than me :-)
[18:53:21] *** jpeterka has quit IRC
[18:54:25] *** gbrown has quit IRC
[18:54:30] *** sflanigan has quit IRC
[19:09:07] *** sflanigan has joined #jbosstools
[19:33:28] *** bfitzpat is now known as bfitzpat_afk
[19:33:36] *** nicoulaj has joined #jbosstools
[19:33:44] *** akazakov has quit IRC
[19:38:28] *** gbrown has joined #jbosstools
[19:44:19] <nickboldt> maxandersen: https://issues.jboss.org/browse/JBIDE-9671 and https://issues.jboss.org/browse/JBIDE-9670 are both assigned to 3.3x stream. Isn't one for 3.2x and one for 3.3x?
[19:44:22] <jbott> Task: [JBIDE-9671] Set up a mirror for WTP SDK 3.2.5 integration build [Open, Blocker, (Build/Releng), nickboldt] https://issues.jboss.org/browse/JBIDE-9671
[19:44:23] <jbott> Task: [JBIDE-9670] Set up a mirror for WTP SDK 3.3.1 integration build [Open, Blocker, (Build/Releng), nickboldt] https://issues.jboss.org/browse/JBIDE-9670
[19:44:58] <nickboldt> and are we moving up to m2e-wtp 0.14 in BOTH branches? (cc: fbricon, bfitzpat_afk)
[19:45:09] *** nickboldt is now known as nickb_afk
[19:46:02] <fbricon> nickb_afk: yeah I should release 0.14.0 next week
[19:48:40] <maxandersen> nickb_afk: none of that is bound to jboss tools release builds afaics.
[19:48:46] *** balunasj_mtg has quit IRC
[19:53:58] *** vpakan has quit IRC
[19:56:06] *** gbrown has quit IRC
[20:03:16] *** nicoulaj has quit IRC
[20:49:28] *** ronr__ has joined #jbosstools
[20:50:41] *** ronr__ is now known as ron
[20:58:14] *** danflo has quit IRC
[20:59:19] *** danflo has joined #jbosstools
[21:02:06] *** mgoldmann has quit IRC
[21:15:02] *** dgolovin is now known as dgolovin-food
[21:22:55] *** mgoldmann has joined #jbosstools
[21:23:00] *** mgoldmann has joined #jbosstools
[21:43:31] *** akazakov has joined #jbosstools
[21:43:32] *** ChanServ sets mode: +o akazakov
[21:45:16] *** rcernich has quit IRC
[21:49:52] *** vpakan has joined #jbosstools
[21:50:54] *** maxandersen has quit IRC
[21:52:48] *** ron has quit IRC
[21:53:08] *** ronr__ has joined #jbosstools
[21:53:34] *** ronr__ is now known as ron
[22:09:20] *** vpakan has quit IRC
[22:10:39] *** ldimaggi has quit IRC
[22:17:42] *** rmartinelli has quit IRC
[22:22:57] *** mgoldmann_ has joined #jbosstools
[22:24:42] *** mgoldmann has quit IRC
[22:39:35] *** bfitzpat_afk is now known as bfitzpat
[22:58:42] *** koentsje has quit IRC
[23:05:41] *** irooskov has joined #jbosstools
[23:26:17] *** dgolovin-food is now known as dgolovin
[23:30:39] *** ron has quit IRC
[23:58:09] *** jpav_ has joined #jbosstools
[23:58:10] *** jpav_ has joined #jbosstools





top