[00:01:46] <ALR> 1.1.0-beta-1 would have no jee--api module at all.
[00:01:52] <ALR> That was introduced in 1.2.0-alpha-1
[00:02:02] <ALR> If you still have it in your workspace, "git clean -df"
[00:02:04] <ALR> mhuniewicz: ^
[00:15:12] <mhuniewicz> ALR, then I guess I need to change something in the dependencies to make WebAppDescriptor class available. Namely, add shrinkwrap-descriptors-impl. Is that OK?
[00:15:29] <ALR> mhuniewicz: Not to depend upon, not really.
[00:15:42] <ALR> mhuniewicz: Anything in impl is just prototype code not intended to be consumed.
[00:15:55] <mhuniewicz> ALR, depend with test scope?
[00:16:11] <ALR> Only if you're comfortable changing that code in your tests
[00:16:16] <ALR> Why not use 1.2.0-alpha-1?
[00:16:47] <ALR> (Which also isn't back-compat, but at least it's intended to be consumed in some fashion)
[00:17:01] <mhuniewicz> The thing is,
[00:17:14] <mhuniewicz> one of the tests needs this WebAppDescriptor class to be present.
[00:17:23] <mhuniewicz> And thats where it is, in impl
[00:19:55] <ALR> So the choice is yours.
[00:20:02] <ALR> But when you upgrade, you'll likely have to change stuff.
[00:20:09] <ALR> If it were me I'd use 1.2.0-alpha-1
[00:20:19] <ALR> And stay on top of the changes for that release series as we go.
[00:20:24] <mhuniewicz> But the Issue is all about making it beta.
[00:20:35] <ALR> Making what Beta?
[00:20:46] <mhuniewicz> The dependencies on descriptors.
[00:20:54] <ALR> Show me the issue?
[00:21:03] <ALR> That's a silly issue description.
[00:21:05] <mhuniewicz> SHRINKWRAP-333
[00:21:07] <jbossbot> jira [SHRINKWRAP-333] Upgrade extension-descriptors to use shrinkwrap-descriptors:1.1.0-beta-1 [Open (Unresolved) Task, Major, Michal Huniewicz] https://issues.jboss.org/browse/SHRINKWRAP-333
[00:22:35] <ALR> mhuniewicz: Updated.
[00:22:40] <ALR> I clarified it.
[00:22:51] <ALR> The issue is really about getting the real code into locked APIs and SPIs.
[00:23:05] <ALR> That it uses the WebAppDescriptor isn't really a requirement for the project
[00:23:36] <ALR> So any way you can assert that the extension module is working, either by making a mock Descriptor type and using that, or by using some generic Descriptor already in the API module, is fine.
[00:23:42] <ALR> SHRINKWRAP-333
[00:23:43] <jbossbot> jira [SHRINKWRAP-333] Upgrade extension-descriptors to use SPI back-compatible version [Open (Unresolved) Task, Major, Michal Huniewicz] https://issues.jboss.org/browse/SHRINKWRAP-333
[00:23:50] <mhuniewicz> Okay, I'll try the version you suggested.
[00:30:05] <mhuniewicz> Should it depend on api-base now?
[00:31:05] <mhuniewicz> ALR, ^
[00:38:54] *** rachmatowicz_ has quit IRC
[00:40:50] <ALR> mhuniewicz: yeah, on api-base
[00:41:09] <ALR> With a test dep on impl-base
[00:41:31] <ALR> Actually a provided dep on impl-base
[00:43:44] <mhuniewicz> ALR, impl-base of descriptors or shrinkwrap?
[00:43:54] <ALR> descriptors
[00:44:06] <mhuniewicz> It doesn't have that at the moment. Do we need that?
[00:44:06] <ALR> It should already have that dep on shrinkwrap
[00:44:28] <ALR> mhuniewicz: Run your tests and find out :)
[00:45:01] <mhuniewicz> ALR, I'll have to fix that WEbAppDescriptors problem first.
[00:45:05] <mhuniewicz> But that's for tomorrow.
[00:45:09] <ALR> Cool
[00:45:13] <mhuniewicz> Thanks for help. Nite! :)
[00:45:24] <ALR> Basically just remove that one and put in something else which asserts all is working :)
[00:45:26] <ALR> Night!
[00:45:37] *** mhuniewicz has quit IRC
[01:19:20] *** kevinpollet has quit IRC
[01:48:45] *** rachmatowicz has quit IRC
[01:55:23] *** rruss has joined #jbosstesting
[02:00:54] *** rruss has quit IRC
[02:15:11] *** ianbrandt has quit IRC
[02:38:41] *** jamezp is now known as jamezp_afk
[02:41:06] *** jeand has quit IRC
[03:59:50] *** stuartdouglas_ has joined #jbosstesting
[04:02:40] *** stuartdouglas has quit IRC
[04:02:41] *** stuartdouglas_ is now known as stuartdouglas
[04:04:41] *** jamezp_afk has quit IRC
[05:48:14] *** ALR has quit IRC
[05:54:07] *** ldimaggi has quit IRC
[07:03:15] *** oskutka has joined #jbosstesting
[07:05:27] *** oskutka has joined #jbosstesting
[07:15:31] *** oskutka has quit IRC
[07:15:54] *** oskutka has joined #jbosstesting
[07:25:33] *** oskutka has quit IRC
[08:22:45] *** maeste has joined #jbosstesting
[11:17:37] *** kevinpollet has joined #jbosstesting
[11:58:43] *** alesj has joined #jbosstesting
[12:10:38] *** alesj has quit IRC
[13:01:03] *** kevinpollet has quit IRC
[14:07:53] *** maeste has quit IRC
[14:33:20] *** kpiwko has joined #jbosstesting
[14:33:25] *** jeand has joined #jbosstesting
[14:34:31] *** kevinpollet has joined #jbosstesting
[16:03:13] *** jamezp has joined #jbosstesting
[16:03:46] *** jamezp is now known as jamezp_afk
[16:29:36] *** aslak_ has joined #jbosstesting
[16:43:21] *** kevinpollet has quit IRC
[17:10:11] *** aslak_ has quit IRC
[18:58:51] *** rbattenfeld has joined #jbosstesting
[18:58:59] *** rbattenfeld has left #jbosstesting
[21:15:50] *** rachmatowicz has joined #jbosstesting
[21:26:43] *** maeste has joined #jbosstesting
[21:38:02] *** kpiwko has quit IRC
[23:55:12] *** maeste has quit IRC





top