[00:02:23] *** oskutka has joined #jbosstesting [00:04:58] *** aslak has joined #jbosstesting [00:19:23] *** oskutka has quit IRC [00:20:16] *** aslak has quit IRC [00:21:37] *** mhuniewicz has quit IRC [00:31:51] *** aslak has joined #jbosstesting [00:39:43] <bmajsak> ALR: Do we have any conventions re naming of the tests? I thought we are sticking to "shouldXYZ", but now I see tests written in JUnit 3 manner -> testXYZ [00:41:08] *** ldimaggi has joined #jbosstesting [00:45:56] *** lfryc has joined #jbosstesting [01:02:56] *** aslak has quit IRC [01:04:28] *** oskutka has joined #jbosstesting [01:10:41] *** oskutka has quit IRC [01:11:53] *** oskutka has joined #jbosstesting [01:14:15] *** oskutka has quit IRC [01:15:14] *** oskutka has joined #jbosstesting [01:18:36] *** aslak has joined #jbosstesting [01:20:25] <ALR> bmajsak: I have no naming conventions really. So long as it's descriptive. And I usually don't use the "test" prefix [01:26:38] *** PeteRoyle has quit IRC [01:39:38] <ALR> bmajsak: Pull request, great [01:40:08] <bmajsak> ALR: SHRINKDESC-86 fixed. Tomorrow I will share my "findings" re generated descriptors in JIRA. Good night. [01:40:25] <ALR> bmajsak: Night! [01:40:35] <bmajsak> Again I messed with commit messages :) But at least my hook is working [01:40:44] <bmajsak> unfortunately not from eclipse ;) [01:45:59] <bmajsak> ALR: One more commit to this pull request in few minutes, so hold on for a sec [01:46:07] <ALR> bmajsak: Ah OK [01:46:56] <bmajsak> ALR: Just noticed that I commented out two tests for persistence descr. which should be executable [01:51:42] <bmajsak> ALR: Done [01:51:49] <ALR> bmajsak: k thanks [01:52:24] <bmajsak> I don't really feel comfortable with the new API. [01:53:10] <bmajsak> Ok, time for me. Cya tomorrow. [01:56:14] *** bmajsak has quit IRC [02:26:57] *** stuartdouglas has quit IRC [02:27:34] *** jamezp is now known as jamezp_afk [02:31:13] *** stuartdouglas has joined #jbosstesting [02:49:01] *** ldimaggi has quit IRC [02:49:56] *** ldimaggi has joined #jbosstesting [03:14:05] *** rachmatowicz_ has quit IRC [03:14:27] *** rachmatowicz has quit IRC [03:55:56] *** rruss has joined #jbosstesting [03:57:57] *** lfryc has quit IRC [04:18:24] *** PeteRoyle has joined #jbosstesting [04:27:10] *** rruss has quit IRC [04:28:14] *** jbossbot has joined #jbosstesting [04:42:11] *** ldimaggi has quit IRC [04:57:56] *** oskutka has quit IRC [04:58:21] *** oskutka has joined #jbosstesting [05:36:58] *** bgeorges has quit IRC [06:42:56] *** aslak has quit IRC [07:51:16] *** oskutka has joined #jbosstesting [07:53:58] *** oskutka has quit IRC [08:10:12] *** vnvarsete has quit IRC [08:10:27] *** vnvarsete has joined #jbosstesting [08:10:47] *** ALR has quit IRC [08:36:59] *** pilhuhn has joined #jbosstesting [08:36:59] *** pilhuhn has joined #jbosstesting [08:41:33] *** maschmid has joined #jbosstesting [08:46:05] *** kpiwko has joined #jbosstesting [08:48:28] *** ge0ffrey has joined #jbosstesting [08:55:43] *** kevinpollet has joined #jbosstesting [09:16:50] *** pil has joined #jbosstesting [09:20:43] *** pilhuhn has quit IRC [09:27:35] *** jeand_ has joined #jbosstesting [10:00:18] <vnvarsete> I have problems with jboss-classpool-ucl locally, version 1.0.0.Alpha6, anyone got input? [10:18:07] *** jhuska has joined #jbosstesting [10:20:04] *** jeand__ has joined #jbosstesting [10:24:04] *** jeand_ has quit IRC [10:37:58] <ge0ffrey> Is there any support for switching Identities in cdi injected unit tests? [10:41:55] <stuartdouglas> not really [10:49:23] *** maeste has joined #jbosstesting [10:58:36] <ge0ffrey> stuartdouglas: I 'd like the ability to annotate @TestUnderIdentity(...) on a test [10:59:26] <ge0ffrey> Is there a module to hold such "seam enriching for tests stuff" already? and where would I start to implement that? [10:59:55] <stuartdouglas> Which container? [11:00:04] <stuartdouglas> Are we talking identity as in EE security? [11:03:46] <ge0ffrey> as in seam-security [11:03:53] <ge0ffrey> so I guess it's an issue on seam-security? [11:04:02] <ge0ffrey> for a seam-security-test module or something [11:04:13] <ge0ffrey> for a seam-security-junit module or something [11:10:37] *** alesj has joined #jbosstesting [11:13:58] <ge0ffrey> stuartdouglas: https://issues.jboss.org/browse/SEAMSECURITY-104 [11:14:00] <jbossbot> jira [SEAMSECURITY-104] In user tests it should be easy to switch Identity for a single test method (or test class): @TestAsIdentity(username = "...") [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SEAMSECURITY-104 [11:15:03] *** aaronwalker has quit IRC [11:26:41] <stuartdouglas> ah [11:27:00] <stuartdouglas> that is easier [11:27:22] <stuartdouglas> I think you have to write an arquillian test enricher [11:27:31] <stuartdouglas> and just hook into seam security internals [11:27:33] *** alesj has quit IRC [11:44:23] <ge0ffrey> I wondering if I can't just add decorator on all my test methods instead: http://styledideas.be/blog/2011/08/04/java-ee6-decorators-advanced-usage/ [11:46:41] <stuartdouglas> ge0ffrey: decorators won't work on test methods [11:46:59] <ge0ffrey> isn't my test class being CDI'ed too? [11:47:09] <stuartdouglas> injected [11:47:10] <ge0ffrey> as I can do @Inject etc in them [11:47:19] <stuartdouglas> its not being turned into a CDI bean though [11:47:25] <ge0ffrey> ow :/ [11:47:34] <stuartdouglas> there are a couple of ways to odo this [11:47:51] <stuartdouglas> afaik testing and junit both provide hooks that you could use [11:48:03] <stuartdouglas> also I think ARQ itself might have a way [11:48:24] <ge0ffrey> is there any reason why arquillian's test enricher can 't give it the power of delegator's etc? so we only have to learn cdi? [11:49:09] <ge0ffrey> and so we can reuse the decorators outside tests [11:49:24] *** alesj has joined #jbosstesting [12:06:54] <stuartdouglas> it would be interceptors that you want, rather than decorators [12:07:00] <stuartdouglas> and I kinda doubt it [12:08:34] <ge0ffrey> yes, replace decorater by intercepter in all the above [12:09:33] *** alesj has quit IRC [12:22:13] *** alesj has joined #jbosstesting [12:29:57] *** alesj has quit IRC [12:38:40] *** ldimaggi has joined #jbosstesting [12:44:38] *** pil is now known as pil-lunch [12:52:05] *** kevinpollet has quit IRC [13:08:04] *** vtunka has joined #jbosstesting [13:10:57] <vnvarsete> Has anyone had problems with the issue I've created on the xnio dependency? https://issues.jboss.org/browse/XNIO-97 [13:10:59] <jbossbot> jira [XNIO-97] xnio-metadata-2.1.0.CR5 contains wrong version number in pom.xml [Open (Unresolved) Bug, Blocker, Unassigned] https://issues.jboss.org/browse/XNIO-97 [13:13:00] *** stuartdouglas has quit IRC [13:18:30] *** stuartdouglas has joined #jbosstesting [13:33:46] *** vtunka has quit IRC [13:34:06] *** vtunka has joined #jbosstesting [13:43:05] *** alesj has joined #jbosstesting [13:48:06] *** maeste has quit IRC [13:50:21] *** alesj has quit IRC [13:50:31] *** kevinpollet has joined #jbosstesting [14:02:00] *** aslak has joined #jbosstesting [14:07:59] *** pil-lunch is now known as pilhuhn [14:10:07] *** aslak has quit IRC [14:23:40] *** aslak has joined #jbosstesting [14:37:09] <jose_freitas> hey aslak, good morning [14:37:19] <aslak> jose_freitas, good morning [14:38:08] <jose_freitas> do you know this error on a managed AS6 http://pastebin.com/Ykxdr8qF ? [14:38:29] <jose_freitas> it does not happen on remote [14:38:51] <jose_freitas> and the stacktrace isn't very clear [14:39:07] <jose_freitas> when executing the error test through ide [14:39:08] <jose_freitas> http://pastebin.com/yxjbaz0U [14:39:17] <aslak> not sure, but my first guess is a client <-> server library conflict [14:39:25] <aslak> e.g. client for 6.1 and server 6.0 or similar [14:39:34] <jose_freitas> hm [14:39:55] <aslak> the ide one is a missing jmx lib [14:40:04] <jose_freitas> it doesn't happen for all tests too [14:40:08] <aslak> jose_freitas, you using the profile client and not the full client ? [14:40:13] <jose_freitas> just for some of them [14:40:16] <jose_freitas> yes [14:40:19] <jose_freitas> profile client [14:40:31] <aslak> yea, there is one more jar you need [14:40:34] <aslak> or two [14:41:19] <jose_freitas> hmm [14:41:40] <aslak> you have jboss-deployers-client-spi? [14:42:24] <jose_freitas> nop [14:42:38] <jose_freitas> jboss-server-manager, jboss-as-profileservice-client and arquillian-jbossas-managed-6 [14:43:13] <aslak> jose_freitas, http://community.jboss.org/message/586273#586273 [14:43:38] <aslak> the jmx-invoker thinggy is what you need to fix the AfterSuite issue [14:44:13] *** aaronwalker has joined #jbosstesting [14:45:08] <jose_freitas> hmm [14:46:54] <jose_freitas> lemme try it [14:47:08] <jose_freitas> weird thing that it worked for other tests [14:47:48] <aslak> it's probably masking another error [14:49:12] *** jeand__ has quit IRC [14:50:23] <jose_freitas> at first I was thinking that it could be a request timeout or something like that. [14:54:32] *** vtunka has quit IRC [14:56:02] *** oskutka has joined #jbosstesting [14:57:17] <vnvarsete> aslak: TIme to answer http://community.jboss.org/thread/172321?tstart=0 ? [14:58:14] <aslak> vnvarsete, it's in the Embedded 6.0 Maven example in doc [14:58:15] <aslak> https://docs.jboss.org/author/display/ARQ/JBoss+AS+6.0+-+Embedded [14:59:48] <vnvarsete> aslak: Ah, so *hardcode* the path there.. [15:00:37] <aslak> hardcode or pull in in from env or command line or what ever you want [15:03:08] <vnvarsete> aslak: I got it, hadn't looked into what the plugin was doing before, so it was quite obvious what to do/change once I looked at it:) [15:04:01] <vnvarsete> aslak: Btw, the example from the wiki is missing the version number on the maven-surefire-plugin, makes the maven 3.x scream about the mission version element:) [15:08:11] *** ldimaggi has quit IRC [15:08:26] <aslak> vnvarsete, sure.. it assumes you have that controlled else where.. :) [15:08:53] <vnvarsete> :) [15:10:15] <maschmid> aslak: hello, I have a question about arquillian-jacoco extension... if I want to get coverage data also from classes in jars packed in a war, I'll have to modify the ApplicationArchiveInstrumenter to also wrap classes inside ArchiveAssets, right? [15:10:28] <vnvarsete> aslak: Arquillian is creating a folder called ${env.JBOSS_HOME}, what's it used for? It sure shouldn't be under version control, but why isn't it generated in the target directory if it's used temporarily? [15:12:22] <aslak> vnvarsete, you provide the runtime, arq only works with it.. [15:13:28] <aslak> if you want to extract it as part of the build, see example: https://github.com/arquillian/arquillian-core/blob/master/examples/junit/pom.xml#L361 [15:13:45] <aslak> maschmid, yea, that sounds about right [15:14:31] <maschmid> aslak: is there any reason why it should't behave like that by default? (except that it isn't implemented yet) [15:14:48] <aslak> maschmid, ... not implemented yet .. [15:14:48] <aslak> :) [15:14:49] <vnvarsete> aslak: Well, the folder only contains a boot.log. Who says that it should be in my root folder of the project? Could I rather redirect it to target? [15:15:24] <aslak> vnvarsete, sounds like the you have something wrong in your pom config [15:15:58] <maschmid> aslak: I'll try to do that then, thanks! :) [15:16:06] <aslak> vnvarsete, check gthe arg line [15:16:16] <aslak> maschmid, cool :) [15:16:53] <vnvarsete> aslak: <argLine>-Xmx512m -XX:MaxPermSize=256m -Djava.net.preferIPv4Stack=true -Djava.util.logging.manager=org.jboss.logmanager.LogManager -Djava.endorsed.dirs=${tt.user.jboss6.home}/lib/endorsed -Djboss.home=${tt.user.jboss6.home} -Djboss.boot.server.log.dir=${tt.user.jboss6.home}</argLine> [15:17:14] <vnvarsete> aslak: I replace the env.JBOSS_HOME with a reference I have in my pom.xml file to where JBoss 6.0.0.Final is installed [15:17:29] <aslak> does tt.... resolve ? [15:17:53] <vnvarsete> good question. Think so, the server starts [15:17:58] <aslak> hmm [15:25:27] *** vnvarsete has quit IRC [15:38:42] *** alesj has joined #jbosstesting [15:46:31] *** vtunka has joined #jbosstesting [15:48:34] *** alesj has quit IRC [15:55:06] *** aaronwalker has quit IRC [15:57:03] *** rachmatowicz has joined #jbosstesting [15:59:01] *** ALR has joined #jbosstesting [16:12:39] *** maeste has joined #jbosstesting [16:20:19] <kpiwko> ALR, good afternoon [16:20:34] <ALR> kpiwko: Hiya [16:20:59] <kpiwko> hi ALR, any chance to see https://github.com/shrinkwrap/shrinkwrap-container-tomcat-60 updated to align shrinwrap version in arquillian CR5? [16:21:21] <ALR> Sure. [16:21:32] <ALR> Should already be in a back-compat version though, why the upgrade needed? [16:22:10] <ALR> Some bug fix you're running into? Or new API feature to take advantage of? [16:22:15] <ALR> kpiwko: ^ [16:22:34] <kpiwko> ALR: I'm having bugs while trying to compile ar-container-tomcat [16:22:53] <ALR> kpiwko: A compile problem? That shouldn't be. What is it? [16:23:23] <kpiwko> ALR: errors like http://pastebin.com/geC2f8AW [16:23:47] <ALR> Oh, that's not a compile error. [16:23:49] <ALR> That's runtime. [16:24:02] <kpiwko> ALR: right, you got me there [16:24:07] <ALR> And it stems from ShrinkWrap Descriptors, not ShrinkWrap proper. [16:24:18] <aslak> kpiwko, you running of tomcat master ? [16:24:35] <kpiwko> ALR: nope, I've done some modifications there [16:24:44] <ALR> kpiwko: That should have been upgraded though [16:24:48] <ALR> At line 44. [16:25:08] <aslak> kpiwko, right, your missing some commits that pulls in the swd stuff after arq no longer expose them trasitivly [16:25:19] <ALR> My thoughts too. [16:25:29] <aslak> kpiwko, rebase from master [16:25:41] <kpiwko> ALR, aslak, let me check, I'm using jhuska branch [16:26:01] <ALR> kpiwko: General recommendation: don't do branches of branches. [16:26:18] <ALR> If you can, everyone should do a topic branch on the upstream and sync up there. [16:26:25] <aslak> kpiwko, https://github.com/arquillian/arquillian-container-tomcat/commit/8a99943bd9163f28e141a8b51fbe4b4ae2baa517 [16:26:26] <jbossbot> git [arquillian-container-tomcat] 8a99943.. Aslak Knutsen ARQ-514 Add test scoped dependency on shrinkwrap-descriptors-impl, no longer come in transitive from Arquillian Core [16:26:28] <jbossbot> jira [ARQ-514] Remove all compile-time dependencies upon ShrinkWrap Descriptors Impl Module [Closed (Done) Task, Blocker, Andrew Rubinger] https://issues.jboss.org/browse/ARQ-514 [16:26:32] <ALR> And someone should be in charge of rebasing the upstream/topic off upstream/master [16:26:42] <ALR> So you can avoid merge problems later. [16:28:20] <kpiwko> aslak, I don't see what's wrong...my head is pointing to https://github.com/arquillian/arquillian-container-tomcat/commit/f68874b2715990f6e28c1f7c3130e04a942912b0, having actual master [16:28:20] <jbossbot> git [arquillian-container-tomcat] f68874b.. Aslak Knutsen ARQ-587 Need to use web.xml v 3.0 for Servlet 3.0 Protocol to work. In 2.5 web.xml mode the web-fragment used by the Protocol is not picked up.... [16:28:21] <jbossbot> jira [ARQ-587] Add a Tomcat managed 7 container [Resolved (Done) Feature Request, Major, Juraj Huska] https://issues.jboss.org/browse/ARQ-587 [16:29:36] <kpiwko> I asked Jura to rebase his branch against upstream/master before I started and it seems to be done correctly [16:35:17] <kpiwko> aslak: arquillian 1.0.0.Final-SNAPSHOT does not use backward compatible release of SW, correct? because when I downgraded arq-core dependency to CR5, the problem disappears [16:36:29] <kpiwko> *disappeared [16:41:12] *** vtunka has quit IRC [16:44:52] <ALR> kpiwko: Yes, ARQ in upstream/master should be using a back-compat release of SW [16:45:01] <ALR> ie. 1.0.0-beta level [16:46:15] <kpiwko> ALR: so it's likely some inconsitency in my local repository [16:46:57] <ALR> kpiwko: Unless you show me another problem which shouldn't be present. [16:47:15] <kpiwko> ALR: yep...thanks for debugging my problems ;) [16:48:20] <ALR> kpiwko: Sure. :) [16:49:02] <aslak> kpiwko, Final SNAPSHOT == CR5 [16:49:25] <kpiwko> aslak: right, I just checked the git log [17:14:45] *** ldimaggi has joined #jbosstesting [17:21:38] *** jamezp_afk is now known as jamezp [17:29:56] *** mbg has joined #jbosstesting [17:32:07] <maschmid> aslak: https://github.com/arquillian/arquillian-extension-jacoco/pull/1 I couldn't find a way to do it without depending on shrinkwrap-impl-base ... I am not familiar with the shrinkwrap api, so I could be missing something... [17:49:58] <ALR> maschmid: Hehe, what can I help with? [17:50:08] <ALR> No compile deps on shrinkwrap-impl-base please :) [17:50:14] <ALR> Those internals are not back-compat [17:50:24] <aslak> ALR, maschmid , yea.. .... [17:50:58] <aslak> ALR, it's the how to get Archive out discussion.. basically the same issue we had withthe VERBOSE_VERBOSE formatter [17:51:42] <aslak> getAsType(GenericArchive, ArhcivePath) should hide ArchiveAsset.. [17:52:01] <aslak> but.. you don't know what is a archive and not [17:52:04] <ALR> aslak: Right. [17:52:10] <ALR> And there's no way to know that. [17:52:16] <ALR> Is knowing it absolutely necessary? [17:52:36] <aslak> well you can try to get every Node in the Archive in a try catch.. but [17:52:50] * ALR pukes [17:53:22] <maschmid> ALR: having an ArchiveAsset interface in api would help :) [17:53:38] <aslak> Asset instanceOf ArchiveAsset is the only option atm as far as i can see [17:54:16] <aslak> ALR, do you remember why some of the Assets were left in impl? ArchiveAsset and ClassLoaderAsset [17:54:31] <ALR> Yeah, so that people didn't use them. [17:54:32] <ALR> :) [17:54:57] <aslak> why not? [17:55:08] <aslak> i can use all the others.. why are ArchiveAsset different [17:55:23] <ALR> I know, I'm looking. [17:55:35] <ALR> I think basically the reasoning was just that we had no use case for it, [17:55:39] <ALR> But it looks like we do. [17:56:00] <ALR> So long as you understand that the instanceof check for ArchiveAsset may not show all possible archives. [17:56:07] <ALR> For instance a ZIP that was added as a File. [17:56:10] <aslak> unless we have another option to handle it. instanceof is never a good solution [17:56:33] <ALR> The other option is to add a flag denoting if the Node is archive content [17:56:41] <ALR> But I think that pollutes things worse. [18:00:37] <ALR> maschmid: Do you wanna do a patch to move ArchiveAsset to API? [18:01:11] <ALR> And as a separate issue we can move ClassLoaderAssert [18:01:18] *** kpiwko has quit IRC [18:01:48] *** kevinpollet has quit IRC [18:02:38] <maschmid> ALR: ok [18:02:48] *** maeste has quit IRC [18:04:09] <ALR> maschmid: SHRINKWRAP-331 [18:04:10] <jbossbot> jira [SHRINKWRAP-331] Add ArchiveAsset to the API [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKWRAP-331 [18:05:15] <ALR> SHRINKWRAP-332 [18:05:16] <jbossbot> jira [SHRINKWRAP-332] Add ClassLoaderAsset to the API [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKWRAP-332 [18:12:06] *** pilhuhn is now known as pil-dinner [18:18:24] *** rruss has joined #jbosstesting [18:21:48] *** rruss has quit IRC [18:34:51] *** kevinpollet has joined #jbosstesting [18:35:04] *** kevinpollet has quit IRC [18:55:28] *** rbattenfeld has joined #jbosstesting [18:55:47] <maschmid> ALR: should the ClassAsset be moved as well? [18:56:27] <ALR> maschmid: Yeah, sure. Wanna open a new issue for it? [18:56:40] <ALR> Also associated tests should move alongside the assets. For instance https://github.com/maschmid/shrinkwrap/blob/master/impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/asset/ClassAssetTestCase.java [18:57:03] <maschmid> no, I'll add it to the 332 [18:58:17] <maschmid> the tests would have to be moved in one go anyway [18:59:26] <rbattenfeld> ALR: Hi Andrew, SHRINKDESC-93/94 are the next descriptors, we should support? SHRINKDESC-91/92 ? [18:59:27] <jbossbot> jira [SHRINKDESC-93] Support jboss-web.xml [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKDESC-93 [18:59:28] <jbossbot> jira [SHRINKDESC-91] Support Java Connector Architecture 1.0 [Open (Unresolved) Task, Major, Jesper Pedersen] https://issues.jboss.org/browse/SHRINKDESC-91 [19:00:01] <ALR> maschmid: OK, but update 322 to reflect we're moving more, k? :) [19:00:17] <ALR> rbattenfeld: Hiya. I thinnk 93/94 first [19:00:26] <ALR> rbattenfeld: JCA 1.0 stuff is DTD-based [19:00:37] <ALR> SHRINKDESC-92 [19:00:38] <jbossbot> jira [SHRINKDESC-92] Create tool for XSD->Java generator [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKDESC-92 [19:00:49] <ALR> Though 92 is a great issue. [19:01:01] <rbattenfeld> ALR: Really? [19:01:02] <ALR> Because it'll let consumers generate their own stuff. [19:01:09] <ALR> rbattenfeld: Really which part? [19:01:32] <rbattenfeld> ALR: SHRINKDESC-92 [19:01:33] <jbossbot> jira [SHRINKDESC-92] Create tool for XSD->Java generator [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKDESC-92 [19:01:58] <ALR> rbattenfeld: Really it's a great issue? [19:02:42] <rbattenfeld> ALR: It is only possible when the metadata.xsl is refactored for supporting all xsd out of the box [19:03:00] <ALR> rbattenfeld: Right. [19:03:10] <rbattenfeld> ALR: I am thinking about this. It is possible [19:03:30] <ALR> rbattenfeld: Not to scare you, but we've had talks about possibly moving off XSLT :) [19:03:41] <ALR> But let's curb that discussion for awhile. [19:04:09] <ALR> So for now the easier issues are 93 and 94 [19:04:35] <rbattenfeld> ALR: ok. So, I will concentrate on SHRINKDESC-93/94. Is it urgent? [19:04:36] <jbossbot> jira [SHRINKDESC-93] Support jboss-web.xml [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/SHRINKDESC-93 [19:04:55] <ALR> Urgent no. [19:05:52] <rbattenfeld> ALR: cool. I think in a week I can provide these descriptors. [19:06:01] <ALR> Sure great [19:06:07] <ALR> And if you can't just let us know. [19:06:16] <ALR> If you wanna lay claim to 'em assign 'em to yourself. [19:06:18] <ALR> YOu know the drill. [19:06:19] <ALR> :) [19:06:31] *** maschmid has quit IRC [19:06:41] <rbattenfeld> ALR: I will. Yes, I know the drill:-) [19:09:19] <rbattenfeld> ALR: See you maybe tomorrow [19:09:32] <ALR> Sweet :) [19:09:58] <rbattenfeld> bye to everyone [19:10:10] *** rbattenfeld has left #jbosstesting [19:16:44] *** rruss has joined #jbosstesting [19:17:23] *** oskutka1 has joined #jbosstesting [19:17:39] *** mbg1 has joined #jbosstesting [19:17:48] *** oskutka has quit IRC [19:18:57] *** aslak has quit IRC [19:19:00] *** mbg has quit IRC [19:26:05] *** rruss has quit IRC [19:31:31] *** aslak has joined #jbosstesting [19:46:12] *** jhuska has quit IRC [19:49:08] *** mhuniewicz has joined #jbosstesting [19:49:24] <mhuniewicz> ALR, hi [19:49:32] <ALR> mhuniewicz: Yo. [19:49:45] <mhuniewicz> The thing I programmed looks OK. You wanna take a look? [19:50:06] <ALR> mhuniewicz: Sure, if you're satisfied just issue a pull request [19:50:17] <mhuniewicz> I wanted you to take a look before I do. [19:50:30] <ALR> It's OK. [19:50:41] <ALR> If I have feedback the pull request form is a good way to discuss the code. [19:50:50] *** rruss has joined #jbosstesting [19:51:03] <ALR> And then it'll keep other commits you make to the same branch as part of the same reqeust [19:51:51] <mhuniewicz> ALR, I understand. Done. [19:51:59] <ALR> Got it. One sec [19:57:44] <ALR> mhuniewicz: Would you please fill out the CLA at cla.jboss.org ? [19:58:40] <mhuniewicz> ALR, what's that? [19:59:04] <ALR> mhuniewicz: Contributor's Licensing Agreement. [19:59:18] <ALR> Basically states that you want to give us code and that we haven't stolen it from you. [19:59:21] <ALR> It's a legal thing. [20:00:03] <ALR> Easy process. Basically you just log in w/ your JBoss ID and pick the ShrinkWrap Project after approving some boilerplate legal text. [20:00:40] <mhuniewicz> ALR, okie dokes. [20:03:00] <ALR> mhuniewicz: And thank you for your contribution :) [20:03:03] <ALR> Upstream. [20:03:06] <ALR> You're famous. [20:03:32] <mhuniewicz> ALR, thanks. [20:03:37] <ALR> mhuniewicz: https://github.com/shrinkwrap/descriptors/commit/b12a8c83ce3ea886d7220a0fcf44af2f0ec85746 [20:03:37] <jbossbot> git [descriptors] b12a8c8.. Michal Huniewicz SHRINKDESC-51: Allow for escaping slashes in node queries. [20:03:39] <jbossbot> jira [SHRINKDESC-51] Using unescaped special query characters when doing a node query with text causes errors [Resolved (Done) Bug, Major, Michal Huniewicz] https://issues.jboss.org/browse/SHRINKDESC-51 [20:03:44] <mhuniewicz> I think I can hear chicks screaming my name outside. [20:03:49] <jose_freitas> hahaha [20:03:56] <ALR> mhuniewicz: Sounds like delusion has set in. [20:06:15] <mhuniewicz> ALR, it says I will receive an email when someone accepts the CLA thing. [20:06:22] <ALR> mhuniewicz: I approved you. [20:06:28] <mhuniewicz> Oh okay. [20:06:30] <ALR> It's gone up the chain to the JBoss Community Manager. [20:06:43] <ALR> When he next reviews the queue he'll finalize the process. [20:06:47] <mhuniewicz> Thanks! [20:06:49] <ALR> N/P [20:07:15] <ALR> mhuniewicz: Also I've added you to the "Developer" group for the SHRINKWRAP project [20:07:22] <mhuniewicz> Awesome [20:07:23] <ALR> So you can now assign those issues to yourself. [20:07:24] <mhuniewicz> :) [20:07:38] <ALR> Excuse me, for SHRINKDESC I mean [20:07:47] <ALR> Though I can add you to SHRINKWRAP too if you want [20:10:35] <mhuniewicz> Sure, why not. [20:12:35] *** ge0ffrey has quit IRC [20:13:46] <mhuniewicz> aslak, ping [20:15:38] <ALR> mhuniewicz: SHRINKWRAP-333 ? [20:15:39] <jbossbot> jira [SHRINKWRAP-333] Upgrade extension-descriptors to use shrinkwrap-descriptors:1.1.0-beta-1 [Open (Unresolved) Task, Major, Unassigned] https://issues.jboss.org/browse/SHRINKWRAP-333 [20:16:06] <ALR> mhuniewicz: That issue is to go into shrinkwrap/extension-descriptors/pom.xml, do the upgrade, then refactor the source and tests to match. [20:16:31] <ALR> mhuniewicz: If you want it, just assign it to yourself. [20:16:51] * ALR brb [20:16:57] <mhuniewicz> ALR, sure. [20:17:15] <mhuniewicz> Cheers. [20:19:46] *** rruss1 has joined #jbosstesting [20:19:46] *** rruss has quit IRC [20:30:03] *** bmajsak has joined #jbosstesting [20:30:17] <bmajsak> Hi all [20:32:02] <bmajsak> ALR: I just read about this CLA thing in the logs. I guess I haven't signed it yet. Will do once I get back home from work. That was long and hard day... :-) [20:36:29] <jose_freitas> ALR: what's the side 8 of the high octane development? [20:36:49] <ALR> bmajsak: Ah yes, we need you in there too! [20:36:55] <ALR> jose_freitas: Side 8? [20:36:57] <jose_freitas> I was rewatching your webinar looking for it and didn't find. [20:37:04] <ALR> There's 8? [20:37:07] <ALR> Shouldn't there be 7? [20:37:11] <ALR> As in "AS7" [20:37:50] <jose_freitas> hm [20:38:07] <jose_freitas> octo cames from 8 [20:38:28] <jose_freitas> that's why I got confused [20:41:34] <bmajsak> ALR: regarding SHRINKDESC-86 and my pull request - have you seen my comment there? [20:41:36] <jbossbot> jira [SHRINKDESC-86] Version and Schema Location are not supported for all Descriptors [Pull Request Sent (Unresolved) Bug, Major, Bartosz Majsak] https://issues.jboss.org/browse/SHRINKDESC-86 [20:42:05] <ALR> bmajsak: Hm, this went upstream [20:42:19] <ALR> But I meant to ask you if you considered the issue done [20:43:08] <ALR> jose_freitas: "Octo" is 8, yes. "Octane" however is the active ingredient in gasoline. [20:43:24] <bmajsak> ALR: I think it is according to the description :-) [20:43:50] <ALR> bmajsak: Fantasic, I'll close the pull request and resolve the issue [20:44:47] <jose_freitas> ALR: yeah, I guess octane is a chemical formula that has 8 carbon atoms. I linked to that concept and forgot about the gasoline. [20:44:58] <ALR> :) [20:45:08] <bmajsak> I will share my thoughts on the forum regarding new, generated API, as I mentioned yesterday. [20:45:18] <ALR> Yeah, we were a couple of metaphors deep. [20:45:22] <jose_freitas> heheh [20:45:34] <ALR> bmajsak: Fantastic, will look out for that. [20:46:07] <bmajsak> I'm still clueless what you are talking about ;-) [20:46:37] <bmajsak> I mean the context [20:46:48] <jose_freitas> octane context bmajsak? [20:46:53] <jose_freitas> http://vimeo.com/28055516 [20:47:09] *** mbg has joined #jbosstesting [20:47:20] *** mbg has quit IRC [20:47:21] *** mbg has joined #jbosstesting [20:47:25] *** mbg1 has quit IRC [20:48:07] <bmajsak> jose_freitas: thx. I will have a look :-) [20:49:28] *** aslak has quit IRC [20:49:33] *** mbg has quit IRC [20:49:38] *** rruss1 has quit IRC [20:49:43] *** oskutka1 has quit IRC [20:50:35] *** oskutka has joined #jbosstesting [20:50:38] *** rruss has joined #jbosstesting [20:50:42] <ALR> bmajsak: Yeah, we did a webinar for the JBoss Developer Series called "High Octane Development", which was meant to mean: "High-powered" [20:50:49] <ALR> rruss: Ping. [20:53:07] <bmajsak> I still need to catch up with a lot of sessions... This "to watch" list is freaking me out [20:54:18] <ALR> Hehe [20:54:38] *** mbg has joined #jbosstesting [20:55:16] <bmajsak> Luckily video works on android so I can watch javazone :-) [20:55:31] <bmajsak> *vimeo [20:57:09] <bmajsak> OK, I'm off for a while. Have a nice afternoon/evening/whatever ;-) [20:57:14] <jose_freitas> you too [20:57:16] <bmajsak> Cya [20:57:17] *** mbg has quit IRC [20:58:42] *** rruss has quit IRC [21:02:31] *** jamezp is now known as jamezp_afk [21:09:10] *** bmajsak has quit IRC [21:09:57] *** oskutka has quit IRC [21:11:29] *** aslak has joined #jbosstesting [21:11:29] *** aslak has quit IRC [21:11:29] *** aslak has joined #jbosstesting [21:13:40] <mhuniewicz> aslak, ping [21:15:54] *** mbg has joined #jbosstesting [21:18:50] *** mbg has quit IRC [21:20:19] <aslak> mhuniewicz, pong [21:20:29] *** mbg has joined #jbosstesting [21:20:44] <mhuniewicz> aslak, did you have a chance to look at that old @PersistenceContext stuff? [21:22:50] *** jamezp_afk has quit IRC [21:22:50] *** mbg has quit IRC [21:23:20] *** jamezp_afk has joined #jbosstesting [21:24:00] *** oskutka has joined #jbosstesting [21:25:05] <aslak> mhuniewicz, yea, two things that came up [21:25:50] *** mbg has joined #jbosstesting [21:25:50] *** mbg has quit IRC [21:26:57] <aslak> mhuniewicz, InjectOpenJPA is the latest btw? or just dep changes ? [21:28:05] <aslak> looks like it.. it has the persistenceUnit implemented as well [21:28:27] <aslak> then only 1 thing [21:28:28] <aslak> :) [21:28:41] <aslak> mhuniewicz, i think we should add a configuration option to turn this feature on [21:28:48] <aslak> https://github.com/m1key/arquillian-container-weld/blob/InjectPcOpenJpa/weld-ee-embedded-1.1/src/main/java/org/jboss/arquillian/container/weld/ee/embedded_1_1/WeldEEMockConfiguration.java [21:29:13] <aslak> something like, enableEntityManagerCreation [21:29:35] <mhuniewicz> aslak, what sets it? [21:29:43] <aslak> user in arq.xml [21:30:55] <aslak> and we still have the persistence.xml location issue right ? [21:30:55] <aslak> it will find the one in META-INF wheter you like it or not ? [21:31:22] <mhuniewicz> I can't remember... Possibly. [21:34:41] <mhuniewicz> aslak, should I focus on configuration switch then? [21:35:37] <aslak> mhuniewicz, yea add the config option, and verify that the META-INF folder is not leaking in [21:35:38] <aslak> and i think we should be good to go [21:36:30] <mhuniewicz> aslak, should I then add something to WeldEEMockConfiguration? Not sure how to go about it. [21:37:48] <aslak> mhuniewicz, yea, just add a boolean there, the rest is handled in the respect of reading it in [21:38:22] <aslak> mhuniewicz, then 'somehow' enable / disable the jpa resolving [21:38:52] <mhuniewicz> aslak, is there a standard way of using this configuration? [21:39:54] <aslak> it is passed into the DeployableContainer.setup() [21:41:18] <mhuniewicz> I mean, in my code, should I inject somehow that WeldEEMockConfiguration and ask it every single time? [21:44:16] *** mbg has joined #jbosstesting [21:44:16] *** mbg has quit IRC [21:45:56] *** rruss has joined #jbosstesting [21:46:26] <aslak> mhuniewicz, aa.. well, i would say when you create the WeldContainer, register a different service if this is enabled or not [21:47:42] *** mbg has joined #jbosstesting [21:49:11] <mhuniewicz> aslak, ideally yes, but the services are created in BeanDeploymentArchiveImpl which has no access to configuration. [21:50:37] *** aslak has quit IRC [21:51:32] *** mbg has quit IRC [21:56:36] *** jamezp_afk is now known as jamezp [22:01:29] *** oskutka has quit IRC [22:04:06] *** rruss has quit IRC [22:06:40] *** jamezp has quit IRC [22:10:30] *** pil-dinner has quit IRC [22:16:34] *** jamezp has joined #jbosstesting [22:29:30] <mhuniewicz> ALR, ping [23:01:50] *** jose_freitas has quit IRC [23:28:36] *** mhuniewicz has quit IRC [23:37:18] *** ALR has quit IRC