[00:00:15] <rachmatowicz> aslak: but you're saying there is not other more legitimate way to do this from a JUnit test?
[00:00:38] <aslak> rachmatowicz, not currently no..
[00:00:55] <rachmatowicz> aslak: ok
[00:01:02] <aslak> rachmatowicz, we do have plans for more arq related callbacks in the test class, e..g @BeforeDeployment etc, but that's not done yet
[00:01:24] <rachmatowicz> aslak: that would be very helpful and useful
[00:02:24] <rachmatowicz> aslak: and there is the crazy idea of being able to construct a named server configuration before it is started and then get ARQ to start it
[00:02:26] <aslak> ALR, i hvae a author file that should work
[00:02:32] <aslak> ALR, if still in need
[00:03:51] *** mbg has quit IRC
[00:04:03] <rachmatowicz> aslak: thanks for your help
[00:07:07] <aslak> rachmatowicz, the names server config etc will be part of arq 1.1,  the code / infrastruct is read, but not merged
[00:07:19] <aslak> names/named
[00:08:45] <aslak> read/ready
[00:09:21] <aslak> it's after 12.. :)
[00:14:49] *** lightguard_jp has quit IRC
[00:16:08] *** aaronwalker has joined #jbosstesting
[00:27:05] *** dabloem has quit IRC
[00:29:33] *** rruss has quit IRC
[00:34:57] *** aaronwalker has quit IRC
[00:42:17] <ALR> aslak: Thanks I rebuilt iy
[00:42:19] <ALR> *it
[00:44:42] *** bobmcw has quit IRC
[00:44:45] *** rachmatowicz has quit IRC
[00:44:45] *** ALR has quit IRC
[00:44:45] *** PeteRoyle has quit IRC
[00:44:45] *** jamezp has quit IRC
[00:44:47] *** pgmjsd has quit IRC
[00:44:47] *** nickarls has quit IRC
[00:44:50] *** jose_freitas has quit IRC
[00:44:55] *** jbott has quit IRC
[00:44:58] *** OndrejZizka has quit IRC
[00:44:59] *** dmlloyd has quit IRC
[00:44:59] *** jbossbot has quit IRC
[00:45:04] *** stuartdouglas has quit IRC
[00:45:15] *** jdlee has quit IRC
[00:45:16] *** ChanServ has quit IRC
[00:55:04] *** jbott has joined #jbosstesting
[00:55:04] *** rachmatowicz has joined #jbosstesting
[00:55:04] *** ALR has joined #jbosstesting
[00:55:04] *** jose_freitas has joined #jbosstesting
[00:55:04] *** PeteRoyle has joined #jbosstesting
[00:55:04] *** OndrejZizka has joined #jbosstesting
[00:55:04] *** jamezp has joined #jbosstesting
[00:55:04] *** pgmjsd has joined #jbosstesting
[00:55:04] *** bobmcw has joined #jbosstesting
[00:55:04] *** nickarls has joined #jbosstesting
[00:55:04] *** ChanServ has joined #jbosstesting
[00:55:04] *** jdlee has joined #jbosstesting
[00:55:04] *** jbossbot has joined #jbosstesting
[00:55:04] *** dmlloyd has joined #jbosstesting
[00:55:04] *** stuartdouglas has joined #jbosstesting
[00:55:04] *** leguin.freenode.net sets mode: +o ChanServ
[01:03:53] *** bobmcw has quit IRC
[01:03:56] *** rachmatowicz has quit IRC
[01:03:56] *** ALR has quit IRC
[01:03:56] *** PeteRoyle has quit IRC
[01:03:56] *** jamezp has quit IRC
[01:03:57] *** pgmjsd has quit IRC
[01:03:58] *** nickarls has quit IRC
[01:04:01] *** jose_freitas has quit IRC
[01:04:06] *** jbott has quit IRC
[01:04:08] *** OndrejZizka has quit IRC
[01:04:10] *** dmlloyd has quit IRC
[01:04:10] *** jbossbot has quit IRC
[01:04:14] *** stuartdouglas has quit IRC
[01:04:25] *** jdlee has quit IRC
[01:04:26] *** ChanServ has quit IRC
[01:06:08] *** jbott has joined #jbosstesting
[01:06:08] *** rachmatowicz has joined #jbosstesting
[01:06:08] *** ALR has joined #jbosstesting
[01:06:08] *** jose_freitas has joined #jbosstesting
[01:06:08] *** PeteRoyle has joined #jbosstesting
[01:06:08] *** OndrejZizka has joined #jbosstesting
[01:06:08] *** jamezp has joined #jbosstesting
[01:06:08] *** pgmjsd has joined #jbosstesting
[01:06:08] *** bobmcw has joined #jbosstesting
[01:06:08] *** nickarls has joined #jbosstesting
[01:06:08] *** ChanServ has joined #jbosstesting
[01:06:08] *** jdlee has joined #jbosstesting
[01:06:08] *** jbossbot has joined #jbosstesting
[01:06:08] *** dmlloyd has joined #jbosstesting
[01:06:08] *** stuartdouglas has joined #jbosstesting
[01:06:08] *** leguin.freenode.net sets mode: +o ChanServ
[02:03:17] *** ianbrandt has quit IRC
[02:12:56] *** bleathem has joined #jbosstesting
[02:23:23] *** aslak has quit IRC
[02:26:29] *** jamezp is now known as jamezp_afk
[02:37:11] *** ALR has quit IRC
[02:37:57] *** ldimaggi has joined #jbosstesting
[04:07:10] *** rruss has joined #jbosstesting
[05:11:23] *** ldimaggi has quit IRC
[06:23:50] *** lightguard_jp has joined #jbosstesting
[06:49:28] *** aaronwalker has joined #jbosstesting
[06:51:52] *** mbg has joined #jbosstesting
[06:56:54] *** OndraZizka has joined #jbosstesting
[07:10:31] *** oskutka has joined #jbosstesting
[07:17:14] *** oskutka has quit IRC
[07:18:37] *** oskutka has joined #jbosstesting
[07:20:50] *** oskutka has quit IRC
[07:22:56] *** oskutka has joined #jbosstesting
[07:23:10] *** oskutka has quit IRC
[07:24:06] *** oskutka has joined #jbosstesting
[07:25:54] *** oskutka has quit IRC
[07:27:09] *** oskutka has joined #jbosstesting
[08:04:13] *** vnvarsete has joined #jbosstesting
[08:15:19] *** bgeorges has joined #jbosstesting
[08:16:01] *** oskutka has quit IRC
[08:16:16] *** rachmatowicz has quit IRC
[08:18:28] *** oskutka has joined #jbosstesting
[08:26:52] *** alesj has joined #jbosstesting
[08:29:31] *** rachmatowicz has joined #jbosstesting
[08:30:20] *** oskutka1 has joined #jbosstesting
[08:30:22] *** oskutka1 has quit IRC
[08:39:32] *** maschmid has joined #jbosstesting
[08:41:33] *** ge0ffrey has joined #jbosstesting
[08:46:51] *** rruss has quit IRC
[08:47:27] *** oskutka has quit IRC
[08:48:30] *** oskutka has joined #jbosstesting
[09:09:21] *** jhuska has joined #jbosstesting
[09:16:39] *** bleathem is now known as bleathem_away
[09:27:01] *** mbg has quit IRC
[09:30:55] *** lightguard_jp has quit IRC
[09:36:37] *** maeste has joined #jbosstesting
[09:41:04] *** Jaikiran has joined #jbosstesting
[09:47:57] *** lfryc has joined #jbosstesting
[10:30:30] <ge0ffrey> Where can I find arquillian-container-spi ? I need it to build tomcat-managed from source
[10:37:26] <ge0ffrey> nvm, found it in jboss nexus, but had to manually add jboss nexus repo to the arq-container sources
[10:57:31] *** stuartdouglas has quit IRC
[11:01:56] *** stuartdouglas has joined #jbosstesting
[11:24:37] *** vtunka_wfh has joined #jbosstesting
[11:34:17] *** bgeorges has quit IRC
[12:03:32] *** kpiwko has joined #jbosstesting
[12:06:07] *** ldimaggi has joined #jbosstesting
[12:07:20] *** alesj has quit IRC
[12:18:35] *** alesj has joined #jbosstesting
[12:20:40] *** aslak has joined #jbosstesting
[12:26:20] *** oskutka has quit IRC
[12:29:16] *** oskutka has joined #jbosstesting
[12:41:42] *** maeste has quit IRC
[13:23:27] *** galderz has joined #jbosstesting
[13:25:49] *** maeste has joined #jbosstesting
[13:28:59] *** Jaikiran is now known as Jaikiran|AFK
[13:42:50] <jose_freitas> hey kpiwko: good morning
[13:43:12] <kpiwko> jose_freitas: good afternoon :)
[13:43:22] <jose_freitas> :)
[13:43:50] <jose_freitas> Have you seen that I've updated the pull request?
[13:43:53] <kpiwko> jose_freitas: I checked your commits, I'll push them upstream as soon as I finish Arquillian Drone cr2 verification
[13:46:06] <jose_freitas> np
[13:46:24] <jose_freitas> just wanted to know if you've seen it.
[13:47:14] <ge0ffrey> aslak: I am making a pull request for managed tomcat to distuing between not started yet and 401 credentials incorrect
[13:48:29] <aslak> ge0ffrey, excellent
[13:48:39] <aslak> ge0ffrey, that was your startup issue?
[13:50:22] <ge0ffrey> aslak: that's the first one at least, I 'll see if there are any others if I fix it
[13:50:38] <aslak> ok
[13:50:44] <ge0ffrey> note that running the tests on arq managed6 itself give it too
[13:52:23] <ge0ffrey> nvm, that last statement is incorrect
[13:58:56] *** galderz has quit IRC
[14:02:37] *** maeste has quit IRC
[14:05:22] *** Jaikiran|AFK is now known as Jaikiran
[14:24:58] *** oskutka has quit IRC
[14:29:17] *** maeste has joined #jbosstesting
[14:35:35] <ge0ffrey> alsak: for the antrun plugin
[14:36:07] <ge0ffrey> aslak: instead of generate-resources, I think we should use generate-test-resources
[14:36:11] <ge0ffrey> as the phase
[14:36:18] <ge0ffrey> if you agree, I 'll add that change to my pull request
[14:37:05] *** oskutka has joined #jbosstesting
[14:38:27] <ge0ffrey> similar for the resources plugin than of course
[14:45:38] *** vnvarsete has quit IRC
[14:55:41] *** rachmatowicz has quit IRC
[14:56:20] *** rachmatowicz has joined #jbosstesting
[15:00:15] *** galderz has joined #jbosstesting
[15:02:47] *** bgeorges has joined #jbosstesting
[15:06:28] <aslak> ge0ffrey, yea, good point
[15:07:23] <ge0ffrey> k, I 'll change that too
[15:10:36] <ge0ffrey> aslak: done, https://github.com/arquillian/arquillian-container-tomcat/pull/8
[15:13:57] <aslak> ge0ffrey, you on windows?
[15:14:04] <ge0ffrey> aslak: no, linux
[15:14:27] <ge0ffrey> aslak: but IIRC the http protocol clearly states that all lines should end with \r\n in the http protocol
[15:14:40] <ge0ffrey> it's not OS dependend
[15:15:15] <aslak> ge0ffrey, assuming every impl follow the spec sure.. hehe
[15:15:47] <ge0ffrey> aslak: I replaced ith with BufferedReader and that supports \n, \r\n and \r
[15:15:53] <ge0ffrey> so nothing has changed
[15:16:08] <ge0ffrey> see BufferedReader api
[15:16:16] <aslak> yeah
[15:16:44] <ge0ffrey> so doesn't matter if the tomcat 6 violates the spec or not
[15:19:30] <aslak> ge0ffrey, you lost the response content check tho?
[15:19:43] <ge0ffrey> aslak: no, see getResponseCode()
[15:19:49] <aslak> in the case of server returning 200 but content ERROR
[15:19:51] <ge0ffrey> aslak: the original one didn't work
[15:20:30] <ge0ffrey> ah... that explains why the original didn't work, it's not checking the server response code?
[15:20:39] <ge0ffrey> aslak: k, I 'll fix it, give me a minute
[15:21:04] <aslak> yea, first one don't check response code but content, the new one checks only return code and not content
[15:21:39] <aslak> as it is, your just reasong the response without doing anything..
[15:21:46] <aslak> reasong/reading
[15:24:16] <ge0ffrey> aslak: who defines that the content starts with "OK - "?
[15:24:20] <ge0ffrey> is that tomcat specific?
[15:24:30] <aslak> think so
[15:25:42] *** maeste has quit IRC
[15:26:42] <ge0ffrey> aslak: done https://github.com/arquillian/arquillian-container-tomcat/pull/8
[15:32:54] <aslak> ge0ffrey, strictly speaking, the if(log.isLoggable .. line could be around the while
[15:34:00] *** rruss has joined #jbosstesting
[15:34:18] <aslak> woo, another example of a possible usecase for do/while as well..  andrew was so proud the other day, seeing it for the first time in the wild :)
[15:34:46] <aslak> or, proud, surprised is more accurate
[15:37:13] <ge0ffrey> aslak: the original code did it like that too, but it makes sense. However, that does mean the lines won't be read if log level isn't fine. Iddunno if that can hurt. feel free to change that of course
[15:38:31] *** oskutka has quit IRC
[15:40:26] <aslak> we're not talking massive amounts of data anyway.. :)
[15:43:00] <aslak> ge0ffrey, you still have issue with ARQ-574 ?
[15:43:02] <jbossbot> jira [ARQ-574] Tomcat managed should not require an installed tomcat server [Open (Unresolved) Enhancement, Major, Unassigned] https://issues.jboss.org/browse/ARQ-574
[15:43:27] <ge0ffrey> aslak: I am copy-paste-adjusting the build config now
[15:43:51] <ge0ffrey> still feels like a workaround though (good enough for now)
[15:45:15] <aslak> it's not up to the container adaptor to get the server for you, it should provided by other means. if we want that feature at some point, it should be handled by a different layer
[15:46:06] <ge0ffrey> aslak: for example, the tomcat-users.xml file is in src/test/resources/container. It doesn't belong in the test classpath
[15:46:30] <ge0ffrey> I am going to put that under src/test/conf/tomcat6 or something
[15:46:44] <ge0ffrey> for guvnor
[15:46:57] <ge0ffrey> (can change it in arq too if you want)
[15:47:01] <aslak> sure, it's not a classpath resource. just easier to deal with under src/test/reosurces
[15:47:56] *** aaronwalker has quit IRC
[15:48:02] <ge0ffrey> aslak: sure => on Q for doing it in arq too?
[15:49:30] <aslak> ge0ffrey, na, leave it in arq for now. we have similar other places as well
[15:49:56] <ge0ffrey> k
[15:50:01] <aslak> it's a resource related to our test. fits the bill enough..
[15:50:12] *** maeste has joined #jbosstesting
[15:51:27] <ge0ffrey> aslak: but does make my point, I am already forking your build script on how to do that. As you improve/change it, mine won't be. So it would be nice if arq could do that. If not at runtime, then with a maven plugin or something.
[15:53:41] <aslak> ge0ffrey, open a new issue describing the feature
[15:54:47] *** bleathem_away has quit IRC
[15:59:21] *** bleathem has joined #jbosstesting
[15:59:51] *** alesj has quit IRC
[16:01:30] *** aaronwalker has joined #jbosstesting
[16:04:07] *** mbg has joined #jbosstesting
[16:04:33] <ge0ffrey> aslak: https://issues.jboss.org/browse/ARQ-576
[16:04:34] <jbossbot> jira [ARQ-576] The build script bits that downloads and configures 1 or more managed containers should be extracted to a maven plugin, so we don't need to copy paste that logic [Open (Unresolved) Feature Request, Minor, Unassigned] https://issues.jboss.org/browse/ARQ-576
[16:06:34] <aslak> thanks
[16:10:36] <ge0ffrey> aslak: you squashed the commits: how do you do that? (wondering on how best to use git)
[16:11:09] <ge0ffrey> I mean, which git commands do you use for doing that?
[16:12:50] *** mbg has quit IRC
[16:13:15] *** mbg has joined #jbosstesting
[16:14:40] *** patman_nl has joined #jbosstesting
[16:18:58] <aslak> ge0ffrey, git rebase -i from_commit_id
[16:19:30] <ge0ffrey> k tnx for info
[16:19:31] <aslak> that gives you a list of all the commits after given commit id, you can then choose to remove, reword, edit, squash etc
[16:20:44] <ge0ffrey> in intellij (or eclipse for that matter), how do you get the CATALINE_HOME var set for the tests? Manually?
[16:22:08] <aslak> arq.xml
[16:22:54] <aslak> https://docs.jboss.org/author/display/ARQ/Tomcat+6.0+-+Managed
[16:23:31] <ge0ffrey> tnx
[16:34:48] *** patman_nl has quit IRC
[16:43:50] *** aaronwalker has quit IRC
[16:47:37] <ge0ffrey> aslak: it would be nice if we could make the arquillian.xml do more of configuration by exception
[16:48:17] <ge0ffrey> for example, everyone needs to specify a username and password
[16:48:52] <ge0ffrey> but in theory, we could set that to a default (the same for all managed containers for simplicity's sake) and then just auto-copy a default tomcat-user.xml into conf
[17:00:24] *** galderz has quit IRC
[17:01:10] *** galderz has joined #jbosstesting
[17:06:56] <ge0ffrey> aslak: I am now running into this one: org.jboss.arquillian.testenricher.cdi.container.BeanManagerProducer lookup \n INFO: BeanManager not found
[17:07:17] <ge0ffrey> Might this require the weld arquillian upgrade branch that alesj was talking about?
[17:07:32] <ge0ffrey> using weld 1.1.3-SNAPSHOT
[17:08:32] <aslak> ge0ffrey, not sure.. do you have the BeanMaanager ObjectFactory thinggy in context.xml ?
[17:08:58] <aslak> ge0ffrey, and the resource-env-ref in web.xml
[17:26:18] <ge0ffrey> aslak: no, as I 'd like to avoid making container specific wars, but deploying to a tomcat6 server of the app works
[17:26:34] <ge0ffrey> Isuppose arquillian can't work without that?
[17:26:38] *** jamezp_afk is now known as jamezp
[17:27:54] *** maeste has quit IRC
[17:31:43] <aslak> ge0ffrey, that's not arquillain
[17:32:04] <aslak> aa.. well..
[17:32:26] <ge0ffrey> aslak: it's weld, but I got weld to work without it. But if jboss ignores the bottom web.xml bit, I am sure it's fine
[17:32:30] <ge0ffrey> trying now
[17:32:33] <aslak> it tries to find it in jndi, which it is not registered by default
[17:32:49] <aslak> weld-servlet has some other tomcat way of binding it i guess
[17:33:59] <ge0ffrey> could be I haven't tested guvnor far enough yet
[17:34:08] <ge0ffrey> the boot worked, so first wanted to get the tests to compile
[17:34:23] *** vtunka_wfh has quit IRC
[17:34:39] <ge0ffrey> therefor I need arq
[17:34:41] <ge0ffrey> success! :)
[17:35:02] <aslak> weee
[17:35:03] <aslak> :)
[17:35:05] <ge0ffrey> my hello world arq test works with all of guvnor in the classpath :)
[17:35:32] <ge0ffrey> aslak: tnx for all your help
[17:36:25] <aslak> yeay! what you can't get done in 3-4 weeks hehe
[17:36:29] <ge0ffrey> looks like tomcat normal deploy is broken though, taking a look
[17:36:57] <ge0ffrey> yea... seam3/weld/arq is still very young
[17:41:33] <ge0ffrey> it was only with the release of seam 3.1 Beta2 that most of the issues dissappeared
[17:41:55] <ge0ffrey> gotta go
[17:42:04] *** ge0ffrey has quit IRC
[18:04:25] *** lfryc is now known as lfryc_away
[18:09:10] *** Jaikiran has quit IRC
[18:20:07] *** jose_freitas has quit IRC
[18:23:25] *** jose_freitas has joined #jbosstesting
[18:30:59] *** rruss has quit IRC
[18:45:14] *** rruss has joined #jbosstesting
[18:45:26] *** ianbrandt has joined #jbosstesting
[18:54:37] *** ldimaggi has quit IRC
[18:55:38] *** maschmid has quit IRC
[19:01:13] *** rbattenfeld has joined #jbosstesting
[19:02:06] *** rbattenfeld has left #jbosstesting
[19:31:35] <jose_freitas> aslak: ping
[19:34:13] <aslak> jose_freitas, heya
[19:39:35] *** rruss has quit IRC
[19:47:23] *** galderz has quit IRC
[19:49:24] <jhuska> aslak, hi, I am continuing with tomcat managed, now working on tomcat 5.5, and I need to support for Servlet 2.4. I started with just copying Servlet 2.5 and changed the name, installed it, but still it looks like it does not know about this implementation, should I register this via spi somehow ?
[19:51:23] <aslak> 5.5 eh? hehe
[19:52:13] <aslak> jhuska, https://github.com/arquillian/arquillian-core/blob/master/protocols/servlet/src/main/java/org/jboss/arquillian/protocol/servlet/ServletExtension.java
[19:52:24] <aslak> jhuska, did yo uget tomcat 7 managed working ?
[19:55:12] <jhuska> aslak, thanks, not yet, I do know how to continue with that, just FYI it is here: https://github.com/jhuska/arquillian-container-tomcat/tree/managed-7
[19:55:42] <jhuska> aslak, should I pull request for this not working thing ?
[19:56:15] <aslak> jhuska, how are you pulling in updates to the different branches?
[19:56:43] <aslak> jhuska, i had a hard time trying to squash and clean up the managed_6 branch last night. multiple duplicate commits etc
[19:58:46] <jhuska> aslak, sorry but I beginner with git, I use this workflow, I fork the project, clone it, make branch for example for tomcat -managed-7, checkout that branch, make changes, commit, and push to origin branch
[19:59:16] <jhuska> aslak, push origin newbranch
[19:59:42] <aslak> yea, but how do you pull in updates from master ?
[20:00:28] <aslak> jhuska, like here, https://github.com/jhuska/arquillian-container-tomcat/commits/managed-7
[20:01:44] *** ldimaggi has joined #jbosstesting
[20:01:45] <jhuska> aslak, you are asking how did I get there the ARQ-575 Upon httpResponseCode 401 (and other client or server errors), a...  commit ?
[20:01:47] <jbossbot> jira [ARQ-575] Tomcat Managed container does not handle not authorized correctly [Resolved (Done) Bug, Major, Aslak Knutsen] https://issues.jboss.org/browse/ARQ-575
[20:02:12] <aslak> you have one new commit from master on top, then a few managed-7 ones. then the one from master with managed 6 from yesterday, then a few of your own from the old commits from managed 6 and some for managed 7
[20:03:30] *** alesj has joined #jbosstesting
[20:04:38] <jhuska> aslak, when the change is made in upstream I was trying to get it to each branch, maybe in a wrong way
[20:05:00] <aslak> jhuska, try rebase
[20:05:24] <aslak> jhuska, that rewrites your new commits ontop of e.g. master
[20:05:50] <aslak> git pull upstream master && git checkout managed_7 && git rebase master
[20:06:29] <aslak> now all new commits in managed_7 is rewritten to come after those in master
[20:06:38] *** alesj has quit IRC
[20:07:05] <aslak> what essentially happens is: managed_7 is reset to the state of master, then the new commits in managed_7 is reapplied
[20:10:36] <jhuska> aslak, thanks for advice, the best probably for me will to backup code, delete forked repo, and fork it again and use rebase as you proposed
[20:13:33] <jhuska> aslak, continuing tomorrow, bye for now
[20:13:37] *** jhuska has quit IRC
[20:17:04] *** lightguard_jp has joined #jbosstesting
[20:31:37] *** dblevins has joined #jbosstesting
[20:52:03] *** alesj has joined #jbosstesting
[20:55:57] <jose_freitas> aslak: sorry, I was summoned in another place
[21:02:46] *** jamezp is now known as jamezp_afk
[21:04:59] *** kevinpollet has joined #jbosstesting
[21:05:16] *** kevinpollet has left #jbosstesting
[21:14:11] <jose_freitas> aslak: .
[21:14:58] <jose_freitas> I'd like to discuss possible solutions too those dependencies we have to add in jboss7 and tomcat for jsfunit-arq extension
[21:19:33] *** bgeorges has quit IRC
[21:21:10] *** rruss has joined #jbosstesting
[21:22:20] *** lfryc_away is now known as lfryc
[21:47:59] *** ALR has joined #jbosstesting
[21:50:25] <jose_freitas> hey ALR, good afternoon
[21:50:39] <ALR> Hi jose_freitas.  Nice to have power again :)
[21:50:46] *** alesj has quit IRC
[21:50:55] <jose_freitas> :)
[21:50:55] <ALR> (They shut off my block last night for hurricane-related repairs)
[21:51:02] <jose_freitas> woa
[21:51:13] <ALR> aslak: You'd mentioned you had a good authors file.  Still got it?
[21:51:30] <ALR> jose_freitas: Yeah, so just logging in today for the first time now.
[21:51:43] <jose_freitas> your area was affected for that big storm?
[21:52:13] <ALR> jose_freitas: Yeah, in spotty ways.  I hadn't lost power initially, but I guess they needed to turn it off to do some other stuff.
[21:52:20] <ALR> My parents haven't had any since Sunday morning.
[21:52:26] * ALR in Boston.
[21:53:10] <ALR> jose_freitas: So remind me where we left off.  I was just recreating that JSFUnit repo.
[21:53:22] <ALR> And was manually finding authors not accounted for in the JBoss.org authors file.
[21:53:32] <ALR> Also needed to import the tags.
[21:53:36] <jose_freitas> hm
[21:53:38] <ALR> So we're preserving enough history
[21:53:52] <ALR> It's not hard, it's just a little lengthy because git-svn is a slow process.
[21:53:58] <jose_freitas> I was thinking that since we didn't release it yet, that we could add another commit. tests on jbossas7 have passed
[21:54:11] <ALR> So I'll start reimporting now in the BG and see if I can't clear past the errors.
[21:54:16] <ALR> jose_freitas: Oh nice
[21:54:29] <ALR> jose_freitas: Sure, push to your repo on a topic branch and make a pull request
[21:54:37] <jose_freitas> ok
[21:54:38] <ALR> And I'll be sure to lay that on top of the new repo
[21:55:57] <jose_freitas> but there's something I'd like to discuss first
[21:56:54] <jose_freitas> right it is now the extension don't add classes from xerces and xalan (they're shipped with jboss 5 and 6)
[21:57:09] <jose_freitas> so for jboss 5 and 6 the extension is working at upstream
[21:57:27] <ALR> jose_freitas: Didn't add Xerces and Xalan to where>?
[21:57:44] <jose_freitas> ops, sorry
[21:57:49] <jose_freitas> lemme contextualize you better
[21:57:59] <ALR> Thx
[21:58:21] <jose_freitas> jsfunit needs some xerces and xalan classes
[21:58:27] <jose_freitas> so they need to be deployed with the application
[21:59:07] <jose_freitas> in case of as5 and as6, as they already have those libs, you don't need that on your application
[21:59:36] <ALR> Ah I see
[21:59:42] <jose_freitas> so, in the upstream, our ArchiveAppender, does not append those classes
[21:59:57] <ALR> And in AS7 because of modular CL (and maybe because they're not in AS7 to begin with) you need to provide 'em
[22:00:05] <jose_freitas> yes
[22:00:08] <ALR> jose_freitas: Proposed solution?
[22:00:20] <jose_freitas> adding them, breaks AS5 tests
[22:00:41] <jose_freitas> because there're class sconflicts
[22:01:29] *** jamezp_afk is now known as jamezp
[22:01:39] <jose_freitas> today, jsfunit without arquillian let this to the user
[22:01:54] <jose_freitas> the user have to manage its dependency
[22:02:06] <ALR> I see.
[22:02:07] <jose_freitas> with arquillian + shrinkwrap, we manage that
[22:02:24] <ALR> Possible for different appenders to be used based on different backing containers?
[22:02:29] <ALR> ie. in AS7 add it, in AS5 don't?
[22:03:04] <jose_freitas> hm, but how could we register them separatedly?
[22:03:49] <ALR> I'm not sure; at what level are these Appenders?
[22:03:58] <ALR> ie. Provided by ARQ, or within JSFUnit?
[22:04:06] <ALR> Or by the ARQ Container?
[22:04:21] <jose_freitas> jsfunit extension
[22:04:40] <jose_freitas> are you familiar with the arq-extension spi?
[22:05:05] <jose_freitas> they are loaded before @Deployment
[22:05:20] <jose_freitas> ops
[22:05:25] <jose_freitas> no, after @Deployment
[22:05:30] <jose_freitas> just after
[22:06:17] <jose_freitas> arq doesn't provide a way to know which server he'll be running at
[22:06:36] <jose_freitas> (which is great)
[22:06:42] <ALR> jose_freitas: ie. https://github.com/arquillian/arquillian-core/tree/master/core/spi/src/main/java/org/jboss/arquillian/core/spi?
[22:08:26] <jose_freitas> I was thinking on adding a feature on shrinkwrap that when adding a class, if the class is not in classpath it does not throw an error. like a permissiveAdd
[22:08:35] <jose_freitas> yes, partly on that ALR
[22:08:56] <ALR> jose_freitas: How would that work in SW?
[22:09:10] <ALR> The second you have Something.class, it's already classloaded.
[22:09:12] <jose_freitas> we could pass a string, it could validate the existence of class
[22:09:20] <ALR> Hence visible to a ClassLoader
[22:09:21] <jose_freitas> and then use addClass
[22:09:39] <ALR> You could do that.  If you passed in a String and a ClassLoader
[22:10:15] <ALR> So basically "try to add this class, but if you can't, just skip it"?
[22:10:28] <ALR> addClassIfAvailable
[22:10:30] <ALR> ?
[22:10:37] <jose_freitas> something like that
[22:11:53] <ALR> jose_freitas: http://docs.jboss.org/shrinkwrap/latest/org/jboss/shrinkwrap/api/container/ClassContainer.html#addClass(java.lang.String, java.lang.ClassLoader)
[22:11:57] <ALR> We can just make a new one:
[22:12:12] <ALR> addClass(String, CL, boolean ignoreIfNotFound)
[22:12:46] <jose_freitas> or that :)
[22:13:02] <ALR> jose_freitas: That sounds reasonable.  Does it fix your issue?
[22:13:33] <jose_freitas> kinda, one problem on this solution is that for as5 for example, we'd have to exclude xerces and xalan dependency
[22:14:01] <jose_freitas> and I'm not exactly buying this idea
[22:14:13] <jose_freitas> I'm just trying to think a way out of it
[22:14:44] <ALR> Why exclude it on AS5?  Wouldn't the preference in AS5 go to the classes in the user deployment instead of the ones in the server?
[22:15:00] <ALR> Or that causes a conflict (ie. ClassCastException) somewher?
[22:15:02] <ALR> *somewhere
[22:15:32] <jose_freitas> yes
[22:15:40] <jose_freitas> it causes classcastexception
[22:15:42] <jose_freitas> at runtime
[22:17:23] <ALR> jose_freitas: k, for now I'll just work on the release stuff
[22:17:28] <ALR> And also I have other SD and ARQ work
[22:17:42] <ALR> So we'll loop back to this when some of the other admin stuff is cleared?
[22:17:48] <jose_freitas> sure thing
[22:17:56] <ALR> I'll background that though
[22:18:04] <aslak> jose_freitas, sorry, was down for dinner..
[22:18:06] <jose_freitas> so, can we release for as6 and as7 instead of as5 and as6?
[22:18:10] <aslak> ALR, sent..
[22:18:13] <ALR> Would need to look more into how we can intelligently apply new stuff to the appender
[22:18:19] <ALR> aslak: Sent...?
[22:18:31] <ALR> aslak: OOoh authors file
[22:18:32] <ALR> Thanks
[22:19:44] <jose_freitas> aslak: np, if you have some time, would you ming on take a look at our discussion above?
[22:19:58] <jose_freitas> is about that discussion on xerces an xalan
[22:20:06] <jose_freitas> and*
[22:20:50] <jose_freitas> ming->mind
[22:24:51] <aslak> been reading up
[22:25:35] <aslak> we don't need to push this down to shrinkwrap, but it's a option
[22:26:26] <aslak> we do similar with testng as well..  if you have guice on cp, we assume you're using the testng guice features so we package it
[22:26:34] <aslak> it's a bit scary with xml parsers tho
[22:28:47] <jose_freitas> hm
[22:28:56] <ALR> It's all scary
[22:29:10] <ALR> SW can offer some help, but really it's a convenience to folks.
[22:29:17] <ALR> And offers a hack to this particular case.
[22:29:34] <ALR> Actually any sensing of the CP scares me usually :)
[22:29:40] <jose_freitas> hehehe
[22:29:43] <ALR> Especially as we go into more and more modular environments.
[22:30:07] <aslak> i don't think addClass will do much good tho, what you want it addPackage. unless you want to specify all classes in xalan
[22:30:51] <jose_freitas> oh yes, indeed... we'd need addPackage.
[22:31:23] <aslak> i believe addPackage(String) works like that already
[22:31:34] <aslak> it will just not add any classes if it can't find it
[22:33:29] <jose_freitas> hm
[22:39:16] <aslak> ALR, he he.. https://github.com/arquillian/arquillian-showcase/commit/8f9cd930c60f68153ba0830ec29de3c4884940cd
[22:39:18] <jbossbot> git [arquillian-showcase] 8f9cd93.. Aslak Knutsen Add auto extract of 3 JBoss AS 7 Servers with config overwrite in the multinode example
[22:39:56] <ALR> Yay AS7
[22:40:10] <aslak> automated the 3 node cluster showcase
[22:40:30] <aslak> 30 sec to run..
[22:41:04] <aslak> done by the time as5 starts.. but it has some hangs some where.. need to research a bit more
[22:41:46] <aslak> i think as7 managed still has the 5 sec lag, just at a different time. we now check socket to see if it is up so we can start it, then we start to check via mgm api when it is done starting
[22:42:13] <aslak> but the first mgm api check still hangs for 5 sec, then tries again and it can connect
[22:42:25] <aslak> the server is started in 2-3 sec, so..
[22:42:30] *** rruss has quit IRC
[22:42:39] <aslak> guess we need to check with socket until the port is open, then switch to mgm api
[22:47:11] <jose_freitas> aslak, can't we check in archiveAppender the container qualifier used in arquillian.xml?
[22:47:29] <aslak> nope
[22:47:56] <aslak> well..  you could inject the configuration etc, but the qualifier won't tell you anything
[22:59:45] *** lightguard_jp is now known as lightguard_jp_aw
[23:00:46] *** ldimaggi has quit IRC
[23:11:40] *** aaronwalker has joined #jbosstesting
[23:22:59] <aslak> lfryc, have you looked at http://saucelabs.com/ondemand ?
[23:35:35] *** bobmcw has quit IRC
[23:39:00] *** bobmcw has joined #jbosstesting
[23:53:39] <aslak> ALR, woo, we missed shrinkwraps 2 year birthday
[23:54:00] *** rruss has joined #jbosstesting
[23:54:27] <aslak> First Commit: 2009-08-05
[23:55:12] *** lightguard_jp_aw is now known as lightguard_jp
[23:55:25] <aslak> lightguard_jp, hey
[23:55:31] <aslak> lightguard_jp, you used jsfunit much ?
[23:56:00] <lightguard_jp> aslak: Not a whole lot. jose_freitas and bleathem would be the ones to ask
[23:56:29] <aslak> mm
[23:56:59] <lightguard_jp> aslak: What's the question though?
[23:57:32] <aslak> it's more jsf test question more then jsfunit specific
[23:58:05] <aslak> in jsfunit, you can assert on response and state all from in container
[23:58:26] *** rruss has quit IRC
[23:58:48] <aslak> are they ever mixed.. eg. assert state based on response or the other way around
[23:59:02] <aslak> or are they always two separate asserts
[23:59:33] <aslak> validateBeanX, validateBeanY, validateRenderedOutputCompA validateRenderedOutputCompB





top