[01:36:57] *** echelog-2 has joined #jbosstesting
[01:47:55] *** OndraZizka has quit IRC
[01:54:17] *** johnament has joined #jbosstesting
[01:57:47] *** ianbrandt has quit IRC
[04:11:14] *** mdobozy has quit IRC
[04:12:54] *** johnament has quit IRC
[06:49:16] *** lightguard_jp has joined #jbosstesting
[07:08:37] *** lightguard_jp has quit IRC
[07:13:00] *** OndraZizka has joined #jbosstesting
[07:38:05] *** nickarls has left #jbosstesting
[07:38:48] *** nickarls has joined #jbosstesting
[07:42:58] *** vnvarsete has joined #jbosstesting
[08:22:23] *** jharting has joined #jbosstesting
[08:33:05] *** lfryc has joined #jbosstesting
[08:34:27] *** galderz has joined #jbosstesting
[08:35:16] *** maschmid has joined #jbosstesting
[08:40:43] *** lfryc is now known as lfryc_wfh
[09:05:14] *** ge0ffrey has joined #jbosstesting
[09:07:55] *** kpiwko has joined #jbosstesting
[09:14:14] *** jhuska has joined #jbosstesting
[09:18:28] *** oskutka has joined #jbosstesting
[09:28:52] *** Jaikiran has joined #jbosstesting
[09:56:17] *** jeand_ has joined #jbosstesting
[10:02:25] *** ALR has joined #jbosstesting
[10:10:55] <nickarls> how are the jacoco report supposed to appear? I get a jacojo.exec file but no pretty bling-bling...
[10:15:24] <nickarls> the plugin does have a report element...
[10:30:57] *** galderz has quit IRC
[10:34:57] *** mgoldmann has joined #jbosstesting
[11:09:02] *** kevinpollet has joined #jbosstesting
[11:17:50] *** pilhuhn has joined #jbosstesting
[11:17:51] *** pilhuhn has joined #jbosstesting
[11:33:00] *** alesj has joined #jbosstesting
[11:34:50] *** galderz has joined #jbosstesting
[12:08:11] *** kevinpollet has quit IRC
[12:22:16] *** galderz has quit IRC
[12:23:08] *** galderz has joined #jbosstesting
[12:45:40] *** nickarls has quit IRC
[12:53:51] *** nickarls has joined #jbosstesting
[13:18:50] *** pilhuhn is now known as pil-lunch
[14:00:28] *** pil-lunch is now known as pilhuhn
[14:29:18] *** kevinpollet has joined #jbosstesting
[14:47:58] *** jose_freitas has joined #jbosstesting
[14:48:38] <jose_freitas> good morning
[14:53:10] <jose_freitas> ALR: ping
[14:53:20] <ALR> jose_freitas: Hiya
[14:54:31] <jose_freitas> what could be different in the classpath build by eclipse and classpath build by maven?
[14:55:41] <jose_freitas> that includeDepedenciesFromPomInClassPath works with junit test, but won't work in a full build
[14:55:54] <jose_freitas> maven* build
[14:57:30] <ALR> jose_freitas: Maven only has one classpath
[14:57:39] <ALR> I mean Eclipse only has one ClassPath
[14:57:54] <ALR> Maven uses different classpaths for compiling src/main and src/test
[14:58:01] <ALR> It has to do w/ scopes
[14:58:28] <ALR> Maven is the authoritative build
[14:58:36] <ALR> IDE is the convenience.
[14:59:10] <jose_freitas> sure
[15:00:55] *** vnvarsete has quit IRC
[15:08:39] <jose_freitas> ALR: I have a jar with a pom.xml at the root of the file and a class A that should load dependencies from this pom to create a base WebArchive. This jar ships as a dependency for a main project X, with test scope. Arquillian Tests in project X use class A to produce their base WebArchive which fails to find pom when building with maven. it works in eclipse "run as JUnit".
[15:09:29] <jose_freitas> tests on maven-resolver finds test-pom, but it don't test a situation where the pom comes from a different jar.
[15:09:46] <jose_freitas> what do you think could be the problem?
[15:10:25] <ALR> Jesus.
[15:10:38] * ALR reaches for pen/paper
[15:10:41] <jose_freitas> jesus is the problem?
[15:10:44] <jose_freitas> hahaha
[15:10:58] <jose_freitas> I knew it
[15:11:22] <ALR> jose_freitas: Can you just send me the failing test?
[15:12:13] <ALR> It's like your class A is in an archive, and then it uses itself to build another WebArchive for project X?
[15:12:20] <ALR> Sounds convoluted.
[15:12:46] <jose_freitas> ok
[15:13:03] <jose_freitas> I'll try to simplify the case to send you
[15:13:27] <jose_freitas> but basically, I build a class A that generates a generic webArchive
[15:15:10] <ALR> OK, Class A builds a WebArchive.
[15:15:14] <ALR> By reading in from some POM.
[15:15:22] <jose_freitas> this class will be used for tests in different projects
[15:15:27] <ALR> OK
[15:15:35] <ALR> That's easy enough.
[15:15:39] <jose_freitas> and it brings a pom
[15:15:49] <ALR> That's where I lose you.
[15:15:50] <jose_freitas> to load some base dependencies
[15:15:53] <ALR> "It brings a POM"?
[15:15:57] <jose_freitas> the jar
[15:16:02] <ALR> What does that mean?  How does a Class bring a POM?
[15:16:04] <ALR> What JAR?
[15:16:18] <jose_freitas> jar for class A
[15:16:26] <ALR> Is the POM in the JAR that contains Class A?
[15:16:32] <jose_freitas> yes
[15:16:39] <ALR> Or is this the POM that is used to make the JAR that contains Class A?
[15:16:51] <jose_freitas> no, the pom ships within the jar
[15:16:53] <jose_freitas> inside of it
[15:16:57] <ALR> Ah, much clearer then
[15:16:58] <ALR> OK
[15:17:08] <ALR> And how is Class A accessing this POM?
[15:18:26] <jose_freitas> .includeDependenciesFromPomInClassPath("basepom.xml")
[15:18:37] <jose_freitas> basepom ships in the root of JAR
[15:18:40] *** rruss has joined #jbosstesting
[15:18:43] <ALR> And what's that code doing?
[15:18:51] <ALR> To get it from the String?
[15:19:02] <ALR> classLoader.getResourceAsStream() ?
[15:19:09] <jose_freitas> that code resolves the same way addASResource resolves
[15:19:36] <ALR> (I have my AS7 workspace open, so apologies for not just cracking it open now)
[15:19:39] *** rruss has quit IRC
[15:19:58] *** rruss has joined #jbosstesting
[15:20:03] <jose_freitas> http://pastebin.com/8Dg6x0W7
[15:20:34] <jose_freitas> this method finds the path in classpath
[15:20:34] <ALR> Simple aside, we really have to look at the naming of the API in the SW Maven Resolver.
[15:20:56] <ALR> Because this: "includeDependenciesFromPomInClassPath" is just silly.
[15:21:04] *** rruss has quit IRC
[15:21:08] <jose_freitas> ok
[15:21:10] *** rruss has joined #jbosstesting
[15:21:14] <jose_freitas> I like descriptive names
[15:21:19] <jose_freitas> but I can change it
[15:21:20] <ALR> Me too,
[15:21:36] <ALR> But also concise.  Anyway, back to the issue at hand.
[15:21:38] <jose_freitas> what do you suggest?
[15:21:49] <jose_freitas> ok, I'll bump you later with naming
[15:21:55] <ALR> Yup :)
[15:22:39] <jose_freitas> ok
[15:22:43] <ALR> Weird.  getResource on TCCL is called twice?
[15:22:43] <jose_freitas> so in the method I pastebin
[15:23:05] <ALR> Once for the URL and then again to get the File via...another call to get the URL?
[15:23:38] <jose_freitas> yeah
[15:23:49] <jose_freitas> to validate it I believe
[15:24:25] <ALR> So validate it, then reuse it.
[15:24:39] <ALR> resourceUrl.getFile()
[15:25:01] <jose_freitas> yeah, I should have thought at it. I just paste it from ContainerBase
[15:25:22] <ALR> Again, this isn't your problem. :)
[15:25:32] <jose_freitas> no no
[15:25:38] <jose_freitas> the thing is that I implemented thjis
[15:25:43] <jose_freitas> it is my problem
[15:25:43] <ALR> What exactly is the error you're getting?
[15:25:44] *** rruss has quit IRC
[15:25:56] <jose_freitas> hehehe
[15:26:07] <ALR> I mean this isn't your problem with not being able to make the archive.
[15:26:28] <jose_freitas> ok
[15:26:34] <jose_freitas> so, it validates correclty
[15:26:37] <jose_freitas> so it finds the URL
[15:26:56] <jose_freitas> but when Validate.isReadable(path, "Path to the pom.xml file must be defined and accessible");
[15:26:59] <jose_freitas> it fails
[15:27:43] <ALR> What's doing that check?
[15:28:57] <jose_freitas> http://pastebin.com/eTrCUQc7
[15:32:25] <ALR> And Validate.isReadable ?
[15:32:36] <ALR> I wish I had my IDE up and useable now :)
[15:32:53] <ALR> But AS7 just takes all the RAM and is too long to close/reopen
[15:33:13] <jose_freitas> http://pastebin.com/h6Z9kDMZ
[15:33:38] <ALR> There's your problem.
[15:33:42] <jose_freitas> yeah I know, I can't build it in my ide
[15:33:54] <ALR> new File()
[15:33:55] <jose_freitas> it's to heavy metal for it
[15:34:01] <ALR> You don't have a File.
[15:34:07] <ALR> You have a POM inside a JAR
[15:34:37] <ALR> Something you can get at via bytes.  But not as a File.
[15:35:04] <ALR> And the IDE probably works because you have that source file in a target/classes dir somewhere that's on the JUnit runtime CP
[15:35:16] <ALR> So you're picking it up from there, not from within the POM
[15:35:26] <ALR> I'm guessing that's your issue.
[15:36:00] <ALR> This code here is assuming you have a File.  And for the contents of something in a JAR, you can't do that assertion.
[15:36:03] <ALR> Makes sense?
[15:36:04] <jose_freitas> right
[15:36:06] <jose_freitas> makes
[15:36:32] <jose_freitas> so, back on naming issue
[15:36:37] <ALR> Ha
[15:36:41] <jose_freitas> since I'm going to change it now, that would be a nice moment
[15:36:56] <ALR> includeDependenciesFromPomInClassPath
[15:37:19] <ALR> Recommend we do this:
[15:37:21] <jose_freitas> there's a method called includeDependenciesFromPom
[15:37:35] <ALR> Forum post with a list of all the method names in SW Resolver API
[15:37:46] <ALR> And then we can all weigh in on each
[15:37:55] <ALR> I try not to do API naming reviews just on my own.
[15:38:07] <ALR> Usually Aslak and I debate back and forth to come up with names.
[15:38:15] <ALR> And usually others throw in opinions too.
[15:38:32] <ALR> That's the API review we do for SW, SD, etc
[15:38:42] <ALR> So looks like its time that Resolvers gets the same love.
[15:39:13] <ALR> In the meantime, I'll crash for a few hours.
[15:39:16] <jose_freitas> great
[15:39:18] <jose_freitas> I'll do it
[15:39:22] <ALR> Send me anything you need.
[15:39:27] <ALR> And I'll be sure to have a look.
[15:39:36] <ALR> And yell at me if that File() idea is off base.
[15:39:41] <ALR> But I think that's it.
[15:39:55] <jose_freitas> :)
[15:40:01] <ALR> Not 100% happy with my explanation why it works in the IDE
[15:40:01] <jose_freitas> ok
[15:40:07] <ALR> But that's a decent guess I'd think.
[15:40:13] <jose_freitas> I'll bump kpwiko before posting on forums too
[15:40:18] <jose_freitas> yes it is
[15:40:22] <jose_freitas> thank you very much
[15:40:27] <ALR> Definitely.  He designed most of it.
[15:40:32] <ALR> No, thank you.
[15:40:46] <ALR> It's you guys working on this stuff which makes the whole process work.
[15:41:04] <ALR> And now that Resolvers has graduated to top-level, I need to give it a good API review.
[15:41:39] <jose_freitas> :) oki doki
[15:41:49] <ALR> Previously I've mostly been letting kpiwko just make whatever calls he sees fit, because he's done a great job.  So now we get to put it through the same wringer that SD, ARQ, SW, etc all get.
[15:41:56] <ALR>  Bye!
[15:42:02] *** ALR has quit IRC
[15:42:02] <jose_freitas> bye
[15:44:28] <kpiwko> jose_freitas: If you are going to spawn such topic on forums, there already a discussion with Samuel
[15:44:34] <kpiwko> jose_freitas: let me find the link
[15:45:43] <kpiwko> jose_freitas: we were discussing some method renaming at http://community.jboss.org/message/612368
[15:47:31] <jose_freitas> great
[15:47:48] <jose_freitas> I'll bump there for the methods I gave name
[15:48:03] <kpiwko> jose_freitas: btw, that Validate.isReadable is my stuff, so you can blame me :)
[15:49:11] <jose_freitas> well, since loadPom and loadSettings uses a File as input
[15:49:18] <jose_freitas> your method is perfectly fine
[15:51:00] <jose_freitas> it validates what it should validate
[15:51:01] <jose_freitas> :)
[15:59:00] <jose_freitas> what got me surprised is that the pom in classpath cannot be accessed as a File
[15:59:51] <jose_freitas> resources can
[16:10:46] <kpiwko> jose_freitas: and pom in classpath is not a resource?
[16:11:10] <jose_freitas> yes they are
[16:11:11] <jose_freitas> afaik
[16:11:41] <jose_freitas> but I might be wrong
[16:11:48] <jose_freitas> I'll try to create a file with new
[16:11:53] <jose_freitas> File(URI)
[16:13:31] <jose_freitas> <ALR> You have a POM inside a JAR
[16:13:31] <jose_freitas> [10:30] <ALR> Something you can get at via bytes.  But not as a File.
[16:14:10] *** rruss has joined #jbosstesting
[16:15:29] *** jharting has quit IRC
[16:24:28] *** mgoldmann has quit IRC
[16:24:55] <jose_freitas> if we cannot get it from a file, it will be a really PITA, cause almost everything that loads pom is file based
[16:24:59] *** mgoldmann has joined #jbosstesting
[17:29:24] *** oskutka has quit IRC
[17:34:02] *** jeand_ has quit IRC
[17:35:26] *** kpiwko has quit IRC
[17:35:36] *** maschmid has quit IRC
[17:58:10] *** kpiwko has joined #jbosstesting
[18:02:42] *** ALR has joined #jbosstesting
[18:06:38] *** kpiwko has quit IRC
[18:06:52] *** galderz has quit IRC
[18:11:30] *** ianbrandt has joined #jbosstesting
[18:12:37] *** aslak has joined #jbosstesting
[18:13:08] *** galderz has joined #jbosstesting
[18:26:05] *** alesj has quit IRC
[18:30:07] *** bleathem has joined #jbosstesting
[18:31:34] *** pilhuhn is now known as pil-dinner
[18:50:22] *** jhuska has quit IRC
[18:59:05] *** lightguard_jp has joined #jbosstesting
[19:00:29] *** galderz has quit IRC
[19:00:33] *** rbattenfeld has joined #jbosstesting
[19:03:11] <rbattenfeld> ALR: Thanks for your help. I quickly saw in github that you manually fixed the broken pom. That means the current upstream/1.2.0.X includes the module splitting in api-javaee ..., right?
[19:04:08] <ALR> rbattenfeld: Yup
[19:04:13] <ALR> All your stuff is in 1.2.0-X
[19:04:20] <ALR> In one commit.
[19:04:36] <ALR> And then I have one commit atop that, just to show you what I changed.
[19:04:48] <ALR> Notice how we lost that test case file in the move.
[19:05:01] <rbattenfeld> ALR: Thanks for that!
[19:05:03] <ALR> Which is why it's important to stay rebased. :)
[19:05:06] <ALR> Absolutely.
[19:05:10] <ALR> And thanks for your work.
[19:05:32] <ALR> I just did some git magic and reorg of the commit tree.
[19:06:33] <rbattenfeld> ALR: There is one little thing I didn't mentioned so far. The ejbjar30 test you write, didn't work for me and I disabled it...
[19:06:48] <ALR> I'm sure it didn't.
[19:07:01] <rbattenfeld> ALR: Cool, git is nice:-)
[19:08:01] <ALR> https://github.com/shrinkwrap/descriptors/blob/1.2.0-X/test/src/test/java/org/jboss/shrinkwrap/descriptors/test/ejb30/EjbJar30DescriptorTestCase.java
[19:08:02] <ALR> That one?
[19:08:13] <ALR> Just a placeholde.r
[19:08:15] <rbattenfeld> ALR: Yes, this one
[19:10:21] <rbattenfeld> ALR: ok, fine, I will if I have time finish all the test cases:-)
[19:13:00] <ALR> rbattenfeld: Did you use the generated tests to seed these static ones?
[19:14:39] <rbattenfeld> ALR: No, I used my XML editor for producing a fully covering xml sample and wrote the descriptor part from hand.
[19:15:00] <rbattenfeld> ALR: THe compare then is done by XmlUnit
[19:16:18] <ALR> Suuuper.
[19:16:34] <ALR> The old tests had this "assertXPath" method
[19:16:38] <ALR> Which was kinda cool
[19:16:57] <ALR> I need to look more at the work that was actually done.
[19:17:04] <ALR> I haven't gotten a chance yet, sorry.
[19:17:20] <ALR> Just got it to build and do git stuff, and see generally that the packages were nicely split.
[19:17:42] <rbattenfeld> ALR: I think, XmlUnit supports this and much more
[19:17:49] <ALR> Definitely.
[19:18:13] <rbattenfeld> ALR: By the way, Aslak pointet me on a thread in the arquillian forum. A guy asled for websphere resource descriptors. I had a talk with him and he sent the xsd's. I will have a look. What do you think about this?
[19:18:37] <rbattenfeld> ALR: * asked *
[19:20:12] <ALR> rbattenfeld: I think I'm not super enthused about it. :)
[19:20:20] <ALR> I mean, sure.  But I wouldn't prioritize it.
[19:20:27] <ALR> It'd be another separate module.
[19:25:03] <rbattenfeld> ALR: yes, definetly! This guy pointet me to something related... I believe that the generation process is something that shouldn't be considered as a thing that supports all existing descriptors out of the box. I see it more as 'I need support for descriptor X, can you provide this within some days '
[19:25:40] <ALR> rbattenfeld: Right, I think we discussed this before in the context of JCA/IronJacamar needing this.
[19:25:52] <ALR> Or at least, I discussed it w/ maeste and Jesoer.
[19:25:55] <ALR> Jesper :)
[19:26:41] <rbattenfeld> ALR: Good, so we are inline:-) It doesn't mean that we cannot add new descriptors within a minute:-)
[19:27:51] <ALR> Awesome.
[19:27:54] <ALR> I'm off for a bit.
[19:28:44] *** ALR has quit IRC
[19:32:08] *** rbattenfeld has left #jbosstesting
[19:32:57] *** dblevins has joined #jbosstesting
[19:38:50] *** Jaikiran has quit IRC
[19:43:48] *** rbattenfeld has joined #jbosstesting
[19:44:21] *** lightguard_jp has quit IRC
[19:50:36] *** rbattenfeld has left #jbosstesting
[20:30:26] *** kevinpollet has quit IRC
[20:34:15] *** rruss has quit IRC
[20:34:57] *** alesj has joined #jbosstesting
[20:55:17] *** lightguard_jp has joined #jbosstesting
[21:03:22] *** galderz has joined #jbosstesting
[21:03:26] *** mgoldmann has quit IRC
[21:04:51] *** mhuniewicz has joined #jbosstesting
[21:05:15] *** lightguard_jp has quit IRC
[21:17:12] *** rruss has joined #jbosstesting
[21:20:45] <jose_freitas> hey aslak, how you doing?
[21:32:57] *** aslak has quit IRC
[21:34:47] *** pil-dinner is now known as pilhuhn
[21:37:14] *** mdobozy has joined #jbosstesting
[21:44:35] *** nilian has joined #jbosstesting
[21:54:07] *** aslak has joined #jbosstesting
[22:04:26] *** nilian has quit IRC
[22:08:28] *** lfryc_wfh has quit IRC
[22:26:04] *** pilhuhn is now known as pilhuhn-sleep
[22:38:07] *** mdobozy has quit IRC
[22:45:44] *** mhuniewicz has quit IRC
[22:46:06] *** mhuniewicz has joined #jbosstesting
[23:22:00] *** galderz has quit IRC
[23:37:35] *** kevinpollet has joined #jbosstesting
[23:42:11] *** jose_freitas_aw has joined #jbosstesting
[23:43:59] *** jose_freitas has quit IRC
[23:44:27] *** jdlee has quit IRC
[23:46:43] *** jdlee has joined #jbosstesting
[23:48:50] *** jose_freitas_aw has quit IRC
[23:51:38] *** jose_freitas has joined #jbosstesting





top