[00:24:39] <mhuniewicz> Good night [00:24:40] *** mhuniewicz has quit IRC [00:37:58] *** aslak has quit IRC [00:38:29] *** alesj has quit IRC [01:47:09] *** stuartdouglas has quit IRC [01:53:22] *** stuartdouglas has joined #jbosstesting [02:14:48] *** jbott has quit IRC [02:20:55] *** ianbrandt has quit IRC [02:38:11] *** rruss has quit IRC [02:45:05] *** ALR has joined #jbosstesting [03:04:48] *** jganoff has joined #jbosstesting [03:29:24] *** ldimaggi has joined #jbosstesting [04:09:37] *** jbott has joined #jbosstesting [04:40:24] *** lightguard_jp is now known as lightguard_jp_aw [05:02:21] *** rruss has joined #jbosstesting [05:06:36] *** rruss has quit IRC [05:51:34] *** bleathem has joined #jbosstesting [05:56:33] *** ldimaggi has quit IRC [06:26:02] *** jganoff has quit IRC [06:45:29] *** maeste has joined #jbosstesting [06:56:34] *** lightguard_jp_aw is now known as lightguard_jp [07:14:03] *** lightguard_jp has quit IRC [07:30:59] *** rruss has joined #jbosstesting [07:38:47] *** jharting has joined #jbosstesting [07:47:50] *** dmlloyd has quit IRC [07:47:59] *** jbossbot has quit IRC [08:02:37] *** bleathem has quit IRC [08:02:41] *** Jaikiran has joined #jbosstesting [08:02:51] *** dmlloyd has joined #jbosstesting [08:05:56] *** jbossbot has joined #jbosstesting [08:07:10] *** tdiesler has joined #jbosstesting [08:20:08] *** mgoldmann has joined #jbosstesting [08:28:11] *** Jaikiran has quit IRC [08:29:12] *** Jaikiran has joined #jbosstesting [08:46:14] *** lfryc has joined #jbosstesting [08:51:58] *** ge0ffrey has joined #jbosstesting [08:57:34] *** rruss has quit IRC [09:08:10] *** kevinpollet has joined #jbosstesting [09:08:24] *** rruss has joined #jbosstesting [09:13:01] *** rruss has quit IRC [09:21:19] *** maeste has quit IRC [09:29:18] *** pilhuhn has joined #jbosstesting [09:29:18] *** pilhuhn has joined #jbosstesting [09:31:47] *** kpiwko has joined #jbosstesting [09:38:07] *** oskutka has joined #jbosstesting [09:38:30] *** jhuska has joined #jbosstesting [09:47:14] *** aslak has joined #jbosstesting [09:47:28] <aslak> ALR, ping [09:47:35] <ALR> aslak: Yo [09:47:44] <aslak> ALR, good morning..:) [09:47:48] <ALR> And to you [09:47:56] <aslak> ALR, did you get to the awards thinggy ? [09:48:01] <ALR> I went to bed at like 8:30 last night. The office exhausted me. [09:48:06] <ALR> I've a draft. [09:48:22] <aslak> ALR, hehe [09:48:25] <ALR> Due today [09:48:39] <aslak> ALR, yea, that's what i remembered.. :) [09:48:45] <ALR> Good call. [09:48:54] <ALR> I wonder if I woulda seen my calendar alert [09:49:12] <aslak> :) [09:49:34] <ALR> Odd process [09:49:40] <ALR> It's a .doc you email [09:49:52] <ALR> aslak: I'll finish up that draft now. [10:07:16] *** galderz has joined #jbosstesting [10:19:46] *** maeste has joined #jbosstesting [11:15:53] *** alesj has joined #jbosstesting [11:33:20] <ALR> aslak: So I've nearly got SD generating code into new modules. [11:33:49] <ALR> Meaning the build should be taking care of the whole thing. [11:35:49] *** tdiesler has quit IRC [11:45:41] *** bgeorges has joined #jbosstesting [11:52:05] *** bcave has quit IRC [11:52:12] <aslak> ALR, nice [11:52:22] <aslak> ALR, two steps ? one for api and one impl ? [11:52:28] *** galderz has quit IRC [11:52:32] *** galderz1 has joined #jbosstesting [11:52:51] <ALR> aslak: It's one step [11:53:06] <ALR> Well, the java source generation part is one step [11:53:16] <ALR> And depending upon what we're generating, put it into the right module [11:53:23] <ALR> But it needs to be broken up more [11:53:37] <ALR> For instance api-jboss, api-javaee5, api-javaee6 [12:03:40] *** galderz1 has quit IRC [12:18:33] *** kevinpollet has quit IRC [12:19:17] *** galderz has joined #jbosstesting [12:33:44] *** mgoldmann has quit IRC [12:54:44] *** pilhuhn is now known as pil-lunch [13:16:56] *** ldimaggi has joined #jbosstesting [13:28:19] <jbossbot> git [descriptors] push master 7508090.. Andrew Lee Rubinger [SHRINKDESC-60] Node.removeAttribute on an attribute which does not exist should return null (by contract) [13:28:20] <jbossbot> jira [SHRINKDESC-60] Support Node.removeAttribute [Resolved (Done) Feature Request, Major, Ken Gullaksen] https://issues.jboss.org/browse/SHRINKDESC-60 [13:28:20] <jbossbot> git [descriptors] push master URL: http://github.com/shrinkwrap/descriptors/compare/032aab2...7508090 [13:34:13] *** alesj has quit IRC [13:34:57] *** jose_freitas has joined #jbosstesting [13:37:36] <jbossbot> git [descriptors] push SHRINKDESC-54 dd58cb1.. ralfbattenfeld [SHRINKDESC-54] Development of EE and JBoss-specific Descriptors into API/Impl split [13:37:37] <jbossbot> jira [SHRINKDESC-54] Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split [Open (Unresolved) Task, Major, Ralf Battenfeld] https://issues.jboss.org/browse/SHRINKDESC-54 [13:37:38] <jbossbot> git [descriptors] push SHRINKDESC-54 52e4cb4.. Andrew Lee Rubinger [SHRINKDESC-54] Refactoring to new SPI, move generated sources into their own modules and ignore them in version control. [13:37:38] <jbossbot> git [descriptors] push SHRINKDESC-54 URL: http://github.com/shrinkwrap/descriptors/compare/f6ac2c1...52e4cb4 [13:39:45] *** kevinpollet has joined #jbosstesting [13:41:38] *** jharting has quit IRC [13:42:25] <jose_freitas> morning [13:44:33] <jbossbot> git [descriptors] push master 368b3c0.. Andrew Lee Rubinger [SHRINKDESC-60] Throw IllegalArgumentException on null input to Node.removeAttribute [13:44:34] <jbossbot> jira [SHRINKDESC-60] Support Node.removeAttribute [Resolved (Done) Feature Request, Major, Ken Gullaksen] https://issues.jboss.org/browse/SHRINKDESC-60 [13:44:34] <jbossbot> git [descriptors] push master URL: http://github.com/shrinkwrap/descriptors/compare/7508090...368b3c0 [13:45:13] <jbossbot> git [descriptors] push SHRINKDESC-54 836f544.. ralfbattenfeld [SHRINKDESC-54] Development of EE and JBoss-specific Descriptors into API/Impl split [13:45:14] <jbossbot> jira [SHRINKDESC-54] Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split [Open (Unresolved) Task, Major, Ralf Battenfeld] https://issues.jboss.org/browse/SHRINKDESC-54 [13:45:14] <jbossbot> git [descriptors] push SHRINKDESC-54 8981a5c.. Andrew Lee Rubinger [SHRINKDESC-54] Refactoring to new SPI, move generated sources into their own modules and ignore them in version control. [13:45:14] <jbossbot> git [descriptors] push SHRINKDESC-54 URL: http://github.com/shrinkwrap/descriptors/compare/52e4cb4...8981a5c [13:45:43] <ALR> aslak: http://jboss.hudson.alrubinger.com/job/Descriptors_SHRINKDESC-54/1/testReport/ [13:45:53] <ALR> aslak: 1,650 tests [13:46:25] <ALR> aslak: The branch in upstream/SD-54 is now totally self-building. [13:46:42] <ALR> Gen runs on its own by default, copies to the right locations, and tests itself. [13:46:50] <ALR> No gen'd files are stored in source control. [13:47:26] *** pil-lunch is now known as pilhuhn [13:47:55] <ALR> aslak: I wanna get the SPI stuff locked. [13:48:00] <ALR> Then this can become the new upstream [13:48:26] <ALR> aslak: So since the new SPI stuff is already in ARQ, how does it look to you for locking down? [13:52:51] <aslak> 1.650 generated tests.. should stress SPI i guess.. :) [13:53:14] *** rruss has joined #jbosstesting [13:53:32] <aslak> ALR, locking down SPI or the new api/impl ? [13:53:45] <ALR> aslak: SPI. [13:53:55] <ALR> aslak: I think the "new" API will look like: [13:54:17] <ALR> "api-base" == what we have now. Then api-javaee5, api-javaee6, api-jboss. [13:54:33] <ALR> Or maybe just one api-javaee [13:55:19] *** maeste has quit IRC [13:56:19] <aslak> spi lockdown is fine from my side.. [13:56:24] <aslak> ALR, heard anything from lincoln ? [13:56:51] <ALR> aslak: No. [13:57:06] <ALR> aslak: Meaning you reviewed the SPI and like it? :) [13:57:27] *** rruss has quit IRC [13:58:59] *** maeste has joined #jbosstesting [14:01:40] <aslak> ALR, mm, there was the question if the DescriptorImporterBase really should be a extends point [14:02:07] <aslak> or rather.. is XMLDomImporter really a DescriptorImporter [14:02:43] <aslak> XMLDomImporter only cares about how to convert a InputStream to a Node [14:02:47] <ALR> One sec [14:02:50] <ALR> Wrapping up a doc [14:04:52] <jbossbot> git [descriptors] push SHRINKDESC-54 93d3239.. Andrew Lee Rubinger [SHRINKDESC-54] Trim maintenance burden of Strings util class to only what is used [14:04:53] <jbossbot> jira [SHRINKDESC-54] Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split [Open (Unresolved) Task, Major, Ralf Battenfeld] https://issues.jboss.org/browse/SHRINKDESC-54 [14:04:53] <jbossbot> git [descriptors] push SHRINKDESC-54 3975934.. Andrew Lee Rubinger [SHRINKDESC-54] Document Child API [14:04:53] <jbossbot> git [descriptors] push SHRINKDESC-54 URL: http://github.com/shrinkwrap/descriptors/compare/8981a5c...3975934 [14:05:11] <ALR> aslak: OK back [14:06:10] <jbossbot> git [arquillian-container-glassfish] push master 3d3d19a.. zpaulovics ARQ-269 ARQ-527 ARQ-449 Implementing the GlassFish compatible way of deployment using the "target" & some new features... [14:06:11] <jbossbot> jira [ARQ-269] Consolidate the remote host configuration for GlassFish Remote [Open (Unresolved) Feature Request, Minor, Dan Allen] https://issues.jboss.org/browse/ARQ-269 [14:06:12] <jbossbot> jira [ARQ-527] EAR deployment on remote container in server mode [Open (Unresolved) Patch, Critical, Unassigned] https://issues.jboss.org/browse/ARQ-527 [14:06:12] <jbossbot> jira [ARQ-449] Add support for SSL on Admin console [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/ARQ-449 [14:06:13] <jbossbot> git [arquillian-container-glassfish] push master URL: http://github.com/arquillian/arquillian-container-glassfish/compare/5e3113c...3d3d19a [14:10:15] <aslak> ALR, yes, we have the DescriptorImporterBase to support for some convenience in the overloading of methods, File, String, InputStream.. so we can do less work in the actual importer [14:10:52] <ALR> The importer ain't doing much [14:10:52] <aslak> ALR, but the DescriptorImporter also bring long some uninteresting / unconvenience things like enduserView [14:11:44] <aslak> DescriptorImporter is the API, while we could wrap the SPI NodeImporter in the 'DescriptorImporterBase' [14:12:01] <aslak> the DescriptorImporterBase then becomes the one that ties API and SPI together. [14:12:08] <ALR> You mean createImporterFromUserView [14:12:49] <aslak> ALR, i mean, the user care about: DescriptorImporter.from(File|InputStream|String) [14:12:57] <ALR> Right [14:13:07] <ALR> I'm looking for a good place to make the importer instance though [14:13:08] <aslak> the XMLImporter / dev care about public Node importRootNode(InputStream stream) [14:13:33] <ALR> I think this is a problem: [14:13:34] <ALR> public abstract Node importRootNode(InputStream stream) throws DescriptorImportException; [14:13:44] <ALR> in DescriptorImporterBase [14:13:52] <ALR> It assumes we have a Node-based Descriptor [14:14:14] <ALR> We have to keep in mind that not all descriptors are/will be XML [14:14:18] <ALR> Like props files. [14:15:52] <aslak> ALR, that depends.. should it be something else then Node or is it a type of Node [14:17:13] <ALR> Well, as it stands now, Node is our internal view of hierarchial/tree structures [14:31:13] <aslak> and a property file is a flat tree structure.. ehhe [14:51:29] *** pilhuhn is now known as pil-biab [15:10:58] *** jose_freitas has quit IRC [15:11:00] *** rruss has joined #jbosstesting [15:14:21] *** pil-biab is now known as pilhuhn [15:18:21] *** jeand has joined #jbosstesting [15:26:22] *** jose_freitas has joined #jbosstesting [15:28:52] *** galderz has quit IRC [15:36:58] *** galderz has joined #jbosstesting [15:59:35] *** maeste has quit IRC [15:59:54] *** maeste has joined #jbosstesting [16:00:16] *** maeste has quit IRC [16:05:15] *** maeste has joined #jbosstesting [16:09:42] *** maeste2 has joined #jbosstesting [16:10:03] *** maeste has quit IRC [16:11:17] *** jeand has quit IRC [16:12:34] *** maeste2 has quit IRC [16:14:19] *** maeste has joined #jbosstesting [16:22:06] *** maeste has quit IRC [16:27:02] *** jeand has joined #jbosstesting [16:32:36] *** bleathem has joined #jbosstesting [16:48:08] <jbossbot> git [descriptors] push SHRINKDESC-54 6a9b0c3.. Andrew Lee Rubinger [SHRINKDESC-54] Add support for connector_1_6.xsd [16:48:10] <jbossbot> jira [SHRINKDESC-54] Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split [Open (Unresolved) Task, Major, Ralf Battenfeld] https://issues.jboss.org/browse/SHRINKDESC-54 [16:48:10] <jbossbot> git [descriptors] push SHRINKDESC-54 URL: http://github.com/shrinkwrap/descriptors/compare/3975934...6a9b0c3 [16:50:58] *** galderz1 has joined #jbosstesting [16:53:29] *** galderz has quit IRC [16:56:45] *** galderz has joined #jbosstesting [16:59:00] *** galderz1 has quit IRC [17:00:21] <jbossbot> git [descriptors] push SHRINKDESC-54 dfdebe5.. Andrew Lee Rubinger [SHRINKDESC-54] Centralize services files [17:00:22] <jbossbot> jira [SHRINKDESC-54] Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split [Open (Unresolved) Task, Major, Ralf Battenfeld] https://issues.jboss.org/browse/SHRINKDESC-54 [17:00:22] <jbossbot> git [descriptors] push SHRINKDESC-54 URL: http://github.com/shrinkwrap/descriptors/compare/6a9b0c3...dfdebe5 [17:03:24] *** oskutka has quit IRC [17:05:11] *** galderz has quit IRC [17:10:46] *** galderz has joined #jbosstesting [17:22:31] *** dmlloyd has quit IRC [17:22:31] *** jbossbot has quit IRC [17:23:05] *** aslak has quit IRC [17:36:11] *** Jaikiran has quit IRC [17:36:41] *** galderz has quit IRC [17:37:20] *** kevinpollet has quit IRC [17:40:08] *** kpiwko has quit IRC [17:45:23] *** lfryc has quit IRC [17:51:55] *** jhuska has quit IRC [17:52:47] *** oskutka has joined #jbosstesting [18:09:16] *** maeste has joined #jbosstesting [18:22:21] *** pilhuhn has quit IRC [18:25:31] *** bleathem has quit IRC [18:28:10] *** oskutka has quit IRC [18:28:15] *** jbossbot has joined #jbosstesting [18:29:30] *** dmlloyd has joined #jbosstesting [18:30:31] *** ge0ffrey has quit IRC [18:40:19] *** aslak has joined #jbosstesting [18:46:49] *** ge0ffrey has joined #jbosstesting [18:48:13] *** ianbrandt has joined #jbosstesting [19:00:54] *** maeste has quit IRC [19:17:38] *** galderz has joined #jbosstesting [19:21:54] *** galderz has quit IRC [19:40:08] *** jeand has quit IRC [19:55:08] *** jeand has joined #jbosstesting [20:04:16] *** jhuska has joined #jbosstesting [20:26:03] *** vtunka has quit IRC [20:34:13] *** bgeorges has quit IRC [20:35:36] *** alesj has joined #jbosstesting [20:37:46] *** alesj has quit IRC [20:42:49] *** rruss has quit IRC [20:45:12] *** lightguard_jp has joined #jbosstesting [20:50:37] *** alesj has joined #jbosstesting [21:00:15] *** dblevins has joined #jbosstesting [21:01:32] *** ge0ffrey has quit IRC [21:45:42] *** lfryc has joined #jbosstesting [21:49:52] *** jeand has quit IRC [21:52:06] *** jhuska has quit IRC [22:27:04] *** rbattenfeld1 has joined #jbosstesting [22:28:11] <rbattenfeld1> ALR: Hi Andrew, really cool work you have done! [22:42:24] *** rbattenfeld1 has left #jbosstesting [22:55:06] *** bleathem has joined #jbosstesting [23:02:31] *** jose_freitas has quit IRC [23:14:41] *** mojavelinux has joined #jbosstesting [23:17:24] *** ldimaggi has quit IRC [23:42:46] *** lfryc has quit IRC [23:57:23] <ianbrandt> aslak: Can do regarding starting comments with the JIRA issue ID. Do you want a JIRA for every pull request (e.g. minor cleanups and such), or just that we start pull request comments with the issue ID if there is one?