[00:03:42] <ianbrandt> aslak, the Tomcat container references arquillian-build and that seems okay, but I'm new so surely I'm not aware of all the concerns. Compared to the prior repo it's a huge improvement. [00:04:31] <ianbrandt> aslak, so are you saying the idea would be you shouldn't even need core in order to build each set of container modules? [00:26:55] *** rruss has quit IRC [00:37:01] <aslak> ianbrandt, well, you need core modules, but they shouldn't rely on poms from core (besides BOM which is imported) to build. so no parent dependency [00:37:21] <aslak> ianbrandt, at least thats the current plan until i change it.. ;) [00:37:59] <aslak> ianbrandt, but bed time here.. fire me a email, post on the forums if you still have problems.. see you tomorrow.. :) [00:38:52] *** aslak has quit IRC [00:39:42] *** PeteRoyle has joined #jbosstesting [00:43:17] *** aaronwalker has joined #jbosstesting [00:44:09] *** mgoldmann has quit IRC [01:23:56] *** ALR has quit IRC [01:30:01] *** johnament has joined #jbosstesting [02:28:58] <PeteRoyle> does <arquillian><engine><deploymentExportPath> work in arq alpha 5? [02:38:01] *** rruss has joined #jbosstesting [02:52:58] *** ldimaggi has joined #jbosstesting [03:17:55] *** Diablo-D3 has joined #jbosstesting [03:47:56] *** lightguard_jp has quit IRC [03:59:20] *** rruss has quit IRC [04:08:53] *** rruss has joined #jbosstesting [04:20:56] *** ianbrandt has quit IRC [05:02:51] *** rruss has quit IRC [05:03:35] *** lightguard_jp has joined #jbosstesting [05:28:21] *** ldimaggi has quit IRC [05:35:52] *** rruss has joined #jbosstesting [07:15:57] *** ianbrandt has joined #jbosstesting [07:16:48] *** ianbrandt has quit IRC [07:37:39] *** tdiesler has quit IRC [08:13:03] *** lfryc has joined #jbosstesting [08:16:03] *** kpiwko has joined #jbosstesting [08:17:19] *** Jaikiran has joined #jbosstesting [08:34:45] *** tdiesler has joined #jbosstesting [08:59:47] *** oskutka has joined #jbosstesting [09:03:36] *** ge0ffrey has joined #jbosstesting [09:05:47] *** aslak has joined #jbosstesting [09:07:34] *** jeand has joined #jbosstesting [09:09:37] *** jharting has joined #jbosstesting [09:17:44] *** mgoldmann has joined #jbosstesting [09:17:45] *** mgoldmann has quit IRC [09:17:46] *** mgoldmann has joined #jbosstesting [09:23:06] *** lightguard_jp has quit IRC [09:25:35] *** lightguard_jp has joined #jbosstesting [09:28:26] *** rruss has quit IRC [10:09:54] *** wolfc has joined #jbosstesting [10:10:14] *** davidbos has joined #jbosstesting [10:11:13] *** Jaikiran is now known as Jaikiran|Lunch [10:23:42] *** alesj has joined #jbosstesting [10:26:51] *** aslak has quit IRC [10:31:19] *** bcave has joined #jbosstesting [10:52:25] *** aaronwalker has quit IRC [10:54:26] <bcave> org.jboss.arquillian.spi.client.container.LifecycleException: Bad shit happened [10:57:21] <jeand> I'm betting this is the tomcat container integration ? [10:57:57] <jeand> If so pardon my french [10:58:20] <bcave> oui oui :) [10:58:39] <bcave> would that be a CP issue? [10:59:16] <jeand> it's been a while since I contributed tomcat integration so not sure [10:59:19] <bcave> Arq alpha5 + shrinkwrap-extension-tomcat 1.0.0 alpha-12 [10:59:19] <jeand> it can be many things [10:59:32] <jeand> could you pastebin the full stacktrace ? [10:59:40] <jeand> to see if that gives more information [11:01:32] <bcave> ah, ok [11:01:44] *** davidbos1 has joined #jbosstesting [11:01:49] <bcave> found the problem, PEBKAC error. [11:02:35] *** davidbos has quit IRC [11:06:15] *** davidbos1 has quit IRC [11:08:33] *** lightguard_jp has quit IRC [11:15:38] <jeand> bcave, ok :-) [11:16:42] <bcave> (port was in use). now that thats fixed, i am back at the original error i was getting. http://pastie.org/1884344 [11:19:12] <bcave> ah... ARQ-410 [11:19:14] <jbossbot> jira [ARQ-410] NPE in ContainerDeployController.forEachManagedDeployment() [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/ARQ-410 [11:22:29] <bcave> took the comments out of the in-container web.xml and voila [11:25:14] *** Jaikiran|Lunch is now known as Jaikiran [11:31:45] *** aslak has joined #jbosstesting [11:38:54] *** pmuir has joined #jbosstesting [11:38:54] *** pmuir has quit IRC [11:38:54] *** pmuir has joined #jbosstesting [11:41:01] *** alesj has quit IRC [11:41:43] *** alesj has joined #jbosstesting [11:42:26] *** davidbos has joined #jbosstesting [11:42:54] *** johnament has quit IRC [11:45:26] *** alesj has quit IRC [11:46:06] *** alesj has joined #jbosstesting [11:46:51] *** maschmid has joined #jbosstesting [12:13:42] <bcave> im trying to understand the problem with ArquillianServletRunner not found. Could not determine ContextRoot from ProtocolMetadata, please contact DeployableContainer developer. [12:14:17] <bcave> alesj / aslak - found an irc log where this problem was discussed, but not sure of what was being discussed... [12:14:24] <bcave> http://echelog.matzon.dk/logs/browse/jbosstesting/1300489200 [12:15:27] <bcave> and this discussion too - http://209.132.182.48/message/598525 [12:25:59] <aslak> bcave, which container is this? [12:26:14] <bcave> tomcat 6 [12:26:18] <bcave> im seeing now.. [12:26:23] <bcave> @ArquillianResource URL [12:28:20] <aslak> bcave, what is your deployment ? [12:28:36] <bcave> WAR [12:29:17] <aslak> bcave, alpha5 ? [12:29:22] <bcave> hang on, will pb some additional info. [12:29:37] <bcave> yeah, alpha5 with shrinkwrap-extension-tomcat-6 alpha 12 [12:30:14] <bcave> pasting the deps for the test in gradle syntax.... [12:30:28] <bcave> http://pastie.org/1884531 [12:30:57] <bcave> and junit 4.8.1 [12:31:33] <aslak> bcave, can you debug? [12:32:38] <aslak> bcave, no deployment exceptions btw? [12:33:11] <aslak> bcave, somethings wrong around this line: https://github.com/arquillian/arquillian-container-tomcat/blob/1.0.0.Alpha5/containers/tomcat-embedded-6/src/main/java/org/jboss/arquillian/container/tomcat/embedded_6/TomcatContainer.java#L204 [12:33:52] <aslak> with the returned ProtocolMetaData.. [12:34:14] <aslak> basically it's missing the ArquillianServletRunner in as a Servlet in HttpContext returned in ProtocolMetadata [12:36:30] <bcave> i'll debug now... [12:36:33] <bcave> http://pastie.org/1884550 [12:36:39] <bcave> thats the test case [12:37:42] <bcave> basically, i should add the @ArquillianResource to the test method? [12:38:05] <bcave> stack trace: http://pastie.org/1884562 [12:38:16] <aslak> bcave, no, your testing incontainer, so you won't have access to the URL resource there [12:41:16] <aslak> bcave, hmm.. shouldn't context.xml be in /META-INF ? your currently placing it in /WEB-INF/META-INF i think [12:42:17] <aslak> you can do: .addAsWebInfResource("it-beans.xml", "beans.xml") [12:42:34] <aslak> .addAsManifestResource("it-context.xml", "context.xml") [12:44:21] <aslak> .addAsResource("it-log4j.xml", "META-INF/log4j.xml") [12:45:06] <aslak> WebInfResource = /WEB-INF, ManifestResource = /META-INF , Resource = /WEB-INF/classes [12:45:37] <aslak> WebResource = / [12:47:10] *** timte has joined #jbosstesting [12:50:58] *** aaronwalker has joined #jbosstesting [13:17:05] *** tdiesler has quit IRC [13:32:27] <aslak> bcave, did that help at all? [13:36:37] *** tdiesler has joined #jbosstesting [13:41:47] <lfryc> how is it going with ARQ-74 ? [13:41:48] <jbossbot> jira [ARQ-74] Base test deployment on project in which test is run [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/ARQ-74 [13:41:49] <bcave> sorry aslak, scrum meeting took a while [13:44:22] <aslak> lfryc, no progress currently, recommendation is to use integration-phase [13:44:38] *** pmuir has quit IRC [13:44:39] <lfryc> ok, thanks Aslak [13:45:08] <lfryc> aslak: and what about reusing the deployment between tests? [13:45:40] <aslak> lfryc, have to revisit that for 1.1 [13:47:24] *** maeste has joined #jbosstesting [13:48:56] <lfryc> aslak: hmm, will see how fast will be deployment when continuously redeploying WAR with 163 classes on AS :-) [13:49:22] <aslak> :) [13:51:52] <aslak> lfryc, selenium stuff right? [13:52:09] <lfryc> aslak: yes, trying to migrate RF tests to Arq + Ajocado [13:53:41] <aslak> lfryc, what handles the deployment today? [13:54:05] <lfryc> aslak: maven cargo2 plugin [13:54:23] <lfryc> aslak: one deployment per suite [13:56:02] <bcave> aslak: same error with those changes to the abstract test case. http://pastie.org/1884761 [13:56:19] *** vtunka has quit IRC [13:56:51] <aslak> bcave, ok odd.. then you need to debug the DeployableContainer deploy(Archive), for some reason it doesn't manage to populate the ProtocolMetadata [13:57:01] <bcave> ok [13:58:30] <bcave> i'll do that now. when we were using alpha4 with shrinkwrap alpha 11 and protocol-servlet-3 alpha4, this was working for the deploy: http://pastie.org/1884776 [14:00:07] *** alesj has quit IRC [14:00:51] <aslak> lfryc, being that your only doing client side testing, i think you might be able to hack around that behavior with a extension [14:00:53] *** alesj has joined #jbosstesting [14:01:15] <aslak> bcave, yea, the ProtocolMetadata came in Alpha5 [14:02:26] <bcave> ah, right. the client-side testing would be similar to other client testing frameworks, right (like selenium) [14:03:14] <aslak> bcave, ? [14:03:28] <bcave> jumping topics while i set up the debug [14:03:29] <bcave> :p [14:03:36] <aslak> hehe ok [14:03:37] <aslak> yes [14:03:59] <aslak> bcave, but your doing incontainer testing.. :) [14:05:39] <lfryc> aslak: how are handled @Before/@BeforeMethod? I don't get them called when running as client tests [14:05:44] <bcave> yeah - just came across the client-side notes on the docs page [14:06:27] <bcave> we're using a different framework for client-side smoke tests. [14:09:51] <aslak> lfryc, yea, that's a little bug / missing feature. they are moved to execute incontainer only.. Missed the client side part when RunAsClient. [14:10:09] <lfryc> aslak: already filed? :-) [14:10:16] *** vtunka has joined #jbosstesting [14:10:32] <aslak> lfryc, the mixed modes and multi contianer kinda mess it up a bit as well, so we need to have support for @RunAsClient and @OperatesOnDeployment support on @Before/@BeforeClass as well [14:10:39] <aslak> lfryc, yea [14:11:11] <lfryc> aslak: seems good :-) [14:11:35] <aslak> lfryc, the problem is of course that we then need to digg down a bit deeper into the test framework then we currently do [14:12:33] <aslak> lfryc, currently we execute or not the Before/BeforeClass phase, with this change we need to filter the methods and pass data to the container about which container it is [14:23:57] *** ge0ffrey has quit IRC [14:26:33] *** ge0ffrey has joined #jbosstesting [14:26:36] <aslak> lfryc, fyi, we have a cloudbees jenkins account running for arquillian now. https://arquillian.ci.cloudbees.com/ let me know if you want access [14:27:20] <lfryc> aslak: not sure we will be able to run selenium tests there [14:27:43] <aslak> lfryc, no idea.. [14:28:01] <aslak> lfryc, i know Jay had a account as well, but hadn't played around with it to much yet he said [14:28:25] *** michaelschuetz has joined #jbosstesting [14:28:29] <lfryc> aslak: ok, please create account for me and I will try what we can get from it ;-) [14:33:23] <aslak> lunch [14:33:26] *** PeteRoyle has quit IRC [14:50:29] <tdiesler> aslak, hi [14:50:56] <tdiesler> aslak, how about adding the callback to the jmx protocol only. Like we have already [14:55:52] *** ldimaggi has joined #jbosstesting [14:57:25] *** vtunka has quit IRC [15:11:17] *** vtunka has joined #jbosstesting [15:12:13] *** rruss has joined #jbosstesting [15:13:43] *** rruss has quit IRC [15:18:44] *** torben has joined #jbosstesting [15:23:40] *** oskutka has quit IRC [15:55:34] *** lfryc has quit IRC [16:02:07] *** oskutka has joined #jbosstesting [16:04:10] <bcave> brb [16:04:13] *** bcave has quit IRC [16:15:46] *** jharting has quit IRC [16:38:35] *** rruss has joined #jbosstesting [16:44:40] *** bcave has joined #jbosstesting [16:46:51] *** davidbos has quit IRC [16:48:02] *** ianbrandt has joined #jbosstesting [16:50:20] *** timte has quit IRC [16:52:44] <bcave> aslak: haven't been able to debug the TomcatContainer [16:52:47] <bcave> :-/ [16:56:41] *** lfryc has joined #jbosstesting [16:58:53] *** oskutka has quit IRC [17:00:25] *** mgoldmann has quit IRC [17:25:06] *** michaelschuetz has quit IRC [17:25:24] * bcave reverts to Alpha4 for now :p [17:29:54] *** Jaikiran is now known as Jaikiran|Dinner [17:35:13] *** kpiwko has quit IRC [17:36:05] *** alesj has left #jbosstesting [17:45:04] *** maschmid has quit IRC [17:48:00] *** Diablo-D3 has left #jbosstesting [18:00:40] *** bcave has quit IRC [18:02:57] <ianbrandt> aslak: Hello again. Just after we wrapped up our chat yesterday my arquillian-container-jbossas got through downloading and compiling, but ultimately jbossas-embedded-6 had failed tests as well. I wanted to use it as an example for migrating arquillian-tomcat-embedded-6 from a DeployableContainer+AuxiliaryArchiveAppender to a LoadableExtension, which is how I understood your tip about the SPI changes. I saw the reference to [18:02:57] <ianbrandt> https://arquillian.ci.cloudbees.com/ in today's earlier chat logs. It's great to see the new repo is setup in Hudson. As it happens the ci build for arquillian-tomcat-embedded-6 is failing on the exact same error mine is. However the ci errors for jbossas-embedded-6 [18:02:58] <ianbrandt> (https://arquillian.ci.cloudbees.com/job/Arquillian-Container-JBossAS/1/org.jboss.arquillian.container$arquillian-jbossas-embedded-6/testReport/junit/org.jboss.arquillian.container.jbossas.embedded_6/JBossASEmbeddedIntegrationTestCase/org_jboss_arquillian_container_jbossas_embedded_6_JBossASEmbeddedIntegrationTestCase/) are different from mine (http://pastebin.com/y7hige0H), with my one change being switching the parent from [18:02:58] <ianbrandt> jboss-parent to arquillian-build. I'm afraid I wasn't clear on exactly how you were saying container modules should be setup to build going forward. Could you share a bit more about what your current setup is? For instance if a certain settings.xml is now required could you pastebin the relevant parts of yours? [18:04:34] *** pmuir has joined #jbosstesting [18:04:59] <aslak> ianbrandt, yea, i'm seeing that error locally as well. i was getting it with other containers previously, but that went away auto magically. to be honest, i have no idea why that happens [18:05:16] <aslak> ianbrandt, it's the first time i'm seeing it in maven as well, i thought it was only a eclipse compile issue [18:05:45] <ianbrandt> aslak, I think I have a possible explanation... [18:07:58] <ianbrandt> When I switched back to the old repo to study a working setup, and then switched back the error went away in Maven, but not in Eclipse. Trying to troubleshoot that I nuked my .m2/repostiory/org/jboss/arquillian dir. Then the error came back in Maven. My guess is local repo confusion between the old and new layouts. [18:08:38] <aslak> hmm [18:09:56] <ianbrandt> In Eclipse of course it uses the imported project's classes dirs over the .m2 installed jars, so I think that's why the error never went away for me in Eclipse. [18:15:58] *** rruss has quit IRC [18:22:33] *** ALR has joined #jbosstesting [18:27:34] *** pmuir has quit IRC [18:28:02] *** pmuir has joined #jbosstesting [18:29:54] *** pmuir_ has joined #jbosstesting [18:30:07] *** pmuir_ has quit IRC [18:30:16] *** pmuir__ has joined #jbosstesting [18:30:23] *** pmuir has quit IRC [18:31:13] *** pmuir__ has quit IRC [18:33:32] *** pmuir has joined #jbosstesting [18:37:13] *** mgoldmann has joined #jbosstesting [18:41:01] *** pmuir has quit IRC [18:52:21] *** maeste has quit IRC [18:54:19] <ianbrandt> aslak, Carrying on, I believe I see the arquillian-tomcat-embedded-6 (and Jetty) issue... org.jboss.arquillian.container.test.impl.client.protocol.ProtocolRegistryCreator is looking for META-INF/services/org.jboss.arquillian.spi.client.protocol.Protocol's, which LocalProtocol still is, but arquillian-protocol-servlet has been changed to a META-INF/services/org.jboss.arquillian.core.spi.LoadableExtension. [18:56:39] <ianbrandt> aslak, any prior art or guidance on reworking or replacing ProtocolRegistryCreator? [19:06:31] <aslak> ianbrandt, ProtocolRegistryCreator use the arq.core.api.ServiceLoader which is what you are populating via LoadableExtension. service(Class, Class) [19:10:13] <aslak> ianbrandt, where is your code? [19:22:53] *** lfryc has quit IRC [19:34:17] *** Jaikiran|Dinner has quit IRC [19:49:13] <ianbrandt> aslak, Sorry, had to step away, and now I have to sign off for a bit in a minute. This wasn't my code though if I understand your question, this is on unchanged HEAD. I forked on github, but haven't made any changes yet as I've been trying to just get a passing build. [19:50:49] <aslak> ianbrandt, which repo are yo uon? [19:52:48] <ianbrandt> aslak, New I believe, arquallian-core and arquillian-container-* [19:55:20] <ianbrandt> aslak, I have to sign off. I should be back within the hour. I'll check the chat logs for any updates. Thanks. [19:55:24] *** ianbrandt has left #jbosstesting [19:57:02] *** tdiesler has quit IRC [20:18:39] *** ianbrandt has joined #jbosstesting [20:29:18] <ianbrandt> aslak, I'm back. Did I understand and answer your question about which repo correctly? [20:36:21] *** rruss has joined #jbosstesting [20:37:22] *** ge0ffrey has quit IRC [21:08:02] *** jeand has quit IRC [21:12:22] <ianbrandt> aslak, I just debugged through it again. In my case the ProtocolRegistryCreator ends up with a DynamicServiceLoader, which computes a serviceFile of META-INF/services/org.jboss.arquillian.spi.client.protocol.Protocol. The only one it finds is [21:12:23] <ianbrandt> jar:file:/Users/ibrandt/.m2/repository/org/jboss/arquillian/arquillian-impl-base/1.0.0-SNAPSHOT/arquillian-impl-base-1.0.0-SNAPSHOT.jar!/META-INF/services/org.jboss.arquillian.spi.client.protocol.Protocol, which refers to the LocalProtocol. Then TomcatEmbeddedInContainerTestCase.shouldBeAbleToInjectMembersIntoTestClass fails, as no enrichment seems to happen with the LocalProtocal. Same with JettyEmbeddedInContainerTestC [21:12:23] <ianbrandt> for 6.1 and 7. From your earlier comment I gather that is not the expected behavior, but without a working example or more guidance as to how it should work I fear I don't have enough knowledge to proceed. [21:16:12] *** ldimaggi has quit IRC [21:17:52] *** michaelschuetz has joined #jbosstesting [21:18:13] *** lightguard_jp has joined #jbosstesting [21:32:25] *** dblevins has quit IRC [21:37:39] *** dblevins has joined #jbosstesting [21:40:14] *** ldimaggi has joined #jbosstesting [22:10:27] *** torben has quit IRC [22:17:22] *** jeand has joined #jbosstesting [22:20:17] *** aslak has quit IRC [22:21:31] *** wolfc has quit IRC [22:27:19] *** aaronwalker has quit IRC [22:27:56] *** aaronwalker has joined #jbosstesting [22:33:02] *** PeteRoyle has joined #jbosstesting [22:35:40] *** jeand has quit IRC [22:35:54] *** aslak has joined #jbosstesting [22:39:43] *** ldimaggi has quit IRC [22:41:21] *** mgoldmann has quit IRC [22:45:35] *** rruss has quit IRC [22:49:26] *** PeteRoyle has quit IRC [23:44:36] *** aaronwalker has quit IRC [23:46:40] *** bobmcw has quit IRC [23:46:53] *** bobmcw has joined #jbosstesting [23:56:35] <aslak> ianbrandt, a yes.. the arquillian-impl-base is split up. it's now core-api, core-spi, core-impl, container-api, container-spi, container-impl, container-test-api, container-test-spi, container-test-impl, test-api, test-spi, test-impl, config-api, config-spi, config-impl [23:57:48] <aslak> ianbrandt, from the deployable container impl, you should need, core-spi, container-spi and test-spi for compile. for test you can use arquillian-junit-container which should pull in all the impls etc..