[01:23:07] *** briandealwis has quit IRC
[02:48:09] <paulweb515_> rcjsuen: how do you commit Dean's stuff so he's the author?
[02:48:20] <rcjsuen> paulweb515_: I only changed author field
[02:48:24] <rcjsuen> I guess it only checks committer field
[02:48:37] <rcjsuen> i applied patch + commit, i didn't use a pull request/whatever
[02:50:36] <paulweb515_> rcjsuen: OK, just amend the commit?
[02:50:43] <paulweb515_> before you push, I mean
[02:50:49] <rcjsuen> not sure i follow
[02:50:57] <rcjsuen> his patch is not a git patch
[02:51:18] <rcjsuen> i applied his diff
[02:51:27] <rcjsuen> in the 'Git Staging' view entered his creds into Author
[02:51:28] <rcjsuen> then commit
[02:51:29] <rcjsuen> then push
[02:51:37] <paulweb515_> oh
[04:12:18] *** rcjsuen has quit IRC
[07:27:01] *** borisb6i has joined #eclipse-e4
[08:22:40] *** borisb6i has quit IRC
[09:04:55] *** tschindl has joined #eclipse-e4
[09:18:55] *** borisb6i has joined #eclipse-e4
[09:47:41] *** tschindl has quit IRC
[10:04:59] *** tschindl has joined #eclipse-e4
[12:20:25] *** borisb6i has quit IRC
[13:40:52] *** rcjsuen_ has quit IRC
[13:48:15] *** rcjsuen_ has joined #eclipse-e4
[13:48:15] *** rcjsuen has joined #eclipse-e4
[13:52:46] *** rcjsuen_ has quit IRC
[14:57:59] *** borisb6i has joined #eclipse-e4
[14:59:46] *** borisb6i has quit IRC
[15:37:26] *** yarthorn has joined #eclipse-e4
[15:59:56] <rcjsuen> tschindl: Which update site are you using to install your tools
[16:00:51] <rcjsuen> http://download.eclipse.org/e4/updates/0.11-I-builds seems to have content from June.
[16:00:55] <tschindl> i'm rarely installing them because i've checked them out
[16:01:02] <rcjsuen> But I guess I'll just use them.
[16:01:09] <rcjsuen> oic
[16:01:18] <rcjsuen> I need to install Juno stuff + your tools to check model at runtime
[16:01:27] <rcjsuen> well I'm sure the June release is good enough for me
[16:01:43] <tschindl> well if you check it out and launch an inner you'll have them
[16:02:48] <tschindl> but the fixes since then are not really needed
[16:03:19] <tschindl> i plan to add a feature soon which allows you to search e.g. for labels, ids, ...
[16:03:23] <tschindl> this should make it much easier to find stuff in the livemodel
[16:19:46] <rcjsuen> emoffatt: What do you think about ~358204
[16:19:47] <Arbalest> Bug 358204 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=358204 - Platform / UI / 4.2 - PC / Windows 7 - NEW / normal / - Assignee: Platform-UI-Inbox - [Compatibility] Huge toolbar buttons with EcoreDiagramEditor
[16:23:12] *** tschindl has quit IRC
[16:34:15] <emoffatt> I've commented on the defect...the only thing that comes to mind is that there may be 'text' in the contributions ??
[16:43:38] *** rcjsuen has quit IRC
[16:43:57] *** rcjsuen has joined #eclipse-e4
[17:09:11] <emoffatt> rcjsuen: meeting ?
[17:09:20] <rcjsuen> emoffatt: Did you send me an invite?
[17:48:33] *** borisb6i has joined #eclipse-e4
[17:48:58] *** susanmccourt has joined #eclipse-e4
[18:00:24] *** borisb6i has quit IRC
[18:01:43] <rcjsuen> emoffatt: I've released the last of Dean's patches that I was looking at this morning. If you want to poke at some of them today/tomorrow, feel free.
[19:52:23] *** briandealwis has joined #eclipse-e4
[19:57:41] *** lpereira has joined #eclipse-e4
[20:40:19] *** borisb6i has joined #eclipse-e4
[20:43:08] <rcjsuen> briandealwis: I'm just going to fix ~357295 by calling the show persp command, then we have the handler to consolidate all (?) the code
[20:43:09] <Arbalest> Bug 357295 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=357295 - Platform / UI / 4.1 - All / All - NEW / normal / - Assignee: remysuen - [Compatibility] PerspectiveSwitcher does not respect Open-New-Perspective in New Window setting
[20:43:28] <briandealwis> rcjsuen: sounds good to me
[20:47:13] <rcjsuen> always feels good to delete code
[20:47:24] <rcjsuen> Code that isn't there is safe code >:)
[20:47:45] <briandealwis> Unless it's there to handle some particular situation :)
[20:48:22] <rcjsuen> :)
[20:59:10] <rcjsuen> oh good I knew I committed it somewhere
[20:59:16] <rcjsuen> in a conveniently named bugXXXXXX branch
[21:27:37] *** borisb6i has quit IRC
[21:41:32] *** borisb6i has joined #eclipse-e4
[21:43:36] *** borisb6i has quit IRC
[22:23:15] *** Arbalest has quit IRC
[22:23:37] *** Arbalest has joined #eclipse-e4
[22:29:12] *** rcjsuen has quit IRC
[22:35:25] *** lpereira has quit IRC
[23:10:27] *** rcjsuen has joined #eclipse-e4
[23:15:19] *** rcjsuen_ has joined #eclipse-e4
[23:16:51] *** rcjsuen has quit IRC
[23:26:36] *** yarthorn has quit IRC
[23:47:12] *** rcjsuen_ is now known as rcjsuen





top