[04:01:28] *** rcjsuen has quit IRC
[08:01:25] *** cadorn has quit IRC
[14:09:26] *** rcjsuen_ is now known as rcjsuen
[14:33:48] *** paulweb515_ has quit IRC
[14:35:19] *** paulweb515_ has joined #eclipse-e4
[14:38:06] *** yarthorn has joined #eclipse-e4
[14:48:17] *** briandealwis has joined #eclipse-e4
[15:14:23] *** borisb6i has joined #eclipse-e4
[15:44:25] *** borisb6i has quit IRC
[15:55:46] *** yarthorn has quit IRC
[16:54:58] *** borisb6i has joined #eclipse-e4
[17:04:58] *** cadorn has joined #eclipse-e4
[17:09:42] *** borisb6i has quit IRC
[17:09:49] *** borisb6i has joined #eclipse-e4
[17:22:48] *** tschindl has joined #eclipse-e4
[17:22:56] <tschindl> rcjsuen: got it ~358020
[17:22:57] <Arbalest> Bug 358020 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=358020 - Platform / UI / 4.2 - PC / Mac OS X - NEW / major / - Assignee: Platform-UI-Inbox - [Compat] EMF-File wizards point to wrong Project
[17:23:28] <tschindl> i tried to remember what actions i executed yesterday before the bug showed up
[17:24:10] <tschindl> it looks like git dialogs are not my friends because e.g. pasting using CTRL+V on OS-X pastes to the workbench and not the dialog
[17:24:15] <rcjsuen> interesting steps
[17:24:29] <rcjsuen> tschindl: you mean like in the commit dialog?
[17:24:50] <tschindl> no that's in the clone dialog
[17:25:27] <rcjsuen> we definitely had a problem before
[17:25:29] <rcjsuen> ~352905
[17:25:30] <Arbalest> Bug 352905 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=352905 - Platform / UI / 4.1 - All / All - VERIFIED / FIXED / major / - Assignee: remysuen - [Compatibility] 'Quick Outline' disappears if opened after opening an editor
[17:25:33] <rcjsuen> ~352149
[17:25:34] <Arbalest> Bug 352149 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=352149 - Platform / UI / 4.1 - PC / Windows XP - CLOSED / DUPLICATE / normal / - Assignee: platform-ui-triaged - [Compatibility] Keybindings do not work in EGit's commit dialog
[17:25:36] <tschindl> opening the clone dialog, adding some git repo to your clipboard and doing a CTRL+V pastes it into the workbench window
[17:25:36] <rcjsuen> but maybe it's not fully fixed
[17:27:21] <tschindl> well ~358020 is somehow messing up the selection used by the wizard
[17:27:21] <Arbalest> Bug 358020 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=358020 - Platform / UI / 4.2 - PC / Mac OS X - NEW / major / - Assignee: Platform-UI-Inbox - [Compat] EMF-File wizards point to wrong Project
[17:27:36] <tschindl> e.g. the properties view gets updated as it should
[17:30:30] <tschindl> grr the wizards are application modal dialogs so I can't access the Contexts-View
[17:31:12] <tschindl> btw delete is not affected by this problem
[17:32:45] <rcjsuen> hm
[17:42:39] <tschindl> ok patched jface to make wizards none modal and the IEclipseContext#selection value is pointin the the correct selection
[17:42:55] <tschindl> so maybe there's something cached somewhere in the compat layer
[17:51:10] <tschindl> ok  it looks like the selection in the popup context is wrong
[17:54:57] <tschindl> the popup context delegates to the Package Explorer Context and this context reports the wrong selection
[17:55:55] <tschindl> out.selection is correct
[17:56:00] <tschindl> selection is wrong
[17:56:09] <tschindl> output.selection
[18:07:33] <rcjsuen> odd that a dialog would interfere
[18:07:51] <rcjsuen> unless it's something with dialog / window / app context conflict
[18:08:33] *** susanmccourt has joined #eclipse-e4
[18:17:53] <tschindl> rcjsuen: yeah scary that a dialog can corrupt our contexts
[18:23:33] <tschindl> hm the git-commit is not executed through a handler
[18:24:27] <tschindl> at least it is not going through the E4HandlerProxy
[18:25:52] <tschindl> i really need to add a search possibility to my live application model
[18:29:22] *** borisb6i has quit IRC
[18:38:49] *** borisb6i has joined #eclipse-e4
[18:42:54] <rcjsuen> Definitely seems kind of weird
[18:43:01] <rcjsuen> the patch wizard also doesn't seem to care about selection
[18:43:08] <tschindl> rcjsuen found it
[18:43:17] <rcjsuen> but the CVS one seems to follow
[18:43:24] <tschindl> yes
[18:43:43] <tschindl> because they probably don't modify the IEvaluationContext
[18:43:49] <tschindl> like the git stuff does
[18:44:55] <tschindl> rcjsuen: i added the looks like we should create a child-context in createExecutionEvent()?
[18:45:04] *** borisb6i has quit IRC
[18:45:24] <tschindl> ... i added the offending lines
[18:45:33] <tschindl> to the bug report
[18:45:40] <rcjsuen> yes, maybe
[18:46:08] <tschindl> well in the debugger i see that the addVariable is going to the "package explorer" context
[18:46:39] <tschindl> so i think we somehow need to protect the effective part from this selection thingy
[18:46:51] <tschindl> I'm wondering though why they are doing this
[18:47:12] <rcjsuen> They do...many things.
[18:47:16] <tschindl> why do they overwrite the selection they get from the window
[18:47:20] <rcjsuen> This is certainly one of the questionable things.
[18:49:10] <tschindl> well naturally though it is questionable we need to protect our contexts from such value settings not?
[18:50:15] <rcjsuen> yes
[18:54:30] <tschindl> the problem is that we don't know when we'd have to destroy the child context if we'd create one
[18:55:27] <rcjsuen> That's one problem.
[18:55:33] <rcjsuen> They acn also call getParent() and interfere with the parent context.
[18:56:23] <tschindl> well this would be we'd do the creation onwrite and reparent all contexts below
[18:57:34] <rcjsuen> the other way is to just make a new IEvaluationContext
[18:57:37] <rcjsuen> that takes a map + eclipse contxt
[18:57:41] <rcjsuen> then when add happens throw it in the map
[18:57:51] <rcjsuen> then the context is nvr touched
[18:57:57] *** cadorn has quit IRC
[18:58:01] <tschindl> right even better
[18:58:26] *** cadorn has joined #eclipse-e4
[18:59:45] *** cadorn has quit IRC
[19:00:08] *** cadorn has joined #eclipse-e4
[19:06:41] <tschindl> hm adding a local map store the values work
[19:07:00] <tschindl> but the parent value look up gets more complex now
[19:07:28] <rcjsuen> Yes, that would complicate things.
[19:07:31] <tschindl> because one first has to look up in the parent hierarchy if a local values has been set before consulting the IEclipseContext
[19:09:45] <tschindl> another problem might be that it now doesn't get subject of injection through DI
[19:09:53] <tschindl> not sure how much of a problem that is
[19:10:15] *** cadorn has quit IRC
[19:13:56] <rcjsuen> tschindl: Well we don't expect people to use IEvaluatioNContext for DI
[19:14:03] <rcjsuen> that part should be hidden
[19:16:04] <tschindl> ok
[19:19:01] <tschindl> rcjsuen: ok I've implemented a first version and it seems to work
[19:22:28] *** jsixface has joined #eclipse-e4
[19:22:42] <jsixface> Hi.
[19:22:53] <jsixface> I have a problem in starting tom cat
[19:23:04] <jsixface> "Server Tomcat was unable to start within 45 seconds. If the server requires more time, try increasing the timeout in the server editor."
[19:23:19] <jsixface> I'm using eclipse indigo in Mac osX
[19:23:24] <jsixface> any idea ??
[19:23:31] *** tschindl has quit IRC
[19:31:47] <rcjsuen> jsixface: I think you should ask at #eclipse.
[19:32:41] <jsixface> rcjsuen, that's a big bunch of people.... but no one is responding...
[19:33:03] <jsixface> i asked there
[19:38:08] *** jsixface has quit IRC
[22:17:56] <briandealwis> I've recently noticed that my deltas.xml has grown to a very large size ? 1.2 MB and one grew to 3MB+.  The toolbar updates really slowing when switching between editors or views
[22:22:59] <rcjsuen> briandealwis: Oleg opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=358158 anyway
[22:23:25] <briandealwis> I just saw that ? but I don't think that's quite the same problem.
[22:23:40] <briandealwis> At least, it doesn't seem to account for growth in the size of deltas.xml
[22:24:02] <rcjsuen> no
[22:27:14] <briandealwis> I maintain quite a few workspaced, and my deltas range in side from 399k to 1m right now (I turfed the 3m one recently; I should have kept it, sorry)
[22:31:28] <rcjsuen> I wonder what it might be, perhaps commands and handlers
[22:33:55] *** rcjsuen is now known as rcjsuen_
[22:34:13] <briandealwis> It does seem full of those.
[23:01:32] *** rcjsuen has joined #eclipse-e4
[23:04:54] *** borisb6i has joined #eclipse-e4
[23:30:30] *** susanmccourt has quit IRC
[23:40:03] *** borisb6i has quit IRC





top