[00:02:21] *** briandealwis has joined #eclipse-e4 [01:24:20] *** briandealwis has quit IRC [03:27:13] *** rcjsuen__ has joined #eclipse-e4 [03:30:35] *** rcjsuen has quit IRC [04:23:26] *** rcjsuen__ has quit IRC [12:09:27] *** rcjsuen has joined #eclipse-e4 [12:57:25] *** rcjsuen has quit IRC [13:25:21] *** rcjsuen_ is now known as rcjsuen [14:05:43] *** briandealwis has joined #eclipse-e4 [15:52:48] <paulweb515> rcjsuen: ~353001 [15:52:50] <Arbalest> Bug 353001 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=353001 - Platform / UI / 4.1 - PC / Linux - NEW / normal / - Assignee: Platform-UI-Inbox - we don't honour allowPluginActivation [15:53:19] <rcjsuen> paulweb515: ello [15:53:40] <paulweb515> I was hoping to put some useful value in the context ... but now I'm not so sure [15:54:17] <paulweb515> maybe the best approach is to simply stick something in the context if they set "true" and always return that (or false) if nothing is found [15:56:43] <rcjsuen> paulweb515: What "useful value" did you have in mind [15:57:23] <paulweb515> rcjsuen: I just mean true or false :-) [15:58:06] <rcjsuen> paulweb515: What you said sounded to me like "I was going to do X...I'm not so sure...I think just saying true/false is better" [15:58:12] <rcjsuen> but now I'm not sure what you're saying lol [15:58:43] <paulweb515> paul reset --hard [16:00:11] <paulweb515> rcjsuen: we need some way of returning a useful value for allowPluginActivation. I'm now thinking that we put "true" into the context when it is set on an ExpressionContext, and we do a "get" on our key when anyone asks for that value ... return true if set, and false if null. What do you think? [16:03:06] <rcjsuen> paulweb515: That would be in line with our strategy for IWWADs and friends. [16:04:56] <rcjsuen> paulweb515: Though I recall you expressed disinterest in it back then. [16:05:11] <rcjsuen> There are some other Praveen patches maybe you should look at. [16:05:25] <rcjsuen> paulweb515: Think it was around popup menu items not remembering their toggle state. [16:05:38] <rcjsuen> Since on a clone the setSelection is always false. [16:24:36] *** yarthorn has joined #eclipse-e4 [22:38:20] *** rcjsuen is now known as rcjsuen_ [23:21:08] *** rcjsuen has joined #eclipse-e4 [23:25:48] *** yarthorn has quit IRC [23:42:22] *** briandealwis has quit IRC [23:45:42] <rcjsuen> never mind i clicked the wrong file