[01:21:24] *** rcjsuen_ has joined #eclipse-e4
[01:25:04] *** rcjsuen has quit IRC
[03:10:55] *** briandealwis has quit IRC
[04:32:31] *** rcjsuen_ has quit IRC
[08:46:36] *** magnet_ has quit IRC
[09:05:55] *** magnet_ has joined #eclipse-e4
[09:50:36] *** magnet_ has quit IRC
[11:48:42] *** magnet_ has joined #eclipse-e4
[12:14:21] *** rcjsuen has joined #eclipse-e4
[12:51:47] *** rcjsuen has quit IRC
[13:35:59] *** briandealwis has joined #eclipse-e4
[13:45:36] *** rcjsuen has joined #eclipse-e4
[13:48:13] <paulweb515> rcjsuen: do we strip out save perspective as anywhere?
[13:48:23] <rcjsuen> paulweb515: Not sure I understand what you mean.
[13:48:26] <paulweb515> rcjsuen: I thought we were banning certain actions ... but I don't remember where
[13:48:28] <rcjsuen> It's not implemented anyway.
[13:48:41] <rcjsuen> Define "ban"
[13:49:29] <paulweb515> I thought we skipped certain ICIs when we checked for their IDs
[13:49:36] <rcjsuen> oh oh
[13:49:36] <rcjsuen> that
[13:49:45] <rcjsuen> I'll have to check
[13:49:48] <rcjsuen> my Eclipse is still in startup
[13:51:48] <rcjsuen> 			}
[13:51:48] <rcjsuen> 		} else if (id != null) {
[13:51:48] <rcjsuen> 			// wire these off because we're out of time, see bug 317203
[13:51:48] <rcjsuen> 			if (id.equals(IWorkbenchCommandConstants.WINDOW_SAVE_PERSPECTIVE_AS)
[13:51:48] <rcjsuen> 					|| id.equals(IWorkbenchCommandConstants.WINDOW_CUSTOMIZE_PERSPECTIVE)) {
[13:51:48] <rcjsuen> 				return null;
[13:51:50] <rcjsuen> 			}
[13:51:55] <rcjsuen> paulweb515: MenuHelper line 83x
[15:24:49] *** briandealwis has quit IRC
[15:25:16] *** briandealwis has joined #eclipse-e4
[16:23:10] <emoffatt> rcjsuen: is there a defect already for the failing test 'testBug317849' ?
[16:24:31] <rcjsuen> emoffatt: see https://bugs.eclipse.org/bugs/show_bug.cgi?id=333496#c2 and down
[16:25:15] <emoffatt> kk thanks, I have a fix...
[17:01:06] *** rcjsuen has quit IRC
[17:12:30] *** rcjsuen has joined #eclipse-e4
[19:06:10] *** briandealwis has quit IRC
[19:31:25] <rcjsuen> paulweb515: We do our submenu processing "lazily" now, right? So a submenu could show up even if none of its children are visible whereas the submenu would just not appear in 3.x?
[19:35:51] <paulweb515> rcjsuen: that's what that processing step in the timer is for
[19:36:46] <rcjsuen> paulweb515: I mean for context menus. Not the main menu bar.
[19:37:55] <paulweb515> rcjsuen: we use the same code on an SWT.Show event to prove the visibility of sub menus ... at least, that's what it is supposed to do:
[19:38:00] <paulweb515> org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.updateElementVisibility(MMenu, MenuManagerRenderer, MenuManager, IEclipseContext, boolean)
[19:38:13] <paulweb515> that's called from org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.showMenu(Event, Menu, MMenu, MenuManager)
[19:38:16] <rcjsuen> Okay, maybe I was living a lie.
[19:38:18] <rcjsuen> Guess I'll have to do some digging.
[19:38:57] <paulweb515> it might not be working correctly, but it's supposed to do visibility for any submenus in the currently showing menus, so that they can be rendered or not
[19:49:18] <rcjsuen> paulweb515: Actually I think it is working. But the EGit contribution has submenus and submenus so I think the second layer is making the parent 'Team' visible.
[19:52:38] <paulweb515> rcjsuen: yes, we only go down 1 layer
[20:22:37] *** briandealwis has joined #eclipse-e4
[22:46:41] *** rcjsuen is now known as rcjsuen_
[23:13:21] *** rcjsuen has joined #eclipse-e4





top