[01:23:45] *** rcjsuen has quit IRC
[01:42:46] *** rcjsuen has joined #eclipse-e4
[04:01:51] *** rcjsuen has quit IRC
[11:20:01] *** magnet_ has joined #eclipse-e4
[13:36:32] *** rcjsuen has joined #eclipse-e4
[13:45:19] <rcjsuen> paulweb515: Did Chris reset your Gerrit thing yet? I'm guessing no
[13:46:17] <paulweb515> no
[14:02:55] *** briandealwis has joined #eclipse-e4
[16:03:03] *** borisb6i has joined #eclipse-e4
[16:08:34] <paulweb515> emoffatt: you need to add a property (rebase = true) to your R4_development branch in EGit.  See http://wiki.eclipse.org/Platform-releng/Git_Workflows#Configuring_the_repo
[16:19:06] <emoffatt> paulweb515: so I just add a new entry with that info ?
[16:20:15] <paulweb515> emoffatt: yes, you just need to add a key=value ... branch.R4_development.rebase=true
[17:52:12] *** borisb6i has quit IRC
[18:11:27] *** borisb6i has joined #eclipse-e4
[18:23:13] *** briandealwis has quit IRC
[18:27:56] *** borisb6i has quit IRC
[20:26:51] <rcjsuen> o look
[20:26:53] <rcjsuen> people downcasting randomly again
[20:28:15] <paulweb515> bad people got, no reason, bad people got, no reason, bad people got, no reason to live ....
[20:28:42] <rcjsuen> paulweb515: so here org.eclipse.core.commands.AbstractHandler.setEnabled(Object)
[20:28:43] <paulweb515> rcjsuen: the team items that are disabled, could you list some of them in the bug ... we should determine the "why"
[20:28:48] <rcjsuen> EGit downcasts to EvaluationContext
[20:28:54] <rcjsuen> (we have ExprContext)
[20:28:55] <rcjsuen> then it x_x
[20:29:04] <paulweb515> well, they need to fix that
[20:29:16] <rcjsuen> it's technically Object
[20:29:22] <rcjsuen> is it valid to downcast to IEC?
[20:30:18] <rcjsuen> actually
[20:30:20] <rcjsuen> i don't know what they're doing
[20:30:24] <rcjsuen> why don't they just use HandlerUtil?
[20:30:43] <paulweb515> We should have been more specific, but it looks like we only allude that it would be the same execution time information
[20:31:14] <paulweb515> rcjsuen: but yes, they should use org.eclipse.ui.handlers.HandlerUtil.getVariable(Object, String) to extract information from a ontext
[20:31:15] <rcjsuen> 	protected void enableWhenRepositoryHaveHead(Object evaluationContext) {
[20:31:17] <rcjsuen> 		if (evaluationContext instanceof EvaluationContext) {
[20:31:19] <rcjsuen> 			EvaluationContext context = (EvaluationContext) evaluationContext;
[20:31:21] <rcjsuen> 			Object selection = context.getVariable(ISources.ACTIVE_CURRENT_SELECTION_NAME);
[20:31:25] <rcjsuen> 			if (selection instanceof TreeSelection) {
[20:31:27] <rcjsuen> 				TreeSelection treeSelection = (TreeSelection) selection;
[20:31:29] <rcjsuen> 				Object firstElement = treeSelection.getFirstElement();
[20:31:31] <rcjsuen> yeah
[20:31:33] <rcjsuen> i see it is done similarly in TeamAction
[20:31:50] <paulweb515> rcjsuen: you mean the logic?  Or that TeamAction uses HandlerUtil ?
[20:31:56] <rcjsuen> TeamAction uses the patter nyou just said
[20:32:06] <rcjsuen> 	public void setEnabled(Object evaluationContext) {
[20:32:06] <rcjsuen> 		IWorkbenchWindow activeWorkbenchWindow = (IWorkbenchWindow) HandlerUtil
[20:32:06] <rcjsuen> 				.getVariable(evaluationContext,
[20:32:06] <rcjsuen> 						ISources.ACTIVE_WORKBENCH_WINDOW_NAME);
[20:32:06] <rcjsuen> 		if (activeWorkbenchWindow != null) {
[20:32:08] <rcjsuen> but EGit just downcasts
[20:32:17] <rcjsuen> I think I will just close Lars's bug and open a new one
[20:32:40] <paulweb515> yes, there were a couple of locations I had hoped to fix that in their code.  I'd contribute ... if they'd fix my bloody ids
[21:33:25] *** briandealwis has joined #eclipse-e4
[22:23:30] *** rcjsuen has quit IRC
[22:48:03] *** rcjsuen has joined #eclipse-e4
[23:25:29] *** briandealwis has quit IRC
[23:25:53] *** briandealwis has joined #eclipse-e4





top