July 13, 2011 
1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | 29 | 30 | 31
July 13, 2011 [01:29:10] *** briandealwis has quit IRC [14:09:28] *** echelog has joined #eclipse-e4 [14:26:46] <rcjsuen> paulweb515: Oh, I thought they could just randomly add stuff and then call update(boolean) [14:30:03] <paulweb515> rcjsuen: for their own TBM, sure. But for the toolbar provided by the view site, they need to call org.eclipse.ui.IActionBars.updateActionBars() or we're not required to honour their changes :-) [14:30:11] <rcjsuen> o [15:34:58] <rcjsuen> paulweb515: Should we be reconciling before the update call or after [15:37:51] <paulweb515> I would say at the end of the update call. Is that what you mean by after? [15:45:02] <rcjsuen> paulweb515: I mean the TBM is JFace code so we can't add stuff there [15:45:05] <rcjsuen> i mean after the method returns [15:46:04] <paulweb515> rcjsuen: we should do our update in updateActionBars(), right? [15:46:12] <rcjsuen> paulweb515: yes we do do it there [16:21:49] *** briandealwis has joined #eclipse-e4 [16:23:49] *** briandealwis1 has joined #eclipse-e4 [16:25:05] *** briandealwis1 has quit IRC [16:25:46] *** briandealwis1 has joined #eclipse-e4 [16:26:16] *** briandealwis has quit IRC [17:10:02] *** magnet_ has quit IRC [22:21:28] *** rcjsuen has quit IRC [22:28:23] *** briandealwis1 has quit IRC [22:49:31] *** rcjsuen has joined #eclipse-e4