April 24, 2019 
< | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | 24 | 25 | 26 | 27 | 28 | 29 | 30 | >
April 24, 2019 [00:01:28] <hcb> ellyjones: Can you tell me what's wrong with removing this line? https://cs.chromium.org/chromium/src/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc?type=cs&q=InsertItemWithStringIdAt&g=0&l=380[00:01:49] <hcb> When I comment it out, Chromium loads but immediately closes when I click the vertical "..." to get options.[00:02:17] *** eszett_ <eszett_!~eszett@unaffiliated/eszett> has joined #chromium[00:02:32] <hcb> I tried commenting it out and changing the first argument for the separator below it to 0, but that didn't work either.[00:05:27] *** eszett__ <eszett__!~eszett@unaffiliated/eszett> has quit IRC (Ping timeout: 245 seconds)[00:09:23] *** eph^ <eph^!eph@ip98-186-247-88.mc.at.cox.net> has quit IRC (Read error: Connection reset by peer)[00:10:00] <trungl-bot> Tree opened by chcunningham at google dot com: Tree is open (revert, https://chromium.googlesource.com/chromium/src/+/fecc44c010b127fca9d51361242df56d78930fc5)[00:11:45] *** RT|Chatzilla <RT|Chatzilla!~chatzilla@reactos/tester/RT> has joined #chromium[00:20:05] *** iapres <iapres!a7dc02b7@gateway/web/freenode/ip.167.220.2.183> has quit IRC (Ping timeout: 256 seconds)[00:27:59] *** leiz <leiz!~leiz@104.132.53.70> has joined #chromium[00:35:26] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[00:44:48] <hcb> ellyjones: I tried letting it add the "History" item and then using RemoveItemAt(0) but it still crashes.[00:45:09] <hcb> I don't know why it's crashing simply because it is missing a menu item.[00:49:16] <hcb> torne: Are available to help with a UI question?[00:49:20] <hcb> *Are you[00:49:55] *** mgol <mgol!~m_gol@89-66-186-151.dynamic.chello.pl> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[00:53:12] *** edwardly <edwardly!~edwardly@unaffiliated/edwardly> has quit IRC (Read error: Connection reset by peer)[00:55:58] *** edwardly <edwardly!~edwardly@pool-71-190-177-155.nycmny.fios.verizon.net> has joined #chromium[00:55:59] *** edwardly <edwardly!~edwardly@pool-71-190-177-155.nycmny.fios.verizon.net> has quit IRC (Changing host)[00:55:59] *** edwardly <edwardly!~edwardly@unaffiliated/edwardly> has joined #chromium[00:56:57] <hcb> Anyone online right now who can help with some GUI code?[01:08:01] *** eszett_ <eszett_!~eszett@unaffiliated/eszett> has quit IRC (Ping timeout: 250 seconds)[01:11:08] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[01:12:16] <hcb> jrmuizel: Can you offer advice for some GUI code I'm working with? (I'm not sure which part of Chromium you work on)[01:12:43] <jrmuizel> hcb: I don't work on chromium at all[01:12:56] *** darktears <darktears!~darktears@kde/developer/menard> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[01:13:05] <hcb> Oh, okay.[01:13:53] <hcb> I'm working on my own version right now and I wanted to remove "History" from the "History" submenu, but when I comment out that entry, Chromium crashes when I open the options menu.[01:16:36] *** krollin <krollin!~krollin@2620:149:f:1874:1494:9ce0:a4e0:7c5b> has joined #chromium[01:21:35] *** thakis_ <thakis_!~thakis_@ool-45715164.dyn.optonline.net> has joined #chromium[01:22:21] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has joined #chromium[01:39:56] *** dydz <dydz!~dydz@17.192.24.32> has quit IRC (Quit: dydz)[01:40:55] <hcb> Never mind, I think I solved my issue.[01:51:40] *** Abdu_Ameen <Abdu_Ameen!a2d53543@gateway/web/freenode/ip.162.213.53.67> has joined #chromium[01:56:56] *** darktears <darktears!~darktears@kde/developer/menard> has joined #chromium[01:56:56] *** ChanServ sets mode: +v darktears[01:58:08] *** rego <rego!uid293518@gateway/web/irccloud.com/x-lrevpnxcfgyzgffs> has quit IRC (Quit: Connection closed for inactivity)[02:08:38] *** kmoon <kmoon!~kmoon@104.132.53.70> has quit IRC (Quit: leaving)[02:08:42] *** darktears <darktears!~darktears@kde/developer/menard> has quit IRC (Ping timeout: 246 seconds)[02:10:57] *** kmoon <kmoon!~kmoon@104.132.53.70> has joined #chromium[02:28:04] *** bluezone <bluezone!uid104970@gateway/web/irccloud.com/x-sgaulmxtsipwdfdk> has quit IRC (Quit: Connection closed for inactivity)[02:31:32] *** bsheedy <bsheedy!bsheedy@nat/google/x-pqtwtlfhrhihxgqi> has quit IRC (Remote host closed the connection)[02:31:56] *** bsheedy <bsheedy!bsheedy@nat/google/x-hjidfjrgcxdfsrpd> has joined #chromium[02:31:56] *** ChanServ sets mode: +v bsheedy[02:34:06] *** javashin <javashin!~javashin@unaffiliated/javashin> has joined #chromium[02:44:15] <chcunningham> PST Sheriff, signing off[02:44:25] *** chcunningham <chcunningham!68844e50@gateway/web/freenode/ip.104.132.78.80> has quit IRC (Quit: Page closed)[02:53:09] *** Goldmember <Goldmember!~Goldmembe@nag77-2-83-152-154-106.fbx.proxad.net> has quit IRC (Remote host closed the connection)[02:57:32] *** thakis_ <thakis_!~thakis_@ool-45715164.dyn.optonline.net> has quit IRC (Quit: thakis_)[03:10:56] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has joined #chromium[03:15:14] *** bsheedy <bsheedy!bsheedy@nat/google/x-hjidfjrgcxdfsrpd> has quit IRC (Remote host closed the connection)[03:15:48] *** bsheedy <bsheedy!bsheedy@nat/google/x-vaekwiddvipqmfps> has joined #chromium[03:15:48] *** ChanServ sets mode: +v bsheedy[03:29:07] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "gclient runhooks" on https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/42118 "Mac10.10 Tests" from daa07adbdec6e560e2d270ebe6c9392a0cc3507c: chromium-autoroll at skia-public dot iam.gserviceaccount.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,tengs@chromium.org,ricea@chromium.org,zmo@chromium.org (:zhenyao),tikuta at chromium dot org,b[03:33:09] <trungl-bot> Tree opened by buildbot at chromium dot org: Tree is open (Automatic: (☆.☆) )[03:34:53] <hcb> https://cdn.discordapp.com/attachments/518172695439867904/570421865416491008/unknown.png[03:35:43] <hcb> ^- I restored History to being clickable on the main menu like it was in older versions, and the History sub-menu from newer versions is now called "Recent tabs".[03:35:58] *** litherum <litherum!~litherum@2620:149:f:1870:b44b:b769:59d0:207d> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[03:57:23] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[04:09:52] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has quit IRC (Quit: thakis_)[04:12:35] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[04:43:42] *** tassee <tassee!~tasse@55d4a10f.access.ecotel.net> has joined #chromium[04:44:52] *** tasse <tasse!~tasse@55d44ea6.access.ecotel.net> has quit IRC (Ping timeout: 276 seconds)[04:44:53] *** tassee is now known as tasse[04:46:21] *** bashfulshell <bashfulshell!uid190567@gateway/web/irccloud.com/x-cmgfpebgnkivtvbm> has quit IRC (Quit: Connection closed for inactivity)[05:10:13] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has quit IRC (Ping timeout: 276 seconds)[05:10:16] *** tasse <tasse!~tasse@55d4a10f.access.ecotel.net> has quit IRC (Ping timeout: 258 seconds)[05:11:32] *** tasse <tasse!~tasse@55d4cc8d.access.ecotel.net> has joined #chromium[05:13:54] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has joined #chromium[05:18:13] *** javashin <javashin!~javashin@unaffiliated/javashin> has quit IRC (Remote host closed the connection)[05:24:15] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[05:39:56] *** Blink <Blink!44a87335@gateway/web/freenode/ip.68.168.115.53> has joined #chromium[05:40:36] *** Blink <Blink!44a87335@gateway/web/freenode/ip.68.168.115.53> has left #chromium[05:41:01] *** ielectric <ielectric!~ielectric@v22014052224618709.yourvserver.net> has joined #chromium[05:42:29] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-paxsptypbqzjwqdi> has quit IRC (Quit: Connection closed for inactivity)[05:45:39] *** ielectric <ielectric!~ielectric@v22014052224618709.yourvserver.net> has quit IRC (Client Quit)[05:51:44] *** sauvin <sauvin!sauvin@about/linux/staff/sauvin> has joined #chromium[05:57:15] *** Abdu_Ameen <Abdu_Ameen!a2d53543@gateway/web/freenode/ip.162.213.53.67> has quit IRC (Ping timeout: 256 seconds)[06:10:55] *** al-damiri <al-damiri!uid142631@gateway/web/irccloud.com/x-golfnajyqvhrjwep> has quit IRC (Quit: Connection closed for inactivity)[06:11:19] *** plasticcat420 <plasticcat420!~ubuntu@74.2.164.14> has joined #chromium[06:22:25] *** m_kato <m_kato!~m_kato@61.120.204.220> has joined #chromium[06:55:07] *** plasticcat420 <plasticcat420!~ubuntu@74.2.164.14> has quit IRC (Quit: Leaving)[07:12:18] *** Asandari <Asandari!~Asandari@107-179-197-180.cpe.teksavvy.com> has quit IRC (Ping timeout: 255 seconds)[07:15:10] *** Asandari <Asandari!~Asandari@107-179-197-180.cpe.teksavvy.com> has joined #chromium[07:33:41] *** acaringi <acaringi!~acaringi@95.82.135.166> has joined #chromium[07:36:17] *** caringi <caringi!~acaringi@95.82.135.142> has quit IRC (Ping timeout: 245 seconds)[08:28:22] *** HerbY_NL2 <HerbY_NL2!~HerbY_NL2@2001:67c:2564:518:24ca:8625:32ce:8c9> has joined #chromium[08:59:31] *** grumpy <grumpy!~grumpy@106.51.72.228> has joined #chromium[09:01:08] *** grumpy <grumpy!~grumpy@106.51.72.228> has quit IRC (Client Quit)[09:01:32] *** mgol <mgol!~m_gol@89-66-186-151.dynamic.chello.pl> has joined #chromium[09:07:15] *** TheCowboy <TheCowboy!uid130777@gateway/web/irccloud.com/x-ymknidrymrgoehue> has quit IRC (Quit: Connection closed for inactivity)[09:20:53] *** mgol <mgol!~m_gol@89-66-186-151.dynamic.chello.pl> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[09:44:27] *** fordfrog <fordfrog!~fordfrog@gentoo/developer/fordfrog> has joined #chromium[09:53:53] *** bashfulshell <bashfulshell!uid190567@gateway/web/irccloud.com/x-pgnhvjimtcfqejpq> has joined #chromium[10:08:06] *** m_kato <m_kato!~m_kato@61.120.204.220> has quit IRC (Quit: Leaving...)[10:14:47] *** Tarnyko <Tarnyko!~Tarnyko@89-159-183-236.rev.numericable.fr> has joined #chromium[10:17:11] <Tarnyko> hi chromiumers[10:29:18] *** mgol <mgol!~m_gol@89-66-186-151.dynamic.chello.pl> has joined #chromium[10:40:46] *** saba <saba!~foo@unaffiliated/saba> has joined #chromium[10:41:17] *** javashin <javashin!~javashin@unaffiliated/javashin> has joined #chromium[11:20:23] *** tassee <tassee!~tasse@55d4607e.access.ecotel.net> has joined #chromium[11:21:11] *** tasse <tasse!~tasse@55d4cc8d.access.ecotel.net> has quit IRC (Ping timeout: 250 seconds)[11:21:36] *** tassee is now known as tasse[11:27:17] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[11:27:52] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 276 seconds)[11:33:09] *** mgol <mgol!~m_gol@89-66-186-151.dynamic.chello.pl> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[11:45:18] *** rego <rego!uid293518@gateway/web/irccloud.com/x-rasjfzvdmnrnsyaj> has joined #chromium[11:46:13] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has joined #chromium[11:53:12] *** hsiktas <hsiktas!sid224847@gateway/web/irccloud.com/x-yoblgupejrxiazim> has quit IRC (Ping timeout: 252 seconds)[11:53:28] *** discopatrick <discopatrick!sid138124@gateway/web/irccloud.com/x-ndnoqbmmfvdqthwd> has quit IRC (Ping timeout: 264 seconds)[11:53:45] *** Scorchin__ <Scorchin__!sid1242@gateway/web/irccloud.com/x-rvlnhnrmpftpemdx> has quit IRC (Ping timeout: 252 seconds)[11:54:04] *** kereliuk__ <kereliuk__!sid238052@gateway/web/irccloud.com/x-luqqenbyrirossts> has quit IRC (Ping timeout: 264 seconds)[11:54:04] *** paulfryzel_ <paulfryzel_!sid243092@gateway/web/irccloud.com/x-hwrpavbtzilycbum> has quit IRC (Ping timeout: 264 seconds)[11:54:04] *** ella_ <ella_!sid287486@gateway/web/irccloud.com/x-utelejsokfbgfzva> has quit IRC (Ping timeout: 264 seconds)[11:54:16] *** ella_ <ella_!sid287486@gateway/web/irccloud.com/x-rlhuqxyvlhkdbsuq> has joined #chromium[11:54:21] *** paulfryzel_ <paulfryzel_!sid243092@gateway/web/irccloud.com/x-goynnbktoutihowp> has joined #chromium[11:54:40] *** sbc100_ <sbc100_!sid288644@gateway/web/irccloud.com/x-cpsareahhedyaheg> has quit IRC (Ping timeout: 264 seconds)[11:54:40] *** eddyb <eddyb!sid155877@gateway/web/irccloud.com/x-iveqzqdjxxdhpgqv> has quit IRC (Ping timeout: 264 seconds)[11:54:50] *** kereliuk__ <kereliuk__!sid238052@gateway/web/irccloud.com/x-ssoevilbgcybbrrh> has joined #chromium[11:54:57] *** discopatrick <discopatrick!sid138124@gateway/web/irccloud.com/x-ihxqrypdczeupdrs> has joined #chromium[11:55:16] *** clinth <clinth!clinth@gateway/web/irccloud.com/x-edshirhzajhvwtor> has quit IRC (Ping timeout: 264 seconds)[11:55:16] *** codebytere <codebytere!sid306540@gateway/web/irccloud.com/x-coouthvujuiuiyon> has quit IRC (Ping timeout: 264 seconds)[11:55:16] *** ecobos <ecobos!sid133554@gateway/web/irccloud.com/x-wuzyuvtvcrotwvlt> has quit IRC (Ping timeout: 264 seconds)[11:55:24] *** hsiktas <hsiktas!sid224847@gateway/web/irccloud.com/x-dbqijgtifuxesrfw> has joined #chromium[11:56:41] *** Scorchin__ <Scorchin__!sid1242@gateway/web/irccloud.com/x-iplaxdpjfyatbfux> has joined #chromium[11:57:18] *** eddyb <eddyb!sid155877@gateway/web/irccloud.com/x-zuwaytisgkqliaee> has joined #chromium[11:57:18] *** clinth <clinth!clinth@gateway/web/irccloud.com/x-cudutwkgwrtmzyzd> has joined #chromium[11:57:24] *** codebytere <codebytere!sid306540@gateway/web/irccloud.com/x-oasjtiilkksmzqnx> has joined #chromium[11:59:54] *** mgol <mgol!~m_gol@9dd3a2ad8e135.rev.snt.net.pl> has joined #chromium[12:00:37] <j`ey> does chrome/v8 use llvm's compiler-rt?[12:03:34] *** bashfulshell <bashfulshell!uid190567@gateway/web/irccloud.com/x-pgnhvjimtcfqejpq> has quit IRC (Quit: Connection closed for inactivity)[12:06:00] *** ecobos <ecobos!sid133554@gateway/web/irccloud.com/x-srmgcunidmhcmsyg> has joined #chromium[12:07:36] *** sbc100_ <sbc100_!sid288644@gateway/web/irccloud.com/x-sjqvinwbunnrihrv> has joined #chromium[12:07:59] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has joined #chromium[12:19:36] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has quit IRC (Quit: thakis_)[12:22:27] *** javashin <javashin!~javashin@unaffiliated/javashin> has quit IRC (Remote host closed the connection)[12:34:49] *** rnk__ <rnk__!~rnk@104.133.9.68> has quit IRC (Ping timeout: 276 seconds)[12:41:47] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has joined #chromium[12:41:49] *** tworaz <tworaz!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 258 seconds)[12:51:11] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has joined #chromium[12:51:30] *** thakis_ <thakis_!~thakis_@ool-2f10b513.dyn.optonline.net> has quit IRC (Client Quit)[13:00:59] *** jamm <jamm!~jamm@unaffiliated/jamm> has joined #chromium[13:01:47] *** sdefresne <sdefresne!~sdefresne@104.132.117.81> has quit IRC (Ping timeout: 244 seconds)[13:04:00] *** sdefresne <sdefresne!~sdefresne@104.132.117.87> has joined #chromium[13:10:09] *** kubast2-2 <kubast2-2!~androirc@user-5-173-219-147.play-internet.pl> has joined #chromium[13:14:29] <kubast2-2> Hey I asked at #webkit and #firefox, I got proposed 3 solutions; brew.sh phantomjs fluyt, and I presume the 2 channels often are inhabitted by different people. Hey I would like to ask, I kinda would need something that would behave like a web browser but had a programming interface to extract the current snapshot of a web page, ability to extract DOM contents/contents of a web page without tags and majority of css options, and I[13:14:31] <kubast2-2> *the 3 this included[13:15:25] <kubast2-2> *and I'm asking this channel for the first time[13:15:46] <kubast2-2> Replace webkit with blink+v8[13:16:32] <j`ey> kubast2-2: you can run chrome headless https://developers.google.com/web/updates/2017/04/headless-chrome[13:25:27] *** kubast2-2 <kubast2-2!~androirc@user-5-173-219-147.play-internet.pl> has quit IRC (Ping timeout: 245 seconds)[13:27:22] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[13:27:22] *** ChanServ sets mode: +v thakis_[13:35:35] *** Scorchin__ is now known as Scorchin[13:40:33] *** be-p <be-p!9764c84d@gateway/web/freenode/ip.151.100.200.77> has joined #chromium[13:41:05] <be-p> guys can I force chromium developers tool to override a .js file with a local version of it[13:41:08] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[13:41:44] <j`ey> thakis_: hey, does chrome/v8 use llvm's compiler-rt?[13:42:06] <j`ey> I looked in my ./third_party/llvm-build, I dont see it, but maybe I missed it[13:42:08] <thakis_> j`ey: "it depends"[13:42:15] <thakis_> we use compiler-rt/lib/asan[13:42:16] <thakis_> and ubsan[13:42:17] <thakis_> and lsan[13:42:20] <thakis_> and cfi[13:42:25] <thakis_> and libprofile[13:42:59] <thakis_> and libcalgn_rt.ios[13:43:03] <thakis_> and libfuzzer[13:43:09] <thakis_> `third_party/llvm-build/Release+Asserts/lib/clang/9.0.0/lib/darwin/`[13:43:15] <thakis_> (and the other os's)[13:43:19] <j`ey> ok, I was thinking of the builtins[13:43:45] <thakis_> "builtins" is a somewhat overloaded term :)[13:44:02] *** be-p <be-p!9764c84d@gateway/web/freenode/ip.151.100.200.77> has quit IRC (Client Quit)[13:44:20] <thakis_> there's two kinds of compiler built-ins too: functions either defined as inline asm in .h files shipped with clang, and functions whose definitions live inside clang that clang emits as needed if referenced[13:44:25] *** be-p <be-p!9764c84d@gateway/web/freenode/ip.151.100.200.77> has joined #chromium[13:44:25] <thakis_> we use these two kinds of builtins[13:44:39] <be-p> if someone answerd me i've crashed, sorry[13:44:52] <thakis_> for cases where clang generates a call to the rt library, we don't use comipler-rt for that[13:45:17] <thakis_> be-p: the channel logs are at https://echelog.com/logs/browse/chromium/ (but nobody answered, i'm afraid)[13:45:33] *** jamm <jamm!~jamm@unaffiliated/jamm> has quit IRC (Ping timeout: 246 seconds)[13:45:40] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Ping timeout: 276 seconds)[13:45:50] * hwennborg waves at thakis[13:46:01] <thakis_> hwennborg: o/[13:46:15] <be-p> lol thank you thakis_[13:46:43] <be-p> but how should I do if I want to put a 'debugger;' statement in the middle of a minified js ?[13:46:43] <j`ey> thakis_: these ones https://github.com/llvm-mirror/compiler-rt/tree/7a739a0dfb6d408c6d587e5c7b52abd89fc3fdd3/lib/builtins[13:47:23] <thakis_> j`ey: yup, don't use those. (i suppose on darwin we use them via system compiler-rt)[13:47:48] <j`ey> thakis_: thanks![13:47:51] <hwennborg> j`ey: i think we're just doing the default thing, which on linux means libgcc and on windows means some windows lib, and on mac means the system's compiler-rt[13:48:18] <thakis_> on windows i think it also means linker error if you multiply two int128s :)[13:48:24] <hwennborg> right[13:48:32] <j`ey> hwennborg: makes sense, I just thought perhaps it might be bundled, since other stuff seems to be![13:49:01] <hwennborg> maybe we should at some point, because as thakis said, there are sometimes problems[13:49:20] *** Horus_Sirius1 <Horus_Sirius1!~Thunderbi@x4d009318.dyn.telefonica.de> has joined #chromium[13:50:27] *** be-p_ <be-p_!9764c84d@gateway/web/freenode/ip.151.100.200.77> has joined #chromium[13:52:00] *** be-p_ <be-p_!9764c84d@gateway/web/freenode/ip.151.100.200.77> has quit IRC (Client Quit)[13:52:18] *** be-p_ <be-p_!9764c84d@gateway/web/freenode/ip.151.100.200.77> has joined #chromium[13:53:12] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-liquyisutwbmyuwc> has joined #chromium[13:53:20] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Quit: thakis_)[13:53:49] *** be-p <be-p!9764c84d@gateway/web/freenode/ip.151.100.200.77> has quit IRC (Ping timeout: 256 seconds)[13:53:57] *** be-p_ <be-p_!9764c84d@gateway/web/freenode/ip.151.100.200.77> has quit IRC (Client Quit)[13:56:54] *** YuGiOhJCJ <YuGiOhJCJ!~YuGiOhJCJ@gateway/tor-sasl/yugiohjcj> has quit IRC (Quit: YuGiOhJCJ)[13:57:10] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[13:57:10] *** ChanServ sets mode: +v thakis_[13:57:30] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Client Quit)[14:10:20] *** abacus <abacus!~znc@nag77-2-83-152-154-106.fbx.proxad.net> has joined #chromium[14:19:51] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[14:19:52] *** ChanServ sets mode: +v thakis_[14:30:39] *** jamm <jamm!~jam@unaffiliated/jamm> has joined #chromium[14:32:16] *** bashfulshell <bashfulshell!uid190567@gateway/web/irccloud.com/x-rqripfyzrwlpqacx> has joined #chromium[14:32:32] *** abacus <abacus!~znc@nag77-2-83-152-154-106.fbx.proxad.net> has quit IRC (Remote host closed the connection)[14:34:57] *** wildlander_ <wildlander_!~wildlande@134.85-85-3.dynamic.clientes.euskaltel.es> has joined #chromium[14:37:08] *** wildlander <wildlander!~wildlande@unaffiliated/wildlander> has quit IRC (Ping timeout: 245 seconds)[14:40:51] *** vasile___ <vasile___!~vasile@nag77-2-83-152-154-106.fbx.proxad.net> has joined #chromium[14:43:44] *** Guest44991 <Guest44991!~sandlotas@23-31-172-245-static.hfc.comcastbusiness.net> has quit IRC (Read error: Connection reset by peer)[14:44:00] *** vasile___ <vasile___!~vasile@nag77-2-83-152-154-106.fbx.proxad.net> has quit IRC (Remote host closed the connection)[14:59:23] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has quit IRC (Read error: Connection reset by peer)[15:03:05] *** himcesjf_ <himcesjf_!~cesjf@unaffiliated/himcesjf> has joined #chromium[15:03:36] *** him-cesjf <him-cesjf!~cesjf@unaffiliated/himcesjf> has quit IRC (Ping timeout: 246 seconds)[15:10:39] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Quit: thakis_)[15:11:13] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[15:11:13] *** ChanServ sets mode: +v thakis_[15:11:27] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Client Quit)[15:12:03] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[15:12:03] *** ChanServ sets mode: +v thakis_[15:12:37] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Client Quit)[15:14:21] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[15:14:21] *** ChanServ sets mode: +v thakis_[15:17:47] *** SerialSmile <SerialSmile!~SerialSmi@83.102.198.70> has joined #chromium[15:24:31] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Quit: thakis_)[15:25:28] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[15:25:28] *** ChanServ sets mode: +v thakis_[15:32:10] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[15:35:36] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Quit: thakis_)[15:36:06] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has joined #chromium[15:36:07] *** ChanServ sets mode: +v thakis_[15:40:31] *** IsilinBN <IsilinBN!~IsilinBN@nag77-2-83-152-154-106.fbx.proxad.net> has joined #chromium[15:42:26] <hcb> Tarnyko: I'm glad to see you're back. Will we be able to work together on resolving some linker/dependency stuff today?[15:43:44] *** Abdu_Ameen <Abdu_Ameen!a2d53551@gateway/web/freenode/ip.162.213.53.81> has joined #chromium[15:45:08] *** IsilinBN <IsilinBN!~IsilinBN@nag77-2-83-152-154-106.fbx.proxad.net> has quit IRC (Remote host closed the connection)[15:53:06] *** bluezone <bluezone!uid104970@gateway/web/irccloud.com/x-uhoivrfipkndzois> has joined #chromium[15:55:29] *** jeeeunevans <jeeeunevans!~jeeeuneva@nag77-2-83-152-154-106.fbx.proxad.net> has joined #chromium[15:57:18] *** jeeeunevans <jeeeunevans!~jeeeuneva@nag77-2-83-152-154-106.fbx.proxad.net> has quit IRC (K-Lined)[15:58:45] <ellyjones> morning folks :)[16:00:25] <hcb> Good morning ellyjones[16:00:41] <hcb> Have you seen the UI changes I did yesterday?[16:00:45] <ellyjones> I have not[16:00:53] <ellyjones> what are you changing?[16:01:12] <hcb> Well, so far I changed the audio player and some entries on the main menu.[16:01:18] <hcb> In addition to the tab shape and color.[16:01:25] <hcb> https://cdn.discordapp.com/attachments/518172695439867904/570300563753795614/unknown.png[16:01:26] <hcb> https://cdn.discordapp.com/attachments/518172695439867904/570421865416491008/unknown.png[16:01:58] <hcb> I also changed "Duplicate" to "Clone tab" like in Opera.[16:02:08] <ellyjones> neat[16:02:15] <ellyjones> what are you overall working towards here?[16:03:10] <hcb> I want my custom Chromium build to look more like older versions, for example a narrow dark gray audio player and a clickable History option on the main menu. Tarnyko and myself are working on Discord to add XP support.[16:03:18] <ellyjones> ahh[16:03:42] <ellyjones> oh, you are collaborating over Discord, to re-add XP support to Chromium?[16:03:46] <hcb> You can see in the second pic that I kept the History sub-menu but changed it to say "Recent tabs".[16:03:54] <ellyjones> I was going to point out that Discord is closed-source :P[16:04:00] *** TheCowboy <TheCowboy!uid130777@gateway/web/irccloud.com/x-lqrbfenxkyggxzsq> has joined #chromium[16:04:07] <ellyjones> cool, best of luck![16:04:11] <hcb> Oh yeah, I can see the ambiguity.[16:04:16] <hcb> Thank you[16:04:47] <hcb> "oh, you are collaborating over Discord, to re-add XP support to Chromium?" Yes[16:05:02] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 245 seconds)[16:05:12] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has joined #chromium[16:06:37] <hcb> That was weird. I feel like the question I just answered was inserted above a message I sent.[16:07:45] <ellyjones> IRC does not have such a behavior[16:12:06] *** wildlander_ <wildlander_!~wildlande@134.85-85-3.dynamic.clientes.euskaltel.es> has quit IRC (Quit: Konversation terminated!)[16:15:29] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[16:16:49] *** himcesjf_ is now known as him-cesjf[16:17:43] *** agomez is now known as tanty[16:31:37] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[16:32:26] <thakis_> ellyjones: also, are you sure that irc doesn't reorder messages?[16:32:29] <thakis_> ellyjones: morning![16:32:37] <ellyjones> thakis_: IRC can reorder messages[16:32:56] <ellyjones> or rather, different clients can have different views of what order messages were in[16:33:09] <ellyjones> but it can't do the thing Slack/Discord does where the client has one view of message order, then updates it later[16:33:17] <j`ey> it just re-ordered messages for me, thakis_ said morning after askign that question :P[16:33:45] <thakis_> but i think i've never seen it happen[16:33:46] <thakis_> oh interesting, i didn't now that[16:34:15] <thakis_> j`ey: when i woke up this morning i realized that time is passing in reverse for me today, maybe it's just htat[16:34:28] <j`ey> :)[16:34:42] <ellyjones> eg, in Slack if I try to send a message from the mobile client at time T, and some other people talk at T + n, and my client can't get my message through to the server until T + 2n, Slack will reorder my view of when the messages happened so that my message is after theirs[16:34:53] <ellyjones> but if I do the same in irssi, my message (from my pov) will stay as being at time T[16:35:13] <ellyjones> there can also be disagreements about message ordering at the server side, since IRC is only weakly consistent in a distributed systems sense[16:35:55] <thakis_> probably something to do with slack and irc measuring time in different inertial frames[16:36:11] <j`ey> so irssi draws your text immediately? and just assumes the others will get it, with slack you draw it once you know the serve recieved the message[16:36:15] <j`ey> or somethng like that?[16:36:27] <ellyjones> j`ey: precisely[16:36:48] <ellyjones> IRC does not have "remote echo" - i.e., when you send a channel message, the server *doesn't* send it back to you[16:37:02] <ellyjones> so your IRC client has no way of knowing when it was received by the server - it just sticks it into your buffer as soon as it was sent[16:37:15] <ellyjones> which may be quite distant temporally from when the server received it[16:38:36] <ellyjones> thakis_: IRC does not bother to abstract away the fact that there are separate servers involved :) it's just like "the network isn't consistent, sorry!"[16:38:56] <ellyjones> an admirably unixy approach to the problem[16:41:53] *** bashfulshell <bashfulshell!uid190567@gateway/web/irccloud.com/x-rqripfyzrwlpqacx> has quit IRC (Quit: Connection closed for inactivity)[16:53:02] *** HerbY_NL2 <HerbY_NL2!~HerbY_NL2@2001:67c:2564:518:24ca:8625:32ce:8c9> has quit IRC (Quit: Leaving)[16:56:03] <hcb> How would I change a define in cflags? I see a file containing cflags in Chromium's code search called gn/build/gen.py but I don't have such a file.[16:56:27] <ellyjones> that's used for building gn[16:56:33] <ellyjones> which you probably are not doing[16:57:09] <ellyjones> anyway, there is no project-wide set of cflags (afaik); instead they are computed per target and as needed: https://cs.chromium.org/search/?q=file:.gn+cflags&sq=package:chromium&type=cs[16:57:10] <caitp> I think you can do something like `gn args --list <builddir>` to see all of the supported gn options, or read BUILD.gn files and look for something that defines the CFLAG you want[16:57:17] <caitp> something like that... it's been a while :)[16:57:54] <ellyjones> hello caitp![16:58:18] <caitp> hello ellyjones![16:58:24] <ellyjones> another IRC holdout, I see :)[16:58:55] <gsnedders> Who needs consistent message ordering? Pff. IRC4evar 💖[16:59:09] <hcb> I've checked a couple of build.gn's and I'm not finding what I need to change.[16:59:15] <ellyjones> gsnedders: amen, IRC life[16:59:47] <caitp> which cflag in particular do you care about?[17:00:35] <hcb> _WIN32_WINNT and and I think WINVER[17:01:00] <hcb> I see D_WIN32_WINNT defined in several places in the code search.[17:01:08] <hcb> For example, src/third_party/grpc/src/config.w32.[17:01:18] <ellyjones> https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?type=cs&q=_WIN32_WINNT+file:.gn&sq=package:chromium&g=0&l=299 maybe?[17:01:35] <ellyjones> you won't see it with the leading 'D' because gn has a syntax specifically for adding -Dfoo to cflags[17:01:44] <ellyjones> namely defines = [ ... ][17:01:46] *** sadrulhc <sadrulhc!~sadrul@2620:15c:0:26:c88d:f517:fe03:f4b7> has joined #chromium[17:01:46] *** ChanServ sets mode: +v sadrulhc[17:02:02] <ellyjones> anyway, my usual way of finding a thign like that is codesearch for the token in question with file:.gn[17:02:09] <ellyjones> and sometimes -file:third_party[17:02:21] <caitp> https://cs.chromium.org/search/?q=_WIN32_WINNT+lang:%5Egn$&sq=package:chromium&type=cs there are a few places[17:02:49] *** _Dark_ <_Dark_!~Dark@unaffiliated/notdark> has quit IRC (Quit: ZNC 1.7.3 - https://znc.in)[17:02:51] <hcb> Thank you. I think I was editing that file earlier and just didn't know this flag was there.[17:03:08] *** _Dark_ <_Dark_!~Dark@unaffiliated/notdark> has joined #chromium[17:13:28] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[17:22:55] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[17:24:38] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[17:24:45] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 268 seconds)[17:36:02] *** darktears <darktears!~darktears@kde/developer/menard> has joined #chromium[17:36:02] *** ChanServ sets mode: +v darktears[17:36:07] *** darktears <darktears!~darktears@kde/developer/menard> has quit IRC (Client Quit)[17:36:57] *** darktears <darktears!~darktears@kde/developer/menard> has joined #chromium[17:36:57] *** ChanServ sets mode: +v darktears[17:37:55] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[17:40:45] *** wolfshappen <wolfshappen!~wolfshapp@irc.furworks.de> has quit IRC (Ping timeout: 246 seconds)[17:42:01] *** wolfshappen <wolfshappen!~wolfshapp@irc.furworks.de> has joined #chromium[17:44:07] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has joined #chromium[17:44:52] *** tworaz <tworaz!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 276 seconds)[17:59:01] *** joonghunpark <joonghunpark!~joonghunp@14.52.19.146> has quit IRC (Quit: This computer has gone to sleep)[18:08:37] *** tassee <tassee!~tasse@55d4579c.access.ecotel.net> has joined #chromium[18:09:12] *** tasse <tasse!~tasse@55d4607e.access.ecotel.net> has quit IRC (Ping timeout: 245 seconds)[18:09:30] *** mgol <mgol!~m_gol@9dd3a2ad8e135.rev.snt.net.pl> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[18:09:37] *** tassee is now known as tasse[18:10:50] *** cmumford <cmumford!cmumford@nat/google/x-koxfuomdrssmsues> has joined #chromium[18:10:50] *** ChanServ sets mode: +v cmumford[18:13:54] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[18:16:04] *** rnk <rnk!rnk@nat/google/x-ikfvbzesspinmnub> has joined #chromium[18:16:05] *** ChanServ sets mode: +v rnk[18:16:58] *** maxmundus <maxmundus!~maxmundus@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[18:18:40] *** tasse <tasse!~tasse@55d4579c.access.ecotel.net> has quit IRC (Ping timeout: 276 seconds)[18:20:07] *** tasse <tasse!~tasse@55d4be81.access.ecotel.net> has joined #chromium[18:20:19] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[18:21:11] *** transfusion2 is now known as transfusion[18:21:53] *** mhrivnak <mhrivnak!~mhrivnak@li1282-118.members.linode.com> has quit IRC (Read error: Connection reset by peer)[18:31:36] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[18:31:49] *** tworaz_ <tworaz_!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 258 seconds)[18:32:43] *** maxmundus <maxmundus!~maxmundus@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[18:39:32] <Tarnyko> ellyjones: first needle in a haystack : https://chromium.googlesource.com/chromium/src.git/+/7a8a904bfdf23bb8cacba471718bc09a0d9a3175[18:40:41] <ellyjones> I think that getting modern chromium to run on winxp will be more like finding a stack of needles hidden inside a larger stack of hay[18:40:46] <ellyjones> and all the needles are very sharp[18:42:59] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has quit IRC (Quit: Leaving)[18:44:15] <Tarnyko> what about Win2000 ? I still have a client with a few machines running this[18:44:22] *** deviantfero <deviantfero!~deviantfe@ip168-243-230-189.intercom.com.sv> has joined #chromium[18:44:27] <ellyjones> that will be even more of an undertaking that Windows XP[18:44:55] <Tarnyko> we should ask if he's interested, and if he says so, start counting out time ^^[18:45:12] <deviantfero> hey guys, I was wondering where I could find more info on gtk's native theme support for chromium, I'm currently writing a GTK theme and I would love to switch up the colors here and there[18:45:15] <deviantfero> nothing to fancy[18:45:15] <torne> i would not be surprised if progress toward modern chromium running on XP is slower than the rate at which XP machines go out of service :)[18:45:32] <deviantfero> but can't seem to find docs on which classes do what on chromium, just some of them[18:45:33] *** oiseaubleue <oiseaubleue!~oiseauble@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[18:45:33] <torne> but if someone's going to pay you to do it then hey[18:45:50] <ellyjones> just so you understand the magnitude of the task here, it's very possible that we will add *new* code that does not run on WinXP faster than you are able to port to WinXP[18:46:13] <ellyjones> there are ~hundreds of chromium devs and probably 5-6 people who work solely on Windows stuff, even before you add whoever from Microsoft is working on Edge[18:46:32] <torne> yeah i would not be surprised if this speeds up with contributions from Edge developers :)[18:46:42] <Tarnyko> ellyjones, torne: even ReactOS, which was supposed to emulate Win2000/XP at its beginning, supports this API now :p ( https://reactos.org/pipermail/ros-diffs/2006-August/013936.html )[18:47:10] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[18:47:38] <ellyjones> it's almost certainly a better use of your (and everyone's) time to push people to upgrade to Win7 or Win10 than it is to backport a codebase the size of Chromium[18:47:51] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has joined #chromium[18:47:57] *** jamm <jamm!~jam@unaffiliated/jamm> has quit IRC (Ping timeout: 245 seconds)[18:49:04] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[18:49:16] <gsnedders> Tarnyko: pretty sure ReactOS predates Win2000; probably was NT4 originally?[18:49:45] <Tarnyko> have you read Terry Pratchett ? "Why did they build gigantic cratertubs of lava for their machines instead of using lasers ? - Because they found it cool and could do it".[18:50:02] <ellyjones> if you are doing it for fun, then by all means, proceed[18:50:11] <ellyjones> but if you were doing it for work purposes I was going to ask you to reconsider :P[18:50:16] *** Arokh <Arokh!~MoveAlong@ip-109-90-223-178.hsi11.unitymediagroup.de> has quit IRC (Ping timeout: 258 seconds)[18:50:26] <Tarnyko> gsnedders: indeed it was NT. Win9x was out of question even back then[18:51:43] *** Arokh <Arokh!~MoveAlong@ip-109-90-223-178.hsi11.unitymediagroup.de> has joined #chromium[18:56:31] <Tarnyko> let me check what is running XP here... an embedded arcade machine, my bank's ATM. Unlucky me: the ATM's keyboard leaves to be desired ^^[18:56:44] <ellyjones> haha oh dear[18:58:42] *** Arokh <Arokh!~MoveAlong@ip-109-90-223-178.hsi11.unitymediagroup.de> has quit IRC (Ping timeout: 259 seconds)[19:00:16] *** RT|Chatzilla <RT|Chatzilla!~chatzilla@reactos/tester/RT> has quit IRC (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2016020300])[19:00:42] <Abdu_Ameen> In manage_passwords_state.cc in "chrome/browser/ui/passwords" there is AppendDeepCopyVector(). I'm changing the form_fetcher_impl which is interfering with this function. What exactly is that function doing?[19:02:12] <hcb> Anyone know what type CRITICAL_SECTION is?[19:02:23] *** dydz <dydz!~dydz@17.192.24.32> has joined #chromium[19:02:45] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has quit IRC (Quit: Leaving)[19:04:19] *** Hexcles_ <Hexcles_!~Hexcles@2620:15c:0:8:408e:78bb:ec2b:6ad3> has joined #chromium[19:04:22] *** Hexcles_ <Hexcles_!~Hexcles@2620:15c:0:8:408e:78bb:ec2b:6ad3> has quit IRC (Client Quit)[19:04:49] *** oiseaubleue <oiseaubleue!~oiseauble@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Ping timeout: 276 seconds)[19:04:52] <hcb> It seems to be an alias for OSLockType.[19:05:10] *** Satsuki <Satsuki!~Satsuki@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[19:05:21] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has joined #chromium[19:08:47] *** tworaz <tworaz!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 245 seconds)[19:09:01] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[19:10:02] *** Satsuki <Satsuki!~Satsuki@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Ping timeout: 250 seconds)[19:11:50] *** monkeystance <monkeystance!~monkeysta@110-174-85-242.static.tpgi.com.au> has left #chromium ("Leaving")[19:13:51] *** sakasanje <sakasanje!~Dominik@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[19:24:44] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[19:26:34] *** sauvin <sauvin!sauvin@about/linux/staff/sauvin> has quit IRC (Read error: Connection reset by peer)[19:27:15] *** al-damiri <al-damiri!uid142631@gateway/web/irccloud.com/x-owngcaqdjksfdmze> has joined #chromium[19:40:09] *** rnk <rnk!rnk@nat/google/x-ikfvbzesspinmnub> has quit IRC (Ping timeout: 252 seconds)[19:41:15] *** gunni <gunni!~gunni@meh/gunni> has quit IRC (Ping timeout: 258 seconds)[19:41:56] *** gunni <gunni!~gunni@meh/gunni> has joined #chromium[19:42:46] *** rnk <rnk!rnk@nat/google/x-uqavnjwegbljkqxl> has joined #chromium[19:42:46] *** ChanServ sets mode: +v rnk[19:51:09] *** sakasanje <sakasanje!~Dominik@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[19:59:06] *** Hunterkane <Hunterkane!~Megamanze@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[20:01:04] <hcb> Tarnyko helped me replace all the SRW locks we could find and after much trial and error, it seems to be compiling.[20:01:51] <Tarnyko> Beware, there may still be some of them lurking around ^^[20:02:45] <hcb> I thought we replaced the interface everything connects to.[20:02:57] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-liquyisutwbmyuwc> has quit IRC (Quit: Connection closed for inactivity)[20:03:23] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has quit IRC (Quit: Leaving)[20:03:39] <hcb> It compiled about 394 targets before failing again.[20:04:49] <Tarnyko> I guessed more work never fails to show ^^[20:05:07] *** cloudshu <cloudshu!uid51395@gateway/web/irccloud.com/x-nnsgohglzgzmzlzy> has joined #chromium[20:05:14] *** Hunterkane <Hunterkane!~Megamanze@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[20:05:32] <hcb> I pasted the error in Discord.[20:05:39] <hcb> Tarnyko ^[20:05:53] <ellyjones> if y'all are mostly coordinating with each other, and not asking questions or speaking for a wider audience, could you coordinate in a different place?[20:06:06] <ellyjones> I look at this channel often to see if there are questions/etc and I keep seeing traffic that is really just between you two :)[20:06:45] *** chrisccoulson <chrisccoulson!~chrisccou@ubuntu/member/chrisccoulson> has quit IRC (Quit: OSError: [Errno 130] Owner died)[20:07:46] <thakis_> i think it's fun to watch[20:07:52] <thakis_> isn't all that busy in here anymore anyhow[20:08:22] <ellyjones> yeah, that's true[20:08:32] <ellyjones> maybe I just need to read IRC less often than once every 15 seconds[20:08:33] <hcb> ellyjones: Okay[20:09:10] *** deviantfero <deviantfero!~deviantfe@ip168-243-230-189.intercom.com.sv> has quit IRC (Ping timeout: 276 seconds)[20:10:25] *** chrisccoulson <chrisccoulson!chrisccoul@ubuntu/member/chrisccoulson> has joined #chromium[20:10:28] *** neonimp <neonimp!~neonimp@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[20:11:13] *** deviantfero <deviantfero!~deviantfe@ip168-243-230-189.intercom.com.sv> has joined #chromium[20:13:01] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has joined #chromium[20:13:22] *** tworaz <tworaz!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 245 seconds)[20:13:30] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[20:14:17] *** Jesin <Jesin!~Jesin@pool-72-83-62-150.washdc.fios.verizon.net> has joined #chromium[20:22:51] <Abdu_Ameen> ellyjones: What does manage_password_state do?[20:23:28] <ellyjones> Abdu_Ameen: can we get a bit more context? no hits in codesearch: https://cs.chromium.org/search/?q=manage_password_state&sq=package:chromium&type=cs[20:23:31] *** litherum <litherum!~litherum@2620:149:f:1870:b44b:b769:59d0:207d> has joined #chromium[20:23:54] <Abdu_Ameen> manage_passwords_state[20:23:56] <Abdu_Ameen> my bad[20:24:12] <ellyjones> there's a comment on the class: https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_state.h?q=manage_passwords_state&sq=package:chromium&dr=CSs&l=27[20:30:13] <Abdu_Ameen> in AppendDeepCopyVector() in manage_passwords_state, it is creating a new form right?[20:30:31] <Abdu_Ameen> on this line. result->push_back(std::make_unique<autofill::PasswordForm>(*form));[20:30:37] <ellyjones> sorry, we're super far out of my area here[20:31:01] <Abdu_Ameen> no problem[20:31:12] <ellyjones> you might need to contact the owners for that code, probably via email[20:32:00] <Abdu_Ameen> Ok thanks[20:34:06] *** deviantfero <deviantfero!~deviantfe@ip168-243-230-189.intercom.com.sv> has quit IRC (Ping timeout: 258 seconds)[20:46:45] *** capOM <capOM!~julien@hqfw01-adm.oblong.com> has joined #chromium[20:47:04] *** SerialSmile <SerialSmile!~SerialSmi@83.102.198.70> has quit IRC (Quit: Leaving)[20:55:54] *** rego <rego!uid293518@gateway/web/irccloud.com/x-rasjfzvdmnrnsyaj> has quit IRC (Quit: Connection closed for inactivity)[21:02:00] *** lnostdal <lnostdal!~lnostdal@77.70.119.51> has quit IRC (Remote host closed the connection)[21:02:52] *** krollin <krollin!~krollin@2620:149:f:1874:1494:9ce0:a4e0:7c5b> has quit IRC (Quit: Leaving...)[21:14:01] *** ajax16384 <ajax16384!~User@109.60.130.33> has joined #chromium[21:17:50] *** neonimp <neonimp!~neonimp@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[21:20:38] *** Horus_Sirius1 <Horus_Sirius1!~Thunderbi@x4d009318.dyn.telefonica.de> has quit IRC (Quit: Horus_Sirius1)[21:25:03] *** vladutz <vladutz!~j@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[21:27:40] <Abdu_Ameen> If I want to run a unit-test for a specific component, how do I do this?[21:28:19] <Abdu_Ameen> I built the unit test exe and im assuming that https://chromium.googlesource.com/chromium/src/+/master/docs/test_descriptions.md is the filters[21:28:55] *** vladutz <vladutz!~j@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[21:29:02] <Abdu_Ameen> but how would i know if my unit test is included in the filter?[21:30:24] <ellyjones> just do: out/rel/unit_tests --gtest_filter=YourSuite.YourTest[21:30:32] <ellyjones> right? if it's included you will see it run, if not you won't[21:30:55] <Abdu_Ameen> What is your suite?[21:31:08] <ellyjones> if your test is TEST(Foo, Bar) the suite is foo[21:31:10] <ellyjones> er is Foo[21:33:44] *** Arokh <Arokh!~MoveAlong@ip-109-90-223-178.hsi11.unitymediagroup.de> has joined #chromium[21:33:47] *** tworaz <tworaz!~tworaz@185.217.215.2> has quit IRC (Ping timeout: 245 seconds)[21:33:50] *** DanBeuregard <DanBeuregard!~DanBeureg@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[21:33:57] *** tworaz <tworaz!~tworaz@185.217.215.2> has joined #chromium[21:34:21] <Abdu_Ameen> thats the same with test_f?[21:35:29] <ellyjones> yup, TEST_F(Foo, Bar) creates a test with suite name Foo and test name Bar[21:35:44] <Abdu_Ameen> Ok thanks for the help[21:37:02] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[21:38:13] *** rnk <rnk!rnk@nat/google/x-uqavnjwegbljkqxl> has quit IRC (Ping timeout: 276 seconds)[21:40:31] *** krollin <krollin!~krollin@2620:149:f:1874:651f:18f5:9103:4b59> has joined #chromium[21:41:28] *** booshibonton <booshibonton!~booshibon@unaffiliated/booshibonton> has quit IRC (Ping timeout: 276 seconds)[21:43:20] *** rnk <rnk!~rnk@104.133.9.68> has joined #chromium[21:44:55] *** mgol <mgol!~m_gol@9dd3a2ad8e135.rev.snt.net.pl> has joined #chromium[21:52:19] *** DanBeuregard <DanBeuregard!~DanBeureg@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)[21:54:05] *** CtrlPprint <CtrlPprint!~ya_nova@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has joined #chromium[21:58:53] *** MoziM <MoziM!~alarm@ip98-164-249-59.oc.oc.cox.net> has quit IRC (Quit: WeeChat 2.4)[21:59:39] *** krollin <krollin!~krollin@2620:149:f:1874:651f:18f5:9103:4b59> has quit IRC (Quit: Leaving...)[22:01:33] *** thakis_ <thakis_!~thakis_@ool-44c79ec4.dyn.optonline.net> has quit IRC (Quit: thakis_)[22:07:25] *** fordfrog <fordfrog!~fordfrog@gentoo/developer/fordfrog> has quit IRC (Quit: Leaving)[22:16:15] *** MoziM <MoziM!~alarm@ip98-164-249-59.oc.oc.cox.net> has joined #chromium[22:38:02] *** CtrlPprint <CtrlPprint!~ya_nova@adijon-456-1-22-24.w86-235.abo.wanadoo.fr> has quit IRC (Ping timeout: 250 seconds)[22:40:05] *** litherum_ <litherum_!~litherum@2620:149:f:1870:44e1:582:a1a4:6d45> has joined #chromium[22:40:37] *** litherum <litherum!~litherum@2620:149:f:1870:b44b:b769:59d0:207d> has quit IRC (Ping timeout: 276 seconds)[22:50:11] *** narispo <narispo!~narispo@185.156.173.27> has joined #chromium[22:51:41] *** ajax16384 <ajax16384!~User@109.60.130.33> has quit IRC (Quit: Leaving)[22:52:13] *** mgol <mgol!~m_gol@9dd3a2ad8e135.rev.snt.net.pl> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)[22:56:52] *** litherum_ <litherum_!~litherum@2620:149:f:1870:44e1:582:a1a4:6d45> has quit IRC (Ping timeout: 276 seconds)[23:01:39] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has joined #chromium[23:11:41] *** litherum <litherum!~litherum@2620:149:f:1870:f9af:c28f:f7e3:18c9> has joined #chromium[23:24:54] *** jrmuizel <jrmuizel!~jrmuizel@135-23-101-109.cpe.pppoe.ca> has quit IRC (Remote host closed the connection)[23:35:14] *** rnk <rnk!~rnk@104.133.9.68> has quit IRC (Ping timeout: 250 seconds)[23:40:11] *** litherum <litherum!~litherum@2620:149:f:1870:f9af:c28f:f7e3:18c9> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)[23:40:46] *** prodigel <prodigel!~florin@95.169.231.203> has joined #chromium[23:44:19] <trungl-bot> Tree opened by hiroshige at google dot com: Tree is open (reverted CL that caused PRESUBMIT failures crbug.com/956247)[23:44:30] *** a-ja <a-ja!~aja@99-165-110-64.lightspeed.stlsmo.sbcglobal.net> has joined #chromium[23:44:49] *** edwardly <edwardly!~edwardly@unaffiliated/edwardly> has quit IRC (Read error: Connection reset by peer)[23:45:39] <prodigel> google-chrome IOS build issues are relevant on this channel?[23:49:21] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "gclient runhooks" on https://ci.chromium.org/p/chromium/builders/ci/linux-jumbo-rel/23706 "linux-jumbo-rel" from 69dc927d90f665ff2c1d6bce6e5b89dbf8dfc9ac: chromium-autoroll at skia-public dot iam.gserviceaccount.com,skhandelwa22@bloomberg.net,marcin@mwiacek.com,szager@chromium.org,drubery@chromium.org)[23:49:25] *** edwardly <edwardly!~edwardly@pool-71-190-177-155.nycmny.fios.verizon.net> has joined #chromium[23:49:25] *** edwardly <edwardly!~edwardly@pool-71-190-177-155.nycmny.fios.verizon.net> has quit IRC (Changing host)[23:49:25] *** edwardly <edwardly!~edwardly@unaffiliated/edwardly> has joined #chromium[23:52:32] *** narispo <narispo!~narispo@185.156.173.27> has quit IRC (Ping timeout: 245 seconds)[23:52:51] *** narispo <narispo!~narispo@185.156.173.27> has joined #chromium[23:54:23] <trungl-bot> Tree opened by buildbot at chromium dot org: Tree is open (Automatic: ヽ(^。^)ノ)[23:55:35] <_Dark_> prodigel: yes[23:58:05] *** rnk <rnk!~rnk@104.133.9.68> has joined #chromium[23:59:30] <prodigel> I'm trying to understand if navigation within an iframe being lost when hitting the 'back' button is correct or not. A good example page: https://w3schools.com/htmL/html_iframe.asp If you click on menu items inside the example Iframe going back and forth works as expected on most platforms/browsers, with one notable exception; iOS Chrome. Even iOS Safari works. Could this be a bug or a 'feature'?