[00:00:21] *** exxe has quit IRC
[00:01:30] <thakis> trungl: thanks
[00:01:54] <phajdan-jr> now landing another patch of death, hehe
[00:02:00] * trungl should make trungl-bot able to do reviews.
[00:02:25] <phajdan-jr> trungl: how about detecting changes landing without green trybots?
[00:02:49] <trungl> but then it would complain about me all the time!
[00:02:54] <trungl> (probably not just me)
[00:03:16] <phajdan-jr> we should make the trybots faster then. working on that.
[00:03:21] <rdsmith> I rarely get all green trybots; more often there's a red that really looks like it doesn't have to do with my stuff.
[00:03:24] <trungl> and more reliable
[00:03:29] <phajdan-jr> oh yeah
[00:04:00] <trungl> and plus there's the problem that sometimes you get green try results, and then make some comment-only changes (or similar)
[00:05:44] <Hixie> find-in-page on http://www.whatwg.org/specs/web-apps/current-work/complete.html doesn't always seem to trigger
[00:05:52] *** taf2 has quit IRC
[00:05:57] <Hixie> e.g. try searching for "attribute" and then quickly changing that to "pattern attribute"
[00:06:07] <Hixie> (by moving to the start of the field and adding "pattern ")
[00:06:13] <Hixie> is it just me? or should i file a bug?
[00:08:49] <nsylvain> rdsmith: ms6 ? Are you talking about the official builders? If so, yes, this is expected, and 1h is actually fast ;) Doing a full checkout on windows takes forever, and all our official builds are from full checkouts
[00:09:06] <nsylvain> and now I just saw the email
[00:09:21] <rdsmith> Are the beta builders official?  In that case, ah, bummer, I'll just resign myself to waiting.
[00:09:21] *** bweinstein has quit IRC
[00:09:38] <rdsmith> And it's 1h and counting, so don't get too excited :-}.
[00:09:42] *** oal has quit IRC
[00:09:50] <nsylvain> rdsmith: depends which one
[00:10:25] <rdsmith> nsylvain: http://chrome-master.mtv.corp.google.com:8010/builders/google%20chrome%20beta
[00:10:36] <jamesr> Hixie: is this before the page is fully loaded or after?
[00:10:37] <nsylvain> no internal url in public please ;)
[00:10:57] *** arv__ has quit IRC
[00:11:02] <rdsmith> It just switched over to compiling.  So 1 hour and 24 minutes.
[00:11:03] <jamesr> Hixie: oh wow, yeah i can repro
[00:11:06] <rdsmith> Whoops; sorry.
[00:11:21] <thakis> Hixie: works for me, is just very slow
[00:11:25] <nsylvain> rdsmith: so this machine does not usually do full checkouts, but this time it did. It's done now though
[00:11:36] <nsylvain> next time should be better
[00:11:40] <rdsmith> Huh.  Ok.
[00:11:48] <jamesr> thakis: seems slower than it should be
[00:11:48] <rdsmith> Sounds good.  That'll be the one my merge'll be in :-}.
[00:11:55] <jamesr> thakis: i wonder if we're issuing a lot of searches that find nothing
[00:12:10] <thakis> jamesr: it's because the renderer is busy playing starcraft 2
[00:12:15] <jamesr> i.e. searching for "pat attribute" when the user has already typed up to "patter attribute"
[00:15:37] *** Adys has joined #chromium
[00:15:55] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Linux Builder (ChromiumOS)" from 54206: brettw at chromium dot org, phajdan.jr at chromium dot org (:phajdan-jr), pkasting at chromium dot org, thakis at chromium dot org, victorw at chromium dot org)
[00:16:08] <thakis> fffffffffffuuuuuuuuu
[00:16:15] <thakis> oh, linux
[00:16:31] <trungl> so much rage
[00:16:33] <trungl> there there
[00:16:35] *** arv__ has joined #chromium
[00:16:36] <thakis> checkign in at the same time as pkasting and brettw is just asking for trouble
[00:16:37] <jamesr> thakis: brettw and pkasting and a webkit roll are in that blamelist, you are probably fine
[00:16:53] <xji_> phajdan-jr: are you looking at the compilation error?
[00:17:00] <phajdan-jr> xji_: yes
[00:17:11] <victorw> distcc[12681] (dcc_writex) ERROR: failed to write: Connection refused distcc[12681] (dcc_writex) ERROR: failed to write: Broken pipe
[00:17:24] <phajdan-jr> xji_: that's me, fixing
[00:17:25] <Hixie> jamesr: should i file a bug? it seems like it's just a timeout issue, if i just rewrite "pattern attribute" from scratch if usually works fine
[00:17:29] <thakis> chrome/browser/dom_ui/filebrowse_ui.cc
[00:17:39] *** pdelgallego has quit IRC
[00:17:47] <jamesr> Hixie: the behavior seems sub ideal, please file a bug
[00:17:54] <jamesr> it's a polish issue
[00:17:56] <thakis> trungl-bot: settreestatus Tree is closed (phajdan-jr looking at linux)
[00:17:57] <trungl-bot> thakis: Set tree status to: "Tree is closed (phajdan-jr looking at linux) [set by :thakis]".
[00:18:08] <thakis> trungl: make it not repeat the status
[00:18:13] <thakis> quick
[00:18:22] <Hixie> jamesr: k
[00:18:24] <trungl> i could just kill trungl-bot
[00:18:37] <jamesr> i like trungl-bot
[00:18:57] <trungl-bot> Tree closed by xji at chromium dot org: Tree is closed ("compile" fail on "Linux Builder (ChromiumOS)" -> phajdan-jr)
[00:19:04] <thakis> trungl: `def handlesettreestatus(self, s): self.handlesettreestatusimpl(s); time.sleep(15); sys.exit(1)`
[00:19:18] <thakis> and have a watcher process that restarts it
[00:19:25] <thakis> sounds like a clean solution
[00:19:33] <trungl> haha
[00:19:58] <trungl> thakis: you should clearly just use the command-line util to set the tree status
[00:20:04] <xji_> hmm.... why when I submit the change in tree status, it did not let me know there is conflict (someone already updated it, and I am based on old status)
[00:20:30] <thakis> trungl: is there one?
[00:20:39] <thakis> trungl-bot is my extended command line
[00:20:39] <trungl-bot> thakis: Error: "is" is not a valid command.
[00:21:22] <trungl> thakis: in trunk/tools/treestatus
[00:21:26] <rohitrao> trungl: go find mirandac for me :)
[00:21:42] <eglaysher> rohitrao: she's not at her desk
[00:21:55] <trungl> eglaysher: rohitrao said trungl, not eglaysher
[00:21:58] <rohitrao> but I want her to do a review :P
[00:22:01] <trungl> rohitrao: what eglaysher said
[00:22:15] <trungl> rohitrao: maybe she'll be back
[00:22:18] <thakis> trungl: sweet! why is that not in src/tools tho? I don't checkout tools/ on most of my clients
[00:22:21] <rohitrao> i hope so
[00:22:24] <trungl> rohitrao: though I think she'll be on vacation
[00:22:30] <trungl> rohitrao: (starting tomorrow)
[00:22:35] <rohitrao> oh, hm
[00:22:36] <trungl> thakis: I have no idea
[00:22:48] <trungl> thakis: there's no method to the organizational madness
[00:23:13] <phajdan-jr> landing the fix
[00:23:16] <phajdan-jr> speculative
[00:24:06] *** bers has quit IRC
[00:25:01] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (phajdan.jr fixing ChromiumOS, speculative fix landed)
[00:26:36] *** bweinstein has joined #chromium
[00:28:48] *** bweinstein has quit IRC
[00:29:13] <brettw> xji: I've got to leave about 4:30 today, can you look after the tree after that?
[00:29:17] <brettw> got a class to go to
[00:29:28] <brettw> (till whenever you go home)
[00:33:41] <phajdan-jr> still fixing
[00:33:46] <phajdan-jr> maybe we can keep the tree open
[00:34:13] <phajdan-jr> uh-oh, some fallout from earlier patches
[00:34:16] <phajdan-jr> will fix anyway
[00:34:50] <brettw> phajdan-jr, you mean Sort, right?
[00:34:56] <brettw> are you looking at that?
[00:35:21] *** fta has quit IRC
[00:35:28] <xji_> brettw: sure. I will leave on 6:30.
[00:35:32] <phajdan-jr> brettw: I mean AppendTab
[00:35:52] <brettw> okay, I'll look at Sort
[00:36:41] <brettw> thakis, looks like you broke Sort
[00:36:52] <thakis> brettw: yay me
[00:37:11] <thakis> looking
[00:37:25] <phajdan-jr> updated tree status
[00:38:09] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (ChromiumOS -> should cycle green, Sort -> thakis)
[00:38:28] <thakis> brettw: it's a bug in the test
[00:38:37] <thakis> fixing, but will be a while (need to sync and rebuild)
[00:38:43] <thakis> feel free to revert in the meantime
[00:38:47] <thakis> if you feel like it
[00:39:18] <thakis> brettw: nvm i'lll revert myself
[00:40:21] <thakis> reverted
[00:40:21] <brettw> thakis, thanks
[00:40:53] <evmar> can anyone review http://codereview.chromium.org/3043030/show ? it's an obvious file rename
[00:41:24] <phajdan-jr> I'll do
[00:41:26] *** thakis has left #chromium
[00:41:32] *** thakis has joined #chromium
[00:41:33] *** ChanServ sets mode: +v thakis
[00:41:34] *** thakis has left #chromium
[00:41:55] <evmar> it's related to the discussion on reducing the number of files in chrome/browser.  i figured i could run a tryjob on each of these renames while i do other stuff
[00:43:08] <phajdan-jr> evmar: LGTM with a nit.
[00:43:27] <rohitrao> evmar: does anyone still need to merge firstrun changes to the branch?
[00:43:44] <evmar> rohitrao: i dunno
[00:43:50] <evmar> rohitrao: that's a good point.  :(
[00:43:58] <rohitrao> trungl: how do you feel about looking at http://codereview.chromium.org/3052027/show ? :)
[00:44:14] <evmar> if we ship every six weeks does this mean our files are gonna be advisory-locked for two out of every six weeks?  :\
[00:44:15] <rohitrao> evmar: we were just talking about how the 6wk schedule makes it hard to do refactorings
[00:44:16] <trungl> rohitrao: I can't tell until I look at it
[00:45:11] <trungl> we just have to refactor really, really quickly
[00:45:36] <xji> markmentovai: looks like need to run "svn cleanup" to remove locks on chromium reliability buildbot again. http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/11344/steps/shell/logs/stdio
[00:46:08] <phajdan-jr> ^^^ can we automated that?
[00:46:34] *** nickcarter has quit IRC
[00:46:44] <trungl> rohitrao: looking, btw
[00:47:26] <xji> I still do not know how to do that.
[00:48:52] *** seventh has joined #chromium
[00:49:04] * trungl is so confused
[00:49:42] <rohitrao> about my cl? sad
[00:49:51] <rohitrao> I'm not really sure how everything broke so badly
[00:50:49] *** __ed has quit IRC
[00:51:16] *** aroben|lunch has quit IRC
[00:51:42] <rohitrao> trungl: http://codereview.chromium.org/3051001 went in between the branch and the revert, which is why nothing was as straightforward as it should've been
[00:52:09] *** satish_ has quit IRC
[00:52:25] <trungl> rohitrao: right
[00:52:39] <trungl> rohitrao: and the thing you're changing did seem wrong
[00:52:42] <trungl> I think
[00:52:49] <rohitrao> oh, I know it's wrong :)
[00:52:55] <trungl> you should just try it ;)
[00:52:57] <rohitrao> tests pass post-change, but not pre-change
[00:53:03] <rohitrao> so this seems like a step forward
[00:53:06] <rohitrao> ok, will submit
[00:53:07] <trungl> rohitrao: ship it!
[00:53:13] <jhawkins> brettw: revert in, what's eta on tree opening?
[00:53:21] <jhawkins> or fix in, whichever
[00:53:59] <rdsmith> So a buildbot question: If there's a crash in the page cycler tests, how can I get at the stack backtrace?  Currently I'm just seeing that expected crashes != actual crashes.
[00:54:07] <rdsmith> (MS6 beta buildbots.)
[00:54:09] *** hrna has quit IRC
[00:54:19] <phajdan-jr> rdsmith: there should be a step called "Process Dumps" or similar
[00:55:00] <rohitrao> trungl, jrg: thanks.  now the moment of truth
[00:55:05] <rohitrao> or perhaps the three hours of truth
[00:55:05] <jrg> bnp
[00:55:10] <jrg> fingers crossxed
[00:55:23] <xji> nsylvain: ping
[00:55:32] <rdsmith> phajdan-jr: In the stdio output?  Or in the build log?  I'm not seeing it.
[00:55:33] <rohitrao> I *think* this will take care of unit_tests on all platforms
[00:55:35] <nsylvain> xji: what's up?
[00:55:42] <trungl> rohitrao: go rohitrao!
[00:55:49] * trungl is just a cheerleader
[00:56:30] <xji> nsylvain: chromim reliability buildbot needs to run "svn cleanup" to remove locks. http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/11345/steps/shell/logs/stdio
[00:56:37] <xji> nsynvain: btw, how do I do that?
[00:56:49] *** isherman has joined #chromium
[00:56:49] *** ChanServ sets mode: +v isherman
[00:56:50] <nsylvain> Just like that ;) Pinging me is the best way
[00:56:53] <nsylvain> i'll fix
[00:57:01] <phajdan-jr> rdsmith: I'm not sure, it's usually one of the build steps, like compile, unit_tests, and so on
[00:57:08] <brettw> probably OK to open
[00:57:16] <xji> nsylvain: ok ;) thanks then
[00:57:55] <rohitrao> brettw++ for finding that cros audio bug, btw
[00:58:01] <xji> nsylvain: like phajdan-jr said: can we make that automatic?
[00:58:16] <brettw> rohitrao, it was trivial after logging into the bot
[00:58:19] <brettw> probably should have done that earlier
[00:58:20] <trungl-bot> Tree opened by brettw at chromium dot org: Tree is open (ChromiumOS -> should cycle green, Sort -> thakis)
[00:58:54] <dhollowa> mrossetti: ping
[00:59:01] <nsylvain> xji: we should
[00:59:14] <mrossetti> dhollowa: ACK
[00:59:35] <dhollowa> mrossetti: i'm getting bookmark_bar... compile error on 472
[00:59:42] <rdsmith> phajdan-jr: I've just read through that list, and I'm not seeing anything like it.  Could you chat me, and I'll send you the URL and you can tell me what I'm missing?
[00:59:52] <dhollowa> mrossetti: yours?
[00:59:57] *** Adys has quit IRC
[01:00:11] <phajdan-jr> rdsmith: sent you the chat invite
[01:00:11] <mrossetti> k, I'm sure it is dhollowa.
[01:00:21] *** thakis has joined #chromium
[01:00:21] *** ChanServ sets mode: +v thakis
[01:00:30] *** scherkus has quit IRC
[01:00:34] <dhollowa> i'll IM you the details.
[01:00:55] *** Adys has joined #chromium
[01:01:58] <fishd> hmm.. tip-of-tree crashes whenever i resume my laptop from sleep
[01:02:01] <fishd> on windows
[01:02:41] <phajdan-jr> is the sleep and resume what causes it to crash? Would be interesting to see the stack trace.
[01:03:26] <phajdan-jr> I hope it's not some Singleton in base
[01:03:59] *** bweinstein has joined #chromium
[01:04:53] <thakis> fishd: http://crbug.com/34928 ?
[01:05:57] <thakis> stack would help
[01:06:37] <phajdan-jr> thakis: there are some dumps attached to that bug
[01:07:45] <phajdan-jr> nsylvain: could you file a GreenTreeTaskForce bug about automating svn cleanup?
[01:08:00] <nsylvain> ok
[01:08:06] <phajdan-jr> thanks!
[01:11:24] *** andybons has quit IRC
[01:11:46] <thakis> phajdan-jr: do you know how to read dmp files?
[01:11:52] <thakis> dmp != stack trace
[01:11:59] <phajdan-jr> thakis: I know absolutely nothing about it :(
[01:12:23] <jamesr> thakis: open them in windbg?
[01:12:37] <thakis> jamesr: does that run on os x?
[01:12:55] <jamesr> the .dmps i see on that bug are from windows
[01:13:08] <jamesr> that's an os-win bug
[01:13:40] *** homata_ has joined #chromium
[01:13:48] <thakis> if there was a text stack, i could at least look through the code for something obvious
[01:14:17] <nsylvain> thakis: I,ll try to get you one
[01:14:27] <thakis> cool
[01:15:39] *** awolfson has quit IRC
[01:17:11] <mirandac> rohitrao: still need review?
[01:17:31] <rohitrao> mirandac: you're back!  can you tell me if http://codereview.chromium.org/3052027/show looks horribly wrong?
[01:17:42] <rohitrao> I've already submitted it, but that's easy to fix :)
[01:18:02] <rohitrao> I'm assuming the intent was to put the file back the way it was before
[01:18:29] <mirandac> rohitrao: looking!  sorry, was getting hair length adjusted :-)
[01:18:40] <rohitrao> I have to do that tomorrow
[01:19:26] <mirandac> ah, I see -- my revert was not quite exactly what it should have been.  :-/
[01:19:47] <nsylvain> thakis:  The stack from windbg is not great. It seems like it's crashing while trying to start a thread, but i'm not sure yet what the thread is.  The guy also wrote a crash id, and it's visible on the crash server, so you can poke there too. i'll continue looking for a few minutes to see if there is anything interesting in the dump
[01:19:53] <mirandac> or, wait -- I thought I reverted this myself.  hmm!
[01:20:11] *** kerz has joined #chromium
[01:20:13] *** ChanServ sets mode: +v kerz
[01:20:17] <kerz> mrossetti, ping
[01:20:31] <kerz> looks like the mac builder is failing to compile your latest change on 472
[01:20:35] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 54221: ananta at chromium dot org (:iyengar), ben at chromium dot org)
[01:20:36] <mrossetti> kerz: ACK
[01:20:43] <mrossetti> kerz: Just reverted.
[01:20:49] <kerz> excellent, many thanks
[01:21:06] <mirandac> rohitrao: it looks right, in any case.  I had added createBookmarkModel when the NTP had a bookmark promo (for a week) -- but now there's no need for it.  I thought I had removed this in my own change, though.  hmm.
[01:21:38] <rohitrao> everything looks good on trunk
[01:21:44] <nsylvain> thakis: a thread is stuck trying to resolve a dns name.  not sure if it's a problem or not
[01:21:58] <rohitrao> but the branch was all weird, because all of TestingProfile was rewritten between the branch and your revert
[01:22:08] <nsylvain> (actually, at least 3 threads are waiting for dns)
[01:22:28] <mirandac> rohitrao: ah, I see!  wow, thanks for catching this.  bleagh!
[01:23:35] <trungl-bot> Tree opened by brettw at chromium dot org: Tree is open (ChromiumOS -> should cycle green, Sort -> thakis)
[01:23:37] *** tonikitoo has joined #chromium
[01:23:52] <thakis> brettw: can you remove me from the status?
[01:24:13] <thakis> ree is open (ChromiumOS -> should cycle green, thakis -> brettw)
[01:24:25] <thakis> trungl-bot: settreestatus tree is open (ChromiumOS -> should cycle green, thakis -> brettw)
[01:24:26] <trungl-bot> thakis: Set tree status to: "tree is open (ChromiumOS -> should cycle green, thakis -> brettw) [set by :thakis]".
[01:24:36] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): tree is open (ChromiumOS -> should cycle green, thakis -> brettw) [set by :thakis]
[01:24:39] <rohitrao> wait, what?
[01:24:51] <rohitrao> thakis -> brettw
[01:24:52] <rohitrao> really?
[01:25:03] <thakis> to remind him to remove me
[01:25:21] <xji> brettw: is the compilation failure in webkit builder a buildbot problem?
[01:25:23] <bryner> anyone (nsylvain?) know if there are windows trybot issues that would cause interactive_ui_tests to fail?
[01:25:30] <bryner> http://build.chromium.org/buildbot/try-server/builders/win/builds/42360
[01:25:40] <brettw> thakis, um, I removed you and then you added yourself back :)
[01:25:43] <jamesr> i've had a lot of failures in interactive_ui_tests on try runs
[01:25:48] <rohitrao> brettw: http://codereview.chromium.org/3052027/show ?
[01:25:51] <rohitrao> grr
[01:25:57] <rohitrao> bryner: http://codereview.chromium.org/3052027/show ?
[01:25:59] <jamesr> i just assumed they were flaky
[01:26:24] <brettw> rohitrao, huh?
[01:26:28] <nsylvain> bryner, jamesr: if someone has been connecting interactively to the try server, it could have caused that.  I don't know who would be doing that though, since I did not do it, and maruel is OOO.
[01:26:32] <thakis> timing fail :-)
[01:26:37] <trungl-bot> Tree opened by thakis at chromium dot org: tree is open (ChromiumOS -> should cycle green)
[01:26:46] <rohitrao> brettw: that was meant for bryner, not you.  autocomplete fail :)
[01:28:02] <bryner> rohitrao, nsylvain: ok, thanks.  i'll give it another shot and see if it goes any better.
[01:28:13] * brettw has to go to a class thing, xji is now solely in charge :)
[01:30:44] *** ananta has joined #chromium
[01:30:44] *** ChanServ sets mode: +v ananta
[01:31:50] *** rdsmith has left #chromium
[01:31:53] *** Erkan_Yilmaz_ has joined #chromium
[01:34:23] *** jlouie has quit IRC
[01:34:56] <rohitrao> kerz: ping
[01:35:05] *** Erkan_Yilmaz has quit IRC
[01:35:27] *** Erkan_Yilmaz__ has joined #chromium
[01:35:46] *** rdsmith has joined #chromium
[01:35:46] *** ChanServ sets mode: +v rdsmith
[01:35:54] *** rdsmith has quit IRC
[01:36:22] *** anicolao has quit IRC
[01:36:28] *** BW^- has joined #chromium
[01:36:41] <rohitrao> kerz: nevermind, saw the expectations fix
[01:37:01] <kerz> yeah, working on it
[01:37:06] <kerz> one more thing not quite right
[01:37:31] <BW^-> what's v8's approx binary footprint? (VM + js parser + standard library for String, Arrray, that kind of thing)
[01:38:16] <rohitrao> woohoo!!! half green!!
[01:38:32] *** Erkan_Yilmaz_ has quit IRC
[01:38:43] <evmar> BW^-: http://packages.ubuntu.com/lucid/libv8-2.0.3 , see file sizes
[01:39:56] *** Erkan_Yilmaz_ has joined #chromium
[01:40:46] <dumi> nsylvain: ping
[01:41:00] *** rohitrao has quit IRC
[01:42:10] <nsylvain> dumi: pong
[01:42:34] *** rsesek has quit IRC
[01:42:57] <dumi> nsylvain: is there a way to force a clean on a webkit canary bot?
[01:43:08] *** Erkan_Yilmaz__ has quit IRC
[01:43:14] <nsylvain> yes, normal force build + clobber
[01:44:00] <dumi> how do i do that? :)
[01:44:04] *** Erkan_Yilmaz__ has joined #chromium
[01:44:38] <xji> there are new (not marked as flaky) interactive_ui_test failures in Mac Test (dbg) and Linux Test (dbg). brettw (r54203), pkasing (r54204), phajdan-jr(r54204), and thakis (r54206) are in blame list. phajdan-jr and thakis's CL seems not related. Could you all please double check the failure is not introduced by you, it is just flaky?
[01:44:46] *** ebraminio has quit IRC
[01:46:12] *** Erkan_Yilmaz_ has quit IRC
[01:46:36] *** seventh has quit IRC
[01:46:41] <phajdan-jr> xji: oh-oh, it's my change
[01:47:04] <phajdan-jr> xji: could you capture the stack traces, file a bug for me, and disable the crashers while I fix it?
[01:48:59] *** Erkan_Yilmaz_ has joined #chromium
[01:49:23] *** ebraminio has joined #chromium
[01:51:11] <xji> phajdan-jr: how to capture the stack traces? I will disable the 3 tests temporarily.
[01:51:42] *** anicolao has joined #chromium
[01:52:20] *** Erkan_Yilmaz__ has quit IRC
[01:52:31] <phajdan-jr> xji: please just copy-paste what is in the logs (stdio) so it doesn't get lost
[01:53:25] *** Erkan_Yilmaz__ has joined #chromium
[01:55:33] *** arv__ has quit IRC
[01:56:33] *** Erkan_Yilmaz_ has quit IRC
[01:57:05] *** seventh has joined #chromium
[01:58:05] *** focus has joined #chromium
[01:58:49] *** fqian has joined #chromium
[01:59:03] <focus> Hi, I'd really appreciate it if someone could point me to where I can get the latest stable release of chromium
[02:00:11] <markmentovai> xji: did you get it figured out?
[02:00:51] <evmar> focus: try googling for [google chrome download]
[02:01:06] <thakis> focus: there are no stable releases of chromium, only of google chrome
[02:01:12] <thakis> chromium is always unstable
[02:01:13] <thakis> :-P
[02:01:39] <phajdan-jr> focus: are you trying to package it for a Linux distro?
[02:01:48] <focus> then where can I get an unstable one? I'm just looking for some of the chromium builds that havent made it into an official google chrome release
[02:01:52] <focus> nope
[02:02:04] <evmar> focus: you can build it yourself then i think
[02:02:45] <thakis> xji: i'm afk for a while. i checked that the test that went red the last time i checked in my cl now passed on the waterfall
[02:03:07] <thakis> focus: google chrome's dev channel is updated every week; chromium isn't a lot more up-to-date
[02:03:11] *** bent-mozilla has quit IRC
[02:03:15] <xji> markmentovai: you mean how to run "svn remove" to clear lock? then, I did not.
[02:03:27] <markmentovai> correct. i can hit it quickly.
[02:03:30] <xji> thakis: its phajdan-jr.
[02:03:54] <xji> markmentovai: nsylvia did it already.
[02:03:58] <phajdan-jr> xji: I can file the bug and disable the test if you prefer. What is the status on your side?
[02:04:10] *** dhaffner has quit IRC
[02:04:13] <thakis> xji: i mean "i'm afk, just fyi. if my current cl should break the tree, don't waste time looking for me, revert. i don't think it will break anything"
[02:04:22] <markmentovai> xji: very well. nsylvain: that's at least the second time we would up with a lock in that directory today, do we know why it's happening?
[02:04:40] <xji> phajdan-jr: I am about to check with you. did you know why you breaks the tests.
[02:04:41] <nsylvain> are you talking about reliability?
[02:05:15] <markmentovai> yeah
[02:05:15] *** js2 has quit IRC
[02:05:23] <xji> phajdan-jr: how long you think you can fix them?
[02:05:24] *** js2 has joined #chromium
[02:05:27] <erikchen>  focus: try http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows if you want to build it yourself
[02:05:38] <phajdan-jr> xji: they are crashy now. the change was quite invasive. by tomorrow end of day.
[02:05:48] *** markmentovai has quit IRC
[02:05:54] <phajdan-jr> xji: I'd like to prevent a revert, because the patch is quite big.
[02:06:44] <xji> phajdan-jr: I have concerns to disable or mark the tests as flaky or fails. Because oftenly people forgot to make it as unflaky or un-failed after they fix. and the tests turned to be ignored.
[02:07:08] <phajdan-jr> xji: that's what the bug is for. And the right action is to disable, because they are crashy.
[02:07:14] <nsylvain> markme: it's been failing non stop for a few days now. I fixed it maybe an hour ago and now it's ok.
[02:07:18] <nsylvain> dah
[02:07:27] <focus> there are no builds just available for d/l like there are of minefield?
[02:07:48] <evmar> focus: the chrome dev channel comes out once a week, that's your best bet
[02:07:48] <xji> phajdan-jr: that is what I am trying to discuss with you. I do not know how invasive the test is? is the focus fail because the change might freeze browser? If the failure is serious (I do not mean if the tests are important or not), we probably should revert the change.
[02:08:25] <phajdan-jr> xji: the test crashes. it seems to be linux-views specific.
[02:08:31] *** eseidel has joined #chromium
[02:08:34] <focus> thanks all, i'll check that out
[02:09:55] *** ebraminio has quit IRC
[02:10:15] *** japhet1 is now known as japhet
[02:10:41] *** focus has quit IRC
[02:10:59] <xji> phajdan-jr: linux (dbg) and mac (dbg)
[02:11:49] *** js2_ has joined #chromium
[02:11:50] *** js2 has quit IRC
[02:12:28] <phajdan-jr> xji: I'm really for disabling.
[02:14:41] *** eseidel has quit IRC
[02:14:44] <xji> phajdan-jr: do you know why the change crashes the tests? You also said that the change is invasive. I want to understand it better. If it is invasive and crashes tests, I think we should revert.
[02:15:39] *** RT|Chatzilla has joined #chromium
[02:15:40] *** eseidel has joined #chromium
[02:16:40] *** tfarina has joined #chromium
[02:16:45] <phajdan-jr> xji: I am not sure why it crashes. I need to take a closer look. It's going to be easier if the patch isn't going to be reverted.
[02:16:53] <phajdan-jr> xji: I estimate the time to fix to about one day.
[02:17:42] <xji> phajdan-jr: I think usually the rule is if it could be fixed soon, we leave it as it. otherwise, (and since it is cause crash), it is better to revert.
[02:18:04] <phajdan-jr> xji: we disable in exceptional situations, and I believe this is one
[02:19:10] <phajdan-jr> IMHO the sheriff's responsibility is to keep the tree green, not necessarily to assess the quality of changes.
[02:19:42] <xji> phajdan-jr: since we do not have clear idea why the crash, and we do not know how severe the crash (the change) is, I tihnk it should be reverted for better investigation.
[02:20:40] <phajdan-jr> xji: please, let me handle filing the bug and disabling of the tests, and I'm going to investigate it until tomorrow's EOD
[02:20:46] <phajdan-jr> xji: if that fails, I'll revert
[02:21:11] <xji> phajdan-jr: this is only my 2nd time to be sheriff. Since sheriff has no ability to assess the quality of changes, revert or fixing quickly is the easy way to keep the tree clean.
[02:21:33] <xji> phajdan-jr: I find the stack traces of the crashes and filing bugs, do you want me to do that? or you can do that?
[02:21:33] <jamesr> phajdan-jr: why is it easier to fix if it's not reverted?
[02:22:42] <phajdan-jr> jamesr: it touches so many things in the download code... I think it is less risky to let it be in the tree provided I can fix quickly instead of risking a bad merge
[02:23:07] <phajdan-jr> xji: up to you
[02:24:45] *** awolfson has joined #chromium
[02:28:44] *** Aria has quit IRC
[02:28:45] *** Aredridel has joined #chromium
[02:33:59] *** erikkay has quit IRC
[02:34:23] <xji> phajdan-jr: I make exception for you. Please file bug and disable the 3 tests. And I would like to change the fix by date to by noon tomorrow, because if you could not fix it and it has to be reverted, we have time to turn on the tests and run cycle green by end of week. How about that? BTW, have you run trybot with you change last time? just wondering whether trybot should catch them.
[02:36:08] <phajdan-jr> xji: I have run trybots, but the real failures got obscured by an explosion of flakiness :(
[02:37:09] * phajdan-jr files bug now
[02:39:12] <phajdan-jr> xji: filed http://crbug.com/50696. Could you disable the affected tests? That would save me some time, I have already started debugging in the working copy.
[02:39:35] *** trungl_ has joined #chromium
[02:39:35] *** ChanServ sets mode: +v trungl_
[02:39:39] *** hebz0rl has joined #chromium
[02:39:47] <xji> phajdan-jr: and I am recording our conversation in sheriff's notes so that glider and brettw knows about that.
[02:39:56] <xji> phajdan-jr: ok. I will do that.
[02:40:03] <phajdan-jr> xji: thanks a lot
[02:42:03] *** BW^- has quit IRC
[02:43:30] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac" from 54228: ananta at chromium dot org (:iyengar), avi at chromium dot org (:motownavi), ben at chromium dot org, evan at chromium dot org (:evmar), jhawkins at chromium dot org, thakis at chromium dot org, tony at chromium dot org (:tony^work), victorw at chromium dot org)
[02:44:02] <evmar> i can't get any buildbot status pages to load
[02:44:57] *** satish_ has joined #chromium
[02:45:48] <satish_> brettw: ping
[02:45:52] *** trungl_ has quit IRC
[02:46:19] <evmar> OSError: [Errno 2] No such file or directory: '/b/slave/chromium-rel-mac/build/src/third_party/yasm/../../xcodebuild/Release/yasm'
[02:46:41] <xji> satish_: brettw is off.
[02:46:56] <satish_> xji: hi, looks like my patch is causing linux x64 tests to fail
[02:47:16] <evmar> satish_: btw, you have windows-style newlines in the patch it seems
[02:47:26] <xji> satish_: test case fail or compilation fail.
[02:47:35] <satish_> xji: tests fail, compile is fine
[02:48:06] <satish_> evmar: I didn't notice, where di dyou see them?
[02:48:15] <xji> satish_: I am looking at the compilation failure. have not check the test fail yet. which test? are you working on that?
[02:48:20] *** trungl is now known as trungl_afk
[02:48:47] <satish_> xji: linux x64, failed ui_tests
[02:48:59] <evmar> i have no idea what this mac prob is
[02:49:39] <satish_> xji: perhaps best to revert my patch
[02:49:59] <xji> satish_: could you revert yourself?
[02:50:23] <xji> evmar: is it possible the buildbot has issue?
[02:51:07] <satish_> xji:yes I can, but sorry haven't done any yet. How to?
[02:51:51] <jhawkins> satish_: drover --revert revision
[02:51:58] <xji> satish_: we are in the same boat. Reverting changes
[02:51:58] <xji> Chromium
[02:51:58] <xji> The easy way: (from a temp dir) drover --revert 1234
[02:51:58] <xji> The hard way: (from a checkout) gclient sync ; svn merge -c -1234 . ; gcl chang
[02:52:17] <evmar> i reverted it
[02:52:17] <satish_> jhawkins: thanks.
[02:52:25] <satish_> xji: i'll do that.
[02:52:30] <evmar> satish_: i already reverted it
[02:52:36] <satish_> evmar:ok, thanks :)
[02:52:45] <evmar> i expect the bot is having problems though :(
[02:53:08] <evmar> oh, actually, a bunch of red linux bots
[02:53:25] <evmar> does not look like flake, the focus tests were solid before and now reliably fail
[02:53:54] *** mabbo_ has joined #chromium
[02:53:56] *** fsamuel__ has joined #chromium
[02:53:56] <phajdan-jr> xji: seems like I'm getting the tests to run fine locally. My bet now is a broken test, seriously.
[02:53:57] *** wjmaclean_ has joined #chromium
[02:53:58] *** eseidel has quit IRC
[02:54:03] *** bryeung_ has joined #chromium
[02:54:04] *** eseidel has joined #chromium
[02:54:04] *** ChanServ sets mode: +v eseidel
[02:54:04] <phajdan-jr> I mean after some fixes. ^
[02:54:06] *** kliegs_ has joined #chromium
[02:54:11] <xji> evmar: focus tests are caused by phajdan-jr's change. we agreeed to disable the tests till he fixes them.
[02:54:20] *** thakis_ has joined #chromium
[02:54:20] *** ChanServ sets mode: +v thakis_
[02:54:21] *** seventh has quit IRC
[02:54:30] <phajdan-jr> and that's going to happen _today_ - hopefully
[02:54:34] <thakis_> hi
[02:54:49] <thakis_> is the build failure complaining about pid_t/int
[02:54:49] <thakis_> ?
[02:55:01] <anicolao> how do I get really old results like http://build.chromium.org/buildbot/layout_test_results/webkit-dbg-linux-3/52625/layout-test-results.zip
[02:55:06] <evmar> the mac build failure is missing files or something
[02:55:20] <nsylvain> xji, phajdan-jr :are the tests disabled yet?
[02:55:25] *** fsamuel has quit IRC
[02:55:34] *** fantasticulous has quit IRC
[02:55:37] <thakis_> ok, cool
[02:55:37] *** trungl has joined #chromium
[02:55:37] *** ChanServ sets mode: +v trungl
[02:55:41] <thakis_> then i'm away again
[02:55:41] <phajdan-jr> nsylvain: it might be faster for me to actually land the fix
[02:55:47] <phajdan-jr> nsylvain: if they are not disabled yet
[02:55:53] <xji> nsylvain: I am doing it right now.
[02:55:57] <thakis_> if you need me send me mail
[02:56:06] <thakis_> (laptop battery very empty)
[02:56:07] *** thakis_ has quit IRC
[02:56:13] <phajdan-jr> xji: if I have like 15 minutes (conservative), I'll land the fix
[02:56:27] <nsylvain> phajdan-jr: the tree as been red for too long. revert of disable ASAP. not more guess work here
[02:56:43] <phajdan-jr> nsylvain: let's disable then; sorry for keeping the redness so long
[02:56:57] <nsylvain> thanks
[02:57:16] *** wjmaclean has quit IRC
[02:57:18] *** bryeung has quit IRC
[02:57:51] <satish_> evmar: you mentioned CRLFs, where did you notice?
[02:58:02] *** rjkroege has quit IRC
[02:58:03] <evmar> chrome/browser/speech/enable_speech_input_switch_browsertest.cc
[02:58:07] *** kliegs has quit IRC
[02:58:07] *** mabbo has quit IRC
[02:59:33] <xji> phajdan-jr: if I disable the tests, how could you know it is ok in trybot?
[03:00:01] <phajdan-jr> xji: these tests are broken, I'm *sure* it will be OK after I fix them.
[03:00:59] <xji> phajdan-jr: what you mean the tests are broken.
[03:01:20] <phajdan-jr> xji: they don't wait properly
[03:01:39] <xji> phajdan-jr: do you mean you are changing the tests?
[03:01:44] <phajdan-jr> xji: yes
[03:01:45] <xji> phajdan-jr: too?
[03:02:04] <phajdan-jr> xji: what do you mean?
[03:02:10] *** eseidel_ has joined #chromium
[03:02:32] *** satish_ has quit IRC
[03:02:35] <xji> phajdan-jr: but why it was ok before?
[03:02:55] *** rjkroege has joined #chromium
[03:03:30] <xji> phajdan-jr: I am REALLY *not* comfortable on you change both the TESTS. it has to be reviewed by someone, right? can you land quickly?
[03:03:45] *** stuartmorgan has quit IRC
[03:05:03] <xji> phajdan-jr: I have no idea on the tests and the changes. No judgement. It might be the right fix. But need someone to review. I would like to take back my word and revert it.
[03:05:15] <xji> phajdan-jr: I am sorry for this back and forth.
[03:05:37] *** hebz0rl has quit IRC
[03:05:47] <phajdan-jr> xji: the change to tests is right anyway, I'm sure about that
[03:05:56] <phajdan-jr> xji: now, my change could still introduce some problem
[03:05:57] *** eseidel has quit IRC
[03:05:57] *** eseidel_ is now known as eseidel
[03:06:02] *** jrforbes_ has joined #chromium
[03:06:03] <phajdan-jr> xji: and I'll investigate it right after
[03:06:09] <phajdan-jr> xji: uploading the uncrashing change now
[03:06:14] <phajdan-jr> it will get proper review
[03:06:22] <xji> phajdan-jr: who is the reviewer? I am reverting.
[03:06:44] <xji> phajdan-jr: it takes time to review.
[03:07:20] <phajdan-jr> fix in
[03:08:02] <phajdan-jr> now running svn blame to find correct reviwer...
[03:08:30] *** leeight has joined #chromium
[03:08:44] *** leeight has left #chromium
[03:08:47] <suzhe> phajdan-jr: what change did you upload? Is it about interactive_ui_tests?
[03:09:22] <phajdan-jr> suzhe: yes
[03:09:33] <suzhe> phajdan-jr: can you send me the link?
[03:09:43] <xji> phajdan-jr: I am reverting 54204 now. really sorry.
[03:09:44] <phajdan-jr> suzhe: to the original or the fix?
[03:09:51] <suzhe> phajdan-jr: your fix.
[03:09:56] <phajdan-jr> xji: I'm puzzled. The tests are going to cycle green.
[03:10:11] *** d0k has quit IRC
[03:10:21] <xji> phajdan-jr: you have to have someone to review, and you need to run the tests in trybot.
[03:10:27] <phajdan-jr> suzhe: http://codereview.chromium.org/3005038
[03:10:41] *** rniwa has quit IRC
[03:12:46] <nsylvain> Ok. I think the process has not been followed really well here.   xji: you, as the sheriff, have the right to revert any change. The rule is "revert now, ask question later". No one should ever blame a sheriff for making a judgement call... even more when the try job was having the problem too.  But...
[03:13:13] <nsylvain> If both sheriff and committers agree, and the problem is limited to a few tests, disabling the tests might be ok too, as long as it's temporary. (bugs should be filed, P0).
[03:13:33] <nsylvain> Leaving the tree in this state for a few hours is not really an option
[03:14:08] <phajdan-jr> nsylvain: I bet the tests are going to be green now after my latest change.
[03:14:21] <phajdan-jr> nsylvain: the CL has been TBR-ed, but now got all correct reviewers
[03:14:23] <evmar> do we know why mac compile failed? that is more concerning to me
[03:14:56] <phajdan-jr> nsylvain: sorry for the interactive_ui_tests breakage
[03:15:14] <nsylvain> phajdan-jr:  TBR is also a good way to fix a problem, when the problem is obvious and the fix is simple. I dont know if this is the case here.  I looked at the diff and I did not understand it.
[03:15:24] <nsylvain> someone who knows that code might though
[03:15:34] <nsylvain> and this is pretty much up to the committers and the sheriff to decide
[03:15:53] <nsylvain> I don't think you should have TBR'ed it to someone who does not know that part of the code though!
[03:16:32] <xji> phajdan-jr: in reverting process, but got conflicted. in an empty directory......
[03:16:38] <phajdan-jr> nsylvain: I assigned reviewers correctly. TBR in commit message was too quick to do the full lookup. :-/
[03:16:39] <nsylvain> in any cases, there is no point in arguing about this too much...
[03:16:39] <xji> nsylvain: lesson learned.
[03:17:18] <nsylvain> xji: now that the patch has been committed.. might as well wait.. :|
[03:17:28] <nsylvain> he seems confident ;)
[03:17:30] *** hebz0rl has joined #chromium
[03:17:51] <nsylvain> we'll know soon
[03:18:18] *** Aferlak12 has quit IRC
[03:18:28] * trungl is accepting bets.
[03:19:46] <evmar> wow, even more red now
[03:19:55] <evmar> maybe satish revert will help
[03:20:37] <suzhe> phajdan-jr: I still believe the tests should not crash at all even without the fix.
[03:20:45] <xji> anyone knows the mac compilation error?
[03:21:03] <phajdan-jr> suzhe: yes, that's also weird to me. I suspect my change did introduce a kind of problem.
[03:21:07] <nsylvain> xji : i looked and i'm not sure yet.
[03:21:15] <evmar> i'm hoping hte next build works
[03:21:19] <phajdan-jr> suzhe: anyway, it seems more correct to me to run all pending in those places.
[03:21:25] <nsylvain> yeah, me too
[03:21:27] *** rafaelw has left #chromium
[03:21:56] <trungl-bot> Tree closed by xji at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac" from 54228: ananta at chromium dot org (:iyengar), avi at chromium dot org (:motownavi), ben at chromium dot org, evan at chromium dot org (:evmar), jhawkins at chromium dot org, thakis at chromium dot org, tony at chromium dot org (:tony^work), victorw at chromium dot org;  ui_tests: cycle green;  interactive_ui_tests: cycle green)
[03:21:58] <evmar> yasm on mac built this time, so it looks good
[03:22:12] <suzhe> phajdan-jr: but InProcessBrowserTest::QuitBrowsers() quits all browsers in a running message loop as well.
[03:22:37] <phajdan-jr> suzhe: could you explain more?
[03:23:44] <suzhe> phajdan-jr: For example in FocusOnReload test, you added a ui_test_utils::RunAllPendingInMessageLoop(); at the end, which actually just post a QuitTask and run the message loop.
[03:23:58] <trungl-bot> Tree closed by xji at chromium dot org: Tree is closed (ui_tests: cycle green;  interactive_ui_tests: cycle green)
[03:25:00] <phajdan-jr> suzhe: I added it after ShowDownloadsTab... as a way of waiting for that operation to finish
[03:25:04] <suzhe> phajdan-jr: But when the test finish, InProcessBrowserTest::QuitBrowsers() will be called to close all browsers, which also does it by posting a task and running the message loop.
[03:25:04] *** tonyg-cr has quit IRC
[03:25:24] *** rohitrao has joined #chromium
[03:25:25] *** ChanServ sets mode: +v rohitrao
[03:25:54] <suzhe> phajdan-jr: I know. I mean the operation you want to wait should be finished in the message loop run inside InProcessBrowserTest::QuitBrowsers().
[03:25:54] *** eroman has quit IRC
[03:26:58] <phajdan-jr> suzhe: I'm not sure what to say about that. Your analysis sounds right. Please make sure to add those comments to the code review.
[03:27:05] *** cying has quit IRC
[03:27:15] *** bweinstein has quit IRC
[03:28:33] *** Martijnc has quit IRC
[03:33:48] *** Martijnc has joined #chromium
[03:34:28] <tfarina> the tree is on fire :(
[03:34:48] <evmar> tfarina: there was a bad change and everything went red, but it's looking greener now
[03:35:08] * trungl loves fire
[03:35:42] * phajdan-jr hates fire
[03:35:44] <tfarina> evmar: looks pretty bad though.
[03:35:55] <tfarina> phajdan-jr: me either :)
[03:36:38] * evmar has a queue of changes nearly ready to go though
[03:36:39] <trungl> though admittedly electric lighting was a great advance
[03:37:01] <phajdan-jr> oh, I just meant that I hate when the tree is on fire
[03:37:44] <phajdan-jr> well, now interactive_ui_tests are cycling... hopefully everything will be fine now
[03:38:16] <tfarina> phajdan-jr: I'm seeing the same failure on it
[03:38:16] <trungl> but, with a big monitor, you get a pleasant warm glow when the tree is on fire
[03:38:47] * trungl will get kicked some day for adding nothing but noise
[03:38:50] <phajdan-jr> tfarina: ah, it still wasn't my CL... have to wait some more
[03:39:14] <phajdan-jr> trungl: I see more grey than red now
[03:39:22] <phajdan-jr> maybe it's dust
[03:39:42] <evmar> man do our bots take a long time to cycle
[03:39:49] <tfarina> phajdan-jr: yup, have to wait more 20 minutes.
[03:41:25] <trungl> speaking of grey, that's the way SF is looking right now
[03:41:41] <evmar> i see blue skies from here (by the bay bridge)
[03:42:57] <trungl> I'm just rolling into SF right now on I-280
[03:43:25] <trungl> the clouds are maybe a couple hundred feet off the ground
[03:44:09] <evmar> so by rolling into sf, do you mean you want to look at another easy patch?
[03:44:11] <evmar> http://codereview.chromium.org/3069014
[03:44:41] <evmar> bonus points if you spot the one file where i fixed a bug
[03:45:03] <trungl> evmar: sure, will look
[03:45:56] <trungl> if only rietveld were faster
[03:46:27] <evmar> trungl: yeah, i got two more after this one ready too
[03:46:46] *** paul_irish has quit IRC
[03:47:29] <trungl> evmar: feel free to queue them up
[03:47:41] <trungl> evmar: I can return the favour later :P
[03:47:53] <evmar> only for trivial cleanup cls :P
[03:48:26] <trungl> there'll be a lot of that
[03:49:39] *** paul_irish has joined #chromium
[03:49:39] *** ChanServ sets mode: +v paul_irish
[03:50:23] <victorw> brettw: xji: hi
[03:51:10] <xji> victorw: about the tree?
[03:51:48] <phajdan-jr> interactive_ui_tests -> green :)
[03:51:53] <xji> victorw: ui_tests seems fine now. I am waiting for interactive_ui_tests to cycle green in last least on bot.
[03:51:58] <victorw> xji: just let you know I will be away from desk for an hour or so. may webkit roll currently running should be safe.
[03:52:29] <victorw> xji: it is unlikely cause issue, but in case it does, feel free to revert it
[03:53:54] <xji> victorw: there is webkit_tests failure I have not looked at yet, are you talking about that?
[03:54:10] <trungl> biab
[03:54:11] *** trungl has quit IRC
[03:55:14] <evmar> noooo
[03:56:00] <xji> victorw: you mean the webkit roll? I have not seen the change commited yet.
[03:56:20] <victorw> xji: it was committed a while back
[03:57:46] <xji> victorw: I see. 54224. probably ok.
[03:58:11] <tfarina> phajdan-jr: ui_test are red though.
[03:58:17] <victorw> xji: yes. I think it is ok. just FYI
[03:58:28] <victorw> xjiL will be back in an hour or so
[03:59:27] *** js2_ has quit IRC
[04:01:37] <phajdan-jr> tfarina: could you post the logs link?
[04:02:41] <tfarina> phajdan-jr: http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Mac
[04:03:46] <phajdan-jr> tfarina: all worker-related
[04:03:53] <phajdan-jr> tfarina: not sure why they fail
[04:04:17] <tfarina> phajdan-jr: no glue here too.
[04:04:22] <xji> tfarina, phajdan-jr: it was reverted. should cycle green.
[04:04:58] <phajdan-jr> xji: I think that the failures from my changes are all green now. Could you take another look to verify?
[04:05:40] <tfarina> xji: could you update the tree status to reflect these changes?
[04:06:00] <evmar> i think we may be safe to open
[04:06:26] *** homata_ has quit IRC
[04:07:04] <xji> tfarina: it is "ui_test: cycle green; interactive_ui_tests: cycle green)
[04:07:41] *** trungl has joined #chromium
[04:07:42] *** ChanServ sets mode: +v trungl
[04:07:45] <xji> evmar: ya. I will open the tree.
[04:08:24] <tfarina> xji: it seems that none of chromium buildbot extension and trungl-bot is working.
[04:09:04] <tfarina> xji: now it changed, maybe there is a delay in the update.
[04:09:21] * trungl saw a blue patch of sky and was pleased.
[04:09:28] <trungl-bot> Tree opened by xji at chromium dot org: Tree is open (ui_tests: cycle green;  interactive_ui_tests: cycle green)
[04:09:36] <xji> tfarina: there is delay.
[04:10:02] *** jamesr has quit IRC
[04:10:20] *** rniwa has joined #chromium
[04:10:40] <tfarina> evmar: hope it will stay opened until I can land some of my patches :)
[04:11:17] <evmar> i only got a review for one of mine :~(
[04:11:30] *** xji_ has left #chromium
[04:12:07] *** xji has left #chromium
[04:12:49] <phajdan-jr> I'll be catching a bus in few minutes (can leave later if there are still problems after my changes).
[04:13:16] * trungl is working on it!
[04:13:37] <evmar> trungl: ah, don't worry about it
[04:15:34] <tfarina> phajdan-jr: I think everything is right again :)
[04:17:25] <tfarina> evmar: removing a entry from .grd would be a problem right now? Should I land it later?
[04:17:33] <evmar> tfarina: i think it is ok now
[04:17:37] <evmar> i think jochen fixed it
[04:17:45] <tfarina> ok, cool!
[04:17:50] *** phajdan-jr has quit IRC
[04:18:04] <tfarina> committing now so.
[04:22:09] <trungl> man, there are a lot of files in this cl
[04:23:43] *** kjg_ has joined #chromium
[04:23:47] <evmar> i am sorry :(
[04:23:54] <evmar> the changes are all very similar
[04:23:59] <tfarina> trungl: if evmar is ok, I can take a look at half :-)
[04:23:59] <evmar> the later two are both very simple
[04:24:24] <trungl> it's all good
[04:24:35] <trungl> I just keep expecting each file to be the last
[04:24:44] *** Adys has quit IRC
[04:24:59] <evmar> after these four patches there are only like 10 callsites of the function left
[04:25:05] <evmar> so i can probably fix those in another two or three changes
[04:25:42] *** Adys has joined #chromium
[04:26:19] *** kjg has quit IRC
[04:26:53] <trungl> sweet
[04:29:22] <rohitrao> what function are you getting rid of?
[04:29:36] <evmar> rohitrao: CommandLine::AppendSwitchWithValue(..., wstring)
[04:29:46] <rohitrao> nice
[04:30:28] * trungl is foolishly converting DictionaryValue to use std::string for keys.
[04:30:35] <evmar> yikes!
[04:30:44] <evmar> i think you actually can't, now that i think of it
[04:30:52] <evmar> i think session restore or something puts unicode into the keys
[04:31:17] <evmar> trungl: http://codereview.chromium.org/3069014/diff/2001/3010 <- the first diff there, converted user data dir to ASCII, which means it would eat user data dirs that weren't ascii
[04:31:22] <evmar> trungl: that was the bug
[04:32:19] <trungl> ah, right
[04:34:13] <trungl> "IntToWString(1)"!
[04:34:18] <evmar> yeah, for serious
[04:34:40] *** MikeSmithW3C^ has quit IRC
[04:35:06] *** MikeSmithW3C has joined #chromium
[04:35:10] <trungl> evmar: LGTM on the other two, btw
[04:35:13] <trungl> biab
[04:36:33] <evmar> thanks
[04:36:37] <evmar> i will land later tonight probably
[04:37:37] *** eseidel has quit IRC
[04:38:03] *** dpranke has quit IRC
[04:41:31] *** hbono has joined #chromium
[04:42:51] *** hbono has quit IRC
[04:43:54] *** chrisccoulson has quit IRC
[04:45:24] <trungl> we need a commit queue for stuff like this
[04:49:34] *** ejat has joined #chromium
[04:49:34] *** ejat has joined #chromium
[04:50:37] *** jamesr has joined #chromium
[04:50:37] *** ChanServ sets mode: +v jamesr
[04:52:29] *** eseidel has joined #chromium
[04:54:22] *** estade has quit IRC
[04:56:26] *** MikeSmithW3C^ has joined #chromium
[04:58:33] *** MikeSmithW3C has quit IRC
[04:59:39] *** eseidel has quit IRC
[05:00:34] *** Gabe_G23 has joined #chromium
[05:06:21] *** paul_irish has quit IRC
[05:08:42] *** paul_irish has joined #chromium
[05:10:58] *** jamesr has quit IRC
[05:14:00] *** jrforbes_ has quit IRC
[05:19:20] *** Aredridel is now known as Aria
[05:32:55] *** plantain_ has joined #chromium
[05:33:40] *** mirandac_ has joined #chromium
[05:34:37] *** leiz has quit IRC
[05:35:42] *** jhawkins has quit IRC
[05:37:10] *** jhawkins has joined #chromium
[05:37:10] *** ChanServ sets mode: +v jhawkins
[05:37:40] *** leiz has joined #chromium
[05:37:40] *** ChanServ sets mode: +v leiz
[05:43:13] *** eggy has quit IRC
[05:43:34] *** eggy has joined #chromium
[05:43:41] *** eggy has quit IRC
[05:43:41] *** eggy has joined #chromium
[05:44:28] <trungl-bot> Tree opened by tfarina at chromium dot org: Tree is open
[05:46:55] *** paul_irish has quit IRC
[05:49:01] *** eggy has quit IRC
[05:55:16] *** mrossetti_ has joined #chromium
[05:56:51] *** eggy has joined #chromium
[05:57:00] *** Aria has quit IRC
[05:58:15] *** mrossetti has quit IRC
[05:59:52] *** paul_irish has joined #chromium
[06:00:51] *** eggy has quit IRC
[06:01:20] *** eggy has joined #chromium
[06:04:45] *** eggy has quit IRC
[06:04:45] *** eggy has joined #chromium
[06:08:45] *** eggy has quit IRC
[06:09:19] *** kjg_ has quit IRC
[06:09:53] *** eggy has joined #chromium
[06:17:13] *** Emperorlou has joined #chromium
[06:20:43] *** plantain_ has quit IRC
[06:20:56] *** tommi has quit IRC
[06:21:36] *** tommi has joined #chromium
[06:22:29] *** cying has joined #chromium
[06:24:37] *** rohitrao has quit IRC
[06:25:43] *** eroman has joined #chromium
[06:25:43] *** ChanServ sets mode: +v eroman
[06:27:31] *** cying has quit IRC
[06:28:01] *** plantain_ has joined #chromium
[06:33:16] *** Emperorlou has quit IRC
[06:37:41] *** Emperorlou has joined #chromium
[06:39:43] *** Engin has joined #chromium
[06:48:13] *** paul_irish_ has joined #chromium
[06:49:13] *** ebraminio has joined #chromium
[06:50:47] *** tonikitoo has quit IRC
[06:51:13] *** jscinoz has joined #chromium
[06:51:17] <jscinoz> hi..
[06:51:33] <terinjokes> hello!
[06:51:33] *** hebz0rl has quit IRC
[06:51:44] <jscinoz> I was wondering if chromium takes advantage of the availability of kernel samepage merging on a linux host
[06:52:54] *** eggy has quit IRC
[06:54:09] *** eggy has joined #chromium
[06:57:14] *** homata_ has joined #chromium
[06:57:39] *** craigsch has joined #chromium
[06:59:12] <trungl> n/a
[06:59:35] *** hebz0rl has joined #chromium
[07:00:37] <craigsch> fishd: suspend resume crash might be http://code.google.com/p/chromium/issues/detail?id=50690
[07:02:13] *** eggy has quit IRC
[07:04:27] *** homata_ has quit IRC
[07:06:47] *** eggy has joined #chromium
[07:07:59] *** craigsch has quit IRC
[07:09:08] *** fsamuel_ has quit IRC
[07:10:13] *** victorw has left #chromium
[07:10:48] *** eggy has quit IRC
[07:11:03] *** tonikitoo has joined #chromium
[07:14:44] *** estes has quit IRC
[07:19:00] *** fqian has quit IRC
[07:20:49] *** eggy has joined #chromium
[07:30:00] *** ejat has quit IRC
[07:31:34] *** mirandac_ has quit IRC
[07:43:01] *** paul_irish has quit IRC
[07:43:06] *** paul_irish_ has quit IRC
[07:43:54] *** plantain_ has quit IRC
[07:45:57] *** estes has joined #chromium
[07:46:08] *** eroman has quit IRC
[07:47:27] *** eroman has joined #chromium
[07:47:27] *** ChanServ sets mode: +v eroman
[07:51:38] *** cying has joined #chromium
[07:53:50] *** eroman has quit IRC
[07:58:02] <evmar> jscinoz: all apps benefit from page merging
[07:58:34] *** roc has quit IRC
[07:59:22] <trungl> but not ksm, which is a different story
[07:59:39] <trungl> mostly applicable to VMs
[08:00:00] <trungl> or other situations in which one doesn't have normal shared pages
[08:00:56] * evmar commits everything he's got
[08:01:00] <evmar> tree breakage in 3... 2..
[08:02:51] <trungl> wheeeeeeee
[08:03:02] <terinjokes> wheee!
[08:03:20] <terinjokes> compiling chromium again
[08:03:35] <terinjokes> mabe it will be done by the morning
[08:09:19] *** Engin has quit IRC
[08:10:04] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 54287: ananta at chromium dot org (:iyengar), evan at chromium dot org (:evmar), viettrungluu at chromium dot org (:trungl))
[08:10:24] *** Strat has quit IRC
[08:10:55] <trungl> evmar: ^^^
[08:11:01] <trungl> it's you
[08:12:07] <evmar> sadness
[08:12:19] <trungl> evmar: you might be able to fix it quickly
[08:12:27] <evmar> yeah, sec
[08:12:34] *** eroman has joined #chromium
[08:12:34] *** ChanServ sets mode: +v eroman
[08:13:03] <evmar> just waiting for the buildbots to respond...
[08:14:01] <trungl> trungl-bot: settreestatus Tree is closed (compile failure -> evan)
[08:14:03] <trungl-bot> trungl: Set tree status to: "Tree is closed (compile failure -> evan) [set by :trungl]".
[08:14:06] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (compile failure -> evan) [set by :trungl]
[08:14:42] <evmar> i reverted the offending line
[08:16:17] <trungl> ok, let's wait for the compile
[08:16:24] <evmar> sorry D:
[08:16:31] <evmar> it's likely to succeed
[08:16:34] <evmar> but what do i know
[08:16:40] <evmar> why are you working at 11:20pm
[08:16:52] <trungl> trungl-bot: settreestatus Tree is closed (compile failure -> evan fixed, waiting for cycle)
[08:16:53] <trungl-bot> trungl: Set tree status to: "Tree is closed (compile failure -> evan fixed, waiting for cycle) [set by :trungl]".
[08:17:09] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (compile failure -> evan fixed, waiting for cycle) [set by :trungl]
[08:17:09] <trungl> evmar: I'm just watching my commits
[08:17:15] <trungl> and wasting time otherwise
[08:17:24] <trungl> (and before that, waiting for trybots)
[08:17:38] <evmar> heh, i forgot the "before" part
[08:17:42] <evmar> writing tests, huh
[08:18:38] <trungl> I had actually written them for other reasons
[08:18:51] <trungl> so I figured they may as well go in
[08:19:08] *** Precea is now known as Precea[BNC]
[08:19:21] <eroman> trungl: why are you working against us by adding yet more tests, that might turn the builder red!
[08:19:30] <trungl> :P
[08:19:36] <eroman> it was working fine before
[08:19:37] <trungl> I only write 100% reliable tests!
[08:19:49] <eroman> trungl: so do i. FAILS_
[08:19:54] <trungl> haha
[08:20:05] <trungl> until it hangs and causes redness anyway!
[08:20:28] <evmar> i think the focus damage pawel added earlier is still happening
[08:20:39] <evmar> BrowserFocusTest.FAILS_TabsRememberFocusFindInPage
[08:20:44] <evmar> er
[08:20:45] <evmar> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserFocusTest.TabInitialFocus&testType=interactive_ui_tests
[08:21:22] *** MikeSmithW3C has joined #chromium
[08:22:33] <trungl> hrm
[08:24:09] <trungl> incidentally, what's up with cros (and linux views) anyway?
[08:27:16] *** glider has joined #chromium
[08:27:16] *** ChanServ sets mode: +v glider
[08:27:41] <glider> good morning, trungl-bot!
[08:27:41] <trungl-bot> glider: Good morning!
[08:28:17] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): open, win compile cycling green
[08:28:23] <evmar> windows built, yay
[08:28:48] *** Zaba has quit IRC
[08:30:55] *** monreal has joined #chromium
[08:35:39] *** Zaba has joined #chromium
[08:36:26] *** markusheintz_ has joined #chromium
[08:38:32] *** pdelgallego has joined #chromium
[08:42:48] *** Zaba has quit IRC
[08:45:36] *** ejat has joined #chromium
[08:46:08] *** Engin has joined #chromium
[08:48:02] *** markusheintz_ has quit IRC
[08:50:20] *** Erkan_Yilmaz__ has quit IRC
[08:54:38] *** markusheintz_ has joined #chromium
[08:55:07] *** ebraminio has quit IRC
[08:56:17] *** Engin has quit IRC
[08:58:04] *** bryeung_ has quit IRC
[08:58:10] <jochen__> good morning
[08:58:25] *** bryeung has joined #chromium
[08:58:39] *** shepazu has quit IRC
[09:00:17] *** wjmaclean_ has quit IRC
[09:00:17] *** mabbo_ has quit IRC
[09:00:17] *** wjmaclean__ has joined #chromium
[09:00:22] *** FullFlannelJacke has quit IRC
[09:00:23] *** fsamuel__ has quit IRC
[09:00:28] *** kliegs_ has quit IRC
[09:01:27] *** rjkroege has quit IRC
[09:02:43] *** FullFlannelJacke has joined #chromium
[09:04:39] *** estes has quit IRC
[09:05:01] <trungl> 'morning
[09:05:17] *** hrna has joined #chromium
[09:06:10] *** rjkroege has joined #chromium
[09:06:26] *** pathorn has joined #chromium
[09:14:06] *** kliegs_ has joined #chromium
[09:14:07] *** ebraminio has joined #chromium
[09:14:18] *** mabbo_ has joined #chromium
[09:14:40] *** fsamuel__ has joined #chromium
[09:18:02] *** RT|Chatzilla has quit IRC
[09:18:44] *** shepazu has joined #chromium
[09:19:32] *** RT|Chatzilla has joined #chromium
[09:19:42] *** Engin has joined #chromium
[09:28:11] *** hrna has quit IRC
[09:28:15] *** Zaba has joined #chromium
[09:28:48] <mnissler> good morning, chromium!
[09:28:48] <trungl-bot> mnissler: Good morning!
[09:30:03] *** bauerb has joined #chromium
[09:30:04] *** ChanServ sets mode: +v bauerb
[09:32:39] *** hrna has joined #chromium
[09:35:45] *** Zaba has quit IRC
[09:36:59] <trungl-bot> Tree opened by glider at chromium dot org: open, win compile cycling green (memory->glider)
[09:38:40] *** pfeldman has joined #chromium
[09:41:28] *** homata_ has joined #chromium
[09:43:50] *** homata_ has quit IRC
[09:44:01] *** pomaxa has quit IRC
[09:47:17] *** johnny_g has joined #chromium
[09:52:49] *** __ed has joined #chromium
[09:53:56] *** trungl has quit IRC
[09:55:40] *** ebraminio has quit IRC
[09:56:40] *** tittiatcoke has joined #chromium
[10:10:00] *** johnny_g has quit IRC
[10:12:20] *** jochen__ has quit IRC
[10:12:46] *** pfeldman_ has joined #chromium
[10:13:47] *** pathorn has quit IRC
[10:15:22] *** pfeldman has quit IRC
[10:15:23] *** pfeldman_ is now known as pfeldman
[10:17:25] *** jochen__ has joined #chromium
[10:17:25] *** ChanServ sets mode: +v jochen__
[10:20:29] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Mac10.6" from 54292: ananta at chromium dot org (:iyengar))
[10:25:09] <glider> ananta: you there?
[10:25:22] *** rniwa has quit IRC
[10:25:28] *** EnginA has joined #chromium
[10:25:47] <glider> ananta: I've forced the build on Mac 10.6 -- let's see if that's not a flakiness
[10:26:01] *** Zaba has joined #chromium
[10:27:55] *** Engin has quit IRC
[10:29:17] *** ebraminio has joined #chromium
[10:34:17] *** roc has joined #chromium
[10:34:57] *** bandu has joined #chromium
[10:40:32] *** ebraminio has quit IRC
[10:42:58] *** lucapost has joined #chromium
[10:43:51] <lucapost> hi all, I found http://dev.chromium.org/developers/design-documents/network-settings, is there a way to setting default option permanently?
[10:44:35] *** ebraminio has joined #chromium
[10:48:50] *** cying has quit IRC
[10:50:22] *** maikmerten has joined #chromium
[10:50:37] *** monreal_ has joined #chromium
[10:52:32] *** EnginA has quit IRC
[10:52:35] *** Engin has joined #chromium
[10:54:22] *** monreal has quit IRC
[10:55:01] *** MikeSmithW3C^ has joined #chromium
[10:55:03] *** bandu is now known as coyo
[10:55:52] *** EnginA has joined #chromium
[10:55:53] <trungl-bot> Tree opened by jorlow at chromium dot org: open, win compile cycling green (memory->glider)
[10:56:08] *** ebraminio has quit IRC
[10:58:28] *** MikeSmithW3C has quit IRC
[10:59:18] *** Engin has quit IRC
[11:01:12] *** jeremyselier has joined #chromium
[11:05:13] *** jeremyselier has quit IRC
[11:06:31] *** coyo has quit IRC
[11:10:45] *** jeremyselier has joined #chromium
[11:12:39] *** path[l] has quit IRC
[11:15:17] *** BCalvignac has quit IRC
[11:16:41] *** BCalvignac has joined #chromium
[11:17:15] *** plantain_ has joined #chromium
[11:19:10] *** loislo has joined #chromium
[11:21:07] *** zloidemon has joined #chromium
[11:24:10] *** eroman has quit IRC
[11:24:27] *** chrisccoulson has joined #chromium
[11:25:27] *** loislo has quit IRC
[11:26:11] *** loislo has joined #chromium
[11:32:09] *** EnginA has quit IRC
[11:34:02] *** Engin has joined #chromium
[11:34:17] *** jochen__ has quit IRC
[11:34:50] *** homata_ has joined #chromium
[11:36:13] *** jochen__ has joined #chromium
[11:36:13] *** ChanServ sets mode: +v jochen__
[11:36:35] *** phrearch has joined #chromium
[11:36:36] <phrearch> hi
[11:36:46] <phrearch> is it possible to use multiple websocket connections for a client?
[11:36:57] *** Engin has quit IRC
[11:37:00] *** EnginA has joined #chromium
[11:37:02] <jorlow> phrearch: it is in theory
[11:37:11] <jorlow> er...yes
[11:37:35] <phrearch> jorlow: ok cool thanks :)
[11:45:41] <jorlow> er....i'm pretty sure
[11:45:48] <jorlow> now that i think about it I'm less sure
[11:45:55] <jorlow> shouldn't be hard to try it out tho, i'd think
[11:49:47] *** homata_ has quit IRC
[11:50:18] <phrearch> yea, worth a test
[11:50:43] <phrearch> it would be nice to have two handlers since i want to keep connections between client-site and client-virtual world
[11:50:59] <phrearch> and they are not on the same server necessarily
[11:51:44] *** lucapost has left #chromium
[11:54:01] *** yutak_home has joined #chromium
[11:54:02] *** ChanServ sets mode: +v yutak_home
[11:56:08] *** path[l] has joined #chromium
[11:59:01] *** BCalvignac has quit IRC
[11:59:43] *** path[l] has quit IRC
[11:59:47] *** path[l] has joined #chromium
[12:01:07] *** BCalvignac has joined #chromium
[12:02:26] *** jochen__ has quit IRC
[12:07:35] *** jochen__ has joined #chromium
[12:07:35] *** ChanServ sets mode: +v jochen__
[12:15:53] *** maikmerten has quit IRC
[12:18:30] *** anicolao has quit IRC
[12:18:58] *** dr_win has quit IRC
[12:19:01] *** plantain_ has quit IRC
[12:20:05] <jscinoz> WC
[12:20:07] *** dr_win has joined #chromium
[12:20:09] *** jscinoz has left #chromium
[12:26:21] *** maikmerten has joined #chromium
[12:27:50] *** EnginA has quit IRC
[12:38:05] <jorlow> please no one break the tree....doing a hairy webkit roll
[12:40:31] *** ejat has quit IRC
[12:44:20] *** Emperorlou_ has joined #chromium
[12:45:30] *** Emperorlou has quit IRC
[12:53:36] *** exxe has joined #chromium
[12:57:09] *** path[l] has quit IRC
[12:59:12] *** taf2 has joined #chromium
[13:00:12] *** Adys has quit IRC
[13:01:09] *** Adys has joined #chromium
[13:01:22] *** fsamuel_ has joined #chromium
[13:01:52] *** plantain_ has joined #chromium
[13:03:57] *** jeremyselier_ has joined #chromium
[13:04:12] *** jeremyselier_ has quit IRC
[13:04:42] *** jeremyselier_ has joined #chromium
[13:06:41] *** andrix has joined #chromium
[13:07:11] *** jeremyselier has quit IRC
[13:07:12] *** jeremyselier_ is now known as jeremyselier
[13:08:18] *** Exilant has joined #chromium
[13:09:27] *** Emperorlou_ has quit IRC
[13:09:40] *** jeremyselier is now known as jeremys
[13:10:49] *** jeremys is now known as jeremyseleir
[13:10:55] *** jeremyseleir is now known as jeremyselier
[13:12:21] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder" from 54304: andreip at chromium dot org)
[13:12:46] *** taf2 has quit IRC
[13:13:26] *** yutak_home has quit IRC
[13:13:47] *** andrix has quit IRC
[13:15:32] *** Emperorlou has joined #chromium
[13:15:34] *** Exilant has left #chromium
[13:16:47] *** jeremyselier has quit IRC
[13:16:48] *** markusheintz_ has quit IRC
[13:17:03] *** jeremyselier has joined #chromium
[13:17:03] *** eseidel has joined #chromium
[13:17:42] *** Engin has joined #chromium
[13:20:17] *** path[l] has joined #chromium
[13:20:26] <trungl-bot> Tree closed by andreip at chromium dot org: Tree closed (memory->glider, build break->andreip)
[13:21:20] *** Andrei_ has joined #chromium
[13:26:03] *** EnginA has joined #chromium
[13:26:37] <jochen__> any eta on the breakage? :/
[13:28:51] *** Engin has quit IRC
[13:31:45] <jorlow> jochen__: hopefully soon
[13:31:47] <jorlow> 2 sided commit
[13:31:55] <jochen__> ah, ok
[13:33:34] *** d0k has joined #chromium
[13:33:37] *** BCalvignac has quit IRC
[13:34:30] *** BCalvignac has joined #chromium
[13:34:52] *** path[l] has quit IRC
[13:36:03] *** mnissler has quit IRC
[13:36:16] *** bauerb has quit IRC
[13:36:29] *** path[l] has joined #chromium
[13:39:45] <Andrei_> jochen__: got a fix, waiting for my local build to verify
[13:39:48] <Andrei_> sorry for the breakage
[13:42:31] <jorlow> i'm building test shell right now too...just in case my build can beat yours
[13:42:52] <jorlow> actually...just commit
[13:43:01] <jorlow> worst case, we're not any worse off than we are now
[13:43:08] *** path[l] has quit IRC
[13:43:35] *** lorenzo has joined #chromium
[13:44:09] <jochen__> nevermind :)
[13:44:28] *** path[l] has joined #chromium
[13:44:49] <Andrei_> committed
[13:50:43] *** eseidel has quit IRC
[13:53:43] *** taf2 has joined #chromium
[13:53:56] <jochen__> Andrei_: is it ok to commit now? :)
[13:55:28] <Andrei_> jochen__: all the builds so far look green
[13:55:37] <jochen__> yeah
[13:55:39] <jorlow> jochen__: what's the rush?
[13:55:41] <Andrei_> can you give it a few more mins
[13:55:45] <Andrei_> please?
[13:55:49] <Andrei_> just to make sure
[13:55:50] *** EnginA has quit IRC
[13:55:59] <jochen__> in one minute, our tech stop guys will shut down my machine and move it to the 4th floor
[13:56:17] <jochen__> but i guess i can fight them off a few more minutes :)
[13:56:27] <jorlow> jochen__: go ahead then
[13:56:34] <jorlow> i'll revert it if necessary
[13:56:53] <jochen__> ok, ta
[13:59:08] *** bauerb has joined #chromium
[14:03:53] *** Viclame has joined #chromium
[14:04:56] *** tonikitoo has quit IRC
[14:06:30] *** jochen__ has quit IRC
[14:07:38] *** Emperorlou has left #chromium
[14:09:05] *** thomasvl has joined #chromium
[14:09:05] *** ChanServ sets mode: +v thomasvl
[14:14:01] *** iOOO9 has joined #chromium
[14:14:16] <iOOO9> hi
[14:14:17] *** path[l] has quit IRC
[14:16:57] *** taf2 has quit IRC
[14:18:51] <iOOO9> could somebody explain why chromium extensions doesn't have as rich gui as firefox extensions? i have a hard time describing what i mean. but, for example, chrome extensions seems to use only html pages for settings pages in extensions like adblock. in firefox they can be a "normal" window native to the os. does this have anything to do with xul?
[14:19:59] <jorlow> iOOO9: nope...design decision....to keep things light weight
[14:20:26] <jorlow> note also that all chrome UI is either web pages or native to the OS
[14:21:07] <jorlow> nothing in ff is "native"
[14:21:46] <iOOO9> but you see what i mean when i say an extension can interact more fully with the web browser?
[14:21:59] <jorlow> yup
[14:22:03] <jorlow> and it can also crash the browser
[14:22:07] <iOOO9> :)
[14:22:09] <iOOO9> indeed
[14:22:22] <jorlow> and also constrains design that's why mozilla is planning on phasing them out
[14:22:39] <iOOO9> what do you mean by saying "contrains design"?
[14:22:50] <jorlow> internal design of the browser
[14:23:16] <iOOO9> ok. so, they're looking at an extension model more similar to the chrome one?
[14:23:44] <jorlow> yeah...it's called jetpack
[14:24:04] <jorlow> i think they plan to allow you to do more UI wise, but it'll all be CSS+JS+HTML
[14:24:14] <jorlow> er...i think they _do_ allow you to do more ui wise
[14:24:27] <jorlow> note also that safari extensions are similar to jetpack + chrome extensions
[14:25:15] <iOOO9> "[14:25] <iOOO9> but you see what i mean when i say an extension can interact more fully with the web browser?"       how could one describe what i'm trying to describ here with more user interface compatible terminology?
[14:25:45] <iOOO9> what is such a window called, compared to the html pages chrome presents?
[14:26:30] <jorlow> chrome doesn't really have that
[14:26:36] <jorlow> gtg in 2 seconds
[14:26:39] *** taf2 has joined #chromium
[14:26:44] <jorlow> but the documentation covers what's possible pretty well
[14:26:51] <jorlow> chrome is more constrained than jetpack/safari
[14:26:55] <jorlow> for philisophical reasons
[14:27:02] <jorlow> (don't want the browser to get cluttered)
[14:27:03] <jorlow> be back in a bit
[14:27:07] <iOOO9> sure
[14:30:01] *** andrix has joined #chromium
[14:30:40] *** aroben has joined #chromium
[14:30:40] *** aroben has joined #chromium
[14:33:21] *** d0k has quit IRC
[14:36:23] *** awolfson has quit IRC
[14:37:36] *** mnissler has joined #chromium
[14:38:35] *** iOOO9 has left #chromium
[14:39:35] *** apavlov has quit IRC
[14:39:37] *** jeremys has joined #chromium
[14:40:09] *** d0k has joined #chromium
[14:40:25] *** jeremys has quit IRC
[14:40:31] *** Viclame has quit IRC
[14:40:57] *** jeremys has joined #chromium
[14:41:50] *** jeremys has quit IRC
[14:42:07] *** jeremys has joined #chromium
[14:42:19] *** jeremys has quit IRC
[14:42:45] *** Emperorlou has joined #chromium
[14:43:35] *** mirandac_ has joined #chromium
[14:43:51] *** jeremyselier has quit IRC
[14:44:34] *** shreyas_ has joined #chromium
[14:44:45] *** plantain_ has quit IRC
[14:54:15] *** rohitrao has joined #chromium
[14:54:15] *** ChanServ sets mode: +v rohitrao
[14:54:20] *** jeremyselier has joined #chromium
[14:54:36] *** jeremyselier has quit IRC
[14:54:58] *** jeremyselier has joined #chromium
[14:55:47] *** jeremyselier has quit IRC
[15:01:10] *** apavlov has joined #chromium
[15:02:44] *** pinkerton has joined #chromium
[15:02:44] *** ChanServ sets mode: +v pinkerton
[15:03:27] *** jeremyselier has joined #chromium
[15:03:27] *** jeremyselier has quit IRC
[15:03:52] *** anicolao has joined #chromium
[15:04:07] *** tonikitoo has joined #chromium
[15:04:32] *** pinkerton has quit IRC
[15:08:00] *** hnrkg has joined #chromium
[15:08:20] *** edakiri has joined #chromium
[15:08:44] *** hebz0rl has quit IRC
[15:08:51] *** pinkerton has joined #chromium
[15:08:51] *** ChanServ sets mode: +v pinkerton
[15:11:00] *** Erkan_Yilmaz has joined #chromium
[15:14:45] *** trigrou has joined #chromium
[15:14:50] <trigrou> Hi
[15:15:25] <trigrou> I have updated my chromium from latest  version, and I have problem with texturing in webgl
[15:15:56] <trigrou> It works with a version a few month ago, and with firefox too -> what do you suggest me to do ?
[15:16:24] <trigrou> I mean I have not seen issue related to it so could be a bug, but I would like another opinion
[15:16:34] *** Aferlak12 has joined #chromium
[15:18:09] *** hrna has quit IRC
[15:18:30] <edakiri> "Today we are open-sourcing ... Chromium OS. " How deceitful.  The OS was already 'open-source'.
[15:20:20] <edakiri> and would not have been Google's choice whether it is open source.
[15:21:31] *** mirandac_ has quit IRC
[15:21:45] *** path[l] has joined #chromium
[15:25:39] <tfarina> Andrei_: time to reopen? the tree looks fine now.
[15:26:00] <tfarina> glider: ^
[15:27:05] *** satish_ has joined #chromium
[15:27:24] *** awolfson has joined #chromium
[15:29:43] *** kliegs_ is now known as kliegs
[15:29:53] <glider> tfarina: just a second
[15:31:41] <trungl-bot> Tree opened by glider at chromium dot org: Tree is open
[15:34:30] *** jeremyselier has joined #chromium
[15:34:30] *** jeremyselier has quit IRC
[15:38:12] *** awolfson has quit IRC
[15:39:46] *** shreyas_ has quit IRC
[15:42:37] *** hnrkg has quit IRC
[15:42:51] *** jeremyselier_ has joined #chromium
[15:43:06] *** Emperorlou has left #chromium
[15:43:21] *** Viclame has joined #chromium
[15:49:46] *** wjmaclean has joined #chromium
[15:51:25] *** jeremyselier_ is now known as jeremyselier
[15:53:02] <tfarina> thanks
[15:53:31] *** Precea[BNC] is now known as Precea
[15:55:01] *** romainhuet has joined #chromium
[15:56:42] *** mnissler has quit IRC
[15:58:52] *** rsesek has joined #chromium
[15:58:52] *** ChanServ sets mode: +v rsesek
[16:00:21] *** vithos has quit IRC
[16:04:29] *** vithos has joined #chromium
[16:05:14] *** yutak_home has joined #chromium
[16:05:14] *** ChanServ sets mode: +v yutak_home
[16:07:04] *** cbentzel has joined #chromium
[16:07:04] *** ChanServ sets mode: +v cbentzel
[16:10:14] *** Kunalagon has joined #chromium
[16:11:20] *** vithos has quit IRC
[16:15:43] *** jeremyselier has left #chromium
[16:15:43] *** jeremyselier has quit IRC
[16:16:13] *** vithos has joined #chromium
[16:16:41] *** tedoc2000 has joined #chromium
[16:17:50] *** jeremyselier has joined #chromium
[16:19:39] *** shreyas_ has joined #chromium
[16:20:07] *** mabbo_ is now known as mabbo
[16:22:09] *** mrossetti has joined #chromium
[16:24:51] *** hrna has joined #chromium
[16:25:57] *** agl has joined #chromium
[16:25:57] *** ChanServ sets mode: +v agl
[16:30:15] *** paul_irish has joined #chromium
[16:31:26] *** cbentzel_ has joined #chromium
[16:31:26] *** ChanServ sets mode: +v cbentzel_
[16:31:49] *** cbentzel has quit IRC
[16:32:45] *** trungl has joined #chromium
[16:32:45] *** ChanServ sets mode: +v trungl
[16:33:04] <trungl> 'morning, Chromium!
[16:33:04] <trungl-bot> trungl: Good morning!
[16:33:31] <trungl> what in the world makes you think it's "good", trungl-bot?
[16:34:34] <pinkerton> it knows we'll all be there monday?
[16:34:37] <rsesek> it's friday!
[16:35:04] *** rohitrao has quit IRC
[16:35:45] *** glider has quit IRC
[16:36:59] *** ROBOd has joined #chromium
[16:37:23] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Linux Builder (ChromiumOS)" from 54314: agl at chromium dot org, glotov at chromium dot org, rsesek at chromium dot org)
[16:39:11] <rsesek> definitely glotov
[16:39:20] *** paul_irish has quit IRC
[16:39:42] <rsesek> trungl-bot: halp
[16:39:42] <trungl-bot> rsesek: Valid commands (use "halp <command>" for more): bug, commit, commits, cookie, fortune, halp, help, lkgr, offices, settreestatus, time, treestatus, tweet, uptime, webkitbug, webkitcommit, webkitcommits, whois. (If you whisper to me, I'll whisper back.)
[16:39:42] *** erikkay has joined #chromium
[16:39:42] *** ChanServ sets mode: +v erikkay
[16:39:50] <rsesek> trungl-bot: whois glotov
[16:39:50] <trungl-bot> rsesek: No explicit entry for glotov found. Try: glotov at chromium dot org / :glotov / glotov at google dot com.
[16:40:24] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed (Linux Builder ChromiumOS -> glotov)
[16:40:59] *** paul_irish has joined #chromium
[16:41:04] <rsesek> anyone know where he is?
[16:41:18] <jorlow> is the chromeos bot broken in some new and exciting way?
[16:41:39] <jorlow> cause if it's the same breakage from yesterday, is there really any point in keeping the tree closed for it?
[16:41:43] <rsesek> this is a compile failure
[16:41:58] <rsesek> so, yes
[16:42:16] <rsesek> okay, I'm reverting him
[16:42:26] <cbentzel_> SGTM
[16:43:27] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed (Linux Builder ChromiumOS -> glotov, rsesek reverting)
[16:43:35] *** skenmy has quit IRC
[16:44:16] *** kjg has joined #chromium
[16:44:51] *** tittiatcoke has quit IRC
[16:46:32] <rsesek> revert in
[16:48:32] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed (waiting for revert to cycle)
[16:50:56] <jorlow> rsesek: compile succeeded
[16:51:11] <rsesek> jorlow: thanks for watching closely. reopened
[16:51:17] *** awolfson has joined #chromium
[16:51:37] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open
[16:51:42] <jorlow> rsesek: i had a vested interest  :-)
[16:51:55] <rsesek> :)
[16:52:03] *** fta has joined #chromium
[16:54:08] <jorlow> gardeners: there's a chance we'll need to clobber windows builders for this roll
[16:54:20] <jorlow> i'll do it as i see issues
[16:54:23] <jorlow> but just letting you know
[16:56:07] *** Strat has joined #chromium
[16:56:19] *** ebraminio has joined #chromium
[16:56:21] *** ebraminio has quit IRC
[16:58:37] *** MikeSmithW3C^ has quit IRC
[16:59:03] *** rjkroege has quit IRC
[17:02:48] *** tonyg-cr has joined #chromium
[17:02:48] *** ChanServ sets mode: +v tonyg-cr
[17:05:07] *** nkostylev has quit IRC
[17:06:08] *** Guest77225 has joined #chromium
[17:09:24] <rsesek> wow the new omnibox is kahuge
[17:09:28] <rsesek> in terms of font size
[17:11:05] *** rohitrao has joined #chromium
[17:11:05] *** ChanServ sets mode: +v rohitrao
[17:11:35] <pinkerton> oh shit, i didn't notice until you said it
[17:11:40] <pinkerton> is that a feature?
[17:11:50] <rsesek> yes ? shess just landed it yesterday
[17:11:59] <pinkerton> eeek
[17:12:01] <rsesek> yea
[17:12:24] <rsesek> !a fan
[17:12:24] <echelog-1> rsesek: Error: "a" is not a valid command.
[17:12:38] <cbentzel_> is that osx only? I don't notice a change on ubuntu.
[17:12:51] <rsesek> yes, mac only
[17:13:27] *** trungl has quit IRC
[17:13:33] <rsesek> http://cl.ly/edf6555ecdd822b05eae
[17:14:00] <rsesek> it's so jarring compared to the tab title size
[17:15:11] *** fta_ has joined #chromium
[17:15:27] <rohitrao> the omnibox text is bigger again?
[17:15:35] <rohitrao> didn't linus make us change that last year?
[17:15:37] <rsesek> yes. it looks like it did in the prehistory days
[17:16:07] * pinkerton shakes his head
[17:16:43] *** fta has quit IRC
[17:16:46] *** fta_ is now known as fta
[17:17:34] <thomasvl> rsesek: file a bug to show the string in ALL CAPS to make sure it's screaming at users  :)
[17:18:00] <pinkerton> use a different color for every letter
[17:18:06] <pinkerton> i hear that works too
[17:18:38] <rsesek> should I really file a bug?
[17:18:51] <rsesek> I think it's by design; shess changed it yesterday
[17:18:55] <rsesek> to match windows or somesuch
[17:20:50] <thomasvl> the whole window chrome is also taller just to make laptop screens more useful
[17:22:04] <rohitrao> wait, really?
[17:22:12] <rohitrao> so we're taller than safari now?
[17:22:24] *** mnissler has joined #chromium
[17:22:48] *** miro_ has joined #chromium
[17:23:20] <motownavi> no, we're precisely the same as safari
[17:23:21] *** miro_ has quit IRC
[17:25:20] <yakattak> /r/redraw
[17:25:23] <yakattak> woops
[17:25:52] *** Agiofws has joined #chromium
[17:26:47] <jorlow> hmmmm...clobbering windows webkit builders
[17:27:10] <rsesek> jorlow: you also have some webkit redness on mac
[17:27:49] <Agiofws>  did an upgrade  on lenny and now chrome has another charcter set ... letters are not that nice anyone know why ?
[17:28:22] <jorlow> rsesek: i'm hoping that's just flake
[17:28:25] <rsesek> k
[17:29:15] <jorlow> i wish there was some way, in your commit, to tell the bots to clobber themselves
[17:29:49] <jorlow> now we'll need to wait till the 54322 cycle to know if the svg problems go away
[17:29:57] *** lorenzo has quit IRC
[17:30:10] *** fta_ has joined #chromium
[17:31:04] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (54322 clobbered windows webkit, so the webkit errors should go green -- jorlow)
[17:31:27] *** fta has quit IRC
[17:31:31] *** fta_ is now known as fta
[17:31:45] *** tittiatcoke has joined #chromium
[17:33:38] <thomasvl> jorlow: what was in your cl that needed a clobber?  a define change?
[17:33:59] <jorlow> thomasvl: http://trac.webkit.org/changeset/64345/
[17:34:16] <jorlow> well, we suspect that one....something within http://trac.webkit.org/log/?verbose=on&rev=64351&stop_rev=64344
[17:34:26] <jorlow> and 2 cls from yesterday that made a public method private (and that's it)
[17:34:37] <jorlow> er...public method protected
[17:35:09] *** MikeSmithW3C has joined #chromium
[17:35:12] <jorlow> the 2 cls from yesterday at least caused it to not compile
[17:35:15] *** rjkroege has joined #chromium
[17:35:22] <jorlow> this one caused the executable to just plain be wrong
[17:35:46] <jorlow> interestingly here only a handful of them crashed/were wrong
[17:35:52] <jorlow> on the canaries, it was 350 tests which failed
[17:36:07] <thomasvl> that would seem to impl msvc is completely failing at tracking simple header deps then
[17:36:22] <agl> we have a number of cases where we allocate memory which isn't really a leak, but looks that way to Valgrind. We land the suppression and carry on. Now, every time we move code around those suppressions need to be updated, which wastes all manner of time. Would it not be good if we defined a function IgnoreLeakChecksForPointer and included suppressions which matched it?
[17:37:15] <pinkerton> interesting idea
[17:37:29] <pinkerton> do we really move code around that often with those types of allocation?
[17:37:34] *** dglazkov has joined #chromium
[17:37:35] *** ChanServ sets mode: +v dglazkov
[17:37:41] <jorlow> thomasvl: this is what happened on the canary: http://buildbot.jail.google.com//buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/32828/steps/webkit_tests/logs/stdio
[17:37:47] <dglazkov> good morning, Chromium!
[17:37:48] <trungl-bot> dglazkov: Good morning!
[17:38:31] <agl> pinkerton: well, I did a couple of days ago. cpu emails me, I fix the suppression, then somebody else lands another suppression and files a bug, another person notices the duplicate and sends me a CL to remove it, etc.
[17:38:53] <agl> pinkerton: a whole teacup of wasted time
[17:39:06] *** markmentovai has joined #chromium
[17:39:07] *** ChanServ sets mode: +v markmentovai
[17:39:30] <pinkerton> :(
[17:39:45] <pinkerton> what was the situation that caused valgrind to think it was a leak?
[17:40:10] <agl> pinkerton: it's a thread local variable so we allocate one per thread as needed
[17:41:57] <thomasvl> jorlow: did http://trac.webkit.org/changeset/64344 seems like it could be interesting.  i wonder if it's from some classes going away but stuff getting left in a lib due to incremental links and/or generated files being left on disk to be found in the wrong place.
[17:42:13] <thomasvl> sorta odd that it only needs a clobber on windows.
[17:42:30] <jorlow> thomasvl: it's possible
[17:43:08] <jorlow> given that it was only svg and the 2 issues i had yesterday were also svg, that's where i looked first
[17:43:27] <jorlow> it's possible it's just coincidence and/or the fact that some svg stuff changed
[17:43:48] <jorlow> thomasvl: wait, no
[17:43:55] <jorlow> that cl wasn't in the roll
[17:44:02] <cbentzel_> Quick process question: looks like there's a memleak in WebCore::CSSStyleSelector::SelectorChecker. Should I enter bug in crbug or on webkit's issue tracker? I'm going to add suppression as well.
[17:44:19] <jorlow> thomasvl: so this is the actual list: http://trac.webkit.org/log/?verbose=on&rev=64351&stop_rev=64345
[17:44:28] <cbentzel_> (I have not touched anything in WebKit yet, so pardon ignorance)
[17:44:35] <jorlow> Andrei included his change in a 2 sided roll a bit earlier
[17:44:53] <jorlow> cbentzel_: probably webkit
[17:45:03] <jorlow> almost for sure, in fact
[17:45:25] <jorlow> sometimes it might make sense to make a cr bug that points to the webkit one
[17:45:40] <jorlow> here i don't think it's worth bothering about, though
[17:45:58] * thomasvl hosts svg/status.xml isn't used in the build process in some way
[17:45:59] <cbentzel_> jorlow: thanks
[17:47:11] *** paul_irish has quit IRC
[17:47:15] *** mnissler has quit IRC
[17:48:28] <thomasvl> jorlow: clobber was only needed on windows, right?
[17:48:34] <jorlow> thomasvl: yes
[17:48:38] <thomasvl> tx
[17:48:40] <jorlow> np
[17:48:45] <jorlow> thanks for looking into this  :-)
[17:48:48] <thomasvl> np
[17:52:32] *** pinkerton has quit IRC
[17:53:15] *** dhaffner has joined #chromium
[17:54:26] *** malavv has quit IRC
[17:54:29] *** malavv has joined #chromium
[17:55:07] *** danno_away has quit IRC
[17:55:07] *** pamg has quit IRC
[17:55:10] *** paul_irish has joined #chromium
[17:57:47] *** Strat has quit IRC
[17:58:05] <thomasvl> jorlow: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/32828/steps/gclient/logs/stdio doesn't show much of anything coming into that gclient sync though.  this is really odd.
[17:59:03] <jorlow> thomasvl: well, the previous syncs pulled it in
[17:59:06] <jorlow> but the compiled failed
[17:59:31] * thomasvl looks more
[17:59:47] <jorlow> thomasvl: that's why there's so many cl's that could be it
[17:59:57] <jorlow> the tree was broken for a bit because of the 2 sided commit
[18:00:12] <thomasvl> k
[18:00:19] <jorlow> (remember boys and girls, avoid 2 sided commits whenever possible!)
[18:00:39] *** albertb has joined #chromium
[18:00:39] *** ChanServ sets mode: +v albertb
[18:02:10] <rohitrao> markmentovai, motownavi: we appear to be in serious danger of going to round table unless someone speaks up
[18:02:28] <markmentovai> dude, we can go to round table whenever
[18:02:40] <markmentovai> for the real thing we should go someplace that serves wine
[18:02:47] <markmentovai> i promise i'll go to round table with you also
[18:02:50] *** ebraminio has joined #chromium
[18:02:57] <rsesek> shess: ping
[18:02:59] *** johnny_g has joined #chromium
[18:03:01] <rohitrao> I didn't really expect him to take me seriously
[18:03:49] *** johnny_g_ has joined #chromium
[18:04:12] <jorlow> hahaha
[18:04:33] <jorlow> rohitrao: what are your requirements?
[18:04:46] <jorlow> for what I assume is a lunch place
[18:05:20] <markmentovai> rohitrao: we'll fix this
[18:06:02] <jorlow> crap
[18:06:06] <jorlow> didn't go green  :-/
[18:06:07] *** fantasticulous has joined #chromium
[18:06:41] <jorlow> oh
[18:06:43] * trungl_afk has never been to round table
[18:06:47] *** trungl_afk is now known as trungl
[18:06:48] <jorlow> fetching the build seems to have failed
[18:06:49] * trungl neither
[18:06:50] <markmentovai> trungl_afk: we'll go, i promise
[18:06:56] <jorlow> does that mean that it loaded the last build??
[18:06:58] <rohitrao> wednesday
[18:07:02] <rohitrao> or monday
[18:07:04] <markmentovai> and thursday
[18:07:05] *** bauerb has quit IRC
[18:07:06] <markmentovai> and friday
[18:07:12] *** johnny_g has quit IRC
[18:07:13] *** johnny_g_ is now known as johnny_g
[18:07:26] <trungl> how about saturday?
[18:07:27] <jorlow> anyone know about the extract step?
[18:07:28] <trungl> and sunday?
[18:07:31] <trungl> they feel left out
[18:07:45] <jorlow> nsylvain: maybe?
[18:07:56] <jorlow> i.e. does http://buildbot.jail.google.com//buildbot/waterfall/builders/Webkit%20(dbg)(1)/builds/23763/steps/extract%20build/logs/stdio mean that it used the previous build or the new one
[18:08:13] <trungl> two-sided commits are so last-year
[18:08:16] <trungl> we should add another side
[18:08:20] *** agl has quit IRC
[18:08:38] *** markmentovai_ has joined #chromium
[18:08:38] *** ChanServ sets mode: +v markmentovai_
[18:09:08] <jorlow> ....k....i'll just wait for the next build and see what happens
[18:10:43] <thakis> i've never been to round table either
[18:10:57] <rsesek> I haven't been to round table in years. we should definitely go
[18:11:20] <thakis> why?
[18:11:26] <rsesek> why not?
[18:12:16] *** markmentovai has quit IRC
[18:12:16] *** markmentovai_ is now known as markmentovai
[18:12:21] <thakis> since i haven't been there yet, i can't say yet
[18:12:35] <thakis> from what i hear it's not something to look forward to
[18:12:43] *** dhaffner has quit IRC
[18:12:45] *** shreyas_ has quit IRC
[18:14:42] <thakis> rohitrao++ for http://codereview.chromium.org/3041028
[18:15:03] <thakis> can we merge that?
[18:17:46] <jorlow> nsylvain: ping
[18:18:14] *** shreyas_ has joined #chromium
[18:18:28] *** splodge-bottom has joined #chromium
[18:19:19] *** rohitrao has quit IRC
[18:19:20] *** rohitrao_ has joined #chromium
[18:19:20] *** ChanServ sets mode: +v rohitrao_
[18:19:36] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (windows WebKit -> jorlow...but not sure what's wrong or how to clobber it properly)
[18:20:33] <terinjokes> is anyone else having problems compiling Chromium on OSX?
[18:20:42] <thakis> terinjokes: no
[18:21:26] <terinjokes> ok, i am, from a checkout during an open tree
[18:21:28] *** satish_ has quit IRC
[18:22:39] <trungl> terinjokes: it might help to indicate what problems you're having
[18:23:05] * trungl would happily accept a gift of a crystal ball, however
[18:23:14] <terinjokes> it's failing doing the chromium build, not being able to copy a file, let's see if I can find the error again
[18:23:46] *** xji has joined #chromium
[18:23:46] *** ChanServ sets mode: +v xji
[18:24:44] <jorlow> o....my stuff should go green after 54325 it seems
[18:25:11] *** maikmerten has quit IRC
[18:25:34] <jorlow> er...24
[18:26:08] <terinjokes> i can't, recompiling
[18:26:40] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (54324 clobbered windows webkit, so the webkit errors should go green -- jorlow)
[18:29:41] *** satish_ has joined #chromium
[18:31:45] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "taskkill" on "Webkit (dbg)(3)")
[18:31:46] *** rsesek has quit IRC
[18:33:05] <jorlow> i donno what that error means...but it seems somewhat bogus
[18:33:50] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (54324 clobbered windows webkit, so the webkit errors should go green -- jorlow)
[18:34:25] *** paul_irish has quit IRC
[18:36:30] *** rsesek has joined #chromium
[18:36:30] *** ChanServ sets mode: +v rsesek
[18:39:06] <nsylvain> jorlow: i'm here now. Is there still a problem?
[18:39:25] *** RT|Chatzilla has quit IRC
[18:39:38] *** rohitrao_ has quit IRC
[18:39:45] <jorlow> nsylvain: maybe not
[18:39:59] <jorlow> what does failing task kill mean for a bot tho?
[18:40:08] <jorlow> webkit dbg 3 just did...and it closed the tree
[18:40:15] *** paul_irish has joined #chromium
[18:40:16] *** ChanServ sets mode: +v paul_irish
[18:40:17] <nsylvain> this is a really good question.  I'll take a look
[18:40:19] <jorlow> didn't seem close tree worthy tho
[18:40:42] <nsylvain> looks like it took more than 1 minute to kill a process
[18:41:01] <jorlow> my other problem was because i misread the tea leaves of the waterfall  :-)
[18:41:11] <nsylvain> :)
[18:41:15] <jorlow> hopefully it's about to go green
[18:41:51] *** Rafael_Barth has joined #chromium
[18:41:59] <Rafael_Barth> Hello
[18:43:44] <Rafael_Barth> I wonder how it's done for him to update the screen automatically without having to click F5 or reloading?
[18:43:55] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open
[18:44:18] <jorlow> Rafael_Barth: this is not the right place to ask
[18:44:46] <jorlow> Rafael_Barth: http://en.wikipedia.org/wiki/Meta_refresh
[18:45:01] <jorlow> will at least get you started
[18:45:17] <Rafael_Barth> which the site then?
[18:45:33] *** pfeldman has quit IRC
[18:45:42] <evmar> Rafael_Barth: try #html
[18:45:51] *** phajdan-jr has joined #chromium
[18:45:51] *** ChanServ sets mode: +v phajdan-jr
[18:46:09] * phajdan-jr looks at interactive_ui_tests failures nsylvain pointed him to
[18:47:22] <Rafael_Barth> did not work #html
[18:47:55] <jorlow> Rafael_Barth: well, either way, this is not the right place...sorry
[18:48:16] <jorlow> what i sent you should be enough to give you ideas on what to search for
[18:49:06] <evmar> Rafael_Barth: try the #html channel on irc
[18:50:05] *** bauerb has joined #chromium
[18:53:04] *** Rafael_Barth has left #chromium
[18:53:33] <thakis> when I try to run the valgrind binary from third_party/valgrind manually, I get "valgrind: Unknown/uninstalled VG_PLATFORM 'amd64-darwin'"
[18:53:46] <thakis> does someone know which env var i need to set?
[18:58:06] *** bweinstein has joined #chromium
[18:58:09] <trungl> VG_PLATFORM?
[18:58:14] * trungl is just guessing
[18:58:43] *** andrix1 has joined #chromium
[18:59:04] *** andrix has quit IRC
[18:59:26] <thakis> from the valgrind source it looks like they're trying to load a .so to check
[18:59:44] *** eroman has joined #chromium
[18:59:44] *** ChanServ sets mode: +v eroman
[18:59:45] <thakis> so more something like `DYLD_LIBRARY_PATH=`pwd`/third_party/valgrind/mac_10.6/lib/valgrind third_party/valgrind/mac_10.6/bin/valgrind`
[19:00:38] *** rubenbb has quit IRC
[19:01:34] *** Rafael_Barth has joined #chromium
[19:02:43] <Rafael_Barth> solution to reload Discovery homepage
[19:03:00] *** mirandac_ has joined #chromium
[19:03:03] <thakis> valgrind -d says "--39890:1:launcher valgrind_lib = /Users/glider/src/valgrind-for-chromium-client/valgrind/scripts/../binaries/mac_10.6/lib/valgrind" ? that seems slightly broken :-)
[19:03:13] <thakis> sadly, glider's not around
[19:03:27] *** trigrou has quit IRC
[19:03:40] *** mirandac_ is now known as mirandac_vx22
[19:03:43] <Rafael_Barth> Extensions chromereload
[19:04:25] <trungl> thakis: clearly you just need to create some symlinks
[19:04:27] *** gavinp has joined #chromium
[19:04:27] *** ChanServ sets mode: +v gavinp
[19:04:35] <trungl> thakis: or rename yourself
[19:05:01] * trungl suggests the latter
[19:05:06] *** estes has joined #chromium
[19:05:07] <trungl> it'd really be no more confusing
[19:05:16] *** estes has quit IRC
[19:05:24] <trungl> except then there'd be two people with a common mysterious "name"
[19:05:48] <thakis> the magic incantation is "VALGRIND_LIB=`pwd`/third_party/valgrind/mac_10.6/lib/valgrind/  third_party/valgrind/mac_10.6/bin/valgrind -h"
[19:06:14] <thakis> now i forgot why i wanted to do this
[19:07:14] *** Rafael_Barth has quit IRC
[19:07:25] <trungl> thakis: you should just go shave some yaks instead
[19:08:22] *** rohitrao has joined #chromium
[19:08:22] *** ChanServ sets mode: +v rohitrao
[19:08:44] <trungl> rohitrao!
[19:08:53] <rohitrao> hello
[19:08:56] <rohitrao> my internet seems to hate me
[19:09:17] <trungl> maybe it does in fact hate you
[19:09:21] <trungl> but do you hate it back?
[19:10:17] <phajdan-jr> how do I build interactive_ui_tests the same way as on ChromiumOS dbg bot?
[19:10:26] * phajdan-jr will bisect and be sure about things
[19:10:47] *** taf2 has quit IRC
[19:13:53] <jorlow> phajdan-jr: isn't the command line in the top of the logs for the compile step?
[19:14:06] *** maikmerten has joined #chromium
[19:14:06] <jorlow> or whichever bot compiles it, if it instead has an extract step
[19:15:37] <phajdan-jr> jorlow: it's non-obvious. I've checked the command-line flags for both compile and update steps.
[19:15:39] *** rubenbb has joined #chromium
[19:15:49] <jorlow> ahh..gotcha
[19:16:13] * phajdan-jr tries blindly with -Dchromeos=1
[19:16:25] *** bauerb has quit IRC
[19:17:12] <phajdan-jr> and that results in third_party/cros/cros_api.gyp not found :(
[19:17:14] <jorlow> thomasvl: btw, the svg build breaks yesterday were link errors
[19:17:38] <jorlow> where it couldn't find the symbols
[19:17:55] <thomasvl> k
[19:18:11] <jorlow> now that i think about it, the .cpp files probably weren't recompiling....so if the symbol names included whether it was protected or public, that'd explain it
[19:18:13] <thomasvl> there was a cl in there that i think moved some code including add/remove of a source files pair
[19:18:19] <jorlow> so it probably was a dependency tracking issue
[19:18:30] <thomasvl> i wonder if it was leaving an old obj in a file due to incremental link
[19:18:45] <jorlow> interesting
[19:18:57] <jorlow> could be
[19:19:15] <thomasvl> i'm not sure what xcode does, but i think the make setup rebuilds the lib for this reason.
[19:19:23] <thomasvl> i'll probably look more next week.
[19:19:35] <jorlow> no prob...just thought of it and figured it was worth a note
[19:19:37] <thomasvl> (at the moment, collecting for travel next week)
[19:19:41] <thomasvl> yup, tx.
[19:20:26] <trungl> phajdan-jr: did you do GYP_DEFINES=chromeos=1 gclient runhooks ?
[19:21:02] *** johnny_g has quit IRC
[19:21:12] <phajdan-jr> trungl: yes, and got the error about cros_api.gyp
[19:21:24] <trungl> hrm
[19:21:25] <phajdan-jr> now I'm trying to fetch some cros_deps, sec
[19:21:34] *** Kunalagon has quit IRC
[19:23:19] <phajdan-jr> ok, that fixed it
[19:23:22] <phajdan-jr> now, let's bisect
[19:26:26] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (phajdan.jr runs git-bisect to pinpoint interactive_ui_tests failures on ChromiumOS)
[19:27:33] <rohitrao> dhollowa: btw, I sent you a codereview for disabling another test
[19:28:05] *** bauerb has joined #chromium
[19:31:32] <dhollowa> rohitrao: looking
[19:34:39] <dhollowa> rohitrao: LGTM.
[19:34:41] <thakis> when i do "array = unitialized; array2 = malloc(foo); memcpy(array2, array, foo);` and run valgrind with track-origins, does valgrind report array as root of array2's uinitializedness?
[19:34:50] <thakis> i guess i could just try
[19:34:59] <thakis> but if someone knows, please say so
[19:35:22] *** gregoiregentil has joined #chromium
[19:35:57] *** awolfson has quit IRC
[19:36:25] *** Kunalagon has joined #chromium
[19:36:41] <gregoiregentil> is there any option (perhaps in include.gypi) to enable dev channel while building chromium? The objective is to get the extensions option. It doesn't appear in our Linux compiled Chromium, even when starting it with the --enable-apps option
[19:37:32] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (phajdan.jr makes interactive_ui_tests green; ETA 15 minutes to land)
[19:37:35] <thakis> what do you mean "the extensions option"?
[19:37:42] <thakis> extensions are supported by default
[19:37:51] *** rniwa has joined #chromium
[19:37:51] *** ChanServ sets mode: +v rniwa
[19:37:52] <thakis> apps i don't know about
[19:37:56] <thakis> aboodman might
[19:37:59] <thakis> gregoiregentil: ^
[19:38:08] <eglaysher> gregoiregentil: also, what do you mean "enable dev channel"? The dev channels are usually built from trunk (or a branch when close to release)
[19:38:52] *** jlouie has joined #chromium
[19:39:52] *** awolfson has joined #chromium
[19:41:18] *** dmaclach has joined #chromium
[19:41:18] *** ChanServ sets mode: +v dmaclach
[19:44:18] *** loislo has quit IRC
[19:45:39] <shess> rsesek, rohitrao, etc: yes, font grew 1pt.  pretty much end of the world.  We didn't match Windows.  The Toolbar all got 2px taller.  The old font made the selection rect be even height while the field was odd height.  Seemed like a reasonable option.
[19:46:40] <shess> As far as why all the other fonts are different ... our gfx::whatever::BaseFont() is different from Windows.  We do use the system font for ours, which is good, but there are all sorts of one-off crap around this, so I'd expect there are other "jarring" spots.
[19:47:09] *** paul_irish has quit IRC
[19:47:18] *** legion13 has quit IRC
[19:47:25] *** paul_irish has joined #chromium
[19:47:25] *** ChanServ sets mode: +v paul_irish
[19:47:31] <shess> BTW, I don't care either way.  Thought I'd rather not hack the selection rect (in addition to the baseline, and soon the padding).
[19:48:45] <shess> rsesek: oh, and really, enter a bug.  there wasn't a "font size is wrong" bug, but there was "here's a bunch of shit, make it match" bug.
[19:49:42] <gregoiregentil> Let me rephrase: we are cross-compiling for ARM Chromium. We have almost the very latest (rev 53573). Extensions doesn't appear in the tools menu. Are we missing a compilation flag which bring the extensions stuff?
[19:50:56] <eglaysher> gregoiregentil: extensions should be on all the time (I don't even think there's a runtime flag to disable it anymore; I know it has been on by default since Dec.).
[19:50:56] *** rniwa has quit IRC
[19:51:39] <phajdan-jr> gregoiregentil: I think that the Extensions entry may be just missing from the menu in the Dev channel.
[19:51:51] <phajdan-jr> gregoiregentil: it is missing on my Mac OS X build, but the extensions are enabled.
[19:52:13] <eglaysher> gregoiregentil: If you look in chrome/browser/wrench_menu_model.cc, you'll see there isn't any checks around the IDC_MANAGE_EXTENSIONS line. At least on trunk.
[19:52:25] <eglaysher> phajdan-jr: is the dev channel being built off a branch?
[19:52:38] <thakis> shess: you made the toolbar 2px higher? andybons spent quite some time to get it 3px smaller
[19:52:44] <phajdan-jr> eglaysher: usually not
[19:52:51] <eglaysher> :-/
[19:53:00] <evmar> gregoiregentil: try visiting chrome://extensions
[19:53:09] <gregoiregentil> OK. Thanks.
[19:54:46] *** shreyas_ has quit IRC
[19:55:41] <thakis> rsesek: i missed context, but if the toolbar is 2px higher, please file and cc shess andybons me alcor
[19:55:45] <thakis> that seems wrong
[19:56:17] *** incluye has joined #chromium
[19:56:18] <rsesek> ok I file bug
[19:57:13] <evmar> sheriffs, linux webkit dbg is busted
[19:57:15] <evmar> OSError: [Errno 31] Too many links: '/tmp/irclib.py_Xc4plh'
[19:57:34] <trungl> we should be adding toolbars, not just going for half-measures like adding pixels to the existing one
[19:57:39] <incluye> Is this a place to get extension support?
[19:57:43] <incluye> For development, not usage, I mean
[19:57:45] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open
[19:57:53] <evmar> incluye: you're probably better off trying the mailing list
[19:58:01] <incluye> evmar: alright thanks
[19:58:05] <shess> thakis: sorry - you should come to the Tuesday meeting and bitch.
[19:58:10] *** thomasvl has quit IRC
[19:58:23] *** yorirou has joined #chromium
[19:58:31] <yorirou> hi
[19:58:46] <thakis> i can bitch here just fine :-)
[19:58:56] <shess> thakis: you need to bitch where the people who make the decisions are.
[19:59:39] <shess> thakis: We aren't just laying awake at night thinking "Everyone else is adding 3px to their toolbars, we should just f'ing add 5px."
[19:59:45] <yorirou> I am using the chromium daily snapshots, and in the last few days my html5 video support is gone. Is there any specific development issue about this problem?
[20:00:00] <incluye> My question whether it's possible to add styles etc. to the page the user is viewing.
[20:00:07] <thakis> shess: the effects seem to be the same though :-)
[20:00:19] *** shreyas_ has joined #chromium
[20:00:51] <shess> thakis: and you can join the chorus of "Get these requests in BEFORE feature freeze."
[20:01:28] <thakis> the toolbar wasn't gargantuan before feature freeze :p
[20:01:29] <incluye> because that seems like it COULD be a vulnerability
[20:01:37] *** lorenzo has joined #chromium
[20:01:41] <incluye> but only for Javascript, and I just want CSS
[20:02:53] <xji> linux webkit_tests starts to fail since build 18683 (whick picked a webkit roll). Is it a buildbot  problem? http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux%20(dbg)(2)/builds/18687/steps/webkit_tests/logs/stdio
[20:03:43] <thakis> incluye: that's possible, read the extension docs
[20:04:21] <thakis> rsesek: AnimatableImageTest makes valgrind puke all over the place. known problem?
[20:04:31] <incluye> thakis: I am, but I can't find that particular information
[20:04:52] <incluye> oh, content_scripts might be it
[20:04:56] <xji> jorlow: any clue on the linux webkit_tests failure?
[20:05:06] *** maikmerten_ has joined #chromium
[20:05:28] *** mirandac_vx22 has quit IRC
[20:05:40] <jorlow> nsylvain: can you take a look at linux webkit_tests
[20:05:45] <jorlow> looks like the bot needs to be kicked
[20:05:58] <jorlow> xji:  ^^^
[20:06:00] *** zloidemon has quit IRC
[20:06:07] <jorlow> anyway, i'm heading home
[20:06:09] <jorlow> later all
[20:07:07] <xji> nsylvain: any clue on the linux webkit_tests failure?
[20:07:15] *** maikmerten has quit IRC
[20:07:20] <nsylvain> looking
[20:07:57] <rsesek> thakis: no
[20:08:21] <thakis> rsesek:  sh tools/valgrind/chrome_tests.sh -t unit_tests --gtest_filter=AnimatableImageTest.* --tool_flags="--track_origins --num-callers=50"
[20:08:22] <rohitrao> rsesek, thakis, shess: total toolbar height looks the same, but the border around the omnibox is one pixel smaller
[20:08:29] *** gregoiregentil has quit IRC
[20:08:40] *** gregoiregentil has joined #chromium
[20:08:44] <rsesek> thakis: not gonna get to it today
[20:09:03] <thakis> rsesek: does that not happen on the mem bots tho?
[20:09:04] <rohitrao> wait, maybe not
[20:09:12] <rsesek> thakis: doesn't seem like it
[20:10:04] <shess> rohitrao: OK.  Yes, I lied.  The containing rectangle for the toolbar is the same.  The buttons and omnibar are 2px taller, and the buttons are 2px narrower.
[20:10:21] <rohitrao> ok, I don't care about this change then :)
[20:10:33] <evmar> but, but, THE PIXELS
[20:10:45] *** yorirou has quit IRC
[20:10:52] *** markmentovai has quit IRC
[20:10:57] <evmar> my tongue cannot get 2px narrower, therefore damaging the lickability of your ui
[20:11:03] <shess> well, the omnibox (omnibar, where'd that come from?) is taller.  So either the font looks weirdly small w/in the field, or looks wrong compared to nearby text.
[20:11:17] <shess> moar px == moar surface area for licking.
[20:12:06] <shess> you can get the sweet and salty receptors working to make a taste fusion.
[20:12:43] <shess> rsesek: wait, M-7?
[20:13:05] <rsesek> shess: that change was on trunk. if it's gonna get merge, pull it back to m6
[20:13:15] <rsesek> and add Regression
[20:13:22] *** rafaelw has joined #chromium
[20:13:22] *** ChanServ sets mode: +v rafaelw
[20:14:53] <shess> rsesek: http://crbug.com/50107 and http://crbug.com/50575 .  Admittedly they weren't marked up right.
[20:14:59] *** kurrik has joined #chromium
[20:14:59] *** ChanServ sets mode: +v kurrik
[20:15:02] *** fantasticulous has quit IRC
[20:16:46] *** Viclame has left #chromium
[20:17:28] <nsylvain> xji: i tried to fix, but not sure if it worked, and now i have a lunch meeting, will be back soon
[20:17:45] <xji> nsylvain: thanks.
[20:18:01] *** apavlov has quit IRC
[20:18:17] *** erickt has quit IRC
[20:18:35] *** gregoiregentil has quit IRC
[20:18:48] *** gregoiregentil has joined #chromium
[20:19:24] <thakis> rsesek: ooh, maybe the bots have a different graphics card than my mac pro and hence i see different leaks?
[20:19:28] <thakis> that'd be worrisome :-/
[20:19:36] <rsesek> then it wouldn't be our fault, either
[20:19:39] <thakis> (all the leaks are in CA, so it's probably ok)
[20:20:25] *** rfulton has joined #chromium
[20:20:40] *** rohitrao has quit IRC
[20:20:45] <phajdan-jr> ui_tests are flakiness, failed to open resources.pak
[20:21:10] *** rsimha has joined #chromium
[20:21:37] *** yorirou has joined #chromium
[20:22:03] * trungl wants an extra toolbar to lick
[20:22:12] <shess> rsesek: is popup-blocked animation for M-7?
[20:22:18] *** bent-mozilla has joined #chromium
[20:22:41] <shess> [I should think so, but since I'm implementing features post freeze already, my mind is confused.]
[20:23:20] <rsesek> shess: the popup block is in m6; the feature is done, just polishing it on the branch
[20:23:58] <shess> rsesek: OK, was trying to think how to handle merging, as the bug doesn't obviously indicate m-6 and for-merge.
[20:28:26] *** dlaurie has joined #chromium
[20:28:26] *** ChanServ sets mode: +v dlaurie
[20:30:41] *** estes has joined #chromium
[20:33:54] *** mirandac_ has joined #chromium
[20:35:14] *** phrearch has quit IRC
[20:35:57] *** jamesr has joined #chromium
[20:35:58] *** ChanServ sets mode: +v jamesr
[20:35:59] *** jamesr has quit IRC
[20:36:15] *** jamesr has joined #chromium
[20:36:15] *** ChanServ sets mode: +v jamesr
[20:39:35] *** tom__ has joined #chromium
[20:39:36] <xji> phajdan-jr: are you still investigating the interactive_ui_tests failures in chromeOS and Mac (10.5/10.6 dbg)?
[20:40:01] <xji> phajdan-jr: and also brett's suggestion on the test file you submitted?
[20:40:05] *** yorirou has quit IRC
[20:41:48] <phajdan-jr> xji: we have a fix (thanks to Brett), waiting for the right infrastructure to land
[20:42:08] <phajdan-jr> xji: let me know if there are some problems I should look into now
[20:42:16] *** tom__ has quit IRC
[20:42:34] *** anicolao has quit IRC
[20:43:03] *** splodge-bottom has quit IRC
[20:43:09] *** kangax_ has joined #chromium
[20:43:47] <kangax_> Is there a way to NOT display "chrome-extension://..." files in scripts tab dropdown?
[20:43:51] *** fqian has joined #chromium
[20:47:15] <thakis> brettw, xji: i'm afk for 70 min or so, revert me if need be
[20:48:21] <brettw> K
[20:49:10] *** jeremyselier has quit IRC
[20:50:43] *** estes has quit IRC
[20:52:39] *** estes has joined #chromium
[20:53:36] *** tonyg-cr has quit IRC
[20:54:56] *** bweinstein has quit IRC
[20:55:10] *** aroben is now known as aroben|lunch
[20:56:31] *** SogarGofin has quit IRC
[20:57:49] <rsesek> shess: ping
[20:58:07] *** chrisccoulson_ has joined #chromium
[20:58:11] <shess> rsesek: what's up?
[20:59:43] <rsesek> shess: so I was looking at autocomplete_text_field_unittest and I don't think it behaves like we think. it does [NSApp postEvent:NSLeftMouseUpEvent atStart:YES] ? so I implemented mouseUp: in AutocompleteTextField and set a breakpoint ? it never gets called. this makes sense because there's no run loop
[21:00:12] <shess> rsesek: there's a loop in -mouseDown:.
[21:00:31] <rsesek> shess: hm. even still, though, mouseUp: never gets called
[21:00:46] <rsesek> which it should, in theory, right?
[21:00:48] <shess> rsesek: actually, the cell's -mouseDown:*, because it needs to check for dragging.
[21:01:07] *** awolfson has quit IRC
[21:01:08] *** chrisccoulson has quit IRC
[21:01:16] <shess> rsesek: -mouseUp: is only called if the mouse-up event is handled via -sendEvent:.  If you pull it via -nextEventMatching*, it won't be.
[21:01:23] <rsesek> ah okay
[21:01:42] * rsesek thinks writing a unit test for 30 lines of code isn't worth all this trouble
[21:01:55] <rsesek> (not for autocomplete, but for my click-drag-release buttons in the wrench menu)
[21:02:17] <shess> rsesek: I think we could have a reasonable framework to make things easier, but not for M-6 :-).
[21:02:37] <rsesek> shess: so my issue is that I just call the super impls of the mouse event methods because I'm just setting flags when certain ones get called. therefore I'm gonna have to manage this run loop myself, which seems tricky
[21:03:57] *** rfulton has quit IRC
[21:04:14] *** acelron has joined #chromium
[21:04:46] <acelron> why are pepper plugins only in-proc?
[21:05:19] <evmar> acelron: so they're sandboxed and don't have IPC overhead
[21:05:28] <suzhe> phajdan-jr: have you uploaded the fix for interactive_ui_tests failure?
[21:06:12] <evmar> directx sdk is another 500mb download :~(
[21:06:31] *** estes has quit IRC
[21:07:17] <phajdan-jr> suzhe: let's chat over IM
[21:07:25] *** shreyas_ has quit IRC
[21:07:31] <xji> phajdan-jr: I've send you 2 emails with the crash stack for (not always) crashes of FocusOnReload and FocusOnReloadCrashTab. Will the fix fixes those?
[21:07:38] <phajdan-jr> xji: yes
[21:07:43] *** SavageX_ has joined #chromium
[21:08:40] *** rsesek has quit IRC
[21:09:13] *** maikmerten_ has quit IRC
[21:09:53] *** maikmerten_ has joined #chromium
[21:10:17] <acelron> evmar: they're sandboxed? what are they prevented from doing if PPAPI contains file and io functions? i thought only the renderers, which are out of proc, are sandboxed.
[21:10:25] *** SavageX_ has quit IRC
[21:10:57] *** SavageX_ has joined #chromium
[21:13:19] *** loret has joined #chromium
[21:14:12] *** loret has left #chromium
[21:14:35] *** loret has joined #chromium
[21:15:17] *** maikmerten_ has quit IRC
[21:15:52] *** SavageX_ has quit IRC
[21:16:04] *** d0k has quit IRC
[21:16:26] <evmar> acelron: that's a good question!  i don't know, so maybe my above guess was wrong
[21:16:40] *** d0k has joined #chromium
[21:16:43] <evmar> acelron: i believe the plan is to expose ppapi hooks for those sorts of things
[21:16:43] *** gregoiregentil has left #chromium
[21:17:10] *** loret has left #chromium
[21:18:52] <acelron> evmar: the design docs im reading for the sandbox say that the sandboxed code MUST be in a separate process. it seems like NaCl is being used to load the pepper plugins right now though (this may be wrong), which I believe has its own sort of sandbox
[21:19:02] *** mtk has joined #chromium
[21:19:19] *** fta_ has joined #chromium
[21:20:20] *** fta has quit IRC
[21:20:27] *** fta_ is now known as fta
[21:21:53] <brettw> I'm landing a scary patch of doom
[21:21:55] <brettw> sorry in advance
[21:21:55] <evmar> acelron: i would ask on chromium-dev
[21:21:59] <evmar> acelron: or ask brettw
[21:22:40] * trungl rushes to land something scary first
[21:22:52] <brettw> acelron, NaCl has it's own separate type of sandbox, plus using Chrome's sandbox
[21:23:20] *** kjg has quit IRC
[21:24:30] <acelron> brettw: then do the file APIs simply bypass the sandbox through IPC?
[21:24:42] *** kjg has joined #chromium
[21:24:53] <brettw> acelron, yes
[21:25:04] *** mtk has quit IRC
[21:25:32] *** mtk has joined #chromium
[21:25:44] *** satish__ has joined #chromium
[21:25:59] *** motownavi has quit IRC
[21:26:09] *** Zaba has quit IRC
[21:27:03] <satish__> One of my CLs is failing to build in the windows try bots, with linker errors in different targets each time. all other platform bots build it fine, and it builds fine locally. Could anyone take a look and suggest what could be wrong?
[21:27:12] *** tonyg-cr has joined #chromium
[21:27:12] *** ChanServ sets mode: +v tonyg-cr
[21:27:19] *** bweinstein has joined #chromium
[21:27:27] *** Geshman has joined #chromium
[21:27:31] *** aroben|lunch is now known as aroben|meeting
[21:29:00] <evmar> brettw: nice change!
[21:29:06] <phajdan-jr> satish__: I usually do a clobber
[21:29:11] <brettw> evmar, it was doom
[21:29:19] <satish__> phajdan-jr: good idea, will try :)
[21:29:23] <evmar> brettw: it may conflict with a change i made last night that switched some IntToWString calls, sorry
[21:29:34] <evmar> brettw: i usually do those sorts of changes piecemeal
[21:29:45] <brettw> evmar: this is the first piece
[21:29:49] <brettw> the old ones are still there
[21:29:54] <evmar> http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git&a=search&h=HEAD&st=author&s=evan , see my last six changes
[21:29:58] <brettw> now I have to go pick up the ones I missed
[21:30:38] <brettw> Also, the error handling for StringToInt was confusing and I broke a bunch of stuff in my first pass
[21:31:17] *** estes has joined #chromium
[21:31:23] *** estes has quit IRC
[21:32:01] <evmar> new api lgtm
[21:32:16] <brettw> I didn't fix the confusing error handling though
[21:32:26] <brettw> It's weird that it can return false and still convert a number
[21:32:39] <brettw> probably the return value should be the number of chars consumed
[21:32:47] <brettw> so then you can see if it consumed the whole string or not
[21:32:49] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules XP (dbg)" from 54354: mrossetti at chromium dot org)
[21:32:53] <evmar> http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_linux.cc?r1=54355&r2=54354&pathrev=54355 , it seems you didn't check the return value in one case (line 247).  on the other hand, the old code never checked if it succeeded
[21:33:04] *** Zaba has joined #chromium
[21:33:15] <gavinp> darn tree closure
[21:33:27] <xji> brettw: did you break module Linux build on string_number_conversions_unittests.cc?
[21:33:37] <brettw> xji, possibly
[21:33:52] <trungl> crap
[21:33:55] <trungl> now the tree is closed
[21:33:58] * trungl forgot to press enter
[21:34:13] <trungl> and I have to rebase
[21:34:19] <brettw> d'oh, need a newline
[21:34:21] * brettw fixes
[21:35:23] *** sbyer has joined #chromium
[21:35:23] *** ChanServ sets mode: +v sbyer
[21:35:28] *** sbyer has left #chromium
[21:35:58] <brettw> fix should be in
[21:36:58] <xji> why tree closed on net_unittests on XP, the failure marked as flaky?
[21:37:35] <phajdan-jr> xji: net_unittests = flakiness, our hires clock skew is really bad
[21:37:41] <phajdan-jr> xji: I will consult cpu about that
[21:39:05] <brettw> xji, good question, opening
[21:39:52] <trungl-bot> Tree opened by brettw at chromium dot org: Tree is open
[21:40:23] *** tom__ has joined #chromium
[21:40:33] <phajdan-jr> brettw: it's difficult to mark the failure as flaky, because it's a crash and can affect all tests
[21:40:49] <phajdan-jr> brettw: it's weird though that it seems to happen so often with net_unittests
[21:41:34] <xji> several interactive_ui_tests in "Interactive Tests (dbg)" starts to fail in build 27914, all due to timeout. anyone has any clue?
[21:42:03] *** romainhuet has quit IRC
[21:43:03] <phajdan-jr> xji: flaky DCHECK failures
[21:43:07] * phajdan-jr looks up the bug report
[21:43:25] *** rjkroege has quit IRC
[21:43:38] <phajdan-jr> xji: http://crbug.com/50663
[21:43:55] * trungl presses enter
[21:45:21] <trungl> here goes nothing
[21:45:45] *** Aferlak12 has quit IRC
[21:46:09] *** bauerb_ has joined #chromium
[21:46:35] <evmar> hahahaha
[21:46:45] <evmar> trungl's patch of doom to match brettw's patch of doom
[21:46:58] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Linux Builder (ChromiumOS)" from 54357: arv at chromium dot org, brettw at chromium dot org, cbentzel at chromium dot org, mrossetti at chromium dot org)
[21:47:00] *** Engin has joined #chromium
[21:47:07] *** Agiofws has quit IRC
[21:47:45] <brettw> ignore that error, it's the one I already fixed
[21:47:52] <trungl> phew
[21:47:57] *** johnny_g has joined #chromium
[21:47:57] *** ChanServ sets mode: +v johnny_g
[21:47:59] <trungl-bot> Tree opened by brettw at chromium dot org: Tree is open
[21:48:32] *** kangax_ has quit IRC
[21:48:40] *** bauerb has quit IRC
[21:48:41] *** bauerb_ is now known as bauerb
[21:49:11] *** estes has joined #chromium
[21:49:38] <xji> phajdan-jr: seems a different set. Those failed in "Interactive build" are TabIn* tests.
[21:50:43] <xji> brettw: any idea on the "interactive Tests" failure (starts from build 27914. caused by timeout)
[21:50:52] <xji> brettw: is the buildbot problem?
[21:51:04] <brettw> xji: no idea
[21:51:49] <xji> nsylvain: any idea on the "interactive Tests" failure (starts from build 27914. caused by timeout)?
[21:52:38] <phajdan-jr> xji: they do fail due to the DCHECK
[21:52:41] <cbentzel_> Sheriffs: I've been looking at memory issues today with a number of supressions. Need to be absent for about 5 hours but will be back online later.
[21:52:43] <phajdan-jr> xji: just double-checked the log
[21:52:56] <cbentzel_> Unfortunately, it was looking pretty good until recently...
[21:53:23] <phajdan-jr> or at least, the DCHECK seems more serious thing / or is closely related to the timeouts
[21:53:29] *** cbentzel_ has quit IRC
[21:53:46] *** mirandac_ has quit IRC
[21:53:52] <phajdan-jr> nsylvain: would be interesting to verify if the bot is healthy
[21:54:06] <phajdan-jr> nsylvain: if kicking the bot fixing it, then maybe the DCHECK failure indicates a bot problem
[21:54:14] * phajdan-jr looks at the test code
[21:54:55] *** tom__ has quit IRC
[21:56:18] <phajdan-jr> I'm afraid it may be a problem with those tests (BrowserKeyboardAccessibility). There is a lot of potential for a hang.
[21:56:31] *** loislo has joined #chromium
[21:56:33] <phajdan-jr> And then the DCHECK qould be only a consequence of the timeout. Hmm...
[21:56:52] *** kjg has quit IRC
[21:56:53] <phajdan-jr> I'll add debugging code to the test.
[21:57:15] *** path[l] has quit IRC
[21:57:46] <xji> phajdan-jr: you right. it is the DCHECK. why there is no symbol in the trace in "dbg" mode.
[21:58:00] *** bauerb has quit IRC
[21:58:02] <phajdan-jr> good question. :(
[21:58:37] *** rdsmith has joined #chromium
[21:58:38] *** ChanServ sets mode: +v rdsmith
[22:00:54] *** dhaffner has joined #chromium
[22:01:08] *** tittiatcoke has quit IRC
[22:01:54] *** mirandac_ has joined #chromium
[22:01:55] *** isherman1 has joined #chromium
[22:01:55] *** ChanServ sets mode: +v isherman1
[22:02:09] <trungl> mirandac_!
[22:02:32] <mirandac_> trungl! I greet you from on high
[22:02:40] <trungl> really?
[22:02:52] <isherman1> pkasting: ping
[22:02:53] <mirandac_> yes, just passing over the mississippi river
[22:02:57] *** phajdan-jr is now known as phajdan-jr|afk
[22:03:00] *** eroman has quit IRC
[22:03:01] *** mirandac_ is now known as mirandac_vx22
[22:03:09] <trungl> will the miracles of technology never cease?
[22:03:28] <eglaysher> trungl: they will never ceases.
[22:03:36] <eglaysher> Except for flash. That will never get better.
[22:03:56] <mirandac_vx22> hopefully not while I'm in midflight, at least!
[22:05:04] <isherman1> eglaysher: ah, but there is still hope ? flash might altogether cease to be
[22:05:15] <eglaysher> truth
[22:05:44] * trungl carefully refrains from all comment
[22:05:49] <trungl> (but not meta-comments)
[22:05:56] <eglaysher> obviously
[22:06:09] <jamesr> trungl: you refrain from comments like flash refrains from good
[22:06:27] *** rohitrao has joined #chromium
[22:06:27] *** ChanServ sets mode: +v rohitrao
[22:06:31] *** dave_levin has joined #chromium
[22:06:34] <trungl> rohitrao!
[22:06:56] *** rdsmith_ has joined #chromium
[22:06:56] *** ChanServ sets mode: +v rdsmith_
[22:06:56] *** rdsmith has quit IRC
[22:06:57] *** rdsmith_ is now known as rdsmith
[22:07:20] <rohitrao> hey i'm back!
[22:07:46] *** aroben|meeting is now known as aroben
[22:07:46] <akalin> me too!!
[22:09:10] <trungl> rohitrao: I take it that the tubes are working again for you
[22:09:16] <rohitrao> for me
[22:09:18] <rohitrao> for now
[22:10:45] *** path[l] has joined #chromium
[22:11:00] *** eseidel has joined #chromium
[22:11:39] *** n3v3le1 has joined #chromium
[22:12:09] *** kjg has joined #chromium
[22:13:10] *** n3v3le has quit IRC
[22:14:24] *** lnostdal has quit IRC
[22:15:00] *** lnostdal has joined #chromium
[22:16:12] * shess In your base, mocking your mocks.
[22:17:37] *** rjkroege has joined #chromium
[22:18:56] *** tonikitoo has quit IRC
[22:20:15] *** aroben has quit IRC
[22:20:41] *** tonikitoo has joined #chromium
[22:21:03] *** lorenzo has quit IRC
[22:23:21] <dabear> are there any blog aggregator for the chrome project? kinda like mozilla planet?
[22:23:35] <evmar> dabear: planet.chromium.org
[22:24:19] <dabear> thanks
[22:24:27] *** phajdan-jr|afk is now known as phajdan-jr
[22:24:52] <cmasone> chocobo: ping
[22:24:59] *** awolfson has joined #chromium
[22:25:08] <phajdan-jr> mrossetti: can interactive_ui_tests failures be possibly your change?
[22:25:21] * phajdan-jr looks up the logs
[22:25:33] <mrossetti> phajdan-jr: I'll take a look.
[22:25:57] <phajdan-jr> http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/9590/steps/interactive_ui_tests/logs/DesiredTLD
[22:26:02] <phajdan-jr> http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/9590/steps/interactive_ui_tests/logs/EscapeToDefaultMatch
[22:26:07] <phajdan-jr> mrossetti: thanks. logs above ^
[22:26:31] *** Malmis has quit IRC
[22:26:46] *** eseidel has quit IRC
[22:28:07] <mrossetti> member:phajdan-jr: Could be, though shouldn't be.  I'll run the tests locally.
[22:28:07] <dabear> evmar: not a hole lot of posts though, except for dev channel releases
[22:28:11] *** Agiofws has joined #chromium
[22:29:23] <evmar> dabear: yeah, just me and adam
[22:29:39] *** rohitrao has quit IRC
[22:30:26] *** edakiri has quit IRC
[22:32:02] *** fta_ has joined #chromium
[22:33:07] *** fta has quit IRC
[22:33:11] *** fta_ is now known as fta
[22:33:47] *** bent-mozilla has quit IRC
[22:34:01] *** bent-mozilla has joined #chromium
[22:35:01] <atwilson> Who is a good person to ask about the WebKit Reliability canaries? I'm trying to figure out why the reliability canary has been red since yesterday morning, and yet clearly the regular reliability bots are not...
[22:35:16] <atwilson> http://build.chromium.org/buildbot/waterfall.fyi/builders/WebKit%20Reliability/
[22:35:35] <jamesr> we have webkit reliability canaries?
[22:36:02] <thakis> hey i'm back!
[22:36:05] *** awolfson has quit IRC
[22:36:11] <atwilson> Apparently?
[22:36:15] *** tonikitoo has quit IRC
[22:36:43] <jamesr> atwilson: well, the reliability bots do not test all URLs on every run
[22:36:56] <jamesr> so perhaps the regular reliability bots just haven't hit that crash yet
[22:36:57] *** zidoh has left #chromium
[22:37:01] <jamesr> can you repro?
[22:37:42] <atwilson> jamesr: Haven't run locally yet. Just seems odd that they're consistently red on the webkit canaries (like, 20+ straight runs) and yet not on the main bots.
[22:38:04] <atwilson> There have been plenty of WK rolls in the interim, so it's not like they are catching upstream stuff.
[22:38:19] <jamesr> the crash on the latest run doesn't involve any WK code
[22:38:28] <jamesr> it's in the network stack
[22:38:38] <atwilson> jamesr: I agree.
[22:38:44] <trungl> thakis: no one pays any attention to you being back :(
[22:38:56] <mirandac_vx22> thakis: I noticed you were back!
[22:39:01] <jamesr> thakis: how can we miss you if you never leave
[22:41:05] <rdsmith> Just made a change to trychange.py (git try, specifically); please let me know if it breaks :-}.
[22:41:08] *** trungl is now known as trungl_afk
[22:42:13] *** xji has quit IRC
[22:42:25] *** xji has joined #chromium
[22:42:25] *** ChanServ sets mode: +v xji
[22:43:45] *** ROBOd has quit IRC
[22:43:55] *** tonikitoo has joined #chromium
[22:44:22] *** eseidel has joined #chromium
[22:44:37] *** EnginA has joined #chromium
[22:44:45] *** thakis is now known as thakis_away
[22:44:48] *** thakis_away is now known as thakis
[22:45:00] <thakis> jamesr: i don't never leave
[22:46:02] *** bauerb has joined #chromium
[22:46:44] *** Engin has quit IRC
[22:46:56] <phajdan-jr> mrossetti: do the interactive_ui_tests failures repro locally?
[22:47:12] <phajdan-jr> mrossetti: it seems to be chromiumos-specific
[22:47:26] <mrossetti> phajdan-jr: No, not locally.
[22:47:38] <mrossetti> Also, they look linux-only.  Concur?
[22:47:40] *** acelron has quit IRC
[22:47:50] <phajdan-jr> mrossetti: chromeos-only. Did you try with -Dchromeos=1?
[22:48:15] <phajdan-jr> mrossetti: oh, but Linux seems to be affected too
[22:48:44] <phajdan-jr> mrossetti: from the 4 blamelist changes, your seems more likely
[22:48:54] <phajdan-jr> mrossetti: should I try to repro on my machine?
[22:48:57] *** loislo_ has joined #chromium
[22:49:08] *** EnginA has quit IRC
[22:49:56] <mrossetti> phadjan-jr: Yes, please.  No linux box here.
[22:50:29] <phajdan-jr> sure. compiling now on a super-fast box. :-D
[22:50:47] *** pkasting has quit IRC
[22:50:48] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (interactive_ui_tests on Linux -> mrosetti, r54354? phajdan.jr investigating)
[22:51:16] *** Malmis has joined #chromium
[22:51:33] <phajdan-jr> mrossetti: could you check if anything suspicious appeared in your trybot run? If it was green, that's also valuable info.
[22:51:41] *** Malmis has quit IRC
[22:51:45] *** Malmis has joined #chromium
[22:52:49] *** loislo has quit IRC
[22:52:50] *** loislo_ is now known as loislo
[22:52:52] *** andrix1 has quit IRC
[22:53:28] *** tonikitoo has quit IRC
[22:54:04] <thakis> who did offlien appcaches?
[22:54:08] <thakis> jorlow?
[22:54:24] <phajdan-jr> thakis: michaeln I think
[22:55:11] <phajdan-jr> mrossetti: got local repro; now trying without your change...
[22:58:38] *** tetsuo-- has joined #chromium
[22:59:02] *** Adys has quit IRC
[22:59:40] <tetsuo--> has anyone noticed the regression in the latest waterfall build? im no longer able to input urls, all input gets redirected to a google search
[22:59:58] *** Adys has joined #chromium
[23:00:15] <phajdan-jr> mrossetti: it's your change :( reverting now
[23:00:29] <mrossetti> Now hold on pavel.
[23:01:02] <mrossetti> phadjam-jr: Hold on.
[23:01:04] <phajdan-jr> mrossetti: ok
[23:01:13] <mrossetti> Side bar please.
[23:01:29] *** abarth has joined #chromium
[23:01:29] *** ChanServ sets mode: +v abarth
[23:01:55] <phajdan-jr> mrossetti: ?
[23:02:33] <mrossetti> Can we take this off-channel for a bit?
[23:02:43] <phajdan-jr> mrossetti: yeah, sent you Im invite
[23:03:21] <jamesr> tetsuo--: that sounds bad
[23:03:26] <jamesr> tetsuo--: what platform? what revision?
[23:03:36] <jamesr> we've had this bug before :/
[23:03:45] <cmasone> anyone know where the code that decides to spin up the zygote process on linux is?
[23:03:47] *** tetsuo--_ has joined #chromium
[23:03:48] <mrossetti> phadjan-jr: I'm not seeing it.  sigh
[23:03:51] <tetsuo--_> woah and it crashes too
[23:04:14] *** tetsuo--_ has quit IRC
[23:04:19] <phajdan-jr> mrossetti: now also sent to your gmail address
[23:04:38] <phajdan-jr> don't worry, I won't do anything bad unless I can contact you reliably :)
[23:05:11] *** tetsuo--_ has joined #chromium
[23:05:12] *** tetsuo-- has quit IRC
[23:05:30] <phajdan-jr> ok, contacted and talking
[23:06:04] <tetsuo--_> build 54367 still has the "omnibar always searches on google" regression, and i was getting memory coruption crashes just now (windows)
[23:06:34] *** Agiofws has left #chromium
[23:06:50] *** ebraminio has quit IRC
[23:06:59] <brettw> Could that be mrossetti's change?
[23:07:00] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (interactive_ui_tests on Linux -> mrosetti, r54354, trybots were green)
[23:07:12] *** Geshman has quit IRC
[23:07:23] <phajdan-jr> brettw: the redness or tetsuo's reports?
[23:07:31] <brettw> tetsuo's reports
[23:07:36] <brettw> he touched the autocomplete directory
[23:07:40] <brettw> I can repro the problem
[23:07:45] *** Adys has quit IRC
[23:07:50] *** MikeSmithW3C has quit IRC
[23:08:07] <brettw> could be me also, I touched that dir earlier today
[23:08:09] <brettw> I'm looking now
[23:08:10] *** Adys has joined #chromium
[23:08:25] *** tittiatcoke has joined #chromium
[23:08:47] *** dpranke has joined #chromium
[23:08:48] *** ChanServ sets mode: +v dpranke
[23:08:51] <phajdan-jr> brettw: not sure. I'm talking with mrossetti now, we're trying to salvage his patch.
[23:09:06] <brettw> I'm building with that patch reverted
[23:09:21] <phajdan-jr> brettw: I did too. interactive_ui_tests failures disappear after that.
[23:09:38] <phajdan-jr> revert being landed
[23:09:41] <brettw> k
[23:10:49] *** Kunalagon has quit IRC
[23:12:04] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (interactive_ui_tests on Linux -> mrosetti, phajdan.jr reverted)
[23:12:27] *** path[l] has quit IRC
[23:12:40] *** dhaffner has quit IRC
[23:12:42] *** MikeSmithW3C has joined #chromium
[23:13:05] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Mac10.6 (dbg)" from 54378: lzheng at google dot com)
[23:13:20] *** dhaffner has joined #chromium
[23:13:24] <phajdan-jr> hmm, flakiness again? I'll check.
[23:14:08] <phajdan-jr> lzheng_: looks like a real breakage
[23:14:10] *** tittiatcoke has quit IRC
[23:14:20] *** rohitrao has joined #chromium
[23:14:20] *** ChanServ sets mode: +v rohitrao
[23:14:43] *** jianli has joined #chromium
[23:14:43] *** ChanServ sets mode: +v jianli
[23:15:19] *** bmizerany has joined #chromium
[23:16:07] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (net_unittests -> lzheng, interactive_ui_tests cycling green after revert)
[23:16:42] *** mirandac_vx22 has left #chromium
[23:16:55] *** rohitrao has quit IRC
[23:17:00] *** rohitrao has joined #chromium
[23:17:00] *** ChanServ sets mode: +v rohitrao
[23:17:14] <phajdan-jr> lzheng_: thank you
[23:18:14] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open (net_unittests -> reverted, interactive_ui_tests -> reverted)
[23:19:09] *** cuba33ci has quit IRC
[23:19:22] <phajdan-jr> my Windows build fails with "Cannot open include file: 'd3dx9.h': No such file or directory". Any clues?
[23:19:32] <evmar> phajdan-jr: you have to install the directx sdk :(
[23:19:36] <evmar> phajdan-jr: see chromium-dev
[23:19:40] <evmar> phajdan-jr: another 500+mb, whee
[23:19:56] <phajdan-jr> how nice. okay, I'll feed Windows some bytes.
[23:21:06] <brettw> mrossetti, the revert fixed URL bar navigation for me. So be sure to test that before re-landing
[23:21:10] *** cuba33ci has joined #chromium
[23:21:21] <mrossetti> brettw, gotcha.
[23:21:23] * phajdan-jr doesn't want to upgrade his internet experience from Chrome to IE8
[23:21:29] <phajdan-jr> it sounds more like a downgrade :)
[23:21:51] *** roc has quit IRC
[23:22:23] *** roc has joined #chromium
[23:23:30] *** kjg has quit IRC
[23:25:44] *** tetsuo--_ has quit IRC
[23:26:07] <evmar> i liked that too :)
[23:26:23] <rohitrao> can someone help take a look at the official google chrome builder?
[23:26:25] <evmar> i wonder if ballmer yells at employees for using chrome like he reportedly did for them using iphones
[23:26:45] <rohitrao> I see libxslt link errors, which I think gets fixed by a clobber build?
[23:26:45] <thakis> probably
[23:26:55] <evmar> rohitrao: errors, or warnings?
[23:26:56] *** tittiatcoke has joined #chromium
[23:27:04] <evmar> rohitrao: my libxml update introduced warnings, dunno how to fix them :(
[23:27:17] <rohitrao> oh, yes, warnings
[23:27:39] <rohitrao> so then why did the compile fail?
[23:27:53] <rohitrao> maybe it's ok now
[23:28:13] *** eseidel has quit IRC
[23:28:37] <rohitrao> oh i see, i just can't read buildbot output
[23:28:39] <rohitrao> or msvc output
[23:29:22] *** rsimha has quit IRC
[23:29:30] <tonyg-cr> does anyone know if it is possible to rebaseline layout tests on the release dashboard? Unless I'm missing something, it looks like it isn't running the archive_webkit_tests_results step which means rebaselining isn't possible.
[23:30:22] <rohitrao> evmar: can you suggest an owner for http://crbug.com/50714 ?
[23:34:12] <evmar> rohitrao: maybe jshin?
[23:34:24] <rohitrao> evmar: ok, thanks
[23:35:07] <tonyg-cr> who is a good person to talk to about the official release bots?
[23:36:16] <rohitrao> tonyg-cr: what's the question? :)
[23:36:43] <tonyg-cr> rohitrao: is it possible to rebaseline layout tests on the release dashboard? Unless I'm missing something, it looks like it isn't running the archive_webkit_tests_results step which means rebaselining isn't possible.
[23:37:07] <tonyg-cr> my real question, i suppose, is whether it is feasible to add that step or if it was left out for a reason
[23:38:06] *** Adys has quit IRC
[23:38:13] <rohitrao> ah, that's not a question for me
[23:38:37] *** path[l] has joined #chromium
[23:38:50] *** tetsuo-- has joined #chromium
[23:39:17] *** imcheng has joined #chromium
[23:40:47] *** path[l] has quit IRC
[23:40:52] *** path[l] has joined #chromium
[23:40:59] *** loislo has quit IRC
[23:41:11] *** rjkroege has quit IRC
[23:44:28] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open
[23:44:33] *** Adys has joined #chromium
[23:45:45] *** trigrou has joined #chromium
[23:46:28] *** eseidel has joined #chromium
[23:47:16] *** Adys has quit IRC
[23:47:22] *** bauerb has quit IRC
[23:47:34] *** Adys has joined #chromium
[23:48:09] *** hrna has quit IRC
[23:50:10] <thakis> afk for 70 min
[23:51:12] *** thakis_ has joined #chromium
[23:51:12] *** ChanServ sets mode: +v thakis_
[23:51:37] *** rniwa has joined #chromium
[23:51:37] *** ChanServ sets mode: +v rniwa
[23:51:57] *** tittiatcoke has quit IRC
[23:54:20] *** tetsuo-- has quit IRC
[23:59:28] *** mrossetti has quit IRC
[23:59:29] *** bent-mozilla has quit IRC





top