[00:00:12] <jamesr> does anyone here use vimdiff? [00:00:43] <erikchen> jamesr: I do occassionally [00:00:52] <fishd> linking test_shell.exe is instantaneous now [00:00:54] <fishd> :) [00:01:15] *** byte has joined #chromium [00:01:29] <jamesr> erikchen: how do i make it work? i want it to pull the RHS in some section [00:02:01] <erikchen> jamesr: I don't quite understand your question. you just want to diff 2 files? [00:02:15] <jamesr> i'm using it as my git mergetool driver [00:02:49] <jamesr> i have a section with conflicts. i want to say "just use the right hand side for this entire section" but can't figure out how to do that [00:02:56] *** kliegs has quit IRC [00:03:21] <erikchen> Have never used it as merge tool, sorry [00:03:33] <jamesr> no problem [00:03:40] * jamesr will continue to RTFM [00:04:03] <evmar_sheriff> jamesr: bad diffing support is actually what drove me to switch to emacs, believe it or not [00:04:20] <jamesr> i was happy with tkdiff [00:04:29] <eglaysher> evmar_sheriff: have you ever got ediff to work as git-mergetool? [00:04:36] <evmar_sheriff> i was doing some really gnarly merge [00:04:43] <evmar_sheriff> eglaysher: once, i forget how now :( [00:04:44] <jamesr> but my symlinks are all hosed now so tkdiff is temporarily down [00:04:51] <jamesr> and as a good vim advocate i figured it's time to learn vimdiff [00:04:56] <evmar_sheriff> man, everything is busted all the time, huh? [00:05:01] <evmar_sheriff> jamesr: meld is pretty good [00:05:31] <jamesr> and i just hosed my shell [00:05:48] <jamesr> protip: don't ctrl-c out of mergetool if gvimdiff is your driver [00:06:28] *** eseidel has quit IRC [00:06:30] <jamesr> evmar_sheriff: can you drive it from the keyboard reasonably? [00:06:49] *** elsenorblanco has joined #chromium [00:07:50] *** elsenorblanco has quit IRC [00:07:51] *** aroben has quit IRC [00:08:53] <evmar_sheriff> jamesr: dunno [00:09:28] <jamesr> this is purty! [00:10:32] *** senorblanco has quit IRC [00:10:55] *** phajdan-jr is now known as phajdan-jr|afk [00:11:01] <nsylvain> so evmar_sheriff, the compile is ok, it is just interactive_ui_tests.. and it's happening on all platforms.. so it has to be a real regression [00:11:20] <evmar_sheriff> nsylvain: oh, huh? [00:11:33] <evmar_sheriff> http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(Views%20dbg)/builds/12196 [00:11:35] <nsylvain> and since it's devtool stuff, it must be the webkit merge [00:11:40] <nsylvain> this is fixed [00:11:46] <nsylvain> http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20(Views%20dbg) [00:11:47] <evmar_sheriff> yeah, we know about that failure [00:11:56] <evmar_sheriff> nsylvain: yeah, but why did the compile fail? [00:12:08] <cpu> evmar_sheriff: do we have a suspect for the mac UI failures? [00:12:09] <evmar_sheriff> nsylvain: it's the second time that's happened today [00:12:15] <nsylvain> ok [00:12:19] *** estes has joined #chromium [00:12:22] <nsylvain> i dont know [00:12:30] <nsylvain> but it should not be the reason why the tree is closed [00:12:46] <evmar_sheriff> i guess all the other failures are worth investigating as well, ok [00:13:04] <evmar_sheriff> nsylvain: while i have you distracted, how about http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(3)/builds/13542 [00:13:15] <evmar_sheriff> svn: Can't move 'C:\b\slave\chromium-dbg-xp-tests-3\build\src\chrome\browser\chromeos\cros\.svn\tmp\entries' to 'C:\b\slave\chromium-dbg-xp-tests-3\build\src\chrome\browser\chromeos\cros\.svn\entries': Access is denied. [00:13:20] <nsylvain> fixing [00:13:27] *** awolfson has quit IRC [00:13:28] <cpu> evmar_sheriff: my guess is stuartmorgan [00:13:28] <nsylvain> ah [00:13:35] <stuartmorgan> evmar_sheriff: yeah, I was just about to say that [00:13:36] <stuartmorgan> I'll revert [00:13:36] <nsylvain> it cleared itself. Most likely hung process somewhere [00:13:58] <stuartmorgan> I'm seeing it in my trybot results too; missed it at the time because a flaky test failed too :( [00:14:30] <rafaelw> evmar_sheriff: fyi: i see the mac failure with me on the blame list. i don't think it's me, but i'm looking... [00:15:09] <trungl-bot> Tree closed by cpu at google dot com: Tree is closed (stuartmorgan reverting) [persistent issues status: http://bit.ly/bsyE8W] [00:15:21] *** kliegs has joined #chromium [00:16:24] <stuartmorgan> evmar_sheriff: reverted; mac ui_tests should cycle green [00:17:30] <evmar_sheriff> how about this one: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg-shlib)(1)/builds/3302 [00:17:33] <evmar_sheriff> "sizes" failed [00:18:05] <markmentovai> evmar_sheriff: do you happen to know what distcc version is in use on the bots having trouble? [00:18:12] <evmar_sheriff> markmentovai: no idea, sorry [00:18:52] *** exxe has quit IRC [00:18:53] <markmentovai> looking at my copy of the distcc source, i can?t figure out how we?d get this one error and then have it exit nonzero without saying something else [00:21:17] <evmar_sheriff> stuartmorgan: does your revert fix the mac compile error? [00:21:25] <evmar_sheriff> stuartmorgan: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/6911 [00:21:57] <markmentovai> oh, distcc 2.18.3. that's old. [00:22:17] <markmentovai> guess i should have checked that first. [00:22:26] <evmar_sheriff> cpu: i'm considering opening, i think most of hte failures have been fixed [00:23:07] <stuartmorgan> evmar_sheriff: no [00:24:16] <markmentovai> evmar_sheriff, nsylvain, etc.: distcc 2.18.3 doesn?t do local fallback when the remote end compiler fails. seemingly it doesn?t carry the remote end?s stderr (or stdout) back to the local end either. [00:24:26] <markmentovai> blech [00:24:58] *** fqian has quit IRC [00:25:08] <markmentovai> linux builder views dbg is ubuntu hardy. are all of the distcc servers too? [00:25:57] <nsylvain> oh ok [00:26:21] *** tonikitoo has quit IRC [00:26:43] <nsylvain> markmentovai: no. The distcc server that caused the failure is a centos server [00:27:14] <nsylvain> and distcc does not even seem to be running [00:27:38] <markmentovai> preprocessing with one set of headers and giving them to a compiler that might be expecting another set of headers? and throw in -Wall and -Werror? sounds like a recipe for this sort of problem. [00:27:48] <evmar_sheriff> markmentovai: wait, that can't be right -- otherwise we'd never get any error messages [00:27:57] <markmentovai> poking more [00:28:04] <markmentovai> maybe something changed recently? [00:28:26] <thakis> evmar_sheriff: compile error might be suzhe ? [00:28:32] <thakis> (on mac) [00:28:57] <suzhe> thakis: what compile error? [00:29:04] <thakis> suzhe: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/6911/steps/compile/logs/stdio [00:29:09] *** pomaxa has joined #chromium [00:29:12] *** satish_ has quit IRC [00:29:24] <thakis> "/b/slave/chromium-rel-mac/build/src/chrome/../chrome/browser/browser_keyevents_browsertest.cc:856: warning: 'BrowserKeyEventsTest_PageUpDownKeys_Test' has a base '<unnamed>::BrowserKeyEventsTest' whose type uses the anonymous namespace" etc [00:29:33] *** dmaclach has quit IRC [00:30:40] <markmentovai> evmar_sheriff: it's possible that we never got error messages *from the affected bots* [00:30:55] <suzhe> thakis: let me have a look. [00:31:16] <evmar_sheriff> markmentovai: normally it says something like "remote build failed, retrying locally" [00:31:38] <markmentovai> yes, that distcc version doesn?t have that at all [00:32:17] <markmentovai> codf188 /usr/bin/distcc --version gives 2.18.3, i'm looking at the source to that version and the local fallback isn't present at all [00:32:20] *** paul_irish has quit IRC [00:32:25] <markmentovai> (linux views dbg) [00:33:14] <suzhe> thakis: I guess it's caused by old gcc version? [00:33:20] <thakis> suzhe: wot? [00:33:28] *** dmaclach has joined #chromium [00:33:37] <thakis> suzhe: the builders are running the gcc version we build with [00:33:57] <thakis> so it's by definition the current gcc version [00:34:34] <thakis> (bevc says she'll try to restart the trybot master tonight, so the try servers should catch stuff in interactive_ui_tests starting tomorrow) [00:34:36] <markmentovai> evmar_sheriff: or, i should say... [00:34:37] <suzhe> thakis: the code built without any problem on my local 10.6. Anyway I'll upload a CL to fix it. [00:34:44] <markmentovai> it does, but only for sometihng like a connection problem [00:34:51] <markmentovai> if the remote end compiles and just happens to exit nonzero [00:34:52] *** rdsmith has joined #chromium [00:34:53] *** ChanServ sets mode: +v rdsmith [00:35:12] <markmentovai> then you're stuck with that, it won't retry the compilation locally [00:35:17] <markmentovai> and you won't get remote stderr [00:35:18] <evmar_sheriff> so if there's any compile problem you just get a silent failure? [00:35:23] <markmentovai> seems like [00:35:30] <evmar_sheriff> i am skeptical. i don't think we could have ever used distcc if that were the case [00:35:42] <markmentovai> that's this version of distcc [00:42:33] *** tonikitoo has joined #chromium [00:42:36] *** marklarson has quit IRC [00:43:13] <markmentovai> ok, the stderr stuff did move - it should be present [00:43:16] <markmentovai> so now we're at: [00:43:40] <markmentovai> remote compiler exits nonzero but doesn't say anything on stderr [00:45:05] <markmentovai> dunno. bug me if it happens again. [00:45:26] <zepo> my pc took 2~hours compiling chromium using -j2 ... [00:46:05] *** rsesek has quit IRC [00:46:39] <evmar_sheriff> zepo: one of our users informed us that he was going to use lynx until chrome had a similar memory footprint. i think he would probably be best off using lynx, then [00:47:23] *** Tin has joined #chromium [00:47:46] <thakis> zepo: use -j20 and it takes 1/10the the time! :-P [00:47:47] <Tin> Hello I am just a regular user and looking for where to download chromium for windows. It is not [00:47:52] *** Tin is now known as Guest51471 [00:48:21] <zepo> rly? just got dual core ;/ [00:48:27] <thakis> get 20core [00:48:30] <Guest51471> I am digging around the site, but just thought it might be useful to know it is not intuitive to a newbie [00:48:36] <evmar_sheriff> Guest51471: i suggest typing "download chrome for windows" into a search engine [00:48:44] *** cpu has quit IRC [00:49:03] <Guest51471> yes the first thing I did and it brought me here [00:49:20] <Guest51471> there is a softpedia link but i would prefer to download from the official site [00:49:33] <evmar_sheriff> http://www.google.com/chrome [00:49:43] <Guest51471> I am looking for chromium not chrome [00:49:47] *** elliottcable is now known as ajnewbold [00:49:57] *** ajnewbold is now known as elliottcable [00:49:59] <evmar_sheriff> you cannot download that, you have to build it yourself [00:50:02] <stuartmorgan> Guest51471: Chromium isn't a product; there's no official download [00:50:22] <Guest51471> oh thanks stuartmorgan, that was not clear to me [00:50:35] <evmar_sheriff> Guest51471: no problem, it's very confusing [00:50:41] <Guest51471> I also use ubuntu it was a simple matter of apt-get chromium [00:50:41] <zepo> couldn't he go for a snapshot? [00:50:46] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): open [persistent issues status: http://bit.ly/bsyE8W] [00:51:22] <evmar_sheriff> stuartmorgan: do you know why reservedaccelerators still fails on mac? [00:51:39] <stuartmorgan> evmar_sheriff: Like I said at the time, that's not related to my revert [00:51:45] <Guest51471> i thought the community might be interested in testers on Windows if it's Google Chrome which I already have then I'll use it instead. [00:51:51] <evmar_sheriff> stuartmorgan: sorry, didn't notice [00:51:56] <thakis> evmar_sheriff: as i said above, that's caused by suzhe [00:51:59] <thakis> (i think) [00:52:03] <evmar_sheriff> Guest51471: if you run the windows dev channel and turn on crash reports, that's a big help [00:52:04] <thakis> oh wait [00:52:16] <evmar_sheriff> browser_focus stuff still fails to compile it seems [00:52:31] <thakis> _that_'s suzhe [00:52:41] <evmar_sheriff> suzhe: should i revert? [00:52:54] <suzhe> thakis: I'm about to send out the fix CL. [00:53:07] <thakis> suzhe: http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests%20(dbg)(1)/builds/7943/steps/interactive_ui_tests/logs/ReservedAccelerators looks like it might be you too [00:54:05] <suzhe> thakis: let me have a look. [00:54:33] *** Guest51471 has quit IRC [00:55:50] *** anicolao has quit IRC [00:56:21] *** kjg has quit IRC [00:58:22] *** peterdn has quit IRC [00:59:46] <suzhe> thakis: I don't know why the test failed. I'm rebuilding on may local machine and will test it again. Just wondering if the screen of the bot is lock? [01:00:08] *** tonikitoo has quit IRC [01:04:45] *** eseidel has joined #chromium [01:06:42] <zepo> is there a way setting chromium as my default browser? I didn't install it, just compiled it from svn [01:06:56] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux" from 53863: scherkus at chromium dot org, victorw at chromium dot org, wtc at chromium dot org) [01:08:51] <eglaysher> "No space left on device" [01:09:06] <evmar_sheriff> third_party/WebKit/WebCore/dom/Document.cpp:5040: fatalerror: error writing to /tmp/ccMu08YJ.s: No space left on device [01:09:15] <evmar_sheriff> jinx elliot :) [01:09:20] <eglaysher> :p [01:09:31] <tony^work> Chromium Linux? [01:09:34] <tony^work> I can clean up [01:09:45] <evmar_sheriff> codf19 [01:13:23] <eglaysher> whoah, out of space on several different linux bots [01:13:46] *** bradnelson has joined #chromium [01:13:46] *** ChanServ sets mode: +v bradnelson [01:14:12] <phajdan-jr|afk> where does that space go to? /tmp? [01:14:17] *** phajdan-jr|afk is now known as phajdan-jr [01:14:24] <evmar_sheriff> lols, 856gb in use on that machine [01:14:38] <nsylvain> they are our main webservers [01:14:43] <nsylvain> hosting build.chromium.org [01:14:48] <nsylvain> they do have a lot of data [01:14:51] <nsylvain> i'll delete some snapshots [01:15:20] <nsylvain> usually we get paged when they run out of memory.. not sure why it did not happen [01:15:32] *** wtc has joined #chromium [01:15:32] *** ChanServ sets mode: +v wtc [01:15:57] <tony^work> nsylvain: where does the buildbot scripts live? [01:16:02] <tony^work> oh, in the chroot? [01:17:07] *** cpu has joined #chromium [01:17:07] *** ChanServ sets mode: +v cpu [01:17:46] <wtc> Anyone know why the compilation failed on Linux? [01:18:13] <cpu> wtc: we've been having troubles with distcc [01:18:20] *** bradnelson has quit IRC [01:18:34] <thakis> suzhe: no idea [01:20:19] *** bent-mozilla has quit IRC [01:20:29] <thakis> (about locks) [01:20:37] <suzhe> thakis: I tested it on my local machine. It failed once out of 10 times. [01:21:05] <thakis> seems like it's not caused by a locked screen then [01:21:27] <thakis> maruel_ooo, nsylvain, markmentovai: test bots never have a locked screen, right? [01:21:55] *** rdsmith has left #chromium [01:22:12] <nsylvain> thakis: most of them do actually [01:22:26] <nsylvain> it's why we have the "interactive" tests. we ensure that those bots don't have a locked screen [01:22:27] <thakis> nsylvain: how does that work with interactive_ui_tests? [01:22:33] <thakis> nsylvain: ah, cool [01:22:59] <thakis> nsylvain: how is that configured? does this happen automatically for interactive_ui in the buildbot master cfg? [01:23:08] <nsylvain> It's a manual change when we set up the bot [01:23:13] <nsylvain> initial setup [01:23:26] <suzhe> thakis: seems that the ReservedAccelerators test is a little flaky on Mac 10.6. But I couldn't reproduce the failure anymore. [01:23:27] <nsylvain> so the new machines you added might not have it... but if it's only for mac, I don't think this applies [01:23:30] <nsylvain> this is mostly a windows thing [01:23:36] <suzhe> thakis: I don't know why. [01:23:40] <thakis> nsylvain: i enabled interactive_ui_tests for mac yesterday [01:23:54] <thakis> nsylvain: suzhe says it's important for mac too [01:23:59] <nsylvain> Ok [01:24:14] <nsylvain> since we never had interactive ui tests on mac.. i'm not too sure how that works [01:24:16] <thakis> suzhe: find out, and mark the test as flaky in the meantime? :-) [01:24:19] <suzhe> thakis: I think it's nothing to do with screen locker. Otherwise other tests would fail as well. [01:24:28] <thakis> oh, good [01:24:34] *** jrmuizel has quit IRC [01:24:39] <suzhe> thakis: ok. I'll send out a CL for it. [01:25:06] <thakis> suzhe: (and you can commit the compile failure cl) [01:26:34] *** smani has joined #chromium [01:28:28] *** smani has quit IRC [01:31:09] <thakis> third_party/WebKit/WebCore/page/PageGroup.cpp:361: fatal error: error writing to /tmp/cceIXvZb.s: No space left on device [01:31:22] <scherkus2> :( [01:31:40] <jamesr> rm -rf /tmp/ [01:32:21] <thakis> that's on codf20 [01:32:56] <thakis> nsylvain: can you look at disk usage on codf20? [01:33:05] <nsylvain> i did, it's fixed now [01:33:12] <nsylvain> how long ago was this error? [01:33:25] <nsylvain> i fixed it ~5-10 minutes ago [01:33:28] *** cbentzel has quit IRC [01:33:36] <thakis> the build log doesn't have a time stamp, but it's the current tree closure [01:33:39] <thakis> 6 min ago? [01:33:41] <thakis> cool [01:33:46] *** markmentovai has quit IRC [01:33:52] <nsylvain> thakis: which bot? [01:33:59] <thakis> codf20 [01:34:00] <thakis> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20Builder%20(dbg)/builds/13125/steps/compile/logs/stdio [01:34:02] <thakis> d'oh [01:34:03] <thakis> :-) [01:34:10] *** seventh has joined #chromium [01:34:13] <thakis> evmar_sheriff: nsylvain fixed something that might've healed the linux bots [01:34:16] *** eseidel_ has joined #chromium [01:35:10] <nsylvain> i believe this one should be fine now [01:35:16] <thakis> trungl-bot: settreestatus Tree is closed (linux bots hopefully cycling green; let's wait and see) [01:35:17] <trungl-bot> thakis: Set tree status to: "Tree is closed (linux bots hopefully cycling green; let's wait and see) [set by :thakis]". [01:35:20] <nsylvain> cpu said he was going to see if they cycle green before opening [01:35:29] <thakis> i said that too :-) [01:36:11] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (linux bots hopefully cycling green; let's wait and see) [set by :thakis] [01:36:51] *** eseidel has quit IRC [01:36:52] *** eseidel_ is now known as eseidel [01:39:14] *** dimich has quit IRC [01:40:01] *** eseidel has quit IRC [01:40:41] *** eseidel has joined #chromium [01:41:13] *** djustice|f has joined #chromium [01:41:36] <djustice|f> i have an issue.. i hope someone can help: [01:41:38] <djustice|f> "You need to make sure that /opt/google/chrome/chrome-sandbox is mode 4755 and owned by root." [01:41:47] <djustice|f> even tho the binary is 4755, and root:root [01:42:09] <djustice|f> 6.0.466.0, from aur, clean archlinux [01:43:07] <jhawkins> djustice|f: Please read the channel topic [01:43:21] *** lorenzo has quit IRC [01:45:02] <evmar_sheriff> djustice|f: google chrome doesn't work on arch anyway, you should build it yourself [01:45:13] <djustice|f> ahh. kool. thx. [01:45:17] <djustice|f> evmar_sheriff: i did build it myself.. [01:45:39] <djustice|f> it built fine.. it just doesnt run. even with the .1d/.0d libs [01:45:53] <evmar_sheriff> if you built it yourself, you wouldn't need to make library symlinks [01:46:08] <thakis> bleh, is pdf broken on the dev channel? [01:46:09] <evmar_sheriff> djustice|f: i suggest asking the people you got it from about it [01:46:12] <evmar_sheriff> thakis: yes [01:46:20] <evmar_sheriff> thakis: http://code.google.com/p/chromium/issues/detail?id=49702 [01:46:31] <djustice|f> evmar_sheriff: um.. ;D and kk. thx. it works fine for everybody on archlinux except for me.. [01:46:52] <thakis> evmar_sheriff: :'-( (i meant on mac tho) [01:46:54] *** Adys has quit IRC [01:47:00] <evmar_sheriff> thakis: mac is broken too [01:47:08] <thakis> evmar_sheriff: just saw stuart's comment [01:47:45] <thakis> linux bug has 2x the stars [01:48:29] *** eseidel_ has joined #chromium [01:49:00] <evmar_sheriff> all 50 linux users starred the linux one [01:50:02] <thakis> :-P [01:50:05] <stuartmorgan> There were 3 or 4 comments from Mac users, so I think it's safe to say Mac users have been starring the Linux bug [01:50:27] <evmar_sheriff> all 34 linux users starred the linux one, along with 16 confused mac users [01:51:03] *** eseidel has quit IRC [01:51:04] *** eseidel_ is now known as eseidel [01:51:25] <evmar_sheriff> despite the tree being closed all the time, we're still really red [01:51:43] <evmar_sheriff> why is reserved accelerators still failing? [01:52:06] *** nickcarter has joined #chromium [01:52:29] *** eseidel has quit IRC [01:54:09] <evmar_sheriff> bah, so frustrated, i'm going home [01:54:12] *** evmar_sheriff is now known as evmar_afk [01:54:19] <jamesr> go home, play starcraft2 [01:54:57] *** stuartmorgan has quit IRC [01:56:10] *** RT|Chatzilla has joined #chromium [01:56:46] *** lorenzo has joined #chromium [01:57:16] <nickcarter> the linux bots are looking green to me. [01:57:26] *** anicolao has joined #chromium [01:58:58] <thakis> trungl-bot: settreestatus Tree is open [01:58:59] <trungl-bot> thakis: Set tree status to: "Tree is open [set by :thakis]". [01:59:32] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open [set by :thakis] [02:01:52] *** mrossetti has quit IRC [02:02:04] *** cpu has quit IRC [02:02:10] *** yutak_home has joined #chromium [02:02:10] *** ChanServ sets mode: +v yutak_home [02:02:50] *** djustice|f has quit IRC [02:04:22] *** jrmuizel has joined #chromium [02:06:43] *** Martijnc has quit IRC [02:06:58] <leiz> how did we linx buts get fixed? [02:07:04] <leiz> linux, even [02:07:14] *** Martijnc has joined #chromium [02:07:25] *** hclam has quit IRC [02:07:31] *** rickcam has joined #chromium [02:07:33] <leiz> was it out of disk space or did a clobber fix it? [02:09:31] *** hclam_ has quit IRC [02:09:56] <eglaysher> leiz: disk space [02:10:22] *** brettw has quit IRC [02:12:00] *** bryeung has quit IRC [02:12:50] *** bryeung has joined #chromium [02:14:03] *** homata_ has joined #chromium [02:14:23] *** cpu has joined #chromium [02:14:23] *** ChanServ sets mode: +v cpu [02:15:00] <cpu> evmar_afk: I'll try to sort the accelerators thing [02:16:21] *** tonyg-cr has quit IRC [02:16:59] *** jamesr has quit IRC [02:17:52] *** khansen_ has joined #chromium [02:18:03] *** yutak_home has quit IRC [02:19:39] *** n00p has quit IRC [02:19:40] *** khansen has quit IRC [02:20:08] *** n00p has joined #chromium [02:22:17] <thakis> cpu: on mac? [02:22:34] <thakis> if so, suzhe's looking afaik [02:22:39] <thakis> if not, ignore [02:22:44] *** tedoc2000 has quit IRC [02:22:46] *** dmaclach has quit IRC [02:23:19] *** tedoc2000 has joined #chromium [02:24:22] <cpu> thakis: yes on mac [02:24:43] *** pdelgallego has quit IRC [02:24:48] *** rickcam has quit IRC [02:25:09] *** dr_win has quit IRC [02:26:36] <suzhe> thakis: what are you talking about? [02:27:30] <leiz> hrm, I guess there's some bots my free disk space script doesn't check [02:28:11] *** dr_win has joined #chromium [02:29:14] <thakis> suzhe: the test failure you were about to mark flaky earlier today [02:30:01] *** isherman has joined #chromium [02:30:01] *** ChanServ sets mode: +v isherman [02:30:11] *** rdsmith has joined #chromium [02:30:11] *** ChanServ sets mode: +v rdsmith [02:30:21] <suzhe> thakis: I see. [02:30:29] *** rdsmith has quit IRC [02:30:51] *** hbono has joined #chromium [02:32:04] *** Emperorlou has joined #chromium [02:39:32] <suzhe> thakis: sent out a CL to mark the test flaky. [02:40:22] *** rickcam has joined #chromium [02:45:03] *** slightlyoff has joined #chromium [02:45:04] *** ChanServ sets mode: +v slightlyoff [02:45:44] *** wtc has quit IRC [02:46:31] * cpu hoping the webkit roll fixes something [02:47:01] <cpu> suzhe: I can review, what is the url? [02:47:39] <suzhe> cpu: http://codereview.chromium.org/3033034/show, just mark the test flaky. Nothing else. [02:48:13] *** evmar_afk is now known as evmar_sheriff [02:48:16] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules XP (dbg)" from 53881: satorux at chromium dot org) [02:48:21] <victorw> nsylvain: seems webkit canary bot is in bad state, could you help?http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/32596/steps/compile/logs/stdio [02:48:24] <suzhe> cpu: I don't know why it failed on 10.6 bot, but succeeded on 10.5 bot. [02:48:37] <nsylvain> victorw: looking [02:48:52] <victorw> nsylvain: thx [02:49:26] <evmar_sheriff> i am back. [02:49:50] *** mazda has joined #chromium [02:49:50] *** ChanServ sets mode: +v mazda [02:50:26] <phajdan-jr> evmar_sheriff: net_unittests = flakiness [02:50:31] * phajdan-jr suggests re-opening [02:50:49] <satorux> oops [02:51:06] <satorux> 53881 should be nothing to do with windows [02:51:23] <satorux> it's code for chrome os [02:51:26] <cpu> suzhe: you can commit [02:51:31] <evmar_sheriff> [58492:51680:0727/171900:322108282:FATAL:time_win.cc(341)] Check failed: now - ReliableNow() - skew_ < kMaxTimeDrift. [02:51:36] <evmar_sheriff> satorux: not your fault [02:52:11] <satorux> evmar_sheriff: thanks [02:52:11] <evmar_sheriff> not sure why that's a CHECK and not a dcheck [02:52:14] <evmar_sheriff> or is it? [02:52:32] <suzhe> cpu: tree is closed again. May I commit? [02:52:33] <thakis> duh-duh-duh duh-duhm [02:53:18] <cpu> suzhe: yes [02:53:20] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): Tree is open (net_unittests on Modules XP (dbg) is flake) [02:53:58] *** ChrisPartridge has quit IRC [02:54:06] *** fbarchard has joined #chromium [02:54:11] <evmar_sheriff> victorw: what's the story on prototype-inheritnce/ [02:54:49] <evmar_sheriff> suzhe: are you fixing ReservedAccelerators? [02:55:05] <victorw> evmar_sheriff: it should be fixed in r53874. [02:55:09] <suzhe> evmar_sheriff: Just committed the CL marking it flaky. [02:55:35] <evmar_sheriff> suzhe: ok [02:55:53] <cpu> evmar_sheriff: we just reviewed suzhe CL [02:56:06] <evmar_sheriff> http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg-shlib)(1)/builds/3305/steps/sizes/logs/stdio [02:56:09] <evmar_sheriff> what is this test? [02:58:32] *** cmasone has quit IRC [02:58:44] *** mazda has quit IRC [02:59:02] <cpu> evmar_sheriff: ping davemoore [03:00:42] <zepo> well, I'm off, you're doing great job, keep going ^^ (and I'd be rly happy using pogo.com in future) [03:01:05] *** zepo has left #chromium [03:01:28] *** ChrisPartridge has joined #chromium [03:01:32] *** dave_levin has quit IRC [03:03:04] <cpu> evmar_sheriff: 53874 is the webkit roll, should fix mac [03:03:26] <cpu> evmar_sheriff: or break everything [03:03:34] <chase> evmar_sheriff: fixed by davemoore in a later CL, see http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg-shlib)(1)/builds/3306/steps/sizes/logs/stdio [03:04:06] *** hebz0rl_ has joined #chromium [03:04:53] <akalin> mal@ just burned eroman@ [03:05:21] *** __ed has quit IRC [03:05:34] <eroman> akalin: huh? ... this is news to me [03:05:57] <akalin> i was just admiring his snarky comment re. extensions sync :) [03:06:00] *** oshima_ has joined #chromium [03:06:17] <victorw> evmar_sheriff: cpu: 53874 fixes the webkit test on mac. [03:06:23] <eroman> akalin: ah [03:06:25] <chase> eroman: i think you're safe. the snark seemed more like goading to me. [03:06:50] <akalin> at first i thought he was suggesting we all sync our chrome extensions to the same account [03:06:59] <eroman> extension sync is all well and good, but i am trying to tackle a more general discovery problem :) [03:07:04] *** trungl has joined #chromium [03:07:04] *** ChanServ sets mode: +v trungl [03:07:06] *** ebraminio has joined #chromium [03:07:08] <evmar_sheriff> i'm bailing this tree as fast as i can, but still it sinks [03:07:36] *** hebz0rl has quit IRC [03:08:42] *** awolfson has joined #chromium [03:09:01] <cpu> victorw: thanks [03:09:16] <evmar_sheriff> cpu: http://build.chromium.org/buildbot/waterfall.fyi/builders/Google%20Chrome%20XP/builds/8149/steps/compile/logs/stdio -- Warning: Could not delete file "c:\b\slave\google-chrome-rel-xp\build\src\chrome\Release\mksnapshot.exe" : Access is denied [03:09:31] <victorw> cpu: np [03:09:50] *** leeight has joined #chromium [03:09:52] *** dhollowa_ has joined #chromium [03:10:28] *** leeight has left #chromium [03:11:33] <cpu> evmar_sheriff: probably mksnapshot was running [03:11:59] <evmar_sheriff> cpu: it's failed for multiple builds http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Google%20Chrome%20XP [03:12:08] <phajdan-jr> cpu: can we add it to the "kill" step? [03:12:17] <evmar_sheriff> cpu: er, but on different files it seems [03:12:18] <phajdan-jr> (if it was really running during compile) [03:12:22] <evmar_sheriff> oh, i see the real problem [03:12:24] <evmar_sheriff> IOError: [Errno 2] No such file or directory: u'app\\theme\\google_chrome\\search_delfi.png' [03:12:36] *** up365 has quit IRC [03:12:39] *** hebz0rl_ has quit IRC [03:13:02] <cpu> evmar_sheriff: yeah but I don't understand the relation of that with the next [03:14:48] <evmar_sheriff> cpu: no idea, mirandac is fixing at least the first problem [03:15:09] <cpu> evmar_sheriff: I was going to blame pkasting [03:15:12] <mirandac> fix in already for search_delfi.png [03:15:21] <mirandac> and deps have been rolled [03:15:30] <evmar_sheriff> mirandac++ [03:15:33] <pkasting> cpu: At least _try_ to look at the source before blaming me [03:15:36] <evmar_sheriff> cpu: me too, but i checked the commit log :) [03:15:50] <pkasting> Man [03:15:56] <evmar_sheriff> pkasting: given that we get ~3 failures per build, it's hard to be too thorough [03:15:58] <pkasting> I'm not brettw [03:16:04] <cpu> pkasting: what is the fun in that? [03:16:13] <evmar_sheriff> this one, on the other hand, is definitely pkasting [03:16:15] <mirandac> pkasting actually alerted me to another issue w/IDR resource names, he is the man [03:16:16] <evmar_sheriff> http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6754/steps/memory%20test:%20unit/logs/stdio [03:16:33] <evmar_sheriff> and by "definitely" i mean "highly unlikely to be" :D :D :D [03:16:35] *** miles339 has joined #chromium [03:16:45] *** miles339 has joined #chromium [03:17:13] <pkasting> Dammit [03:17:26] <evmar_sheriff> any mac people around? thakis, you know about mac opengl stuff right? [03:17:29] <pkasting> I'm under a tight time constraint right now and I just wasted a minute looking at that trying to figure out what I broke :( [03:17:38] <evmar_sheriff> pkasting: aw, sorry [03:17:41] <thakis> evmar_sheriff: what up? [03:17:51] <evmar_sheriff> thakis: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6754/steps/memory%20test:%20unit/logs/stdio , hit "end" after loading page [03:18:21] *** Emperorlou has quit IRC [03:18:32] <miles339> My chromium for Mac OS X build was successful but I can't find the apps it made -- where are they supposed to be? (sorry I'm new) [03:19:20] <thakis> miles339: xcodebuild/Debug/ [03:19:28] <thakis> miles339: (below src) [03:20:01] <miles339> thakis: Found them! Thanks! :) [03:21:13] <evmar_sheriff> thakis: any thoughts on that mac gl thing? [03:21:14] <thakis> evmar_sheriff: http://crbug.com/35164 [03:21:22] <thakis> might be an apple bug [03:21:31] <evmar_sheriff> D: at bug title [03:21:36] <thakis> :-D [03:21:41] <thakis> do you know the regression range? [03:22:01] <mirandac> evmar_sheriff: just sent you http://codereview.chromium.org/3033035/show for review -- it fixes a typo in theme_resources.grd. [03:22:22] <awong> evmar_sheriff: FYI, just committed. shoudl be safe, but I'm currently teathered so I might drop-off. If 53892 breaks, just revert. [03:22:54] *** miles339 has quit IRC [03:23:27] <cpu> mirandac will also fix linux64 :) [03:23:49] *** chrisccoulson_ has quit IRC [03:24:08] <mirandac> I'll do what I can! :-) [03:24:32] <victorw> evmar_sheriff: cpu: FYI. I will be away for dinner for 30 min or so... [03:24:50] <victorw> evmar_sheriff: cpu: so far the webkit roll looks ok [03:25:31] <pkasting> mirandac: it's fine to TBR that kind of thing [03:25:59] *** up365 has joined #chromium [03:26:11] <mirandac> pkasting: yeah, I figured that out after thinking about it for a minute %-) [03:27:48] <evmar_sheriff> thakis: http://codereview.chromium.org/2832087 [03:28:16] <thakis> evmar_sheriff: lg [03:28:36] *** johnny_g has quit IRC [03:29:02] *** leeight has joined #chromium [03:29:14] *** leeight has left #chromium [03:29:39] *** phajdan-jr has quit IRC [03:30:45] <trungl-bot> Tree opened by cpu at google dot com: Tree is open (persistent issues status: http://bit.ly/bsyE8W) [03:30:46] <evmar_sheriff> thakis: grr, don't have svn credentials on this comptuer, mind committing it for me? [03:31:34] <mirandac> another search png error, grrrrrrr, fixing [03:32:03] <thakis> Please provide contibutor as 'First Last <email at example dot com>' [03:32:04] *** oshima__ has joined #chromium [03:32:14] <thakis> bah [03:32:22] <evmar_sheriff> thakis: haha, you can commit as yourself too, i don't mind [03:32:30] <evmar_sheriff> i should remove the -c stuff [03:32:34] <evmar_sheriff> too easy to get wrong [03:33:02] <thakis> i love it, way better than having to edit the cl description on rietveld [03:33:05] <thakis> anyway, done [03:33:34] <evmar_sheriff> thanks [03:33:45] <evmar_sheriff> hey, main tree is briefly all green [03:33:58] <evmar_sheriff> reliability and memory bots are screwed but they always are [03:34:25] <thakis> why is "official" in the header all red? [03:34:28] * trungl also likes the -c stuff [03:35:38] <evmar_sheriff> thakis: miranda is on that [03:35:47] <thakis> oic [03:35:55] *** oshima_ has quit IRC [03:35:56] *** oshima__ is now known as oshima_ [03:36:01] * thakis remembers reviewing the cl that broke that :-/ [03:38:45] *** shoe` has quit IRC [03:38:48] <evmar_sheriff> if we don't break stuff sometimes, we're being too careful [03:38:49] *** shoe` has joined #chromium [03:40:07] <mirandac> ok, one more time. this time I fixed all typos, instead of waiting to fix each one on a separate cl. [03:42:56] <mirandac> committed fixes for hopefully everything; grabbing a sandwich, BRB [03:43:11] <trungl> mirandac fixed everything! [03:43:12] <trungl> sweet [03:43:22] <trungl> close all the bugs now [03:43:40] <mirandac> trungl: "hopefully." I'm always optimistic that I'll find the one missing semicolon that will cause the universe to dissolve into rainbows [03:43:51] <trungl> that'd be okay too [03:44:05] *** Aria has joined #chromium [03:44:08] <trungl> as long as it's pretty [03:44:15] <evmar_sheriff> any sync people around? [03:44:18] <trungl> and there's gold at the end [03:44:26] <trungl> we need more gold on our tree [03:45:38] *** mirandac_phone has joined #chromium [03:46:01] *** mirandac_phone is now known as mirandac_nourish [03:47:03] *** mirandac_nourish has quit IRC [03:47:10] *** mirandac_phone has joined #chromium [03:47:37] *** dhollowa_ has quit IRC [03:49:45] * evmar_sheriff sends a useful diff to sync folks [03:49:46] <evmar_sheriff> http://codereview.chromium.org/3076008/diff/1/2 [03:50:59] <cpu> evmar_sheriff: at a loss on the perf regression on XP [03:51:12] <evmar_sheriff> i gotta run, good luck :P [03:51:16] *** evmar_sheriff is now known as evmar_afk [03:51:20] <cpu> evmar_sheriff: ok [03:52:30] <cpu> fbarchard: ping [03:54:55] <cpu> trungl: what is the deal with NSNib instantiateNibWithOwner:topLevelObjects ? [03:55:11] <trungl> cpu: I thought I fixed the suppression for that? [03:55:18] <trungl> cpu: is it still showing up? [03:55:55] <thakis> cpu: where's that at? might happen cause of buggy code. is that in notifications-related tests? [03:56:08] <thakis> (i know that these have the bug i'm thinking of) [03:56:12] <fbarchard> cpu: hey [03:56:46] <cpu> fbarchard: looking at a perf regression in XP [03:56:52] <trungl> thakis: I assume that's the leak formerly in WillInitializeMainMessageLoop() [03:56:57] <trungl> but I moved the leak [03:57:06] <thakis> oh ok [03:57:09] <trungl> (there's now a comment/TODO at the point of the leak, so you can find it) [03:57:09] <thakis> good work! [03:57:21] * trungl has to get off the bus in a minute [03:57:26] *** jrmuizel has quit IRC [03:57:31] <trungl> biab [03:57:33] *** trungl has quit IRC [03:58:05] *** jrmuizel has joined #chromium [03:58:09] <cpu> fbarchard: but I am not sure, the other changes seem even less likely [03:58:48] <fbarchard> cpu: my change pulls in new binaries for windows ffmpeg... shouldnt cause a perf issue [03:58:50] *** pathorn has joined #chromium [03:58:51] *** ChanServ sets mode: +v pathorn [04:00:03] *** csilv has left #chromium [04:00:13] <cpu> fbarchard: ok. I am just grasping at thin air. Maybe is transient [04:01:51] <cpu> I needz to go, afk for ~1 hour, can I deputize somebody or go lawless ? [04:03:07] <cpu> for example scherkus .. :) [04:05:20] *** cpu has quit IRC [04:05:57] *** ph0nk has quit IRC [04:06:15] *** trungl has joined #chromium [04:06:16] *** ChanServ sets mode: +v trungl [04:14:21] *** cmasone has joined #chromium [04:14:21] *** ChanServ sets mode: +v cmasone [04:20:06] *** trungl has quit IRC [04:20:53] *** trungl has joined #chromium [04:20:53] *** ChanServ sets mode: +v trungl [04:23:18] *** yusukes has left #chromium [04:23:57] *** yusukes has joined #chromium [04:25:42] *** slightlyoff has quit IRC [04:25:49] *** bers has quit IRC [04:26:34] *** wash has joined #chromium [04:27:48] *** mirandac_phone has quit IRC [04:31:38] *** bmizerany has quit IRC [04:38:35] *** rniwa has quit IRC [04:54:24] *** mirandac is now known as mirandac_afk [05:03:45] *** cmasone has quit IRC [05:04:24] <trungl> anyone around? [05:04:55] * trungl is hoping for no answer [05:05:37] * trungl is going to do something which may break something [05:05:54] <victorw> trungl: hi [05:06:14] <victorw> trungl: could I roll a samll webkit before you break thing? [05:06:25] <trungl> victorw: sure [05:06:53] <trungl> victorw: (what I'd likely break is Linux x64 release base_unittests, fwiw [05:06:57] *** rickcam|home has joined #chromium [05:07:07] <victorw> trungl: thx, will land it soon [05:07:14] <trungl> victorw: so it should be almost entirely orthogonal) [05:07:18] <trungl> but I'll wait for you [05:08:10] <victorw> trungl: done [05:08:14] <victorw> trungl: thx [05:08:18] <trungl> victorw: thanks [05:13:26] *** MikeSmithXX has joined #chromium [05:16:57] *** MikeSmithW3C^ has quit IRC [05:22:15] *** awolfson has quit IRC [05:23:20] *** paul_irish has joined #chromium [05:26:17] *** cmasone has joined #chromium [05:26:17] *** ChanServ sets mode: +v cmasone [05:29:43] *** ejat has joined #chromium [05:34:05] *** loislo has joined #chromium [05:35:42] *** bweinstein has quit IRC [05:35:58] * trungl twiddles his thumbs [05:37:39] *** scherkus2 has quit IRC [05:39:07] *** victorw has left #chromium [05:45:38] *** paul_irish has quit IRC [05:48:03] *** jrforbes_ has quit IRC [05:50:36] *** tedoc2000 has quit IRC [05:52:31] *** mirandac has joined #chromium [05:53:05] *** mirandac is now known as mirandac_athome [05:55:00] <trungl> crap [05:55:02] *** ejat has quit IRC [05:56:28] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "base_unittests" on "Chromium Linux x64" from 53903: kkanetkar at chromium dot org, victorw at chromium dot org, viettrungluu at chromium dot org (:trungl)) [05:56:59] <trungl> yes yes yes [05:57:30] <trungl> trungl-bot: settreestatus Tree is open (viettrungluu reverting 53903; persistent issues status: http://bit.ly/bsyE8W) [05:57:32] <trungl-bot> trungl: Set tree status to: "Tree is open (viettrungluu reverting 53903; persistent issues status: http://bit.ly/bsyE8W) [set by :trungl]". [05:58:03] *** kavita has joined #chromium [05:58:29] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (viettrungluu reverting 53903; persistent issues status: http://bit.ly/bsyE8W) [set by :trungl] [05:59:37] <trungl> trungl-bot: settreestatus Tree is open (r53903 reverted; persistent issues status: http://bit.ly/bsyE8W) [05:59:38] <trungl-bot> trungl: Set tree status to: "Tree is open (r53903 reverted; persistent issues status: http://bit.ly/bsyE8W) [set by :trungl]". [06:00:01] *** alt-dot-net-geek has joined #chromium [06:00:02] <trungl> sad [06:00:31] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (r53903 reverted; persistent issues status: http://bit.ly/bsyE8W) [set by :trungl] [06:00:50] <trungl> that is pretty annoying, whatdyaknow [06:05:51] *** estes has quit IRC [06:08:34] *** wash has quit IRC [06:09:46] * trungl talks to himself some more [06:13:14] *** cpu has joined #chromium [06:13:14] *** ChanServ sets mode: +v cpu [06:14:03] *** paul_irish has joined #chromium [06:14:06] <cpu> plantain: I just want to say that is an awesome nick [06:14:55] <plantain> errr, thanks. [06:16:15] *** MikeSmithXX has quit IRC [06:16:43] <trungl> cpu is here! [06:16:47] <kavita> cpu: Is the culprit for recent bot failure my fault? kkanerkar@chromium? I am still at work if you need me to revert. [06:16:50] * trungl is no longer alone [06:17:09] <trungl> which bot failure? [06:17:30] <kavita> Revision: 53900, 53902, 53903 Blame list: kkanetkar at chromium dot org,victorw@chromium.org,viettrungluu@chromium.org [06:17:43] <trungl> oh no, that was me [06:17:47] <kavita> oh ok [06:17:57] <trungl> it was even kind of expected [06:18:05] <trungl> (kind of = 85%) [06:18:09] <kavita> oh ok [06:18:27] <trungl> kavita: thanks for checking though [06:18:46] <kavita> np [06:20:46] <cpu> so trungl what is the deal with the linux redness? [06:21:07] *** asn has joined #chromium [06:21:12] <trungl> cpu: I was just tired of green [06:21:14] *** asn has left #chromium [06:21:26] <trungl> cpu: but, more seriously, see the commit message for 53903 [06:21:31] <cpu> trungl: understandable [06:22:02] <cpu> trungl: but why to to red why not, say purple? [06:22:07] *** wash has joined #chromium [06:22:33] <trungl> cpu: purple is so much harder to accomplish [06:22:40] <cpu> trungl: I see now, the timeout thingy of tessamac [06:22:47] *** ctruta has quit IRC [06:22:49] <trungl> cpu: right [06:23:15] *** loislo has quit IRC [06:23:22] <trungl> cpu: it causes base_unittests to not exit cleanly (or the test runner to not detect that it's exited), but only on Linux x64 Release [06:23:30] <trungl> this is a bit confusing [06:24:21] *** alt-dot-net-geek has quit IRC [06:25:32] *** jrmuizel has quit IRC [06:26:44] <cpu> speaking of which the x64 official seems failed compilation [06:26:59] *** victorw has joined #chromium [06:30:11] <trungl> cpu: weird, looks like that should be an ffmpeg problem, but I don't see any change which would likely cause that [06:30:21] <trungl> cpu: so let's blame pkasting [06:30:42] <trungl> cpu: hmmm, the last three builds have failed [06:30:48] <trungl> cpu: so I guess I should be looking further [06:30:50] <cpu> that was my guess :) [06:30:56] *** hayato has quit IRC [06:31:04] *** adiumtestuser has quit IRC [06:31:09] <cpu> is fbarchard [06:31:35] <cpu> he rolled ffmpeg but mirandac error masked it [06:32:16] <cpu> fbarchard: ping [06:33:22] <trungl> cpu: yeah, looks like it [06:33:59] *** Kunalagon has joined #chromium [06:40:42] <cpu> I can't revert from home so I filed a bug (50478) [06:41:07] *** skanduk has joined #chromium [06:43:30] *** pfeldman has joined #chromium [06:46:42] *** mirandac_athome has quit IRC [06:49:15] *** Kunalagon has quit IRC [06:49:41] *** skanduk has quit IRC [06:52:54] *** tkent has quit IRC [06:53:21] <cpu> night night all [06:53:43] *** cpu has quit IRC [06:55:16] *** oshima_ has quit IRC [06:55:56] *** thakis_ has joined #chromium [06:55:56] *** ChanServ sets mode: +v thakis_ [06:56:31] *** wash has quit IRC [06:56:55] *** pathorn has quit IRC [06:57:35] *** mirandac has joined #chromium [07:03:04] *** morrita has quit IRC [07:05:48] *** morrita has joined #chromium [07:06:55] *** js2 has quit IRC [07:07:02] <thakis_> zub: test_shell is in chrome-git/src/webkit/tools/test_shell afaik [07:07:27] <thakis_> zub: (where webkit != third_party/WebKit/WebKit) [07:08:45] *** mirandac has quit IRC [07:09:39] *** michaeln has quit IRC [07:09:51] *** akalin2 has quit IRC [07:13:31] *** victorw has quit IRC [07:14:00] *** victorw has joined #chromium [07:14:17] *** victorw has quit IRC [07:15:25] *** loislo has joined #chromium [07:16:04] *** lorenzo has quit IRC [07:19:41] *** fqian has joined #chromium [07:21:00] *** ebraminio has quit IRC [07:21:23] *** ebraminio has joined #chromium [07:25:03] *** Engin has joined #chromium [07:25:17] <Engin> chrome thinks a 6-character UTF-8 string to be of .length = 7 [07:25:34] <Engin> and charCodeAt() shows aritificial characters [07:25:38] <Engin> hence string comparision fails [07:25:47] <Engin> more specifically indexOf [07:26:25] *** shoe` has quit IRC [07:29:06] *** lorenzo has joined #chromium [07:31:16] *** pfeldman has quit IRC [07:34:03] *** Guest234 has joined #chromium [07:34:31] *** Guest234 has quit IRC [07:35:01] *** tyoshino has quit IRC [07:41:58] *** pfeldman has joined #chromium [07:43:56] *** arv__ has joined #chromium [07:45:35] <jrg> trungl you there? [07:45:42] <trungl> jrg: barely? [07:45:55] <jrg> trungl: going to be "barely there" for 10min? [07:46:06] <trungl> jrg: probably, why? [07:46:35] <jrg> trungl: just landed a CL. Going to gym now. If you see trungl-bot yell please revert me. Should be fine (mac only et al) but... [07:46:57] <trungl> jrg: ok [07:47:01] <trungl> jrg: I can handle that [07:47:03] <trungl> :) [07:47:07] <jrg> thx [07:47:11] <trungl> np [07:54:32] <Engin> I taclked the problem to the toLowerCase(), that's the buggy piece [07:59:16] *** bevc_work has joined #chromium [07:59:33] *** pfeldman has quit IRC [08:00:12] *** rniwa has joined #chromium [08:03:27] *** MikeSmithW3C has joined #chromium [08:07:09] <bevc_work> Hi everyone. I'll be restarting the try master in 20 minutes. [08:07:59] *** fqian has quit IRC [08:08:26] *** fqian has joined #chromium [08:09:57] *** paul_irish has quit IRC [08:12:54] <Engin> workaround is to use toUpperCase haha [08:16:45] *** FullFlannelJacke has quit IRC [08:17:35] *** JodaZ_ has quit IRC [08:17:51] *** rniwa has quit IRC [08:18:16] *** rniwa has joined #chromium [08:27:22] *** fr has quit IRC [08:29:47] *** estes has joined #chromium [08:29:59] <bevc_work> going to restart the try master now [08:31:38] *** arv__ has quit IRC [08:32:09] *** FullFlannelJacke has joined #chromium [08:37:36] *** fr has joined #chromium [08:38:55] *** JodaZ has joined #chromium [08:44:12] *** General1337 has joined #chromium [08:47:11] *** General13372 has quit IRC [08:47:20] *** Erkan_Yilmaz_ has quit IRC [08:50:33] *** glider has joined #chromium [08:50:33] *** ChanServ sets mode: +v glider [08:52:31] *** Engin has quit IRC [08:52:58] *** Engin has joined #chromium [08:58:45] *** glider has left #chromium [08:58:55] *** glider has joined #chromium [08:58:55] *** ChanServ sets mode: +v glider [08:59:10] <glider> good morning, trungl-bot! [08:59:10] <trungl-bot> glider: Good morning! [09:01:51] *** __ed has joined #chromium [09:05:22] *** fqian has quit IRC [09:11:08] *** lnrd has joined #chromium [09:13:13] *** tittiatcoke has joined #chromium [09:16:58] *** roc has quit IRC [09:17:10] *** hbono has quit IRC [09:18:03] *** ejat has joined #chromium [09:18:03] *** ejat has joined #chromium [09:18:49] <glider> dear sherrifs, does anybody have the power to reconfig the memory master? [09:22:30] *** e-jat has joined #chromium [09:22:47] *** ejat has quit IRC [09:24:17] *** Precea is now known as Precea[BNC] [09:28:24] *** trungl has quit IRC [09:28:43] *** bevc_work has quit IRC [09:30:30] *** pdelgallego has joined #chromium [09:31:49] *** star-affinity has joined #chromium [09:36:10] *** pomaxa has quit IRC [09:45:31] *** kavita has quit IRC [09:47:04] *** yutak has quit IRC [09:48:43] *** e-jat has quit IRC [09:54:20] *** Adys has joined #chromium [09:55:51] *** yusukes has quit IRC [10:00:26] *** bmizerany has joined #chromium [10:02:20] *** pfeldman has joined #chromium [10:06:00] <zub> does V8 work on an armv4? [10:06:15] *** rniwa has quit IRC [10:12:24] *** bauerb has joined #chromium [10:12:24] *** ChanServ sets mode: +v bauerb [10:13:28] <lindi-> zub: yes (already replied on another channel) [10:15:47] *** peterdn has joined #chromium [10:16:14] *** zork has quit IRC [10:21:16] *** hrna has joined #chromium [10:22:05] <mnissler> bulach: any updates on the stuck git mirror? I still see it at the very same revision as yesterday. [10:25:00] *** bgmerrell has quit IRC [10:25:15] *** bgmerrell has joined #chromium [10:27:28] <hwennborg> mnissler: bulach isn't in yet [10:27:55] <mnissler> hwennborg: OK, I'll talk to him later then. [10:28:50] *** ph0nk has joined #chromium [10:30:54] *** hamaji has quit IRC [10:33:52] *** ROBOd has joined #chromium [10:37:59] <bulach> mnissler: just arrived... still stuck at the same version.. :( nsylvain and chase said they fixed for US and were investigating for Europe, let dig my emails and see if there's any update... [10:38:12] <bulach> oh.. and good morning chromium! :) [10:38:32] <mnissler> bulach: I've already replied on the mail thread that it doesn't work for me. [10:39:01] <bulach> cool, thanks! I guess we'll need to wait for them to wake up... :( [10:41:07] *** jeremymos has joined #chromium [10:41:07] *** ChanServ sets mode: +v jeremymos [10:42:39] *** ukai has quit IRC [10:44:01] *** satish_ has joined #chromium [10:44:01] *** ukai has joined #chromium [10:44:01] *** ChanServ sets mode: +v ukai [10:44:21] *** satish_ has quit IRC [10:44:42] *** satish_ has joined #chromium [10:46:50] <trungl-bot> Tree closed by jeremy at chromium dot org (:jeremymos): Tree is closed (XP perf is red; persistent issues status: http://bit.ly/bsyE8W) [10:55:22] <jeremymos> XP Perf is red, I'm going to start backing out patches on the blame list... [10:56:04] *** vithos has quit IRC [10:57:11] *** elmargol has left #chromium [10:59:34] *** hrna has quit IRC [11:00:39] *** satorux has quit IRC [11:11:53] *** eroman has quit IRC [11:15:32] *** MikeSmithW3C^ has joined #chromium [11:17:16] *** MikeSmithW3C has quit IRC [11:18:22] *** morrita has quit IRC [11:18:44] <jeremymos> Will be away from my computer for about an hour - feel free to reopen the tree if it goes green. [11:22:49] *** maikmerten has joined #chromium [11:26:13] *** ebraminio is now known as ebram|taajob [11:27:08] *** MikeSmithW3C^ has quit IRC [11:27:36] *** MikeSmithW3C has joined #chromium [11:29:16] *** chrisccoulson has joined #chromium [11:32:01] *** vithos has joined #chromium [11:32:36] *** bmizerany has quit IRC [11:33:21] *** romainhuet has joined #chromium [11:40:28] *** estes has quit IRC [11:40:33] *** bmizerany has joined #chromium [11:42:57] *** denysonique has quit IRC [11:44:44] *** ebram|taajob is now known as ebraminio [11:46:13] *** dpolukhin has joined #chromium [11:52:48] *** dsdeiz has joined #chromium [11:52:56] *** dsdeiz has left #chromium [11:56:58] *** khansen_ is now known as khansen [12:01:01] *** bmizerany has quit IRC [12:01:33] *** BCalvignac2 has joined #chromium [12:03:29] *** BCalvignac has quit IRC [12:11:10] *** xdgc has joined #chromium [12:22:00] *** yuzo has quit IRC [12:24:46] *** estade has quit IRC [12:25:02] *** estade has joined #chromium [12:25:02] *** ChanServ sets mode: +v estade [12:27:16] *** xdgc has quit IRC [12:35:18] <trungl-bot> Tree closed by timurrrr at chromium dot org: Tree is closed (XP perf is red; Memory waterfall/UI is red; persistent issues status: http://bit.ly/bsyE8W) [12:35:24] <jorlow> jeremymos: didn't go green :-( [12:35:47] *** homata__ has joined #chromium [12:35:51] <pamg> Nope, needs more of the responsible patches reverted. (There were quite a few.) [12:37:10] *** homata_ has quit IRC [12:38:37] *** cmtx_ has joined #chromium [12:40:29] *** yuzo has joined #chromium [12:40:37] *** lnrd has quit IRC [12:43:53] <jeremymos> pamg: does the blame range look accurate to you? 53881-53885? [12:45:16] <pamg> jeremymos: Sure looks like it. [12:45:31] <jeremymos> pamg: ok, lets try the ffmpeg patch... [12:45:57] <pamg> ffmpeg or the IME would be my guesses. [12:46:17] <jeremymos> thanks pam, I'll try both... [12:47:33] <jorlow> :-) [12:47:36] <pamg> jeremymos: The IME change claims to be ChromeOS-specific, so perhaps it's less likely. [12:48:00] <jeremymos> pamg: I'll revert anyway, tree has been closed for long enough already :( [12:48:15] <jorlow> prob a good idea [12:50:27] *** yuzo has quit IRC [12:52:18] <jeremymos> ime patch doesn't revert cleanly, will see if ffmpeg does the trick... [12:55:28] *** homata__ has quit IRC [12:57:34] *** markusheintz_ has joined #chromium [13:00:45] *** Maxdamantus has joined #chromium [13:01:56] *** exxe has joined #chromium [13:16:25] *** hrna has joined #chromium [13:24:09] *** davirtavares has joined #chromium [13:30:31] *** zub has quit IRC [13:30:34] *** zub has joined #chromium [13:32:15] *** leeight has joined #chromium [13:32:18] *** leeight has left #chromium [13:35:02] <jeremymos> ok, looks like the ffmpeg patch was the culprit, I'll just wait for a couple more bots to go treen, then I'll reopen the tree... [13:35:50] * jorlow prepares his webkit roll for submission :-) [13:36:44] *** pdelgallego has quit IRC [13:39:54] *** dr_win has quit IRC [13:44:11] *** pdelgallego has joined #chromium [13:44:53] *** ejat has joined #chromium [13:46:01] *** thomasvl has joined #chromium [13:46:01] *** ChanServ sets mode: +v thomasvl [13:46:10] <jeremymos> and we're open again, wheee.... [13:46:23] <jeremymos> please hold off on patches for one more minute... [13:46:32] <jeremymos> just rolling back a patch I needlessly reverted.... [13:46:59] <trungl-bot> Tree opened by jeremy at chromium dot org (:jeremymos): Tree is open ( Memory waterfall is red - needs supression; persistent issues status: http://bit.ly/bsyE8W) [13:49:15] <jeremymos> jorlow: go ahead, I'm done... [13:49:24] <jorlow> jeremymos: oh..ha..already did [13:49:31] <jeremymos> np [13:49:33] <jorlow> (thought the opening was the green light) [13:49:48] *** lorenzo has quit IRC [13:53:19] *** dr_win has joined #chromium [13:56:11] <trungl-bot> Tree opened by timurrrr at chromium dot org: Tree is open (persistent issues status: http://bit.ly/bsyE8W) [13:57:43] *** dr_win has quit IRC [13:57:52] *** path[l] has joined #chromium [13:58:01] *** lorenzo has joined #chromium [14:02:16] *** aroben has joined #chromium [14:02:16] *** aroben has joined #chromium [14:03:53] *** dr_win has joined #chromium [14:06:57] *** lorenzo_ has joined #chromium [14:07:42] *** lorenzo has quit IRC [14:09:43] *** andrix has joined #chromium [14:21:28] *** Aferlak12 has joined #chromium [14:32:59] *** davirtavares has quit IRC [14:39:25] *** FullFlannelJacke has quit IRC [14:40:06] *** FullFlannelJacke has joined #chromium [14:42:43] *** xdgc has joined #chromium [14:48:39] *** pinkerton has joined #chromium [14:48:39] *** ChanServ sets mode: +v pinkerton [14:49:06] *** rubenbb has quit IRC [14:49:24] *** davirtavares has joined #chromium [14:51:22] <xdgc> Hi. An extension development question: I'm having difficulties understanding how chrome.extensions.sendRequest works. I can make a request but the data is not immediately available after the request. Is this some kind of threading? Code and console output: http://pastebin.ca/1910093 [14:51:26] *** RT|Chatzilla has quit IRC [14:52:39] *** RT|Chatzilla has joined #chromium [14:56:04] *** yutak_home has joined #chromium [14:56:04] *** ChanServ sets mode: +v yutak_home [14:58:01] *** Emperorlou has joined #chromium [15:00:34] *** yutak_home has quit IRC [15:01:04] *** path[l] has quit IRC [15:01:08] *** e-jat has joined #chromium [15:01:08] *** e-jat has joined #chromium [15:01:11] *** path[l] has joined #chromium [15:01:45] *** yutak_home has joined #chromium [15:01:45] *** ChanServ sets mode: +v yutak_home [15:02:06] *** ejat has quit IRC [15:03:51] *** leeight has joined #chromium [15:03:55] *** leeight has left #chromium [15:04:31] *** n00p has quit IRC [15:07:35] <thomasvl> xdgc: it's a bit early for most of the extension folks, try the extension mailing list (and archives) for info [15:08:52] <xdgc> thomasvl: thanks. googling helps, actually. sendRequest is asynchronous... [15:09:15] *** zloidemon has joined #chromium [15:09:27] *** n00p has joined #chromium [15:11:53] *** rubenbb has joined #chromium [15:13:25] *** maikmerten has quit IRC [15:22:32] *** aroben is now known as aroben|breakfast [15:22:41] *** kjg has joined #chromium [15:26:21] *** e-jat has quit IRC [15:27:59] *** d0k has joined #chromium [15:28:17] *** xdgc has quit IRC [15:28:42] *** Martijnc has quit IRC [15:29:12] *** malavv has quit IRC [15:29:18] *** malavv has joined #chromium [15:29:24] *** tonikitoo| has joined #chromium [15:29:52] *** ejat has joined #chromium [15:31:57] *** kjg has quit IRC [15:32:42] *** Martijnc has joined #chromium [15:35:52] *** awolfson has joined #chromium [15:39:11] *** kjg has joined #chromium [15:39:18] *** [Nef] has joined #chromium [15:44:30] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 53935: jorlow at chromium dot org) [15:44:43] <jorlow> should just be a clobber [15:46:23] <jorlow> clobbered webkit and chromium builder dbg [15:47:44] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (windows needed clobber -> jorlow; persistent issues status: http://bit.ly/bsyE8W) [15:49:27] <jorlow> and just did releases as well [15:49:32] <jorlow> that should fix it [15:49:41] <jorlow> i had to clobber the canaries as well, and now they're good [15:52:57] *** whesse has quit IRC [15:53:40] *** Precea[BNC] is now known as Precea [15:56:32] *** yutak_home has quit IRC [15:56:53] *** path[l]_ has joined #chromium [15:59:02] *** BUGabundo_remote has joined #chromium [15:59:13] *** path[l] has quit IRC [15:59:14] *** path[l]_ is now known as path[l] [15:59:28] <BUGabundo_remote> good after noon [15:59:49] <BUGabundo_remote> latest build in launchpad PPA won't even start on a clean profile [15:59:50] <BUGabundo_remote> http://code.google.com/p/chromium/issues/detail?id=50517 [16:00:00] <BUGabundo_remote> let me know if you guys need further data [16:00:06] <BUGabundo_remote> thanks in advance [16:04:24] *** tonikitoo| is now known as tonikitoo [16:04:51] *** dmaclach has joined #chromium [16:05:54] *** dmaclach has quit IRC [16:06:11] *** Aria has quit IRC [16:06:37] *** EnginA has joined #chromium [16:09:07] <pinkerton> BUGabundo_remote: um, how about...OS version? [16:09:50] *** Engin has quit IRC [16:10:05] *** General1337 has quit IRC [16:10:33] *** thakis__ has joined #chromium [16:10:33] *** ChanServ sets mode: +v thakis__ [16:13:24] *** loislo has quit IRC [16:14:04] *** lucapost has joined #chromium [16:14:29] *** jrforbes_ has joined #chromium [16:14:33] *** thakis_ has quit IRC [16:15:24] *** loislo has joined #chromium [16:15:52] <lucapost> hi all, I have a problem with chromium. Always, when I restart my browser authenticated sessions are lost! [16:16:16] *** lucapost has quit IRC [16:17:08] *** tfarina has joined #chromium [16:18:18] *** paul_irish has joined #chromium [16:19:02] <BUGabundo_remote> pinkerton: I knew I had forgoten something [16:19:17] <BUGabundo_remote> debian unstables 64bits [16:19:26] <BUGabundo_remote> it usually gets that from the past from About [16:19:30] <BUGabundo_remote> but since it doesn't open [16:20:22] *** rsesek has joined #chromium [16:20:22] *** ChanServ sets mode: +v rsesek [16:23:22] *** dhollowa_ has joined #chromium [16:25:05] *** lucapost has joined #chromium [16:25:54] <pinkerton> BUGabundo_remote: don't tell me, put it in the bug [16:27:51] *** path[l] has quit IRC [16:28:14] *** dhollowa_ has quit IRC [16:28:48] <satish_> I'm having an issue testing a GRD addition. Try server fails to build with an error that the newly added images don't exist, but they are part of the patch. Anyone interested to look at http://codereview.chromium.org/3058019 and see if I missed something? [16:28:54] *** thakis__ has quit IRC [16:29:03] *** lucapost has quit IRC [16:29:42] <rsesek> satish_: the try servers don't do well with images [16:30:08] <rsesek> satish_: generally, if you want to test your CL and it requires images, land the resources in a separate CL, wait for LKGR to roll past that, and then run your CL through the trybots [16:30:35] <satish_> rsesek: I'll do that, thanks! [16:30:35] *** dhollowa_ has joined #chromium [16:30:59] *** path[l] has joined #chromium [16:32:05] <pinkerton> rsesek: i've never had that problem [16:32:17] <rsesek> pinkerton: really? I definitely have [16:32:21] <pinkerton> weird [16:32:31] <satish_> pinkerton: could you have a look at the url above and see if I really missed something? [16:33:56] <pinkerton> there's nothing in the faq about images [16:34:42] <pinkerton> http://dev.chromium.org/developers/try-server-usage [16:34:53] <pinkerton> if there really is a problem, someone should update it [16:37:45] *** Aferlak12 has quit IRC [16:37:58] *** star-affinity has quit IRC [16:38:02] *** Aferlak12 has joined #chromium [16:38:06] *** mrossetti has joined #chromium [16:38:14] *** star-affinity has joined #chromium [16:38:45] *** BUGabundo_remote has quit IRC [16:39:41] *** path[l] has quit IRC [16:39:49] <rsesek> pinkerton: cl to you (http://codereview.chromium.org/3023023) [16:40:56] *** stuartmorgan has joined #chromium [16:40:57] *** ChanServ sets mode: +v stuartmorgan [16:41:21] *** scotty has joined #chromium [16:41:33] *** scotty has left #chromium [16:42:13] <pcgod> the tryserver page has "Binary files are not supported. Text files with CRLF will have issues too." [16:42:26] *** n00p has quit IRC [16:42:45] *** path[l] has joined #chromium [16:43:17] <pinkerton> maybe it doesn't consider pdfs and binary [16:43:22] <pinkerton> s/and/as [16:44:18] *** tonikitoo has quit IRC [16:44:32] *** erikkay has joined #chromium [16:44:32] *** ChanServ sets mode: +v erikkay [16:44:49] *** EnginA has quit IRC [16:46:15] *** n00p has joined #chromium [16:46:49] *** jeremymos has quit IRC [16:47:14] *** Kunalagon has joined #chromium [16:47:25] *** fta has joined #chromium [16:49:23] *** star-affinity_ has joined #chromium [16:49:30] *** paul_irish_ has joined #chromium [16:50:30] *** glider has quit IRC [16:52:16] *** awidegreen has joined #chromium [16:53:19] *** mmoss has quit IRC [16:53:24] *** star-affinity has quit IRC [16:53:25] *** star-affinity_ is now known as star-affinity [16:53:44] <satish_> pcgod: thanks, that clarifies [16:54:37] *** n00p has quit IRC [16:56:43] *** ejat has quit IRC [16:57:55] *** n00p has joined #chromium [16:58:31] *** loislo has quit IRC [16:58:53] *** loislo has joined #chromium [17:00:34] *** tonikitoo| has joined #chromium [17:00:36] *** tittiatcoke has quit IRC [17:01:31] *** path[l] has quit IRC [17:02:33] *** trungl has joined #chromium [17:02:33] *** ChanServ sets mode: +v trungl [17:04:19] <trungl> 'morning, Chromium. [17:04:19] <trungl-bot> trungl: Good morning! [17:04:50] <trungl> must you always be so cheerful, trungl-bot? [17:05:41] *** seventh has quit IRC [17:06:20] *** aroben|breakfast is now known as aroben [17:06:29] *** loislo has joined #chromium [17:09:36] *** loislo has quit IRC [17:10:41] *** fta_ has joined #chromium [17:10:44] <trungl-bot> Tree opened by jorlow at chromium dot org: Tree is open (persistent issues status: http://bit.ly/bsyE8W) [17:11:00] *** loislo has joined #chromium [17:11:23] *** fta has quit IRC [17:11:25] *** fta_ is now known as fta [17:11:43] *** dhollowa_ has quit IRC [17:13:48] <anicolao> the try bots keep asking me to authenticate though I have my chromium key in my ssh-agent; have I missed a step? [17:14:33] *** MikeSmithW3C^ has joined #chromium [17:17:25] *** Engin has joined #chromium [17:17:36] *** MikeSmithW3C has quit IRC [17:18:16] *** path[l] has joined #chromium [17:19:42] <dglazkov> good morning, Chromium! [17:19:42] <trungl-bot> dglazkov: Good morning! [17:20:59] *** rohitrao has joined #chromium [17:20:59] *** ChanServ sets mode: +v rohitrao [17:22:21] <rohitrao> jrg: ping [17:22:50] *** Erkan_Yilmaz has joined #chromium [17:23:37] <trungl> 'morning, dglazkov [17:25:49] *** Emperorlou has left #chromium [17:26:06] <path[l]> hi does anyone know if the contextmenu api allows me to add a contextmenu to a link only if the url the link is to matches some pattern [17:28:38] *** tonyg-cr has joined #chromium [17:28:39] *** ChanServ sets mode: +v tonyg-cr [17:31:40] <anicolao> on my authentication problem, it only seems to happen on a macbook [17:34:42] *** fta_ has joined #chromium [17:36:05] *** loislo has quit IRC [17:36:08] *** fta has quit IRC [17:36:10] *** fta_ is now known as fta [17:36:48] *** loislo has joined #chromium [17:38:18] *** paul_irish_ has quit IRC [17:39:50] <bryeung> ping: chromiumos sheriff here. I need to get a chromium commit reverted because it broke our ARM build. [17:40:36] <bryeung> I don't have commit access, but here is the issue: [17:40:39] <bryeung> http://codereview.chromium.org/2856067 [17:41:05] *** jrforbes_ has quit IRC [17:41:11] *** maikmerten has joined #chromium [17:43:20] <bryeung> playmobil/cpu/evanm: anyone there? [17:44:16] *** ejat has joined #chromium [17:44:16] *** ejat has joined #chromium [17:45:21] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Mac10.5 Tests" from 53944: avi at chromium dot org (:motownavi)) [17:45:33] <motownavi> agh [17:46:17] *** victorw has joined #chromium [17:46:17] *** ChanServ sets mode: +v victorw [17:46:20] *** ctruta has joined #chromium [17:46:24] *** paul_irish_ has joined #chromium [17:46:24] *** ChanServ sets mode: +v paul_irish_ [17:46:52] <motownavi> the change doesn't touch the findbar which that test is [17:46:59] <motownavi> suspect flake [17:47:14] *** d0k has quit IRC [17:48:16] *** trungl has quit IRC [17:48:29] *** d0k has joined #chromium [17:50:46] *** thakis_ has joined #chromium [17:50:46] *** ChanServ sets mode: +v thakis_ [17:51:12] <bryeung> ping: chromiumos sheriff looking for a committer. [17:51:26] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed (Mac10.5 unit_tests -> avi -> flake?; watching) [17:53:08] *** igneo has joined #chromium [17:53:26] <rohitrao> motownavi: which test? [17:53:47] <motownavi> Failure was FindBarTextFieldTest.Display [17:53:57] <motownavi> My change was the address bar folder windows [17:54:00] *** TabAtkin1_ has joined #chromium [17:54:00] *** ChanServ sets mode: +v TabAtkin1_ [17:54:03] <rohitrao> that might be a once-a-month flaky test :) [17:58:32] *** paul_irish has quit IRC [17:58:38] *** paul_irish_ is now known as paul_irish [17:59:08] *** paul_irish_ has joined #chromium [17:59:20] *** Adys has quit IRC [17:59:24] *** estes has joined #chromium [18:04:31] <kliegs> trungle-bot: help [18:04:35] <kliegs> trungl-bot: help [18:04:36] <trungl-bot> kliegs: The help command is "halp" (blame thakis for this). [18:04:43] <kliegs> trungl-bot: halp [18:04:44] <trungl-bot> kliegs: Valid commands (use "halp <command>" for more): bug, commit, commits, cookie, fortune, halp, help, lkgr, offices, settreestatus, time, treestatus, tweet, uptime, webkitbug, webkitcommit, webkitcommits, whois. (If you whisper to me, I'll whisper back.) [18:07:07] *** fantasticulous has joined #chromium [18:07:09] <motownavi> do we want to hold the tree closed? I need to get lunch [18:07:27] <motownavi> and while I want to see the mac test green it's going to take a while [18:07:35] <rsesek> if it passed other platforms/testers, reopen [18:07:52] *** ojn has joined #chromium [18:08:31] <motownavi> it passed 10.6 testers and debug 10.5 testers [18:08:46] *** monreal has joined #chromium [18:08:53] <motownavi> reopening then [18:09:17] *** tonyg-cr has quit IRC [18:10:37] <trungl-bot> Tree opened by avi at chromium dot org (:motownavi): Tree opened (Mac10.5 unit_test -> flake (blame avi if need be)) [18:11:48] *** anicolao has quit IRC [18:14:31] *** andybons has joined #chromium [18:14:31] *** ChanServ sets mode: +v andybons [18:15:34] *** markmentovai has joined #chromium [18:15:34] *** ChanServ sets mode: +v markmentovai [18:16:41] <trungl-bot> Tree opened by timurrrr at chromium dot org: Tree opened (memory waterfall wants your suppressions; Mac10.5 unit_test -> flake (blame avi if need be)) [18:17:17] *** tedoc2000 has joined #chromium [18:17:41] *** tedoc2000 has joined #chromium [18:19:08] *** maqr has quit IRC [18:21:55] <rohitrao> stuartmorgan: hah, I just filed a bug for the DOMUI test :) [18:22:41] *** dmaclach has joined #chromium [18:22:41] *** ChanServ sets mode: +v dmaclach [18:23:03] <dhollowa> tonyg: ping [18:24:38] *** jrmuizel has joined #chromium [18:24:43] *** fta_ has joined #chromium [18:25:24] *** earyoyo has joined #chromium [18:25:24] *** ChanServ sets mode: +v earyoyo [18:25:51] *** phajdan-jr has joined #chromium [18:25:51] *** ChanServ sets mode: +v phajdan-jr [18:26:01] *** fta has quit IRC [18:26:09] *** fta_ is now known as fta [18:26:48] *** tedoc2000 has quit IRC [18:27:53] *** vassilisl has quit IRC [18:28:02] *** estes has quit IRC [18:28:25] *** johnny_g has joined #chromium [18:28:25] *** ChanServ sets mode: +v johnny_g [18:30:02] *** trungl has joined #chromium [18:30:02] *** ChanServ sets mode: +v trungl [18:31:04] <stuartmorgan> Whoever stole Mac10.5 Perf(2), please bring it back... [18:31:47] *** tedoc2000 has joined #chromium [18:32:06] *** path[l] has quit IRC [18:33:22] <jorlow> sheriff....the commits are getting somewhat ahead of the waterfall [18:33:33] <rickcam> Does anyone have experience building Chrome on Windows running inside a VMware instance that's running on Linux? If you were picking between doing that, with a beefy Linux machine, or having a dedicated, but not so beefy Windows machine, what would you do? [18:34:03] <nsylvain> rickcam: We actually do something like that for our buildbots [18:34:21] <nsylvain> rickcam: We use vmware ESX (which is a linux-like OS from vmware) [18:35:16] <nsylvain> We can get windows VMs that are faster than other non-beefy Windows machines.. but it really depends how beefy you are talking about ;) [18:35:18] *** rdsmith has joined #chromium [18:35:18] *** ChanServ sets mode: +v rdsmith [18:35:59] <rdsmith> Just tried to drover a change into the release branch, and drover stack dumped on me. Anyone in a position to offer guidance? [18:36:09] <rickcam> nsylvain: thanks. The linux box would be a z600. I still have to find out what kind of Windows box I can get through stuff/ if do linux on the z600 [18:36:29] <nsylvain> Oh ok [18:36:31] <rickcam> but I've been warned that it will not be nearly so powerful [18:36:57] <rickcam> I was kind of thinking of getting that anyway -- try both paths and see which one wins [18:37:15] <nsylvain> So. A VM running on a z600 (running vmware esx.. if it's even possible) would be like a dell T3400 . But if you can't run ESX, then you would run vmware workstation, and I'm not sure it would be worth it anymore [18:38:28] *** TabAtkins_ has quit IRC [18:38:41] <rickcam> ok. I haven't used esx before. Not too long ago, I used to run XP in VMware on top of Slackware. It was fine as an "email OS", but not so sure about doing real builds, etc. [18:38:50] <thakis_> is gmail giving 500s for anyone else? [18:38:56] <thakis_> (in before "see topic") [18:39:17] <rickcam> Where does the ESX come into the picture? With newer VMware is there something other than the host OS and then hosted OS?? [18:40:53] *** path[l] has joined #chromium [18:41:02] *** TabAtkins_ has joined #chromium [18:41:02] *** ChanServ sets mode: +v TabAtkins_ [18:41:14] *** path[l] has quit IRC [18:41:22] *** aroben is now known as aroben|lunch [18:41:55] *** peterdn has quit IRC [18:43:32] *** cpu has joined #chromium [18:43:33] *** ChanServ sets mode: +v cpu [18:44:14] *** davirtavares has quit IRC [18:44:42] *** path[l] has joined #chromium [18:45:35] *** paul_irish has quit IRC [18:49:13] *** finnur has joined #chromium [18:49:13] *** ChanServ sets mode: +v finnur [18:51:15] <thakis_> whoa, a CL with 400 review comments: http://codereview.chromium.org/2487001 [18:52:03] *** bweinstein has joined #chromium [18:52:07] *** arv__ has joined #chromium [18:52:25] *** FullFlannelJacke has quit IRC [18:52:34] *** Venom_X has joined #chromium [18:52:36] <bulach> mnissler, bauerb, jochen, hwennborg: our git is ToT! big thanks to cmd and nsylvain! [18:52:51] <bauerb> yay, thanks! [18:52:56] *** hebz0rl has joined #chromium [18:53:01] <bulach> ops, cmp and nsylvain [18:53:04] <nsylvain> :) [18:53:33] *** RT|Chatzilla has quit IRC [18:53:44] *** xiyuan has joined #chromium [18:53:44] *** ChanServ sets mode: +v xiyuan [18:53:44] <mnissler> bulach, nsylvain: yay! great work! what was the problem? [18:53:53] *** andrix has quit IRC [18:54:09] *** andrix has joined #chromium [18:54:20] <nsylvain> The problem was that the sync crashed, and had to be restarted, and it took us a day to fix it correctly, because we (I) forgot that we swapped that backend a few weeks ago and I was trying to fix the old backend :( :( [18:54:30] *** tonyg-cr has joined #chromium [18:54:30] *** ChanServ sets mode: +v tonyg-cr [18:54:58] *** xiyuan has quit IRC [18:55:00] *** paul_irish has joined #chromium [18:55:00] *** ChanServ sets mode: +v paul_irish [18:55:06] *** xiyuan has joined #chromium [18:55:07] *** ChanServ sets mode: +v xiyuan [18:55:37] <chase> bulach: time is off on that system, so we're fixing that [18:57:36] * thakis_ kicks gmail [18:57:38] <mnissler> nsylvain: ah, so I guess there's nothing we could have done to help you out. thanks again! [18:57:48] <bulach> nsylvain, chase: many thanks for doing your magic! [18:58:05] <thakis_> gmail kicks back [19:02:55] *** evmar_afk is now known as evmar_sheriff [19:03:13] * trungl kicks thakis. [19:03:22] <trungl> oh, I guess gmail can take care of itself [19:05:14] *** fta_ has joined #chromium [19:06:40] <cpu> nickcarter: ping [19:06:51] *** rniwa has joined #chromium [19:06:51] *** ChanServ sets mode: +v rniwa [19:06:53] *** path[l] has quit IRC [19:07:18] *** fta has quit IRC [19:07:22] *** js2 has joined #chromium [19:07:23] *** fta_ is now known as fta [19:08:35] <evmar_sheriff> cpu: around? [19:08:35] *** vampirefrog has joined #chromium [19:08:43] <evmar_sheriff> cpu: i am here now, would like to discuss tree state [19:09:20] <cpu> yeah [19:09:28] <cpu> I see we are editing the same thing [19:09:35] <evmar_sheriff> ah, yes [19:09:35] *** estes has joined #chromium [19:09:35] <evmar_sheriff> ok [19:09:41] <cpu> I belive is nick CL [19:09:45] <evmar_sheriff> do we know if anyone is still looking at reliability bustage? [19:10:13] *** az has joined #chromium [19:10:18] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree opened (memory waterfall wants your suppressions) [19:10:43] <cpu> evmar_sheriff: Revision: 53871 [19:10:58] *** lorenzo_ has quit IRC [19:11:17] *** estes has quit IRC [19:11:41] <evmar_sheriff> what is that? [19:11:55] <evmar_sheriff> cpu: i don't know what you are talking about [19:12:19] *** nvictor has joined #chromium [19:12:24] <nvictor> hello chromium :) [19:12:28] <evmar_sheriff> rsesek: i would prefer to get people to fix the memory issues [19:12:35] *** ejat has quit IRC [19:12:44] <evmar_sheriff> rsesek: i have already tracked down one real memory leak that is due to a red memory bot yesterday [19:12:45] <rsesek> evmar_sheriff: I just removed the avi bit from the status; that's someone else's' doing [19:12:52] <evmar_sheriff> oh, oh [19:12:59] <nvictor> i'm not sure how to do this. but i want to disable text-shadow on every page i visit. like a user style. how do i do that. i'm using chrome :) [19:13:24] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): Tree open [continuing issues: http://bit.ly/bsyE8W] [19:13:34] <stuartmorgan> nvictor: try the support channel or forum (see topic for links) [19:13:56] <nvictor> thanks [19:13:58] *** ejat has joined #chromium [19:13:58] *** ejat has joined #chromium [19:14:04] <eglaysher> evmar_sheriff: I will partially revert my patch from yesterday due to the red. (just got in) [19:14:37] <evmar_sheriff> eglaysher: thanks, no rush [19:15:08] *** agl has joined #chromium [19:15:08] *** ChanServ sets mode: +v agl [19:17:26] *** loislo has quit IRC [19:17:44] <evmar_sheriff> cpu: ah, i see. i sent nick a patch yesterday about the leak [19:18:10] *** igneo has left #chromium [19:18:22] *** rickspencer3 has joined #chromium [19:19:13] <rsesek> rdsmith: check_perms failed your CL: net/base/cookie_monster_unittest.cc Contains executable permission [19:19:15] *** BLW has joined #chromium [19:19:26] <rdsmith> Arrggh. [19:19:37] <rdsmith> Thank you for calling that out. Ok if I just go in and fix that problem? [19:19:51] <rsesek> talk to a real sheriff. I'm just playing one on tv [19:19:52] <rsesek> :) [19:20:00] <rdsmith> :-} [19:20:18] <cpu> evmar_sheriff: nick is going to fix [19:20:46] <rdsmith> Hold one; I want to check the other failure on my submission. I may just need to revert. [19:21:57] *** Hoostine has quit IRC [19:22:44] <fbarchard> XP perf breaks on new ffmpeg binaries. Seems page cycler mosz goes up a tad with larger DLL's and we're right on the threshhold [19:23:05] *** BCalvignac has joined #chromium [19:23:20] <rohitrao> thomasvl: you think the failing download and multipart tests are due to a bot problem? http://crbug.com/50060 [19:23:34] <rdsmith> Ok, two questions: a) Is it ok if I just fix the check_perms and submit it in, and b) How should I interpret the startup test failure? The actual test failure isn't mine, but it's in a perf test, and there's some chance my change might have had perf implications. Is that test potentially tripping if something is taking "too long" and if so, how can I figure out what? [19:23:44] *** Aria has joined #chromium [19:24:04] <rsesek> cpu/evmar_sheriff: ^ [19:24:15] <victorw> any trooper around? Webkit canary linux bot is having issue: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/33536/steps/webkit_unit_tests/logs/stdio [19:24:17] <fbarchard> is anyone familiar with XP perf with advice? [19:24:36] <thomasvl> rohitrao: there were other things that got disabled that maybe should get moved to the branch also then [19:24:45] <rdsmith> rsesek: Thanks. [19:24:57] <victorw> nsylvain: could you help with webkit canary linux bot? [19:25:10] <victorw> nsylvain: any trooper around? http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/33536/steps/webkit_unit_tests/logs/stdio [19:25:11] <rohitrao> thomasvl: yeah, I was thinking about just merging those cls to the branch [19:25:15] <cpu> fbarchard: did you see the bug I created? [19:25:25] <rsesek> rdsmith: the startup_test is usually flaky. see what happens on the next run/other perf bots [19:25:26] <evmar_sheriff> rdsmith: please fix or revert the check_deps issue ASAP [19:25:45] <rdsmith> Will fix. [19:25:50] <evmar_sheriff> rdsmith: startup test, we will investigate [19:25:57] <fbarchard> cpu: yes. andrew and I looked at it. Since the tests dont really play media files, with think its the time for loading dll's went up [19:26:00] <rdsmith> evmar_sheriff: Thanks. [19:26:16] <evmar_sheriff> fbarchard: why does startup wait for media dlls to load? [19:26:17] <fbarchard> cpu: we added webm support which increased size about 30% on chromium [19:26:39] *** BLW has quit IRC [19:26:42] *** BCalvignac2 has quit IRC [19:26:50] <cpu> fbarchard: I mean your deps roll was reverted [19:27:13] <evmar_sheriff> startup tests failure appears to be that the browser crashed :( [19:27:14] <cpu> fbarchard: or you did landed again? [19:27:20] <evmar_sheriff> this thing is made of balsa wood [19:27:25] <fbarchard> cpu: I know its reverted, but I'd like to get it in [19:27:39] *** fta has quit IRC [19:28:20] <evmar_sheriff> fbarchard: why does startup wait for media dlls to load? [19:28:21] <fbarchard> cpu: crbug on perf http://code.google.com/p/chromium/issues/detail?id=50507 [19:28:33] <cpu> fbarchard: ok [19:28:38] *** ojn has left #chromium [19:28:40] <rohitrao> evmar_sheriff: I've seen 11g of balsa hold up 25kg of sand. Your metaphor may be broken :) [19:28:58] <evmar_sheriff> fbarchard: i will ask on the bug [19:29:01] <fbarchard> evmar_sheriff: as far as I know it doesnt wait. its a vm usage that fails? [19:29:18] *** fta has joined #chromium [19:29:29] <evmar_sheriff> fbarchard: sorry, crossed wires, see bug for discussion [19:30:02] <rdsmith> evmar_sheriff: Permissions fix landed. [19:30:13] <rdsmith> Is there any way to detect those automatically? git cl presubmit didn't do it for me. [19:30:21] <evmar_sheriff> rdsmith: thanks! in the future feel free to fix breakage immediately as you see it [19:30:33] <rdsmith> Sounds good; will do. [19:30:47] <evmar_sheriff> rdsmith: see the "must" in bold under http://code.google.com/p/chromium/wiki/UsingGit#Contributing [19:30:57] <evmar_sheriff> is what i would guess, not sure though [19:31:42] *** alokp has joined #chromium [19:31:42] *** ChanServ sets mode: +v alokp [19:32:17] <rohitrao> dhollowa: who owns AutoFillManagerTest.GetProfileSuggestionsEmptyValue? [19:33:23] <rdsmith> evmar_sheriff: If you're talked about the subversion properties, it's in there. But that's about CRLF, not execute permissions, so I don't think that's it. (I searched the link you gave for all instances of "must" and that's the only one I found bolded.) [19:33:37] <dhollowa> rohitrao: looking [19:33:44] <evmar_sheriff> rdsmith: not sure then, sorry [19:33:48] <rdsmith> ("It's in there" == "The sandbox I dcommitted from had that stuff.) [19:33:55] <rdsmith> Ok, no worries. I'll try to figure it out. [19:33:57] <rohitrao> dhollowa: It's crashing in official builds, not on the main waterfall [19:34:57] <dhollowa> rohitrao: do you have crash log? [19:35:04] <rohitrao> dhollowa: will IM you [19:35:09] <dhollowa> rohitrao: thx. [19:35:15] <cpu> fbarchard: I see it now, is an extra 1.6M of ram. Is that intentional? [19:35:16] *** nickcarter_ has joined #chromium [19:36:08] <evmar_sheriff> cpu: i asked this on the bug [19:36:29] <trungl> the tree is pretty far behind, should we consider closing? [19:37:58] <cpu> evmar_sheriff: it feels like a bug, it is just memory you can alloc memory in the sandbox [19:39:26] *** Vanderhuge has quit IRC [19:39:41] <trungl-bot> Tree closed by cpu at google dot com: Tree is closed (catching up | memory waterfall wants your suppressions; Mac10.5 unit_test -> flake (blame avi if need be)) [19:39:47] *** path[l] has joined #chromium [19:40:20] <cpu> although tree is closed we take valgrind supressions [19:40:59] <rsesek> cpu: the Mac 10.5 tests are fine. that should be removed [19:41:40] *** markusheintz_ has quit IRC [19:42:11] <fbarchard> cpu: 1.6 MB compared to trunk before the roll? the code is only 1 MB [19:43:10] <cpu> fbarchard: http://build.chromium.org/buildbot/perf/xp-release-dual-core/dhtml/report.html?history=150&rev=-1&graph=vm_peak_r [19:43:39] *** Vanderhuge has joined #chromium [19:44:46] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed (catching up | memory waterfall wants your suppressions) [19:44:49] <fbarchard> cpu: neat graph. I could look at the code and/or segments. My guess is ffmpeg's increased data usage. They went from dynamic allocs to statically allocated arrays.. presumably for performance [19:44:53] <mirandac_afk> is anyone else pulling and building the 472 branch? trying to do this, but having issues. [19:44:57] *** mirandac_afk is now known as mirandac [19:46:25] *** shepazu has quit IRC [19:47:01] <phajdan-jr> mirandac: there was some post just a while ago on chromium-dev about 472, not sure if it's helpful [19:47:12] *** Aria has quit IRC [19:49:01] <mirandac> phajdan-jr: thanks, I see it -- for git not svn, but may be helpful, thanks! [19:50:06] <cpu> mirandac: what kind of issues? [19:50:38] *** pathorn has joined #chromium [19:50:38] *** ChanServ sets mode: +v pathorn [19:50:53] *** rickspencer3 has quit IRC [19:51:06] <mirandac> cpu: I have a gclient file that I think is correct, and it gets the code, but runhooks fails to build the solution, and doesn't tell me anything helpful about why. I don't know if my .gclient is wrong, or what exactly is the problem. [19:51:51] *** vampirefrog has quit IRC [19:53:04] <cpu> mirandac: ok, no clue then :) [19:53:16] <mirandac> cpu: we are on the same page :-) [19:53:33] <evmar_sheriff> we should not add suppressions, [19:53:36] <evmar_sheriff> we should revert bad changes [19:53:47] <cpu> I am all for that [19:54:01] <evmar_sheriff> eglaysher: feel free to commit your revert even though tree is closed [19:54:47] <cpu> i'll be back [19:55:07] *** maikmerten has quit IRC [19:55:18] <fbarchard> cpu: does page cycler load more than one page at a time? ffmpeg is instanced for each tab. ie if it increased 160k but opened 10 tabs, it would use 1.6 mb more [19:55:24] <eglaysher> evmar_sheriff: done [19:55:25] *** maikmerten has joined #chromium [19:56:16] *** estes has joined #chromium [19:56:21] *** shepazu has joined #chromium [19:57:06] *** ctruta_ has joined #chromium [19:57:29] *** bmizerany has joined #chromium [19:58:22] <thakis_> mirandac: you mean runhooks fails to do the gyp->msvcproj conversion? [19:58:23] *** pfeldman has quit IRC [19:58:39] <mirandac> thakis_: that's correct. [19:58:53] <thakis_> mirandac: can you paste the error somewhere? e.g. codepad.org [19:59:17] <thakis_> mirandac: btw rohitrao wants to do a branded build too, maybe you can collaborate [19:59:50] <rohitrao> I got my ToT official build to work [19:59:58] <rohitrao> but I didn't try a branch build [20:00:03] *** js2 has quit IRC [20:00:18] *** js2 has joined #chromium [20:00:21] <mirandac> rohitrao: can you send me your .gclient file? [20:00:55] <rohitrao> done [20:00:58] *** bmizerany has quit IRC [20:01:09] *** ctruta has quit IRC [20:01:54] <mirandac> thakis_: error is "No solution specified." I have the feeling I'm connecting to a part of the source tree that's not quite right. will try rohitrao's gclient file, see if that helps... [20:01:56] *** csilv has joined #chromium [20:03:02] <rohitrao> there's some magic gclient url to use if you want a branch build, but I don't know what that is or how it works [20:03:04] *** Aria has joined #chromium [20:03:17] *** maikmerten has quit IRC [20:03:32] *** hclam has joined #chromium [20:03:39] *** maikmerten has joined #chromium [20:04:06] <mirandac> rohitrao: yes, I have been trying to figure that out. I thought I had it, and the code downloads fine, but ... no solution is built. trying to get in touch with kerz or maruel. [20:04:56] *** loislo has joined #chromium [20:07:17] *** hclam_ has joined #chromium [20:07:24] *** ctruta_ has quit IRC [20:07:30] *** fsamuel has quit IRC [20:07:46] *** fsamuel has joined #chromium [20:09:02] <trungl-bot> Tree closed by evan at chromium dot org (:evmar): Tree closed [continuing issues: http://bit.ly/bsyE8W] [20:09:11] *** BUGa_grumpy has joined #chromium [20:11:04] <xiyuan> sheiffs: I have CL with GRD changes (http://codereview.chromium.org/2868067). Please let me know when it is good to submit. Thanks. [20:11:22] <phajdan-jr> xiyuan: it seems the GRD problems are gone [20:11:30] <phajdan-jr> it's just about closed tree now it seems [20:11:44] *** dave_levin has joined #chromium [20:11:59] <xiyuan> phajdan-jr: okay. So I am free to check in now when tree is open? [20:12:02] <pinkerton> yup [20:12:07] <xiyuan> cool... :) [20:13:08] <tfarina> evmar_sheriff: hum, would be good to provide an url for logs? [20:13:42] *** fta_ has joined #chromium [20:14:38] *** fta has quit IRC [20:14:40] <tfarina> evmar_sheriff: in http://bit.ly/bsyE8W. [20:14:52] *** fta_ is now known as fta [20:15:39] *** estes has quit IRC [20:20:51] *** estes has joined #chromium [20:21:11] *** estes has joined #chromium [20:21:27] *** ctruta has joined #chromium [20:21:33] * trungl should live blog his meetings. [20:23:15] <evmar_sheriff> http://build.chromium.org/buildbot/waterfall/builders/Vista%20Perf%20(dbg) [20:23:34] *** maikmerten has quit IRC [20:23:35] <evmar_sheriff> why does it take 20 minutes per run normally but is now almost to 30 minutes on the current run? [20:24:33] <BUGa_grumpy> ahh [20:24:39] <BUGa_grumpy> finally managed to get back in here [20:24:40] <BUGa_grumpy> http://code.google.com/p/chromium/issues/detail?id=50517 [20:24:48] *** bryner_ has joined #chromium [20:24:48] *** ChanServ sets mode: +v bryner_ [20:24:59] <BUGa_grumpy> tried several previous revisions [20:25:17] <BUGa_grumpy> they don't crash boot loop around the isa server [20:27:11] *** lorenzo has joined #chromium [20:28:22] <cpu> i'm back [20:28:34] *** paul_irish has quit IRC [20:28:54] *** fta_ has joined #chromium [20:29:17] *** nvictor has left #chromium [20:30:03] *** fta has quit IRC [20:30:07] *** fta_ is now known as fta [20:32:03] *** andrix has quit IRC [20:33:22] <jrg> rohitrao: pong [20:33:30] *** paul_irish has joined #chromium [20:33:31] *** ChanServ sets mode: +v paul_irish [20:33:33] <rsesek> shess: ping [20:33:42] <shess> rsesek: what's up? [20:33:59] <rsesek> shess: what's the status of http://codereview.chromium.org/3014029/show? ? it'd be nice to have in M6 and it's a relatively small change [20:34:27] <rohitrao> jrg: was going to ask you about how to build official builds, but got help from everyone else [20:34:40] <jrg> rohitrao: excellent. (delayed due to wife doc appt this morning) [20:34:52] <rohitrao> jrg: the rest of the ui_tests failures just need to be disabled on the branch (bot problems, we think) [20:34:58] <rohitrao> and we're looking at the autofill failure now [20:35:13] <shess> rsesek: am distracted by top-chrome pixel adjustments. I don't recall any reason to not check it in, I can try to get it this afternoon. [20:35:26] <markmentovai> rohitrao, mirandac: did you also figure out your "how to do a branch build" question? [20:35:31] <rsesek> shess: okay ? thanks. let me know if you'd like me to carry it over the wall [20:35:33] <jrg> rohitrao: thanks for hitting this! I feel foolish volunteering and then seeing you all race to fix it before I'm even ITO... but oh well. [20:35:48] <shess> rsesek: just keep the tree green at all times :-). [20:35:59] <rsesek> I'll try; no promises :p [20:36:00] <markmentovai> rsesek: shess meant to say "allays." [20:36:09] <markmentovai> allays i keep da tree green. [20:36:10] <rsesek> markmentovai: I automatically translate that in my head [20:36:24] <mirandac> markmentovai: I thought I had, but once again, runhooks is not building the solution. :-P [20:36:25] <alokp> I will disable pepper3d - am not sure why it failed again [20:36:35] <shess> markmentovai: is that aksing too much? [20:36:37] <markmentovai> mirandac: you want official? [20:36:47] <markmentovai> official branch or just branch? [20:36:54] <mirandac> markmentovai: I want the 472 branch for windows, that's all. [20:37:02] <mirandac> just the branch. [20:37:05] <evmar_sheriff> victorw: prototype-inheritance-2 is failing on mac bot [20:37:11] <evmar_sheriff> victorw: didn't you just fix this? [20:37:28] <markmentovai> just the branch might be tricky, because i don?t think anyone maintains the deps file that you?ll get [20:37:45] <markmentovai> the branch deps file for official builds is maintained [20:37:53] <markmentovai> and you can use it to build unofficial [20:38:00] <mirandac> I see. that would explain why I can't build it. ok, I will build official, then, that would be awesome [20:38:24] <markmentovai> mirandac: by e-mail [20:38:35] *** fta has quit IRC [20:38:44] <mirandac> markmentovai: thanks! [20:38:53] *** FoxPower has joined #chromium [20:39:04] <FoxPower> Hello [20:39:26] <evmar_sheriff> markmentovai, rsesek: http://build.chromium.org/buildbot/perf/mac-release-10.6/startup/report.html?history=150&rev=-1&graph=several_tabs [20:39:26] *** alokp_ has joined #chromium [20:39:33] <evmar_sheriff> what does that mean? why is it spiking? [20:39:46] <markmentovai> jeezaloo. dunno. [20:39:49] <evmar_sheriff> it seems the test is crashing a lot, which maybe means mac crashes on startup sometimes? [20:39:59] <thakis_> nsylvain: do you know how incredibuild works? does it preprocess on the master and then send these files out for compilation (like distcc) or does it virtualize the file system, so that an #include on the client is resolved by getting the included file from the server (w caching)? xoreax's page doesn't say, but it kinda sounds like it's the latter? [20:40:37] <FoxPower> Is chromium only for netbooks? [20:40:58] <evmar_sheriff> FoxPower: see channel topic [20:41:03] *** paul_irish has quit IRC [20:41:15] <FoxPower> Ok [20:41:27] <victorw> evmar_sheriff: no. let me check [20:42:17] <nsylvain> thakis_: my understanding is that it does file system virtualization [20:42:25] <victorw> evmar_sheriff: I haven't roll webkit yet, maybe just flaky? [20:42:49] <akalin> hooray no more grd change handling [20:43:07] <victorw> evmar_sheriff: it does not fail on webkit canary bot, so I think it is just flaky [20:43:50] <victorw> evmar_sheriff: the test I fixed is a different one [20:44:48] *** bent-mozilla has joined #chromium [20:46:58] *** paul_irish has joined #chromium [20:46:58] *** ChanServ sets mode: +v paul_irish [20:47:42] *** ctruta has quit IRC [20:47:44] *** senorblanco has joined #chromium [20:47:44] *** ChanServ sets mode: +v senorblanco [20:48:43] *** arv__ has quit IRC [20:50:46] *** bauerb has quit IRC [20:52:42] *** trungl is now known as trungl_afk2 [20:53:09] *** tfarina has quit IRC [20:53:14] *** chrisccoulson has quit IRC [20:55:10] *** tonyg-cr has quit IRC [20:56:47] *** ctruta has joined #chromium [20:57:18] *** rdsmith has quit IRC [20:57:24] *** shreyas_ has joined #chromium [20:57:30] <rohitrao> jrg: one of the autofill tests is crashy on the official builders, and we understand the problem, but we don't know what intent of the test it, so we have no immediate fix [20:57:55] <rohitrao> jrg: I think we should disable the test, because it's preventing 95% of the unit tests from running [20:58:09] <rohitrao> jrg: and when we have a fix, we can merge it back into the branch [20:58:16] <evmar_sheriff> victorw: can you take care of prototype-interhitance-2? [20:58:39] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): Tree open [continuing issues: http://bit.ly/bsyE8W] [20:59:03] <victorw> evmar_sheriff: I believe it passed on next run [21:00:14] *** estes has quit IRC [21:00:33] <evmar_sheriff> victorw: according to dashboard it never passes [21:00:41] <evmar_sheriff> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2Fprototype-inheritance-2.html [21:01:03] <evmar_sheriff> victorw: we need to mark it crashing as well [21:01:15] <evmar_sheriff> victorw: or revert the change that caused hte crash [21:01:16] <victorw> evmar_sheriff: yes. we already mark it in test_expectations. it just crashed in previous run [21:01:22] <evmar_sheriff> and file a bug, etc [21:01:44] <victorw> evmar_sheriff: sure. [21:01:56] <evmar_sheriff> thanks [21:02:34] <victorw> evmar_sheriff: did you notice it crashes on other platform? [21:02:59] *** pfeldman has joined #chromium [21:03:16] *** rdsmith has joined #chromium [21:03:16] *** ChanServ sets mode: +v rdsmith [21:03:18] <victorw> evmar_sheriff: I will check teh flkiness dashboard [21:03:21] <evmar_sheriff> victorw: according to that page, no. but i don't see why it would be specific [21:03:30] *** rdsmith has quit IRC [21:04:10] *** mrossetti has quit IRC [21:06:10] *** mrossetti has joined #chromium [21:06:30] *** FoxPower has left #chromium [21:08:32] *** chrisccoulson has joined #chromium [21:10:04] *** pfeldman_ has joined #chromium [21:10:16] *** dumi has quit IRC [21:12:14] *** FullFlannelJacke has joined #chromium [21:12:46] *** thakis__ has joined #chromium [21:12:46] *** ChanServ sets mode: +v thakis__ [21:12:54] *** pfeldman has quit IRC [21:12:54] *** pfeldman_ is now known as pfeldman [21:13:51] <satish_> evmar_sheriff: I have a grd change ready, can you let me know when to land? [21:14:12] <evmar_sheriff> satish_: i believe it's now safe to just land it [21:14:25] *** mtk has joined #chromium [21:14:32] *** Engin has quit IRC [21:14:40] <evmar_sheriff> satish_: so go for it before someone breaks the tree again [21:14:57] *** Engin has joined #chromium [21:15:01] *** thakis_ has quit IRC [21:15:01] <satish_> thanks, landed [21:17:14] *** thakis_ has joined #chromium [21:17:14] *** ChanServ sets mode: +v thakis_ [21:19:09] *** thakis__ has quit IRC [21:19:24] <jrg> rohitrao: do it (e.g. disable for now), but cc dhollowa and jhawkins on bug for follow-up [21:19:27] <jrg> mark bug p1 [21:19:44] <rohitrao> jrg: will do, waiting on try runs [21:20:05] *** Adys has joined #chromium [21:20:27] <rohitrao> jrg: and then the rest of the ui_tests failures were for tests that are already disabled on trunk (we think bot problems) [21:20:50] <thakis_> rsesek, pinkerton: is it worth switching to a different branch that requires 15 min of recompilation, or will i get a new set of comments within 20 min or so? [21:20:51] <jrg> rohitrao: interesting. You are disabling on that bot, yes? [21:20:57] <evmar_sheriff> jrg: i am doing my best to fix the memory bots but i think it is a losing battle. i am sorry [21:21:12] <pinkerton> thakis_: i dont follow [21:21:16] <jrg> evmar_sheriff: no need to be sorry [21:21:27] <evmar_sheriff> it turns out they really are finding leaks all the time [21:21:33] <evmar_sheriff> i really worry about the number of suppressions we have [21:21:34] <jrg> evmar_sheriff: yep. we suck. [21:21:36] <rohitrao> jrg: for the autofill tests, I'm wrapping everything in #if !defined(GOOGLE_CHROME_BUILD) [21:21:43] <thakis_> pinkerton: for my tabpose CL, will i get a new set of comments within 20 minutes? [21:21:47] <pinkerton> no [21:21:56] <thakis_> ok, thanks :-) [21:22:00] <rohitrao> jrg: for the ui_tests, I think we should just merge over the CLs that disabled them. thomasvl, do you agree? [21:22:08] *** thomasvl has quit IRC [21:22:25] <jrg> evmar_sheriff: I've got a thing this afternoon but can help with this tomorrow. Is there something you need specifically other than aggressive behavior? [21:22:26] *** aroben|lunch is now known as aroben [21:22:44] <evmar_sheriff> i need the cycle time to be faster ;) [21:23:06] *** estes has joined #chromium [21:23:12] <evmar_sheriff> i realized i should be looking at the memory bots console rather than the summary at the top, because lots of these issues are fixed but we're waiting for cycle [21:23:15] <evmar_sheriff> ack, lunch time [21:23:17] *** evmar_sheriff is now known as evmar_afk [21:23:21] <evmar_afk> cpu: don't be afraid to close [21:25:31] *** jamesr has joined #chromium [21:25:31] *** ChanServ sets mode: +v jamesr [21:26:31] <jrg> evmar_afk / evmar_sheriff: we have a volunteer memory sheriff; perhaps we need a dedicated one. [21:28:11] <rsesek> thakis: I don't have any major comments; you can probably switch [21:28:17] *** Zaba has quit IRC [21:29:12] *** tonyg-cr has joined #chromium [21:29:12] *** ChanServ sets mode: +v tonyg-cr [21:29:20] *** maikmerten has joined #chromium [21:29:43] <nickcarter_> evmar: I just committed a fix that should fix almost all of the sync suppressions [21:31:09] *** peterdn has joined #chromium [21:31:38] <jhawkins> rohitrao: what's the AF test problem? [21:31:58] <rohitrao> jhawkins: give me one minute, I'll cc you on the bug [21:32:58] *** tom__ has joined #chromium [21:33:15] *** kjg has quit IRC [21:33:36] *** kjg has joined #chromium [21:34:32] <rohitrao> jhawkins: http://crbug.com/50537 , but I'm not sure if my explanation makes sense :) [21:34:33] *** tom__ has quit IRC [21:34:37] *** Engin has quit IRC [21:35:00] <rohitrao> jhawkins: I know why the test is crashing, but I don't understand what it's trying to do [21:35:39] <jhawkins> rohitrao: why are you disabling all AutoFillManagerTest's? [21:35:53] <jhawkins> are they all trying to hit the server on branded builds? [21:35:56] <rohitrao> jhawkins: they're all crashing in branded builds. I haven't submitted anything yet [21:36:30] <jhawkins> rohitrao: this is George Y's code, and he's out on vacation. are you disabling them on the branch only? [21:36:39] *** Zaba has joined #chromium [21:36:40] <rohitrao> jhawkins: because |request_url| doesn't match DISABLED_REQUEST_URL, we continue through to the URLFetcher code, which crashes [21:36:59] *** mtk has quit IRC [21:37:06] <rohitrao> I'm not entirely sure what to do. I have a CL to disable them only in branded builds [21:37:19] <rohitrao> they run so early in unit_tests that we crash before running 95% of the tests [21:37:24] <jrg> rohitrao: I'm doing branded / release build now. Getting ffmpeg errors. Did you get this as well? [21:37:34] <rohitrao> so disabling seems less bad than what we have now [21:37:47] <rohitrao> jrg: no, did you check out src-internal too? [21:37:53] <jrg> rohitrao: yes [21:37:57] <rohitrao> huh [21:38:05] <jrg> will try clean [21:38:09] <rohitrao> I'm doing a branded/debug build, but that shouldn't make too much of a difference? [21:38:37] <rohitrao> jrg: oh, thomasvl said you needed to do a clean build after running the GYP_DEFINES gclient sync [21:38:39] *** cpu has quit IRC [21:38:48] <markmentovai> lies [21:38:57] <rohitrao> sad [21:38:57] <jrg> rohitrao: will nuke/pave [21:39:08] <markmentovai> but because we suck, it'll rebuild EVERYTHING anyway [21:39:11] <markmentovai> so you might as well nuke [21:39:32] *** pomaxa has joined #chromium [21:39:46] <jrg> yeop [21:40:05] <jrg> markmentovai: what I meant was 'rm -rf' instead of an xcodebuild clean [21:40:13] <markmentovai> yeah, gotcha [21:40:29] <markmentovai> neither is necessary, but it'll rebuild the world after you change officialness anyway, so you might as well help it along by rm -rf [21:41:04] <fbarchard> jrg: what are your ffmpeg build errors? [21:41:44] <jrg> fbarchard: starts with Config.h: no such file, then a bunch of likely related stuff e.fg .CONFIG_H263_BLAH: unceclared [21:42:07] <jrg> fbarchard: don't know why Config.h not generated [21:42:13] <csilv> is there a short url for codereview? ala crbug.com, crrev.com [21:42:23] *** xiyuan has left #chromium [21:43:04] <fbarchard> jrg: its either your config or a mismatch between your src and deps. what cpu/platform? [21:43:12] *** Aria has quit IRC [21:43:20] <bryeung> can anyone tell me how http://chromium-status.appspot.com/lkgr gets updated? [21:43:45] <jrg> osx/10.6 [21:44:07] <rsesek> bryeung: it's documented on dev.chromium.org ? a series of builders and testers needs to go green in order for it to be updated; you can see the exact list in the buildbot source code (the exact file is qualified on that docs page) [21:44:09] <markmentovai> when "important" main waterfall builders are green on "important" steps at a certain revision, it's the lkgr. [21:44:14] <fbarchard> jrg: 32 bit? [21:44:18] <jrg> yep [21:44:22] <jrg> I did nothing funny [21:44:30] *** bent-mozilla has quit IRC [21:44:51] <bryeung> thanks [21:45:12] <bryeung> chromiumos needs it to roll past 53949 before the arm builds will roll green over there... [21:45:22] *** thakis__ has joined #chromium [21:45:22] *** ChanServ sets mode: +v thakis__ [21:45:43] <fbarchard> jrg: you should have the file src\third_party\ffmpeg\config\Chrome\mac\ia32\config.h (with / instead) [21:46:13] *** phajdan-jr is now known as phajdan-jr|afk [21:46:32] <jrg> I do. (running to interview so AFK but please email ideas if you have some). [21:47:56] *** thakis_ has quit IRC [21:47:58] <thakis__> jrg never does anything funny. software is serious business [21:48:21] <jrg> thakis: I admit I am not funny. [21:48:23] *** vampirefrog has joined #chromium [21:48:37] *** bent-mozilla has joined #chromium [21:48:50] *** vampirefrog has quit IRC [21:49:05] *** fantasticulous has quit IRC [21:49:16] *** fantasticulous has joined #chromium [21:49:39] *** dpolukhin has quit IRC [21:52:30] *** ebraminio1 has joined #chromium [21:54:21] *** tonikitoo| has quit IRC [21:54:26] *** cpu has joined #chromium [21:54:26] *** ChanServ sets mode: +v cpu [21:55:28] <rohitrao> jrg: do you have a preference between #ifdef'ing out all the tests and using the MAYBE_ syntax? [21:55:37] *** lorenzo has quit IRC [21:55:39] <rohitrao> jrg: I prefer MAYBE_, but there are like 20 tests [21:56:15] *** ebraminio has quit IRC [21:56:28] *** brainproxy has quit IRC [21:57:26] *** tonikitoo| has joined #chromium [22:00:45] *** anicolao has joined #chromium [22:02:00] *** Erkan_Yilmaz_ has joined #chromium [22:02:17] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules XP (dbg)" from 54002: estade at chromium dot org) [22:04:03] <cpu> estade: ping [22:04:09] <estade> cpu: hello [22:04:17] <estade> oh, looking [22:04:34] *** zloidemon has quit IRC [22:05:17] *** Erkan_Yilmaz has quit IRC [22:05:51] <estade> cpu: ah, i really don't think that's me [22:05:56] <estade> crash in net / spdy code [22:06:20] *** rdsmith has joined #chromium [22:06:20] *** ChanServ sets mode: +v rdsmith [22:06:50] <cpu> estade: I see looks flaky [22:07:26] <estade> cpu: do you see it crashing earlier in the logs as well? [22:07:34] <estade> perhaps a spdy person should be notified [22:07:51] <cpu> estade: i'll do that [22:08:38] <evmar_afk> i have seen this crash before [22:08:40] <evmar_afk> [32268:125992:0728/123353:391400844:FATAL:time_win.cc(341)] Check failed: now - ReliableNow() - skew_ < kMaxTimeDrift. [22:08:45] <evmar_afk> it's something about hte clock getting off [22:08:56] *** evmar_afk is now known as evmar [22:08:59] *** evmar is now known as evmar_sheriff [22:09:16] <cpu> I will open in a sec [22:09:40] <cpu> the net failure is just flake [22:09:54] *** loislo has quit IRC [22:10:04] *** brainproxy has joined #chromium [22:10:05] *** TabAtkin1_ has quit IRC [22:10:09] *** tsdh has joined #chromium [22:10:21] <pkasting> The windows trybots aren't compiling due to a WebCore link error [22:10:23] <trungl-bot> Tree opened by cpu at google dot com: Tree open [continuing issues: http://bit.ly/bsyE8W] [22:10:27] <pkasting> And maruel is out this week [22:10:34] <pkasting> Does anyone else know much about them? [22:10:38] <pkasting> Maybe LKGR is bad? [22:11:07] <cpu> pkasting: poke nicolas [22:11:42] <evmar_sheriff> cpu: opened bug on SPDY crash http://code.google.com/p/chromium/issues/detail?id=50556 [22:12:22] <pkasting> nsylvain: Poke, as per cpu ^^^ [22:12:25] <cpu> evmar_sheriff: neat [22:12:52] *** TabAtkins_ has quit IRC [22:12:56] *** TabAtkins_ has joined #chromium [22:12:56] *** ChanServ sets mode: +v TabAtkins_ [22:13:09] <victorw> pkasting: clobber should fix teh try bot. I saw the same issue in windows multi dll build, and clobber makes it go away [22:14:35] <tsdh> Hi. I use chromium (the daily snapshots) on Linux. When starting it the first time it takes ages till the startup page with the images of the most visited pages is there. [22:14:41] <tsdh> What might be the reason? [22:14:55] <evmar_sheriff> tsdh: where do you get the daily snapshots from? [22:18:06] *** ph0nk has quit IRC [22:18:11] *** trungl_afk2 is now known as trungl [22:18:27] *** ph0nk has joined #chromium [22:18:51] * cpu notes that since he last patrolled the tree, the commit rate feels twice as fast [22:20:25] <victorw> fsamuel: hi [22:20:41] <fsamuel> victorw: hi [22:20:42] <victorw> fsamuel: looks like your change breaks test_expectation [22:20:55] <tsdh> evmar_sheriff: Gentoo ebuild that fetches from http://build.chromium.org/buildbot/snapshots/chromium-rel-linux64/<build-no>/chrome-linux.zip [22:21:00] <victorw> I think it is because of dup entries in the file [22:21:49] <victorw> fsamuel: Line:3131 Duplicate expectation. /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/LayoutTests/tables/mozilla/other/slashlogo.html [22:22:07] <victorw> fsamuel: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/33553/steps/webkit_tests/logs/stdio [22:22:48] <evmar_sheriff> tsdh: hm, probably a bug. if you're a programmer we'd welcome your help tracking it down [22:22:53] <evmar_sheriff> $ git fetch [22:22:53] <evmar_sheriff> error: The requested URL returned error: 502 (curl_result = 22, http_code = 502, sha1 = e6052261b75986650948d7a76d69ca228e1dc1e2) [22:22:57] <evmar_sheriff> fffffuuuuuuuu [22:23:34] <fsamuel> hmm, that's odd [22:23:40] <fsamuel> ok [22:23:41] <fsamuel> I see [22:23:54] <fsamuel> the slashlogo.html = FAIL needs to be deleted [22:24:13] <victorw> fsamuel: yes [22:25:20] <cpu> evmar_sheriff: proxy issues? [22:26:22] <fsamuel> victorw: do you have commit access to webkit? Might be easier for you to delete it. Sorry about that. [22:26:36] *** Kunalagon has quit IRC [22:26:39] <victorw> fsamuel: I will do it [22:27:35] *** Kunalagon has joined #chromium [22:27:45] <ananta> evmar_sheriff: please ignore chrome frame ie8 redness. I just restarted the builder. [22:28:04] <tsdh> evmar_sheriff: Well, if there's some description of how to provide the info you need, I'm happy to do that as soon as I find some spare time. [22:28:33] *** rdsmith has quit IRC [22:28:47] <fsamuel> victorw: it's odd how that happened without any merge complaints. Sorry about that, again. [22:30:30] <victorw> fsamuel: np. [22:30:42] *** rdsmith has joined #chromium [22:30:42] *** ChanServ sets mode: +v rdsmith [22:30:57] *** Kunalagon has quit IRC [22:30:59] <victorw> fsamuel: they are in different lines. so merge won't complain in this case [22:31:55] <tsdh> evmar_sheriff: Hm, by deleting .cache/chromium/ it seems to be fast again... [22:31:59] *** tsdh has quit IRC [22:32:05] *** rdsmith has quit IRC [22:32:37] *** shreyas_ has quit IRC [22:34:27] *** fta has joined #chromium [22:35:37] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "test_shell_tests" on "Webkit Linux" from 54011: alyssad at chromium dot org, ben at chromium dot org, brettw at chromium dot org, stoyan at chromium dot org) [22:35:51] <thakis__> gclient should support runhoooks [22:36:01] <thakis__> or at least have spellchecking support for commands [22:36:37] <jamesr> fsamuel: how many webkit patches do you have? [22:37:14] <fsamuel> I don't know, I have maybe 4 in, plus several iterating currently [22:37:22] <fsamuel> submitted but not landed yet [22:37:33] <fsamuel> going through multiple iterations [22:37:39] <victorw> fsamuel: fix landed [22:38:08] <fsamuel> victorw: Thanks [22:38:28] *** brettw has joined #chromium [22:38:28] *** ChanServ sets mode: +v brettw [22:38:28] <fsamuel> jamesr: Still tweaking my workflow...I will now remember to rerun layout tests after merge :) [22:38:45] <fsamuel> oops [22:38:56] <fsamuel> that was supposed to be directed at victorw too [22:39:53] <evmar_sheriff> build breakage? that's unpossible! [22:40:13] <brettw> evmar_sheriff, looks like a bot problem, it says there was a failure creating a temp dir [22:40:31] <victorw> evmar_sheriff: I saw the simular issue on webkit canary linux bot, nsylvain reboot and fix the issue for me [22:41:33] *** isherman has quit IRC [22:41:37] *** satish_ has quit IRC [22:44:15] *** Engin has joined #chromium [22:44:56] *** alt-dot-net-geek has joined #chromium [22:47:09] <senorblanco> thakis__: you could set up a .completions file for gclient [22:47:58] <evmar_sheriff> nsylvain: ^^^ [22:48:05] *** pfeldman_ has joined #chromium [22:49:07] <senorblanco> er, well I guess .completions is me-specific. "You could use user-defined completions for gclient." There. [22:50:40] <thakis__> i could? how? [22:50:47] <trungl-bot> Tree opened by evan at chromium dot org (:evmar): Tree open [continuing issues: http://bit.ly/bsyE8W] [22:50:50] *** bandu has quit IRC [22:50:55] <evmar_sheriff> opening, in the hope the bot error is transient [22:51:34] *** pfeldman has quit IRC [22:51:35] *** pfeldman_ is now known as pfeldman [22:51:51] *** rsimha has joined #chromium [22:51:52] <evmar_sheriff> brettw: http://codereview.chromium.org/3067013 [22:52:07] <evmar_sheriff> thakis__: ^^ [22:52:26] *** fta_ has joined #chromium [22:52:58] *** loislo has joined #chromium [22:53:05] <brettw> evmar_sheriff, you want me to review? [22:53:15] <evmar_sheriff> brettw: yes [22:53:26] <evmar_sheriff> it's related to the failure your change triggered, kind of obvious [22:53:29] <brettw> evmar_sheriff, done [22:53:56] <senorblanco> thakis__: man tcsh, look for the "complete" builtin [22:54:03] <senorblanco> (assuming you use tcsh) [22:54:03] *** maikmerten has quit IRC [22:54:07] *** isherman has joined #chromium [22:54:07] *** ChanServ sets mode: +v isherman [22:54:15] *** fta has quit IRC [22:54:24] *** fta_ is now known as fta [22:57:08] *** pfeldman_ has joined #chromium [22:58:12] <victorw> fsamuel: early-table-layout failed on webkit canary [22:58:26] <senorblanco> thakis__: I always have to relearn the syntax, but here's one that might work: complete gclient 'p/*/(cleanup config diff export help pack recurse revert revinfo runhooks status sync update)/' [22:58:54] <thakis__> senorblanco: thx [22:58:57] *** xiyuan has joined #chromium [22:58:58] *** ChanServ sets mode: +v xiyuan [22:59:06] <victorw> fsamuel: there is no expectation [22:59:18] <fsamuel> victorw, jamesr: Yup, going to rebaseline using the rebaseline tool [22:59:33] <fsamuel> victorw, jamesr: I expected that [22:59:36] <victorw> fsamuel: ok. [22:59:51] <victorw> fsamuel: I see [23:00:09] <fsamuel> victorw, jamesr: I just have to figure out how to use it properly, and if I can submit the new baselines :P [23:00:12] *** rohitrao has quit IRC [23:00:27] *** pfeldman has quit IRC [23:00:28] *** pfeldman_ is now known as pfeldman [23:01:21] <victorw> fsamuel: think you should mark it in test_expectation so webkit test won't be red [23:02:05] *** rohitrao has joined #chromium [23:02:05] *** ChanServ sets mode: +v rohitrao [23:02:26] <fsamuel> victorw: Sorry, still trying to figure out the correct workflow for all this...so I should mark any platform that I don't have a layout expectation for as FAIL? [23:02:31] <jamesr> fsamuel: can you verify that the results here: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=fast%2Ftable%2Fearly-table-layout.html are all valid? [23:02:33] <fsamuel> in the expectation file? [23:02:53] *** ROBOd has quit IRC [23:03:08] *** awidegreen has quit IRC [23:04:35] *** loislo has quit IRC [23:04:52] <cpu> evmar_sheriff: I asked to nicolas and he rebooted that webkit bot [23:05:08] <victorw> fsamuel: I think MISSING in this case: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/32674/steps/webkit_tests/logs/stdio [23:05:11] <fsamuel> jamesr: doesn't load in firefox, currently building chrome, need 5 min [23:05:51] *** alt-dot-net-geek has quit IRC [23:08:21] *** isherman has quit IRC [23:09:48] *** cmtx_ has quit IRC [23:11:28] <victorw> fsamuel: for now, I am going to mark the test in test expectaions so the bot becomes green. and then you could add baselines. [23:12:02] <senorblanco> l8r [23:12:04] *** senorblanco has left #chromium [23:12:23] <fsamuel> victorw: ok, what do you set it as...can you set an expectation for a particular platform? [23:12:54] <fsamuel> victorw: Sorry, I want to know for future reference [23:12:58] <fsamuel> so I avoid this in the future [23:13:07] <victorw> fsamuel: yes. just add WIN MAC LINUX etc to the test expectations file [23:13:16] *** Adys has quit IRC [23:14:41] *** MikeSmithXX has joined #chromium [23:16:10] <nsylvain> cpu, evmar_sheriff: I think there is a real problem with the webkit stuff. It seems like some unit tests are deleting important files [23:16:33] <nsylvain> we had the same problem on the webkit canary earlier, and rebooting it seemed to help.. but i'm still not sure what's going on [23:16:46] *** fta_ has joined #chromium [23:16:50] <nsylvain> now it keeps doing a full checkout [23:16:57] *** Adys has joined #chromium [23:16:57] *** pfeldman has quit IRC [23:16:58] *** General1337 has joined #chromium [23:17:49] <evmar_sheriff> nsylvain: got a link? [23:17:51] *** tonikitoo| has quit IRC [23:17:53] <victorw> nsylvain: webkit canary linux seems fine after you reboot it this morning [23:17:57] *** MikeSmithW3C^ has quit IRC [23:18:05] *** fta has quit IRC [23:18:09] *** fta_ is now known as fta [23:18:19] <fsamuel> victorw, jamesr: btw, why does this page not load in firefox? [23:18:25] <rohitrao> akalin: ping [23:19:00] <jamesr> fsamuel: what firefox? [23:19:04] <pkasting> evmar_sheriff: Do you know why for a couple weeks my Windows build has been spewing "libxslt.lib(numbers.obj) : warning LNK4049: locally defined symbol _xmlIsBaseCharGroup imported" [23:19:12] <victorw> fsamuel: which one? the flakiness dashboard? [23:19:18] <pkasting> evmar_sheriff: I heard a rumor you did something with libxml symbols or something [23:19:28] <nsylvain> evmar_sheriff: this bot : http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Linux Test_shell starts fine, but fail the "delete" tests. (scary). Then webkit_unit_tests fails because there is a missing file, and webkit_tests fails because of missing files too. [23:19:29] <fsamuel> victorw: yup [23:19:40] *** hclam_ has quit IRC [23:20:03] <evmar_sheriff> pkasting: yes, what's up [23:20:09] <evmar_sheriff> pkasting: oops, misread [23:20:14] <evmar_sheriff> pkasting: i think wtc fixed that [23:20:31] <pkasting> Oh? When? I just synced this build but I didn't build clean [23:20:40] <evmar_sheriff> fsamuel: nobody ever tested it in ffox, probably some simple mistakes [23:20:40] <victorw> fsamuel: I remember this is because of some hashchange features required by the dashboard. chrome 4 does not work too [23:20:41] *** hclam has quit IRC [23:20:52] <jamesr> yeah it's something pretty dumb [23:20:55] <jamesr> no, not the hashchange [23:21:00] <jamesr> referencing document.body somewhere [23:21:14] *** estes has quit IRC [23:21:14] <jamesr> ojan: yt? [23:21:31] <victorw> jamesr: ok. I was getting the issue with loading it in chrome 4 [23:21:36] <ojan> jamesr: what's up? [23:21:48] <jamesr> ojan: do you maintain the flakiness dashboard HTML? [23:22:03] <ojan> jamesr: by some definition of "maintain" :) [23:22:06] <evmar_sheriff> nsylvain: hm, hypothesis: someone does dir = GetTempDir(); ...test code...; Delete(dir);. but when GetTempDir fails it deletes the wrong dir [23:22:12] <jamesr> flakiness_dashboard.html:315 is document.body.innerHTML = '<div id="loading-ui">LOADING...</div>';, but in firefox document.body is null at that point [23:22:20] *** anicolao has quit IRC [23:22:38] <jamesr> probably because we haven't parsed the <body> tag at that point? [23:22:47] <ojan> jamesr: meh. i have made 0 efffort to make it work in FF. it did work at first, but then i decided i didn't care. [23:22:55] <nsylvain> evmar_sheriff: it would match what we see [23:22:58] <ojan> jamesr: although, i'll certainly code review patches that make it work in FF [23:23:02] *** kurrik has quit IRC [23:23:03] <jamesr> ojan: where's it live? [23:23:24] <ojan> jamesr: http://src.chromium.org/viewvc/chrome/trunk/tools/dashboards/ [23:23:33] <fsamuel> I suppose I"ll just keep a stable build of chrome around just in these cases :P [23:23:50] <jamesr> you could install google chrome :) [23:24:17] <fsamuel> can I have chromium and chrome running at the same time? [23:24:31] *** rniwa_ has joined #chromium [23:24:31] *** ChanServ sets mode: +v rniwa_ [23:24:35] *** rniwa_ has left #chromium [23:24:51] *** Engin has quit IRC [23:25:31] <evmar_sheriff> nsylvain: http://codereview.chromium.org/3033037 [23:25:50] *** rniwa has quit IRC [23:26:09] <jamesr> yeah [23:26:14] <nsylvain> evmar_sheriff: nice! [23:26:14] <fsamuel> yay, it works :) [23:26:37] <evmar_sheriff> i grepped for EXPECT.*CreateUniqueTemp [23:26:42] *** girlhot has joined #chromium [23:26:45] <jamesr> fsamuel: they use different default user data directories [23:28:09] <pkasting> Is there some flag to ui_tests that makes it run chrome in-process [23:28:14] <pkasting> For debugging [23:28:27] <pkasting> unlike the browser tests it doesn't document having --single_process [23:30:38] <mirandac> pkasting: I usually use the flag to make it wait 60 seconds on spawning a child process, which works fine with ui tests [23:31:11] <pkasting> nm, I just attached to my crashed proc [23:31:11] <atwilson> pkasting: I think when I was last debugging I just hardcoded --single_process in the test, IIRC. [23:31:35] <victorw> fsamuel: all baselines are ready in webkit canary bots, do you want to add new baselines? [23:32:08] <fsamuel> yea, trying to figure out how to do that :) [23:32:31] <fsamuel> 100728 17:35:20 rebaseline_chromium_webkit_tests.py:869 ERROR No version of image diff was found. Check your build. [23:32:48] <victorw> fsamuel: https://trac.webkit.org/wiki/Rebaseline [23:33:00] <victorw> fsamuel: you need to build dumprendertree [23:33:08] <victorw> fsamuel: I can do this one for you [23:33:32] *** tittiatcoke has joined #chromium [23:33:59] <fsamuel> victorw: I'd prefer to fumble through it myself to learn, unless, of course, I'm blocking someone [23:34:12] *** estes has joined #chromium [23:35:00] <evmar_sheriff> nsylvain: webkit linux slave lost [23:35:04] <evmar_sheriff> nsylvain: probably deleted itself :) [23:35:08] <victorw> fsamuel: I prefer to make the bot becomes green so I can continue to roll webkit. next time, if you could update test expectations when you don;t have baseline, then it won't block [23:35:44] <fsamuel> victorw: ok, sure thanks, sorry about that [23:35:52] <victorw> fsamuel: np [23:36:03] <nsylvain> evmar_sheriff: I restarted it [23:38:14] <jamesr> i have a hanging renderer tab in my google chrome build. i wanna attach gdb to it and get symbolized traces [23:38:27] *** estes has quit IRC [23:38:30] <jamesr> where da symbols at? [23:38:36] <markmentovai> jamesr: official build? [23:38:39] <jamesr> yeah [23:38:44] <jamesr> is chrome.breakpad.ia32 what i want? [23:38:58] <markmentovai> dunno, where'd you find it? [23:39:15] *** isherman has joined #chromium [23:39:15] *** ChanServ sets mode: +v isherman [23:39:19] *** estes has joined #chromium [23:39:29] <jamesr> next to where the mac .dSYM.tar.bz2's are [23:39:50] <markmentovai> get the .breakpad file for google chrome framework [23:40:03] <markmentovai> sorry [23:40:05] <jamesr> this is linux, sorry [23:40:05] <jamesr> heh [23:40:08] <markmentovai> DOH [23:40:13] <cpu> agl: ping [23:40:14] <markmentovai> i was wrong anyway [23:40:17] <jamesr> i remember how to do this for mac [23:40:23] <jamesr> wondering what the equivalent file and gdb-foo is [23:40:45] <markmentovai> ok [23:40:50] <markmentovai> gdb can't deal with .breakpad files [23:40:51] *** phajdan-jr|afk has quit IRC [23:40:52] <markmentovai> only breakpad can [23:41:20] <markmentovai> i'd try the .zip, maybe the chrome in there has debugging symbols [23:41:25] <jamesr> trying that now [23:41:29] <evmar_sheriff> jamesr: wiki/Main/ChromeDebugging has links to symbols info [23:41:54] <thakis__> estade: ping [23:42:01] <estade> thakis__: hello [23:42:09] <jamesr> there it is! [23:42:15] <jamesr> thanks evmar_sheriff, markmentovai [23:42:17] <fsamuel> jamesr, victorw: So I'm trying rebaseline tool locally to get an idea of how to use it [23:42:20] <markmentovai> nice [23:42:25] <thakis__> estade: do you remember why the per-group sorting in the task manager is in the gtk views code instead of in the model code? [23:42:26] <fsamuel> it still complains about image diff [23:42:28] <cyberix> I read a blog post which said that chrome should have flash support these days. [23:42:29] <fsamuel> even after compiling [23:42:36] <cyberix> All my browser says is "missing plugin" [23:42:38] <fsamuel> *even after compiling dumprendertree [23:42:44] <cyberix> why? [23:42:49] <jamesr> cyberix: see /topic [23:42:53] <thakis__> cyberix: i would assume because you use linux [23:43:02] <cyberix> thakis__: Ubuntu [23:43:04] <victorw> fsamuel: build_dumprendertree should build image diff binary [23:43:31] <fsamuel> I ran WebKitTools/Scripts/build-dumprendertree --gtk [23:43:37] <jamesr> why --gtk? [23:43:51] <estade> thakis__: well I didn't write it, and no not really [23:44:00] <estade> thakis__: although i think it may be for technical reasons [23:44:06] <jamesr> the webkit gtk port has pretty much nothing to do with chromium [23:44:16] <thakis__> huh, i thought i reviewed a cl by you that added it [23:44:18] <thakis__> nvm then :-) [23:44:20] <fsamuel> which platform then? [23:44:25] <jamesr> leave it off [23:44:27] <estade> thakis__: no I think it was mhm [23:44:28] <fsamuel> how do I compile it for chromium-linux [23:44:32] <estade> i did fix it some though [23:44:37] *** fantasticulous has quit IRC [23:44:39] <fsamuel> Building not defined for this platform! [23:44:47] <estade> because it got indexes out of sync with the model [23:44:47] <jamesr> i always do this from a mac [23:45:11] <estade> but if you did it on the model side, I think you'd have to completely rebuild the table every time anything changed, which might be crap for performance [23:45:14] *** pinkerton has quit IRC [23:45:17] *** romainhuet has quit IRC [23:45:35] <estade> and besides, conceptually, the model isn't changing, only its presentation [23:46:01] <thakis__> estade: kinda sucks that every port needs to have this same sorting code though [23:46:13] <estade> domui [23:46:13] <thakis__> estade: why does this currently not run every time the model changes? [23:46:26] <fsamuel> jamesr: What argument do I pass to build-dumprendertree [23:46:27] <estade> does what not run [23:46:28] <victorw> fsamuel: I landed new baselines, please take a look: http://trac.webkit.org/changeset/64233 [23:46:41] <jamesr> fsamuel: 1.) do this on a mac 2.) don't pass any arguments to it [23:47:13] <fsamuel> jamesr: so the rebaseline tool cannot be done on linux? [23:47:14] <victorw> jamesr: fsamuel: pass -w so it grabs baselines from webkit canary [23:47:29] <thakis__> estade: "but if you did it on the model side, I think you'd have to completely rebuild the table very time anything changed" <- it needs to resort everything every time anything changes now too, no? [23:47:40] *** ebraminio has joined #chromium [23:48:00] <estade> yea it has to move crap around, but not recreate the underlying resources [23:48:14] *** isherman has quit IRC [23:48:43] <fsamuel> So there's no way to use the rebaseline tool on linux? [23:48:57] <estade> I think that the sorting is where it belongs. It's unfortunate that every port has to deal with it, but IIRC the actual comparison implemetnation is platform agnostic [23:49:21] <jamesr> i'm not sure if it's possible, but i never have used it on linux [23:49:24] <estade> and if you don't like that some code ends up being "duplicated", I'd say the best solution is to make it a domui :) [23:49:50] <thakis__> estade: domui is ugly [23:49:52] <thakis__> :-( [23:50:09] <estade> what, visually? [23:50:12] <thakis__> yeah [23:50:20] <thakis__> for some things at least [23:50:31] <estade> i dunno, the new bookmark manager seems good to me [23:50:48] <thakis__> yes, that's ok (modulo speed) [23:50:54] <thakis__> but i don't like the tabbed prefs [23:51:11] <estade> well it's not exactly done [23:51:11] <thakis__> and i don't think i'd like a tabbed taskman [23:51:25] *** lindasexihot has joined #chromium [23:51:35] <cpu> evmar_sheriff: the memory leaks in dns is now bug 50563 [23:51:40] <thakis__> it's going to be superweird that chrome does something else on chrome->prefs than every other mac app :-( [23:51:42] *** ebraminio1 has quit IRC [23:51:42] <estade> the options dialog is far from polished at the moment [23:51:43] <rohitrao> domui taskmanager seems like a bad idea :) [23:51:54] *** phajdan-jr has joined #chromium [23:51:54] *** ChanServ sets mode: +v phajdan-jr [23:51:56] <thakis__> i hope we can keep the toplevel prefs window around on mac [23:52:03] <jamesr> well i've discovered that it's hanging in sqlite at least [23:52:04] <estade> dubious [23:52:07] <jamesr> can't get a full trace [23:53:16] *** girlhot has quit IRC [23:53:47] *** aroben has quit IRC [23:54:26] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder x64" from 54032: sargrass at google dot com, stuartmorgan at chromium dot org) [23:54:27] <rohitrao> trungl: is integrated flash in 5.0? [23:55:20] <brettw> rohitrao, yes [23:57:12] *** tittiatcoke has quit IRC [23:57:23] <cpu> rohitrao: task manager in flash ftw [23:58:21] *** rniwa has joined #chromium [23:58:21] *** ChanServ sets mode: +v rniwa [23:58:26] *** arv__ has joined #chromium [23:58:33] <agl> cpu: thanks for the memory leaks email. It's just valgrind being stupid. Since I moved code around I suspect that I just avoided a previous suppression. [23:59:10] *** pdelgallego has quit IRC [23:59:19] <cpu> agl: so are u planning to update the supressions? [23:59:54] <agl> cpu: yes, looking at it now.