[00:00:10] <pinkerton> ok thanks. l8r guys.
[00:00:41] <trungl-bot> Tree closed by mmoss at chromium dot org: Tree is closed (ChromiumArm -> cycling green; Mac/Win check_deps -> cycling green; Linux extract_build -> cycling green)
[00:01:00] *** pinkerton has quit IRC
[00:02:09] *** scarybeasts has joined #chromium
[00:02:09] *** ChanServ sets mode: +v scarybeasts
[00:03:01] <awong> scarybeasts: fyi, pinkerton has left for the day.  I can help out for the next 30 mins or so.
[00:03:46] <scarybeasts> awong: yeah, just chatted
[00:03:53] <awong> scarybeasts: cool
[00:06:13] *** gsub has joined #chromium
[00:07:26] *** atwilson_ has joined #chromium
[00:07:26] *** ChanServ sets mode: +v atwilson_
[00:09:28] <scarybeasts> hmm, check deps still orange on Mac
[00:09:35] *** senorblanco has quit IRC
[00:09:48] <awong> scarybeasts: will ping hclam.
[00:10:03] <scarybeasts> awong: sat near him still? :)
[00:10:09] <hclam> i'm here :)
[00:10:18] <awong> scarybeasts: I'm staring at the top of his head...like I do mosts days :)
[00:10:23] <hclam> strange I ran it locally and it was success..
[00:10:57] <scarybeasts> Snippets.FAILS_ThaiUTF8 wut?
[00:11:51] <scarybeasts> same error as started with r53090 by the looks of it
[00:13:31] *** isherman has quit IRC
[00:13:38] <awong> scarybeasts: started at the same build....I'm not sure how r53090 could cause an issue with thai...
[00:14:16] *** fta has quit IRC
[00:14:25] *** fusion44 has quit IRC
[00:14:42] <hclam> scarybeasts: ouch I typed in the wrong path in the last commit
[00:15:19] *** awidegreen has quit IRC
[00:15:28] <scarybeasts> you think that's the cause or i should comb through other CLs in the range?
[00:15:43] <hclam> scarybeasts: I checked in the fix for check_deps
[00:16:03] *** awolfson has quit IRC
[00:16:32] <scarybeasts> thanks, let's see how that greens :)
[00:16:58] <awong> scarybeasts: re FAIL_ThaiUTF8, that seems to have been broken a long time.
[00:17:04] <hclam> I really don't know how to run checkdeps.py locally :(
[00:17:15] <hclam> whatever path I fed it, it was always success
[00:18:23] *** isherman has joined #chromium
[00:18:24] *** ChanServ sets mode: +v isherman
[00:18:34] *** exxe has quit IRC
[00:19:08] *** exxe has joined #chromium
[00:19:29] *** isherman1 has joined #chromium
[00:19:30] *** ChanServ sets mode: +v isherman1
[00:21:37] <leiz> scarybeasts: can I commit http://codereview.chromium.org/3029013/show ?
[00:21:53] *** isherman1 has quit IRC
[00:22:57] *** isherman has quit IRC
[00:23:07] *** isherman has joined #chromium
[00:23:07] *** ChanServ sets mode: +v isherman
[00:23:42] <leiz> scarybeasts: all I'm doing is shuffling valgrind suppressions around, should be perfectly safe.
[00:24:21] <scarybeasts> looking
[00:24:32] *** AaronMT has quit IRC
[00:25:57] <scarybeasts> leiz: nice, we even gained some bug id's :) yeah go ahead
[00:26:29] <leiz> thx, and off to another meeting I go
[00:26:42] <awong> scarybeasts: seems like things are pretty sedate. I'm going to stop watching the tree now.
[00:27:17] <akalin> does anyone remember who inferno at chromium dot org is?
[00:27:22] *** rohitrao has quit IRC
[00:27:25] *** isherman has quit IRC
[00:27:31] <akalin> doesn't trungl-bot have something for this
[00:27:33] <akalin> trungl-bot: halp
[00:27:33] <trungl-bot> akalin: Valid commands (use "halp <command>" for more): bug, commit, commits, cookie, fortune, halp, help, lkgr, offices, settreestatus, time, treestatus, tweet, uptime, webkitbug, webkitcommit, webkitcommits, whois. (If you whisper to me, I'll whisper back.)
[00:27:41] <akalin> trungl-bot: whois inferno
[00:27:42] <trungl-bot> akalin: It looks like inferno could be: inferno at chromium dot org / :inferno / aarya at google dot com.
[00:27:46] <akalin> aha
[00:27:54] <scarybeasts> awong: yeah Linux went green, i'll reopen if the check_deps start looking green
[00:29:10] <thakis> akalin: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
[00:29:19] <scarybeasts> yeah, that's Inferno, one of our security guys
[00:29:25] <inferno-sec> akalin: inferno is me (aarya
[00:29:30] <thakis> that works too
[00:29:49] <akalin> inferno-sec: sent you an IM!
[00:30:01] *** jcivelli has joined #chromium
[00:30:01] *** ChanServ sets mode: +v jcivelli
[00:30:29] <akalin> blargh, unit_tests is now consistently running out of address space
[00:30:40] <akalin> time to upgrade to snow leopard i guess
[00:30:54] <akalin> unless i can turn off other stuff than svg
[00:31:03] <scarybeasts> akalin: 32bit must die!
[00:31:08] <dcheng> akalin: Do it!
[00:31:09] <awong> akalin: you can turn off the linker...
[00:31:48] <akalin> awong: but i want to link unit_tests :(
[00:32:36] *** exxe has quit IRC
[00:33:14] *** isherman has joined #chromium
[00:33:15] *** ChanServ sets mode: +v isherman
[00:33:46] *** atwilson_ has quit IRC
[00:33:56] <thakis> akalin: i comment out random _unittest files from chrome_tests.gyp to build unit_tests :-P
[00:33:59] <trungl-bot> Tree closed by cevans at chromium dot org: Tree is closed (ChromiumArm -> cycling green; Mac/Win check_deps -> cycling green)
[00:34:02] <thakis> but i'll go 10.6 today i think
[00:34:04] <akalin> thakis: lol
[00:34:16] *** atwilson_ has joined #chromium
[00:34:16] *** ChanServ sets mode: +v atwilson_
[00:34:16] <akalin> i think i promised myself i'd upgrade to 10.6 once i cleared off all my M6 blockers
[00:34:24] *** monreal has quit IRC
[00:36:43] <scarybeasts> ooh i see the start of some green @hclam :D
[00:37:13] <evmar> we should split unit_tests anyway
[00:37:21] <evmar> no advantage to one huge binary
[00:39:17] <akalin> seriously
[00:39:38] *** jrmuizel has quit IRC
[00:40:31] <akalin> unit_tests[0-9]
[00:40:53] <evmar> chrome_unit_tests, browser_unit_tests, extension_unit_tests
[00:40:59] <evmar> or whatev
[00:41:09] <phajdan-jr> evmar: can we split them like fast vs slow?
[00:41:14] *** thakis has quit IRC
[00:41:35] <awong> smoke_tests, unit_tests, regression_tests?
[00:41:37] <akalin> flaky_unit_tests
[00:41:49] <evmar> phajdan-jr: then they'd all just go into "slow"  :P
[00:41:51] *** romainhuet has joined #chromium
[00:41:52] *** romainhuet has quit IRC
[00:42:21] <phajdan-jr> evmar: no, we have a lot of fast ones, seriously
[00:42:30] <phajdan-jr> akalin: unit_tests are pretty solid
[00:42:46] <awong> evmar: did you have any issues installing hte various patches for VS2008?  I keep getting "not a valid Win32 application" when running the various downloaded patch files.
[00:42:57] *** eglaysher has joined #chromium
[00:42:57] *** ChanServ sets mode: +v eglaysher
[00:43:04] <phajdan-jr> they're too good for the system
[00:43:04] <evmar> awong: haven't gotten there yet
[00:43:30] *** rsesek has quit IRC
[00:43:31] *** markmentovai has quit IRC
[00:43:44] <awong> phajdan-jr: they just sense my dislike of them.
[00:43:56] <pcgod> downloaded using dev channel chrome? ;)
[00:44:46] <awong> evmar: okay. KB967631, KB960075, KB957912 all seem to have problems.  They also all come from "Microsoft Connect" rather than "Microsoft Download Center"
[00:44:51] <awong> evmar: have fun :)
[00:44:57] <evmar> oh yeah, ther'es also the "chrome corrupts large binary downloads" bug
[00:45:15] <tony^work> splitting won't make the binary much smaller
[00:45:16] <pcgod> everything >25mb in current win dev channel
[00:45:23] <tony^work> most of the size is from the stuff we link in
[00:45:29] <evmar> tony^work: good point. :(
[00:50:13] <akalin> if only there were some way to avoid static linking...we could call it something like 'dynamic' linking
[00:50:42] <akalin> :(
[00:51:43] *** tonikitoo has joined #chromium
[00:52:18] *** homata_ has joined #chromium
[00:54:51] *** n3v3le has joined #chromium
[00:57:58] <stuartmorgan> Can the tree be re-opened now? Looks like things are greening
[00:58:15] *** michaeln has quit IRC
[00:58:28] <scarybeasts> opening. try not to land anything too risky :)
[00:59:03] <scarybeasts> open
[00:59:06] * leiz commits
[00:59:14] <trungl-bot> Tree opened by cevans at chromium dot org: Tree is open -> careful please :D
[00:59:15] *** atwilson_ has quit IRC
[00:59:37] <tony^work> looks like a good time to roll webkit :)
[01:00:23] *** pdelgallego has quit IRC
[01:04:36] <evmar> lol, i thought tony was kidding!
[01:05:12] <tony^work> the 11 commits that went in make me think it was a mistake
[01:05:16] <scarybeasts> eek me too
[01:05:37] <leiz> I think we should throttle the commits
[01:06:01] <scarybeasts> agree
[01:06:09] * evmar is leading the do-ocracy
[01:06:19] <trungl-bot> Unknown tree status set by cevans at chromium dot org: Tree is throttled -> scarybeasts on irc
[01:06:39] <awong> scarybeasts: gotta say closed...
[01:06:40] <leiz> that should say "tree is closed"
[01:06:41] <scarybeasts> oh sorry evan
[01:06:46] <eglaysher> evmar: "do-ocracy". I like that.
[01:06:55] <leiz> awong: jinx
[01:07:04] <akalin> scarybeasts: i'd like to commit http://codereview.chromium.org/2884027/show
[01:07:10] <akalin> mac trybot failed, but looks like unrelated errors
[01:07:13] <scarybeasts> akalin: looking
[01:07:19] <trungl-bot> Tree closed by cevans at chromium dot org: Tree is closed -> throttled, scarybeasts on irc
[01:08:06] <scarybeasts> akalin: can you re-run the mac try bot whilst we look at how this huge pile of commits does?
[01:08:16] <akalin> scarybeasts: i already kicked off another mac trybot run
[01:08:22] <akalin> it seems like the queue is really long?
[01:08:27] <akalin> i did that maybe half an hour ago
[01:08:36] <scarybeasts> yeah everything seems slow today
[01:09:03] <leiz> akalin: there is no queue since we turned off try by default
[01:09:53] <akalin> hmm
[01:10:23] <akalin> leiz: so mac trybot jobs should start instantly?
[01:11:13] <akalin> or maybe for some reason it's not hooked into the issue
[01:11:25] <akalin> http://build.chromium.org/buildbot/try-server/builders/mac/builds/39065 should be tied to 2884027
[01:12:27] <leiz> it might get the association when it finishes
[01:13:01] <leiz> right now it's associated with the last finished try result
[01:13:10] *** roc has quit IRC
[01:14:21] <akalin> i see
[01:14:40] <akalin> i thought it associates before it finishes?
[01:15:07] <leiz> the first try job for a given patchset
[01:15:12] <akalin> oh
[01:15:12] <akalin> hmm
[01:15:28] <leiz> At least that's how I think it works. Let it finish and reload the cl.
[01:16:57] <maruel> akalin: whatever last try job updates set the rietveld state
[01:17:00] <scarybeasts> anyone know if there's a buildbot URL param to show more revisions?
[01:17:07] <maruel> update = a step finishes
[01:17:21] <maruel> but only if the state changed (as an optimization)
[01:17:24] <maruel> so it can breaks :)
[01:18:34] <maruel> scarybeasts: see im
[01:18:49] *** sogar_gofin has quit IRC
[01:19:28] *** dumi has joined #chromium
[01:19:28] *** ChanServ sets mode: +v dumi
[01:20:15] *** awolfson has joined #chromium
[01:21:16] *** marria has joined #chromium
[01:21:16] *** ChanServ sets mode: +v marria
[01:23:27] <scarybeasts> is sargrass at google dot com around?
[01:23:56] <leiz> scarybeasts: he's here in person
[01:24:13] <leiz> scarybeasts: want me to deliver a msg?
[01:24:21] <scarybeasts> looks like there's a persistent failure in OptionsUITest.LoadOptionsByURL
[01:24:24] <scarybeasts> from a ways back
[01:24:43] <estade> scarybeasts: he's logging on
[01:25:18] <scarybeasts> http://src.chromium.org/viewvc/chrome?view=rev&revision=53070 sounds most likely
[01:27:19] <leiz> chromium xp is still unhappy
[01:27:35] <leiz> compile fail in chrome_frame_net_tests
[01:27:47] <leiz> doh, that was me
[01:27:53] *** kaasinees has joined #chromium
[01:28:00] <leiz> wtf, it passes the tryserver
[01:28:01] *** sargrass has joined #chromium
[01:28:01] *** ChanServ sets mode: +v sargrass
[01:28:10] <erikkay> getting 400s on crbug.com.  anybody else getting through?
[01:28:21] <erikkay> (only trying to submit)
[01:28:21] <csilv> scarybeasts, where are the LoadOptionsByURL failures you're referring to?
[01:28:53] *** gsub has quit IRC
[01:28:55] <sargrass> scarybeasts are you looking for me? I'm Chen.
[01:29:12] <scarybeasts> csilv: Linux Builder (Views dbg)
[01:29:17] <csilv> thx
[01:29:53] <leiz> scarybeasts: I think chromium xp had a brainfart, because chromium builder compiled correctly
[01:29:54] <scarybeasts> sargrass: hi Chen, do you think r53070 could be related to the failures in LoadOptionsByURL (Linux Builder Views dbg)?
[01:30:27] <leiz> sargrass: re: failure in r53070 - that's why I reverted that CL the first time around
[01:30:45] <leiz> that is, I reverted r52787
[01:31:21] <leiz> scarybeasts: can I commit http://codereview.chromium.org/3056006/show to kick the chromium xp builder and see if turns green?
[01:31:32] <sargrass> scarybeasts, Hi, I'm looking at that now.
[01:31:39] <csilv> leiz, the earlier issue was occurring on CrOS.  that was fixed, but clearly we'll need a fix for linux views
[01:31:46] *** dglazkov has quit IRC
[01:32:31] <leiz> csilv: no, I said linux builder views in http://codereview.chromium.org/3012007
[01:32:48] <scarybeasts> leiz: looking
[01:33:17] <scarybeasts> leiz: awesome yes
[01:33:50] <scarybeasts> ooh we got a red in Mac 10.6 ErrorPageTest.DNSError_GoBack2Forward2
[01:33:57] *** roc has joined #chromium
[01:34:00] <leiz> scarybeasts: Thx. Committed. Hopefully the bot will go green.
[01:34:32] *** apatrick_ has joined #chromium
[01:34:32] *** ChanServ sets mode: +v apatrick_
[01:35:54] <csilv> scarybeasts: fix coming...
[01:36:06] <scarybeasts> csilv: great
[01:36:13] *** nirnimesh has quit IRC
[01:36:59] *** thakis has joined #chromium
[01:36:59] *** ChanServ sets mode: +v thakis
[01:42:29] *** petriborg1 has joined #chromium
[01:42:36] <scarybeasts> oh good the DNSError_GoBack2Forward2 was just flake
[01:42:53] <akalin> scarybeasts: the mac trybot for my change finished: http://build.chromium.org/buildbot/try-server/builders/mac/builds/39065
[01:42:57] <akalin> although it still didn't update the issue
[01:43:07] <phajdan-jr> scarybeasts: it shouldn't be flaky. Can I take a look at the log? Could you paste the link here?
[01:43:17] <akalin> can i check it in?
[01:43:55] *** kierank has joined #chromium
[01:43:59] <scarybeasts> phajdan-jr: http://buildbot.jail.google.com/buildbot/chromium/builders/Mac10.6%20Tests%20(dbg)(2)/builds/6605/steps/ui_tests/logs/stdio
[01:44:08] *** kierank has left #chromium
[01:44:18] *** dmaclach has quit IRC
[01:44:25] <leiz> phajdan-jr: btw, r53026 and r53031 are for tests that were marked flaky, but actually failed.
[01:44:32] <scarybeasts> akalin: looking
[01:45:01] <leiz> phajdan-jr: I think the flaky tests dashboard should mark flaky tests in red if they've failed N times in a row.
[01:45:05] <scarybeasts> akalin: sorry, what's the original codereview url?
[01:45:39] *** dglazkov has joined #chromium
[01:45:39] *** ChanServ sets mode: +v dglazkov
[01:45:51] *** isherman has quit IRC
[01:46:15] *** shoe has quit IRC
[01:46:34] *** andybons has joined #chromium
[01:46:35] *** ChanServ sets mode: +v andybons
[01:47:31] <andybons> who should I ping about a pending change?
[01:47:42] <scarybeasts> andybons: me
[01:48:09] <andybons> scarybeasts: http://codereview.chromium.org/2834059/show - trybots were run with the most recent patch set but show on patch #1
[01:48:09] <petriborg1> Hey I'm running chrome official build r52279 on ubuntu 9.10 and 10.04, and am seeing something very strange on my banking page render wise resulting in what appears to be a large block of ? would anyone be interested in helping me on this problem?
[01:49:36] <scarybeasts> csilv: any news on that fix?
[01:49:48] <kaasinees> petriborg1, missing flash?
[01:49:56] <csilv> coming...
[01:50:01] <csilv> ls
[01:50:01] <petriborg1> nope flash is installed and working kassinees
[01:50:13] <petriborg1> i was just at hulu.com and it was working great
[01:50:30] *** nirnimesh has joined #chromium
[01:50:30] *** ChanServ sets mode: +v nirnimesh
[01:50:49] <scarybeasts> andybons: so a mac specific change and green try bots?
[01:50:53] <phajdan-jr> leiz: I was thinking about it. I think I'm going to do it.
[01:50:59] <andybons> scarybeasts: correct
[01:51:43] <scarybeasts> andybons: ok to submit if you're not running off :)
[01:52:08] <petriborg1> this blob of strange data appears to be getting inserted into the page
[01:52:20] <andybons> scarybeasts: i'll stick around to make sure things stay green :)
[01:52:20] <petriborg1> this does not happen in other browsers like firefox
[01:52:39] <petriborg1> its during the login process which is why its extra bad :(
[01:53:36] <petriborg1> i cleared the history completely, event went as far as to delete ~/.config/google-chrome and uninstall and do a fresh install from google.com and its *still* there
[01:54:13] <akalin> scarybeasts: http://codereview.chromium.org/2884027/show
[01:54:21] *** mazda has joined #chromium
[01:54:21] *** ChanServ sets mode: +v mazda
[01:55:12] *** roc has quit IRC
[01:55:50] *** bmizerany has quit IRC
[01:55:56] <petriborg1> I saved the html page to disk and looked at it in vim, and saw that the random "data" appears to be a block of &#65533;&#65533;
[01:56:33] <csilv> scarybeast, fix submitted for linux views.  r53126
[01:56:37] <leiz> scarybeasts: chromium xp hates me :(
[01:56:52] <evmar> petriborg1: wow, that's pretty weird
[01:57:02] <evmar> petriborg1: does it not happen in other browsers?
[01:57:13] <petriborg1> correct i've tried others and it doesn't happen
[01:57:22] <leiz> nsylvain: you around? any idea why this is failing? http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/13198/steps/compile/logs/stdio
[01:57:30] <leiz> maruel: ^^
[01:57:33] <evmar> man, why are our windows builders so slooooow
[01:57:36] <thakis> shess: the omnibox highlight color looks all wrong on 10.6
[01:58:02] <shess> thakis: haven't done anything to it, that I'm aware of.
[01:58:15] <thakis> maybe that's the problem? :-)
[01:58:38] <shess> do you mean text-selection, or outline around the field?
[01:58:41] *** roc has joined #chromium
[01:58:44] <petriborg1> i've got an ubuntu 9.10 and a 10.04 desktop install and they both did it (same build) I had a freshly installed laptop w/ ubuntu 10.04 installed on it so I tried that chrome and it didn't get this strange block of text
[01:58:55] <thakis> the highlight color in web contents looks terrible too
[01:59:43] <scarybeasts> csilv: thank you :D
[02:00:02] *** thakis has quit IRC
[02:00:07] <scarybeasts> akalin: ok give it a shot
[02:00:40] *** thakis has joined #chromium
[02:00:40] *** ChanServ sets mode: +v thakis
[02:01:03] <thakis> shess: nvm, had a weird color profile selected
[02:01:11] <evmar> petriborg1: oh, btw your cache is in ~/.cache/google-chrome, maybe that's it?
[02:01:24] <shess> thakis: the looks-like-ass profile?  That'll get you every time.
[02:01:30] <petriborg1> ah didn't know that - i'll try that just a sec
[02:01:49] *** dglazkov has quit IRC
[02:03:24] *** aroben has quit IRC
[02:03:43] <petriborg1> evmar - thanks for the suggestion - but it didn't solve anything - i'm starting to think that the site itself might be sending me this data - anyone have any idea how I could verify that?
[02:04:17] <jamesr> wireshark
[02:04:47] <jamesr> petriborg1: wireshark should do the trick, assuming this isn't https
[02:05:00] <jamesr> if it is that's a little trickier
[02:05:03] <petriborg1> its a bank website thats doing it, it is https :(
[02:05:14] <petriborg1> which is why i'm digging into this at all
[02:05:22] <petriborg1> its during the fucking login process :(
[02:05:56] <evmar> petriborg1: maybe poke around in about:net-internals
[02:05:57] <jamesr> petriborg1: that is weird. you can also try the build in inspector (right click -> inspect element, click on resources tab) but that may or may not be helpful
[02:06:11] <evmar> petriborg1: you can look at the cache entry there, maybe that has a clue
[02:06:22] <evmar> petriborg1: i wonder if it's chrome-specific or if it's linux-chrome-specific?
[02:06:24] <jamesr> definitely file a bug on new.crbug.com
[02:07:50] *** General1337 has joined #chromium
[02:08:16] <thakis> hooray, i built unit_tests without having to resort to hacks
[02:08:22] <petriborg1> jamesr - I've got the elem inspector open - very handy - its how I first verified first realized that the chrome / firefox page was different data-wise
[02:09:27] <jamesr> petriborg1: i'll bet some printf()s in the right part of the network stack would help
[02:09:33] <jamesr> petriborg1: probably best to proceed on a bug, though
[02:09:45] <thakis> trungl: ping
[02:09:57] <trungl> thakis: gnip
[02:10:11] <thakis> trungl: just installed 10.6. fullscreen is kinda broken on 10.6. known problem?
[02:10:14] *** dglazkov has joined #chromium
[02:10:14] *** ChanServ sets mode: +v dglazkov
[02:10:26] <trungl> thakis: no idea
[02:10:29] <trungl> thakis: ask rohit?
[02:10:32] <petriborg1> evmar - how do I look at the cache? I greped the files in the folder - I think what is there are the initial page which is 75%+ javascript which load different elements on load
[02:10:36] <thakis> not here
[02:10:40] <trungl> thakis: presumably that's known
[02:10:48] <petriborg1> aka I don't think we can "see" it in the cache
[02:11:05] <petriborg1> jamesr - do you think its a bug in chrome or a bug on their site?
[02:11:15] <jamesr> petriborg1: can't say yet
[02:11:24] <evmar> petriborg1: about:net-internals, click around there
[02:11:24] <akalin> scarybeasts: thanks!
[02:11:24] <petriborg1> hang on let me dump a bit of the HTML into a pastbin
[02:11:24] *** General13372 has quit IRC
[02:11:29] <jamesr> petriborg1: but if you see this in chrome and not firefox the initialy suspicious is chrome
[02:11:34] <petriborg1> ok
[02:12:25] *** kaasinees has quit IRC
[02:13:56] <petriborg1> http://pastebin.ca/1904897
[02:14:34] <phajdan-jr> scarybeasts: I'd like to land http://codereview.chromium.org/3040011/show. I ran trybots earlier and it was only red on check_deps which I've fixed. OK to land? I don't mind if you'd like to see confirmed green at least for the compile.
[02:14:40] <thakis> trungl: bug filed
[02:14:42] <jamesr> petriborg1: this could be the new html5 parser
[02:15:22] <jamesr> petriborg1: yeah file a bug please and link that in chat
[02:15:36] <petriborg1> all right
[02:17:38] <jamesr> i'll CC the relevant people
[02:18:42] <jamesr> petriborg1: if you have a new firefox you can try turning on their html5 parser (it's somewhere in about:config) and seeing if that works as well
[02:18:51] <leiz> weird, I swear chromium xp clobbers before every build, but I can't find that in the steps anywhere
[02:18:57] <scarybeasts> phajdan-jr: hmm, looks like surgery so i'd prefer a green try bot :)
[02:19:42] <phajdan-jr> scarybeasts: sure. Is the compile step sufficient?
[02:19:47] <phajdan-jr> (no code change)
[02:20:01] <scarybeasts> phajdan-jr: ok yes
[02:20:10] <petriborg1> jamesr i haven't got the beta of firefox yet but i'll look into that after I'm done writing up the ticket - what should I include other then the obvious steps to reproduce ?
[02:20:22] <leiz> scarybeasts: chromium xp is still failing, can you hold off commits until the run for r53128 finishes so I can clobber the bot?
[02:20:41] <jamesr> petriborg1: the obvious steps to reproduce and the output you see
[02:20:49] <petriborg1> ok
[02:20:50] <jamesr> and what other browsers+versions you have tried in that work
[02:20:57] <petriborg1> k
[02:20:58] <scarybeasts> leiz: ok
[02:21:08] *** n3v3le has quit IRC
[02:21:09] *** n3v3le has joined #chromium
[02:21:13] *** Adys has quit IRC
[02:21:36] *** Adys has joined #chromium
[02:21:37] *** dglazkov has quit IRC
[02:22:08] <leiz> scarybeasts: or reboot the machine or something
[02:22:34] *** yutak_home has joined #chromium
[02:22:34] *** ChanServ sets mode: +v yutak_home
[02:23:50] *** mazda has quit IRC
[02:24:04] <scarybeasts> leiz: reinstall linux on it ;-)
[02:24:07] *** mazda has joined #chromium
[02:24:27] <nsylvain> leiz: Just seeing your message now. I think this is evan.  libxml change.
[02:24:36] <nsylvain> you should revert that
[02:24:39] <nsylvain> i need to go afk
[02:24:55] *** albertb_ has joined #chromium
[02:25:02] <leiz> evmar: ^
[02:26:34] <scarybeasts> ah, http://buildbot.jail.google.com/buildbot/chromium/builders/Chromium%20XP/builds/13199/steps/compile/logs/stdio_html seems instructive
[02:26:50] <leiz> scarybeasts: and compile with wine?
[02:27:02] <leiz> scarybeasts: I thought it was my CL the whole time because I touched chrome frame
[02:27:21] <leiz> totally missed evmar's r53122
[02:27:33] *** RT|Chatzilla has joined #chromium
[02:27:43] <scarybeasts> me too
[02:28:07] <scarybeasts> evmar: you caught that?
[02:30:13] <evmar> wot?
[02:30:27] <leiz> evmar: we have a compile failure on chromium xp but not chromium builder
[02:30:28] <petriborg1> jamesr & evmar  --  http://code.google.com/p/chromium/issues/detail?id=49720
[02:30:31] <scarybeasts> evmar: http://buildbot.jail.google.com/buildbot/chromium/builders/Chromium%20XP/builds/13199/steps/compile/logs/stdio_html
[02:30:38] <scarybeasts> is that related to r53122 ?
[02:30:47] <evmar> sigh
[02:30:49] <leiz> evmar: both of our try jobs passes the windows try bot
[02:30:52] <evmar> seems likely
[02:31:08] <scarybeasts> <3 CF
[02:31:11] <evmar> you can revert me
[02:31:18] <evmar> it was not an importnat change
[02:31:46] <leiz> and if that doesn't fix it, revert my cl
[02:31:56] <scarybeasts> leiz: which rev?
[02:32:02] <scarybeasts> evmar: ok
[02:32:58] *** Beetny` has quit IRC
[02:32:58] <leiz> scarybeasts: evmar is 53122, mine is 53113
[02:33:29] <petriborg1> hey guys you may be able to reproduce it by going to this url:   https://www4.usbank.com/internetBanking/RequestRouter?requestCmdId=DisplayLoginPageNotYou
[02:33:41] <evmar> petriborg1: yes!
[02:33:48] <petriborg1> you get scary boxes?
[02:33:48] *** Beetny has joined #chromium
[02:33:49] <evmar> petriborg1: reproduced here
[02:33:49] <evmar> yeah
[02:33:54] <petriborg1> nice!
[02:34:01] <petriborg1> i'll add the url to the page
[02:34:05] <petriborg1> the bug report i mean
[02:34:22] <leiz> I wouldn't call those boxes scary
[02:34:27] <leiz> scarybeasts is scary ;)
[02:34:36] <jamesr> i can repro on mac
[02:34:37] <scarybeasts> raaaarrrr
[02:34:42] <petriborg1> no it is scary when its happening on your login page leiz
[02:34:46] *** stevenjb has quit IRC
[02:34:58] <jamesr> given that you're seeing the unicode replacement character, it's almost certainly the new html5 tokenizer barfing on something
[02:35:03] <petriborg1> i thought my box got hacked or something crazy until i inspected the payload and found it to be the same character
[02:35:06] <leiz> jamesr: does it happen with safari?
[02:35:13] *** mrossetti has quit IRC
[02:36:20] <leiz> petriborg1: ah, ya, that's bad :(
[02:36:22] *** jhawkins has joined #chromium
[02:36:22] *** ChanServ sets mode: +v jhawkins
[02:36:46] <jamesr> leiz: yes
[02:36:49] <petriborg1> yeah i know it was the "unicode fail" char - but that doesn't stop it from being "OMG OMG OMG" ;-)
[02:36:53] <leiz> petriborg1: it's a regression, it works fine with 5.0.375.86
[02:36:54] <jamesr> (in a version of safari with the new tokenizer)
[02:37:01] <jhawkins> scarybeasts: have a CL ready http://codereview.chromium.org/2811059/show
[02:37:14] <trungl-bot> Tree closed by cevans at chromium dot org: Tree is closed (Chromium XP -> revert in)
[02:37:47] <scarybeasts> jhawkins: looking
[02:37:59] <jhawkins> tests are in first patch set
[02:38:29] <petriborg1> leiz - sure I know it didn't even break even on the build previous - its all good :-)
[02:39:33] <petriborg1> jamesr - do you still need me to get the firefox html5 output?
[02:39:40] <jamesr> nah
[02:39:41] <jamesr> that's fine
[02:39:43] <petriborg1> ok
[02:39:53] <scarybeasts> jhawkins: i don't see any test file in 1st patch set? am i on drugs?
[02:40:02] <jamesr> petriborg1: should have plenty of information to fix it now
[02:40:20] <petriborg1> great, glad to hear it :-)
[02:40:21] *** tonyg-cr has quit IRC
[02:40:31] <leiz> petriborg1: did you file a bug on crbug.com already?
[02:40:34] <petriborg1> i always hate bugs I can't reproduce in my own code ;-)
[02:40:43] <petriborg1> leiz - http://code.google.com/p/chromium/issues/detail?id=49720
[02:41:11] *** johnny_g has quit IRC
[02:41:12] <leiz> ah, very good
[02:41:47] *** dmaclach has joined #chromium
[02:41:51] <evmar> petriborg1: thank you very much for the effort in tracking that down!
[02:42:38] <evmar> petriborg1: https://bugs.webkit.org/show_bug.cgi?id=42112
[02:44:52] <scarybeasts> the Mac 10.6 perf tests seem to be riding the line, grr
[02:46:02] <petriborg1> seems a mistake to convert nulls just because ... null is usually your friend :-/
[02:47:57] <jhawkins> scarybeasts: I mean the trybot runs
[02:48:31] <abarth> petriborg1: the null issue has had lots of ink spilled over it
[02:48:48] <abarth> petriborg1: Hixie thinks that the nulls are problems waiting to happen
[02:49:00] <petriborg1> it sounds like it based on the comments on the webkit.org tracker :-)
[02:49:25] <jamesr> petriborg1: can you still log in successfully?
[02:49:30] <abarth> petriborg1: yeah.  it's really helpful to see real world examples
[02:49:34] *** albertb_ has quit IRC
[02:50:04] <scarybeasts> jhawkins: ok, seems isolated. submit if you can watch it for a bit. i think the tree is greening
[02:50:14] <petriborg1> jamesr - yes i can
[02:50:15] <jhawkins> scarybeasts: will do
[02:50:36] <jamesr> ok
[02:50:59] <phajdan-jr> scarybeasts: when the tree is re-opened, can I be first in the queue with my ssl_test_util move patch?
[02:51:09] <phajdan-jr> green compile on Linux for now
[02:51:44] <leiz> scarybeasts: I also need to fix valgrind because I suck http://codereview.chromium.org/2856052/show
[02:53:18] <leiz> btw, we'll know if the revert works or not in ~14 minutes
[02:53:19] <petriborg1> abarth - i'm not a "security" hacker anymore, but from my previous jobs, I can possibly understand how it might cause some sort of problem, sort of like UTF urls but frankly I'm not sure I understand how substituting in something other then NULL would magically "fix" the problem instead you'd just see some other hack-padding value instead of null
[02:53:25] <scarybeasts> leiz: feel free to toss that in right away :)
[02:53:34] <scarybeasts> phajdan-jr: sure
[02:53:47] *** Adys_ has joined #chromium
[02:54:05] <scarybeasts> csilv: still here?
[02:54:10] <jamesr> petriborg1: i think part of the idea is that now you'll want to call up your bank and yell at them for having NULL in the html they serve to user
[02:54:22] <jamesr> petriborg1: that doesn't sound very compelling to me but you can ask Hixie
[02:54:24] <csilv> yes, i see it... looking
[02:55:01] <scarybeasts> csilv: thanks! maybe we should revert?
[02:55:32] <dcheng> Why would you have embedded NULLs in HTML? That sounds like it's just asking for trouble.
[02:55:45] <leiz> scarybeasts: official xp failure is the same as chromium xp
[02:55:51] <leiz> scarybeasts: official linux failure is me
[02:56:06] <scarybeasts> leiz: ah thanks, i was just about to turn my attention to those official builders
[02:56:10] <petriborg1> jamesr - possibly, but because of this I started reading my banks HTML page - holy shit scary ass HTML right there >.<
[02:56:11] <leiz> scarybeasts: official mac has been broken for days (need 10.6 upgrade)
[02:56:19] <jamesr> dcheng: because they were ignored by parsers for years
[02:56:21] <jamesr> dcheng: and so why not?
[02:56:23] *** Adys has quit IRC
[02:56:26] *** Adys_ is now known as Adys
[02:56:39] <petriborg1> rather i should say scary javascript - since its 90% JS
[02:57:12] <jamesr> i'll bet the bank has "char buf[255]; // should be big enough memset(buf, 0, 255); sprintf(buf, "%s", unsanitized_crap_from_database);"
[02:57:20] *** jrmuizel has joined #chromium
[02:57:20] <scarybeasts> jamesr: haha
[02:57:30] <trungl-bot> Tree closed by cevans at chromium dot org: Tree is closed (Chromium XP -> revert in, Linux Views Dbg -> csilv)
[02:57:31] *** yutak_home has quit IRC
[02:57:31] <dcheng> jamesr: Yeah, then you do something like my $foo = `wget -O - http://mypagewithnulls.com` and wonder why something explodes later.
[02:58:53] <jamesr> like most things on the web, though, it's clear that the author is at fault (in this case the bank). that still doesn't tell you what to do about the problem
[02:58:54] <petriborg1> jamesr - maybe but its probably done in a combination of Cobol, Pascal, and cold-fusion or something evil
[02:59:01] <akalin> what null issue
[02:59:02] <akalin> @_@
[02:59:14] <petriborg1> ok off i go
[02:59:15] <petriborg1> thanks guys
[02:59:19] <petriborg1> been fun heh
[02:59:20] <dcheng> The HTML5 parser converts null characters to 0xfffd, I think.
[02:59:21] <jamesr> petriborg1: i don't wanna know how my bank does its website or how oscar-meyer makes my lunch
[02:59:34] <petriborg1> exactly :-)
[03:00:26] <akalin> <3 HTML5
[03:01:44] *** dmaclach_ has joined #chromium
[03:02:37] *** dmaclach_ has quit IRC
[03:02:54] *** erikkay has quit IRC
[03:03:09] <csilv> scarybeasts: fix coming
[03:03:17] *** hbono has joined #chromium
[03:03:27] <scarybeasts> csilv: will it work this time? :P
[03:03:56] <csilv> yes.  it will.  sorry about the hassle
[03:04:12] <leiz> scarybeasts: linux official build fix is http://codereview.chromium.org/2861070
[03:04:40] <scarybeasts> leiz: LGTM
[03:05:09] <leiz> also, chromium xp's compile finished!
[03:05:27] *** dmaclach has quit IRC
[03:06:11] *** shoe has joined #chromium
[03:06:30] <scarybeasts> i see signs of hope
[03:07:17] *** shoe has left #chromium
[03:08:11] *** leeight has joined #chromium
[03:08:15] *** ananta has quit IRC
[03:08:19] *** mpcomplete has quit IRC
[03:08:38] *** ananta has joined #chromium
[03:08:38] *** ChanServ sets mode: +v ananta
[03:08:55] *** mpcomplete has joined #chromium
[03:08:55] *** ChanServ sets mode: +v mpcomplete
[03:09:24] *** leeight has left #chromium
[03:10:00] <csilv> scareybeasts: linux views, fix in.
[03:10:39] <scarybeasts> csilv: thx!
[03:11:55] *** petriborg1 has left #chromium
[03:13:11] <akalin> so is the M6 branch still off-limits?
[03:13:50] <trungl-bot> Tree closed by cevans at chromium dot org: Tree is closed (fixes in -> throttled; see scarybeasts on irc)
[03:14:10] <hbono> scarybeasts: morning (from Tokyo).
[03:14:17] <scarybeasts> hbono: hello :)
[03:14:54] <phajdan-jr> scarybeasts: does "throttled" mean I can land my move change?
[03:15:09] <scarybeasts> phajdan-jr: i was just about to make you that offer
[03:15:28] <phajdan-jr> cool, landing then in few seconds...
[03:15:33] <dcheng> Can I use git cl to upload WebKit changes into chromium's rietveld?
[03:15:36] <scarybeasts> the only recent red looks like flake so go ahead
[03:15:50] <jrg> scarybeasts: I have some small Mac-only CLs I'd like to land.  http://codereview.chromium.org/2878041 (is a suppression removal); http://codereview.chromium.org/3030008 (chaneges some constants).  SGTY?
[03:15:59] <scarybeasts> jrg: looking
[03:16:27] <phajdan-jr> scarybeasts: landed, watching the tree carefully
[03:17:06] <scarybeasts> jrg: LGTM
[03:17:20] *** jshin has quit IRC
[03:17:23] <jrg> scarybeasts: landed; thx
[03:17:25] <hbono> scarybeasts: I should have come to the office earlier to help you. Thank you so much for your hard work. :)
[03:17:42] *** trungl has quit IRC
[03:17:50] <scarybeasts> hbono: thank pinkerton, he took care of business whilst i was slacking most of the day
[03:18:47] <hbono> scarybeasts: indeed.
[03:19:20] <leiz> hbono: I kept him company (and good morning!)
[03:19:51] <hbono> leiz: good evening. :)
[03:19:53] *** jamesr has quit IRC
[03:21:08] *** fqian has joined #chromium
[03:21:37] *** dmaclach has joined #chromium
[03:21:49] *** kerz has quit IRC
[03:22:39] *** dmaclach has quit IRC
[03:23:37] <andybons> hbono, scarybeasts: headed home. don't foresee any red from the perf bot but if so and it looks like my change feel free to revert
[03:23:50] <andybons> everything else looks ok, though
[03:25:02] <andybons> have a good night all
[03:25:51] <hbono> andybons: have a good night.
[03:26:06] <scarybeasts> night bons
[03:26:25] *** andybons has quit IRC
[03:27:08] <oshima> hi, troopers here? i have a question about lkgr.
[03:27:41] <leiz> oshima: chromium xp kept on failing, which is why lkgr is behind
[03:28:02] <oshima> yes, the problem is that lkgr seems to be updated even if chromeos build fails.
[03:28:29] <leiz> oshima: ah, you should ask maruel and nsylvain.
[03:28:34] <oshima> chromeos tree is closed because chromium build is failing :(
[03:28:42] <oshima> k
[03:28:48] *** fqian has quit IRC
[03:28:56] <scarybeasts> oshima: we should have fixed that
[03:29:21] <leiz> oshima: are you using chromium's lkgr to decice what revision to use for cros?
[03:29:22] <oshima> scarybeasts: yes, i want. do you know where the code is?
[03:29:38] <oshima> chromium for chromium os
[03:29:47] *** zork has joined #chromium
[03:30:31] <phajdan-jr> scarybeasts: my change passed compile step on all platforms. I'm going to eat some dinner. I can't imagine how my change could break something else than compile, but if it does, please just revert immediately. Watch out for flakiness.
[03:30:38] <scarybeasts> ok
[03:30:38] *** jamesr has joined #chromium
[03:30:38] *** ChanServ sets mode: +v jamesr
[03:30:47] *** phajdan-jr is now known as phajdan-jr|afk
[03:30:54] <leiz> oshima: lkgr is at 53110, does that not build for you?
[03:32:42] *** mihaip has quit IRC
[03:33:49] <oshima> leiz: 53110 doesn't compile on chromeos tree.
[03:34:18] <oshima> leiz: looks like build itself was working on chromium tree. hmm, don't understand.
[03:35:12] <oshima> http://buildbot.jail.google.com/buildbot/chromeos/builders/x86%20generic%20incremental%20(RC)/builds/1766/steps/shell_5/logs/stdio
[03:35:15] <leiz> oshima: right, we haven't had a build break here, so I don't know what's wrong
[03:35:37] <oshima> has "svn update ... --revision 53110'
[03:35:41] <scarybeasts> oooh! green Chromium XP
[03:36:16] <oshima> and failing with "chrome/browser/chromeos/update_observer.cc:26: error: enumeration value 'UPDATE_STATUS_REPORTING_ERROR_EVENT' not handled in switch"
[03:36:18] <leiz> oshima: maybe you guys are using a different compiler?
[03:36:27] <leiz> that throws more warnings?
[03:37:02] <oshima> leiz: hold on. i have an idea...
[03:37:03] <scarybeasts> if i open the tree, will i regret it?
[03:37:35] <leiz> scarybeasts: nah, everyone's out to dinner
[03:37:36] <akalin> <3 crrev.com
[03:37:51] *** dave_levin has quit IRC
[03:37:53] <hbono> scarybeasts: congraturations. :)
[03:38:10] <leiz> oshima: ya, it's g++ 4.2.4 vs 4.4.3
[03:38:20] <leiz> oshima: and the warning is in cros specific chromium code.
[03:39:04] <oshima> leiz: let me talk to chromeos build folks..
[03:39:33] <leiz> oshima: tell sean to fix his code, and maybe switch codg208 to a newer version of ubuntu
[03:41:37] <scarybeasts> wait for it..
[03:42:17] <oshima> leiz: i actually think this is deps issue.
[03:42:20] <trungl-bot> Tree opened by cevans at chromium dot org: Tree is open
[03:42:28] <scarybeasts> ding ding
[03:42:46] <akalin> MOAR CLS
[03:43:50] <hbono> leiz: also switch chromiumos trybots to a newer version of ubuntu?
[03:46:39] <leiz> oshima: deps issue? how so?
[03:47:12] <leiz> hbono: ya, we'd want all the chromeos bots to be using gcc 4.4.3, since that what they're using in their build environment.
[03:50:05] <oshima> leiz: chromium needs code from chromium os and has DEPS to fetch specific version. may be chromium os builder is using latest version instead of deps.
[03:50:15] <oshima> i may be wrong and need to double check.
[03:50:24] <oshima> (i'm not familiar with chromiumos build)
[03:50:50] <scarybeasts> hmm, anyone heard of DeleteNotifications? that might be real rather than flake
[03:52:11] <leiz> oshima: no, I think the warning is legit
[03:52:19] *** Venom_X has quit IRC
[03:52:48] <leiz> oshima: it's not a deps issue, src/chrome/browser/chromeos is in the chromium tree
[03:53:01] <leiz> oshima: it's a gcc 4.2.4 vs gcc 4.4.3 issue
[03:53:09] <oshima> which depends on third_party/cros which is DEPS
[03:53:45] <oshima> leiz: you may be right. i just want to double check.
[03:53:55] <scarybeasts> akalin: still here?
[03:54:09] <leiz> but the code in question is not in third_part/cros, nor does it #include anything from third_party/cros
[03:54:21] <oshima> enum is defined in third_party/cros
[03:55:31] *** eglaysher has quit IRC
[03:55:49] <akalin> scarybeasts: yeah what's up?
[03:55:56] <akalin> did i break something? D:
[03:55:58] <leiz> oshima: ah ya, there it is.
[03:56:39] <scarybeasts> akalin: it seems implausible, but there's been a consistent failure since r53127
[03:56:59] <akalin> scarybeasts: on what?
[03:57:03] <leiz> oshima: in that case it could be a DEPS issue. If the header + code are out of sync.
[03:57:12] <akalin> DeleteNotifications?
[03:57:14] <scarybeasts> Linux Tests x64 unit_tests DeleteNotifications
[03:57:17] <scarybeasts> it's a SIGSEGV
[03:57:43] <scarybeasts> hbono: ok if i grab dinner?
[03:57:48] <oshima> leiz: yes. i'll look for help on chromiumos side. thanks!
[03:57:56] <leiz> oshima: ok, dunner time for me.
[03:57:58] <akalin> scarybeasts: hmm weird
[03:58:04] <leiz> dinner, even
[03:58:05] <akalin> my change has to do with sync and extensions
[03:58:14] <hbono> scarybeasts: sure. I'm looking at the deletenotification crash.
[03:58:21] <scarybeasts> hbono: thx
[03:58:24] <akalin> hbono: okay
[03:58:47] <akalin> does TopSitesTest touch extensions in any way?
[03:59:19] <hbono> akalin: probably not.
[03:59:30] <akalin> mmm
[03:59:45] <akalin> it does seem suspicious that it showed up at 51327
[03:59:53] *** csilv has left #chromium
[04:01:33] <leiz> akalin: I'm building unit_tests on linux here, I can test when the build finishes
[04:01:59] <akalin> okay
[04:02:22] *** phajdan-jr|afk has quit IRC
[04:02:35] <akalin> fwiw, my change passed the linux trybots
[04:05:34] <leiz> it seems to only happen on 64-bit linux
[04:05:41] <leiz> the linux trybots are mostly 32
[04:05:43] <hbono> akalin: yeah. this crash happens only on x64.
[04:05:46] *** isherman has joined #chromium
[04:05:53] *** ChanServ sets mode: +v isherman
[04:06:07] <leiz> akalin: I think it's you: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20x64/builds/4587
[04:06:36] <leiz> extract build is green, so the revision is accurate, and the blamelist is only 1 revision
[04:09:55] <hbono> leiz: I'm wondering why an extension change affects TopSitesTest, which is a part of history test, though.
[04:10:04] *** GeekShadow has quit IRC
[04:10:18] *** trungl has joined #chromium
[04:10:18] *** ChanServ sets mode: +v trungl
[04:10:57] <leiz> hbono: no idea, that's for akalin to find out :)
[04:12:06] <hbono> leiz: I'm also building unittest on my Linux (x64) box to investigate it.
[04:13:50] <leiz> hbono: hmm, worked for me locally
[04:14:37] <leiz> let me make sure I built correctly
[04:15:45] <hbono> leiz: I'm getting the Linux (x64) binary from the build server.
[04:17:54] *** csilv_ has joined #chromium
[04:21:12] *** ebraminio has quit IRC
[04:24:49] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open (DeleteNotifications -> hbono investigating)
[04:28:36] <csilv_> ugh.  i lose again...
[04:30:55] <leiz> csilv_: shake your fist in the air with rage
[04:31:21] <csilv_> i admit humilation and defeat.  time to revert and fight another day...
[04:31:50] <scarybeasts> csilv: ok :) bummer
[04:32:56] <scarybeasts> akalin: that bot cycles pretty quick, we can try a revert if you want
[04:33:42] <hbono> it seems DeleteNotifications crashes on my PC when using the binary downloaded from the buildbot.
[04:34:13] *** js2 has quit IRC
[04:35:42] *** tedoc2000 has quit IRC
[04:39:27] <scarybeasts> hbono: should we just try a revert?
[04:41:24] <hbono> scarybeasts: it may be a builder issue since this crash does not happen when I build the unittest on my Linux (x64) PC.
[04:41:33] *** trungl has quit IRC
[04:41:59] <hbono> scarybeasts: Nevertheless, we may try revert his change to see what happens if he allows it.
[04:42:02] <scarybeasts> hmm interesting
[04:43:05] <hbono> scarybeasts: as I wrote above, on the other hand, when I download the compiled binary from the builder and run its unittest on my Linux (x64) PC, it crashes.
[04:45:12] <hbono> scarybeasts: can I reboot the Linux (x64) builder, clobber it, and see its output binary?
[04:45:58] <scarybeasts> sounds good
[04:46:26] *** jamesr has quit IRC
[04:46:35] <scarybeasts> csilv: how's that revert going?
[04:46:48] <hbono> scarybeasts: thanks. I'm rebooting it.
[04:49:02] <csilv_> scarybeasts, could i bribe you into doing the revert on your end?  i have the CL number.
[04:49:27] <scarybeasts> csilv: sure, but what about the follow-on CLs?
[04:50:07] <csilv_> 53070 is the main offending CL. my subsequent failed fixes are 53126, 53133.
[04:50:22] <scarybeasts> hmm let me see if drover can handle that
[04:50:25] <csilv_> ok
[04:52:22] <scarybeasts> hbono: is it ok to revert in multiple pieces or should i try and coalesce into 1 CL?
[04:54:13] <hbono> scarybeasts: sure.
[04:54:37] <scarybeasts> csilv: in the interests of getting it done right away, here come three pieces
[04:54:50] <csilv_> k
[04:57:58] *** MikeSmithW3C has quit IRC
[05:00:38] *** csilv_ has quit IRC
[05:02:53] *** tfarina has joined #chromium
[05:04:59] *** dglazkov has joined #chromium
[05:04:59] *** ChanServ sets mode: +v dglazkov
[05:07:13] *** csilv_ has joined #chromium
[05:08:25] <csilv_> thx scarybeasts.  i owe you a beer/coffee/something!
[05:08:43] <scarybeasts> don't thank me until it compiles :P
[05:09:45] *** trungl has joined #chromium
[05:09:46] *** ChanServ sets mode: +v trungl
[05:10:32] *** homata_ has quit IRC
[05:10:38] *** bweinstein has quit IRC
[05:11:42] *** rniwa has quit IRC
[05:13:39] *** rohitrao has joined #chromium
[05:13:39] *** ChanServ sets mode: +v rohitrao
[05:16:16] <csilv_> (shutting down here, online again in 30 mins)
[05:16:17] *** csilv_ has left #chromium
[05:16:50] <akalin2> hbono: i hear talks about reverting
[05:17:03] <akalin2> looks like it is my change?
[05:18:26] <hbono> akalin2: not totally sure. It may be a builder issue since this crash does not happen on my Linux (x64) PC when I built chromium on it.
[05:18:33] <akalin2> ok
[05:18:53] <hbono> akalin2: on the other hand, when I ran the binary downloaded from the builder, it crashes.
[05:19:07] <akalin2> hunh
[05:19:08] <akalin2> that's weird
[05:19:12] <akalin2> that seems to point to a builder issue
[05:19:14] <hbono> akalin2: to check it, I have rebooted the builder and clobbered it.
[05:19:19] <akalin2> ok
[05:19:21] <akalin2> i'll be here for a bit
[05:20:02] <hbono> akalin2: if the clobber does not help, I would try reverting your change as the last resort. Sorry.
[05:20:13] *** MikeSmithW3C has joined #chromium
[05:20:19] *** hclam has quit IRC
[05:20:24] <akalin2> hbono: okay, that sounds fine
[05:21:35] *** MikeSmithW3C has quit IRC
[05:21:43] *** MikeSmithW3C has joined #chromium
[05:27:09] *** isherman has quit IRC
[05:29:17] <scarybeasts> uh oh
[05:29:22] <scarybeasts> buildbot failure
[05:29:28] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "update" on "Chromium Linux Builder (dbg)")
[05:29:38] <hbono> scarybeasts: yeah.
[05:30:37] <scarybeasts> IOError: [Errno 28] No space left on device
[05:31:08] <scarybeasts> hbono: you got any clue how to fix that?
[05:31:11] <hbono> scarybeasts: I have logged into the bot and am deleting files.
[05:31:16] <scarybeasts> ah thx
[05:33:32] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Linux Builder (dbg)" -> hbono deleting files, DeleteNotifications -> hbono investigating)
[05:36:59] *** dglazkov has quit IRC
[05:39:09] *** tedoc2000 has joined #chromium
[05:44:05] *** hayato has quit IRC
[05:44:50] *** hayato has joined #chromium
[05:44:51] *** Emperorlou has quit IRC
[05:47:39] *** tonikitoo has quit IRC
[05:49:04] *** csilv_ has joined #chromium
[05:49:11] <hbono> deleted files. let me try clobbering the bot.
[05:51:24] <akalin2> hbono: so we wait for another build?
[05:51:58] <hbono> akakin2: it seems unittests finished successfully after the reboot: <http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Tests%20x64/builds/4595>
[05:52:19] <akalin2> oh, great
[05:52:22] <akalin2> so some weird builder issue?
[05:52:35] <akalin2> also can you paste an external link?  i'm at home
[05:52:52] <hbono> akalin2: it seems so. I'm going to reboot the "Chromium Linux x64" bot when it becomes idle.
[05:53:02] <akalin2> ok
[05:53:06] <akalin2> thanks for investigating
[05:53:13] <akalin2> glad to know i didn't break stuff!
[05:53:53] <hbono> akalin2: sorry, it's <http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20x64/builds/4595>.
[05:55:23] <akalin2> coolio
[05:56:07] <akalin2> so did you reboot the bot before the successful build or just clobber?
[05:56:23] <akalin2> oh, right, just a clobber
[05:56:28] <akalin2> yeah, i guess it's some weird build issue :/
[05:56:40] <hbono> akalin2: indeed.
[05:56:44] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Linux Builder (dbg)" -> waiting for cycling green, "Chromium Linux x64" -> need reboot)
[05:56:57] *** tedoc2000 has quit IRC
[05:57:34] *** estes has quit IRC
[05:58:11] <scarybeasts> miracle. Linux Builder (Views dbg) is greeeeeeeen
[05:59:05] <hbono> scarybeasts: yeah. the "Linux Tests x64" bot is also green. :)
[06:00:53] *** victorw has quit IRC
[06:01:25] *** victorw has joined #chromium
[06:01:25] *** ChanServ sets mode: +v victorw
[06:01:38] *** tonikitoo has joined #chromium
[06:02:04] <scarybeasts> hbono: it's like Christmas has come early :)
[06:02:18] *** mihaip has joined #chromium
[06:02:28] <hbono> scarybeasts: :)
[06:03:12] <hbono> scarybeasts: probably you can have a good night.
[06:03:25] <scarybeasts> hbono: probably i should go home yes
[06:03:33] *** dglazkov has joined #chromium
[06:03:34] *** ChanServ sets mode: +v dglazkov
[06:03:43] <scarybeasts> hbono: night :)
[06:04:36] *** scarybeasts has quit IRC
[06:12:02] *** MX80 has quit IRC
[06:13:21] *** ctruta has joined #chromium
[06:17:11] *** dave_levin has joined #chromium
[06:18:39] *** csilv_ has quit IRC
[06:18:54] *** ctruta has quit IRC
[06:19:21] *** csilv_ has joined #chromium
[06:20:09] *** csilv_ has left #chromium
[06:21:20] *** eroman has quit IRC
[06:22:04] *** General13372 has joined #chromium
[06:24:09] *** FullFlannelJacke has quit IRC
[06:25:01] *** General1337 has quit IRC
[06:25:01] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ( "Chromium Linux x64" -> need reboot)
[06:25:29] *** MX80 has joined #chromium
[06:25:52] *** ecolell has left #chromium
[06:29:06] *** rohitrao has quit IRC
[06:30:04] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ( "Chromium Linux x64" -> waiting for cycling green)
[06:33:28] *** MikeSmithW3C has quit IRC
[06:36:56] *** FullFlannelJacke has joined #chromium
[06:42:11] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open
[06:52:34] *** Adys has quit IRC
[06:52:55] *** Adys has joined #chromium
[06:53:16] *** skerner has joined #chromium
[06:53:16] *** ChanServ sets mode: +v skerner
[06:57:11] *** FullFlannelJacke has quit IRC
[07:01:22] *** sanjeevr has joined #chromium
[07:01:50] *** sanjeevr has quit IRC
[07:07:30] *** dglazkov has quit IRC
[07:07:52] *** thakis_ has joined #chromium
[07:07:52] *** ChanServ sets mode: +v thakis_
[07:07:55] *** ebraminio has joined #chromium
[07:08:34] <Hixie> who implemented websockets in chrome again? i'm considering changing the constructor's second argument to an array and would like to see if that's ok
[07:09:23] *** estes has joined #chromium
[07:11:33] <dave_levin> Hixie: Ditto (what I said in #webkit).
[07:11:48] <Hixie> k
[07:11:53] <Hixie> didn't realise it was the same code :-)
[07:13:24] *** mihaip has quit IRC
[07:13:25] <dave_levin> Hixie: Well there is a portion that is shared and a portion that is platform specific. (iirc, ukai does the chromium platform specific part and ap the normal osx webkit platform specific part. ukai has done a lot of the portion that is shared.)
[07:13:39] <Hixie> aah
[07:14:53] <dave_levin> Hixie: and given the working time in Japan. ukai should be there. Probably just away for the moment.
[07:16:03] <Hixie> k
[07:16:13] <Hixie> i'll send e-mail
[07:16:17] <Hixie> ukai@chromium and ap@webkit?
[07:17:39] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("XP Tests", "Vista Tests" -> hbono investigating)
[07:20:03] *** loislo has joined #chromium
[07:22:34] <leiz> is there a bot that's out of space still?
[07:22:50] <leiz> ah, nm
[07:23:15] <hbono> leiz: I have deleted temp files from the bots.
[07:32:11] *** peepsalot has quit IRC
[07:36:05] *** tlrobinson has quit IRC
[07:36:16] *** tlrobinson has joined #chromium
[07:36:16] *** peepsalot has joined #chromium
[07:38:51] *** estes has quit IRC
[07:53:41] <dave_levin> Hixie: yes
[07:53:54] <Hixie> k, thanks
[07:56:35] *** abarth has quit IRC
[07:58:10] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("XP Tests", "Vista Tests" -> the binary seems to be corrupted, hbono clobbering)
[07:59:08] *** dave_levin_ has joined #chromium
[08:02:03] *** dave_levin has quit IRC
[08:02:03] *** dave_levin_ is now known as dave_levin
[08:02:16] *** jrmuizel has quit IRC
[08:16:23] <leiz> Mac10.6 Perf(2) died
[08:18:20] <trungl-bot> Tree opened by thestig at chromium dot org (:leiz): Tree is open ("XP Tests", "Vista Tests" -> the binary seems to be corrupted, hbono clobbering, Mac10.6 Perf(2) needs a hard reboot)
[08:38:11] *** trungl has quit IRC
[08:43:37] *** Erkan_Yilmaz has quit IRC
[08:46:07] *** n3v3le has quit IRC
[08:46:17] *** japhet has quit IRC
[08:46:22] *** jstrom has quit IRC
[08:46:28] *** jstrom has joined #chromium
[08:46:42] *** japhet has joined #chromium
[08:46:42] *** ChanServ sets mode: +v japhet
[08:47:58] *** n3v3le has joined #chromium
[08:48:35] *** chrisccoulson has joined #chromium
[08:49:01] *** abarth has joined #chromium
[08:49:01] *** ChanServ sets mode: +v abarth
[08:53:01] <jochen__> good morning
[08:53:35] <leiz> guten morgen
[08:55:26] *** roc has quit IRC
[08:56:12] *** Zaba has quit IRC
[08:58:03] *** japhet has quit IRC
[08:58:52] *** japhet has joined #chromium
[08:58:52] *** ChanServ sets mode: +v japhet
[09:00:15] *** Zaba has joined #chromium
[09:01:44] *** dr_win has quit IRC
[09:04:29] <hbono> TopSitesTest.DeleteNotifications still crashes on XP and Vista bots.
[09:15:49] *** jeremymos has quit IRC
[09:23:25] <leiz> hbono: file a bug and mark it flaky?
[09:23:37] <leiz> hbono: how did you fix it for linux 64-bit
[09:23:39] <leiz> ?
[09:24:21] <hbono> leiz: for Linux, rebooting the builder fixed it.
[09:24:52] <hbono> leiz: currently, I'm re-building unit_test.exe on my Windows box and see it crashes.
[09:25:17] <hbono> leiz: if it still crashes, I will file a bug and mark it flaky.
[09:26:57] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("XP Tests", "Vista Tests" -> hbono still investigating, Mac10.6 Perf(2) needs a hard reboot)
[09:34:16] *** star-affinity has joined #chromium
[09:35:50] *** pdelgallego has joined #chromium
[09:37:02] <danno_> good morning chromium!
[09:37:03] <trungl-bot> danno_: Good morning!
[09:37:35] <danno_> hbono: are you still playing sheriff from yesterday?
[09:40:34] <hbono> danno_: partly. (I'm fixing "XP tests" and "Vista tests", which have been crashing when I was a sheriff.)
[09:42:38] <hbono> danno_: ah. it seems rebooting the "Chromium builder" bot fixed them finally.
[09:43:43] <danno_> hbono: ok. anything else that I should know for my sheriff duty today?
[09:44:07] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("XP Tests", "Vista Tests" -> cycling green, Mac10.6 Perf(2) needs a hard reboot)
[09:44:42] *** hrna has joined #chromium
[09:44:46] *** [Nef] has joined #chromium
[09:45:03] <hbono> danno_: as written in the status message, the "Mac 10.6 Perf(2)" bot has been dead. Is it possible to ask mark to reboot it when he wakes up?
[09:46:46] *** monreal has joined #chromium
[09:48:27] *** timing has left #chromium
[09:50:39] <hbono> danno_: Unfortunately, I cannot reboot the "Mac 10.6 Perf(2)" bot because its ssh server has been dead.
[09:52:43] *** fusion44 has joined #chromium
[09:53:59] <danno_> hbono: sure. do you mean mark larson?
[09:54:49] <hbono> danno_: it's Mark Mentovai.
[09:55:21] <hbono> danno_: sorry for your confusion.
[09:55:37] <danno_> hbono: sorry for my ignorance :-)
[09:55:52] <hbono> danno_: no problem. :)
[09:56:47] *** sergey_miryanov has joined #chromium
[09:58:08] <hbono> danno_: if you have any questions (or problems), please feel free to ping me. (I'm in the Tokyo office for at least two hours.)
[09:59:41] *** _zerg has joined #chromium
[10:01:17] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Chromium Mac" from 53163: nick at chromium dot org, nirnimesh at chromium dot org, thestig at chromium dot org (:leiz))
[10:02:09] *** monreal has quit IRC
[10:02:39] *** Adys has quit IRC
[10:05:43] <danno_> hbono: ok, thanks.
[10:08:15] <leiz> hbono: reopen?
[10:08:44] <hbono> TopSitesTest.DeleteNotifications crahsed on Mac this time.
[10:10:49] <leiz> sigh
[10:11:01] <hbono> leiz: yes,  we can reopen the tree and investigate it in the background. (It's up to danno.)
[10:12:47] <danno_> leiz: what exactly failed? I don't actually see a red bot.
[10:14:20] <leiz> danno_: talk to hbono, I'm going to bed.
[10:14:28] *** monreal has joined #chromium
[10:17:21] <leiz> I'm going to sneak in a heapchecker suppression if nobody minds: http://codereview.chromium.org/3037013/show
[10:21:02] *** romainhuet has joined #chromium
[10:22:47] *** Buck has joined #chromium
[10:23:06] <danno_> nirnimesh: ping?
[10:23:45] <hbono> danno_: it's <http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/6814>.
[10:24:18] <danno_> hbono: thanks, I found it. It's just unclear to me if any of the commits have anything to do with the failure.
[10:24:52] <danno_> hbono: only suspect might be 53161 by nirnimesh
[10:25:00] <hbono> danno_: right. this TopSitesTest.DeleteNotifications crash seems to be a bot issue.
[10:25:23] <danno_> hbono: ok, I'll assume so and open the tree
[10:25:25] <hbono> danno_: I have been fixing the bots today.
[10:26:31] <danno_> hbono: you've been rebooting the bots or what exactly?
[10:26:43] <hbono> danno_: the test crashed on Linux this morning. The test crashed on Windows this afternoon, and the test finally crashes on Mac.
[10:27:49] <hbono> danno_: yes. I have rebooted the bots and clobbered them everytime when this test crashed.
[10:27:54] *** maikmerten has joined #chromium
[10:29:04] *** hclam has joined #chromium
[10:29:27] <hbono> (We need to wait the bot to be idle before rebooting it, though.)
[10:29:40] *** homata_ has joined #chromium
[10:32:08] *** abarth has quit IRC
[10:32:08] *** peepsalot has quit IRC
[10:32:09] *** stuartmorgan has quit IRC
[10:32:09] *** zork has quit IRC
[10:32:09] *** Malmis has quit IRC
[10:32:09] *** leiz has quit IRC
[10:32:10] *** hasimo has quit IRC
[10:33:32] *** abarth has joined #chromium
[10:33:32] *** peepsalot has joined #chromium
[10:33:32] *** zork has joined #chromium
[10:33:32] *** stuartmorgan has joined #chromium
[10:33:32] *** Malmis has joined #chromium
[10:33:32] *** leiz has joined #chromium
[10:33:32] *** hasimo has joined #chromium
[10:33:32] *** verne.freenode.net sets mode: +vvv abarth stuartmorgan leiz
[10:35:41] *** hclam has quit IRC
[10:35:59] *** timsteele has quit IRC
[10:36:14] *** ROBOd has joined #chromium
[10:36:31] *** wyfrn has joined #chromium
[10:36:38] <trungl-bot> Tree closed by danno at google dot com: Tree is closed ("Chromium Mac" needs reboot)
[10:36:47] <nirnimesh> hbono: hi
[10:37:16] <nirnimesh> I looked at the unit_tests failure. not even remotely related to my CL
[10:38:29] <hbono> nirnimesh: I agree. This issue seems to be a bot issue.
[10:38:48] <hbono> nirnimesh: I have to spend lots of time fixing bots today.
[10:38:53] *** homata___ has joined #chromium
[10:42:10] *** homata_ has quit IRC
[10:43:05] <jochen__> should i wait for chromium mac to finish it's current build, or reboot it instantly?
[10:44:37] <hbono> jochen__: I would like to wait this build cycle if there are not any urgent changes.
[10:47:27] *** dumi has quit IRC
[10:47:29] *** pfeldman_ has joined #chromium
[10:47:50] <hbono> jochen__: I wish the bot becomes good without reboots, though. :)
[10:48:36] <jochen__> sure
[10:49:37] <jochen__> lots of tests are failing right now anyway :/
[10:54:59] *** wyfrn has quit IRC
[10:55:57] *** monreal_ has joined #chromium
[10:57:18] *** General13372 has quit IRC
[10:57:40] *** General1337 has joined #chromium
[10:58:29] *** homata_ has joined #chromium
[10:58:57] *** homata___ has quit IRC
[10:59:33] *** monreal has quit IRC
[11:12:07] *** Buck has quit IRC
[11:14:05] *** exxe has joined #chromium
[11:15:51] *** Beetny` has joined #chromium
[11:18:30] *** Beetny has quit IRC
[11:20:22] * hbono is wishing unit_tests finish successfully without reboots.
[11:20:52] *** Beetny` has quit IRC
[11:21:13] *** Beetny has joined #chromium
[11:22:07] *** tyoshino has quit IRC
[11:22:29] *** tyoshino has joined #chromium
[11:24:29] *** ukai has quit IRC
[11:24:32] *** ukai has joined #chromium
[11:25:09] <hbono> The "Chromium Mac" bot does not need reboot. :)
[11:28:49] <jochen__> nice
[11:29:56] <hbono> danno_: can you re-open the tree? I assume the bot will cycle green.
[11:30:24] <danno_> hbono: with pleasure :-)
[11:30:52] <hbono> danno_: thanks a lot.
[11:32:14] *** abarth is now known as abarth|zZz
[11:33:07] <trungl-bot> Tree opened by danno at google dot com: Tree is open ("Chromium Mac" cycling green, Mac10.6 Perf(2) needs a hard reboot)
[11:33:53] <danno_> trungl-bot: rapture!
[11:33:53] <trungl-bot> danno_: Error: "rapture!" is not a valid command.
[11:35:24] <jochen__> what's up with Google Chrome Mac?
[11:35:29] <jochen__> it fails to compile for a while now
[11:36:31] <jochen__> and the perf regression looks pretty serious
[11:50:07] *** homata___ has joined #chromium
[11:52:35] *** dave_levin has quit IRC
[11:53:04] *** homata_ has quit IRC
[11:53:14] *** leavittx has quit IRC
[11:53:59] *** leavittx has joined #chromium
[11:55:18] *** homata___ has quit IRC
[12:00:20] <trungl-bot> Tree opened by timurrrr at chromium dot org: Tree is open ("Chromium Mac" cycling green, Mac10.6 Perf(2) needs a hard reboot; TSan bots -> timurrrr is trying new TSan binaries)
[12:00:23] *** masterov has quit IRC
[12:02:57] *** mains_power has joined #chromium
[12:03:12] *** mains_power has quit IRC
[12:03:29] *** masterov has joined #chromium
[12:04:34] *** leavittx has quit IRC
[12:06:19] *** leavittx has joined #chromium
[12:09:51] *** mains_power has joined #chromium
[12:10:03] *** davirtavares has joined #chromium
[12:10:13] <mains_power> How do I download the Linux Chromium source code?
[12:11:26] <trungl-bot> Tree opened by danno at google dot com: Tree is open (Mac10.6 Perf(2) needs a hard reboot; TSan bots -> timurrrr is trying new TSan binaries)
[12:13:13] <danno_> mains_power: http://code.google.com/p/chromium/wiki/LinuxBuildInstructions
[12:13:31] *** fusion44 has left #chromium
[12:16:32] *** hrna has quit IRC
[12:20:39] *** hbono has quit IRC
[12:22:36] *** hbono has joined #chromium
[12:24:38] *** hbono has left #chromium
[12:25:05] *** hbono has joined #chromium
[12:36:45] *** hbono has quit IRC
[12:55:11] *** chzealot has joined #chromium
[12:55:20] *** chzealot has left #chromium
[13:07:06] <mains_power> You can't just read the whole source tree
[13:07:11] <mains_power> it would take a loooong time
[13:07:13] <mains_power> would it not?
[13:07:24] <mains_power> 1.2GB
[13:07:36] *** ebraminio has quit IRC
[13:12:39] *** chrisccoulson has quit IRC
[13:13:58] <mnissler> mains_power: see http://dev.chromium.org/developers/how-tos/get-the-code and http://code.google.com/p/chromium/wiki/UsingGit
[13:20:07] *** aroben has joined #chromium
[13:20:07] *** aroben has joined #chromium
[13:21:54] *** oki- has joined #chromium
[13:22:16] *** monreal_ has quit IRC
[13:22:18] <oki-> hello, i have two questions
[13:22:20] *** Emperorlou has joined #chromium
[13:23:07] <oki-> is it planned to have a changelog or "note by the developer" implemented in extensions when an extension is automatically updated?
[13:23:39] <oki-> and why is the address bar blank with chrome-extension:// urls openend by extensions?
[13:24:18] *** Martijnc has joined #chromium
[13:26:22] *** monreal has joined #chromium
[13:36:28] <mains_power> how long does it take to build chrome?
[13:38:55] *** hrna has joined #chromium
[13:40:36] *** tonikitoo has quit IRC
[13:43:02] *** andrix has joined #chromium
[13:49:09] *** GeekShadow has joined #chromium
[13:51:17] *** mazda has quit IRC
[14:01:30] *** oki-- has joined #chromium
[14:03:11] *** oki- has quit IRC
[14:08:36] *** General13372 has joined #chromium
[14:11:16] *** General1337 has quit IRC
[14:11:34] *** aroben is now known as aroben|away
[14:17:52] *** fusion44 has joined #chromium
[14:22:18] *** pinkerton has joined #chromium
[14:22:18] *** ChanServ sets mode: +v pinkerton
[14:22:28] *** sergey_miryanov has quit IRC
[14:22:31] *** pinkerton is now known as pink_panera
[14:25:34] *** oki-- has quit IRC
[14:27:37] *** Viclame has joined #chromium
[14:28:52] *** tonikitoo has joined #chromium
[14:33:54] *** FullFlannelJacke has joined #chromium
[14:40:24] *** tonikitoo has quit IRC
[14:42:42] *** aroben|away is now known as aroben
[14:45:03] *** tonikitoo has joined #chromium
[14:45:23] *** AaronMT has joined #chromium
[14:45:41] *** dhollowa_ has joined #chromium
[14:49:18] *** chrisccoulson has joined #chromium
[14:50:29] *** tfarina has quit IRC
[14:55:42] *** jrmuizel has joined #chromium
[14:58:17] *** awolfson has quit IRC
[15:00:10] *** rohitrao has joined #chromium
[15:00:10] *** ChanServ sets mode: +v rohitrao
[15:05:17] <pink_panera> morning
[15:05:17] *** pink_panera has quit IRC
[15:05:28] *** pinkerton has joined #chromium
[15:05:28] *** ChanServ sets mode: +v pinkerton
[15:05:36] *** pinkerton is now known as pink_panera
[15:05:38] <pink_panera> whee
[15:05:51] * pink_panera throttles colloquy
[15:10:42] *** lzheng has quit IRC
[15:10:54] *** lzheng has joined #chromium
[15:10:54] *** ChanServ sets mode: +v lzheng
[15:11:13] *** FullFlannelJacke has quit IRC
[15:12:16] *** andybons has joined #chromium
[15:12:16] *** ChanServ sets mode: +v andybons
[15:12:31] *** phrearch has joined #chromium
[15:12:32] *** marklarson has quit IRC
[15:12:32] *** malavv has quit IRC
[15:12:32] *** jschuh_ has quit IRC
[15:12:32] *** cpu has quit IRC
[15:12:32] <phrearch> hi
[15:12:39] <pink_panera> hi
[15:13:01] *** peper has quit IRC
[15:13:06] <phrearch> im trying to debug some js code, but chromium keeps cache every time of the old version. any idea how i can force chromium to use the new ?
[15:13:32] *** skenmy has quit IRC
[15:13:52] <andybons> rohitrao: ping
[15:13:59] <rohitrao> andybons: sup
[15:14:10] <andybons> rohitrao: are you running the dev channel?
[15:14:11] *** peper has joined #chromium
[15:14:22] <andybons> rohitrao: i just got downgraded to 5.0.350.0 unknown
[15:14:28] <rohitrao> 6.0.466.4
[15:14:33] <rohitrao> haha, weird
[15:14:44] <andybons> wtf. people hate me
[15:14:49] *** stoyan has quit IRC
[15:15:14] <pink_panera> if (ip == [andybons getIPAddr]) { [andybons screw]; }
[15:15:16] <rohitrao> who owns the update configs?
[15:15:42] *** FullFlannelJacke has joined #chromium
[15:15:46] <andybons> rohitrao: seems like i'm the only one who got screwed
[15:15:58] <pink_panera> well, in a sample size of 2
[15:16:27] <rohitrao> if we're only pushing at x%, that might make sense
[15:16:39] <rohitrao> but i thought it was all or nothing for the dev channel
[15:16:57] <motownavi> sample of 3: I'm 466 too
[15:17:22] *** zaspire has quit IRC
[15:17:23] *** Guest74342 has joined #chromium
[15:17:28] <pink_panera> when did we cut 466? is that a new one, or from 2 wks ago?
[15:17:56] <rohitrao> last week, seems like?
[15:18:01] *** leavittx has quit IRC
[15:18:02] <rohitrao> we're up to 473 now
[15:19:13] *** zaspire has joined #chromium
[15:20:30] *** stoyan has joined #chromium
[15:20:30] *** ChanServ sets mode: +v stoyan
[15:21:11] *** malavv has joined #chromium
[15:21:11] *** jschuh_ has joined #chromium
[15:21:11] *** cpu has joined #chromium
[15:21:11] *** verne.freenode.net sets mode: +v cpu
[15:22:06] *** dave_levin has joined #chromium
[15:22:20] *** Beetny` has joined #chromium
[15:22:27] *** RT|Chatzilla has quit IRC
[15:23:21] *** Dykam has quit IRC
[15:23:41] *** praseodym has quit IRC
[15:24:09] *** mattijle has quit IRC
[15:24:10] *** Dykam has joined #chromium
[15:24:12] *** mattijle has joined #chromium
[15:24:26] *** Beetny has quit IRC
[15:24:38] *** japhet has quit IRC
[15:24:41] *** malavv has quit IRC
[15:24:49] *** japhet has joined #chromium
[15:24:49] *** ChanServ sets mode: +v japhet
[15:25:25] *** praseodym has joined #chromium
[15:25:32] *** RT|Chatzilla has joined #chromium
[15:25:34] *** mattm_g has quit IRC
[15:25:47] *** cpu has quit IRC
[15:28:27] *** rohitrao has quit IRC
[15:29:13] *** wyfrn has joined #chromium
[15:29:38] *** jrmuizel has quit IRC
[15:30:14] *** mattm_g has joined #chromium
[15:30:14] *** ChanServ sets mode: +v mattm_g
[15:31:17] *** jschuh_ has quit IRC
[15:32:14] *** Guest74342 has quit IRC
[15:32:36] *** Herald has quit IRC
[15:33:18] *** Herald has joined #chromium
[15:34:07] *** skenmy^ has joined #chromium
[15:35:24] <pink_panera> sigh. last time i built on this laptop was june 4th
[15:35:29] <pink_panera> that's not going to help me one bit.
[15:36:07] *** jrmuizel has joined #chromium
[15:39:25] *** dmaclach has joined #chromium
[15:39:39] *** leeight has joined #chromium
[15:39:43] *** leeight has left #chromium
[15:42:06] *** dave_levin_ has joined #chromium
[15:44:02] *** dave_levin_ has quit IRC
[15:44:18] *** dave_levin has quit IRC
[15:52:29] *** dmaclach_ has joined #chromium
[15:52:29] *** dmaclach has quit IRC
[15:52:30] *** dmaclach_ is now known as dmaclach
[15:53:25] *** cbentzel has joined #chromium
[15:53:25] *** ChanServ sets mode: +v cbentzel
[15:54:04] *** Precea[BNC] is now known as Precea
[15:55:12] *** dr_win has joined #chromium
[15:55:21] *** dmaclach has quit IRC
[15:56:38] *** Singularity has quit IRC
[16:00:09] *** rickspencer3 has joined #chromium
[16:00:35] *** trungl has joined #chromium
[16:00:35] *** ChanServ sets mode: +v trungl
[16:01:44] *** skenmy^ is now known as skenmy
[16:02:14] *** skenmy is now known as Guest97418
[16:04:04] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 53178: cbentzel at chromium dot org)
[16:04:20] *** awolfson has joined #chromium
[16:04:58] *** Venom_X has joined #chromium
[16:05:14] *** agl has joined #chromium
[16:05:14] *** ChanServ sets mode: +v agl
[16:05:53] <agl> cbentzel: see the tree?
[16:06:40] *** shreyas_ has joined #chromium
[16:07:07] <trungl-bot> Tree opened by danno at google dot com: Tree is open (flaky Unexpected PDB error; UNKNOWN (24) -> cycling green)
[16:07:45] <danno_> agl: i'm on sheriff duty, I saw it
[16:08:10] <trungl-bot> Tree opened by agl at chromium dot org: Tree is open (flaky Unexpected PDB error; UNKNOWN (24) -> cycling green)
[16:08:13] <agl> danno_: ok, thanks. I usually assume that there's nobody around in the morning
[16:09:19] <danno_> agl: one man's morning is another one's late afternoon. I'm in Munich.
[16:09:30] *** rickspencer3 has quit IRC
[16:11:02] *** mihaip has joined #chromium
[16:11:03] <cbentzel> reverting
[16:11:29] <danno_> cbentzel: why reverting? I don't think you cause this
[16:11:32] <cbentzel> Actually, that is unrelated build problem with what i did
[16:11:40] <cbentzel> danno_: Was my knee jerk reaction
[16:12:04] <danno_> cbentzel: np
[16:12:43] *** rickspencer3 has joined #chromium
[16:12:55] *** gavinp has quit IRC
[16:13:06] <pink_panera> back in 15 from home.
[16:13:10] *** pink_panera has quit IRC
[16:13:43] *** jrmuizel has quit IRC
[16:14:05] *** rsesek has joined #chromium
[16:14:05] *** ChanServ sets mode: +v rsesek
[16:17:00] *** ctruta has joined #chromium
[16:19:44] *** tedoc2000 has joined #chromium
[16:19:51] *** thakis_ has quit IRC
[16:19:58] *** kermit has quit IRC
[16:20:27] *** hebz0rl has joined #chromium
[16:23:19] *** mihaip has quit IRC
[16:23:22] *** mains_power has quit IRC
[16:23:44] <agl> danno_: may I close the tree to sync up for a GRD change?
[16:24:25] *** pinkerton has joined #chromium
[16:24:25] *** ChanServ sets mode: +v pinkerton
[16:24:28] <pinkerton> back
[16:25:16] <danno_> agl: there's not much going on anyway, go ahead
[16:26:36] <agl> thanks
[16:27:17] *** mazda has joined #chromium
[16:27:21] <trungl-bot> Tree closed by agl at chromium dot org: Tree is closed (syncing for GRD change)
[16:27:30] *** shreyas_ has quit IRC
[16:28:19] *** rickspencer3 has left #chromium
[16:28:58] <pinkerton> andybons: do you need to mark that bug as formerge so we don't forget the cl?
[16:29:21] <andybons> pinkerton: the m6ui bug?
[16:29:24] <andybons> yeah
[16:29:24] <pinkerton> yeah
[16:29:34] <andybons> doing now
[16:29:40] <pinkerton> thx
[16:31:05] <pinkerton> i'm relieved to see this tab facelift so far hasn't regressed the startup time bot
[16:31:18] <pinkerton> seems like everything we did previously would
[16:31:30] <pinkerton> keeping fingers crossed for the shadows.
[16:31:40] *** mazda has quit IRC
[16:32:43] *** mazda has joined #chromium
[16:32:43] *** ChanServ sets mode: +v mazda
[16:33:01] *** shreyas_ has joined #chromium
[16:34:33] *** FullFlannelJacke has quit IRC
[16:36:11] <pinkerton> andybons: there's a CALayer concept called shadowPath that I learned about at wwdc. it makes drawing shadows really fast.
[16:36:16] <pinkerton> andybons: that might help as well
[16:36:29] <pinkerton> but i don't know if it would require making things layers that currently aren't
[16:37:11] *** malavv has joined #chromium
[16:40:43] *** rohitrao has joined #chromium
[16:40:53] *** ChanServ sets mode: +v rohitrao
[16:42:04] *** thakis_ has joined #chromium
[16:42:04] *** ChanServ sets mode: +v thakis_
[16:43:56] <pinkerton> i just got this error on 10.6: "Xcode was unable to stop sharing this machine for shared workgroup builds (distcc).
[16:43:56] <pinkerton> The release note 'Troubleshooting Problems with Sharing Your Computer for Distributed Builds' "
[16:44:02] <pinkerton> but I can't find that release note anywhere
[16:44:08] <pinkerton> pointers?
[16:45:00] <pinkerton> oh wait, i think i found something
[16:45:28] *** ctruta has quit IRC
[16:45:46] <rohitrao> why would you want to stop sharing? :(
[16:46:02] *** FullFlannelJacke has joined #chromium
[16:46:23] <rsesek> rohitrao: using performSelector:withDelay: fixes the issue, so it definitely was the modal loop that was causing wonkiness
[16:46:43] <pinkerton> rohitrao: because it's broken :)
[16:46:54] <rohitrao> haha
[16:47:06] <rohitrao> rsesek: good to know.  I think that's ok to delay
[16:47:14] <rsesek> rohitrao: delay=0.0
[16:47:23] <rsesek> that just forces it to schedule a timer on the outermost runloop
[16:47:49] <rohitrao> rsesek: yeah, I just always worry about objects getting destroyed in the meantime :)
[16:48:04] <rohitrao> but toggling fullscreen shouldn't matter at all
[16:48:06] <rsesek> we use this trick a lot, so it should be okay
[16:49:20] *** jrmuizel has joined #chromium
[16:50:51] <pinkerton> weird, my other machine no longer shows up in bonjour
[16:50:57] <pinkerton> yet i can vnc to it, and ping it.
[16:51:11] *** trungl_ has joined #chromium
[16:51:11] *** ChanServ sets mode: +v trungl_
[16:51:16] <thakis_> morning folks!
[16:51:24] <rsesek> morning thakis!
[16:51:26] <trungl_> thakis_!
[16:51:28] <thakis_> if you feel like doing me a favor, star http://code.google.com/p/support/issues/detail?id=4244 !
[16:51:35] <thakis_> if you don't, do it anyway!
[16:51:44] *** agayev has joined #chromium
[16:51:50] <rohitrao> huh, apparently the UI breaks if you remove all the views and forget to add them back
[16:52:05] <pinkerton> oh, xcode was lying to me
[16:52:08] <pinkerton> yay.
[16:52:17] *** dglazkov has joined #chromium
[16:52:17] *** ChanServ sets mode: +v dglazkov
[16:52:23] <rsesek> thakis: I also don't get why some autocompletes use : and some use =
[16:52:27] <rsesek> the inconsistency hurts me
[16:53:00] <trungl_> rohitrao: I would have thought that would improve the UI
[16:53:08] <rohitrao> ouch
[16:53:23] <rohitrao> thakis: I think they just need to default to the "what-you-typed" match?
[16:53:25] <trungl_> rohitrao: you know, make it even more minimal
[16:54:11] *** trungl__ has joined #chromium
[16:54:11] *** ChanServ sets mode: +v trungl__
[16:54:53] <pinkerton> rohitrao: less is more
[16:55:02] *** trungl has quit IRC
[16:55:02] *** trungl__ is now known as trungl
[16:55:08] <pinkerton> trungl: if the entire ui disappeared until you moused over it?
[16:56:17] <trungl> pinkerton: I think only the bits of UI within say 50 pixels of the cursor should be visible
[16:57:16] <rsesek> trungl: can I send you a CL?
[16:57:21] <rsesek> s/can/may
[16:57:31] *** trungl_ has quit IRC
[16:57:48] <trungl> rsesek: you may, but I may not get back to you for an hour or two
[16:57:59] *** bradnelson has joined #chromium
[16:57:59] *** ChanServ sets mode: +v bradnelson
[16:58:06] <rsesek> trungl: okay. tree is closed. and it's small
[17:02:55] *** trungl_ has joined #chromium
[17:02:55] *** ChanServ sets mode: +v trungl_
[17:05:04] *** ctruta has joined #chromium
[17:05:10] *** trungl_ has quit IRC
[17:05:48] *** MikeSmithW3C has joined #chromium
[17:06:25] <thakis_> rsesek: send it to me, i have time now
[17:06:34] <rsesek> thakis: http://codereview.chromium.org/3014021/show
[17:07:01] <dglazkov> good morning, Chromium!
[17:07:02] <trungl-bot> dglazkov: Good morning!
[17:07:18] *** trungl has quit IRC
[17:07:23] <rsesek> the DPB flake is going to hold up the tests of the grd change
[17:07:27] <rsesek> *PDB
[17:07:36] <rsesek> clobbering may help?
[17:08:11] <rsesek> danno_ / agl: ^ maybe clobber chromium builder dbg and reopen?
[17:08:51] <pinkerton> shess: ping?
[17:09:19] <thakis_> good morning, Dglazkov!
[17:09:31] <agl> danno_: I think the tree is ready to open
[17:09:39] <agl> danno_: so your call if you wish to clobber
[17:10:10] <rsesek> all of the gray tests on windows are because the dbg builder didn't produce a binary, so they'll sit like that until they do
[17:10:19] <danno_> agl: dunno, don't have enough experience with the PDB problem to know if it will help
[17:10:50] <jochen__> i'd suggest to clobber it
[17:10:52] <jochen__> can't hurt
[17:10:58] <danno_> agl: but it's been broke for 6 builds, probably wouldn't hurt
[17:11:01] *** tonyg-cr has joined #chromium
[17:11:01] *** ChanServ sets mode: +v tonyg-cr
[17:11:16] <agl> danno_: I don't even know where the clobber button is these days
[17:11:23] <agl> anyone care to press it?
[17:11:26] <rsesek> I'll do it
[17:11:41] <jochen__> same place as ever
[17:13:18] <jochen__> anybody got a second to review http://codereview.chromium.org/3020018
[17:13:19] <rsesek> hmmm it's not going for me
[17:13:34] <jochen__> i clobber them
[17:14:06] *** fta has joined #chromium
[17:14:35] <jochen__> dan's doing it :)
[17:14:55] *** erlehmann has joined #chromium
[17:14:57] <jochen__> go, danno, go
[17:15:04] <erlehmann> hello there
[17:15:18] <danno_> clobbered!
[17:16:33] *** davemoore has joined #chromium
[17:16:33] *** ChanServ sets mode: +v davemoore
[17:17:43] *** MikeSmithW3C has quit IRC
[17:18:14] *** MikeSmithW3C has joined #chromium
[17:18:14] *** bradnelson has quit IRC
[17:18:20] *** mrossetti has joined #chromium
[17:21:44] *** bradnelson has joined #chromium
[17:21:45] *** ChanServ sets mode: +v bradnelson
[17:21:48] *** phrearch has left #chromium
[17:23:10] *** fta_ has joined #chromium
[17:24:35] *** fta has quit IRC
[17:24:40] *** fta_ is now known as fta
[17:25:54] *** ctruta has quit IRC
[17:26:13] <trungl-bot> Tree opened by agl at chromium dot org: Tree is open (Chromium Builder (dbg) needs a clobber? Mac10.6 Perf(2) needs a hard reboot; TSan bots -> timurrrr is trying new TSan binaries)
[17:26:20] *** wyfrn has quit IRC
[17:28:15] <trungl-bot> Tree opened by danno at google dot com: Tree is open (TSan bots -> timurrrr is trying new TSan binaries)
[17:28:44] *** sanjeevr has joined #chromium
[17:28:47] *** awidegreen has joined #chromium
[17:34:10] *** jibot has joined #chromium
[17:34:43] *** dmaclach has joined #chromium
[17:35:24] *** ebraminio has joined #chromium
[17:37:52] *** sanjeevr1 has joined #chromium
[17:37:52] *** ChanServ sets mode: +v sanjeevr1
[17:39:14] *** sanjeevr has quit IRC
[17:44:53] *** mazda has quit IRC
[17:45:15] *** ctruta has joined #chromium
[17:49:13] <thakis_> haven't written perl in ages
[17:49:14] <thakis_> http://codepad.org/seuCEpR0
[17:50:24] <rsesek> thakis: why you not use python?
[17:50:29] <thakis_>  1785 files changed, 17082 insertions(+), 0 deletions(-)
[17:51:35] *** thakis_ has quit IRC
[17:57:50] *** senorblanco has joined #chromium
[17:57:50] *** ChanServ sets mode: +v senorblanco
[17:57:53] *** fta_ has joined #chromium
[17:58:19] *** trungl has joined #chromium
[17:58:19] *** ChanServ sets mode: +v trungl
[17:58:28] *** oki- has joined #chromium
[17:58:45] *** rdsmith has joined #chromium
[17:58:46] <oki-> is the gallery user count update delayed today?
[17:58:54] *** fta has quit IRC
[17:59:05] *** ChanServ sets mode: +v rdsmith
[17:59:09] *** fta_ is now known as fta
[18:02:39] *** arv has joined #chromium
[18:03:11] *** Erkan_Yilmaz has joined #chromium
[18:04:09] <senorblanco> webkit roll incoming
[18:06:15] <thakis> rsesek: 'cause stuff like this is less convenient in python
[18:06:34] <rsesek> but? perl
[18:06:43] <thakis> rsesek: python's import lines would be longer than the whole perl "program"
[18:06:54] <thakis> it's the right tool for some things
[18:07:01] * rsesek shudders
[18:07:04] <thakis> not for programming
[18:07:14] <thakis> but for things like this it's good
[18:07:31] *** BCalvignac has joined #chromium
[18:08:09] <pinkerton> heh
[18:08:28] *** star-affinity has quit IRC
[18:09:54] *** FullFlannelJacke has quit IRC
[18:10:50] <trungl-bot> Tree closed by evan at chromium dot org (:evmar): closed, letting bots catch up (TSan bots -> timurrrr is trying new TSan binaries)
[18:12:32] <evmar> i'd be very surprised if include guard spam helped the build at all
[18:12:48] <evmar> and sad too, cause that is uggggly
[18:14:07] <rsesek> I need someone with a 10.5 box to test something. pinkerton or thakis ? either of you free?
[18:14:38] <pinkerton> sure, though i don't have a dev setup on my 10.5 box
[18:14:46] <rsesek> pinkerton: that's fine. this is just a test app
[18:15:04] *** romainhuet has quit IRC
[18:15:14] *** romainhuet has joined #chromium
[18:15:30] <pinkerton> rsesek: sure, email or put it on your www share
[18:15:30] <rsesek> pinkerton: http://www.corp.google.com/~rsesek/chrome/MenuButton.app.zip ? can you test the click-drag-release semantics?
[18:15:39] <pinkerton> sure
[18:15:52] <rsesek> the buttons are in the view menu. when you click-drag-release, the label will turn to the title of the button
[18:15:59] <rsesek> thanks
[18:16:49] *** [Nef] has quit IRC
[18:17:04] <pinkerton> nope, no workie
[18:17:09] <rsesek> :(
[18:17:26] <rsesek> anything in Console?
[18:17:29] *** ebraminio has quit IRC
[18:17:49] <rsesek> it works so beautifully in SL
[18:17:59] * rsesek curses Leopard. again.
[18:18:15] <pinkerton> heh
[18:18:50] *** ebraminio has joined #chromium
[18:19:54] * pinkerton spends the day with pixie and twiddling constants
[18:19:59] <rsesek> pinkerton: anything in console?
[18:20:03] <rsesek> or does it just not owrk
[18:20:27] <pinkerton> hitTest = (null)
[18:20:31] <pinkerton> twice
[18:20:39] <rsesek> hm
[18:20:45] <rsesek> that's weird
[18:20:54] <pinkerton> then when it works, i get hitTest = (null) followed by segment = 0
[18:21:04] <rsesek> it does work?
[18:21:05] <pinkerton> it works if i click/release/click, as expect
[18:21:06] <pinkerton> ed
[18:21:10] <rsesek> ah
[18:21:47] <evmar> win compile fail
[18:21:53] <rsesek> the code is fairly straightforward. I don't get why this wouldn't work
[18:22:12] <pinkerton> maybe post to frameworksIT?
[18:22:25] <pinkerton> brb gonna grab some food
[18:22:28] *** oki- has quit IRC
[18:23:01] <evmar> ...\chrome_frame\buggy_bho_handling.cc(105) :error C2664: 'ATL::CCritSecLock::CCritSecLock(CRITICAL_SECTION &,bool)' : cannot convert parameter 1 from 'ATL::CComCriticalSection' to 'CRITICAL_SECTION &'
[18:23:15] <evmar> tommi: you
[18:24:11] <evmar> tommi: are you on it, or want a revert?
[18:24:59] <trungl-bot> Tree closed by evan at chromium dot org (:evmar): closed (win compile fail -> tommi, TSan bots -> timurrrr is trying new TSan binaries)
[18:25:20] <pinkerton> anyone seen shess around yet today?
[18:25:51] <sanjeevr1> evmar: Are you reverting?
[18:26:57] *** johnny_g has joined #chromium
[18:26:57] *** ChanServ sets mode: +v johnny_g
[18:26:58] *** ejat has joined #chromium
[18:27:29] <pinkerton> rohitrao: can you answer a question about StyledTextFieldCell?
[18:27:32] <evmar> sanjeevr1: go for it
[18:27:38] <rsesek> pinkerton: he's at lunch
[18:27:39] <evmar> sanjeevr1: maybe ping tommi yourself
[18:27:58] <pinkerton> slacker
[18:28:00] <evmar> sanjeevr1: tommi is just my guess based on where it's failing and his commit message
[18:28:05] <ejat> http://code.google.com/p/chromium/issues/detail?id=35198 <-- any comment on the issue
[18:28:07] <rsesek> allays
[18:28:17] *** webclientthakis has joined #chromium
[18:28:40] <evmar> ejat: see comment 169
[18:28:41] <sanjeevr1> It is tommi
[18:29:01] *** oshima_ has joined #chromium
[18:30:53] <bradnelson> Somebody reverting tommi's change?
[18:31:03] <sanjeevr1> YEah I am on it
[18:31:20] <pinkerton> i really wish i knew why my profile can't submit bugs any more
[18:31:33] <rsesek> pinkerton: did you clear your cookies and cache?
[18:31:40] <pinkerton> yes
[18:31:45] <pinkerton> it's something else
[18:31:52] <rsesek> what happens in incognito?
[18:32:08] <pinkerton> haven't tried that
[18:32:13] *** nsylvain has quit IRC
[18:32:20] <pinkerton> yay, copying from a text field removes the text and you can't undo!
[18:32:20] <bradnelson> sanjeevr1: k, thanks
[18:32:21] <sanjeevr1> Reverted
[18:32:47] <ejat> evmar: http://paste.ubuntu.com/467098/
[18:33:49] <evmar> ejat: put it on the bug!  :)
[18:34:14] <evmar> ejat: i know nothing about this bug, i just saw he requested some more info and then 10 more people commented with "it also affects me, but i won't provide any information to help"  :(
[18:35:20] <pinkerton> rsesek: incognito is broken too
[18:36:21] <rsesek> pinkerton: weeeeird
[18:36:24] <rohitrao> pinkerton: back
[18:36:56] <pinkerton> rohitrao: do you know much about how we use StyledTextFieldCell?
[18:37:07] <trungl-bot> Tree closed by sanjeevr at chromium dot org: closed (reverted 53194, TSan bots -> timurrrr is trying new TSan binaries)
[18:37:19] *** mihaip has joined #chromium
[18:37:19] *** ChanServ sets mode: +v mihaip
[18:37:48] <sanjeevr1> bradnelson: I need to catch a shuttle, can you reopen the tree if it turns green?
[18:38:05] <evmar> sanjeevr1: i will if he doesn't. go catch your shuttle! :)
[18:38:15] <webclientthakis> pinkerton: it's used for the omnibox i think. if that's the question.
[18:38:21] <shess> pinkerton: I know!
[18:38:32] <bradnelson> sanjeevr1: k, will do, run run
[18:38:38] <sanjeevr1> Thx :)
[18:38:53] <rohitrao> pinkerton: it's just a common base class for the omnibox and findbar
[18:38:54] <shess> once upon a time, someone noticed that omnibox had crap on the edges, and findbar had crap on the edges, so StyledTextFieldCell became the repo for "text cell with crap on the edges."
[18:39:17] <shess> nowadays the omnibox cell is so wicked custom that I'm not entirely convinced that sharing code actually gains anything.
[18:39:33] <rohitrao> or maybe we should share more code ;)
[18:39:40] *** andrix has quit IRC
[18:40:02] <pinkerton> shess: cole wants the omnibox to have a light bezel below it to match what we've added to the tab strip
[18:40:11] <shess> mocks?
[18:40:19] <rohitrao> but not the find bar?
[18:40:19] <pinkerton> shess: should i conditionalize that for the omnibox, or should i just put that in StyledTextField for everything?
[18:40:21] <pinkerton> idk
[18:40:32] <dcheng> Does git cl patch not handle patching in patches that remove files?
[18:40:32] <pinkerton> i can email mocks if you want
[18:40:35] <dcheng> It keeps saying patch does not apply.
[18:40:38] *** fqian has joined #chromium
[18:40:38] <pinkerton> of course they're not posted anywhere
[18:40:42] <rohitrao> mocks would be nice :)
[18:40:58] <pinkerton> give me a min to finish sending another email
[18:41:11] *** RT|Chatzilla has quit IRC
[18:41:25] <shess> oh, I see, you're planning to do it.
[18:41:28] <shess> hmm
[18:42:12] <shess> so far we've done things like -cornerRadius to allow them to differentiate themselves.
[18:43:04] <pinkerton> right, just wondering if i should do something like that
[18:43:10] <pinkerton> or not bother
[18:43:58] <pinkerton> shess / rohitrao: forwarded mocks
[18:44:50] <shess> well, they need to differentiate themselves somehow, right?  I'm not sure refactoring is great post-freeze, so I'd support hacking it in with a TODO bug for someone to clean it up later.  If you didn't notice, I don't really care for StyleTextFieldCell :-).
[18:45:00] <pinkerton> right now i have the findbar drawing it too, and it doesn't look bad but it doesn't fit in with the buttons to the right of it either.
[18:45:12] <pinkerton> but then again, who am i to say what looks good any more?
[18:45:27] *** markmentovai has joined #chromium
[18:45:28] *** ChanServ sets mode: +v markmentovai
[18:46:19] <trungl-bot> Tree opened by bradnelson at google dot com: open (cycling green, go slow, TSan bots -> timurrrr is trying new TSan binaries)
[18:47:35] <pinkerton> shess: i can add a "shouldDrawBezel" method and overrride it in the autocomplete cell if you think that's best
[18:47:36] *** jrforbes_ has joined #chromium
[18:47:57] <shess> dammit.  I see that the findbar buttons are rounded.  which means the LHS of the text area should be rounded.
[18:48:03] <tommi> sherrifs: I'm fixing the build break.  Sorry :(
[18:48:09] <pinkerton> shess: heh
[18:48:19] <shess> pinkerton: I think that's probably ... adequate.  I hates it.
[18:48:37] <pinkerton> what part do you hate? that it's there, or that it's conditional?
[18:48:48] <bradnelson> tommi: its been reverted, so take your time :-)
[18:49:26] <shess> I hate that the "shared" code is going to end up with a half-dozen exposed overrides to support the unshared portion, and it will be impossible to follow.
[18:49:36] <rohitrao> the main point of sharing a base class was just to get the two fields drawing the same
[18:49:37] <rohitrao> I think
[18:49:45] <shess> yeah - and they don't :-).
[18:49:46] <rohitrao> the decoration stuff was an added bonus
[18:49:57] <rohitrao> they still draw the same border and focus rect
[18:50:01] <pinkerton> and shadow
[18:50:14] <pinkerton> i think these minor differences handled by overrides are ok
[18:50:24] <tommi> ah
[18:50:35] <pinkerton> i mean, it's not like side tabs :)
[18:50:43] <tommi> bradnelson: thanks.  for some reason it doesn't break on my machine
[18:50:44] <rohitrao> ooh, the findbar could totally use side tabs
[18:50:52] <rohitrao> what if you want to search for multiple things?
[18:51:05] <pinkerton> or if you have multiple search pasteboards!
[18:51:15] <pinkerton> apple could add it any day now!
[18:51:20] <pinkerton> we must prepare!
[18:51:29] *** arv has quit IRC
[18:51:30] <shess> A styled_text_field_util.h which exported the drawing bits would handle it just as well without the subclassing.
[18:52:28] <rohitrao> shess: was going to suggest that.  M7? :)
[18:52:40] <rohitrao> this is basically how we handle drawing the window background
[18:52:50] <pinkerton> i never really cared for that pattern, you still then have to make sure the two users call everything in the same order and the right way
[18:52:55] <pinkerton> so they can easily get out of sync
[18:52:59] <rohitrao> which is sorta shared between the real window and the fullscreen window
[18:53:07] *** dave_levin has joined #chromium
[18:53:07] *** ChanServ sets mode: +v dave_levin
[18:54:06] *** andrix has joined #chromium
[18:54:27] <pinkerton> when you have to start documenting the util functions with "call this first" "call X after Y" "must call this last so it shows up on top" etc, you've failed.
[18:56:01] *** arv has joined #chromium
[18:56:01] *** ChanServ sets mode: +v arv
[18:56:04] <shess> pinkerton: I was thinking more along the lines of taking -drawWithFrame:inView: and extracting that into something where you passed in the rounded and the bezeled and the wicked-cool-glow-effect-thing.  Everything else would just be slipstreamed to the subclass (which already has to know all that crap intimately anyhow).
[18:56:38] <pinkerton> ah
[18:57:25] *** dmaclach has quit IRC
[18:59:03] *** johnny_g has quit IRC
[18:59:09] *** johnny_g has joined #chromium
[18:59:09] *** ChanServ sets mode: +v johnny_g
[18:59:20] <shess> But when we're doing things like pasting buttons and fields together and expecting them to look visually unified, I'm kind of fine having them be similar unshared implementations.  If we were talking about a dozen subclasses, wonderful, but after a year we still have exactly two.
[18:59:27] *** johnny_g has quit IRC
[18:59:36] *** bweinstein has joined #chromium
[18:59:54] *** dmaclach has joined #chromium
[18:59:58] *** johnny_g has joined #chromium
[18:59:58] *** ChanServ sets mode: +v johnny_g
[19:01:18] *** loislo has quit IRC
[19:01:43] *** arv has quit IRC
[19:02:01] *** arv has joined #chromium
[19:02:01] *** ChanServ sets mode: +v arv
[19:03:20] <pinkerton> shess: i'll have a cl for you momentarily
[19:05:10] <evmar> it is too bad all of this code you're writing is mac-specific, too
[19:05:29] <evmar> i would like to do vector gfx on other platforms but the thought of writing that code over again in skia makes my brain hurt
[19:06:03] <pinkerton> what do you think this is? xul?
[19:06:10] <evmar> :D
[19:06:15] *** phajdan-jr has joined #chromium
[19:06:15] *** ChanServ sets mode: +v phajdan-jr
[19:06:56] <evmar> not the "position buttons on the toolbar" code, but the "draw a button to a pixel buffer using a bunch of canvas api calls"
[19:07:55] <shess> the thought of writing that code to be cross-platform makes my brain hurt.
[19:08:15] <shess> [Unless you want the skia version to look identical to Mac :-).]
[19:08:15] <evmar> i guess we have some sort of canvas abstraction at the chrome layer
[19:08:29] <evmar> yeah, i do.  why wouldn't i?
[19:08:42] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Mac10.6 Tests" from 53199: dhollowa at chromium dot org, mirandac at google dot com, sanjeevr at chromium dot org)
[19:08:52] <evmar> it's not like you do anything crazy like close boxes on the left :P
[19:09:44] <dhollowa> DeleteNotifications is flakey, 10.6 tests are ok i believe
[19:10:58] <bradnelson> dhollowa: safe to reopen?
[19:11:13] <dhollowa> i believe so, yes
[19:11:19] <pinkerton> shess: are all the methods in the header for StyledTextFieldCell "protected"? ie, nobody calls them outside of the implementation besides subclasses?
[19:11:29] <bradnelson> dhollowa: k
[19:11:33] <shess> should be.
[19:11:43] <pinkerton> shess: if so i'd like to move them into a separate category to indicate that, so people don't try to call them.
[19:12:44] <trungl-bot> Tree closed by bradnelson at google dot com: closed
[19:13:05] * evmar woke up early today to get his change in
[19:13:15] <maruel> I didn't and I regret
[19:13:41] <pinkerton> shess: cl to you
[19:13:58] <phajdan-jr> sheriffs, compile failure is me :-/
[19:14:02] <phajdan-jr> I'll fix in seconds
[19:14:33] <shess> pinkerton: if you add a category, maybe you could also add include guards :-).
[19:14:38] <sanjeevr1> phajdan-jr: OK
[19:14:38] <pinkerton> heh ok
[19:14:46] <trungl-bot> Tree closed by bradnelson at google dot com: closed (x64 -> pawel)
[19:15:03] <bradnelson> phajdan-jr: ok, I'll hold off on revert
[19:15:59] <phajdan-jr> bradnelson: thanks, fix in
[19:17:37] <pinkerton> andybons: yay safari!
[19:17:53] <andybons> pinkerton: wha safari?
[19:17:59] <pinkerton> filing duplicate bugs
[19:18:13] <andybons> pinkerton: ah. haha
[19:18:48] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (compile -> phajdan.jr; sorry; fix in; trybots were green)
[19:21:18] *** agayev has quit IRC
[19:23:30] *** fantasticulous has joined #chromium
[19:26:48] <phajdan-jr> dhollowa: ping
[19:26:53] <trungl-bot> Tree opened by bradnelson at google dot com: open (TSan bots -> timurrrr is trying new TSan binaries)
[19:27:00] <dhollowa> phajdan-jr: yes
[19:27:21] *** oshima__ has joined #chromium
[19:27:24] <phajdan-jr> dhollowa: are you going to disable TopSitesTest.DeleteNotifications?
[19:27:29] *** oshima__ has quit IRC
[19:27:31] <dhollowa> doing it now, yes
[19:27:37] <dhollowa> phajdan-jr: marking as flakey
[19:27:42] <phajdan-jr> dhollowa: no, that won't work
[19:27:46] *** trungl has quit IRC
[19:27:53] *** trungl has joined #chromium
[19:27:53] *** ChanServ sets mode: +v trungl
[19:27:58] <phajdan-jr> dhollowa: it crashes entire unit_tests, and FLAKY makes it still run. You want DISABLED.
[19:28:32] <dhollowa> phajdan-jr: ah, ok, thanks.  i'll mark DISABLED then.
[19:28:40] <phajdan-jr> thanks!
[19:28:46] <dhollowa> np
[19:28:53] *** moblin- has joined #chromium
[19:29:04] *** agayev has joined #chromium
[19:29:06] *** dmaclach has quit IRC
[19:29:12] <moblin-> hello, why are chrome-extension:// URLs hidden?
[19:29:48] *** chrisccoulson has quit IRC
[19:31:10] *** oshima_ has quit IRC
[19:31:12] *** IRWolfie- has joined #chromium
[19:31:21] *** csilv has joined #chromium
[19:31:21] *** ChanServ sets mode: +v csilv
[19:31:46] <dhollowa> phajdan-jr: http://codereview.chromium.org/2832066
[19:32:42] *** dmaclach has joined #chromium
[19:32:50] <IRWolfie-> does chromium have a limit on the number of simultaneous downloads?
[19:33:06] <phajdan-jr> dhollowa: LGTM with a comment
[19:33:11] <IRWolfie-> doesn't seem to allow above 6
[19:33:48] <IRWolfie-> (from the one site)
[19:34:03] <moblin-> and is there a way to force chrome to show them?
[19:34:28] *** oshima_ has joined #chromium
[19:35:08] <maruel> if gclient breaks in the next minutes, it's my fault, please ping me
[19:35:48] *** lca has joined #chromium
[19:36:18] <bradnelson> maruel: :-)
[19:36:28] <phajdan-jr> IRWolfie-: I'm not sure, it can be something in the download code, or a lower-level network stack code.
[19:36:42] <phajdan-jr> IRWolfie-: the best thing to do is probably to file a good bug, with reliable steps to reproduce
[19:37:24] <stuartmorgan> Unless the specs have changed to not recommend limiting persistent connections, it's presumably intentional
[19:38:23] <phajdan-jr> stuartmorgan: but if it's surprising for the user, it might be a good idea to display some info what happened and why
[19:38:52] *** chrisccoulson has joined #chromium
[19:41:06] *** fta has quit IRC
[19:41:31] <mirandac> ui_tests are me, reverting, will fix and recommit.
[19:41:51] *** fantasticulous has quit IRC
[19:42:49] *** davirtavares has quit IRC
[19:43:50] *** fusion441 has joined #chromium
[19:44:01] <trungl-bot> Tree opened by mirandac at chromium dot org: open (TSan bots -> timurrrr is trying new TSan binaries, ui_tests should cycle green)
[19:44:13] <pinkerton> shess: bezel is already on the tabs and tab strip on the trunk
[19:44:47] <moblin-> come on googlers, you must know why :/
[19:44:53] *** fusion44 has quit IRC
[19:45:01] *** pfeldman_ has quit IRC
[19:45:09] <shess> pinkerton: is there going to be one on the button hovers?
[19:45:31] <phajdan-jr> moblin-: might be better to ask on chromium-dev ML
[19:45:36] <pinkerton> shess: i don't think so
[19:45:46] <pinkerton> shess: maybe a small shadow, but that's not coming until later
[19:46:01] <shess> pinkerton: sigh.  thought omnibox and buttons were supposed to more-or-less match in the vertical.
[19:46:09] <pinkerton> take it up with cole please
[19:47:01] <shess> pinkerton: what do you think of the popup versus the bezel?  popup is 2 pixels down, third pixel is border (a dark alpha).
[19:47:21] <pinkerton> popup?
[19:47:40] <phajdan-jr> dhollowa: your test disabling change broke the compile
[19:47:48] <shess> omnibox popup
[19:47:48] <pinkerton> shess: idk, it looks fine to me
[19:47:54] <phajdan-jr> dhollowa: you can fix it by using FRIEND_TEST_ALL_PREFIXES from base.gtest_prod_util.h
[19:48:03] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder x64" from 53211: ahendrickson at google dot com, albertb at chromium dot org, ananta at chromium dot org (:iyengar), dhollowa at chromium dot org, mirandac at google dot com, stuartmorgan at chromium dot org)
[19:48:14] <IRWolfie-> I was thinkining that it must be a deliberate limit since it stops at exactly 6,  "save link as" will not display a dialog box until there are 5 downloads from the site (firefox allows above 6)
[19:48:27] <IRWolfie-> s/5/6/
[19:48:55] <IRWolfie-> I'll file a bug anyway and see what the response is
[19:49:07] *** abarth|zZz is now known as abarth
[19:49:26] <shess> pinkerton: seems kinda like there's multiple light/shadow transitions to me :-).
[19:49:55] <shess> pinkerton: OK, I'm going to stop questioning the UI, now.  Because I'm sure it will change.
[19:49:56] <pinkerton> idk. i just match the pictures cole gives me
[19:49:58] <pinkerton> :)
[19:50:07] <pinkerton> i'll ask him when he comes back online
[19:50:16] <dhollowa> compile fail is mine.  missed friend test.  working on it.
[19:50:27] <bradnelson> dhollowa: k
[19:52:06] <trungl-bot> Tree closed by bradnelson at google dot com: closed (ui_tests -> dhollowa)
[19:52:22] *** SixEcho has joined #chromium
[19:52:58] <phajdan-jr> bradnelson: I'll apply a long-term fix, will land in minutes
[19:52:59] *** estes has joined #chromium
[19:53:07] <trungl-bot> Tree closed by bradnelson at google dot com: closed ( -> dhollowa)
[19:53:40] <SixEcho> if about:memory shows several tabs/pids with no tab names ? does that indicate a problem? (orphaned tab)?  or is that some other way to represent extensions?
[19:55:33] <IRWolfie-> aha , it's a site limited, but firefox allows me to choose save location where as chrome waits for download to become possible before prompting
[19:57:02] *** johnny_g has quit IRC
[19:57:19] *** maikmerten_ has joined #chromium
[19:57:20] *** johnny_g has joined #chromium
[19:57:21] *** ChanServ sets mode: +v johnny_g
[19:57:29] *** johnny_g has quit IRC
[19:58:11] <phajdan-jr> bradnelson: fix in
[19:58:12] *** johnny_g has joined #chromium
[19:58:12] *** ChanServ sets mode: +v johnny_g
[19:58:13] <phajdan-jr> dhollowa: fix in
[19:58:32] *** ahendrickson has joined #chromium
[19:58:32] *** ChanServ sets mode: +v ahendrickson
[19:59:00] *** johnny_g has quit IRC
[19:59:10] <phajdan-jr> and now cycle, cycle, cycle... green?
[19:59:14] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (compile -> dhollowa, phajdan.jr landed the fix)
[19:59:40] *** webclientthakis has quit IRC
[19:59:49] <phajdan-jr> SixEcho: yeah, I think it's sort of a minor bug
[19:59:52] *** maikmerten has quit IRC
[19:59:55] *** kurrik has joined #chromium
[19:59:55] *** ChanServ sets mode: +v kurrik
[19:59:59] <pinkerton> shess: updated version posted
[20:00:19] *** moblin- has quit IRC
[20:00:28] <dhollowa> phajdan-jr: thx!
[20:00:41] *** johnny_g has joined #chromium
[20:00:52] *** ChanServ sets mode: +v johnny_g
[20:01:27] *** beng has joined #chromium
[20:01:28] *** ChanServ sets mode: +v beng
[20:01:39] *** mathrick has joined #chromium
[20:01:53] *** johnny_g has quit IRC
[20:01:58] <mathrick> hey guys, is web inspector known to be broken in latest nightlies on linux?
[20:02:07] <mathrick> I see nothing in the element pane
[20:02:18] <mathrick> all the other panes seem functional, but the element tree is completely empty
[20:02:24] *** johnny_g has joined #chromium
[20:02:24] *** ChanServ sets mode: +v johnny_g
[20:02:41] <phajdan-jr> mathrick: are you using a non-C and non-English locale?
[20:02:49] <mathrick> yes, da_DK.UTF-8
[20:03:01] *** johnny_g has quit IRC
[20:03:53] <mathrick> phajdan-jr: is that a known thing?
[20:04:04] <phajdan-jr> mathrick: could you do a bug lookup, and if you don't find anything, file a bug and post the URL here?
[20:04:09] <mathrick> sure
[20:04:18] <phajdan-jr> mathrick: one of Gentoo Linux users has reported it to distro Bugzilla
[20:04:26] <phajdan-jr> mathrick: now it sounds like an upstream issue
[20:04:36] <mathrick> OK
[20:04:45] *** johnny_g has joined #chromium
[20:04:45] *** ChanServ sets mode: +v johnny_g
[20:04:56] *** johnny_g has quit IRC
[20:05:27] *** johnny_g has joined #chromium
[20:05:27] *** ChanServ sets mode: +v johnny_g
[20:05:30] <mathrick> phajdan-jr: http://code.google.com/p/chromium/issues/detail?id=49494
[20:05:39] *** johnny_g has quit IRC
[20:05:48] <mathrick> and http://code.google.com/p/chromium/issues/detail?id=49418
[20:06:45] *** malavv_ has joined #chromium
[20:06:45] <bradnelson> phajdan-jr: doesn't seem to have worked...
[20:06:54] *** crashbug has joined #chromium
[20:07:04] <mathrick> phajdan-jr: it seems to happen on en-US as well
[20:07:10] *** malavv_ has quit IRC
[20:07:34] <crashbug> hi, the latest Chromium build from http://build.chromium.org/buildbot/snapshots/chromium-rel-xp/53206/ crashes on exit
[20:08:00] <crashbug> Alt+F4 or click the wrench and exit, crashes Chromium
[20:08:40] *** IRWolfie- has left #chromium
[20:08:52] <phajdan-jr> bradnelson: a typo, fising in seconds
[20:08:53] *** Peter- has quit IRC
[20:08:57] <phajdan-jr> sorry :(
[20:09:21] *** loislo has joined #chromium
[20:09:43] <phajdan-jr> mathrick: thanks, looking now
[20:09:50] <mathrick> sure
[20:10:02] <mathrick> I'll try working in en-US in the meantime
[20:11:24] <mathrick> yup, any en locale seems to fix it actually, including en_GB
[20:11:35] <pinkerton> shess: ok, i changed it to NSRectFill
[20:11:46] <pinkerton> sorry, i didn't understand what point you were making before
[20:11:56] *** rniwa has joined #chromium
[20:11:56] *** ChanServ sets mode: +v rniwa
[20:12:54] *** hclam has joined #chromium
[20:17:12] *** kermit has joined #chromium
[20:17:46] *** Peter- has joined #chromium
[20:19:44] <phajdan-jr> bradnelson: looks like this time the fix worked; still cycling on win though
[20:19:59] *** mihaip has quit IRC
[20:20:29] *** arv has quit IRC
[20:20:35] *** arv has joined #chromium
[20:20:35] *** ChanServ sets mode: +v arv
[20:20:38] *** dr_win has quit IRC
[20:21:03] *** arv has quit IRC
[20:21:33] <trungl-bot> Tree opened by bradnelson at google dot com: open (go SLOW, TSan bots -> timurrrr is trying new TSan binaries)
[20:21:33] *** arv has joined #chromium
[20:21:33] *** ChanServ sets mode: +v arv
[20:23:13] <phajdan-jr> going to land a patch
[20:24:46] *** rafaelw has joined #chromium
[20:24:46] *** ChanServ sets mode: +v rafaelw
[20:24:48] *** oshima_ has quit IRC
[20:25:06] *** mihaip has joined #chromium
[20:25:06] *** ChanServ sets mode: +v mihaip
[20:25:29] *** webclientthakis has joined #chromium
[20:26:09] <dcheng> Does anyone know why git cl patch complains that 'patch does not apply' when I try to apply a patch the removes files?
[20:27:37] <phajdan-jr> dcheng: might be a bug. Try running the git command it runs manually, it should give better error message.
[20:27:55] * pinkerton watches rsesek typing
[20:28:08] <rsesek> creepy
[20:28:11] <pinkerton> yes.
[20:28:52] <dcheng> Ah... now it complains that the removal patch leaves file contents
[20:29:15] <dcheng> Which is strange, since pre-removal, the files were the exact same size on both systems.
[20:30:09] <shess> pinkerton: in case I wasn't clear - if NSRectFill() works, then all LGTM.
[20:30:24] <pinkerton> shess: yeah, i just wanted to let you know
[20:30:38] <pinkerton> i'm waiting on my try job
[20:30:47] <senorblanco> danno_, bradnelson, sanjeevr1:  WebKit roll incoming
[20:30:51] <pinkerton> heh
[20:32:04] *** jshin has joined #chromium
[20:32:04] *** ChanServ sets mode: +v jshin
[20:32:24] <sanjeevr1> senoblaco: OK
[20:33:03] <bradnelson> senorblano: you wanna close the tree for it? ;-)
[20:33:17] <senorblanco> your call.
[20:34:11] <bradnelson> senorblanco: k, I'm gonna close it for a sec, since we've got a few changes in the pipe
[20:34:40] <trungl-bot> Tree closed by bradnelson at google dot com: closed for webkit landing...
[20:36:14] *** shreyas_ has quit IRC
[20:36:46] * pinkerton twiddles thumbs for the tree
[20:38:33] <shess> rohitrao: you have time to hit up my ev-bubble CL?
[20:38:57] <shess> rohitrao: I guess merging-to-branch is merging-to-branch, just want to make sure you aren't in layers hell or something.
[20:39:29] * rohitrao needs to learn to refresh the codereview page in the morning
[20:39:50] <rohitrao> (looking)
[20:40:14] *** victorw has left #chromium
[20:41:56] *** shreyas_ has joined #chromium
[20:42:43] *** erlehmann has quit IRC
[20:43:57] *** [Nef] has joined #chromium
[20:44:12] <rsesek> pinkerton: the click-drag-release may not be fixable on 10.5
[20:44:51] <pinkerton> rsesek: ok
[20:44:51] *** trungl_ has joined #chromium
[20:44:51] *** ChanServ sets mode: +v trungl_
[20:45:09] <pinkerton> i'd definitely post to frameworksIT then about it
[20:45:10] <rsesek> pinkerton: I'll put the details as to why in the bug report. but I guess this will be 10.6 only
[20:45:15] *** trungl has quit IRC
[20:45:15] *** trungl_ is now known as trungl
[20:45:18] <pinkerton> they may know the magic
[20:46:07] *** mihaip has quit IRC
[20:47:12] *** kbrosnan has quit IRC
[20:48:17] *** MikeSmithW3C has quit IRC
[20:49:37] <rohitrao> trungl: in fullscreen mode, is the tabstrip extra-tall to include space for the menu?
[20:49:49] <rohitrao> or do we just set its frame to be a bit lower down?
[20:49:54] <trungl-bot> Tree opened by bradnelson at google dot com: open (go SLOW, TSan bots -> timurrrr is trying new TSan binaries)
[20:50:07] <trungl> rohitrao: I believe so
[20:50:21] <rohitrao> ok, that makes more sense
[20:50:38] <rohitrao> (assuming you answered yes to my first question, not my second)
[20:51:09] <trungl> rohitrao: oh, you had a second question
[20:51:22] <rohitrao> well, one question with two options
[20:52:54] * trungl always chose C.
[20:53:02] <trungl> (this explains his grades)
[20:55:05] *** mihaip has joined #chromium
[20:55:05] *** ChanServ sets mode: +v mihaip
[20:56:33] <webclientthakis> rohitrao: extra-tall iirc
[20:56:47] <rohitrao> hehe, I just decided the opposite
[20:57:00] <trungl-bot> Tree opened by timurrrr at chromium dot org: open (go SLOW)
[20:57:07] <rohitrao> maxY is set to (shownFraction*height) - verticalOffsrt
[20:57:08] * webclientthakis goes SLOW
[20:57:11] <rohitrao> offset even
[20:57:26] <webclientthakis> rohitrao: bah, all fancy with your looking at the code
[20:57:40] <rohitrao> i just spent 10 minutes trying to figure out why this worked
[20:57:45] <rohitrao> maybe that means we need more comments
[20:57:48] <rohitrao> more comments!
[20:57:55] <rohitrao> or less code
[20:58:04] <webclientthakis> or better variable names
[20:58:08] <webclientthakis> that solves everything
[20:58:12] * trungl votes for less code
[20:58:23] <webclientthakis> scrolling too slow? rename the scrolling funtion to fastScroll()
[21:00:58] <pinkerton> so gcl commit no longer checks to see if a cl has passed the try servers?
[21:01:13] <pinkerton> intentional, or bug?
[21:01:55] *** elliottcable has quit IRC
[21:02:28] *** elliottcable has joined #chromium
[21:02:28] <jibot> elliottcable is teh suxxor
[21:02:43] *** fantasticulous has joined #chromium
[21:04:56] *** MikeSmithW3C has joined #chromium
[21:05:36] *** maikmerten_ has quit IRC
[21:06:54] *** phajdan-jr is now known as phajdan-jr|afk
[21:07:46] <trungl> pinkerton: I thought gcl commit was supposed to remind you now
[21:07:49] * trungl shrugs
[21:07:53] * trungl uses git-cl
[21:08:04] <pinkerton> i get no warnings about anything
[21:08:46] *** ctruta has quit IRC
[21:08:49] <pinkerton> builders are starting to get behind
[21:09:05] *** ctruta has joined #chromium
[21:15:00] *** bulach has joined #chromium
[21:15:00] *** ChanServ sets mode: +v bulach
[21:16:36] <davidben> Has anyone ever seen "error: RPC failed; result=22, HTTP code = 502" when fetching from the git mirror? I've been getting that a lot lately.
[21:16:46] <inferno-sec> looks like bugdroid is down! can anyone kick it ?
[21:17:04] *** Darxus has joined #chromium
[21:17:19] *** mlloyd has quit IRC
[21:18:23] <Darxus> Is there a bug open somewhere for passing the Internet Explorer Testing Center?  http://samples.msdn.microsoft.com/ietestcenter/
[21:18:28] <pinkerton> brb
[21:18:33] *** trungl has quit IRC
[21:24:33] <crashbug> the latest Chromium build 53222 doesn't crash anymore on exit, thanks for the fix
[21:25:11] *** kbrosnan has joined #chromium
[21:27:56] *** chocobo__ has joined #chromium
[21:27:56] *** ChanServ sets mode: +v chocobo__
[21:29:10] *** jamesr has joined #chromium
[21:29:10] *** ChanServ sets mode: +v jamesr
[21:33:16] *** loislo_ has joined #chromium
[21:35:22] *** loislo has quit IRC
[21:35:22] *** loislo_ is now known as loislo
[21:40:01] *** shreyas_ has quit IRC
[21:40:36] <Viclame> entonces vamos a suponer que calcula bien
[21:40:57] <Viclame> i'm sorry, wrong window :S
[21:41:31] <pinkerton> at least it's not your password
[21:43:08] *** ib3rnd has joined #chromium
[21:43:21] *** ctruta_ has joined #chromium
[21:44:57] *** shreyas_ has joined #chromium
[21:46:15] <rohitrao> hunter2?
[21:46:15] *** mac-mini1 has joined #chromium
[21:46:53] <andybons> pinkerton: which cell class should I be looking in for the toolbar buttons?
[21:47:10] *** ctruta has quit IRC
[21:47:10] *** ctruta_ is now known as ctruta
[21:47:12] <andybons> pinkerton: gradient button cell?
[21:47:20] <pinkerton> yes
[21:47:26] *** affix has joined #chromium
[21:47:30] <andybons> pinkerton: k
[21:48:09] <andybons> pinkerton: loving all the "clean this up" commentary in there...
[21:48:19] <pinkerton> from trung? yeah
[21:50:19] *** Guest1718 has joined #chromium
[21:50:57] *** ib3rnd has quit IRC
[21:51:16] *** fubd has joined #chromium
[21:53:46] *** fubd has left #chromium
[21:54:36] *** chrisccoulson has quit IRC
[21:56:31] <jrg> pinkerton mark ping
[21:56:39] <pinkerton> pong
[21:56:43] <pinkerton> im getting on bridge
[21:56:50] <jrg> OK I'll be right there
[21:56:51] <markmentovai> jrg: i will dial in
[21:56:54] *** fantasticulous has quit IRC
[21:56:54] *** elliottcable has quit IRC
[21:56:55] *** crashbug has quit IRC
[21:56:55] *** hebz0rl has quit IRC
[21:56:55] *** tedoc2000 has quit IRC
[21:56:55] *** stoyan has quit IRC
[21:56:56] *** |fbt| has quit IRC
[21:56:56] *** mabbo has quit IRC
[21:56:56] *** akalin has quit IRC
[21:57:23] *** ctruta has quit IRC
[21:57:32] *** stoyan has joined #chromium
[21:57:32] *** ChanServ sets mode: +v stoyan
[21:57:35] *** rdsmith has quit IRC
[22:00:19] *** tedoc2000 has joined #chromium
[22:01:19] *** akalin has joined #chromium
[22:01:24] *** |fbt| has joined #chromium
[22:01:30] *** jcivelli has quit IRC
[22:01:44] *** Darxus has left #chromium
[22:01:52] *** Guest1718 has quit IRC
[22:03:33] *** elliottcable has joined #chromium
[22:03:33] <jibot> elliottcable is teh suxxor
[22:06:21] <andybons> pinkerton: bam. two line change: http://cl.ly/82679eda514ef51e75b5
[22:07:52] *** mabbo has joined #chromium
[22:08:18] *** isherman has joined #chromium
[22:08:19] *** ChanServ sets mode: +v isherman
[22:08:36] *** fta has joined #chromium
[22:09:04] *** hebz0rl has joined #chromium
[22:09:15] <pinkerton> andybons: wow, cool
[22:09:20] <pinkerton> what did you do?
[22:09:29] *** Mikey has joined #chromium
[22:09:29] <jibot> Mikey is always erasing jibot's memory and defined again, much to his chagrin and someone who doesn't like definitions. and no longer having anything known about him by jibot.
[22:09:36] <andybons> pinkerton: there was already a shadow on the templated images. i just upped the opacity to 1
[22:09:44] *** fantasticulous has joined #chromium
[22:09:56] *** Mikey is now known as Guest94198
[22:10:00] <pinkerton> hm. ask cole if that's what he intended. clearly he wrote a lot of code to do....something for this
[22:10:34] <andybons> pinkerton: that's a different one. embossing the icons.
[22:10:38] *** Guest94198 has quit IRC
[22:10:43] <pinkerton> rohitrao: have the find next/prev arrows changed lately?
[22:10:51] <pinkerton> rohitrao: they're gone on ToT waterfall builds
[22:11:05] <andybons> rohitrao: just noticed that, too.
[22:11:38] <pinkerton> wondering if it's the same problem as with the NTB, but i don't think those icons have changed
[22:12:09] *** Mikey_ has joined #chromium
[22:13:26] *** andrix has quit IRC
[22:13:55] *** Mikey_ has joined #chromium
[22:14:12] <shess> rohitrao: OK see pink was bugging you, so I'll bug you.
[22:14:22] <pinkerton> lol
[22:14:39] <pinkerton> if even i notice something, it's gotta be bad!
[22:14:51] <shess> rohitrao: WRT SetLabel() versus SetFullLabel(), WDYT about just moving all of those to protected:, so that users of the subclasses don't abuse them as data storage?
[22:15:30] <shess> rohitrao: if subclasses want to make that decision, they can just provide an inline function.
[22:15:37] *** dr_win has joined #chromium
[22:16:20] *** hebz0rl has quit IRC
[22:17:20] *** Mikey_ has quit IRC
[22:18:01] *** Mikey_ has joined #chromium
[22:18:26] *** Mikey_ has joined #chromium
[22:19:45] *** Mikey_ has joined #chromium
[22:20:15] *** Mikey_ has joined #chromium
[22:21:39] *** Mikey_ has joined #chromium
[22:22:32] *** Mikey_ has joined #chromium
[22:22:35] *** Mikey_ has quit IRC
[22:23:26] *** shreyas_ has quit IRC
[22:23:35] *** dr_win has quit IRC
[22:24:36] <lca> is it possible to build chromium in mac osx 10.5?
[22:25:10] <pinkerton> yes, mostly, but you might run out of address space linking
[22:26:04] *** Darxus has joined #chromium
[22:26:13] <Darxus> I need some kind of special access to mark one bug as blocking another?
[22:26:31] <sanjeevr1> The "run out of address space while linking" issue is happening for me everytime on 10.5. Any known workarounds?
[22:26:52] <lca> pinkerton: is there any workaround?
[22:26:54] <dcheng> sanjeevr1: You can try disabling SVG, but the fix is to upgrade to 10.6.
[22:27:07] *** fta_ has joined #chromium
[22:27:08] <pinkerton> lca: disable things, like svg, until it links
[22:27:09] <dcheng> Or just don't build unit tests.
[22:27:32] *** ctruta has joined #chromium
[22:27:46] <pinkerton> if you just build the chrome target, you should be ok, but if you build all, you'll certainly fail on unit tests
[22:28:02] *** fta has quit IRC
[22:28:03] *** fta_ is now known as fta
[22:28:12] <Darxus> I don't think this bug should have been deleted:  http://code.google.com/p/chromium/issues/detail?id=49823
[22:28:35] <Darxus> If it makes sense for the 294 bugs to be created individually, they should be listed as blocking that one.
[22:28:53] *** monreal has quit IRC
[22:28:54] *** shreyas_ has joined #chromium
[22:29:12] <lca> pinkerton: I am building just chrome and it is not working. how do I disable svg?
[22:29:23] <sanjeevr1> I am builing just the Chrome target. I get "can't map file, errno=12" in libwebore.a while linking
[22:29:36] <pinkerton> rsesek gave me the magic last time, i forget it now
[22:29:40] <rsesek> lca:  export GYP_DEFINES="enable_svg=0" gclient runhooks
[22:29:46] <pinkerton> ta da!
[22:29:57] <pinkerton> don't you need a semicolon before gclient?
[22:30:00] <rsesek> probably
[22:30:07] <rsesek> or remove the export
[22:30:57] <lca> rsesek, pinkerton thanks! I will try it.
[22:31:45] *** jshin has quit IRC
[22:31:47] <sanjeevr1> dcheng: Yeah I have been postponing the 106 upgrade :). I have one small bug I need to debug quickly. If I can somehow get it to work once .... :)
[22:31:54] <sanjeevr1> 106 => 10.6
[22:33:07] <jamesr> sanjeevr1: you've disabled SVG?
[22:33:34] <sanjeevr1> jamesr: Trying that right now.
[22:40:51] *** loislo has quit IRC
[22:42:25] *** vrk has joined #chromium
[22:42:25] *** ChanServ sets mode: +v vrk
[22:42:40] *** huanr has joined #chromium
[22:42:40] *** ChanServ sets mode: +v huanr
[22:43:53] *** isherman has quit IRC
[22:44:17] *** Mikey_ has joined #chromium
[22:44:46] *** dr_win has joined #chromium
[22:45:14] *** loislo has joined #chromium
[22:45:21] *** isherman has joined #chromium
[22:45:21] *** ChanServ sets mode: +v isherman
[22:46:24] *** fantasticulous has quit IRC
[22:46:27] *** chocobo__ has quit IRC
[22:48:30] *** isherman has quit IRC
[22:48:44] <thakis> markmentovai: any idea what might cause "interactive_ui_tests[61306:107] Unknown class 'TabStripView', using 'NSView' instead. Encountered in Interface Builder file at path /Volumes/MacintoshHD2/src/chrome-git/src/xcodebuild/Debug/Chromium Framework.framework/Resources/BrowserWindow.nib."?
[22:50:24] <pinkerton> er
[22:51:30] *** barcon332 has quit IRC
[22:51:54] *** shreyas_ has quit IRC
[22:51:57] *** loislo has quit IRC
[22:52:46] *** dr_win has quit IRC
[22:56:54] *** shreyas_ has joined #chromium
[22:58:10] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Linux Builder (ChromiumOS)" from 53241: japhet at chromium dot org, oshima at chromium dot org)
[22:58:32] *** dumi has joined #chromium
[22:58:33] *** ChanServ sets mode: +v dumi
[22:58:43] <oshima> sheriff: looking at it
[22:59:04] <dumi> atwilson: got a minute?
[22:59:13] <bradnelson> oshmia: k
[22:59:21] <bradnelson> oshima: ok
[23:00:12] <trungl-bot> Tree closed by bradnelson at google dot com: closed --> oshima
[23:00:50] <oshima> fix is  coming shortly
[23:01:55] *** hebz0rl has joined #chromium
[23:02:35] *** Viclame has left #chromium
[23:03:28] *** ROBOd has quit IRC
[23:03:36] *** agayev has quit IRC
[23:03:39] *** jshin has joined #chromium
[23:03:39] *** ChanServ sets mode: +v jshin
[23:04:43] <oshima> fix is in http://codereview.chromium.org/2809065. it was merge error. sorry about that.
[23:04:54] <thakis> markmentovai: nvm, looks like interactive_ui_tests isn't built with -Wl,-ObjC yet
[23:04:59] *** BCalvignac1 has joined #chromium
[23:07:05] <markmentovai> thakis: ok. i'm working on the breakpad dev blocker anyway.
[23:07:49] *** [Nef] has quit IRC
[23:08:52] *** BCalvignac has quit IRC
[23:10:59] *** ctruta has quit IRC
[23:11:18] <trungl-bot> Tree closed by oshima at chromium dot org: closed --> (fix is in. waiting for compilation)
[23:12:39] <rohitrao> pinkerton, shess: was hunting down old teammates, back now
[23:12:51] <pinkerton> ok
[23:13:23] *** romainhuet has quit IRC
[23:13:37] <rohitrao> pinkerton: there's a bug filed about missing findbar icons, but I don't see it on local builds
[23:13:46] <pinkerton> right, it only happens on packaged builds
[23:13:51] <pinkerton> like the NTB issue did
[23:14:00] <pinkerton> download a waterfall build and you'll see it
[23:14:06] <oshima> sheriff: chromeos dbg builder is way behind because all tests are failing (due to a bug which is fixed in 453201). can you kill it and start next cycle?
[23:14:09] <rohitrao> ah, ok
[23:14:22] <rohitrao> I'll ask andybons then, cause I think he just redid all the icons
[23:14:33] <mrossetti> When I do a runhooks I get a "Error: Dependency src/tools/grit/grit/test/data specified more than once". Familiar to anyone?
[23:15:34] <andybons> rohitrao: redid all the icons?
[23:15:37] <leiz> go go bugdroid go!
[23:15:49] <rohitrao> andybons: I thought you checked in pdf versions of everything
[23:15:52] <oshima> chromiumos dbg passed compilation. opening tree.
[23:16:04] <rohitrao> andybons: did that include the findbar icons too? because they appear to be gone now :)
[23:16:09] <andybons> rohitrao: not the findbar icons. just toolbar stuff
[23:16:21] <trungl-bot> Tree opened by oshima at chromium dot org: Tree is open (chromeos dbg should cycle green)
[23:16:27] <rohitrao> andybons: ok, I guess I can't blame you then
[23:16:39] <leiz> oshima: want me to kick cros dbg?
[23:16:46] <andybons> rohitrao: i'm sure it's my fault anyway. i'll just let you solve the problem and we'll call it a day
[23:16:52] <rohitrao> sounds good
[23:16:57] <oshima> leiz: i'd appreciate if you can.
[23:17:05] <leiz> oshima: will do
[23:17:16] <oshima> thanks
[23:17:23] <trungl-bot> Tree opened by oshima at chromium dot org: Tree is open (chromiumos builder should cycle green)
[23:18:33] <leiz> evmar: so I just kicked a bot for oshima and I noticed a bunch of xmessage processes in ps
[23:18:45] <leiz> oshima: next cycle has started
[23:19:36] *** trungl has joined #chromium
[23:19:36] *** ChanServ sets mode: +v trungl
[23:19:38] <oshima> leiz, evmar: we need to turn this off for bots.
[23:19:57] *** ahendrickson has quit IRC
[23:20:33] <oshima> leiz: thank you for starting next cycle.
[23:21:58] <oshima> by the way, looks like CheckFalseTest.CheckFails has been failed on Linux Tests 64 and ChromiumOS builder for quite some time. has anyone looked into it?
[23:22:36] *** Perfexion has joined #chromium
[23:22:59] *** Perfexion has left #chromium
[23:24:20] *** lca_ has joined #chromium
[23:24:55] *** Venom_X is now known as Venom_latelnch
[23:27:05] <oshima> phajdan.jr: ping
[23:27:24] *** dr_win has joined #chromium
[23:27:38] <leiz> oshima: I filed bug 49833 for the xmessage issue.
[23:28:02] *** lca has quit IRC
[23:28:02] *** lca_ is now known as lca
[23:28:14] *** hombre_que has joined #chromium
[23:28:22] <oshima> leiz: thanks. i'll look into it.
[23:28:22] <leiz> oshima: you're valgrind sheriff tomorrow, are you warming up by acting as sheriff today? :)
[23:28:53] *** piman_ has joined #chromium
[23:28:53] *** ChanServ sets mode: +v piman_
[23:29:53] *** hombre_que has quit IRC
[23:32:37] *** hclam has quit IRC
[23:33:00] <leiz> oshima: let me see if I can reproduce the checkfails problem
[23:33:39] *** js2 has joined #chromium
[23:33:43] *** shreyas_ has quit IRC
[23:33:47] <oshima> leiz: thanks
[23:33:49] *** cbentzel has quit IRC
[23:34:15] <atwilson> dumi: back
[23:34:28] <leiz> oshima: where's bradnelson? Did you guys swap?
[23:35:00] <dumi> atwilson: question about shared workers. how are they terminated? and do they need to go away within a short time window like the dedicated workers?
[23:35:40] <oshima> leiz: no. i'm just looking at stuff because I broke build:)
[23:35:52] * atwilson is looking at the code to refresh his memory
[23:37:24] *** agl has quit IRC
[23:37:51] <atwilson> The decision to shutdown the shared worker is in WorkerProcessHost::DocumentDetached().
[23:38:10] <atwilson> That fires off a message to the renderer to shutdown the worker.
[23:38:27] <atwilson> I believe the actual "shutdown the worker thread" mechanism is identical for Dedicated and Shared Workers.
[23:38:47] <atwilson> dumi: ^^^
[23:38:54] <atwilson> Does that answer your question?
[23:39:32] <dumi> atwilson: is there a function that's being called whenever a shared worker needs to be shut down?
[23:39:39] <dumi> atwilson: something like Worker::terminate()?
[23:40:11] <atwilson> dumi: Are you talking about the browser process, or the renderer process?
[23:40:16] <atwilson> (worker process)
[23:40:20] *** fta has quit IRC
[23:40:41] <dumi> atwilson: i'm basically looking for a shutdown function that's being called by the non-worker process
[23:40:49] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 53247: ananta at chromium dot org (:iyengar), erg at google dot com (:eglaysher))
[23:40:57] <dumi> atwilson: something that initiates the shutdown
[23:41:08] *** hbono has joined #chromium
[23:41:35] *** eglaysher has joined #chromium
[23:41:35] *** ChanServ sets mode: +v eglaysher
[23:41:36] <jibot> eglaysher is a Chromium Googler.
[23:41:49] <atwilson> dumi: I'm not making myself clear. The shutdown is initiated in WorkerProcessHost::DocumentDetached(), which sends a message to the worker process to shut it down.
[23:42:09] <atwilson> Are you asking me "what code in the webkit repository is invoked to shutdown the shared worker context"?
[23:42:29] <dumi> atwilson: yes, sorry
[23:42:31] <atwilson> WorkerProcessHost::DocumentDetached() executes in the browser process - is that what you want?
[23:42:40] <atwilson> dumi: looking.
[23:42:44] <dumi> atwilson: i need something in webkit
[23:42:57] <dumi> atwilson: thanks, sorry i haven't asked that from the beginning
[23:43:17] <eglaysher> ananta: compile failure?
[23:43:35] <sanjeevr1> Ananta or erg?
[23:43:46] <oshima> leiz: i filed abut for CheckFails. let me know if you want me to make it FAILS_.
[23:43:53] <oshima> s/abut/a bug/
[23:43:54] <eglaysher> it's not me. One of the other builders passed compile with my patch
[23:43:55] <sanjeevr1> Ananta's changes are in ChromeFrame
[23:43:57] <eglaysher> but then failed.
[23:44:28] <eglaysher> ananta's changes are in tab_contents and are the cause.
[23:44:30] <markmentovai> it's ananta
[23:44:33] *** Mikey has joined #chromium
[23:44:33] <jibot> Mikey is always erasing jibot's memory and defined again, much to his chagrin and someone who doesn't like definitions. and no longer having anything known about him by jibot.
[23:44:34] *** Mikey has quit IRC
[23:44:53] <markmentovai> ananta: unguarded #include of a _win.h file (external_tab_container_win.h) from a cross-platform header (tab_contents.h)
[23:45:20] <leiz> oshima: I can't reproduce it locally
[23:45:27] <sanjeevr1> Yeah, pinging Ananta
[23:45:33] *** webclientthakis has quit IRC
[23:45:46] <thakis> is there a difference between ~/.gyp/include.gypi and ~/.gyp/includes.gypi?
[23:45:50] <thakis> do they both work?
[23:45:55] <oshima> leiz: it's pretty consistent. let me try. which build did you test?
[23:45:57] <markmentovai> thakis: include.gypi works
[23:46:07] <markmentovai> includes.gypi is made-up
[23:46:28] <thakis> i thought i used that so far :-P
[23:46:29] <atwilson> dumi: The code path in the worker process is: WebSharedWorkerStub::OnTerminateWorkerContext(), which calls down into WebWorkerBase::stopWorkerThread() in the webkit code, which calls WorkerThread::stop().
[23:46:35] <leiz> oshima: I'm at r53237
[23:46:51] <dumi> atwilson: thanks
[23:46:52] <sanjeevr1> Can't reach Ananta, reverting.
[23:46:54] <trungl-bot> Tree closed by bradnelson at google dot com: closed --> ananta
[23:46:55] <dumi> atwilson: i'll look at that
[23:47:46] <atwilson> dumi: OK, feel free to shoot me an IM or email if you want more info. Shutdown stuff is *really* tricky to get right for workers (as you know :)
[23:48:14] <dumi> atwilson: will do :)
[23:48:54] <sanjeevr1> Reverted
[23:49:55] <trungl-bot> Tree closed by sanjeevr at chromium dot org: closed Reverted 53247, waiting for green
[23:53:12] *** hclam has joined #chromium
[23:54:20] *** lca has quit IRC
[23:55:10] *** hrna has quit IRC
[23:56:28] <leiz> oshima: oh, duh, I did a debug build instead of a release build. trying again.
[23:57:16] <oshima> leiz: i could reproduce on chromium os build.  it's tot.
[23:58:10] *** Venom_latelnch is now known as Venom_X
[23:58:12] <oshima> debug build is failing with check.





top