[00:02:28] <thakis> jochen__: if i can fidn it
[00:03:21] * thakis found a branch called "doitlife" on his mbp
[00:03:22] *** thakis_ has joined #chromium
[00:03:23] *** ChanServ sets mode: +v thakis_
[00:03:40] <markmentovai> rsesek: recall, it?s not an oS, but an Os.
[00:03:51] <rohitrao> hah
[00:03:51] <rsesek> allays
[00:03:53] <thakis> "checking out files XXX of 12000"
[00:04:20] *** rohitrao has quit IRC
[00:05:04] *** thakis_ has quit IRC
[00:05:23] <cpu> jochen__: dbg builder fail
[00:05:25] *** estes has quit IRC
[00:05:45] <thakis> jochen__: http://codereview.chromium.org/3017011
[00:05:50] <markmentovai> cpu: it?s windows pdb crap again, i kicked it for another cycle.
[00:05:53] <thakis> jochen__: it's very rough (as in "crashes on mac")
[00:08:33] *** jrmuizel has quit IRC
[00:09:37] <jochen__> thakis: ta
[00:09:55] *** aroben has quit IRC
[00:11:25] *** yutak_home has joined #chromium
[00:11:26] *** ChanServ sets mode: +v yutak_home
[00:13:22] *** estes has joined #chromium
[00:13:58] *** markusheintz_ has quit IRC
[00:14:59] <thakis> rsesek: i bet it's   [layer setContents:image_.get()];
[00:15:06] <rsesek> what about it?
[00:15:11] <thakis> contents should always be a CGImageRef
[00:15:13] <jochen__> markmentovai: XP Tests is green
[00:15:22] <rsesek> ahhh
[00:15:23] <rsesek> interesting
[00:15:24] <thakis> NSPDFImageRep can't convert to CGImageRef
[00:15:37] <markmentovai> jochen__: gonna wait ?til the debug builder has something for the debug testers to start testing
[00:15:42] <thakis> (NSBitmapImageRep has a CGImage method, but the loaded image contains only NSPDFImageReps)
[00:15:56] <jochen__> sure
[00:16:04] <markmentovai> should only be a couple more minutes
[00:16:23] <markmentovai> oh, not this again
[00:16:43] <rsesek> thakis: so then I haz to convert using CGImageForProposedRect:context:hints:?
[00:17:09] <jochen__> did you just force or also clobber?
[00:17:14] <thakis> rsesek: could work
[00:17:17] <markmentovai> force.
[00:17:19] <thakis> sorry for not catching this :-/
[00:17:22] <markmentovai> this pdb thing is awful.
[00:17:45] <markmentovai> does anyone know what the pdb problem is?
[00:18:03] <jochen__> no, it usually goes away by itself :)
[00:18:31] <rsesek> thakis: or do you think it'd be easier to take over drawing in self as the delegate?
[00:18:33] *** markusheintz_ has joined #chromium
[00:18:34] <thakis> rsesek: "Available in Mac OS X v10.6 and later."
[00:18:41] <thakis> (CGImageForProposedRect:context:hints: on NSImage)
[00:18:48] <rsesek> I HATE YOU 10.5!!!!!
[00:18:58] <leiz> awww
[00:18:58] <thakis> hate apple for making 10.5 so shoddy :-P
[00:19:36] <rsesek> thakis: looks like I can just use drawLayer:inContext: and then just call drawInRect on the NSImage
[00:19:40] * rsesek hopes
[00:19:55] <thakis> rsesek: how can you draw an NSImage to a CGContext?
[00:20:03] <thakis> doesn't that need a conversion to CGImageRef too?
[00:20:41] <rsesek> thakis: don't they push the context so you can just do normal drawing/
[00:20:58] <thakis> don't know
[00:21:04] <rsesek> I'll find out shortly
[00:21:27] <leiz> sigh, tree still closed for grd change. do we have a bounty for the fix yet? I'd be happy to add to it.
[00:21:57] <markmentovai> well, now we?re waiting out rebuilds because of pdb flake.
[00:22:10] <thakis> rsesek: i'll try rendering the nsimage into a cgbitmapcontext in the meantime
[00:22:24] <markmentovai> jochen__ said that the grd fix doesn?t work well with IB, which insists on using its own value for IntDir?
[00:22:36] <jochen__> no
[00:22:46] <jochen__> it insists on intdir being temporary
[00:23:05] <jochen__> but i think i have a work around for it
[00:23:07] <markmentovai> ok. do we lose anything, performance-wise, by using something other than IntDir?
[00:23:14] <markmentovai> if so, do it anyway :)
[00:23:19] <jochen__> hehe
[00:23:27] <jochen__> i guess not, that's what i'm going to do tomorrow
[00:23:42] <jochen__> it's not that this is impssible to do
[00:23:49] <jochen__> it's more that i didn't have time for it before feature freeze
[00:23:59] <thakis> rsesek: this way it works: http://codepad.org/OcjWSunN (code mostly stolen from cocoadev.com)
[00:24:03] <jochen__> also, what i really would love to have was a unit test that actually exhibits this behaviour
[00:24:45] <jochen__> like, you comile something
[00:24:49] <jochen__> change some file
[00:24:53] <jochen__> rebuild
[00:25:06] <markmentovai> jochen__: ought to be possible to write a test like that.
[00:25:10] *** Zontar has joined #chromium
[00:25:10] <jochen__> and somehow the code produces an incorrect result
[00:25:29] <Zontar> chromium
[00:25:35] <markmentovai> correct.
[00:25:55] <Zontar> but why?
[00:26:48] <evmar> Zontar: http://deviantdecorum.files.wordpress.com/2009/01/simplified.jpg
[00:26:54] *** markusheintz_ has quit IRC
[00:26:54] <rsesek> thakis: cool. compiling now using the drawInRect for image
[00:26:59] <Zontar> yes, chromium is a correct word
[00:27:48] *** awidegreen has quit IRC
[00:32:46] <rsesek> thakis: do you have the URL from which that snippet is based so I can attribute properly?
[00:33:24] <markmentovai> do we have any sheriffs on hand? phajdan-jr|afk?
[00:33:30] <markmentovai> doesn?t look promising.
[00:33:31] <Zontar> chromium
[00:33:35] <thakis> rsesek: http://www.cocoadev.com/index.pl?CGImageRef (first hit for "nsimage cgimageref"; i'm a simple man), but it's not really a very original snippet
[00:33:55] <thakis> markmentovai: phajdan-jr|afk is here, should i tell him to pay attention to irc?
[00:33:58] <jamesr> evmar: YEAH
[00:34:03] <Zontar> chromium
[00:34:03] <jamesr> O-KAY
[00:34:07] *** ebraminio1 has joined #chromium
[00:34:10] *** phajdan-jr|afk is now known as phajdan-jr
[00:34:10] <Zontar> chromium
[00:34:16] * phajdan-jr stops being AFK
[00:34:18] <markmentovai> thakis, phajdan-jr: the tree is probably ready to reopen, but i?m leaving
[00:34:22] <Zontar> chromium
[00:34:29] <markmentovai> Zontar: first and final warning.
[00:34:30] <phajdan-jr> markmentovai: I'd prefer to wait for the tests to finish
[00:34:32] <jamesr> Zontar: ok thanks that's enough
[00:34:38] <Zontar> what's enough?
[00:34:53] <markmentovai> phajdan-jr: it's been closed for two hours and it?s feature-freeze day, i'm sure there?s a backlog.
[00:34:54] <jamesr> enough babbling
[00:34:56] <Zontar> but chromium is correct
[00:35:12] <markmentovai> phajdan-jr: the tests will begin and be isolated to jochen__'s checkin
[00:35:37] <phajdan-jr> markmentovai: ok, will throttle manually
[00:35:42] <markmentovai> excellent.
[00:35:45] <Zontar> do you concur?
[00:36:25] *** ebraminio has quit IRC
[00:36:26] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Closed (grd change); please ping phajdan-jr on #chromium if you want to commit
[00:36:54] * bauerb gets in line
[00:37:00] <Zontar> I asked a question
[00:37:53] *** ChanServ sets mode: +o jamesr
[00:38:04] *** shoe has quit IRC
[00:38:27] *** jamesr sets mode: -b JoesphL0t!*@*
[00:38:36] *** ChanServ sets mode: -o jamesr
[00:38:41] *** shoe has joined #chromium
[00:39:22] <phajdan-jr> bauerb: if you have a patch, please post the review link here :)
[00:39:27] <rsesek> thakis: http://www/~rsesek/chrome/pba.zib - plz test
[00:39:38] <thakis> rsesek: 404
[00:39:58] <Zontar> chromium
[00:40:01] <rsesek> thakis: http://www.corp.google.com/~rsesek/chrome/pba.zip
[00:40:11] <bauerb> phajdan-jr: http://codereview.chromium.org/2884024/show
[00:40:14] *** monreal has quit IRC
[00:40:17] <thakis> rsesek: 404
[00:40:18] <Zontar> chromium
[00:40:30] *** ChanServ sets mode: +o jamesr
[00:40:30] <bauerb> phajdan-jr: it's the mac side of jochen__'s patch
[00:40:37] <Zontar> chromium
[00:40:44] <rsesek> thakis: um? I just downloaded it. try going to http://www.corp.google.com/~rsesek/chrome/ and downloading it
[00:40:47] <Zontar> chromium
[00:40:55] <thakis> rsesek: that worked
[00:40:59] <rsesek> wtf
[00:41:00] <rsesek> okay
[00:41:00] <Zontar> chromium
[00:41:14] <cpu> phajdan-jr: can I land http://codereview.chromium.org/2809060/show  ?
[00:41:25] <Zontar> chromium
[00:41:43] <phajdan-jr> bauerb: please give it a trybot run unless you need to land it right now because things will break
[00:41:47] *** Zontar was kicked by jamesr (Zontar)
[00:42:01] <phajdan-jr> cpu: sure, please go ahead
[00:42:07] <thakis> rsesek: animation shows up. repeatedly
[00:42:09] *** Zontar has joined #chromium
[00:42:15] <Zontar> hey what's that
[00:42:17] <rsesek> thakis: are you on popuptest1.html?
[00:42:20] <thakis> it should only trigger if the page action is new
[00:42:22] <thakis> no, 3
[00:42:29] <thakis> also, it animates to the wrong position
[00:42:37] <jamesr> Zontar: stop spamming the channel or you'll be banned
[00:42:49] <bauerb> phajdan-jr: it's pending :-/
[00:42:57] <Zontar> but I only said chromium
[00:43:13] <thakis> rsesek: it shows that animation every 5s or so
[00:43:14] <rsesek> thakis: no. I disagree. take Google Reader. you keep the tab open, pop open a new video to youtube and the it animates. you keep the tab open for days and then repeat. now you forget about it and you get angry and go rawr because there's no animation
[00:43:17] <rsesek> thakis: deliberate
[00:43:25] <phajdan-jr> bauerb: if it can wait, I'd prefer to have confirmed green.
[00:43:43] <jochen__> bauerb: you try again a stale version :)
[00:43:46] <phajdan-jr> at least after the grd fallout is cleaned up
[00:43:52] <Zontar> chromium
[00:44:00] <thakis> rsesek: it plays every 5 seconds on popuptest3.html
[00:44:00] <Zontar> chromium
[00:44:04] *** jamesr sets mode: +b *!*@80-219-8-29.dclient.hispeed.ch
[00:44:04] *** Zontar was kicked by jamesr (Zontar)
[00:44:10] <rsesek> thakis: deliberate. that page opens a new popup every 5s
[00:44:13] *** ChanServ sets mode: -o jamesr
[00:44:20] <bauerb> jochen__: *whistles* that's why i have you to look over it
[00:44:20] <rsesek> thakis: the destination position is good enough. I thought about calculating the precise position to which it should animate, but that seemed like serious overkill. the point is to attract the user to the omnibar. it'd also introduce a dependency on autocomplete, locationbarview, contentsettings, etc.
[00:44:44] <thakis> rsesek: also, it's pretty weird that the icon looks different from the actual icon up there
[00:44:50] <thakis> (i understand that that's no pdf)
[00:45:42] <rsesek> thakis: that image doesn't come as pdf and I don't want to be responsible for changing the omnibox image
[00:46:51] <cpu> phajdan-jr: done
[00:47:49] <dhollowa> phajdan-jr: can i land http://codereview.chromium.org/3041007
[00:48:37] <phajdan-jr> dhollowa: yes, please go ahead
[00:49:34] <cbentzel_> phadjan-jr: Can I land http://codereview.chromium.org/3055001/show
[00:49:35] <bauerb> phajdan-jr: jochen__ is gonna land it tomorrow morning (EST)
[00:49:56] <cbentzel_> phadjan-jr: Still waiting on win trybot, but I have patched it into win locally and net_unittests pass
[00:50:51] <cbentzel_> phadjan-jr: Normally I would wait, but the svn update seems to be taking forever on the win slave. Anything I can do to get it to accelerate?
[00:51:25] <leiz> phajdan-jr: http://codereview.chromium.org/3038009/show, affects official builds only.
[00:51:25] <dhollowa> phajdan-jr: done.  thanks.
[00:52:03] <jamesr> anyone know why i'm getting massive warning spew from inspector_resources.target.mk every time i build?
[00:52:05] <jamesr> on linux
[00:52:30] <tony^work> phajdan-jr: can I check in a webkit roll?
[00:52:45] *** awolfson has quit IRC
[00:52:53] *** bgmerrell has quit IRC
[00:52:57] <leiz> jamesr: I think I did last week, but didn't pay attention to it. see if (a) clobber helps or (b) who touched the corresponding gyp file last.
[00:53:10] <phajdan-jr> leiz: yes, please land
[00:53:23] <phajdan-jr> tony^work: can we wait until the grd fallout cleans up?
[00:53:29] <tony^work> phajdan-jr: sure
[00:53:34] <phajdan-jr> tony^work: I'd appreciate a green trybot results too :)
[00:53:38] <phajdan-jr> just in case
[00:53:47] <tony^work> do green canaries count?
[00:54:15] <phajdan-jr> tony^work: it's a good sign, but if you can, please give them some trybot runs too (e.g. the layout_tests bots)
[00:54:42] *** wyfrn_ has joined #chromium
[00:54:55] <tony^work> well, they're not going to finish the layout_test bots today. I think the windows one can take 2+ hours to run
[00:55:19] <jamesr> tony^work: they see you rollin', they hatin. patrollin' trying t'catch you rolling red in
[00:55:25] <phajdan-jr> tony^work: let's start the try job, not sure how long the tree will stay closed
[00:55:34] <tony^work> yeah, I started the try jobs
[00:55:42] <phajdan-jr> thanks!
[00:55:52] <shess> phajdan-jr: Could I land Mac-only http://codereview.chromium.org/2870059 ?
[00:55:55] <jamesr> the canaries run the fill layout test suite
[00:56:00] *** victorw has left #chromium
[00:56:03] <leiz> markmentovai: btw, with the "Google Chrome Mac" official bot down, we might not catch build errors with the breakpad roll.
[00:56:04] <jamesr> so i don't think the layout_test bots will provide any additional coverage
[00:56:13] <jamesr> and by 'fill' i of course mean 'full'
[00:56:30] <phajdan-jr> shess: you've got a green light to land!
[00:56:37] <shess> thx!
[00:57:17] *** fusion44 has left #chromium
[00:57:37] <cbentzel_> phajdan-jr: Can I land http://codereview.chromium.org/3055001/show (sorry, mis-spelled your name before). Waiting for Win but have patched and tested locally. I understand if I need to wait for win trybot.
[00:58:03] * thakis dislikes the new "new tab" button on mac
[00:58:17] * shess agrees with thakis
[00:58:27] <akalin> there's a new tab button?
[00:58:45] <shess> plus button right of rightmost tab?
[00:58:51] <akalin> oh
[00:59:02] <akalin> who doesn't use Cmd/Ctrl-T for a new tab??
[00:59:18] <phajdan-jr> cbentzel_: please wait for green win and ping me back. sorry you have to wait. :-/
[00:59:21] <leiz> people without keyboards?
[00:59:28] <akalin> leiz: good point
[00:59:28] <shess> akalin: yeah, but the button is there no matter how you do it.
[00:59:52] <akalin> would it be better or worse if it were evmar's head
[00:59:55] <jamesr> akalin: i have no command button, you insensitive clod
[01:00:05] <davidben> phajdan-dr: May I land http://codereview.chromium.org/2962018/show ? It's Mac-only.
[01:00:05] <akalin> jamesr: nor a Ctrl button?
[01:00:17] <akalin> condolences :(
[01:00:29] <shess> and it currently looks ick, at least on the theme in my dev chromium (star gazing)
[01:00:34] <phajdan-jr> davidben: green light, go ahead
[01:01:06] <shess> ok, I don't like it for the default theme, either.  looks like a mistake or something.
[01:01:41] <leiz> alyssad: yesterday, a lady showed me ~10 video clips, and easy time she used the mouse to drag the quicktime window so it's almost full screen
[01:01:49] <leiz> akalin: err ^
[01:02:02] <akalin> leiz: on the mac?
[01:02:21] <leiz> akalin: I wondered why didn't just press alt+f, and then I realized her keyboard tray is folded in
[01:02:23] <cbentzel_> phajdan-dr: May I land http://codereview.chromium.org/3014014/show
[01:02:39] <leiz> gah, can't type today, s/why/why she/
[01:02:47] <phajdan-jr> tony^work: could you take a look at these webkit failures: http://build.chromium.org/buildbot/waterfall/builders/Webkit%20%28dbg%29%283%29/builds/19241/steps/webkit_tests/logs/stdio ?
[01:02:54] *** bauerb has quit IRC
[01:03:16] <thakis> markmentovai: is every committer able to change the buildbot configs?
[01:03:20] <thakis> or only troopers?
[01:03:29] <leiz> akalin: basically many users only use the keyboard to type in text boxes, everything else is a mouse click
[01:03:34] <leiz> thakis: anyone can
[01:03:35] <phajdan-jr> cbentzel_: green light, please land
[01:03:43] <thakis> leiz: thanks
[01:03:46] <jochen__> thakis: every committer
[01:03:56] <thakis> jochen__: thanks
[01:03:57] <akalin> leiz: indeed
[01:04:04] <jochen__> there's nothing like troopers anymore
[01:04:15] <leiz> but i'm a trooper
[01:04:18] <thakis> jochen__: who reboots bots then?
[01:04:19] <jochen__> just people with varying amounts of passwords
[01:04:26] <jochen__> i can reboot bots
[01:04:31] <thakis> then you're a trooper
[01:04:38] <jochen__> am not
[01:04:40] <thakis> that's the definition
[01:04:42] <thakis> are too
[01:04:48] <jochen__> i'm a tired puppy and i'll go to bed now
[01:05:00] <leiz> jochen__ hasn't volunteered to be a trooper, but he is Trooper Capable (TM)
[01:05:03] <thakis> have a manly night
[01:05:13] <thakis> puppy
[01:05:13] <tony^work> phajdan-jr: seems like styles-iframe has crashed about 5 times in the past 750
[01:05:24] <tony^work> I can mark it as flakey if you want
[01:05:32] <trungl_afk> evmar: ping
[01:05:39] *** trungl_afk is now known as trungl
[01:05:50] <phajdan-jr> tony^work: yes, please! green is good.
[01:05:50] *** __FlyingHyrax__ has joined #chromium
[01:06:07] <thakis> tony^work: ping
[01:06:40] <thakis> tony^work: looks like even the current default_plugin on linux has that resource issue since it loads a localized string from a bundle
[01:06:47] <pkasting> phajdan-jr: Have you landed your .grd change yet?
[01:06:48] <trungl> evmar: unping
[01:06:51] <thakis> do you think it's worth disabling the default plugin for m6?
[01:06:53] *** trungl is now known as trungl_afk
[01:07:17] *** mbelshe has joined #chromium
[01:07:17] *** ChanServ sets mode: +v mbelshe
[01:07:45] <tony^work> thakis: I thought we didn't support the default_plugin on linux currently
[01:07:50] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed. Waiting for bots to catch up, ETA 4:40 PM PDT. phajdan-jr is sheriffing.
[01:07:51] <thakis> tony^work: we do
[01:07:55] <thakis> well, it's on
[01:08:07] <thakis> it doesn't do a lot
[01:08:13] <phajdan-jr> phajdan-jr: I have no .grd changes, I was asked to help with sheriffing.
[01:08:14] *** bmizerany has joined #chromium
[01:08:14] <pkasting> phajdan-jr: oh nm I guess it was jochen's change
[01:08:20] <tony^work> thakis: what happens when it tries to load a string?
[01:08:26] <pkasting> phajdan-jr: I have a .grd change too
[01:08:26] <tony^work> it should crash, right?
[01:08:33] <thakis> tony^work: i guess it will get a different string instead?
[01:08:42] <mbelshe> So when are we going to fix this .grd business?  I don't understand the issue
[01:08:45] <thakis> (after updating)
[01:08:47] <thakis> (else, it works)
[01:08:54] <tony^work> thakis: I thought we didn't load the pak file for the plugin process
[01:08:56] <thakis> mbelshe: jochen__ has a cl to fix it i think
[01:09:13] <mbelshe> awesome - and then we won't have these multi-hour tree closures anymore?
[01:09:20] <thakis> tony^work: i think we do load the webkit resources pak?
[01:09:32] <thakis> mbelshe: well, not for grd changes. we will find other reasons i'm sure
[01:09:32] *** __FlyingHyrax__ has left #chromium
[01:09:37] <tony^work> thakis: but we're not loading it currently, right?
[01:09:51] <phajdan-jr> pkasting: let's wait for some greenness first
[01:09:53] <thakis> tony^work: we're currently loading a localized string from somewhere
[01:10:25] <tony^work> thakis: in the plugin process?  then I don't know where the pak file is getting loaded
[01:10:53] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed. Waiting for bots to catch up, ETA 4:40 PM PDT (grd train boarding; pkasting there, anyone else?). phajdan-jr is sheriffing.
[01:11:18] *** awong has quit IRC
[01:13:27] *** wyfrn_ has quit IRC
[01:15:52] <awong_> windows people...how important is it to use the second disk for building on a z600?
[01:15:53] *** janm has quit IRC
[01:16:54] <satish_> fishd: hi, yt?
[01:17:32] <satish_> fishd: er.. sorry, pinged the wrong person :(
[01:18:01] <mbelshe> Maybe, until the .grd global tree closures are finished, GRD changes should only be allowed at night....
[01:18:29] <jamesr> awong_: if you build on the first disk then it will be pretty unusuable during some stages of the compile
[01:18:38] *** wyfrn has joined #chromium
[01:18:45] <jamesr> awong_: so if you like to start a build and then try to do something else having it on a second disk is quite nice
[01:19:12] <awong_> jamesr: I see.  I'll setup the second disk then.  Thanks!
[01:19:30] <jamesr> maybe this is different in win7 (maybe the disk schedule doesn't suck so bad)
[01:19:59] <mbelshe> If pkasting does another .grd change, is that going to close the tree for hours again?
[01:20:15] <pkasting> Why am I getting all these messages about "libxslt.lib(transform.obj) : warning LNK4049: locally defined symbol _xmlMalloc imported"
[01:20:56] <pkasting> mbelshe: Personally I'd be happy enough to leave the tree open during .grd changes
[01:21:10] <pkasting> I think the bustage from a .grd change versus something else is pretty obvious
[01:21:15] <pkasting> And the costs of closing the tree are high
[01:21:33] <mbelshe> yes, I'm afraid if I miss a 5 minute window, I'll be done for the day...
[01:21:45] <awong_> jamesr: meh...I don't need all the disk space, so I might as well partition for now. :P
[01:22:37] <markmentovai> thakis: googlers
[01:22:54] <thakis> tony^work: i was wrong, the string is hardcoded atm
[01:22:55] <thakis> phew
[01:23:05] *** satish_ has quit IRC
[01:24:23] <rsesek> what's the eta on opening? I've got 2 CLs to land; I've been waiting for almost 3 hours on one of them.
[01:25:05] <markmentovai> phajdan-jr: i guess that question's for you
[01:25:13] <mbelshe> it says 4:40 right in the status
[01:25:21] <rsesek> is that for the grd change though?
[01:26:15] *** dglazkov has quit IRC
[01:26:41] *** markmentovai has quit IRC
[01:27:55] <phajdan-jr> rsesek: yeah, the status is hopefully accurate
[01:28:11] <rsesek> phajdan-jr: is that at 1640 we're opening again, or 1640 another grd change?
[01:28:52] <phajdan-jr> rsesek: we're going to keep rate-limiting the tree, and pkasting will land his grd change
[01:29:06] <phajdan-jr> btw, anyone else wants to board the grd train?
[01:29:11] <rsesek> phajdan-jr: okay. then I'd like to get in line w/ 2 CLs
[01:30:11] <phajdan-jr> rsesek: is any of them a grd change?
[01:30:20] <rsesek> phajdan-jr: negative
[01:30:53] <mdm_chromium> if there's a need for a whitespace change afterward I have a CL that fixes some spelling in comments
[01:31:17] <phajdan-jr> rsesek: could you post the codereview links here so I can do my checks?
[01:32:15] <rsesek> phajdan-jr: sure. note that the trybot runs are on an earlier versions of the CL: http://codereview.chromium.org/3014005/show http://codereview.chromium.org/3008010/show
[01:33:01] *** gavinp` has joined #chromium
[01:33:02] *** ChanServ sets mode: +v gavinp`
[01:33:32] *** urbanape has quit IRC
[01:33:36] *** urbanape has joined #chromium
[01:34:11] *** exxe has quit IRC
[01:35:06] <mbelshe> i think we should open the tree?
[01:36:02] <phajdan-jr> I'll handle that, please be patient. Will still be rate-limiting.
[01:36:05] <thakis> wtf why is python26 in chrome-git/tools?!
[01:36:13] <mbelshe> so, can i checkin?  or should i just go home?
[01:36:24] <mbelshe> i don't understand why we're rate limiting
[01:36:39] <thakis> why, to make hitting m6 more exciting
[01:36:51] <rsesek> mbelshe: because there will be a checkin flood after we reopen
[01:37:06] <mbelshe> ok - so we are waiting to take a branch?
[01:37:12] <phajdan-jr> rsesek: please make sure we have recent, green trybot runs. I'd rather not allow landing changes without it except when there are important reasons to do otherwise.
[01:37:51] <mbelshe> i just need to know when I can checkin.
[01:37:58] <mbelshe> if i can't checkin, please let me know and i'll go home
[01:38:12] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed and rate-limited (ping phajdan-jr). grd train boarding (pkasting, anyone else?)
[01:38:30] <phajdan-jr> mbelshe: what was your CL link?
[01:38:33] <rsesek> phajdan-jr: the latter doesn't need another run; the former will have a mac result in a bit (the win/lin/cros results would not be affected as only mac changes have been done since the results)
[01:39:00] <mbelshe> http://codereview.chromium.org/2832057/show
[01:39:03] <mbelshe> and
[01:39:19] <mbelshe> http://codereview.chromium.org/3051003/show
[01:39:24] <phajdan-jr> rsesek: I'd prefer to see green on all platforms, it modifies some cross-platform files it seems.
[01:39:44] <phajdan-jr> mbelshe: http://codereview.chromium.org/2832057/show has no trybots :(
[01:39:53] <mbelshe> yes it does - i modified some comments -
[01:39:59] <rsesek> phajdan-jr: as stated, the tryruns for all platforms passed. no other cross-plat code changes have occurred since then. only mac has changed and another result will be coming in.
[01:40:18] <phajdan-jr> mbelshe: please go ahead and commit http://codereview.chromium.org/3051003/show
[01:40:19] *** jrmuizel has joined #chromium
[01:40:29] <mbelshe> phadjan- thanks
[01:42:32] <phajdan-jr> rsesek: I'd really like to see recent green. Everything else is gotcha-prone and a no-go unless there are important reasons to land it right now.
[01:42:49] <mbelshe> Sorry to nag so much, but why are we rate-limiting right now?  Is it so we can take a branch?
[01:43:55] <rsesek> phajdan-jr: the green results aren't from 3 days ago. that's the patch set they're attached to. they're about 6 hours hold
[01:43:59] <phajdan-jr> mbelshe: it is just to prevent a pile-up. I'm generally accepting changes.
[01:44:00] <rsesek> *old
[01:44:31] <phajdan-jr> rsesek: it seems nobody else wants to land, lemme just take a few seconds to take another look
[01:44:38] <mbelshe> phajdan - I respectfully disagree with the approach.
[01:45:28] *** ebraminio1 has quit IRC
[01:45:36] <phajdan-jr> rsesek: green light for http://codereview.chromium.org/3008010/show
[01:46:12] <rsesek> thanks
[01:47:34] <rvargas> phajdan-jr:  http://codereview.chromium.org/2854053/show
[01:51:10] <thakis> trungl_afk: who did the "critical security update" stuff on about;plugins? cpu? jam2?
[01:52:07] *** AaronMT has quit IRC
[01:56:02] <phajdan-jr> rvargas: sure, please go ahead. sorry for the delay.
[01:56:19] <rvargas> thanks
[01:56:44] *** MikeSmithW3C has joined #chromium
[01:56:45] <jrg> phajdan-jr: would like to landm mac-only CL.  Is small.  OK wif u?  http://codereview.chromium.org/2884026/show
[01:56:52] <thakis> rsesek: ping
[01:56:56] <rsesek> thakis: pong
[01:57:12] <phajdan-jr> jrg: could you wait until the mac trybot finishes?
[01:57:17] <jrg> ok
[01:57:27] <phajdan-jr> rsesek: I think the tree is quite safe. What was your other CL?
[01:57:46] <rsesek> phajdan-jr: http://codereview.chromium.org/3014005/show
[01:58:12] <phajdan-jr> rsesek: fine, please go ahead
[01:58:25] <rsesek> gracias
[01:58:44] <thakis> rsesek: unping :P
[01:58:51] *** ScriptRipper has quit IRC
[02:00:14] <mpcomplete> phajdan-jr: i have a bugfix CL i'd like to get in before the cutoff tonight
[02:00:38] <phajdan-jr> mpcomplete: sure, what's the codereview link?
[02:00:58] <mpcomplete> phajdan-jr: http://codereview.chromium.org/3039005/show
[02:01:09] <mpcomplete> phajdan-jr: i fixed the unit test failure
[02:01:37] <phajdan-jr> mpcomplete: could you please get a green trybot on at least one platform? linux seems to be the fastest
[02:01:55] <phajdan-jr> mpcomplete: I'm not going to insist on that however if you need to catch the release train
[02:02:18] *** jhawkins has quit IRC
[02:02:33] *** General13372 has quit IRC
[02:02:51] <mpcomplete> phajdan-jr: my feeling is that the only failure on linux/mac was InitFromValueValid, which i verified fixed locally
[02:03:47] <phajdan-jr> mpcomplete: if you can, please give it a trybot run
[02:04:34] *** abarth has quit IRC
[02:04:42] *** abarth has joined #chromium
[02:04:42] *** ChanServ sets mode: +v abarth
[02:05:09] <phajdan-jr> mbelshe: green light for http://codereview.chromium.org/2832057/show if you commit within next 5 minutes
[02:05:28] <phajdan-jr> anyone wants to land?
[02:06:54] *** jamesr has quit IRC
[02:07:13] *** RT|Chatzilla has joined #chromium
[02:07:31] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open. grd train boarding (pkasting, anyone else?)
[02:08:06] *** hbono has joined #chromium
[02:09:45] *** atwilson has joined #chromium
[02:09:45] *** ChanServ sets mode: +v atwilson
[02:10:23] <phajdan-jr> the memory waterfall is really sad. Can someone volunteer to help?
[02:10:40] <thakis> phajdan-jr: sure. what do you want me to do?
[02:10:58] *** leeight has joined #chromium
[02:11:01] *** leeight has left #chromium
[02:11:02] <phajdan-jr> thakis: could you take a look at the memory waterfall and try to track down the source of redness?
[02:11:07] *** General1337 has joined #chromium
[02:11:10] <thakis> phajdan-jr: :-P
[02:11:11] <thakis> ok
[02:11:18] <phajdan-jr> thanks a lot
[02:11:39] <phajdan-jr> good, green trybot changes landing, thanks for your patience
[02:12:21] <hbono> phajdan-jr: Issue 49253 describes the memory errors in base_unittests.
[02:13:02] <hbono> so, it may be a good idea not to suppress them.
[02:13:19] <phajdan-jr> hbono: indeed. Can we stop running those tests temporarily?
[02:13:55] *** solsTiCe has joined #chromium
[02:14:35] *** jamesr has joined #chromium
[02:14:35] *** ChanServ sets mode: +v jamesr
[02:14:42] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (rate limiting, please ping phajdan-jr). grd train boarding (pkasting, anyone else?)
[02:14:44] <hbono> phajdan-jr: I'm not sure if it is a good idea. It may be better to ask thesig.
[02:14:51] <phajdan-jr> leiz: ^
[02:17:28] *** fta_ has joined #chromium
[02:17:58] <hbono> phajdan-jr: we need to suppress other memory errors while asking it to leiz?
[02:18:11] *** Sarten-X has quit IRC
[02:18:22] <solsTiCe> hi. I just found that chromium behave badly on jqapi.com. on the home page it scroll wrongly and I can't see the changelog. once you've choosen a function from the menu on the left it bahves ok except if you you scroll when on the left menu
[02:18:40] *** fta has quit IRC
[02:18:42] <jamesr> solsTiCe: does this happen in safari?
[02:18:48] <solsTiCe> no
[02:18:52] *** fta_ is now known as fta
[02:19:19] <jamesr> solsTiCe: can you file a bug? new.crbug.com
[02:19:42] <solsTiCe> ok
[02:20:07] <jamesr> thanks
[02:21:45] <trungl-bot> Tree closed by phajdan.jr at chromium dot org (:phajdan-jr): Tree is closed (rate limiting, please ping phajdan-jr) ~5:30 PDT should be fully open again. grd train boarding (pkasting, anyone else?)
[02:23:42] *** awolfson has joined #chromium
[02:26:03] *** ukai has joined #chromium
[02:26:33] *** Erkan_Yilmaz_ has joined #chromium
[02:26:37] *** tonikitoo has joined #chromium
[02:26:49] <trungl-bot> Tree opened by phajdan.jr at chromium dot org (:phajdan-jr): Tree is open. grd train boarding (pkasting, anyone else?)
[02:27:32] <akalin> yeah what the hell happened to the new tab button on mac
[02:27:44] <rsesek> akalin: search crbug for cmyk os:Mac
[02:27:58] <tony^work> I wonder if telling people when you're going to reopen makes for a more crowded commit
[02:28:12] *** pdelgallego has quit IRC
[02:29:30] <akalin> rsesek: oh
[02:29:39] *** rniwa has joined #chromium
[02:29:39] *** ChanServ sets mode: +v rniwa
[02:29:52] *** Erkan_Yilmaz has quit IRC
[02:30:50] <leiz> phajdan-jr: I'm the valgrind sheriff today
[02:31:03] <leiz> phajdan-jr: but I haven't got around to it
[02:31:15] *** bmizeran_ has joined #chromium
[02:31:21] <leiz> phajdan-jr: I'll probably go on a suppression spree tonight :D
[02:31:31] <phajdan-jr> tony^work: that will mean a quick closing of the tree :) I'm just trying to convince people to land their changes.
[02:31:32] <mattm_g> Is there any pattern for doing death tests with DCHECK?  The xmessage dialog that comes up blocks the test execution (though it passes if you manually dismiss the dialog)
[02:31:54] <phajdan-jr> mattm_g: that's bad, they should not appear when running tests
[02:32:11] <leiz> evmar: ^^
[02:32:23] <mattm_g> phajdan-jr: hm, maybe it's something particular about googleurl_unittests?
[02:32:31] <leiz> we might need to add a check for CHROME_HEADLES
[02:32:37] <leiz> CHROME_HEADLESS, rather
[02:32:49] <phajdan-jr> mattm_g: I don't think so, maybe base/test/test_suite.h
[02:32:56] *** bmizerany has quit IRC
[02:33:03] <evmar> that is strange.  if anything the check should be shared with win
[02:33:21] <tony^work> fwiw, I get into a strange state when a renderer tries to open an xmessage
[02:33:32] <phajdan-jr> tony^work: yeah, seen that too with ui_tests
[02:33:41] <evmar> hah
[02:34:05] *** fta_ has joined #chromium
[02:34:34] <solsTiCe> jamesr: it's an extension that cause the scrolling bug: Visionneuse Google Documents PDF/PowerPoint (par Google)
[02:34:34] <leiz> phajdan-jr: did you swap a sheriff rotation with someone?
[02:34:57] <phajdan-jr> leiz: I was asked to do so, and I'm doing it just for today.
[02:35:21] <jamesr> solsTiCe: how odd. be sure to include that in the bug report
[02:35:37] <solsTiCe> may I still make a bug report ?
[02:35:44] <jamesr> yeah
[02:36:23] *** fta has quit IRC
[02:36:37] *** fta_ is now known as fta
[02:37:33] <leiz> phajdan-jr: ah, thx for volunteering!
[02:37:40] *** victorw has joined #chromium
[02:37:40] *** ChanServ sets mode: +v victorw
[02:39:00] <hbono> phajdan-jr: thank you for your volunteer work. I'm a sheriff today, though. :)
[02:39:54] *** dmaclach has quit IRC
[02:41:00] *** Emperorlou has joined #chromium
[02:41:28] <phajdan-jr> hbono: great, good luck! Does it mean I can get back to my patches?
[02:41:39] <hbono> phajdan-jr: sure.
[02:41:41] <thakis> is there a document on how to run valgrind tests locally?
[02:41:48] <phajdan-jr> hbono: thanks a lot
[02:42:01] <thakis> i have a suppression that claims that something is a valgrind bug, but that doesn't feel correct
[02:42:07] *** tonyg-cr has quit IRC
[02:42:12] *** rsimha has quit IRC
[02:42:20] <rsesek> phajdan-jr: I'm looking at ui tests
[02:43:19] <leiz> thakis: now-a-days I think there's a prebuilt copy of valgrind checked into the tree
[02:43:32] <leiz> thakis: the valgrind test script looks for that and runs it.
[02:43:35] <thakis> leiz: yes, http://www.chromium.org/developers/how-tos/using-valgrind looks like it's not terribly out of date
[02:43:43] <thakis> thanks
[02:44:16] <phajdan-jr> rsesek: thanks. I think hbono is now sheriffing though.
[02:45:40] <mattm_g> phajdan-jr,evmar: hm, looks like googleurl_unittests don't use base/test/test_suite.h
[02:46:02] <phajdan-jr> mattm_g: ah, it may be a dependency issue (can it depend on base?)
[02:46:17] *** erikkay has quit IRC
[02:46:19] <phajdan-jr> mattm_g: if we don't have a soltuion now, could you file a bug with GreenTreeTaskForce label and CC me?
[02:46:34] <hbono> rsesek: does it mean mac ui_tests?
[02:46:38] <rsesek> hbono: yes
[02:46:39] <mattm_g> phajdan-jr: I think it's intended to be separate (it's pulled in by deps), so probably not
[02:46:51] *** fta_ has joined #chromium
[02:47:00] <hbono> rsesek: thank you so much for fixing them. :)
[02:47:13] <rsesek> I may have broken them, so I'm gonna make sure :)
[02:47:37] *** fta has quit IRC
[02:47:52] *** fta_ is now known as fta
[02:51:13] *** cbentzel_ has quit IRC
[02:56:51] *** yutak_home has quit IRC
[02:56:54] *** shess has quit IRC
[02:57:54] *** tfarina has joined #chromium
[02:58:49] *** cbentzel_ has joined #chromium
[02:58:49] *** ChanServ sets mode: +v cbentzel_
[02:58:56] *** leeight has joined #chromium
[02:59:02] *** leeight has left #chromium
[02:59:07] <jamesr> uh oh
[02:59:14] <jamesr> my macbook pro's screen just went cinema lights at the bottom
[02:59:30] <jamesr> or theater lights i guess
[02:59:55] <cbentzel_> Is jega154 a known slow win trybot slave? It's still churning, but has taken over 4 hours to complete
[03:00:35] <jamesr> does that mean it's time for a new one?
[03:00:44] <leiz> all win trybots are slow :)
[03:00:45] <tfarina> yup!
[03:00:45] *** Beetny` has joined #chromium
[03:00:46] <rsesek> hbono: got a fix for the uibots
[03:00:50] <rsesek> (mac)
[03:01:04] *** GeekShadow has quit IRC
[03:01:20] *** MikeSmithW3C has quit IRC
[03:01:30] <hbono> rsesek: it's great. thank you for your work. :)
[03:01:39] <rsesek> heh I broke it, so don't thank me too much ;)
[03:01:49] <leiz> jamesr: wow, that was a really slow gclient step
[03:01:49] *** jamesr has quit IRC
[03:01:54] <cbentzel_> Sorry, I kicked it off 5 hours ago. I guess this is expected on a day like today?
[03:01:56] <hbono> rsesek: haha.
[03:02:32] <leiz> cbentzel_: for some reason it decided to checkout all the src code again
[03:02:58] *** Beetny has quit IRC
[03:03:10] <leiz> cbentzel_: it's a case of bad luck I guess
[03:03:25] <leiz> the run should've only been 2.x hours
[03:03:30] <cbentzel_> leiz: Yeah, especially since I'm trying to get this in for tonight.
[03:03:48] <cbentzel_> leiz: I was tempted to kick off another try but didn't want to add fuel to the fire
[03:03:50] <leiz> cbentzel_: but it's almost done
[03:04:18] <leiz> cbentzel_: at this point it won't help, there's 50+ try jobs ahead of you
[03:04:34] *** dave_levin has quit IRC
[03:04:41] <leiz> cbentzel_: but it's almost done, another 30-40 minutes I think
[03:05:00] <rsesek> thakis: ping?
[03:05:00] <leiz> cbentzel_: if you already have a LGTM, I'm sure you'll get it in before bedtime
[03:05:03] <cbentzel_> leiz: Thanks for the info. I'll try to be more productive about improvements instead of just whining after tonight,
[03:05:04] <thakis> rsesek: !
[03:05:12] *** jamesr has joined #chromium
[03:05:12] *** ChanServ sets mode: +v jamesr
[03:05:18] <rsesek> thakis: http://codereview.chromium.org/3005018 - I love it when I forget to switch back to Debug config so I test the wrong binaries
[03:05:19] <thakis> jamesr: !
[03:05:28] <leiz> cbentzel_: sorry I can't help, I only know how to make the linux build fast.
[03:06:18] <leiz> hbono: do you want to review http://codereview.chromium.org/3035008 ?
[03:06:18] <thakis> rsesek: oops
[03:06:28] <rsesek> thakis: the tests caught it
[03:06:34] <thakis> cool :-)
[03:06:48] <rsesek> but b/c I built you that release mode binary, I was running old tests :(
[03:07:42] <hbono> leiz: sure.
[03:08:06] *** jrmuizel has quit IRC
[03:08:12] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open. grd train boarding (pkasting, anyone else?) (mac ui_tests -> fix at r52982)
[03:12:46] *** echelog-1 has joined #chromium
[03:14:47] *** shess has joined #chromium
[03:14:48] *** ChanServ sets mode: +v shess
[03:16:07] * shess new best use for a 30-inch monitor: "LoginHook - Checking boot partition scheme" for 5 minutes.
[03:16:11] <evmar> Replacements<char> r; r.SetScheme("https", url_parse::Component(0, url.scheme().size()); url = url.ReplaceComponents(repl)
[03:16:18] <evmar> or some such
[03:16:20] <evmar> doesn't seem so bad
[03:16:23] <thakis> phajdan-jr: cl to you
[03:17:19] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "base_unittests" on "Modules XP (dbg)" from 52982: andybons at chromium dot org, jhawkins at chromium dot org, nirnimesh at chromium dot org, rsesek at chromium dot org)
[03:17:53] *** andybons_ has joined #chromium
[03:17:53] *** ChanServ sets mode: +v andybons_
[03:18:13] *** mazda has joined #chromium
[03:18:13] *** ChanServ sets mode: +v mazda
[03:18:28] <phajdan-jr> thakis: looking
[03:18:44] <rsesek> hm base_unittests doesn't seem to have an obvious culprit
[03:19:02] <phajdan-jr> thakis: sure, LGTM
[03:19:54] *** Erkan_Yilmaz__ has joined #chromium
[03:20:20] <hbono> rsesek: yeah.
[03:20:42] <andybons_> may just be flake
[03:20:44] *** jschuh_ has joined #chromium
[03:21:25] <hbono> andybons: I have re-run the tests.
[03:22:06] *** tonyg-cr has joined #chromium
[03:22:06] *** ChanServ sets mode: +v tonyg-cr
[03:23:25] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Modules XP (dbg)" -> flake? hbono re-running)
[03:23:31] *** phajdan-jr has quit IRC
[03:23:32] *** Erkan_Yilmaz_ has quit IRC
[03:23:41] *** leeight has joined #chromium
[03:23:46] *** leeight has left #chromium
[03:25:36] *** andybons has left #chromium
[03:25:43] *** victorw has left #chromium
[03:28:03] *** csilv has left #chromium
[03:28:31] <thakis> anyone around who knows about valgrind?
[03:29:38] <hbono> thakis: even though I have some knowledge about it, leiz is an expert.
[03:30:03] <thakis> leiz: why don't we run valgrind with --track_origins? too slow?
[03:30:13] <rohitrao> shess: I don't understand half of your bug updates, but this sounds like M7 :)
[03:30:19] <pkasting> I'm getting to where I want to check in
[03:30:20] *** bmizeran_ has quit IRC
[03:30:29] <pkasting> Not sure who is sheriffing at this point
[03:30:38] *** bmizerany has joined #chromium
[03:30:54] <hbono> pkasting: I'm working as a sheriff now.
[03:31:31] *** yuzo has quit IRC
[03:31:31] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open grd train boarding (pkasting, anyone else?)
[03:31:42] *** jshin has quit IRC
[03:32:12] <tfarina> how can I add a .png to the tree?
[03:32:23] <tfarina> it needs a separate CL right?
[03:32:27] *** mazda has quit IRC
[03:32:37] <hbono> pkasting: I think now is a good time to check in a grd change.
[03:32:54] <jamesr> tfarina: i believe the typical pattern is to land the .png by itself and then land changes that refer to it (so that your try jobs can see the .png)
[03:33:01] <pkasting> hbono: OK, do you want me to close the tree, or just leave it open?
[03:33:45] <tfarina> jamesr: thanks!
[03:33:46] <hbono> pkasting: maybe it is better for you to close it.
[03:37:37] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 52982: andybons at chromium dot org, jhawkins at chromium dot org, nirnimesh at chromium dot org, rsesek at chromium dot org, tfarina at chromium dot org)
[03:38:38] *** tedoc2000 has quit IRC
[03:39:18] <tfarina> it needs a clobber?
[03:39:30] <hbono> tfarina: it seems so.
[03:39:34] <evmar> webcore.lib(WebGLRenderingContext.obj) : fatal error LNK1318: Unexpected PDB error; UNKNOWN (24) ''
[03:39:35] *** yuzo has joined #chromium
[03:39:35] *** ChanServ sets mode: +v yuzo
[03:39:35] *** yuzo has quit IRC
[03:40:00] <jamesr> thanks for the descriptive error message, msvs
[03:40:33] <hbono> jamesr: indeed.
[03:40:41] *** tonyg-cr has quit IRC
[03:41:32] *** jrmuizel has joined #chromium
[03:41:39] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open grd train boarding (pkasting, anyone else?)
[03:42:17] *** tonyg-cr has joined #chromium
[03:42:17] *** ChanServ sets mode: +v tonyg-cr
[03:42:40] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Builder (dbg) -> clobbered), grd train starting (pkasting, anyone else?)
[03:43:48] <pkasting> Doh, hbono, if you were going to clobber, you should have told me to commit
[03:43:58] <pkasting> Now it's going to be ten million years :(
[03:44:07] *** Sarten-X has joined #chromium
[03:44:18] <tfarina> :(
[03:44:40] <hbono> pkasting: Indeed. I should have noticed it. Sorry.
[03:45:00] *** tonyg-cr has quit IRC
[03:46:07] <estade> hbono: can i commit an m6 change that has all green trybots
[03:46:39] <thakis>  LINK(target) out/Release/unit_tests
[03:46:40] <thakis> collect2: ld terminated with signal 6 [Aborted]
[03:46:40] <estade> i have been waiting for an open tree but perhaps I haven't been vigilant enough as I haven't seen it open yet today
[03:46:40] <thakis> terminate called after throwing an instance of 'std::bad_alloc'
[03:46:42] <thakis> on a linux bot
[03:46:45] *** andybons_ has quit IRC
[03:46:53] *** dglazkov has joined #chromium
[03:46:53] *** ChanServ sets mode: +v dglazkov
[03:47:07] <hbono> estade: maybe we should let pkasting check in his grd change.
[03:47:33] <estade> is there some reason we can't do both?
[03:47:52] <estade> my change is linux only
[03:47:55] <estade> grd is only broken on windows
[03:48:22] *** dglazkov has quit IRC
[03:49:12] *** fta has quit IRC
[03:49:17] *** dmaclach has joined #chromium
[03:49:44] <cbentzel_> hbono: can I commit an m6 change? Sorry it's now, but the try job just completed after 4.5 hours
[03:49:47] *** kerz has quit IRC
[03:49:51] <pkasting> There is no reason we can't do both
[03:50:20] <hbono> estade: ok.
[03:50:36] *** fta has joined #chromium
[03:50:46] <pkasting> cbentzel_: What's the change
[03:50:53] <estade> hbono: thanks
[03:51:05] <cbentzel_> pkasting: http://codereview.chromium.org/3055001/show
[03:51:31] <hbono> estade: it is better for you to thank pkasting. :)
[03:51:42] <pkasting> cbentzel_: Seems fine
[03:51:43] *** dmaclach has quit IRC
[03:51:51] <cbentzel_> pkasting: Thanks!
[03:52:01] <pkasting> I say let's just all go ahead and land now
[03:52:10] <pkasting> We'll keep the tree closed afterwards
[03:52:59] <cbentzel_> pkasting: OK
[03:53:00] <hbono> pkasting: sure. can you open the tree when you finish it?
[03:53:15] *** rniwa has quit IRC
[03:53:19] <pkasting> hbono: OK
[03:53:26] *** fqian has quit IRC
[03:53:30] <hbono> pkasting: thanks a lot.
[03:53:47] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree closed (.grd change cycling)
[03:58:18] *** johnny_g has quit IRC
[03:58:57] *** MikeSmithW3C has joined #chromium
[04:01:45] *** yuzo has joined #chromium
[04:01:45] *** ChanServ sets mode: +v yuzo
[04:02:06] *** yuzo has quit IRC
[04:03:20] *** kurrik has quit IRC
[04:04:05] *** asargent3 has joined #chromium
[04:04:12] *** asargent3 has left #chromium
[04:05:21] *** Sarten-X has quit IRC
[04:07:54] *** fta_ has joined #chromium
[04:09:59] *** fta has quit IRC
[04:10:09] *** fta_ is now known as fta
[04:10:16] *** cbentzel_ has quit IRC
[04:10:41] *** andybons has joined #chromium
[04:10:41] *** ChanServ sets mode: +v andybons
[04:10:43] *** cbentzel_ has joined #chromium
[04:10:43] *** ChanServ sets mode: +v cbentzel_
[04:10:54] *** wattz has joined #chromium
[04:11:05] *** wattz has left #chromium
[04:11:12] *** MikeSmithW3C^ has joined #chromium
[04:13:45] *** MikeSmithW3C has quit IRC
[04:13:46] <rsesek> hbono: mac ui tests are all green now. I'm heading out
[04:13:47] <rsesek> night all
[04:14:03] <hbono> rsesek: have a good night.
[04:14:09] *** rsesek has quit IRC
[04:15:16] *** andybons has left #chromium
[04:15:26] *** MikeSmithW3C^ has quit IRC
[04:17:31] <jamesr> how does an email with the subject 'Immense wang with ease' get through the gmail spam filters?
[04:20:41] *** arv has quit IRC
[04:20:46] <thakis> jamesr: wang is a name
[04:21:08] <thakis> maybe they're merely into human trafficking?
[04:21:19] <jamesr> of obese people?
[04:21:28] <thakis> yeah
[04:21:50] * eggy blinks
[04:21:50] <thakis> hbono: can i land http://codereview.chromium.org/2825059 ?
[04:23:50] *** tonyg-cr has joined #chromium
[04:23:50] *** ChanServ sets mode: +v tonyg-cr
[04:24:52] <hbono> thakis: ok.
[04:25:24] <thakis> thanks
[04:25:26] <cbentzel_> hbono: How about http://codereview.chromium.org/3014013/show? (This is the last of my mstone6 CLs)
[04:26:02] *** MikeSmithW3C^ has joined #chromium
[04:26:43] <hbono> cbentzel_: ok.
[04:26:48] *** mazda has joined #chromium
[04:26:50] <cbentzel_> hbono: great, thanks!
[04:26:54] *** yuzo has joined #chromium
[04:26:56] <tfarina> leiz: do you want to take another look at my env_var CL (or can I commit when the tree opens)?
[04:27:48] <dhollowa> hbono: how about mac-only: http://codereview.chromium.org/3039014/show
[04:28:53] *** gavinp` has quit IRC
[04:30:04] <hbono> dhollowa: pkasting has landed a resource change that includes some nib change. does your change work with his change?
[04:30:19] *** RT|Chatzilla has quit IRC
[04:31:05] *** rohitrao has quit IRC
[04:31:25] *** jamesr has quit IRC
[04:32:33] <dhollowa> hbono: yes, i've merged pkasting's change, and re-run unit tests locally.  no problems.
[04:33:00] <thakis> dhollowa: you merged the nib files?
[04:33:20] <dhollowa> thakis: he did not change the AutoFillDialog.xib
[04:33:32] <pkasting> The only nib change I made was a change to the IDC_* ID for one of the commands
[04:33:38] <dhollowa> thakis: so no merge needed with nib.
[04:33:40] <thakis> dhollowa: ok
[04:33:47] <hbono> dhollowa: ok.
[04:33:48] <pkasting> BTW, if someone could check that specific change I'd appreciate it
[04:33:55] <pkasting> I don't have my macbook here
[04:34:06] <dhollowa> pkasting: how would i check?
[04:36:24] *** tfarina has quit IRC
[04:38:14] <dhollowa> hbono: landed.
[04:38:38] <tonyg-cr> tony^work: is the last webkit roll done for the day or do you have another planned?
[04:39:07] <hbono> dhollowa: thank you for noticing it.
[04:39:32] <dhollowa> pkasting: it worked for me.
[04:39:39] <pkasting> hoorj!
[04:43:03] <dhollowa> hbono: are the ui_tests failures on mac understood?
[04:44:43] *** MikeSmithW3C^ has quit IRC
[04:45:35] *** akalin has quit IRC
[04:45:55] <hbono> dhollowa: If I recally corectly, rsesek has fixed them.
[04:48:14] *** gfeher has quit IRC
[04:50:31] *** bweinstein has quit IRC
[04:50:52] *** bweinstein has joined #chromium
[04:53:16] *** evmar is now known as evmar_afk
[04:55:28] *** fta_ has joined #chromium
[04:55:57] *** bweinstein has quit IRC
[04:56:43] *** fta has quit IRC
[04:56:53] *** fta_ is now known as fta
[04:57:19] *** Gabe_G23 has quit IRC
[04:59:20] <cbentzel_> hbono: Going to catch subway. I'll be back online in ~45 minutes in case there is an issue with my two CLs.
[04:59:51] <dhollowa> pkasting: FocusTraversalTest.TraversalWithNonEnabledViews yours?
[05:00:40] *** Gabe_G23 has joined #chromium
[05:00:40] <jrg> cbentzel_: next time, perhaps, you could just "not land" if you are about to run away.
[05:01:06] <hbono> cbentzel_: thank you for noticing it. I'm looking at the tree.
[05:01:58] *** akalin has joined #chromium
[05:02:32] *** cbentzel has quit IRC
[05:04:33] <pkasting> dhollowa: Where?
[05:04:51] <dhollowa> pkasting: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests/builds/21441/steps/unit_tests/logs/stdio
[05:05:40] <pkasting> nsylvain, maruel: Vista tests (dbg 4) seems sick: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20(dbg)(4)/builds/9795/steps/extract%20build/logs/stdio
[05:09:36] *** mrossetti has quit IRC
[05:09:57] *** dglazkov has joined #chromium
[05:09:57] *** ChanServ sets mode: +v dglazkov
[05:10:22] <pkasting> dhollowa: I doubt it but I am rebuilding and will try locally
[05:11:17] <dhollowa> pkasting: i notice SessionRestoreUITest.TwoWindowsCloseOneRestoreOnlyOne on Mac as well
[05:11:26] <dhollowa> pkasting: i'll try that locally
[05:11:41] <pkasting> I don't know why either of those would be me
[05:11:44] <hbono> can I restart the "Vista tests (dbg 4)" bot?
[05:12:07] <dhollowa> pkasting: ok
[05:12:45] <pkasting> hbono: restart like reboot?
[05:13:10] <hbono> pkasting: yes.
[05:13:19] <pkasting> SGTM
[05:13:46] <hbono> pkasting: thanks. :)
[05:18:30] *** RT|Chatzilla has joined #chromium
[05:20:34] *** wyfrn has quit IRC
[05:21:54] *** tkent has joined #chromium
[05:21:54] *** ChanServ sets mode: +v tkent
[05:24:13] <pkasting> dhollowa: FocusTraversal* seems to pass for me locally
[05:24:48] *** dmaclach has joined #chromium
[05:26:24] *** arv has joined #chromium
[05:28:10] <dhollowa> pkasting: ya, TwoWindowsCloseOneRestoreOnlyOne is fine for me locally.  must have been spurious.
[05:28:57] *** cbentzel has joined #chromium
[05:28:57] *** ChanServ sets mode: +v cbentzel
[05:32:19] *** michaeln has quit IRC
[05:32:56] *** Sarten-X has joined #chromium
[05:36:20] <pkasting> Confused, "Linux builder (ChromiumOS dbg)" seems to be on the individual lines in the console, but not on the summary at top
[05:37:06] *** loislo has joined #chromium
[05:37:12] <mirandac> hbono: I would love to commit http://codereview.chromium.org/2805089/show .  I've run the tests on my local winbuild and it all passes.
[05:38:22] *** bmizerany has quit IRC
[05:38:39] *** dmaclach has quit IRC
[05:38:50] *** cbentzel_ has quit IRC
[05:39:12] *** pathorn has quit IRC
[05:39:23] <hbono> mirandac: ok.
[05:39:34] <tonyg-cr> Anyone mind if i roll webkit after the tree opens? r63707 looks good.
[05:39:48] <mirandac> hbono: thanks! :-D
[05:40:15] *** dr_win has quit IRC
[05:40:28] <Emperorlou> When is WAV support coming to HTML5 in chrome?
[05:41:03] *** FullFlannelJacke has quit IRC
[05:42:21] <Emperorlou> .wav files are supported by every other browser and it's the closest thing to a standard if it wasn't for Chrome's lack of support!
[05:43:02] <Emperorlou> otherwise, all web applications need to have 2 versions of audio for every sound
[05:43:05] <pkasting> Emperorlou: How about you go write a patch
[05:43:59] <tonyg-cr> emperorlou: http://crbug.com/23916
[05:43:59] <Emperorlou> That would be pretty cool and all
[05:44:02] <pkasting> Emperorlou: Besides, Chrome, Firefox and Opera all support ogg
[05:45:06] <Emperorlou> hehe, that link I actually commented on already
[05:45:11] <Emperorlou> posted my ++
[05:45:39] <Emperorlou> Ok here's the thing
[05:45:51] <Emperorlou> Ogg has support on all browsers except safari
[05:46:09] <Emperorlou> and IE is probably gonna suck it up and lack support for ogg
[05:46:10] <Emperorlou> fine...
[05:46:15] <Emperorlou> wav is supporte dby all BUT chrome
[05:46:23] <Emperorlou> and you know IE is prolly gonna support it
[05:46:42] <Emperorlou> because its inefficient and uncompressed
[05:47:00] <Emperorlou> which fits perfectly for IE
[05:47:07] <Emperorlou> but more importantly, it would be a standard
[05:47:38] <Emperorlou> on top of that, the data is uncompressed and could be manipulated. Online audio applications would use this
[05:47:50] <Emperorlou> so it needs to be supported one way or another
[05:49:00] <Emperorlou> And who cares about all that stuff. Google is amazing and never lets me down :)
[05:50:02] <Emperorlou> Collecting the most talented coders on the planet for supreme excellence in development
[05:51:16] <pkasting> Emperorlou: We don't need rationale, we're not opposed to supporting it
[05:51:21] <pkasting> Emperorlou: We need a patch
[05:51:49] <rubenbb> and the ticket indicates chromium devs are well aware of the issue
[05:51:55] <thakis> hbono: ok for http://codereview.chromium.org/2819056/show ?
[05:51:58] <Emperorlou> yea
[05:52:03] <thakis> also, is someone looking into the xp tests failure?
[05:52:32] <Emperorlou> I'm probably not the best candidate to try to attempt to implement it. Starting from less than 0.
[05:53:07] *** cbentzel has quit IRC
[05:54:44] *** bgmerrell has joined #chromium
[05:55:09] <thakis> i'm landing a valgrind suppression
[05:55:29] <thakis> that seems safe
[05:56:26] *** bandu has joined #chromium
[05:56:28] <Emperorlou> But if chrome implements .wav support, it will unite humanity in a way that has never happened before. It's ground-breaking that all browsers would support the same audio formats. Whoever would take on such a task would be convicted of saving the human race from BILLIONS of terrabytes of needless audio transcoding!
[05:56:51] <thakis> Emperorlou: wav files are not compressed
[05:56:59] <thakis> that's like suggesting to converge to bmp for images
[05:57:06] <rubenbb> only to waste terabytes of bandwidth sending an uncompressed format
[05:57:37] <Emperorlou> yes, but we would have a common format. and for the most part, the audio file sizes would be very small (for button clicks and beeps and such)
[05:57:52] <rubenbb> and since disk space is much cheaper than bandwidth... ;)
[05:59:08] <Emperorlou> you're right, bandwidth would be wasted with wav. But wav being the most basic of audio formats, it should really have been implemented first. And this doesn't even address the obvious data manipulation benefits that WAV support provides
[05:59:33] <rubenbb> frankly, other than obvious time constraints, I don't know why it isn't supported already
[05:59:46] <Emperorlou> rubenbb++
[06:00:06] <Emperorlou> its more likely that IE will support wav than ogg
[06:00:26] <Emperorlou> which means wav is the closest to standard on the planet
[06:01:37] <pkasting> OK, at this point I'm prepared to claim that the .grd change has worked
[06:01:44] <pkasting> So the question is, do I open the tree?
[06:01:53] <pkasting> Or leave it under somebody else's authority
[06:03:49] <mirandac> I can take nominal charge of the tree
[06:03:52] *** jrmuizel has quit IRC
[06:04:11] <mirandac> ...since I don't see anyone else in the room ;-)
[06:04:40] <mirandac> I'm looking at the XP failures, and watching the bots turn.  will be here until I'm satisfied that my change was, at the very least, benign.
[06:05:17] *** Emperorlou has quit IRC
[06:05:19] <thakis> mirandac: ok to land http://codereview.chromium.org/2870060/show ?
[06:05:29] <pkasting> I think I'll just claim the tree is open
[06:05:38] <pkasting> It seems like things are calm enough that it won't hurt
[06:05:46] <mirandac> thakis: please do
[06:06:05] <trungl-bot> Tree opened by pkasting at chromium dot org: Tree open (mirandac temporarily sheriffing)
[06:06:15] <hbono> pkasting: I agree.
[06:06:41] <mirandac> pkasting: works for me.  oh, hbono is still in the house -- cool.
[06:07:34] <hbono> mirandac: I'm in the Tokyo office.
[06:07:45] <mirandac> hbono: this is why I can't see you! :-)
[06:07:54] *** dglazkov has quit IRC
[06:07:56] <thakis> alright, i'm driving home
[06:08:02] <thakis> back in 1h or so
[06:08:45] <rubenbb> I'm surprised you don't stay on here through an android irc client or something ;)
[06:10:16] *** jrmuizel has joined #chromium
[06:10:27] <mirandac> looks like XP unit tests resolved themselves.
[06:10:31] *** estes has quit IRC
[06:10:45] *** bandu is now known as coyo
[06:10:46] <hbono> mirandac: yeah.
[06:11:54] *** jrmuizel has quit IRC
[06:13:40] *** dmaclach has joined #chromium
[06:14:37] *** fta has quit IRC
[06:15:00] *** fta has joined #chromium
[06:15:59] *** jshin has joined #chromium
[06:16:59] <leiz> 52999 commits in the tree, 52999 commits..
[06:17:19] <mirandac> take one down, pass it around...
[06:17:33] <tonyg-cr> ukai is the lucky winner
[06:17:51] <leiz> so close!
[06:19:48] *** jshin_ has joined #chromium
[06:20:04] *** ricow has quit IRC
[06:20:22] *** ricow has joined #chromium
[06:20:22] *** dmaclach has quit IRC
[06:20:45] *** dmaclach has joined #chromium
[06:24:28] *** dr_win has joined #chromium
[06:24:31] *** jshin has quit IRC
[06:24:32] *** jshin_ is now known as jshin
[06:24:52] *** fta_ has joined #chromium
[06:26:20] *** loislo has quit IRC
[06:26:29] *** fta has quit IRC
[06:26:37] *** fta_ is now known as fta
[06:26:54] *** loislo has joined #chromium
[06:27:06] *** loislo has quit IRC
[06:35:34] *** PigeonCluster has joined #chromium
[06:39:55] *** Kunalagon has joined #chromium
[06:46:13] *** kphanee has left #chromium
[06:47:34] *** tonikitoo has quit IRC
[06:53:07] *** Kunalagon has quit IRC
[06:56:42] <trungl-bot> Tree opened by mirandac at chromium dot org: Tree open (mirandac -> ui_tests)
[06:57:10] *** fta_ has joined #chromium
[06:57:45] *** fta has quit IRC
[06:57:53] *** fta_ is now known as fta
[06:58:26] *** dmaclach has quit IRC
[06:59:52] *** timsteele has joined #chromium
[06:59:53] <jibot> timsteele is a Chromium Googler.
[07:00:47] *** tonikitoo has joined #chromium
[07:03:18] *** 77CAAXZMM has quit IRC
[07:03:48] <trungl-bot> Tree opened by mirandac at chromium dot org: Tree open (ui_tests should cycle green)
[07:04:32] <mirandac> hbono: I have a revert in for the test which was failing on the buildbots.  it passes on my local winbots, and discussion with arv tonight makes me suspect the test harness, and not the test itself.  the windows ui tests should turn green after my revert.  will investigate w/arv tomorrow.
[07:05:21] *** mirandac is now known as mirandac_afk
[07:06:09] *** PigeonCluster has left #chromium
[07:07:00] <hbono> mirandac_afk: thanks a lot.
[07:07:08] * hbono is looking valgrind errors.
[07:07:22] *** loislo has joined #chromium
[07:08:25] <leiz> hbono: same here
[07:08:49] <leiz> hbono: BrowserEncodingTest.FLAKY_TestEncodingAutoDetect is failing on all bots, I'm looking for the regression
[07:09:08] <leiz> hbono: there's some npapi tests on mac that were disabled, but the test names changed, so they're failing
[07:09:12] *** fta_ has joined #chromium
[07:09:27] <leiz> so we just need to update the disabled test file
[07:09:48] <leiz> kinoko checked in new tests for the download code, I think that's leaking
[07:10:16] <hbono> leiz: thanks for noticing it.
[07:10:28] *** fta has quit IRC
[07:10:38] *** fta_ is now known as fta
[07:11:12] <hbono> leiz: I'm now trying <http://codereview.chromium.org/2808056/show>, which may fix Issue 49590.
[07:11:18] <leiz> chromium mac base is still broken, I sent a cl to the other valgrind folks, but I haven't heard a reply
[07:11:33] <timsteele> is there an acting sheriff in the house?
[07:12:00] <hbono> timsteele: me? (since I'm in Tokyo.)
[07:12:03] *** tonyg-cr has quit IRC
[07:12:48] <leiz> timsteele: I can pretend to be sheriff if needed
[07:14:16] <hbono> leiz: I'm a sheriff today and tomorrow: <http://dev.chromium.org/developers/tree-sheriffs>. :)
[07:14:24] <timsteele> heh, okay.  so this isn't as bad as it sounds but, dudley just sent me a tweak to existing strings in generated_resources wanted for m6...
[07:14:27] <timsteele> there are no tests that verify these strings though
[07:14:40] <timsteele> so I'm pretty sure it can't cause the typical redness
[07:15:06] <leiz> is this a grd change?
[07:15:12] <akalin2> lol PM-owned
[07:15:26] <timsteele> that's what Im saying yes.
[07:15:27] <leiz> but not adding/deleting any entries?
[07:15:30] <timsteele> right
[07:15:43] <timsteele> akalin2: tell me about it
[07:15:57] <hbono> timsteele: I think it's ok to land it.
[07:16:00] <leiz> that sounds safe
[07:17:03] <leiz> besides, the tree is pretty quite at this hour
[07:17:45] <timsteele> hbono, leiz: cool, thanks.  yeah I was just wondering since it's an hour before the big freeze if things would be extra cautious :)
[07:17:54] <hbono> leiz: yeah.
[07:17:58] <timsteele> i'll prep things and let you know in a moment when im ready.
[07:20:33] *** peepsalot has quit IRC
[07:20:44] *** fta_ has joined #chromium
[07:22:40] *** fta has quit IRC
[07:22:53] *** fta_ is now known as fta
[07:25:29] *** peepsalot has joined #chromium
[07:28:07] *** pfeldman has joined #chromium
[07:31:31] *** mirandac has joined #chromium
[07:31:32] <mirandac> cubs
[07:31:41] <mirandac> *cough*
[07:34:54] *** c_zahmad has joined #chromium
[07:36:51] <timsteele> leiz,hbono: fyi patch incoming
[07:37:08] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium XP" from 53007: ahendrickson at google dot com, fbarchard at chromium dot org, jochen at chromium dot org (:jochen__), jrg at chromium dot org, mirandac at google dot com)
[07:37:11] <timsteele> gah
[07:37:45] *** arv has quit IRC
[07:38:29] *** roc has quit IRC
[07:38:33] <hbono> timsteele: it is just a buildbot flakiness. I'm re-opening the tree.
[07:39:19] <jrg> hbono: are you sure we can just reopen?  Perhaps we need to do a clean build and delete the pdb file?
[07:39:29] <leiz> "C:\b\slave\chromium-rel-xp\build\src\net\disk_cache\mapped_file_win.cc : fatal error C1083: Cannot open program database file: 'c:\b\slave\chromium-rel-xp\build\src\build\release\obj\net\net\vc80_ib_1.idb': No error
[07:39:57] <leiz> no error, uh huh
[07:40:16] <mirandac> no error in the sense of fatal error, apparently
[07:42:46] <hbono> jrg: If I recall correctly, the "Chromium XP" bots always clobbers. (I may be wrong, though.)
[07:42:56] <jrg> hbono: don't know.
[07:43:10] <jrg> hbono: wait... we can just look at stout
[07:43:24] <leiz> it does
[07:43:29] <hbono> jrg: to read <http://chrome-buildbot.corp.google.com:8010/builders/Chromium%20XP/builds/13179/steps/compile/logs/stdio>, it writes "Deleting C:\b\slave\chromium-rel-xp\build\src\build\Release..."
[07:43:34] <hbono> jrg: yeah.
[07:43:35] <leiz> I'd just reopen and let it go again
[07:44:18] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open
[07:44:27] <hbono> re-opened.
[07:44:51] *** thakis_ has joined #chromium
[07:44:51] *** ChanServ sets mode: +v thakis_
[07:45:07] *** abarth has quit IRC
[07:46:04] <jrg> hbono: yeah, it's got --clobber in there.
[07:46:27] <hbono> jrg: thank you for noticing it. :)
[07:46:44] <timsteele> so my generated_resources patch failed to commit at first 'cause it was out of date,
[07:46:49] <timsteele> looks like satorux added some strings
[07:46:51] <timsteele> fyi
[07:46:54] *** thakis__ has joined #chromium
[07:46:54] *** ChanServ sets mode: +v thakis__
[07:47:20] <akalin2> sounds like satorux...strung you along
[07:47:27] * akalin2 puts on shades
[07:47:28] <mirandac> oops.   and zing!
[07:47:35] <akalin2> YEEEEAAAAHHHHHHHHH
[07:48:06] <mirandac> timsteele: thanks for mentioning.
[07:48:32] <hbono> indeed.
[07:48:45] <hbono> timsteele: thank you for noticing it.
[07:49:37] *** thakis_ has quit IRC
[07:49:54] *** fta_ has joined #chromium
[07:51:32] *** fta has quit IRC
[07:51:38] *** fta_ is now known as fta
[07:52:58] *** rniwa has joined #chromium
[07:53:10] *** General1337 has quit IRC
[07:53:33] *** General1337 has joined #chromium
[07:54:32] *** mpr has quit IRC
[07:55:45] *** jibot has quit IRC
[07:55:54] <timsteele> akalin2: http://bit.ly/cse2TX
[07:57:22] *** rniwa has quit IRC
[07:57:24] *** tehbaut has quit IRC
[07:57:41] *** fta has quit IRC
[07:57:44] *** purefusion has quit IRC
[07:58:06] <timsteele> akalin2: no response!? I thought that was pretty good.
[07:58:11] *** dave_levin has joined #chromium
[07:58:21] *** fta has joined #chromium
[07:58:23] *** thakis__ has quit IRC
[07:59:14] *** tehbaut has joined #chromium
[07:59:19] <leiz> timsteele: you probably traumatized him
[07:59:41] <timsteele> lol
[08:01:26] <akalin2> timsteele: damn that was pretty good
[08:01:46] *** purefusion has joined #chromium
[08:02:47] *** mirandac is now known as mirandac__afk
[08:06:16] *** hamaji has joined #chromium
[08:07:00] *** pfeldman has quit IRC
[08:08:08] *** mpr has joined #chromium
[08:14:45] *** hrna has joined #chromium
[08:16:31] *** roc has joined #chromium
[08:16:36] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open (hbono looking windows builders since r53008 added some strings.)
[08:18:39] <jshin> hbono: looks like i'd better wait a while before landing a CL with a grd change
[08:19:35] *** ukai has quit IRC
[08:20:13] <hbono> jshin: it is safer to announce it here.
[08:21:27] <jshin> hbono: do you think it's ok to land it now or wait a while for the previous string change to sort it out ?
[08:21:56] <hbono> jshin: sure. I'm happy to watch the bots. :)
[08:23:01] <jshin> hbono: thanks. i'll watch it for a while after landing, too
[08:23:47] *** pfeldman_ has joined #chromium
[08:25:04] *** ukai has joined #chromium
[08:26:19] *** fta_ has joined #chromium
[08:26:39] <jshin> a cl with a grd change was just landed
[08:26:45] *** pfeldman__ has joined #chromium
[08:27:15] *** General1337 has quit IRC
[08:27:30] *** fta has quit IRC
[08:27:38] *** fta_ is now known as fta
[08:30:14] <hbono> jshin: thanks you for noticing it.
[08:30:37] *** pfeldman_ has quit IRC
[08:31:01] <jshin> hbono: np :-)
[08:31:44] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac Builder" from 53016: jcivelli at chromium dot org)
[08:34:36] *** crf has joined #chromium
[08:37:51] *** bauerb has joined #chromium
[08:38:07] *** homata_ has joined #chromium
[08:39:05] *** General1337 has joined #chromium
[08:40:44] *** jcivelli has joined #chromium
[08:40:55] <jcivelli> Sorry for the breakage, reverting...
[08:40:55] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Mac Builder" -> distcc flake? hbono watching the next cycle)
[08:41:21] <jcivelli> Oh, I am not to blame?
[08:41:35] * leiz looks too
[08:42:13] <leiz> /b/slave/chromium-rel-mac-builder/build/src/chrome/browser/cocoa/translate/translate_infobar_base.mm: In member function 'virtual InfoBar* TranslateInfoBarDelegate::CreateInfoBar()':
[08:42:17] <leiz> /b/slave/chromium-rel-mac-builder/build/src/chrome/browser/cocoa/translate/translate_infobar_base.mm:105: error: 'kBeforeTranslate' was not declared in this scope
[08:42:19] <jcivelli> Yes, it's me
[08:42:48] <jcivelli> I'll revert
[08:44:14] <hbono> jcivelli: ah. thanks.
[08:44:56] *** fta_ has joined #chromium
[08:44:57] <hbono> jcivelli, leiz: I'm reading wrong places.
[08:45:00] *** pdelgallego has joined #chromium
[08:45:06] <jcivelli> OK, I reverted
[08:45:56] *** fta has quit IRC
[08:46:08] *** fta_ is now known as fta
[08:46:59] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Mac Builder" -> reverted r53016, waiting for cycling)
[08:47:03] *** homata_ has quit IRC
[08:47:24] *** homata_ has joined #chromium
[08:47:36] *** Erkan_Yilmaz__ has quit IRC
[08:47:41] *** nexex has quit IRC
[08:47:45] *** Hasbro has quit IRC
[08:47:53] *** nexex has joined #chromium
[08:47:56] *** pfeldman__ has quit IRC
[08:48:48] *** monreal has joined #chromium
[08:49:11] <jochen__> guys, can i land a grd change?
[08:49:14] <jochen__> strings only
[08:49:31] <hbono> jochen__: ok.
[08:49:45] <danno_> hbono: Can I land a windows admin template CL first?
[08:49:49] *** jshin has quit IRC
[08:50:08] <danno_> hbono: it is also just strings, but they are not grd strings
[08:51:16] <hbono> danno_: ok. but, currently windows builders already have two grd changes landed.
[08:51:16] <jochen__> i
[08:53:00] <danno_> hbono: my changes are in .adm/.admx admin templates that shouldn't cause build problems.
[08:53:57] <danno_> hbono: landed!
[08:55:22] <hbono> danno_: thanks you for noticing it. :)
[08:55:28] *** homata___ has joined #chromium
[08:55:45] *** Zaba has quit IRC
[08:57:10] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open (hbono watching windows bots because of grd changes)
[08:57:13] *** fta_ has joined #chromium
[08:57:26] *** homata_ has quit IRC
[08:57:55] *** fta has quit IRC
[08:58:07] *** fta_ is now known as fta
[09:01:45] *** nickcarter has quit IRC
[09:01:58] *** Zaba has joined #chromium
[09:03:28] *** hrna has quit IRC
[09:06:33] *** jshin has joined #chromium
[09:07:33] *** [Nef] has quit IRC
[09:12:20] <hbono> I would like to land a chage that pulls the new husnepll (1.2.11) when the tree becomes quiet.
[09:13:00] *** fta_ has joined #chromium
[09:14:12] *** fta has quit IRC
[09:14:22] *** fta_ is now known as fta
[09:15:34] *** bauerb has quit IRC
[09:19:23] *** janm has joined #chromium
[09:19:24] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac" from 53017: akalin at chromium dot org, jcivelli at chromium dot org, jrg at chromium dot org, jshin at chromium dot org, nick at chromium dot org, ricow at chromium dot org, satorux at chromium dot org, tim at chromium dot org (:timsteele))
[09:22:10] <timsteele> looks like jcivelli maybe? translate_infobar stuff?
[09:22:26] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Chromium Mac" -> r53016 reverted, hbono watching windows bots because of grd changes)
[09:23:33] <hbono> timsteele: it seems so.
[09:24:02] *** dave_levin has quit IRC
[09:24:08] *** dave_levin has joined #chromium
[09:24:26] <ricow> I am pretty sure we can rule out my change at least
[09:26:06] <hbono> ricow: jcivelli has already reverted his change. So, the bot is to cycle green.
[09:26:25] <ricow> great
[09:27:29] *** fta_ has joined #chromium
[09:27:46] *** fta has quit IRC
[09:27:55] *** fta_ is now known as fta
[09:31:48] *** jcivelli has quit IRC
[09:31:51] *** roc has quit IRC
[09:34:10] <leiz> hbono: can I land http://codereview.chromium.org/3047003/show when a try bot finishes?
[09:34:23] <leiz> hbono: it should make some valgrind bots happy
[09:34:51] <hbono> leiz: sure.
[09:35:39] <leiz> hbono: can you tell ukai r53000 caused a tsan error? http://build.chromium.org/buildbot/memory/builders/Windows%20Tests%20(tsan)/builds/1047
[09:36:04] <hbono> ukai: ping?
[09:36:14] *** Precea is now known as Precea[BNC]
[09:36:19] <leiz> ukai: oh, you're on irc, duh. :) ^^^
[09:38:17] <ukai> hi
[09:39:16] <hbono> ukai: hbono: can you tell ukai r53000 caused a tsan error? http://build.chromium.org/buildbot/memory/builders/Windows%20Tests%20(tsan)/builds/1047
[09:39:34] *** bauerb_ has joined #chromium
[09:39:35] <ukai> will look into this
[09:40:38] *** JakeSays has quit IRC
[09:40:40] *** bauerb_ has quit IRC
[09:40:42] *** bauerb has joined #chromium
[09:40:43] *** ChanServ sets mode: +v bauerb
[09:41:12] *** fta_ has joined #chromium
[09:41:17] *** janm has quit IRC
[09:41:51] *** JakeSays has joined #chromium
[09:42:16] *** johnny_g has joined #chromium
[09:42:23] *** fta has quit IRC
[09:42:37] *** fta_ is now known as fta
[09:42:59] *** johnny_g_ has joined #chromium
[09:43:06] *** maikmerten has joined #chromium
[09:45:38] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("Chromium Mac" -> cycling green, hbono watching windows bots because of grd changes)
[09:46:51] *** johnny_g has quit IRC
[09:46:52] *** johnny_g_ is now known as johnny_g
[09:52:43] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 53021: danno at chromium dot org, jochen at chromium dot org (:jochen__))
[09:54:09] <jochen__> grd fallout
[09:54:21] <hbono> jochen__: it seems so.
[09:56:37] <leiz> better to just keep the tree closed for the grd change rather than having the tree close over and over again
[09:58:49] *** apavlov has joined #chromium
[09:58:49] <hbono> leiz: yeah.
[10:00:28] <hbono> leiz: there are los of grd changes today.
[10:03:41] *** homata_ has joined #chromium
[10:03:49] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Vista Tests (dbg)(1)" -> grd fallout)
[10:05:46] *** homata___ has quit IRC
[10:07:25] *** chrisccoulson has joined #chromium
[10:07:29] *** monreal has quit IRC
[10:08:40] *** pfeldman_ has joined #chromium
[10:09:31] *** johnny_g_ has joined #chromium
[10:13:24] *** johnny_g has quit IRC
[10:13:56] *** star-affinity has joined #chromium
[10:14:08] *** jshin has left #chromium
[10:14:36] *** fta_ has joined #chromium
[10:16:13] *** fta has quit IRC
[10:16:21] *** fta_ is now known as fta
[10:19:09] *** monreal has joined #chromium
[10:28:41] *** roc has joined #chromium
[10:34:07] *** ROBOd has joined #chromium
[10:36:16] *** [Nef] has joined #chromium
[10:45:15] *** ScriptRipper has joined #chromium
[10:45:31] *** ScriptRipper has quit IRC
[10:45:31] *** ScriptRipper has joined #chromium
[10:46:05] *** exxe has joined #chromium
[10:47:15] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Vista Tests (dbg)(1)" -> grd fallout, waiting for cycling green)
[10:59:54] *** wyfrn has joined #chromium
[11:10:04] *** tonikitoo has quit IRC
[11:12:38] <yutak> Can we open the tree?
[11:13:01] <hbono> yutak: do you have an urgent change?
[11:13:36] <yutak> Not an urgent one
[11:16:15] <hbono> yutak: we are to create a m6 branch soon. So, if your change is not a m6 change, it may be a good idea to wait until creating the branch.
[11:18:33] <yutak> My change is an M6 bug fix
[11:19:10] <yutak> It's simple enough and confirmed on the try bot
[11:19:34] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open ("Vista Tests (dbg)(1)" -> cycling green)
[11:19:37] <hbono> yutak: I have re-opened the tree since all tests are cycling green.
[11:19:55] <hbono> finally.
[11:20:30] <leiz> hbono: I have a bunch of non-code fixes. Going to commit them and go to bed.
[11:20:33] <yutak> Thanks
[11:20:58] <hbono> leiz: sure. :)
[11:21:45] <hbono> I have landed a change that pulls the new hunspell. Sorry if it causes a sync problem.
[11:21:54] *** tonikitoo has joined #chromium
[11:25:20] <leiz> hbono: ok, I'm off to bed. Please revert my changes if they cause trouble.
[11:25:50] <hbono> leiz: yeah. have a good night.
[11:33:43] *** hsb has joined #chromium
[11:34:46] *** fusion44 has joined #chromium
[11:36:46] *** hsb has left #chromium
[11:41:01] *** sleetdrop has joined #chromium
[11:41:08] *** kazoo has joined #chromium
[11:54:55] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open
[11:54:57] *** peterdn has joined #chromium
[11:57:45] *** Peter` has quit IRC
[11:59:15] *** Peter` has joined #chromium
[12:00:53] *** homata___ has joined #chromium
[12:03:46] *** homata_ has quit IRC
[12:06:31] *** kazoo has quit IRC
[12:13:40] *** davirtavares has joined #chromium
[12:19:05] <timing> how do I make chrome break on js errors?
[12:19:26] <timing> it just stops execution without telling me where
[12:19:40] <timing> I have to turn to firefox with firebug to find those bugs
[12:28:35] *** GeekShadow has joined #chromium
[12:28:54] <ricow> timing: see topic
[12:30:17] <timing> o wrong channel
[12:30:26] <timing> but while i'm here, does someone know the answer?
[12:31:47] <ricow> timing: menu -> developer -> developer tools
[12:32:06] *** FullFlannelJacke has joined #chromium
[12:32:39] <timing> yes
[12:32:59] <timing> but when I for example call a function on a non exisiting object
[12:33:11] <timing> firebug gives me an error explaining what's going on
[12:33:18] <timing> but the developer tools do not
[12:33:30] <timing> it just stops executing the javascript
[12:33:39] <timing> I have to add a lot of log lines to see where the javascript stops
[12:37:27] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Mac10.6 Tests (dbg)(1)" from 53035: satorux at chromium dot org)
[12:41:15] <satorux> hmm, my change was nothing to do with mac...
[12:41:44] <satorux> now looking at the error message
[12:43:52] *** finnur has joined #chromium
[12:43:52] *** ChanServ sets mode: +v finnur
[12:44:41] <satorux> URLFetcherTest.SameThreadsTest was failing
[12:45:05] <hbono> satorux: yeah. it failed starting the test server.
[12:45:33] <satorux> hbono: do you have any idea why this started?
[12:46:32] <hbono> satorux: maybe it's just a flakiness of the bot. I'm re-running the test.
[12:46:39] <satorux> thanks
[12:49:15] <hbono> satorux: no problem.
[12:49:34] <trungl-bot> Tree closed by hbono at chromium dot org: Tree is closed ("Mac10.6 Tests (dbg)(1)" -> flake? hbono watching the next cycle)
[12:50:42] *** fta has quit IRC
[12:51:21] *** fta has joined #chromium
[12:58:06] *** akalin has quit IRC
[12:58:07] *** leavittx has quit IRC
[12:58:07] *** solsTiCe has quit IRC
[13:00:24] *** akalin has joined #chromium
[13:00:24] *** solsTiCe has joined #chromium
[13:00:24] *** leavittx has joined #chromium
[13:02:03] *** chrisccoulson has quit IRC
[13:03:59] *** Emperorlou has joined #chromium
[13:04:18] <timing> ricow: hmm, there are more users with the same question. so it's probably a feature request/bug
[13:04:57] <hbono> satorus: the tests succeeded in the next cycle. I have re-opened the tree.
[13:05:43] <trungl-bot> Tree opened by hbono at chromium dot org: Tree is open
[13:10:19] *** andrix has joined #chromium
[13:12:24] *** vesav has quit IRC
[13:12:36] <satorux> hbono: thanks!
[13:12:53] <hbono> satorux: no problem. :)
[13:14:03] <hbono> I would like to leave the office, wishing the tree keeps green.
[13:16:17] *** hbono has quit IRC
[13:18:03] *** fta_ has joined #chromium
[13:19:35] *** fta has quit IRC
[13:19:48] *** fta_ is now known as fta
[13:23:39] *** sleetdrop has quit IRC
[13:26:49] *** Peter` has quit IRC
[13:27:16] *** cbentzel has joined #chromium
[13:27:17] *** ChanServ sets mode: +v cbentzel
[13:29:30] *** finnur has quit IRC
[13:32:10] *** finnur has joined #chromium
[13:32:10] *** ChanServ sets mode: +v finnur
[13:37:54] *** Peter` has joined #chromium
[13:38:24] *** cbentzel has quit IRC
[13:40:21] *** homata_ has joined #chromium
[13:42:12] *** tonikitoo has quit IRC
[13:42:45] *** homata___ has quit IRC
[13:43:10] *** mazda has quit IRC
[13:47:54] *** crf has quit IRC
[13:48:47] *** awolfson has quit IRC
[13:57:01] *** zaspire has joined #chromium
[14:00:13] *** fta_ has joined #chromium
[14:00:34] *** fta has quit IRC
[14:00:51] *** fta_ is now known as fta
[14:02:14] *** duffydack has joined #chromium
[14:03:18] *** chrisccoulson has joined #chromium
[14:05:16] *** homata_ has quit IRC
[14:07:48] *** General13372 has joined #chromium
[14:08:06] *** duffydack has left #chromium
[14:09:35] *** ebraminio has joined #chromium
[14:11:45] *** General1337 has quit IRC
[14:25:38] *** fta_ has joined #chromium
[14:27:04] *** fta has quit IRC
[14:27:17] *** fta_ is now known as fta
[14:29:35] *** tonikitoo has joined #chromium
[14:32:07] *** duffydack has joined #chromium
[14:33:27] *** duffydack has left #chromium
[14:37:25] *** wb_ has joined #chromium
[14:38:21] *** OtherJakeSays has joined #chromium
[14:40:05] *** tonikitoo has quit IRC
[14:40:27] *** JakeSays has quit IRC
[14:40:28] *** andrix has quit IRC
[14:48:51] *** tonikitoo has joined #chromium
[14:50:22] *** pdelgallego has quit IRC
[14:51:37] *** jeremymos has joined #chromium
[14:51:37] *** ChanServ sets mode: +v jeremymos
[14:54:06] *** AaronMT has joined #chromium
[14:54:07] *** fta_ has joined #chromium
[14:54:22] *** fta has quit IRC
[14:54:27] *** fta_ is now known as fta
[14:55:45] *** kwaak has joined #chromium
[14:57:05] *** MX80 has quit IRC
[14:58:41] *** andrix has joined #chromium
[15:00:09] *** MikeSmithW3C has joined #chromium
[15:02:31] *** awolfson has joined #chromium
[15:02:38] *** chrisccoulson has quit IRC
[15:03:12] *** chrisccoulson has joined #chromium
[15:03:29] *** pdelgallego has joined #chromium
[15:04:40] *** fleymn has joined #chromium
[15:06:06] *** jrmuizel has joined #chromium
[15:06:12] *** fleymn has quit IRC
[15:07:39] <kwaak> I'm porting some FF exts over, and Chrome doesn't have ANY  IO/Process API's in the Chrome.* NS (Similiar to https://developer.mozilla.org/en/nsIProcess). Would NPAPI plugins be the only way/ (lols)
[15:08:41] *** fleymn has joined #chromium
[15:10:41] *** MX80 has joined #chromium
[15:14:01] *** pinkerton has joined #chromium
[15:14:01] *** ChanServ sets mode: +v pinkerton
[15:14:46] *** jrmuizel has quit IRC
[15:19:47] *** yurys has quit IRC
[15:23:16] *** flyflylee has joined #chromium
[15:24:51] *** fleymn has quit IRC
[15:27:48] *** flyflylee has quit IRC
[15:28:53] *** flyflylee has joined #chromium
[15:29:01] *** yurys has joined #chromium
[15:35:40] *** dave_levin has quit IRC
[15:35:49] *** dave_levin has joined #chromium
[15:36:52] *** fta_ has joined #chromium
[15:38:18] *** fta has quit IRC
[15:38:31] *** fta_ is now known as fta
[15:39:15] *** koollman has left #chromium
[15:41:39] *** wyfrn has quit IRC
[15:41:51] *** pinkerton_ has joined #chromium
[15:41:52] *** ChanServ sets mode: +v pinkerton_
[15:42:08] *** pinkerton_ is now known as pink_mbp
[15:42:34] *** pinkerton has quit IRC
[15:46:08] *** fleymn has joined #chromium
[15:49:20] *** flyflylee has quit IRC
[15:50:08] *** solsTiCe has left #chromium
[15:54:11] *** Precea[BNC] is now known as Precea
[15:54:39] *** aroben has joined #chromium
[15:54:39] *** aroben has joined #chromium
[16:03:46] *** fta_ has joined #chromium
[16:05:13] *** fta has quit IRC
[16:05:16] *** fta_ is now known as fta
[16:05:37] *** malavv has quit IRC
[16:05:42] *** malavv has joined #chromium
[16:09:03] *** leeight has joined #chromium
[16:09:16] *** leeight has left #chromium
[16:12:30] *** agayev has joined #chromium
[16:13:15] *** dmaclach has joined #chromium
[16:13:43] *** ctruta has joined #chromium
[16:18:00] *** Kunalagon has joined #chromium
[16:18:43] *** jrmuizel has joined #chromium
[16:19:01] *** dmaclach has quit IRC
[16:19:28] *** Adys has joined #chromium
[16:21:13] *** agayev has quit IRC
[16:22:24] *** nfa has joined #chromium
[16:22:37] *** agayev has joined #chromium
[16:23:30] *** awolfson has quit IRC
[16:25:21] *** tedoc2000 has joined #chromium
[16:26:45] *** fleymn has quit IRC
[16:27:02] *** pinkerton has joined #chromium
[16:27:02] *** ChanServ sets mode: +v pinkerton
[16:28:27] *** awolfson has joined #chromium
[16:28:35] *** gavinp` has joined #chromium
[16:28:35] *** ChanServ sets mode: +v gavinp`
[16:29:31] *** pink_mbp has quit IRC
[16:30:35] *** cbentzel has joined #chromium
[16:30:35] *** ChanServ sets mode: +v cbentzel
[16:31:12] *** fta_ has joined #chromium
[16:32:24] *** fta has quit IRC
[16:32:30] *** fta_ is now known as fta
[16:33:34] *** nfa has left #chromium
[16:39:02] *** trungl has joined #chromium
[16:39:02] *** ChanServ sets mode: +v trungl
[16:41:53] *** Vanderhuge has joined #chromium
[16:43:22] *** Adys has quit IRC
[16:44:46] <malavv> Good morning Chromium, maybe I am not searching at the right place, but does someone knows if there is a way to know from which plugin comes a request from the browser? It seems like all the information is lost within Webkit
[16:44:47] <trungl-bot> malavv: Good morning!
[16:46:35] *** AryehGregor has quit IRC
[16:47:28] *** Adys has joined #chromium
[16:47:48] *** jrforbes_ has joined #chromium
[16:48:10] * trungl is sure trungl-bot doesn't know the answer.
[16:48:20] * trungl doesn't quite parse the question either, unfortunately.
[16:48:57] <trungl> malavv: sorry, what exactly are you asking?
[16:50:28] <malavv> The question was not intended for the trungl-bot, I appreciated the fact that it even tried to answer
[16:50:39] *** AryehGregor has joined #chromium
[16:50:54] <trungl> malavv: I realize that, but I myself don't understand your question
[16:51:06] <gavinp`> trungl-bot is nothing if not earnest.
[16:51:06] <trungl-bot> gavinp`: Error: "is" is not a valid command.
[16:51:13] <gavinp`> i take that back.
[16:51:17] <trungl> haha
[16:51:56] <trungl> malavv: in particular, what request? ("from the browser"?)
[16:51:57] <malavv> I am looking for a way to know from which plug-in comes the urlRequest while being on the IOThread of the main process
[16:52:20] <trungl> oh
[16:52:29] <trungl> yeah, that might be lost in webkit
[16:52:35] *** kliegs has quit IRC
[16:52:44] <trungl> hrm
[16:52:45] <pinkerton> anyone know what's up with the win webkit failues?
[16:53:01] <malavv> k, k Thanks trungl
[16:53:25] <trungl> malavv: I don't know this code very well, so don't take my word as gospel, though
[16:54:11] *** wyfrn has joined #chromium
[16:54:55] *** erikkay has joined #chromium
[16:54:55] *** ChanServ sets mode: +v erikkay
[16:55:27] *** Adys has quit IRC
[16:55:28] *** Adys_ has joined #chromium
[16:56:17] <cbentzel> trungl-bot: what is a grue?
[16:56:17] <trungl-bot> cbentzel: Error: "what" is not a valid command.
[16:56:41] <Emperorlou> trungl-bot: define grue
[16:56:42] <trungl-bot> Emperorlou: Error: "define" is not a valid command.
[16:56:48] *** hrna has joined #chromium
[16:56:51] <Emperorlou> heh
[16:56:53] *** kwaak has left #chromium
[16:57:56] *** Adys_ is now known as Adys
[17:00:23] *** kliegs has joined #chromium
[17:00:46] <pinkerton> thakis: ping?
[17:00:55] <thakis> pinkerton: pong
[17:00:58] *** Venom_X has joined #chromium
[17:01:06] <pinkerton> why do we need this viewID thing? why can't we use viewWithTag?
[17:01:09] <cbentzel> I'll disable the PauseWhenNotConnected syncer test
[17:01:22] <thakis> pinkerton: it's used in xplat testing code
[17:01:35] <pinkerton> so?
[17:01:35] * thakis looks for an example?
[17:02:40] <thakis> pinkerton: suzhe stored the view ids in the tag in an early CL, but several of our views use tags for something else
[17:02:51] <pinkerton> hmm
[17:03:01] <pinkerton> it just sucks to be re-inventing the wheel
[17:03:28] <thakis> e.g. chrome/browser/browser_focus_uitest.cc
[17:03:42] <thakis> tree traversal is a 5 line wheel
[17:03:53] <thakis> and we need more than one tag per view sometimes
[17:04:02] <pinkerton> with lots of arguing about maps and caches
[17:04:25] *** wyfrn has quit IRC
[17:04:36] <thakis> also, this viewID stuff is purely for testing, so it shouldn't take away `tag`, when `tag` is used by 'real' code
[17:04:57] <Emperorlou> trungl-bot: Do .wav support in html5 for chrome
[17:04:57] <trungl-bot> Emperorlou: Error: "Do" is not a valid command.
[17:05:10] <thakis> pinkerton: it's not really lots of arguing
[17:05:15] *** satish_ has joined #chromium
[17:05:19] <pinkerton> ok :)
[17:06:09] <thakis> pinkerton: even if trung feels strongly about the map, the hash table could be replaced by associative references on the views. that would be a ~10 line change to the current cl
[17:06:19] <thakis> i think the current version of the cl is either good as-is or very close
[17:06:22] <trungl> that would be greatly preferable
[17:06:29] <trungl> I also don't see why things need to be unset
[17:06:32] <trungl> (on dealloc)
[17:06:36] <thakis> tidiness
[17:06:46] <trungl> (except insofar as there's a map)
[17:07:09] <trungl> the lifetime/accessibility of the ViewID should be the same as that of the view
[17:07:10] <trungl> tidiness my ass
[17:07:21] <trungl> the net result is a whole lot of untidiness
[17:07:26] <trungl> and global state
[17:07:46] <thakis> trungl: :-) maybe you can express that in a more enthusiastic form on the review
[17:07:46] <trungl> associative references would be preferable
[17:08:29] <thakis> "much better; can you replace the hash table in these two functions with associative references? that should be a 10-line change and you don't need the dealloc overrides anymore" or somethign like that
[17:10:03] *** mdwright_laptop has joined #chromium
[17:11:40] *** clawtros has joined #chromium
[17:12:11] <thakis> willchans OOO autoresponder is nice
[17:12:19] <clawtros> is there a way to cancel an event?  returning false doesn't seem to do anything
[17:12:53] <clawtros> er this is for an extension i'm mucking around with
[17:13:10] *** rdsmith has joined #chromium
[17:13:10] *** ChanServ sets mode: +v rdsmith
[17:14:34] *** mrossetti has joined #chromium
[17:15:10] *** wyfrn has joined #chromium
[17:15:51] *** awidegreen has joined #chromium
[17:16:16] *** tonyg-cr has joined #chromium
[17:16:16] *** ChanServ sets mode: +v tonyg-cr
[17:16:53] <trungl> thakis: his email autoresponder?
[17:17:01] <thakis> trungl: yes
[17:17:22] <trungl> thakis: you're going to make us all send him email to see his autoresponder?
[17:17:31] * trungl will blame thakis, you know.
[17:17:42] <thakis> send him a valgrind fix CL
[17:18:10] <trungl> those are annoying to come up with
[17:18:21] <trungl> unless I first create a memory leak
[17:19:46] <thakis> chrome is full of memory leaks as is
[17:20:03] <trungl> yeah, but then I'd have to find one
[17:20:16] <trungl> it's like finding a needle in a pin cushion!
[17:20:31] *** pinkerton has quit IRC
[17:24:55] *** sogar_gofin has left #chromium
[17:25:02] *** sogar_gofin has joined #chromium
[17:25:06] *** dglazkov has joined #chromium
[17:25:06] *** ChanServ sets mode: +v dglazkov
[17:25:19] *** trungl has quit IRC
[17:25:48] <dglazkov> good morning, Chromium!
[17:25:48] <trungl-bot> dglazkov: Good morning!
[17:27:25] *** abarth has joined #chromium
[17:27:25] *** ChanServ sets mode: +v abarth
[17:28:41] <thakis> good morning, dglazkov
[17:29:00] <dglazkov> thakis: hey! how's China?
[17:29:02] *** Erkan_Yilmaz has joined #chromium
[17:29:53] *** wyfrn has quit IRC
[17:30:52] <thakis> dglazkov: old
[17:31:35] *** pinkerton has joined #chromium
[17:31:35] *** ChanServ sets mode: +v pinkerton
[17:32:51] *** finnur has quit IRC
[17:34:01] *** senorblanco has joined #chromium
[17:34:01] *** ChanServ sets mode: +v senorblanco
[17:35:05] *** Adys has quit IRC
[17:35:32] *** sgronblo has joined #chromium
[17:35:55] <sgronblo> Does the history page in chrome support entering a date as a parameter?
[17:37:03] *** dmaclach has joined #chromium
[17:37:06] *** finnur has joined #chromium
[17:37:06] *** ChanServ sets mode: +v finnur
[17:37:15] *** agayev has quit IRC
[17:37:55] *** agayev has joined #chromium
[17:38:05] <sogar_gofin> Hello all. Can someone give me some pointers on hwo to hook the allocator in /base/ up for my own project? Is it as simple as linking the allocator library to my application, then maybe instantiating a global scope object in my main.cpp?
[17:45:13] *** mdwright_laptop has left #chromium
[17:45:48] <thakis> sogar_gofin: have you seen base/allocator/README ?
[17:47:51] *** finnur has quit IRC
[17:48:29] <thakis> sogar_gofin: linking in the lib should be enough, but you can always try putting some logging message into malloc (and hope that the logging statement doesn't need to malloc :-) ), recompile, and check that it gets called
[17:48:57] <sogar_gofin> ah, there is the README =) *slaps forehead*
[17:49:01] <sogar_gofin> thanks very much thankis!
[17:49:47] <pinkerton> he's our favorite bot
[17:49:57] <Emperorlou> it would appear websockets are not working in the latest chrome (though its hard to tell if its glassfish that's failing or not. However to taht effect, a standalone websocket client worked)
[17:50:54] <Emperorlou> Any known issues?
[17:53:09] *** trungl has joined #chromium
[17:53:10] *** ChanServ sets mode: +v trungl
[17:54:34] <sogar_gofin> thakis ~ this may or may not be another dumb question but I'd appreciate any insight you can offer:
[17:55:10] <malavv> Emperorlou: Apparently not, there are suppose to work sorry. Still implementing new handshake protocol though
[17:55:19] <sogar_gofin> I see that Chromium has actually taken the libcmt.lib from microsoft and hard-modified the entries for [de]allocation within it to re-direct to the custom [de]allocators.
[17:55:56] <sogar_gofin> Do I need to worry about whether or not libcmt.lib is an older version of the libcmt code that might have vulnerabilities, etc, or are all the updates that MS issues binary-compatible with this library?
[17:58:03] <sogar_gofin> ... did that all make sense? I might have a misconception about something
[17:59:17] <thakis> dunno
[17:59:24] <thakis> chrome uses it
[18:00:48] <malavv> A question to the Webkit folks around, when I follow a request that is initiated by a out of process plugins, for some reason, m_requestorProcessID doesn't get set
[18:01:36] <malavv> It seems that this was meant exactly for what I'm trying to use it, but does not seem to be working
[18:01:52] <malavv> Or did it purpose changed along the way?
[18:03:55] *** yesudeep has joined #chromium
[18:05:40] *** monreal has quit IRC
[18:06:03] *** chrisccoulson has quit IRC
[18:06:28] *** Adys has joined #chromium
[18:08:23] *** monreal has joined #chromium
[18:10:01] *** [Nef] has quit IRC
[18:10:55] *** clawtros has left #chromium
[18:11:08] *** stuartmorgan has joined #chromium
[18:11:08] *** ChanServ sets mode: +v stuartmorgan
[18:14:02] *** marklarson has joined #chromium
[18:16:39] *** bauerb has quit IRC
[18:16:57] <dhollowa> pinkerton: a suppression for mac valgrind: http://codereview.chromium.org/3037011/show
[18:17:21] <sogar_gofin> When I include the allocator.lib in my linker line, I get compile errors >MSVCRT.lib(MSVCR80.dll) : error LNK2005: _realloc already defined in allocator.lib(allocator_shim.obj)
[18:18:00] <pinkerton> dhollowa: is there any way to restrict that regexp any?
[18:18:06] <pinkerton> Z* seems a bit much
[18:18:25] <dhollowa> pinkerton: that was the most specific i could get
[18:18:41] <dhollowa> pinkerton: it is just the single func though
[18:18:55] <sogar_gofin> It looks like a few of the libs I have besides LIBCMT include definitions for malloc, _realloc, etc. Has anyone had a similar issue? Is there a way to force it to keep the first link references from allocator still link against MSVCRT even though it has the same symbols in it?
[18:18:55] <pinkerton> ok
[18:19:10] <pinkerton> dhollowa: did you want a lgtm, or...?
[18:19:16] <dhollowa> pinkerton: please
[18:20:11] <dhollowa> pinkerton: if it is helpful i was planning to work through some of the others too
[18:20:19] <pinkerton> sweet
[18:22:03] *** shreyas_ has joined #chromium
[18:24:35] *** phajdan-jr has joined #chromium
[18:24:35] *** ChanServ sets mode: +v phajdan-jr
[18:24:43] <pinkerton> hrm, after upgrading to 10.6, i'm only using about 8 cores of the 16 on my distributed build box
[18:24:48] <thakis> sogar_gofin: http://www.google.com/search?sourceid=chrome&ie=UTF-8&q=replace+malloc+msvcrt
[18:24:49] <pinkerton> so the build is going pretty slow
[18:25:19] <thakis> pinkerton: there was a thread on that on chromium-dev. not sure if distcc or ccache was the culprit
[18:25:30] <pinkerton> it seems to work fine at the office
[18:25:40] <thakis> try disabling distcc, 16 cores are fast too
[18:25:54] *** fta_ has joined #chromium
[18:26:10] <pinkerton> disabling distcc on which machine? the local one?
[18:26:13] <pinkerton> it's off
[18:26:14] *** RT|Chatzilla has quit IRC
[18:26:55] *** johnny_g has joined #chromium
[18:26:56] *** ChanServ sets mode: +v johnny_g
[18:27:17] *** fta has quit IRC
[18:27:28] *** Zucca has quit IRC
[18:27:29] *** fta_ is now known as fta
[18:27:57] <sogar_gofin> thanks thankis
[18:28:19] *** star-affinity has quit IRC
[18:28:21] <sogar_gofin> thakis*
[18:29:16] <pinkerton> now it's back to pegging all 16 cores
[18:29:16] *** jrforbes_ has quit IRC
[18:29:25] *** rsesek has joined #chromium
[18:29:25] *** ChanServ sets mode: +v rsesek
[18:29:27] <pinkerton> it's like some projects are misconfigured or something
[18:30:05] *** Adys has quit IRC
[18:31:22] *** cbentzel has quit IRC
[18:31:35] <wjmaclean> Can I kill a job I sent to the try-bot?
[18:31:43] <rsesek> no
[18:32:05] <pinkerton> and don't try to
[18:33:04] *** agayev has quit IRC
[18:33:38] <thakis> pinkerton: talking about it seems to have helped then
[18:33:41] <thakis> therapy works
[18:33:41] *** rniwa has joined #chromium
[18:33:42] *** ChanServ sets mode: +v rniwa
[18:33:49] <pinkerton> well webkit is back to 8cores
[18:33:59] <pinkerton> base and browser peg all 16, but webkit doesn't
[18:35:09] *** andrix has quit IRC
[18:35:31] <thakis> how does that make you feel?
[18:35:32] <pinkerton> why does the waterfall just sometimes forget it's in merge mode?
[18:35:43] *** jshin has joined #chromium
[18:35:47] <trungl> thakis: why do ask how does that make you feel?
[18:35:48] *** ChanServ sets mode: +v jshin
[18:36:10] *** andrix has joined #chromium
[18:37:04] <trungl> pinkerton: forget how?
[18:37:10] <pinkerton> stops being in merge mode
[18:37:16] <pinkerton> upon a reload
[18:37:40] <trungl> hmm
[18:37:56] <dhollowa> anyone available for suppression review? http://codereview.chromium.org/2873053/show
[18:38:01] <pinkerton> it's like the cookie it sets goes away every few hours or so
[18:38:03] <thakis> trungl: don't ask me, ask pink. he has 8 idle cores, not me
[18:38:28] <thakis> dhollowa: can't you fix the leak instead? :-/
[18:38:28] <trungl> maybe the cookie expires?
[18:38:32] * trungl looks
[18:38:55] <rsesek> dhollowa: that's not a leak. that's an invalid read
[18:39:37] <thakis> *can't you just fix the invalid read?
[18:39:49] <dhollowa> thakis: was planning to make bots go green then look at the fixes.
[18:39:50] <rsesek> it may just be an uninitialized variable or something
[18:40:15] <dhollowa> thakis: no?
[18:40:54] <phajdan-jr> sheriffs, I'm going to grab some breakfast. If my change causes any problems, feel free to revert immediately. Should be fine though. Watch out for flaky failures.
[18:41:02] <phajdan-jr> pinkerton: ^
[18:41:05] *** phajdan-jr is now known as phajdan-jr|afk
[18:41:18] <pinkerton> thanks for the headsup
[18:41:21] <thakis> dhollowa: dunno, if i want to fix a leak i usually don't submit a suppression first, to make sure i really go on to fix it :-P
[18:41:32] <trungl> pinkerton: hrm, the cookie is supposed to last for 30 days
[18:41:53] <dhollowa> thakis: this isn't in my stuff.  i'm sending bugs to owners.
[18:41:56] <pinkerton> trungl: well then something is broken. it happens on all my machines.
[18:42:06] <thakis> dhollowa: i'll take a look if i can fix the problem
[18:42:31] * trungl blames the time warp in pinkerton's vicinity.
[18:42:32] <thakis> dhollowa: do you happen to know which test this is in?
[18:42:54] *** abarth has quit IRC
[18:43:08] <dhollowa> thakis: no, it is unclear.  it is in the TearDown after a timer delay
[18:43:19] <thakis> dhollowa: ok, will find out
[18:43:56] *** abarth has joined #chromium
[18:43:56] *** ChanServ sets mode: +v abarth
[18:44:06] *** finnur has joined #chromium
[18:44:06] *** ChanServ sets mode: +v finnur
[18:45:37] *** Zucca has joined #chromium
[18:46:28] *** sgronblo has left #chromium
[18:48:30] *** Venom_X has quit IRC
[18:48:50] *** Venom_X has joined #chromium
[18:52:21] *** phajdan-jr|afk is now known as phajdan-jr
[18:54:56] *** Venom_X has quit IRC
[18:59:00] <pinkerton> trungl: what's an associative reference?
[18:59:07] <pinkerton> in the context of this cl?
[18:59:24] *** Viclame has joined #chromium
[18:59:31] <trungl> oh crap
[18:59:41] <trungl> I just noticed that they're only available in 10.6 or later
[18:59:42] <trungl> sigh
[18:59:48] <trungl> pinkerton: http://developer.apple.com/iphone/library/documentation/cocoa/conceptual/objectivec/Articles/ocAssociativeReferences.html
[18:59:58] <motownavi> http://angrymuon.squarespace.com/journal/2009/9/6/extending-object-behaviour-in-objective-c-with-associated-re.html
[19:00:00] <trungl> hrm
[19:00:08] <trungl> bummer
[19:00:37] <pinkerton> oh right
[19:00:43] <pinkerton> doesn't that also require the 64bit runtime?
[19:00:45] *** csilv has joined #chromium
[19:00:53] *** ChanServ sets mode: +v csilv
[19:01:02] <motownavi> don't think so
[19:01:17] <motownavi> it just adds a feature
[19:01:48] <motownavi> you need 64 bits for exception unification and non-fragile subclassing
[19:03:08] *** eroman has joined #chromium
[19:03:08] *** ChanServ sets mode: +v eroman
[19:03:53] *** scarybeasts has joined #chromium
[19:05:13] *** kerz has joined #chromium
[19:05:13] *** ChanServ sets mode: +v kerz
[19:07:19] *** yesudeep has left #chromium
[19:08:33] *** jamesr has joined #chromium
[19:08:33] *** ChanServ sets mode: +v jamesr
[19:10:18] *** tabatkins is now known as TabAtkins
[19:13:01] *** Venom_X has joined #chromium
[19:13:20] *** Precea is now known as Precea[BNC]
[19:13:31] *** dave_levin has joined #chromium
[19:14:02] <malavv> ping dimich
[19:15:19] <leiz> is that an all green tree I see?!
[19:15:40] <phajdan-jr> better make a screenshot, it's gonna change ;-)
[19:15:41] *** shreyas_ has quit IRC
[19:15:50] <phajdan-jr> but it's good to see the greeeen
[19:16:11] <leiz> quick, land a grd change ;)
[19:17:06] *** fta_ has joined #chromium
[19:18:15] *** markmentovai has joined #chromium
[19:18:15] *** ChanServ sets mode: +v markmentovai
[19:18:49] *** fta has quit IRC
[19:18:58] *** fta_ is now known as fta
[19:19:27] *** victorw has joined #chromium
[19:19:27] *** ChanServ sets mode: +v victorw
[19:21:22] *** hayato_ has joined #chromium
[19:21:43] *** shreyas_ has joined #chromium
[19:21:56] <scarybeasts> leiz: do your worst :P
[19:22:09] *** hayato_ has quit IRC
[19:24:35] <pinkerton> grr my waterfall stopped reloading
[19:25:03] <thakis> trungl: oh well
[19:25:12] <trungl> sniff
[19:25:20] <thakis> would be nicer, but it's ok as is too
[19:25:40] <pinkerton> there's been a lot of win test flake, both xptests and webkit this morning
[19:25:51] *** peterdn has quit IRC
[19:26:03] <trungl> I'm not super-thrilled about it, but other fixes would also seem to be fairly invasive
[19:26:15] <trungl> though maybe we should just provide the ability to set ViewIDs for controls
[19:26:19] * trungl shrugs
[19:26:31] <trungl> (or even just buttons)
[19:28:54] *** aroben is now known as aroben|afk
[19:29:07] <thakis> i think it's ok as is
[19:31:00] <trungl> yeah
[19:31:10] <trungl> the cure may be worse than the disease
[19:33:34] *** cbentzel has joined #chromium
[19:33:34] *** ChanServ sets mode: +v cbentzel
[19:36:43] <Emperorlou> loislo: Any more ideas why chrome would be experiencing packet loss when streaming xhr from the server?
[19:36:54] <Emperorlou> *message loss I suppose
[19:36:58] <pinkerton> shower, back in 15. don't break mah tree
[19:38:46] *** davirtavares has quit IRC
[19:39:44] *** Venom_X_ has joined #chromium
[19:40:08] <dimich> malavv: pong
[19:40:13] *** abarth has quit IRC
[19:42:32] *** bweinstein has joined #chromium
[19:43:33] *** Venom_X has quit IRC
[19:43:34] *** Venom_X_ is now known as Venom_X
[19:47:41] *** estes has joined #chromium
[19:48:16] *** shreyas_ has quit IRC
[19:51:21] *** abarth has joined #chromium
[19:51:21] *** ChanServ sets mode: +v abarth
[19:51:26] <pinkerton> sync unit tests have failed twice in a row
[19:51:28] *** abarth has quit IRC
[19:51:37] <pinkerton> phajdan-jr: started with your cl, thoughts?
[19:53:22] *** OtherJakeSays is now known as JakeSays
[19:53:28] *** pfeldman_ has quit IRC
[19:53:40] *** shreyas_ has joined #chromium
[19:54:34] <rsesek> thakis: yt?
[19:54:38] <thakis> rsesek: it
[19:54:52] <rsesek> thakis: can you repro http://code.google.com/p/chromium/issues/detail?id=49357?
[19:55:01] <rsesek> (you're the only 10.5-er I know :p)
[19:55:48] <phajdan-jr> pinkerton: lemme look, do you have the logs?
[19:55:56] *** maikmerten_ has joined #chromium
[19:56:04] *** loislo has quit IRC
[19:56:19] <pinkerton> phajdan-jr: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(1)/builds/25827/steps/sync_unit_tests/logs/stdio
[19:56:31] <pinkerton> that's the first one, the other appears to fail in a similar way but i didn't look too deeply
[19:56:58] <pinkerton> phajdan-jr: and it just went back to green
[19:57:00] <phajdan-jr> pinkerton: doesn't look like me, it might be a bot wanting to be kicked
[19:57:04] <pinkerton> sigh
[19:57:16] <phajdan-jr> pinkerton: but it also might be a broken test that is hanging
[19:57:19] <thakis> rsesek: can't repro with the build he linked to. did you try running chrome under valgrind and following the repro steps?
[19:57:34] <rsesek> thakis: those tests are good under valgrind
[19:57:39] <rsesek> thakis: nothing's changed in months
[19:57:40] * thakis found http://sites.google.com/a/chromium.org/dev/developers/how-tos/using-valgrind yesterday and now wants to tell everyone about it :-P
[19:57:42] <phajdan-jr> pinkerton: hey, how about disabling SyncerThreadWithSyncerTest.FLAKY_PauseWhenNotConnected? I bet it is hanging, just see the log.
[19:57:51] <thakis> rsesek: i mean chrome itself, not the tests
[19:58:09] <rsesek> thakis: no. I haz no valgrindable machine. but that use case is covered by tests
[19:58:24] <thakis> every machien is valgrindable; there are binaries checked in
[19:58:29] <thakis> you just need a .gclient tweak
[19:58:30] <rsesek> thakis: do not work on 10.6
[19:58:32] <thakis> (see page above)
[19:58:46] <pinkerton> phajdan-jr: ok want me to do that?
[19:58:47] <thakis> ls third_party/valgrind/
[19:58:48] <thakis> linux_x64	linux_x86	mac		mac_10.6
[19:58:52] <rsesek> thakis: doesn't work
[19:58:59] *** maikmerten has quit IRC
[19:59:03] *** fta has quit IRC
[19:59:06] <rsesek> thakis: crbug.com/46947
[19:59:21] <phajdan-jr> pinkerton: yes, please
[19:59:34] <pinkerton> phajdan-jr: ok will send you a review momentarily
[19:59:59] <thakis> rsesek: ooh, nice
[20:00:06] *** fta has joined #chromium
[20:00:18] <thakis> let me run the repro under valgrind then
[20:01:20] *** eroman has quit IRC
[20:01:23] <thakis> ?once my current valgrind run on unit_tests is done (at 72%, has been running for 2h or so)
[20:01:38] <rsesek> thakis: no ?gtest_filter?
[20:02:02] <atwilson> windows (cygwin) git question: I'm trying to do a "git cl dcommit", and it gave me some kind of message about "migrating from a git-svn v1 layout", said it was done, and now it just sits there. I've killed it and re-ran git cl dcommit, and it sits there after the "hit enter to confirm" prompt.
[20:02:03] <thakis> rsesek: i have a leak that i don't know where it's coming from, so i'm doing this sharding trick
[20:02:15] <atwilson> Is it expected that "git cl dcommit" can take 1hr+ to run?
[20:02:17] <rsesek> ah
[20:02:24] <thakis> (i already have the right shard, but i figured since i'm at 72% and doing something else, i might as well let the run complete)
[20:02:29] <thakis> atwilson: no
[20:02:39] <sky_> atwilson: it's slow, but I've never seen it that slow.
[20:02:44] <pinkerton> phajdan-jr: http://code.google.com/p/chromium/issues/detail?id=39070
[20:02:58] <atwilson> OK, I guess I can land my patch from my mac instead...
[20:02:58] <pinkerton> it's already been disabled and re-enabled
[20:02:59] <sky_> atwilson: I've only seen it slow if I haven't pull'd recently.
[20:03:01] *** aroben|afk is now known as aroben|meeting
[20:03:15] <atwilson> sky: Yeah, and I did a "git pull".
[20:03:58] <atwilson> This may be my first dcommit from this git repo, so maybe I did the setup incorrectly. I'll go re-review the docs.
[20:04:29] <sky_> did you forget the git svn init ?
[20:04:38] <phajdan-jr> pinkerton: I think we should disable it again. Better green than sorry.
[20:04:43] <pinkerton> i am
[20:06:30] <pinkerton> phajdan-jr: http://codereview.chromium.org/2819058/show for your lgtm
[20:07:00] <jochen__> can i land a grd-only change?
[20:07:20] <phajdan-jr> pinkerton: LGTM with a comment
[20:07:50] <pinkerton> oops heh
[20:12:05] <jochen__> pinkerton: can i land a grd-only change?
[20:12:14] <pinkerton> jochen__: sure. will it bust-up windows?
[20:13:14] *** ctruta has quit IRC
[20:13:21] *** ROBOd has quit IRC
[20:13:30] <jochen__> as always
[20:13:44] <pinkerton> heh ok then. enjoy.
[20:13:44] <jochen__> but it doesn't include code
[20:13:47] *** ROBOd has joined #chromium
[20:14:10] <phajdan-jr> sheriffing would be boring without some redness ;-)
[20:14:19] <phajdan-jr> and now a webkit roll too
[20:14:34] <pinkerton> heh
[20:14:36] *** rohitrao has joined #chromium
[20:14:36] *** ChanServ sets mode: +v rohitrao
[20:14:39] <pinkerton> should we close the tree for both?
[20:14:55] <pinkerton> rohitrao: jrg was looking for you
[20:15:13] <rohitrao> yeah, just noticed that :)
[20:15:45] <rohitrao> jrg: done traveling for today, cl looks good
[20:17:27] *** aroben|meeting is now known as aroben
[20:21:06] <pinkerton> jochen__: shouldn't you close the tree?
[20:23:02] *** scarybeasts is now known as scarybeasts_lunc
[20:23:18] *** evmar_afk is now known as evmar
[20:23:18] <evmar> does anyone use msysgit?
[20:23:31] *** scarybeasts_lunc is now known as scarybeasts_afk
[20:23:31] <tony^work> try bots are so much better today.  thanks sky_!
[20:23:31] <evmar> i just installed it and it takes ~3 seconds for "git" (with no args) to run
[20:24:10] <jochen__> pinkerton: i clobbered the builders. with a bit of luck, nothing happens
[20:24:18] <pinkerton> ok
[20:25:19] * phajdan-jr suggests being more verbose in the status, just in case
[20:26:55] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac Builder (dbg)" from 53068: pinkerton at chromium dot org, senorblanco at google dot com, suzhe at chromium dot org)
[20:27:14] <tony^work> uh oh
[20:27:20] <tony^work> please don't let that be a linker OOM
[20:27:54] <rsesek> nope. suzhe
[20:28:02] <tony^work> whew
[20:28:21] <jochen__> phajdan-jr: verbose enough? :)
[20:28:29] <rsesek> view_id_util_browsertest.mm:62: error: 'VIEW_ID_PAGE_MENU' was not declared in this scope
[20:28:48] <tony^work> suzhe: ping
[20:28:54] *** tonyg-cr has quit IRC
[20:28:59] <suzhe> I'm looking
[20:30:42] <senorblanco> ChromeOS blew up too
[20:30:44] <pinkerton> suzhe: looks like you forgot an include
[20:30:55] <suzhe> no
[20:31:03] <suzhe> somebody removed VIEW_ID_PAGE_MENU from view_ids.h
[20:31:24] <pinkerton> ah, well, there is no longer a page menu
[20:31:25] <thakis> makes sense, as it doesn't exist any more
[20:31:39] <thakis> i think i saw a cl go by by pkasting to remove it last night
[20:31:44] <pinkerton> d'oh
[20:32:09] <pkasting> Indeed, page menu is gone
[20:32:18] <pkasting> Thou Shalt Not Use VIEW_ID_PAGE_MENU
[20:32:19] <tony^work> seems like a bad merge.  can we revert and try to reland once resolved?
[20:32:26] <suzhe> may I just check in the fix?
[20:32:31] <tony^work> sure, if you have it
[20:32:44] <evmar> i like how we went from "to find anything, i have to try both menus" => "to find anything, i have to open the first menu then check the tools menu within it"
[20:32:53] <evmar> also like how a wrench has a separate "tools" section within it
[20:32:59] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (Mac -> suzhe)
[20:33:08] <evmar> and by "like" above, i mean "evan is being negative again and will now stop himself"
[20:33:28] * pinkerton hugs evmar
[20:33:48] <phajdan-jr> it'd be interesting to get some stats how often these things are used
[20:33:52] <phajdan-jr> and what are the patterns
[20:34:13] <jochen__> who blew up chromium os builder?
[20:34:26] <thakis> evmar: it's strictly better because the first click is always right
[20:34:37] <thakis> HAH!
[20:35:02] <jochen__> i'd say it's sky_
[20:35:03] <pinkerton> jochen__: maybe the webkit roll? wasn't there one?
[20:35:07] <jochen__> no
[20:35:09] <jochen__> sky
[20:35:24] * pinkerton is swapping too much
[20:35:32] <jochen__> in 53062
[20:35:37] <suzhe> pinkerton: fix committed. TBR set to you.
[20:35:53] <thakis> dhollowa: BookmarkBarControllerTest.DeleteFromOffTheSideWhileItIsOpen  is the offending test (just fyi)
[20:36:59] *** phajdan-jr is now known as phajdan-jr|afk
[20:38:47] <pinkerton> did anyone get in touche with sky?
[20:39:33] <jochen__> not me
[20:40:37] *** wyfrn has joined #chromium
[20:42:19] *** fta_ has joined #chromium
[20:42:30] <pinkerton> sky_: ping?
[20:43:04] *** fta has quit IRC
[20:43:11] *** fta_ is now known as fta
[20:45:03] *** mu has joined #chromium
[20:46:17] <thakis> dhollowa: lg on your suppression cl from this morning; i added some notes to the bug
[20:47:18] *** hebz0rl has quit IRC
[20:47:18] *** Emperorlou_ has joined #chromium
[20:47:18] *** Emperorlou has quit IRC
[20:47:18] *** ctruta has joined #chromium
[20:47:27] *** ilya has joined #chromium
[20:47:27] *** ChanServ sets mode: +v ilya
[20:48:04] <nirnimesh> who can I talk to about the password store/manager?
[20:48:48] <thakis> nirnimesh: jcivelli, dhollowa, maybe me, jhawkins
[20:49:03] <mu> Upgraded to chromium-dev 6.0.466.0 this morning and now every download seems to end when the file is 40mb--files larger abruptly stop in the middle. Can download normally through wget. Any suggestions?
[20:49:33] *** Emperorlou_ has quit IRC
[20:49:47] <thakis> mu: known bug, will be fixed in the next dev channel release
[20:50:03] <mu> I see. Okay, thank you. fwiw, couldn't find it on the bug tracker
[20:50:15] *** ilya has quit IRC
[20:50:19] * rohitrao thinks we should make the default search be over "all issues"
[20:50:51] *** victorw has left #chromium
[20:51:13] *** Emperorlou has joined #chromium
[20:51:27] <mu> Right, sorry. Thanks for the time.
[20:51:54] *** mu has left #chromium
[20:52:25] <evmar> rohitrao: or we could make the default search be "open issues + issues that were closed within the last week"
[20:52:36] <pinkerton> sorry, was in a meeting,
[20:52:39] <pinkerton> are we backing sky out?
[20:53:47] <rohitrao> yeah, open+last week would work too
[20:54:04] <jochen__> you're the sheriff
[20:54:09] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (chromeos -> sky?)
[20:54:22] <pinkerton> well i'm not in mtn view with a clear view of his desk, or knowledge that he went to lunch :)
[20:54:38] <pinkerton> i'll back him out
[20:54:55] <tony^work> seems isolated enough that we can open the tree while we backout
[20:55:32] <pinkerton> doesn't seem that isolated at all
[20:55:38] <pinkerton> it touches a huge chunk of the ui
[20:55:44] <tony^work> *shrug* ok
[20:56:19] <evmar> PINK RULES WITH AN IRON FIST
[20:56:26] <evmar> (in a good way, though)
[20:57:02] * pinkerton watches drover spew huge amounts of stuff
[20:57:07] <pinkerton> this cl worries me :)
[20:57:28] <pinkerton> dne
[20:57:29] <pinkerton> done
[20:58:11] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (chromeos backout, waiting on green)
[21:00:27] *** loislo has joined #chromium
[21:04:31] <Emperorlou> Chrome is experiencing data loss when streaming packets using a Comet technique. I have 1 XHR setup as the "download" stream and another XHR that I use as the "upload" stream. It seems that if Chrome is not "sending" anything, any received data is delivered perfectly. However if I were to send data, data received directly after is sometimes lost (about 80% success rate on a LAN, about 40% over the internet). Any ideas why this mi
[21:05:23] <Emperorlou> Also note that firefox doesn't experience this issue at all
[21:06:02] <jochen__> please send a mail to chromium-extensions@
[21:06:02] <jochen__> that's off-topic here
[21:07:13] <Emperorlou> ohrly?
[21:08:01] <Emperorlou> whats the topic here?
[21:08:01] <jochen__> developing the browser
[21:08:01] *** fta has quit IRC
[21:08:01] <jochen__> not stuff with or for the browser
[21:08:01] <Emperorlou> seems on topic to me then
[21:08:01] *** jparent_ has quit IRC
[21:08:01] <Emperorlou> appears to be a browser issue
[21:08:21] *** fta has joined #chromium
[21:08:36] *** skerner has quit IRC
[21:09:36] *** wyfrn has quit IRC
[21:09:36] *** rohitrao_ has joined #chromium
[21:09:36] *** ChanServ sets mode: +v rohitrao_
[21:10:32] <Emperorlou> I have the site that demonstrates the issue here: http://nik.redirectme.net:8081/RPGGameDemo/
[21:10:49] <Emperorlou> If you were to log-in with firefox, all communication with the server is passed back to the client successfully
[21:10:59] *** rohitrao has quit IRC
[21:10:59] *** rohitrao_ is now known as rohitrao
[21:11:24] <evmar> Emperorlou: i disagree with jochen__, and think your bug reports are on-topic, but i also suspect your problem is complicated enough that it probably belongs in a bug report.  :)
[21:12:08] <evmar> Emperorlou: interesting idea!  i miss the king's quest era of rpgs
[21:12:25] <Emperorlou> hehe yeah its just a demo, I have something much greater planned :D
[21:12:25] <pinkerton> 'akes no sense to me
[21:13:32] *** aroben is now known as aroben|away
[21:13:48] <Emperorlou> Its especially to see the effects of the packet loss when chatting since your chats get lost often enough
[21:14:47] *** isherman has joined #chromium
[21:14:47] *** ChanServ sets mode: +v isherman
[21:14:48] <tony^work> pinkerton: chromiumos looks green.  are we waiting for all the tests to run too?
[21:15:14] <Emperorlou> but doesn't happen in firefox. and it also doesn't happen unless you're doing some chatting or moving around. Otherwise, you receive everyone else's chat no problem. very strange....
[21:15:20] <pinkerton> tony^work: nope, i'll reopen
[21:15:45] <tony^work> thanks!
[21:15:51] * tony^work will wait until after lunch to land
[21:16:23] <trungl-bot> Tree opened by pinkerton at chromium dot org: Tree is open
[21:18:31] <pinkerton> suzhe: chromium builder?
[21:19:48] <jochen__> pinkerton: pdb flakiness
[21:19:54] <pinkerton> k
[21:22:45] *** isherman has quit IRC
[21:23:27] *** dD0T has joined #chromium
[21:25:43] <suzhe> pinkerton: Just back to seat. What's up?
[21:26:22] <pinkerton> nothing i guess. pdb flake
[21:26:30] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 53077: albertb at chromium dot org, apatrick at chromium dot org, rvargas at google dot com)
[21:26:52] <pinkerton> who broke mah tree!?
[21:27:18] <pinkerton> apatrick_: !
[21:27:34] *** tonyg-cr has joined #chromium
[21:27:34] *** ChanServ sets mode: +v tonyg-cr
[21:27:53] *** [Nef] has joined #chromium
[21:28:32] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (linux -> apatrick)
[21:29:46] <pinkerton> anyone have a line to apatrick_ before i back him out?
[21:31:22] <jamesr> don't see him at his desk
[21:31:34] <pinkerton> ok, out he goes.
[21:32:26] <pinkerton> done
[21:35:36] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (linux backout, cycling green)
[21:36:08] *** phajdan-jr|afk is now known as phajdan-jr
[21:36:45] <akalin> greetings chromiumites
[21:36:47] *** agayev has joined #chromium
[21:37:06] <akalin> it's a fine day in M7
[21:37:51] <pinkerton> m7 doesn't start until august, we're still fixing M6 non-feature bugs until then
[21:38:30] <pinkerton> go forth and make it suck less! :D
[21:39:03] <akalin> oh :(
[21:39:44] <pinkerton> it's not that bad :)
[21:40:49] <akalin> M6 will never end
[21:41:36] <pinkerton> ha
[21:41:38] *** peterdn has joined #chromium
[21:42:39] <trungl-bot> Tree opened by pinkerton at chromium dot org: Tree is open
[21:43:03] <jamesr> chrome 6, chrome 6.2, chrome 6.2.8, chrome 6.2.8.3, chrome 6.2.3.8.1
[21:43:46] *** maikmerten_ has quit IRC
[21:44:16] <sky_> pinkerton: sorry for not seeing the breakage.
[21:44:32] <pinkerton> np
[21:47:48] <akalin> Chrome 666
[21:51:46] *** isherman has joined #chromium
[21:51:46] *** ChanServ sets mode: +v isherman
[21:52:05] *** coyo has quit IRC
[21:54:30] *** Adys has joined #chromium
[21:54:34] *** shess has quit IRC
[21:55:55] *** Adys has quit IRC
[21:55:56] *** mihaip has joined #chromium
[21:55:56] *** ChanServ sets mode: +v mihaip
[21:57:04] *** Adys has joined #chromium
[21:57:05] *** isherman has quit IRC
[21:58:11] *** ebraminio has quit IRC
[21:58:28] *** andrix has quit IRC
[21:58:43] *** johnny_g_ has joined #chromium
[21:58:45] *** johnny_g has quit IRC
[21:58:45] *** johnny_g_ is now known as johnny_g
[21:58:53] *** cbentzel has quit IRC
[21:59:24] *** isherman has joined #chromium
[21:59:24] *** ChanServ sets mode: +v isherman
[22:01:44] *** shess has joined #chromium
[22:01:44] *** ChanServ sets mode: +v shess
[22:04:26] *** isherman has quit IRC
[22:07:10] *** abarth has joined #chromium
[22:07:10] *** ChanServ sets mode: +v abarth
[22:07:28] *** gavinp` has quit IRC
[22:10:02] <fishd> is anyone working on fixing the webkit (chromium) tip-of-tree bustage?
[22:10:16] *** fta_ has joined #chromium
[22:10:22] *** ebraminio has joined #chromium
[22:11:41] *** fta has quit IRC
[22:11:55] *** fta_ is now known as fta
[22:14:41] <tony^work> fishd: I'll look at it now
[22:17:00] *** mabbo has quit IRC
[22:17:19] *** Adys has quit IRC
[22:18:57] <fishd> tony^work: actually, i have a fix... see discussion in #webkit if you are interested
[22:19:43] <tony^work> yes, I see it now
[22:20:50] *** agayev has quit IRC
[22:21:42] <fishd> tony^work: http://trac.webkit.org/changeset/63770
[22:23:06] *** Nola has joined #chromium
[22:23:10] *** mabbo has joined #chromium
[22:23:21] *** shreyas_ has quit IRC
[22:24:19] *** victorw has joined #chromium
[22:24:19] *** ChanServ sets mode: +v victorw
[22:25:58] *** |fbt| has joined #chromium
[22:26:18] * shess just spent an hour debugging networking issue.  Did you know you could enter newlines into the proxy.pac field in OSX network preferences?
[22:27:21] *** finnur has quit IRC
[22:28:21] *** ecolell has joined #chromium
[22:28:27] *** shreyas_ has joined #chromium
[22:29:39] *** mirandac_afk is now known as mirandac
[22:32:00] *** [Nef] has quit IRC
[22:32:56] <Nola> its really weird that you cant set what page new tabs use??
[22:34:11] <pinkerton> yup
[22:34:45] <Nola> is that a known issue?
[22:34:56] <Nola> or a actual design decision for some reason
[22:35:13] <pinkerton> it is by design
[22:35:16] <Nola> why
[22:35:22] <pinkerton> it's a very very long story
[22:35:48] <Nola> in my office, everyone has a different extension to fix that
[22:35:54] <Nola> its jumbled up
[22:36:00] <Nola> people seem universally annoyed
[22:36:01] <pinkerton> and that's the recommended fix for those who want that behavior
[22:36:31] <pinkerton> i disagree with your assessment of universal annoyance.
[22:36:47] <Nola> so basically, google wants to force the "New Tab Page" on people by disallowing setting a page?
[22:36:56] *** isherman has joined #chromium
[22:36:56] *** ChanServ sets mode: +v isherman
[22:37:16] <pinkerton> like i said, this is a much longer discussion, and this is not the right forum for such design decisions.
[22:37:41] <evmar> google also wants to force people to go back and forward by not allowing you to remove the back/forward buttons from the toolbar!
[22:37:43] <dcheng> I heard Chrome is trying to force people to use tabs too. Bad Chrome!
[22:37:51] <evmar> dcheng: joke jinx!
[22:38:08] <Nola> hell, I just want my tabs to open up on www.google.com
[22:38:16] <Nola> the "new tab page" has no use
[22:38:17] <dcheng> Does that mean I can't make any jokes unless someone says my nick 5 times?
[22:38:27] <Nola> its not like i would ever use that in a million years
[22:38:31] <Nola> i want to search when i open a new tab
[22:38:35] *** apatrick_ has left #chromium
[22:38:41] <stuartmorgan> Nola: This is a development channel; please use the forums for this
[22:39:46] <pinkerton> i loves me some green trees!
[22:40:05] <evmar> pinkerton: this is a development channel, please talk to greenpeace about your tree-hugging
[22:40:11] <pinkerton> lol
[22:40:12] * evmar stops with the bad jokes
[22:40:21] <pinkerton> don't make me back you out
[22:40:24] <evmar> wow, that is a nice looking tree
[22:40:39] <Nola> why cant you discuss "pre-development" issues here?
[22:41:06] <Nola> the ideas have to be formulated before the code is written ...
[22:41:41] <evmar> we do design by auteur, not design by committee.  even the devs don't get to make input on the design
[22:41:44] <stuartmorgan> Nola: the ideas have been formulated, and discussed, and decided on
[22:42:23] <Nola> so you're saying nobody who could make a difference is here to listen to me even if I made a good point
[22:42:35] <stuartmorgan> Nola: I'm saying your viewpoint has already been expressed
[22:42:41] *** finnur has joined #chromium
[22:42:41] *** ChanServ sets mode: +v finnur
[22:42:41] <evmar> Nola: that is correct, that is why we keep trying to direct you to the forum
[22:42:48] <evmar> Nola: this is a channel for development
[22:43:13] <Nola> that's confusing evmar -- on my development team this is what we do 50% of the time
[22:43:28] <Nola> these kinds of thoughts are the core of development
[22:43:30] <pinkerton> if you wanted to talk about developing an extension to solve this problem, we would entertain that, i believe
[22:43:36] *** shreyas_ has quit IRC
[22:44:15] <pinkerton> Nola: yes, but you can't just show up 3 years into a project and ask someone to re-visit a design decision that's been upheld countless numbers of times over the years
[22:44:36] *** |fbt| has quit IRC
[22:45:12] <Nola> what about the old idea of  "Give Em' What They Want"     If it even was issue enough to _have_ to be upheld, then obviously people wanted another option
[22:45:39] *** ctruta has quit IRC
[22:45:40] <stuartmorgan> Nola: the forums are monitored for major trends in feedback
[22:45:50] <stuartmorgan> If you want to add your vote, posting in the forum is the way to do that
[22:45:56] <Nola> ok
[22:45:59] <Nola> I will
[22:46:37] <Nola> the main thing is i dont want to have to install a bunch of extensions and keep up with them over the years and download new versions as the author disappears
[22:46:48] <Nola> its a horrible hassle for such a simple thing as setting a tab page
[22:47:11] <stuartmorgan> Nola: That would be great feedback to put in your forum post. This isn't the right place for it
[22:47:19] * pinkerton agrees with stuartmorgan
[22:47:51] <evmar> Nola: btw, if you hit alt-enter in the url bar it opens what you've typed in a new tab.  that helps the use case of "search for something in a new tab" -- you hit ctl-L, type what you want, alt-enter, and you now have that search in a new tab
[22:48:00] <evmar> Nola: every time you have to visit google.com to do a search we've kinda failed
[22:48:16] <evmar> Nola: which i think is why your request is an uncommon one
[22:48:24] *** johnny_g_ has joined #chromium
[22:48:24] *** ChanServ sets mode: +v johnny_g_
[22:48:24] *** johnny_g_ has quit IRC
[22:48:30] *** johnny_g_ has joined #chromium
[22:48:30] *** ChanServ sets mode: +v johnny_g_
[22:48:33] *** |fbt| has joined #chromium
[22:48:38] *** johnny_g has quit IRC
[22:48:39] *** johnny_g_ is now known as johnny_g
[22:49:11] *** tonikitoo has quit IRC
[22:49:47] *** tonikitoo has joined #chromium
[22:50:39] *** eroman has joined #chromium
[22:50:39] *** ChanServ sets mode: +v eroman
[22:50:50] *** finnur has quit IRC
[22:52:07] *** Adys has joined #chromium
[22:53:06] <nirnimesh> are cookies guaranteed to be set by the time navigation completes?
[22:53:39] *** abarth has quit IRC
[22:54:19] *** abarth has joined #chromium
[22:54:19] *** ChanServ sets mode: +v abarth
[22:54:36] *** loislo has quit IRC
[22:54:52] *** tonikitoo has quit IRC
[22:56:02] <eroman> nirnimesh: what do you mean by navigation completes? cookies set from an HTTP response or cookies set by javascript? reading/writing cookies is racy, can't tell what order it will happen
[22:56:11] <mmoss> cevans, hbono, pinkerton: I made a change to the way Linux bots archive/extract builds. If that breaks, ping me.
[22:56:24] <pinkerton> k
[22:56:36] <pinkerton> scarybeasts_afk: ^^
[22:57:05] *** fta has quit IRC
[22:57:09] <phajdan-jr> nirnimesh: I suggest to ask fishd
[22:57:28] <phajdan-jr> nirnimesh: and if the answer is surprising, I'd be interested to know
[22:57:35] *** fta has joined #chromium
[22:57:44] *** Viclame has left #chromium
[22:57:48] *** aroben|away is now known as aroben
[22:59:45] <nirnimesh> eroman: I mean when page load completes (ie OpenURL returns).
[23:00:09] <phajdan-jr> tricky webkit thing, made even more tricky by our multi-process architecture
[23:00:18] <phajdan-jr> one of the main themes of flaky tests
[23:00:52] *** fta_ has joined #chromium
[23:01:19] <eroman> nirnimesh: in that case yes. if the cookie was set via a response header, then it is guaranteed to have been set by the time the request completes. but it is still tricky in that you may have multiple transactions changing the same cookie :)
[23:01:28] *** loislo has joined #chromium
[23:02:20] *** fta has quit IRC
[23:02:24] *** fta_ is now known as fta
[23:04:51] *** bmizerany has joined #chromium
[23:07:05] <Nola> yeah after researching and reading the reasons behind not allowing me to set a web page to open on new tabs ...
[23:07:16] <mmoss> pinkerton, scarybeasts_afk: Builder Webkit Linux (dbg)(3) is me
[23:07:18] <Nola> removed chrome
[23:07:30] <pinkerton> enjoy
[23:07:31] <Nola> back to Firefox for the next couple years
[23:08:06] *** Nola has left #chromium
[23:08:34] <pinkerton> oh noes! we lost a user!
[23:10:38] <evmar> pinkerton: aw, be nice.  i think the right way to say that is "firefox is a good browser too, so enjoy it"
[23:10:44] <fishd> nirnimesh: cookies delivered in HTTP response headers for a document, are set before we start streaming the response body to webkit.
[23:11:28] <pinkerton> evmar: i did tell him to enjoy it :)
[23:11:47] <thakis> <cmd-q-rant />
[23:12:19] <pinkerton> thakis: please discuss on the forums.....
[23:12:22] * pinkerton hides
[23:13:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Mac10.5 Tests" from 53092: atwilson at chromium dot org, dhollowa at chromium dot org, estade at chromium dot org, hclam at chromium dot org, jrg at chromium dot org, michaeln at chromium dot org)
[23:13:23] <pinkerton> crudz
[23:13:34] *** froek has quit IRC
[23:13:36] <jrg> pinkerton: I'm checking to see if it's mine
[23:14:17] <pinkerton> TopSitesTest.DeleteNotifications
[23:14:22] *** satish_ has left #chromium
[23:14:32] <jrg> pinkerton: I don't see a red boton the 'mac' columns?
[23:14:48] <pinkerton> the test has gone red, but the entire builder hasn't updated the column color
[23:14:57] <pinkerton> if you click it, you'll see the ui tests are red
[23:15:05] *** froek_ has joined #chromium
[23:15:17] *** hrna has quit IRC
[23:15:27] <pinkerton> jrg: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/17201/steps/unit_tests/logs/stdio
[23:15:35] *** fsamuel has quit IRC
[23:15:38] <jrg> right... got it.  Probably not I.
[23:16:41] <pinkerton> hrm, no idea looking at the list of culprits
[23:16:56] <dhollowa> pinkerton: not ringing a bell here.
[23:17:55] <atwilson> sad that there's no actual stack trace for 10.5
[23:19:33] <mmoss> Chromium Linux Builder (dbg) had a bad bot script merge, I'm fixing
[23:20:37] <rsesek> dmaclach: ping
[23:20:47] *** Venom_X_ has joined #chromium
[23:20:57] *** Venom_X has quit IRC
[23:20:57] *** Venom_X_ is now known as Venom_X
[23:21:25] <pinkerton> ok well two machines went red
[23:21:29] <pinkerton> so it's something legit
[23:21:38] <pinkerton> both 10.5 and 10.6 tests are red
[23:21:42] *** froek_ has quit IRC
[23:22:05] <pinkerton> god the waterfall is so slow
[23:22:09] <pinkerton> i can't get it to tell me anything
[23:22:32] *** agayev has joined #chromium
[23:22:56] *** loislo has quit IRC
[23:23:03] <pinkerton> hrm 10.6 bot faild checkdeps
[23:23:09] <pinkerton> that seems bad as well
[23:23:50] <atwilson> pinkerton: Looking for the 10.6 test redness. link?
[23:23:54] <pinkerton> hclam is the reason for the 10.6 redness
[23:23:54] <rsesek> pinkerton: chec_deps is hclam
[23:23:59] <atwilson> kk
[23:24:05] <pinkerton> and he's not on irc
[23:24:40] <pinkerton> trying gchat. anyone sit near him?
[23:25:09] *** cuba33ci has quit IRC
[23:25:25] * atwilson wonders why the tree always implodes at the same time he submits a CL.
[23:25:30] <pinkerton> heh
[23:25:49] <pinkerton> i'll give him 3 more minutes to reply then im backing him out
[23:25:49] *** froek_ has joined #chromium
[23:26:12] <phajdan-jr> add some things about trybots catching check_deps problems very easily
[23:26:19] <pinkerton> yeah.
[23:26:40] <pinkerton> according to rietveld, it passed the trybot on mac
[23:27:02] *** cuba33ci has joined #chromium
[23:27:03] <phajdan-jr> and on which platform check_deps failed?
[23:27:07] <pinkerton> mac
[23:27:12] <awong_> I've got hclam
[23:27:12] <phajdan-jr> weird
[23:27:20] *** froek_ is now known as froek
[23:27:26] <pinkerton> awong_: get him on irc
[23:27:31] <awong_> getting him now
[23:27:34] <phajdan-jr> maybe we should log some things to prevent it from happening again? It's surprising that the trybot didn't catch the problem here.
[23:29:27] <erikchen> trying to debug chrome in VS2005. I'm getting "no symbols are loaded for this document". already gone through wiki instructions. any ideas?
[23:30:12] <pinkerton> why is chromium arm purple?
[23:31:19] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (Mac check_deps -> hclam fixing; Mac unit_tests: atwilson at chromium dot org, dhollowa at chromium dot org, estade at chromium dot org, hclam at chromium dot org, jrg at chromium dot org, michaeln at chromium dot org ??
[23:32:02] *** ROBOd has quit IRC
[23:32:32] <pinkerton> svn: Could not open the requested SVN filesystem
[23:32:32] <pinkerton> Error: failed to run command: svn checkout http://google-url.googlecode.com/svn/trunk@139 /b/slave/chromium-rel-arm/build/src/googleurl --revision 139 --force
[23:32:53] <awong_> pinkerton: wow. that looks dead
[23:33:03] <pinkerton> maruel: ?
[23:33:09] *** froek has quit IRC
[23:33:41] <pinkerton> who can fix that bot?
[23:33:42] <awong_> pinkerton: I'm on the bot. going to poke around.
[23:33:45] <pinkerton> ok thanks
[23:34:21] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (ChromiumArm -> awong looking; Mac check_deps -> hclam fixing; Mac unit_tests: atwilson at chromium dot org, dhollowa at chromium dot org, estade at chromium dot org, hclam at chromium dot org, jrg at chromium dot org, michaeln at chromium dot org ??)
[23:34:26] *** hclam has joined #chromium
[23:34:56] <pinkerton> hclam: we were wondering why your cl passed the mac trybots check_deps, but then broke the build. did you make a change after sending it?
[23:34:57] <awong_> pinkerton: seems transient.  Current cycle passed that stage.
[23:35:10] <pinkerton> weird
[23:35:28] <markmentovai> eh?
[23:35:33] <markmentovai> current cycle has a red check_deps
[23:35:48] <awong_> markmentovai: talking about chromium arm bot's gclient failure.
[23:35:52] <markmentovai> ooh
[23:36:34] <mmoss> pinkerton: crap, the bot master is sending hard-coded archive urls to the slaves :(, that didn't come up when I searched sources, now I need to sync my change with a master restart
[23:36:53] <pinkerton> can you back out?
[23:37:00] <mmoss> pinkerton: I guess I'll revert for now, the linux testers should cycle green in bit
[23:37:09] <pinkerton> k
[23:37:54] <pinkerton> scarybeasts_afk: i'm gonna need you to take over soon, it's almost 6 here.
[23:38:53] <pinkerton> markmentovai: why don't the builders run check_deps? Why make the mac tester bots run that?
[23:38:55] <erikchen> can someone kick mac_valgrind please?
[23:38:57] <erikchen> getting ld(13711) malloc: *** mmap(size=16777216) failed (error code=12)
[23:38:57] <erikchen> *** error: can't allocate region
[23:39:10] <erikchen> http://build.chromium.org/buildbot/try-server/builders/mac_valgrind/builds/209/steps/compile/logs/stdio
[23:39:12] <tony^work> erikchen: I think tha means you're out of memory
[23:39:14] <markmentovai> pinkerton: dunno. time, probably. it really only needs to happen once per platform.
[23:39:20] <tony^work> kicking won't solve that
[23:39:31] <pinkerton> markmentovai: yeah, that's why having it run on multiple bots sounded odd
[23:39:34] <erikchen> what would be solution?
[23:39:51] <awong_> that looks like linker is out of vm.
[23:39:52] <stuartmorgan> erikchen: 10.6
[23:40:07] <erikchen> stuartmorgan: sorry, could you explain?
[23:40:11] <markmentovai> pinkerton: the multiples is because the 10.6 configs were just copied from the 10.5 configs
[23:40:17] <pinkerton> :)
[23:40:21] <markmentovai> so 10.6-dbg-1 got the same set of tests that 10.5-dbg-1 had.
[23:40:30] <stuartmorgan> erikchen: There have been threads about this on chromiumd-dev; 10.5 is dying as a build platform
[23:40:46] <awong_> erikchen: the issues is that the linker is exhausting the virtual memory space.
[23:40:48] <stuartmorgan> erikchen: the solution is to switch all our bots to 10.6, which is underway
[23:41:00] <stuartmorgan> At least one Mac valgrind bot has been dead for a while
[23:41:04] <erikchen> I see. thanks guys.
[23:41:25] <pinkerton> awong_: now the chromium arm build is red
[23:41:53] <awong_> pinkerton_: looking...
[23:42:54] <awong_> pinkerton: that looks like a legitimate compile error.  'void BrowserList::AllBrowsersClosed()' member function declared in class 'BrowserList'
[23:43:01] <pinkerton> yay.
[23:43:10] <atwilson> that's me
[23:43:16] <atwilson> looking.
[23:43:26] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (ChromiumArm -> awong looking; Mac check_deps -> hclam fixing; Linux -> mmoss reverting; Mac unit_tests: atwilson at chromium dot org, dhollowa at chromium dot org, estade at chromium dot org, hclam at chromium dot org, jrg at chromium dot org, michaeln at chromium dot org ??)
[23:43:28] *** rdsmith has quit IRC
[23:43:34] *** rdsmith has joined #chromium
[23:43:34] *** ChanServ sets mode: +v rdsmith
[23:44:14] * pinkerton keeps an eye on the mac ui_tests
[23:44:23] <atwilson> awong: link?
[23:44:30] <awong_> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Arm/builds/6124/steps/compile/logs/stdio
[23:44:30] <atwilson> (AllBrowsersClosed())?
[23:44:45] *** awong_ is now known as awong
[23:44:57] <atwilson> nm, see it.
[23:45:11] *** dumi has quit IRC
[23:45:48] <atwilson> I'm fixing the chromium arm compile error - it's a simple fix.
[23:45:53] *** michaeln has joined #chromium
[23:45:53] *** ChanServ sets mode: +v michaeln
[23:47:27] *** Kunalagon has quit IRC
[23:49:14] <atwilson> kk, chromium arm should be fixed now.
[23:50:29] <trungl-bot> Tree closed by atwilson at chromium dot org: Tree is closed (ChromiumArm -> cycling green (atwilson checked in fix); Mac check_deps -> hclam fixing; Linux -> mmoss reverting; Mac unit_tests: atwilson at chromium dot org, dhollowa at chromium dot org, estade at chromium dot org, hclam at chromium dot org, jrg at chromium dot org, michaeln at chromium dot org ??)
[23:53:22] *** Singularity has joined #chromium
[23:56:24] <dhollowa> pinkerton: looks like 10.5 unit_tests passed this round.
[23:56:31] <pinkerton> dhollowa: it was ui_tests
[23:56:35] <pinkerton> it's still going
[23:56:59] <pinkerton> oh
[23:57:02] <pinkerton> it was unit tests
[23:57:03] <pinkerton> wtf.
[23:57:04] <pinkerton> argh.
[23:57:14] <dhollowa> DeleteNotifications
[23:57:18] *** scarybeasts_afk has left #chromium
[23:57:29] <atwilson> it was unit_tests originally. I think it was just flake.
[23:57:34] <dhollowa> yes
[23:58:10] <pinkerton> my bad, sorry. too many things flaming at once
[23:58:40] <trungl-bot> Tree closed by pinkerton at chromium dot org: Tree is closed (ChromiumArm -> cycling green; Mac/Win check_deps -> cycling green; Linux -> mmoss reverting)
[23:59:00] <pinkerton> well, i need to go but the other sheriff just....left the room.
[23:59:27] <awong> pinkerton: go...
[23:59:42] *** rdsmith has quit IRC
[23:59:48] *** agayev has quit IRC
[23:59:50] <awong> I'll watch for the next 30 mins at least.





top