[00:00:25] <ananta> awong: The svn patch is failing probably because the file originally had a missing newline. I will keep a watch for any failures.
[00:00:45] *** sjefen6 has quit IRC
[00:01:06] <markmentovai> shess: mac release compile failure, yours? known?
[00:01:15] <shess> markmentovai: am loooking right now
[00:01:16] *** sjefen6 has joined #chromium
[00:01:17] *** sbyer has joined #chromium
[00:01:17] *** ChanServ sets mode: +v sbyer
[00:01:27] <chronarion> awong: Can I commit http://codereview.chromium.org/2872034/show The two linux try failures are flaky tests.
[00:01:30] <shess> [more correctly, am waiting for the web page...]
[00:01:44] *** smead has left #chromium
[00:02:15] <akalin> mattm_g: i'm not the one doing the logging myself, i'm going to go help someone
[00:02:19] <akalin> just making sure that it should work
[00:02:54] <markmentovai> shess: autocomplete_text_field_cell.mm, line 652 pboard may be used uninit., line 666 image may be used uninit
[00:03:06] *** magn3ts_ has quit IRC
[00:03:14] <shess> yeah.  do not know why that's happening there but not for me ... oooh, probably opt flags?
[00:03:24] *** joshia has joined #chromium
[00:03:24] *** ChanServ sets mode: +v joshia
[00:03:29] <awong> ananta: sucky. so there's no way to get past the patch stage on the try servers?
[00:03:31] <markmentovai> shess: right, gcc can only check for that with -O
[00:03:41] <ananta> awong: looks like it
[00:04:05] *** Adys has joined #chromium
[00:04:09] <jhawkins> awong: another re-enable http://codereview.chromium.org/2950007
[00:04:28] <awong> ananta: okay, let's hang on until the current mac issue is fixed. then commit.
[00:05:15] <awong> chronarion, jhawkins: same with those two patches.
[00:05:26] *** awolfson has quit IRC
[00:05:40] <awong> shess: is there a quick fix? or should we revert?
[00:05:56] <shess> markmentovai: http://codereview.chromium.org/2951012  looks like it gets it?
[00:05:57] <seanparent> Checking on status to see if I can land <http://codereview.chromium.org/2859043/show> before EOBD.
[00:06:19] *** Adys_ has joined #chromium
[00:06:21] <shess> awong: http://codereview.chromium.org/2951012 should get it.
[00:06:32] <markmentovai> shess: lgtm
[00:06:35] <awong> seanparent: can you cooridante with pkasting?
[00:06:41] <ananta> awong: ok
[00:06:46] <awong> shess: go for it.
[00:06:53] <pkasting> I am close to ready to land both my .grd changes
[00:07:07] <markmentovai> shess: concern about whether this does the right thing if *both* icon an decoration are true: recommend structuring the logic with an "else if" on one side to be explicit
[00:07:11] <markmentovai> but that's another change for another time
[00:07:20] <pkasting> Have to get a final signoff on one, and sync my checkouts
[00:08:00] <shess> awong: if that doesn't green it, will revert both.
[00:08:05] <awong> shess: ok
[00:08:27] <seanparent> pkasting: ping me when you're ready. Let me know if you want to commit mine or just commit at "the same time".
[00:08:59] *** Adys has quit IRC
[00:10:00] <shess> markmentovai: is transition code which I hope to have gone in the next day or two.  if the values are inconsistent, that's very bad, but if/else won't make them consistent, unfortunately.
[00:10:14] *** rniwa has joined #chromium
[00:10:14] *** ChanServ sets mode: +v rniwa
[00:10:21] <markmentovai> 'k. i'm only looking at this one function in isolation, i don't have that context. killing it is better. :)
[00:10:27] <estade> seanparent: what does lint say about newlines
[00:10:31] *** alt-dot-net-geek has quit IRC
[00:10:36] <estade> that is making you put two newlines
[00:10:49] <estade> it doesn't complain for me, e.g.: http://codereview.chromium.org/2804039/diff/53001/28011
[00:10:59] <markmentovai> shess: thanks for the quick fix
[00:11:14] <shess> markmentovai: am sad I didn't catch it.
[00:12:36] <seanparent> Says that I'm missing a newline at the end if I don't.
[00:12:44] <markmentovai> shess: the tree in the state it's in, this one break doesn't really account for any lost productivity at all
[00:12:45] <seanparent> Hang on and I'll post an example...
[00:13:02] <shess> markmentovai: aside, how does Xcode figure out when I can do Command-k to compile an individual file?  Used to always work, now I seem to inconsistently be able to do it.
[00:13:04] <awong> purples
[00:13:17] <markmentovai> shess: it depends on target membership
[00:13:44] <markmentovai> and what .xcodeproj is open
[00:13:49] <slightlyoff> is the tree really still closed?
[00:13:50] <shess> markmentovai: I mean like I can do it once, but then when I fix the errors I cannot do it again sometimes.  Have to do a Build, then later I can do it again.
[00:13:58] <markmentovai> if you command-I a file and look in the targets tab, is anything checked?
[00:14:11] <markmentovai> oh, that's weird. i'm always able to compile it, but sometimes it doesn't clean up the errors/warnings until a full Build.
[00:14:18] <markmentovai> gotta watch the build results window to be sure.
[00:14:35] <awong> slightlyoff: we still haven't managed to cycle green.
[00:14:55] <shess> nope, nothing checked.  it's definitely a file that's part of the build.
[00:14:55] *** stoyan has joined #chromium
[00:14:56] *** ChanServ sets mode: +v stoyan
[00:15:05] *** Adys_ is now known as Adys
[00:15:16] <shess> [err, part of browser lib.  so part of many builds.]
[00:15:18] <sbyer> estade: if you're using git and add a file, you get the missing-newline lint complaint.  Git likes to strip out that last newline in the patch.
[00:15:19] <seanparent> http://codereview.chromium.org/lint_patch/issue2859043_67001_30014
[00:15:35] <estade> sbyer: actually I don't
[00:15:46] <estade> could depend on the git version
[00:16:05] <estade> git-svn version 1.7.0.1 (svn 1.4.6)
[00:16:40] <awong> ananta, chronarion, jhawkins: clear on mac side. go ahead and commit
[00:16:42] *** mirandac has quit IRC
[00:16:47] <jhawkins> thanks
[00:17:29] <markmentovai> awong: thanks for sheriffing today, despite apparently signed up to be the gardener and not the sheriff
[00:18:03] <shess> +1
[00:18:19] <awong> markmentovai: :P thanks for helping out with all the failures.
[00:18:30] *** aroben has quit IRC
[00:18:34] <pkasting> awong, seanparent: At this point I'm ready to land except for needing to sync my checkouts first.  Do we want to hold off on further commits to wait for the builders to catch up, or is the tree not ready for .grd changes?
[00:18:46] <ananta> awong: thanks
[00:18:50] <estade> sbyer, seanparent: are your svn properties correct? http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/slave/config
[00:19:12] *** mirandac has joined #chromium
[00:19:12] *** ChanServ sets mode: +v mirandac
[00:19:22] *** Erkan_Yilmaz_ has joined #chromium
[00:19:34] <estade> see also http://dev.chromium.org/developers/coding-style#TOC-Subversion-properties
[00:20:19] <awong> pkasting: you've got way more experience with grd changes than I do.  We still haven't cycled green from tony's grit change.
[00:20:22] <sbyer> estade: I haven't added a file since I last double-checked the config, so unsure if that fixes it.  I'll try and remember the next time I do add one.
[00:20:38] <awong> pkasting: but I don't have any expectation that they won't go green.
[00:20:59] <pkasting> Let's hold the tree closed to changes for a bit to let the bots catch up some, then.
[00:21:09] <awong> okay
[00:21:10] <markmentovai> heh. that's new. :)
[00:21:28] <awong> hah. throttle -> 0.
[00:21:30] *** stevenjb has quit IRC
[00:21:31] *** estes has joined #chromium
[00:21:38] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (prepping for grd change.)
[00:22:16] <seanparent> My config looks correct (i.e. *.cc = svn::eol-style=LF etc.) Looking at other link.
[00:22:23] *** Erkan_Yilmaz__ has joined #chromium
[00:22:34] *** Erkan_Yilmaz has quit IRC
[00:25:01] <markmentovai> allays tree been closed.
[00:25:01] <awong> pkasting: can I pass off control of the tree to you for the grd change?
[00:25:11] <pkasting> OK
[00:25:18] <awong> thanks
[00:25:22] <seanparent> estade: config file looks correct, git-svn --version reports "git-svn version 1.7.1 (svn 1.5.1)"
[00:25:38] *** Erkan_Yilmaz_ has quit IRC
[00:25:43] <estade> seanparent: does py depot_tools/cpplint.py <filename> report errors?
[00:25:44] <rsesek> markmentovai: another phrase is more apt here
[00:26:54] *** MikeSmithW3C^ has joined #chromium
[00:27:16] <pkasting> seanparent: Is your .grd change to generated_resources.grd?
[00:27:50] <awong> chrome frame test bots have gone purple twice.
[00:27:54] *** Erkan_Yilmaz_ has joined #chromium
[00:27:56] *** loislo has quit IRC
[00:28:07] <awong> ananta: would you happen to have any ideas about the purple on the CF bots?
[00:28:51] <ananta> awong: It appears that net tests have been hanging for a while on the IE6 and IE7 builders.
[00:28:55] <seanparent> pkasting: Yes and theme_resources.grd
[00:29:26] <pkasting> Oh, theme_resources?  :(  Can you link me to your review so I can look?  That's what I'll be changing
[00:29:41] <thakis> markmentovai: do you know why interactive_ui_tests aren't running yet for mac?
[00:29:46] <markmentovai> i do not
[00:29:57] <thakis> markmentovai: do you know who might know?
[00:30:01] <seanparent> estade: No. Local cpplint.py does not report an error without the extra nl.
[00:30:17] <markmentovai> i might, it just so happens that i do not.
[00:30:19] *** MikeSmithW3C has quit IRC
[00:30:26] <seanparent> http://codereview.chromium.org/2859043/show
[00:30:32] <markmentovai> as i recall, they do function on the mac
[00:30:40] <markmentovai> try nsylvain?
[00:31:10] <nsylvain> looking
[00:31:11] <ananta> awong: they work fine on IE8. Not sure what the issue is. They started occurring from revision 52211
[00:31:22] *** tonikitoo is now known as tonikitoo{away}
[00:31:23] *** Erkan_Yilmaz__ has quit IRC
[00:31:24] <ananta> awong: which changed grd files.
[00:31:26] <thakis> nsylvain: i was wondering why itneractive_ui_tests aren't running for os x
[00:31:34] <thakis> nsylvain: seems like they mostly work locally
[00:31:38] <nsylvain> ah
[00:31:40] <thakis> (they need to run with an unlocked screen tho)
[00:31:42] <nsylvain> i dont know about this
[00:31:47] <pkasting> seanparent: That looks sane enough, though you have an extraneous newline that crept in towards the end of the file you should remove
[00:32:06] *** Erkan_Yilmaz has joined #chromium
[00:32:35] <seanparent> pkasting: Yikes - thanks for catching that nl. must have happened in a merge. removing it now.
[00:33:19] <pkasting> seanparent: I'll have you land first and then I'll sync to your changes to land mine, but at the moment I can barely get anything from poor buildbot
[00:33:52] <awong> ananta: the net tests shoudldn't have an GRD dependencies should they?
[00:34:37] *** mirandac has quit IRC
[00:34:50] *** Erkan_Yilmaz_ has quit IRC
[00:35:35] *** eseidel has joined #chromium
[00:35:41] <seanparent> pkasting: Ready to commit - am I cleared?
[00:35:45] <tony^work> awong: there is a single grd file
[00:35:48] <tony^work> err, for net
[00:36:01] *** Erkan_Yilmaz_ has joined #chromium
[00:36:02] <awong> seanparent: hang one sec...
[00:36:05] <tony^work> it might have broken a net unittest
[00:36:26] <seanparent> awong: hanging...
[00:36:34] <estade> seanparent: meh, I'm stumped.
[00:36:35] <pkasting> No, sorry -- I'm trying to get buildbot to tell me what's up
[00:36:45] <pkasting> But every request is taking like 45 seconds
[00:37:28] *** jeremyselier has quit IRC
[00:37:43] <awong> tony^work: okay. so how do we fix this?
[00:38:09] <tony^work> awong: I can't see the buildbot, but I think grd related failures are starting to clear up
[00:38:22] <tony^work> do you have a link to the bot that failed?
[00:38:45] <kinuko> trungl-bot: lkgr
[00:38:46] <trungl-bot> kinuko: 52179
[00:38:48] <awong> tony^work: http://build.chromium.org/buildbot/waterfall/builders/Chrome%20Frame%20Tests%20(ie6)
[00:38:59] <awong> codf171.jail
[00:39:03] *** Erkan_Yilmaz has quit IRC
[00:39:07] <awong> and codf235.jail
[00:39:52] <tony^work> awong: net unittests have passed
[00:40:06] <pkasting> seanparent: My plan is to wait for Chromium Builder (win dbg) to do another build, and for awong/tony^work to say things are fine with the problem they're looking at
[00:40:12] <awong> ananta ^^^
[00:40:28] <dcheng> Right now my Linux machine is a dual core with 4GB of memory. Am I likely to see much gain in compile time if I move to a quadcore with 8GB?
[00:40:38] <awong> dcheng: ram will help
[00:40:42] <tony^work> awong: chrome_frame_net_tests have passed (build 3535) but chrome_frame_unittests failed due to a disconnect from the master
[00:40:56] <tony^work> dcheng: yes, more ram will make link much faster
[00:41:09] <awong> tony^work: the chromeframe ie6 and ie7 bots failed twice.
[00:41:14] <ananta> awong:
[00:41:18] <ananta> yes?
[00:41:20] <seanparent> pkasting: Okay - waiting more...
[00:41:21] <awong> both times disconnected from master.
[00:41:28] <dcheng> awong, tony^work: Thanks for the tip.
[00:41:42] <ananta> awong: I am looking at the ie6 failures right now. IE7 appears to be going green
[00:41:56] <awong> ananta: ah, okay.  So you're on both boths then?
[00:42:05] <ananta> awong:yes
[00:42:11] <awong> ananta: cool. thanks
[00:42:15] <jamesr> dcheng: 2>4 cores will also be a big speedup
[00:42:31] *** Erkan_Yilmaz__ has joined #chromium
[00:42:48] <awong> dcheng: FYI, I've tried the z600 versus a quad core and don't notice a significant difference for myself in linux using distcc here in kir. I also have found that -j25 is about equal to -j50 on our cluster.
[00:42:55] *** jrmuizel has quit IRC
[00:42:56] <dcheng> jamesr: I'm already using the distcc cluster, and I figure adding cores won't help that much.
[00:42:58] <bryner> dcheng: also, until you get more ram, a shared library build can help quite a bit with the link time for compile + testing cycles
[00:43:45] <awong> dcheng: I've got 16G of ram, use a ramdisk for my object fiels and ccache, and link with gold. I don't notice the link times in incrementals really.
[00:44:25] <dcheng> Hmm...
[00:44:46] <dcheng> I'll try more RAM first since that's the simplest thing.
[00:44:48] *** rohitrao has quit IRC
[00:45:02] <jamesr> awong: what happens if you do 'touch third_party/WebKit/WebCore/rendering/RenderObject.cpp' and then 'time make -jXX BUILDTYPE=Debug chrome' ?
[00:45:47] *** janm has quit IRC
[00:45:54] *** Erkan_Yilmaz has joined #chromium
[00:45:55] <oshima> howdy, i'm back.
[00:45:57] *** Erkan_Yilmaz_ has quit IRC
[00:45:58] *** alt-dot-net-geek has joined #chromium
[00:46:19] *** ojan has joined #chromium
[00:46:20] *** ChanServ sets mode: +v ojan
[00:47:15] <awong> jamesr: errr...don't know...
[00:48:06] <oshima> awong: are we still not ready to open the tree?
[00:48:09] <awong> oshima: hello!  pkasting has the lock for a grd change.
[00:48:18] <oshima> ok
[00:48:27] <awong> so, answer is...no.
[00:48:28] <awong> :(
[00:48:32] *** johnny_g has joined #chromium
[00:48:37] *** Erkan_Yilmaz__ has quit IRC
[00:48:44] <awong> actually, it's time for horizontal emoticons:  ;_;
[00:48:51] <stoyan> sheriffs: May I submit changelist for ChromeFrame - http://codereview.chromium.org/2987001/show
[00:48:56] <pkasting> stoyan: No
[00:49:11] *** jlebar has quit IRC
[00:49:36] <tony^work> things seem to be going green now . . .
[00:49:56] <pkasting> tony^work, awong: Is the tree green enough that you are comfortable with us landing .grd changes?
[00:50:23] <tony^work> I think so, but I defer final judgement to awong :)
[00:50:34] <awong> don't look at me! I have the least experience here!
[00:50:41] <awong> I say go for it.
[00:50:46] <oshima> stoyan: lgtm
[00:51:00] <awong> stoyan: you should coordinate with pkasting though
[00:51:08] *** Erkan_Yilmaz_ has joined #chromium
[00:51:19] <pkasting> Right, I already said no above
[00:51:36] <stoyan> awong: I'm fine waiting.
[00:51:42] <oshima> ok
[00:51:44] <pkasting> seanparent: OK, go ahead, and tell me when you've landed
[00:51:50] <oshima> sorry i'm still catching up.
[00:52:02] <seanparent> pkasting: ...
[00:52:28] *** ebraminio has quit IRC
[00:53:02] *** pdelgallego has quit IRC
[00:53:31] *** Erkan_Yilmaz__ has joined #chromium
[00:54:18] <seanparent> pkasting: The cl has landed!
[00:54:23] *** Erkan_Yilmaz has quit IRC
[00:55:17] <pkasting> OK, both my changes have now landed also
[00:56:01] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree is closed (.grd changes cycling)
[00:57:01] *** Erkan_Yilmaz has joined #chromium
[00:57:03] *** Erkan_Yilmaz_ has quit IRC
[00:58:06] *** alt-dot-net-geek has quit IRC
[00:59:29] *** abarth has joined #chromium
[00:59:29] *** ChanServ sets mode: +v abarth
[00:59:44] *** Erkan_Yilmaz__ has quit IRC
[01:00:25] *** roc has quit IRC
[01:07:36] *** jlebar has joined #chromium
[01:11:40] <thakis> oshima: ok to land http://codereview.chromium.org/download/issue2963009_4001.diff ?
[01:13:10] <oshima> pkasting: what do you think? do you want to wait or ok to check this in?
[01:14:42] <pkasting> No, the build is broken
[01:14:46] <thakis> ok
[01:14:48] <pkasting> tony^work: Help
[01:14:54] <tony^work> hmm?
[01:14:58] <tony^work> looking
[01:15:00] <shess> oshima, estade, awong, jam: am looking at Mac start regression.  Not super confident, unfortunately :-(.
[01:15:12] <pkasting> tony^work: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20(dbg)/builds/22186/steps/compile/logs/stdio
[01:15:33] <pkasting> tony^work: Caused by http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=52239&r2=52238&pathrev=52239 but I don't see why
[01:15:47] <tony^work> buildbots are faster than before
[01:15:48] <tony^work> that's good
[01:16:16] <pkasting> Really wish GRIT dumped out, say, the particular syntax it was trying to compile when it had an error
[01:16:27] <oshima> shess: thank you for looking at it.
[01:17:22] *** Erkan_Yilmaz has quit IRC
[01:17:38] <pkasting> Wait, I have an idea
[01:17:47] *** Erkan_Yilmaz has joined #chromium
[01:17:55] <pkasting> Could that error happen if a line referenced a resource on disk that no longer existed?
[01:18:30] <tony^work> maybe, but I don't see a reference to closed_window.png
[01:19:01] <pkasting> I do
[01:19:01] <tony^work> the linux bot error is more obvious: make: *** No rule to make target `chrome/app/theme/closed_window.png', needed by `out/Release/obj/gen/chrome/grit/theme_resources.h'.
[01:19:11] *** Erkan_Yilmaz_ has joined #chromium
[01:19:17] <pkasting> There were two difference resource IDs that both referenced the same file on disk
[01:19:32] <pkasting> And neither one was used in Chrome after my change
[01:19:43] <pkasting> My change moved the file and eliminated one of the two but missed the other
[01:20:00] <pkasting> I got this right in my original master checkout but wrong in the checkout where I split off this individual patch
[01:20:04] <pkasting> Just checked in a fix
[01:20:07] <tony^work> ah, ok
[01:20:28] <tony^work> I see the other reference to closed_window.png now
[01:20:35] <pkasting> For reference, I still have no idea what the GRIT output is saying
[01:20:43] <pkasting> It's totally useless in tracking down the bug :(
[01:20:44] <tony^work> there is no grit output on the linux build
[01:20:54] <tony^work> because it succeeded with no errors
[01:21:21] <pkasting> Yeah, I mean the output I linked above
[01:21:29] <pkasting> The Windows dbg compile log
[01:21:47] <pkasting> Dunno why it breaks there and not on Linux
[01:21:52] <tony^work> yeah, I have no idea what that means.  seems like bad xml?
[01:22:45] *** Erkan_Yilmaz has quit IRC
[01:23:25] <tony^work> buildbot is getting faster!  I wonder what the problem was.
[01:23:30] *** Erkan_Yilmaz_ has quit IRC
[01:23:34] *** alt-dot-net-geek has joined #chromium
[01:27:10] *** eseidel has quit IRC
[01:27:31] <tony^work> pkasting: build got past theme_resources.grd this time
[01:27:32] *** abarth has quit IRC
[01:27:48] <shess> oshima: and the solution to Mac startup_test was "let it cycle"?  OK, I can live with that.
[01:28:13] <oshima> shess: you mean it's flake?
[01:28:24] <shess> oshima: well, I haven't done anything.
[01:29:08] <oshima> ah, i see. it's passing now.
[01:30:22] <trungl-bot> Tree closed by oshima at chromium dot org: Tree is closed (.grd changes cycling, chromeos interactive_ui_tests -> derat)
[01:31:30] *** alt-dot-net-geek has quit IRC
[01:31:59] <thakis> jamesr: say, WebKit can't depend on chrome's gfx/, right?
[01:32:27] <jamesr> thakis: ?_?
[01:34:02] *** mazda has quit IRC
[01:35:03] * bryner wonders what's up with the windows try bots
[01:35:17] <pkasting> thakis: No
[01:36:00] <pkasting> bryner: What's the problem?
[01:36:53] <bryner> seems to be >90 minutes behind patches sent to it... is that normal for this time of day?
[01:37:00] <thakis> jamesr: i don't follow
[01:37:01] <thakis> jamesr: yes or no?
[01:37:01] <thakis> please answer
[01:37:01] <estade> I think that's internet-slang for "look of yes"
[01:37:01] <thakis> I NEED TO KNOW
[01:37:21] *** tonyg-cr has quit IRC
[01:37:46] *** rafaelw2 has joined #chromium
[01:38:07] *** alt-dot-net-geek has joined #chromium
[01:38:16] *** markmentovai has quit IRC
[01:39:45] <pkasting> bryner: That's normal for all times of day
[01:39:48] *** mirandac has joined #chromium
[01:39:48] *** ChanServ sets mode: +v mirandac
[01:40:05] <bryner> pkasting: oh, ok. maybe i had just been lucky up until now :-)
[01:40:24] <pkasting> bryner: Sadly, we seem to be hitting scaling issues in several different areas simultaneously
[01:41:41] *** rniwa_ has joined #chromium
[01:41:41] *** ChanServ sets mode: +v rniwa_
[01:41:41] *** rniwa has quit IRC
[01:41:41] *** rniwa_ is now known as rniwa
[01:46:06] *** jrmuizel has joined #chromium
[01:47:37] <stuartmorgan> pkasting: Can I check in some leak suppressions?
[01:48:15] *** RT|Chatzilla has joined #chromium
[01:50:03] *** Sonderblade has quit IRC
[01:50:07] <stuartmorgan> oshima: ^^^
[01:50:17] <thakis> jamesr: LayoutTests/canvas/toDataURL doesn't have a pixel result. how do i add one? just check one in on mac?
[01:50:25] <thakis> or do i need pixel results somehow?
[01:50:30] <pkasting> stuartmorgan: Yes
[01:50:41] <pkasting> stoyan: You can check in too
[01:51:28] <oshima> pkasting: thanks
[01:52:44] *** tonyg-cr has joined #chromium
[01:52:44] *** ChanServ sets mode: +v tonyg-cr
[01:53:04] *** mazda has joined #chromium
[01:53:08] <oshima> stuartmorgan: and thank you for suppression. i was going to work on them.
[01:53:24] <stuartmorgan> oshima: I thought I was just going to fix it, which is why I took so long
[01:53:39] *** udp has joined #chromium
[01:53:42] <stuartmorgan> but it turns out there are enough bugs in the memory handling that it's not clear how the code is supposed to work :(
[01:54:05] *** nickcarter has quit IRC
[01:56:07] *** Venom_X has quit IRC
[01:56:26] <oshima> stuartmorgan: np.
[01:56:41] *** phajdan-jr has joined #chromium
[01:56:42] *** ChanServ sets mode: +v phajdan-jr
[01:57:18] *** mazda has quit IRC
[01:58:04] *** abarth has joined #chromium
[01:58:05] *** ChanServ sets mode: +v abarth
[01:58:22] *** abarth has quit IRC
[02:00:15] *** wr| has quit IRC
[02:01:30] *** sebmarkbage has quit IRC
[02:01:44] *** mazda has joined #chromium
[02:01:44] *** ChanServ sets mode: +v mazda
[02:02:28] *** AaronMT has quit IRC
[02:03:44] *** seanparent has quit IRC
[02:05:39] <akalin> are ToT builds failing for anyone else for theme_resources.grd?
[02:06:02] <akalin> oh, i probably should have synced
[02:06:31] <oshima> akalin: yes, pkasting has already fixed grd issue.
[02:06:37] *** wr| has joined #chromium
[02:06:48] <pkasting> Yep, sorry 'bout that
[02:07:40] <slightlyoff> and is there a grid theme for Claro?
[02:07:54] * slightlyoff checks
[02:09:13] *** yutak_home has joined #chromium
[02:09:13] *** ChanServ sets mode: +v yutak_home
[02:11:25] *** alt-dot-net-geek has quit IRC
[02:12:03] *** slightlyoff has quit IRC
[02:14:16] *** awolfson has joined #chromium
[02:15:22] *** ojan has quit IRC
[02:17:48] *** az has quit IRC
[02:17:50] *** j^ has joined #chromium
[02:20:14] *** legion13 has joined #chromium
[02:23:48] *** nshkrob has quit IRC
[02:24:15] *** nshkrob has joined #chromium
[02:24:16] *** ChanServ sets mode: +v nshkrob
[02:27:03] *** rniwa has left #chromium
[02:28:07] *** seventh has joined #chromium
[02:28:20] *** roc has joined #chromium
[02:30:58] *** andybons has quit IRC
[02:31:36] *** Cheery has quit IRC
[02:33:57] *** cpu has quit IRC
[02:34:05] *** dmaclach has quit IRC
[02:34:12] *** __swift has joined #chromium
[02:34:55] <__swift> is there some non-obvious way to select all text in the developer console? on the windows version, at least, i can't figure out how to do it
[02:36:51] *** stuartmorgan has quit IRC
[02:39:27] *** viro101 has joined #chromium
[02:40:05] <pkasting> Any sync folks around?
[02:40:16] <chronarion> yes
[02:40:18] <chronarion> what's up?
[02:40:34] <pkasting> http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20%28dbg%29%281%29 has failed to complete sync_unit_tests the last two runs
[02:40:39] <chronarion> looking
[02:40:41] <pkasting> Both times in FLAKY_Pause
[02:40:57] *** jlebar has quit IRC
[02:41:21] <pkasting> The only src change between the last good and first bad run was in the whitespace file, so I'm not sure whether this is just a way that these tests fail sometimes
[02:43:19] <pkasting> Looking back further, this test seems to cause the test suite to fail this way occasionally
[02:43:33] <pkasting> So it's probably flake, though seeing it twice in a row is a little worrisome
[02:43:43] <chronarion> we're disabling it now, thanks for the heads up
[02:44:10] <pkasting> Thanks for fast action
[02:44:41] <pkasting> Next up: Why is the Mac 10.6 bot in such sad shape?
[02:44:52] <pkasting> Sheriffs/Mac people?
[02:45:20] <bryner> anyone know how to create an optimized build on linux that has debug symbols?
[02:45:49] <jrg> pkasting: lots of bots unhappy due to link issues but I'm not aware of any 10.6 problems (until now)
[02:47:02] <pkasting> jrg: http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.6%20Tests
[02:47:09] <jrg> pkasting: I'll suppress
[02:47:31] <pkasting> There seem to be lots of failures + "log parsing error"s
[02:47:45] <jrg> pkasting: plz be more specific
[02:48:11] <jrg> pkasting: that link does not have a parsing error
[02:48:37] <pkasting> jrg: ????
[02:48:46] <oshima> pkasting:  sync test seems to be crashing. i have cl to disable http://codereview.chromium.org/2981009/show
[02:48:47] <pcgod> bryner: using buildtype Release and adding -g to the cflags should work
[02:49:04] <jrg> pkasting: please be more specific (e.g. links) on "log parsing error" problems
[02:49:06] <pkasting> jrg: "unit_tests
[02:49:07] <pkasting> 11 disabled
[02:49:07] <pkasting>  10 flaky
[02:49:07] <pkasting> log parsing error
[02:49:07] <pkasting> did not complete
[02:49:07] <pkasting> failed 36"
[02:50:06] <bryner> pcgod: thanks
[02:51:50] <oshima> chronarion: are you going to disable Pause?
[02:52:07] *** GeekShadow has joined #chromium
[02:52:24] *** eseidel has joined #chromium
[02:53:51] *** GeekSh4dow has joined #chromium
[02:54:25] *** bweinstein has quit IRC
[02:55:30] *** GeekShad0w has quit IRC
[02:56:21] <chronarion> yes
[02:56:25] <chronarion> i'm uploading it
[02:57:42] *** GeekShadow has quit IRC
[02:57:58] *** rvargas has quit IRC
[02:58:04] <oshima> chronarion: thanks.
[02:58:05] *** rniwa has joined #chromium
[02:58:05] *** ChanServ sets mode: +v rniwa
[02:59:13] *** yutak_home has quit IRC
[02:59:14] <chronarion> oshima: skrul said to go with your patch
[02:59:43] <oshima> chronarion: got it.
[03:00:53] <oshima> done.
[03:02:17] *** mrossetti has quit IRC
[03:02:22] <oshima> tony^work: ping
[03:02:39] *** jshin has quit IRC
[03:03:52] *** dr_win has quit IRC
[03:03:54] <oshima> any chrome frame folks here?
[03:04:33] *** dr_win has joined #chromium
[03:05:20] <oshima> chrome_frame_net_tests is failing after r52211. i'll revert it if I don't hear in next 5 min.
[03:06:58] <trungl-bot> Tree closed by oshima at chromium dot org: Tree is closed (.grd changes cycling, syn_unit_test -> disable in, chrome_frame_net_tests -> r52211))
[03:07:48] <awong> oshima: I'm not sure if revertting 52211 is a good idea
[03:08:20] <awong> I think most of the grd changes that cmae afterwareds depend on that.
[03:08:21] <oshima> awong: dependent changes are in?
[03:08:41] <oshima> ah, this has grd change....
[03:08:43] <awong> yeah..that changes was the preparation for all the grd stuff that happened.
[03:09:30] <awong> given how much other stuff was fixed in the process, letting chromeframe go bad for a while seems like the lesser evil.
[03:09:47] <pkasting> oshima: Please don't revert 52211
[03:09:52] <awong> maybe e-mail ananta and update the tree status to say there's no owner.
[03:09:52] <oshima> no, i don't
[03:10:30] <pkasting> oshima: "Cannot use V8 Proxy resolver in single process mode." sounds like an issue you could contact eroman about
[03:11:21] <awong> pkasting: that's a red herrring I think.
[03:11:22] *** LadySerena has joined #chromium
[03:11:27] <eroman> pkasting: that warning is always in the test log (cant run in single process), shouldnt be an error tho
[03:11:29] <awong> This is a green run of hte bot: http://build.chromium.org/buildbot/waterfall/builders/Chrome%20Frame%20Tests%20(ie6)/builds/3528/steps/chrome_frame_net_tests/logs/stdio
[03:12:16] <pkasting> awong, oshima: Your diagnosis of 52211 seems wrong
[03:12:29] <pkasting> awong, oshima: Look at http://build.chromium.org/buildbot/waterfall/builders/Chrome%20Frame%20Tests%20(ie6)/builds/3529
[03:12:41] <pkasting> awong, oshima: Same failure, at r52203
[03:13:03] <pkasting> awong, oshima: This seems to be flakiness of some sort
[03:13:04] <awong> pkasting: I don't htink we have a diagnosis yet to be wrong about. :)
[03:13:11] *** bmizerany has quit IRC
[03:13:21] <pkasting> awong: The tree status claims otherwise.  I'll change it
[03:13:27] *** rvargas has joined #chromium
[03:13:27] *** ChanServ sets mode: +v rvargas
[03:13:31] <LadySerena> using Google Chrome here, and I notice every time I go to Google Reader I have a Google Chrome Renderer process that chews up processor time, but I'm wondering why it does so?
[03:13:43] *** dr_win has quit IRC
[03:13:44] <awong> flaky sounds good to me. I'm going to send a mail to chromium-dev stating explicitly not to to revert the grd changes.
[03:13:47] <awong> pkasting: thanks
[03:13:59] <oshima> pkasting: ok, i need to go back further then.
[03:14:08] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree is closed (.grd changes cycling, syn_unit_test -> disable in, chrome_frame_net_tests -> flakiness?)
[03:15:33] *** viro101 has quit IRC
[03:16:12] <pkasting> awong, oshima: I am satisfied that the .grd changes have not caused problems.  Do you want me to reopen?
[03:16:38] <oshima> i was going to ask it. if you're happy, let's open!
[03:16:50] *** __swift has quit IRC
[03:16:53] * thakis gets ready
[03:17:09] <trungl-bot> Tree opened by pkasting at chromium dot org: Tree is open (sync_unit_test -> disable in, chrome_frame_net_tests -> flakiness?)
[03:19:33] *** leeight has joined #chromium
[03:20:14] *** hebz0rl_ has joined #chromium
[03:20:14] *** leeight has left #chromium
[03:21:00] *** hbono has joined #chromium
[03:21:39] *** Erkan_Yilmaz has joined #chromium
[03:22:12] *** trungl has quit IRC
[03:23:20] *** rubenbb has quit IRC
[03:24:15] *** hebz0rl has quit IRC
[03:24:45] <ananta> awong: There appears to be a race condition which triggers the net tests to hang.
[03:24:55] *** johnny_g has quit IRC
[03:25:02] <ananta> awong: I am debugging it right now.
[03:25:09] <oshima> anata: is this about chrome_frame_net_tests?
[03:25:16] <ananta> oshima: yeah
[03:25:16] <oshima> ananta: (sorry)
[03:25:40] *** cbentzel has joined #chromium
[03:25:40] <oshima> ananta: thanks
[03:27:56] *** jshin has joined #chromium
[03:27:56] *** ChanServ sets mode: +v jshin
[03:27:56] *** pathorn has quit IRC
[03:27:57] *** johnny_g has joined #chromium
[03:28:15] <trungl-bot> Tree opened by oshima at chromium dot org: Tree is open (chrome_frame_net_tests -> ananta)
[03:28:34] *** yuzo has joined #chromium
[03:28:34] *** ChanServ sets mode: +v yuzo
[03:28:46] *** MikeSmithW3C has joined #chromium
[03:29:43] <akalin> yay open tree!!
[03:30:21] <awong> Woohoo
[03:30:25] *** johnny_g has quit IRC
[03:30:27] * awong high-fives oshima
[03:30:34] *** MikeSmithW3C^ has quit IRC
[03:30:46] <akalin> what's up with the win trybot :(
[03:30:48] <akalin> it's so behind
[03:31:01] <awong> akalin: sympathy slowness for the tree closure today.
[03:31:06] <akalin> :((
[03:31:15] <oshima> awong: yip
[03:31:21] <akalin> oh god so many check ins
[03:31:22] <akalin> so much grey
[03:31:53] *** jrmuizel has quit IRC
[03:32:08] <jamesr> if it makes you feel any better one of the apple build.webkit.org testers is nearly 11 hours behind
[03:32:19] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open (chrome_frame_net_tests -> ananta, please be slow with the checkins...)
[03:33:19] *** alt-dot-net-geek has joined #chromium
[03:33:27] *** fqian has quit IRC
[03:33:43] <akalin> that's the problem with having the tree closed for so long
[03:33:51] <akalin> once it's open, everyone dumps on it and something inevitably breaks again :((
[03:33:52] <awong> well
[03:33:55] <awong> it's going to close again.
[03:34:16] <awong> if they torrent it like this.
[03:34:22] <akalin> but that incentivizes people to rush changes quickly to get their change in in the brief window when the tree is open
[03:34:49] <chronarion> fyi though, we're running a hackathon for sync in seattle
[03:34:59] <chronarion> so there's a bulk order of sync changes that have been pending
[03:35:05] <awong> okay
[03:35:09] <akalin> :(
[03:35:19] <awong> well, still try to pace yourselves...I don't think anyone's going to preemptively close the tree
[03:35:36] <chronarion> yeah, I think that was the initial rush
[03:35:37] <awong> but like akalin said, we're just asking for a compile failure to whack like 15 changes
[03:37:34] <oshima> make sure you run try bots and pass all tests. trybots should to be green for good change now.
[03:38:06] <chronarion> sgtm
[03:39:20] <chronarion> i'm going to add on a very low risk change and I think that's mostly it from us
[03:39:27] <thakis> estade: is there a commandline param to look at the tabbed options dialog?
[03:39:32] <thakis> *html options dialog
[03:39:32] *** leeight has joined #chromium
[03:39:35] *** leeight has left #chromium
[03:42:35] *** jamesr has quit IRC
[03:44:46] <awong> anyone familiar with ScriptSourceCode?
[03:47:05] <awong> Need a v8-bindings sanity check if someone is around who knows that stuff...
[03:54:08] *** alt-dot-net-geek has quit IRC
[03:54:27] <phajdan-jr> wow, the tree is open... wondering if I'll manage to land the change before it closes again
[03:56:20] *** legion13 has quit IRC
[03:57:50] *** dhollowa has joined #chromium
[03:57:50] *** ChanServ sets mode: +v dhollowa
[03:59:12] *** ebraminio has joined #chromium
[04:01:06] *** csilv has left #chromium
[04:01:55] <phajdan-jr> landed!
[04:04:39] *** eseidel has quit IRC
[04:08:09] *** magn3ts has joined #chromium
[04:11:41] *** phajdan-jr has quit IRC
[04:12:10] <dhollowa> hey folks, a question... is there a reliable way to determine at runtime whether i'm running within Chrome-proper versus unit_tests for instance?
[04:17:11] *** jamesr has joined #chromium
[04:17:11] *** ChanServ sets mode: +v jamesr
[04:17:41] *** Sarten-X has joined #chromium
[04:18:16] <oshima> hi, i noticed that try bots are heterogeneous even for the same configuration. certain bots for the same configuration has different kernel, gtk,python than others.
[04:18:35] *** trungl has joined #chromium
[04:18:35] *** ChanServ sets mode: +v trungl
[04:18:42] <oshima> is this intentional?
[04:20:52] <sky_> wow, what a backed up tree.
[04:21:12] *** tonyg-cr has quit IRC
[04:21:38] <akalin> no kidding
[04:22:26] <oshima> akalin: r u asking me?
[04:24:50] *** emhs has joined #chromium
[04:24:51] <oshima> wow (looking at tree).
[04:25:38] <emhs> Hey, quick chromium-os question: Is there (or will there be) some form of virtual keyboard, to enable tablet usage of chromium-os?
[04:26:02] <jamesr> emhs: see /topic
[04:26:08] <jamesr> emhs: chromium-os questions go somewhere else
[04:26:19] <emhs> Oops.  That's what I get for not paying enough attention.
[04:26:19] <oshima> emhs: use #chromium-os
[04:26:40] <emhs> Off I go then.  While I'm here, however, thanks for working on such an awesome browser.
[04:26:46] * emhs <3s chromium.
[04:27:02] <oshima> so does anyone know answer to my question about trybot environment?
[04:27:35] *** emhs has left #chromium
[04:27:36] <oshima> this seems to be causing flaky-ness toExtensionApiTest.CaptureVisibleTab on trybots.
[04:28:19] *** ebraminio has quit IRC
[04:31:03] *** thakis is now known as thakis_afk
[04:33:01] <oshima> ok, looks like we have karmic 64 bit for chromeos but they're also shared with others.
[04:33:05] <oshima> hmm
[04:37:28] *** hbono has quit IRC
[04:43:58] <jamesr> oshima: shouldn't the test pass on different configs?
[04:44:02] <jamesr> oshima: i mean, we have users on different configs
[04:44:16] *** erikkay has quit IRC
[04:45:26] <oshima> jamesr: i think so for kernel and gtk, but tool may depend on python version.
[04:45:30] *** jshin has quit IRC
[04:45:38] <oshima> just want to make sure this is not misconfig or something
[04:45:40] <jamesr> and it doesn't used the checked-in python?
[04:45:52] <jamesr> i have no idea if it's intentional or not
[04:46:14] <jamesr> i would expect developers on slightly different versions of ubuntu to be able to run the tests (within reason of course)
[04:47:25] <oshima> jamesr: i think it is, although I'm not sure about python.
[04:48:46] <oshima> anyway, i file a bug so hopefully we can fix it soon.
[04:49:16] *** trungl has quit IRC
[04:50:15] *** TabAtkins__ has joined #chromium
[04:53:05] *** hbono has joined #chromium
[04:55:03] *** MikeSmithW3C has quit IRC
[04:55:16] *** chronarion has quit IRC
[04:55:26] *** cbentzel has quit IRC
[04:55:43] *** rniwa has quit IRC
[04:57:34] *** estes has quit IRC
[04:58:53] <oshima> i'm signing off. please be kind to the tree :)
[04:59:40] *** rubenbb has joined #chromium
[05:00:16] <eroman> oshima: thanks for all your work!
[05:00:33] *** shoe has quit IRC
[05:01:17] *** shoe has joined #chromium
[05:04:39] *** MikeSmithW3C has joined #chromium
[05:17:00] *** jamesr has quit IRC
[05:20:35] *** trungl has joined #chromium
[05:20:35] *** ChanServ sets mode: +v trungl
[05:34:51] *** GeekSh4dow has quit IRC
[05:34:53] *** bent-mozilla has quit IRC
[05:41:12] *** magn3ts has quit IRC
[05:42:50] *** BryanWB has joined #chromium
[05:45:44] *** loislo has joined #chromium
[05:48:38] *** bweinstein has joined #chromium
[05:50:55] *** SixEcho has joined #chromium
[05:52:13] 
[05:53:29] *** hebz0rl_ has quit IRC
[05:54:16] *** loislo has quit IRC
[06:26:51] *** jamesr has joined #chromium
[06:26:51] *** ChanServ sets mode: +v jamesr
[06:29:15] *** eseidel has joined #chromium
[06:32:07] *** victorw has left #chromium
[06:38:16] *** tedoc2000 has quit IRC
[06:39:06] *** Buglouse has quit IRC
[06:39:32] *** eseidel has quit IRC
[06:44:26] *** SixEcho1 has joined #chromium
[06:47:54] *** SixEcho has quit IRC
[06:49:10] *** Omen_20 has quit IRC
[06:49:14] *** nayankk has left #chromium
[06:49:35] *** BryanWB has quit IRC
[06:50:50] *** seventh has quit IRC
[06:58:54] *** leavittx has quit IRC
[07:00:37] *** leavittx has joined #chromium
[07:02:00] *** Omen_20 has joined #chromium
[07:07:19] *** estes has joined #chromium
[07:10:46] *** michaeln has quit IRC
[07:11:36] *** jamesr has quit IRC
[07:14:11] *** eseidel has joined #chromium
[07:16:41] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder" from 52283: sanjeevr at chromium dot org)
[07:17:09] *** loislo has joined #chromium
[07:26:02] *** Precea is now known as Precea[BNC]
[07:26:10] *** til has joined #chromium
[07:27:02] <til> have there been any major changes to the extensions infrastructure in the last couple of months?
[07:27:16] <til> my extension has been not 100% lately, and i'm just getting around to debugging it
[07:27:53] <rubenbb> check the mailing list, extensions are not supported on irc
[07:27:54] <til> i had an architectural overhaul that i didn't deploy, as i hadn't finished the docs for it yet
[07:28:00] <til> it's not functional either
[07:28:07] <til> rubenbb: thanks
[07:28:50] *** rafaelw2 has quit IRC
[07:29:03] <kermit> does browsing history ever expire?
[07:30:03] *** duffydack has joined #chromium
[07:30:25] <rubenbb> there's some limit after which it starts getting deleted or something, something like 3-6 months
[07:31:35] *** duffydack has left #chromium
[07:33:04] *** MikeSmithW3C has quit IRC
[07:33:32] *** MikeSmithW3C has joined #chromium
[07:34:40] *** johnny_g has joined #chromium
[07:36:23] *** til has quit IRC
[07:38:21] <rubenbb> kermit: although, looking at my history indices I see data going back 9 months ago when I first started using chromium, but I've heard someone claim that those are actually empty so who knows
[07:39:19] *** SixEcho1 has quit IRC
[07:40:05] <rubenbb> hmm, they may in fact be empty, running strings on those files turns up almost nothing.  Either that or they've been packed somehow, dunno
[07:41:28] *** estes has quit IRC
[07:42:43] *** eseidel has quit IRC
[07:44:21] *** MikeSmithW3C has quit IRC
[07:45:21] *** eseidel has joined #chromium
[07:51:07] *** rubenbb has quit IRC
[07:51:35] *** MikeSmithW3C has joined #chromium
[07:52:04] <trungl-bot> Tree opened by sanjeevr at chromium dot org: Tree is open (should cycle green)
[07:53:46] *** yutak has quit IRC
[07:58:05] *** eroman has quit IRC
[08:01:53] *** yuzo has quit IRC
[08:07:23] *** yuzo has joined #chromium
[08:07:23] *** ChanServ sets mode: +v yuzo
[08:09:06] *** BryanWB has joined #chromium
[08:14:05] *** jeremyselier has joined #chromium
[08:16:59] *** jeremyselier has quit IRC
[08:17:13] *** eseidel has quit IRC
[08:17:31] *** jeremyselier has joined #chromium
[08:18:10] *** jeremyselier has quit IRC
[08:18:41] *** jeremyselier has joined #chromium
[08:19:52] *** jeremyselier has joined #chromium
[08:19:54] *** BryanWB has quit IRC
[08:21:40] *** yutak has joined #chromium
[08:21:40] *** ChanServ sets mode: +v yutak
[08:21:46] *** MichealH has joined #chromium
[08:25:28] *** mmoss has quit IRC
[08:26:56] *** dmaclach has joined #chromium
[08:32:45] *** iamdharma has quit IRC
[08:32:53] *** dave_levin has quit IRC
[08:33:15] *** Zucca has quit IRC
[08:33:47] *** pdelgallego has joined #chromium
[08:34:03] *** dmaclach has quit IRC
[08:37:48] *** jeremyselier has quit IRC
[08:38:46] *** estes has joined #chromium
[08:40:25] *** Imperator_ has joined #chromium
[08:47:24] *** Erkan_Yilmaz has quit IRC
[08:55:36] *** kjalarr has quit IRC
[08:55:50] *** Zaba has quit IRC
[08:58:35] *** kjalarr has joined #chromium
[08:59:34] *** MichealH has quit IRC
[09:01:13] *** Adys has quit IRC
[09:02:18] *** Zaba has joined #chromium
[09:04:27] *** eseidel has joined #chromium
[09:05:38] *** wr| has quit IRC
[09:05:51] *** wr| has joined #chromium
[09:08:08] *** bweinstein has quit IRC
[09:11:41] *** TabAtkins__ has quit IRC
[09:17:02] *** johnny_g has quit IRC
[09:18:04] *** trungl has quit IRC
[09:21:28] *** kphanee has joined #chromium
[09:21:50] *** kphanee has left #chromium
[09:23:27] *** peavey has quit IRC
[09:23:33] *** SkyLined3 has joined #chromium
[09:27:00] *** SkyLined2 has quit IRC
[09:29:48] *** mazda has quit IRC
[09:31:00] *** star-affinity has joined #chromium
[09:33:18] <jochen__> mornig ppl
[09:34:58] *** mazda has joined #chromium
[09:34:59] *** ChanServ sets mode: +v mazda
[09:35:53] *** zuh_ has joined #chromium
[09:44:30] *** bauerb has joined #chromium
[09:44:30] *** ChanServ sets mode: +v bauerb
[09:44:45] *** jeremyselier has joined #chromium
[09:46:46] *** TabAtkins__ has joined #chromium
[09:47:39] *** jeremyselier has quit IRC
[09:48:10] *** jeremyselier has joined #chromium
[09:48:16] *** podivilov has joined #chromium
[09:48:21] *** podivilov has left #chromium
[09:48:50] *** jeremyselier has quit IRC
[09:49:21] *** jeremyselier has joined #chromium
[09:49:32] *** TabAtkins__ has quit IRC
[09:50:01] *** jeremyselier has quit IRC
[09:50:32] *** jeremyselier has joined #chromium
[09:51:14] *** goshawk has joined #chromium
[09:51:43] *** jeremyselier has joined #chromium
[09:52:23] *** jeremyselier has quit IRC
[09:52:54] *** jeremyselier has joined #chromium
[09:54:05] *** jeremyselier has joined #chromium
[09:54:45] *** jeremyselier has quit IRC
[09:55:16] *** jeremyselier has joined #chromium
[09:55:40] *** yurys has joined #chromium
[09:55:56] *** jeremyselier has quit IRC
[09:56:27] *** jeremyselier has joined #chromium
[09:57:40] *** jeremyselier has joined #chromium
[09:57:43] *** podivilov has joined #chromium
[10:03:38] <hwennborg> morning
[10:22:43] <jochen__> hey hwennborg
[10:42:23] *** apavlov has joined #chromium
[10:43:11] *** ROBOd has joined #chromium
[10:52:15] *** janm has joined #chromium
[10:53:14] *** reiko_ has joined #chromium
[10:53:15] *** ChanServ sets mode: +v reiko_
[10:57:55] *** reiko_ is now known as reiko
[10:58:09] *** monreal has joined #chromium
[10:59:01] *** jeremymos has joined #chromium
[10:59:01] *** ChanServ sets mode: +v jeremymos
[11:00:20] <jeremymos> oshima: Tree looks kind of red, close?
[11:05:37] <trungl-bot> Tree closed by jeremy at chromium dot org (:jeremymos): Tree is closed (too much redness)
[11:05:43] <jeremymos> Closed tree, any sheriffs online?
[11:09:00] *** chrisccoulson has quit IRC
[11:15:49] *** chrisccoulson has joined #chromium
[11:20:47] *** General13372 has joined #chromium
[11:23:40] *** General1337 has quit IRC
[11:25:12] <nkostylev> jochen__: Mac ui_tests?
[11:28:07] <jochen__> sec
[11:28:54] *** roc has quit IRC
[11:29:47] <jochen__> hum, that could be me :/
[11:29:51] <jochen__> let me have a closer look
[11:33:01] *** jeremyselier has quit IRC
[11:33:23] *** eseidel has quit IRC
[11:33:38] *** jeremyselier has joined #chromium
[11:34:52] <jochen__> i'll land a compile fix
[11:36:54] *** yydyao has joined #chromium
[11:44:13] <jochen__> done
[11:48:01] *** Imperator_ has quit IRC
[11:51:22] <nkostylev> thank
[11:51:24] <nkostylev> s
[11:51:35] *** yydyao has left #chromium
[11:56:08] <trungl-bot> Tree closed by nkostylev at chromium dot org: Tree is closed (too much redness, ui_tests > jochen submitted fix, should cycle green)
[11:57:53] *** ukai has quit IRC
[11:59:10] *** orschiro has joined #chromium
[11:59:39] <orschiro> hello guys, in firefox I can scroll the page by clicking the mousewheel. is there any extension for chromium to have this feature too?
[12:00:44] <orschiro> oh never mind, it's the wrong channel. sorry
[12:04:30] *** jorlow has quit IRC
[12:13:10] *** MikeSmithW3C has quit IRC
[12:13:46] *** MikeSmithW3C has joined #chromium
[12:15:45] *** jorlow has joined #chromium
[12:15:45] *** ChanServ sets mode: +v jorlow
[12:16:17] <nkostylev> thakis_afk: are you here?
[12:17:08] *** orschiro has quit IRC
[12:17:23] *** peavey has joined #chromium
[12:18:28] <trungl-bot> Tree closed by nkostylev at chromium dot org: Tree is closed (Interactive Tests (dbg) > nkostylev reverting CL, ui_tests > jochen submitted fix, should cycle green)
[12:21:17] <apavlov> Any Mac folks around?
[12:32:32] *** hbono has quit IRC
[12:34:23] *** phrearch has joined #chromium
[12:34:24] <phrearch> hi
[12:34:36] <phrearch> does chromium support __noSuchMethod__ yet?
[12:34:40] <phrearch> for js
[12:37:52] *** goshawk has quit IRC
[12:41:46] *** cbentzel has joined #chromium
[12:46:16] *** mazda has quit IRC
[12:47:18] *** fta has joined #chromium
[12:55:24] *** fta has quit IRC
[12:58:02] *** MikeSmithW3C has quit IRC
[13:12:33] *** ukai has joined #chromium
[13:14:01] *** davirtavares has joined #chromium
[13:18:50] <pamg> nkostylev, jochen__: Tree is looking pretty clean. What do you think about opening it?
[13:19:23] *** FullFlannelJacke has quit IRC
[13:20:33] *** FullFlannelJacke has joined #chromium
[13:23:39] *** mazda has joined #chromium
[13:28:33] *** andrix has joined #chromium
[13:34:00] *** BryanWB has joined #chromium
[13:35:31] *** BryanWB has quit IRC
[13:36:35] <trungl-bot> Tree opened by pam at chromium dot org (:pamg): Tree is open
[13:37:23] *** GeekShadow has joined #chromium
[13:46:41] *** allanwoj has joined #chromium
[13:52:02] <jochen__> +1
[14:02:36] *** cbentzel has quit IRC
[14:04:05] <nkostylev> pamg: I'm marking it as open
[14:06:22] <pamg> nkostylev: Thanks, I opened it about half an hour ago.
[14:06:37] <nkostylev> pamg: ok then, I was afk :)
[14:06:43] <nkostylev> thanks
[14:10:14] <pamg> No problem./
[14:24:45] *** hrna has joined #chromium
[14:24:59] *** Beetny` has quit IRC
[14:29:31] *** fta has joined #chromium
[14:31:38] *** awolfson has quit IRC
[14:32:42] *** leeight has joined #chromium
[14:33:19] *** leeight has left #chromium
[14:40:07] *** fta_ has joined #chromium
[14:40:24] *** tonikitoo{away} is now known as tonikitoo
[14:42:05] *** fta has quit IRC
[14:43:26] *** davirtavares has left #chromium
[14:46:22] *** hrna has quit IRC
[14:46:39] *** AaronMT has joined #chromium
[14:50:54] *** cbentzel has joined #chromium
[14:56:56] *** cbentzel has quit IRC
[14:58:28] *** jeremyselier_ has joined #chromium
[14:58:36] *** jeremyselier has quit IRC
[14:58:37] *** jeremyselier_ is now known as jeremyselier
[14:59:18] *** zaspire has joined #chromium
[14:59:30] *** jeremyselier has joined #chromium
[15:00:45] *** jeremyselier_ has joined #chromium
[15:03:44] *** jeremyselier has quit IRC
[15:03:44] *** jeremyselier_ is now known as jeremyselier
[15:06:35] <trungl-bot> Tree closed by bevc at chromium dot org: Tree is closed. Rebooting server at 7AM PDT.
[15:07:45] *** andybons has joined #chromium
[15:07:45] *** ChanServ sets mode: +v andybons
[15:08:01] *** bevc_work has joined #chromium
[15:08:03] <andybons> mornin' yall.
[15:08:14] <pamg> Hola andybons .
[15:08:28] <andybons> pamg: you in berlin nowawadays?
[15:08:34] <pamg> Munich
[15:08:44] <andybons> haha. too early to type correctly
[15:08:47] <andybons> cool! enjoying it?
[15:09:11] <pamg> Absolutely!
[15:09:49] <andybons> good god you've got to be kidding me that the tree has been closed this long and won't be open for another hour
[15:09:53] <jeremymos> 'Morning Andy!
[15:10:05] <andybons> pamg: awesome :)
[15:10:09] <jeremymos> :/
[15:10:13] <andybons> jeremymos: Mornin'!
[15:10:30] <pamg> It was open for a couple of hours.
[15:10:41] <andybons> pamg: when? like 4am est?
[15:10:49] <andybons> ;)
[15:10:51] <pamg> Yup, about that.
[15:10:58] <andybons> hahaha
[15:11:01] <andybons> sigh
[15:11:12] <skerner> andybons: It just closed.  I wanted to check something in, but ran tests one more time.  Big mistake.
[15:11:45] <andybons> skerner: break things before pst wakes up, apologize later. have I taught you NOTHING through example!?
[15:13:48] <skerner> andybons: Don't worry.  I hereby declare that I will never test "one last time" before checkin again!
[15:14:01] <pamg> So that's what I've been doing wrong!
[15:14:03] *** magn3ts has joined #chromium
[15:14:27] <pamg> I keep breaking them long enough before PST wakes up that I have time to fix them. A critical flaw in my plan.
[15:14:27] * andybons Sets a good example on how to GTD.
[15:14:52] <andybons> also a good tactic is to say you have "interviews"
[15:14:57] <andybons> or "meetings"
[15:15:06] <andybons> so you can't get to it right away
[15:15:19] <andybons> shit i'm giving away all my secrets
[15:15:35] <andybons> my advantage during promo period is dwindling.
[15:16:40] <andybons> brb. I have a, uh, interview.
[15:18:20] *** MikeSmithW3C has joined #chromium
[15:21:23] *** davirtavares has joined #chromium
[15:22:08] <davirtavares> Hi, any chance to exists such way to disable <audio> and <video> on build?
[15:22:53] *** magn3ts has quit IRC
[15:25:37] *** cbentzel has joined #chromium
[15:26:38] *** bent-mozilla has joined #chromium
[15:31:52] *** fta__ has joined #chromium
[15:32:55] *** fta_ has quit IRC
[15:32:58] *** hrna has joined #chromium
[15:40:23] *** MikeSmithW3C has quit IRC
[15:43:53] *** ebraminio has joined #chromium
[15:48:46] <jorlow> hmmm
[15:48:54] <jorlow> what's up with this tree closure?
[15:49:03] <jorlow> is 7am pdt in 9 minutes?
[15:49:14] <jorlow> and if so , how long will it last?  really wanna get something landed  :-/
[15:52:25] <nsylvain> should be quick
[15:52:31] <nsylvain> 10 minutes maybe
[15:52:44] <nsylvain> and yes, it's in 5 minutes now
[15:52:51] <nsylvain> so, 15 minutes everything should reopen
[15:55:02] <andybons> nsylvain: woot for tree openage
[15:55:12] <andybons> time to break stuff!
[15:56:36] *** jeremyselier_ has joined #chromium
[15:56:48] *** aroben has joined #chromium
[15:56:57] *** aroben has joined #chromium
[15:57:37] <jorlow> great!
[15:58:40] *** jeremyselier__ has joined #chromium
[16:00:44] *** jeremyselier has quit IRC
[16:00:45] *** jeremyselier__ is now known as jeremyselier
[16:01:17] *** Zucca has joined #chromium
[16:01:18] *** jeremyselier_ has quit IRC
[16:01:26] *** agayev has joined #chromium
[16:02:25] *** awolfson has joined #chromium
[16:03:45] *** MikeSmithW3C has joined #chromium
[16:04:36] *** up365 has quit IRC
[16:05:23] *** luxigo has joined #chromium
[16:06:40] <nsylvain> 10 minutes was a little over optimistic :(
[16:06:58] <andybons> nsylvain: what sort of timeline are we thinking?
[16:07:30] <nsylvain> we rebooted the server to help clear out some of the slowdown issue we've been seeing. Server did not reboot.
[16:07:33] <nsylvain> trying to fix
[16:07:35] <nsylvain> ETA unknown
[16:07:38] <nsylvain> ASAP
[16:08:57] *** bob31 has joined #chromium
[16:09:24] <bob31> any idea why there's no hotkey bound for the 'Clear Data' dialog in the Cocoa port?
[16:09:44] <davirtavares> Hi, any chance to exists such way to disable <audio> and <video> on build?
[16:10:30] <andybons> bob31: try searching for a bug on crbug.com and file one if you think it's needed.
[16:13:23] *** jeremyselier has quit IRC
[16:13:39] *** up365 has joined #chromium
[16:13:45] *** loislo has quit IRC
[16:14:09] *** dr_win has joined #chromium
[16:14:22] *** rsesek has quit IRC
[16:14:41] *** rsesek has joined #chromium
[16:14:41] *** ChanServ sets mode: +v rsesek
[16:15:52] *** cbentzel has quit IRC
[16:17:02] *** malavv has quit IRC
[16:17:36] *** cbentzel has joined #chromium
[16:18:05] <bob31> andybons: http://crbug.com/1404
[16:19:42] <andybons> bob31: ok sounds good
[16:19:54] <bob31> does starring increase prio/vote?
[16:20:27] <bob31> I remember that usage from the googlecode googlecode hosting project
[16:20:28] <andybons> bob31: yup
[16:20:39] *** Omen_20 has quit IRC
[16:20:43] <bob31> k
[16:20:47] <bob31> thanks
[16:22:00] *** up365 has quit IRC
[16:22:49] <nsylvain> jorlow: server is back up, slaves are not all connected yet, but if you want to commit now, this will at least make sure they start doing something as soon as they connect.
[16:23:24] <trungl-bot> Tree closed by nsylvain at google dot com: Tree is closed - waiting for green - ask nsylvain to commit
[16:24:12] *** malavv has joined #chromium
[16:24:18] *** bob31 has left #chromium
[16:26:07] <jorlow> how do i commit, nsylvain ?
[16:26:13] <jorlow> git cl seems to be saying no
[16:26:17] <jorlow> and i forget how to bypass
[16:26:36] <andybons> jorlow: ^^^
[16:26:49] <jorlow> yup
[16:27:11] *** SkyLined3 has quit IRC
[16:27:51] <jorlow> done
[16:28:11] *** SkyLined has joined #chromium
[16:28:18] *** tedoc2000 has joined #chromium
[16:29:28] *** Precea[BNC] is now known as Precea
[16:33:22] <rsesek> nsylvain: may I commit http://codereview.chromium.org/2906009/show ?
[16:33:53] <nsylvain> sure
[16:33:57] <rsesek> thanks
[16:34:03] *** erikkay has joined #chromium
[16:34:03] *** ChanServ sets mode: +v erikkay
[16:34:18] *** trungl has joined #chromium
[16:34:18] *** ChanServ sets mode: +v trungl
[16:35:06] <trungl> 'morning, Chromium.
[16:35:06] <trungl-bot> trungl: Good morning!
[16:35:08] *** Omen_20 has joined #chromium
[16:35:58] <andybons> nsylvain: http://codereview.chromium.org/2946015/show ?
[16:36:09] <nsylvain> ok
[16:36:20] <andybons> nsylvain: thanks much :)
[16:44:33] <jorlow> hmm...one of the builders is red on my change
[16:44:55] <rsesek> fatal error LNK1318: Unexpected PDB error; UNKNOWN (24)
[16:45:11] <jorlow> hm...yeah
[16:45:25] <jorlow> nsylvain: ^^^
[16:45:33] <nsylvain> Ok fixing
[16:46:11] *** up365 has joined #chromium
[16:46:40] *** stuartmorgan has joined #chromium
[16:46:40] *** ChanServ sets mode: +v stuartmorgan
[16:51:54] *** janm has quit IRC
[16:54:07] *** dmaclach has joined #chromium
[16:54:23] *** ebraminio has quit IRC
[16:55:36] *** Gadget3000 has quit IRC
[16:57:32] *** cmtx_ has joined #chromium
[16:57:40] *** az has joined #chromium
[16:58:59] *** fta__ is now known as fta
[16:59:12] *** MichealH has joined #chromium
[17:05:34] *** rohitrao has joined #chromium
[17:05:34] *** ChanServ sets mode: +v rohitrao
[17:05:48] *** dmaclach has quit IRC
[17:05:59] *** fta has quit IRC
[17:06:20] *** fta has joined #chromium
[17:06:21] *** jeremyselier has joined #chromium
[17:08:47] *** jeremyselier has quit IRC
[17:09:08] *** cbentzel has quit IRC
[17:09:33] *** up365 has quit IRC
[17:09:45] *** up365 has joined #chromium
[17:09:53] *** tonyg-cr has joined #chromium
[17:09:53] *** ChanServ sets mode: +v tonyg-cr
[17:10:30] *** Erkan_Yilmaz has joined #chromium
[17:10:36] *** cbentzel has joined #chromium
[17:10:57] *** janm has joined #chromium
[17:11:24] *** cmtx_ has quit IRC
[17:12:07] *** awidegreen has joined #chromium
[17:14:34] *** barcon332 has joined #chromium
[17:16:51] <trungl> rohitrao!
[17:16:58] <rohitrao> hello
[17:17:23] *** chrisccoulson has quit IRC
[17:18:14] <rsesek> PINKERTON WHERE R U?
[17:19:00] <trungl> he probably has a hangover
[17:19:32] <trungl> rsesek: maybe he won't be in today
[17:19:39] <rsesek> that would be unfortunate
[17:19:42] <trungl> rsesek: he's not going to mac triage
[17:19:53] <trungl> rsesek: but if his calendar is to be believed, he should be in tomorrow
[17:19:56] <nsylvain> still getting    Creating library C:\b\slave\chromium-dbg-builder\build\src\build\Debug\lib\startup_tests.lib and object C:\b\slave\chromium-dbg-builder\build\src\build\Debug\lib\startup_tests.exp
[17:19:56] <nsylvain> webcore.lib(RenderView.obj) : fatal error LNK1318: Unexpected PDB error; UNKNOWN (24) ''
[17:19:59] <jorlow> trungl: what did you do to him?
[17:20:06] <rsesek> trungl: no good. I need code reviewed
[17:20:21] * trungl will rubberstamp anything.
[17:20:23] <trungl> (for a price)
[17:20:42] *** nkostylev has quit IRC
[17:21:23] <rsesek> trungl: then you'll be the lucky person to review buttons in the wrench menu
[17:21:25] <rsesek> :)
[17:21:29] *** dmaclach has joined #chromium
[17:21:39] <trungl> rsesek: that could be exciting
[17:21:58] <mirandac> doesn't trungl-bot do reviews yet?
[17:22:04] *** lindi- has joined #chromium
[17:22:16] <trungl> trungl-bot: lgtm
[17:22:17] <trungl-bot> trungl: Error: "lgtm" is not a valid command.
[17:22:21] <trungl> mirandac: nope
[17:22:31] <mirandac> trungl-bot: pleeeeeeeease?
[17:22:31] <trungl-bot> mirandac: Error: "pleeeeeeeease?" is not a valid command.
[17:22:32] <trungl> trungl-bot: review 12345
[17:22:33] <trungl-bot> trungl: Error: "review" is not a valid command.
[17:22:49] <trungl> trungl-bot: rubberstamp
[17:22:50] <trungl-bot> trungl: Error: "rubberstamp" is not a valid command.
[17:22:50] <mirandac> I see a 20% project! :-)
[17:22:53] <trungl> bummer
[17:23:10] *** awolfson has quit IRC
[17:23:38] * trungl wonders if rietveld has a decent programmatic interface.
[17:23:57] <mirandac> now that WOULD be awesoem.  awesome.  aewsmoe.
[17:24:52] *** gavin has quit IRC
[17:24:56] <trungl> maybe I should make trungl-bot take over from me as pinkerton's secretary
[17:25:40] <trungl> or maybe pink needs a bot too
[17:25:41] *** gavin has joined #chromium
[17:25:50] <mirandac> pinkerbot!
[17:26:05] *** rginda has quit IRC
[17:26:39] <trungl> biab
[17:26:48] <rohitrao> pink is getting back today, should be in tomorrow
[17:26:54] <rohitrao> or at least that's what I remember
[17:27:10] <rsesek> according to twitter, he's home
[17:27:14] <trungl> rohitrao: his vacation ended yesterday, if email is to be believed
[17:27:20] <rohitrao> interesting
[17:27:35] <trungl> pinkerton doesn't need a secretary, he needs more stalkers!
[17:27:35] <rohitrao> tell me more about this "twitter"
[17:27:50] <trungl> maybe trungl-bot should tweet
[17:27:52] <stuartmorgan> nsylvain: looks like things are starting to green; can I land a change to some DOMUI that's behind a flag? It'll help get Mac and Linux turning green :)
[17:27:53] *** trungl has quit IRC
[17:28:00] <nsylvain> 1 sec
[17:28:00] *** awolfson has joined #chromium
[17:28:11] <nsylvain> let me try to fix chromium builder dbg first
[17:29:20] *** bent-mozilla has quit IRC
[17:29:59] *** phajdan-jr has joined #chromium
[17:29:59] *** ChanServ sets mode: +v phajdan-jr
[17:30:05] *** mmoss has joined #chromium
[17:30:05] *** ChanServ sets mode: +v mmoss
[17:30:38] *** gavin has quit IRC
[17:32:12] *** bent-mozilla has joined #chromium
[17:32:15] *** gavin has joined #chromium
[17:32:16] *** gavin has joined #chromium
[17:33:28] *** chrisccoulson has joined #chromium
[17:34:19] *** cbentzel has quit IRC
[17:36:49] *** mrossetti has joined #chromium
[17:37:24] *** gavin has quit IRC
[17:38:43] *** trungl_afk is now known as trungl
[17:39:01] * trungl just dropped food on his keyboard and hence can't claim to be afk.
[17:45:10] <gavinp> trungl_eak ?
[17:47:50] *** gavin has joined #chromium
[17:47:50] *** gavin has joined #chromium
[17:48:13] *** tonyg-cr has quit IRC
[17:48:57] *** fta_ has joined #chromium
[17:49:33] *** up365 has quit IRC
[17:49:58] *** bevc_work has quit IRC
[17:50:19] *** gavin__ has joined #chromium
[17:50:30] *** fta has quit IRC
[17:50:32] *** fta_ is now known as fta
[17:50:58] *** AaronMT has quit IRC
[17:51:19] *** eseidel has joined #chromium
[17:51:37] *** eseidel has quit IRC
[17:51:48] *** AaronMT has joined #chromium
[17:52:04] *** gavin has quit IRC
[17:54:54] <nsylvain> stuartmorgan: go ahead
[17:55:11] *** bevc_work has joined #chromium
[17:55:46] *** dhollowa has quit IRC
[17:56:31] <trungl-bot> Tree opened by nsylvain at google dot com: Tree is open - cycling green
[17:58:23] *** jshin has joined #chromium
[17:58:23] *** ChanServ sets mode: +v jshin
[17:59:04] *** Venom_X has joined #chromium
[18:02:35] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac Builder" from 52318: stuartmorgan at chromium dot org)
[18:03:27] *** up365 has joined #chromium
[18:03:29] <stuartmorgan> glah; I forgot to try release. Reverting
[18:04:14] <rsesek> trungl: CL to you
[18:05:18] *** davirtavares has left #chromium
[18:05:27] *** RT|Chatzilla has quit IRC
[18:05:33] *** apavlov has quit IRC
[18:05:37] <trungl-bot> Tree opened by stuartmorgan at chromium dot org: Tree is open (stuartmorgan reverted; will cycle green)
[18:06:19] *** ebraminio has joined #chromium
[18:07:00] *** RT|Chatzilla has joined #chromium
[18:07:13] *** bevc_work has quit IRC
[18:08:15] *** aroben has quit IRC
[18:08:46] <phajdan-jr> dangerous number of patches landing simultanously
[18:09:17] <jorlow> phajdan-jr: feel fre to close the tree
[18:10:34] <phajdan-jr> jorlow: I'll let sheriff make the decision. The problem is that if the "tree open" window is so narrow due to redness, it's difficult to land all those patches in a different way.
[18:10:57] *** rginda has joined #chromium
[18:10:57] *** ChanServ sets mode: +v rginda
[18:11:05] <jorlow> yeah...but on the other hand, half the bots dont' even seem to be working
[18:11:27] <jorlow> kinda disconcerting...
[18:12:17] <jeremymos> I closed the tree, need to let things settle down...
[18:12:47] <trungl-bot> Tree closed by jeremy at chromium dot org (:jeremymos): Tree is closed (too many patches landing at once, give things time to cool down)
[18:12:56] <jeremymos> If you feel things are green enough feel free to reopen
[18:13:50] *** johnny_g has joined #chromium
[18:16:59] *** dhollowa has joined #chromium
[18:16:59] *** ChanServ sets mode: +v dhollowa
[18:19:00] *** markmentovai has joined #chromium
[18:19:01] *** ChanServ sets mode: +v markmentovai
[18:20:00] *** estes has quit IRC
[18:24:54] *** Sarten-X has quit IRC
[18:26:49] *** aroben has joined #chromium
[18:30:44] *** andrix has quit IRC
[18:30:49] *** andrix has joined #chromium
[18:31:17] *** ojan has joined #chromium
[18:31:17] *** ChanServ sets mode: +v ojan
[18:33:06] <mpcomplete> i'm trying to build chrome on my macbook, and i get a linking error: ld: in /path/to/libwebcore.a, can't map file, errno=12
[18:33:10] <ojan> podivilov: ping
[18:33:18] <mpcomplete> this only happens when building debug
[18:34:02] <stuartmorgan> mpcomplete: see the chromium-dev threads about 10.5/10.6
[18:34:02] <podivilov> ojan: pong
[18:34:11] <stuartmorgan> mpcomplete: tl;dr: get 10.6
[18:34:40] <mpcomplete> stuartmorgan: ah. thanks
[18:34:45] <ojan> podivilov: just checking in...what's the state of webkit merging? anything i should be focusing on? do you have a merge in progress or should i start preparing one?
[18:34:55] <ojan> podivilov: i see the reliability canary is having issues
[18:35:00] *** cbentzel has joined #chromium
[18:37:15] *** star-affinity has quit IRC
[18:39:38] *** fta_ has joined #chromium
[18:41:11] *** fta has quit IRC
[18:41:16] *** fta_ is now known as fta
[18:41:50] *** bevc_work has joined #chromium
[18:43:59] <jeremymos> reverting r52326 - it's causing mac unit tests to fail...
[18:45:50] <jeremymos> revert committed - RegexEscape SandboxAccess should now pass.
[18:46:32] *** maikmerten has joined #chromium
[18:46:42] *** aroben has quit IRC
[18:48:32] *** aroben has joined #chromium
[18:48:32] *** aroben has joined #chromium
[18:48:58] *** estade_laptop has joined #chromium
[18:49:29] *** bent-mozilla has quit IRC
[18:50:38] *** skrul has joined #chromium
[18:50:38] *** ChanServ sets mode: +v skrul
[18:51:04] *** caac has joined #chromium
[18:51:26] *** trungl is now known as trungl_afk
[18:51:31] <caac> hey guys, is it true you can't make desktop apps with the latest chromium build ('cause of the unimenu)
[18:52:35] *** gavin__ is now known as gavin
[18:54:04] *** stoyan has quit IRC
[18:54:18] <mpcomplete> stuartmorgan: have you had luck following the upgrade instructions on that wave?
[18:54:21] <sky_> the menu item is cominb back.
[18:54:57] <stuartmorgan> mpcomplete: I've been on 10.6 for a long time; the instructions have changed since I did it.
[18:54:59] <caac> sky_: so I can't make desk. apps?
[18:55:06] <sbyer> mpcomplete: I have, FWIW
[18:55:48] <mpcomplete> sbyer: i can't figure out how to get to netboot
[18:56:52] <sky_> Ya, I think you'll have to wait.
[18:57:14] <caac> omg
[18:57:24] <rohitrao> mpcomplete: option on startup, enter the password, then press 'n;
[18:57:25] *** RT|Chatzilla has quit IRC
[18:57:42] <mpcomplete> rohitrao: is something supposed to happen when i hold option on startup? it just boots normally
[18:57:52] <rohitrao> I
[18:57:57] *** dmaclach has quit IRC
[18:58:01] <rohitrao> I'm pretty sure something is supposed to happen :)
[18:58:09] <sbyer> mpcomplete: yeah, it's supposed to boot into the boot menu
[18:58:24] *** taf2 has joined #chromium
[18:58:45] <sbyer> mpcomplete: using an Apple keyboard? (I've seen non-Apple keyboards have a problem with option-boot)
[18:59:01] <mpcomplete> sbyer, rohitrao: sorry, i'm a mac noob.. i was hold the apple key
[18:59:13] *** caac has left #chromium
[18:59:14] <sbyer> hehe, that'll do it
[18:59:24] *** dmaclach has joined #chromium
[18:59:26] *** estade_laptop has quit IRC
[18:59:39] *** estade_laptop has joined #chromium
[19:01:43] *** dmaclach has quit IRC
[19:02:00] *** jshin has quit IRC
[19:02:05] *** bweinstein has joined #chromium
[19:02:31] <mpcomplete> sbyer: do you know if i want snow leopard stable or testing?
[19:03:51] *** bauerb has quit IRC
[19:04:10] <sbyer> mpcomplete: stable, unless you want to put yourself on the testing track.
[19:04:16] *** tonyg-cr1 has joined #chromium
[19:04:16] *** ChanServ sets mode: +v tonyg-cr1
[19:04:40] <estade_laptop> jeremymos: are you looking at mac unit test failures
[19:04:49] <estade_laptop> (sorry I'm a little late to the party)
[19:04:54] <jeremymos> estade_laptop: reverta lready checked in
[19:05:04] *** mazda has quit IRC
[19:05:10] <estade_laptop> sweet
[19:06:45] *** pfeldman has joined #chromium
[19:06:51] *** janm has quit IRC
[19:07:36] <pfeldman> ojan: hey. i'll look into debug inspector layout tests failures
[19:08:19] <ojan> pfeldman: thanks! let me know if i can help with anything there. obviously, i can do the webkit review once it's ready
[19:08:32] <pfeldman> ojan: k, thnx
[19:10:20] *** jshin has joined #chromium
[19:10:20] *** ChanServ sets mode: +v jshin
[19:10:37] *** fqian has joined #chromium
[19:11:34] *** dmaclach has joined #chromium
[19:12:26] *** rsesek has quit IRC
[19:12:37] *** rsesek has joined #chromium
[19:12:37] *** ChanServ sets mode: +v rsesek
[19:12:40] *** rsesek has left #chromium
[19:12:46] *** rsesek has joined #chromium
[19:12:47] *** ChanServ sets mode: +v rsesek
[19:12:49] <estade_laptop> is anyone looking at chromeframe net tests?
[19:14:30] <oshima> estade_laptop: ananta was looking at it.
[19:14:44] <oshima> we should have it on the status. i'll update.
[19:15:32] <estade_laptop> thanks
[19:15:35] *** eglaysher has joined #chromium
[19:15:35] *** ChanServ sets mode: +v eglaysher
[19:15:35] <trungl-bot> Tree closed by oshima at chromium dot org: Tree is closed (too many patches landing at once, give things time to cool down, chrome_frame_net_tests -> ananta)
[19:17:11] *** dhollowa_ has joined #chromium
[19:19:34] <ananta> oshima: still looking
[19:19:38] *** janm has joined #chromium
[19:19:46] <ananta> oshima: please update the status accordingly
[19:20:44] <ojan> how do the reliability bots work?
[19:20:45] <oshima> ananta: is the current status wrong?
[19:20:53] <ojan> specifically, what does "reliability: complete result of previous build warning" mean
[19:20:54] <ojan> ?
[19:20:59] <ananta> oshima: cool
[19:21:45] <oshima> is anyone looking at linux webkit dbg (2)?
[19:22:31] *** monreal has quit IRC
[19:22:50] <awong> ojan: usually I think that means the build phase didn't complete..
[19:23:04] <awong> ojan: which bot?
[19:23:28] <ojan> awong: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit.org%20Reliability%20Builder&builder=WebKit%20Reliability
[19:24:13] <oshima> pfeldman, ager: ping
[19:24:29] <pfeldman> oshima: pong
[19:24:31] <phajdan-jr> sheriffs: what's keeping the tree closed? I think we can deal with chrome_frame_tests redness.
[19:24:36] <phajdan-jr> oshima: ^
[19:25:11] <oshima> yes, i'd like to open, but wanted to double check about webkit failure.
[19:25:31] <oshima> pfeldman: any idea about linux webkit dbg (2)?
[19:25:55] <stuartmorgan> It's only a single test; chances of it hiding a regression while it's being fixed are super-low
[19:26:00] <mabbo> can someone link me to any kind of straightforward instructions for getting the latest chromium/webkit builds that pass layout tests?
[19:26:12] <oshima> ok, will open.
[19:26:45] <awong> ojan: okay, not 100% sure anymore. What I thought was happening is that it picked a stale build from the reliability builder.
[19:26:50] <pfeldman> oshima: clearly ager
[19:27:22] *** cpu has joined #chromium
[19:27:22] *** ChanServ sets mode: +v cpu
[19:27:31] <oshima> pfeldman: thanks.
[19:27:48] <trungl-bot> Tree opened by oshima at chromium dot org: Tree is open (chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[19:27:54] <phajdan-jr> yay! thanks!
[19:27:59] <awong> ojan: IIRC, usually it clears if the related builder ("Webkit.org Reliability Builder" builder) can stay green for a couple of cycles of the "Webkit Reliability" builder
[19:28:22] <ojan> awong: k. thanks. i guess i'll give it another run.
[19:28:24] *** fta_ has joined #chromium
[19:28:28] <pfeldman> ojan: inspector layout tests work fine for me on WebKit ToT
[19:28:44] <ojan> pfeldman: in a debug build?
[19:28:52] <pfeldman> ojan: debug windows
[19:29:12] *** cpu has left #chromium
[19:29:18] <ojan> pfeldman: in testshell?
[19:29:23] <pfeldman> ojan: yes
[19:29:25] *** podivilov has quit IRC
[19:29:35] <ojan> pfeldman: ok. i have another try server run going, so hopefully it
[19:29:37] *** victorw has joined #chromium
[19:29:38] *** ChanServ sets mode: +v victorw
[19:29:39] <ojan> will pass
[19:30:10] <oshima> btw, i'm not sheriff today (just swapped yesterday with rafaelw), but doing it until my name disappears from waterfall ;)
[19:30:12] <pfeldman> ojan: in case they don't: http://trac.webkit.org/changeset/63309 and http://trac.webkit.org/changeset/63311 are the guys to roll out.
[19:30:18] *** fta has quit IRC
[19:30:31] *** fta_ is now known as fta
[19:30:37] <pfeldman> ojan: most likely http://trac.webkit.org/changeset/63309
[19:30:58] <pfeldman> but again, works for me locally!
[19:31:07] <ojan> pfeldman: ok. thanks for looking into it.
[19:31:11] <pfeldman> np
[19:32:19] <ojan> pfeldman: I assume Ilya is gone for the night then?
[19:32:23] *** allanwoj has quit IRC
[19:32:51] *** asargent has joined #chromium
[19:32:51] *** ChanServ sets mode: +v asargent
[19:32:59] *** thakis_afk is now known as thakis
[19:32:59] *** jamesr has joined #chromium
[19:33:00] *** ChanServ sets mode: +v jamesr
[19:34:00] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 52339: erg at chromium dot org (:eglaysher), lzheng at chromium dot org, phajdan.jr at chromium dot org (:phajdan-jr), rvargas at google dot com, stoyan at chromium dot org, stuartmorgan at chromium dot org)
[19:34:40] *** bevc_work has quit IRC
[19:34:50] <phajdan-jr> compile failure in webkit glue!
[19:34:59] <stuartmorgan> Not me this time; who touched weburlloader_impl.cc ?
[19:35:01] *** csilv has joined #chromium
[19:35:01] *** ChanServ sets mode: +v csilv
[19:35:20] <oshima> looking at changes now...
[19:35:28] *** gavin has quit IRC
[19:35:34] <eglaysher> me
[19:35:34] *** gavin has joined #chromium
[19:35:35] *** gavin has joined #chromium
[19:35:39] <eglaysher> it passed the trybots :(
[19:35:46] *** pfeldman has quit IRC
[19:36:06] <eglaysher> revert in progress
[19:36:12] *** rniwa has joined #chromium
[19:36:12] *** ChanServ sets mode: +v rniwa
[19:36:15] <oshima> eglaysher: thanks
[19:36:52] *** stevenjb has joined #chromium
[19:37:04] *** Venom_X is now known as Venom_lnch
[19:37:38] *** zer0her0_ is now known as zer0her0
[19:39:08] <rohitrao> shess: do you know why the globe icon is gone? :)
[19:39:25] *** rafaelw has joined #chromium
[19:39:25] *** ChanServ sets mode: +v rafaelw
[19:39:33] *** eroman has joined #chromium
[19:39:33] *** ChanServ sets mode: +v eroman
[19:39:35] *** scheib has joined #chromium
[19:39:46] <shess> rohitrao: no, but it's there in the star-decoration CL I sent you.  I'm going to figure out the specific bit and pull it out.
[19:40:03] <oshima> eglaysher: you're reverting it now right? just double checking.
[19:40:05] *** bent-mozilla has joined #chromium
[19:40:20] <eglaysher> oshima: yes. drover is just being slow since the patch touches >30 files
[19:40:49] *** thakis has quit IRC
[19:41:17] <oshima> eglaysher: i can revert using git revert if you like.
[19:41:20] *** thakis has joined #chromium
[19:41:20] *** ChanServ sets mode: +v thakis
[19:41:26] <oshima> up to you.
[19:41:35] <rafaelw> jam, estade: here now. what can i do?
[19:41:46] *** nickcarter has joined #chromium
[19:41:50] <eglaysher> it should be almost done
[19:41:56] <rafaelw> jam2: ^^
[19:42:11] <oshima> rafaelw: hi, we're reverting r52336.
[19:42:29] <oshima> i'll hand it off to you :)
[19:42:43] <rafaelw> ok. thanks.
[19:42:49] <oshima> i mean, erg is reverting.
[19:44:26] <eglaysher> finally at the part where the revert is committing.
[19:44:27] <phajdan-jr> the revert takes quite long. how about using drover?
[19:45:42] <eglaysher> revert is in.
[19:46:09] *** loislo has joined #chromium
[19:47:44] *** til has joined #chromium
[19:47:59] <scheib> Any gclient + git + webkit experts online?   I'm running into an "Error: No SCM found for url None" when performing a gclient sync. I've setup a .gclient with web instructions and successfully built once.
[19:48:11] *** Sarten-X has joined #chromium
[19:50:12] <trungl-bot> Tree closed by estade at chromium dot org: Tree is closed - waiting for more green (compile -> erg (fix in), chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[19:50:48] *** maikmerten_ has joined #chromium
[19:54:10] *** maikmerten has quit IRC
[19:55:07] *** trungl has joined #chromium
[19:55:07] *** ChanServ sets mode: +v trungl
[19:55:38] *** Precea is now known as Precea[BNC]
[19:57:47] <asargent> scheib: there was an update to some of the depot_tools recently - I often have problems when this happens, and just blow away my copy and re-checkout and that usually solves things
[19:58:23] <asargent> http://dev.chromium.org/developers/how-tos/depottools
[19:58:34] *** jamesr has quit IRC
[19:58:53] *** AaronMT_ has joined #chromium
[19:59:06] *** kliegs has quit IRC
[19:59:29] *** kliegs has joined #chromium
[19:59:29] <eglaysher> looks like the compile failures are turning green.
[20:00:50] *** AaronMT_ has quit IRC
[20:01:13] *** AaronMT_ has joined #chromium
[20:01:16] *** froek has joined #chromium
[20:01:29] *** luxigo has quit IRC
[20:02:23] *** AaronMT has quit IRC
[20:02:23] *** AaronMT_ is now known as AaronMT
[20:03:19] <froek> How does gclient know to pull different code for the different platforms.  For example, gclient sync on windows pulls the bookmark core code that has tags enabled.  Obviously on mac tags are not supported, so it pulls from a different revision.  I've looked at the DEPS but can't figure out how gclient knows to pull a different DEPS file
[20:04:05] <kermit> does browsing history ever expire?
[20:04:09] <jam2> eglaysher: let's wait till they all turn green then we can reopen
[20:04:34] <eglaysher> jam2: all bots or all previously red bots?
[20:05:06] *** taf2 has quit IRC
[20:06:19] *** rubenbb has joined #chromium
[20:06:20] <sky_> kermit: yes
[20:06:33] <jam2> eglaysher: all preivously red
[20:06:35] <froek> I think I found it, appears to be .gclient_entries
[20:06:43] <kermit> sky_: when?
[20:08:01] <jam2> ok reopening it
[20:08:22] <ojan> jam2: i think you broke the webkit canary compile
[20:08:24] <trungl-bot> Tree opened by jam at chromium dot org (:jam2): Tree is open (chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:08:57] <ojan> jam2: http://trac.webkit.org/changeset/63330
[20:08:58] <jam2> ojan: yep that's expected
[20:09:04] <sky_> kermit: not sure, look in expire_history_backend
[20:09:08] <jam2> ojan: i have a chrome change that will fix it
[20:09:11] *** Gadget3000 has joined #chromium
[20:09:12] <jam2> http://codereview.chromium.org/2934018/show
[20:09:20] <jam2> ojan: if you can review it, i can commit it now
[20:09:46] <ojan> jam2: i don't understand. won't that need to be committed with the webkit roll?
[20:09:51] *** rsesek has quit IRC
[20:09:56] *** rsesek has joined #chromium
[20:09:57] *** ChanServ sets mode: +v rsesek
[20:10:07] <jam2> jam2: my change needs to be committed before the roll
[20:10:10] *** duffydack has joined #chromium
[20:10:11] <jam2> ojan: i mean
[20:10:55] <awong> froek: shouldn't get .gclient_entires.  Look for "deps_os" inside the DEPS file.  The  .gclient_entries is mostly a cache I think.
[20:10:55] <jam2> i had a webkit change that changed an API, so i left a temporary ifdef in webkit code so that the chrome code can know whether ot use the old or new definition.  now that webkit rolled that change, i dont need that temporary code anymore
[20:11:09] <froek> awong: I see, looking...
[20:11:27] <ojan> jam2: http://trac.webkit.org/changeset/63330 hasn't been rolled yet.
[20:12:29] <jam2> ojan: i know, it needs to be rolled _after_ my change above, or else the tree will be broken
[20:12:37] <jam2> http://trac.webkit.org/changeset/63330  is the the change taking out the temp define
[20:12:48] <ojan> jam2: can you revert the webkti change until the chrome change lands then?
[20:13:04] <jam2> ojan: the chrome change is trivial, i'd rather land it TBR
[20:13:16] <ojan> jam2: if i'm understanding you right, there's no reason there needs to be any period where there webkit canaries are broken.
[20:13:27] <froek> awong: I see that.  However there doesn't appear to be any entries that pertain to the bookmark code in src/chrome/browser/bookmark.
[20:13:49] <ojan> jam2: do whatever you want, but please fix the canaries asap.
[20:13:57] <jam2> ojan: you're right, i didnt consider the webkit canaries.  let me see if i can get a quick review and check it in
[20:14:28] *** janm has quit IRC
[20:14:40] *** duffydack has quit IRC
[20:15:13] <awong> froek: don't know then. Sorry :(
[20:15:39] <froek> awong: I'm using bookmark_model.cc as a reference/tutorial on trying to figure this out.  It's vastly different on mac than it is on a windows box
[20:15:51] <eglaysher> froek: that doesn't sound right.
[20:16:01] *** agl has joined #chromium
[20:16:01] *** ChanServ sets mode: +v agl
[20:16:03] <awong> froek: they should be the same...are you sure that your synced to the same revision on both clients?
[20:16:17] *** jamesr has joined #chromium
[20:16:17] *** ChanServ sets mode: +v jamesr
[20:16:21] <eglaysher> most of the core chrome/ code should be the same across platforms.
[20:16:38] <eglaysher> You'll note that on windows, you have a full checkout of chrome/browerser/gtk and chrome/browser/cocoa.
[20:17:19] <froek> eglaysher: awong: let me back up a sec.  I've pulled src on mac and on windows.  Tags are not supported in mac yet, so the bookmark_model.cc is different in that it doesn't have RemoveTag() function.  is that correct or my windows pull is wrong somehow?
[20:17:43] <eglaysher> wait when did we add tags to chrome's bookmark system?
[20:18:24] <froek> hmm
[20:18:35] <jam2> ojan: chrome change committed
[20:18:39] *** fta_ has joined #chromium
[20:18:49] <ojan> jam2: thanks. sorry for being grumpy. :)
[20:19:14] <eglaysher> There is no RemoveTag() function in my tree. (linux checkout)
[20:19:23] <jam2> ojan: np at all, i completely forgot about the canary build :)
[20:19:36] <jam2> thanks for reminding me, i'll be careful next time
[20:19:49] <ojan> jam2: yeah, there are too many builders to be aware of these days. :(
[20:20:06] *** fta has quit IRC
[20:20:15] *** fta_ is now known as fta
[20:22:35] <stuartmorgan> froek: the short answer is that that's not correct; we don't pull completely different copies/revisions of Chromium code for different platforms
[20:23:05] *** nickcarter has quit IRC
[20:23:21] <froek> stuartmorgan: I see.  So it's the same DEPS no matter what, and the only real platform switching code is in the deps_os block of the DEPS correct?
[20:23:47] <pkasting> froek: If your source files are different, something went wrong and one of your repos has the wrong data
[20:23:55] <pkasting> froek: I mean one of your checkouts
[20:24:02] <froek> pkasting: makes sense.. ok thx
[20:24:19] <jam2> ok tons fo checkins, ok if i close the tree to let it catch up?
[20:24:26] <stuartmorgan> froek: AFAIK DEPS doesn't apply to chromium code (except webkit chromium code)
[20:24:27] *** phrearch has quit IRC
[20:24:36] <pkasting> froek: Sometimes SVN gets confused and the only solution is to nuke parts of the checkout and completely re-sync :)
[20:25:04] <pkasting> froek: Also, like eglaysher, I'm unaware of any work to add tagging support for bookmarks
[20:25:25] <rohitrao> shess: heh, found the problem :P
[20:25:36] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed to let a bunch of changes cycle (chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:25:40] <shess> rohitrao: yes.  is stupid.  I'm delayed writing a unit test.
[20:29:18] <stuartmorgan> froek: The repository's copy of that file doesn't have a RemoveTag function, so I have no idea what you pulled on Windows. Maybe you have a patch applied locally.
[20:29:38] <rohitrao> shess: do the omnibox and popup icons line up once you switch to <=?  They don't for me
[20:30:09] *** rniwa has quit IRC
[20:30:19] <shess> rohitrao: nope.  Some constant-tweaking left to happen, but I didn't want to get too lost in the details.
[20:30:29] <rohitrao> sounds good
[20:32:25] <shess> rohitrao: http://codereview.chromium.org/2958012 !!!
[20:33:20] *** janm has joined #chromium
[20:33:37] *** eseidel has joined #chromium
[20:34:42] <jam2> cbentzel: broken net_unittests
[20:35:18] <jam2> cbentzel: please revert.  also why didn't you use the trybots?
[20:36:44] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed to let a bunch of changes cycle (net_unittests -> cbentzel, chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:37:40] <cbentzel> reverting
[20:37:46] <ananta> estade: Can I submit a fix for the chrome frame net tests hang?
[20:38:45] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed to let a bunch of changes cycle (net_unittests -> cbentzel reverting, chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:39:21] <eglaysher> aaaaarrrrrggh.
[20:39:52] <cbentzel> reverted
[20:39:53] <cbentzel> sorry
[20:39:58] *** barcon332 has quit IRC
[20:40:27] <jam2> am i the only one getting build failures on process_watcher_win.cc??
[20:40:39] <eglaysher> jam2: no. I am committing
[20:40:47] <jam2> apparently not, just saw the tree
[20:41:11] <jam2> eglaysher: please wait for the trybot next time
[20:41:20] <eglaysher> I DID.
[20:41:31] <jam2> i dont see it http://codereview.chromium.org/2937010?
[20:41:47] <andybons> trungl: trungalung
[20:41:55] <eglaysher> jam2: http://build.chromium.org/buildbot/try-server/builders/win/builds/39702
[20:42:12] *** victorw has left #chromium
[20:42:15] <trungl> andybons: bonsalon?
[20:43:08] <andybons> trungl: regarding http://crbug.com/34135
[20:43:16] *** aroben has quit IRC
[20:43:39] <andybons> trungl: does this help at all? http://codereview.chromium.org/2952004/diff/13001/14011?context=10&column_width=80
[20:44:02] *** phajdan-jr is now known as phajdan-jr|afk
[20:44:19] <jam2> eglaysher: how come it didn't update the coderview url then?
[20:44:54] <eglaysher> I have no idea, but this isn't the first time this has happened.
[20:45:00] <trungl> andybons: dunno, try it?
[20:45:15] <stuartmorgan> eglaysher/jam2: that happened to me this morning too
[20:45:23] <andybons> trungl: i got that crash once while testing
[20:45:47] <trungl> andybons: with your change?
[20:45:57] <jam2> eglaysher: i guess i dont understand how it could have compield on the windows try bots
[20:46:01] <andybons> trungl: but I haven't been trying to repro, but based on the stack trace I just figured that if something returns NULL it has to be checked.
[20:46:12] <andybons> trungl: or _could_ return NULL that is
[20:46:43] <andybons> trungl: yeah. testing tearing off app tabs and stuff
[20:46:57] <awong> eglaysher: intersting note...that try link you sent looks like it has an empty patch.
[20:47:03] <eglaysher> blink
[20:47:28] <eglaysher> that's more than a little worrying.
[20:47:49] <awong> eglaysher: yeah...no kidding.  You using git try? Did it accidentally diff against the wrong branch?
[20:48:21] <trungl> andybons: yeah, checking for NULLity seems better to me
[20:48:24] *** janm has quit IRC
[20:48:34] <trungl> andybons: it's not obvious to me what the NULL return means
[20:48:44] <trungl> andybons: (is it then definitely not an app tab?)
[20:49:07] <andybons> trungl: well if it can't find it, then it isn't _any_ kind of tab, right? so no?
[20:49:19] * trungl barely knows what it means to be an app tab.
[20:49:23] <andybons> trungl: if a tab is closed in the woods
[20:49:24] <eglaysher> Yes, I'm using git-try.
[20:49:32] <trungl> andybons: I think it could be a pinned tab which has been closed
[20:49:45] <jam2> eglaysher: idle_win.cc is also borken, is that you?
[20:49:46] *** rubenbb has quit IRC
[20:49:52] <jam2> and plugin_service.cc
[20:49:57] *** udp has quit IRC
[20:50:16] <eglaysher> jam2: ok I'm pulling everything out because obviously something went absoluetly wrong with my trybot runs.
[20:50:31] <trungl> andybons: (note that the pinned tab check is separate and different)
[20:50:36] <jam2> eglaysher: i dont knw if it's you, i'm asking if you changed those files
[20:50:41] <andybons> trungl: right.
[20:50:51] <trungl> andybons: I have no idea what the intersection of app tabs versus pinned tabs is
[20:51:00] <andybons> trungl: i'm just keeping you in the loop on the change since i remember that stack trace
[20:51:12] <andybons> trungl: and i'm not associating this change with that bug you own
[20:51:20] <eglaysher> jam2: plugin_service definitly is. There's maybe a 10% chance the other one is though.
[20:51:29] <trungl> andybons: thanks, I hope this makes that crash go away ;)
[20:51:47] <jam2> eglaysher: ok please revert
[20:51:56] <andybons> trungl: i do, too. you can take credit, though :)
[20:52:04] *** wash has joined #chromium
[20:53:06] <estade_laptop> ananta: sorry, was afk. Please do commit your fix
[20:53:28] <trungl> andybons: hard to take credit for things without repro steps! it may just vanish silently....
[20:53:44] <rohitrao> why was that crash mac-only then?
[20:54:10] <ananta> estade: thanks
[20:54:18] <eglaysher> jam2: revert in progress
[20:54:33] *** Buglouse has joined #chromium
[20:55:13] *** udp has joined #chromium
[20:55:32] * jam2 (not aimed at anyone in particular), but i'm going to throttle todays checkins to only ones with green trybot runs
[20:55:56] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (compile failure->erg reverting, net_unittests -> cbentzel reverting, chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:57:37] <trungl> rohitrao: maybe it only occurred on shutdown?
[20:57:48] <trungl> rohitrao: which is a bit different
[20:57:49] <rektide> is there a hotkey for the "select an element in page" tool?
[20:57:57] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (NO CHECKINS TODAY WITHOUT GREEN TRYBOT OR EXPLANATION WHY TEST FAILED) (compile failure->erg reverting, net_unittests -> cbentzel reverting, chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[20:57:57] <rohitrao> possibly
[20:58:12] <rektide> half the ajax shit on the planet disappears if you're not hovering over, making the inspector tool hard to use
[21:00:06] *** Erkan_Yilmaz_ has joined #chromium
[21:00:12] *** rafaelw has quit IRC
[21:01:23] *** tonyg-cr1 has quit IRC
[21:01:31] *** Venom_lnch is now known as Venom_X
[21:01:59] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (NO CHECKINS TODAY WITHOUT GREEN TRYBOT OR EXPLANATION WHY TEST FAILED) (compile failure->erg reverting,  chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[21:03:21] *** Erkan_Yilmaz has quit IRC
[21:03:37] *** rafaelw has joined #chromium
[21:03:37] *** ChanServ sets mode: +v rafaelw
[21:04:54] <oshima> johnny_g: ping
[21:05:06] *** LadySerena has left #chromium
[21:05:11] *** cbentzel has quit IRC
[21:08:09] *** dave_levin has joined #chromium
[21:08:09] *** ChanServ sets mode: +v dave_levin
[21:08:14] *** mabbo has quit IRC
[21:10:24] *** eroman has quit IRC
[21:12:29] *** rjkroege has quit IRC
[21:12:43] *** rjkroege has joined #chromium
[21:12:55] *** eseidel has quit IRC
[21:14:15] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (ONLY CHECKIN IF GREEN TRYBOT RUN OR EXPLANATION WHY TEST FAILED) (compile failure->erg reverting,  chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[21:15:16] *** Ruetobas has quit IRC
[21:15:51] <oshima> stuartmorgan: ping
[21:16:17] <jam2> hmm looks like somthing is worng with IE6 Chrome Frame builder.  anyone here who knows what to do?
[21:16:36] <awong> jam2: I'm pretty sure ananta is looking at that.
[21:17:14] <awong> jam2: errr...ignore me, I'm talking off an old tree view.
[21:17:38] <pkasting> jam2: Can I check in a change that removes a bunch of images off disk (no code change)?  trybots can't run that.
[21:17:52] *** Ruetobas has joined #chromium
[21:18:19] <ananta> jam2: I tried forcing a build leading to extract build failures
[21:18:39] <ananta> jam2: The next run should hopefully go through
[21:19:21] *** janm has joined #chromium
[21:20:36] *** Omen_20 has quit IRC
[21:20:41] *** MikeSmithW3C has quit IRC
[21:20:41] *** mabbo has joined #chromium
[21:20:58] <oshima> jam2: may I check in suppression change? http://codereview.chromium.org/2998007
[21:22:52] <estade_laptop> oshima: go ahead
[21:22:52] <jam2> oshima: sure
[21:23:00] <oshima> thanks
[21:23:04] <jam2> ananta: sg
[21:23:27] *** MichealH has quit IRC
[21:23:29] <jam2> pkasting: sure, but let the tree be green first
[21:23:40] *** jrmuizel has joined #chromium
[21:25:24] *** Kunalagon has joined #chromium
[21:25:37] *** MikeSmithW3C has joined #chromium
[21:26:41] *** duffydack has joined #chromium
[21:28:40] *** tonyg-cr has joined #chromium
[21:28:40] *** ChanServ sets mode: +v tonyg-cr
[21:31:12] *** duffydack has quit IRC
[21:31:32] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (ONLY CHECKIN IF GREEN TRYBOT RUN OR EXPLANATION WHY TEST FAILED) (chrome_frame_net_tests -> ananta, linux webkit dbg(2) -> ager?)
[21:31:35] *** cbentzel has joined #chromium
[21:31:44] <oshima> cpu: ping
[21:32:07] *** rdsmith has joined #chromium
[21:32:17] *** kermit has quit IRC
[21:32:25] *** duffydack has joined #chromium
[21:32:46] *** saittam has joined #chromium
[21:33:05] *** wash has quit IRC
[21:33:25] *** cbentzel has quit IRC
[21:33:25] *** scheib has quit IRC
[21:33:40] <oshima> jam2: another suppression. http://codereview.chromium.org/2903015
[21:34:22] <jam2> oshima: fine
[21:34:32] <oshima> jam2: thx
[21:36:30] *** michaeln has joined #chromium
[21:36:30] *** ChanServ sets mode: +v michaeln
[21:37:02] *** duffydack has quit IRC
[21:37:33] *** aroben has joined #chromium
[21:37:39] *** cbentzel has joined #chromium
[21:38:29] *** luxigo has joined #chromium
[21:39:19] <stuartmorgan> oshima: pong
[21:39:27] *** saittam has quit IRC
[21:39:53] *** saittam has joined #chromium
[21:41:05] *** saittam has quit IRC
[21:41:18] *** saittam has joined #chromium
[21:41:48] *** saittam has quit IRC
[21:45:09] *** eseidel has joined #chromium
[21:45:25] *** johnny_g has quit IRC
[21:45:57] <rdsmith> Is there a suspected revision responsible for the chrome frame test failures?  I'm one of the possible revisions that might have caused it, but it doesn't look related to my changes.
[21:46:12] <estade_laptop> rdsmith: I think ananta fixed it. it's cycling green
[21:46:18] <estade_laptop> (seemingly)
[21:46:45] <estade_laptop> yea it's green
[21:47:26] <rdsmith> Really?  I guess I don't know how to read the waterfall; it looks like annanta's revision shows red on those two tests, just like everything before her.
[21:47:56] *** Erkan_Yilmaz__ has joined #chromium
[21:47:59] <rdsmith> But thanks; I won't worry about it.
[21:48:31] <estade_laptop> rdsmith: yea because the extract build failed. I think he had to clobber the bots, which made them go red because they interrupted the build, but the next build went green. Look at the top row
[21:49:07] *** luxigo has quit IRC
[21:49:18] <rdsmith> Ah, got it.  So a clobber and rebuild doesn't show up associated with any revisions (I'm looking at the console view.)  Thanks!
[21:51:08] *** jshin has quit IRC
[21:51:16] *** Erkan_Yilmaz_ has quit IRC
[21:51:18] *** kermit has joined #chromium
[21:51:37] *** jshin has joined #chromium
[21:51:37] *** ChanServ sets mode: +v jshin
[21:52:40] <oshima> stuartmorgan: there were remaining valgrind errors in ExtensionPrefStoreTest and I checked in more suppressions.
[21:52:58] <oshima> correction: relaxed the suppressions.
[21:53:02] <stuartmorgan> oshima: thanks; sorry I forgot to follow up on that this morning
[21:53:11] <oshima> np
[21:53:38] <oshima> i think linux/chromeos valgrind will be green (crossing finger)
[21:53:42] *** fta has quit IRC
[21:54:00] *** abarth has joined #chromium
[21:54:00] *** ChanServ sets mode: +v abarth
[21:56:25] *** bob31 has joined #chromium
[21:57:14] *** MichealH has joined #chromium
[21:58:16] <bob31> andybons: is the cmd-shift-delete patch already reviewed and maybe on buildbot?
[21:58:38] <rsesek> bob31: I think it went in thsi morning
[21:59:08] <bob31> rsesek: thanks, will try a snapshot. wasn't sure how to read that info from the review item without checking SVN
[22:00:12] <rsesek> bob31: if description has a Committed: <URL> line then it's in SVN
[22:01:32] <bob31> rsesek: yeah, it has, started a snapshot build but didn't work. lemme re-test properl.....
[22:01:46] <bob31> rsesek: downloaded build 52343
[22:01:55] <bob31> rsesek: wich I suppose is the SVN revid
[22:01:58] <rsesek> trungl: CL back to you
[22:02:45] *** victorw has joined #chromium
[22:02:46] *** ChanServ sets mode: +v victorw
[22:03:14] <bob31> rsesek: Menu item has proper annotation of hotkey but pressing Cmd-Shift-Delete doesn't bring up the dialog
[22:03:36] <tommi> estade_laptop: fyi I just submitted a patch w/green bots as per the status - please slap my fingers if I shouldn't have
[22:04:05] <trungl> rsesek: will look
[22:04:12] <bob31> it's a little wron
[22:04:17] <bob31> it's Backspace and not Delete
[22:04:21] <thakis> do we have closure support in chrome?
[22:04:27] <thakis> i.e. a callback with prebound parameters
[22:05:51] <estade_laptop> tommi: I think the tree closure and the message about green bots are two orthogonal thoughts
[22:05:58] <estade_laptop> but it should probably be opened
[22:06:01] <estade_laptop> looks pretty green
[22:06:22] <tommi> ah, misunderstood
[22:06:29] *** Kunalagon has quit IRC
[22:06:42] * tommi slaps fingers
[22:07:07] <jam2> regarding the tree, i think it should be open, but only for changes with try results
[22:07:14] <jam2> most of todays failures could have been prevented with them
[22:07:29] <jam2> i just kept it marked closed so that people cant commit without -f
[22:07:35] *** janm has quit IRC
[22:07:39] <jam2> othe5rwise people check in changes without trybot runs
[22:07:49] <shess> jam2: so ... open if we have try results?
[22:07:58] <jam2> yes
[22:08:02] <jam2> green ones :)
[22:08:06] <tommi> hah
[22:08:14] *** rjkroege has quit IRC
[22:08:17] <jam2> or test results that are failing but you can explain that it's flakey
[22:08:33] <jam2> but MOST DEFINITELY, NO CHECKINS THAT HAVENT BEEN EVEN TESTED TO COMPILE!!!
[22:08:37] *** rjkroege has joined #chromium
[22:10:37] *** eroman has joined #chromium
[22:10:38] *** ChanServ sets mode: +v eroman
[22:11:26] *** andrix has quit IRC
[22:11:32] <tommi> jam2 ... I have two powerful words for you ... come on.... come on...
[22:11:56] *** maikmerten_ has quit IRC
[22:12:37] <rsesek> bob31: comment on the bug, I guess
[22:12:47] <bob31> will
[22:14:06] <agayev> can't reproduce crashes reported by trybots
[22:15:14] <estade_laptop> ojan: I think excessive-comma-usage.html needs an expectations update on linux
[22:16:18] <estade_laptop> ojan: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fjs%2Fexcessive-comma-usage.html
[22:16:38] <bob31> rsesek: good enough: http://code.google.com/p/chromium/issues/detail?id=1404#c18 ???
[22:16:59] <rsesek> bob31: I'll rebuild my tree and if I Can repro I'll reopen it
[22:16:59] <rjkroege> given that the tree is closed, what CL would people recommend that would be a safe baseline?
[22:17:03] <trungl-bot> Tree opened by estade at chromium dot org: Tree is open (please use trybots) (linux webkit dbg(2) -> needs expectations update)
[22:17:21] <ojan> estade_laptop: yup. looks liek it crashes. looking at the blamelist it seems like updating to V8 2.2.24 is the most likely culprit
[22:17:46] <ojan> estade_laptop: http://build.chromium.org/buildbot/perf/dashboard/ui/changelog.html?url=/trunk/src&mode=html&range=52310:52309
[22:17:48] <bob31> rsesek: oops, I got a Delivery Failure mail after updating the issue. klinx at chromium dot org is reported as failed
[22:17:56] <rsesek> weird
[22:18:06] <bob31> klink at chromium dot org
[22:18:22] <bob31> actually klink at google dot com
[22:18:27] *** taf2 has joined #chromium
[22:18:34] <jamesr> yeah that's expected
[22:18:46] <jamesr> wonder if there's any way to bulk update bug CC lists
[22:18:54] <bob31> not my fault though
[22:19:09] <bob31> oh and went staright into spam folder
[22:19:30] <jamesr> nope, when you updated the bug it generates an email to everyone on the CC list. one of the emails on the bug's CC list is bouncing
[22:19:39] <bob31> yep
[22:19:53] <bob31> just surprised it is handled as if I was From:
[22:19:53] *** janm has joined #chromium
[22:20:04] <bob31> and not From: bugbot at google dot com
[22:20:27] *** slightlyoff has joined #chromium
[22:20:27] *** ChanServ sets mode: +v slightlyoff
[22:20:43] *** estes has joined #chromium
[22:21:34] <estade_laptop> ojan: for the time being, do you tihnk ew can file a bug and change the expectations, until ager has a chance to fix it?
[22:21:47] <estade_laptop> the other options are a) revert v8 roll and b) let tree remain red
[22:22:05] *** Beetny has joined #chromium
[22:22:19] *** Beetny has quit IRC
[22:22:37] *** Kunalagon has joined #chromium
[22:23:12] * shess wants a version of git cl dcommit which can slipstream multiple branches.
[22:24:06] <ojan> estade_laptop: yeah, but we can do this all in the chrome tree...
[22:24:18] <ojan> estade_laptop: src/webkit/tools/layout_tests/test_expectations.txt
[22:24:33] <ojan> estade_laptop: that's for layout tests that fail due to chrome-side problems
[22:25:02] <estade_laptop> ojan: ok ill get on that
[22:25:15] <ojan> estade_laptop: happy to code review if you need
[22:25:45] *** bmizerany has joined #chromium
[22:26:53] *** loislo has quit IRC
[22:26:59] *** Beetny has joined #chromium
[22:28:59] *** taf2 has quit IRC
[22:30:16] *** janm has quit IRC
[22:31:43] *** eseidel has quit IRC
[22:32:15] <andybons> bob31: it's already landed and on trunk.
[22:34:07] *** eroman has quit IRC
[22:35:39] *** Erkan_Yilmaz_ has joined #chromium
[22:35:43] *** taf2 has joined #chromium
[22:37:31] *** ebraminio has quit IRC
[22:39:11] *** Erkan_Yilmaz__ has quit IRC
[22:43:04] *** janm has joined #chromium
[22:44:51] *** luxigo has joined #chromium
[22:46:20] *** arv has joined #chromium
[22:46:20] *** ChanServ sets mode: +v arv
[22:49:29] *** janm has quit IRC
[22:51:53] *** taf2 has quit IRC
[22:52:30] <bob31> andybons: thanks, I know. it just seems to be a little wrong
[22:52:38] <bob31> see the comment to the issue
[22:53:13] <andybons> bob31: interface builder doesn't allow you to map the windows-style 'Delete
[22:53:16] <andybons> ' key anymore
[22:53:46] <andybons> bob31: and all modern mac keyboards have 'delete' where 'backspace' is.
[22:53:55] *** joshia has left #chromium
[22:54:04] <bob31> andybons: I only have a full sized alu keyboard
[22:54:11] <andybons> bob31: like mine, which doesn't even allow me to use the other key.
[22:54:11] <bob31> andybons: no portable device
[22:54:16] <bob31> uhm
[22:54:26] <bob31> andybons: I can use Delete and BackSpace
[22:54:53] <aboodman> argh. 28, 35, and 64 pending try jobs
[22:55:07] <andybons> bob31: http://images.apple.com/keyboard/images/top_view_20091020.jpg
[22:55:15] <aboodman> by the time my job runs the results will be invalid
[22:55:16] <asargent> that's what happens when we tell people to actually use them
[22:55:29] <bob31> andybons: that's a crippled light keyboard
[22:55:30] *** ace__ has joined #chromium
[22:55:32] <bob31> missing right part
[22:56:00] <jamesr>  i have a full sized one and both keys on it are labelled 'delete'
[22:56:10] <jamesr> i.e. the ones that say 'backspace' and 'delete' on my microsoft keyboard
[22:56:11] <bob31> Firefox supports both keys
[22:56:38] <bob31> jamesr: mine has a <-- icon on backspace and delete with the [X]> box
[22:56:48] *** taf2 has joined #chromium
[22:56:55] <bob31> <[X] as in the Cocoa gui seems to be the backspace icon
[22:57:04] <rsesek> bob31: just go into System Prefs ?> Keyboard and override the shortcut key
[22:57:07] <andybons> bob31: Good for Firefox. They're not a native cocoa app. Interface builder simply does not allow it.
[22:57:23] <bob31> so that wide delete button on that keyboard in the image is what?
[22:57:35] <motownavi> You can't make a delete shortcut with either key using the pref pane
[22:57:37] <jamesr> ..delete?
[22:57:46] *** tonikitoo has quit IRC
[22:58:02] <bob31> so there's no abckspace in _modern_ apple keyboards?
[22:58:09] <motownavi> There never was
[22:58:14] <andybons> bob31: no. there never was.
[22:58:20] <bob31> yes thereis
[22:58:46] <motownavi> What the PC calls "backspace" has always been "delete"
[22:59:01] *** MichealH has quit IRC
[22:59:10] <motownavi> http://en.wikipedia.org/wiki/File:Apple_Extended_Keyboard.jpg
[22:59:13] <motownavi> circa 1986
[22:59:39] <bob31> well in Termanil.app default settings Backspace is C-h and Delete has no effect
[22:59:50] <bob31> in any case, regardless of Backspace or Delete
[23:00:24] <bob31> 1) what about the issue of missing focus and shortcut being eaten by an input form field
[23:00:39] <bob31> 2) can we make the clear-and-close button default-focusses?
[23:00:41] <motownavi> are there bugs files?
[23:00:46] <motownavi> filed?
[23:01:41] *** fsamuel has quit IRC
[23:01:44] <bob31> don't know. it's debatable to have a shortcut for showing the dialog but having to use the mouse to click a button
[23:01:48] <bob31> or pointless
[23:02:07] *** rafaelw has left #chromium
[23:02:21] <motownavi> I don't think that the menu item is used enough to justify putting a keyboard shortcut on it in the first place.
[23:02:55] <motownavi> http://developer.apple.com/mac/library/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGUserInput/XHIGUserInput.html
[23:03:02] <motownavi> "You should provide keyboard shortcuts only for frequently used commands, not for every command. Presenting the user with too many keyboard shortcuts can be overwhelming and can make an application's user interface seem difficult to learn."
[23:03:49] <motownavi> Adding a keyboard shortcut for every command is a windowsism. Win apps are designed to be keyboard driven, from back in the day when not every computer had a mouse. Mac apps never were.
[23:04:02] * motownavi mutters and gets back to coding.
[23:04:20] <bob31> motownavi: actually mac guis are in part more keyboard controllable but then some parts less
[23:04:28] *** udp has quit IRC
[23:04:34] <bob31> motownavi: also I don't want Apple to cut my hands
[23:04:42] <motownavi> If you want complete keyboard control of the menus, just turn on accessibility
[23:04:45] *** cpu has joined #chromium
[23:04:45] *** ChanServ sets mode: +v cpu
[23:04:56] <bob31> this is the keyboard
[23:04:58] <bob31> http://www.everymac.com/images/other_images/apple-aluminum-keyboard.jpg
[23:05:18] <bob31> bigger
[23:05:18] <bob31> http://gizmodo.com/assets/resources/2007/07/imac-slim-keyboard-1.jpg
[23:05:32] <bob31> not quite but almost
[23:05:52] <motownavi> why bring up this keyboard?
[23:06:12] <bob31> as I have accidentally ordered the international one with Tilde to the left of Z instead of below Esc and then with narrow left-shift
[23:06:29] <bob31> motownavi: because noone seemed to believe me I have a modern keyboard with backspace _and_ delete
[23:06:44] <bob31> motownavi: was starting to believe it's a fake keyboard
[23:06:50] <motownavi> I don't see the word "backspace" anywhere in that image
[23:06:54] <andybons> bob31: where on that keyboard does it say backspace?
[23:07:19] <bob31> where it says delete it has backspace in internation version
[23:07:23] <bob31> let me find a pic
[23:07:26] <motownavi> really?
[23:07:30] <bob31> yeah
[23:07:35] <trungl-bot> Tree opened by estade at chromium dot org: Tree is open (please use trybots)
[23:07:36] <bob31> it's an icon though
[23:07:38] <bob31> not text
[23:07:40] <bob31> <--
[23:07:55] *** bmizerany has quit IRC
[23:08:00] <motownavi> then you read the icon as "backspace" when you plug the keyboard into a pc and read it as "delete" when you plug it into the mac
[23:08:03] <bob31> [+/=] [   <--   ]
[23:08:31] <pcgod> the HIG link above has "delete (or backspace)" and "forward delete"...
[23:08:32] <motownavi> Mac people pronounce "backspace" as "delete". One of the things you need to get used to when you switch platforms.
[23:08:37] <bob31> well it works as backspace in all editors, terminals and whatnot on Darwin 10.6.4
[23:08:41] <andybons> bob31: if both of you don't settle down i'm turning this car around and reverting the change.
[23:08:52] *** elihorne has joined #chromium
[23:08:52] *** ChanServ sets mode: +v elihorne
[23:09:21] <markmentovai> oh, good, ellie's here
[23:09:22] *** eseidel has joined #chromium
[23:09:31] <elihorne> allays
[23:09:41] <bob31> andybons: don't. we're halfway there and reacting on backspace is something I can live with
[23:09:49] <andybons> elihorne: where is your 'delete' key located?
[23:10:00] <elihorne> top right of the keyboard?
[23:10:39] <andybons> elihorne: so if you were to be asked "press command-shift-delete" which keys would you press in succession?
[23:10:54] <bob31> finally: http://i415.photobucket.com/albums/pp234/nullschleife/alukey-e1.jpg
[23:10:59] *** udp has joined #chromium
[23:11:07] <elihorne> err.. command then shift then delete?
[23:11:52] <motownavi> (I still fail to see the word backspace. ? is pronounced "delete".
[23:12:04] <bob31> in any case
[23:12:13] <stuartmorgan> motownavi, bob31: how about you each decide that you are right and have won the internets
[23:12:13] <bob31> the keycodes are different between those two
[23:12:15] <estade_laptop> oshima, stuartmorgan: ExtensionPrefStore test still leaking
[23:12:16] *** SkyLined has quit IRC
[23:12:16] <stuartmorgan> And then move on :P
[23:12:20] <cpu> I also want support for my keyboard: http://www.datahand.com/products/default.htm
[23:12:27] <motownavi> between the same key in the us vs international keybd?
[23:12:39] <stuartmorgan> estade_laptop: awesome :( I'm not sure what happened to pamg fixing that today
[23:12:40] <andybons> bob31: ok. then let's all agree that you shall live with it unless you would like to write a patch that allows the use of the forward delete key.
[23:12:41] <motownavi> cpu: where's the delete key on that?
[23:12:51] <elihorne> http://upload.wikimedia.org/wikipedia/commons/9/96/Apple-wireless-keyboard-aluminum-2007.jpg
[23:12:59] <estade_laptop> stuartmorgan: ok if i disable the test
[23:13:01] *** pathorn has joined #chromium
[23:13:01] *** ChanServ sets mode: +v pathorn
[23:13:06] <markmentovai> what's with the keyboard pr0n?
[23:13:07] <motownavi> or figure out how to make IB take the forward delete key as a shortcut
[23:13:07] <oshima> estade_laptop: k, let me check...
[23:13:14] <markmentovai> nice fn button
[23:13:22] <stuartmorgan> estade_laptop: we should be able to widen the suppressions
[23:13:22] <bob31> :)
[23:13:38] <estade_laptop> yea, we should, but we've tried and failed several times
[23:13:56] *** bmizerany has joined #chromium
[23:14:13] <estade_laptop> it's not a "real" leak yet since the pref store is only used by the unit test for now (right?)
[23:14:47] <rsesek> trungl: ping
[23:14:52] <bob31> andybons: let's switch to the more pressing issue and ignore delete keys
[23:14:56] <motownavi> bob31: just purchase http://www.daskeyboard.com/images/products/2.jpg
[23:15:04] <stuartmorgan> estade_laptop: maybe? I don't know if the next step has happened yet
[23:15:14] <bob31> I have to admit I don't get what all the hate is about
[23:15:33] <bob31> I didn't make the keyboard or layout. all defaults
[23:15:37] <stuartmorgan> estade_laptop: what's still showing leaks?
[23:16:05] <estade_laptop> http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/5111
[23:16:19] <motownavi> It's like calling the "option" key "alt". It's always been "delete" and "forward delete" on the Mac, and "backspace" and "delete" on the PC. Like talking in yards with the USers and meters with everyone else. A quick mental conversion and everyone's happy.
[23:16:25] *** rafaelw has joined #chromium
[23:16:25] *** ChanServ sets mode: +v rafaelw
[23:16:57] <stuartmorgan> motownavi: please, just stop
[23:16:58] <bob31> motownavi: hohum, let's just ingore the names. keycodes are different and names are like the wind and smoke
[23:16:58] *** Erkan_Yilmaz__ has joined #chromium
[23:17:11] <bob31> thanks
[23:17:30] <stuartmorgan> estade_laptop: we have a suppression that should cover that, we should just figure out what small mod it takes
[23:17:42] <stuartmorgan> estade_laptop: that will be less work than turning off the tests
[23:17:48] <oshima> estade_laptop: seems like i missed one more case.
[23:17:54] <estade_laptop> stuartmorgan: yea I get that... but I don't agree it will be less work
[23:18:08] <estade_laptop> given how long it takes to check
[23:18:09] <bob31> the real issue is: you start chromium and start page google.com has search input field focused. there the shortcut does not work but others do work (Cmd-T for example)
[23:18:16] <stuartmorgan> oshima: feel free to add extra stars liberally :)
[23:18:36] <bob31> andybons: again, thanks a million for the quick change
[23:19:38] <oshima> stuartmorgan: yes, that's what i'm doing:)
[23:19:56] *** rafaelw has left #chromium
[23:19:57] <estade_laptop> stuartmorgan, oshima : it looks as if this redness may be hiding other redness as well (from VisitedLinkEventsTest)
[23:20:00] <bob31> tested with 6.0.467.0 (52378)
[23:20:06] *** rafaelw has joined #chromium
[23:20:06] *** ChanServ sets mode: +v rafaelw
[23:20:12] *** Erkan_Yilmaz_ has quit IRC
[23:20:26] <andybons> bob31: you're welcome to file a bug about the input field stealing focus.
[23:20:48] *** General1337 has joined #chromium
[23:20:54] <elihorne> tards.
[23:20:56] *** elihorne has quit IRC
[23:21:05] <bob31> andybons: ok. and another one for default focus on clear button in the dialog? 2 issues?
[23:21:49] <rsesek> no there's deliberately not a default button
[23:21:54] <rsesek> if there is a default one, it would be on cancel
[23:21:55] <rsesek> not clear
[23:22:05] <oshima> stuartmorgan: http://codereview.chromium.org/3002002
[23:22:09] <rsesek> but esc maps to the cancel button
[23:22:36] <andybons> bob31: what rsesek said. just the one issue since the other one will probably just be closed as a WontFix
[23:22:46] <bob31> andybons: is that MacIsm?
[23:23:04] <andybons> bob31: huh?
[23:23:10] <bob31> andybons: HIG guides
[23:23:18] <bob31> andybons: no default focus on buttons
[23:23:21] <rohitrao> I think it's making it hard to perform really destructive actions :)
[23:23:31] <andybons> bob31: what rohitrao said.
[23:23:32] <stuartmorgan> oshima: thanks
[23:23:58] *** General13372 has quit IRC
[23:24:30] <oshima> estade_laptop: some of VisitedLinkEventsTest are excluded in chrome/test/data/valgrind/unit_tests.gtest.txt
[23:24:54] <andybons> bob31: like if my cat accidentally hits cmd-option-delete and then return as it walks over my keyboard, i lose all my cached porn.
[23:25:04] <bob31> depends on perspective and how you use the application. I may be in the minority, don't know. I'm used to open dialog + press enter
[23:25:07] <oshima> it says they sometime hangs.
[23:25:21] <bob31> andybons: I live with "browser history longer than 5 minutes is not needed"
[23:25:31] <bob31> andybons: not quite but
[23:25:33] *** rafaelw has left #chromium
[23:25:54] <bob31> incognito mode is not what I need though
[23:25:58] <bob31> I work like this
[23:26:12] <bob31> do some stuff, ......., clean history, do some other stuff
[23:26:30] <andybons> bob31: one bug.
[23:26:40] *** rafaelw has joined #chromium
[23:26:41] *** ChanServ sets mode: +v rafaelw
[23:26:43] <mpcomplete> shess: did your omnibox changes remove the icon from the URL bar, or is that my local changes?
[23:26:57] <andybons> mpcomplete: i see it too. the leftmost one?
[23:27:06] <mpcomplete> andybons: yes
[23:27:13] <andybons> mpcomplete: i see it
[23:27:13] <shess> mpcomplete: was a bug.  a fix is checked in.
[23:27:23] *** dumi has quit IRC
[23:27:27] <mpcomplete> shess: ok thanks
[23:27:31] <shess> sure
[23:27:32] *** rohitrao has quit IRC
[23:28:00] <bob31> andybons: don't worry, I will file the key eater bug only. thanks for the quick changes
[23:28:11] <bob31> andybons: reference 1404?
[23:28:15] *** chrisccoulson has quit IRC
[23:28:47] *** rafaelw has left #chromium
[23:28:52] <andybons> bob31: thanks. no need to reference 1404. leave as untriaged with no assignee. it will get picked up and triaged as appropriate
[23:29:19] *** rafaelw has joined #chromium
[23:29:19] *** ChanServ sets mode: +v rafaelw
[23:29:32] <akalin> lite protobufs strip unrecognized fields
[23:29:34] <akalin> that makes me sad :((
[23:29:52] *** rniwa has joined #chromium
[23:29:52] *** ChanServ sets mode: +v rniwa
[23:32:56] *** roc has joined #chromium
[23:33:03] *** Kunalagon has quit IRC
[23:33:35] <bob31> andybons: hope this is good enough: 49109
[23:34:07] *** Vanderhuge has quit IRC
[23:34:22] <andybons> bob31: good enough. thanks :)
[23:34:24] <bob31> oh, no way to re-edit the issue. I would have removed the unspecifed version info lines. sorry
[23:34:34] *** hrna has quit IRC
[23:35:48] *** Venom_X has quit IRC
[23:37:06] *** ROBOd has quit IRC
[23:37:35] <bob31> to contradict some of the HIG guide stuff: why does the Mac gui support Emacs line editing in text fields when it is so focused on simplicity and mouse-heavyness. the emacs line editing stuff is default and easier to use than with Gtk+ as it's not exclusive-or other keys
[23:37:39] *** Imperator_ has joined #chromium
[23:38:00] <bob31> I guess it's historical and hard to remove by now :)
[23:38:04] <bob31> maybe NS heritage
[23:38:16] <bob31> I love it
[23:39:48] <akalin> characterizing the mac gui as 'mouse-heavy' is erroneous
[23:40:52] *** zaspire has quit IRC
[23:42:01] <pkasting> rafaelw, estade, jam2: At some point this afternoon I'll have a .grd change to land.  Perhaps I should try to land without closing the tree?  It changes theme_resources instead of generated_resources, so it may not actually break the windows bots
[23:43:36] <rafaelw> pkasting: I don't have a strong feeling. I'll defer to your judgement.
[23:43:58] *** chrisccoulson has joined #chromium
[23:44:00] *** xji has joined #chromium
[23:44:00] *** ChanServ sets mode: +v xji
[23:44:02] <pkasting> I'm just trying to avoid locking up the tree for hours... I think on the whole it makes things worse instead of better
[23:44:51] *** janm has joined #chromium
[23:45:01] <evmar> pkasting: i wonder if you could foist your patch onto someone in a different time zone
[23:45:34] <rafaelw> +1 on not closing the tree for long periods. i just don't have a sense of how likely a theme_resources change is to cause trouble. i've had really bad luck with grd changes lately.
[23:46:01] <pkasting> evmar: The last couple days, I've checked in theme_resources.grd changes, and nothing's turned red even on the first build
[23:46:01] *** dmazzoni has joined #chromium
[23:46:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac Builder" from 52408: pkasting at chromium dot org, sergeyu at chromium dot org)
[23:46:15] <evmar> lol
[23:46:30] <pkasting> Not a .grd change!
[23:46:30] <evmar> (i'm sure it's unrelated, just funny anyway)
[23:46:32] <pkasting> It's probably me though :)
[23:46:34] <evmar> "what could possibly go wrong?"
[23:46:51] <ojan> evmar: i think the ui test failure might be your change
[23:47:05] <ojan> evmar: i say that only looking at the change description of course :)
[23:47:42] <evmar> which failure?
[23:47:48] <ojan> evmar: it could also be the webkit merge...but i did run the merge through the try bots
[23:47:49] <pkasting> Compile failure is me
[23:48:05] <ojan> evmar: http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.6%20Tests%20(dbg)(2) and http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Tests%20x64
[23:48:20] <ojan> evmar: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20x64/builds/4285/steps/ui_tests/logs/OpenDatabaseSyncInputs
[23:48:23] <pkasting> Dammit, the Mac trybot OKed this change!
[23:48:56] <ojan> evmar: that's likely related to your change, right?
[23:49:08] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree is closed (compile -> pkasting)
[23:49:19] <evmar> ojan: well, it's a worker test
[23:49:31] <evmar> as far as i can tell they're like "if (coinflip()) segfault()"
[23:49:40] <evmar> but yeah, it might be me, i wil poke at it
[23:49:42] * atwilson cries
[23:50:20] <pkasting> Making sure my fix for Mac compile failure is the right one
[23:50:25] <ojan> evmar: it's failed on three builders now (two linux, one mac), so i think it's probably a genuine failure
[23:50:56] <evmar> ojan: hm, i didn't actually touch this code
[23:51:04] <evmar> i only changed some helper binaries (convert_dict etc)
[23:51:12] <pkasting> Fix in
[23:51:17] <evmar> unless it's an older change of mine
[23:51:27] <pkasting> Waiting to ensure nothing else goes red, then will reopen
[23:51:43] <evmar> i made a change last thursday that could be related, but these tests only started failing today right?
[23:52:20] <ojan> evmar: yeah, they started failed just now...as in, with http://src.chromium.org/viewvc/chrome?view=rev&revision=52391
[23:52:44] *** peavey has quit IRC
[23:52:54] <evmar> but as you can see, i only modified stuff under tools/, not used by teh worker tests
[23:53:01] *** dmazzoni has quit IRC
[23:53:06] <evmar> i will attemtp to repro locally though
[23:53:34] *** bob31 has left #chromium
[23:54:31] *** peavey has joined #chromium
[23:54:32] <ojan> evmar: i would take responsibility, but this definitely pass the try server on mac and linux
[23:54:45] <ojan> evmar: and the webkit canaries for that matter
[23:55:11] <ojan> evmar: and, as best i can tell from the blamelists, that just leaves your change
[23:56:12] *** sergeyu has joined #chromium
[23:58:41] *** Erkan_Yilmaz_ has joined #chromium





top