[00:00:13] *** awong_ has joined #chromium [00:03:47] *** hclam has joined #chromium [00:07:07] *** rohitrao has quit IRC [00:07:12] *** rohitrao has joined #chromium [00:07:12] *** ChanServ sets mode: +v rohitrao [00:08:37] *** eseidel has joined #chromium [00:09:15] *** viro101 has quit IRC [00:11:31] *** shepazutoo has quit IRC [00:11:44] *** Buglouse has quit IRC [00:11:58] *** shepazu has joined #chromium [00:12:02] *** viro101 has joined #chromium [00:14:02] *** abarth has joined #chromium [00:14:02] *** ChanServ sets mode: +v abarth [00:18:13] <motownavi> heads-up, I have a grd change I need to land [00:19:34] *** sbyer has joined #chromium [00:19:34] *** ChanServ sets mode: +v sbyer [00:20:02] <pkasting> I do too! [00:20:10] <pkasting> Maybe we can land them simultaneously [00:21:31] <motownavi> pkasting: are you ready? [00:21:52] *** rubenbb has quit IRC [00:21:53] <motownavi> well... which grd [00:22:09] <motownavi> I'm generated_resources.grd [00:22:25] <pkasting> motownavi: My checkout is finishing syncing [00:22:38] <pkasting> motownavi: I'm modifying basically all the other .grds (but not that one) [00:22:54] <thakis> i'm adding a grd file [00:22:59] <thakis> does that count as grd change? [00:23:15] *** viro101 has quit IRC [00:23:27] * motownavi chuckles at the havoc to be wreaked [00:24:12] <pkasting> I don't think it does [00:24:21] <cbentzel> tonyg-cr: This seems like a good time for me to go home :) [00:24:22] <pkasting> Because I don't think Windows gets confused on it and needs 2 builds [00:24:47] <tonyg-cr> cbentzel: have a good one :) [00:25:03] <pkasting> tonyg-cr: Is now a good time to close the tree for .grd changes? [00:25:40] <tonyg-cr> pkasting: yeah, things have actually settled down [00:25:47] <tonyg-cr> go for it :) [00:26:00] *** cbentzel has quit IRC [00:26:35] <pkasting> motownavi: I closed the tree [00:26:42] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree closed for .grd landings (reliability -> pkasting) [00:26:51] <pkasting> motownavi: But perhaps we should wait until the builders catch up some? [00:27:38] <pkasting> I guess it depends on how long the tree can stay closed [00:27:44] <motownavi> I'm ok with taking a breather [00:28:27] <pkasting> If we wait until the win dbg builder is ready that'll be about a half hour [00:28:49] <pkasting> And then it'll be roughly another 45 minutes after that when everything is fully cycled through and we know the results [00:29:19] <motownavi> :( we really need to fix this grd thing [00:29:39] <pkasting> We can shave 15 minutes off that by landing now, at the cost of possibly overlooking bustage from the other patches that build with us [00:29:54] * motownavi shrugs [00:29:58] <pkasting> However, those look harmless [00:30:03] *** cbentzel has joined #chromium [00:30:17] <pkasting> Let's go ahead and land, you ready to go? [00:30:19] <motownavi> shall we break things? [00:30:29] <motownavi> who first? [00:30:32] <pkasting> Both at once [00:30:36] <pkasting> Landing now [00:31:06] <motownavi> damn out of date [00:31:07] <motownavi> updating... [00:31:15] <pkasting> :( [00:31:20] <pkasting> You're going to miss the window [00:31:24] <motownavi> dammit [00:31:50] <pkasting> Well no, you still have like 2 minutes [00:31:54] <pkasting> Until the dbg builder cycles [00:31:56] <motownavi> working on it [00:32:20] <motownavi> ok, 51908 [00:34:08] *** markmentovai has quit IRC [00:34:47] <pkasting> It looks like the current dbg cycle didn't pick up either of our changes [00:35:14] <motownavi> huh [00:36:45] <thakis> dhollowa: chrome/browser/password_manager/password_store_mac.cc if you ahven't seen it [00:36:50] <thakis> dunno how useful that is for you [00:37:49] *** awidegreen has quit IRC [00:39:00] *** kinnetica has quit IRC [00:39:40] *** DBO has joined #chromium [00:42:47] *** tonikitoo has quit IRC [00:43:16] *** bers has quit IRC [00:44:08] *** fta_ has joined #chromium [00:44:23] <dhollowa> thakis: thanks, i'll take a look. [00:44:23] *** awolfson has quit IRC [00:45:27] *** fta has quit IRC [00:45:30] *** fta_ is now known as fta [00:46:27] *** thakis_ has quit IRC [00:46:38] *** aroben has quit IRC [00:51:08] <motownavi> ChromiumOS builder failure seems like a flake [00:54:21] *** asargent has joined #chromium [00:54:22] *** ChanServ sets mode: +v asargent [00:57:57] <pkasting> dhollowa: Looks like your commit broke some tests [00:58:24] <pkasting> dhollowa: PersonalDataManagerTest.SetEmptyProfile did not complete [00:58:43] <dhollowa> pkasting: looking [01:01:21] <dhollowa> pkasting: yes, mine. will revert. [01:02:27] <awong> sheriffs, after pkasting's grd change is done...mind if I attempt a massive webkit roll? :( [01:02:58] *** [Nef] has quit IRC [01:03:11] *** mrossetti has quit IRC [01:03:27] <cbentzel> awong: Probably OK - but I'm on EDT and may be taking off before the fallout happens [01:03:41] <tonyg-cr> awong: i'll be around [01:03:45] *** brettw has joined #chromium [01:03:45] *** ChanServ sets mode: +v brettw [01:03:49] <tonyg-cr> seems like as good a time as any [01:04:21] <tonyg-cr> awong: do you already have a revision in mind? [01:04:22] *** mrossetti has joined #chromium [01:04:22] *** ChanServ sets mode: +v mrossetti [01:04:27] <awong> yeah...that was my though. It's been passing the try servers, and looks pretty good on the canaires, so I think things will be fine. But it'as also 174 revisions. [01:04:31] <awong> yes [01:04:45] *** mrossetti has quit IRC [01:05:16] <awong> 62670 -> 62844 http://codereview.chromium.org/2933004/show [01:05:36] <awong> Any point in between has issues with changes in webkit refcounts. [01:07:09] <trungl> exciting [01:07:49] <dhollowa> pkasting: my revert is in. [01:08:04] <pkasting> Thanks [01:08:25] *** kinnetica has joined #chromium [01:09:07] <andybons> akalin: ping [01:09:21] *** rohitrao_ has joined #chromium [01:09:22] *** ChanServ sets mode: +v rohitrao_ [01:09:33] <pkasting> cbentzel, tonyg-cr: Vista UI tests started failing just before we closed the tree and I haven't been able to track down a cause [01:09:59] <cbentzel> pkasting: OK, looking, thanks for heads up [01:10:21] *** Venom_X has quit IRC [01:12:12] <cbentzel> brettw: Do you think the Vista UI test failures are due to your PPAPI pull? [01:13:19] *** rohitrao has quit IRC [01:13:19] *** rohitrao_ is now known as rohitrao [01:13:38] <pkasting> WTF is "KeyError: 'Duplicate keys: [32768, 32767]'" [01:13:47] <pkasting> (Linux chromeos compile failure) [01:13:53] <brettw> cbentzel, I'm doing a build of the UI tests now [01:14:08] <brettw> it's failing in some non-Pepper plugin, so I would be surprised [01:14:39] <evmar> pkasting, tony^work: it is the .rc packer complaining about a key occurring twice [01:14:44] <brettw> LayoutPluginTester.UnloadNoCrash is a regular plugin which should have totally independent code [01:14:59] <evmar> pkasting, tony^work: i wonder if we have a 16-bit item id and we're overflowing or something? [01:14:59] <brettw> anyway, I'm looking [01:15:17] <cbentzel> brettw: Thanks. [01:15:56] <pkasting> evmar: Probably me, probably some sort of bad merge resolve. Let me try to find it. [01:16:12] <pkasting> I like how many things go wrong with the tree simultaneously [01:16:13] <evmar> what's strange is that the numbers it lists are different [01:16:23] <pkasting> Maybe that means it's happening twice [01:16:39] <pkasting> tony^work suggests duplicate IDR_xxx in the same file [01:17:02] *** cmasone has quit IRC [01:17:24] <pkasting> I wish I could get any data on which ID is supposedly a dupe [01:17:29] <pkasting> Or even which file [01:17:34] *** rafaelw has quit IRC [01:24:30] *** dhg has joined #chromium [01:24:30] *** ChanServ sets mode: +v dhg [01:25:32] <tony^work> hmm, I bet it's an ID that's supposed to be behind an <if> getting included twice [01:26:43] *** rsesek has quit IRC [01:27:30] <pkasting> tony^work: Yeah, but for the life of me I can't find it [01:27:44] <tony^work> e.g., something behind a toolkit_views <if>? [01:28:02] *** cbentzel has quit IRC [01:28:42] <pkasting> It's breaking when chromeos=1 [01:28:54] <pkasting> So I looked through the files I touched for everything behind that [01:28:58] <pkasting> And can't find any dupes [01:29:30] *** cmasone has joined #chromium [01:29:30] *** ChanServ sets mode: +v cmasone [01:29:40] <jhawkins> win trybot has 29 pending. awesome [01:31:00] <dhg> pkasting: i'm a little late to the party... but my win trybot complained about this: c:\b\slave\win\build\src\build\Debug\obj\global_intermediate\chrome\grit/google_chrome_strings.h(95) : warning C4005: 'IDS_TRY_TOAST_WHY' : macro redefinition c:\b\slave\win\build\src\build\Debug\obj\global_intermediate\chrome\grit/chromium_strings.h(94) : see previous definition of 'IDS_TRY_TOAST_WHY' [01:31:04] <dhg> ignore if thats not useful [01:31:21] <dhg> chrome vs chromium? [01:31:37] <pkasting> dhg: I haven't touched the strings files though [01:31:43] <dhg> no idea. [01:31:49] <dhg> just wonderin [01:32:11] <pkasting> dhg: And something is supposed to conditionally include only one of those, I don't know how all that works [01:32:49] <dhg> pkasting: me either... [01:37:13] <pkasting> ARGH [01:37:42] <tony^work> I'm trying to repro locally, I think it'll be easy to find if I open up the generated header [01:38:37] <pkasting> So we have chromeos compile failures that are probably me but not sure how to track down, unit test failures that were dhollowa and he reverted, ui test failures that no one is sure about, mac test failures that look to be flakiness [01:38:43] *** dglazkov has quit IRC [01:38:46] <pkasting> Did I miss anything? [01:40:15] <motownavi> no i think you're right [01:40:22] <motownavi> I think I'm clear, so I'm getting dinner. [01:41:28] *** RT|Chatzilla has joined #chromium [01:41:30] <tony^work> pkasting: no duplicate, it's a collision between ids in different grd files [01:41:34] <tony^work> I'm making a fix [01:41:39] <pkasting> How can that happen? [01:41:59] *** chronarion has quit IRC [01:42:15] <mpcomplete> linux/mac people: is there some cross-platform abstraction for GdkPixbuf or NSImage? [01:42:43] <jam2> tony^work: nice catch [01:42:53] <jam2> i dont understand how this can happen either [01:43:10] <tony^work> grit pseudo randomly generates an ID for each resource [01:43:16] *** rubenbb has joined #chromium [01:43:24] <tony^work> but we invoke grit on lots of different files that don't know about each other [01:43:39] <tony^work> now we have a collision [01:43:43] *** lalalalilili has left #chromium [01:43:57] <tony^work> so, grit allows you to set what the start ID is for each file [01:44:06] <tony^work> but we would have to manually keep track of which grd file is using which id [01:44:24] <jam2> ugh [01:44:25] <tony^work> but maybe it's time to do that [01:44:27] <motownavi> mpcomplete: Nope. We'll sometimes throw around SkBitmaps and convert them... [01:45:16] <pkasting> So why did this start now? Because Avi added a couple strings and pushed us over a limit? [01:45:26] <tony^work> I don't know, bad luck? [01:45:49] <motownavi> I switched out strings. Removed one for each one I added. [01:45:51] <tony^work> I don't remember how the pseudo random works, maybe reordering strings changed the numbering [01:45:52] <jhawkins> maruel, nsylvain: any idea what's going on with the win try bots? [01:46:07] <thakis> awong: chromium will need rebaselining after https://bugs.webkit.org/attachment.cgi?id=60984&action=review [01:46:07] <tony^work> anyway, I have a working build. I'll tbr a fix [01:46:10] <thakis> awong: heads up [01:46:13] <pkasting> Thanks [01:46:22] <motownavi> oh, I did add one, sorry [01:47:15] *** fta_ has joined #chromium [01:48:39] *** fta has quit IRC [01:48:45] *** fta_ is now known as fta [01:49:38] *** AaronMT has joined #chromium [01:50:04] <pkasting> brettw: Did you find anything conclusive about those UI test failures, or are you still investigating? [01:51:19] <pkasting> tony^work: I suspect we should go through our .grds and set an explicit start value on all of them, with plenty of space between each, to prevent this occurring again. [01:51:29] *** Martijnc has quit IRC [01:51:33] <pkasting> tony^work: Should I file a bug? You want to tackle this? [01:51:52] <brettw> pkasting, it took me forever to get a compile, and when I ran that one test, it worked. Now I'm running them all, but it's still going. [01:52:06] <thakis> awong: there are 19 pending patches in the commit queue tho, so it'll be a while until it's in [01:52:10] *** eseidel has quit IRC [01:52:43] <brettw> my local UI test run seems to be hung on a link doctor test, anybody seen that before? [01:53:01] <shess> rohitrao: had some responses to your comments queued up, but was thinking of waiting until you finish? WDYT? [01:53:22] <brettw> nevermind, seems to be unstuck [01:53:38] <shess> rohitrao: BTW, you should see the _next_ CL. Ugh. But if it weren't ugly, it wouldn't need the love... [01:54:31] <brettw> it seems the worker tests are marked as fails, but then each one times out [01:54:35] <brettw> and it takes FOREVER to run [01:54:35] <tony^work> pkasting: I'm filing a bug now [01:54:44] <pkasting> Ah, OK, I'll stop writing up mine :) [01:55:15] *** abarth has quit IRC [01:55:41] <pkasting> tonyg-cr: The Mac tests seem to be extremely flaky. There are a lot of red spots popping up and then disappearing for browser tests, ui tests, etc. [01:56:09] <andybons> maruel: ping [01:56:17] <tonyg-cr> i'll see if i can pin down any of the flakes [01:56:40] <tonyg-cr> in general, the whole tree has been much more flaky this time around than my last sheriff round [01:56:47] <awong> thakis: okay, thanks for the heads up. Now I got to figure out how ot make the rebaselining tool work again :-/ [01:56:56] *** rohitrao has quit IRC [01:57:01] *** rohitrao has joined #chromium [01:57:01] *** ChanServ sets mode: +v rohitrao [01:57:31] <andybons> tonyg-cr, pkasting: if they're failing only on 10.6 there's a bug to track it here: http://crbug.com/48546 [01:57:54] <andybons> jrg is extending the timeout period but i need to see if the bots are running out of memory and there's a leak somewhere [01:58:11] <tonyg-cr> andybons: yes, it is all 10.6 [01:58:14] <pkasting> andybons: That indeed looks like the main problem [01:59:02] *** AaronMT_ has joined #chromium [01:59:28] <brettw> pkasting: I gave up running the UI tests locally, the worker stuff was taking too long. I'm doing a release build now but that will take a while to complete. [01:59:47] <pkasting> brettw: As long as someone is still investigating, I'm happy [01:59:59] *** AaronMT has quit IRC [01:59:59] *** AaronMT_ is now known as AaronMT [02:00:04] <pkasting> brettw: The failure is weird, it's very consistent but I don't see why it would have started happening [02:00:05] *** rsleevi has joined #chromium [02:00:06] <maruel> andybons: pong [02:00:35] <andybons> maruel: can you add me to valentine so that i can get into the buildbots? [02:00:38] *** malavv has quit IRC [02:00:40] *** abarth has joined #chromium [02:00:40] *** ChanServ sets mode: +v abarth [02:00:59] <maruel> andybons: you're frustrated and want to kill them all? :) [02:01:14] <andybons> maruel: haha. if only [02:01:50] * awong is developing a dislike for ietestcenter [02:02:20] <dcheng> awong: But it's fair and balanced! [02:02:26] <jam2> lol [02:02:41] <awong> it's also getting added in huge swaths and breakin' ma canaries! [02:04:30] *** chrisccoulson_ has quit IRC [02:06:59] *** dmaclach has quit IRC [02:10:37] *** DBO has quit IRC [02:13:05] <tonyg-cr> pkasting, tony^work: i have to sign off for a few minutes, could one of you reopen the tree if 51913 works? [02:13:29] <tony^work> tonyg-cr: sure, I can do that [02:14:59] *** erikkay has quit IRC [02:15:00] <brettw> ananta, jam says you have a fix for the vista UI test failure? [02:15:36] <brettw> ananta, oh, that was yesterday, it looks like that problem is back [02:16:15] <jam2> ananta's change was http://codereview.chromium.org/2897002/show, but the problem it solves is the same one that's occuring now. he said he thinks it's because something is leaking handles on the bot. they key is "[2704:4756:2091056921:FATAL:webplugin_delegate_impl_win.cc(526)] Check failed: 0 != plugin_name_atom. " [02:17:58] *** xji has joined #chromium [02:17:58] *** ChanServ sets mode: +v xji [02:19:55] *** jrmuizel has joined #chromium [02:19:55] <jam2> i believe this is the same bug that ananta fixed, but in a different place in teh file [02:21:35] *** awolfson has joined #chromium [02:22:12] *** MikeSmithW3C has joined #chromium [02:22:32] *** tonyg-cr has quit IRC [02:23:19] *** AaronMT has quit IRC [02:30:08] *** Precea[BNC] is now known as Precea [02:32:28] <dhg> think the tree can open yet? seems that the chromeos one passed [02:32:39] <tony^work> I wanted some more green [02:33:07] <tony^work> the ui tests are almost done on 3 red bots [02:33:21] *** asargent has quit IRC [02:34:42] *** jrmuizel has left #chromium [02:35:30] *** paulgrous has joined #chromium [02:36:00] <xji> how to read test results in trybot? for example: http://build.chromium.org/buildbot/try-server/builders/layout_mac/builds/1892 lists one failed test: struct-use-01-t.svg, but which file/png in http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2FW3C-SVG-1.1%2Fstruct-use-01-t.svg are the acutal layout results in mac? [02:37:18] *** chronarion has joined #chromium [02:37:18] *** ChanServ sets mode: +v chronarion [02:37:45] * thakis looks at tree in horror [02:38:24] <chronarion> my god, it's full of red [02:39:40] <tony^work> bah, my grd change requires a force build [02:40:31] *** kinnetica has quit IRC [02:41:01] <awong> tony^work: so I'm guessing we aren't opening the tree anytime soon? [02:41:22] <pkasting> Sad LOL [02:41:30] *** kinnetica has joined #chromium [02:41:32] <pkasting> We are so hosed with these .grd changes [02:41:38] <awong> no kidding. [02:42:05] <pkasting> I propose we give $10000 to the person who fixes this [02:42:12] <pkasting> Maybe that would be sufficient motivation [02:42:54] <awong> pkasting: make that 10k + no sheriff duty for a year :P [02:43:26] <dcheng> I thought someone made a tenative patch to help alleviate the grd madness. [02:43:38] <awong> okay. FYI, I'm going to try and land the webkit roll late tonight. [02:43:54] *** beng_ has quit IRC [02:44:02] *** AaronMT has joined #chromium [02:44:25] <awong> I'm guessing most people online right now won't care, but if anyone objects, let me know. I'm going to target like 9pm or 10pm. [02:44:26] <jam2> pkasting: peer bonus from the whole team would be > 10K ;) [02:44:53] <pkasting> Linus has in the past suggested limiting peer bonus bombs to ~10 people [02:45:03] <jam2> haha we're too big [02:45:09] <pkasting> But for this perhaps we could have an exception... [02:45:26] *** eseidel has joined #chromium [02:45:58] <tony^work> hmm, maybe someone should make a windows make generator for gyp [02:46:00] <awong> I betcha the time saves is worth more than 10k in developer time a day. [02:46:02] <tony^work> that the buildbots can use [02:46:58] *** pgrous_ has joined #chromium [02:47:49] *** bandu has joined #chromium [02:49:19] *** tama has joined #chromium [02:49:44] <dcheng> I could have sworn someone ported the fix in http://code.google.com/p/gyp/source/detail?r=762 over to the MSVS generator. [02:50:02] <dcheng> They were asking about how to upload stuff not in the chromium depot to codereview. [02:50:03] *** coyo|pingout has quit IRC [02:51:00] <thakis> pkasting: jochen__ had a patch for this [02:51:06] <thakis> not sure if it works tho :-P [02:51:54] *** kinnetica has quit IRC [02:52:27] *** bandu has quit IRC [02:53:02] *** AaronMT has quit IRC [02:53:38] *** paulgrous has quit IRC [02:53:39] *** pgrous_ is now known as pgrous [02:53:42] *** eseidel has quit IRC [02:53:53] *** paulgrous has joined #chromium [02:55:32] *** fta_ has joined #chromium [02:56:35] *** hbono has joined #chromium [02:56:57] *** fta has quit IRC [02:56:59] *** fta_ is now known as fta [02:57:51] *** tonyg-cr has joined #chromium [02:57:52] *** ChanServ sets mode: +v tonyg-cr [02:59:14] *** fbarchard has quit IRC [02:59:42] *** dmaclach has joined #chromium [02:59:44] *** fbarchard has joined #chromium [03:01:03] *** lalalalilili has joined #chromium [03:02:59] <jam2> so is anyone doing a clean build? [03:03:11] <tony^work> oh, dbg is done [03:03:16] <tony^work> I'll poke the dbg test slaves [03:03:28] <jam2> thanks [03:03:57] <jam2> will another check in also force this? i hve a harmless pepper change ;) [03:04:18] <tony^work> sure, but it's done now [03:05:13] *** paulgrous has quit IRC [03:05:29] *** paulgrous has joined #chromium [03:07:08] *** dmaclach has quit IRC [03:07:11] <eroman> anyone else getting 502s when trying to sync? (on native_client) [03:07:27] <jam2> eroman: i was getting strange errors when tryign to commit toa nother project on google code [03:07:31] <jam2> i had to keep retrying [03:07:56] <jam2> tony^work: i'm confused, so is it fine to check in? [03:07:56] <eroman> jam2: could be that. altho gclient has been retrying for the past 2 minutes :) [03:07:56] <rsleevi> eroman: I was having that problem earlier getting SVN logs, and eventually kept retrying [03:08:17] <jam2> tony^work: nm i see your force builds [03:09:07] <tony^work> so the bots are having a hard time updating too [03:09:12] <tony^work> because of the 502 errors from svn [03:09:24] <tony^work> which is delaying the tests from running and the tree from greening [03:12:38] *** tedoc2000 has quit IRC [03:15:27] *** ojan is now known as ojan_away [03:15:46] *** pkasting is now known as TF2_Heavy [03:15:52] <TF2_Heavy> CART MOVES WRONG WAY! [03:16:29] *** thakis is now known as pkasting [03:16:31] <pkasting> woot [03:16:46] *** pkasting is now known as thakis [03:17:45] *** vbendeb has joined #chromium [03:17:45] *** ChanServ sets mode: +v vbendeb [03:17:46] <TF2_Heavy> thakis: THE BURNING YOU FEEL? IT IS SHAME. [03:17:52] *** vbendeb has quit IRC [03:19:05] *** feldstein has joined #chromium [03:19:05] *** ChanServ sets mode: +v feldstein [03:21:14] <maruel> pkasting is in shape today [03:21:26] <maruel> it's been a while YOU HAVEN'T FELT ALL CAPS [03:22:54] <TF2_Heavy> KEEP CRYING, COWARDS! [03:22:59] <TF2_Heavy> NOW IS COWARD KILLING TIME! [03:23:10] *** cbentzel has joined #chromium [03:24:22] <cbentzel> tonyg-cr: Need help with anything (just back online, see a lot of red) [03:25:07] <TF2_Heavy> cbentzel: ENGINEER IS CREDIT TO TEAM! [03:26:00] *** pgrous has quit IRC [03:26:06] *** pgrous__ has joined #chromium [03:26:59] <tony^work> cbentzel: tonyg left and I volunteered to watch the tree [03:27:15] <tony^work> but it looks like google code is down so the bots can't update [03:27:21] <tony^work> if they could update, I think the tree would go green [03:28:32] <andybons> cbentzel, tony^work: it's 9:30 here. i'm not getting anywhere with the bots. will follow up when mentovai is next to me tomorrow. [03:28:46] <andybons> the 10.6 bots, that is. [03:28:56] <cbentzel> andybons: It's 9:30 here as well. Thanks for looking at the 10.6 bots [03:29:48] <andybons> cbentzel: ah. you're in cambridge. i was there when it was a lowly 6 or so engineers [03:29:57] <TF2_Heavy> ENGINEER IS SPY! [03:30:07] *** awolfson has quit IRC [03:30:50] <trungl-bot> Tree closed by tony at chromium dot org (:tony^work): tree closed (code.google.com being slow; bots should go green) [03:31:07] <tonyg-cr> tony^work, cbentzel: i'm back online now ? so basically there is nothing we can do but wait for code.google.com? [03:31:13] <tony^work> I guess [03:31:27] <tony^work> I think I'm going to go home since I'm not sure there's anything to be done other than wait [03:31:40] <cbentzel> tony^work: Is it svn specific issues with code.google.com? [03:31:42] <tony^work> things seem to be going now [03:31:45] <tonyg-cr> thanks for helping out w/ those grd changes [03:32:10] <TF2_Heavy> tony^work: WE SEND ITSY-BITSY CART BACK HOME! [03:32:20] <tony^work> if you scroll up, you can see eroman complaining about svn timing out too [03:32:42] <tony^work> pkasting: your game references are over my head [03:32:43] <tony^work> :) [03:32:48] <TF2_Heavy> IS NOT POSSIBLE! [03:32:56] *** bryner has quit IRC [03:33:03] *** TF2_Heavy is now known as pkasting [03:33:04] <eroman> code.google.com is working again for me now [03:33:07] <eroman> (btw) [03:33:09] <jamesr> SHERIFF IS SPY! [03:33:14] <pkasting> What, no one plays TF2? [03:33:15] <pkasting> Sigh [03:33:19] <tony^work> eroman: yeah, the bots are getting past the update step as well [03:33:39] <rsleevi> pkasting: It's ok, I appreciated the references. [03:33:50] <pkasting> admittedly the Heavy is a little awkward to work in unless we start talking about sandwiches. [03:34:26] <pkasting> Sigh, I guess I'm going home too [03:34:28] <andybons> SCANWICHES (http://scanwiches.com/) [03:34:38] <cbentzel> pkasting: That's one of the games on the Orange Box not named Portal, right? [03:34:45] <pkasting> cbentzel: Yes [03:34:49] *** dpranke has quit IRC [03:34:53] <jamesr> woah [03:35:38] *** rohitrao_ has joined #chromium [03:35:38] *** ChanServ sets mode: +v rohitrao_ [03:36:07] <andybons> rohitrao_: fix 48546 for me. kthxbai [03:36:46] <rohitrao_> ew [03:37:11] <andybons> rohitrao_: srsly. [03:37:27] <rohitrao_> oh, my startup_tests were failing with that error yesterday [03:37:39] <andybons> rohitrao_: locally!? [03:37:52] <rohitrao_> I saw "Check failed: g_shutdown_pipe_write_fd != -1" [03:38:13] <andybons> rohitrao_: can you repro it locally now? [03:39:11] *** rolandsteiner has joined #chromium [03:39:34] *** rohitrao has quit IRC [03:39:35] *** rohitrao_ is now known as rohitrao [03:41:09] <cbentzel> brettw: Any insight into why Linux x64 is having problems building third_party/ppapi/tests/test_case.cc (and where the test_case.cc is being generated in the first place?) [03:41:45] <rohitrao> andybons: running tests now. I think chromium was crashing once or twice across a thousand launches [03:41:52] *** slightlyoff has joined #chromium [03:41:53] *** ChanServ sets mode: +v slightlyoff [03:42:39] <andybons> rohitrao: right. that's what we're seeing. not sure if we're in an OOM issue or if the deadline for IPC receives needs to be increased [03:43:07] <rohitrao> wait, maybe not [03:43:37] <rohitrao> it failed pretty consistently in ShutdownTest.SimpleSessionEnding [03:43:44] <rohitrao> yeah, I think I can reproduce [03:43:55] <pathorn> andybons: are you talking about the errors that have been happening for weeks? [03:43:57] <pathorn> or is this new [03:45:08] <pathorn> the 10.6 bot sometimes hangs on something as simple as AppendTab [03:45:26] <andybons> pathorn: yes. i got assigned this bug (and for perfectly good reason) by cbentzel because it was failing within Extension tests, but as they keep getting suppressed the error pops up elsewhere. it's simply that the browser tests consist of a lot of extensions tests [03:45:57] <pathorn> I also have http://crbug.com/46609 [03:46:24] <pathorn> might make sense to merge the two [03:46:28] *** tama has quit IRC [03:46:35] <rohitrao> how do I run startup_tests single-process? [03:46:49] <pathorn> I think it passes on some command line flags [03:46:52] <pathorn> such as --user-data-dir [03:46:54] <andybons> pathorn: yeah. [03:47:04] <pathorn> but there might be a whitelist somewhere [03:47:40] *** leeight has joined #chromium [03:47:45] *** leeight has left #chromium [03:49:30] <rohitrao> oh, of course this is a release build, so I have no symbols [03:50:34] *** bandu has joined #chromium [03:54:10] *** Gina has quit IRC [03:56:34] <pathorn> I found a reproducable null pointer crash in webkit on dev channel windows [03:56:43] <pathorn> happens every time I double-click a code review comment [03:56:55] <jamesr> file a bug? [03:56:56] <pathorn> happens in trunk as of last night too [03:57:08] <rohitrao> does it happen in a webkit nightly build? [03:57:19] <pathorn> good point [03:58:40] *** csilv has left #chromium [04:00:19] <jam2> open the tree? [04:01:02] *** MikeSmithW3C has quit IRC [04:02:06] *** hinoka|away has quit IRC [04:04:27] *** paulgrous has quit IRC [04:04:41] <cbentzel> jam2: I'm going to go to sleep, so I'll let tonyg make the call [04:04:44] *** paulgrous has joined #chromium [04:04:55] <jam2> cbentze: sounds good [04:07:17] *** leeight has joined #chromium [04:07:20] *** leeight has left #chromium [04:08:05] <rohitrao> does anyone know how to run startup_tests in gdb? :) [04:10:19] *** cbentzel has quit IRC [04:14:04] *** stuartmorgan has quit IRC [04:14:22] *** jshin has quit IRC [04:14:27] *** bobthemilkman has joined #chromium [04:14:45] *** yutak_home has quit IRC [04:15:55] <tonyg-cr> jam2: you have a change that you think is pretty safe? maybe we should let one in to make sure all of the builders are at work [04:16:10] *** FullFlannelJacke has quit IRC [04:16:42] *** abarth has quit IRC [04:17:25] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): tree open (recovering, please don't land anything risky) [04:17:37] *** abarth has joined #chromium [04:18:25] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open (recovering, please don't land anything risky) [04:24:12] <pathorn> rohitrao: what about "ulimit -c unlimited" to generate a core dump? [04:26:29] <trungl-bot> Tree closed by tonyg at google dot com (:tonyg-cr): Tree is closed (don't want to get too far behind) [04:26:35] *** feldstein has quit IRC [04:28:34] *** abarth has joined #chromium [04:28:35] *** ChanServ sets mode: +v abarth [04:30:31] *** FullFlannelJacke has joined #chromium [04:30:53] *** abarth has quit IRC [04:35:58] *** zer0her0_ has joined #chromium [04:38:30] <tonyg-cr> stumped by the linux net_unittests failure, doesn't seem related to any of the changes and hasn't been flaky [04:38:40] <jam2> i was just looking at it [04:38:49] *** zer0her0 has quit IRC [04:38:59] <jam2> i wonder if it's reading a corrupt cache? [04:39:19] <jam2> dont' know enough about that code tho [04:39:42] <tonyg-cr> me either, it would surprise me if the tests carried cache state on disk in between runs though [04:41:10] *** Precea is now known as Precea[BNC] [04:41:45] *** slightlyoff has quit IRC [04:44:05] *** Weems has quit IRC [04:48:07] *** himikov has quit IRC [04:53:31] *** rohitrao has quit IRC [04:54:33] *** Beetny has joined #chromium [04:56:36] *** Beetny` has quit IRC [04:56:50] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open (nothing too risky please) [05:01:01] *** jamesr has quit IRC [05:07:16] *** bryner has joined #chromium [05:08:41] *** bryner_ has joined #chromium [05:10:10] *** fta_ has joined #chromium [05:11:19] *** fta has quit IRC [05:11:22] *** fta_ is now known as fta [05:12:46] *** kenneth_reitz has joined #chromium [05:13:07] *** bryner has quit IRC [05:13:08] *** bryner_ is now known as bryner [05:14:01] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open [05:22:59] *** pathorn has quit IRC [05:23:26] *** pathorn1 has joined #chromium [05:23:26] *** ChanServ sets mode: +v pathorn1 [05:24:27] *** pathorn has joined #chromium [05:24:51] *** dglazkov has joined #chromium [05:24:52] *** ChanServ sets mode: +v dglazkov [05:26:14] <dhollowa> any mac folks out there available for small review? [05:28:45] *** MikeSmithW3C has joined #chromium [05:29:23] <tonyg-cr> yay! the tree is all green (except for the webkit test which has been suppressed upstream) [05:29:30] <tonyg-cr> i'm signing off, be careful w/ the tree [05:31:11] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open (sleeping sheriffs, be gentle with the tree) [05:32:16] *** tonyg-cr has quit IRC [05:33:05] *** Buglouse has joined #chromium [05:34:11] <trungl> dhollowa: maybe? [05:34:15] *** bobthemilkman has quit IRC [05:35:24] *** morrita has quit IRC [05:40:16] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Vista (dbg)" from 51924: bryner at chromium dot org, eroman at chromium dot org (:eroman), pkasting at chromium dot org) [05:43:17] <trungl-bot> Tree opened by eroman at chromium dot org (:eroman): Tree is open (sleeping sheriffs, be gentle with the tree) [05:43:39] <bryner> eroman: do you know what's up with net_unittests? [05:43:44] <eroman> ya [05:44:00] <eroman> i reopened, gonna commit a patch for the failure [05:44:17] <bryner> ok, cool [05:45:11] <bryner> i assume it was a pre-existing problem, since it happened before your last checkin? [05:46:34] <eroman> bryner: crbug.com/48588 [05:47:36] <bryner> k [05:48:17] <andybons> hbono: thanks for catching that leak, btw [05:49:42] *** andybons has quit IRC [05:54:42] <pkasting> Any Linux ChromeOS/Linux views people around? [05:55:06] <pkasting> The commit I landed breaks a unit test and I have no idea why; I think it might be because the tests get run in a different order [05:55:32] <pkasting> I'd really like someone to run it in a debugger and see what's up, as the stack trace isn't very useful to me on Windows [05:55:52] *** eseidel has joined #chromium [05:57:18] <pkasting> However, if no one's around, I'll have to revert myself (again) [05:59:00] *** rolandsteiner has quit IRC [06:01:45] <pkasting> Sigh, silence [06:03:01] *** abarth has joined #chromium [06:03:02] *** ChanServ sets mode: +v abarth [06:03:08] <rsleevi> pkasting: CRY SOME MORE? too cruel? ;-) [06:03:28] <pkasting> I HEAR SOMEONE BUILDING DIAPER CHANGING STATION [06:03:46] <pkasting> Oh well, landing the revert [06:05:16] *** bweinstein has quit IRC [06:06:23] <pkasting> Going away for the night, if the bot closes the tree for linux_views or linux_chromeos failures on my change, the revert is already in, so you can reopen [06:06:56] <abarth> pkasting: good night [06:08:02] <bryner> btw, newbie question: some of the docs say to use "git cl push", while some say "git cl dcommit". do they do the same thing? [06:08:43] <trungl> bryner: for committing into chromium, you should use git cl dcommit [06:08:54] <bryner> ok, that's what i used [06:09:07] <trungl> git cl push presumably wouldn't work [06:09:33] <trungl> (git cl dcommit commits via git-svn, which is required since chromium is in an svn repo) [06:09:57] <trungl> (git cl push apparently pushes into a git repo, which I believe cros uses; I've never used it myself) [06:10:07] <bryner> ah, got it [06:10:09] <bryner> thanks [06:14:30] *** fta has quit IRC [06:16:16] *** fta has joined #chromium [06:17:52] *** loislo has joined #chromium [06:25:38] *** pfeldman_ has joined #chromium [06:25:56] *** pfeldman__ has joined #chromium [06:26:03] *** viro101 has joined #chromium [06:27:33] *** zaspire has quit IRC [06:28:15] *** loislo has quit IRC [06:30:05] *** pfeldman_ has quit IRC [06:30:18] *** viro101 has quit IRC [06:34:16] *** rolandsteiner has joined #chromium [06:36:35] *** eseidel has quit IRC [06:42:44] *** thakis_ has joined #chromium [06:42:45] *** ChanServ sets mode: +v thakis_ [06:45:16] *** dglazkov has quit IRC [06:48:25] <ananta> can someone restart the chromium xp builder? [06:48:30] <ananta> codg25.jail [06:59:08] <thakis_> maruel nsylvain ^ [07:00:04] <ananta> thakis_: I sent them an email. Thanks [07:00:51] *** morrita has joined #chromium [07:03:45] *** bandu has quit IRC [07:07:22] *** eseidel has joined #chromium [07:08:45] *** AaronMT has joined #chromium [07:09:18] *** michaeln has quit IRC [07:14:48] *** thakis__ has joined #chromium [07:14:48] *** ChanServ sets mode: +v thakis__ [07:15:28] *** loislo has joined #chromium [07:15:46] *** AaronMT_ has joined #chromium [07:16:41] *** AaronMT has quit IRC [07:16:41] *** AaronMT_ is now known as AaronMT [07:19:00] *** thakis_ has quit IRC [07:21:09] *** fta_ has joined #chromium [07:22:21] *** fta has quit IRC [07:22:35] *** fta_ is now known as fta [07:25:58] *** pgrous__ has quit IRC [07:29:30] *** AaronMT has quit IRC [07:33:13] *** MikeSmithW3C has quit IRC [07:36:31] *** thakis_ has joined #chromium [07:36:33] *** ChanServ sets mode: +v thakis_ [07:36:56] *** thakis_ has quit IRC [07:38:26] *** xinming has left #chromium [07:39:34] *** thakis__ has quit IRC [07:49:24] *** thakis_ has joined #chromium [07:49:24] *** ChanServ sets mode: +v thakis_ [07:49:29] *** eseidel has quit IRC [07:50:34] *** thakis__ has joined #chromium [07:50:34] *** ChanServ sets mode: +v thakis__ [07:52:49] <thakis__> hbono: do you have a bug for your highdpi work? [07:52:54] <thakis__> i'd like to read what it's about [07:54:01] *** thakis_ has quit IRC [08:05:18] *** thakis_ has joined #chromium [08:05:18] *** ChanServ sets mode: +v thakis_ [08:06:05] *** thakis_ has quit IRC [08:06:07] <awong_> FYI, I'm going to attempt a big webkit roll. Will be watching for redness. [08:06:14] *** phunehehe has joined #chromium [08:06:23] *** ChanServ sets mode: +v awong_ [08:07:09] *** MichealH has joined #chromium [08:09:25] *** thakis__ has quit IRC [08:11:08] *** trungl has quit IRC [08:11:16] *** phunehehe has quit IRC [08:18:13] *** fta has quit IRC [08:20:21] *** fta has joined #chromium [08:22:29] *** bweinstein has joined #chromium [08:23:08] *** bryner has quit IRC [08:23:39] *** Slide-O-Mix has left #chromium [08:25:55] *** slightlyoff has joined #chromium [08:25:55] *** ChanServ sets mode: +v slightlyoff [08:33:05] <hbono> thakis: they are issue 1715 and 36939. [08:33:36] * hbono is installing snow leopard. [08:34:10] *** Buglouse has quit IRC [08:34:44] *** eseidel has joined #chromium [08:36:52] <awong_> anyone around familiar with how V8Bindings get generated? An idl change was checked in that's breaking the webkit canaries, but I don't know how to fix it. [08:36:55] <awong_> http://trac.webkit.org/changeset/62880 [08:37:33] *** rniwa has joined #chromium [08:39:12] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac Builder" from 51935: ajwong at chromium dot org) [08:43:29] *** Erkan_Yilmaz has quit IRC [08:45:15] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (waiting on rebuild on Chromium Mac Builder) [08:49:38] <hbono> awong_: when I added composition events <http://trac.webkit.org/changeset/50968/trunk>, I needed to change some files under "WebCore/bindings/v8" for v8. I'm sure eseidel can give you better advices. [08:52:20] <awong_> hbono: thanks for the pointer. That actually looks quite helpful. I'll go look under bindings/v8. [08:52:42] <hbono> awong_: no problem. :) [08:54:03] *** FunkyPenguin has quit IRC [08:54:04] *** MichealH has quit IRC [08:55:18] *** ph0nk has quit IRC [08:56:14] *** rolandsteiner has quit IRC [08:58:39] *** hbono has quit IRC [08:58:54] *** hbono has joined #chromium [09:00:13] *** hbono has quit IRC [09:01:22] <awong_> the mac builder failure really looks like a builder hiccup. It's like libwebcore.a got deleted between build targets. I'm going to clobber and open the tree while I watch it. [09:01:26] *** hbono has joined #chromium [09:02:27] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open (awong watching Chromium Mac Builder clobber) [09:05:21] *** WildFox has joined #chromium [09:05:23] <WildFox> moin [09:05:34] <WildFox> does anyone know what's happenning with the chromium webkit buildbots? [09:05:59] <awong_> WildFox: I'm looking at our webkit canary bots. [09:06:06] <WildFox> thanks [09:06:13] <awong_> Someone checked in an IDL change which broke things. I'm not quite sure how to fix it. [09:08:27] <awong_> WildFox: Do you know anything about http://trac.webkit.org/changeset/62880? [09:10:10] *** DBO has joined #chromium [09:12:47] *** bweinstein has quit IRC [09:13:11] <WildFox> awong_: what do you mean, which broke things? not building anymore? [09:15:17] <awong_> WildFox: sorry for not being more clear. That change seems to be what broke the chromium webkit buildbots. I just created a bug for it. [09:15:35] <WildFox> url? [09:15:42] <WildFox> awong_: seems somewhat unlikely btw [09:15:47] <awong_> https://bugs.webkit.org/show_bug.cgi?id=41935 [09:16:14] <awong_> I have a patch that fixes the compile locally. [09:16:34] <WildFox> aha, I see they all hang on the gclient step [09:16:36] <awong_> though, I'm kinda just stabbing in the dark. :( [09:16:39] <WildFox> looking at build.webkit.org/waterfall btw [09:16:54] <WildFox> didn't see the compilation was a problem [09:17:10] <awong_> ah, I'm looking at the chromium canaries. http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/31317/steps/compile/logs/stdio [09:17:27] <awong_> if they're hanging at gclient, that's another issue. [09:17:39] <WildFox> awong_: ok, I can review your timeranges patch btw [09:17:57] <awong_> WildFox: cool. thanks. I'll take a peek at the webkit builders in a sec. [09:18:43] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac" from 51935: ajwong at chromium dot org) [09:19:18] *** fta has quit IRC [09:20:39] *** fta has joined #chromium [09:27:01] <awong_> WildFox: Patch up for review when you've got a sec: https://bugs.webkit.org/show_bug.cgi?id=41935 [09:27:26] <WildFox> sure [09:29:12] *** rniwa has quit IRC [09:29:52] <WildFox> awong_: that's not correct [09:30:26] <WildFox> oh wait, TimeRanges is a mediaplayer thing [09:32:11] <awong_> WildFox: I'm pretty sure it's only used inside the video/audio tags. The IDL has it conditional on video. But I could be wrong. [09:32:20] <WildFox> yeah, you're right, r=me. [09:32:33] <WildFox> do you need cq+ ? [09:33:16] <awong_> WildFox: cq+ would be great. [09:33:43] *** slightlyoff has quit IRC [09:33:51] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (awong trying to sort out Chromium Mac.) [09:34:03] <WildFox> submitted [09:34:20] <awong_> WildFox: thanks [09:41:27] *** [Nef] has joined #chromium [09:41:51] *** star-affinity has joined #chromium [09:42:33] *** Fishy_ has joined #chromium [09:42:47] *** hrna has joined #chromium [09:42:59] *** estan_ has joined #chromium [09:43:32] <estan_> hey folks. i've clicked "no" to saving password on a couple of sites, now i've changed my mind. how can i make the "do you want to save password?" show up again for these sites? [09:43:41] *** apavlov has joined #chromium [09:44:43] <estan_> oh sorry this is not a user channel. [09:44:47] * estan_ moves along. [09:44:49] <awong_> crap, I think I'm hitting a VM limit in the linker on mac after the webkit roll. errno=12 seems to be OOM. [09:45:12] *** estan_ has left #chromium [09:45:26] *** FishFace has quit IRC [09:45:52] *** Fishy_ is now known as FishFace [09:47:19] *** hbono has left #chromium [09:47:47] *** hbono has joined #chromium [09:52:48] *** barcon332 has quit IRC [09:59:02] *** ScriptRipper has quit IRC [09:59:11] <hwennborg> good morning chromium! [09:59:11] <trungl-bot> hwennborg: Good morning! [09:59:13] *** FishFace has left #chromium [10:06:13] *** DBO has quit IRC [10:07:51] *** ScriptRipper has joined #chromium [10:15:13] *** pathorn has quit IRC [10:16:29] *** fta_ has joined #chromium [10:18:05] *** fta has quit IRC [10:18:18] *** fta_ is now known as fta [10:22:12] *** bauerb has joined #chromium [10:22:13] *** ChanServ sets mode: +v bauerb [10:27:49] *** maro has quit IRC [10:28:18] *** DBO has joined #chromium [10:31:08] *** rsleevi has quit IRC [10:33:26] *** rolandsteiner has joined #chromium [10:33:34] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (tentative fix for Chromium Mac submitted.) [10:36:05] *** ROBOd has joined #chromium [10:38:37] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open (Mac Webkit & Win Accessibility -> awong) [10:44:18] *** DBO has quit IRC [10:51:19] *** fta has quit IRC [10:53:06] *** fta has joined #chromium [10:55:40] *** pfeldman__ has quit IRC [11:04:13] *** General1337 has joined #chromium [11:05:42] *** FishFace has joined #chromium [11:06:49] *** General13372 has quit IRC [11:07:33] *** apavlov has quit IRC [11:09:23] *** kinnetica has joined #chromium [11:11:20] *** ph0nk has joined #chromium [11:11:25] *** FishFace has left #chromium [11:12:00] <WildFox> awong_: can you cycle the bots on webkit? they all hang [11:14:39] *** maro has joined #chromium [11:16:28] *** GNU\colossus has joined #chromium [11:17:34] <GNU\colossus> hi there :) does chromium/chrome support what's called Web Shortcuts in konqueror and (iirc) Bookmark Keywords in Firefox? basically, I want a user-set shorthand for the addressbar, that expands to a full-fledged URI whilst replacing certain parts of that by the given arguments. [11:18:02] <GNU\colossus> like "ex arg1" should expand to "http://example.com/?q=arg1" [11:20:20] <vesav> are you talking about opensearch? [11:20:22] *** tkent has quit IRC [11:21:03] <vesav> at least http://thepiratebay.org/ offers me on the url bar to press tab and enter search term and it then completes certain part of url to display search results [11:21:41] <vesav> http://static.thepiratebay.org/opensearch.xml this defined in the page header enables the functionality [11:21:58] <wRAR> not necessarily [11:22:28] <wRAR> (and he is talking not about custom site searches, but about more flexible functionality) [11:22:56] <vesav> o [11:22:57] <vesav> k [11:23:23] <wRAR> (though it can be achieved by using Chrome custom search functionality too) [11:23:32] *** kenneth_reitz has quit IRC [11:24:38] *** BryanWB has joined #chromium [11:31:49] *** BryanWB has quit IRC [11:32:19] <awong_> WildFox: sorry...got distracted by a couple of other build issues. I'll see what I can do, but I'm not sure I have access to those particular bots. [11:34:02] <WildFox> thanks [11:34:47] <GNU\colossus> vesav: I think wRAR correctly summed it up :) [11:35:35] <wRAR> GNU\colossus: this channel is not for user questions btw [11:36:51] <GNU\colossus> I see. will take my marbles elsewhere. [11:38:39] *** chaser_ has quit IRC [11:39:41] *** kenneth_reitz has joined #chromium [11:44:30] *** apavlov has joined #chromium [11:45:09] <awong_> WildFox: do you happen to know anything about the setup of those build bots? I can't even tell if they're hosted by Google or not... [11:49:43] <awong_> WildFox: found the info...seems like I don't actually have access to these bots (I think I need to get to them physically). I've sent a mail to the people who run them, but I don't think they'll be looking at it until around 10-11am PST. [11:49:44] *** Adys has quit IRC [11:49:54] *** pfeldman_ has joined #chromium [11:51:25] *** StaRetji has joined #chromium [11:52:35] *** Adys has joined #chromium [11:52:36] <StaRetji> Folks, is there a way to close chromium from command line, but now using killall command [11:52:37] <StaRetji> thx [11:52:48] <StaRetji> but not* [11:57:00] *** Athunye has joined #chromium [11:58:04] *** kenneth_reitz has quit IRC [11:58:28] <Athunye> Is there something like web developer or firebub/php for chromium ? [11:59:54] <WildFox> awong_: sorry, no idea about the setup [12:00:28] <Athunye> Hmm. Ctrl-Shift-j [12:03:20] *** hbono has quit IRC [12:09:17] *** eroman has quit IRC [12:16:41] *** Beetny` has joined #chromium [12:18:29] *** Beetny has quit IRC [12:22:25] *** rolandsteiner has quit IRC [12:24:20] *** satish_ has joined #chromium [12:27:22] <glotov> Hello sheriffs! I'm going to land a GRD change [12:28:13] <glotov> Trybots evaled green for it so I hope it will be smooth. [12:29:44] * hwennborg crosses fingers [12:30:48] <glotov> clearance for taxing? [12:31:48] *** chaser has joined #chromium [12:32:24] <trungl-bot> Tree closed by glotov at chromium dot org: Tree is closed (GRD change -> glotov) [12:32:29] <hwennborg> i don't have experience with landing grd changes, but if you can do it then go ahead [12:32:59] <glotov> yes, executing steps at http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Landing-a-GRD-Resources-Change [12:33:16] <hwennborg> ok [12:33:57] <hwennborg> we've experienced some turbulence after the latest webkit roll, but hopefully that shouldn't interfere [12:34:35] <glotov> no code change, just adding resource strings. CL: http://codereview.chromium.org/2897004/show [12:40:07] *** satish_ has left #chromium [12:40:33] *** satish_ has joined #chromium [12:40:45] *** chaser has quit IRC [12:40:51] *** satish_ has quit IRC [12:41:02] *** satish_ has joined #chromium [12:41:51] *** satish_ has left #chromium [12:42:07] *** satish_ has joined #chromium [12:42:22] *** chaser has joined #chromium [12:42:26] *** satish_ has quit IRC [12:47:03] *** Zucca has quit IRC [12:48:31] *** Zucca has joined #chromium [12:54:32] *** eseidel has quit IRC [12:54:39] *** eseidel has joined #chromium [12:57:24] *** Zucca has quit IRC [12:59:02] *** awolfson has joined #chromium [12:59:07] *** Zucca has joined #chromium [13:05:45] *** chrisccoulson_ has joined #chromium [13:09:18] *** Zucca has quit IRC [13:09:29] *** NthDeGeek has joined #chromium [13:09:51] *** Zucca has joined #chromium [13:11:59] <trungl-bot> Tree opened by glotov at chromium dot org: Tree is open (Mac Webkit & Win Accessibility -> awong) [13:13:36] *** grayhatgeek has joined #chromium [13:13:56] *** onox has joined #chromium [13:14:01] <grayhatgeek> hi everyone [13:14:52] <onox> is this the channel for questions to devs? [13:15:00] *** eseidel_ has joined #chromium [13:15:58] *** Zucca has quit IRC [13:16:57] *** Zucca has joined #chromium [13:18:29] *** amruthraj has quit IRC [13:18:42] *** grayhatgeek has quit IRC [13:19:00] *** amruthraj has joined #chromium [13:19:04] *** eseidel has quit IRC [13:19:04] *** eseidel_ is now known as eseidel [13:26:59] *** Zuccace has joined #chromium [13:27:04] *** Zucca has quit IRC [13:28:13] *** onox has left #chromium [13:29:25] *** NthDeGeek has quit IRC [13:33:04] *** Zucca has joined #chromium [13:34:05] *** Zuccace has quit IRC [13:34:22] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "test_shell_tests" on "Webkit (dbg)(1)" from 51948: glotov at chromium dot org) [13:36:51] <glotov> hwennborg: do you have an idea what went wrong with the tree? [13:37:00] <hwennborg> looking... [13:38:26] *** satish_ has joined #chromium [13:39:50] *** eseidel has quit IRC [13:39:54] *** abarth has quit IRC [13:40:20] *** Zucca has quit IRC [13:41:26] <trungl-bot> Tree closed by hwennborg at google dot com (:hwennborg): Tree is closed ("test_shell_tests" on "Webkit (dbg)(1)", hwennborg looking) [13:43:28] <trungl-bot> Tree opened by hwennborg at google dot com (:hwennborg): Tree is open ("test_shell_tests" on "Webkit (dbg)(1)", hwennborg looking) [13:44:18] *** andrix has joined #chromium [13:54:09] *** eseidel has joined #chromium [13:54:32] *** Adys has quit IRC [13:59:21] *** Zucca has joined #chromium [14:06:44] <trungl-bot> Tree opened by hwennborg at google dot com (:hwennborg): Tree is open [14:09:48] *** rohitkc has joined #chromium [14:12:08] *** awolfson has quit IRC [14:17:27] *** paulgrous has quit IRC [14:18:23] *** jparent has quit IRC [14:18:35] *** jparent has joined #chromium [14:18:35] *** ChanServ sets mode: +v jparent [14:18:47] *** sky_ has quit IRC [14:18:50] *** sky_ has joined #chromium [14:18:50] *** ChanServ sets mode: +v sky_ [14:19:10] *** Martijnc has joined #chromium [14:27:53] *** fta_ has joined #chromium [14:28:15] *** rohitrao has joined #chromium [14:28:15] *** ChanServ sets mode: +v rohitrao [14:29:57] *** fta has quit IRC [14:30:00] *** fta_ is now known as fta [14:32:34] *** apavlov has quit IRC [14:39:11] *** sebmarkbage has quit IRC [14:41:08] <trungl-bot> Tree opened by glotov at chromium dot org: Tree is open (Mac Webkit & Win Accessibility -> awong) [14:42:08] <trungl-bot> Tree opened by glotov at chromium dot org: Tree is open [14:42:09] <glotov> Sorry, bad refresh of my browser :( [14:45:17] *** Zucca has quit IRC [14:45:30] *** Zucca has joined #chromium [14:47:18] *** sebmarkbage has joined #chromium [14:52:34] *** vitalyr has joined #chromium [14:57:02] <vitalyr> anyone with root access to our buildbots here? [14:59:25] *** Thurloat has joined #chromium [15:01:00] *** cbentzel has joined #chromium [15:04:15] *** Zuccace has joined #chromium [15:04:46] *** Zucca has quit IRC [15:07:52] *** apavlov has joined #chromium [15:11:40] *** Precea[BNC] is now known as Precea [15:16:06] *** malavv has joined #chromium [15:26:31] *** Erkan_Yilmaz has joined #chromium [15:26:32] *** Erkan_Yilmaz has joined #chromium [15:26:34] <maruel> vitalyr: yes [15:27:25] <vitalyr> maruel: could please look into incredibuild problems on our win webkit canary? [15:27:31] <vitalyr> maruel: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/31353/steps/compile/logs/stdio [15:29:47] *** wjmaclean_ has joined #chromium [15:31:51] <maruel> vitalyr: done [15:32:44] <vitalyr> maruel: thanks! now we can get new svg baselines... [15:35:01] *** rohitrao has quit IRC [15:35:16] *** cbentzel has quit IRC [15:37:45] <glotov> Hi! May I close the tree to land GRD change? [15:40:44] *** Adys has joined #chromium [15:41:17] *** dp has joined #chromium [15:41:35] *** dp has left #chromium [15:41:58] *** cbentzel has joined #chromium [15:43:45] <trungl-bot> Tree closed by glotov at chromium dot org: Tree is closed (GRD change -> glotov) [15:45:25] *** thakis_ has joined #chromium [15:45:25] *** ChanServ sets mode: +v thakis_ [15:49:14] *** zer0her0 has joined #chromium [15:50:36] *** rvargas has quit IRC [15:51:07] *** masterov has quit IRC [15:54:13] *** awidegreen has joined #chromium [16:00:22] *** masterov has joined #chromium [16:03:09] *** thakis__ has joined #chromium [16:03:09] *** ChanServ sets mode: +v thakis__ [16:05:45] *** thakis_ has quit IRC [16:06:54] *** awolfson has joined #chromium [16:10:13] *** Singularity has quit IRC [16:18:00] *** thakis__ has quit IRC [16:18:04] *** tedoc2000 has joined #chromium [16:18:44] *** leeight has joined #chromium [16:18:50] *** leeight has left #chromium [16:18:51] *** Athunye has quit IRC [16:19:51] *** rohitrao has joined #chromium [16:19:51] *** ChanServ sets mode: +v rohitrao [16:21:20] *** rsesek has joined #chromium [16:21:21] *** ChanServ sets mode: +v rsesek [16:23:00] <hwennborg> glotov: ping? [16:27:17] *** spot has quit IRC [16:27:19] <glotov> yes [16:28:10] <glotov> hwennborg: I clobbered buildbots and waiting for them to compile... [16:28:26] <hwennborg> glotov: ah yes, i see that now. good [16:28:48] *** pgrous has joined #chromium [16:30:36] *** Gina has joined #chromium [16:34:16] <glotov> tough luck, reverting... [16:37:20] <hwennborg> ok [16:37:23] <trungl-bot> Tree opened by glotov at chromium dot org: Tree is open (cycling green after revert) [16:38:37] *** dmaclach has joined #chromium [16:39:54] <fsamuel> Anyone want to give me a quick opinion on my patch for this bug http://code.google.com/p/chromium/issues/detail?id=25135 . Is this is a reasonable solution? It's only a few lines of code change. [16:40:08] <fsamuel> I'm not looking for a full review, just an opinion [16:43:22] *** dmaclach has quit IRC [16:46:23] *** Beetny has joined #chromium [16:46:28] *** masterov has quit IRC [16:48:09] <maruel> fsamuel: send a formal codereview [16:48:44] *** yutak_home has joined #chromium [16:48:44] *** ChanServ sets mode: +v yutak_home [16:49:17] *** Beetny` has quit IRC [16:50:20] *** fta_ has joined #chromium [16:51:15] *** fta has quit IRC [16:51:29] *** fta_ is now known as fta [16:52:54] *** Adys has quit IRC [16:53:17] *** erikkay has joined #chromium [16:53:17] *** ChanServ sets mode: +v erikkay [16:54:55] *** alyxuk has quit IRC [16:57:47] *** ph0nk has quit IRC [16:58:39] *** Aikar has left #chromium [16:58:44] *** alyxuk has joined #chromium [16:58:44] *** alyxuk has quit IRC [16:58:44] *** alyxuk has joined #chromium [16:59:01] *** himikov has joined #chromium [17:04:35] *** masterov has joined #chromium [17:10:46] *** Martijnc has quit IRC [17:16:19] *** dglazkov has joined #chromium [17:16:19] *** ChanServ sets mode: +v dglazkov [17:17:14] *** Martijnc has joined #chromium [17:17:15] <rsesek> eglaysher: ping [17:17:23] <fsamuel> maruel: so it's a fix to svg + skia, should this be a webkit bug or chromium bug? [17:18:52] *** aroben has joined #chromium [17:18:52] *** aroben has joined #chromium [17:22:19] *** apavlov has quit IRC [17:23:07] *** malavv has quit IRC [17:23:19] *** Zuccace has quit IRC [17:23:40] *** tonyg-cr has joined #chromium [17:23:40] *** ChanServ sets mode: +v tonyg-cr [17:23:50] <dglazkov> good morning, Chromium! [17:23:50] <trungl-bot> dglazkov: Good morning! [17:23:52] *** Venom_X has joined #chromium [17:25:05] <hwennborg> good morning [17:25:12] <dhollowa> good morning [17:27:39] <satish_> good morning! [17:29:56] <fsamuel> good morning! :) [17:30:49] *** stuartmorgan has joined #chromium [17:30:49] *** ChanServ sets mode: +v stuartmorgan [17:31:30] *** MichealH has joined #chromium [17:31:39] *** MichealH has joined #chromium [17:31:42] *** duffydack has joined #chromium [17:34:35] <maruel> fsamuel: chromium [17:34:52] *** dhg has left #chromium [17:35:19] *** masterov has quit IRC [17:38:09] <trungl-bot> Tree opened by glotov at chromium dot org: Tree is open [17:41:25] <hwennborg> yay, the green has returned [17:42:29] *** duffydack has quit IRC [17:46:12] *** jrmuizel has joined #chromium [17:48:16] <dglazkov> :) [17:49:18] *** pgrous has quit IRC [17:49:22] <hwennborg> any MTV/SFO sheriffs in the house? i need to go offline relatively soon [17:49:28] *** maikmerten has joined #chromium [17:49:43] *** happygrue has quit IRC [17:50:29] *** [Nef] has quit IRC [17:50:31] *** markmentovai has joined #chromium [17:50:32] *** ChanServ sets mode: +v markmentovai [17:51:09] *** tonikitoo has joined #chromium [17:51:23] *** jrmuizel has quit IRC [17:53:04] *** jrmuizel has joined #chromium [17:55:17] *** fta has quit IRC [17:57:06] *** fta has joined #chromium [18:00:33] *** Zucca has joined #chromium [18:02:37] *** masterov has joined #chromium [18:03:48] *** star-affinity has quit IRC [18:11:15] *** RT|Chatzilla has quit IRC [18:12:26] *** bauerb has quit IRC [18:13:47] *** kenneth_reitz has joined #chromium [18:15:43] *** Zaba has quit IRC [18:17:09] <arv> hwennborg: I'm in [18:21:24] *** masterov has quit IRC [18:22:01] *** kuchhal has left #chromium [18:22:54] *** bweinstein has joined #chromium [18:24:43] *** duffydack has joined #chromium [18:26:20] *** Zaba has joined #chromium [18:26:23] <hwennborg> arv: all right, i'm off then [18:30:08] *** WildFox has quit IRC [18:31:45] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 51968: dhollowa at chromium dot org) [18:32:23] <dhollowa> looking [18:32:33] *** mrossetti has joined #chromium [18:32:33] *** ChanServ sets mode: +v mrossetti [18:32:47] <mrossetti> oster: http://gizmodo.com/5582940/i-wish-the-smart-tank-were-real [18:33:10] <thakis> mrossetti: wrong channel [18:33:15] <xji> is webkit_tests suppose to work in layout_win_7 ? [18:33:15] <thakis> no oster around [18:33:37] <mrossetti> blast! sorry thakis and the rest of you! [18:33:48] <dhollowa> not mine. looks like bot problem. [18:33:56] <thakis> mrossetti: np, we all enjoy tanks here [18:34:08] <arv> dhollowa: yeah, I'll look into it [18:34:58] *** dmaclach has joined #chromium [18:37:26] *** atwilson has quit IRC [18:37:57] <arv> any trooper around? [18:42:29] *** whesse has quit IRC [18:43:28] *** bweinstein has quit IRC [18:43:51] *** cbentzel has quit IRC [18:44:26] *** johnny_g has joined #chromium [18:44:26] *** ChanServ sets mode: +v johnny_g [18:44:57] <trungl-bot> Tree closed by arv at google dot com: Tree is closed (compile -> arv) [18:45:23] *** WildFox has joined #chromium [18:45:23] *** WildFox has joined #chromium [18:47:29] *** mrossetti has quit IRC [18:47:47] *** mrossetti has joined #chromium [18:47:47] *** ChanServ sets mode: +v mrossetti [18:48:02] <xji> dglazkov: is webkit_tests suppose to work in layout_win_7 ? [18:48:56] *** asargent has joined #chromium [18:48:56] *** ChanServ sets mode: +v asargent [18:48:57] *** loislo has quit IRC [18:48:59] <trungl-bot> Tree opened by arv at google dot com: Tree is open [18:49:46] *** ojan_away is now known as ojan [18:51:13] *** hinoka|away has joined #chromium [18:51:13] *** ChanServ sets mode: +v hinoka|away [18:52:06] *** cbentzel has joined #chromium [18:54:33] *** WildFox has quit IRC [18:54:47] <thakis> jochen__: what happened to your grd patch? [18:58:45] *** bweinstein has joined #chromium [19:00:44] *** malavv has joined #chromium [19:05:08] *** masterov has joined #chromium [19:09:15] *** zaspire has joined #chromium [19:10:02] *** dave_levin has quit IRC [19:10:08] *** dave_levin has joined #chromium [19:11:55] *** fta_ has joined #chromium [19:13:13] *** Venom_X is now known as Venom_lnch [19:13:53] *** fta has quit IRC [19:13:57] *** fta_ is now known as fta [19:21:45] *** loislo has joined #chromium [19:22:36] <jrg> arv: I've got meetings and an interview 11-1 so you'll be a little alone as sheriff today. I'll be here a bit late tho. [19:22:59] <arv> jrg: No problem [19:29:13] <thakis> tony^work: re linux def plugin: what happens when chrome is autoupdated and the plugin requests a string/image? will it get a different string/image than it requested? [19:29:52] <tony^work> thakis: right [19:30:25] <thakis> hrm [19:30:48] *** kurrik has quit IRC [19:30:51] *** xji_ has joined #chromium [19:30:51] *** ChanServ sets mode: +v xji_ [19:31:12] <tony^work> the old binary would be using the new pak file, and some things may have been re-arranged in the pak file [19:31:16] <thakis> doesn't sound like i'd want to punt this then [19:31:29] <thakis> this is a giant yak shave [19:31:37] *** abarth has joined #chromium [19:31:38] *** ChanServ sets mode: +v abarth [19:31:39] *** FullFlannelJacke has quit IRC [19:31:41] <tony^work> yup, sorry :( [19:32:04] <thakis> not your fault [19:32:17] <thakis> and i get to learn about gyp, zygotes, etc [19:32:23] <thakis> :-) [19:32:56] *** xji has quit IRC [19:32:57] <tony^work> heh. I'm not the right person to ask about zygotes. agl probably knows the most about them. [19:33:12] *** FullFlannelJacke has joined #chromium [19:33:38] <thakis> i think i can figure it out [19:34:47] <evmar> zygote is alwasy sandbox due to the way suid works [19:34:50] <evmar> so you can't use it for plugins [19:35:07] <tony^work> but we could make a new zygote, right? [19:36:08] *** satish_ has quit IRC [19:36:19] *** hinoka|away has quit IRC [19:40:53] <evmar> yeah, but that is a decent amount of work. :\ [19:41:16] *** rafaelw has joined #chromium [19:41:16] *** ChanServ sets mode: +v rafaelw [19:41:32] <Thurloat> Hey #chromium, is there any plan to release a gwt devmode for Chrome OSX? (or am I barking up the wrong tree?) [19:42:27] *** cbentzel has quit IRC [19:42:44] *** rafaelw has quit IRC [19:43:34] *** csilv has joined #chromium [19:43:34] *** ChanServ sets mode: +v csilv [19:43:51] *** jrmuizel has quit IRC [19:43:56] <stuartmorgan> Thurloat: are you talking about a plugin? [19:44:05] *** cbentzel has joined #chromium [19:45:22] <Thurloat> stuartmorgan: yep [19:45:39] <Thurloat> stuartmorgan: i knew i was missing a keyword in there :) [19:46:02] <stuartmorgan> Thurloat: do you have a link to the plugin? [19:46:09] *** pfeldman_ has quit IRC [19:47:03] <stuartmorgan> nm, found it [19:48:09] *** thakis_ has joined #chromium [19:48:09] *** ChanServ sets mode: +v thakis_ [19:49:10] *** skrul_ has joined #chromium [19:49:10] *** ChanServ sets mode: +v skrul_ [19:49:33] <stuartmorgan> Thurloat: looks like these are very browsers specific; you'd have to ask the GWT people why the Chrome extension is Windows-only [19:49:40] *** jrmuizel has joined #chromium [19:49:49] <Thurloat> stuartmorgan: thanks for the direction :) [19:52:49] *** rafaelw has joined #chromium [19:52:49] *** ChanServ sets mode: +v rafaelw [19:53:21] *** kinnetica has quit IRC [19:55:01] *** malavv_ has joined #chromium [19:58:04] <asargent> tony^work , eglaysher , johnny_g : looks like one of your CLs broken browser_tests on linux [19:58:14] <asargent> s/broken/broke/ [19:58:20] *** hinoka|away has joined #chromium [19:58:20] *** ChanServ sets mode: +v hinoka|away [19:59:14] *** jamesr has joined #chromium [19:59:14] *** ChanServ sets mode: +v jamesr [19:59:23] <johnny_g> asargent: looks unlikely to be me, not touching views [20:01:26] *** beng_ has joined #chromium [20:03:10] <trungl-bot> Tree opened by erg at chromium dot org (:eglaysher): Tree is open (linux browser_tests -> erg investigating) [20:04:48] *** bryner has joined #chromium [20:04:49] *** ChanServ sets mode: +v bryner [20:11:16] <eglaysher> linux browser_tests should cycle green [20:14:06] *** jrmuizel has quit IRC [20:14:15] <trungl-bot> Tree opened by erg at chromium dot org (:eglaysher): Tree is open (linux browser_tests should cycle green) [20:15:08] *** fta_ has joined #chromium [20:15:35] *** sbyer has quit IRC [20:15:46] *** vitalyr has quit IRC [20:15:59] *** tonyg-cr1 has joined #chromium [20:15:59] *** ChanServ sets mode: +v tonyg-cr1 [20:16:34] *** fta has quit IRC [20:16:38] *** tonyg-cr has quit IRC [20:16:41] *** fta_ is now known as fta [20:16:56] *** masterov has quit IRC [20:19:15] *** rvargas has joined #chromium [20:19:16] *** ChanServ sets mode: +v rvargas [20:22:04] *** sbyer has joined #chromium [20:22:04] *** ChanServ sets mode: +v sbyer [20:23:08] *** Thurloat has quit IRC [20:24:32] *** Thurloat has joined #chromium [20:24:57] *** Thurloat has quit IRC [20:27:19] *** jrmuizel has joined #chromium [20:27:40] *** Venom_lnch is now known as Venom_X [20:30:27] *** jrmuizel has quit IRC [20:32:22] *** tonyg-cr1 has quit IRC [20:32:48] *** tonyg-cr has joined #chromium [20:32:48] *** ChanServ sets mode: +v tonyg-cr [20:37:35] *** aroben is now known as aroben|lunch [20:39:15] <awong> xji: ping [20:42:22] *** tonyg-cr has quit IRC [20:42:30] <thakis> mattm_g: you did the kwallet stuff, right? [20:42:34] <skrul_> any gtk folks out there that can take a quick look at this change -> http://codereview.chromium.org/2964003 ? I'm trying to take an existing static signal handler for the expander changes and make it a class method (so i can write the change to the profile). However, when I use the "notify::expanded" signal (which the previous code did), i get a crash with an infinite recursion on the stack. [20:43:17] *** mrossetti has quit IRC [20:43:21] <mattm_g> thakis: nope [20:43:28] <skrul_> the code does work if i use the "activate" signal, but this is kind of strange cuz it gets notified before the state of the expander is changed [20:43:33] <thakis> mattm_g: d'oh [20:43:36] <thakis> ignore my ccing you then [20:43:53] <eglaysher> skrul_: are you doing something that would trigger a notify during your notify signal handler? [20:44:30] <eglaysher> I recommend having the gtk+ source code open in another buffer/frame whenever doing any gtk+ debugging. [20:44:31] <skrul_> eglaysher: i don't think so -- the handler code currently does nothing other than log [20:44:39] <thakis> skrul_: do you need CHROMEG_CALLBACK instead of CHROME_GTK_CALLBACK? [20:44:56] <thakis> skrul_: nvm [20:46:19] *** [Nef] has joined #chromium [20:48:39] <trungl-bot> Tree opened by erg at chromium dot org (:eglaysher): Tree is open [20:48:58] <skrul_> i'll try taking a closer look at the gtk source and see if that is enlightening :) the recursive stack does not include any chrome code, which is kind of strange. Perhaps I'm setting up the callback incorrectly. [20:53:01] <rohitrao> trungl_afk, thakis: haven't looked at actual startup numbers yet, but turning on layers feels slower and also draws wrong :) [20:53:22] <thakis> rohitrao: yay [20:53:42] <arv> eglaysher: The Basic test is still failing [20:53:44] <thakis> rohitrao: do you know if safari sets wantsLayer? [20:54:44] <rohitrao> thakis: no idea, but it also doesn't have any overlapping content [20:56:08] <thakis> rohitrao: if you scroll a flash video halfway off-screen, they're at least clipping the layer somehow [20:56:44] <rohitrao> doesn't that come naturally from being in a view? [20:57:13] <thakis> rohitrao: i thought so, but i also thought you told me that no [20:57:26] <thakis> i misunderstood you apparently [20:57:56] <thakis> rohitrao: the overlay you get with find-in-page (that draws the yellow highlights) is a child window [20:57:59] <thakis> (in safari) [20:58:01] <thakis> not a view [20:58:05] *** dmaclach has quit IRC [20:58:21] *** dmaclach has joined #chromium [20:58:30] <rohitrao> ah [20:58:58] <rohitrao> oh, but child windows are hard to put into the key view loop [21:00:26] <thakis> rohitrao: to this i normally reply "write a proof of concept app" [21:01:08] *** duffydack has quit IRC [21:02:37] *** duffydack has joined #chromium [21:03:32] *** cbentzel has quit IRC [21:03:44] *** markmentovai has quit IRC [21:04:30] *** cbentzel has joined #chromium [21:08:47] *** OtherJakeSays has joined #chromium [21:09:17] *** phanee has quit IRC [21:09:29] *** phanee has joined #chromium [21:09:35] *** OtherJakeSays is now known as JakeSays [21:09:51] *** JakeSays is now known as OtherJakeSays [21:09:54] *** OtherJakeSays is now known as JakeSays [21:11:05] *** JakeSays has quit IRC [21:11:18] <awong> Is there some trick to figuring out who the next webkit gardner is? I'm looking at the gardening calendar, but I can't get it to tell me who each shift is assigned to. [21:11:25] *** JakeSays has joined #chromium [21:12:15] *** ib3rnd has joined #chromium [21:13:03] <rohitrao> thakis: ok, I have decided that drawers are separate windows that are part of the keyview loop [21:13:06] <rohitrao> does that sound right? :) [21:13:40] <thakis> rohitrao: on first glance it sounds right [21:14:07] *** beng_ has quit IRC [21:17:36] *** agl has quit IRC [21:17:46] *** viro101 has joined #chromium [21:17:55] *** zer0her0 has quit IRC [21:21:22] *** fta_ has joined #chromium [21:22:45] *** fta has quit IRC [21:22:56] *** fta_ is now known as fta [21:23:12] *** Buglouse has joined #chromium [21:24:53] *** bmizerany has quit IRC [21:25:18] *** loislo_ has joined #chromium [21:25:39] *** aroben|lunch is now known as aroben [21:27:03] <trungl-bot> Tree closed by arv at chromium dot org: Tree is closed (Reliability crashes) [21:27:34] *** kenneth_reitz has quit IRC [21:28:02] *** loislo has quit IRC [21:28:03] *** loislo_ is now known as loislo [21:32:29] <pkasting> arv: That's the second crash in 24 hours we've had at NPSWF32!DllUnregisterServer+0x168f [21:33:01] <arv> pkasting: ? [21:33:04] <pkasting> arv: I wonder if jam2, brettw, or any of the other folks connected to plugins/Flash might know what to do with this [21:33:21] <pkasting> arv: in re: "Tree closed (reliability crashes)" [21:33:51] <pkasting> arv: (I've been watching the reliability bot closely since yesterday I commented out most of the existing crash suppressions) [21:35:04] <brettw> pkasting: dunnow [21:35:05] <pkasting> arv: I don't think the tree needs to be closed though [21:35:18] <arv> pkasting: I wasn't sure... opening again [21:35:19] *** ib3rnd has quit IRC [21:35:27] *** eseidel has quit IRC [21:35:42] *** GeorgeY has joined #chromium [21:35:43] *** ChanServ sets mode: +v GeorgeY [21:35:45] *** eseidel has joined #chromium [21:36:09] <trungl-bot> Tree opened by arv at chromium dot org: Tree is open [21:36:39] *** malavv has quit IRC [21:37:33] <pkasting> brettw: Do you know if this is the bundled plugin? [21:37:45] <pkasting> brettw: I don't know how the reliability bot is set up or how we could tell [21:37:51] <brettw> "np" is Netscape Plugin which is non-bundled [21:37:56] <pkasting> OK [21:38:04] <brettw> bundled is "gc" [21:38:16] <pkasting> So, likely we can't do anything with these crashes, then? [21:38:24] <pkasting> Or is there somewhere at Adobe we can report [21:38:34] <brettw> unless its some system resource exhaustion [21:38:42] <brettw> we should make sure we're running the latest version [21:42:13] *** abarth has quit IRC [21:45:55] *** eseidel has quit IRC [21:47:20] <stuartmorgan> arv: um, that was/is a Mac bug [21:48:22] *** tonyg-cr has joined #chromium [21:48:22] *** ChanServ sets mode: +v tonyg-cr [21:48:27] <stuartmorgan> And it shows a frame of Flash, which the Mac bug doesn't. Can you file a new bug instead? [21:48:49] <arv> stuartmorgan: OK [21:50:24] *** andrix1 has joined #chromium [21:52:36] *** jschuh has quit IRC [21:52:55] *** andrix has quit IRC [21:54:21] *** dglazkov has quit IRC [21:54:42] <jrg> arv: I'm going to starty working my way through the redness, starting with release builders and heading towards memory bots. [21:55:25] *** andrix1 has quit IRC [21:55:45] <arv> jrg: I'm adding an exception for the flash crash [21:55:50] <jrg> ok [21:55:57] <thakis> brettw: there's this flash-related bug that ananta is working on [21:56:14] <thakis> brettw: http://crbug.com/48478 [21:58:32] *** StaRetji1 has joined #chromium [21:58:33] *** StaRetji has quit IRC [22:03:32] *** bmizerany has joined #chromium [22:04:07] *** cbentzel has quit IRC [22:04:19] *** duffydack has quit IRC [22:05:03] *** evmar is now known as evmar_afk [22:05:03] *** inferno-sec has quit IRC [22:05:22] *** inferno-sec has joined #chromium [22:05:22] *** ChanServ sets mode: +v inferno-sec [22:05:38] *** cbentzel has joined #chromium [22:07:07] *** xji_ has quit IRC [22:09:34] *** fta_ has joined #chromium [22:09:59] *** arv is now known as arv_afk [22:10:21] *** duffydack has joined #chromium [22:10:48] <awong> sheriffs: I'd like to try another large webkit roll. Any objections? Hazard is based on the size. [22:10:51] *** fta has quit IRC [22:10:55] *** fta_ is now known as fta [22:11:05] *** duffydack has left #chromium [22:11:30] *** xji_ has joined #chromium [22:11:38] *** ChanServ sets mode: +v xji_ [22:14:28] *** StaRetji1 has left #chromium [22:20:01] <awong> okay, trying the big webkit roll. Will be watching. [22:20:38] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 52001: erikchen at google dot com) [22:20:56] <erikchen> umm...I don't think this is me? [22:21:11] <awong> that looks like the bot is hozed [22:22:10] <awong> I think it got scared by my declaration of intent to roll webkit. Smart bot. [22:23:08] <awong> erikchen: just kicked the bot. Let's see if it recovers [22:24:37] <erikchen> thanks [22:24:40] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (Webkit Builder (dbg) kicked. Waiting for compile to start before reopen) [22:24:49] <pkasting> Is there a test prefix for unittests that causes a test to be not run at all? [22:24:58] <pkasting> DISABLED_? Or is that just layout tests? [22:25:10] <awong> pkasting: I thought that was for unittests, and not layout tests. [22:25:15] <awong> it definitely works for unittests. [22:25:37] *** legion13 has joined #chromium [22:26:55] <awong> all clear. reopening [22:27:43] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open [22:28:30] *** atwilson has joined #chromium [22:28:51] *** hinoka|away has quit IRC [22:29:16] <davidben> (Let's try this again... :D) I guess this should wait until after the WebKit roll, but any sheriff mind walking me through doing a GRD change when the tree is ready? [22:29:56] <awong> Heh...yes, please wait until after this roll... [22:30:05] <awong> I expect some minor turbulence. [22:33:44] <maruel> I've checked in gclient changes, expect some major turbulence [22:39:16] *** Derreck has joined #chromium [22:39:44] *** loislo has quit IRC [22:40:55] <pkasting> I think WebKit Builder dbg needs to be restarted [22:41:02] <pkasting> nsylvain: Do you agree? ^^ [22:41:02] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 52004: ajwong at chromium dot org, pkasting at chromium dot org) [22:41:09] <pkasting> http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Builder%20(dbg) [22:41:14] <nsylvain> checking [22:42:31] <arv_afk> we need to kick the builder again [22:42:36] *** arv_afk is now known as arv [22:43:52] <arv> I see it already restarted. no force build needed [22:44:13] <nsylvain> pkasting: looks good now [22:44:33] <awong> nsylvain: what was wrong? That exact error happened one build cycle earlier. [22:44:48] <nsylvain> the Incredibuild service on the machine crashed [22:44:50] <nsylvain> I had to restart it [22:44:54] *** eseidel has joined #chromium [22:44:54] <awong> ic [22:45:10] <pkasting> Thanks nsylvain [22:45:22] *** satish_ has joined #chromium [22:47:07] <trungl-bot> Tree opened by pkasting at chromium dot org: Tree is open [22:47:40] <erikkay> running into a git cl problem I haven't seen before [22:47:58] <erikkay> I'm getting "cannot upload with a dirty tree. you must commit locally first." [22:48:07] <erikkay> but git status shows nothing dirty [22:48:09] <evmar_afk> erikkay: run "git status" once and retry [22:48:10] <evmar_afk> oh [22:48:10] <evmar_afk> hm [22:48:12] *** evmar_afk is now known as evmar [22:48:19] <maruel> git reset --hard HEAD [22:48:20] <rsesek> or git checkout [22:48:30] <rsesek> or git co if you've aliased well [22:48:38] <satish_> a GIT question - I'm looking to rename a class & associated files in chromium, is 'git mv' the way to go and does it preserve revision log? [22:49:05] <rsesek> satish_: git does not track files, it tracks content. it *detects* renames, so you don't need to be explicit; but git mv works fine [22:49:16] <erikkay> rsesek: thanks. that worked. so what was wrong? local git database just confused? [22:49:26] *** eseidel has quit IRC [22:49:29] <rsesek> erikkay: yup. I think there was a thread on cr-dev a while ago about this [22:49:33] *** eseidel has joined #chromium [22:49:48] <erikkay> k. thanks again. [22:49:51] <rsesek> np [22:51:00] *** WildFox has joined #chromium [22:51:06] *** thakis_ has quit IRC [22:52:04] *** General1337 has quit IRC [22:52:45] <satish_> rsesek: thanks, still not sure if revision history will be preserved? [22:53:01] <rsesek> satish_: yes. revision history of what? [22:53:06] *** General1337 has joined #chromium [22:53:54] *** ctruta has joined #chromium [22:53:54] *** ChanServ sets mode: +v ctruta [22:54:18] <satish_> rsesek: once the renamed file is in, will we still be able to go back in revision log of the new file and refer to the old changes? [22:54:38] <rsesek> yes [22:56:01] <satish_> rsesek: great, thanks. i'm guessing if i have to rename both the file and the class declared in it, it should be done as 2 patches so that GIT can match the contents of the file when rename of file happens? [22:56:12] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 52009: ananta at chromium dot org (:iyengar), dhg at chromium dot org, jam at chromium dot org (:jam2), stuartmorgan at chromium dot org) [22:56:18] <davidben> git doesn't track history of a single file. The data model is simply a bunch of snapshots of the entire tree. Everything about single files --- renames, etc. --- is implicit. (When you ask for a single files revision history, it actually goes through the entire history and filters out anything that didn't touch your file.) [22:56:41] <jam2> doh, looks like my change caused it [22:56:44] <ctruta> Hi, I'm having trouble understanding the instructions to contribute code using GIT-CL. Could someobody please clarify? Specifically, I'm new with git and I don't quite understand the following: git checkout -b mychange origin/master [22:56:51] <jam2> looking into it [22:56:54] <rsesek> davidben explains it well. git will be able to detect that a certain percentage of the file is the same and still consider it a rename [22:56:57] <pcgod> https://git.wiki.kernel.org/index.php/GitFaq#Why_does_git_not_.22track.22_renames.3F [22:57:05] <ctruta> I'm getting the error: fatal: git checkout: updating paths is incompatible with switching branches. [22:57:05] <ctruta> Did you intend to checkout 'origin/master' which can not be resolved as commit? [22:57:07] <satish_> ok, i'll give it a shot :) thanks. [22:57:20] <rsesek> ctruta: try origin/trunk isntead [22:57:22] <rsesek> *instead [22:57:31] <ctruta> aha, I'll try, thanks [22:57:44] <brettw> I'm trying to fix for Jam [22:58:11] <davidben> satish_: If you want to verify that renames got detected, you'll want to pass -M to git show, diff, etc. It doesn't do rename detection by default. (git-cl should pass the appropriate flags when actually uploading your patch.) [22:58:15] *** Venom_X has quit IRC [22:58:47] <jam2> btw strange that this passed on the trybot [22:59:18] *** RobWork has quit IRC [22:59:26] <satish_> davidben: thanks, i'll try that. [22:59:35] <brettw> fix should be in along with a big mess of other stuff I checked in at the same time. Sorry, had DEPS dependency problems so I needed to pull in my stuff [22:59:40] <thakis> rsesek: when i moved the default pugin around, git decided that i renamed path1/plugin_impl_mac.h -> path2/plugin_impl_gtk.h and the other way round :-) [22:59:48] <ctruta> rsesek: so, to be sure that I understand, I will add the GOATS file, plus the files that I have been working on, to the "mychange" branch, then I do a "git cl upload", yes? [23:00:01] *** hinoka|away has joined #chromium [23:00:02] *** ChanServ sets mode: +v hinoka|away [23:00:16] <rsesek> ctruta: correct. but you have to git commit first. then upload will diff against the origin/trunk branch and upload the resulting snapshot [23:00:22] <rsesek> thakis: heh [23:01:44] *** loislo has joined #chromium [23:01:57] <ctruta> rsesek: aha, I see. ok. In that case, I might just switch to the branch that I have been working on, where everything is committed, then commit GOATS over there, then upload that one... I presume I don't have to use "mychange" branch [23:02:17] <rsesek> ctruta: no. I create a new branch for every CL I work on [23:02:33] <rsesek> a CL ~= a bug [23:03:18] <ctruta> rsesek: and here is another question: I didn't care about what I put in the commit message file... should I? Does it matter when I upload? [23:04:05] <rsesek> ctruta: when you upload, you will be prompted for a CL description, which does matter a lot. the first line is a short description (<100 chars) then you can add paragraphs describing the change if necessary. then there should be a BUG= line and a TEST= line [23:04:15] <maruel> I reverted the gclient change due to webkit incompatibility [23:04:21] *** rohitrao has quit IRC [23:04:53] <ctruta> rsesek: ok, thank you very much. I'll see how I can manage, and if I get stuck, I'll come back here :-) [23:05:36] <arv> brettw: It looks like it is still failing the compile [23:06:00] <brettw> arv: thanks, different error now [23:06:03] *** cbentzel has quit IRC [23:06:18] *** malavv_ has quit IRC [23:07:11] *** eseidel has quit IRC [23:07:24] *** WildFox has quit IRC [23:07:26] <thakis> ctruta: for git commit messages, i use "x" most of the time [23:07:34] <thakis> sometimes i wish i was even more explicit [23:07:38] <thakis> but most of the time that's good enough [23:07:47] <thakis> i commit about 3 times per minute tho [23:07:56] <thakis> (to git. not to chromium's svn.) [23:07:59] *** ryaxnbuntu has joined #chromium [23:08:06] <ctruta> thakis: good tip, thx :D [23:08:10] *** loislo has quit IRC [23:09:53] <jam2> arv: fix checked in [23:09:55] <jam2> deps fun [23:09:56] <thakis> V8DerivedSources5 [23:10:16] <thakis> didn't we have just 4 of those? (and just one a while ago?) [23:10:51] <arv> jam2: thanks [23:11:02] *** eseidel has joined #chromium [23:11:08] *** MichealH has quit IRC [23:12:50] <skrul_> eglaysher: if you are curious, turns out that signal handlers for property change notifications (such as "notify::expanded") have a different signature than generic signal handlers (such as "activate") [23:13:50] *** Derreck has quit IRC [23:14:26] *** RobWork has joined #chromium [23:15:45] *** fbarchard has quit IRC [23:17:06] <ctruta> I have one more curiosity: the GOATS file there is just a joke (for the sake of the example), isn't it? I mean, it's presented seriously, but nobody is really expecting a GOATS file among the other submitted files.... right?.... [23:17:16] *** fta_ has joined #chromium [23:18:33] *** fta has quit IRC [23:18:39] *** fta_ is now known as fta [23:18:56] <stuartmorgan> It's deadly serious; if we don't have GOATS in the repository, how will be recover them in case of a teleportation accident? [23:19:12] <pcgod> thakis: only 5? there are 8... [23:19:30] <thakis> ctruta: http://www.goatsteleported.com/ [23:22:08] <ctruta> thakis: yes, I saw goatsteleported.com but I could not distinguish between a jocular description of something serious, or just sheer sarcasm [23:22:42] <thakis> ctruta: chrome's task manager _does_ have a "goats teleported" column [23:23:38] <thakis> ctruta: http://src.chromium.org/viewvc/chrome?view=rev&revision=36154 [23:23:48] <ctruta> thankis: ok, then, I guess I haven't paid enough attention. Allright. Stay tuned for my CL *and* my GOATS [23:24:00] <ctruta> thakis: ok, then, I guess I haven't paid enough attention. Allright. Stay tuned for my CL *and* my GOATS [23:24:22] <ctruta> thakis: you have an id that's easy to mispell as "thanks" :-) [23:24:34] <thakis> ctruta: get an irc client with tab completion [23:24:41] <thakis> :-) [23:25:32] <ctruta> thakis: yet another good tip. thanks. I should hang out with you guys more often :-) [23:25:46] *** ryaxnbuntu has quit IRC [23:28:37] <jrg> jam dhg ananta stuartmorgan: is anyone on tree closure? [23:29:20] <stuartmorgan> jrg: [2:12pm] jam2: arv: fix checked in [23:29:37] <jrg> thx [23:29:48] <arv> thanks [23:34:56] *** legion13 has quit IRC [23:35:57] *** maikmerten has quit IRC [23:37:22] *** Erkan_Yilmaz_ has joined #chromium [23:37:56] *** ryaxnb has joined #chromium [23:38:35] <jam2> jrg [23:38:44] <jrg> jam2: [23:38:45] <jam2> just saw this [23:38:51] <jam2> just saw your email [23:38:53] <jam2> looking now [23:39:00] <jrg> thx is unrelated to tree closure tho [23:40:19] <jam2> ah ok, i'll let brett look at it then siince he wrote taht code [23:40:27] *** Erkan_Yilmaz has quit IRC [23:42:36] <jrg> jam2: it's real simple [23:46:10] <arv> gclient failed on Builder Vista Tests (dbg)(4) [23:46:10] <awong> is anyone looking at the build failure? [23:46:35] <arv> awong: there are a lot of compile failures [23:46:57] <arv> awong: and we have had 2 fixes for these so we are waiting for these [23:47:20] <awong> arv: ah, I see...missed the last few IRC messages. [23:47:45] *** Precea is now known as Precea[BNC] [23:48:10] *** kenneth_reitz has joined #chromium [23:49:35] <arv> brettw: URLLoader is failing [23:49:52] <arv> brettw: in chrome/test/ui/ppapi_uitest.cc:91 [23:49:56] *** Erkan_Yilmaz__ has joined #chromium [23:52:10] *** Martijnc has quit IRC [23:52:28] *** Erkan_Yilmaz_ has quit IRC [23:52:51] *** aroben has quit IRC [23:52:54] *** Precea[BNC] is now known as Precea [23:53:53] <akalin> any ETA on tree reopening? [23:54:30] <arv> akalin: Nope [23:54:59] <awong> arv: I'm looking into the webkit failures. Looks like the roll might have caused a major regression in windows (~320 tests). [23:55:02] *** ryaxnb has quit IRC [23:55:28] *** eseidel has quit IRC [23:59:22] *** arv has quit IRC [23:59:39] *** awolfson has quit IRC