[00:02:34] <davidben> thakis: (I interpreted the TODO(snej) to mean add a reasonable localizable error message for that error code, like we do in ssl_cert_error_handler.cc.)
[00:03:05] *** Malmis has joined #chromium
[00:06:07] *** tedoc2000 has quit IRC
[00:07:35] *** mrossetti has quit IRC
[00:09:12] *** tedoc2000 has joined #chromium
[00:09:49] *** Malmis has quit IRC
[00:11:33] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[00:11:51] *** ratdeptrai has quit IRC
[00:11:57] *** Malmis has joined #chromium
[00:12:56] *** Vamp898 has joined #chromium
[00:13:25] 
[00:15:30] <Vamp898> does it maybe have to do with one of these upgrades? http://pastebin.com/YPPStX6J
[00:15:51] *** NthDeGeek has quit IRC
[00:16:29] *** asargent has joined #chromium
[00:16:29] *** ChanServ sets mode: +v asargent
[00:17:36] *** dimich has quit IRC
[00:23:16] *** freezway has quit IRC
[00:28:14] *** trungl has quit IRC
[00:28:50] *** rsleevi has joined #chromium
[00:30:11] *** awidegreen has quit IRC
[00:33:30] *** tedoc2000 has quit IRC
[00:33:46] *** tedoc2000 has joined #chromium
[00:34:08] *** markmentovai has quit IRC
[00:34:47] *** rsesek has quit IRC
[00:37:26] *** rohitrao has quit IRC
[00:41:55] *** Vamp898 has quit IRC
[00:42:45] <rsleevi> cmasone: ping
[00:47:45] *** TabAtkins_ has quit IRC
[00:50:33] *** abarth has quit IRC
[00:52:21] *** michaeln has joined #chromium
[00:52:21] *** ChanServ sets mode: +v michaeln
[00:52:55] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium XP" from 51790: asargent at chromium dot org, dcheng at chromium dot org, feldstein at chromium dot org, hclam at chromium dot org, nirnimesh at chromium dot org, pkasting at chromium dot org, scherkus at chromium dot org, shess at chromium dot org, vrk at google dot com)
[00:53:24] <pkasting> Looks like bot issues
[00:53:28] <pkasting> Not a bad commit
[00:54:16] <pkasting> I reopened
[00:54:26] <pkasting> We'll see what the bot does this next time
[00:54:26] *** apatrick_ has left #chromium
[00:54:57] <trungl-bot> Tree opened by pkasting at chromium dot org: Tree is open
[00:59:53] <tonyg-cr> pkasting: it has failed 2 more times
[01:00:02] <tonyg-cr> i'm going to close the tree until we figure out what is going on
[01:00:30] <pkasting> Already closed
[01:00:46] *** dmaclach has quit IRC
[01:01:01] <trungl-bot> Tree closed by pkasting at chromium dot org: Tree closed, bot hosed
[01:01:05] <tonyg-cr> thx, are you already looking into having it rebooted?
[01:01:35] <pkasting> I sicced nsylvain on it
[01:01:47] *** alyssad has joined #chromium
[01:01:48] *** ChanServ sets mode: +v alyssad
[01:01:50] <pkasting> He has been fixing bot problems for me all afternoon, someone give him a cookie
[01:02:36] <nsylvain> chromium xp needs a reboot, it's going to take ~5 minutes
[01:03:02] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (XP bot -> nsylvain)
[01:03:10] * thakis hands nsylvain a cookie
[01:05:05] *** DBO has quit IRC
[01:07:31] *** kinnetica has joined #chromium
[01:07:36] *** thakis_ has joined #chromium
[01:07:36] *** ChanServ sets mode: +v thakis_
[01:08:16] *** thakis__ has joined #chromium
[01:08:16] *** ChanServ sets mode: +v thakis__
[01:10:20] *** Martijnc has quit IRC
[01:10:46] *** aroben has quit IRC
[01:12:39] *** thakis_ has quit IRC
[01:14:00] *** bandu is now known as coyo
[01:14:14] *** rohitkc has quit IRC
[01:16:52] <thakis> dhollowa: are there design docs for the new autofill stuff somewhere?
[01:17:12] *** ojan has joined #chromium
[01:17:12] *** ChanServ sets mode: +v ojan
[01:17:38] <dhollowa> thakis: ui mocks at: http://folder/roma/design/chrome/autofill/
[01:17:48] <thakis> dhollowa: more like "problem statement" etc
[01:17:53] *** magn3ts_ has joined #chromium
[01:18:09] <thakis> dhollowa: i'm looking at http://code.google.com/p/chromium/issues/detail?id=44016 have no idea what i'm supposed to do :-)
[01:18:15] <thakis> is this bug about password storage or autofill?
[01:18:21] <thakis> how much code do these systems share?
[01:18:21] <thakis> etc
[01:18:30] <nsylvain> pkasting: the machine did not come abck on its own. I'll try to kick it. most likely because it's still installing pending windows updates on reboot
[01:18:49] <dumi> can somebody pls point me to the correct copyright header that should be used by all new code added by google to webkit?
[01:19:54] <thakis> dhollowa: the mocks helped tho, thanks :-)
[01:20:15] <jam2> HEADS UP: app engine will be undergoing maintainence from 5-6pm pst (in 40 minutes), so rietveld will be down then
[01:20:24] <dhollowa> thakis: hmm.  that is a bit cryptic.  more in the land of autocomplete.
[01:20:39] <thakis> dhollowa: does autocomplete store passwords?
[01:20:47] <dhollowa> thakis: yes
[01:21:10] <thakis> dhollowa: oh wait, am i confusing autocomplete and autofill?
[01:21:17] <thakis> dhollowa: is password fill a part of autocomplete?
[01:21:21] <cbentzel> jam2: I assume chromium-status will also be down? Any way to close/open tree in that case?
[01:21:40] <dhollowa> thakis: autofill does not do anything with passwords.  only autocomplete.
[01:21:46] <thakis> dhollowa: ok
[01:22:36] <cbentzel> tonyg-cr: vrk is going to revert her change which broke test_shell_tests on memory bots.
[01:22:49] <cbentzel> tonyg-cr: I'll be off soon.
[01:22:59] <dhollowa> thakis: warning, the wk side blends the AF and AC terms a bit.  just fyi.
[01:23:00] <tonyg-cr> cbentzel: thanks, see ya tomorrow
[01:23:09] <thakis> dhollowa: my mind blends these too
[01:23:31] <dhollowa> thakis: and we hope to in the users' minds as well.
[01:23:44] <dhollowa> thakis: i.e. "just works"
[01:24:54] *** Venom_X has quit IRC
[01:27:27] <dhollowa> thakis: from my read of the bug...  the crux is the difference between <input type='text' name='password'/> and <input name='whatever' type='password'/>
[01:27:31] *** jedivulcan has quit IRC
[01:27:47] <thakis> dhollowa: that's WontFix then, no?
[01:28:26] *** Smeuuh has joined #chromium
[01:28:47] *** cbentzel has quit IRC
[01:30:44] <Smeuuh> ok, I guess this question is asked 10 times a day, but I couldn't find any answers on the net: how long till we get PDF support inside chromium and where can I follow the development?
[01:30:54] *** dmazzoni_ has joined #chromium
[01:31:49] <thakis> Smeuuh: that's a chrome-only feature afaik
[01:31:51] <thakis> like h.264
[01:32:01] <Smeuuh> oh, is it? it was posted on the chromium blog
[01:32:13] <Smeuuh> http://blog.chromium.org/2010/06/bringing-improved-pdf-support-to-google.html
[01:32:13] <thakis> yeah, that confused me too
[01:32:41] <Smeuuh> damn, that's annoying
[01:32:43] <dmazzoni_> sheriffs: OK to commit a rollback now, or do I need to wait until the tree opens?
[01:32:47] <Smeuuh> is it patent encumbered or something ?
[01:33:02] <Smeuuh> doesn't it just use libpdf which is free software ?
[01:33:06] <dmazzoni_> cbentzel, sehr, tonyg: ^^^
[01:33:10] <dhollowa> thakis: i'm having trouble repro'ing: ~dhollowa/autofill/pwd.html
[01:33:22] <trungl-bot> Tree opened by nsylvain at google dot com: Tree is open
[01:33:39] <dmazzoni_> nevermind, open now. thanks
[01:33:40] *** dmazzoni has quit IRC
[01:33:40] <tonyg-cr> dmazzoni_: open now :)
[01:33:44] <dmazzoni_> :)
[01:33:52] <stuartmorgan> Smeuuh: that blog post has the public information about the integrated PDF rendering
[01:33:57] <thakis> dhollowa: ls: /home/dhollowa/autofill/: No such file or directory
[01:35:02] <Smeuuh> stuartmorgan: I don't understand your reply. Is it chrome only then?
[01:35:33] *** dglazkov has quit IRC
[01:35:43] *** chrisccoulson has quit IRC
[01:35:51] *** bratsche has quit IRC
[01:37:03] <stuartmorgan> Smeuuh: It's currently Chrome-only
[01:37:07] <rsleevi> Smeuuh: I doubt it's a matter of patent encumbrance, since PDF is an "open" standard (good enough for ISO at least, as if that means anything these days)
[01:37:32] <Smeuuh> stuartmorgan: but planned to move to chromium ?
[01:38:29] *** chrisccoulson has joined #chromium
[01:39:52] <stuartmorgan> Smeuuh: Like I said, the blog post has the public information about it; the corollary is that if the blog post doesn't say something about it, you probably aren't going to get an answer here
[01:40:05] <Smeuuh> alright.
[01:40:13] <Smeuuh> found this nice hack though: http://www.omgubuntu.co.uk/2010/07/use-google-chromes-native-pdf-reader-in.html
[01:40:50] *** Martijnc has joined #chromium
[01:41:24] <Smeuuh> nice, it works.
[01:43:14] *** Martijnc has quit IRC
[01:50:09] *** bratsche has joined #chromium
[01:53:36] <tonyg-cr> nsylvain: The XP builder never came back, is it still restarting? I'm thinking about closing the tree so it doesn't get too far behind.
[01:53:58] <nsylvain> it's buildign right now
[01:54:20] <nsylvain> almsot done
[01:54:33] *** thakis__ has quit IRC
[01:54:56] <nsylvain> don't look at the config if you are sheriff, you are missing out on a lot of info
[01:55:01] *** Smeuuh has left #chromium
[01:55:16] <jrg> tonyg-cr / nsylvain: half of those CLs are mine which are Mac-only so it's less behind than it looks.
[01:55:33] <tonyg-cr> hmm? the waterfall doesn't show that it is building. what am i missing?
[01:55:50] <tonyg-cr> what do you mean by "don't look at the config"
[01:56:01] <nsylvain> duh.
[01:56:03] <nsylvain> i meant
[01:56:10] <nsylvain> "don't only look at the console"
[01:56:26] *** magn3ts_ has quit IRC
[01:56:30] <nsylvain> there is the "failures only" page for sheriffs
[01:56:43] *** bryner has joined #chromium
[01:56:44] *** ChanServ sets mode: +v bryner
[01:56:58] <tonyg-cr> i see that page now, thanks for the tip
[01:57:02] <nsylvain> np
[01:57:41] *** naan_ has joined #chromium
[02:05:40] *** kinnetica has quit IRC
[02:06:40] *** erikkay has quit IRC
[02:07:11] *** eseidel has joined #chromium
[02:07:23] *** dmaclach has joined #chromium
[02:09:02] *** tedoc2000 has quit IRC
[02:12:47] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (Windows too far behind)
[02:14:06] *** Martijnc has joined #chromium
[02:14:12] *** maro has quit IRC
[02:17:54] *** jcivelli has joined #chromium
[02:17:54] *** ChanServ sets mode: +v jcivelli
[02:18:05] *** thakis_ has joined #chromium
[02:18:05] *** ChanServ sets mode: +v thakis_
[02:19:53] *** maro has joined #chromium
[02:19:59] <jcivelli> Running ToT, renderers keep crashing for me in some accessibility related code. Anyone seeing this?
[02:22:37] *** dmaclach has quit IRC
[02:24:38] *** maro has quit IRC
[02:25:12] <nirnimesh> what does "Error: CapabilityDisabledError; please report!" on codreview mean?
[02:25:56] *** hbono has joined #chromium
[02:26:58] <jrg> nirnmiesh: it does that to people who don't have both a valid first and valid last name.
[02:27:19] <nirnimesh> jrg: that helps. thanks :)
[02:27:51] <pkasting> nirnimesh: I believe AppEngine is having problems
[02:29:35] *** maro has joined #chromium
[02:30:24] *** RT|Chatzilla has joined #chromium
[02:34:57] <tonyg-cr> trungl-bot settreestatus Tree is open
[02:34:58] <trungl-bot> tonyg-cr: Invalid response 500.
[02:35:25] <tonyg-cr> chromium-status won't let me open the tree :(
[02:35:33] <stuartmorgan> Down for maintenance
[02:35:39] <tonyg-cr> eta?
[02:35:43] <stuartmorgan> 5-
[02:35:45] <stuartmorgan> 6
[02:35:47] <tonyg-cr> ah cool
[02:35:49] <stuartmorgan> was the announcement earlier
[02:35:59] <tonyg-cr> i have to sign offline for about 15 mins, would you mind opening it when it comes back
[02:36:02] * stuartmorgan fails at using the return key
[02:36:04] <tonyg-cr> sorry i missed the announcement
[02:36:29] *** maro has quit IRC
[02:37:09] <stuartmorgan> sure, although you may be back before it is :)
[02:38:06] *** maro has joined #chromium
[02:39:46] *** yutak_home has quit IRC
[02:40:39] *** tonyg-cr has quit IRC
[02:41:31] *** rohitrao has joined #chromium
[02:41:31] *** ChanServ sets mode: +v rohitrao
[02:41:44] *** coyo has quit IRC
[02:41:48] <rohitrao> thakis: is gmail totally broken for you?
[02:42:20] <rohitrao> crap, this might be a layers thing
[02:42:49] <thakis_> rohitrao: no, seems to work
[02:42:59] <rohitrao> bah, layers
[02:43:01] <rohitrao> maybe
[02:43:11] <rohitrao> I got into this weird state where the gmail tab had no view
[02:43:21] <thakis_> rohitrao: certainly layers
[02:44:12] *** mrossetti has joined #chromium
[02:44:12] *** ChanServ sets mode: +v mrossetti
[02:44:34] <rohitrao> better now
[02:44:40] <rohitrao> maybe it was an autoupdate bug
[02:44:47] <rohitrao> but that seems unlikely too
[02:45:24] *** maro has quit IRC
[02:45:33] <thakis_> rohitrao: it was a rare bug that only happens with layers and that will be incredibly hard to track down and debug
[02:45:50] <thakis_> rohitrao: you've just caught a glimpse of what you'll be doing the next 3 weeks
[02:45:52] <thakis_> prescient!
[02:45:59] <rohitrao> thakis_: or it'll be an incredibly common bug that's easy to reproduce, wipes out the whole UI, and is impossible to fix
[02:46:28] *** maro has joined #chromium
[02:46:53] *** mrossetti has left #chromium
[02:48:12] <trungl-bot> Tree opened by stuartmorgan at chromium dot org: Tree is open
[02:48:22] *** rafaelw has left #chromium
[02:49:57] *** tav has joined #chromium
[02:50:31] *** tonyg-cr has joined #chromium
[02:50:31] *** ChanServ sets mode: +v tonyg-cr
[02:52:13] *** rolandsteiner has joined #chromium
[02:54:21] *** bandu has joined #chromium
[02:58:08] *** awolfson has joined #chromium
[03:00:02] *** MikeSmithW3C^ has quit IRC
[03:00:09] *** Martijnc has quit IRC
[03:00:46] *** thakis_ has quit IRC
[03:01:49] <tonyg-cr> csilv: I think 51770 caused mac ui_tests to be flaky http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/6585/steps/ui_tests/logs/TwoCommandsOneTab
[03:01:58] *** eseidel has quit IRC
[03:02:26] <csilv> tonyg-cr, looking...
[03:05:03] <tonyg-cr> csilv: if you agree that change looks like it could have caused that, would you mind rolling back while you look into a fix?
[03:06:22] <csilv> tonyg-cr: yes.  i think i'm more likely to mark that test as flakey since it's mine, but i'll have take action asap.
[03:06:25] *** Gina has quit IRC
[03:06:41] <tonyg-cr> okay, either way is fine, thanks
[03:07:38] <tonyg-cr> trungl-bot settreestatus Tree is open (mac ui_tests -> csilv)
[03:07:49] <trungl-bot> tonyg-cr: Set tree status to: "Tree is open (mac ui_tests -> csilv) [set by :tonyg-cr]".
[03:08:26] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (mac ui_tests -> csilv) [set by :tonyg-cr]
[03:09:38] *** hrna has joined #chromium
[03:10:54] *** kinnetica has joined #chromium
[03:12:22] *** andrix has joined #chromium
[03:13:48] *** bmizerany has quit IRC
[03:14:50] *** feldstein has quit IRC
[03:15:23] *** roc has joined #chromium
[03:17:35] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "test_shell_tests" on "Webkit Linux (dbg)(1)" from 51808: pkasting at chromium dot org)
[03:18:44] <tonyg-cr> pkasting: ping?
[03:18:45] <pkasting> Uh
[03:18:51] <pkasting> Not sure which change is doing that
[03:19:11] *** kinnetica has quit IRC
[03:19:33] <tonyg-cr> 62670:62723 is the range?
[03:19:57] <pkasting> tonyg-cr: I have to run, do you think you could revert me?
[03:20:13] <tonyg-cr> sure
[03:20:21] <pkasting> Thanks
[03:21:22] <csilv> tonyg-cr: marked that problematic test as FLAKY pending a real fix. 51811.
[03:21:37] <tonyg-cr> csilv: thanks :)
[03:24:49] *** rolandsteiner has quit IRC
[03:26:42] <trungl-bot> Tree closed by tonyg at google dot com (:tonyg-cr): Tree is closed (Waiting to make sure compile cycles green at 51812)
[03:32:15] *** hbono has quit IRC
[03:36:37] *** bryner has quit IRC
[03:36:51] *** bmizerany has joined #chromium
[03:37:52] *** johnny_g has quit IRC
[03:39:22] *** rafaelw2 has joined #chromium
[03:41:58] *** leeight has joined #chromium
[03:42:10] *** leeight has left #chromium
[03:42:36] *** TabAtkins_ has joined #chromium
[03:42:36] *** ChanServ sets mode: +v TabAtkins_
[03:49:56] <trungl-bot> Tree closed by tonyg at google dot com (:tonyg-cr): Tree is closed (Waiting to make sure compile cycles green at 51813)
[03:50:05] *** Aria has joined #chromium
[03:52:20] *** bandu is now known as coyo
[03:52:35] *** thakis_ has joined #chromium
[03:52:35] *** ChanServ sets mode: +v thakis_
[03:56:07] *** hbono has joined #chromium
[03:59:23] *** andrix has quit IRC
[04:05:50] *** leeight has joined #chromium
[04:05:53] *** leeight has left #chromium
[04:06:55] *** rolandsteiner has joined #chromium
[04:12:10] *** tav_ has joined #chromium
[04:13:01] *** tav has quit IRC
[04:13:01] *** tav_ is now known as tav
[04:16:12] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open (Compile cycling green at 51813)
[04:16:21] *** dr_win has quit IRC
[04:16:58] *** dr_win has joined #chromium
[04:19:22] *** bryner has joined #chromium
[04:21:14] *** dr_win has quit IRC
[04:23:17] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Chromium Mac" from 51812: ananta at chromium dot org (:iyengar), csilv at chromium dot org, jrg at chromium dot org, jvoung at google dot com, pkasting at chromium dot org, tonyg at chromium dot org (:tonyg-cr))
[04:24:11] *** tonikitoo has joined #chromium
[04:24:24] *** bryner_ has joined #chromium
[04:25:03] *** jcivelli` has quit IRC
[04:26:48] *** stuartmorgan has quit IRC
[04:26:52] *** Buglouse has joined #chromium
[04:26:55] * jrg looking at tree closure
[04:27:28] <tonyg-cr> jrg: thanks, i'm trying to sort it out too ?there were several things breaking at once
[04:27:29] *** bryner has quit IRC
[04:27:29] *** rafaelw2 has quit IRC
[04:27:31] *** bryner_ is now known as bryner
[04:27:48] <jrg> tonyg-cr: I think BookmarkBarFolderControllerTest.ChildFolderCallbacks is mine; will fix
[04:28:01] <tonyg-cr> jrg: thanks!
[04:28:37] *** trungl has joined #chromium
[04:28:37] *** ChanServ sets mode: +v trungl
[04:29:03] *** trungl has quit IRC
[04:29:20] <trungl-bot> Tree closed by tonyg at google dot com (:tonyg-cr): Tree is closed (Sorting out failures)
[04:30:00] *** trungl has joined #chromium
[04:30:01] *** ChanServ sets mode: +v trungl
[04:33:42] *** coyo has quit IRC
[04:35:18] *** bmizeran_ has joined #chromium
[04:36:24] <trungl-bot> Tree opened by tonyg at google dot com (:tonyg-cr): Tree is open (mac_unit_tests -> jrg)
[04:37:22] *** bmizerany has quit IRC
[04:39:25] <trungl-bot> Tree opened by jrg at chromium dot org: Tree is open
[04:42:03] *** bandu has joined #chromium
[04:42:37] *** dpranke has quit IRC
[04:45:11] *** chrisccoulson has quit IRC
[04:46:53] *** hinoka|away has quit IRC
[04:49:30] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 51818: jam at chromium dot org (:jam2))
[04:50:22] <jam2> looking at build failure (couldnt run this code through the try bots because of deps fun)
[04:50:36] <jamesr> whoops
[04:50:45] <jamesr> i think i slipped in right before the build broke
[04:50:56] <jamesr> can revert if it looks helpful
[04:51:35] <jam2> no i know what the problem is
[04:51:41] <jam2> stupid gcc!
[04:57:36] <trungl-bot> Tree opened by jam at chromium dot org (:jam2): Tree is open
[04:59:19] *** rohitrao has quit IRC
[04:59:30] *** bryner has quit IRC
[05:00:18] *** pathorn has quit IRC
[05:01:48] <jamesr> jam2: still you
[05:02:12] <jamesr> jam2: unused parameter warnings
[05:02:20] <jam2> yeah, fixing now
[05:02:22] <jam2> i realy hate gcc
[05:03:03] <tonyg-cr> it is really msvc's fault for not being stricter
[05:03:24] <jam2> tonyg-cr: why is that a problem that there are unused parameters?
[05:03:53] <tonyg-cr> okay, i guess it swings both ways
[05:03:54] <trungl> it really depends on the compiler settings
[05:04:09] <tonyg-cr> the times i've gotten bit were for useful warnings like initialization order
[05:04:11] <trungl> and I don't think we're even consistent on that count across our different builds
[05:04:13] <jam2> yeah, i'm just surprised that we fail the build on this
[05:04:34] <jam2> the other gcc error that i got was for this foo(&bar())
[05:04:39] <jam2> bar returns a struct
[05:04:48] <jam2> this is valid C!
[05:05:33] <trungl> of course, if you turn up the warning level, you'll get warnings for lots of valid constructs
[05:05:44] <trungl> ... and then you set it to turn warnings into errors
[05:05:48] <trungl> sigh
[05:06:41] * trungl wonders if we haven't recently turned up the warning level on some of our builders.
[05:06:43] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux x64" from 51820: jam at chromium dot org (:jam2), jamesr at chromium dot org, jrg at chromium dot org)
[05:07:10] <jamesr> we should have the warning level high but consistent across platforms
[05:07:43] <trungl> I'm pretty sure we don't warn for unused parameters on the mac builds
[05:08:28] <jamesr> we do warn for unused paramater
[05:08:39] <jamesr> see the last run from any of the chromium mac builders
[05:10:12] *** bmizerany has joined #chromium
[05:11:02] <trungl> hmmm
[05:11:10] <trungl> but do we turn them into errors?
[05:11:47] <jamesr> looks like it
[05:12:19] <jamesr> also pass -Wno-unused-parameter
[05:12:22] <trungl> weird, I'd never noticed that before
[05:12:28] <jamesr> thought that turned the warning off
[05:13:29] *** bmizeran_ has quit IRC
[05:13:29] <jamesr> stepping out for food. if r51819 is causing problems too just revert, i can re-land it really easily
[05:13:32] <jamesr> back in a bit
[05:14:29] <bmizerany> my friends and I are searching for a bare-bones hello world chrome extension that will build and install on os x.  does anyone have anything?  we've been all over forums and the chromimun wiki looking with no success.
[05:14:40] <bmizerany> *chromium
[05:15:47] <trungl-bot> Tree opened by jam at chromium dot org (:jam2): Tree is open
[05:17:35] *** bmizeran_ has joined #chromium
[05:18:19] <bmizeran_> [sorry for the possible re-post; my tubes got clogged] my friends and I are searching for a bare-bones hello world chrome extension that will build and install on os x.  does anyone have anything?  we've been all over forums and the chromimun wiki looking with no success.
[05:19:08] *** bmizerany has quit IRC
[05:24:28] <jam2> anyone available for a small mechanical review?
[05:29:58] <thakis_> jam2: oui
[05:30:25] <jam2> thakis_: thanks, http://codereview.chromium.org/2827047/show
[05:31:06] <jam2> oh
[05:31:07] <jam2> actually
[05:31:07] <jam2> nm
[05:31:13] <jam2> i cant check this in until webkit roll
[05:31:20] <jam2> i thought i could avoid that, but looks like i cant
[05:35:45] <thakis_> jam2: ok. will still take a look, but will take my time then
[05:38:28] <jamesr> bmizeran_: nearly any chrome extension will work fine on any OS (assuming it doesn't have native code, which is true most of the time)
[05:38:36] <jamesr> bmizeran_: tried the chromium-extensions mailing list?
[05:38:47] <bmizeran_> jamesr: we've looked everywhere
[05:38:56] <bmizeran_> we found this and are trying to get it loading d3d81fc182e4
[05:38:58] <jamesr> bmizeran_: and you can't find any chromium extensions on the internet?
[05:38:59] <bmizeran_> ooops
[05:39:08] <bmizeran_> http://hg.mozilla.org/mozilla-central/file/d3d81fc182e4/modules/plugin/sdk/samples/basic/mac
[05:39:19] <jamesr> that's not a chromium extension
[05:39:31] *** hbono has quit IRC
[05:39:45] <bmizeran_> jamesr: plugin.  not extension.  sorry
[05:40:03] <bmizeran_> npapi is what we're trying to get working
[05:40:19] <jamesr> ah
[05:40:22] <jamesr> yeah that's a bit trickier
[05:40:44] <jamesr> https://developer.mozilla.org/en/plugins is probably the best resource
[05:41:57] <bmizeran_> I was hoping you wouldn't say that. ;)  heh.  it's been pretty brutal thus far.
[05:43:12] *** dmaclach has joined #chromium
[05:46:11] <jamesr> there are some test plugins in the WebKit repository too that might be helpful
[05:46:20] <jamesr> sorry i don't have anything more useful
[05:46:40] <jamesr> i've tried to do this before and quickly decided to just give up and do something different
[05:49:54] <thakis_> bmizeran_: what are your problems?
[05:50:04] <thakis_> i've done it before and it seems to work :-P
[05:51:16] <jamesr> right on queue! i was worried i'd have to imply that OS X was a terrible development environment to get thakis_ to jump in :]
[05:51:46] <bmizeran_> thakis_: we'll, we got the xcodeproj building and working now.  now we code. :)  only took an hour to figure out.  we had to fix some of the source to get it building
[05:51:47] <thakis_> jamesr: that would've just made you look clueless :-)
[05:53:29] <thakis_> bmizeran_: hooray then :-)
[05:53:31] <bmizeran_> it looks as if all the plugins in /Library/Internet Plugins are all products of XCode.  Is XCode the best tool for compiling these things?
[05:53:43] <thakis_> bmizeran_: yes
[05:54:09] <thakis_> bmizeran_: you want the plugin to be a bundle, and building bundles without xcode is unnecessary pain
[05:54:11] <bmizeran_> thakis_: ok cool. just checking.  I love dev'n on a mac, but XCode isn't my cup of tea.  but it's all good.
[05:54:24] <bmizeran_> thakis_: yeah. I hear that. thx for the protip
[05:55:47] *** thakis__ has joined #chromium
[05:55:48] *** ChanServ sets mode: +v thakis__
[05:55:48] *** thakis_ has quit IRC
[05:56:39] <bmizeran_> thakis: aah.  no worries here:   `echo -e "all:\n\txcodebuild" > Makefile"`  :)
[06:02:16] *** bweinstein has quit IRC
[06:03:31] *** tonyg-cr has quit IRC
[06:03:41] *** tonyg-cr has joined #chromium
[06:03:41] *** ChanServ sets mode: +v tonyg-cr
[06:06:11] *** hbono has joined #chromium
[06:10:11] <thakis__> bmizeran_: but then you have to wait for "checking dependencies" every time you build (not an issue with smaller projects)
[06:11:34] *** tonyg-cr has quit IRC
[06:18:30] <bmizeran_> thakis: we'll cross that bridge when we get to it.  heh.
[06:19:20] <bmizeran_> thakis: how do you just display "hello" from an in-memory string to the doc?
[06:19:43] *** Aria has left #chromium
[06:21:47] *** dmaclach has quit IRC
[06:21:57] *** deusr has joined #chromium
[06:22:49] <deusr> hi
[06:24:21] <deusr> anyone know tell me the difference of the chrome for chromium? I tested the two and the chrome seems much faster, why?
[06:26:03] *** ph0nk1 has joined #chromium
[06:26:06] *** ph0nk has quit IRC
[06:28:46] *** AaronMT has joined #chromium
[06:29:45] *** jamesr has quit IRC
[06:30:34] <bmizeran_> deusr: iirc, chromium is the dev/bleeding-edge (Cromium is Chrome what WebKit is to Safari)
[06:32:06] *** thakis_ has joined #chromium
[06:32:06] *** ChanServ sets mode: +v thakis_
[06:32:11] *** thakis__ has quit IRC
[06:32:14] <thakis_> bmizeran_: "the doc"? you mean stdio?
[06:32:31] <thakis_> or do you want to paint to your plugin's area?
[06:32:37] <bmizeran_> thakis_: plugin area
[06:33:12] <bmizeran_> thakis_: do I always have to paint?  like in the xcode example?
[06:33:19] <thakis_> bmizeran_: look for OnDrawRect in http://google.com/codesearch/p?hl=en#hfE6470xZHk/webkit/default_plugin/plugin_impl_mac.mm&q=plugin_impl_mac.mm&sa=N&cd=1&ct=rc
[06:33:52] <rsleevi> bmizeran_: you can always make a scriptable object that interacts with the JS on the page
[06:34:38] <thakis_> (i'm going on and off 'cause i'm testing code that runs on connection changes)
[06:34:53] *** AaronMT has quit IRC
[06:35:11] <bmizeran_> rsleevi: hrm.  yeah.  I'm wondering if that would be perfomant for large amounts of streaming data and needs to be flushed and redrawn constantly
[06:35:24] *** thakis__ has joined #chromium
[06:35:24] *** ChanServ sets mode: +v thakis__
[06:35:37] *** rafaelw2 has joined #chromium
[06:35:40] *** thakis_ has quit IRC
[06:36:16] <rsleevi> bmizeran_: Oh, in that case, you totally want to paint. I wasn't sure if you were still on the "Hello World" question :)
[06:39:46] *** pfeldman_ has joined #chromium
[06:40:12] <rsleevi> bmizeran_: Are you talking about a windowed or windowless plugin? Windowed you can paint into the NPWindow, windowless you use NPN_InvalidateRect/NPN_InvalidateRegion/NPN_ForceRedraw and handle the NPP_Paint that gets called
[06:41:21] <thakis__> rsleevi: mac plugins are always windowless
[06:41:53] <thakis__> bmizeran_: are you using coregraphics or coreanimation for drawing?
[06:42:06] *** bweinstein has joined #chromium
[06:42:10] <thakis__> (the mozilla sample code uses core graphics)
[06:42:23] <thakis__> (which is a good choice if you're just getting started)
[06:42:28] <thakis__> (and a good choice in general too)
[06:47:15] *** XDS|Onyx|CM5 has quit IRC
[06:51:06] * trungl mentions, for anyone paying attention, that apparently Opera supplies fairly okay NPAPI documentation (as opposed to MDC, which is fairly atrocious).
[06:51:34] * trungl would discourage anyone from writing new NPAPI plugins, however.
[06:51:43] *** viro101 has joined #chromium
[06:52:03] <rsleevi> trungl: Using Pepper as the alternative?
[06:52:41] <trungl> Ideally, though ideally Pepper would be further along in having APIs and in stabilizing.
[06:53:23] <thakis__> trungl: npapi seems to work in more browsers
[06:53:29] <trungl> true
[06:53:49] <trungl> of course, NPAPI is barely an API
[06:53:55] <trungl> and is utterly unsandboxable
[06:54:17] <trungl> and we should do our best to turn off support for it sooner rather than later
[06:54:29] <thakis__> surely not before there's an alternative
[06:55:39] <trungl> yeah, but for any plugin that's starting to be written now ...
[06:56:44] * trungl can't provide any good advice, because the situation is all bad.
[06:58:02] <rsleevi> trungl: Is Pepper seeking to be a replacement for NPAPI? I thought it sought to build/extend NPAPI. Then again, that's what I get for sticking to MDC docs....
[06:58:45] <trungl> rsleevi: http://code.google.com/p/ppapi/
[06:59:04] <trungl> (this is "Pepper v2")
[06:59:48] <trungl> though our full story is surely more complicated
[06:59:56] <trungl> (and perhaps involves nacl)
[07:00:50] <thakis__> trungl: hey, that doesn't look all that bad
[07:00:55] <thakis__> it has documentation!
[07:01:11] <trungl> Pepper v2 is actually quite pleasant
[07:01:31] <trungl> the dangers in working with it is that it changes from day to day
[07:01:38] <thakis__> but still, if i would want to write a plugin just for fun, it wouldn't use it because a) i wouldn't have heard of this and b) my browser doesn't support it (i wouldn't use the dev channel if i was joe plugindev schmuck)
[07:03:08] <trungl> well, surely, if you used NPAPI, the "fun" part would surely be lost
[07:03:14] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "base_unittests" on "Modules Mac10.6 (dbg)" from 51831: ananta at chromium dot org (:iyengar))
[07:04:33] <thakis__> trungl: it's a run-off-the-mill plugin api as far as i can tell; it's not all that bad
[07:04:36] <trungl> even ignoring the lack of cross-platformedness of NPAPI, you'd have to deal with bad documentation, a pretty horrible programming interface, quirky/inconsistent support across browsers,
[07:04:39] *** ph0nk has joined #chromium
[07:04:54] *** dglazkov has joined #chromium
[07:04:54] *** ChanServ sets mode: +v dglazkov
[07:04:55] <trungl> three (or is it four?) different drawing models on Mac
[07:05:03] <trungl> windowed vs windowless mode elsewhere
[07:05:08] <thakis__> but only 2 interesting ones
[07:05:32] <trungl> except when some browser insists on falling back to QD
[07:05:40] <thakis__> and pepper will only have no inconsisten browser support if it fails :-)
[07:05:41] <rsleevi> trungl: But haven't you seen the studies - Swearing can help ease pain!  Which means NPAPI is somewhere between codeine and unconsciousness ;-)
[07:05:49] *** ph0nk1 has quit IRC
[07:06:25] <trungl> and, imagine how much fun it'll be when firefox takes their plugins out of process too!
[07:06:40] <thakis__> isn't that in 3.6?
[07:06:44] <thakis__> anyway, good night!
[07:06:45] *** thakis__ has quit IRC
[07:06:46] <trungl> dunno
[07:07:33] *** spot has quit IRC
[07:07:35] <rsleevi> yeah, they just landed it for Windows in 3.6.4
[07:07:38] <trungl> (to answer thakis__'s question, in 3.6.4 on Windows and Linux)
[07:08:17] <rsleevi> promptly followed by 3.6.6 to fix all the Flash crashes ;)
[07:10:41] <trungl> it's amazing NPAPI works at all
[07:10:44] <rsleevi> So with regards to PPAPI, do you have any knowledge as to other browsers looking/planning to implement it? Obviously it was on the Firefox roadmap at one point with "Pepper V1", I'm just curious what degree of inter-vendor work is going on with it when the commit tree is so heavily @chromium.org (exclusively?)
[07:10:46] <trungl> well, actually, it barely does
[07:11:13] <trungl> well, mozilla is noncommittal
[07:11:49] <trungl> there's a chicken-and-egg problem, wherein no browser maker wants to support it until there are plugins which use it
[07:12:56] <trungl> though recent rumblings vaguely indicate that (at least some at) mozilla aren't so thrilled by plugins at all, really
[07:13:06] <trungl> (maybe that's not entirely accurate)
[07:13:44] <trungl> but there's always the desire to give plugins exactly the same capabilities as available from javascript (and no more)
[07:14:19] <rsleevi> trungl: As opposed to? WHATWG standardization of elements and IDL to make plugins "unnecessary"?
[07:14:20] *** spot has joined #chromium
[07:15:25] <trungl> e.g., making plugins draw through canvas, and use other "html5" APIs for other things as well
[07:15:52] *** loislo has joined #chromium
[07:16:21] <trungl> I suppose it depends on what capabilities one envisions plugins having
[07:19:24] <trungl-bot> Tree opened by ananta at chromium dot org (:iyengar): Tree is open
[07:19:43] *** AaronMT has joined #chromium
[07:19:56] *** dglazkov has quit IRC
[07:19:59] <rsleevi> Sure, but isn't a plugin-less HTML5 even further off than a stable ppapi? I'm just thinking of say, threading, the closest I've seen from the standards are web workers, and while quite nice within a JavaScript context, nowhere near as robust (or a pain or, admittedly, as easy to screw up) as OS threads.
[07:22:24] <trungl> perhaps not "plugin-less", but by making most/all of the plugin APIs directly tied to their html5 counterparts
[07:22:54] *** yurys has quit IRC
[07:23:12] <trungl> so, to draw, a plugin might have to use a canvas
[07:23:29] <trungl> if it's lucky, perhaps it'd get direct access to a surface or somesuch
[07:24:09] *** loislo has quit IRC
[07:24:15] <trungl> similarly for sound, storage, etc.
[07:24:48] <trungl> of course, there's always the problem of the nonexistence of the required html5 APIs
[07:27:31] <trungl> (the two competing models are: 1. offer plugins lower-level access, and hopefully build html5 support to work off the same low-level backend; 2. offer plugins only high-level access, exactly equal to what html5 will provide)
[07:27:49] <trungl> 2. is, well, even more theoretical than 1.
[07:28:07] <trungl> (in that I don't believe anyone is actually working on 2.)
[07:29:38] <rsleevi> trungl: This may be perhaps unrelated, as I haven't studied much of the NaCL implementation, but my understanding of NaCL was that the sandbox was implemented/implementable as an NPAPI plugin. I wonder how such an implementation might intersect with 2., though I can see it reasonably via 1.
[07:30:01] <trungl> NaCl will move to Pepper v2.
[07:30:16] *** loislo has joined #chromium
[07:30:28] *** dave_levin has quit IRC
[07:30:55] <trungl> I suppose that this doesn't make it not implementable as an NPAPI plugin.
[07:31:19] <trungl> Well, pretty much everything is implementable as an NPAPI plugin since there are no constraints on NPAPI plugins.
[07:32:01] <trungl> It'd be difficult to offer nice low-level APIs (like one envisages for NaCl) in 2.
[07:32:15] *** happygrue_ has joined #chromium
[07:32:37] <trungl> but I don't think mozilla is currently expressing much interest in NaCl
[07:33:23] <trungl> (but, again, that may be due to not wanting to commit to supporting anything which no one uses yet)
[07:33:32] <trungl> <shrug>
[07:33:49] <rsleevi> Right, that was where my question was coming from. I can see NaCl as NPAPI (I think it is already), and NaCl as PPAPI doesn't seem far reaching, since PPAPI seems to primarily focus on normalizing the horrendous graphics/input problems of NPAPI. I just couldn't see NaCl as "HTML5++" or whatever the hybrid solution of #2 might be called
[07:35:28] <rsleevi> Then again, in this future world of stable APIs, there's no reason to see NaCl and HTML5++ as complementary-but-different services of the browser, rather than the NaCl-as/via-PPAPI/NPAPI of today
[07:35:35] *** happygrue has quit IRC
[07:35:47] <rsleevi> Sorry, that is no reason not to see them. The nots are important :)
[07:37:24] <trungl> right, though it's hard to see what #2 would offer that PPAPI wouldn't
[07:37:55] <trungl> (i.e., presumably PPAPI would be powerful enough to provide access to all of HTML5)
[07:38:00] *** peepsalot has quit IRC
[07:38:17] <trungl> really, #2 mainly envisages a different way of providing a platform-independent API
[07:38:25] <trungl> but one which is higher level
[07:38:58] <trungl> (the benefit being that basically only one API has to be offered)
[07:39:26] *** michaeln has quit IRC
[07:39:34] <rsleevi> Right. Because one API, much like 640kb, should be enough for anything :)
[07:39:52] <trungl> and the drawback being that it enforces a much more restrictive, webby API
[07:40:30] <trungl> which would be bad if you're trying to write native-equivalent high-performance games, for example
[07:40:42] <trungl> but not so bad if you just want to write plugins to supplement web content
[07:41:48] <trungl> on the bright side, I don't think it'd be hard to add PPAPI support to firefox
[07:42:32] *** MikeSmithW3C has joined #chromium
[07:42:51] *** bmizeran_ has quit IRC
[07:42:58] *** Namegduf has quit IRC
[07:43:00] *** Namegduf has joined #chromium
[07:43:10] <rsleevi> Right. That's why I was surprised that you expressed that some had even talked about #2, since it seems like it would practically prevent implementations such as InstantAction (uses a plugin to deploy/stream native platform games)
[07:44:29] <rsleevi> Anyways, that's tomorrow's API. For today, the comments of PPAPI vs NPAPI piqued my interest enough to try to find  "how soon", "who" and "what then", but it sounds like NPAPI, with all it's pain, is still the path for a new plugin, even one that may not see market for 6-12 mos.
[07:46:58] <trungl> yeah, probably the wise (market) choice
[07:47:26] <trungl> just try to code with possibly switching over in mind
[07:48:12] *** DBO has joined #chromium
[07:48:32] <trungl> it's not inconceivable to support both either
[07:49:21] <trungl> (probably not really more painful than supporting NPAPI on multiple platforms)
[07:49:27] *** peepsalot has joined #chromium
[07:49:42] <rsleevi> I say market for lack of a better term for "if I suddenly had the urge to write a plugin". But even with a stable PPAPI, isn't it reasonable to assume Chrome/ium will continue to support NPAPI, like all good web technologies, well past it's EOL (hello <marquee>)
[07:49:51] *** malavv has quit IRC
[07:51:13] <trungl> probably, though perhaps any transition to 64-bit would make continued support of NPAPI less compelling (since it'd be very difficult to support 32-bit NPAPI plugins in a 64-bit browser)
[07:51:46] <trungl> and then there's the security aspect
[07:52:09] *** tonikitoo has quit IRC
[07:52:22] <trungl> (which is to say that we worry about plugins being vectors for attack)
[07:53:20] <rsleevi> Understandably so, though how does PPAPI reduce that surface, beyond facilitating out-of-process execution easier?
[07:54:29] <trungl> since PPAPI will provide complete (enough) APIs (e.g., for file access, sound, etc.), a properly-written PPAPI plugin should be sandbox-able
[07:54:57] <trungl> (i.e., the browser only has to broker the provided API)
[07:55:38] <trungl> this is in contrast to NPAPI, which doesn't provide complete APIs, so plugins have no choice but to go directly to the system for file access, sound, etc.
[07:56:08] <trungl> (well, drawing too, especially in windowed mode)
[07:57:08] <trungl> [so a Pepper plugin should be able to run in a process with very, very low rights]
[07:57:39] <trungl> whereas NPAPI plugins must run in a process with basically full privileges
[08:00:22] *** urbanape has quit IRC
[08:00:43] *** cristim has joined #chromium
[08:01:51] <rsleevi> Fair enough, although that seems like a browser would only be able to Sandbox if, by definition, a Pepper plugin is forbidden from going low level (as opposed to merely being encouraged not to by the tantalizingly low-hanging fruit of the available API). Since if Browser A implements Pepper without sandboxing, you'll inevitably end up with plugins targeting that. And if sandboxing is seen as implicit/mandatory, it certainly presents a chall
[08:01:51] <rsleevi> to find an appropriate platform-independent abstraction (and I wonder how certain systems manufacturers would see it compared to, say, Flash, and how that might affect their motivation to implement it, or more aptly, not implement)
[08:03:09] *** bweinstein has quit IRC
[08:03:47] <cristim> hi there, can anyone reproduce the memleak that occurs when opening this page: http://qa.coreboot.org/log_commit.php?revision=4894
[08:04:09] <cristim> (this may be a webkit issue, though)
[08:04:49] <cristim> it seems to work in firefox
[08:05:14] *** tonikitoo has joined #chromium
[08:06:32] *** MichealH has joined #chromium
[08:06:38] *** MichealH has joined #chromium
[08:07:29] <cristim> it reproduces in windows with version 5.0.375.99 and in ubuntu with nightly build 51813
[08:07:32] <rsleevi> cristim: I hit 1.9gigs of realmem before closing, with the load never finishing. I do see it load in FF
[08:08:11] <rsleevi> cristim: I'm on OS X 10.6.4 w/ 5.0.375.86 (hrrm, I need to update....)
[08:08:24] <cristim> thanks
[08:08:31] <trungl> rsleevi: True. The story is complicated by the desire to make Pepper + NaCl the standard path. But, regardless, one hopes that, in this day and age, all browsers would run it in a sandbox. Regardless, being pragmatic, one should regard PPAPI as being a step forward, even if perhaps not as fully specified (e.g., in terms of sandboxability).
[08:09:07] <trungl> Systems manufacturers are also pragmatic, which is why they, e.g., support NPAPI on their desktop platforms.
[08:09:21] <trungl> anyway, I should be off to bed
[08:09:26] <trungl> 'night
[08:09:40] <rsleevi> trungl: There's no question that PPAPI is infinitely more appealing than NPAPI, even at it's very early stage. Thanks for fielding the questions
[08:10:04] <trungl> :)
[08:10:46] <trungl> (Obligatory disclaimer: one shouldn't take anything I say as gospel....) :)
[08:11:01] *** trungl has quit IRC
[08:11:02] <rsleevi> nah, I'll stick to MDC as gospel ;-)
[08:11:12] *** AaronMT has quit IRC
[08:18:20] <cristim> yay, safari also reproduces it, so it's a webkit issue
[08:18:48] *** pfeldman_ has quit IRC
[08:19:40] <rsleevi> cristim: oops, yeah, should have mentioned that. Safari also chews up the memory quicker
[08:22:01] *** deusr has quit IRC
[08:22:20] *** rsleevi has quit IRC
[08:25:02] *** ivan has quit IRC
[08:25:08] *** ivan has joined #chromium
[08:33:19] *** ph0nk has quit IRC
[08:35:05] *** [Nef] has quit IRC
[08:36:14] *** DBO has quit IRC
[08:36:22] *** dmazzoni_ has quit IRC
[08:46:06] <jochen__> morning
[08:48:11] *** Erkan_Yilmaz has quit IRC
[08:52:31] *** viro101 has quit IRC
[08:57:46] *** bandu has quit IRC
[08:59:53] *** MichealH has quit IRC
[09:08:13] *** ese has quit IRC
[09:11:54] *** bauerb has joined #chromium
[09:11:55] *** ChanServ sets mode: +v bauerb
[09:16:15] *** apavlov has joined #chromium
[09:21:05] *** cardona507 has joined #chromium
[09:23:44] *** cardona507 has left #chromium
[09:26:25] *** kinuko has quit IRC
[09:27:37] *** roc has quit IRC
[09:30:06] *** star-affinity has joined #chromium
[09:32:06] *** roc has joined #chromium
[09:32:56] *** paul_irish_ has joined #chromium
[09:39:52] *** tedoc2000 has joined #chromium
[09:41:15] *** eseidel has joined #chromium
[09:51:30] *** paul_irish_ has quit IRC
[10:04:14] *** fta has joined #chromium
[10:05:35] *** [Nef] has joined #chromium
[10:11:18] *** MikeSmithW3C^ has joined #chromium
[10:14:33] *** MikeSmithW3C has quit IRC
[10:15:20] *** Beetny has joined #chromium
[10:20:17] *** Buglouse has quit IRC
[10:21:41] *** satish__ has joined #chromium
[10:21:56] <satish__> hwennborg: ping
[10:26:26] *** fta_ has joined #chromium
[10:27:58] *** fta has quit IRC
[10:30:08] *** ROBOd has joined #chromium
[10:30:49] *** satish__ has quit IRC
[10:32:35] *** eseidel has quit IRC
[10:40:31] *** fta__ has joined #chromium
[10:40:47] *** fta__ is now known as fta
[10:41:59] *** fta_ has quit IRC
[10:56:28] *** eroman has quit IRC
[11:02:06] *** kinnetica has joined #chromium
[11:04:00] *** General1337 has joined #chromium
[11:07:16] *** General13372 has quit IRC
[11:10:47] *** romainhuet has joined #chromium
[11:26:26] *** pfeldman has joined #chromium
[11:27:31] *** MikeSmithW3C^ has quit IRC
[11:28:52] *** MikeSmithW3C has joined #chromium
[11:32:06] *** masterov has joined #chromium
[11:33:10] *** ROBOd has quit IRC
[11:33:33] *** ROBOd has joined #chromium
[11:34:16] *** udp has quit IRC
[11:38:39] *** udp has joined #chromium
[11:38:56] *** vitalyr has joined #chromium
[11:44:56] *** Fistput has joined #chromium
[11:45:12] *** MikeSmithW3C has quit IRC
[11:46:48] *** vlt has left #chromium
[11:49:13] *** Fistput has left #chromium
[11:51:36] *** tedoc2000 has quit IRC
[11:55:39] *** fta_ has joined #chromium
[11:57:21] *** lianj has quit IRC
[11:57:52] *** fta has quit IRC
[12:03:39] *** fta_ is now known as fta
[12:05:34] *** rolandsteiner has quit IRC
[12:07:55] *** hbono has quit IRC
[12:12:01] *** alyxuk| has quit IRC
[12:17:48] *** MikeSmithW3C has joined #chromium
[12:18:32] *** MikeSmithW3C has joined #chromium
[12:33:49] *** [Nef] has quit IRC
[12:41:50] *** leeight has joined #chromium
[12:41:54] *** leeight has left #chromium
[12:44:08] *** FullFlannelJacke has quit IRC
[12:45:50] *** fta_ has joined #chromium
[12:46:51] *** fta has quit IRC
[12:46:54] *** fta_ is now known as fta
[12:51:46] *** FullFlannelJacke has joined #chromium
[12:56:23] *** goxboxlive has quit IRC
[13:10:26] *** fta is now known as fta2
[13:10:38] *** fta2 is now known as fta
[13:19:07] *** [Nef] has joined #chromium
[13:23:56] *** ph0nk has joined #chromium
[13:27:35] *** alyxuk has joined #chromium
[13:30:53] *** andrix has joined #chromium
[13:38:21] *** tonikitoo has quit IRC
[13:43:13] *** himikof has quit IRC
[13:44:09] *** leeight has joined #chromium
[13:44:16] *** leeight has left #chromium
[13:47:36] *** Martijnc has joined #chromium
[13:50:10] *** fta_ has joined #chromium
[13:51:59] *** fta has quit IRC
[13:52:08] *** fta_ is now known as fta
[13:52:57] *** cbentzel has joined #chromium
[14:05:03] *** dr_win has joined #chromium
[14:09:16] *** XDS|Onyx|CM5 has joined #chromium
[14:12:41] *** tonikitoo has joined #chromium
[14:18:16] *** rohitrao has joined #chromium
[14:18:16] *** ChanServ sets mode: +v rohitrao
[14:20:50] <rohitrao> thakis: you're not awake, are you?
[14:24:16] *** spot has quit IRC
[14:24:16] *** spot has joined #chromium
[14:25:51] *** cbentzel has quit IRC
[14:30:38] *** brot has quit IRC
[14:30:39] *** rellig has quit IRC
[14:33:45] *** awolfson has quit IRC
[14:42:01] *** kinnetica has quit IRC
[14:45:34] *** shreyas_ has joined #chromium
[14:54:02] *** xinming has joined #chromium
[14:58:31] <xinming> When I click a e2dk link, there will a be a pop for wether to open it via that program, I've check "never ask again" check box, So, Can I to make that box show again?
[14:59:25] *** brot has joined #chromium
[15:01:29] *** fta_ has joined #chromium
[15:02:52] *** fta has quit IRC
[15:02:52] *** fta_ is now known as fta
[15:05:21] *** cbentzel has joined #chromium
[15:18:17] *** DBO has joined #chromium
[15:20:49] *** trungl has joined #chromium
[15:20:49] *** ChanServ sets mode: +v trungl
[15:21:35] <trungl> 'morning, Chromium.
[15:21:35] <trungl-bot> trungl: Good morning!
[15:24:29] *** Gina has joined #chromium
[15:24:47] *** Maxdamantus has joined #chromium
[15:25:30] <Maxdamantus> Hmm.. Is shift + insert on Chromium (X11) intentionally pasting from the wrong buffer?
[15:27:11] <xinming> Anyone here would answer my questions please?
[15:30:20] <Maxdamantus> It just pastes from the clipboard, like ctrl + v, but middle click pastes from the primary buffer.
[15:31:00] *** cbentzel has quit IRC
[15:34:41] <Maxdamantus> Actually, seems most gtk apps don't work that way.. hmm..
[15:34:55] <Maxdamantus> Though every other GUI application I use does :\
[15:36:13] *** awolfson has joined #chromium
[15:43:07] *** aroben has joined #chromium
[15:43:08] *** aroben has joined #chromium
[15:55:45] *** rohitrao has quit IRC
[15:59:48] *** Ruetobas has quit IRC
[16:00:53] *** dmaclach has joined #chromium
[16:02:36] *** Ruetobas has joined #chromium
[16:05:18] *** dmaclach has quit IRC
[16:06:10] *** yutak_home has joined #chromium
[16:06:10] *** ChanServ sets mode: +v yutak_home
[16:06:14] *** rsesek has joined #chromium
[16:06:14] *** ChanServ sets mode: +v rsesek
[16:06:39] <trungl> Good morning, rsesek!
[16:06:49] <rsesek> good morning, trungl!
[16:11:12] *** fta_ has joined #chromium
[16:12:56] *** fta has quit IRC
[16:13:06] *** fta_ is now known as fta
[16:17:12] *** cbentzel has joined #chromium
[16:17:33] *** naan_ has quit IRC
[16:21:53] *** adzuci has quit IRC
[16:23:20] *** shreyas_ has quit IRC
[16:28:21] *** naan_ has joined #chromium
[16:29:06] *** shreyas_ has joined #chromium
[16:34:48] *** Gina has quit IRC
[16:35:27] *** awidegreen has joined #chromium
[16:35:46] *** Gina has joined #chromium
[16:42:43] *** tedoc2000 has joined #chromium
[16:42:51] *** rafaelw2 has quit IRC
[16:43:12] *** DBO has quit IRC
[16:45:37] *** kcbanner has joined #chromium
[16:47:20] *** shreyas_ has quit IRC
[16:47:58] *** glotov has joined #chromium
[16:49:15] <glotov> Hello! Is any sheriff here? I'm going to commit GRD change...
[16:49:41] *** roc has quit IRC
[16:50:21] <rsesek> glotov: it's early so I'd go ahead and do it. follow these instructions but you can skip the tree closing http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Landing-a-GRD-Resources-Change
[16:50:37] <rsesek> i.e. land the grd now; when the first two blocks in the Windows console view have started compile, push a whitespace CL
[16:50:44] <rsesek> and just let things roll on bumpily
[16:51:31] <glotov> oh, cool. Is it because of no buildbot are working right now?
[16:51:40] <rsesek> glotov: it was :) but someone just landed
[16:52:12] <glotov> :) Funny. Should I close and wait?
[16:52:21] <cbentzel> glotov: You can close
[16:52:42] <rsesek> glotov: yes, I'd close and wait, land the grd, when compile starts land whitespace, and then reopen
[16:52:44] <glotov> thanks!
[16:53:00] <rsesek> gatekeeper may close the tree automatically from grd changes, but just reopen
[16:53:19] <cbentzel> glotov: And sorry for landing a change... my fault for not looking at IRC before doing it.
[16:53:30] <glotov> no problem
[16:53:38] *** rohitrao has joined #chromium
[16:53:38] *** ChanServ sets mode: +v rohitrao
[16:57:06] <rsesek> glotov: safe to land grd again (cbentzel's CL has stated compiling)
[16:57:59] *** rellig has joined #chromium
[17:00:01] <glotov> ok, thx, taking this moment...
[17:01:02] <rsesek> trungl-bot: settreestatus Tree closed (grd change -> glotov)
[17:01:03] <trungl-bot> rsesek: Set tree status to: "Tree closed (grd change -> glotov) [set by :rsesek]".
[17:01:11] <rsesek> trungl: that's nifty
[17:01:27] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree closed (grd change -> glotov) [set by :rsesek]
[17:08:28] <glotov> GRT committed, time to reopen?
[17:08:46] *** phajdan-jr has joined #chromium
[17:08:47] *** ChanServ sets mode: +v phajdan-jr
[17:08:51] <rsesek> glotov: not yet; need a whitespace CL after the first two windows blocks start
[17:09:12] *** zaspire has joined #chromium
[17:10:04] *** tonyg-cr has joined #chromium
[17:10:05] *** ChanServ sets mode: +v tonyg-cr
[17:10:31] *** MichealH has joined #chromium
[17:12:59] <rsesek> glotov: go ahead and push a whitespace CL or the rest of your CL
[17:13:20] <rsesek> the first two windows blocks are now started on your grd CL; after that, reopen
[17:13:47] <wjmaclean> Layout test question: If I want to create a layout test that is Skia specific (i.e. only Chromium linux+win), what directory do I put it in?
[17:14:15] *** loislo has quit IRC
[17:18:41] *** Venom_X has joined #chromium
[17:19:07] *** himikof has joined #chromium
[17:19:10] *** dave_levin has joined #chromium
[17:19:57] *** fta_ has joined #chromium
[17:21:11] <rsesek> glotov: compile failed?
[17:21:41] *** viro101 has joined #chromium
[17:21:45] *** fta has quit IRC
[17:21:50] *** fta_ is now known as fta
[17:22:42] *** Erkan_Yilmaz has joined #chromium
[17:26:14] <glotov> rsesek: looking
[17:31:29] *** dglazkov has joined #chromium
[17:31:37] *** ChanServ sets mode: +v dglazkov
[17:31:52] <trungl> Good morning, dglazkov!
[17:36:06] *** malavv has joined #chromium
[17:36:18] *** malavv has quit IRC
[17:36:50] *** malavv has joined #chromium
[17:38:17] <cbentzel> glotov: Any update on compile failure?
[17:38:26] *** Beetny` has joined #chromium
[17:40:39] *** Beetny has quit IRC
[17:41:32] *** MichealH_ has joined #chromium
[17:41:35] <cbentzel> glotov: It looks like it's complaining about duplicate headers in grit/google_chrome_strings.h and grit/chromium_strings.h
[17:41:49] <cbentzel> glotov: I apologize in advance for not knowing anything about grit
[17:42:20] *** awidegreen has quit IRC
[17:42:37] <glotov> cbentzel: not sure. Same failures before my change
[17:43:35] <glotov> cbentzel: in Chromium XP bot, since 51843, no?
[17:43:51] <cbentzel> glotov: On Chromium builder it only happened with 51845
[17:43:56] *** awidegreen has joined #chromium
[17:44:00] *** stuartmorgan has joined #chromium
[17:44:00] *** ChanServ sets mode: +v stuartmorgan
[17:44:33] <cbentzel> glotov: On Chromium XP it was the first build which incorporated 51845 (and also 51844, 51843)
[17:44:34] *** MichealH_ has quit IRC
[17:45:00] *** MichealH has quit IRC
[17:45:27] *** dmaclach has joined #chromium
[17:45:30] <rsesek> glotov: use the merged console view
[17:45:48] <glotov> rseek: yes, you're right
[17:48:20] *** MichealH has joined #chromium
[17:48:31] <cbentzel> glotov: Should you revert, or are the compile failures expected?
[17:50:38] <cbentzel> glotov: It doesn't look like you landed a whitespace change - is this needed (sorry, still reading through GRD docs)
[17:50:46] <rsesek> compile shouldn't fail
[17:50:47] <glotov> cbentzel: not expected. I'll revert in 10 mins if not find the fix, is it alright?
[17:51:02] <cbentzel> glotov: OK
[17:51:14] <rsesek> I'd revert; the tree's been closed for 50 minutes already
[17:52:09] <cbentzel> rsesek: It's been that long? Thanks for keeping track
[17:52:14] <cbentzel> rsesek: I agree, revert
[17:52:18] <rsesek> http://chromium-status.appspot.com/status_viewer
[17:52:35] <cbentzel> glotov: Do you know how to revert, or do you want me to?
[17:52:42] <glotov> drover?
[17:52:55] <cbentzel> glotov: That is the answer.
[17:54:46] <glotov> reverted
[17:55:33] <cbentzel> glotov: OK, I'll re-open
[17:56:36] *** erikkay has joined #chromium
[17:56:36] *** ChanServ sets mode: +v erikkay
[17:56:39] *** ph0nk has quit IRC
[17:57:02] *** andybons has joined #chromium
[17:57:02] *** ChanServ sets mode: +v andybons
[17:57:05] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open (Revert is in, should cycle green)
[17:58:47] *** udp has quit IRC
[18:02:10] <glotov> cbentzel: what did you mean as a whitespace change?
[18:03:30] <rsesek> glotov: did you read the grd instructions?
[18:04:37] *** udp has joined #chromium
[18:05:41] *** fantasticulous has joined #chromium
[18:05:47] <dglazkov> good morning, Chromium!
[18:05:47] <trungl-bot> dglazkov: Good morning!
[18:06:13] <trungl> Good morning, dglazkov!
[18:06:25] <dglazkov> :)
[18:09:44] *** hinoka|away has joined #chromium
[18:09:44] *** ChanServ sets mode: +v hinoka|away
[18:10:17] *** MikeSmithW3C^ has joined #chromium
[18:10:27] *** Venom_X is now known as Venom_bbiab
[18:10:51] <cbentzel> Does anyone know if the pulseaudio version changed on the ChromiumOS valgrind bots recently?
[18:11:18] <cbentzel> One of these started failing consistently on a simple version number change for chrome-release
[18:11:46] <glotov> rsesek: Yes, just magically skipped point 3. Last time I landed GRD, it was OK without it.
[18:12:13] <glotov> rsesek: will try again tomorrow
[18:12:17] *** star-affinity has quit IRC
[18:12:36] <rsesek> glotov: it depends on how you modify the grd files; sometimes you can get lucky and not have to, but not most times
[18:12:57] <glotov> rsesek: now I see
[18:13:38] <rsesek> glotov: but compile generally7 doesn't fail; I think there may be an error with your CL
[18:14:02] *** MikeSmithW3C has quit IRC
[18:14:20] *** Zaba has quit IRC
[18:14:39] <glotov> rsesek: trying it with trybot as well
[18:15:18] <rsesek> good plan
[18:15:33] <rsesek> the tests will probably fail due to the GRD change, but compile should succeed
[18:18:02] *** Zaba has joined #chromium
[18:18:03] *** fantasticulous has quit IRC
[18:20:17] *** happygrue has joined #chromium
[18:21:56] *** fta_ has joined #chromium
[18:23:04] *** RT|Chatzilla has quit IRC
[18:23:24] *** fta has quit IRC
[18:23:35] *** fta_ is now known as fta
[18:24:11] *** happygrue_ has quit IRC
[18:24:47] *** naan_ has quit IRC
[18:26:26] *** viro101 has quit IRC
[18:29:54] *** aroben is now known as aroben|lunch
[18:30:19] *** asargent has left #chromium
[18:31:52] *** jshin has quit IRC
[18:35:03] *** loislo has joined #chromium
[18:36:17] *** bandu has joined #chromium
[18:36:40] *** phanee has joined #chromium
[18:41:03] *** ph0nk has joined #chromium
[18:42:21] <tonyg-cr> nsylvain, cbentzel: the windows webkit_tests are complaining about not being able to access a file because it is in use. Does this just mean the bot needs to be kicked?
[18:45:51] *** trungl_ has joined #chromium
[18:45:51] *** ChanServ sets mode: +v trungl_
[18:46:20] *** apavlov has quit IRC
[18:47:56] *** jshin has joined #chromium
[18:47:57] *** ChanServ sets mode: +v jshin
[18:48:41] *** trungl__ has joined #chromium
[18:48:41] *** ChanServ sets mode: +v trungl__
[18:49:16] *** trungl has quit IRC
[18:49:16] *** trungl__ is now known as trungl
[18:51:32] *** Jeff_501 has joined #chromium
[18:51:51] <Jeff_501> Hello
[18:51:53] <cbentzel> tonyg-cr: Probably.
[18:52:06] <Jeff_501> When the os will be release?
[18:52:30] <tonyg-cr> cbentzel: looks like nsylvain might not be around yet, are there any other troopers around?
[18:52:42] *** trungl_ has quit IRC
[18:53:18] <cbentzel> tonyg-cr: maruel looks like he's around. I'll ask him if this is something you or I can just do ourselves
[18:53:19] *** rryk has joined #chromium
[18:53:42] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open
[18:54:30] *** [Nef] has quit IRC
[18:55:03] *** Jeff_501 has left #chromium
[18:56:05] <rryk> Hello. I have been developing a project for Chromium and recently started to merge changes with latest Chromium version. Since I haven't been updating for quite some time, several things broken. I generate bindings for V8 from IDL files for my own elements but I can't make it work again. There were a number of changes from rev 36959 to 51622 and I have tried to fix those, but still no luck. I don't get custom functions in JavaScript.
[18:56:21] *** evmar_afk is now known as evmar
[18:56:48] <evmar> rryk: you might wanna ask on the chromium-dev mailing list, and provide more info about what you tried
[18:57:33] <rryk> evmar: can you please help me if I will provide more info?
[18:57:46] <rryk> evmar: or should I write to chromium-dev anyway?
[18:57:59] <evmar> rryk: i don't know a lot about the v8 bindings, i think only one or two people do.  the mailing list is probably your best chance
[18:58:00] <phajdan-jr> rryk: the project moves very fast. If your change is big, it may be a good idea to split it so it's possible to integrate it faster.
[18:58:33] <cbentzel> tonyg-cr: I'll reboot the Webkit (dbg)(3) machine
[18:58:47] <phajdan-jr> rryk: 36959 -> 51622 is just a lot of code to do a merge/rebase for. It's going to be really hard indeed. :-/
[18:59:12] <tonyg-cr> cbentzel: can you forward me the chat log w/ the instructions for rebooting, if possible i'd like to add it to the sheriff wiki
[18:59:22] <rryk> phajdan-jr: I am developing support of new 3D format in Uni Saarland, namely XML3D. I introduce a number of elements in their own namespace, with specific renderers and specific JavaScript interfaces.
[18:59:26] *** awong_ has quit IRC
[18:59:49] <rryk> phajdan-jr: Most of my changes do not touch the core of the Chromium. I have set up the project in such a way that I can develop it independently
[19:00:12] <rryk> phajdan-jr: Actually I mostly modify WebKit, but I won't get any advice on V8 from #webkit :(
[19:00:12] *** awong_ has joined #chromium
[19:00:43] <rryk> Apparently V8******.cpp are generated, but the code never steps into there.
[19:00:46] *** ChanServ sets mode: +v awong_
[19:00:52] <phajdan-jr> rryk: I think that to avoid issues like this, you'd need to get some code upstream. Asking on chromium-dev (or chromium-html5?) seems to be a good first step.
[19:01:09] *** fta has quit IRC
[19:01:10] <rryk> phajdan-jr: okay... i will do so.. thanks
[19:01:12] <phajdan-jr> rryk: oh, and debugging may also be surprising due to multi-process model
[19:01:21] *** thakis_ has joined #chromium
[19:01:21] *** ChanServ sets mode: +v thakis_
[19:01:43] <evmar> rryk: the v8 bindings generation code was all rewritten recently
[19:02:16] <evmar> rryk: another idea is to find the point where the bindings code change happened (in the last few months, you can grep the webkit changelogs for bindings to find it i bet), and then do one merge up to the point just behind that
[19:02:26] <evmar> rryk: that will help isolate the bindings changes from other problems you may encounter
[19:02:34] *** fta has joined #chromium
[19:04:10] <trungl> thakis_!
[19:04:22] 
[19:05:17] <evmar> yeah, what was that all about
[19:05:26] <evmar> markus is probably at home mourning right now
[19:05:35] *** phajdan-jr is now known as phajdan-jr|afk
[19:06:12] *** fta_ has joined #chromium
[19:06:24] <thakis_> so am i
[19:06:26] <thakis_> only not at home
[19:07:11] *** Weems has joined #chromium
[19:07:14] 
[19:07:17] <evmar> http://i.imgur.com/gIqcV.jpg
[19:07:36] <thakis_> evmar: :-D
[19:07:44] <trungl> thakis_: as far as we could tell, given the mood of the people in the train, they must not have seen the game
[19:07:51] *** fta has quit IRC
[19:07:55] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open (webkit purple -> cbentzel)
[19:08:04] *** fta_ is now known as fta
[19:08:44] <trungl> score another one for the octopus
[19:08:54] <trungl> though I hear it was wrong for the Euro Cup
[19:09:08] <evmar> so it turns out that ld knows how to print out the functions it's dropping (due to them being unused).  unfortunately for us the list of these functions is over 15k lines long
[19:10:07] *** thakis__ has joined #chromium
[19:10:07] *** ChanServ sets mode: +v thakis__
[19:10:08] <thakis__> trungl: people in munich are like that
[19:10:13] <rryk> evmar: i have seen that DerivedSources*.cpp are not generated automatically and took that into account. However I didn't see to much changes in idl format, so it seems that it should still work since bindings are generated automatically.
[19:10:21] <trungl> thakis__: cheerful?
[19:10:24] <trungl> thakis__: drunk?
[19:10:24] <rryk> evmar: *not==now
[19:10:48] <evmar> rryk: the extent of my knowledge is seeing one person write "new bindings code is simple, yay!" and i can't even remember who wrote that... :)
[19:11:26] <trungl> (perhaps unlike the gloomy, drunk northerners)
[19:11:47] <rryk> evmar: i hope I will get that person to answer me on the mailing list :)
[19:12:13] <rryk> evmar: I will be going then... and write a mail later...  thanks and bye
[19:12:17] *** bweinstein has joined #chromium
[19:12:22] *** thakis_ has quit IRC
[19:12:29] *** bweinstein has quit IRC
[19:12:47] *** bweinstein has joined #chromium
[19:15:32] *** Venom_bbiab is now known as Venom_X
[19:16:50] *** MichealH has quit IRC
[19:17:42] <awong_> tonyg: ping
[19:17:47] *** MoonGlorious has joined #chromium
[19:17:53] <tonyg-cr> awong_: pong
[19:18:15] <awong_> tonyg-cr: I saw you reverted the webkit roll yesterday.  Do you remember what went wrong?
[19:18:16] *** csilv has left #chromium
[19:18:32] <awong_> http://src.chromium.org/viewvc/chrome?view=rev&revision=51812
[19:18:45] <tonyg-cr> yes, let me send you a link, just a sec
[19:19:07] <awong_> thanks
[19:19:12] *** rryk has quit IRC
[19:20:40] <tonyg-cr> there were problems with both 51808 and 51807, so it is hard to separate all of the things that were going on
[19:21:06] <tonyg-cr> this one i believe was from the wk roll:
[19:22:04] <tonyg-cr> http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux%20(dbg)(1)/builds/23300/steps/test_shell_tests/logs/stdio
[19:22:39] <awong_> ugh
[19:22:50] <tonyg-cr> normally i wouldn't revert a roll, but pkasting had to leave for the day and there were a couple of breakages to sort out
[19:23:06] <awong_> yep, I understand
[19:23:06] *** maikmerten has joined #chromium
[19:23:47] <jcivelli> does anyone know how to access a page's meta-tags from the renderer?
[19:30:27] *** jshin has quit IRC
[19:32:51] *** agl has joined #chromium
[19:32:51] *** ChanServ sets mode: +v agl
[19:33:08] *** AaronMT has joined #chromium
[19:33:33] *** csilv has joined #chromium
[19:33:33] *** ChanServ sets mode: +v csilv
[19:37:58] *** sjefen6 has quit IRC
[19:39:37] *** arv has joined #chromium
[19:39:37] *** ChanServ sets mode: +v arv
[19:40:20] *** sjefen6 has joined #chromium
[19:40:22] *** malavv has quit IRC
[19:44:19] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[19:49:19] <XDS|Onyx|CM5> could someone give me a hand with a broken Chrome / Chromium extension . Just need a little guidance.
[19:51:23] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules XP (dbg)" from 51861: agl at chromium dot org, cbentzel at chromium dot org, rsesek at chromium dot org)
[19:51:34] <rsesek> not it
[19:52:56] <agl> not it (no code change)
[19:53:05] <cbentzel> Mine was a supression. I don't believe agl's SSL change would have an impact.
[19:53:38] <cbentzel> OK, I'll probably open soon then, and assume this is just a flake.
[19:53:38] <evmar> i am sad that net_unittests has gone the ui_tests route of flakiness
[19:54:25] *** fta_ has joined #chromium
[19:54:33] <atwilson> Is there a list anywhere of upcoming webkit gardeners? I can look at the calendar, but there's no way to see who the gardeners are without having to individually click on 50+ events.
[19:54:48] <agl> cbentzel: it's a flake if you look at the code of the test
[19:54:50] *** fta has quit IRC
[19:55:04] <agl> cbentzel: "TODO(erikkay): Without this sleep, the recv seems to fail a small amount of the time"
[19:55:07] *** fta_ is now known as fta
[19:55:15] <cbentzel> agl: Ouch, OK
[19:56:14] <phajdan-jr|afk> sleep in the codebase? yuck.
[19:56:20] *** phajdan-jr|afk is now known as phajdan-jr
[19:56:27] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[19:56:44] <evmar> that test should be shot
[19:56:55] <evmar> better to not test the code than have that kind of unpredictability, i say
[19:57:12] <phajdan-jr> evmar: Sleep is easily grepabble, at least.
[19:57:23] <phajdan-jr> by the way, does it show up on the flakiness dahsboard?
[19:57:45] *** nkolba has joined #chromium
[19:58:07] * phajdan-jr received the "Tree is closed dude!" message third time today
[19:58:11] * trungl hands evmar a gun.
[19:59:13] <cbentzel> Oops, may close again with the compile failures
[19:59:59] <cbentzel> evan: It looks like r51862 introduced compilation problems
[20:00:38] <evmar> yay
[20:00:49] <evmar> haha
[20:01:31] <trungl-bot> Tree closed by cbentzel at chromium dot org: Tree is closed (waiting for compile revert)
[20:01:37] <evmar> one sec
[20:02:57] *** tonikitoo has quit IRC
[20:03:04] *** tonikitoo has joined #chromium
[20:03:36] <phajdan-jr> cbentzel: do you have logs for the latest TelnetServer test failure?
[20:04:26] *** [Nef] has joined #chromium
[20:04:50] <evmar> phajdan-jr: http://codereview.chromium.org/2901003
[20:05:34] <fta> is anyone working on the issues caused by cairo 1.9.10+?
[20:05:36] *** jamesr has joined #chromium
[20:05:36] *** ChanServ sets mode: +v jamesr
[20:05:52] <evmar> fta: estade wrote a change, but i don't understand it
[20:06:02] <evmar> fta: i was sorta hoping someone else would review it
[20:06:16] <evmar> fta: i am considering installing maverick on my primary desktop to try to catch this sort of thing sooner
[20:06:30] <phajdan-jr> evmar: could you file and link a bug for that CL
[20:06:46] <thakis> andybons: thanks for aligning top and bottom edges of the reload etc buttons with the omnibox edges
[20:06:55] <cbentzel> evmar: It was a different test that was flaking
[20:07:18] <fta> phajdan-jr, for that cairo thing, there's already a bug
[20:07:19] <evmar> cbentzel: which?
[20:07:27] <cbentzel> evmar: the one in net/base/telnet_server_unittest.cc (due to the listen_socket_unittest)
[20:07:40] <phajdan-jr> fta: I know. I was referring to evmar's flakiness CL. Sorry about the confusion.
[20:07:48] <fta> oops
[20:07:56] <phajdan-jr> np
[20:07:59] <cbentzel> evmanr: Thanks for marking FLAKY though, beat me to it.
[20:08:02] <evmar> cbentzel: haha, the same comment is copypasta
[20:08:17] *** nkolba has quit IRC
[20:08:30] <cbentzel> evmar: OK. It looks like you added a fix for 51862 - I'll open tree soon
[20:09:21] <andybons> thakis: the overall chrome height is now 4px shorter than safari's
[20:09:43] <thakis> andybons: i'm a bit confused by the dropdown triangle missing on the wrench menu
[20:09:45] <thakis> but oh well
[20:10:00] <thakis> dhollowa: i got "[30237:267:1133362674037377:FATAL:/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/renderer_host/render_view_host.cc(1662)] Check failed: autofill_query_id_ == query_id (2 vs. 1)" on my trunk build
[20:10:05] <thakis> known problem? worth worrying about?
[20:10:13] *** aroben|lunch is now known as aroben
[20:10:42] <dhollowa> thakis: no, and yes.  i'll look.  thanks.
[20:11:18] <andybons> thakis: yeah. that's all cole. i like how it takes less space
[20:11:36] <andybons> thakis: but stuff will grow on me, stuff won't. oh well.
[20:11:47] * rohitrao syncs to see the new pretty, maybe
[20:12:26] <rohitrao> mihai was commenting that the toolbar felt too tall now
[20:12:28] <thakis> andybons: true, but now it looks like the reload/back buttons. but wrench shows a menu on click while back shows one on hold (and reload is just a regular button)
[20:12:56] *** bauerb has quit IRC
[20:13:44] <andybons> thakis: i think it's still up in the air. we're trying it out to see how it feels and if we want then we change it.
[20:13:49] <thakis> andybons: with bookmarks and tabs open, we match safari's upper chrome height. without bookmarks, we're slightly aheard
[20:14:03] <thakis> andybons: if you're keeping votes, i think i like the triangle :-P
[20:14:03] <rohitrao> upper chrome?
[20:14:13] <thakis> rohitrao: tabs + toolbar + bookmark bar
[20:14:13] <rsesek> TopChrome
[20:14:15] <rohitrao> thakis: I'm also pro-triangle :P
[20:14:22] <rohitrao> is that like TopSites?
[20:14:24] <rohitrao> or TopCoder?
[20:14:33] <rsesek> label:TopChrome in crbug
[20:14:42] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[20:15:00] <rohitrao> cazy
[20:15:03] <rohitrao> crazy
[20:17:21] *** AaronMT has quit IRC
[20:17:42] <andybons> rohitrao, thakis: Everyone loves the triangle. It loves you, too.
[20:17:59] <thakis> andybons: i do feel loved
[20:18:48] <rsesek> feel the geometric bliss of being in love with and being loved by a triangle
[20:19:07] <thakis> trungl: are you in jail?
[20:19:23] <thakis> trungl: ping ping ping ping
[20:19:44] *** pinkerton has joined #chromium
[20:19:44] *** ChanServ sets mode: +v pinkerton
[20:19:52] <trungl> thakis: i'm actually out of the country
[20:20:01] <thakis> trungl: wat
[20:20:05] <trungl> at an undisclosed location
[20:20:05] <thakis> trungl: where?
[20:20:08] <thakis> trungl: why?
[20:20:13] <thakis> trungl: how?
[20:20:15] <thakis> trungl: since when?
[20:20:17] <trungl> which may or may not involve prison
[20:20:19] <thakis> trungl: for how long?
[20:20:29] <trungl> so many questions
[20:20:37] <thakis> i can't believe they let you get away
[20:20:46] <trungl> where: NDIP
[20:20:54] <trungl> why: why not?
[20:21:06] <trungl> how: hitchhiking
[20:21:07] <thakis> trungl: anyway, danno wants to talk to you. he's in your office. get here. fast.
[20:22:00] <thakis> trungl: http://acronyms.thefreedictionary.com/NDIP : "NDIP	National Dental Inspection Programme"
[20:22:11] <fta> evmar, estade: i can probably land the cairo patch in my dailies, or just build locally and test..
[20:22:13] <thakis> trungl: what's wrong with your teeth anyhow
[20:22:14] <thakis> ?
[20:23:00] <evmar> fta: the patch might fix things, but i'd like to understand why it does or doesn't first :)
[20:23:05] <evmar> estade: ^^^
[20:23:13] <trungl> since when: I guess I arrived early Saturday
[20:23:27] <trungl> for how long: until Sunday
[20:25:09] <evmar> trungl: short trip
[20:25:23] <trungl> haha
[20:26:41] *** kinuko has joined #chromium
[20:26:41] *** ChanServ sets mode: +v kinuko
[20:27:28] <trungl> knowing the country apparently helps in figuring out where ndip is
[20:28:05] <trungl> (or even being in the country, since google helpfully routes you to a country-specific site)
[20:28:29] <trungl> or rather, the omnibox does
[20:29:11] *** lnostdal has quit IRC
[20:29:13] *** nkolba has joined #chromium
[20:30:14] <thakis> trungl: i remember you told me where you are
[20:30:22] <thakis> i'll send danno your way
[20:31:58] <trungl> NDIP is surely even more specific
[20:32:26] <trungl> though not quite specific enough for someone to find me by going door-to-door
[20:33:19] <thakis> "excuse me sir, i'm looking for the guy who's working on plugins in chrome. haven't seen him? thanks, i'll try next door."
[20:33:26] *** rafaelw2 has joined #chromium
[20:33:26] *** ChanServ sets mode: +v rafaelw2
[20:33:29] *** pathorn has joined #chromium
[20:33:29] *** ChanServ sets mode: +v pathorn
[20:34:19] <jam2> does anyone know when the next weebkit roll will happen?  it's been a while
[20:35:12] <tonyg-cr> jam2: there is some badness going on w/ refptr right now which i think it making the roll tricky
[20:35:25] <tonyg-cr> jam2: pkasting's didn't work last night
[20:35:51] <pkasting> Yeah unfortunately Darin Adler enabled some assertions upstream that tons of our code apparently breaks
[20:35:52] <jcastro> hi evmar, have you had a chance to check out appmenu-gtk? It's working pretty well now
[20:35:57] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "XP Tests (dbg)(1)" from 51864: evan at chromium dot org (:evmar))
[20:36:04] *** rafaelw2 is now known as rafaelw
[20:36:08] <thakis> perfect timing on my check in!
[20:36:18] <pkasting> vitalyr is working on fixing the issues in our code to allow us to move forward
[20:36:35] <evmar> ffffff
[20:37:19] <evmar> i think that may be flake
[20:37:26] *** eseidel has joined #chromium
[20:37:54] <vitalyr> all adoptRef misuse assertions now seem to be fixed
[20:37:55] <evmar> Backtrace: RevokeDragDrop [0x77532BE5+144] (No symbol) [0x02500080]
[20:38:06] <evmar> that does not seem like the kind of backtrace a filepath change would induce
[20:38:09] <vitalyr> some deletion has begun assertions still remain...
[20:38:36] <cbentzel> evmar: I agree
[20:39:05] <jam2> ah thanks for the update, that suck
[20:39:06] <jam2> s
[20:40:11] *** nkolba has quit IRC
[20:40:34] <cbentzel> tonyg-cr: Any problem with me opening the tree? I'll enter a bug for SizeAndLayout if it was just a flake.
[20:40:45] *** malavv has joined #chromium
[20:40:59] <tonyg-cr> cbentzel: sgtm
[20:41:06] *** fta_ has joined #chromium
[20:41:55] <cbentzel> tonyg-cr: what was the cool trungl-bot command to set tree status
[20:42:03] <thakis> trungl-bot: halp
[20:42:03] <trungl-bot> thakis: Valid commands (use "halp <command>" for more): bug, commit, commits, cookie, fortune, halp, help, lkgr, offices, settreestatus, time, treestatus, uptime, webkitbug, webkitcommit, webkitcommits, whois. (If you whisper to me, I'll whisper back.)
[20:42:04] <tonyg-cr> settreestatus
[20:42:06] <thakis> cbentzel: ^
[20:42:25] <cbentzel> trungl-bot: settreestatus Tree is Open
[20:42:25] <trungl-bot> cbentzel: Sorry, you must have voice in #chromium to set the tree status.
[20:42:27] *** fta has quit IRC
[20:42:33] *** fta_ is now known as fta
[20:42:42] <cbentzel> guess I need to learn irc commands
[20:42:53] <tonyg-cr> rvargas: did 51858 cause problems for linux memory_test?
[20:42:58] *** markmentovai has joined #chromium
[20:42:58] *** ChanServ sets mode: +v markmentovai
[20:43:01] <rohitrao> cbentzel: ask evmar for voice
[20:43:05] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[20:43:30] *** phajdan-jr is now known as phajdan-jr|afk
[20:43:35] <trungl> anyone with voice can give voice
[20:43:46] <rohitrao> oh
[20:43:50] <rohitrao> I have the power!
[20:43:51] <trungl> cbentzel: are you registered?
[20:44:01] <trungl> (and log in with a password?)
[20:44:20] <cbentzel> trungl: I am not. (I'm assuming you mean IRC rather than chromium.org account)
[20:44:33] <trungl> yes
[20:44:36] <trungl> you should probably register
[20:44:54] <trungl> so that someone else doesn't come along and claim to be cbentzel
[20:45:23] *** Lantizia has quit IRC
[20:45:44] <cbentzel> trungl: OK.
[20:45:45] *** bryner has joined #chromium
[20:45:45] *** ChanServ sets mode: +v bryner
[20:46:10] <thakis> cbentzel: search gmail for 'Reminder: getting the "+" marker on IRC'
[20:47:38] <rvargas> tonyg-cr: I saw that... and was waiting for the second run of chromium to finish (the regular linux bot fixed itself the next run)... I don't see how can it be :(
[20:48:44] <bryner> sorry if this is answered somewhere... it looks like the try server is using a rev that doesn't build on windows.  will it move to a newer rev on its own?
[20:49:01] *** vitalyr has quit IRC
[20:49:17] <thakis> bryner: use `git try --r $REVISION`
[20:49:17] <pkasting> tonyg-cr: What problems did my chrome_tests.gypi change cause?
[20:49:21] <tonyg-cr> rvargas: it has failed twice on the waterfall console now ? want to wait one more and see if it happens again?
[20:49:31] <pkasting> tonyg-cr: (That you rolled back last night)
[20:49:40] <bryner> thakis: ah, cool thanks
[20:50:01] <tonyg-cr> pkasting: a linker error in gtk ? i'll see if i can find the message still
[20:50:05] <thakis> bryner: it should never use a revision that doesn't build tho, only one that your patch doesn't apply cleanly against. if the build fails, reply to the try server mail and maruel will fix this
[20:50:21] <rvargas> tonyg-cr: yes, please.
[20:50:59] <trungl> sometimes --clobber is needed on the trybots
[20:51:11] <trungl> and sometimes the trybots aren't smart enough to figure that out for themselves
[20:51:33] <bryner> thakis: oh, well it could be that i'm misunderstanding, but if it's using rev 51845, i can see on the main continuous build page that the compile failed at that rev, and was fixed at 51846
[20:51:58] <thakis> bryner: the try bots should use lkgr
[20:52:01] <thakis> trungl-bot: lkgr
[20:52:02] <trungl-bot> thakis: 51845
[20:52:24] <trungl> lkgr fail?
[20:52:27] <thakis> lkgr is "last known good revision" and should never be a rev with compile failures :-)
[20:52:43] <thakis> maruel: ^ lkgr broken?
[20:53:52] *** rafaelw has quit IRC
[20:54:16] <cbentzel> tonyg-cr: I need to step out for the next half hour
[20:54:28] <tonyg-cr> cbentzel: i'll be here
[20:54:41] <tonyg-cr> pkasting: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(Views%20dbg)/builds/11734/steps/compile/logs/stdio
[20:55:53] <pkasting> thanks
[20:57:09] *** duffydack has joined #chromium
[20:57:23] *** duffydack has left #chromium
[20:59:47] *** jamesr has quit IRC
[21:00:31] <maruel> thakis: interesting
[21:00:41] <maruel> maybe someone changed it manually?
[21:00:46] <maruel> or reforced a build?
[21:00:55] *** mrossetti has joined #chromium
[21:00:55] *** ChanServ sets mode: +v mrossetti
[21:00:58] <maruel> or I don't know
[21:01:11] <trungl> you can change the lkgr manually?
[21:01:23] <trungl> (well, evidently, with sufficient privileges, this must be possible)
[21:02:08] *** cbentzel has quit IRC
[21:04:06] *** cbentzel has joined #chromium
[21:07:20] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 51871: estade at chromium dot org)
[21:07:27] <tonyg-cr> rvargas: third failure
[21:07:51] *** pinkerton has quit IRC
[21:08:18] *** pinkerton has joined #chromium
[21:08:18] *** ChanServ sets mode: +v pinkerton
[21:08:46] *** dpranke has joined #chromium
[21:08:46] *** ChanServ sets mode: +v dpranke
[21:09:20] *** jshin has joined #chromium
[21:09:21] *** ChanServ sets mode: +v jshin
[21:10:53] <rvargas> tonyg-cr: reverted
[21:11:15] <tonyg-cr> estade: I don't think your change caused the compile failure, it couldn't create the DRT exe, which probably means bot problem
[21:11:23] <tonyg-cr> rvargas: thanks, we'll see what happens
[21:11:28] *** rafaelw2 has joined #chromium
[21:11:28] *** ChanServ sets mode: +v rafaelw2
[21:11:47] *** rafaelw2 is now known as rafaelw
[21:12:22] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (bot problems?)
[21:12:29] <rvargas> tonyg-cr: there was also the reliability crash.
[21:12:51] *** pinkerton has quit IRC
[21:13:02] <tonyg-cr> estade: looks like it recovered already
[21:13:10] *** fta_ has joined #chromium
[21:13:26] *** [Nef] has quit IRC
[21:13:50] <tonyg-cr> rvargas: thanks, i see that now too
[21:14:24] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open
[21:14:47] *** [Nef] has joined #chromium
[21:15:07] *** fta has quit IRC
[21:15:18] *** fta_ is now known as fta
[21:15:42] *** eseidel has quit IRC
[21:15:52] *** eroman has joined #chromium
[21:15:52] *** ChanServ sets mode: +v eroman
[21:16:22] *** Venom_X is now known as Venom_bbiab
[21:18:40] *** SkyLined has joined #chromium
[21:20:32] *** lnostdal has joined #chromium
[21:23:57] *** sebmarkbage has joined #chromium
[21:24:41] *** SkyLined has quit IRC
[21:25:02] *** SkyLined has joined #chromium
[21:25:09] <pkasting> cbentzel, tonyg-cr: I just checked in a change that temporarily comments out most of the suppressions in the reliability bot known crashes list
[21:25:25] <tonyg-cr> pkasting: that sounds like fun
[21:25:25] <dhollowa> thakis: ping
[21:25:26] *** bmizerany has joined #chromium
[21:25:35] <thakis> dhollowa:
[21:25:35] <pkasting> cbentzel, tonyg-cr: The goal is to find which still apply and which can really be removed.  I expect the bot to go red, and I'll be watching it.
[21:25:47] <dhollowa> thakis: addresses the DCHECK: http://codereview.chromium.org/2945003
[21:25:48] <tonyg-cr> pkasting: aren't many of them flaky?
[21:26:10] <estade> tonyg-cr: thanks for being on top of it:)
[21:27:23] <thakis> dhollowa: isn't there someone familiar with that code to review this? :-P
[21:27:41] <dhollowa> thakis: sure, no problem.
[21:28:20] <thakis> dhollowa: cl makes sense to me, but i don't have experience in that area of the code yet
[21:28:30] <dhollowa> thakis: understood.
[21:28:54] *** SkyLined2 has joined #chromium
[21:30:31] *** SkyLined3 has joined #chromium
[21:31:38] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Vista" from 51877: eroman at chromium dot org (:eroman), jrg at chromium dot org)
[21:31:41] *** elmargol_ has quit IRC
[21:31:51] *** elmargol has joined #chromium
[21:31:52] <dhollowa> thakis: any chance you could patch it in to repro?  i hit it once but was difficult to manually verify.
[21:31:59] *** SkyLined has quit IRC
[21:32:09] *** erikchen has joined #chromium
[21:32:10] *** ChanServ sets mode: +v erikchen
[21:32:35] <thakis> dhollowa: i hit it only once too
[21:32:54] <tonyg-cr> eroman: did your change break net_unittests?
[21:32:57] <jrg> tonbyg sehr cbentzel: are you on tree closure?   My change was mac only.  eroman's change appeared networking-related
[21:33:12] <eroman> tonyg-cr: i doubt it, hasnt that spdy test been flaking for a while?
[21:33:14] *** FullFlannelJacke has quit IRC
[21:33:19] <dhollowa> ok, the unit test covers it...  no problem.
[21:33:27] *** SkyLined2 has quit IRC
[21:33:56] *** chronarion has joined #chromium
[21:33:56] *** ChanServ sets mode: +v chronarion
[21:33:56] *** eseidel has joined #chromium
[21:34:02] <tonyg-cr> eroman: i think this is different (could be wrong)
[21:35:12] <tonyg-cr> eroman: next run will be ready in a few minutes - let's wait and see
[21:35:18] *** FullFlannelJacke has joined #chromium
[21:35:24] *** SkyLined3 has quit IRC
[21:35:25] *** terinjokes has joined #chromium
[21:36:40] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (waiting to see if net_unittests is a flake)
[21:38:38] <tonyg-cr> eroman: failed again, want to try a rollback
[21:38:51] *** Buglouse has joined #chromium
[21:38:54] <terinjokes> I'm on a mac using Flash for Chrome, but have noticed that normally if a flash application as ctrl keybindings, that these are normally auto-mapped to cmd. This isn't the case with Flash for Chrome
[21:39:28] <thakis> stuartmorgan: ^ (terinjokes )
[21:39:41] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (net_unittests -> eroman)
[21:39:45] <eroman> tonyg-cr: you can re-open while i investigate
[21:40:44] <eroman> makes no sense to my why that woudl fail tho
[21:42:07] *** cbentzel has quit IRC
[21:42:17] *** loislo has quit IRC
[21:42:33] <tonyg-cr> eroman: yeah your code does seem kind of far from that, but i haven't seen it flake out at all
[21:42:44] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (net_unittests -> eroman)
[21:42:50] <tonyg-cr> eroman: and jrg's is mac-only
[21:42:51] *** cbentzel has joined #chromium
[21:43:41] *** pfeldman has quit IRC
[21:43:43] *** eseidel has quit IRC
[21:43:59] *** jamesr has joined #chromium
[21:43:59] *** ChanServ sets mode: +v jamesr
[21:45:51] <cbentzel> tonyg-cr: I'm back now
[21:46:51] *** maikmerten has quit IRC
[21:47:56] <cbentzel> tonyg-cr: has anyone been assigned to the heapcheck net failures?
[21:48:23] *** sbyer has quit IRC
[21:48:32] *** eseidel has joined #chromium
[21:48:32] *** andrix1 has joined #chromium
[21:49:33] *** andrix has quit IRC
[21:49:41] <tonyg-cr> cbentzel: i don't think so, i've mainly been watching the console
[21:49:56] *** michaeln has joined #chromium
[21:49:56] *** ChanServ sets mode: +v michaeln
[21:50:37] *** Aikar has joined #chromium
[21:51:02] *** himikov has joined #chromium
[21:51:30] <Aikar> are there any set in stone limitations on webworkers in chrome? I was trying to spawn alot of workers but then noticed its an external process for every worker, but theres def not as many processes as workers i tried to spawn, and majority of the workers appear to not be functioning
[21:51:49] *** MichealH has joined #chromium
[21:52:00] *** himikof has quit IRC
[21:52:02] <rsesek> dmaclach: ping
[21:52:08] *** MoonGlorious has quit IRC
[21:53:59] <cbentzel> tonyg-cr: OK, I'll look at it.
[21:54:02] <jam2> Aikar: y eah there's a limit of 20 processes
[21:54:25] <Aikar> to webworkers specifically or chrome in general?
[21:54:53] <dmaclach> rsesek: pong
[21:55:02] <Aikar> http://code.google.com/p/chromium/issues/detail?id=37518&q=web%20workers&colspec=ID%20Stars%20Pri%20Area%20Feature%20Type%20Status%20Summary%20Modified%20Owner%20Mstone%20OS  this guy said he could get 16
[21:55:59] <rsesek> dmaclach: I'm trying to use GTMUILocalizerAndLayoutTweaker with a NSSegmentedControl and it doesn't seem to get localized; this is needed for M6 wrench menu stuff. known issue? should I file a bug on chromium or in gtm (where I don't think I can assign to you)?
[21:56:36] <dmaclach> file it against GTM please, and I'll handle the assignment and take a look
[21:56:47] <rsesek> dmaclach: okay will do, thanks!
[21:57:10] <dmaclach> rsesek: since TVL is AWOL ;-)
[21:57:16] <rsesek> I know :(
[21:58:56] <rsesek> dmaclach: http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=53
[22:00:11] <dmaclach> rsesek: updated and assigned. Thanks.
[22:00:16] <rsesek> thank you :)
[22:03:04] <tonyg-cr> awong: I think your r51857 broke some PPAPITest on linux ui_tests
[22:03:17] *** romainhuet has quit IRC
[22:04:52] <Aikar> ok so, if theres a 20 proc limit, shouldnt WebWorkers be divying up threads between the webworker processes if it hits the 20 cap instead of just dieing silently?
[22:05:30] <jam2> Aikar: v8 doesnt support multi-threading now
[22:05:32] *** shepazutoo has joined #chromium
[22:05:41] <jam2> that's why they're in different processes
[22:05:43] <jam2> it's being owrked on
[22:05:49] <Aikar> cause this is bad, what if user has 19 tabs open and goes to a site that tries to spawn 5 threads...
[22:05:59] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 51882: rsimha at chromium dot org)
[22:06:23] *** bers has joined #chromium
[22:06:36] <Aikar> im not seeing any exceptions or anything, so how else would the dev know a worker has failed to be created :/
[22:06:53] *** shepazu has quit IRC
[22:07:41] <Aikar> or is it 20 per site? cause i do notice more than 20 processes
[22:08:27] <atwilson> Aikar: There is a 16-worker-per-tab limit
[22:08:39] <atwilson> With an overall total of 64, I believe.
[22:08:59] *** XDS|Onyx|CM5 has quit IRC
[22:09:00] <atwilson> We may change these limits in the future if/when v8 supports multi-threading.
[22:09:02] <cbentzel> rsimha: Do you plan to revert?
[22:09:15] <cbentzel> rsimha: Looks like you may not have merged with evmar's changes earlier.
[22:09:44] *** jshin has quit IRC
[22:09:59] <atwilson> Aikar: You shouldn't see any worker "dying silently", btw. What happens is, if you try to create workers beyond the limit, the creation of those workers is queued up until one of the other workers closes.
[22:10:17] <Aikar> ah ok
[22:10:29] <tonyg-cr> Does anyone know rsimha's IRC nic? It isn't on http://code.google.com/p/chromium/wiki/UserHandleMapping
[22:10:32] <atwilson> Since the HTML5 spec doesn't guarantee anything about timeliness of worker creation, this is technically valid behavior.
[22:10:47] <atwilson> although obviously non-ideal.
[22:10:53] <cbentzel> tonyg-cr: I'll just start the revert myself.
[22:11:00] <tonyg-cr> cbentzel: perfect
[22:11:01] <thakis__> is there a document on how to add a new grd file?
[22:11:04] <awong> tonyg-cr: let me take a look at 51857
[22:11:11] <tonyg-cr> awong: thanks
[22:11:33] <tonyg-cr> awong: there is a fair bit of redness, so if it looks likely and isn't trivial, would you mind reverting while you look into it?
[22:11:50] <awong> yeah, give me a couple of secs
[22:11:59] <tonyg-cr> awong: sure, np
[22:12:53] <Aikar> well we wanted  quick implementation to see performance gains so was doing 1 thread per object calculating which in this case was 250 lol. before we knew it would be multi processes...
[22:13:05] <Aikar> so now ima start working on a pool i guess
[22:13:36] <awong> tongy-cr: reverting.  I have no clue why that would break that test.
[22:14:33] *** kurrik has joined #chromium
[22:14:33] *** ChanServ sets mode: +v kurrik
[22:15:06] <jam2> hey, if it's a ppp test, you can also disable the test
[22:15:09] <jam2> brett or i can take a look at it
[22:15:16] <jam2> i knwo the webkit roll is a mess right now
[22:15:23] <tonyg-cr> awong: I don't either, I just saw that it was a PPAPI test and your change touched PPAPI
[22:15:25] <cbentzel> tonyg-cr: Mind if I open the tree now that the revert is in?
[22:15:38] <tonyg-cr> cbentzel: sgtm
[22:16:00] *** vitalyr has joined #chromium
[22:16:19] <awong> tonyg-cr: The weirdness is that my change is one layer lower.  I use PPAPI, but this is testing the actual PPAPI implementation which I shouldn't affect. Reverting is easy, so doing now.
[22:17:06] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open (Should cycle green after revert)
[22:20:01] *** andrix1 has quit IRC
[22:20:15] *** phajdan-jr|afk has quit IRC
[22:21:00] <nirnimesh> my try job in win fails with "...chrome\grit/google_chrome_strings.h(57) : error C2220: warning treated as error - no 'object' file generated". ANy ideas?
[22:21:13] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux x64" from 51883: robertshield at chromium dot org, rsimha at chromium dot org, shess at chromium dot org, willchan at chromium dot org)
[22:21:19] <stuartmorgan> terinjokes: what does "normally" mean; what browser and what version of Flash?
[22:21:49] <terinjokes> ie, the standard OS-provided flash
[22:21:54] <cbentzel> re-opening tree, same compile issue that I reverted
[22:22:07] <stuartmorgan> terinjokes: So, Flash 10.0?
[22:22:14] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (cycling green)
[22:22:16] <terinjokes> 10.1, yes
[22:22:59] <stuartmorgan> terinjokes: 10.1 != 10.0. The version of Flash that came with the OS was 10.0. Have you installed 10.1 yourself?
[22:23:14] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (compile cycling green, net_unittests -> eroman)
[22:23:27] <terinjokes> yes, i guess i must have... doesn't matter, same features have been there since at least Flash 9
[22:24:16] <stuartmorgan> terinjokes: It does matter; 10.1 and 10.0 don't handle events the same way at all, and you are talking about Flash behavior
[22:24:34] *** fta_ has joined #chromium
[22:24:57] <stuartmorgan> terinjokes: so if you use the bundled Flash 10.1 in Chrome you don't get this behavior, but if you use non-bundled Flash 10.1 (the same version as ships with Chrome) in Chrome, you do?
[22:25:21] *** fta has quit IRC
[22:25:28] <terinjokes> exactly... expected behavior that's been there for a while
[22:25:32] *** fta_ is now known as fta
[22:25:54] <terinjokes> as I was waiting for a response, i was messing around, and have noticed that correct behavior returns if you flip to another tab and return
[22:25:57] *** malavv has quit IRC
[22:26:19] *** malavv has joined #chromium
[22:27:23] <stuartmorgan> terinjokes: please file a bug then, with all this information, the exact versions of Flash and Chrome, and an example site where this can be reproduced
[22:28:19] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (compile cycling green, net_unittests -> eroman, reliability -> pkasting)
[22:28:22] <tonyg-cr> pkasting: you are starting to get some of your reliability results
[22:29:26] <pkasting> tonyg-cr: Not yet I'm not
[22:29:40] <pkasting> tonyg-cr: The partial result of the current run hasn't come out yet
[22:29:51] <tonyg-cr> pkasting: there is some incomplete output
[22:30:27] <pkasting> tonyg-cr: The incomplete output is "waiting for results"
[22:30:42] <pkasting> tonyg-cr: Make sure you're not looking at "complete result of previous build"
[22:31:14] <maruel> sent mass clobbers to the win try slaves
[22:31:21] <maruel> they are really slow these days :(
[22:31:23] <tonyg-cr> pkasting: oops, you are right
[22:34:12] <malavv> Hey Maruel, can you push this on the try-bots for me please? http://codereview.chromium.org/2487001
[22:36:55] *** MikeSmithW3C^ has quit IRC
[22:38:28] *** danno_ has joined #chromium
[22:38:28] *** ChanServ sets mode: +v danno_
[22:39:21] <terinjokes> stuartmorgan: Issue 48589
[22:39:31] *** mrossetti has quit IRC
[22:39:35] *** rohitrao has quit IRC
[22:39:59] <stuartmorgan> terinjokes: thanks
[22:40:11] <terinjokes> np
[22:40:27] *** hrna has quit IRC
[22:40:43] *** AaronMT has joined #chromium
[22:41:14] *** shreyas_ has joined #chromium
[22:41:16] <stuartmorgan> terinjokes: is d81 the Gala pre-release?
[22:42:27] *** shreyas_ has quit IRC
[22:43:15] <stuartmorgan> terinjokes: nm, found it
[22:43:30] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Mac" from 51882: eroman at chromium dot org (:eroman), estade at chromium dot org, jrg at chromium dot org, pkasting at chromium dot org, robertshield at chromium dot org, rsimha at chromium dot org, rvargas at google dot com, shess at chromium dot org)
[22:45:03] <tonyg-cr> same failure again, opened
[22:45:18] <cbentzel> tonyg-cr: Thanks, beat me to it.
[22:45:30] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (net_unittests -> eroman, reliability -> pkasting)
[22:48:29] <andybons> akalin, cbentzel: seems like the timeouts on the 10.6 bots for extension tests are not any one test-specific.
[22:49:04] <andybons> akalin: disregard my last.
[22:49:33] <andybons> vandebo: ^^^ do you know by chance when the 10.6 bots started timing out?
[22:50:04] <rsesek> trungl: ping
[22:50:26] <vandebo> I don't recall anything specific about timing out tests
[22:50:34] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (reliability -> pkasting)
[22:50:39] <tonyg-cr> eroman: yay, greenness
[22:51:01] <andybons> vandebo: http://crbug.com/48151
[22:51:21] <eroman> tonyg-cr: i just suppressed it :(
[22:52:19] *** AaronMT has quit IRC
[22:52:53] <vandebo> I just noticed it as sporadic flakiness - that was the first day of my rotation, so it started wither Jul 1, or with the previous sheriff.  Sorry that's not more helpful
[22:53:32] <andybons> vandebo: no worries. thanks.
[22:54:40] <cbentzel> andybons: Sorry, I don't have any insight into the cause of the timeout problem.
[22:54:59] *** beng_ has joined #chromium
[22:55:15] <andybons> erikkay: ping
[22:56:20] <awong> ojan: ping
[22:56:24] <vitalyr> awong: the webkit_unit_tests debug failure on win should be fixed in webkit r62831
[22:56:39] <ojan> awong: what's up?
[22:56:47] <malavv> Does someone have time to push http://codereview.chromium.org/2487001 on the trybots for me please?
[22:56:48] <awong> vitalyr: cool. thanks.  So given all the changes, should we actually try to jump to ToT in the next roll?  That's like 100+ revisions
[22:57:03] <awong> ojan: http://build.chromium.org/buildbot/waterfall.fyi/changes/34843 seems to have broken the mac webkit canary.  Do you know anything about that?
[22:57:51] <vitalyr> awong: yeah, sounds scary. but my last try run was successful modulo the webkit_unit_tests failure and the newly added ie layout tests.
[22:58:36] <vitalyr> awong: do you think you could try rolling to ToT? (it's getting late here...)
[22:58:38] <awong> vitalyr: okay.  There's one more mac failure to fix, and then I can try doing the big jump.
[22:58:57] <ojan> awong: are you sure that was the cause of the build brake?
[22:58:57] *** Olytibar has joined #chromium
[22:58:57] <awong> vitalyr: yep, I'll take it from here.  Thanks for getting everything in order
[22:59:08] <awong> ojan: pretty sure...
[22:59:10] *** cbentzel has quit IRC
[22:59:11] <awong> http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/21961/steps/compile/logs/stdio
[22:59:21] *** Olytibar has left #chromium
[22:59:48] <awong> ojan: We're getting unresolved symbols on WebCore::SelectionController::setSelection.  I think your revision changed the function signature there.
[23:00:31] <ojan> oh...yeah, that is my changed. i got distracted by the RenderMediaControlsChromium error
[23:00:35] <vitalyr> awong: ah, i see.
[23:00:37] <andybons> stuartmorgan: ping
[23:00:54] <stuartmorgan> andybons: pong
[23:01:32] <andybons> stuartmorgan: do you remember seeing timeouts in browser_tests on the 10.6 bots when you were sheriffing 6/29 and 6/30?
[23:01:34] <vitalyr> awong: so once again to sum up the refcounded failures: adoptRef-related ones should be now fixed
[23:01:42] *** Venom_bbiab is now known as Venom_X
[23:02:27] <andybons> stuartmorgan: something like http://crbug.com/48151
[23:02:29] <vitalyr> awong: there were also a few assertion failres related to refcouned requiring deref before it can be deleted
[23:02:53] <vitalyr> awong: i fixed the ones that showed up on my linux box and in my try runs.
[23:02:56] <stuartmorgan> andybons: not that I recall, no
[23:02:59] <ojan> awong: hm...not sure why it's not linking. i added an optional argument to the method in question.
[23:03:28] *** cbentzel has joined #chromium
[23:03:31] <stuartmorgan> andybons: but I wouldn't swear it wasn't happening if it was flaky
[23:03:46] <awong> vitalyr: Cool. So it should clear for a roll again, minus whatever incremental layout tests failures have crept in
[23:04:06] <andybons> stuartmorgan: we have non-deterministic timeouts on the extension api stuff happening on 10.6, but not on 10.5
[23:04:10] <awong> ojan: hmm...could be an incremental link issue?
[23:04:17] <vitalyr> awong: right
[23:04:20] *** General13372 has joined #chromium
[23:04:31] <ojan> awong: that's my best guess.
[23:04:33] <andybons> stuartmorgan: just wondering about finding a CL so if you had seen it when you were sherriff.
[23:04:37] <ojan> awong: have you tried a clobber?
[23:04:49] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder x64" from 51890: jamesr at chromium dot org)
[23:05:04] <jamesr> :<
[23:05:12] <awong> vitalyr: Cool. I'll prep for a roll then.  Have a good night!
[23:05:13] <jamesr> on it
[23:05:20] <jamesr> blaaaaah
[23:05:30] <vitalyr> vitalyr: thanks and good luck!
[23:05:42] <vitalyr> awong: oops :)
[23:05:44] <vitalyr> awong: thanks and good luck!
[23:06:07] <awong> ojan: not yet.  Would it be okay to roll out the change instead?  I'd like to try for this huge roll since vitalyr just got things roughly stable.
[23:06:12] <awong> vitalyr: thanks!
[23:06:16] <jamesr> sheriffs: build break is me, fix eta 60 seconds
[23:06:32] <tonyg-cr> jamesr: you have 55
[23:06:39] *** General1337 has quit IRC
[23:06:50] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (compile -> jamesr, reliability -> pkasting)
[23:07:27] *** dimich has joined #chromium
[23:07:35] <jamesr> well, assuming the git mirror catches up within my 60 seconds
[23:07:54] <rsesek> jamesr: git svn fetch will pull from the writeable svn which is always up to date
[23:08:05] *** jshin has joined #chromium
[23:08:05] *** ChanServ sets mode: +v jshin
[23:08:05] *** ROBOd has quit IRC
[23:08:05] *** c3l has left #chromium
[23:08:22] *** bandu has quit IRC
[23:08:30] <ojan> awong: i really don't think this is the cuase of the compile failure. upstream, RenderMediaControlsChromium is failng as well, but the setSelection issue isn't there.
[23:08:35] <ojan> http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/10423/steps/compile-webkit/logs/stdio
[23:09:04] <ojan> awong: is the RenderMediaControlsChromium issue being addressed?
[23:09:39] <awong> ojan: I'm taking care of RenderMediaControlsChromium right now.
[23:11:30] *** terinjokes has left #chromium
[23:11:41] <thakis> cbentzel, tonyg-cr: can i commit a cl that adds a single png and does nothing else?
[23:11:58] <ojan> awong: can we try a clobber?
[23:11:59] *** apatrick_ has joined #chromium
[23:11:59] *** ChanServ sets mode: +v apatrick_
[23:12:05] <tonyg-cr> thakis: tree should be open in just a minute
[23:12:29] <tonyg-cr> i don't see how the png could hurt, but it really shouldn't be long
[23:12:41] <rsesek> trungl: cancel ping. the answer was |-cancelTracking|
[23:12:42] *** awolfson has quit IRC
[23:12:45] <rsesek> you can guess at the question
[23:12:47] <rsesek> :)
[23:12:52] *** MichealH has quit IRC
[23:12:55] <awong> ojan: yeah...
[23:13:00] <jamesr> crap
[23:13:06] <awong> ojan: I'll kick the bot now.
[23:13:18] *** viro101 has joined #chromium
[23:13:35] *** bandu has joined #chromium
[23:14:17] <ojan> awong: in the meantime, i'll add 5195166-1.html to test_expectations
[23:14:23] <awong> ojan: thanks
[23:14:45] <ojan> awong: sorry...didn't realize this patch would affect chromium.
[23:15:11] <awong> ojan: no worries.
[23:15:23] <jamesr> so i either committed what i wanted or i reverted eroman
[23:15:37] <jamesr> or maybe both
[23:15:41] <tonyg-cr> thakis: open for business
[23:15:46] <jamesr> not sure exactly what git svn dcommit -f decided to do there
[23:15:57] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (compile cycling green, reliability -> pkasting)
[23:16:39] *** apatrick_ has left #chromium
[23:17:58] <thakis> tonyg-cr: thanks
[23:19:55] <jamesr> apparently it did the right thing
[23:20:23] <pkasting> tonyg-cr: One run complete: only one of my commented-out crashes has surfaced so far.  Surprising.
[23:20:49] <jamesr> not every URL loads every run
[23:20:54] <jamesr> and not every crash will repro on every load
[23:21:00] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder" from 51893: eroman at chromium dot org (:eroman), jamesr at chromium dot org)
[23:21:07] <tonyg-cr> pkasting: wow, there was either a lot of cruft or a lot of flakiness
[23:21:20] *** coyo|pingout has joined #chromium
[23:21:53] <jamesr> that was from before my fix
[23:22:01] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (compile cycling green, reliability -> pkasting)
[23:22:01] *** chrisccoulson_ has joined #chromium
[23:22:21] *** thakis_ has joined #chromium
[23:22:22] *** ChanServ sets mode: +v thakis_
[23:24:13] *** bandu has quit IRC
[23:26:17] <cmasone> folks, is anyone looking at the Linux ChromiumOS compile failure?
[23:26:23] <atwilson> Did we clobber the win trybots? I keep getting errors like these, even after the clobber: 1: C:\b\slave\win\build\src\build\Debug\obj\global_intermediate\chrome\grit/google_chrome_strings.h(57) : error C2220: warning treated as error - no 'object' file generated
[23:26:28] <atwilson> Or did we just clobber the build bots?
[23:26:31] <cmasone> Something in chrome/renderer/webgles2context_impl.cc
[23:26:36] <ojan> can haz webkit review? https://bugs.webkit.org/show_bug.cgi?id=41905
[23:26:59] *** thakis__ has quit IRC
[23:27:04] <ojan> awong: ^^^ that's the "fix" for the test failure on the canaries
[23:28:33] <awong> ojan: I'm not a webkit reviewer. :(  But for chromium only test-expectaitons changes, I think you can just submit unreviewed.
[23:28:48] <ojan> oh. that's right. i forgot. thx.
[23:28:54] <awong> LGTM though ;)
[23:32:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules XP (dbg)" from 51897: eroman at chromium dot org (:eroman), jamesr at chromium dot org, thakis at chromium dot org)
[23:32:16] <thakis> pretty sure that's not me :-)
[23:32:28] <jamesr> same thing
[23:32:34] <thakis> eroman: you win
[23:32:34] <tonyg-cr> reopening
[23:32:36] <jamesr> err no
[23:32:37] <jamesr> that's eroman
[23:32:53] <tonyg-cr> oh, eroman's revert broke something?
[23:32:55] <jamesr> he reverted disabling a test
[23:32:57] <jamesr> and the test fails
[23:33:02] <jamesr> so i think he re-enabled a test that fails
[23:33:27] <cbentzel> jamesr: I think that's right
[23:33:30] <jamesr> i'm not totally unclear about the lack of double negatives
[23:34:49] <awong> The Webkit.org Builder is daying with what looks like an IncrediBuild failure.  Anyone know what to do with this? http://buildbot.jail.google.com/buildbot/waterfall.fyi/builders/Webkit.org%20Builder/builds/6756/steps/compile/logs/stdio3
[23:35:02] <tonyg-cr> oh i see, he reverted his change in 51893 and then reverted the test disable in 51897
[23:35:42] <cbentzel> tonyg-cr: Yeah, I IM'ed him. I'll prepare a FAILS cl if he doesn't respond.
[23:37:09] <trungl-bot> Tree closed by tonyg at chromium dot org (:tonyg-cr): Tree is closed (compile cycling green, net_unittests ->cbentzel/eroman, reliability -> pkasting)
[23:37:31] *** viro101 has quit IRC
[23:40:12] *** awolfson has joined #chromium
[23:40:43] *** vitalyr has quit IRC
[23:41:53] <cbentzel> I forgot how to git cl dcommit with closed tree
[23:42:30] *** jshin has quit IRC
[23:42:31] <cbentzel> rsesk: thanks
[23:42:59] *** mrossetti has joined #chromium
[23:42:59] *** ChanServ sets mode: +v mrossetti
[23:43:01] *** Zucca has quit IRC
[23:43:32] <cbentzel> tonyg-cr: OK, I re-added the FAILS prefix. Should tree open?
[23:43:47] <tonyg-cr> yeah, i think so
[23:43:50] *** eseidel_ has joined #chromium
[23:44:04] <cbentzel> tonyg-cr: OK, I'll do it and make sure it works.
[23:45:13] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open (compile cycling green, net_unittests ->cbentzel/eroman, reliability -> pkasting)
[23:45:31] *** eseidel_ has quit IRC
[23:45:56] *** fta_ has joined #chromium
[23:47:05] <tonyg-cr> cbentzel: that might have needed to be a DISABLED_ instead of FAILS_ because it was crashing ? we'll see what happens
[23:47:20] *** eseidel has quit IRC
[23:47:35] *** viro101 has joined #chromium
[23:47:37] <ojan> awong: looks like the linker error went away.
[23:47:50] <ojan> awong: thx for waiting for the clobber.
[23:47:54] <awong> ojan: awesome.
[23:48:07] <cbentzel> tonyg-cr: Ahh, OK
[23:48:11] <ojan> awong: at least...it's gotten past webkit_unit_tests, which is where it used to hit that error.
[23:48:17] *** fta has quit IRC
[23:48:24] *** Zucca has joined #chromium
[23:48:31] *** fta_ is now known as fta
[23:49:21] <awong> ojan: now...if we can just make the try servers look happy, I get to submit a 174 change roll. :-/
[23:49:36] <ojan> awong: yikes.
[23:49:50] * ojan is not looking forward to being webkit sheriff next week
[23:51:42] *** jshin has joined #chromium
[23:51:42] *** ChanServ sets mode: +v jshin
[23:52:06] <davidben> When the tree finishes churning a bit, does a sherriff mind helping me with a grd change? (Yes, this is the same one from yesterday. :-D)
[23:54:44] <eroman> wtf? thats bogus. so first buildbot blames my CL as breaking a net_unittest.... fine, i revert it
[23:54:48] <eroman> now it still fails
[23:55:16] <thakis> eroman: it wants you to revert more of your cls
[23:55:16] * eroman goes and cries in the corner.
[23:55:48] <awong> I just submitted a build to layout_mac and layout_win.  It shows i pending, but the bot is sitting idle.  Is this normal?
[23:56:16] *** kinnetica has joined #chromium
[23:56:30] <tonyg-cr> eroman, cbentzel: looks like net_unittests cleared up before 51900
[23:57:29] <cbentzel> tonyg-cr, eroman: ummm, let me look.
[23:58:22] <trungl-bot> Tree opened by tonyg at chromium dot org (:tonyg-cr): Tree is open (reliability -> pkasting)
[23:59:31] *** awong_ has quit IRC
[23:59:42] *** rohitrao has joined #chromium
[23:59:42] *** ChanServ sets mode: +v rohitrao
[23:59:43] *** hclam has quit IRC





top