[00:00:04] *** eseidel has quit IRC
[00:00:05] *** eseidel_ is now known as eseidel
[00:01:59] <pcgod> /src/chrome/browser/gtk/options/advanced_contents_gtk.cc
[00:02:10] <thakis> pcgod: sshh! ;-)
[00:03:15] <gOcOOl> thakis: cool thanks, but just out of curiosity, knowing your way around the source code is probably the only practical way to get around this issue i suppose. The reason I ask is because, i'd like to try and get my hands wet with the source code and maybe fix a few bugs that need attention. But I keep stumbling across this problem when i feel the need to investigate the part of the source code (atleast roughly) where the issue might be occuring
[00:03:18] *** Martijnc has quit IRC
[00:03:28] *** chrisccoulson has quit IRC
[00:04:50] <gOcOOl> even to be able to pepper the source with some error logging, i need to know, alteast roughly, what part of the source code gets executed
[00:05:39] *** Buglouse has joined #chromium
[00:05:55] <gOcOOl> that has been the biggest stumbling block for me so far
[00:07:23] <trungl> grep/ack/etc. are your friends
[00:07:52] <trungl> that and being able to read code
[00:07:58] *** SixEcho has quit IRC
[00:08:33] <gOcOOl> what would i be grep'ing for in this case? if i knew what function i was looking for, I could just do, 'info func foo' in gdb and get a good listing.
[00:09:56] <pcgod> http://www.google.com/codesearch?q=package:chromium+proxy+option ...
[00:10:50] <gOcOOl> pcgod: ahh, excellent! that's certainly a good start.
[00:12:06] *** shepazu has joined #chromium
[00:18:59] *** Venom_X has quit IRC
[00:19:47] <thakis> gOcOOl: also http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code (it's a bit out of date)
[00:19:54] <thakis> (but mostlyright)
[00:20:29] <thakis> gOcOOl: all ui is in chrome/browser (c/b/gtk for linux, c/b/views for windows/chromeos, c/b/cocoa for mac mostly)
[00:25:13] <trungl> thakis: we're going to get rid of the combined stop/reload button soon, right?
[00:26:27] <trungl> silence is clearly consent
[00:27:07] *** neure has quit IRC
[00:27:36] *** spline has joined #chromium
[00:29:06] *** viro101 has joined #chromium
[00:30:32] <thakis> trungl: are we?
[00:30:40] <thakis> trungl: i thought we're keeping it and adding heuristics
[00:30:47] <trungl> I have no idea
[00:31:04] <thakis> trungl: like keeping it in "stop" state until hover out if it's stop when the cursor hovers in
[00:31:15] <thakis> trungl: and letting it oscillate at at most 1 hz
[00:31:21] <thakis> i think we're keeping it
[00:31:26] <thakis> but i don't know
[00:31:29] <thakis> might be wishful thinking
[00:31:41] * trungl is confused.
[00:33:40] *** spline has left #chromium
[00:35:57] *** Adys has quit IRC
[00:36:01] *** dumi has joined #chromium
[00:36:02] *** ChanServ sets mode: +v dumi
[00:37:34] <dumi> vitalyr: looks like you might need to submit a rebaseline for a webkit test after your latest webkit roll
[00:38:39] <vitalyr> dumi: yeah, somehow svg stuff slipped through... i'm working on a next roll, where i'm going to fix it
[00:38:53] *** awidegreen has quit IRC
[00:39:38] <dumi> vitalyr: cool, thanks :)
[00:48:51] *** SixEcho has joined #chromium
[00:57:42] *** urbanape has quit IRC
[00:59:35] *** duffydack has left #chromium
[01:06:14] *** awolfson has quit IRC
[01:07:19] *** tonikitoo has quit IRC
[01:14:37] <rubenbb> hmm, anyone else not able to load this page in newer chromium? http://rene-ladan.nl/
[01:14:45] <rubenbb> works fine for me in arora with older webkit
[01:19:34] *** orm has joined #chromium
[01:21:28] *** orm has joined #chromium
[01:31:37] *** NthDeGeek has quit IRC
[01:33:15] *** aroben has quit IRC
[01:36:04] *** RT|Chatzilla has joined #chromium
[01:41:53] *** eseidel has quit IRC
[01:42:22] *** eseidel has joined #chromium
[01:44:31] *** Gina has quit IRC
[01:45:22] *** abarth has quit IRC
[01:47:26] <thakis> trungl: http://codereview.chromium.org/2835036
[01:47:30] *** MikeSmithW3C has quit IRC
[01:47:58] <thakis> (compare with http://codereview.chromium.org/1528032 )
[01:48:02] *** MikeSmithW3C has joined #chromium
[02:01:43] *** XDS|Onyx|CM is now known as XDS|Onyx|CM5
[02:14:35] *** yutak_home has joined #chromium
[02:14:37] *** ChanServ sets mode: +v yutak_home
[02:22:42] *** bmizerany has quit IRC
[02:24:07] *** viro101 has quit IRC
[02:25:24] *** bmizerany has joined #chromium
[02:26:50] *** yanick_ has joined #chromium
[02:27:23] <yanick_> hi, is this a good place to ask a question about Chromium browser?
[02:29:06] <yanick_> both laptops at home have ubuntu 10.04 installed, both have chromium browser from the ppa site, one reports flash 10, the other flash 9. On the one with flash 9, I tried reinstalling flashplugin-installer, but nothing do, Chromium still stick to version 9. I'm clueless...
[02:29:11] <yanick_> any idea?
[02:29:34] *** Buglouse has quit IRC
[02:30:33] *** leeight has joined #chromium
[02:30:39] *** leeight has left #chromium
[02:36:13] <thakis> trungl: lg or what?
[02:39:39] *** jennyf has joined #chromium
[02:43:26] *** SixEcho has left #chromium
[02:43:47] *** abarth has joined #chromium
[02:43:48] *** ChanServ sets mode: +v abarth
[02:48:40] *** leeight has joined #chromium
[02:48:42] *** leeight has left #chromium
[02:49:50] *** tav has quit IRC
[02:51:07] *** dumi has quit IRC
[02:52:30] *** dhaffner has quit IRC
[02:55:06] *** yutak_home has quit IRC
[02:55:22] *** yanick_ has left #chromium
[02:57:47] *** Buglouse has joined #chromium
[02:59:59] *** jedivulcan_ has joined #chromium
[03:02:39] *** jamesr has joined #chromium
[03:02:39] *** ChanServ sets mode: +v jamesr
[03:02:48] *** vitalyr has quit IRC
[03:03:32] *** Buglouse has quit IRC
[03:03:45] *** jedivulcan has quit IRC
[03:03:45] *** jedivulcan_ is now known as jedivulcan
[03:16:03] *** fr| has joined #chromium
[03:16:33] *** hbono has joined #chromium
[03:16:55] *** mrossetti has joined #chromium
[03:17:10] *** fr has quit IRC
[03:18:50] *** roc has quit IRC
[03:19:50] *** roc has joined #chromium
[03:21:55] *** jedivulcan has quit IRC
[03:22:27] <thakis> sheriffs (i.e. trungl): i'm afk for a while. if the tree goes red, i blame flakiness
[03:22:42] <thakis> but if other people want to submit, you can revert me anyway ;-)
[03:24:30] *** roc has quit IRC
[03:26:39] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder" from 51681: thakis at chromium dot org)
[03:31:42] *** rohitrao has joined #chromium
[03:31:43] *** ChanServ sets mode: +v rohitrao
[03:32:36] *** peepsalot has joined #chromium
[03:33:04] *** mrossetti has quit IRC
[03:33:35] <peepsalot> i suddenyl started getting unresponsive pages for almost every URL i visit.  is there a log or something I can check to see what the heck is going on>
[03:35:40] <peepsalot> hmm, i guess maybe my user profile is corrupt
[03:35:44] <peepsalot> wonder what caused that
[03:36:33] *** rolandsteiner has joined #chromium
[03:37:39] *** bmizerany has quit IRC
[03:39:12] *** bmizerany has joined #chromium
[03:41:51] <hbono> thakis: it seems your r51681 caused a build break on Windows since it forgot changing the resource file ('chrome/app/chrome_dll.rc') correctly.
[03:42:19] *** tav has joined #chromium
[03:42:26] <peepsalot> ok, where would my chromium user profile be on ubuntu linux?  i assumed it would be something like ~/.chromium-browser but there is no directory like that
[03:42:27] *** Gina has joined #chromium
[03:44:37] <hbono> peepsalot: If I recall correctly, it is in "~/.config/google-chrome". (I'm a Windows person, so my answer may be wrong.)
[03:45:02] *** kollock has joined #chromium
[03:47:55] <peepsalot> hbono, ah, yes that's it.  is there anything i can check to submit a bug report on what may have cause the corruption?
[03:49:33] <tkent> hbono: thakis is AFK.  I think we may revert r51681.
[03:50:14] *** kinnetica has quit IRC
[03:50:34] <hbono> peepsalot: it is definitely helpful to try renaming the directory and check whether your chrome works again.
[03:50:59] <MikeSmithW3C> friends, we are still looking for a qualified editor to take over the WebIDL spec
[03:51:01] <MikeSmithW3C> http://dev.w3.org/2006/webapi/WebIDL/
[03:51:18] <MikeSmithW3C> (we = W3C WebApps working group)
[03:51:27] <hbono> tkent: even though it is just changing one line to fix this build break, I'm OK to revert his change if you like it.
[03:52:11] <peepsalot> hbono, it seems to be working again after renaming ~/.config/chromium
[03:54:24] <hbono> peepsalot: Thank you so much for your investigation. It is surely an issue caused by corrupted profiles.
[03:54:41] *** olgagirl has joined #chromium
[03:55:07] <peepsalot> hbono, but is there any way to tell what would have caused such corruption?
[03:55:49] *** bmizerany has quit IRC
[03:56:29] *** kollock has quit IRC
[03:58:13] <peepsalot> also, is there any difference between the chrome binaries available from google, versus chromium which is in ubuntu repositories?  i realize that the revisions they are built from are going to be somewhat different, but is there any some maybe closed source features that are included in chrome that are not in chromium??
[03:58:50] <hbono> peepsalot: if your chrome does not cause a crash, it is not so easy to tell it.
[04:00:26] *** barcon332 has quit IRC
[04:00:53] *** awolfson has joined #chromium
[04:01:23] *** Cheery has joined #chromium
[04:01:52] <Cheery> is it possible to get the chrome show a caret, despite preventing all modifications?
[04:08:57] <JakeSays> MikeSmithW3C: what constitutes 'qualified'?
[04:09:07] *** olgagirl has joined #chromium
[04:09:57] *** olgagirl has quit IRC
[04:16:05] <hbono> Cheery: even though it is just a random thought, it might be possible when writing an extension (or JS) that prevents the default action for all key events. (I'm not sure if it really works, though.)
[04:17:21] <MikeSmithW3C> JakeSays: intimate familiarity with IDL and Javascript
[04:17:33] <MikeSmithW3C> and with the DOM I suppose
[04:17:38] <trungl> hbono: I guess I should revert thakis?
[04:17:47] *** tedoc2000 has quit IRC
[04:17:54] <JakeSays> hmm.
[04:17:54] <trungl> (what was the problem?)
[04:19:26] *** jedivulcan has joined #chromium
[04:19:56] <Cheery> hbono: no options that'd just make a div focusable and show caret inside itself?
[04:20:07] *** thakis_ has joined #chromium
[04:20:07] *** ChanServ sets mode: +v thakis_
[04:20:09] *** bweinstein has quit IRC
[04:20:15] <thakis_> re
[04:20:20] <trungl> thakis_: !
[04:20:27] <thakis_> trungl: yeah yeah
[04:20:52] <trungl> should I revert you?
[04:21:06] <thakis_> trungl: let me look first
[04:21:21] <hbono> thakis, trungl: <http://codereview.chromium.org/2885023>
[04:22:04] <thakis_> hbono: that's not enough
[04:22:46] <hbono> thakis: yeah, I'm looking one by one.
[04:23:23] <thakis_> #include "webkit/default_plugin/plugin_impl.h" needs to be removed form webkit/glue/plugins/webplugin_delegate_impl_win.h
[04:23:26] <thakis_> (seems to be not used)
[04:23:30] <thakis_> and a DEPS file is needed
[04:23:38] <JakeSays> hmm. so what engine is chrome using to render PDF's?
[04:23:50] <trungl> hrm
[04:24:08] <trungl> thakis_: so what's your prognosis
[04:24:09] <trungl> ?
[04:24:11] <thakis_> trungl: i think i can fix this
[04:24:14] <trungl> is the patient doa?
[04:24:53] * trungl clearly just enjoys reverting thakis.
[04:25:14] <trungl-bot> Tree closed by thakis at chromium dot org: Tree is closed (thakis looking; yell on #chromium if you need to commit)
[04:28:00] <thakis_> trungl: hbono: http://codereview.chromium.org/2838044 ?
[04:28:57] *** awolfson has quit IRC
[04:30:03] <thakis_> trungl: i'll commit this and see what happens
[04:30:17] <hbono> thakis_: it is a good idea. :)
[04:30:43] <JakeSays> is the pdf rendering stuff in the tree?
[04:32:14] <trungl> thakis_: is it not still missing a bunch of other DEPS changes? (bunch possibly = 1)
[04:32:29] <trungl> e.g., to chrome/browser/DEPS
[04:32:30] <thakis_> trungl: possible?
[04:32:49] <trungl> renderer/DEPS?
[04:33:13] <hbono> JakeSays: even though I'm not sure about it, how about checking the "about:: plugins" page and seeing what libraries are used for PDFs?
[04:34:03] <hbono> oops, it's a typo of "about:plugins".
[04:34:44] <JakeSays> hbono: hmm. only thing listed is acrobat reader.
[04:36:35] <hbono> JakeSays: So, your chrome uses acrobat reader.
[04:37:08] <JakeSays> yeah i figured it did, but i'm running chrome v5
[04:37:15] <thakis_> trungl: http://codereview.chromium.org/2813047 , but maybe it's not necessary to get the build green?
[04:37:38] <Cheery> does javascript have something like pydoc or such?
[04:37:42] *** chronarion has joined #chromium
[04:37:42] *** ChanServ sets mode: +v chronarion
[04:38:32] <JakeSays> i'll try the dev channel and see what that gives me
[04:38:48] <thakis_> trungl: i'll revert
[04:38:58] <trungl> ok, thanks
[04:39:09] *** bweinstein has joined #chromium
[04:39:16] <trungl> it may be that your last change is enough
[04:39:18] <trungl> but I don't know
[04:39:46] <thakis_> trungl: no, w/glue/plugins/webplugin_delegate_impl_win depends on something in default_plugin
[04:39:52] <trungl> d'oh
[04:39:56] <thakis_> fixable, but takes too long
[04:39:59] <thakis_> for now
[04:40:27] <trungl> thakis_: is the problem that the trybots don't clobber?
[04:40:31] <trungl> (when they build?)
[04:40:50] <trungl> problem for "why didn't the trybots catch this?"
[04:41:07] <thakis_> trungl: i guess the #include found the old file? doesn't really make sense
[04:41:36] <thakis_> i _did_ have a green run on all trybots at some point
[04:41:55] <thakis_> sadness
[04:42:00] <thakis_> i'll try again later today, i guess
[04:42:05] <trungl> thakis_: hrm, it's known that xcodebuild isn't so smart about #includes and deleted headers
[04:42:10] <trungl> but that's a windows file
[04:42:23] <trungl> thakis_: maybe try giving --clobber to the trybots?
[04:42:32] <JakeSays> hbono: maybe i'm mistaken, but according to a chromium blog post chrome from the dev channel is supposed to have integrated PDF support.
[04:42:32] <thakis_> trungl: will do
[04:42:55] <thakis_> JakeSays: that's only in chrome, not in chromium afaik
[04:43:02] <trungl> chrome 5 is also not dev channel
[04:43:06] <trungl> dev channel is on chrome 6
[04:43:14] <JakeSays> thakis_: ohhh ok.
[04:43:23] <JakeSays> trungl: yeah i just installed chrome 6
[04:43:40] <thakis_> drover takes its time with the revert?
[04:44:37] <JakeSays> ah hah. i had to enable the plugin. very cool
[04:44:53] <hbono> JakeSays: yeah, the current dev channel is 6.0.453.1 dev.
[04:45:45] <JakeSays> dang. that is going to be awesome once it's done!
[04:47:27] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open (revert in, should cycle green)
[04:47:31] *** chronarion has quit IRC
[04:47:57] <thakis_> trungl: revert in
[04:48:03] <trungl> thanks
[04:48:05] <thakis_> trungl: i'm afk for another hour or so
[04:50:03] *** jamesr has quit IRC
[04:52:42] <JakeSays> hmm. i hope the pdf stuff makes it in to chromium.
[04:53:17] <eggy> pdf stuff?
[04:53:39] <JakeSays> eggy: http://blog.chromium.org/2010/06/bringing-improved-pdf-support-to-google.html
[04:54:47] *** Cheery has left #chromium
[04:55:13] <eggy> ah
[04:58:43] *** thakis_ has quit IRC
[05:01:20] *** tonikitoo has joined #chromium
[05:01:29] *** tyoshino has quit IRC
[05:03:26] *** adiumtestuser has quit IRC
[05:03:38] *** adiumtestuser has joined #chromium
[05:03:39] *** ChanServ sets mode: +v adiumtestuser
[05:06:03] *** jamesr has joined #chromium
[05:06:03] *** ChanServ sets mode: +v jamesr
[05:10:43] <orm> so chrome uses webkit?
[05:10:57] <orm> I'll have to look into how to make plugins for it
[05:11:01] *** tav has quit IRC
[05:12:15] *** bobthemilkman has joined #chromium
[05:12:17] <hbono> orm: yes. chrome uses webkit.
[05:12:42] *** rohitrao has quit IRC
[05:22:54] *** bweinstein has quit IRC
[05:25:21] *** XDS|Onyx|CM5 has quit IRC
[05:28:13] <JakeSays> hmm. i'm guessing its foxit.
[05:28:14] *** roc has joined #chromium
[05:29:49] *** Buglouse has joined #chromium
[05:37:27] *** clochette has joined #chromium
[05:45:28] *** jamesr has quit IRC
[05:45:53] *** jamesr has joined #chromium
[05:45:53] *** ChanServ sets mode: +v jamesr
[05:51:32] *** Forsaken1GER has quit IRC
[05:51:50] *** Forsaken|GER has joined #chromium
[05:54:13] *** Eminence has joined #chromium
[06:04:10] *** Buglouse has quit IRC
[06:11:56] *** ese has quit IRC
[06:12:00] *** ese has joined #chromium
[06:12:22] *** fredliu has joined #chromium
[06:16:53] *** jennyf has joined #chromium
[06:17:45] <fredliu> Hi guys, i'm trying to build Chromium on Mac, i'm using Mac 10.5, and it can't build.
[06:18:14] <fredliu> ld: in /PATHTO/chromium/src/xcodebuild/Debug/libwebcore.a, can't map file, errno=12
[06:18:16] <fredliu> collect2: ld returned 1 exit status
[06:18:34] *** jennyf has quit IRC
[06:20:05] <fredliu> i grabbed the source this afternoon, the tree was open
[06:21:29] <hbono> fredliu: it seems your mac runs out of memory while linking chromium.
[06:21:40] <fredliu> can somebody point me a direction where I can get this fixed? I googled, it seems there was a valgrind related bug similar to this
[06:22:16] <fredliu> oh? thanks for that, i did have a lot of crap loaded when building
[06:22:41] <fredliu> thanks i'll try rebuild after closing some applications
[06:23:08] <hbono> fredliu: if you don't need to debug information, it may be a good idea to build a release build, i.e. "xcodebuild -configuration Release".
[06:23:45] <fredliu> hbono: thanks for your advice, but i think i do need debug information
[06:24:09] <fredliu> since i'm going to do some modifications on chromium
[06:24:33] <hbono> fredliu: good luck. :)
[06:25:20] <fredliu> hbono: thanks! i'll take that NOT as a warning~ ;)
[06:26:31] <hbono> fredliu: oops, I don't have any intention of giving you a warning. sorry for that.
[06:27:46] <fredliu> hbono: no problem~ i've just started building chromium and already got some problems, so it seems like a bumpy start for me~
[06:28:00] <rubenbb> fredliu: how much RAM do you have?
[06:28:29] <fredliu> 4G in total
[06:28:37] <rubenbb> you should probably start off by building release, just to make sure it works, then you can build debug later once you've made some modifications and are ready to debug
[06:29:06] <rubenbb> fredliu: and how much is being used when you're not building, chromium needs around 1 GB to build usually
[06:29:18] <fredliu> rubenbb: thanks for the advice, i'll try that  too
[06:29:34] <fredliu> free mem 1.3G now
[06:29:38] <fredliu> i'm rebuilding it now
[06:29:43] <rubenbb> ok, that should be enough for a release build
[06:30:49] <fredliu> rubenbb: then how much is normally needed for a debug build?
[06:32:11] <rubenbb> sounds like you're running into this problem - http://groups.google.com/a/chromium.org/group/chromium-reviews/browse_thread/thread/292b5ddb5bfc69bf?fwc=1
[06:32:28] *** cyberanger has joined #chromium
[06:32:42] <rubenbb> debug build will take as much as you can get ;) it has to link a 2 GB binary at the end, so the more the better
[06:33:15] <rubenbb> but your address space issue is on top of that
[06:33:58] <fredliu> rubenbb: ya, i saw that post too, i thought it's somehow related to valgrind
[06:35:06] <rubenbb> no, that part of the comment was removed
[06:35:33] <rubenbb> basically, they link libwebcore first in the unit tests because the linker runs out of memory otherwise
[06:35:49] <fredliu> i c...
[06:35:51] <rubenbb> fredliu: what chromium version are you building?
[06:36:07] <fredliu> em.. i guess the latest?
[06:36:14] <rubenbb> which target?
[06:36:17] <rubenbb> All?
[06:36:20] <fredliu> ya
[06:36:26] <rubenbb> you can just build Chrome, that will avoid any issues with unit tests
[06:36:31] *** thakis_ has joined #chromium
[06:36:32] *** ChanServ sets mode: +v thakis_
[06:36:41] <fredliu> i c
[06:36:44] *** nayankk has quit IRC
[06:36:58] <fredliu> thanks, i'll try that if the current build still fails
[06:37:39] *** sandra_f has joined #chromium
[06:37:53] <fredliu> actually i have another questions, the waterfall page, as long as the top of the page says the tree is open, i should be fine grabing a copy from the svn, right?
[06:38:52] *** ad0le has joined #chromium
[06:39:02] <rubenbb> looks like they added that line several times for the mac tests, I wonder if the problem is that some new test executable has pulled in libwebcore on the mac but they forgot to make libwebcore link first
[06:39:35] <rubenbb> fredliu: I believe so
[06:39:47] *** sandra_f has quit IRC
[06:39:51] <fredliu> rubenbb: thanks!
[06:40:08] <rubenbb> you can always force a certain commit number or downgrade to whatever commit you want, so not a big deal
[06:41:04] <fredliu> i c.. right now, i'm just following the instruction on the chromium web page
[06:41:13] <ad0le> font-style: oblique; when used in conjunction with a font that was loaded via the @font-face derivitive, breaks the font rendering and reverts to the default html font. If you omit or change the value of font-style to any of the other values (normal) it works just fine.
[06:42:05] <ad0le> tl;dr @font-face + font-style: oblique = yuk font
[06:43:31] <rubenbb> ad0le: try in another webkit browser, if it has the same problem, it's a webkit issue and should be reported to them
[06:43:52] <ad0le> I tried in Safari (for windows) and it rendered fine
[06:44:07] <ad0le> is there another windows based webkit browser I can test with?
[06:45:13] <ad0le> opera render correctly as well
[06:45:16] *** cyberanger has left #chromium
[06:45:34] <rubenbb> try arora
[06:47:12] <rubenbb> ad0le: chromium uses a patched webkit, so it could be that, or maybe just safari using an older webkit
[06:47:34] <rubenbb> can you check what webkit version each webkit brower you're testing is using?
[06:47:43] <ad0le> cool, Im downloading arora now
[06:51:57] <ad0le> sure here they are: Opera 10.51 (works), IE7 (no @font-face support), Firefox 3.6.4 (works), Chrome 5.0.375.99 (broken), Safari 5.0 (works), Arora 0.10.0 (works)
[06:53:02] <rubenbb> for the last 3, what webkit version is each using
[06:53:04] <rubenbb> ?
[06:53:19] <ad0le> Should be in the credits
[06:54:14] <rubenbb> if safari 5 is using a newer webkit and arora an older one, it's probably a bug in the chrome patches of webkit
[06:54:34] <rubenbb> in that case, you can post a bug at crbug.com and include that info to make the case it's a chromium issue
[06:54:48] <rubenbb> ie which webkit version each is using
[06:55:01] <ad0le> done and done... was told to come here with issues because parsing errors were king :)
[06:55:41] <rubenbb> oh, I see you already did - http://code.google.com/p/chromium/issues/detail?id=48393
[06:55:56] <thakis_> trungl: without --clobber, the try jobs passed again :-/
[06:56:29] <trungl> and with --clobber?
[06:57:50] *** bers has joined #chromium
[06:58:08] <thakis_> trungl: the windows one failed
[06:58:27] <thakis_> (but i might've fixed the checkdeps issues, so maybe it's ok the other two passed)
[06:58:46] <thakis_> this is a bit weird, 'cause the CL contained a compile error on windows
[06:58:48] <thakis_> oh well
[06:58:56] <thakis_> will wait for the next clobber trybot result
[06:59:20] <trungl> hopefully it'll all be good
[07:00:44] *** ad0le has left #chromium
[07:02:38] <thakis_> trungl: for the window sizer patch: do you think it's ok if i just make up minimum numbers (16 for height, 100 for width or so)?
[07:03:01] <thakis_> good point btw, this occurred to me too while driving home
[07:03:25] <trungl> thakis_: sure, though I'd guess that the minimum height should probably be at least the height of the standard title bar
[07:03:40] <thakis_> isn't that 16 with the default zoom level?
[07:03:58] <trungl> you might be right?
[07:04:11] * trungl only knows that the menu is 22.
[07:05:38] *** Gina has quit IRC
[07:06:39] *** Gina has joined #chromium
[07:10:55] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open
[07:13:51] *** roc has quit IRC
[07:20:38] *** fredliu has quit IRC
[07:25:05] *** jennyf has joined #chromium
[07:25:50] *** jennyf has quit IRC
[07:26:17] *** cybergirl has joined #chromium
[07:28:04] *** cybergirl has quit IRC
[07:29:36] <jochen__> morning
[07:30:30] <thakis_> moin moin
[07:32:28] <jochen__> can't map file: libwebcore.a
[07:32:30] <jochen__> grrrrr
[07:33:08] <thakis_> trungl: i'll try to land the plugin cl again. the clobber try made it through compilation & checkdeps on windows
[07:33:21] <thakis_> and passed browser_tests and ui_tests on linux
[07:33:23] *** FullFlannelJacke has quit IRC
[07:34:56] *** pfeldman has joined #chromium
[07:36:06] <trungl> thakis_: ok, now's a good hour to try it :P
[07:36:15] <thakis_> :-P
[07:36:51] * trungl is not currently on PDT, so he will be off.
[07:37:00] <trungl> 'night Chromium.
[07:37:00] <trungl-bot> trungl: 'night.
[07:37:19] *** trungl has quit IRC
[07:39:58] <thakis_> w.t.f.
[07:41:11] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 51692: thakis at chromium dot org)
[07:41:17] <rubenbb> jochen__: probably cuz of something like this? http://groups.google.com/a/chromium.org/group/chromium-reviews/browse_thread/thread/292b5ddb5bfc69bf?fwc=1
[07:42:05] <jochen__> well, the reason is that the mac linker is 32bit only
[07:42:16] <jochen__> and i'm too lazy to upgrade to 10.6
[07:42:47] <rubenbb> ok, I thought maybe that dependencies reordering wasn't added to some new executable
[07:43:05] <rubenbb> because apparently it fixed those problems before
[07:43:21] <jochen__> it worked around the problem
[07:43:39] <jochen__> you can also strip debug symbols, or disable svg
[07:43:46] <jochen__> but all of these are temporary solutions
[07:44:45] <rubenbb> well, since a bunch of the mac test executables use the same workaround, I wonder if it can't be fixed just by doing the same for whatever new executable doesn't use that workaround yet
[07:46:31] <rubenbb> anyway, the reason I had that link is because someone reported the same problem on 10.5 an hour ago
[07:48:09] <jochen__> the correct answer would be that 10.5 is not supported as development platform anymore
[07:48:15] <trungl-bot> Tree closed by thakis at chromium dot org: Tree is closed (thakis trying to fix)
[07:48:16] *** MikeSmithW3C^ has joined #chromium
[07:49:27] <thakis_> jochen__: as a bandaid, `GYP_DEFINES='enable_svg=0' gclient runhooks`
[07:49:45] <thakis_> and you need to comment a random set of files from chrome/chrome_tests.gyp :-P
[07:49:53] * thakis_ needs to upgrade to 10.6 too
[07:50:09] <hbono> it seems  our mac build uses adds "{ 'variables': { 'chromium_mac_pch': 0, 'enable_svg': 0, 'fastbuild': 1, } }" to "~/.gyp/include.gypi".
[07:50:23] <jochen__> thakis_: that's Chromium Framework failing...
[07:50:44] <thakis_> jochen__: with svg disabled?
[07:50:58] <jochen__> no
[07:51:25] <rubenbb> 10.5 still listed as supported, feel free to remove ;) http://code.google.com/p/chromium/wiki/MacBuildInstructions
[07:52:16] *** MikeSmithW3C has quit IRC
[07:53:09] <thakis_> jochen__: then disabling svg will help you
[07:53:25] <thakis_> rubenbb: we'll update that page once the trybots etc are all 10.6
[07:53:40] <thakis_> (eta: 1.5 weeks or so)
[07:53:49] <rubenbb> heh, I was just joking with jochen :)
[07:55:18] <jochen__> technically, it's still supported anyway
[07:55:22] <jochen__> for compiling release builds
[07:57:20] *** awidegreen has joined #chromium
[07:57:38] <jochen__> and why is VS always performing a full link
[07:57:47] <rubenbb> yeah, I suggested a release build to that guy
[07:58:01] *** bers has quit IRC
[08:03:01] *** rohitkc has joined #chromium
[08:06:46] *** DBO has quit IRC
[08:27:40] *** jamesr has quit IRC
[08:27:49] *** General13372 has joined #chromium
[08:28:21] *** jamesr has joined #chromium
[08:28:21] *** ChanServ sets mode: +v jamesr
[08:31:30] *** General1337 has quit IRC
[08:32:15] *** hagabaka has quit IRC
[08:41:27] *** [Nef] has quit IRC
[08:41:42] *** lafille has joined #chromium
[08:41:49] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open
[08:41:58] *** Adys has joined #chromium
[08:43:49] <thakis_> looks like it actually went through
[08:43:54] <thakis_> i'm off
[08:44:38] *** lafille has quit IRC
[08:47:45] <yusukes> sheriffs: i have just landed a change that contains .grd changes.
[08:47:48] <yusukes> r51698
[08:48:49] *** Snow_White has quit IRC
[08:49:54] *** reggna has quit IRC
[08:52:01] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "test_shell_tests" on "Webkit Mac10.5" from 51692: thakis at chromium dot org)
[08:52:05] <thakis_> bah!
[08:53:36] *** reggna has joined #chromium
[08:53:36] <thakis_> webkitpy.layout_tests.port.websocket_server.PyWebSocketNotStarted: Failed to start PyWebSocket server on port 8880.
[08:53:41] <thakis_> that seems like it's not my fault
[08:53:53] <thakis_> maruel nsylvain ^
[08:55:03] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open ("test_shell_tests" on "Webkit Mac10.5" -> flake)
[09:00:47] *** thakis_ has quit IRC
[09:03:08] *** lodle has joined #chromium
[09:03:29] <lodle> hey guys, Where do the bug reporting inside chrome go? Is there a public veiwable list?
[09:07:03] <hbono> lodle: it is <http://crbug.com/>.
[09:10:23] *** loislo has joined #chromium
[09:12:21] <lodle> is that short for something as i get a 404
[09:12:46] <lodle> ah stupid >
[09:13:57] <lodle> i just reported a bug and it doesnt show
[09:14:07] <lodle> does it take time to get onto the list?
[09:15:11] <hbono> lodle: is it possible to give me your bug ID?
[09:15:23] <lodle> no idea what it was
[09:15:28] <lodle> was withing chrome
[09:15:38] <lodle> thinking now i should of just reported it normally
[09:17:32] *** JakeSays has quit IRC
[09:19:47] *** urbanape has joined #chromium
[09:20:13] <hbono> lodle: I think the bug ID is written in the page when writing the description of your bug and pressing a "Submit Issue" button.
[09:23:39] *** apavlov has joined #chromium
[09:24:33] *** clochette has joined #chromium
[09:25:51] *** roc has joined #chromium
[09:26:21] *** clochette has quit IRC
[09:29:02] *** urbanape has quit IRC
[09:29:02] *** DBO has joined #chromium
[09:31:39] *** Beetny has joined #chromium
[09:40:55] *** pfeldman has quit IRC
[09:55:01] *** rohitkc has quit IRC
[09:58:15] *** rohitkc has joined #chromium
[09:58:54] <lodle> hmm no id on the page
[09:59:03] <lodle> think ill resubmit it on the bug tracker
[10:01:29] *** romainhuet has joined #chromium
[10:04:16] *** goxboxlive has joined #chromium
[10:05:30] <goxboxlive> A couple of days i ago i checked out the source from chromium via repo/git. When start buliding i miss a toll named cgpt toll. What is it, and what can i do to have it in my build root system?
[10:05:55] <goxboxlive> /s tooll/tool
[10:08:54] *** hrna has joined #chromium
[10:12:22] *** phajdan-jr has joined #chromium
[10:12:22] *** ChanServ sets mode: +v phajdan-jr
[10:14:34] *** olgagirl has joined #chromium
[10:16:06] *** olgagirl has quit IRC
[10:18:08] *** kinnetica has joined #chromium
[10:18:44] *** urbanape has joined #chromium
[10:23:17] *** jpld has joined #chromium
[10:25:32] *** jamesr has quit IRC
[10:27:23] *** bobthemilkman has quit IRC
[10:29:27] *** chrisccoulson has joined #chromium
[10:31:48] *** eseidel has quit IRC
[10:32:25] *** eseidel has joined #chromium
[10:43:34] *** General13372 has quit IRC
[10:45:47] *** [Nef] has joined #chromium
[10:50:23] *** FishFace has joined #chromium
[10:50:35] *** jpld has left #chromium
[10:51:25] *** howlymowly has joined #chromium
[10:52:56] <phajdan-jr> hi guys, could you create a chromium at gentoo dot org e-mail alias and add me (phajdan.jr) and voyageur to it? Let me know if you'd prefer me to file a bug instead.
[10:56:34] *** eseidel has quit IRC
[11:04:53] *** ROBOd has joined #chromium
[11:08:57] *** eseidel has joined #chromium
[11:09:38] *** General1337 has joined #chromium
[11:27:04] *** hbono has quit IRC
[11:41:30] *** pfeldman has joined #chromium
[11:43:17] *** kinnetica has quit IRC
[11:55:19] *** lianj__ has joined #chromium
[11:56:15] *** lianj__ is now known as lianj
[11:59:02] *** lianj_ has quit IRC
[12:05:56] *** rohitkc has quit IRC
[12:08:08] *** yusukes has quit IRC
[12:08:49] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Mac10.5 (dbg)" from 51702: chrome-release at google dot com)
[12:14:35] *** rohitkc has joined #chromium
[12:35:30] <phajdan-jr> oops, please ignore my message above, wrong channel :-/
[12:45:53] *** FunkyPenguin has joined #chromium
[12:47:10] <FunkyPenguin> im no dev, but im trying to package chromium for openSUSE MeeGo, and have taken the source that the linuxfoundation used
[12:47:43] <FunkyPenguin> ive also updated v8 and icu to match them, but chromium fails to build with https://build.opensuse.org/package/live_build_log?arch=i586&package=chromium&project=home%3Ajoeyli%3Abranches%3AopenSUSE%3AFactory%3AContrib&repository=standard
[12:47:58] <FunkyPenguin> anyone able to point me as to what im doing wrong please?
[12:48:19] <FunkyPenguin> openSUSE has a statically built version of chromium but that doesnt work with meego
[12:50:15] *** star-affinity has joined #chromium
[12:53:11] <phajdan-jr> FunkyPenguin: apparently it lacks the definition of PP_Resource, hmm...
[12:55:09] <FunkyPenguin> err where is that defined and how can i fix it?
[13:04:03] *** General1337 has quit IRC
[13:04:04] *** tonikitoo has quit IRC
[13:04:04] *** jedivulcan has quit IRC
[13:04:04] *** fr| has quit IRC
[13:04:05] *** kliegs has quit IRC
[13:04:06] *** Ruetobas has quit IRC
[13:04:06] *** erickt has quit IRC
[13:04:07] *** Peter` has quit IRC
[13:04:07] *** vandebo has quit IRC
[13:04:07] *** Dykam has quit IRC
[13:04:08] *** shenki has quit IRC
[13:04:09] *** abachm has quit IRC
[13:04:09] *** jptix has quit IRC
[13:04:10] *** jstrom has quit IRC
[13:04:10] *** awong has quit IRC
[13:04:10] *** Precea[BNC] has quit IRC
[13:04:38] *** jstrom has joined #chromium
[13:07:18] *** cbentzel has joined #chromium
[13:07:19] *** General1337 has joined #chromium
[13:07:19] *** tonikitoo has joined #chromium
[13:07:19] *** jedivulcan has joined #chromium
[13:07:19] *** fr| has joined #chromium
[13:07:19] *** kliegs has joined #chromium
[13:07:19] *** Ruetobas has joined #chromium
[13:07:19] *** erickt has joined #chromium
[13:07:19] *** Peter` has joined #chromium
[13:07:19] *** vandebo has joined #chromium
[13:07:19] *** Dykam has joined #chromium
[13:07:19] *** abachm has joined #chromium
[13:07:19] *** shenki has joined #chromium
[13:07:19] *** jptix has joined #chromium
[13:07:19] *** Precea[BNC] has joined #chromium
[13:07:19] *** awong has joined #chromium
[13:07:19] *** zelazny.freenode.net sets mode: +vv vandebo awong
[13:09:19] <phajdan-jr> FunkyPenguin: I'm doing some grep searches to find that out
[13:10:10] <phajdan-jr> FunkyPenguin: oh, maybe it is defined, but the compiler is more strict
[13:10:32] <phajdan-jr> FunkyPenguin: I've found a definition that PP_Resource is in fact int64_t, which indeed is not a pointer type
[13:10:39] <phajdan-jr> FunkyPenguin: what gcc version are you using?
[13:24:22] *** apavlov has quit IRC
[13:24:45] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[13:27:24] *** eseidel has quit IRC
[13:27:36] *** apavlov has joined #chromium
[13:30:38] *** Eminence has left #chromium
[13:30:42] *** Martijnc has joined #chromium
[13:35:03] *** andrix has joined #chromium
[13:36:38] *** rolandsteiner has quit IRC
[13:38:28] <pcgod> phajdan-jr: those warnings are from gcc 4.5
[13:42:25] *** tonikitoo has quit IRC
[13:42:55] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "test_shell_tests" on "Webkit" from 51706: cbentzel at chromium dot org)
[13:44:05] *** barcon332 has joined #chromium
[13:47:08] *** Martijnc has quit IRC
[13:49:18] *** rolandsteiner has joined #chromium
[13:49:34] <phajdan-jr> pcgod: then it deserves a good bug report I'd say
[13:49:37] <phajdan-jr> FunkyPenguin: ^
[13:49:42] *** MikeSmithW3C^ has quit IRC
[13:50:37] <phajdan-jr> as a workaround, you should add -Dwerror= to the gyp call. This will prevent the build from failing.
[13:51:21] *** phajdan-jr is now known as phajdan-jr|afk
[13:53:00] *** Martijnc has joined #chromium
[13:54:17] <FunkyPenguin> phajdan-jr|afk, sorry for the delay - im using gcc-4.5.0
[13:54:17] <FunkyPenguin> phajdan-jr|afk, i'll file a bug shortly - and thanks for the workaround
[13:56:21] *** awolfson has joined #chromium
[13:57:46] *** Martijnc has quit IRC
[13:58:03] *** Martijnc has joined #chromium
[13:58:19] *** MikeSmithW3C^ has joined #chromium
[13:59:35] *** whesse has joined #chromium
[14:01:06] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open
[14:04:50] *** MikeSmithW3C^ has quit IRC
[14:13:47] *** phajdan-jr|afk is now known as phajdan-jr
[14:13:51] *** FullFlannelJacke has joined #chromium
[14:16:26] *** rohitrao has joined #chromium
[14:16:26] *** ChanServ sets mode: +v rohitrao
[14:18:52] *** rolandsteiner has quit IRC
[14:19:30] *** MikeSmithW3C has joined #chromium
[14:20:20] *** Beetny has quit IRC
[14:20:29] *** MikeSmithW3C has quit IRC
[14:33:55] *** cbentzel has quit IRC
[14:40:35] *** bmizerany has joined #chromium
[14:41:58] *** tonikitoo has joined #chromium
[14:42:07] *** awolfson has quit IRC
[14:45:38] *** rohitrao has quit IRC
[14:46:40] *** yutak_home has joined #chromium
[14:46:41] *** ChanServ sets mode: +v yutak_home
[14:56:28] *** aroben has joined #chromium
[14:56:29] *** aroben has joined #chromium
[14:58:31] *** _Raptor_ has joined #chromium
[14:58:33] *** cbentzel has joined #chromium
[15:01:52] *** _Raptor_ has left #chromium
[15:06:25] *** shreyas_ has joined #chromium
[15:07:26] *** lodle has quit IRC
[15:08:20] *** orm has left #chromium
[15:08:50] *** ScriptRipper has quit IRC
[15:09:40] <maruel> thakis: I restarted both Webkit Mac10.5(dbg)(2) and (3) in case
[15:09:42] *** ScriptRipper has joined #chromium
[15:10:27] *** benkong2 has joined #chromium
[15:10:35] <benkong2> hey all
[15:10:43] <benkong2> anyone got this problem?
[15:10:44] <benkong2> [1:1:1157100234:ERROR:chrome/browser/zygote_main_linux.cc(340)] write: Broken pipe
[15:11:04] *** FunkyPenguin has quit IRC
[15:11:31] <maruel> phajdan-jr: gcc 4.5.0 is broken, there are already bug reports about that
[15:11:40] <benkong2> linux mint 9 just did a dist-upgrade and new daily installed
[15:12:47] *** ScriptRipper has quit IRC
[15:12:47] *** ScriptRipper has joined #chromium
[15:13:24] *** maro has quit IRC
[15:13:25] *** rubenbb has quit IRC
[15:13:25] *** vesav has quit IRC
[15:13:26] *** cmasone has quit IRC
[15:13:26] *** BenL has quit IRC
[15:13:26] *** jam2 has quit IRC
[15:13:27] *** dcheng has quit IRC
[15:13:36] *** BenL has joined #chromium
[15:13:48] *** dcheng has joined #chromium
[15:14:22] <benkong2> chromium-browser will not start
[15:14:48] *** jam2 has joined #chromium
[15:14:48] *** ChanServ sets mode: +v jam2
[15:15:10] *** MikeSmithW3C has joined #chromium
[15:16:12] <maruel> benkong2: see topic
[15:16:51] *** tav has joined #chromium
[15:16:58] <benkong2> oops thanks sorry
[15:17:33] *** bmizerany has quit IRC
[15:19:24] *** cmasone has joined #chromium
[15:19:24] *** ChanServ sets mode: +v cmasone
[15:19:32] <maruel> PSA: I'll restart the try server
[15:20:15] *** bmizerany has joined #chromium
[15:20:34] *** vesav has joined #chromium
[15:21:32] *** maro has joined #chromium
[15:22:19] *** FunkyPenguin has joined #chromium
[15:22:38] *** XDS|Onyx|CM5 has joined #chromium
[15:25:04] *** rubenbb has joined #chromium
[15:25:49] *** cbentzel has quit IRC
[15:27:14] <phajdan-jr> maruel: ok, does it mean all gcc-4.5.0 related bugs are invalid?
[15:28:09] *** tav has quit IRC
[15:33:51] *** cbentzel has joined #chromium
[15:34:35] <maruel> phajdan-jr: invalid, no, but gcc 4.5.0 has a bug making it impossible to build chromium
[15:34:37] *** trungl has joined #chromium
[15:34:38] *** ChanServ sets mode: +v trungl
[15:34:39] <maruel> AFAIK
[15:37:36] *** dmazzoni has joined #chromium
[15:37:39] <cbentzel> OK, going to look at page_cycler_morejs on Vista perf, which has been failing for days
[15:38:23] <cbentzel> Unfortunately, it just has a "timeout" message. I've seen this before when an expected symbol was not found when loading a DLL. I'm sure there's lots of other problems which would cause this.
[15:40:47] <pcgod> maruel: it's possible to build chromium but it miscompiles one file which breaks omnibox search
[15:42:43] *** thakis_ has joined #chromium
[15:42:44] *** ChanServ sets mode: +v thakis_
[15:50:04] *** bauerb has joined #chromium
[15:50:04] *** ChanServ sets mode: +v bauerb
[15:50:53] <FunkyPenguin> maruel, sorry, you cant use gcc-4.5.0 at all? even using -Dwerror=
[15:52:13] *** leeight has joined #chromium
[15:52:59] *** leeight has left #chromium
[15:55:20] *** rohitrao has joined #chromium
[15:55:20] *** ChanServ sets mode: +v rohitrao
[15:55:23] *** MikeSmithW3C has quit IRC
[15:56:02] *** benkong2 has quit IRC
[15:58:10] *** bobthemilkman has joined #chromium
[15:58:28] <FunkyPenguin> s
[16:05:33] *** awolfson has joined #chromium
[16:05:47] *** MikeSmithW3C has joined #chromium
[16:09:25] *** MikeSmithW3C^ has joined #chromium
[16:12:10] *** MikeSmithW3C has quit IRC
[16:14:28] <FunkyPenguin> sorry how should i be using -Dwerror=
[16:15:08] * tonikitoo needs an ojan :-)
[16:17:21] *** hagabaka has joined #chromium
[16:17:21] *** hagabaka has joined #chromium
[16:18:46] *** thakis_ has quit IRC
[16:19:41] *** jedivulcan_ has joined #chromium
[16:19:52] *** bobthemilkman has quit IRC
[16:22:24] *** jedivulcan has quit IRC
[16:22:25] *** jedivulcan_ is now known as jedivulcan
[16:26:03] *** rsesek has joined #chromium
[16:26:03] *** ChanServ sets mode: +v rsesek
[16:28:07] *** bratsche has joined #chromium
[16:32:33] <phajdan-jr> FunkyPenguin: when you call gyp, add it as a command-line flag
[16:33:54] *** tedoc2000 has joined #chromium
[16:35:16] <phajdan-jr> FunkyPenguin: like build/gyp_chromium build/all.gyp -Dwerror= --depth=.
[16:35:23] <phajdan-jr> (copied the above from the Gentoo ebuild)
[16:39:39] <FunkyPenguin> phajdan-jr, ah thanks - i had it in the wrong place :)
[16:42:43] *** erikkay has joined #chromium
[16:42:44] *** ChanServ sets mode: +v erikkay
[16:44:35] *** stuartmorgan has joined #chromium
[16:44:36] *** ChanServ sets mode: +v stuartmorgan
[16:48:15] *** Gina has quit IRC
[16:49:08] *** rsesek has quit IRC
[16:52:28] *** andybons has joined #chromium
[16:52:29] *** ChanServ sets mode: +v andybons
[16:53:25] *** MichealH has joined #chromium
[16:53:37] *** hagebake has joined #chromium
[16:53:37] *** hagebake has joined #chromium
[16:53:57] *** rsesek has joined #chromium
[16:53:58] *** ChanServ sets mode: +v rsesek
[16:54:24] *** hagabaka has quit IRC
[16:55:05] *** elihorne has joined #chromium
[16:55:05] *** ChanServ sets mode: +v elihorne
[17:01:10] <trungl> 'morning, Chromium.
[17:01:11] <trungl-bot> trungl: Good morning!
[17:01:50] *** agl has quit IRC
[17:07:27] *** tonyg-cr has joined #chromium
[17:07:27] *** ChanServ sets mode: +v tonyg-cr
[17:07:29] <rohitrao> hello trungl
[17:07:41] <trungl> rohitrao!
[17:09:43] *** Gina has joined #chromium
[17:13:24] *** barcon332 has quit IRC
[17:15:09] *** peper has quit IRC
[17:22:45] *** bweinstein has joined #chromium
[17:22:53] *** bweinstein has quit IRC
[17:23:10] *** bweinstein has joined #chromium
[17:23:50] *** urbanape has quit IRC
[17:24:05] *** elihorne has left #chromium
[17:28:06] *** peper has joined #chromium
[17:34:24] *** glass-eye is now known as Slide-O-Mix
[17:37:11] <trungl-bot> Tree opened by sky at chromium dot org: Tree is open [grd change @ 51718, prepare for a bumpy ride]
[17:39:18] *** duffydack has joined #chromium
[17:42:27] *** Venom_X has joined #chromium
[17:48:38] <phajdan-jr> evmar_afk: ping
[17:56:19] <thakis> rsesek: isn't http://code.google.com/p/chromium/issues/detail?id=48453 fixed on trunk?
[17:56:30] <rsesek> thakis: yes. I just synced and noticed
[17:56:58] *** malavv has joined #chromium
[17:57:00] <thakis> rsesek: i complained about it last week and it was fixed within a day :-)
[17:57:17] <rsesek> thakis: you complained in a submitted codereivew so I figured a bug would be good ;)
[17:57:24] *** urbanape has joined #chromium
[17:57:52] *** fishd has joined #chromium
[17:57:52] *** ChanServ sets mode: +v fishd
[17:58:15] *** tonyg-cr has quit IRC
[17:58:17] *** tonyg-cr1 has joined #chromium
[17:58:17] *** ChanServ sets mode: +v tonyg-cr1
[17:59:53] *** pfeldman has quit IRC
[18:00:26] *** TabAtkins_ has joined #chromium
[18:00:26] *** ChanServ sets mode: +v TabAtkins_
[18:00:35] *** mpcomplete has joined #chromium
[18:00:35] *** ChanServ sets mode: +v mpcomplete
[18:01:05] *** pfeldman has joined #chromium
[18:04:28] *** Erkan_Yilmaz has joined #chromium
[18:10:23] *** star-affinity has quit IRC
[18:11:25] *** vitalyr has joined #chromium
[18:13:08] *** Zaba has quit IRC
[18:14:12] <vitalyr> thakis: there seems to have been lots of release mode failures before your change
[18:14:24] *** hinoka|away has joined #chromium
[18:14:24] *** ChanServ sets mode: +v hinoka|away
[18:14:29] <vitalyr> thakis: after your change debug failures started
[18:15:24] <thakis> vitalyr: hm, so maybe my change just triggered it by forcing rebuilds of some of the plugin stuff
[18:15:34] <thakis> anyways, building testshell right now
[18:16:05] *** happygrue has joined #chromium
[18:17:05] *** pfeldman has quit IRC
[18:17:25] *** pfeldman has joined #chromium
[18:17:26] *** sbyer has joined #chromium
[18:17:26] *** ChanServ sets mode: +v sbyer
[18:18:48] *** rohitkc has quit IRC
[18:19:47] *** Zaba has joined #chromium
[18:20:00] *** happygrue_ has joined #chromium
[18:20:21] *** rohitkc has joined #chromium
[18:21:36] <vitalyr> thakis: on the main waterfall the flakiness dashboard reports that the release mode failures started after http://src.chromium.org/viewvc/chrome?view=rev&revision=51540
[18:21:47] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "XP Tests (dbg)(1)" from 51717: stuartmorgan at chromium dot org)
[18:22:07] <vitalyr> thakis: dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fframes%2Fsandboxed-iframe-about-blank.html%2Cfast%2Fframes%2Fsandboxed-iframe-navigation-allowed.html%2Chttp%2Ftests%2Fplugins%2Fcross-frame-object-access.html%2Chttp%2Ftests%2Fsecurity%2FmixedContent%2Finsecure-plugin-in-iframe.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fembed-tag-control-char.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fembed-ta
[18:22:08] <vitalyr> g-null-char.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fembed-tag.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fobject-embed-tag-control-char.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fobject-embed-tag-null-char.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fobject-embed-tag.html%2Chttp%2Ftests%2Fsecurity%2FxssAuditor%2Fobject-tag.html%2Cplatform%2Fchromium%2Fplugins%2Fcall-as-function.html%2Cplatform%2Fchromium%2Fplugins%2Fmultiple-plugins.html%2Cp
[18:22:08] <vitalyr> latform%2Fchromium%2Fplugins%2Fnested-plugin-objects.html%2Cplatform%2Fchromium%2Fplugins%2Frefcount-leaks.html%2Cplatform%2Fchromium%2Fplugins%2Freturn-npobject.html%2Cplatform%2Fchromium%2Fplugins%2Fscript-object-invoke.html%2Cplugins%2Fdestroy-during-npp-new.html%2Cplugins%2Fdestroy-plugin-from-callback.html%2Cplugins%2Fembed-property.html%2Cplugins%2Fget-empty-url.html%2Cplugins%2Fget-url-that-the-resource-load-delegate-will-disallow.html%2Cplugins%
[18:22:14] <vitalyr> 2Fgetintidentifier-special-values.html%2Cplugins%2Fgeturlnotify-during-document-teardown.html%2Cplugins%2Finstance-available-before-stylesheets-loaded-object.html%2Cplugins%2Finstance-available-before-stylesheets-loaded.html%2Cplugins%2Finvoke.html%2Cplugins%2Fnetscape-construct.html%2Cplugins%2Fnetscape-destroy-plugin-script-objects.html%2Cplugins%2Fnetscape-get-property-return-value.html%2Cplugins%2Fnetscape-identifier-conversion.html%2Cplugins%2Fnets
[18:22:19] <vitalyr> cape-invoke-browserfuncs.html%2Cplugins%2Fnetscape-invoke-default.html%2Cplugins%2Fnetscape-invoke-failure.html%2Cplugins%2Fnetscape-plugin-map-data-to-src.html%2Cplugins%2Fnetscape-plugin-property-access-exception.html%
[18:22:20] <thakis> vitalyr: the code in that revision isn't used by webkit tests
[18:22:27] <thakis> vitalyr: whow. use a pastebin.
[18:22:42] <thakis> vitalyr: see pkasting's recent mail to chromium-dev about this problem
[18:22:47] <trungl-bot> Tree opened by sky at chromium dot org: Tree is open [grd change @ 51718, prepare for a bumpy ride]
[18:22:57] <thakis> must've been something earlier to that revision
[18:22:59] *** happygrue has quit IRC
[18:23:04] <thakis> mpcomplete just happened to trigger it
[18:23:08] <vitalyr> thakis: heh, sorry, didn't look that long in the browser
[18:24:50] *** happygrue_ has quit IRC
[18:25:20] *** happygrue has joined #chromium
[18:26:26] *** vitalyr has quit IRC
[18:28:26] *** duff has joined #chromium
[18:30:55] *** duffydack has quit IRC
[18:31:33] <thakis> i can see the webkit failures locally
[18:31:35] <thakis> good news i guess
[18:32:06] *** markmentovai has joined #chromium
[18:32:06] *** ChanServ sets mode: +v markmentovai
[18:32:52] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open [grd change @ 51718, prepare for a bumpy ride; thakis looking at webkit_tests]
[18:39:30] *** dave_levin has joined #chromium
[18:39:31] *** RT|Chatzilla has quit IRC
[18:40:02] <thakis> pkasting: webkit sheriff ping
[18:41:23] *** fta has joined #chromium
[18:41:26] *** phajdan-jr is now known as phajdan-jr|afk
[18:44:03] <thakis> pkasting: unping for now
[18:48:53] *** dave_levin has quit IRC
[18:49:26] *** loislo has quit IRC
[18:50:20] *** bauerb has quit IRC
[18:51:00] *** tonyg-cr1 has quit IRC
[18:51:59] *** fta has quit IRC
[18:53:22] *** fta has joined #chromium
[18:54:10] <trungl-bot> Tree opened by sky at chromium dot org: Tree is open [thakis looking at webkit_tests]
[18:54:45] *** pfeldman has quit IRC
[18:55:03] *** roc has quit IRC
[18:55:33] *** Venom_X has quit IRC
[18:55:33] *** Venom_X_ has joined #chromium
[18:55:33] *** Venom_X_ is now known as Venom_X
[18:56:24] *** tonyg-cr has joined #chromium
[18:56:24] *** ChanServ sets mode: +v tonyg-cr
[18:58:45] *** [Nef] has quit IRC
[19:02:16] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open [thakis looking at webkit_tests, cbentzel looking at page_cycler_morejs]
[19:04:37] *** Venom_X has quit IRC
[19:04:38] *** Venom_X has joined #chromium
[19:06:03] *** cdegough has joined #chromium
[19:08:42] *** shreyas_ has quit IRC
[19:11:14] *** jamesr has joined #chromium
[19:11:15] *** ChanServ sets mode: +v jamesr
[19:13:23] <stuartmorgan> thakis: do those webkit tests do clean builds? Maybe this is just really belated fallout from my change because of a clobber or something
[19:13:50] <thakis> stuartmorgan: my current theory is that they don't and that the plugin was still around on the old location
[19:13:52] *** shreyas_ has joined #chromium
[19:13:54] <thakis> and that your change might've broken it
[19:14:12] <thakis> mpcomplete just happened to step on this for the release builds and for debug builds
[19:14:16] <thakis> i'm testing locally
[19:14:30] <stuartmorgan> thakis: Yeah, that seems plausible. I assumed since all the trybots and then real bots were happy, I'd covered everything that needed the flag
[19:16:05] *** sky_ has quit IRC
[19:18:05] *** sbyer has quit IRC
[19:19:28] <stuartmorgan> thakis: I can't even tell where TeshShell gets launched from for these tests :P I think we should just revert the webkit/tools/test_shell/test_shell.gypi part of my change for now
[19:19:48] <stuartmorgan> Unless you know where the launch happens so we can add the flag
[19:20:15] <thakis> stuartmorgan: toplevel entry point is webkit/tools/layout_tests/run_webkit_tests.sh
[19:20:36] <stuartmorgan> Yeah, I'm a couple of layers in so far
[19:21:05] <thakis> that calls third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[19:21:06] *** jamesr has quit IRC
[19:21:22] *** sbyer has joined #chromium
[19:21:22] *** ChanServ sets mode: +v sbyer
[19:21:24] <thakis> and that calls third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py i guess
[19:22:28] *** sky_ has joined #chromium
[19:22:28] *** ChanServ sets mode: +v sky_
[19:22:51] *** lianj has quit IRC
[19:22:51] *** lianj has joined #chromium
[19:22:56] <thakis> stuartmorgan: copying the plugin over fixes things for me locally
[19:23:18] <stuartmorgan> Okay, I'll revert that part
[19:23:59] *** dglazkov has joined #chromium
[19:23:59] *** ChanServ sets mode: +v dglazkov
[19:24:20] <dglazkov> good morning, Chromium!
[19:24:20] <trungl-bot> dglazkov: Good morning!
[19:25:46] <trungl> Good morning, dglazkov!
[19:26:01] <thakis> stuartmorgan: we should fix the script invocation i think
[19:26:09] <thakis> stuartmorgan: dpranke probably can tell us how
[19:26:24] <thakis> stuartmorgan: i replied to the chromium-dev thread and asked him to join us here
[19:26:25] *** csilv has joined #chromium
[19:26:25] *** ChanServ sets mode: +v csilv
[19:26:30] <thakis> doesn't look like there's a rush to fix this :-P
[19:26:31] <stuartmorgan> thakis: of course we should, but we shouldn't leave the tree broken in the meantime. And it's probably something that needs a webkit roll
[19:27:22] <stuartmorgan> thakis: because nobody fixed it over a holiday weekend it should stay broken now that people are looking at it?
[19:27:37] <thakis> stuartmorgan: fair enough
[19:29:14] *** cdegough has left #chromium
[19:32:10] *** jparent_ has quit IRC
[19:33:23] *** adzuci has quit IRC
[19:34:12] *** robertshield has joined #chromium
[19:35:04] *** loislo has joined #chromium
[19:36:26] *** bratsche has quit IRC
[19:37:59] *** adzuci has joined #chromium
[19:38:09] *** phajdan-jr|afk is now known as phajdan-jr
[19:41:29] *** jparent has joined #chromium
[19:41:29] *** ChanServ sets mode: +v jparent
[19:43:42] <trungl-bot> Tree opened by cbentzel at chromium dot org: Tree is open [thakis looking at webkit_tests, cbentzel looking at memory tests]
[19:46:41] *** adzuci has quit IRC
[19:46:57] *** johnny_g has joined #chromium
[19:47:21] *** adzuci has joined #chromium
[19:47:55] *** reuss has left #chromium
[19:49:04] *** bratsche has joined #chromium
[19:50:18] <tonyg-cr> cbentzel: There are 2 flaky reliability crashes that have been going on long enough that i can't pinpoint the roll. I'm going to open bugs and start looking into them
[19:50:51] <cbentzel> tonyg-cr: SGTM
[19:50:55] *** sky_ has left #chromium
[19:52:18] <rsesek> is autocomplete in crbug broken for other people?
[19:54:09] <thakis> webkit folks (e.g. japhet): I have a cl that may or may not need rebaselines for chromium/skia ( https://bugs.webkit.org/show_bug.cgi?id=41580 ). how do i go about landing it?
[19:55:54] *** sky_ has joined #chromium
[19:55:54] *** ChanServ sets mode: +v sky_
[19:56:06] *** howlymowly has quit IRC
[19:56:06] *** duff has left #chromium
[19:56:29] *** howlymowly has joined #chromium
[19:57:52] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open [cbentzel looking at memory tests]
[19:58:14] *** apatrick_ has joined #chromium
[19:58:14] *** ChanServ sets mode: +v apatrick_
[19:59:09] *** hrna has quit IRC
[20:03:21] *** eroman has joined #chromium
[20:03:21] *** ChanServ sets mode: +v eroman
[20:03:59] <japhet> thakis: rebaslines other than the test you're adding i assume?
[20:04:07] <thakis> japhet: yes
[20:04:11] <thakis> japhet: i just found http://trac.webkit.org/wiki/Rebaseline
[20:04:19] <thakis> does this talk about the webkit buildbots?
[20:04:26] <thakis> i.e. do i just land my patch?
[20:04:59] *** fta_ has joined #chromium
[20:06:04] *** fta has quit IRC
[20:08:02] *** dmaclach has joined #chromium
[20:09:07] *** bmizerany has quit IRC
[20:10:50] <japhet> thakis: i think that's the best we can do, but i would strongly recommend warning the webkit gardener before landing :-)
[20:11:14] <japhet> thakis: though it's been a few months since my gardener shift came up, so my knowledge may be out of date
[20:11:39] <thakis> pkasting: ^ be warned :-)
[20:12:51] *** hrna has joined #chromium
[20:12:58] <thakis> pkasting: ideally, you could set cq+ on https://bugs.webkit.org/show_bug.cgi?id=41580
[20:13:04] <thakis> (i can't, i'm not a committer)
[20:15:05] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 51740: ajwong at chromium dot org, eroman at chromium dot org (:eroman))
[20:15:37] *** dimich has quit IRC
[20:15:54] *** shreyas_ has quit IRC
[20:16:29] <awong> failure seems like windows build issue? fatal error RC1109: error creating c:\b\slave\webkit-dbg-builder\build\src\webkit\Debug\obj\test_shell\test_shell.exe.embed.manifest.res
[20:17:15] <eroman> awong: agreed, i dont think it has to do with our changes. wait for it to try again?
[20:17:30] <awong> eroman: that's my thought.  Shoudl we reopen?
[20:17:43] <eroman> awong: my eight ball says Yes
[20:17:56] <tonyg-cr> that error looks like what happens when a process is still open using the exe
[20:18:06] <tonyg-cr> perhaps the previous run didn't close down properly
[20:18:09] <tonyg-cr> reopening sounds good
[20:18:15] <awong> done
[20:19:07] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open [Webkit Builder (dbg) expected to cycle clean]
[20:19:07] *** apavlov has quit IRC
[20:21:03] *** mrossetti has joined #chromium
[20:21:03] *** ChanServ sets mode: +v mrossetti
[20:25:11] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 51740: ajwong at chromium dot org, andybons at chromium dot org, dhollowa at chromium dot org, eroman at chromium dot org (:eroman))
[20:25:49] <awong> similar to last time...looks like build flake:  webcore.lib(RenderTextControl.obj) : fatal error LNK1318: Unexpected PDB error; UNKNOWN (24) ''
[20:26:14] <tonyg-cr> the windows one has cleared up already
[20:26:34] <tonyg-cr> *sorry, the webkit one
[20:26:39] <tonyg-cr> safe to reopen
[20:27:12] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open [ Chromium builder expected to go green ]
[20:28:03] <awong> looking through the log, there seems to be a number of warnings about Unrecognized Elements during the "Embedding manifest" stage.  Is that normal?
[20:28:22] <awong> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20(dbg)/builds/21983/steps/compile/logs/stdio   Look for "requestedPrivileges"
[20:28:35] *** jamesr has joined #chromium
[20:28:35] *** ChanServ sets mode: +v jamesr
[20:34:13] *** fta_ is now known as fta
[20:34:29] *** malavv has quit IRC
[20:34:53] *** phajdan-jr is now known as phajdan-jr|afk
[20:39:15] *** pathorn has joined #chromium
[20:39:15] *** ChanServ sets mode: +v pathorn
[20:39:33] <thakis> rsesek: do you know if someone is working no the "you've been update,r estart chrome" notification on mac?
[20:39:33] *** mnissler_ has joined #chromium
[20:40:00] <rsesek> thakis: I don't think anyone is doing the UI; mark has the backend piece
[20:43:40] *** cbentzel has quit IRC
[20:45:04] *** cbentzel has joined #chromium
[20:46:48] *** bmizerany has joined #chromium
[20:47:18] <markmentovai> thakis: i think the ui is just "orange ball"
[20:47:34] <markmentovai> i can probably just tie the backend up to do that
[20:47:34] <markmentovai> and
[20:47:39] <thakis> markmentovai: and a new menu item in the wrench menu that opens a dialog
[20:47:43] <markmentovai>  if we want to do more/less/change it, we can work that
[20:47:44] <markmentovai> yup
[20:51:06] *** hagebake has left #chromium
[20:51:18] <fearphage> a bug for you http://www.trygve-lie.com/blog/entry/svg_embed_and_performance
[20:52:39] <thakis> fearphage: bugs.webkit.org
[20:53:01] *** trungl_ has joined #chromium
[20:53:01] *** ChanServ sets mode: +v trungl_
[20:53:53] *** trungl__ has joined #chromium
[20:53:53] *** ChanServ sets mode: +v trungl__
[20:54:09] <thakis> trungl trungl_ trungl__!
[20:54:22] <trungl__> don't forget trungl_afk
[20:54:27] <thakis> he's afk
[20:54:50] <trungl__> man, this game is really boring so far
[20:54:55] *** udp has quit IRC
[20:55:14] *** udp has joined #chromium
[20:57:09] *** trungl has quit IRC
[20:57:09] *** trungl__ is now known as trungl
[20:57:28] <phajdan-jr|afk> trungl__: not sure if it's applicable here, but /msg nickserv ghost ... might be useful
[20:57:34] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 51745: gene at chromium dot org, hclam at chromium dot org, suzhe at chromium dot org)
[20:57:38] *** trungl_ has quit IRC
[20:57:46] *** phajdan-jr|afk is now known as phajdan-jr
[20:58:06] <hclam> compilation failed? looking..
[20:58:12] *** abarth has quit IRC
[20:59:47] <hclam> looks like it failed to generated chrome frame header
[21:01:06] <hclam> none of the three patches affected those files, maybe flaky?
[21:01:54] <trungl> phajdan-jr: it surely would be applicable, but I'm clearly too lazy to use it
[21:01:55] <phajdan-jr> hclam: that would be bad, could you paste the log URL here?
[21:02:04] <trungl> plus I'd have to remember my password
[21:02:15] *** mattm_g has quit IRC
[21:02:45] <hclam> Reading input_file: C:/b/slave/chromium-rel-xp/build/src/chrome/installer/mini_installer/chrome_frame.release
[21:02:45] <hclam> Scanning for server DLLs in C:/b/slave/chromium-rel-xp/build/src/build/Release
[21:02:45] <hclam> Traceback (most recent call last):
[21:02:45] <hclam>   File "tools/build/win/scan_server_dlls.py", line 153, in ?
[21:02:45] <hclam>     sys.exit(main(options))
[21:02:45] <hclam>   File "tools/build/win/scan_server_dlls.py", line 138, in main
[21:02:46] <hclam>     options.output_dir)
[21:02:46] <hclam>   File "tools/build/win/scan_server_dlls.py", line 96, in ScanServerDlls
[21:02:47] <hclam>     ScanDllsInSection(config, 'GENERAL', output_dir, registered_dll_list)
[21:02:47] <hclam>   File "tools/build/win/scan_server_dlls.py", line 111, in ScanDllsInSection
[21:02:48] <hclam>     for option in config.options(section):
[21:02:49] <hclam>   File "c:\b\slave\chromium-rel-xp\build\src\third_party\python_24\lib\ConfigParser.py", line 241, in options
[21:02:49] <hclam>     raise NoSectionError(section)
[21:02:49] <hclam> ConfigParser.NoSectionError: No section: 'GENERAL'
[21:03:15] <hclam> but not really flaky, failed twice already
[21:03:15] <rsesek> pastebin please
[21:03:30] <hclam> sorry, my bad
[21:03:31] <phajdan-jr> hclam: might be a sick bot
[21:04:26] <mnissler_> hclam: I can only see PDB error, happens every now and then...
[21:04:59] <phajdan-jr> do we have a GreenTreeTaskForce bug about these PDB flakes?
[21:05:08] *** bmizerany has quit IRC
[21:07:58] <mnissler_> phajdan-jr: I don't think so... will create one.
[21:08:41] *** victorw has left #chromium
[21:10:03] <phajdan-jr> thanks!
[21:10:24] *** tedoc2000 has quit IRC
[21:11:11] *** tedoc2000 has joined #chromium
[21:11:36] *** mattm_g has joined #chromium
[21:11:39] *** ChanServ sets mode: +v mattm_g
[21:12:03] *** romainhuet has quit IRC
[21:12:21] *** fta_ has joined #chromium
[21:12:54] *** dave_levin has joined #chromium
[21:14:04] *** fta has quit IRC
[21:14:49] *** dumi has joined #chromium
[21:14:50] *** ChanServ sets mode: +v dumi
[21:15:31] *** gOcOOl has left #chromium
[21:16:35] *** phajdan-jr is now known as phajdan-jr|afk
[21:17:30] *** fta_ is now known as fta
[21:18:34] <mnissler_> rsesek: Might the TabRestoreUITest.BasicRestoreFromClosedWindow failures be due to your change?
[21:18:48] <rsesek> mnissler: let me see
[21:19:13] <rsesek> mnissler: probably. will revert
[21:19:35] *** fsamuel has joined #chromium
[21:19:38] <rsesek> mnissler: can I commit on closed tree?
[21:19:45] *** [Nef] has joined #chromium
[21:19:57] <mnissler_> phajdan-jr|afk: here is the bug, in case you want to add more information http://code.google.com/p/chromium/issues/detail?id=48488
[21:20:40] <mnissler_> rsesek: technically you can of course :) but I'm no sheriff...
[21:20:45] <rsesek> oh heh I just assumed
[21:21:25] <mnissler_> rsesek: considering the compile failure is probably only win hickup, I would just go ahead :)
[21:21:51] <mnissler_> rsesek: positive, next win build compiled successfully
[21:21:53] <rsesek> kk
[21:22:47] *** ph0nk has joined #chromium
[21:22:57] <fsamuel> so I'm working on a delightful svg/skia bug :) SkPathContainsPoint in SkiaUtils.cpp seems to be very badly broken if your viewport is not in screen coordinates (pixels)
[21:23:27] <trungl> here goes nothing
[21:23:49] <fsamuel> one solution would be to make SkRegion use floats (A LOT of work)
[21:24:05] <fsamuel> a simpler solution would be to transform the path into screen coordinates
[21:24:15] <fsamuel> is this an acceptable solution?
[21:24:56] <trungl> crap
[21:24:58] <trungl> closed tree
[21:25:00] <trungl> sigh
[21:25:12] <maruel> fsamuel: trying asking on the ML, maybe senorblanco knows
[21:29:23] * maruel commits gclient refactor of hell
[21:29:24] <thakis> fsamuel: SkRegion probably shouldn't be changed
[21:29:25] *** tedoc2000 has quit IRC
[21:29:32] <thakis> fsamuel: best ask on the bug and cc people
[21:29:43] <thakis> senorblanco and agl ahve used skia before
[21:29:45] <thakis> brettw too
[21:30:08] *** tedoc2000 has joined #chromium
[21:30:54] * maruel reverts
[21:30:54] <fsamuel> thakis: Skia uses ints ALL over the place, which doesn't work well if your svg viewBox is unusual.
[21:31:38] *** dmaclach has quit IRC
[21:33:23] <maruel> I fixed the bug instead of reverting
[21:33:29] <fsamuel> maruel, thakis: I'll post this on the ML, thanks.
[21:33:30] *** dimich has joined #chromium
[21:33:30] *** ChanServ sets mode: +v dimich
[21:33:57] *** barcon332 has joined #chromium
[21:34:06] <trungl> can/should we re-open?
[21:34:15] <trungl> the failure which closed it cleared
[21:36:18] <maruel> fixed Chromium Linux (dbg-shlib)
[21:37:20] <mnissler_> trungl: I believe so. The revert for the failing ui_tests is also in.
[21:37:39] <mnissler_> any sheriffs around?
[21:37:44] <trungl> trungl-bot: settreestatus Tree is open (reverts in)
[21:37:45] <trungl-bot> trungl: Set tree status to: "Tree is open (reverts in) [set by :trungl]".
[21:38:01] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (reverts in) [set by :trungl]
[21:38:04] <trungl> tonyg-cr: ?
[21:38:13] <trungl> cbentzel: ?
[21:38:20] <trungl> well, I opened it anyway
[21:38:27] *** cbentzel has quit IRC
[21:38:48] <tonyg-cr> trungl: thanks!
[21:38:56] *** dimich has quit IRC
[21:39:01] <trungl> don't thank me yet
[21:39:05] * trungl is about to break the tree
[21:39:16] <trungl> well, hopefully not
[21:39:30] <trungl> but with decided nonzero probability
[21:40:06] *** cbentzel has joined #chromium
[21:40:21] <trungl> crap
[21:40:25] <trungl> needs rebasing
[21:41:11] *** jamesr_ has joined #chromium
[21:41:12] *** ChanServ sets mode: +v jamesr_
[21:41:36] <maruel> it's possible you see gclient exceptions, it's my fault and will recover within 5 minutes
[21:42:18] <mnissler_> trungl: no luck, ey? ;)
[21:43:17] *** duffydack has joined #chromium
[21:43:51] <trungl> ok, here goes nothing
[21:43:52] <trungl> (again)
[21:43:57] *** romainhuet has joined #chromium
[21:44:13] *** romainhuet has quit IRC
[21:45:03] *** jamesr has quit IRC
[21:45:04] *** jamesr_ is now known as jamesr
[21:45:47] <cbentzel> sehr, tonyg: Is there anything you want me to look at? Tree is fairly red. Sorry I was gone for a bit.
[21:45:47] *** bmizerany has joined #chromium
[21:46:33] *** andrix1 has joined #chromium
[21:46:50] *** ratdeptrai has joined #chromium
[21:48:15] *** michaeln has joined #chromium
[21:48:15] *** ChanServ sets mode: +v michaeln
[21:49:00] <tonyg-cr> cbentzel: 51759 should green up most tests
[21:49:13] *** andrix has quit IRC
[21:49:22] <tonyg-cr> we could close until it cycles through to be sure
[21:49:40] <cbentzel> tonyg-cr: Tempted, but let
[21:50:03] <tonyg-cr> it looks really bad, but its really just that one revert
[21:50:15] <cbentzel> OK
[21:50:47] <tonyg-cr> although, i'm not sure about net_unittests
[21:51:29] <fta> oh my, chromium is really unusable with recent cairo
[21:52:50] *** duffydack has left #chromium
[21:53:32] *** pfeldman has joined #chromium
[21:55:45] *** fishd has quit IRC
[21:57:47] <tonyg-cr> willchan: is it possible reverting mbelshe's change caused SpdyNetworkTransactionTest.CorruptFrameSessionError to hang?
[21:58:04] *** chrisccoulson has quit IRC
[22:00:43] *** fta_ has joined #chromium
[22:00:48] *** phajdan-jr|afk has quit IRC
[22:02:19] *** fta has quit IRC
[22:02:29] *** dmaclach has joined #chromium
[22:03:04] *** NthDeGeek has joined #chromium
[22:04:57] *** jrmuizel has joined #chromium
[22:06:10] *** dimich has joined #chromium
[22:06:11] *** ChanServ sets mode: +v dimich
[22:07:26] <tonyg-cr> trungl: I didn't follow what you expected would fix the xp compile error, do we need to restart the bot?
[22:08:05] <trungl> tonyg-cr: errrr, I didn't see that
[22:08:26] <trungl> tonyg-cr: (that particular build failure, that is)
[22:09:26] *** chrisccoulson has joined #chromium
[22:11:17] <trungl> tonyg-cr: maybe kicking the bot would help?
[22:11:21] <trungl> I have no idea
[22:11:36] <robertshield> trungl: I think the compile error is my fault.
[22:12:32] <trungl> robertshield: seems quite possible
[22:12:33] *** MikeSmithW3C^ has quit IRC
[22:12:39] <robertshield> There's a dependency error introduced with an installer change I made
[22:12:42] <robertshield> there's a fix at http://codereview.chromium.org/2877013
[22:13:00] <robertshield> may I commit it?
[22:13:27] <trungl> sure
[22:13:28] <cbentzel> robertshield: LGTM
[22:14:29] <robertshield> ok, committed
[22:14:40] *** dpranke has joined #chromium
[22:14:41] *** ChanServ sets mode: +v dpranke
[22:14:48] <robertshield> sorry about that
[22:16:18] <trungl> trungl-bot: settreestatus Tree is open (fix in for Chromium XP build failure)
[22:16:18] <fsamuel> http://code.google.com/p/chromium/issues/detail?id=25135 In case anyone wants to look at my current workaround
[22:16:19] <trungl-bot> trungl: Set tree status to: "Tree is open (fix in for Chromium XP build failure) [set by :trungl]".
[22:16:23] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (fix in for Chromium XP build failure) [set by :trungl]
[22:17:24] *** pfeldman has quit IRC
[22:17:25] *** MikeSmithW3C^ has joined #chromium
[22:17:56] *** andrix1 has quit IRC
[22:19:59] *** ph0nk has quit IRC
[22:20:08] *** ph0nk has joined #chromium
[22:21:05] *** ph0nk1 has joined #chromium
[22:21:06] *** ph0nk has quit IRC
[22:21:08] *** mnissler_ has quit IRC
[22:21:18] *** jrmuizel_ has joined #chromium
[22:21:24] *** dhollowa_ has quit IRC
[22:22:15] *** malavv has joined #chromium
[22:23:07] <hclam> the heapcheck error is on me.. fixing it now
[22:23:39] *** jrmuizel has quit IRC
[22:23:40] *** jrmuizel_ is now known as jrmuizel
[22:24:48] *** bradn has joined #chromium
[22:24:49] *** bradn has quit IRC
[22:25:09] <trungl> tonyg-cr, cbentzel: what do you think of closing the tree to let the bots catch up a bit?
[22:25:13] *** ph0nk has joined #chromium
[22:25:36] *** ph0nk1 has quit IRC
[22:25:41] <tonyg-cr> trungl-bot: settreestatus Tree is closed (too far behind)
[22:25:42] <trungl-bot> tonyg-cr: Set tree status to: "Tree is closed (too far behind) [set by :tonyg-cr]".
[22:25:56] <tonyg-cr> trungl: good idea
[22:26:29] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (too far behind) [set by :tonyg-cr]
[22:26:46] *** GeorgeY has left #chromium
[22:27:37] *** peper has quit IRC
[22:32:00] *** feldstein has joined #chromium
[22:32:00] *** ChanServ sets mode: +v feldstein
[22:33:52] *** peper has joined #chromium
[22:36:30] *** jrmuizel has quit IRC
[22:41:49] *** fta__ has joined #chromium
[22:42:50] *** fta_ has quit IRC
[22:43:02] *** feldstein has quit IRC
[22:43:40] *** dionyziz has joined #chromium
[22:45:23] <cbentzel> hclam: Should we just revert r51767? Or is a patch coming soon?
[22:46:30] <hclam> cbentzel: there'll be a patch coming soon
[22:46:38] <hclam> cbentzel: i'll suppress the error first
[22:48:18] <trungl> tonyg-cr, cbentzel: do you guys know what's up with the purple?
[22:50:30] *** MichealH_ has joined #chromium
[22:50:33] <cbentzel> hclam: OK, please enter a bug if one hasn't been entered already
[22:50:41] <cbentzel> trungl: Haven't looked at purple yet, looking now
[22:50:53] *** fta__ is now known as fta
[22:51:39] <trungl> cbentzel: looks like out of disk space for one of them
[22:51:59] <tonyg-cr> trungl: who has rights to resolve that?
[22:52:14] <trungl> tonyg-cr: one of the troopers, I guess?
[22:52:26] <trungl> maruel, nsylvain: ^^^
[22:52:32] <trungl> I don't know who's around today
[22:52:44] *** ROBOd has quit IRC
[22:53:01] <cbentzel> trungl, tonyg-cr: maruel was around earlier
[22:53:20] *** MichealH has quit IRC
[22:53:33] *** MichealH_ has quit IRC
[22:53:48] <trungl> markmentovai might also be able to help?
[22:54:21] <nsylvain> trungl / tonyg-cr : what's up?
[22:54:25] *** MichealH_ has joined #chromium
[22:54:36] <trungl> nsylvain: purple bots
[22:54:42] <trungl> one of them is out of disk space
[22:54:49] <trungl> other ... dunno
[22:54:50] <nsylvain> ok
[22:54:51] <cbentzel> trungl, tonyg-cr: I can wipe out the c:\b\slave\chromium-rel-nacl-tests-64\build directory (I think)
[22:55:03] *** MichealH_ is now known as MichealH
[22:55:21] *** MichealH has quit IRC
[22:55:21] *** MichealH has joined #chromium
[22:56:03] *** feldstein has joined #chromium
[22:56:03] *** ChanServ sets mode: +v feldstein
[22:58:54] <trungl> cbentzel, tonyg-cr, nsylvain: also, someone should probably check up on Chromium Reliability
[23:00:00] <cbentzel> trungl, tonyg-cr: OK, wiped out the directory on codgq189, I'll see if that fixes things.
[23:00:25] <hclam> cbentzel: I have a fix for the heapcheck / valgrind error, can I land it?
[23:00:41] <cbentzel> hclam: CL?
[23:01:16] <hclam> cbentzel: ploading
[23:01:34] <tonyg-cr> trungl: reliability is just waiting for a build, which should be okay at 51771, right?
[23:01:58] <trungl> tonyg-cr: oh, right
[23:02:17] <tonyg-cr> another good reason to keep things closed right now
[23:02:21] <trungl> forgot about the string of failed release builds
[23:03:03] <hclam> cbentzel: http://codereview.chromium.org/2818047
[23:03:40] *** General13372 has joined #chromium
[23:05:19] *** abarth has joined #chromium
[23:05:19] *** ChanServ sets mode: +v abarth
[23:05:23] *** loislo has quit IRC
[23:05:44] <cbentzel> hclam: I think it's fine to add after the tree re-opens normally (don't usually stall for memory tests).
[23:05:54] *** MichealH has quit IRC
[23:05:58] <hclam> ok, thanks
[23:05:59] <cbentzel> hclam: My general preference is to just revert the broken CL and make the fix after
[23:06:08] <nsylvain> trungl: i have a super flaky wireless connection, i can seem to be able to connect. someone else shuld take care of it ... i'll keep trying though
[23:06:53] *** General1337 has quit IRC
[23:08:51] <rsesek> sky_: ping
[23:10:55] <cbentzel> trungl, tonyg-cr, nsylvain: xp reliability is still compiling, but made it past previous failures
[23:11:00] <sky_> I'm here.
[23:11:23] *** awolfson has quit IRC
[23:12:05] <rsesek> sky_: my CL broke the TabRestoreUITest. going to send a modified one to you
[23:12:14] <sky_> ok
[23:12:23] <tonyg-cr> cbentzel: what do you mean? If I understand correctly, once the xp compile passes at 51771, then the reliability will take that build and continue.
[23:13:08] <cbentzel> tonyg-cr: Ooops, I was talking about XP compile only, not reliability
[23:13:39] *** bandu has joined #chromium
[23:14:36] <tonyg-cr> cbentzel: gotcha. it looks like it might succeed on this run, do you see an error in the current output?
[23:15:03] <cbentzel> tonyg-cr: I did not see an error (and it made it past the previous compilation failure)
[23:18:22] *** tonikitoo has quit IRC
[23:18:23] <robertshield> yes, looks like the setup fix worked. sorry for the redness
[23:19:20] <tonyg-cr> cbentzel: i see now, it has finished compiling, we should fix the purple and reopen
[23:19:48] <tonyg-cr> cbentzel: were you able to fix the purple or do we need another trooper (since nsylvain is having trouble logging in)
[23:20:10] <cbentzel> tonyg-cr: I _may_ have fixed the NACL Tests (x64) one
[23:20:35] <cbentzel> tonyg-cr: I can try to free up space on Vista Perf (dbg)
[23:21:45] *** dionyziz has quit IRC
[23:22:30] <tonyg-cr> cbentzel: i think we should reopen now, vista perf has been failing anyway, so it is probably okay if it is purple until you find some hdd space there
[23:23:12] <trungl> tonyg-cr, cbentzel: I agree with tony
[23:23:17] <cbentzel> tonyg-cr: Sounds good.
[23:23:48] <tonyg-cr> trungl-bot: settreestatus Tree is open (purple -> cbentzel)
[23:23:49] <trungl-bot> tonyg-cr: Set tree status to: "Tree is open (purple -> cbentzel) [set by :tonyg-cr]".
[23:24:05] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open (purple -> cbentzel) [set by :tonyg-cr]
[23:24:42] *** fta_ has joined #chromium
[23:25:49] *** fta has quit IRC
[23:26:30] *** fta_ has quit IRC
[23:27:46] *** jamesr has quit IRC
[23:31:50] *** jamesr has joined #chromium
[23:31:51] *** ChanServ sets mode: +v jamesr
[23:33:06] <tonyg-cr> trungl: Is it possible to suppress one of the duplicate reports from trungl-bot ^^^
[23:33:37] <trungl> tonyg-cr: yes, though then I'd have to make it smarter
[23:33:37] <tonyg-cr> trungl: it seems to output that it has set the status, and then poll the tree and output again when it "finds out" that is has set the status
[23:33:49] <trungl> yeah
[23:33:58] <trungl> I'll fix it sometime
[23:34:17] <tonyg-cr> the bot rocks by the way
[23:34:24] <trungl> thanks :)
[23:37:22] <rohitrao> trungl, thakis: if I run startup_tests locally, what do I do with the output?
[23:37:38] <trungl> rohitrao: what do you mean?
[23:37:40] <thakis> rohitrao: throw it into a python shell
[23:37:47] <thakis> rohitrao: type python
[23:37:49] <thakis> then type
[23:37:52] <thakis> min([
[23:37:55] <thakis> then hit cmd-v
[23:37:57] <thakis> then hit ])
[23:37:59] <thakis> and hit enter
[23:38:03] <thakis> or do
[23:38:09] <thakis> def avg(x): return sum(x) / len(x)
[23:38:11] * trungl had various scripts
[23:38:12] <thakis> and type
[23:38:17] <rohitrao> haha
[23:38:19] <thakis> avg([
[23:38:20] <thakis> paste
[23:38:20] *** mrossetti has quit IRC
[23:38:21] <thakis> ])
[23:38:22] <thakis> etc
[23:38:25] <rohitrao> ok, so just looking at the min and avg of the results?
[23:38:26] *** mrossetti has joined #chromium
[23:38:26] *** ChanServ sets mode: +v mrossetti
[23:38:35] *** mrossetti has quit IRC
[23:38:36] <thakis> rohitrao: i like min, markmentovai likes avg
[23:38:43] <rohitrao> I'm turning on layers across the board :-D
[23:38:44] <thakis> rohitrao: mean works too
[23:38:46] * trungl preferred the mid-80% average
[23:39:07] *** mrossetti has joined #chromium
[23:39:07] *** ChanServ sets mode: +v mrossetti
[23:39:08] <rohitrao> are some of these tests more important than others?
[23:39:21] <trungl> but depending on the perf impact you're looking for (and how idle your machine is), you may need lots of runs to get meaningful results
[23:39:22] <rohitrao> and should I be running anything else other than startup_tests?
[23:39:30] <trungl> hmm
[23:39:45] <trungl> dunno
[23:39:49] * rohitrao needs to try this on his super-old mac mini
[23:39:59] * rohitrao needs to reinstall 10.5 on his mac mini
[23:40:49] <cbentzel> hclam: Tree is open now. Why don't you try landing your patch and if that doesn't clean up memory bots go ahead and revert the change which caused it in the first place.
[23:42:49] *** mrossetti_ has joined #chromium
[23:42:50] *** ChanServ sets mode: +v mrossetti_
[23:43:28] <trungl> rohitrao: you should port chrome to powerpc and get a *really old* mac mini
[23:43:53] <davidben> When would be a good time for me to push a GRD change? I've got one that I've been sitting on for a couple of weeks...
[23:44:34] *** mrossetti_ has quit IRC
[23:44:35] *** tonyg-cr has quit IRC
[23:44:36] *** rubenbb has quit IRC
[23:44:48] <davidben> (Relatedly, what's the procedure? Probably worth having someone who knows how it works driving.)
[23:45:26] *** mrossetti has quit IRC
[23:46:36] <rohitrao> trungl: I'll get right on that
[23:46:45] <rohitrao> trungl: also, thanks
[23:46:47] *** Malmis has quit IRC
[23:46:58] <trungl> rohitrao: I expect the powerpc port to be ready for M3
[23:47:15] *** mrossetti has joined #chromium
[23:47:15] *** tonyg-cr has joined #chromium
[23:47:15] *** rubenbb has joined #chromium
[23:47:15] *** zelazny.freenode.net sets mode: +vv mrossetti tonyg-cr
[23:49:42] <thakis> davidben: put the grd change into a cl with no other changes, warn the sheriffs (cbentzel tonyg-cr) and commit when the tree isn't super busy
[23:50:52] *** michaeln has left #chromium
[23:51:18] *** mrossetti has quit IRC
[23:51:19] *** tonyg-cr has quit IRC
[23:51:19] *** rubenbb has quit IRC
[23:52:45] <davidben> Hrm, but the CL adds placeholder bits to an existing thing, so the code changes go along with it somewhat. http://codereview.chromium.org/2859026/show
[23:54:47] *** andybons has quit IRC
[23:56:29] *** JakeSays has joined #chromium
[23:57:28] *** mrossetti has joined #chromium
[23:57:28] *** tonyg-cr has joined #chromium
[23:57:28] *** rubenbb has joined #chromium
[23:57:28] *** zelazny.freenode.net sets mode: +vv mrossetti tonyg-cr
[23:57:43] *** freezway has joined #chromium
[23:57:57] <thakis> davidben: if it passed the trybots, it's probably fine. ask the sheriffs
[23:58:07] <thakis> davidben: (shouldn't you remove the TODO(snej)s in that cl?)
[23:58:18] <freezway> can i ask a question here? no one responds in -support
[23:59:25] *** hrna has quit IRC





top