[00:01:42] <willchan> joshia: the build fix is clear now, right?
[00:02:13] <willchan> eglaysher_lin: any word on the miniinstaller test?
[00:04:58] *** tonikitoo has quit IRC
[00:06:12] *** pinkerton has quit IRC
[00:06:14] *** rohitrao has quit IRC
[00:06:19] *** pssw0rt has joined #chromium
[00:06:38] <cpu_> pamg_: autoparanoid
[00:06:46] <eglaysher_lin> willchan: I actually can't get it to run
[00:06:46] *** howlymowly has joined #chromium
[00:07:04] <eglaysher_lin> so I'm having problems reproducing the problem
[00:07:05] <pssw0rt> how to compile chromium to get the buttons of minimize maximize and close in the left corner???
[00:07:35] <cpu_> pssw0rt: what os?
[00:07:47] <pssw0rt> linux
[00:07:54] <willchan> eglaysher_lin: there are 3 changes in that window, your pak one looks the most likely to me
[00:08:01] <willchan> eglaysher_lin: do you mind a speculative revert?
[00:08:07] <eglaysher_lin> go right ahead.
[00:08:17] <eglaysher_lin> I guess I can try to commit it a fourth time.
[00:08:20] <willchan> eglaysher_lin: k, thx.  reverting.
[00:09:11] <thakis> treestatus?
[00:09:40] <willchan> closed still
[00:09:42] <thakis> k
[00:09:43] <thakis> thx
[00:10:15] *** mahemoff has quit IRC
[00:12:27] *** Transformer has joined #chromium
[00:13:12] *** jrmuizel has quit IRC
[00:13:34] <trungl-bot> Tree opened by willchan at chromium dot org: Tree is open (miniinstaller=>hoping r50392 will fix it)
[00:14:20] <akalin> yay open tree
[00:16:35] *** pssw0rt has quit IRC
[00:17:16] *** dhollowa has joined #chromium
[00:17:17] *** ChanServ sets mode: +v dhollowa
[00:17:28] *** howlymowly has quit IRC
[00:18:07] *** bers has quit IRC
[00:20:00] * motownavi is worried about the page cycler and startup tests
[00:20:11] <motownavi> been on and off red since forever
[00:20:21] *** rafaelw2 has quit IRC
[00:20:48] <willchan> motownavi: senorblanco sent out an email about it to chrome-team, his resize patch may be the cause
[00:22:56] *** victorw has left #chromium
[00:24:48] *** eseidel has quit IRC
[00:25:13] <motownavi> ah
[00:25:26] <motownavi> both? that would be cool. well, not cool, but good to know
[00:26:20] *** dantasse has joined #chromium
[00:27:21] <dantasse> hey sheriffs- I've got a GRD change.  when/how should I land it?
[00:27:39] <dantasse> http://codereview.chromium.org/2856012/show
[00:28:08] *** jshin has quit IRC
[00:28:12] *** kliegs has quit IRC
[00:28:15] <rsesek> http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Landing-a-GRD-Resources-Change
[00:28:16] <rsesek> fyi
[00:28:20] <motownavi> let's wait until we see if the revert took
[00:28:48] <mpcomplete> dantasse: can you ping me when you're about to land? i have a grd change too
[00:29:09] <dantasse> ok, sounds good
[00:32:47] <cpu_> btw, my change has a grd change but does not add an entry, so it should be ok
[00:33:06] <cpu_> (famous last words)
[00:33:33] <willchan> k
[00:33:40] <rsesek> sky__: is your phantom tab cl ready for review? I didn't get mail but see it in my list
[00:35:10] *** sbyer has joined #chromium
[00:35:10] *** ChanServ sets mode: +v sbyer
[00:35:19] *** rektide has joined #chromium
[00:36:49] *** rafaelw1 has joined #chromium
[00:36:49] *** ChanServ sets mode: +v rafaelw1
[00:39:39] *** eseidel has joined #chromium
[00:40:46] *** sbyer has quit IRC
[00:42:35] <sky__> rsesek: no, I'm just going to disable and not nuke.
[00:42:55] <sky__> I'm going to nuke that cl.
[00:43:05] <sky__> closed
[00:43:48] *** hagabaka has quit IRC
[00:44:22] *** awolfson has quit IRC
[00:45:41] *** hagabaka has joined #chromium
[00:52:00] *** JoesphL0t has joined #chromium
[00:58:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder" from 50402: willchan at chromium dot org)
[01:00:07] <jamesr> willchan!!
[01:00:30] *** rektide has quit IRC
[01:00:42] <motownavi> And we still don't know if 50392 worked... :(
[01:00:59] *** apatrick_ has joined #chromium
[01:00:59] *** ChanServ sets mode: +v apatrick_
[01:02:49] *** senorblanco has joined #chromium
[01:02:49] *** ChanServ sets mode: +v senorblanco
[01:04:06] <senorblanco> willchan: ping?
[01:05:28] *** AaronMT has quit IRC
[01:06:55] *** alyssad has joined #chromium
[01:06:55] *** ChanServ sets mode: +v alyssad
[01:08:42] <senorblanco> sheriffs:  do you mind if I check in a fix for perf regression into closed tree?
[01:08:50] <thakis> agl: thoughts on http://codereview.appspot.com/1706045 ?
[01:09:39] <cpu_> senorblanco: is not compiling right now
[01:10:00] <senorblanco> cpu_ : noted
[01:10:05] <senorblanco> my fix is an image file..
[01:10:39] <cpu_> senorblanco: you could revert willchan's cl and put your cl... but I am not a sheriff so
[01:10:40] <jamesr> senorblanco: was some image on the NTP resized when it didn't need to be?
[01:10:51] <senorblanco> jamesr: yep
[01:10:57] <jamesr> someone should revert willchan unless he's contacted sheriffs out-of-band
[01:11:00] <jamesr> senorblanco: :<
[01:11:25] <cpu_> I think willchan is the sherif
[01:11:33] <senorblanco> jamesr: http://codereview.chromium.org/2837012/show
[01:12:16] <jamesr> he's doing a good job taking charge of the tree's green-ness :P
[01:12:39] <willchan> sorry, i just got back
[01:13:00] <cpu_> sheriff, someone broke the tree ;)
[01:13:06] <senorblanco> :)
[01:13:09] <willchan> wtf, i just built that change
[01:13:13] <willchan> time to revert myself :(
[01:13:15] <jamesr> you're the only one
[01:13:25] <willchan> k, reverting
[01:14:34] *** drusepth has quit IRC
[01:15:32] <willchan> eglaysher_lin: looks like miniinstaller got fixed
[01:17:10] <willchan> senorblanco: your change lgtm, you can land it
[01:17:23] <senorblanco> k thx
[01:17:26] <willchan> i'm going to keep the tree closed while it greens up again
[01:17:42] *** robertshield2 has joined #chromium
[01:17:43] <senorblanco> landed
[01:17:50] *** mpcomplete has quit IRC
[01:19:23] <trungl-bot> Tree closed by willchan at chromium dot org: Tree is closed (r50406 fixed the build failure, waiting for tree to green up)
[01:20:55] <estade> encoded_terms = WideToUTF16Hack(UTF8ToWide(EscapePath(WideToUTF8(terms))));
[01:21:55] <senorblanco> gotta catch a train.. cya
[01:21:58] *** senorblanco has quit IRC
[01:23:24] <thakis> mirandac: there?
[01:24:07] <motownavi> willchan: dantasse and mpcomplete have grd changes they want to land. Can we land them once the tree goes green before we go crazy again?
[01:24:23] <willchan> motownavi: ok
[01:24:29] <dglazkov> yay, I rolled in another perf regression!
[01:24:32] * dglazkov rocks
[01:24:39] <motownavi> dantasse: get ready
[01:24:45] <thakis> any mac folks want to lgtm http://codereview.chromium.org/2801014 ?
[01:24:46] <dantasse> i'm ready
[01:24:47] <thakis> 1 lien change
[01:24:49] <motownavi> mpcomplete... is gone :(
[01:25:08] <motownavi> thakis: takign
[01:25:49] <thakis> motownavi: thanks
[01:25:58] *** mpcomplete has joined #chromium
[01:25:58] *** ChanServ sets mode: +v mpcomplete
[01:26:21] *** robertshield2 has quit IRC
[01:26:28] <thakis> motownavi: is it ok if i land this?
[01:27:03] <motownavi> use it as the whitespace change for dantasse 's grd change :)
[01:27:21] <motownavi> if you can wait
[01:27:38] <motownavi> looks like senor already broke the embargo but I'd prefer some tree breathing time
[01:28:28] *** crescendo has quit IRC
[01:28:28] *** kcbanner has quit IRC
[01:28:28] *** Adys has quit IRC
[01:28:28] *** deshantm has quit IRC
[01:28:28] *** Gabe_G23 has quit IRC
[01:28:28] *** skydrome has quit IRC
[01:28:28] *** tehbaut has quit IRC
[01:28:28] *** SRabbelier has quit IRC
[01:28:28] *** TabAtkins has quit IRC
[01:28:28] *** Greboid has quit IRC
[01:28:28] *** Utoxin has quit IRC
[01:28:28] *** urbanape has quit IRC
[01:28:28] *** ivan has quit IRC
[01:28:28] *** nutz has quit IRC
[01:28:28] *** eggy has quit IRC
[01:28:28] *** vladbph has quit IRC
[01:28:28] *** msteele_ has quit IRC
[01:28:28] *** dalias has quit IRC
[01:28:28] *** jcastro has quit IRC
[01:28:49] <willchan> i gave him the ok for it, hopefully it'll fix the perf/startup problems from earlier
[01:29:28] *** Utoxin has joined #chromium
[01:29:48] *** vladbph has joined #chromium
[01:31:00] *** jcivelli has quit IRC
[01:31:22] *** tehbaut has joined #chromium
[01:31:41] <motownavi> ok, that sounds reasonable
[01:31:51] *** Gabe_G23 has joined #chromium
[01:31:56] <motownavi> thakis's change is the perfect whitespace
[01:32:02] <motownavi> meanwhile I'm off. good luck
[01:32:22] *** tehbaut has joined #chromium
[01:32:27] *** tehbaut has quit IRC
[01:32:51] <thakis> motownavi: i have to run in 6 min or so
[01:32:56] *** abarth has joined #chromium
[01:32:56] *** ChanServ sets mode: +v abarth
[01:33:10] *** abarth is now known as abarth|R-
[01:33:27] *** tehbaut has joined #chromium
[01:33:41] <thakis> willchan, dantasse: how long until you need a whitespace cl?
[01:33:42] *** SRabbelier has joined #chromium
[01:33:49] <willchan> dantasse: yt?
[01:33:52] <dantasse> yeah
[01:33:55] *** tehbaut has joined #chromium
[01:34:04] <dantasse> i'm ready to submit whenever you are
[01:34:16] <willchan> gimme a sec
[01:34:30] <willchan> wanna see what else i'm waiting on to green up
[01:34:35] <dantasse> ok
[01:34:55] *** tehbaut has joined #chromium
[01:35:22] *** tedoc2000 has quit IRC
[01:35:26] <willchan> dantasse: it looks fine to me, go for it
[01:36:03] *** tedoc2000 has joined #chromium
[01:36:22] <willchan> thakis: it'll be longer than 6 minutes until dantasse's compile kicks off
[01:36:31] <willchan> if you gimme the codereview link, i'll land it for you
[01:36:45] <mpcomplete> willchan: i have a grd change too, can i commit it?
[01:36:54] <willchan> mpcomplete: oh, you're here.  go for it.
[01:36:54] <thakis> willchan: thanks! http://codereview.chromium.org/2801014/show
[01:37:02] <mpcomplete> thanks
[01:37:04] <willchan> thakis: ok, i'll tbr it to you.
[01:37:13] *** urbanape has joined #chromium
[01:37:17] <thakis> it's reviewed already
[01:37:24] <willchan> thakis: k
[01:37:32] *** psusi has joined #chromium
[01:37:46] <dantasse> ok, trying to commit, but the tree is closed
[01:37:50] <dantasse> how do I force it?
[01:37:52] <willchan> dantasse: -f
[01:38:25] *** tehbaut has joined #chromium
[01:38:33] <trungl-bot> Tree closed by willchan at chromium dot org: Tree is closed (grd changes landing)
[01:38:50] <dantasse> ok, thanks.  committed... now
[01:38:51] *** tehbaut has joined #chromium
[01:38:56] <mpcomplete> ditto
[01:38:57] *** tehbaut has quit IRC
[01:39:22] *** tehbaut has joined #chromium
[01:40:22] *** tehbaut has joined #chromium
[01:40:56] *** tehbaut has joined #chromium
[01:41:19] *** psusi has quit IRC
[01:41:26] *** tehbaut has joined #chromium
[01:43:00] *** nutz has joined #chromium
[01:43:01] *** dalias has joined #chromium
[01:43:43] *** kcbanner has joined #chromium
[01:43:46] *** markmentovai has quit IRC
[01:44:00] *** crescendo has joined #chromium
[01:44:08] *** Adys has joined #chromium
[01:44:32] *** jcastro has joined #chromium
[01:44:43] *** skydrome has joined #chromium
[01:45:02] *** rsesek has quit IRC
[01:45:59] *** jshin has joined #chromium
[01:45:59] *** ChanServ sets mode: +v jshin
[01:47:08] *** Lunix has left #chromium
[01:47:18] <dantasse> huh, my patch isn't on the waterfall yet.  is that normal?
[01:47:24] *** tehbaut has joined #chromium
[01:47:28] <willchan> dantasse: you sure you landed it?
[01:47:29] *** tehbaut has quit IRC
[01:47:50] <dantasse> ... well, I got this: Committing to svn://svn.chromium.org/chrome/trunk/src
[01:47:51] <dantasse>         M       chrome/app/generated_resources.grd
[01:47:52] *** tehbaut has joined #chromium
[01:48:04] <dantasse> and then it sent me back to the prompt. let me try again.
[01:48:56] *** Aria has joined #chromium
[01:48:56] *** tehbaut has joined #chromium
[01:49:20] *** pdelgallego has quit IRC
[01:49:22] *** tehbaut has joined #chromium
[01:49:52] *** tehbaut has joined #chromium
[01:50:22] *** tehbaut has joined #chromium
[01:50:52] *** tehbaut has joined #chromium
[01:50:57] *** tehbaut has quit IRC
[01:51:25] *** tehbaut has joined #chromium
[01:51:27] *** tehbaut has quit IRC
[01:51:55] *** tehbaut has joined #chromium
[01:52:28] *** tehbaut has joined #chromium
[01:53:30] <willchan> dglazkov: what's the status on the perf regression?
[01:53:42] <dglazkov> willchan: early investigation
[01:53:53] <willchan> dantasse: i see your commit now
[01:54:05] <dantasse> excellent.
[01:54:24] <dantasse> thanks, sorry about the delay
[01:54:34] <dantasse> issue with cygwin/git I think
[01:55:55] *** tehbaut has joined #chromium
[01:55:57] *** tehbaut has quit IRC
[01:56:23] *** tehbaut has joined #chromium
[01:56:56] *** tehbaut has joined #chromium
[01:59:54] *** tehbaut has joined #chromium
[02:00:04] <akalin> perhaps someone should kick tehbaut until he fixes his issue
[02:00:24] *** darwin_ has quit IRC
[02:00:45] *** andybons has quit IRC
[02:00:56] *** tehbaut has joined #chromium
[02:01:22] *** tehbaut has joined #chromium
[02:01:54] *** tehbaut has joined #chromium
[02:02:24] *** tehbaut has joined #chromium
[02:03:24] *** tehbaut has joined #chromium
[02:03:52] *** tehbaut has joined #chromium
[02:04:15] *** Hydrogenum has left #chromium
[02:04:25] *** tehbaut has joined #chromium
[02:04:52] *** tehbaut has joined #chromium
[02:05:25] *** tehbaut has joined #chromium
[02:05:30] *** dantasse has left #chromium
[02:05:52] *** tehbaut has joined #chromium
[02:06:02] <awong> I'm banning tehbaut
[02:06:08] <akalin> +1
[02:06:24] *** tehbaut has joined #chromium
[02:07:22] *** tehbaut has joined #chromium
[02:07:23] *** ChanServ sets mode: +b *!*@unaffiliated/tehbaut
[02:07:23] *** tehbaut was kicked by ChanServ (Banned: excessive join/part)
[02:08:14] *** RT|Chatzilla has joined #chromium
[02:10:36] <willchan> landing thakis's change soon
[02:12:03] <awong> btw, for reference, to add a ban on chanserv, do "akick #chromium add <user/patter> <message>".  Anyone who can get a +v probably can do this.
[02:12:21] *** GeekShadow has quit IRC
[02:15:46] *** tedoc2000 has quit IRC
[02:15:54] *** jrmuizel has joined #chromium
[02:17:18] *** tedoc2000 has joined #chromium
[02:18:44] *** cpu has quit IRC
[02:19:08] *** cpu_ has quit IRC
[02:19:45] *** tedoc2000 has quit IRC
[02:20:10] *** bent-mozilla has quit IRC
[02:20:45] *** dantasse has joined #chromium
[02:21:27] *** stuartmorgan has quit IRC
[02:21:58] *** TabAtkins has joined #chromium
[02:21:58] *** ivan has joined #chromium
[02:21:58] *** eggy has joined #chromium
[02:21:58] *** msteele_ has joined #chromium
[02:21:58] *** zelazny.freenode.net sets mode: +v TabAtkins
[02:22:21] <dantasse> err hey, question about grd's
[02:23:09] <dantasse> is it just additions to the generated_resources.grd (strings) that breaks the build, or is it all grd files? (say, chrome/browser/browser_resources.grd)
[02:25:04] <dcheng> Hmm. If I enter 'code.google.com/p/anything' in Chrome, it keeps navigating to code.google.com/p/http:/ - how can I figure out if it's Google Code acting up or Chrome?
[02:25:07] *** dmaclach has quit IRC
[02:26:21] *** MikeSmithW3C has quit IRC
[02:27:06] *** robertshield2 has joined #chromium
[02:28:46] <willchan> dcheng: doesn't happen to me
[02:28:53] *** tedoc2000 has joined #chromium
[02:29:01] <willchan> i get a 404
[02:30:43] <dcheng> willchan: code.google.com/p/chromium, code.google.com/p/azilink, etc all redirect to the weird URL ending in http:/
[02:30:58] <dcheng> about:net-internals has this to say:
[02:31:01] <willchan> dcheng: works fine for me
[02:31:05] <dcheng> (P) t=1277166519319         HTTP_CACHE_READ_INFO                              [dt=  0]
[02:31:09] <dcheng> (P) t=1277166519325         URL_REQUEST_REDIRECTED                             --> location = "http://code.google.com/p/http:/"
[02:31:10] *** MikeSmithW3C has joined #chromium
[02:31:16] <willchan> that's in your cache?
[02:31:20] <akalin> have you tried another browser?
[02:31:33] <dcheng> It works in another browser, I wasn't sure if there was some weird Google Code cookie causing it though.
[02:31:34] <willchan> try whacking your cache and doing it again
[02:31:45] <dcheng> Why would such a strange entry get into my cache in the first place?
[02:32:15] <willchan> dcheng: not sure, try about:cache/http://your.url.com/here
[02:32:50] <dcheng> There's a cached 301 redirect from Google Code. Weird.
[02:33:00] <willchan> the 301 actually says to do that?
[02:33:06] <dcheng> Yep.
[02:33:10] <willchan> the Location: header in there has the http:?
[02:33:13] <dcheng> Yep.
[02:33:19] * willchan is boggled
[02:33:42] <willchan> unless there's a really bad bug in the cache (you can ask rvargas), it might be a really bad bug in google code
[02:34:01] <willchan> try whacking the cache and seeing if you still get that same response
[02:34:25] *** eseidel has quit IRC
[02:34:42] *** abarth|R- has quit IRC
[02:34:43] *** tonyg-cr has quit IRC
[02:34:49] *** tonyg-cr has joined #chromium
[02:34:50] *** ChanServ sets mode: +v tonyg-cr
[02:34:53] *** Erkan_Yilmaz_ has joined #chromium
[02:34:54] <dcheng> willchan: same thing.
[02:35:39] <tony^work> willchan: did rolling back r50392 fix the miniinstaller?
[02:35:44] <willchan> dcheng: wow, wtf.  please whack cache again, open up about:net-internals, then resend the request, then go to net-internals, click on "dump to text"
[02:35:46] <willchan> tony^work: yes
[02:35:56] *** kliegs has joined #chromium
[02:35:59] <tony^work> tears
[02:36:06] <willchan> dcheng: then look at the request/response headers from net-internals for that URL_REQUEST
[02:36:07] <tony^work> Ok, thanks
[02:36:14] <willchan> dcheng: and send me those headers
[02:36:37] <willchan> elide your cookies before sending the output
[02:36:49] *** ovi1 has joined #chromium
[02:36:49] *** joshia has quit IRC
[02:38:08] *** Erkan_Yilmaz has quit IRC
[02:38:30] <dantasse> willchan: would it keep the tree closed longer to land another grd change now?
[02:38:46] <willchan> dantasse: yes
[02:38:47] <dantasse> (realized I had edited two grd's, but only committed one)
[02:38:59] <dantasse> ok, guess I'll hold off then
[02:39:18] <akalin> so to clarify, does checking in *any* grd changes require this process?
[02:39:25] <akalin> even, say, adding a new string?
[02:39:42] <willchan> not sure.  i never edit grd files :)
[02:39:54] <akalin> hmm
[02:40:07] *** kliegs has quit IRC
[02:40:14] <robertshield2> akalin: last I heard, the answer was yes
[02:40:20] *** eseidel has joined #chromium
[02:40:24] <akalin> o_O
[02:40:31] <akalin> i guess i got lucky in my previous grd checkins then
[02:40:35] *** kliegs has joined #chromium
[02:40:36] *** kliegs has quit IRC
[02:41:12] *** kliegs has joined #chromium
[02:41:28] <willchan> ok, tests are going again, i'll reopen tree
[02:41:29] <dcheng> willchan: Where do I see request headers? Only place I see them is in about:cache
[02:41:33] <dcheng> Oh wait, they're in the text dump as well I think.
[02:41:35] <dcheng> I think all the interesting bits should be there.
[02:42:13] <trungl-bot> Tree opened by willchan at chromium dot org: Tree is open (memory failures should all be suppressed now)
[02:43:32] <willchan> dcheng: interesting, maybe you have a spdy bug.  lemme check
[02:43:49] *** ovi1 has left #chromium
[02:44:08] <dcheng> willchan: It might also be interesting to note that it used to work 1 hour ago.
[02:44:22] <willchan> dcheng: you haven't restarted your browser, have you?
[02:45:06] <dcheng> willchan: I don't think I have in between the time it was working and the time it stopped working.
[02:45:38] <willchan> dcheng: can you take a look at build.chromium.org
[02:45:49] <willchan> dcheng: do you get a cert error?
[02:46:15] <dcheng> willchan: Yes, if I try to visit the https version.
[02:46:32] <willchan> dcheng: try to visit http://build.chromium.org
[02:46:50] <dcheng> Everything looks fine.
[02:47:35] <willchan> dcheng: i think you're hitting a server side bug in SPDY
[02:48:30] <dcheng> willchan: Alright, thanks for taking a look.
[02:49:41] *** tedoc2000_ has joined #chromium
[02:49:51] *** tedoc2000 has quit IRC
[02:49:58] *** tonyg-cr has quit IRC
[02:50:32] *** dantasse has left #chromium
[02:53:27] *** erikkay has quit IRC
[02:53:34] *** tonyg-cr has joined #chromium
[02:53:34] *** ChanServ sets mode: +v tonyg-cr
[02:55:10] *** tedoc2000_ has quit IRC
[02:57:32] *** yutak_home has quit IRC
[02:59:08] <willchan> dglazkov: any more progress on this mac perf regression?  think we can get a fix in today?
[02:59:45] *** tedoc2000_ has joined #chromium
[03:00:50] *** dglazkov has quit IRC
[03:00:58] *** boshomo has quit IRC
[03:02:14] <akalin> mac folks: is it sufficient to change 'enable_svg%': 1 -> 0 in build/features_override.gypi to get unit_tests to link?
[03:02:23] <akalin> i tried that, still get mmap errors :(
[03:02:27] *** bent-mozilla has joined #chromium
[03:02:54] <dpranke> akalin: make sure you do a clean rebuild and gclient runhooks after changing that
[03:03:03] <akalin> you need a clean rebuild?
[03:03:04] <akalin> blurggghh
[03:03:17] <akalin> okay, that's probably why
[03:04:20] *** tedoc2000_ has quit IRC
[03:04:47] *** abarth has joined #chromium
[03:04:47] *** ChanServ sets mode: +v abarth
[03:04:55] *** abarth is now known as abarth|R-
[03:06:44] *** alyssad has quit IRC
[03:09:14] *** tedoc2000_ has joined #chromium
[03:11:51] *** Lunix has joined #chromium
[03:15:38] *** Transformer has joined #chromium
[03:17:41] *** Transformer has left #chromium
[03:18:10] <pkasting> Is there some utility that takes a multi-file diff and prints out a total of how many lines added and removed?
[03:18:20] <pkasting> I'm curious how much code my current patch guts.
[03:18:47] *** kbr_google has quit IRC
[03:19:24] <awong> pkasting: maybe diffstat? Not sure...
[03:19:33] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 50414: willchan at chromium dot org)
[03:20:10] <willchan> wtf, it timed out
[03:20:29] <willchan> reopening
[03:21:08] *** gionnico has quit IRC
[03:21:21] <jamesr> who knows about our OS X certificate management system?
[03:21:31] <jamesr> i'm getting skull+crossbones on certs that i believe to be good
[03:21:34] <trungl-bot> Tree opened by willchan at chromium dot org: Tree is open
[03:21:34] *** dmaclach has joined #chromium
[03:21:44] <willchan> jamesr: is it mixed content?
[03:21:47] *** dmaclach has quit IRC
[03:21:49] <jamesr> no, bad cert
[03:21:53] *** tonyg-cr has quit IRC
[03:21:59] <willchan> what does the error message say?
[03:22:24] <willchan> you may want to walk over and show it to wtc
[03:22:27] *** dave_levin has quit IRC
[03:22:44] *** tedoc2000_ has quit IRC
[03:22:50] <jamesr> might do that
[03:22:51] *** tedoc2000 has joined #chromium
[03:23:09] <jamesr> the exact same cert (at least according to the signature) is green padlock on my macbook pro and skull+crossbones on my mac pro
[03:23:48] <willchan> yeah, show it to wtc
[03:28:26] *** rohitkc has quit IRC
[03:31:17] *** Mark_ has joined #chromium
[03:33:23] *** thakis_ has joined #chromium
[03:33:23] *** ChanServ sets mode: +v thakis_
[03:33:29] *** thakis__ has joined #chromium
[03:33:29] *** ChanServ sets mode: +v thakis__
[03:35:28] <dcheng> One of my favorite error messages from VS: 3>..\dom\Clipboard.cpp : error C2471: cannot update program database '敆畘Ơ畢撜畘ŵ畢ᕛ邤A'
[03:35:55] <Mark_> can anyone tell me if theres a way to have chromium refresh to where i was scrolled at before
[03:36:18] <Mark_> using  <meta http-equiv=refresh content='300'>  makes the page go to the top
[03:36:26] <Mark_> whereas f5 etc brings me to where i was looking at before
[03:36:41] *** jshin has quit IRC
[03:37:54] <dcheng> Mark_: Does using <meta http-equiv="refresh"> bring you back to the same place in other browsers?
[03:38:04] *** thakis_ has quit IRC
[03:38:06] *** kazoo has joined #chromium
[03:38:07] <Mark_> yea
[03:38:20] <Mark_> and actually i just found a bug report i think
[03:38:21] <Mark_> http://www.mail-archive.com/chromium-bugs at googlegroups dot com/msg57954.html
[03:38:36] <dcheng> Mark_: Does using window.location.reload() do what you need?
[03:38:42] <Mark_> dunno im using cacti
[03:38:50] <Mark_> ive got a big page of graphs
[03:38:55] <Mark_> most of them i dont care about
[03:39:00] <Mark_> (right now at least)
[03:39:09] <dcheng> Mark_: I'm giving you a potential workaround, you have to try it =)
[03:39:12] <Mark_> the ones i want to watch happen to be at the bottom
[03:39:13] <Mark_> :P
[03:40:41] <Mark_> ugh theres definitely already a report
[03:40:41] <Mark_> http://code.google.com/p/chromium/issues/detail?id=3115
[03:41:03] <Mark_> which apparently is a webkit issue
[03:43:01] <Mark_> if window.location.reload() works and is more compatible across the board
[03:43:06] <Mark_> ill ask the cacti people to just use that instead
[03:43:36] <dcheng> Give it a shot, I've got no idea if it actually works around the WebKit bug.
[03:43:58] *** kazoo has quit IRC
[03:45:44] *** mazda has joined #chromium
[03:45:44] *** ChanServ sets mode: +v mazda
[03:45:57] <Mark_> is google at the mercy of webkit for a lot of bugs
[03:46:02] *** robertshield2 has quit IRC
[03:46:10] <Mark_> or do they have a developer that can commit to webkit
[03:48:51] *** hbono has joined #chromium
[03:51:05] *** FullFlannelJacke has joined #chromium
[03:51:21] <jamesr> many people on the chromium project also contribute to webkit
[03:51:35] <jamesr> it's not really a 'google' issue
[04:01:05] *** bent-mozilla has quit IRC
[04:01:53] *** bent-mozilla has joined #chromium
[04:02:50] *** rafaelw1 has left #chromium
[04:04:36] *** mpcomplete has quit IRC
[04:06:23] *** rafaelw2 has joined #chromium
[04:06:24] *** ChanServ sets mode: +v rafaelw2
[04:07:50] <willchan> jamesr: do you what's up with this perf regression?  is someone on it?
[04:08:00] <jamesr> intl2?
[04:08:47] <jamesr> willchan: if you mean intl2 on mac then dglazkov filed crbug.com/47115 and is following up in webkit
[04:08:49] <jamesr> willchan: otherwise i dunno
[04:09:07] <jamesr> i could revert upstream
[04:09:15] <willchan> yeah, the mac intl2 one
[04:09:19] <jamesr> but i dunno if he's heard anything back yet (dglazkov appears gone for the day)
[04:09:45] *** fqian has quit IRC
[04:10:30] <willchan> jamesr: do we have a culprit cl?  or is that still up in the air?
[04:10:35] <jamesr> willchan: yeah
[04:11:01] <jamesr> there's only one possible candidate in the range and the candidate is scary (adds hyphenation support to line breaking)
[04:11:04] *** rafaelw2 has quit IRC
[04:11:13] *** yuzo has quit IRC
[04:11:44] <willchan> jamesr: are you sure it's mac only?  xp seems to have regressed too.
[04:11:50] <willchan> in the graphs
[04:12:04] <jamesr> same rev and also intl2?
[04:12:16] <jamesr> do you think it regressed there too but is just still inside the allowed range?
[04:13:07] <willchan> 50393-50401 is the window
[04:13:13] *** leeight has joined #chromium
[04:13:21] <willchan> yeah, it's that webkit roll
[04:13:26] *** trungl_ has joined #chromium
[04:13:26] *** ChanServ sets mode: +v trungl_
[04:13:43] <jamesr> and what's the approx % regression?
[04:13:55] <willchan> 3467 to 3732
[04:13:58] <willchan> ms
[04:14:04] <jamesr> so ~10% ish?
[04:14:08] <willchan> yeah
[04:14:23] <willchan> xp single core is worse
[04:14:30] <willchan> 7s to 24s
[04:14:36] <jamesr> holy shit
[04:14:58] *** csilv has left #chromium
[04:15:01] <willchan> vista dual core is 4.378 to 4.55
[04:15:04] <willchan> s
[04:15:15] *** pathorn has quit IRC
[04:15:28] <willchan> there's definitely a regression on all the windows perf bots
[04:15:49] <willchan> linux too, 7% or so
[04:16:17] <willchan> yeah, i think we need to revert upstream, but is someone going to be around to roll webkit too?
[04:16:33] <willchan> or maybe i should revert the last roll
[04:16:41] <jamesr> yeah
[04:17:20] <jamesr> sucky think about page cycler regressions is we can't give repro instructions to people that aren't googlers :[
[04:17:40] <willchan> we might be able to identify the pages that are slowing down
[04:17:51] <willchan> presumably our saved pages aren't that different from the live pages
[04:18:13] *** leeight has quit IRC
[04:18:30] <willchan> anyway, i'll revert the roll for now
[04:18:32] <jamesr> ok
[04:18:37] <jamesr> i don't have time to try to get a repro URL tonight
[04:18:40] <jamesr> although that would be ideal
[04:18:42] <willchan> fair enough
[04:18:53] <jamesr> once we have a repro then the correct path forward is to provide the repro case upstream, revert upstream, and then roll
[04:19:51] <jamesr> i would just revert upstream but that's poor manners without providing a repro case
[04:20:41] <willchan> fair enough
[04:22:12] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 50421: mazda at chromium dot org, pkasting at chromium dot org)
[04:22:23] <jamesr> i'll bet our allowed perf ranges on the other bots are just too wide
[04:22:23] *** chrisccoulson has quit IRC
[04:22:55] <willchan> bleh, libstartup tests link error, msvc--
[04:22:58] <willchan> reopening
[04:24:13] <trungl-bot> Tree opened by willchan at chromium dot org: Tree is open
[04:24:35] *** speedy1 has quit IRC
[04:25:04] *** Lunix has left #chromium
[04:27:13] *** Beetny has joined #chromium
[04:31:39] *** leeight has joined #chromium
[04:31:43] *** leeight has left #chromium
[04:39:25] *** jamesr has quit IRC
[04:44:06] *** trungl_ has quit IRC
[04:54:27] *** dpranke has quit IRC
[04:57:56] *** Buglouse has quit IRC
[05:02:05] *** wocao has joined #chromium
[05:03:29] *** trungl_ has joined #chromium
[05:03:29] *** ChanServ sets mode: +v trungl_
[05:07:04] <wocao> when i compile the chromium for arm-generic ,it using the compiler from itself armv7a-cros-linux-gnueabi-XX but i want to specify the arm compile ,how to do that
[05:07:28] *** bmizerany has quit IRC
[05:11:07] *** Precea is now known as Precea[BNC]
[05:12:04] *** phanee has joined #chromium
[05:13:28] *** rjkroege has quit IRC
[05:15:56] *** SartenX has quit IRC
[05:16:05] *** thakis__ has quit IRC
[05:20:38] *** Precea[BNC] is now known as Precea
[05:26:08] *** shreyas has joined #chromium
[05:26:35] *** shreyas has quit IRC
[05:26:56] *** tonikitoo has joined #chromium
[05:27:01] *** Sarten-X has joined #chromium
[05:29:54] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 50424: cmasone at google dot com)
[05:30:37] *** ennui has joined #chromium
[05:31:30] *** paulgrous has joined #chromium
[05:33:03] *** Transformer has joined #chromium
[05:35:36] *** paulgrous has quit IRC
[05:35:36] *** Transformer has quit IRC
[05:46:21] *** tfarina has joined #chromium
[05:48:07] <tfarina> need we to revert?
[05:51:54] <tony^work> I bet it's arv's grd change
[05:51:58] <tony^work> we should let the bots cycle
[05:52:43] <tony^work> I'm forcing builds
[05:52:55] <tfarina> tony^work: yeah, I just looked now http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests%20(dbg)(1)
[05:53:35] <tfarina> tony^work: it needs to be clobbered?
[05:54:05] <trungl-bot> Tree closed by tony at chromium dot org (:tony^work): tree closed (grd change, forcing a build, should cycle green)
[05:56:48] *** tedoc2000 has quit IRC
[05:57:56] *** MikeSmithW3C has quit IRC
[05:59:39] <tony^work> it doesn't need to be clobbered
[05:59:50] <tony^work> afk, but will poke the debug bots once the compile finishes
[06:00:51] *** rjkroege_ has joined #chromium
[06:02:54] <tfarina> tony^work: righ. Why I can't see here http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests%20(dbg)(1) it compiling again?
[06:03:52] *** ennui has quit IRC
[06:12:49] *** thakis_ has joined #chromium
[06:12:49] *** ChanServ sets mode: +v thakis_
[06:17:39] *** BryanWB has joined #chromium
[06:18:58] *** dglazkov has joined #chromium
[06:18:59] *** ChanServ sets mode: +v dglazkov
[06:20:24] <dglazkov> willchan: why'd you revert the roll?
[06:20:38] <dglazkov> it's not like we can not roll
[06:21:46] <dglazkov> darn it
[06:21:49] <dglazkov> tkent: yt?
[06:26:27] <tfarina> tony^work: can we reopen?
[06:27:35] *** rjkroege_ has quit IRC
[06:32:58] *** nayankk has quit IRC
[06:33:16] *** nayankk has joined #chromium
[06:34:44] *** michaeln has quit IRC
[06:36:10] *** hbono has quit IRC
[06:38:16] *** hrna has joined #chromium
[06:42:03] *** mrossetti_ has joined #chromium
[06:42:04] *** mrossetti has quit IRC
[06:42:04] *** mrossetti_ is now known as mrossetti
[06:43:42] *** rickspencer3 has quit IRC
[06:46:44] *** mrossetti has quit IRC
[06:46:45] *** tfarina has quit IRC
[06:51:18] *** MikeSmithW3C has joined #chromium
[06:56:44] *** mazda has quit IRC
[06:58:55] <tkent> dglazkov: pong
[06:59:04] *** bevc has joined #chromium
[06:59:06] <dglazkov> tkent: writing you a long email :)
[07:01:34] *** mazda has joined #chromium
[07:01:34] *** ChanServ sets mode: +v mazda
[07:02:51] <tony^work> oh, tfarina is gone
[07:03:01] <tony^work> I just poked the unittest bots
[07:03:08] <tony^work> I'll open the tree since it should go green
[07:04:06] <trungl-bot> Tree opened by tony at chromium dot org (:tony^work): tree open (grd change, should cycle green)
[07:07:19] *** General13372 has joined #chromium
[07:09:14] *** dglazkov has quit IRC
[07:09:47] *** hbono has joined #chromium
[07:10:15] *** General1337 has quit IRC
[07:25:50] *** jrmuizel has quit IRC
[07:32:51] *** dmaclach has joined #chromium
[07:35:21] *** bevc has quit IRC
[07:35:38] *** jrmuizel has joined #chromium
[07:40:24] *** bmizerany has joined #chromium
[07:43:47] *** dmaclach has quit IRC
[07:47:02] *** roc has quit IRC
[07:47:13] *** hagabaka has quit IRC
[07:48:36] *** bmizerany has quit IRC
[07:51:37] *** kenneth_reitz has quit IRC
[07:51:46] *** scherkus has joined #chromium
[07:52:01] *** scherkus has quit IRC
[07:52:14] *** carstenh has joined #chromium
[08:02:50] *** pamg_ has joined #chromium
[08:02:51] *** ChanServ sets mode: +v pamg_
[08:06:47] *** sylon has joined #chromium
[08:10:13] *** pamg_ has quit IRC
[08:14:09] *** phajdan-jr|afk is now known as phajdan-jr
[08:14:23] *** BryanWB has quit IRC
[08:14:39] *** BryanWB has joined #chromium
[08:15:49] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 50431: tkent at google dot com)
[08:16:00] <tkent> oh?
[08:16:13] <phajdan-jr> tkent: pdb flake on Windows :-/
[08:17:23] <tkent> ok, just reopen
[08:17:51] <trungl-bot> Tree opened by tkent at chromium dot org: Tree is open
[08:17:55] *** thakis_ has quit IRC
[08:23:00] *** adiumtestuser has quit IRC
[08:23:52] *** sylon has left #chromium
[08:25:24] *** adiumtestuser has joined #chromium
[08:25:25] *** ChanServ sets mode: +v adiumtestuser
[08:28:47] <phajdan-jr> tkent: failed again. Maybe it needs a clobber?
[08:29:03] <tkent> I have just kicked clobber build.
[08:34:39] *** jrmuizel has quit IRC
[08:38:41] *** jamesr has joined #chromium
[08:41:06] *** yuzo has joined #chromium
[08:41:07] *** ChanServ sets mode: +v yuzo
[08:42:49] *** Erkan_Yilmaz_ has quit IRC
[08:43:39] *** trungl_ has quit IRC
[08:53:28] *** darwin_ has joined #chromium
[08:58:34] *** BryanWB has quit IRC
[09:00:58] *** GeekShadow has joined #chromium
[09:04:58] *** jamesr has quit IRC
[09:06:01] *** mossila has joined #chromium
[09:15:18] *** pdelgallego has joined #chromium
[09:24:29] <trungl-bot> Tree closed by aa at chromium dot org: Tree is closed (landing grd change)
[09:24:55] <tony^work> aboodman: if you time it right, the tree shouldn't go red
[09:25:09] <tony^work> as in, press clobber in the 60s between landing a change and the builders starting
[09:27:20] <aboodman> tony^work: sorry was just following instructions on dev.chromium.org
[09:27:29] <tony^work> just an fyi
[09:27:32] <tony^work> closing is fine with me
[09:27:34] <aboodman> which builders are you referring to?
[09:27:47] <tony^work> the windows builders
[09:27:56] <aboodman> i see
[09:28:00] <aboodman> ok, next time
[09:33:13] *** romainhuet has joined #chromium
[09:38:40] *** nayankk has quit IRC
[09:38:58] *** nayankk has joined #chromium
[09:40:42] *** phanee has quit IRC
[09:45:36] *** pfeldman has joined #chromium
[09:56:25] *** mossila has quit IRC
[09:57:23] *** bent-mozilla has quit IRC
[09:58:16] *** roc has joined #chromium
[10:01:49] <trungl-bot> Tree opened by aa at chromium dot org: Tree is open
[10:11:46] *** bauerb has joined #chromium
[10:11:46] *** ChanServ sets mode: +v bauerb
[10:11:55] *** pamg_ has joined #chromium
[10:11:55] *** ChanServ sets mode: +v pamg_
[10:12:04] <jochen__> good morning
[10:12:40] *** Aria has quit IRC
[10:13:52] *** pamg_ has quit IRC
[10:14:29] <aboodman> hello
[10:14:38] <aboodman> i know it's time to go to sleep when jochen__ shows up
[10:15:05] <pamg> Good night then, aboodman.
[10:15:10] <aboodman> it's like a reverse alarm clock
[10:15:42] *** fuzeman has quit IRC
[10:16:23] *** fuzeman has joined #chromium
[10:19:35] *** mahemoff has joined #chromium
[10:23:53] *** hebz0rl has joined #chromium
[10:25:01] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "mini_installer_test" on "XP Tests" from 50434: aa at chromium dot org, tony at chromium dot org (:tony^work))
[10:26:14] <tony^work> really?
[10:26:16] <tony^work> that's probably me
[10:26:17] <tony^work> looking
[10:27:06] <tony^work> hmm, it passed on vista
[10:27:56] *** pfeldman has quit IRC
[10:28:02] <trungl-bot> Tree closed by tony at chromium dot org (:tony^work): Tree is closed ("mini_installer_test" -> tony investigating)
[10:30:37] *** ROBOd has joined #chromium
[10:31:18] <tony^work> let me know if you need to commit
[10:31:23] <tony^work> I think this is isolated
[10:40:40] *** glider has joined #chromium
[10:40:41] *** ChanServ sets mode: +v glider
[10:43:37] *** reiko has quit IRC
[10:47:52] *** pfeldman has joined #chromium
[10:49:06] *** yuzo has quit IRC
[10:49:13] *** yuzo has joined #chromium
[10:49:13] *** ChanServ sets mode: +v yuzo
[10:50:01] *** eseidel has quit IRC
[10:50:12] *** abarth|R- has quit IRC
[10:52:09] *** Mark_ has left #chromium
[10:54:20] <trungl-bot> Tree opened by tony at chromium dot org (:tony^work): tree is open (mini installer tests on XP should cycle green)
[10:55:25] <tony^work> sorry for the long closed tree.  speculative fix checked in
[11:02:35] *** chrisccoulson has joined #chromium
[11:07:02] <phajdan-jr> landing a change that might break page_cyclers
[11:07:23] <phajdan-jr> I'm watching the tree, but in case I miss some regression, feel free to revert the patch without warning
[11:07:24] *** nebula has joined #chromium
[11:08:12] <tony^work> hmm, the current XP Tests is going to fail on mini installer again
[11:08:17] <tony^work> should I just restart it?
[11:08:57] *** nebula is now known as nebula76
[11:09:42] <tony^work> I'm going to restart it
[11:10:21] <tony^work> oh ,nevermind, it's almost done
[11:10:28] *** slavka` has joined #chromium
[11:10:59] *** up365 has quit IRC
[11:11:29] *** up365 has joined #chromium
[11:12:56] * tony^work waits an hour for Tests XP to get to mini_installer_tests
[11:14:00] *** mahemoff has quit IRC
[11:15:24] *** laranon has joined #chromium
[11:16:04] *** laranon has joined #chromium
[11:22:16] *** nebula76 has quit IRC
[11:31:13] *** SRabbelier has quit IRC
[11:37:50] *** SRabbelier has joined #chromium
[11:42:20] *** pfeldman has quit IRC
[11:44:00] *** pfeldman has joined #chromium
[11:47:32] *** BryanWB has joined #chromium
[11:57:11] *** leiz has quit IRC
[11:58:17] <tony^work> yes, green!
[11:59:11] *** markusheintz has joined #chromium
[11:59:23] *** leiz has joined #chromium
[12:00:51] *** hbono has quit IRC
[12:03:20] *** wocao has quit IRC
[12:07:44] *** Martijnc has joined #chromium
[12:10:39] *** phajdan-jr has quit IRC
[12:14:18] *** Herald has joined #chromium
[12:14:50] *** mahemoff has joined #chromium
[12:14:56] *** General13372 has quit IRC
[12:15:39] <Herald> hi guys, maybe this is a silly question: how can i change the content types which chrome/chromium displays in-browser, rather than downloading?
[12:15:41] *** sjefen6 has quit IRC
[12:15:54] *** sjefen6 has joined #chromium
[12:16:05] <Herald> all i want is to display .js files rather than download them by default, can't find how to do this anywhere
[12:16:05] *** slavka` has quit IRC
[12:20:38] <Herald> so, i want to modify chromes mime type settings
[12:20:40] <Herald> any takers?
[12:22:18] *** leiz has quit IRC
[12:22:21] *** leiz has joined #chromium
[12:22:22] *** ChanServ sets mode: +v leiz
[12:23:11] *** slavka` has joined #chromium
[12:26:38] *** paulgrous has joined #chromium
[12:27:48] *** slavka` has quit IRC
[12:31:46] *** GeekShadow has quit IRC
[12:47:49] *** yuzo has quit IRC
[12:50:46] *** Zaba has quit IRC
[12:51:03] *** MikeSmithW3C^ has joined #chromium
[12:52:42] *** MikeSmithW3C^ has quit IRC
[12:54:38] *** MikeSmithW3C has quit IRC
[12:57:59] *** paulgrous has quit IRC
[12:58:43] *** Zaba has joined #chromium
[12:59:53] *** dumi has quit IRC
[13:04:23] *** Xunie has joined #chromium
[13:04:49] <Xunie> Is it possible to use VLC for every media stream? (wmv/avi/etc...)
[13:05:21] <Xunie> Because in ubuntu 10.04, totem is the default media player in chrome, and I hate that.
[13:05:52] <selckin> read the topic and ask in an ubuntu channel
[13:06:58] <Xunie> Shit, "ask user questions in #chromium-support", bleh. I hate being spat out for that.
[13:08:07] <bauerb> Herald: I'm pretty sure Chrome already displays the MIME type application/javascript by default
[13:09:40] *** Xunie has left #chromium
[13:14:55] <Herald> bauerb: yes, I think this server may be serving js as a different mimetype...
[13:15:18] *** masterov has quit IRC
[13:16:12] *** ROBOd_ has joined #chromium
[13:17:41] *** ROBOd has quit IRC
[13:22:14] *** sebmarkbage has quit IRC
[13:24:48] *** away01 is now known as temp01
[13:26:00] *** mahemoff has quit IRC
[13:29:31] *** mazda has quit IRC
[13:33:25] *** mahemoff has joined #chromium
[13:33:53] *** shreyas has joined #chromium
[13:39:37] *** rjkroege has joined #chromium
[13:41:48] *** Beetny` has joined #chromium
[13:43:37] *** Beetny has quit IRC
[13:46:23] *** crescendo has quit IRC
[13:48:17] *** shreyas has quit IRC
[13:55:24] *** GeekShadow has joined #chromium
[13:55:56] *** adiumtestuser has quit IRC
[13:56:51] *** tonikitoo has quit IRC
[13:58:37] *** adiumtestuser has joined #chromium
[13:58:37] *** ChanServ sets mode: +v adiumtestuser
[14:01:51] *** pdelgallego has quit IRC
[14:02:21] *** rjkroege has quit IRC
[14:05:06] *** mahemoff has quit IRC
[14:06:18] *** az has quit IRC
[14:07:09] *** amx has joined #chromium
[14:07:22] *** mahemoff has joined #chromium
[14:10:04] *** pinkerton has joined #chromium
[14:10:04] *** ChanServ sets mode: +v pinkerton
[14:16:50] *** roc has quit IRC
[14:19:51] *** thomasvl has joined #chromium
[14:19:51] *** ChanServ sets mode: +v thomasvl
[14:22:46] *** rohitrao has joined #chromium
[14:22:46] *** ChanServ sets mode: +v rohitrao
[14:23:53] *** mpavel has joined #chromium
[14:24:32] <mpavel> is there a reason for my app working in debug mode (in it's tab at a url) and not in the popup?
[14:24:46] <mpavel> sorry, my chrome extension
[14:24:56] <rohitrao> pinkerton: I don't understand" Toolbar is now indented along with the rest of the window
[14:24:56] <rohitrao> content."  Is there a new mock?
[14:25:05] <pinkerton> bwahahah no
[14:25:16] <pinkerton> the sidebar takes up the entire left side
[14:25:35] <pinkerton> "whatever sky did on windows" is the new mock
[14:25:47] <pinkerton> see how much fun i'm having?
[14:26:12] <rohitrao> indeed
[14:26:16] <rohitrao> is this checked in on windows?
[14:26:25] <pinkerton> yah
[14:26:54] <pinkerton> so i'm just blindly following along
[14:27:55] *** mazda has joined #chromium
[14:27:55] *** ChanServ sets mode: +v mazda
[14:28:31] <rohitrao> so the way i'm reading this, the tabstrip is still at the top always
[14:28:44] <rohitrao> and sometimes we're leaving a gap on the left side
[14:28:50] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "XP Tests (dbg)(1)" from 50448: jeremy at chromium dot org (:jeremymos))
[14:29:47] *** tonikitoo has joined #chromium
[14:30:23] <pinkerton> rohitrao: if useVerticalTabs is set, there is no tabstrip at the top, and a gap is left for the (eventual) side tab view
[14:30:29] *** MikeSmithW3C has joined #chromium
[14:30:58] <pinkerton> that's how i see the code, i just checked
[14:31:57] *** Beetny` has quit IRC
[14:32:12] <rohitrao> ah, i missed the part where we don't create the tab strip controller at all if we're using vertical tabs
[14:32:28] <pinkerton> right, that part didn't change so it's not in this cl
[14:32:34] <pinkerton> i'm just ripping out the toolbar controller changes
[14:32:50] <rohitrao> ok, i'm satisfied. lgtm :)
[14:32:52] <pinkerton> so it's basically a big "undo" of most of my last cl
[14:32:57] <pinkerton> good times.
[14:33:12] <pinkerton> and the tree is closed.
[14:34:33] *** jeremymos has joined #chromium
[14:34:33] *** ChanServ sets mode: +v jeremymos
[14:34:40] *** az has joined #chromium
[14:36:23] <jeremymos> Any sherriffs online who can help me kick the bots after touching generated_resources.grd ?
[14:37:54] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed [grd change @ 50448 -> cycling green]
[14:41:57] *** mahemoff has quit IRC
[14:42:05] *** kliegs has quit IRC
[14:42:16] <pamg> jeremymos: I can help with bots. What do they need?
[14:42:43] <jeremymos> pamg: kicking, I changed the .grd files - tree status indicates rsesek may have kicked them already...
[14:43:24] <pamg> OK, let me know if they need more help... in the next 15 min before I have a meeting.
[14:43:35] <jeremymos> pamg: thanks!
[14:43:44] *** mahemoff has joined #chromium
[14:44:52] <jeremymos> pamg: looks like they still need kicking - XP Tests (dbg), Interactive Tests (dbg), & Vista Tests (dbg)
[14:45:05] <pamg> Simple restart, or clobber?
[14:45:27] <jeremymos> pamg: I don't know what needs to be done for grd changes, I'm guessing clobber....
[14:47:52] <pamg> jeremymos: I'll try a few. Reluctant to do them all, because a clobber build is so slow... Can you not access the buildbot to kick them too?
[14:49:49] <pcgod> jeremymos: http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Landing-a-GRD-Resources-Change
[14:52:52] *** AaronMT has joined #chromium
[14:53:42] *** janm has joined #chromium
[14:57:26] *** deshantm has joined #chromium
[14:58:49] *** rickspencer3 has joined #chromium
[14:59:12] * pinkerton waits for the tree to cycle
[14:59:20] *** roc has joined #chromium
[14:59:22] * pinkerton twiddles thumbs
[15:02:00] * jeremymos :/
[15:03:54] *** jrmuizel has joined #chromium
[15:04:45] *** zaspire has joined #chromium
[15:06:03] *** MX80 has quit IRC
[15:09:25] *** purefusion has quit IRC
[15:10:03] *** gfeher has joined #chromium
[15:13:02] *** purefusion has joined #chromium
[15:13:28] <jeremymos> ok, tree opened...
[15:14:12] <trungl-bot> Tree opened by playmobil at google dot com (:jeremymos): Tree is open [Should cycle green after grd change @ 50448]
[15:15:13] <pinkerton> yay!
[15:15:37] <pinkerton> sigh, gypi file out of date
[15:15:42] * pinkerton rebuilds the world and hoses his machine
[15:17:05] *** laranon has quit IRC
[15:18:23] *** crescendo has joined #chromium
[15:18:57] *** age has joined #chromium
[15:19:02] *** rsesek has joined #chromium
[15:19:03] *** ChanServ sets mode: +v rsesek
[15:20:56] *** vithos has quit IRC
[15:21:40] <age> hello. chromium-6.0.443.0 does not build for me, gives following error when linking chromium binary: "out/Release/obj.target/chrome/libdebugger.a(devtools_remote_listen_socket.o): In function `DevToolsRemoteListenSocket::DispatchField()': devtools_remote_listen_socket.cc:(.text._ZN26DevToolsRemoteListenSocket13DispatchFieldEv+0x93): undefined reference to `std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_compare(unsigne
[15:21:41] <age> d long, unsigned long)'". any idea why does that happen?
[15:22:11] *** age has quit IRC
[15:22:54] *** age has joined #chromium
[15:23:57] <rsesek> is that ToT
[15:24:07] *** MX80 has joined #chromium
[15:25:01] *** thomasvl has quit IRC
[15:25:37] *** thomasvl has joined #chromium
[15:25:37] *** ChanServ sets mode: +v thomasvl
[15:25:43] *** vithos has joined #chromium
[15:27:18] *** jrmuizel has quit IRC
[15:29:50] *** japhet1 has joined #chromium
[15:29:50] *** ChanServ sets mode: +v japhet1
[15:30:57] *** japhet has quit IRC
[15:32:40] *** tfarina has joined #chromium
[15:34:55] *** age has quit IRC
[15:36:47] *** kcbanner has quit IRC
[15:37:13] *** roc has quit IRC
[15:38:12] *** trungl_ has joined #chromium
[15:38:12] *** ChanServ sets mode: +v trungl_
[15:39:26] *** kliegs has joined #chromium
[15:39:41] *** jrmuizel has joined #chromium
[15:45:24] *** dmazzoni has joined #chromium
[15:53:31] *** shreyas has joined #chromium
[15:59:03] *** leeight has joined #chromium
[15:59:06] *** leeight has left #chromium
[15:59:11] *** jrmuizel has quit IRC
[16:00:36] *** jrmuizel has joined #chromium
[16:02:47] *** tonikitoo has quit IRC
[16:03:46] *** gfeher has quit IRC
[16:04:52] *** tedoc2000 has joined #chromium
[16:07:34] *** tfarina has quit IRC
[16:10:58] *** shreyas has quit IRC
[16:12:30] *** Beetny has joined #chromium
[16:15:52] *** shreyas has joined #chromium
[16:16:11] *** rjkroege has joined #chromium
[16:17:14] *** jrmuizel has quit IRC
[16:21:22] *** mahemoff has quit IRC
[16:21:39] *** thomasvl_ has joined #chromium
[16:21:39] *** ChanServ sets mode: +v thomasvl_
[16:21:58] *** thomasvl_ has quit IRC
[16:22:31] *** trungl_ has quit IRC
[16:23:30] *** mahemoff has joined #chromium
[16:23:41] *** tonikitoo has joined #chromium
[16:28:02] *** stuartmorgan has joined #chromium
[16:28:02] *** ChanServ sets mode: +v stuartmorgan
[16:29:20] *** janm has quit IRC
[16:31:50] *** malavv has quit IRC
[16:31:54] *** malavv has joined #chromium
[16:32:30] *** moblin_ has joined #chromium
[16:32:42] *** Aria has joined #chromium
[16:33:03] <moblin_> hello, is there a way to run v8 from the cmd line against a js file, for benchmarking purposes?
[16:33:36] <maruel> moblin_: yes but it's not the right channel for that
[16:33:56] *** yutak_home has joined #chromium
[16:33:56] *** ChanServ sets mode: +v yutak_home
[16:33:56] <Aria> What is the right channel for that, actually?
[16:34:05] <maruel> moblin_: ask on chromuim-support, I'll follow up
[16:34:11] <Aria> Aah, right.
[16:34:15] <maruel> meant #chromium-support
[16:34:43] *** monreal has joined #chromium
[16:35:55] *** trungl_ has joined #chromium
[16:35:55] *** ChanServ sets mode: +v trungl_
[16:36:07] <trungl_> 'morning, Chromium.
[16:36:07] <trungl-bot> trungl_: Good morning!
[16:37:28] <robertshield> good morning
[16:37:36] <rsesek> morning
[16:43:42] *** moblin_ has quit IRC
[16:47:36] *** dmaclach has joined #chromium
[16:47:55] *** rjkroege has quit IRC
[16:50:16] *** gfeher has joined #chromium
[16:52:06] *** BryanWB has quit IRC
[16:57:55] *** andybons has joined #chromium
[16:57:55] *** ChanServ sets mode: +v andybons
[16:59:48] *** kliegs has quit IRC
[17:00:21] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg)" from 50455: mnaganov at chromium dot org)
[17:00:22] *** kliegs has joined #chromium
[17:01:22] <motownavi> Looks like a spurious timeout. Let's see if the following cycle clears it up
[17:05:09] *** jeremymos has quit IRC
[17:05:52] *** jrmuizel has joined #chromium
[17:06:58] <mnaganov> yes, looks pretty strange
[17:07:45] <robertshield> yeah, looks like the build just decided to hang
[17:09:33] <robertshield> @sheriffs: I'm looking at the failure in Linux Builder (Views dbg), looks like a legitimate crash in AutocompleteEditViewGtk::TextWidth(), doesn't look related to the failing test
[17:09:41] <robertshield> I'm waiting to see one more run
[17:09:42] *** tonyg-cr has joined #chromium
[17:09:43] *** ChanServ sets mode: +v tonyg-cr
[17:10:50] *** moblin_ has joined #chromium
[17:11:21] <motownavi> robertshield: cool, thx
[17:15:44] *** willchan_ has joined #chromium
[17:15:44] *** ChanServ sets mode: +v willchan_
[17:17:32] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open ("Chromium Linux Builder (dbg)" failure appeared spurious)
[17:17:46] <robertshield> I reopened, looks like the next compile on the linux builder went through
[17:24:23] *** qinjia has joined #chromium
[17:24:26] *** trungl_ has quit IRC
[17:30:29] *** vithos has quit IRC
[17:32:18] *** fta has quit IRC
[17:32:54] *** fqian has joined #chromium
[17:34:58] *** fta has joined #chromium
[17:37:19] *** vithos has joined #chromium
[17:37:46] <willchan_> robertshield,motownavi: looks like everything is green, mod some flaky tests, and the XP page_cycler_moz.  anyone tracking this issue?
[17:39:13] <robertshield> willchan: I was going to mark the TestCNInvalidStickiness test flaky due to http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests%20(dbg)(4)
[17:39:26] *** glider has quit IRC
[17:39:33] <robertshield> I haven't looked at the xp page cycler
[17:43:19] <willchan_> robertshield: sounds good to me
[17:43:53] <andybons> pinkerton: ping
[17:43:57] *** thakis_ has joined #chromium
[17:43:57] *** ChanServ sets mode: +v thakis_
[17:44:23] <willchan_> ok, i've gotta run off for some errands, then i'll go to the office.  afk next hour or so.
[17:44:29] *** willchan_ has quit IRC
[17:48:00] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open
[17:52:25] *** Erkan_Yilmaz has joined #chromium
[17:52:27] *** Barkhorn has joined #chromium
[17:52:37] *** Erkan_Yilmaz has quit IRC
[17:54:25] *** trungl is now known as trungl_afk
[17:55:11] *** rsesek has quit IRC
[17:55:42] *** sebmarkbage has joined #chromium
[17:56:05] *** jshin has joined #chromium
[17:56:05] *** ChanServ sets mode: +v jshin
[17:56:32] *** Erkan_Yilmaz has joined #chromium
[18:00:37] *** GeekShadow has quit IRC
[18:00:38] *** rsesek has joined #chromium
[18:00:38] *** ChanServ sets mode: +v rsesek
[18:00:42] <fearphage> http://dl.dropbox.com/u/2400/opera/bugs/bugs.htm?http://my.imaginary/site/
[18:13:31] *** nutz has left #chromium
[18:22:03] *** markmentovai has joined #chromium
[18:22:04] *** ChanServ sets mode: +v markmentovai
[18:23:05] *** kuchhal has left #chromium
[18:24:04] *** erikkay has joined #chromium
[18:24:05] *** ChanServ sets mode: +v erikkay
[18:25:54] *** rohitrao has quit IRC
[18:27:48] *** ChanServ sets mode: +o maruel
[18:27:54] *** maruel sets mode: -b *!*@unaffiliated/tehbaut
[18:28:01] *** tehbaut has joined #chromium
[18:28:05] *** maruel sets mode: -b *!*arghh2d2@cpe-98-30-113-178.woh.res.rr.com
[18:28:12] *** maruel sets mode: -b *!*@76.91.62.8
[18:28:19] *** maruel sets mode: -b *!*@jibot.imaj.es
[18:28:24] *** maruel sets mode: -b *!*jibot@67.207.137.*
[18:28:47] *** ChanServ sets mode: -o maruel
[18:30:03] *** RT|Chatzilla has quit IRC
[18:30:08] *** General1337 has joined #chromium
[18:31:38] *** sbyer has joined #chromium
[18:31:38] *** ChanServ sets mode: +v sbyer
[18:31:53] *** rjkroege has joined #chromium
[18:38:37] <rsesek> pinkerton: it's your favorite bug crbug.com/47134
[18:39:04] <pinkerton> heh
[18:39:21] <pinkerton> blame trung
[18:39:35] <pinkerton> that's my story and im sticking to it
[18:39:37] <rsesek> :p
[18:41:43] *** rohitrao has joined #chromium
[18:41:44] *** ChanServ sets mode: +v rohitrao
[18:41:45] *** sbyer has left #chromium
[18:41:49] *** sbyer has joined #chromium
[18:41:49] *** ChanServ sets mode: +v sbyer
[18:42:08] *** gfeher has quit IRC
[18:43:09] * thakis_ just learned that abarth is a car brand
[18:44:00] *** phanee has joined #chromium
[18:44:53] *** phanee has left #chromium
[18:45:49] *** maikmerten has joined #chromium
[18:48:01] <stuartmorgan> My favorite bug is the space-switching-on-page-load that also seems to be back
[18:48:13] <stuartmorgan> We should just decide these are features, since we can't manage to keep them fixed
[18:48:45] *** rjkroege has quit IRC
[18:48:46] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Linux Tests (dbg-shlib)(1)" from 50466: jcivelli at chromium dot org, rsesek at chromium dot org)
[18:48:53] <rsesek> not my fault
[18:51:30] *** wr| has quit IRC
[18:51:46] *** trungl has joined #chromium
[18:51:46] *** ChanServ sets mode: +v trungl
[18:52:56] *** mdm_chromium has joined #chromium
[18:52:59] *** dglazkov has joined #chromium
[18:53:00] *** ChanServ sets mode: +v dglazkov
[18:53:07] <dglazkov> good morning, Chromium!
[18:53:07] <trungl-bot> dglazkov: Good morning!
[18:53:08] *** wr| has joined #chromium
[18:53:19] <robertshield> jcivelli: ping
[18:53:22] <dglazkov> you trungl-bot
[18:53:28] <dglazkov> :)
[18:54:10] <robertshield> going to revert r50465 methinks
[18:54:51] *** fqian has joined #chromium
[18:56:22] *** kbr_google has joined #chromium
[18:56:22] *** ChanServ sets mode: +v kbr_google
[18:57:04] *** thakis_ has quit IRC
[18:57:33] *** fta has quit IRC
[18:58:59] *** abarth has joined #chromium
[18:58:59] *** ChanServ sets mode: +v abarth
[18:59:16] *** abarth has quit IRC
[18:59:53] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open, revert for 50465 is in.
[19:05:08] *** rjkroege has joined #chromium
[19:05:09] *** ChanServ sets mode: +v rjkroege
[19:05:29] *** bent-mozilla has joined #chromium
[19:05:35] *** mrossetti has joined #chromium
[19:07:49] *** mrossetti has joined #chromium
[19:08:20] <willchan> robertshield: i'm back in
[19:08:33] <robertshield> hey
[19:08:59] <robertshield> we had a closure / revert
[19:09:38] <robertshield> valgrind bots are slightly unhappy, but I added a suppression that will hopefully get picked up this run
[19:15:46] *** Zaba has quit IRC
[19:17:17] *** dantasse has joined #chromium
[19:18:17] *** mrossetti_ has joined #chromium
[19:18:25] *** mrossetti has quit IRC
[19:18:26] *** mrossetti_ is now known as mrossetti
[19:20:50] <willchan> ok, great
[19:21:26] *** nsylvain has joined #chromium
[19:21:27] *** ChanServ sets mode: +v nsylvain
[19:22:43] *** lianj has quit IRC
[19:24:10] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open
[19:24:34] *** lianj has joined #chromium
[19:24:40] *** Zaba has joined #chromium
[19:26:02] *** thomasvl has quit IRC
[19:26:13] *** thomasvl has joined #chromium
[19:26:13] *** ChanServ sets mode: +v thomasvl
[19:26:15] *** csilv has joined #chromium
[19:26:15] *** ChanServ sets mode: +v csilv
[19:29:51] *** rjkroege has quit IRC
[19:30:28] *** inferno-sec has quit IRC
[19:31:41] *** roc has joined #chromium
[19:32:48] <stuartmorgan> Ugh, we combined stop and reload? Are we at least going to lock its state during hover?
[19:33:13] <pinkerton> take it up with ui-leads
[19:33:24] *** inferno-sec has joined #chromium
[19:33:25] *** ChanServ sets mode: +v inferno-sec
[19:33:31] <stuartmorgan> pinkerton: is the lack of locking an implementation bug, or a design feature?
[19:33:39] <pinkerton> beats me
[19:33:45] <stuartmorgan> I guess I'll just file it
[19:34:10] <pinkerton> i'd suggest emailing them. you'll probably just get a WONTFIX in bugs
[19:34:16] <pinkerton> with no explanation
[19:35:14] *** qinjia has quit IRC
[19:37:07] *** GeekShadow has joined #chromium
[19:38:26] *** apatrick_ has left #chromium
[19:39:26] *** rohitrao has quit IRC
[19:39:44] *** rohitrao has joined #chromium
[19:39:45] *** ChanServ sets mode: +v rohitrao
[19:50:48] <rsesek> about:ipc is borked on mac
[19:51:00] *** mpcomplete has joined #chromium
[19:51:01] *** ChanServ sets mode: +v mpcomplete
[19:51:49] *** jamesr has joined #chromium
[19:51:50] *** ChanServ sets mode: +v jamesr
[19:52:34] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder x64" from 50479: akalin at chromium dot org)
[19:53:05] <robertshield> akalin: ping
[19:53:21] *** pathorn has joined #chromium
[19:53:21] *** ChanServ sets mode: +v pathorn
[19:54:37] <willchan> definitely broken, we need to revert
[19:54:41] <willchan> akalin: yt?
[19:55:22] *** bauerb has quit IRC
[19:55:42] <willchan> well, hm
[19:56:04] <willchan> chromium shared lib builder worked
[19:56:35] <willchan> it looks like the proto compiler filed to generate the .pb.h
[19:56:47] <robertshield> akalin says he's looking into it
[19:56:53] <willchan> ok
[19:57:39] *** lnostdal_ has quit IRC
[19:57:43] *** moblin_ has quit IRC
[19:58:17] <rsesek> jrg: ping
[19:58:39] <willchan> chase: ping
[19:59:38] <trungl-bot> Tree opened by akalin at chromium dot org: Tree is open (revert for 50479 in)
[20:00:35] *** pfeldman has quit IRC
[20:05:42] *** cpu has joined #chromium
[20:05:43] *** ChanServ sets mode: +v cpu
[20:06:03] *** apatrick_ has joined #chromium
[20:06:04] *** ChanServ sets mode: +v apatrick_
[20:09:35] *** Martijnc has quit IRC
[20:09:44] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux" from 50480: akalin at chromium dot org, hclam at chromium dot org, mbelshe at chromium dot org)
[20:09:54] <robertshield> ugh
[20:09:55] <hclam> looking
[20:10:28] *** up365 has quit IRC
[20:10:53] <hclam> it's google/cacheinvalidation/types.pb.h
[20:11:12] <hclam> looks like including protobuf generated header and not found
[20:11:22] <willchan> that's the same build error from earlier
[20:11:26] <robertshield> yeah, looks stale.. maybe needs a clobber
[20:11:38] <hclam> probably a race condition in build sequence
[20:11:55] <willchan> yeah, the proto buf dependency probably is not being properly expressed in the make file
[20:11:56] <hclam> protobuf targets need to have hard_dependency in gyp..
[20:12:18] <willchan> the revert is already in for the broken behavior
[20:12:29] <willchan> er, the changelist that caused it
[20:13:49] <robertshield> ok, let's see if it cycles?
[20:16:12] *** scherkus has joined #chromium
[20:16:25] <robertshield> ok, it compiled again, reopening..
[20:17:00] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open, revert for 50465 is in, linux bots should go green
[20:17:23] *** up365 has joined #chromium
[20:18:24] *** mahemoff has quit IRC
[20:19:16] *** inferno-sec has quit IRC
[20:19:18] *** mahemoff has joined #chromium
[20:19:24] *** shreyas has quit IRC
[20:20:20] *** wjmaclean_ has quit IRC
[20:21:54] *** wjmaclean has joined #chromium
[20:24:32] *** mahemoff has quit IRC
[20:24:33] *** rickspencer3_ has joined #chromium
[20:24:54] *** shreyas has joined #chromium
[20:25:25] *** rafaelw has joined #chromium
[20:25:25] *** ChanServ sets mode: +v rafaelw
[20:26:10] *** rickspencer3 has quit IRC
[20:30:09] *** MikeSmithW3C^ has joined #chromium
[20:33:10] *** MikeSmithW3C has quit IRC
[20:36:08] *** Barkhorn has quit IRC
[20:36:50] *** victorw has joined #chromium
[20:36:50] *** ChanServ sets mode: +v victorw
[20:37:01] <thakis> thomasvl: i get a bunch of "sign doesn't match errors" if i compile chrome with clang. i had to turn on -Wno-sign-compare
[20:37:14] <thakis> does gcc not have this warning, or is it just reported in fewer cases?
[20:38:10] *** tittiatcoke has joined #chromium
[20:38:29] <thomasvl> i don't think gcc defaults it on with Wall or Wextra
[20:38:46] <thomasvl> there is a note in common.gypi about it for the windows settings, so they might have it turned on there.
[20:39:11] *** fta has joined #chromium
[20:39:36] <thomasvl> thakis: i'd say start without it, but maybe log a bug to see about using it.
[20:39:36] *** rickspencer3_ is now known as rickspencer3
[20:39:43] <thakis> ok
[20:40:01] <thomasvl> thakis: if you look at a mac webkit build, there are a few more things they jack up that we haven't, it might be worth going after those also in the future.
[20:40:33] <thakis> lots of of the sign warnings were in webkit, so they don't have that yet i guess :-)
[20:41:05] <thomasvl> thakis: core webkit, or chromium webkit?
[20:41:32] <thakis> good point, don't remember
[20:41:36] <thomasvl> i did have some warnings in chroimium files within webkit i had to fix because the other builds don't hit those files.
[20:41:38] <thakis> i thought webcor
[20:42:23] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open, Chromium Arm should cycle green.
[20:44:44] *** shoe has joined #chromium
[20:47:13] <thomasvl> thakis: ygm
[20:47:21] <thakis> thomasvl: thx
[20:49:07] *** chrisccoulson_ has joined #chromium
[20:49:29] *** scherkus_ has joined #chromium
[20:49:38] *** scherkus has quit IRC
[20:50:35] <shoe> hey, is there any way to make chromium close an audio device after closing a page with a <video> element?
[20:50:55] <shoe> (so that other programs can use the device)
[20:50:58] *** chrisccoulson has quit IRC
[20:51:29] <hclam> it does close the audio device after a page cloes, doesn't it?
[20:52:36] <shoe> afaict, it does not.  I leave the page and the device is still open, but if I close the app, I can access the device.
[20:53:05] <shoe> this is a native alsa device - not pulseaudio
[20:53:09] <thomasvl> shoe: sure it's <video> and not flash?
[20:53:19] <jrg> rsesek: pong
[20:53:24] <shoe> i'm positive it's <video> and not flash.
[20:53:30] <thomasvl> shoe: sure there aren't other tabs with flush/audio that causes it to stay in use.
[20:53:52] <rsesek> jrg: I'm trying to use about:ipc and it doesn't work; it goes to a blank page (chrome://about/ipc)
[20:53:54] <shoe> no tabs, it's a single window in kiosk mode.
[20:53:57] <rsesek> wondered if you had ideas
[20:54:06] <thomasvl> shoe: open an issue with a test case then (http://new.crbug.com)
[20:54:40] <jrg> rsesek: looks broken; I'm about to hit lunch but will send you a CL to fix it after then.  (I don't know what's wrong but I'll find out.)
[20:54:49] <rsesek> jrg: thanks!
[20:54:51] <jrg> np
[20:54:52] <shoe> mostly, I'm wondering if there's any trick I can do to the video element to make it close?
[20:55:44] <willchan> akalin: before you reland, note: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20(dbg)(1)/builds/25208/steps/check%20deps/logs/stdio
[20:55:52] <willchan> checkdeps error
[20:56:57] <hclam> shoe: sounds like a bug, can you file a bug against me?
[20:57:10] *** tonyg-cr has quit IRC
[20:57:19] <hclam> a tab close should cause all related audio device to be closed, if not then there's a bug..
[20:57:33] <trungl-bot> Tree opened by ananta at chromium dot org (:iyengar): Tree is open, Chromium Arm should cycle green. ChromeFrame IE7 builder offline for debugging
[21:00:22] *** tonyg-cr has joined #chromium
[21:00:22] *** ChanServ sets mode: +v tonyg-cr
[21:01:14] <hclam> willchan: ping
[21:01:18] *** rjkroege has joined #chromium
[21:01:19] *** ChanServ sets mode: +v rjkroege
[21:01:30] <willchan> hclam: pong
[21:01:50] <hclam> about the page recycler regression from webkit
[21:02:05] <willchan> hclam: the intl regression?
[21:02:09] <hclam> yup
[21:02:12] <willchan> ok, sup?
[21:02:38] <hclam> is it possible that we roll in the webkit change and wait for upstream fix?
[21:03:02] *** Hixie has quit IRC
[21:03:16] <hclam> otherwise we'll have a drift with webkit
[21:03:23] <jamesr> hclam: or revert upstream
[21:03:42] <jamesr> that's what i would prefer (revert the offending patch in webkit, roll)
[21:04:35] *** Hixie has joined #chromium
[21:04:45] *** tlrobinson has quit IRC
[21:05:12] *** rjkroege has quit IRC
[21:05:14] *** pfeldman has joined #chromium
[21:05:15] <hclam> the change is from apple, I can check the status with the guy
[21:05:22] *** rjkroege has joined #chromium
[21:05:22] *** ChanServ sets mode: +v rjkroege
[21:05:37] <jamesr> he's working on it
[21:05:40] <jamesr> and can repro locally
[21:05:42] <jamesr> are you cc'd on the bug?
[21:06:06] <hclam> nope, but I have the thread
[21:06:36] <jamesr> i'm updating the bug
[21:06:37] *** kliegs has quit IRC
[21:06:46] <hclam> I added myself to the bug too
[21:07:28] <jamesr> suggested reverting. if they don't object soon i'll roll it out
[21:07:33] <jamesr> are we green for a webkit roll otherwise?
[21:07:44] *** kliegs has joined #chromium
[21:08:13] <hclam> yup, pretty green for the recent revisions
[21:08:41] <hclam> thanks
[21:09:06] <jamesr> to be polite we should give them some time to chime up before rolling out
[21:09:38] <hclam> sounds good
[21:10:51] *** duffydack has joined #chromium
[21:12:07] <hclam> jamesr: 61549, 61552, 61556 61561 are related build fix, may have to roll out at the same time
[21:12:39] <jamesr> patches with 4 followup build fixes are typically bad news
[21:12:50] *** tlrobinson has joined #chromium
[21:13:19] <jamesr> hclam: can you generate a mega rollout? i don't know if i have the svn-foo to do that
[21:13:32] <hclam> sure, will do
[21:13:56] <hclam> jamesr: you use git or svn?
[21:14:03] <jamesr> both
[21:14:17] <hclam> will get you a git patch
[21:14:29] <jamesr> since this has binaries i tend to use svn
[21:14:42] <jamesr> dunno if git will do the right thing for the images
[21:15:36] <hclam> jamesr: git does pretty well if you commit manually, not so well with commit queue
[21:18:12] <willchan> hclam: do you need anything from me still?  or do you webkit folks have it under control?
[21:18:55] <hclam> willchan: not from the chromium side, thanks :)
[21:19:06] <willchan> hclam: excellent
[21:19:41] <robertshield> willchan: I'm adding a suppression for the reliability failure
[21:19:52] <willchan> robertshield: ok, great
[21:21:05] <akalin> any gyp gurus around
[21:22:29] <thomasvl> akalin: what's up?  (markmentovai is around also)
[21:22:34] <hclam> jamesr: I'm wrong about git.. doesn't handle binaries for revert.. trying svn now
[21:22:53] <akalin> thomasvl: so i'm running into problems with defining gyp rules for proto bufs
[21:23:00] <jamesr> hclam: yeah, it's a shame
[21:23:57] <akalin> basically, there's third_party/cacheinvalidation/cacheinvalidation.gyp, which defines cacheinvalidation_proto (.proto -> .pb.h and .pb.cc files), cache_invalidation_proto_cc (library containing all the .pb.h .pb.cc files) and cacheinvalidation, which depends on cacheinvalidation_proto_cc
[21:24:42] <akalin> it looks like i got the export settings right, but if i make another library target X depend on cacheinvalidation, it barfs because the .pb.h file isn't generated before it tries to compile X
[21:24:45] <dcheng> Is the file selection input broken for anyone else?
[21:25:01] <thomasvl> akalin: this checked in, or in a cl to look at?
[21:25:19] <markmentovai> something needs to be hard
[21:25:21] <markmentovai> or none-type
[21:25:31] <markmentovai> if everything's a static lib, that will happen
[21:25:35] <akalin> thomasvl: cacheinvalidation.gyp is checked in, and http://codereview.chromium.org/2827014/show makes the syncapi target in chrome.gyp depend on cacheinvalidation
[21:25:36] <jamesr> hclam: sigh
[21:25:38] <akalin> markmentovai: oh
[21:25:39] <akalin> what is hard?
[21:25:43] <markmentovai> hard_dependency
[21:25:46] <jamesr> hclam: so mitz is unhappy with it being reverted
[21:25:52] <akalin> ah, okay i didn't know about that
[21:25:57] <markmentovai> it says "don't unhook this dependency relationship, other targets depend on side effects"
[21:26:06] <akalin> markmentovai: i see
[21:26:17] <markmentovai> you would make the target that generates the .cc and .h files hard
[21:26:36] <akalin> markmentovai: basically anything that generates header files, right?
[21:26:40] <markmentovai> akalin: http://code.google.com/p/gyp/wiki/InputFormatReference#Linking_Dependencies
[21:26:53] *** tittiatcoke has quit IRC
[21:26:55] <markmentovai> no, only things that generate headers where those headers need to be seen by other targets
[21:26:57] *** pronto has joined #chromium
[21:26:57] <jamesr> hclam: so we're at an impasse. i imagine he'll fix it soon :/
[21:27:05] <markmentovai> and it only really happens for static_library targets
[21:27:06] <maruel> wow, the translate toolbar is screwed on 6.0.437.3
[21:27:11] <akalin> i see
[21:27:21] <pronto> is there anyway to block an image yet with chromium?
[21:27:51] <maruel> pronto: use lynx, see topic
[21:27:52] <thomasvl> akalin: fyi the rule/sources in cacheinvalidation_proto could move into cacheinvalidation_proto_cc and avoid one extra target too.
[21:27:57] <akalin> markmentovai: i'm looking at remoting/base/protocol/chromotocol.gyp, and it looks like the .pb.{h,cc} generating rule has hard_dependency, but also chromotocol_proto_lib
[21:27:58] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Linux Tests (dbg)(2)" from 50486: victorw at chromium dot org)
[21:28:07] <pronto> oh, right
[21:28:26] <akalin> thomasvl: i thought that keeping the generated proto files and the real .cc/.h files separate would be cleaner
[21:28:27] <thomasvl> that would remove one more things for the IDEs to dependency analyze/sort
[21:28:34] <akalin> oh
[21:28:36] <akalin> maybe i'll just do that
[21:29:04] *** sbyer has quit IRC
[21:29:13] <akalin> thanks!
[21:29:20] <thomasvl> akalin: right, but it does add a target which means additional input to build systems.  minor, but if you look at some of the chrome gyp files, we tended to skip that stuff just to pipeline things more during the build.
[21:29:37] <markmentovai> let the tools handle it for you
[21:29:56] <markmentovai> end .gyp file proliferation
[21:30:09] *** dpranke has joined #chromium
[21:30:09] *** ChanServ sets mode: +v dpranke
[21:30:12] <markmentovai> no reason to split this guy out
[21:30:44] <akalin> markmentovai: okay
[21:30:57] <victorw> willchan: robertshield: hi
[21:31:06] <akalin> what if two independent libraries needed the .pb.cc files?
[21:31:21] <akalin> only then would it be better to split it out?
[21:31:23] <markmentovai> yes
[21:31:28] <akalin> k
[21:31:32] <robertshield> victorw: hi
[21:31:32] <markmentovai> unless one lib already dpeends on the other
[21:31:33] <markmentovai> but even so
[21:31:34] <robertshield> was that you?
[21:31:49] <markmentovai> you should make the .pb.cc files be built into the library that generates them
[21:31:55] <victorw> robertshield: I don't think so. my patch should not change anything
[21:31:56] <markmentovai> and not try to build them into another targ
[21:32:10] <akalin> i see
[21:32:20] <markmentovai> why would you compile the same thing twice?
[21:32:29] <markmentovai> you wouldn't!
[21:32:45] <markmentovai> (there are some reasons to. but they rarely come up in chromium_code.)
[21:32:49] <akalin> indeed
[21:34:00] <thomasvl> akalin: there's a directive like "process_outputs_as_sources" that you want to add to the rule
[21:34:16] *** jrmuizel has quit IRC
[21:34:18] <thomasvl> then you don't have to list them in the lib target, just have the rule, and the rest happens for you completely with the right deps.
[21:35:12] <robertshield> scherkus: ping
[21:36:37] *** duffydack has left #chromium
[21:37:56] *** skydrome has quit IRC
[21:38:06] *** skydrome has joined #chromium
[21:38:44] <jamesr> hclam: so the options are (1) don't roll until mitz patches or (2) roll, reset the expectations for intl2 to be higher, and remember to reset them back down when the regression is fixed
[21:38:48] <jamesr> (2) is a very dangerous path
[21:39:38] <jamesr> (1) kind of sucks as well but upstream is being a bit petulant
[21:43:07] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open, revert for unit_tests failure is in.
[21:43:33] <thakis> markmentovai: is chromium_mac_pch used for anything these days?
[21:43:45] <markmentovai> the 10.5 bots use it
[21:43:50] <markmentovai> to turn off pch
[21:44:05] <markmentovai> it's not needed on 10.6, pch goes off automatically when distcc is on
[21:44:15] <thakis> markmentovai: in my ignorant testing, it appeared that pchs aren't used with this on either
[21:44:28] <markmentovai> only webkit
[21:44:33] <thakis> i tried to turn them on ( http://codereview.chromium.org/2868021 ), but it didn't really ehlp
[21:44:34] <thakis> ah
[21:44:35] <thakis> ok
[21:44:38] <thakis> yes, i saw that
[21:44:45] <markmentovai> it's not gonna make a difference
[21:44:52] <markmentovai> because we don't have a prefix header anywhere
[21:44:54] <markmentovai> only webkit does
[21:44:54] <markmentovai> t
[21:45:02] <thakis> well, i added one
[21:45:06] <thakis> that included cocoa.h
[21:45:08] <markmentovai> oh, please don't :)
[21:45:14] <thakis> slowed down the build by 50%
[21:45:15] <jamesr> hclam: i think we'll just have to not roll for a little bit
[21:45:17] *** pfeldman has quit IRC
[21:45:18] <markmentovai> it won't help
[21:45:28] <markmentovai> and apple's gcc pch implementation is a nightmare
[21:45:37] <markmentovai> i have a hatin' on it
[21:46:41] *** inferno-sec has joined #chromium
[21:46:41] *** ChanServ sets mode: +v inferno-sec
[21:47:17] *** romainhuet has quit IRC
[21:48:10] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 50505: ajwong at chromium dot org, msneck at google dot com, robertshield at chromium dot org, vangelis at chromium dot org)
[21:48:27] *** bmizerany has joined #chromium
[21:48:27] *** maikmerten has quit IRC
[21:48:48] <awong> "Running ncdecode_tablegen
[21:48:49] <awong> Badly defined mnemonic name"
[21:48:52] <awong> any ideas?
[21:50:22] <dcheng> Does anyone else here have problems with <input type="file"> on Windows dev?
[21:50:34] <awong> msneck: ping
[21:50:57] <hclam> jamesr: sorry I was talking to someone else
[21:51:17] <jamesr> hclam: no problem. did you see my messages above?
[21:51:27] <hclam> jamesr: yp
[21:51:42] <awong> thinking current failure is the NaCl roll...anyone know how to confirm?
[21:53:01] <hclam> I also think we should roll it out, but we can give him some time
[21:53:24] <awong> I can't find him...
[21:54:05] <awong> starting ticker...will roll out at 12:55.
[21:54:08] <hclam> jamesr: what about we set a time for rolling out if it's not fixed?
[21:56:18] <awong> found Mark.  Sounds like this change needs a clobber.
[21:56:21] *** scherkus has joined #chromium
[21:56:29] *** scherkus has quit IRC
[21:56:32] <awong> I'm going to clobber Chromium Builder (dbg).
[21:56:51] *** michaeln has joined #chromium
[21:56:51] *** ChanServ sets mode: +v michaeln
[21:58:03] <robertshield> does anyone know about the missing libpdf.so error on the official builders?
[21:58:16] <trungl-bot> Tree closed by ajwong at chromium dot org: Tree is closed (Chromium Builder (dbg) -> Clobber due to NaCl DEPs roll)
[21:59:02] *** tonyg-cr has quit IRC
[21:59:07] *** laranon has joined #chromium
[22:00:10] *** glider has joined #chromium
[22:00:10] *** ChanServ sets mode: +v glider
[22:00:13] <awong> robertshield: I've clobbered Chromium Builder (dbg).  The release builder didn't go red, so I'm just going to leave it alone.  Sound good?
[22:01:20] *** glider has quit IRC
[22:01:23] *** shreyas has quit IRC
[22:01:39] <robertshield> awong: sounds good to me
[22:02:15] <robertshield> I would like to leave the tree closed for a bit while the builders catch up and while I try to figure out what's wrong with the official builders
[22:03:37] <jamesr> hclam: i think we probably shouldn't be seen as setting deadlines or anything like that. he's working on it and will hopefully update us
[22:04:06] <hclam> jamesr: ok
[22:04:22] <jamesr> hclam: if we don't hear anything in a few hours then we should probably sync up offline and decide what to do (maybe with dglazkov and fishd)
[22:04:31] *** cpu has quit IRC
[22:05:28] <hclam> sounds good
[22:06:00] <jamesr> and just hope there aren't any surprises that the canaries can't catch :)
[22:06:53] <hclam> surprises usually come together, hopefully not this time :)
[22:07:47] <awong> robertshield: okay.  Can I pass off reopening the tree to you then?
[22:08:16] <robertshield> awong: sure, if I don't figure out the official builders thing soon, I'll reopen anyway
[22:09:46] *** hrna has quit IRC
[22:10:19] <awong> robertshield: thanks!
[22:10:27] <awong> btw, have you pinged jam?
[22:10:43] <awong> he might know about the official builder.
[22:11:12] <robertshield> awong: will do, thanks!
[22:13:18] *** up365 has quit IRC
[22:13:46] *** up365 has joined #chromium
[22:16:22] *** willchan_ has joined #chromium
[22:16:22] *** ChanServ sets mode: +v willchan_
[22:18:54] *** senorblanco has joined #chromium
[22:18:55] *** ChanServ sets mode: +v senorblanco
[22:21:16] *** eseidel has joined #chromium
[22:22:18] *** mpcomplete has quit IRC
[22:23:51] *** laranon_ has joined #chromium
[22:24:25] *** abarth has joined #chromium
[22:24:25] *** ChanServ sets mode: +v abarth
[22:24:49] *** laranon has quit IRC
[22:26:39] *** mpcomplete has joined #chromium
[22:26:39] *** ChanServ sets mode: +v mpcomplete
[22:26:41] *** dave_levin has joined #chromium
[22:26:41] *** ChanServ sets mode: +v dave_levin
[22:26:43] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open (Clobber fixed NaCl DEPs roll)
[22:27:29] *** bers has joined #chromium
[22:28:25] *** dantasse has quit IRC
[22:30:23] *** tonyg-cr has joined #chromium
[22:30:23] *** ChanServ sets mode: +v tonyg-cr
[22:30:33] <jrg> rsesek: you aren't going to believe this.  http://codereview.chromium.org/2869017
[22:30:38] <jrg> Sigh.
[22:31:10] <rsesek> jrg: just got that. heh
[22:37:32] *** msneck has joined #chromium
[22:37:32] *** ChanServ sets mode: +v msneck
[22:42:45] *** jrmuizel has joined #chromium
[22:44:57] *** msneck has left #chromium
[22:45:00] <thakis> git checkout trung
[22:45:03] <thakis> all the time
[22:45:07] <thakis> fffff
[22:45:54] *** msneck has joined #chromium
[22:45:54] *** ChanServ sets mode: +v msneck
[22:48:51] *** zaspire has quit IRC
[22:50:36] <nsylvain> Wow, the tree is a lot behind!
[22:50:40] *** ROBOd_ has quit IRC
[22:50:49] *** rickspencer3 has quit IRC
[22:51:05] *** rickspencer3 has joined #chromium
[22:51:25] <awong> nsylvain: had a clobber on windows
[22:52:50] <robertshield> nsylvain: it's the post-tree-reopening-rush
[22:53:58] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open
[22:55:01] *** Beetny has quit IRC
[22:56:55] *** tonikitoo has quit IRC
[23:07:04] *** lnostdal has joined #chromium
[23:07:16] *** monreal has quit IRC
[23:07:36] *** bers has quit IRC
[23:11:14] *** up365 has quit IRC
[23:11:39] *** Zucca has quit IRC
[23:13:05] *** jg has joined #chromium
[23:13:05] <motownavi> mirandac: hey, saw http://code.google.com/p/chromium/issues/detail?id=46710 . Same thing as http://code.google.com/p/chromium/issues/detail?id=47200 ? Perhaps a cross-plat notification issue?
[23:13:37] <prasadt> Is there some way to submit a webkit patch to chromium bots for validation before commit?
[23:13:38] <mirandac> motownavi: yes, I just posted a reply to the bug.  it's a regression, as well...
[23:13:44] <motownavi> ah ok
[23:13:49] *** romainhuet has joined #chromium
[23:14:07] <mirandac> motownavi: I'm going to try to track down where it regressed, hopefully something easy -- overlooking the incognito case, etc.
[23:14:23] *** Zucca has joined #chromium
[23:14:36] <motownavi> Cool. If you've got it that's awesome.
[23:16:44] <mirandac> motownavi: yeah, I'll see if I can figure it out...
[23:17:46] <thakis> mirandac: build/build-bisect.py just in case you haven't heard of it
[23:18:24] <mirandac> thakis: thanks, but not sure it would work in this case -- not an error per se, just a bubble hanging around a little too long :-(
[23:18:36] <thakis> mirandac: yes it would help
[23:18:46] <thakis> helps tracking down anything that's reprocible
[23:19:00] <mirandac> thakis: well, then, I'll check it out.  I was under the impression it was less powerful than it seems to be!
[23:21:00] *** elsenorblanco has joined #chromium
[23:21:08] *** mpavel has quit IRC
[23:22:43] *** senorblanco has quit IRC
[23:24:19] *** thomasvl has quit IRC
[23:25:01] *** eseidel has quit IRC
[23:25:07] *** eseidel has joined #chromium
[23:25:37] *** rickspencer3 has quit IRC
[23:26:02] *** rickspencer3 has joined #chromium
[23:28:18] *** eseidel has quit IRC
[23:28:36] *** up365 has joined #chromium
[23:29:10] *** dglazkov_ has joined #chromium
[23:29:10] *** ChanServ sets mode: +v dglazkov_
[23:30:29] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "XP Tests (dbg)(1)" from 50511: senorblanco at google dot com, sky at chromium dot org)
[23:30:31] <mirandac> PROTIP: build-bisect.py is amazing.  use for all your binary build search purposes!
[23:30:39] <rsesek> :)
[23:31:34] <elsenorblanco> looking (doesn't look like me, but you never know)
[23:32:25] <rohitrao> pkasting: ping
[23:32:33] <pkasting> rohitrao: pong
[23:32:56] <rohitrao> pkasting: can you remind me what the difference is between the first and second passes in HistoryURLProvider?
[23:33:01] <robertshield> scherkus: ping
[23:33:20] <pkasting> rohitrao: The first pass is synchronous, only queries the in-memory DB, and we only use the top result from it
[23:33:27] *** dglazkov has quit IRC
[23:33:27] *** dglazkov_ is now known as dglazkov
[23:33:40] <robertshield> senorblanco: I think it's r50523 unless you have evidence to the contrary :)
[23:33:47] *** kees has joined #chromium
[23:33:55] <pkasting> rohitrao: The second pass is async (main body run on the History thread), queries the full DB, and we use all results from it; in order to avoid weird behavior, the top result should agree with the 1st pass
[23:34:20] <kees> hi! I'm trying to work on the PTRACE-in-Ubuntu-breaks-BreakPad problem.  is anyone here familiar with the crash handler in Chromium?
[23:34:28] <rohitrao> ah, that's why we redo the first pass
[23:34:29] <pkasting> rohitrao: In the world where we use Mike's new search code, assuming it's fast enough to just run synchronously, all that complexity can die, and we can run just one pass
[23:34:44] <elsenorblanco> robertshield: but it failed at 50511?
[23:34:47] <rohitrao> pkasting: and all of this is just doing prefix matches on the url database?
[23:34:50] <pkasting> kees: mmentovai, but he doesn't seem to be around
[23:35:08] <sky__> unit_test failure looks like it might be flake.
[23:35:27] <pkasting> rohitrao: Yes; the in-memory URL database holds only typed URLs, the "main" URL database holds all visited URLs
[23:35:36] <kees> pkasting: ah, okay.  I'm trying to find the signal handler to see how the crashing process stops and waits for the debugger to attach.  /me continues to grep
[23:36:00] <sky__> I think we should reopen.
[23:36:02] <elsenorblanco> sky__: it failed on the same test on two different bots.. kinda suspicious flake :)
[23:36:15] <robertshield> senorblanco: hrmm..  did you go near the extension manifest stuff?
[23:36:19] <sky__> ok
[23:36:20] <rohitrao> pkasting: ok, thanks
[23:36:32] *** eseidel has joined #chromium
[23:36:36] <elsenorblanco> robertshield: nope.  just added a mutex to a skia call.
[23:36:48] <robertshield> ok.. I'm disabling that test and filing a bug
[23:37:11] *** shepazu has joined #chromium
[23:37:59] <sky__> that failure seems to indicate someone removed a file the test relies upon.
[23:39:23] <robertshield> it seems to, but it happens sporadically and the files it needs should all be there
[23:39:55] <sky__> weird
[23:40:39] <robertshield> yeah,  scherkus' recent patch is the only one nearby and that just adds files (doesn't remove them)
[23:41:41] *** andybons has quit IRC
[23:43:37] <sky__> should we reopen the tree if you're going to disable the tests?
[23:43:41] <trungl-bot> Tree opened by robertshield at chromium dot org: Tree is open (disabled crashing extensions manifest test)
[23:43:44] <robertshield> yeah, reopened
[23:43:47] <sky__> :)
[23:44:14] <robertshield> motownavi: willchan: I'm off to commute, see you in a bit
[23:44:20] <motownavi> ok
[23:44:40] <elsenorblanco> failed on linux to
[23:44:41] <elsenorblanco> too
[23:44:42] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Linux Tests (dbg)(2)" from 50511: senorblanco at google dot com, sky at chromium dot org)
[23:45:20] *** Erkan_Yilmaz_ has joined #chromium
[23:45:21] <elsenorblanco> went green on windows tho
[23:45:59] *** evmar_afk is now known as evmar
[23:48:27] *** Erkan_Yilmaz has quit IRC
[23:50:43] *** Wicked has quit IRC
[23:52:33] *** Wicked has joined #chromium
[23:54:51] *** LA2 has joined #chromium
[23:55:49] *** msneck has left #chromium
[23:56:10] <pinkerton> yay, can't link unit tests.
[23:56:27] <pinkerton> what's the magic incantation?
[23:56:36] <LA2> In build 48679 that comes with Ubuntu 10.04, one Ogg Theora file plays out of sync, another plays OK. Both are screencasts created with Recordmydesktop. How can I tell what's different between these two files?
[23:56:44] <rsesek> pinkerton: export GYP_DEFINES="enable_svg=0"; gclient runhooks
[23:56:47] <chase> avi/willchan/robertshield: i have a CL ready to make xp perf (1) moz green
[23:56:54] <pinkerton> rsesek: thx
[23:58:02] <LA2> this one plays OK, created some time back, http://commons.wikimedia.org/wiki/File:Recordmydesktop-svenska.ogv
[23:58:34] 
[23:59:28] *** Erkan_Yilmaz__ has joined #chromium





top