[00:03:17] *** tedoc2000 has joined #chromium
[00:08:04] <jamesr> well hey hey
[00:08:16] <jamesr> the chrome on my mac is pretty wedged
[00:08:22] <jamesr> browser proc is pegged, renderers can't repaint
[00:08:27] <jamesr> any mac weenies want to take a look?
[00:08:42] *** thakis_ has quit IRC
[00:08:48] <jamesr> 6.0.422.0 dev, the browser UI still kinda works
[00:09:32] *** thakis_ has joined #chromium
[00:09:33] *** ChanServ sets mode: +v thakis_
[00:10:41] <dcheng> Hmm. Does anyone know why common.lib would disappear from my output directory, and why VS isn't rebuilding it?
[00:11:08] <dcheng> Oh, there's another error before that.
[00:11:29] <dcheng> Though I wouldn't call it helpful either.
[00:11:30] <willchan> jamesr: i've heard of that bug.  iirc, the solution was to get a Lucid livecd and install that.
[00:11:34] <dcheng> 3>.\Debug\obj\common\resource_dispatcher.obj : fatal error LNK1106: invalid file or disk full: cannot seek to 0x11D75C
[00:12:04] <dcheng> The disk certainly isn't full.
[00:12:19] <dcheng> Well, blowing away that .obj file fixed it. Weird.
[00:12:41] <jamesr> dcheng: i think that's what happens when the linker process runs out of virtual memory
[00:13:13] <dcheng> How likely is the linker to run out of virtual memory space on a 64-bit machine?
[00:13:32] <jamesr> well, if the linker's a 32 bit process
[00:13:50] <jamesr> then fairly likely. it only has 2gb to begin with and windows is poor at allocating within that
[00:17:57] <dcheng> Ah.
[00:18:03] <dcheng> Still, that's dumb.
[00:18:15] *** bweinstein has joined #chromium
[00:19:05] *** remyo has joined #chromium
[00:19:34] <jamesr> it might be something else
[00:19:40] <jamesr> sucks that we keep seeing issues like this
[00:19:47] <remyo> Is there a way to open bookmarks (or bookmarks) with shortcut keys?
[00:19:59] <remyo> (or bookmarklets) I meant
[00:27:10] *** asargent2 has quit IRC
[00:27:29] <trungl-bot> Tree opened by rsesek at chromium dot org: \u2600 Open for business \u2600
[00:29:11] <rsesek> jcivelli, jshin: I'm heading out
[00:29:39] <jshin> rsesek: good evening !
[00:30:01] *** rsesek has quit IRC
[00:36:18] *** General13372 has joined #chromium
[00:37:51] *** remyo has quit IRC
[00:40:42] *** General1337 has quit IRC
[00:43:57] *** Inc has joined #chromium
[00:45:59] *** AaronMT has quit IRC
[00:46:07] *** pathorn has quit IRC
[00:48:25] *** |ifette| has joined #chromium
[00:51:39] *** nth_ has quit IRC
[00:52:24] *** ifette has quit IRC
[00:58:43] *** _rs has quit IRC
[00:59:07] *** mbelshe has joined #chromium
[00:59:08] *** remyo has joined #chromium
[01:00:55] *** pathorn has joined #chromium
[01:03:52] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Linux Builder (ChromiumOS)" from 49466: albertb at chromium dot org, dhg at chromium dot org, evan at chromium dot org (:evmar), jhawkins at chromium dot org)
[01:05:12] <jcivelli> who broke it?
[01:05:22] <mbelshe> distcc[30266] ERROR: compile /home/chrome-bot/.ccache/account_cr.tmp.codf189.30261.ii on codf20.jail.google.com:3633/2 failed chrome/browser/chromeos/login/account_creation_view.cc: In member function 'virtual TabContents* chromeos::AccountCreationDomView::CreateTabContents(Profile*, SiteInstance*)': chrome/browser/chromeos/login/account_creation_view.cc:97: error: cannot allocate an object of abstract type 'chromeos::AccountCreationTabCon
[01:06:06] *** thakis_ has quit IRC
[01:06:10] *** dhg has joined #chromium
[01:06:50] *** yutak_home has joined #chromium
[01:06:50] *** ChanServ sets mode: +v yutak_home
[01:07:39] *** mathrick has joined #chromium
[01:08:18] <mathrick> hi guys, is there any effort to reduce leaks/fragmentation inside individual tabs' processes?
[01:08:56] <mathrick> this is horribly unscientific, but I frequently see things like 150-200M gains when I just close and immediately reopen a tab that's been parent to a long browsing session
[01:09:03] <mathrick> particularly if it included many images
[01:09:26] <dimich> Builder Linux Builder (ChromiumOS) fails 3 Inspector tests, suspect WebKit r60965, working on disabling/creating a bug.
[01:10:36] <jcivelli> jhawkins: bustage is yours
[01:10:40] <jhawkins> yep
[01:10:42] <jhawkins> on it
[01:10:44] <jcivelli> Cool
[01:10:56] <trungl-bot> Tree closed by mbelshe at chromium dot org: Tree is closed (Automatic: "compile" -  jhawkins at chromium dot org)
[01:11:57] <dcheng> mathrick: If there's a real leak and it's reproducible, file a bug at crbug.com?
[01:13:00] *** thakis_ has joined #chromium
[01:13:00] *** ChanServ sets mode: +v thakis_
[01:13:04] <mathrick> dcheng: well, the problem is that it's a behaviour I see after, say, 1h of image browsing, or 1h of a session where I open and close many links in tabs
[01:13:24] <mathrick> it's not something where I can just navigate to a single URL and say "here, it breaks"
[01:13:41] <mathrick> I'm working on synthetic stress test that'd exhibit this now, lesse if I succeed
[01:13:59] <mathrick> if there are any tools in common use with chromium that could help here, it'd be great
[01:15:08] <mathrick> btw, for all I know it might be fragmentation and not "real" leaks, but the end effect is the same -- chromium uses ungodly amounts of memory on some old tabs, whereas closing/reopening the last one in a tree immediately brings it down to reasonable amounts
[01:15:10] *** bradleymeck has quit IRC
[01:16:26] <eglaysher> I've seen something like this. At least on the linux version, if I leave the waterfall on 60-second autoreload, that tab'll grow up to 5 gigs.
[01:16:36] <eglaysher> Never seen it on windows
[01:20:51] <jhawkins> jcivelli: it's probably safe to re-open
[01:20:53] *** dglazkov has quit IRC
[01:21:02] <jhawkins> esp if the chromium os build is going to take 19 minutes
[01:21:28] <mathrick> eglaysher: yup, linux here
[01:25:32] <mathrick> eglaysher: is waterfall something I can access from an URL? Or otherwise is there a concise yet unambiguous way to say what you just said in a bug report?
[01:25:43] <eglaysher> mathrick: build.chromium.org
[01:25:44] <jcivelli> jhawkins: OK reopening
[01:26:06] <eglaysher> if you note the URL it redirects to, it has "waterfall" in the title.
[01:26:17] <mathrick> eglaysher: ahh, so you mean just watching the report with autoreload?
[01:26:26] <eglaysher> yes: http://build.chromium.org/buildbot/waterfall/console?reload=60
[01:26:30] <eglaysher> Reloads every 60 seconds.
[01:26:37] *** bweinstein has quit IRC
[01:26:39] <eglaysher> After two or three days, it grows to 5 gigs.
[01:27:02] <mathrick> okay, I'll see if I can whip up a faster test with images
[01:27:09] <trungl-bot> Tree opened by jcivelli at chromium dot org: Open (Chromium OS should cycle green)
[01:31:13] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49463: albertb at chromium dot org, jhawkins at chromium dot org)
[01:33:12] <jhawkins> grd change, nothing to see here
[01:34:27] *** piman_ has quit IRC
[01:35:41] *** Venom_lnch has quit IRC
[01:35:51] *** piman_ has joined #chromium
[01:35:52] *** gajop has quit IRC
[01:36:08] *** agl has quit IRC
[01:36:31] *** dale1v[away] has quit IRC
[01:36:43] <thakis_> anyone up for an easy review: http://codereview.chromium.org/2795003/show
[01:36:57] <thakis_> helps if you know about plugins (eg piman_ evmar )
[01:38:03] *** zel has left #chromium
[01:39:18] <trungl-bot> Tree closed by jshin at chromium dot org: Tree is closed ("unit_tests" : grd change => waiting for cycle)
[01:41:29] <piman_> thakis_: I'll look at it
[01:41:43] *** fqian has quit IRC
[01:42:46] *** apatrick_ has joined #chromium
[01:45:47] *** dale1v has joined #chromium
[01:46:24] <piman_> thakis_: I guess the default plugin is linked in and we call the default_plugin::NP_* directly, right ?
[01:46:35] <thakis_> piman_: yes
[01:46:41] <piman_> LGTM then
[01:47:55] *** pathorn has quit IRC
[01:49:21] *** gajop has joined #chromium
[01:51:17] *** Kernel-Panic has joined #chromium
[01:52:00] <thakis_> thaks
[01:52:04] <thakis_> thanks, even
[01:53:27] *** greggman has quit IRC
[01:53:58] <thakis_> akalin: so, how do i get gyp to generate makefiles on os x?
[01:54:04] <thakis_> akalin: and why don't they Just Work?
[01:55:33] <jhawkins> jshin: ping
[01:55:47] *** MikeSmithW3C has joined #chromium
[01:56:28] *** nthawEE has joined #chromium
[01:57:48] <jshin> jhawkins: pong
[01:57:55] <pkasting> Rietveld == 500 :(
[01:58:22] <jhawkins> jshin: in your latest commit, you define MAYBE_Test after your first use of MAYBE_Test...so you basically renamed Test to MAYBE_Test for the first use
[01:58:37] <jshin> arg ...
[01:59:30] *** Zucca has quit IRC
[01:59:48] <jshin> touched the wrong test first and forgot to remove MAYBE_ prefix
[02:02:25] *** phed__ has quit IRC
[02:04:57] <estade> I propose that all grd changes be limited to a single hour of the day
[02:05:07] <estade> midnight to 1am preferably
[02:05:10] *** kcbanner has quit IRC
[02:05:35] <trungl-bot> Tree opened by jshin at chromium dot org: Tree is open ("unit_tests/ ui_test/browser_test: grd change => cycling green)
[02:06:32] <jshin> wonder if there is any way to prevent grd changes from turning tree red? well, if there was, we'd have implemented it...
[02:06:40] <dcheng> There's a few bugs for gyp
[02:06:45] <dcheng> They've been open for a long time =)
[02:06:59] <akalin> thakis_: it's hard :(
[02:07:09] <akalin> thakis_: basically xcode handles a lot of stuff automagically, like nib files, etc.
[02:07:15] <dcheng> http://code.google.com/p/gyp/issues/detail?id=42 and http://code.google.com/p/gyp/issues/detail?id=76 are the bugs in question.
[02:07:16] <akalin> i can forward you mentovai's reply to my query if you'd like
[02:07:19] <atwilson> brettw,fishd_: I'm adding some plumbing to allow setting the frame name when opening new windows from the browser process (and also to allow tracking the frame name as passed in for renderer-initiated windows via window.open()).
[02:07:32] <thakis_> akalin: i just discovered that `xcodebuild -target chrome OBJROOT=clang/obj DSTROOT=clang CXX=/Users/thakis/src/llvm/Debug/bin/clang++ CC=/Users/thakis/src/llvm/Debug/bin/clang LINK=echo` more or less does what i want it to
[02:07:35] *** hagabaka has quit IRC
[02:07:40] <thakis_> akalin: but forward anyways; sounds interesting
[02:08:02] <akalin> yeah
[02:08:09] <akalin> the problem is that xcodebuild takes a long time
[02:08:22] <akalin> since it has to calculate the dependencies, etc., which only has to be done once per reload in xcode (since it's persistent)
[02:09:05] <atwilson> The CL is here: http://codereview.chromium.org/2775003 - instead of having RVH::CreateRenderView() take a frame_name parameter, I instead added a GetRenderViewFrameName() API on RenderViewHostDelegate.
[02:09:40] <atwilson> ^^^ brettw fishd: I wasn't sure which was the better way to go, and neither was rafaelw, so I wanted to ping you guys about this.
[02:10:02] <thakis_> akalin: true that, but i'm only trying to play with clang
[02:10:07] <akalin> mmm
[02:10:07] <atwilson> His specific question was: http://codereview.chromium.org/2775003/diff/2001/3007#newcode484
[02:10:14] <jshin> dcheng: thanks for the pointer.
[02:10:33] <akalin> thakis_: why bother, gcc will catch up now that they're moving to C++!!
[02:10:43] <thakis_> akalin: :-D
[02:10:56] <jamesr> not on os x it won't
[02:11:17] <fishd_> atwilson: ok
[02:11:45] *** fishd_ is now known as fishd
[02:12:11] <thakis_> evmar, other git heroes: i patched in your clang patch, and now i'm adding stuff to that. what's the right way to do that? create a branch off the branch with your patch?
[02:12:15] <fishd> atwilson: i don't have any time right now... but that API suggests having to ask the embedder for the name.  why not just push it down upon creationg of the view?
[02:12:16] <thakis_> how do i upload that then?
[02:12:21] *** fishd is now known as fishd|away
[02:12:23] *** Martijnc has quit IRC
[02:12:50] <atwilson> fishd: Meaning make it a param to RVH::CreateRenderView()? Or something else?
[02:13:26] <atwilson> The larger context of this is we need to store information about BackgroundContents so we can restore them on restart (frame name and URL).
[02:13:36] <akalin> yay i'm responsible for #1 dev channel crash
[02:13:38] *** malavv has quit IRC
[02:13:43] <atwilson> So I'm adding plumbing to allow this information to come up from the webkit layer and also get passed back down.
[02:13:52] <thakis_> akalin: aren't you used to that by now?
[02:13:57] <akalin> thakis_: :((
[02:14:02] <akalin> i don't think i've been #1 before
[02:14:03] <thakis_> akalin: we always find a way to blame it on you somehow
[02:14:05] <akalin> just up there
[02:15:28] *** dhg has quit IRC
[02:16:48] *** r00s has joined #chromium
[02:17:00] *** r00s has left #chromium
[02:18:28] <mathrick> eglaysher: okay, so far it doesn't seem to be triggered by just reloading a page with many images, at least not when the images are loaded by JS and the page is very simple
[02:18:51] *** RT|Chatzilla has joined #chromium
[02:19:52] *** jrg has quit IRC
[02:19:58] *** kcbanner has joined #chromium
[02:20:17] *** tonyg-cr has quit IRC
[02:25:06] *** cying has joined #chromium
[02:28:36] *** sbyer_afk has quit IRC
[02:30:02] <tony^work> hmm, I think email from codereview.chromium.org is getting marked as spam
[02:31:35] *** xji has quit IRC
[02:31:51] <jhawkins> tony^work: it frequently does, though not consistently. I have people that set me as reviewers send me code review URLs in gchat
[02:32:34] <jhawkins> and I do the same
[02:33:20] *** hagabaka has joined #chromium
[02:33:26] *** hagabaka has joined #chromium
[02:36:01] *** stevenjb has quit IRC
[02:39:22] *** tedoc2000 has quit IRC
[02:41:52] <hclam> sheriffs: I landed a patch to enable building stuff in the remoting/ folder, if things go wrong please let know, i'll monitor the tree too
[02:42:59] *** jrmuizel has quit IRC
[02:46:56] *** dmaclach has quit IRC
[02:48:45] *** rafaelw1 has joined #chromium
[02:48:47] *** samosa has joined #chromium
[02:48:48] *** tonikitoo has quit IRC
[02:48:52] *** samosa has left #chromium
[02:49:03] *** samosa has joined #chromium
[02:49:07] *** cyy has quit IRC
[02:51:06] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 49482: hclam at chromium dot org, thakis at chromium dot org)
[02:51:17] <hclam> ooops.. looking
[02:51:46] <samosa> you know one thing that annoys me in google chrome?
[02:52:19] <Inc> the lack of themes!
[02:52:26] <Inc> or themes listed in extensions!
[02:52:28] <samosa> no.
[02:52:39] <akalin> it's sheer speed?
[02:52:41] <akalin> its
[02:52:44] <jamesr> poor os x support
[02:52:45] * jamesr ducks
[02:52:50] <akalin> zing
[02:52:58] <samosa> nope
[02:53:17] <akalin> having to restart for a browser update?
[02:53:21] <hclam> I broke the build, see what's wrong
[02:53:26] <hclam> *seeing
[02:53:36] *** ChanServ sets mode: +o thakis
[02:53:46] *** ananta has joined #chromium
[02:54:02] *** ChanServ sets mode: +o thakis_
[02:54:11] <hclam> i can fix it in 10 minutes
[02:54:13] *** jamesr was kicked by thakis_ (zing)
[02:54:20] <akalin> lol
[02:54:21] *** ChanServ sets mode: -o thakis
[02:54:23] *** jamesr has joined #chromium
[02:54:24] *** ChanServ sets mode: -o thakis_
[02:54:41] <jamesr> i now understand why chrome works so poorly on mac
[02:54:47] <thakis_> !!
[02:54:47] <echelog-1> thakis_: Error: "!" is not a valid command.
[02:55:00] <jamesr> !help
[02:55:00] <echelog-1> jamesr: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin.
[02:55:03] <trungl> trigger-happy people?
[02:55:20] <samosa> when you click on a torrent link, it does not give you the option to either open or download, it just downloads torrent by default, unlike firefox which does gives you to open -> (set to be open using utorrent)
[02:55:24] <trungl> so much more helpful than trungl-bot
[02:56:12] <jamesr> samosa: once it's downloading can you just click it in the DL bar? does that do the right thing?
[02:56:52] <samosa> jamesr: it does, but its rather two steps, where in ff its just 1 step.
[02:57:30] <jamesr> a valid point. this is probably in crbug.com somewhere, right?
[02:57:33] <jamesr> go vote it up
[02:57:50] <jcivelli> samosa: you can select "Always open this file type"
[02:58:25] <samosa> jcivelli: where is this?
[02:58:33] <samosa> under*
[02:58:45] *** thakis__ has joined #chromium
[02:58:45] *** ChanServ sets mode: +v thakis__
[02:58:56] <jcivelli> samosa: in the download bar, press the button on the right of the downloaded item, it's in the menu
[02:59:47] *** thakis_ has quit IRC
[03:00:08] *** yutak_home has quit IRC
[03:01:13] <trungl-bot> Tree closed by jcivelli at chromium dot org: Tree is closed (hclam fixing)
[03:01:35] <hclam> fix is submitted, waiting to see the results
[03:02:10] <jcivelli> hclam: good. And you did it with 2 minutes remaining on your clock ;-)
[03:02:24] <hclam> :)
[03:02:30] *** tonikitoo has joined #chromium
[03:04:18] <samosa> oh, wow. that really does work. thanks for that, jcivelli !
[03:04:46] <tony^work> evmar: I think it's ok to just check in svn prop changes to webkit
[03:04:47] *** kliegs has quit IRC
[03:05:45] *** happygrue has joined #chromium
[03:06:35] <samosa> can someone make a chatzilla (chatium?) extension for chrome now? ^^
[03:07:16] <trungl-bot> Tree opened by jcivelli at chromium dot org: Tree is open (linux cycling green)
[03:07:17] <hclam> linux dbg-shlib builds now, hope it can clear linux x64 bot
[03:07:25] <samosa> i know theres a mibbit extension i think, but mibbit is banned on freenode :(
[03:08:23] <samosa> maybe i should ask in chatzilla chan
[03:09:18] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium XP" from 49482: dimich at chromium dot org, estade at chromium dot org, fbarchard at chromium dot org, hclam at chromium dot org, jhawkins at chromium dot org, jshin at chromium dot org, mattm at chromium dot org (:mattm_g), shess at chromium dot org, thakis at chromium dot org, ziadh at chromium dot org)
[03:10:14] <hclam> windows complains the same things as linux but that is fxed
[03:10:28] <hclam> can wait for it to cycle though
[03:10:49] <estade> hclam: meh, i don't think there's a need
[03:10:53] <estade> but either way, update status
[03:10:55] *** magn3ts has joined #chromium
[03:11:19] <hclam> can someone do that for me? Can't access it now..
[03:12:54] <hclam> thanks
[03:12:55] *** jrmuizel has joined #chromium
[03:13:21] <trungl-bot> Tree closed by estade at chromium dot org: Tree is closed (compile fix is in; waiting for cycle)
[03:18:19] *** trungl has quit IRC
[03:18:41] *** remyo has left #chromium
[03:24:38] <mathrick> hmm, is there any way to make chromium open a new *tab* (not window)?
[03:24:53] *** magn3ts has quit IRC
[03:24:59] <akalin> File > New Tab?
[03:25:06] <hclam> ctrl + t
[03:25:06] <mathrick> I mean programmatically
[03:25:19] <hclam> javascript?
[03:25:21] <mathrick> window.open() is fine for a new window, but it's too obnoxious for something running for 15 minutes or more
[03:25:23] <mathrick> hclam: yes
[03:26:23] <mathrick> ie. I've successfully made a testcase to illustrate a memleak caused by opening new windows/tabs, but it's way too annoying to run with new windows taking over the desktop
[03:26:25] *** thakis__ has quit IRC
[03:26:56] <mathrick> I'd be much happier if I could make it just open new tabs in a single window somewhere in a dusty corner
[03:27:37] <hclam> hm.. I actually don't know how to do this in js..
[03:29:36] *** cying has quit IRC
[03:30:58] <mattm_g> mathrick: can you run it under a VM, xnest/Xephyr, etc?
[03:31:36] <mathrick> mattm_g: well, I've run it successfully already, so it's not a problem for me. But I wanted to paste a little bit less obnoxious example into the bug report
[03:32:23] <hclam> windows compilation is clear too
[03:32:27] <hclam> I think we can open the tree now
[03:32:46] *** dale1v has quit IRC
[03:33:04] <samosa> can google chrome view/open .xul files?
[03:33:47] <samosa> jcivelli: you know that "Always open as thing" is there a way to revert back ?
[03:34:27] <mattm_g> mathrick: eh, you could just post it with a disclaimer
[03:37:08] <hclam> can someone open the tree?
[03:37:13] <hclam> I can't access the page now..
[03:37:32] <mathrick> mattm_g: I guess I'll have to do that
[03:38:12] <hayato> Hi, I am sheriff on JST. May I open it now?
[03:38:30] <hclam> I think ajwong is opening it
[03:38:43] <hclam> yup, it's open now
[03:38:47] <trungl-bot> Tree opened by ajwong at chromium dot org: Tree is open
[03:39:51] <hclam> hayato: mac build will complain soon as the bot is running behind, but that should be fixed already
[03:40:31] <hayato> hclam: okay. Thanks.
[03:42:29] *** k-man has joined #chromium
[03:42:32] <k-man> hello
[03:42:59] <k-man> anyone know of a chrome plugin that i can use to save my login for for various sites, but that will not save the pw?
[03:43:27] <akalin> k-man: no, but you may have better luck in the forums listed in the topic
[03:44:11] <samosa> Does anyone know where google chrome keeps its file extension settings?
[03:49:08] <mathrick> okay, should I open a new bug for memory leaks caused by opening new tabs/windows within a single process with a test case, or is there an existing bug that's particularly well-suited for that?
[03:49:26] <mathrick> I can see some, but they're all messy, unclear, or only slightly related
[03:49:47] *** leeight has joined #chromium
[03:49:50] *** leeight has left #chromium
[03:50:18] *** k-man has left #chromium
[03:50:32] *** ojan is now known as ojan_away
[03:50:45] <akalin> what do you mean by memory leaks?
[03:51:28] <mathrick> akalin: do you have logs from 2h40m ago, just after I joined?
[03:51:37] <mathrick> it's described there
[03:51:51] <mathrick> timestamp is 01:08 for me, and it's 03:52 now
[03:51:55] <akalin> ah, i see
[03:52:08] <akalin> may as well, file a new bug, if you have a repro case
[03:52:12] <mathrick> ok
[03:52:36] <mathrick> akalin: should I mention repro in the title, or is that unnecessary?
[03:52:55] <akalin> the repro case fits in the title?
[03:53:01] <akalin> no need, just list it in the body
[03:53:48] <mathrick> gotcha
[03:56:56] *** rafaelw1 has quit IRC
[03:57:06] *** kliegs has joined #chromium
[03:57:54] <pkasting> jshin, jcivelli, jochen__: I am about to commit a change that goofs with .grd files
[03:58:11] <pkasting> jshin, jcivelli, jochen__: I will clobber the Windows builders
[03:58:49] <samosa> is there any chrome extension which can open .xul files?
[03:59:24] *** davemoore has quit IRC
[03:59:29] <maruel> samosa: see topic
[04:00:13] <samosa> Acknowledged.
[04:01:07] *** csilv has left #chromium
[04:03:16] *** hbono has joined #chromium
[04:05:03] *** leeight has joined #chromium
[04:05:13] *** leeight has left #chromium
[04:10:05] *** holdenss has joined #chromium
[04:12:05] <leiz> hclam: I think you broke the build here: http://build.chromium.org/buildbot/waterfall.fyi/builders/Google%20Chrome%20Linux%20x64/builds/1916 ?
[04:13:10] <trungl-bot> Tree opened by thestig at chromium dot org (:leiz): Tree is open (Linux 64 Official -> hclam?)
[04:13:49] <leiz> sheriffs - I gotta run, if my recent check ins are bad, just revert.
[04:14:51] <hayato> leiz: ok
[04:22:00] *** atwilson_ has joined #chromium
[04:22:45] *** atwilson_ has joined #chromium
[04:24:10] *** cying has joined #chromium
[04:25:08] *** leeight has joined #chromium
[04:25:10] *** leeight has left #chromium
[04:26:06] *** dpranke has quit IRC
[04:28:10] *** trungl has joined #chromium
[04:28:10] *** ChanServ sets mode: +v trungl
[04:29:21] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open
[04:30:03] <atwilson_> I'm seeing what seem to be spurious compilation errors on the win trybot (link errors due to missing symbols in sync_listen_notifications). Anyone looking at this? Do we just need a clobber?
[04:32:06] <akalin> atwilson_: i may know what's up -- let me look
[04:32:41] <atwilson_> akalin: Here's an example: http://build.chromium.org/buildbot/try-server/builders/win/builds/35224
[04:34:10] <akalin> atwilson_: may just need a clobber -- the offending change should have been reverted
[04:34:21] <akalin> 49353 was the change, 49357 reverted
[04:34:23] <atwilson_> Agreed.
[04:34:29] <atwilson_> Any clue on how to clobber the trybot?
[04:34:30] <akalin> i don't think it was checked in again after that
[04:34:40] <akalin> git try -c if you're using git
[04:34:50] <akalin> probably a similar switch for gcl or whatever
[04:35:06] <atwilson_> coool
[04:40:35] *** JoJo_CN has joined #chromium
[04:42:01] *** atwilson_ has quit IRC
[04:42:11] *** atwilson_ has joined #chromium
[04:46:20] *** trungl has quit IRC
[04:48:13] *** trungl has joined #chromium
[04:48:14] *** ChanServ sets mode: +v trungl
[04:49:16] *** chrisccoulson has quit IRC
[04:49:44] <pkasting> sheriffs: It looks like the dbg builder decided to ignore my clobber for one iteration, so I suspect som Windows dbg tests are going to go red
[04:49:49] *** magn3ts has joined #chromium
[04:50:21] <pkasting> Please don't back me out if that's the only issue, as hopefully once the dbg builder finally cycles (may take a long time), things will be OK
[04:50:30] <pkasting> I'm going home
[04:50:52] <hayato> pkasting: ok. I'm watching.
[04:52:41] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49489: wtc at chromium dot org)
[04:54:05] *** tfarina has joined #chromium
[04:54:58] <trungl> why, oh why, mr python, does str() insist on ascii?
[04:55:06] *** dumi has joined #chromium
[04:55:26] <akalin> sthurr()
[04:55:41] *** jamesr has quit IRC
[04:59:52] <hayato> wtc, you there?
[05:00:23] *** trungl-bot has quit IRC
[05:00:33] *** trungl-bot has joined #chromium
[05:00:47] *** thakis_ has joined #chromium
[05:00:47] *** ChanServ sets mode: +v thakis_
[05:01:12] <tfarina> I think we need to revert
[05:01:24] <hayato> okay. I'll revert.
[05:01:25] <tfarina> http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests%20(dbg)(1)
[05:02:31] <trungl-bot> Tree closed by hayato at chromium dot org: Tree is closed (Vista unit_tests; reverting)
[05:03:31] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (Vista unit_tests; reverting) [test: \u2264]
[05:03:39] <trungl> trungl-bot: treestatus
[05:03:41] <trungl-bot> trungl: Tree status set by viettrungluu at chromium dot org: Tree is closed (Vista unit_tests; reverting) [test: ?]
[05:03:57] <trungl> excellent
[05:04:23] <thakis_> evmar: http://codereview.chromium.org/2762014/diff/2001/3035 :-)
[05:04:38] <tfarina> trungl: heh :)
[05:04:57] *** trungl-bot has quit IRC
[05:05:05] *** trungl-bot has joined #chromium
[05:05:19] <thakis_> tethering blows my mind
[05:05:43] <trungl> thakis_: how about unicode support?
[05:06:01] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (Vista unit_tests; reverting) [test: ?]
[05:06:11] *** hbono has left #chromium
[05:06:19] <thakis_> trungl: i'm trying to look up a unicode thumbs up symbol, but my tethering connection is too slow
[05:06:25] <thakis_> trungl: thumbs up!
[05:06:59] <trungl> next up: html5
[05:07:12] <trungl> though maybe trungl-bot should skip directly to html6
[05:07:17] *** hbono has joined #chromium
[05:08:03] *** tyoshino_ has quit IRC
[05:08:15] *** atwilson__ has joined #chromium
[05:08:48] <thakis_> why does NSControl's setObjectValue: take an id and not an NSObject?
[05:09:04] <trungl-bot> Tree closed by viettrungluu at chromium dot org (:trungl): Tree is closed (Vista unit_tests; reverting) [test: ????]
[05:09:16] <hayato> I'm reverting 49489
[05:09:37] <trungl> thakis_: is there really a big difference as far as cocoa is concerned?
[05:09:54] <thakis_> trungl: www.unicodesnowmanforyou.com
[05:10:14] <akalin> still waiting until I can run my games on TrunGL
[05:10:30] <thakis_> trungl: autofill_text_fill_mac.mm wants to call -isKindOfClass on the param, which is a method in NSObject. id doesn't have it
[05:10:42] <thakis_> "no in practice, yes in theory" i guess
[05:11:05] *** atwilson_ has quit IRC
[05:11:14] <trungl> thakis_: but does one really care that something is an NSObject or whether it conforms to the NSObject protocol?
[05:11:38] <thakis_> trungl: id doesn't conform to any protocol
[05:11:50] <trungl> I realize that too
[05:12:03] <thakis_> it's an uprising datatype
[05:12:06] <tfarina> hayato: yep.
[05:12:30] <trungl> shuttle arriving soon
[05:12:42] <trungl> "arriving" is so ambiguous
[05:12:44] * trungl shrugs
[05:12:53] * trungl departs stage right.
[05:12:58] <trungl> Or is that stage left.
[05:13:04] * trungl couldn't have been a stage actor.
[05:13:07] *** trungl has quit IRC
[05:14:06] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open (Windows should cycle green)
[05:14:46] *** samosa has quit IRC
[05:16:38] *** Aria has joined #chromium
[05:16:45] *** JoJo_CN has quit IRC
[05:17:13] *** DaBonBon has joined #chromium
[05:17:33] <DaBonBon> now that final version of flash 10.1 is released, any idea when google chrome stable release be updated to integrate it?
[05:20:44] *** _ifette_ has joined #chromium
[05:24:31] *** |ifette| has quit IRC
[05:26:24] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "plugin_tests" on "XP Perf (dbg)" from 49492: pkasting at chromium dot org, thestig at chromium dot org (:leiz), wtc at chromium dot org, zork at chromium dot org)
[05:26:50] *** spenguin[work] has joined #chromium
[05:27:10] <spenguin[work]> hey, is this the channel for the chromium browser?
[05:27:16] <Aria> Dev, yes.
[05:27:22] * Aria points at the topic.
[05:27:24] <DaBonBon> yes, spenguin[work] , but for support, go to #chromium-support
[05:27:39] <spenguin[work]> ok sir, but I think ill be back here ;)
[05:27:54] <tfarina> hayato: another one to revert?
[05:28:59] *** atwilson__ has quit IRC
[05:29:05] *** atwilson_ has joined #chromium
[05:32:01] <hayato> tfarina: pkasting said some Windows dbg tests are going to go red in his change.
[05:33:06] <Inc> to
[05:33:06] <tfarina> hayato: ok
[05:33:23] <hayato> I guess it should cycle green. So I'll open it now.
[05:33:36] *** trungl has joined #chromium
[05:33:36] *** ChanServ sets mode: +v trungl
[05:34:00] <trungl> thakis, thakis_: you still there?
[05:34:17] <thakis_> trungl: maybe
[05:34:28] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open (Wndows should cycle green)
[05:34:30] <trungl> physically but not mentally?
[05:35:11] <trungl> thakis_: I was going to point out that cocoa is always happy to -retain/-release ids, even though that is, strictly speaking, somewhat dubious
[05:35:29] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open (Windows should cycle green)
[05:36:16] <trungl> thus my conclusion is that one can typically assume that ids conform to the NSObject protocol
[05:37:09] <thakis_> trungl: didn't check, but i thought that for raw (id) types, this checking isn't done for compat reasons, and for id<Foo> types, Foo is usually a subtype of the NSObject protocol and hence all works out
[05:37:12] <thakis_> just a guess tho
[05:37:17] *** Inc has left #chromium
[05:38:17] <trungl> I suspect they're still adding plenty of things which just take id
[05:39:06] *** dglazkov has joined #chromium
[05:39:07] *** ChanServ sets mode: +v dglazkov
[05:39:42] *** afval has quit IRC
[05:41:12] *** rolandsteiner has joined #chromium
[05:43:21] *** hbono has quit IRC
[05:45:02] *** leeight has joined #chromium
[05:45:07] *** leeight has left #chromium
[05:45:14] *** holdenss has quit IRC
[05:45:31] *** holdenss has joined #chromium
[05:47:19] * trungl kind of resents it when google.com tries to push Chrome on him.
[05:47:20] *** bweinstein has joined #chromium
[05:47:37] <akalin> beats pushing background images
[05:48:26] <trungl> but then they pulled it, thereby cutting short the useful life of my bing-ifying content script
[05:48:28] *** jrmuizel has quit IRC
[05:48:38] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49495: satorux at chromium dot org, tfarina at chromium dot org)
[05:50:10] *** jrmuizel has joined #chromium
[05:50:22] <thakis_> trungl: you could add another extension that adds a bg image
[05:50:30] <thakis_> trungl: to vindicate your bg image removal extension
[05:51:20] <trungl> thakis_: it started out as a bg image remover ... but then it turned into a logo replacer
[05:51:30] <trungl> I guess I can have it add a bg image too
[05:51:31] <thakis_> trungl: there's one for that already
[05:51:46] <trungl> maybe pull a bg image from bing.com
[05:51:49] <thakis_> trungl: https://chrome.google.com/extensions/detail/nedjejdfkkjgebciefdfofjhmeogiaga
[05:52:22] *** zork has joined #chromium
[05:52:28] <trungl> thakis_: but it won't replace it with the bing logo
[05:53:26] *** magn3ts has quit IRC
[05:53:44] <trungl> biab
[05:54:12] *** trungl has quit IRC
[05:54:32] *** jrmuizel has quit IRC
[05:54:34] *** _ifette_ has quit IRC
[05:55:21] *** trungl has joined #chromium
[05:55:21] *** ChanServ sets mode: +v trungl
[05:57:09] <trungl> now, back to more fun with oauth
[05:57:58] *** hbono has joined #chromium
[05:58:50] <trungl-bot> Tree closed by hayato at chromium dot org: Tree is closed (waiting cycle green)
[06:01:40] *** phanee has quit IRC
[06:02:23] *** thakis_ has quit IRC
[06:03:40] <tfarina> hayato: almost green :)
[06:04:12] *** _ifette_ has joined #chromium
[06:04:18] *** leeight has joined #chromium
[06:04:22] *** leeight has left #chromium
[06:05:05] *** jrmuizel has joined #chromium
[06:05:12] <hayato> okay. I'll open the tree
[06:05:55] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open
[06:11:23] *** DaBonBon has quit IRC
[06:12:07] *** DaBonBon has joined #chromium
[06:18:35] *** Zucca has joined #chromium
[06:18:36] *** Aria has quit IRC
[06:20:17] *** dhollowa_ has quit IRC
[06:22:31] *** fqian has joined #chromium
[06:22:50] *** _ifette_ has quit IRC
[06:23:54] *** fqian has quit IRC
[06:25:21] *** thakis_ has joined #chromium
[06:25:22] *** ChanServ sets mode: +v thakis_
[06:27:20] *** tfarina has quit IRC
[06:27:31] *** MikeSmithW3C has quit IRC
[06:28:23] <trungl> trungl-bot: treestatus
[06:28:24] <trungl-bot> trungl: Tree status set by hayato at chromium dot org: Tree is open
[06:30:00] *** jrmuizel has quit IRC
[06:35:29] *** jrmuizel has joined #chromium
[06:38:50] <trungl> argh, redirects
[06:39:05] <spenguin[work]> is there a parameter to prevent chromium to launch in the same position as earlier
[06:39:20] <dglazkov> trungl-bot: halp
[06:39:20] <trungl-bot> dglazkov: Valid commands (use "halp <command>" for more): bug, commit, commits, cookie, fortune, halp, help, lkgr, offices, time, treestatus, uptime, webkitbug, webkitcommit, webkitcommits, whois. (If you whisper to me, I'll whisper back.)
[06:39:29] <dglazkov> trungl-bot: lkgr
[06:39:30] <trungl-bot> dglazkov: 49484
[06:39:37] *** cedric__ has joined #chromium
[06:39:41] <spenguin[work]> s/to launch/from launch/;
[06:39:43] <dglazkov> trungl-bot: webkitbug
[06:39:44] <trungl-bot> dglazkov: webkitbug takes exactly one argument; try using "halp"
[06:39:58] <dglazkov> trungl-bot: fortune
[06:39:59] <trungl-bot> dglazkov: It's raisins that make Post Raisin Bran so raisiny ...
[06:40:28] <dglazkov> trungl-bot: you need better writers.
[06:40:28] <trungl-bot> dglazkov: Error: "you" is not a valid command.
[06:40:48] <dglazkov> trungl-bot: no, _you_ is not a valid command
[06:40:48] <trungl-bot> dglazkov: Error: "no," is not a valid command.
[06:41:02] <dglazkov> :(
[06:41:39] <trungl> doesn't pass the Turing Test yet
[06:42:23] *** cedricv has quit IRC
[06:43:23] *** cedric__ has quit IRC
[06:45:33] <dglazkov> ha. _I_ don't pass Turing Test yet.
[06:47:07] <zork> dglaskov: fortune
[06:49:41] * thakis_ realizes that trungl is an anagram for Turlng
[06:50:07] <thakis_> coincidence?
[06:50:26] <trungl> must be
[06:50:32] * trungl isn't clever enough for anagrams
[06:51:22] <thakis_> $ c++filt __ZNSsD1Ev
[06:51:22] <thakis_> std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string()
[06:51:24] <thakis_> wot?
[06:51:33] <thakis_> i need to learn how c++ name mangling works one day
[06:52:12] <thakis_> it seems to get around the axioms of compression somehow
[06:56:16] <trungl> thakis_: there's clearly something wrong going on there
[06:57:04] *** glaksmono has joined #chromium
[06:57:09] <glaksmono> anyone here?
[06:59:01] *** Kunalagon has joined #chromium
[07:00:05] <dglazkov> zork: cookie
[07:01:02] <zork> dglazkov: lkgr
[07:02:10] <dglazkov> zork: cookie
[07:02:38] <dglazkov> cookie is a universal answer
[07:02:54] <zork> I'd say your script needs to be updated, but cookies are delicious.
[07:04:53] *** glaksmono_ has joined #chromium
[07:05:48] <trungl> dglazkov: chocolate chip
[07:05:59] *** glaksmono__ has joined #chromium
[07:06:30] <glaksmono__> anyone here???
[07:06:32] *** glaksmono has quit IRC
[07:06:37] *** glaksmono__ is now known as glaksmono
[07:06:38] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed while base.gyp surgery cycles
[07:06:45] <glaksmono> heh?
[07:06:56] * jam2 hi everyone, i just closed the tree to give the tree a break while some surgery of base.gyp goes through
[07:07:02] * jam2 crossing fingers
[07:09:02] *** DaBonBon has quit IRC
[07:09:36] *** glaksmono_ has quit IRC
[07:10:54] *** glaksmono_ has joined #chromium
[07:12:40] *** glaksmono has quit IRC
[07:12:54] *** cying_ has joined #chromium
[07:13:02] *** glaksmono has joined #chromium
[07:13:11] *** cying_ has quit IRC
[07:13:29] <glaksmono> guys
[07:13:35] <glaksmono> how do you enable that dialog box in VS
[07:13:42] <glaksmono> where it's asking if there's something old in the solution?
[07:16:05] *** glaksmono_ has quit IRC
[07:16:17] *** MikeSmithW3C has joined #chromium
[07:16:53] *** dhollowa_ has joined #chromium
[07:16:54] *** glaksmono_ has joined #chromium
[07:17:53] *** dglazkov has quit IRC
[07:18:05] *** glaksmono has quit IRC
[07:18:07] *** glaksmono_ is now known as glaksmono
[07:18:42] *** hagabaka has quit IRC
[07:20:21] <trungl> bloody oauth
[07:20:54] *** bweinstein has quit IRC
[07:25:36] *** Kunalagon has quit IRC
[07:27:11] *** loislo has joined #chromium
[07:34:11] *** glaksmono_ has joined #chromium
[07:35:12] *** glaksmono_ has quit IRC
[07:35:13] *** jrmuizel has quit IRC
[07:35:49] *** glaksmono has quit IRC
[07:37:11] *** jrmuizel has joined #chromium
[07:40:04] <dhollowa_> hmm, should mac builder be idle?
[07:40:04] *** MikeSmithW3C has quit IRC
[07:41:24] *** tonyg-cr has joined #chromium
[07:41:25] *** ChanServ sets mode: +v tonyg-cr
[07:42:25] *** cying has quit IRC
[07:45:46] *** rafaelw1 has joined #chromium
[07:48:43] *** atwilson_ has quit IRC
[07:49:35] * jam2 fail
[07:50:09] <trungl-bot> Tree closed by jam at chromium dot org (:jam2): Tree is closed (reverted, waiting for tree to green)
[07:51:00] *** tonyg-cr has quit IRC
[07:52:02] <dhollowa_> jam2: we really need to wait?
[07:58:01] <jam2> no i can open
[07:58:20] <trungl-bot> Tree opened by jam at chromium dot org (:jam2): Tree is open
[07:58:40] <dhollowa_> jam2: cool, thx.
[07:59:19] *** Waste has joined #chromium
[08:00:39] *** jrmuizel has quit IRC
[08:02:19] *** Zaba has quit IRC
[08:04:32] *** altan has quit IRC
[08:05:02] *** kcbanner has quit IRC
[08:06:19] *** gajop has quit IRC
[08:10:09] *** kphanee has quit IRC
[08:11:52] *** Waste is now known as Malbaratament
[08:13:09] *** Zaba has joined #chromium
[08:13:51] *** Adys has quit IRC
[08:18:22] *** gajop has joined #chromium
[08:19:48] *** kcbanner has joined #chromium
[08:22:35] *** slavka` has joined #chromium
[08:26:49] *** Adys has joined #chromium
[08:28:37] *** rafaelw1 has left #chromium
[08:32:21] *** js2 has quit IRC
[08:51:16] *** Erkan_Yilmaz_ has quit IRC
[08:55:46] *** rolandsteiner has quit IRC
[09:02:03] *** abarth is now known as abarth|zZz
[09:06:51] *** rolandsteiner has joined #chromium
[09:08:52] *** GeekShadow has joined #chromium
[09:15:10] *** thakis_ has quit IRC
[09:15:35] *** plafayette has quit IRC
[09:17:45] *** holdenss has quit IRC
[09:24:40] *** Zaba has quit IRC
[09:28:27] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder" from 49507: tony at chromium dot org (:tony^work))
[09:28:32] <tony^work> crap
[09:28:34] <tony^work> looking
[09:28:37] *** Zaba has joined #chromium
[09:30:52] *** tittiatcoke has joined #chromium
[09:30:52] *** tittiatcoke has quit IRC
[09:30:52] *** tittiatcoke has joined #chromium
[09:35:32] <tony^work> speculative fix checked in
[09:36:30] <trungl-bot> Tree closed by tony at chromium dot org (:tony^work): tree closed (windows compile -> tony testing fix)
[09:44:35] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Modules Mac10.5 (dbg)" from 49508: tony at chromium dot org (:tony^work))
[09:44:50] <tony^work> hmm
[09:45:36] <tony^work> I'm pretty sure net_unittests is not me
[09:45:37] <trungl-bot> Tree opened by tony at chromium dot org (:tony^work): tree is open
[09:47:54] *** ScriptRipper has quit IRC
[09:49:37] *** rubenbb has quit IRC
[09:51:16] *** ager has joined #chromium
[09:53:29] *** thakis_ has joined #chromium
[09:53:29] *** ChanServ sets mode: +v thakis_
[09:53:36] *** ScriptRipper has joined #chromium
[09:56:45] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "update" on "Webkit Builder (dbg)")
[09:57:47] <tony^work> bot is out of space
[09:57:50] <tony^work> I will try to clean it up
[09:59:23] <tony^work> maybe someone beat me to it
[09:59:37] *** thakis_ has quit IRC
[10:18:56] *** leeight has joined #chromium
[10:19:56] *** leeight has left #chromium
[10:24:13] *** ricow has joined #chromium
[10:25:30] *** adiumtestuser has quit IRC
[10:25:43] *** rubenbb has joined #chromium
[10:25:54] *** bauerb has joined #chromium
[10:26:08] <trungl-bot> Tree opened by tony at chromium dot org (:tony^work): tree is open
[10:27:43] *** trungl has quit IRC
[10:28:32] *** glider has joined #chromium
[10:31:12] <trungl-bot> Tree opened by hayato at chromium dot org: Tree is open
[10:36:27] *** adiumtestuser has joined #chromium
[10:38:49] *** leeight has joined #chromium
[10:38:55] *** leeight has left #chromium
[10:39:59] *** thakis_ has joined #chromium
[10:39:59] *** ChanServ sets mode: +v thakis_
[10:40:24] *** ROBOd has joined #chromium
[10:58:44] *** apavlov has joined #chromium
[11:10:20] *** Zaba has quit IRC
[11:15:12] *** BCalvignac has joined #chromium
[11:16:22] *** ScriptRipper has quit IRC
[11:17:22] *** Zaba has joined #chromium
[11:28:31] *** ScriptRipper has joined #chromium
[11:31:55] *** hbono has quit IRC
[11:33:09] *** BCalvignac has quit IRC
[11:41:05] *** phajdan-jr has joined #chromium
[11:41:06] *** ChanServ sets mode: +v phajdan-jr
[11:55:20] *** phajdan-jr is now known as phajdan-jr|afk
[11:55:29] *** c_zahmad has quit IRC
[11:56:02] *** chrisccoulson has joined #chromium
[11:56:23] *** ScriptRipper has quit IRC
[11:56:23] *** ScriptRipper has joined #chromium
[12:01:40] *** slavka` has quit IRC
[12:03:06] *** slavka` has joined #chromium
[12:15:38] *** tav has quit IRC
[12:17:26] <glider> Hi all
[12:17:32] <glider> any sheriffs around here?
[12:18:11] <hayato> glider: hi, I am on sheriff
[12:23:00] <glider> hayato: I am going to roll the new Valgrind binaries that were reverted two days ago. I'll be monitoring the bots and suppress the new warnings if necesary
[12:24:16] <hayato> glider: ok. thanks for letting us know. I'll be watching for a litte too.
[12:29:29] <trungl-bot> Tree opened by glider at chromium dot org: Tree is open (glider testing new Valgrind)
[12:36:22] *** General1337 has joined #chromium
[12:37:06] *** Malbaratament is now known as afval
[12:38:03] *** JoJo_CN has joined #chromium
[12:40:03] *** General13372 has quit IRC
[12:41:52] *** mahemoff has joined #chromium
[12:44:36] *** zloidemon has quit IRC
[12:48:42] *** brianfcoleman has joined #chromium
[12:56:38] *** brianfcoleman has quit IRC
[13:03:03] *** temp01 has quit IRC
[13:03:38] *** temp01 has joined #chromium
[13:10:25] *** shreyas has joined #chromium
[13:10:49] *** nthawEE has quit IRC
[13:14:01] *** slavka`1 has joined #chromium
[13:14:34] *** zloidemon has joined #chromium
[13:15:42] *** slavka` has quit IRC
[13:15:55] *** TabAtkins_ has quit IRC
[13:15:58] *** tittiatcoke has quit IRC
[13:16:12] *** TabAtkins_ has joined #chromium
[13:16:19] *** tittiatcoke has joined #chromium
[13:18:41] *** slavka`1 has quit IRC
[13:21:29] *** slavka` has joined #chromium
[13:21:53] *** zaspire has joined #chromium
[13:22:11] *** nthawEE has joined #chromium
[13:24:25] *** rohitkc has joined #chromium
[13:30:05] <jochen__> good morning chromium
[13:30:05] <trungl-bot> jochen__: Good morning!
[13:30:16] *** rolandsteiner has quit IRC
[13:31:39] *** Zaba has quit IRC
[13:32:07] *** shreyas has quit IRC
[13:32:32] *** tonikitoo has quit IRC
[13:32:58] *** Zaba has joined #chromium
[13:33:22] *** loislo has quit IRC
[13:44:44] *** mahemoff_ has joined #chromium
[13:47:43] *** mahemoff has quit IRC
[13:47:43] *** mahemoff_ is now known as mahemoff
[13:59:05] *** thomasvl has joined #chromium
[13:59:06] *** ChanServ sets mode: +v thomasvl
[13:59:36] *** thomasvl has quit IRC
[14:00:03] *** thomasvl has joined #chromium
[14:00:03] *** ChanServ sets mode: +v thomasvl
[14:01:50] *** tkent has quit IRC
[14:02:34] *** thomasvl has quit IRC
[14:03:12] *** thomasvl has joined #chromium
[14:03:12] *** ChanServ sets mode: +v thomasvl
[14:04:36] *** kcbanner has quit IRC
[14:10:01] *** zloidemon has quit IRC
[14:10:30] *** zloidemon has joined #chromium
[14:10:53] *** tonikitoo has joined #chromium
[14:16:52] *** wjmaclean_ has joined #chromium
[14:19:36] *** kcbanner has joined #chromium
[14:21:23] *** BCalvignac has joined #chromium
[14:26:20] *** coyo|pingout has quit IRC
[14:29:10] *** shreyas has joined #chromium
[14:38:29] *** Beetny has quit IRC
[14:42:53] *** JoJo_CN has quit IRC
[14:49:18] *** slavka` has quit IRC
[14:49:20] *** slavka`1 has joined #chromium
[14:50:10] *** kliegs has quit IRC
[14:59:53] *** nthawEE has quit IRC
[15:05:13] *** coyo has joined #chromium
[15:07:12] *** kliegs has joined #chromium
[15:13:57] *** malavv has joined #chromium
[15:16:30] *** jrmuizel has joined #chromium
[15:17:09] *** shreyas has quit IRC
[15:22:50] *** shreyas has joined #chromium
[15:30:03] *** ubuntujenkins has joined #chromium
[15:32:54] *** jroes has joined #chromium
[15:33:05] *** shreyas has quit IRC
[15:34:42] *** shreyas has joined #chromium
[15:41:37] *** mitzampt has joined #chromium
[15:46:45] *** remyo has joined #chromium
[15:47:16] <remyo> Any readability users here? I'm trying to find a way to activate readability via shortcut key. Any ideas?
[15:49:26] <maruel> remyo: see topic
[15:50:42] <remyo> So no questions related to the chrome browser?
[15:53:34] *** tav has joined #chromium
[15:55:46] *** jrmuizel has quit IRC
[15:57:08] *** GeekShado_ has joined #chromium
[15:57:09] *** tusk has quit IRC
[15:57:29] *** masterov has joined #chromium
[15:57:42] *** tav has quit IRC
[15:59:35] *** mitzampt has quit IRC
[15:59:59] *** tav has joined #chromium
[16:00:03] *** AaronMT has joined #chromium
[16:00:07] *** GeekShadow has quit IRC
[16:02:09] *** masterov_ has joined #chromium
[16:02:20] *** mahemoff_ has joined #chromium
[16:02:23] *** masterov has quit IRC
[16:02:23] *** masterov_ is now known as masterov
[16:03:09] *** rsesek has joined #chromium
[16:03:09] *** ChanServ sets mode: +v rsesek
[16:04:32] *** GeekShad__ has joined #chromium
[16:05:10] *** mahemoff has quit IRC
[16:05:10] *** mahemoff_ is now known as mahemoff
[16:06:51] *** leeight has joined #chromium
[16:06:55] *** leeight has left #chromium
[16:08:33] *** GeekShado_ has quit IRC
[16:11:20] *** jroes has left #chromium
[16:12:25] *** Aria has joined #chromium
[16:12:28] *** tusk has joined #chromium
[16:13:36] *** bradleymeck has joined #chromium
[16:15:09] *** JoJo_CN has joined #chromium
[16:15:33] <maruel> remyo: ask on #chromium-support
[16:15:58] <remyo> Thanks
[16:17:32] *** duffydack has joined #chromium
[16:22:28] *** varc has joined #chromium
[16:27:00] *** apavlov has quit IRC
[16:27:40] *** malavv_ has joined #chromium
[16:27:52] *** malavv_ has quit IRC
[16:27:55] *** remyo has quit IRC
[16:28:06] *** BryanWB has joined #chromium
[16:29:00] <malavv> Sorry to bother but I would have a question on coding convention
[16:29:26] *** remyo has joined #chromium
[16:29:30] <malavv> I wrote an unit test and put mock class definition in an anonymous namespace, should I put method defenition too?
[16:29:45] <malavv> method implementation*
[16:30:01] <rsesek> malavv: in unit tests, I generally put the method impls in with the class declaration
[16:30:13] <rsesek> malavv:  like http://codereview.chromium.org/2781004/show
[16:31:07] <malavv> I see, thansk rsesek
[16:31:37] *** ager has quit IRC
[16:34:51] *** ubuntujenkins has left #chromium
[16:36:57] *** GeekShad__ is now known as GeekShadow
[16:37:04] *** trungl has joined #chromium
[16:37:04] *** ChanServ sets mode: +v trungl
[16:38:04] *** Martijnc has joined #chromium
[16:38:30] <shreyas> how do i convert a string16 to a NSString on the mac
[16:40:04] *** kliegs has quit IRC
[16:40:06] <glider> FIY: I'm restarting the ui_tests on the CrOS bots. There were no recent changes except mine, so we don't lose any information
[16:41:06] *** roc has joined #chromium
[16:42:15] *** hagabaka has joined #chromium
[16:42:15] *** hagabaka has joined #chromium
[16:42:19] <glider> s/IY/YI/
[16:45:34] *** masterov_ has joined #chromium
[16:46:32] <thomasvl> any sheriff around?
[16:46:44] *** masterov_ has quit IRC
[16:47:10] *** jrmuizel has joined #chromium
[16:48:18] <thomasvl> closing tree
[16:49:27] <trungl-bot> Unknown tree status set by thomasvl at chromium dot org: Tree is close Webkit - tvl figuring out what happened (glider testing new Valgrind)
[16:50:03] <glider> thomasvl: is it because of the MAYBE_ tests?
[16:50:16] <glider> thomasvl: I've got the fix
[16:50:23] <thomasvl> glider: no, it's 20+ behind
[16:50:28] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed Webkit - tvl figuring out what happened (glider testing new Valgrind)
[16:50:38] <thomasvl> that we're throwing script errors in a loop
[16:50:45] <thomasvl> s/that/and/
[16:51:09] *** remyo_ has joined #chromium
[16:51:59] <thomasvl> rsesek: jinx
[16:52:09] <rsesek> heh yup
[16:52:34] *** monreal has joined #chromium
[16:54:24] *** remyo has quit IRC
[16:55:11] *** yutak_home has joined #chromium
[16:55:11] *** ChanServ sets mode: +v yutak_home
[16:55:18] <glider> thomasvl: mind if I roll the fix for Windows UI tests?
[16:55:25] <thomasvl> glider: go for it
[16:55:51] *** whesse has quit IRC
[16:58:18] *** Erkan_Yilmaz has joined #chromium
[16:58:26] *** Erkan_Yilmaz has joined #chromium
[16:59:16] *** diegocaro has quit IRC
[17:00:34] *** shreyas has quit IRC
[17:02:06] *** duffydack has quit IRC
[17:04:43] *** varc has left #chromium
[17:05:05] *** remyo_ has quit IRC
[17:05:22] <thomasvl> glider: did you kick a bot to have it go purple?
[17:05:49] *** shreyas has joined #chromium
[17:05:55] <glider> thomasvl: XP Perf? Nope
[17:06:07] <thomasvl> k, looking
[17:06:38] <trungl-bot> Tree closed by thomasvl at chromium dot org: Tree is closed - cycling green (glider testing new Valgrind)
[17:07:08] *** dmaclach has joined #chromium
[17:14:19] *** tittiatcoke has quit IRC
[17:18:44] *** trungl has quit IRC
[17:18:46] *** tittiatcoke has joined #chromium
[17:18:46] *** tittiatcoke has quit IRC
[17:18:46] *** tittiatcoke has joined #chromium
[17:22:55] <trungl-bot> Tree opened by thomasvl at chromium dot org: Tree is open (glider testing new Valgrind)
[17:23:42] *** duffydack has joined #chromium
[17:27:44] *** tonyg-cr has joined #chromium
[17:27:45] *** ChanServ sets mode: +v tonyg-cr
[17:29:54] *** proteus- has joined #chromium
[17:30:37] <proteus-> Should I ask about extension development here, or in #chromium-support?
[17:32:20] *** kinnetica has joined #chromium
[17:34:37] <proteus-> Is there a way to prevent the page in a popup from being "closed" when the user clicks away from the extension?
[17:36:55] *** nthawEE has joined #chromium
[17:42:41] *** BryanWB has quit IRC
[17:43:09] *** glider has quit IRC
[17:44:35] *** urbanape has quit IRC
[17:48:21] *** shreyas has quit IRC
[17:52:06] *** sbyer has joined #chromium
[17:52:14] *** sbyer has quit IRC
[17:52:29] *** dglazkov has joined #chromium
[17:52:30] *** ChanServ sets mode: +v dglazkov
[17:53:26] *** thakis_ has quit IRC
[17:53:48] *** shreyas has joined #chromium
[17:55:33] *** Zaba has quit IRC
[17:55:46] *** cmasone has joined #chromium
[17:56:10] *** trungl has joined #chromium
[17:56:10] *** ChanServ sets mode: +v trungl
[17:58:03] <rsesek> any mac ppl around for a 2-line CL?
[17:58:30] *** sbyer has joined #chromium
[17:58:42] *** Zaba has joined #chromium
[17:59:15] *** dhollowa__ has joined #chromium
[18:01:04] <bauerb> rsesek: i can review your cl
[18:01:09] <rsesek> bauerb: thanks http://codereview.chromium.org/2767012
[18:01:54] <cmasone> if I've just git cl dcommitt'd a CL with the right content but the wrong description, can I do anything about it post-facto?
[18:02:12] <rsesek> cmasone: nope; svn is pretty permanent about commit messages
[18:02:28] <cmasone> awesome.  sigh.
[18:05:31] <dglazkov> good morning, Chromium!
[18:05:32] <trungl-bot> dglazkov: Good morning!
[18:05:44] <dglazkov> hey trungl-bot
[18:06:16] *** mrossetti has joined #chromium
[18:06:16] <dglazkov> I don't mean to hurt your feelings, but a greeting from trungl was more... sincere. It's not you. It's me.
[18:06:32] <trungl> Good morning, dglazkov!
[18:06:40] * dglazkov whoops
[18:06:49] *** bweinstein has joined #chromium
[18:08:04] <trungl> these robot-produced greetings do seem to lack the human touch, for some reason
[18:08:24] <shess> is better than robot-produced beatings.
[18:08:43] *** mrossetti has quit IRC
[18:09:58] <mirandac> next step for trungl-bot: the Turing test!
[18:10:18] <trungl> I thought html5 support was next
[18:10:34] <mirandac> isn't that part of html5?
[18:10:36] <bauerb> I thought making toast was next
[18:10:51] *** mrossetti has joined #chromium
[18:11:07] <trungl> we should hook up the Chrome toaster (which I believe thakis currently has) to trungl-bot
[18:11:16] *** markmentovai has joined #chromium
[18:11:17] *** ChanServ sets mode: +v markmentovai
[18:13:27] <dglazkov> We're building Cylons?!
[18:15:25] *** xji has joined #chromium
[18:16:20] <shess> 28% of the Chrome team _are_ Cylons.
[18:16:55] *** Aria has quit IRC
[18:17:02] *** bauerb has quit IRC
[18:17:24] *** atwilson_ has joined #chromium
[18:20:19] *** GeekShadow has quit IRC
[18:21:05] *** thakis_ has joined #chromium
[18:21:06] *** ChanServ sets mode: +v thakis_
[18:21:39] <trungl> thakis_!
[18:21:47] <thakis_> trungl___________!
[18:22:17] *** urbanape has joined #chromium
[18:24:01] <trungl> thakis_: who are you and what have you done with thakis?
[18:24:16] *** atwilson_ has quit IRC
[18:24:36] *** _ifette_ has joined #chromium
[18:26:37] <thakis_> trungl: i don't know, i guess i forgot to power off his mac pro and/or to /nick thakis_afk on it
[18:28:11] <trungl> or possibly thakis_afk lost his connection and automatically logged himself back in as thakis
[18:29:16] <afval> o_O
[18:29:16] <thakis_> nah, he isn't the type who would do that
[18:30:13] <trungl> yeah, more likely that he just forgot to do something
[18:30:16] <trungl> that slacker
[18:30:20] *** duffydack has quit IRC
[18:33:56] *** duffydack has joined #chromium
[18:34:48] *** stevenjb has joined #chromium
[18:36:27] *** JoJo_CN has quit IRC
[18:36:50] *** qinjia has joined #chromium
[18:37:55] *** mfinkle has left #chromium
[18:41:11] *** pathorn has joined #chromium
[18:42:53] *** bauerb has joined #chromium
[18:45:21] *** Erkan_Yilmaz_ has joined #chromium
[18:47:33] *** GeekShadow has joined #chromium
[18:47:37] *** Erkan_Yilmaz has quit IRC
[18:48:26] *** Venom_X has joined #chromium
[18:51:20] *** maikmerten has joined #chromium
[18:52:04] *** jshin has quit IRC
[18:52:16] *** qinjia has quit IRC
[18:52:31] *** qinjia has joined #chromium
[18:52:55] *** qinjia has quit IRC
[18:53:30] *** csilv has joined #chromium
[18:54:04] *** qinjia has joined #chromium
[18:55:58] *** Erkan_Yilmaz_ is now known as Erkan_Yilmaz
[18:56:00] *** Erkan_Yilmaz has joined #chromium
[18:56:06] *** tittiatcoke has quit IRC
[18:56:45] *** qinjia has quit IRC
[18:57:20] *** qinjia has joined #chromium
[18:57:56] *** urbanape has quit IRC
[19:00:13] <csilv> ls
[19:04:03] *** wtc has joined #chromium
[19:04:50] *** dhollowa__ has joined #chromium
[19:05:23] *** joshia has quit IRC
[19:07:31] *** mahemoff has quit IRC
[19:08:56] *** joshia has joined #chromium
[19:11:16] *** qinjia has quit IRC
[19:12:13] <shreyas> in the WebFrame::selectionAsMarkup() the HTML of only the selected text is returned, is there a method to get the HTML off the whole page????
[19:14:12] *** inferno-sec has quit IRC
[19:14:12] <thakis_> csilv: all.sh			file.pp.bc		file.pp.mm.ok		multidelta.log		test.in
[19:14:20] *** inferno-sec has joined #chromium
[19:14:21] <thakis_> crash.mm		file.pp.ll		file.pp.o		orig			test1.sh
[19:14:24] <thakis_> crash.mm.bak		file.pp.mm		file.pp.s		out.llvm
[19:14:33] <thakis_> crash.mm.ok		file.pp.mm.bak		log			out_visible.llvm
[19:15:17] *** dhollowa__ has quit IRC
[19:15:28] <csilv> i knew someone had to point out my slip...
[19:19:43] *** lianj_ has joined #chromium
[19:22:55] *** lianj has quit IRC
[19:32:19] *** eseidel has joined #chromium
[19:33:51] <thakis_> evmar: did you have any cases of clang complaining about `if (foo) ;  // do nothing`? what's the workaround? `if foo() { /* do nothing */ }`?
[19:34:23] *** urbanape has joined #chromium
[19:34:34] *** darwin has quit IRC
[19:34:40] *** Kernel-Panic has quit IRC
[19:34:47] *** slavka` has joined #chromium
[19:35:20] *** Kernel-Panic has joined #chromium
[19:36:05] *** slavka`1 has quit IRC
[19:37:12] *** dabear has quit IRC
[19:45:35] <eglaysher> thakis_: people should be using {} instead of ; anyway due to style guide issues.
[19:46:48] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49540: wtc at chromium dot org)
[19:47:04] *** bauerb has quit IRC
[19:49:34] <thakis_> estade: kthx
[19:49:40] <thakis_> eglaysher: kthx i mean
[19:49:49] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open
[19:49:59] <wtc> I tested my CL on try bots twice.
[19:50:08] <nsylvain> i blame flakiness
[19:50:39] *** eseidel has quit IRC
[19:51:51] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open - reliability will go down for a quick reboot
[19:52:43] *** asargent2 has joined #chromium
[19:52:52] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open - reliability will go down for a reboot
[19:53:22] *** eseidel has joined #chromium
[19:54:09] <asargent2> heads up to sheriffs - I just commited a CL with changes to a .grd file
[19:55:07] *** |ifette| has joined #chromium
[19:56:54] *** deshantm_web has joined #chromium
[19:57:16] *** skerner has joined #chromium
[19:58:16] *** _ifette3 has joined #chromium
[19:58:29] *** _ifette_ has quit IRC
[19:59:09] *** abarth|zZz is now known as abarth
[20:01:32] *** |ifette| has quit IRC
[20:02:49] *** dglazkov has quit IRC
[20:04:19] *** roc has quit IRC
[20:05:00] *** kcbanner has quit IRC
[20:07:16] *** RT|Chatzilla has quit IRC
[20:08:19] <jcivelli> Does anybody know the best way to create a FilePath from a WebString?
[20:10:45] *** willchan-macbook has joined #chromium
[20:11:12] <willchan-macbook> who can tell me how to get the client_id of a chrome user?
[20:11:48] <inferno-sec> can anyone help to commit my webkit security patch
[20:13:41] *** Zaba has quit IRC
[20:13:55] *** dhollowa__ has joined #chromium
[20:15:10] <chase> willchan-macbook: Local State file?
[20:15:35] <willchan-macbook> chase: it's in there?  ok, great, thanks!
[20:16:00] *** rafaelw1 has joined #chromium
[20:16:11] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open
[20:17:08] *** dhollowa__ has quit IRC
[20:17:43] *** rafaelw1 has quit IRC
[20:18:11] *** rafaelw1 has joined #chromium
[20:19:14] *** jshin has joined #chromium
[20:19:15] <thakis_> markmentovai: can i send you a patch?
[20:19:36] <markmentovai> NO!
[20:19:37] <markmentovai> ok
[20:19:43] <markmentovai> patch me
[20:19:55] *** kcbanner has joined #chromium
[20:20:19] <mirandac> anyone up for a pure code removal patch? ripping all traces of "import home page" out of the importer code...
[20:24:07] <thakis_> markmentovai: http://codereview.chromium.org/2730015
[20:24:15] *** Zaba has joined #chromium
[20:24:34] <rsesek> thakis_: is my unit test cl still lg?
[20:25:14] <thakis_> let me give it another quick look
[20:25:16] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49548: boliu at chromium dot org)
[20:28:26] *** dave_levin has joined #chromium
[20:28:38] *** Zaba has quit IRC
[20:29:32] *** Zaba has joined #chromium
[20:29:39] <thakis_> rsesek: lg i guess. i find at() weird, but i suppose it looks nicer with pointers
[20:29:39] <thakis_> (and yeah, it does range checking, but meh)
[20:30:32] <rsesek> thakis_: what's weird about at()?
[20:30:48] <thakis_> rsesek: i find operator[] more natural
[20:31:10] <rsesek> yes. but like you said (*v)[i] is even uglier than v->at()
[20:31:31] *** shreyas has quit IRC
[20:31:39] <nsylvain> anyone knows about the failure?
[20:31:43] <nsylvain> boliu?
[20:32:19] <rsesek> nsylvain: asargent submitted a grd change
[20:32:35] <nsylvain> will try a clobber
[20:32:49] <rsesek> nsylvain: there's 2 cls after it, so it should take care of itself
[20:33:02] <nsylvain> ok
[20:33:22] <trungl-bot> Tree closed by nsylvain at chromium dot org: Tree is closed - unit tests -> grd?
[20:34:23] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open - Will monitor unit tests, most likely needs a cycle due to grd change
[20:37:42] *** Kunalagon has joined #chromium
[20:37:56] *** |ifette| has joined #chromium
[20:39:26] *** fqian has joined #chromium
[20:40:48] *** _ifette3 has quit IRC
[20:41:17] *** apatrick_ has left #chromium
[20:42:20] <thakis_> markmentovai: time to talk about const NSString*?
[20:42:21] <thakis_> *do you have?
[20:42:30] <markmentovai> thakis_: let's talk about that when i'm done reviewing this
[20:42:38] <thakis_> markmentovai: ok
[20:42:39] <markmentovai> i'm eager to talk about the more contentious things you found
[20:43:14] <thakis_> the current cl should be harmless
[20:43:14] <thakis_> i hope
[20:43:20] *** dglazkov has joined #chromium
[20:43:22] *** ChanServ sets mode: +v dglazkov
[20:43:25] <markmentovai> have you tested it with gcc-4.2?
[20:43:35] <markmentovai> or entrusted the trybots with the task?
[20:43:58] <thakis_> i compiled with xcode. the try bots will run eventually, but they take their time these days
[20:44:09] <markmentovai> mhm
[20:44:39] *** duffydack has quit IRC
[20:45:05] <markmentovai> i like that this has overall resulted in more minuses than pluses
[20:45:59] *** duffydack has joined #chromium
[20:46:52] *** dale1v has joined #chromium
[20:47:28] <thakis_> i like how it fixes a potential crasher
[20:47:29] *** maikmerten has quit IRC
[20:47:54] <markmentovai> although all of the fixes are technically "better," there are a couple that fix pure crap
[20:47:55] <markmentovai> i like that
[20:48:31] <markmentovai> the ?extern? thing threw me for a sec until i realized that the declaration lives in the header and it?s keeping its extern.
[20:49:02] <markmentovai> so what?s the story with NSString*?
[20:49:23] <thakis_> so
[20:49:36] <markmentovai> don?t start with ?so.? start again.
[20:49:36] <thakis_> all the cocoa apis take NSString*
[20:49:50] <markmentovai> that?s better :)
[20:50:01] <thakis_> which means it's wrong to pass a const NSString*
[20:50:16] <thakis_> ok
[20:50:19] <thakis_> all the cocoa apis take NSString*
[20:50:26] <thakis_> hich means it's wrong to pass a const NSString*
[20:50:27] <markmentovai> thank you
[20:50:27] <thakis_> *which
[20:50:37] <thakis_> we do `const NSString* foo = @"foo";` in quite a lot of places
[20:50:38] <thakis_> and then clang complains when we pass this to cocoa
[20:50:49] <markmentovai> i see why this is contentious
[20:50:50] <markmentovai> :(
[20:50:53] <thakis_> it's a quirk in the language that nsstring literals aren't const, but that's the way it is
[20:51:00] <thakis_> i spoke with chris lattner about this yesterday
[20:51:26] <markmentovai> nsstring literals aren?t? -fconstant-cfstrings?
[20:51:40] <rsesek> FWIW, Apple specifies string constants in AppKit as extern NSString* const kYourMom
[20:51:40] <thakis_> he says that constness in objc is done by having immutable classes and mutalbe subclasses
[20:51:40] <thakis_> and he'd just make all our strings nonconst
[20:52:08] <thakis_> NSString * const foo != NSString const * foo == const NSString* foo
[20:52:15] *** ojan_away is now known as ojan
[20:52:15] <thakis_> rsesek: that means const pointer, not const value
[20:52:26] <rsesek> thakis_: I'm aware. but that's what Apple does
[20:52:57] <markmentovai> right right
[20:53:50] <thakis_> i think all our const NSStrings need to become NSStrings
[20:54:35] <thakis_> since they're immutable anyway, it's not really less save
[20:55:15] <markmentovai> are we using -fconstant-cfstrings now?
[20:55:33] <markmentovai> hm, maybe not, i thought we were
[20:55:49] <thakis_> we aren't
[20:56:22] <markmentovai> with -fconstant-cfstrings, extern const NSString* should be an error even to gcc
[20:56:45] *** Venom_X has quit IRC
[20:56:46] <markmentovai> ok
[20:57:00] <markmentovai> we're bound a bit by how apple's designed this
[20:57:16] <markmentovai> i agree with you
[20:58:13] <thakis_> hooray
[20:58:57] *** arv has joined #chromium
[20:58:57] <thakis_> markmentovai: what exactly does -fconstant-cfstrings do? NSString* a = @"asf" still compiles with that option
[20:59:40] <trungl-bot> Tree opened by nsylvain at chromium dot org: Tree is open
[21:00:07] *** maikmerten has joined #chromium
[21:00:25] *** RobWork has quit IRC
[21:00:55] <markmentovai> oh, you know what, i'm wrong
[21:00:57] <markmentovai> it is the default
[21:00:59] <markmentovai> so we are using it
[21:01:11] <markmentovai> my test was flawed
[21:01:21] <markmentovai> with -fconstant-cfstrings
[21:01:22] <thakis_> still not sure what it does
[21:01:35] <markmentovai> CFSTR() and @"" become a different underlying class
[21:01:42] <markmentovai> that?s fully compatible with NSString* and CFStringRef
[21:01:51] <markmentovai> but the entirety of the object is compiler-generated
[21:02:06] <thakis_> advantage?
[21:02:22] <markmentovai> as opposed to becoming an object of the ?normal? immutable NSString and CFStringRef
[21:02:38] <markmentovai> refcounting ops are no-op
[21:02:44] <thakis_> ah
[21:02:50] *** Venom_X has joined #chromium
[21:02:57] <markmentovai> they shouldn?t be deallocable in any event
[21:02:57] <thakis_> markmentovai: possibly contentious issue 2:
[21:03:09] <markmentovai> these guys can guarantee that
[21:03:58] *** _ifette_ has joined #chromium
[21:04:05] *** tonyg-cr has quit IRC
[21:04:05] <thakis_> we use @properties with a custom setter in a few places
[21:05:27] *** Venom_X_ has joined #chromium
[21:06:06] <thakis_> clang complains that this conflicts with the @property, the reason being that the property isn't declared nonatomic and the setter doesn't do synchronization
[21:06:27] <thakis_> (which is a bug)
[21:06:49] <thakis_> i think _all_ our properties should be nonatomic
[21:07:06] <markmentovai> i think so too, but i haven?t evaluated them all
[21:07:11] <markmentovai> i?d be VERY surprised if we needed an atomic one
[21:07:19] <thakis_> this allows custom setters/getters without any hassle, and synchronized getters/setters don't buy us anything anyway
[21:07:25] <markmentovai> right
[21:07:25] <thakis_> it's also a rule that's easy to understand
[21:07:25] <thakis_> markmentovai: ^ hooray?
[21:07:30] <markmentovai> i think so
[21:07:31] *** |ifette| has quit IRC
[21:09:27] *** Venom_X has quit IRC
[21:09:27] *** Venom_X_ is now known as Venom_X
[21:16:31] <rsesek> thakis: when I build with 10.5 and I use ASSERT_TRUE(image.allocPixels()) I get 'Conversion from 'void' to non-scalar type 'SkBitmap' requested', but not when i build with 10.6 sdk
[21:17:12] *** hagebake has joined #chromium
[21:17:12] *** hagebake has joined #chromium
[21:17:45] *** hagabaka has quit IRC
[21:19:21] <rsesek> thakis_: ^
[21:20:16] <thakis_> rsesek: huh. why?
[21:20:21] <rsesek> thakis_: I have no idea
[21:20:30] <thakis_> what's the return type of allocPixels()? not bool?
[21:20:33] <rsesek> bool
[21:20:52] <rsesek> I think it's talking about the function MakeImage() would return void from the assert, but the return type is SkBitmap
[21:20:54] <rsesek> but I still dont' get it
[21:20:56] *** abarth has quit IRC
[21:21:05] <rsesek> the assert should *assert* not return void
[21:21:10] *** asargent2 has left #chromium
[21:23:32] <rsesek> thakis_: in fact, I'm sure that's it
[21:23:41] <rsesek> you can't ASSERT out of a non-test function apparenlty
[21:24:54] *** glider has joined #chromium
[21:24:54] <thakis_> ah, i guess that kinda makes sense
[21:24:55] <estade> rsesek: right, you have to wrap the function call if you want to be able to do that
[21:24:55] <thakis_> afk, need to run and switch sessions
[21:24:59] *** jamesr has joined #chromium
[21:25:13] <rsesek> estade: can you elaborate?
[21:25:17] <rsesek> oh
[21:25:22] <estade> rsesek: i'm looking for the syntax
[21:26:02] <estade> ASSERT_NO_FATAL_FAILURE(Foo())
[21:26:51] *** Peter- has quit IRC
[21:27:12] *** Peter- has joined #chromium
[21:27:46] <estade> rsesek: now that I actually read more of what you wrote, I'm not sure what I just said is helpful
[21:28:48] *** Ruetobas has quit IRC
[21:29:29] <rsesek> estade: yea I don't think that will work :/
[21:29:57] *** thakis_ has quit IRC
[21:30:36] <estade> rsesek: so you can't assert out of non-void functions (not non-test functions)
[21:30:54] <rsesek> estade: that appears to be the case
[21:31:39] *** Ruetobas has joined #chromium
[21:32:25] *** rafaelw1 has quit IRC
[21:33:57] *** tonyg-cr has joined #chromium
[21:33:58] *** ChanServ sets mode: +v tonyg-cr
[21:34:01] <inferno-sec> a#Aoscmu6486
[21:34:22] <inferno-sec> ignore my bad chars
[21:37:25] *** tittiatcoke has joined #chromium
[21:39:07] <inferno-sec> while packing stuff, hitting keyboard, sorry about it
[21:40:39] *** RobWork has joined #chromium
[21:41:59] *** _ifette_ has quit IRC
[21:42:11] *** _ifette_ has joined #chromium
[21:45:33] *** inferno-sec has quit IRC
[21:45:40] *** inferno-sec has joined #chromium
[21:46:13] *** tittiatcoke has quit IRC
[21:46:27] *** tittiatcoke has joined #chromium
[21:46:27] *** tittiatcoke has quit IRC
[21:46:27] *** tittiatcoke has joined #chromium
[21:47:26] *** phajdan-jr|afk has quit IRC
[21:49:54] <malavv> Network related question: Are UrlHttpjob only called on the IO thread?
[21:49:55] *** jetienne has joined #chromium
[21:51:14] *** chrisccoulson has quit IRC
[21:56:33] <rsesek> I keep hitting a check in PassiveLogCollector::SourceTracker::AdjustReferenceCountForSource() in my dbg build
[21:56:37] <rsesek> anyone know anything about that?
[21:58:26] *** RobWork has quit IRC
[21:58:58] *** RobWork has joined #chromium
[21:59:04] *** _ifette_ has quit IRC
[21:59:16] *** _ifette_ has joined #chromium
[22:00:20] *** RobWork has quit IRC
[22:00:52] *** RobWork has joined #chromium
[22:01:19] *** Beetny has joined #chromium
[22:02:05] *** chrisccoulson has joined #chromium
[22:04:52] *** kwaters has joined #chromium
[22:05:11] <kwaters> maruel: Are you around?
[22:05:42] *** rafaelw1 has joined #chromium
[22:06:32] <csilv> sheriffs, submitted 49580, renable two disabled tests that were problematic in 2009.  think they may be fine now, but i'm watching the tree closely.
[22:07:02] <maruel> kwaters: pong
[22:07:27] <kwaters> maruel: http://codereview.chromium.org/2786013/show breaks ChromeOS
[22:07:35] <maruel> malavv: you can put an assert in the constructor to figure out
[22:07:36] <kwaters> can you make it so https:// maps to svn, and/or revert that change
[22:07:57] <maruel> kwaters: oops, let me revert
[22:09:27] *** thakis_ has joined #chromium
[22:09:27] *** ChanServ sets mode: +v thakis_
[22:10:25] *** tedoc2000 has joined #chromium
[22:11:33] *** RobWork has quit IRC
[22:12:08] *** RobWork has joined #chromium
[22:17:07] *** _ifette_ has quit IRC
[22:17:20] *** _ifette_ has joined #chromium
[22:17:22] *** dglazkov has quit IRC
[22:17:24] *** nirnimesh has quit IRC
[22:17:28] *** dglazkov has joined #chromium
[22:17:28] *** ChanServ sets mode: +v dglazkov
[22:19:40] *** duffydack has left #chromium
[22:20:00] <rsesek> eroman: I keep hitting a CHECK in net/passive_log_collector.cc(240)] Check failed: info.reference_count + offset >= 0 (-1 vs. 0). ideas?
[22:20:24] *** BryanWB has joined #chromium
[22:25:51] *** caac has joined #chromium
[22:26:51] <caac> hey everyone, will Chrome change the bookmark icon to the right and leave out "http://"?
[22:27:52] <sky__> rsesek: eroman is looking into it.
[22:27:55] <sky__> I filed a bug on it a while back
[22:28:33] <rsesek> sky__: cool. is there any way to mitigate in the meantime? I can't debug what I need to atm
[22:28:48] <sky__> no idea.
[22:28:49] *** kwaters has left #chromium
[22:34:10] *** BryanWB has quit IRC
[22:34:28] *** eseidel has quit IRC
[22:34:50] *** gajop has left #chromium
[22:37:17] *** ROBOd has quit IRC
[22:38:18] <inferno-sec> can anyone help to commit my webkit patch
[22:38:34] *** dale1v is now known as dale1v[away]
[22:39:08] <inferno-sec> usually i ask the webkit sheriff, but hamaji is not around
[22:39:41] <jhawkins> inferno-sec: help to commit? is it set to r+?
[22:39:49] <inferno-sec> yes
[22:40:56] *** eglaysher has quit IRC
[22:41:13] <inferno-sec> jhawkins: https://bugs.webkit.org/show_bug.cgi?id=40031
[22:41:57] <jhawkins> inferno-sec: tell dhyatt on #webkit you don't have commit bit and ask him to cq+ the CL
[22:42:09] <jhawkins> I don't have r+bit, so I can't set it
[22:42:17] <inferno-sec> security bugs can't go to commit queue :(
[22:42:23] <jhawkins> ah, didn't know
[22:42:26] <inferno-sec> there is r+ already there, i need to get the commit
[22:42:40] <inferno-sec> sorry i mean manual commit the fix
[22:43:11] <jhawkins> lemme see if I can land it
[22:43:14] *** eseidel has joined #chromium
[22:43:21] <inferno-sec> thanks a lot James
[22:44:32] <jhawkins> np
[22:45:19] *** thakis__ has joined #chromium
[22:45:19] *** ChanServ sets mode: +v thakis__
[22:45:47] *** thakis has quit IRC
[22:45:48] *** thakis__ is now known as thakis
[22:46:19] *** _ifette_ has quit IRC
[22:46:49] *** estade has quit IRC
[22:47:00] *** dale1v[away] is now known as dale1v
[22:47:01] <jhawkins> inferno-sec: waiting for b.wk.org to go green
[22:47:12] <inferno-sec> ok
[22:48:36] *** thakis_ has quit IRC
[22:49:09] *** estade has joined #chromium
[22:49:10] *** ChanServ sets mode: +v estade
[22:49:36] *** deshantm_web has quit IRC
[22:52:10] <trungl_away> trungl-bot: 'afternoon
[22:52:11] <trungl-bot> trungl_away: Error: "'afternoon" is not a valid command.
[22:52:19] <trungl_away> Good afternoon, trungl-bot.
[22:52:19] <trungl-bot> trungl_away: Good afternoon.
[22:52:32] <trungl_away> ok, trungl-bot is taking off for the weekend, so to speak.
[22:52:53] *** trungl-bot has quit IRC
[22:55:25] *** zaspire has quit IRC
[23:00:07] *** willchan-macbook has quit IRC
[23:01:40] *** Kunalagon has quit IRC
[23:02:03] <brettw> Anybody have suggestions about what to do about all the scons and mk files appearing in svn status?
[23:02:28] <thomasvl> brettw: svn:ignore
[23:02:47] <thomasvl> i've been adding info for msvc and xcode, but i don't know all the magic bits for scons/mk
[23:02:50] *** rafaelw1 has quit IRC
[23:03:13] <brettw> thomasvl, can you point me to an example of what you did for xcode?
[23:03:51] *** Adys has quit IRC
[23:04:07] *** wjmaclean_ has quit IRC
[23:04:13] *** Adys has joined #chromium
[23:04:15] <thomasvl> brettw: http://src.chromium.org/viewvc/chrome?view=rev&revision=49579
[23:05:38] <thomasvl> brettw: i'm trying to find the email
[23:06:01] <brettw> thomasvl, so we set these properties in the directory in which the file appears, right?
[23:06:16] <thomasvl> y
[23:07:03] *** tittiatcoke has quit IRC
[23:07:18] <thomasvl> brettw: sent directly to you
[23:07:38] <brettw> thx
[23:07:48] *** dpranke has joined #chromium
[23:07:48] *** ChanServ sets mode: +v dpranke
[23:08:49] <brettw> thomasvl, woot, I will do some of these and send the review to you
[23:09:13] <thomasvl> k
[23:12:16] <sbyer> sheriffs: something got cross-wired in my commit, reverting.
[23:12:19] *** glider_ has joined #chromium
[23:15:14] *** tonyg-cr has quit IRC
[23:15:25] *** robarnold has quit IRC
[23:15:30] *** glider_ has left #chromium
[23:15:53] *** glider has quit IRC
[23:17:31] *** xji has quit IRC
[23:19:42] *** robarnold has joined #chromium
[23:20:02] *** maikmerten has quit IRC
[23:20:05] *** tonyg-cr has joined #chromium
[23:20:05] *** ChanServ sets mode: +v tonyg-cr
[23:21:08] *** willchan-macbook has joined #chromium
[23:21:28] <jam2> sheriffs: i want to check in http://codereview.chromium.org/2767010/show, which changes how base is built in order to support binaries that depend on -fpic
[23:21:48] <jam2> trybots are green, but i want ot close the tree while doing this since i did see some strange errors on some linux buildbots when i did it
[23:21:52] <jam2> can i try this now?
[23:22:25] <jam2> nsylvain, mbelshe ping
[23:23:31] *** dale1v is now known as dale1v[away]
[23:23:45] *** kinnetica has quit IRC
[23:24:17] *** rafaelw1 has joined #chromium
[23:27:19] *** xji has joined #chromium
[23:27:55] *** willchan-macbook has quit IRC
[23:28:19] <brettw> thomasvl, how do I upload this prop change, it gives me an error?
[23:28:23] <brettw> or should I just submit?
[23:28:43] <thomasvl> brettw: i do a svn diff and capture the output, then manually send out an email for review.
[23:28:57] <thomasvl> (see that groups link i sent you)
[23:29:14] <thomasvl> that way someone can sanity check it before i commit it.
[23:29:29] <thomasvl> you could also past the diff into an email on codereview if you wanted
[23:29:36] *** General13372 has joined #chromium
[23:29:39] <brettw> I'll just do manual mail
[23:30:29] * jam2 closed the tree
[23:31:17] <nsylvain> jam2: pong
[23:31:44] <jam2> nsylvain: i just closed the tree, hopefully it'll be quick
[23:31:51] <nsylvain> sounds good
[23:31:53] <jam2> nsylvain: i'm monitoring the tree
[23:31:57] *** xiyuan has left #chromium
[23:32:01] *** caac has quit IRC
[23:32:03] <jam2> (this is blocking next dev channel build)
[23:33:26] *** General1337 has quit IRC
[23:33:36] *** dale1v[away] is now known as dale1v
[23:34:12] *** robarnold has quit IRC
[23:35:36] *** Venom_X has quit IRC
[23:37:25] *** tonikitoo has quit IRC
[23:38:20] *** robarnold has joined #chromium
[23:38:23] *** mirandac has quit IRC
[23:38:29] *** feldstein has quit IRC
[23:39:10] *** tedoc2000 has quit IRC
[23:41:51] *** monreal has quit IRC
[23:41:52] *** slavka` has quit IRC
[23:42:15] <nsylvain> jam2: you saw the failure?
[23:42:27] <jam2> nsylvain: yes, but i can't reproduce
[23:42:29] *** tonyg-cr has quit IRC
[23:42:36] <jam2> nsylvain: i'm going to try to clobber it and see
[23:42:41] *** inferno-sec has quit IRC
[23:42:42] <nsylvain> ok
[23:42:47] <nsylvain> ping me if you need help
[23:43:54] <jam2> thanks will do
[23:44:40] *** inferno-sec has joined #chromium
[23:46:00] <jam2> nsylvain: i can't load the internal buildbot page iwth the clobber link
[23:46:27] <jam2> for Chromium Linux Builder (dbg-shlib)
[23:46:41] <nsylvain> see im
[23:46:44] *** thakis_ has joined #chromium
[23:46:45] *** ChanServ sets mode: +v thakis_
[23:46:53] *** thakis has quit IRC
[23:46:53] *** thakis_ is now known as thakis
[23:51:12] *** jrmuizel has quit IRC
[23:51:23] *** earyoyo has quit IRC
[23:51:32] *** Martijnc has quit IRC
[23:51:49] *** earyoyo has joined #chromium
[23:54:10] *** adlr has quit IRC
[23:54:58] *** adlr has joined #chromium
[23:55:31] *** jrmuizel has joined #chromium
[23:56:14] *** silassewell has joined #chromium
[23:56:32] *** erickt_ has joined #chromium
[23:57:01] *** hinoka has joined #chromium
[23:57:16] *** erickt_ has left #chromium
[23:57:24] *** erickt_ has joined #chromium
[23:58:52] <eseidel> evmar, estade: pointed erickt_ at you for help tracking down some chromium linux/ automounter incompatiblity.  I figured you two would know who to point him to or how he might diagnose (he's a software engineer at local tech company) :p
[23:59:28] <thakis> eseidel: evmar is out for today
[23:59:52] <eseidel> thakis: k.  I don't really know who else worked on chromium linux besides evmar, agl and estate
[23:59:53] <erickt_> aw shucks :)
[23:59:55] <thakis> trungl: hey, looks like someone powered off my mac pro
[23:59:57] <thakis> i'm me again!





top