[00:00:51] *** hagebake is now known as hagabaka [00:03:54] <thakis_> estade: i want to have several gtkwidgets in one container, all on top of each other, and only one of them should be visible at a time [00:04:00] <thakis_> what's the container of choice here? [00:04:22] <thakis_> a hbox and manually removing & adding children? [00:11:43] *** zel has left #chromium [00:13:00] *** senorblanco has quit IRC [00:13:16] <mattm_g> thakis_: you can just leave them in the container and show/hide on them [00:13:34] *** bers has joined #chromium [00:13:34] <thakis_> mattm_g: i'll try that, thanks [00:14:42] *** bers has quit IRC [00:18:40] *** nebula has quit IRC [00:18:44] *** Martijnc has quit IRC [00:20:31] *** garykac has quit IRC [00:23:42] <dcheng> Hm. Is there any Web* equivalent to WebString/WebVector, but for maps? [00:24:07] <thakis_> mattm_g: looks like the hbox gets very wide if i do this [00:25:02] <mattm_g> thakis_: if the children are hidden it shouldn't apply any padding for them (maybe a show_all on some parent is causing them to show?) There's some function to exempt a widget from gtk_widget_show_all though I don't recall the name off hand [00:26:05] <mattm_g> ah, gtk_widget_set_no_show_all [00:26:41] <mattm_g> you can also look at the gtk location bar code, it does this kind of thing [00:28:05] *** xiyuan has left #chromium [00:28:18] *** vithos has quit IRC [00:30:08] *** deshantm has quit IRC [00:31:01] *** lzheng has quit IRC [00:31:06] *** kellegous has quit IRC [00:31:27] *** Macuyiko has joined #chromium [00:35:25] *** dale1v has joined #chromium [00:35:32] *** tonikitoo has joined #chromium [00:36:32] *** SRabbelier has joined #chromium [00:37:12] *** ik0n has joined #chromium [00:39:34] *** m0_ has joined #chromium [00:42:16] *** m0 has quit IRC [00:43:27] *** jrmuizel has quit IRC [00:45:43] *** markmentovai has quit IRC [00:47:28] *** kliegs has quit IRC [00:49:49] *** tittiatcoke has quit IRC [00:50:53] *** xiyuan has joined #chromium [00:52:36] *** coyo has joined #chromium [00:55:57] *** SleepingCoyote has quit IRC [00:56:34] <thakis_> mattm_g: is there an easy way to get the hbox to be as large as the largest hidden child it contains? [00:57:38] *** coyo|pingout has joined #chromium [00:58:07] *** thomasvl has quit IRC [00:58:30] *** duffydack has joined #chromium [00:58:43] <rsesek> thakis: cl to you, but no rush bc i'm out for the night [00:58:54] <rsesek> jcivelli, jshin: heading out [01:00:36] *** _rs has quit IRC [01:00:37] <jshin> rsesek: good night ! thanks a lot for your great help today [01:00:40] <jcivelli> rsesek: ok. Good evening. [01:00:59] *** xji has quit IRC [01:01:39] *** coyo has quit IRC [01:03:10] *** kellegous has joined #chromium [01:03:20] <mattm_g> thakis_: hm, not aware of a drop in, but you could probably do gtk_widget_size_request (note restrictions on when it can be called) on each of the children and then gtk_widget_set_size_request on the container (have to add in any padding, probably) [01:03:51] *** hagabaka has quit IRC [01:04:41] *** zer0her0 has joined #chromium [01:06:33] *** hagabaka has joined #chromium [01:06:34] *** hagabaka has joined #chromium [01:07:01] <estade> thakis_: what is this for [01:10:00] *** genericbrandx has joined #chromium [01:10:44] *** kliegs has joined #chromium [01:12:08] *** duffydack has left #chromium [01:15:52] <estade> jshin: http://codereview.chromium.org/2733005/show [01:16:47] *** bradleymeck has quit IRC [01:17:04] *** MikeSmithXX has joined #chromium [01:18:51] <evmar> thakis_: yeah, what are you doing? it sounds scary :) [01:19:07] <evmar> thakis_: you might consider a GtkNotebook with no tabs showing [01:19:17] <thakis_> evmar: yes, trying just that atm [01:19:23] <jshin> estade: looking [01:19:23] <thakis_> evmar, estade: bug 45546 [01:19:36] *** eseidel has joined #chromium [01:19:56] <evmar> ah yes, definitely use a notebook for that [01:20:02] <evmar> since you're just fakign side tabs on a notebook anyway [01:20:26] <evmar> thakis_: btw, did you consider a gtknotebook with the tabs set to the left side? [01:21:19] *** MikeSmithW3C^ has quit IRC [01:21:41] <thakis_> evmar: i haven't, i'm following mocks :-P [01:22:05] <evmar> can i see a mock? [01:23:26] <thakis_> evmar: sent per mail [01:24:02] *** AaronMT has quit IRC [01:24:19] *** Venom_X has quit IRC [01:25:38] <evmar> i suggest doing a side-tab gtknotebook, and then it'll be easy to convert if we decide that's not ok [01:27:21] *** eseidel has quit IRC [01:30:10] *** xji has joined #chromium [01:31:05] *** felipe` has quit IRC [01:34:45] *** vithos has joined #chromium [01:38:09] *** dglazkov has quit IRC [01:38:46] <willchan> do we use a regexp lib in chromium? if so, can someone point it out to me? [01:38:52] *** vithos has quit IRC [01:39:07] <jshin> one in Webkit is used by form autofill. [01:39:19] <jshin> for non-ASCII chars, one in ICU can be used, too [01:39:44] <willchan> the one in WebKit? can we reach into that from chrome/ code? [01:40:03] <jshin> i guess not. autofill is run inside a renderer process, i heard [01:40:27] <willchan> we must use regexps somewhere browser-side, right? [01:40:54] *** Aria has joined #chromium [01:41:12] *** thakis_ has quit IRC [01:41:16] <jshin> for better omnibox suggestion based on history, i heard one would be used soon (one in ICU because it has to deal with non-ASCII chars well) [01:41:35] <evmar> i believe we don't [01:41:37] <jshin> but other than that, i think nobody uses it in the browser [01:42:10] *** thakis_ has joined #chromium [01:42:10] *** ChanServ sets mode: +v thakis_ [01:43:01] *** vithos has joined #chromium [01:43:38] *** rsesek has quit IRC [01:44:03] *** vithos has quit IRC [01:46:15] *** dave_levin_ has joined #chromium [01:48:13] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49340: ctguil at chromium dot org, mark at chromium dot org (:markmentovai), skerner at chromium dot org, vangelis at chromium dot org) [01:48:35] <pcgod> http://echelog.matzon.dk/logs/browse/chromium/1275343200 .. search for regexp [01:48:49] <pcgod> er regex [01:49:04] *** zer0her0 has quit IRC [01:49:56] *** dave_levin__ has joined #chromium [01:49:57] <jcivelli> skerner: unit_test failure, yours? [01:50:22] <skerner> looking... [01:51:20] <trungl-bot> Tree closed by jshin at chromium dot org: Tree is closed (Vista unittest => skerner ) [01:51:23] *** hbono has joined #chromium [01:52:11] *** RT|Chatzilla has joined #chromium [01:52:15] *** dave_levin_ has quit IRC [01:52:33] *** atwilson has joined #chromium [01:54:33] <atwilson> I'm putting together a patch to add plumbing to pass up the name of a newly-opened frame to the associated RenderViewHost when creating a frame, and vice versa (allowing setting a frame name when initiating a new window from the browser process). Who might be a good reviewer for that? I was going to ping rafaelw, but he's at an offsite the next coupla days. [01:54:52] <evmar> darin ;) [01:55:22] <skerner> jcivelli, ctguil: Still looking, but r49339 looks like it could be the issue, based on the files involved. [01:56:23] <trungl-bot> Tree closed by jshin at chromium dot org: Tree is closed (Vista unittest => skerner, ctguil) [01:59:19] <skerner> ctguil: Can you take a look at the unit test failure? [01:59:35] *** TabAtkin1_ has joined #chromium [02:00:09] *** TabAtkins_ has quit IRC [02:00:42] <jcivelli> skerner: does not look like ctguil is logged on IRC [02:01:11] <jshin> hmm. he's offline on gmail,too... [02:02:51] <jcivelli> OK, that calls for a revert then [02:03:16] *** timsteele has quit IRC [02:03:55] <skerner> jcivelli: Looking at the failure, it seems unlikely my patch caused it. [02:04:29] *** kcbanner has quit IRC [02:05:18] <jshin> jcivelli: are you reverting? [02:06:15] <jcivelli> jshin: yes [02:06:36] <jshin> jcivelli: ok [02:08:08] <jcivelli> Reverted [02:10:16] *** dale1v has quit IRC [02:13:26] <jcivelli> Arg! Looks like the unit-test failure was flakiness! [02:13:34] <trungl-bot> Tree closed by jshin at chromium dot org: Tree is closed (Vista unittest : ctguil's 49339 reverted. waiting for unit_tests to pass) [02:14:23] <jshin> arg... then, mark it as flaky and re-revert? [02:14:31] *** stevenjb has quit IRC [02:14:47] *** dave_levin has quit IRC [02:14:48] *** dave_levin__ is now known as dave_levin [02:15:31] <jshin> i'm marking it as flaky [02:15:56] <jcivelli> ok, I'll revert the revert [02:17:05] *** shepazu has quit IRC [02:17:05] <jcivelli> I'll wait for the UI test next run though [02:19:03] *** japhet has quit IRC [02:19:13] *** shepazu has joined #chromium [02:19:27] *** kcbanner has joined #chromium [02:19:37] <trungl-bot> Tree opened by jcivelli at chromium dot org: Tree is open [02:22:52] *** thakis_ has quit IRC [02:24:32] *** japhet has joined #chromium [02:24:34] *** dmaclach has quit IRC [02:27:49] *** apatrick_ has left #chromium [02:29:22] <jshin> jcivelli: i'm attending a meeting at 5:30 and will take off after that [02:33:30] *** hbono has quit IRC [02:35:11] *** trungl has quit IRC [02:38:55] *** Macuyiko has quit IRC [02:40:20] *** kellegous has quit IRC [02:40:39] <jcivelli> OK, I am out. Please be gentle with the tree [02:40:50] *** General13372 has quit IRC [02:42:36] *** skerner has quit IRC [02:42:57] *** iSerg has joined #chromium [02:43:00] *** trungl has joined #chromium [02:43:00] *** ChanServ sets mode: +v trungl [02:43:52] *** xji has quit IRC [02:45:09] *** hbono has joined #chromium [02:46:01] *** General1337 has joined #chromium [02:46:05] *** Malmis has quit IRC [02:46:20] <pkasting> Wow, the Mac trybot is like 3 hours behind [02:49:36] *** eseidelDesk has quit IRC [02:50:33] *** General13372 has joined #chromium [02:51:30] *** Malmis has joined #chromium [02:53:34] *** General1337 has quit IRC [02:56:01] *** rvargas has quit IRC [02:57:25] *** MikeSmithXX has quit IRC [02:57:45] *** tonyg-cr has quit IRC [02:59:08] *** tedoc2000 has quit IRC [03:07:15] *** cbentzel has joined #chromium [03:10:22] *** yutak_home has quit IRC [03:11:58] *** Royall has joined #chromium [03:12:04] <Royall> Pinning a Tumblr tab in Google Chrome defeats the purpose of the (1) title notifier [03:13:03] <akalin> don't pin it? [03:13:20] <Royall> :s I guess [03:14:02] *** bevc_work has quit IRC [03:14:26] *** eugene has joined #chromium [03:14:41] <eugene> hello good people [03:15:01] <eugene> can somebody direct me to the svg handling source? [03:15:12] *** rvargas has joined #chromium [03:15:42] *** Royall has left #chromium [03:16:25] *** dave_levin has quit IRC [03:18:51] *** zer0her0 has joined #chromium [03:22:11] *** cbentzel has quit IRC [03:24:25] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib)" from 49354: ananta at chromium dot org (:iyengar)) [03:26:50] *** rubenbb has quit IRC [03:27:04] <ananta> I will take a look [03:27:35] *** rubenbb has joined #chromium [03:32:00] *** pathorn has quit IRC [03:32:24] <eugene> svggraphics.js [03:32:27] <eugene> is this it? [03:36:58] *** trungl has quit IRC [03:38:37] *** dglazkov has joined #chromium [03:40:29] *** kellegous has joined #chromium [03:40:39] *** kellegous has quit IRC [03:44:41] <trungl-bot> Tree closed by ananta at chromium dot org (:iyengar): Tree is closed (Automatic: "compile" on "Chromium Linux Builder (dbg-shlib). Prospective fix submitted)" from 49354: ananta at chromium dot org (:iyengar)) [03:46:26] <ananta> I submitted a fix for the build failure [03:46:53] <ananta> will open the tree when the compile goes through [03:52:35] *** leeight has joined #chromium [03:52:39] *** leeight has left #chromium [03:56:01] *** TabAtkin1_ has quit IRC [03:56:20] *** yusukes has joined #chromium [03:56:57] *** TabAtkins_ has joined #chromium [03:57:09] <yusukes> ananta: Linux Builder (dbg-shlib) bot is now green. can i reopen the tree? [03:58:32] *** magn3ts has joined #chromium [03:59:14] <ananta> yeah. however chromium xp is now broken [03:59:33] <ananta> it appears to be 49353 [04:00:01] <ananta> i guess we should wait for this run before starting to revert [04:01:52] *** tfarina has joined #chromium [04:01:52] <yusukes> i see [04:01:55] *** tonikitoo has quit IRC [04:03:20] <ananta> yusukes: I will revert 49353 if the current chromium XP build run fails [04:03:38] *** rolandsteiner has joined #chromium [04:04:16] <ananta> tfarina: yt? [04:04:32] <tfarina> yep [04:04:51] <ananta> tfarina: It appears that chromium XP failures are due to your CL [04:05:05] <ananta> tfarina: Can you fix/revert? [04:05:41] <tfarina> can we revert? [04:05:41] <tfarina> so I can take a look with more time. [04:05:41] <ananta> tfarina: i will revert [04:05:43] <tfarina> ananta: cool thanks. [04:06:11] *** Buglouse has quit IRC [04:06:17] *** arv has quit IRC [04:06:50] <ananta> yusukes: revert is in [04:07:09] <ananta> yusukes: should we open? [04:08:22] *** rickspencer3 has quit IRC [04:09:06] *** iSerg has quit IRC [04:12:05] *** fqian has quit IRC [04:13:00] <trungl-bot> Tree closed by ananta at chromium dot org (:iyengar): Tree is closed (Revert for Chromium XP compile failures is in. Waiting for cycle) [04:13:22] *** leeight has joined #chromium [04:13:24] *** leeight has left #chromium [04:24:56] *** beej666 has quit IRC [04:25:58] *** eugene has quit IRC [04:26:24] *** mfinkle has quit IRC [04:29:11] <akalin> ananta: how did 49353 break the tree? [04:29:18] <akalin> oh [04:29:20] <akalin> nm [04:30:39] *** mfinkle has joined #chromium [04:31:08] *** SRabbelier has quit IRC [04:32:13] <tfarina> ananta: the chromium XP compiled [04:32:31] <tfarina> ananta: should we wait until it finished? [04:33:15] *** tedoc2000 has joined #chromium [04:33:26] <tfarina> akalin: not sure yet how it could break the tree ;( [04:33:36] <akalin> weird [04:34:22] <tfarina> akalin: I reopened the issue and sent it to the trybots. It compiled fine here. [04:34:31] *** alyxuk has quit IRC [04:36:08] <yusukes> ananta: Chromium OS bot is still red. http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7942/steps/unit_tests/logs/ChromeOSEmptyRecord [04:36:23] <yusukes> is this related to 49354? [04:37:30] <tfarina> akalin: need I to open another issue (or is fine to fix it on the same)? [04:38:43] *** mfinkle has quit IRC [04:42:04] <akalin> tfarina: you can reopen the issue, i think [04:42:16] *** chrisccoulson has quit IRC [04:42:49] *** mfinkle has joined #chromium [04:44:28] <akalin> tfarina: the winxp bots may have needed a clobber [04:45:27] <tfarina> akalin: I think you are right, because it was a link failure (so could be that). [04:45:49] *** dpranke has quit IRC [04:48:10] *** Waste has quit IRC [04:52:30] <trungl-bot> Tree closed by ananta at chromium dot org (:iyengar): Tree is closed ( installer tests: ananta) [04:53:10] *** leeight has joined #chromium [04:53:13] *** leeight has left #chromium [04:53:30] <trungl-bot> Tree opened by ananta at chromium dot org (:iyengar): Tree is open ( installer tests: ananta) [04:54:15] *** vithos has joined #chromium [04:56:32] <akalin> yay open tree [04:56:40] <tfarina> akalin: another try, the same thing (http://build.chromium.org/buildbot/try-server/builders/win/builds/35035/steps/compile/logs/stdio). [04:57:32] <tfarina> akalin: wait, I had another try that worked :/ [04:58:13] <akalin> yeah it's weird [04:58:19] <akalin> i mean sync_constants.cc is compiled right there [04:59:30] <tfarina> yep, very strange. [04:59:34] <akalin> tfarina: try bots compile in debug mode [04:59:41] <akalin> maybe if you try compiling locally in release mode? [04:59:42] *** dumi has quit IRC [04:59:55] <akalin> you may be able to repro [04:59:55] *** dmaclach has joined #chromium [05:01:07] <tfarina> akalin: sure, I will try that. [05:01:22] *** rolandsteiner has quit IRC [05:03:28] *** trungl has joined #chromium [05:03:28] *** ChanServ sets mode: +v trungl [05:05:54] *** trungl_ has joined #chromium [05:05:55] *** ChanServ sets mode: +v trungl_ [05:09:49] *** trungl has quit IRC [05:09:49] *** trungl_ is now known as trungl [05:11:00] *** dmaclach has quit IRC [05:12:06] *** leeight has joined #chromium [05:12:07] *** leeight has left #chromium [05:17:09] *** rolandsteiner has joined #chromium [05:18:32] *** slavka` has joined #chromium [05:18:44] *** huckphin has joined #chromium [05:18:48] <trungl-bot> Tree opened by ananta at chromium dot org (:iyengar): Tree is open ( Revert for installer_unit_tests failure is in) [05:22:48] *** jrmuizel has joined #chromium [05:24:50] *** dmaclach has joined #chromium [05:27:28] *** sshc has quit IRC [05:31:31] *** MikeSmithW3C has joined #chromium [05:32:22] *** MikeSmithW3C has quit IRC [05:32:43] *** MikeSmithW3C has joined #chromium [05:42:34] *** Kernel-Panic has quit IRC [05:42:39] *** tonikitoo has joined #chromium [05:42:54] *** Kernel-Panic has joined #chromium [05:46:11] *** thakis_ has joined #chromium [05:46:11] *** ChanServ sets mode: +v thakis_ [05:46:55] *** thakis__ has joined #chromium [05:46:55] *** ChanServ sets mode: +v thakis__ [05:47:06] *** rolandsteiner has quit IRC [05:48:52] *** vithos has quit IRC [05:49:08] *** vithos has joined #chromium [05:49:57] <trungl> thakis_! [05:50:32] *** thakis_ has quit IRC [05:54:16] <trungl> hmmm, captchas are bad for bots [05:55:24] <trungl> any appengine experts around? [05:57:58] *** rolandsteiner has joined #chromium [05:58:11] <trungl> (even less likely) any ClientLogin experts around? [06:02:13] *** nth_ has joined #chromium [06:02:36] *** huckphin has quit IRC [06:02:57] *** magn3ts has quit IRC [06:02:57] <thakis__> trungl: ! [06:03:11] <trungl> you gained an extra '_'! [06:03:32] <trungl> (it must be age and/or experience) [06:04:49] <trungl> thakis__: since you know everything, I'll ask you: do you know if the auth token that you get back from ClientLogin expires? [06:05:22] *** jrmuizel has quit IRC [06:06:01] <thakis__> trungl: i don't, but my googling skills suggest that "yes" [06:06:27] <trungl> what do your binging skills suggest? [06:07:20] *** michaeln has quit IRC [06:09:45] *** goddard has joined #chromium [06:09:45] <trungl> thakis__: in the case of gdata, some other documentation suggests that tokens don't actually expire [06:09:50] *** jrmuizel has joined #chromium [06:09:58] <goddard> Why is it chrome allows persistent connections? [06:10:09] <trungl> (and my token from > 5 days ago is still valid) [06:10:30] <goddard> what information is it keep on sending if I am idling at a webpage [06:10:56] <trungl> goddard: see channel topic [06:12:52] <thakis__> trungl: motownavi won a bing sticker yesterday btw [06:12:57] *** tedoc2000 has quit IRC [06:13:04] <thakis__> trungl: i searched for "appengine clientlogin token expiry" [06:13:13] <trungl> thakis__: what did he do to earn that? [06:13:32] <thakis__> trungl: there's a session called "stump the experts", and he stumped them [06:13:35] <thakis__> repeatedly [06:13:42] <thakis__> so he got a tshirt, and a bing sticker [06:13:51] <thakis__> and an invitation to join the panels of experts next year [06:14:07] <trungl> wow [06:14:25] <trungl> maybe I'll have to go to wwdc next year [06:14:39] <goddard> +trungl huh [06:14:56] <trungl> goddard: " Ask user questions (including webm) in the unofficial #chromium-support or the official http://www.google.com/support/chrome/" [06:15:30] <goddard> whats this for? [06:17:17] <goddard> .. [06:18:02] <Aria> Development. [06:18:49] *** goddard has left #chromium [06:18:49] *** dmaclach_ has joined #chromium [06:19:13] *** sshc has joined #chromium [06:22:23] *** dmaclach has quit IRC [06:22:23] *** dmaclach_ is now known as dmaclach [06:23:13] <trungl> maybe I can use oauth instead [06:23:14] <trungl> hrm [06:23:41] *** thakis_ has joined #chromium [06:23:41] *** ChanServ sets mode: +v thakis_ [06:27:35] *** thakis__ has quit IRC [06:34:53] *** dave_levin has joined #chromium [06:43:47] *** tittiatcoke has joined #chromium [06:44:55] *** zloidemon has joined #chromium [06:47:14] *** tfarina has quit IRC [06:48:27] *** thakis_ has quit IRC [06:49:16] <trungl> hrm, quality work, google [06:53:45] *** Kernel-Panic has quit IRC [06:54:19] *** darwin has quit IRC [06:56:22] *** dmaclach has quit IRC [07:00:57] *** tittiatcoke has quit IRC [07:02:40] *** Aria has left #chromium [07:02:57] *** thakis_ has joined #chromium [07:02:58] *** ChanServ sets mode: +v thakis_ [07:04:05] <trungl> worst. wikipedia. article. ever. [07:06:49] *** Kernel-Panic has joined #chromium [07:15:09] *** coldhead has joined #chromium [07:15:53] <coldhead> can i get some ops please? [07:16:02] <coldhead> +o coldhead ? [07:25:58] <trungl> uh, no [07:27:14] *** cedricv has joined #chromium [07:27:27] *** jrmuizel has quit IRC [07:28:30] *** Kernel-Panic has quit IRC [07:32:23] *** slavka` has quit IRC [07:32:44] <rubenbb> hah [07:34:25] *** loislo has joined #chromium [07:34:58] *** slavka` has joined #chromium [07:38:20] <thakis_> oh no, i missed the worst wikipedia article ever! [07:41:36] <rubenbb> I'm guessing it's the OAuth one? [07:49:49] *** bers has joined #chromium [07:54:27] *** selckin has joined #chromium [08:00:52] *** dave_levin has quit IRC [08:01:48] *** Kernel-Panic has joined #chromium [08:04:16] *** kcbanner has quit IRC [08:05:21] *** nth_ has quit IRC [08:10:59] *** bsmedberg has quit IRC [08:11:28] *** bsmedberg has joined #chromium [08:11:55] *** nthawEE has quit IRC [08:12:06] *** jamesr has quit IRC [08:14:58] *** nthawEE has joined #chromium [08:18:27] *** Pupeno has quit IRC [08:19:02] *** kcbanner has joined #chromium [08:23:15] *** Zaba has quit IRC [08:27:17] *** Zaba has joined #chromium [08:27:36] *** satorux has joined #chromium [08:28:00] <satorux> r49370 may break the chrome for chromium os build [08:28:44] <satorux> inside chromium os chroot. [08:28:52] <satorux> as it introduced '<!@(<(pkg-config) --libs-only-l gnome-keyring-1)', [08:28:53] *** coyo|pingout has quit IRC [08:29:00] <satorux> which is not in the chroot i suppose [08:29:27] <tony^work> the problem is that gnome-keyring is not installed? [08:29:49] <tony^work> I think there was an email to chromium-dev about re-running install-build-deps.sh for this new package [08:30:27] <satorux> yeah, but the chroot used for chromium os is gentoo based [08:30:43] <satorux> we would need to add RDEPEND or something in the ebuild file there [08:30:53] <tony^work> I see, so you need to emerge a new package? [08:30:57] <satorux> but would be nice if we could avoid adding it [08:31:46] <tony^work> if you want to avoid adding it, you'll need to add conditionals to the gyp file and #ifs to the code [08:31:53] <yusukes> gnome-keyring package seems not to support cross compilation, so just adding RDEPEND might not work. [08:31:54] <satorux> let me see if it actually breaks [08:32:05] <satorux> it was my guess work [08:32:49] <tony^work> I suspect you are correct . . . [08:36:03] <satorux> Exception: Call to './pkg-config-wrapper "/build/x86-generic/" --cflags gnome-keyring-1' returned exit status 0. while loading dependencies of src/base/base.gyp while loading dependencies of src/net/net.gyp while loading dependencies of src/app/app.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp [08:36:10] <satorux> in the chroot used for chromium os build [08:37:01] *** coyo has joined #chromium [08:37:31] *** glaksmono_ has joined #chromium [08:37:42] <satorux> would it be possible to add some conditionals in the gyp file so the pkg-config won't be called if chromeos==1? [08:37:42] <glaksmono_> anyone know which part of the source code handles bookmarking? [08:37:57] <tony^work> satorux: yes, but you will also need #ifs in the code [08:38:06] <satorux> argh [08:38:10] <tony^work> it won't compile without the keyring headers [08:38:21] <satorux> that's unfortunate [08:38:35] <satorux> chrome for chromium os is nothing to do with gnome and even the keyring [08:38:47] <tony^work> true [08:38:58] *** glaksmono__ has joined #chromium [08:39:05] <tony^work> will the profile directory be encrypted by default? [08:39:21] <satorux> i suppose the stateful partition is encrypted [08:39:33] <satorux> it's the plan [08:39:39] <tony^work> then you probably don't need gnome keyring [08:39:40] <satorux> not sure if it's implemented. [08:40:10] *** glaksmono__ is now known as glaksmono [08:40:38] <glaksmono> anyone know which part of the source code handles bookmark manager? [08:42:23] *** glaksmono_ has quit IRC [08:42:33] <tony^work> satorux: looking more closely at the diff, I think you can build w/o gnome-keyring [08:42:47] <tony^work> I think it's sufficient to add a conditional to the gyp file for pkg-config [08:44:00] <tony^work> it looks like the .h and .cc files are already excluded from the chromeos build [08:44:15] <satorux> that's good to know [08:44:35] <satorux> I'll give it a try [08:47:11] *** glaksmono_ has joined #chromium [08:48:07] *** glaksmono__ has joined #chromium [08:49:06] *** tittiatcoke has joined #chromium [08:49:58] *** glaksmono has quit IRC [08:50:05] *** glaksmono__ is now known as glaksmono [08:50:41] *** MikeSmithW3C has quit IRC [08:50:51] *** Erkan_Yilmaz_ has quit IRC [08:51:42] *** glaksmono_ has quit IRC [08:55:16] <glaksmono> anyone know which part of the source code handles bookmark manager? [08:57:38] *** GeekShadow has joined #chromium [09:01:02] *** glaksmono has quit IRC [09:05:03] *** m0_ is now known as m0 [09:05:33] <m0> glaksmono: it is an extension built in [09:08:33] *** MikeSmithW3C has joined #chromium [09:09:37] *** Waste has joined #chromium [09:11:59] *** nebula has joined #chromium [09:17:18] *** glaksmono has joined #chromium [09:17:28] <glaksmono> anyone know part of the source code that handles bookmarking? [09:20:43] <m0> glaksmono: it is an extension built in [09:20:56] <glaksmono> m0: ah.. [09:21:11] <m0> glaksmono: wait, did you mean how to bookmark? or the bookmakr manager? [09:21:33] <m0> or this chrome://bookmarks/ [09:21:36] <glaksmono> m0: what's the difference? [09:22:20] <m0> Well, when you bookmark, a bookmark bubble will show, and that is native. The bookmark manager is html (bundled as an extension) built into chrome. [09:23:02] <glaksmono> so which part is the "bookmark manager"? [09:23:33] <glaksmono> for example when we create a new tab, on the top right there's "other bookmark" folder, is that being handled by boomark or bookmark manager? [09:23:49] <glaksmono> m0: i'm looking at one bug of bookmark [09:24:20] <m0> that is native. [09:24:40] <m0> glaksmono: what is the bug #? [09:25:29] <m0> glaksmono: I believe in src/chrome/browser/views you will see some bookmark views [09:25:41] <glaksmono> 6336 [09:26:08] <m0> glaksmono: bookmark_bar_view adds all the buttons, and I think you will see Other Bookmarks [09:26:24] *** coyo|pingout has joined #chromium [09:26:50] *** coyo has quit IRC [09:26:51] *** tittiatcoke has quit IRC [09:26:53] <glaksmono> src/chrome/browser i only sync [09:27:04] <glaksmono> i don't see views there... hmm.. [09:27:30] <m0> it is in src/chrome/browser/"views" [09:27:42] <m0> there is a folder, that contains all the views of chromium. [09:28:07] <m0> http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/ [09:28:17] <glaksmono> ah yes i see it [09:28:27] <glaksmono> how do i see this from visual studio? [09:28:42] <glaksmono> can't see it for some reason hmm.. [09:28:46] <m0> expand the browser project, and you will see views [09:29:18] <m0> If you want to quickly go there, open the console window (in VS) and type, "open bookmark_bar_view.cc" [09:32:24] <glaksmono> ah i see it [09:32:33] <glaksmono> i was thrown off with that transparent folders [09:32:40] <glaksmono> there's also browser folder that's transparent [09:32:43] <glaksmono> with dashed lines [09:34:36] <m0> Interesting, dashed lines if I recall means excluding [09:35:18] <glaksmono> ah i see, thanks a lot m0 for helping me to get started hehe.. [09:35:26] <glaksmono> m0: i'll look at the code [09:35:48] <m0> Let me know if you need anything, I will be around tomorrow. It is almost 4AM now, time for bed :< [09:36:00] <glaksmono> ahh.. you're in east coast? [09:36:17] <glaksmono> alright :) [09:36:22] *** skerner has joined #chromium [09:36:32] <m0> I had a mid-life crises fixing one broken of mine (For my father) took me 3 hours :< Note to self: never update a development server without testing the other websites ::) [09:36:46] <m0> broken (website) [09:37:05] <glaksmono> ahhh :) [09:39:00] <m0> mhm at chromium dot org in case you need anything to help you get started with your first patch :) It is a fun process! [09:39:03] * m0 nice [09:39:14] * m0 slaps m0 ... nite [09:43:56] <glaksmono> m0: added to my contact :) [09:44:09] <glaksmono> m0: thanks so much.. [09:48:16] *** glaksmono_ has joined #chromium [09:48:25] *** glaksmono_ has quit IRC [09:51:17] *** glaksmono has quit IRC [09:52:55] *** shepazu has quit IRC [09:55:00] <trungl-bot> Tree opened by yusukes at chromium dot org: Tree is open (Revert for installer_unit_tests failure is in. Chromium OS unit_tests -> r49354 ??) [09:59:10] <Zedde> Hello , I have a question about the webbrowser, more for addons, is there posibly to create a addon that adds more search functions to the right click menu ? [10:01:04] <Zedde> I haven't google as I don't know if it's posibly or not, is it I can start searching for info not I'll just drop it :) [10:03:29] *** skerner has quit IRC [10:07:20] *** nebula has quit IRC [10:07:32] *** hagabaka has quit IRC [10:08:30] *** bauerb has joined #chromium [10:11:46] *** bers has quit IRC [10:42:07] *** abarth has quit IRC [10:44:45] *** alyxuk has joined #chromium [10:46:23] *** temp01 has joined #chromium [10:48:08] *** robarnold|eviltw has joined #chromium [10:50:03] *** robarnold has quit IRC [10:52:12] *** tittiatcoke has joined #chromium [10:52:38] *** dale1v has joined #chromium [10:53:12] *** mahemoff has joined #chromium [10:54:39] *** mahemoff has quit IRC [10:58:17] *** ROBOd has joined #chromium [11:09:50] *** mahemoff has joined #chromium [11:12:42] <joth> anyone looking at CrOS unit_tests fail? [11:12:53] <joth> I think http://src.chromium.org/viewvc/chrome?view=rev&revision=49354 caused it [11:13:08] <joth> it reverted some of the code from the previous revision on metric_log.cc [11:14:18] *** holdenss has joined #chromium [11:15:04] <joth> ping ananta ^^ [11:15:26] <joth> (back in 10) [11:19:31] *** Macuyiko has joined #chromium [11:22:37] *** phajdan-jr has joined #chromium [11:22:38] *** ChanServ sets mode: +v phajdan-jr [11:23:29] <phajdan-jr> Hi! Can anyone do a trivial code review for me? http://codereview.chromium.org/2658003 [11:23:50] *** chrisccoulson has joined #chromium [11:24:11] *** mahemoff has quit IRC [11:27:05] *** BCalvignac has quit IRC [11:31:45] *** apavlov has joined #chromium [11:33:01] *** zloidemon has quit IRC [11:35:02] *** MikeSmithW3C has quit IRC [11:35:15] *** zloidemon has joined #chromium [11:40:10] *** mahemoff has joined #chromium [11:45:02] *** mahemoff has quit IRC [11:57:24] *** yusukes has quit IRC [12:00:12] *** wers has joined #chromium [12:03:59] *** ik0n has quit IRC [12:04:40] *** Waste has quit IRC [12:06:03] *** Waste has joined #chromium [12:07:33] *** duffydack has joined #chromium [12:07:36] *** rolandsteiner has quit IRC [12:07:53] *** ik0n has joined #chromium [12:08:35] *** mahemoff has joined #chromium [12:12:21] *** mahemoff_ has joined #chromium [12:13:43] *** mahemoff has quit IRC [12:13:43] *** mahemoff_ is now known as mahemoff [12:23:02] *** chrisccoulson has quit IRC [12:27:19] *** chrisccoulson has joined #chromium [12:32:10] *** General13372 has quit IRC [12:37:02] *** leeight has joined #chromium [12:37:20] *** leeight has left #chromium [12:42:26] *** coldhead has left #chromium [12:42:38] *** leeight has joined #chromium [12:43:16] *** leeight has left #chromium [12:44:16] *** dale1v has quit IRC [12:50:11] *** dale1v has joined #chromium [12:50:11] *** dale1v has joined #chromium [12:50:35] *** BCalvignac has joined #chromium [12:56:54] *** dale1v has quit IRC [12:58:29] *** cbentzel has joined #chromium [13:01:51] *** Macuyiko has left #chromium [13:02:03] <joth> I'm going to go ahead and revert r49354 then [13:05:12] *** dale1v has joined #chromium [13:05:14] <trungl-bot> Tree opened by joth at google dot com: Tree is open (Revert for Chromium OS unit_tests r49354 in) [13:05:25] *** MikeSmithW3C has joined #chromium [13:07:03] *** chaser has quit IRC [13:07:49] *** dale1v is now known as dale1v[away] [13:10:48] * phajdan-jr likes the trungl-bot's status updates :) [13:11:46] *** BCalvignac has quit IRC [13:11:51] *** tonikitoo has quit IRC [13:17:12] *** dale1v[away] has quit IRC [13:17:51] *** dale1v has joined #chromium [13:23:44] *** hbono has quit IRC [13:26:01] *** GeekShadow has quit IRC [13:28:11] *** duffydack has quit IRC [13:36:44] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "base_unittests" on "Modules Linux" from 49385: glider at chromium dot org) [13:37:47] *** MikeSmithW3C has quit IRC [13:40:42] *** glider has joined #chromium [13:46:41] *** dale1v has quit IRC [13:48:57] <trungl-bot> Tree opened by glider at chromium dot org: Tree is open (Modules Linux need investigation) [13:50:11] *** dale1v has joined #chromium [13:50:11] *** dale1v has joined #chromium [13:51:50] *** thomasvl has joined #chromium [13:51:50] *** ChanServ sets mode: +v thomasvl [13:53:24] *** BCalvignac has joined #chromium [13:54:51] *** Malmis has quit IRC [13:55:08] *** BCalvignac has quit IRC [13:57:22] *** BCalvignac has joined #chromium [13:59:01] *** phajdan-jr is now known as phajdan-jr|afk [13:59:44] *** dale1v has quit IRC [14:01:52] *** chrisccoulson has quit IRC [14:02:36] *** dale1v has joined #chromium [14:02:36] *** dale1v has joined #chromium [14:02:39] *** Ruetobas has quit IRC [14:03:40] *** dale1v has quit IRC [14:03:48] *** Malmis has joined #chromium [14:03:51] *** GeekShadow has joined #chromium [14:04:40] *** kcbanner has quit IRC [14:05:29] *** Ruetobas has joined #chromium [14:08:10] *** cbentzel has quit IRC [14:09:03] *** BCalvignac has quit IRC [14:09:39] *** holdenss has quit IRC [14:17:08] *** nuclearjello has joined #chromium [14:19:25] *** kcbanner has joined #chromium [14:20:44] *** chrisccoulson has joined #chromium [14:22:19] *** rvargas has quit IRC [14:25:34] *** phajdan-jr|afk has quit IRC [14:27:29] *** MikeSmithW3C has joined #chromium [14:29:47] *** tittiatcoke has quit IRC [14:32:16] *** zaspire has joined #chromium [14:35:26] *** Zaba_ has joined #chromium [14:35:51] *** tonikitoo has joined #chromium [14:37:53] *** Zaba has quit IRC [14:37:58] *** Zaba_ is now known as Zaba [14:41:42] <trungl-bot> Tree opened by glider at chromium dot org: Tree is open [14:43:43] *** deshantm has joined #chromium [14:44:03] *** kliegs has quit IRC [14:46:15] *** BCalvignac has joined #chromium [14:57:44] *** kcbanner has quit IRC [15:03:21] *** phajdan-jr|afk has joined #chromium [15:03:27] *** ChanServ sets mode: +v phajdan-jr|afk [15:03:32] *** AaronMT has joined #chromium [15:05:09] *** kcbanner has joined #chromium [15:06:45] *** kliegs has joined #chromium [15:09:51] *** MikeSmithW3C has quit IRC [15:12:04] *** wers has quit IRC [15:14:20] *** MikeSmithW3C has joined #chromium [15:15:17] *** felipe` has joined #chromium [15:19:35] *** MikeSmithW3C has quit IRC [15:23:46] *** Martijnc has joined #chromium [15:27:57] *** kRush has quit IRC [15:31:12] *** thakis_ has quit IRC [15:32:16] *** Illyism has joined #chromium [15:32:53] *** slavka`1 has joined #chromium [15:32:57] *** kRush has joined #chromium [15:33:54] *** leeight has joined #chromium [15:34:01] *** leeight has left #chromium [15:34:29] *** nifiga has quit IRC [15:34:41] <thomasvl> glider: is anyone working on the busted chromeos bot? ie-should we close until that is fixed? [15:35:14] *** slavka` has quit IRC [15:35:17] <glider> thomasvl: at the moment I'm opening new bugs and working on the suppressions [15:35:51] <glider> thomasvl: I guess it's ok not to close [15:36:01] <thomasvl> sorry, main waterfall, not valgrind [15:36:18] <thomasvl> it's been failing for almost the height of console [15:37:17] <thomasvl> it looks like some reverts were tried (according to status), but that got lost from status along the way and so isn't being tracked [15:37:22] <thomasvl> glider: ^^ [15:38:10] <thomasvl> ananta / joth : yt? [15:38:37] <joth> thomasvl: y [15:38:57] <thomasvl> any ideas on the failing bot? (going from your updates to status) [15:39:03] *** shreyas has joined #chromium [15:39:13] <glider> thomasvl: oh, I see. Looks like I've removed it after the automatic close [15:39:47] <thomasvl> given how the tree started this week, i'd just like to make sure we don't let in another long standing failure. :( [15:40:04] <joth> originally just unit_tests was failing. I made a revert which fixed that, but in the meantime something else broke and I didn't yet get chance to chase that one :-/ [15:41:26] <shreyas> what does the method TabStripModel::MoveTabContentsAt() in "chrome/browser/tabs/tab_strip_model.h" ? it does not seem to work [15:41:27] <thomasvl> ok, closing [15:41:33] <trungl-bot> Tree closed by thomasvl at chromium dot org: Tree closed, ChromiumOS builder has collected errors -> ??? [15:41:46] <thomasvl> i'll try to help dig in a moment, but we probably shouldn't let me come in [15:43:43] <joth> looks like it was the webkit roll http://src.chromium.org/viewvc/chrome?view=rev&revision=49374 [15:44:06] <joth> hamaji: ^^ [15:44:08] <thomasvl> yusukes also made things worse it seems [15:46:22] <thomasvl> http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7958 goes to 18 failing from 5 the run before [15:48:57] <shreyas> anyone know why TabStripModel::MoveTabContentsAt() doesnt work as expected [15:49:34] <thomasvl> joth: it's night in TOK, suggestions? [15:50:10] <hamaji> joth: hmm something was broken by my wk roll? [15:50:24] <thomasvl> hamaji: chromiumos browser_tests [15:50:27] <joth> cros browser tests started to fail [15:50:38] <thomasvl> looks like yusukes cl after you made things worse [15:51:02] <thomasvl> i guess i'll revert yusukes in the mean time to get back down the number of failures [15:51:20] <glider> thomasvl: I'm going to land a cros suppression to make the Valgrind bots greener, is that ok? [15:51:20] <joth> SGTM, it's a small change so should be easy to roll back [15:51:35] <joth> thomasvl: ^ [15:52:02] <thomasvl> glider: give me a second to get this drover ready, then we can land them together for a single spin. [15:52:33] <joth> hamaji: the browser test error from the roll are the ones in http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7957 [15:52:34] <glider> thomasvl: ok, will monitor the waterfall [15:53:29] <thomasvl> glider: commit it now (i'm about to also) [15:53:54] <thomasvl> in [15:53:56] <glider> thomasvl: done [15:54:00] <thomasvl> glider: tx [15:55:18] <hamaji> hmm it is crashing :( let me take a look shortly [15:56:26] <hamaji> joth: i think this is the first browser_test break http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7954 and this is the second http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7955 [15:56:37] <hamaji> joth: it looks like the failing test is changing? [15:57:39] <hamaji> after r49375, UserNotPassed and UserPassed seem to be always failing [15:58:24] <hamaji> however, in r49374, the failing test is TestSchemeInspector and this isn't failing after r49375. maybe TestSchemeInspector is just flaky? [16:00:00] <hamaji> so, i'm guessing we need to revert r49375, not webkit roll? [16:00:46] <joth> hamaji: good point. r49375 also looks related to the revision thomasvl just reverted... [16:01:23] *** kphanee has quit IRC [16:01:49] *** kphanee has joined #chromium [16:01:52] *** bradleymeck has joined #chromium [16:03:12] <thomasvl> hamaji / joth : want me to nuke r49375? [16:03:44] *** rsesek has joined #chromium [16:03:44] *** ChanServ sets mode: +v rsesek [16:05:06] *** Kernel-Panic has quit IRC [16:05:11] <thomasvl> hamaji / joth : i think i will nuke that one [16:05:18] <thomasvl> we can always spin it back in if need be [16:05:30] <rsesek> I'm going to revert a CL to get CrOS back to green [16:05:38] <joth> thomasvl: seems reasonable. [16:06:00] *** Kernel-Panic has joined #chromium [16:06:23] <joth> looks like r49375 should be a clean rollback now [16:06:51] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree closed [rsesek reverting] [16:07:21] <joth> rsesek: which CL are you reverting? [16:07:23] <thomasvl> rsesek: already done [16:07:27] <rsesek> joth: oh I see [16:07:28] <rsesek> hm [16:07:33] <rsesek> why is it not green?!?! [16:07:43] <thomasvl> just landed the second one [16:07:50] <joth> 3 separate reverts were needed, bots still catching up [16:08:30] <thomasvl> well, we hope this is all it takes [16:08:31] <thomasvl> :) [16:08:37] <rsesek> heh [16:08:37] <joth> +1 [16:08:52] <thomasvl> #@&#@** windows bot is purple [16:08:54] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree closed [cycling green] [16:09:13] <rsesek> thomasvl: needs svn cleanup [16:09:21] <rsesek> in third_party\icu [16:09:29] <thomasvl> let me see if i can do that [16:09:46] <rsesek> glider: have you been trying to green CrOs valgrind? [16:10:11] <glider> rsesek: yes, a bit [16:10:25] <thomasvl> not sure why that bot didn't self heal [16:10:29] <rsesek> glider: is there anything you haven't looked at? [16:10:40] *** roc has joined #chromium [16:11:25] <glider> rsesek: I have landed a suppression for IOJankObserver, looks like it's the only problem at the moment [16:11:34] <rsesek> glider: sg, thanks [16:15:41] *** roc has quit IRC [16:15:48] <thomasvl> oh, it's out of disk space [16:15:54] <thomasvl> maruel: yt? [16:15:58] <maruel> thomasvl: pong [16:16:02] <maruel> what slave? [16:16:16] *** roc has joined #chromium [16:16:20] <thomasvl> maruel: codf134 [16:16:29] <thomasvl> http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(1)/builds/24158/steps/gclient/logs/stdio [16:16:34] <thomasvl> maruel: ^^ [16:17:57] <thomasvl> rsesek: the good news is the failing test count is dropping with each revert [16:18:03] <rsesek> heh [16:18:51] <rsesek> what's up with BrowserTest.RevivePhantomTab? [16:18:59] <rsesek> on XP [16:19:58] <thomasvl> chromiumos builder on the last revert now [16:20:41] *** malavv has quit IRC [16:21:15] <maruel> doing [16:21:46] <thomasvl> maruel: tx. why do they run out of space? just from more src being pulled in? or something getting left around? [16:21:58] <maruel> don't know yet [16:22:26] *** tedoc2000 has joined #chromium [16:25:56] <thomasvl> rsesek / glider : either of you look at the mem waterfall in console mode? [16:26:03] <rsesek> thomasvl: y [16:26:11] *** darwin has joined #chromium [16:26:19] <thomasvl> know what test to skip on the mac so that stops happening? [16:26:43] *** spot has quit IRC [16:26:44] *** spot has joined #chromium [16:26:49] * thomasvl hasn't looked yet [16:26:56] <thomasvl> but it's at 13 hours again [16:27:18] *** malavv has joined #chromium [16:27:20] <glider> thomasvl: dunno [16:28:15] <thomasvl> i'll log into it and see what's running [16:28:49] <rsesek> thomasvl: it looks like it finished and is now hung [16:29:04] *** trungl has quit IRC [16:30:28] *** malavv_ has joined #chromium [16:32:41] <thomasvl> the binary isn't running [16:32:50] <thomasvl> and the bluetooth updater is on screen again [16:32:56] <rsesek> thomasvl: what about memcheck_analyze.py? [16:33:07] <joth> thomasvl: looks like we're almost there http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/7966 :) [16:33:42] <thomasvl> bounced it and will make sure i check that the bluetooth updater isn't on screen again [16:34:20] *** malavv has quit IRC [16:34:45] *** hagabaka has joined #chromium [16:34:45] *** hagabaka has joined #chromium [16:34:50] <thomasvl> joth: sweet! [16:35:45] <rsesek> thomasvl: do you have any thoughts on why 10.6 perf is so flaky? [16:35:54] *** trungl has joined #chromium [16:35:54] *** ChanServ sets mode: +v trungl [16:37:48] <thomasvl> rsesek: the ui_test had exited, but the renderer was still going [16:37:56] <rsesek> thomasvl: there was a crash [16:37:59] <rsesek> so that seems possible [16:38:00] <thomasvl> so the script was probably stuck waiting for all kids to exit [16:39:26] <rsesek> CrOS went green! [16:40:18] <thomasvl> rsesek: i'd say talk to chase, the range might just be a little too tight for how much it shifts in normal runs [16:40:33] <rsesek> ok [16:40:51] <rsesek> I think we're ready to open [16:41:51] *** malavv_ has quit IRC [16:42:11] *** tedoc2000 has quit IRC [16:42:17] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open [16:42:25] <thomasvl> rsesek: i take that back [16:42:30] <thomasvl> shutdown tests are actually failing [16:42:42] <thomasvl> rsesek: time to talk to trungl [16:42:55] <trungl> ? [16:43:33] <rsesek> trungl: http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2)/builds/4092/steps/startup_test/logs/stdio [16:43:51] <rsesek> ShutdownTest.TwentyTabsUserQuit [16:44:03] <thomasvl> one other failure was a different shutdown test [16:44:15] <thomasvl> they happen to start with a webkit roll, which is never a good sign [16:44:22] <thomasvl> and are off and on, but more on it seems [16:44:30] <thomasvl> (then before that cl) [16:44:36] <rsesek> thomasvl: this has been a problem for all 3 days I've been sheriff I think [16:45:04] <thomasvl> rsesek: can you collect the failing tests and drop it in a bug [16:45:17] <rsesek> thomasvl: y; I'm backtracking it now [16:45:56] <thomasvl> rsesek: tx [16:45:56] <trungl> from the looks up of, it seems that the pages it tries to load aren't loading [16:46:05] <trungl> looks of it, that is [16:46:07] * trungl can't type [16:46:16] <trungl> (or at least the right notifications aren't sent) [16:46:31] <trungl> so it makes sense that a webkit problem could cause this [16:47:20] <thomasvl> could also be a race in the test itself, that is just easier to hit on that bot? :( [16:47:30] *** malavv has joined #chromium [16:47:41] <thomasvl> ie-something happens before something is registered to hear it, etc. [16:48:42] *** tonyg-cr has joined #chromium [16:48:42] *** ChanServ sets mode: +v tonyg-cr [16:49:38] <rsesek> it's been happening since at least a week [16:49:42] <rsesek> but it seems to be getting more frequent [16:50:58] <trungl> thomasvl: that might be possible, I suppose; I don't know offhand [16:51:57] <thomasvl> maruel: any luck with that bot? [16:52:04] *** dmaclach has joined #chromium [16:52:48] <maruel> thomasvl: it didn't heal? [16:52:57] <maruel> I seems it can't fit build.dead anymore [16:53:15] <thomasvl> maruel: wasn't sure, it's still doing a checkout [16:53:20] <thomasvl> so i wasn't sure if this time would work [16:53:25] <maruel> ok it should be fine then [16:53:42] <thomasvl> maruel: tx [16:56:45] *** gajop has joined #chromium [16:57:25] <rsesek> is there any way to paginate the console view? [16:58:20] <thomasvl> rsesek: nope. new console might have it [16:59:45] <rsesek> trungl, thomasvl: http://code.google.com/p/chromium/issues/detail?id=44067 [17:01:04] *** tonyg-cr has quit IRC [17:02:06] *** MikeSmithW3C has joined #chromium [17:03:00] *** shreyas has quit IRC [17:04:57] *** dmaclach has quit IRC [17:06:55] *** skerner has joined #chromium [17:07:05] *** dmaclach has joined #chromium [17:09:36] *** robarnold|eviltw is now known as robarnold [17:11:38] *** shreyas has joined #chromium [17:14:25] *** trungl has quit IRC [17:14:26] *** tedoc2000 has joined #chromium [17:14:33] *** trungl has joined #chromium [17:14:34] *** ChanServ sets mode: +v trungl [17:15:24] *** tonyg-cr has joined #chromium [17:15:24] *** ChanServ sets mode: +v tonyg-cr [17:15:48] *** dmaclach has quit IRC [17:18:08] <shreyas> where is the HTML code of a particular site loaded in a tab stored exaclty?? how can you access it?? [17:19:10] <rsesek> shreyas: TabContents holds a RenderViewHost, which corresponds to a RenderView in another process, which holds a WebFrame, which has a WebCore::Frame, which has the HTML [17:19:46] *** dmaclach has joined #chromium [17:19:58] <shreyas> rsesek: where is the rendered HTML stored? [17:21:40] <rsesek> shreyas: in the WebCore::Frame's DocumentLoader [17:22:13] <shreyas> rsesek: awsm, thnx a lot [17:22:47] *** sshc has quit IRC [17:23:16] <rsesek> jochen__: ping [17:23:46] <bauerb> rsesek: not sure if jochen's there, he's ooo at the moment [17:24:04] <rsesek> bauerb: he committed two things and I think one of them caused a perf rgression [17:25:58] *** tedoc2000 has quit IRC [17:26:06] <rsesek> bauerb: is he eisinger? [17:26:09] <rsesek> @google [17:26:16] <bauerb> rsesek: yes [17:26:39] *** tedoc2000 has joined #chromium [17:28:09] *** trungl has quit IRC [17:31:13] *** Erkan_Yilmaz has joined #chromium [17:32:21] *** kinnetica has quit IRC [17:32:54] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open [XP Perf -> jochen?] [17:33:52] *** skerner has quit IRC [17:35:44] *** tonyg-cr has quit IRC [17:38:26] *** kinnetica has joined #chromium [17:40:56] *** tonyg-cr has joined #chromium [17:40:56] *** ChanServ sets mode: +v tonyg-cr [17:47:25] *** Venom_X has joined #chromium [17:55:42] *** thakis_ has joined #chromium [17:55:42] *** ChanServ sets mode: +v thakis_ [17:59:13] *** GeekShadow has quit IRC [18:04:57] <rsesek> anyone familiar with the perf tests? [18:07:40] *** Venom_X has quit IRC [18:08:01] *** pinkerton has joined #chromium [18:08:01] *** ChanServ sets mode: +v pinkerton [18:09:23] *** jrmuizel has joined #chromium [18:11:19] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "compile" on "Chromium Builder (dbg)" from 49401: dmaclach at chromium dot org, podivilov at chromium dot org, rogerta at google dot com) [18:11:58] <rsesek> LINK : fatal error LNK1318: Unexpected PDB error; UNKNOWN (24) '' [18:13:11] *** mahemoff has quit IRC [18:14:11] <dmaclach> don't think it's me [18:14:12] *** dglazkov has joined #chromium [18:14:12] *** ChanServ sets mode: +v dglazkov [18:14:22] <dglazkov> good morning, Chromium! [18:14:22] <trungl-bot> dglazkov: Good morning! [18:14:26] <rsesek> I think that may be a bot issue [18:14:53] <rsesek> maruel: ping [18:15:00] <maruel> rsesek: pong [18:15:14] <rsesek> maruel: LINK : fatal error LNK1318: Unexpected PDB error; UNKNOWN (24) '' on Chromium Builder dbg [18:15:25] <maruel> rsesek: force a clobber or just a build [18:15:29] <maruel> IB is unhappy these days [18:15:31] <rsesek> okay [18:16:40] <thakis_> trungl-bot: say hello to dglazkov from me too, please [18:16:41] <trungl-bot> thakis_: Error: "say" is not a valid command. [18:16:58] <dglazkov> trungl-bot: help [18:16:59] <trungl-bot> dglazkov: The help command is "halp" (blame thakis for this). [18:17:09] * dglazkov blames thakis_ [18:17:16] <thakis_> thakis! not me! [18:17:52] <dglazkov> oh. sorry, thakis_ [18:18:15] *** slavka`1 has quit IRC [18:18:22] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed [Chromium-dbg -> clobbered] [XP Perf -> jochen/rsesek] [18:18:35] <dglazkov> I can barely tell you guys apart. The coccygeal process is easy to miss [18:19:23] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open [Chromium-dbg -> should go green] [XP Perf -> jochen/rsesek] [18:19:41] *** Venom_X has joined #chromium [18:20:34] *** mahemoff has joined #chromium [18:21:44] *** xji has joined #chromium [18:21:49] *** chaitanyag has quit IRC [18:21:51] <thakis_> what's trungl-bot's status report latency? or does it just not report open->open transitions? [18:22:10] *** garykac has joined #chromium [18:22:39] *** ivan has quit IRC [18:22:43] *** sshc has joined #chromium [18:23:02] <trungl_away> thakis_: should be about a minute [18:23:31] <trungl_away> well, less than a minute [18:23:36] <trungl_away> on average 30-seconds-ish [18:23:45] <trungl_away> trungl_away: treestatus [18:23:58] <trungl_away> trungl-bot: treestatus [18:23:59] <trungl-bot> trungl_away: An error has occurred and has been logged. Please contact this bot's administrator for more information. [18:24:04] <trungl_away> ahhhhhhhhhh [18:24:50] * thomasvl bets trungl_away can't handle '!' in his bot scripts [18:25:12] <trungl_away> can't handle unicode, apparently [18:25:14] <trungl_away> sigh [18:25:34] <thomasvl> ah, different kind of failure. :) [18:25:54] <jcivelli> rsesek: I see couple of werid leaks in ChromeOS valgrind, looking [18:26:10] <rsesek> jcivelli: thanks. I'm sorting out perf with jochen [18:27:58] *** ivan has joined #chromium [18:29:40] *** trungl-bot has quit IRC [18:30:14] <rsesek> chase: yt? [18:32:48] *** trungl-bot has joined #chromium [18:33:40] *** GeekShadow has joined #chromium [18:35:41] *** malavv has quit IRC [18:35:52] *** trungl-bot has joined #chromium [18:36:02] <trungl_away> trungl-bot: treestatus [18:36:04] <trungl-bot> trungl_away: An error has occurred and has been logged. Please contact this bot's administrator for more information. [18:36:06] <trungl_away> crap [18:36:20] *** trungl-bot has quit IRC [18:37:01] <pinkerton> lol [18:39:15] *** RT|Chatzilla has quit IRC [18:39:58] *** skydrome has quit IRC [18:40:12] *** trungl-bot has joined #chromium [18:40:18] *** trungl_away is now known as trungl [18:40:24] <trungl> trungl-bot: treestatus [18:40:25] <trungl-bot> trungl: An error has occurred and has been logged. Please contact this bot's administrator for more information. [18:40:29] <trungl> sigh [18:40:45] <trungl> pinkerton: shouldn't you be enthralled by some exciting new thing at wwdc? [18:41:18] * rsesek needs someone familiar with perf_expectations.json [18:41:39] <pinkerton> trungl: yeah. i'm playing with shiny things. [18:41:59] *** thakis_ has quit IRC [18:42:13] <trungl> pinkerton: did you buy some new jewelry [18:42:14] <trungl> ? [18:42:31] *** BenL has quit IRC [18:43:38] *** trungl-bot has quit IRC [18:43:44] *** trungl-bot has joined #chromium [18:44:03] *** sitsofe has joined #chromium [18:44:08] <trungl> unicursday comes around and breaks trungl-bot [18:44:17] <trungl> trungl-bot: treestatus [18:44:18] <trungl-bot> trungl: Tree status set by rsesek at chromium dot org: Tree is open! [XP Perf \u2192 jochen/rsesek] [18:44:51] <sitsofe> do questions like "chrome crashes 100% of the time when I do X" go to #chromium-support? [18:45:05] <sitsofe> s/chrome/chromium [18:47:56] <willchan> sitsofe: http://new.crbug.com [18:48:17] *** trungl-bot has quit IRC [18:48:24] *** trungl-bot has joined #chromium [18:49:40] <sitsofe> willchan: aw, I'm going to have to sign in :) But really I want to check if it happens for anyone else before I file it... If it's a one off or a quirk of my system then... [18:49:49] *** stevenjb has joined #chromium [18:50:03] *** tonikitoo has quit IRC [18:50:09] <sitsofe> (For what it's worth I could get the crash to happen with firefox 3.5) [18:50:20] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open! [XP Perf \u2192 jochen/rsesek] [test] [18:50:57] <willchan> sitsofe: if you have a reproducible URL that crashes for you, we'd like to know. [18:51:27] <sitsofe> willchan: well I hate reporting bugs that only I can reproduce hence the reason I'm asking first [18:52:02] <sitsofe> and this particular setup is "quirky" (a downloaded nightly on Slackware 64 which isn't one of your supported platforms) [18:52:27] *** dhollowa__ has joined #chromium [18:52:35] <willchan> sitsofe: i see. i'd recommend just filing a bug report. [18:52:45] <willchan> we'll close it if it's not reproducible. [18:53:02] <trungl> escaped characters will have to do for now [18:53:21] <sitsofe> willchan: heh. OK well if I remember I'll try and test on a Fedora and Ubuntu system and get around to filing it [18:53:21] <trungl-bot> Tree opened by viettrungluu at chromium dot org (:trungl): Tree is open! [XP Perf \u2192 jochen/rsesek] [18:53:40] <sitsofe> I guess that means I should really check to see if you have any Flash or Linux bugs in the db already... [18:54:20] <willchan> haha, we have a lot of those :) [18:54:26] *** bratsche is now known as br-away [18:54:31] <trungl> Flash bugs? [18:54:32] <willchan> flash-- [18:54:34] <trungl> impossible! [18:54:38] <sitsofe> heh [18:54:42] <trungl> lalala [18:54:43] <willchan> inconceivable! [18:54:48] <sitsofe> willchan: hmm you weren't joking [18:54:51] * trungl puts his fingers in his ears. [18:58:32] *** skydrome has joined #chromium [18:59:00] *** pinkerton has quit IRC [18:59:04] <sitsofe> ah great and now the issue has magically resolved itself [19:00:46] <rsesek> thomasvl: valigrind-4 is going to need another kick [19:00:48] <rsesek> BookmarksUITest.TwoCommandsOneTab crashes [19:00:52] <jcivelli> willchan: seems like http://codereview.chromium.org/2763004 might have triggered a leak on ChromeOS valgrind [19:00:55] <rsesek> and we'll get the hug children [19:00:58] *** zloidemon has quit IRC [19:01:04] *** skydrome has quit IRC [19:01:22] <thomasvl> rsesek: looking [19:01:28] *** skydrome has joined #chromium [19:01:29] <rsesek> thomasvl: I'm adding it to the skip list [19:01:42] <willchan> jcivelli: i think glider submitted a suppression [19:01:42] <thomasvl> k, let me know when it is in and i'll kick it [19:01:44] <rsesek> sg [19:02:15] <jcivelli> willchan: Ah ok, great [19:02:25] *** bigbluehat has joined #chromium [19:02:31] <willchan> ping me if it doesn't go away [19:02:36] <willchan> i'm working on a fix [19:03:51] <thomasvl> rsesek: isn't it just updating? [19:03:58] *** zloidemon has joined #chromium [19:04:06] <rsesek> thomasvl: oh weird [19:04:13] *** pinkerton has joined #chromium [19:04:13] *** ChanServ sets mode: +v pinkerton [19:04:19] <rsesek> then maybe the crashing test wasn't what caused the hang [19:05:23] <rsesek> thomasvl: still worth it to file a bug re: the crash? [19:05:37] *** thakis_ has joined #chromium [19:05:37] *** ChanServ sets mode: +v thakis_ [19:06:12] <thomasvl> can't hurt to log it as possible [19:06:22] *** MikeSmithW3C has quit IRC [19:08:02] *** thakis__ has joined #chromium [19:08:03] *** ChanServ sets mode: +v thakis__ [19:08:20] <thomasvl> maruel / nsylvain : master having issues? [19:08:30] <thomasvl> things just go slow and i'm getting some proxy errors for some pages [19:08:35] *** bigbluehat has left #chromium [19:09:03] <rsesek> taking lunch. bbiab [19:09:06] <maruel> thomasvl: probably the proxy then [19:10:07] *** thakis_ has quit IRC [19:11:23] *** malavv has joined #chromium [19:11:58] <thakis__> trungl: i broke your bot! [19:12:00] * thakis__ beams [19:12:44] * thakis__ 's coccygeal process is unstoppable it seems [19:12:50] <trungl> thakis__: what did you do? [19:12:55] <trungl> trungl-bot: fortune [19:12:57] <trungl-bot> trungl: My Aunt MAUREEN was a military advisor to IKE & TINA TURNER!! [19:13:13] * trungl will just have to fix not-his-own-code [19:13:16] <thakis__> trungl: i put unicode arrows in the tree status [19:13:21] <trungl> oh, that [19:13:25] *** phajdan-jr|afk is now known as phajdan-jr [19:13:56] <pinkerton> wtf, my laptop just thought it was in dallas [19:14:02] <trungl> trungl-bot: treestatus [19:14:03] <trungl-bot> trungl: Tree status set by viettrungluu at chromium dot org: Tree is open! [XP Perf \u2192 jochen/rsesek] [19:14:47] <thakis__> hrm [19:14:48] *** Venom_X is now known as Venom_lnch [19:15:10] *** _rs has joined #chromium [19:15:41] *** fqian has joined #chromium [19:15:46] *** mahemoff has quit IRC [19:17:34] *** Neoteric has quit IRC [19:17:35] *** JoJo_CN has joined #chromium [19:18:37] <trungl-bot> Tree opened by thakis at chromium dot org: Tree is open! \u2603 XP Perf \u2192 jochen/rsesek \u2603 [19:18:41] *** dhollowa__ has quit IRC [19:18:55] <thakis__> lame [19:19:26] <evmar> lawls [19:20:52] *** rvargas has joined #chromium [19:22:33] *** lianj has quit IRC [19:23:14] *** Neoteric has joined #chromium [19:24:41] *** lianj has joined #chromium [19:25:15] <jcivelli> senorblanco: yt? [19:30:19] *** jamesr has joined #chromium [19:31:48] *** tonikitoo has joined #chromium [19:34:47] *** RavuAlHemio has joined #chromium [19:35:51] <jcivelli> Does anbody know what is going on with the reliability bot? It's been failing regularly with V8 out of memory errors since May [19:36:58] *** glider has quit IRC [19:40:08] <thomasvl> jcivelli: i tried to log a suppression the other day for it (in the middle of the nightmare cleanup day), but i guess it doesn't cover all that is happening. [19:40:32] *** abarth has joined #chromium [19:40:32] *** ChanServ sets mode: +v abarth [19:41:43] *** RavuAlHemio has quit IRC [19:43:50] *** altan has joined #chromium [19:43:54] *** dhollowa__ has joined #chromium [19:44:23] <altan> In the bug report area, what does label "Mstone-X PlatformParity" mean? [19:44:29] <altan> I get the last part obviously but not the firt [19:44:32] <altan> *st [19:44:44] *** JoJo_CN has quit IRC [19:45:06] <pinkerton> it has been triaged, but not targeted for a specific near-term milestone [19:45:10] <jcivelli> thomasvl: I see the suppression now. Looks like the stack changed recently. I'll update the regression with the new stack [19:45:32] *** dhollowa__ has quit IRC [19:45:42] *** dimich has joined #chromium [19:45:53] <altan> I see, thanks [19:47:34] *** shreyas has quit IRC [19:51:57] *** apavlov has quit IRC [19:52:35] *** shreyas has joined #chromium [19:52:56] *** pinkerton has quit IRC [19:52:59] *** trungl is now known as trungl_away [19:55:57] *** trungl has joined #chromium [19:55:57] *** ChanServ sets mode: +v trungl [19:56:17] *** zel has joined #chromium [19:59:58] *** phajdan-jr is now known as phajdan-jr|afk [20:03:21] *** dhollowa__ has joined #chromium [20:05:06] *** kcbanner has quit IRC [20:05:50] *** paulgrous has joined #chromium [20:06:47] <rsesek> back [20:10:02] *** thakis__ has quit IRC [20:10:18] <jshin> i'm gonna mark AccountScreenTest.TestSchemeInspector as flaky (it keeps failing interminttenly) [20:10:22] *** jamesr has quit IRC [20:12:26] *** General1337 has joined #chromium [20:13:49] *** _rs has quit IRC [20:14:04] *** dale1v has joined #chromium [20:14:05] *** dale1v has joined #chromium [20:14:35] *** paulgrous has quit IRC [20:15:12] *** awong_ has joined #chromium [20:15:38] *** ChanServ sets mode: +v awong_ [20:16:06] *** dhollowa__ has quit IRC [20:16:26] *** dhollowa__ has joined #chromium [20:17:24] *** JoJo_CN has joined #chromium [20:17:33] *** paulgrous has joined #chromium [20:18:07] *** thakis_ has joined #chromium [20:18:07] *** ChanServ sets mode: +v thakis_ [20:18:33] *** JoJo_CN has quit IRC [20:18:37] *** JoJo_CN has joined #chromium [20:19:42] *** kcbanner has joined #chromium [20:22:29] *** brettw has joined #chromium [20:22:29] *** ChanServ sets mode: +v brettw [20:22:54] <shreyas> rse [20:23:18] <brettw> DeviceContext2D is failing on Linux 64 and it's my fault (just enabled this test). I'll disable it, but am planning on waiting for other platforms to see what they think about the test [20:23:25] <shreyas> sry wrong channel [20:24:09] <sitsofe> willchan: looks like the problem is intermittent and is tied to the Flash 64 plugin (crashes firefox 3.5 entirely when it strikes) [20:24:58] <evmar> sitsofe: you should try a current firefox, it protects itself from plugin crashes [20:25:58] <sitsofe> evmar: it was more to see what happened rather than daily browsing (which I tend to do in chromium) [20:26:18] *** Mike1_ has joined #chromium [20:26:37] *** JoJo_CN has quit IRC [20:26:39] <sitsofe> the problem didn't happen in 32 bit firefox so it seems plugin related [20:27:14] *** inferno-sec has quit IRC [20:27:18] <thakis_> kbr_google: ping [20:27:19] *** sitsofe has quit IRC [20:27:30] <Mike1_> hey! Is there to have one tab-close button (for all tabs) on the right side? Like in Firefox 1.5 and older http://jira.atlassian.com/secure/attachment/18300/screenshot-1.jpg (not my screenshot ;) ) [20:27:30] <trungl-bot> Tree opened by jshin at chromium dot org: Tree is open! \u2603 XP Perf \u2192 jochen/rsesek \u2603, DeviceContext2D => brettw will disable on Linux64 after seeing how it goes elsewhere [20:27:32] <kbr_google> thakis_: hi [20:28:15] <thakis_> kbr_google: is there a document that explains the plan for accelerated compositing? i'm wondering if it's worth investing some time to improve backing_store_mac.mm. will this still be used once the gpu process goes live? [20:28:27] *** tittiatcoke has joined #chromium [20:28:35] *** Mike1_ is now known as Mike1 [20:29:31] <trungl-bot> Tree opened by rsesek at chromium dot org: Tree is open! \u2603 XP Perf \u2192 chase \u2603, DeviceContext2D \u261b brettw will disable on Linux64 after seeing how it goes elsewhere [20:30:32] <trungl-bot> Tree opened by brettw at chromium dot org: Tree is open! \u2603 XP Perf \u2192 chase \u2603, DeviceContext2D \u261b brettw disabled \u263a [20:31:02] <rsesek> thakis: you really say no to the COMPARE_SK_NS_IMG_SIZES? because gtest doesn't print line numbers of failures, it's helpful to have the original variable names [20:31:33] <trungl-bot> Tree opened by chase at chromium dot org: Tree is open! \u2603 XP Perf \u2192 chase (fix landed) \u2603, DeviceContext2D \u261b brettw disabled \u263a [20:32:10] <kbr_google> thakis_: vangelis at google dot com is the best person to email about the state of the compositing work. currently all effort is going into the windows port and other platforms will follow. i can say definitively however that backing_store_mac.mm will not be used to transmit the rendering results from the gpu process to the browser process. app/surface/accelerated_surface_mac.h, backed by IOSurface, will be the likely candidate. [20:32:46] *** diegocaro has joined #chromium [20:32:55] *** shreyas_ has joined #chromium [20:33:00] <thakis_> kbr_google: and this will just not work on 10.5? [20:33:04] <diegocaro> Hi, to all [20:33:15] *** asargent2 has joined #chromium [20:33:37] <thakis_> rsesek: can't you do something like ASSERT(FOO) << "some message"? [20:33:54] <thakis_> rsesek: if you really like the macro, at least put the args in parens in the body [20:34:06] *** dhollowa__ has quit IRC [20:34:22] <rsesek> thakis: okay. I like the macro because then the variable names get reported in the failure message, rather than just skia & cocoa [20:34:29] *** rohitkc has quit IRC [20:34:34] *** paulgrous has quit IRC [20:34:48] <atwilson> do people generally use the "git try --webkit" flag? It doesn't seem to be picking up my webkit changes in the patch file it sends up, so I wonder if it is busted again, or if I'm just Doing It Wrong. [20:35:31] <kbr_google> thakis_: 10.6 will be the initial target. we can consider backports once it is working well. dspringer mentioned there may be ways to use SPIs to get hardware accelerated rendering results from one process to another on 10.5, but accelerated_surface_mac.h/cc does work on 10.5, just not quickly [20:36:06] *** shreyas has quit IRC [20:36:14] <thakis_> kbr_google: thanks. would be great if a design doc about all this was written at some point, even if it was very rough [20:36:56] *** loislo has quit IRC [20:38:14] *** inferno-sec has joined #chromium [20:38:51] <kbr_google> thakis_: i'll mention it to vangelis. actually he says that the architectural survey he wrote up a while ago for the accelerated compositing code is still relevant, but you're right, i should write up the state of the mac code [20:39:07] <thakis_> kbr_google: where's that survey at? [20:39:09] <evmar> (i would like to read the equiv thing on linux, too) [20:39:42] *** tonyg-cr has quit IRC [20:40:42] <kbr_google> thakis_, evmar: on docs.google.com, search for vangelis; it's called "GPU Accelerated Rendering in Chrome", and he says it's pretty up to date [20:41:01] *** bers has joined #chromium [20:41:54] <thakis_> kbr_google: cool. could he move that to http://www.chromium.org/developers/design-documents at some point? [20:44:19] *** tusk has joined #chromium [20:44:37] *** thakis_ has quit IRC [20:44:44] <tusk> hello is there any reason to now be dependant to gnome-keyring?? [20:45:25] *** tonyg-cr has joined #chromium [20:45:25] *** ChanServ sets mode: +v tonyg-cr [20:45:48] *** bauerb has quit IRC [20:45:49] <jshin> brettw: ImageData (ppapi test) also fails on Mac. Is it also yours? [20:46:08] <brettw> jshin, yeah, I'll disable that as well [20:46:09] <brettw> :( [20:46:14] <jshin> :-) [20:47:26] <kbr_google> thakis_: emailed vangelis about that [20:47:27] <brettw> jshin, where is the failure? I don't see it [20:47:58] <jshin> http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/3812/steps/ui_tests/logs/ImageData [20:48:08] <brettw> jshin, ah, only on 10.6 [20:48:11] <brettw> this is exasperating [20:48:12] *** nthawEE has quit IRC [20:48:22] <jshin> also on 10.5 [20:48:31] <jshin> http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/16002/steps/ui_tests/logs/ImageData [20:49:24] *** asargent2 has quit IRC [20:50:38] <brettw> jshin, okay, disabled [20:50:51] <jshin> thanks [20:51:01] *** rektide_ is now known as rektide [20:51:47] <trungl-bot> Tree opened by jshin at chromium dot org: Tree is open! \u2603 XP Perf \u2192 chase (fix landed) \u2603, ui_test(DeviceContext2D/ImageData) \u261b brettw disabled \u263a [20:53:18] *** Waste is now known as afval [20:55:13] *** bers has quit IRC [20:58:27] *** jamesr has joined #chromium [20:58:56] <jshin> brettw: DeviceContext2D also fails on Windows XP [21:02:25] <maruel> atwilson: probably "busted again" [21:03:07] <pcgod> tusk: the reason is http://crbug.com/25404 [21:03:09] <maruel> atwilson: I'd like to fix it though [21:03:39] *** cbentzel_ has quit IRC [21:04:52] <tusk> pcgod: ok thx [21:06:05] *** edufelipe has joined #chromium [21:06:32] *** Erkan_Yilmaz_ has joined #chromium [21:07:12] <edufelipe> Hi folks! I'm having a strange behavior using dispatchEvent. http://dpaste.com/205764/ [21:07:36] <edufelipe> Could anyone check this out and see if it should display alert or not? [21:09:00] *** duffydack has joined #chromium [21:09:21] *** shreyas_ has quit IRC [21:10:06] *** Erkan_Yilmaz has quit IRC [21:10:10] *** BenMcLean has joined #chromium [21:10:29] *** BenMcLean has left #chromium [21:12:19] *** dhollowa__ has joined #chromium [21:12:49] *** nthawEE has joined #chromium [21:14:32] <tusk> http://erunways.com/html5/WebM_VP8_video/ << i0'm trying this page and it tells me my chromium doesn't support <video> tag, is that a problem from the page? i use the lattest svnchromium build [21:14:45] *** shreyas has joined #chromium [21:15:41] *** BryanWB has joined #chromium [21:16:09] *** dhollowa__ has quit IRC [21:23:20] <jshin> brettw seems away. i'm disabling Context2D on Win as well (it failed on multiple win bots) [21:31:32] *** Zxcvb_ has joined #chromium [21:32:28] <brettw> jshin, did you already do that? I just got back [21:32:50] *** asargent2 has joined #chromium [21:33:24] <Zxcvb_> can chrome frame completely replace msie (including mshtml, shdocvw, and urlmon)? [21:33:26] <jshin> brettw: yes, i just did. btw, Pepper3D failed on Vista [21:33:43] <brettw> jshin, Pepper3D is totally unrelated [21:33:46] <brettw> that's the old interface [21:33:48] <brettw> could be flaky [21:34:46] <jhawkins> brettw, jshin: why was the PPAPITest.DeviceContext2D test disabled instead of marked as FAILS_? [21:34:53] <jhawkins> it's not crashing or timing out, as far as I can see [21:35:07] <brettw> jhawkins, because I forgot about FAILS [21:35:24] <brettw> it's not a big deal for now, I'm actively working on it [21:35:39] <jhawkins> brettw: OK, thanks [21:36:24] <jshin> jhawkins: thanks for catching it. :-) [21:37:08] <jshin> brettw: maybe, Pepper3D is flaky, but somehow flakiness dashboard has just one run (on Vista) that failed. we'll see [21:38:19] *** Zxcvb_ has quit IRC [21:40:48] *** dpranke has joined #chromium [21:40:48] *** ChanServ sets mode: +v dpranke [21:42:12] *** mattm_g has quit IRC [21:44:09] *** thakis_ has joined #chromium [21:44:09] *** ChanServ sets mode: +v thakis_ [21:45:15] *** nth_ has joined #chromium [21:45:42] *** nthawEE has quit IRC [21:48:30] <trungl-bot> Tree opened by rsesek at chromium dot org: \xa1Tree is open! \u270e ui_test(DeviceContext2D, ImageData) \u261b brettw disabled \u263a [21:48:51] <fta> i briefly see an ugly page with a "Standard new tab page" link when i open the NTP (using trunk), i can't find that string in the sources. any idea where it could come from? http://people.ubuntu.com/~fta/chromium-ntp.ogv [21:49:05] *** phajdan-jr|afk has quit IRC [21:49:07] *** BryanWB has quit IRC [21:49:47] <fta> it seems to happen when i open the 1st ntp tab, not if i already have one open [21:50:01] *** Kunalagon has joined #chromium [21:50:05] *** loislo has joined #chromium [21:50:24] <trungl> damn unicursday [21:50:40] <rsesek> :D [21:50:54] <rsesek> 3rd day in a row as sheriff? my mind is starting to go [21:51:01] <rsesek> I can no longer write code, just valgrind suppressions [21:51:41] <thakis_> trungl: trungl-bot _needs_ to support unicode characters [21:51:48] <rsesek> I agree! [21:51:51] <thakis_> this channel is missing out on the awesome iTree status [21:52:03] <rsesek> revolutionary and magical iTree [21:52:10] <eglaysher> I am about to commit a huge GRD change. What bots do I have to kick (I accidently closed the tree yesterday because of this). [21:52:32] <rsesek> available in stores June 42 [21:52:37] <trungl> but where does it end? will trungl-bot need to support iVideoTree when that comes out too? [21:52:44] <rsesek> trungl: yes [21:52:55] <rsesek> eglaysher: I'm not familiar with the process of grd changes [21:52:59] <mirandac> eglaysher: two win bots, AFAIK [21:53:06] * trungl ponders making trungl-bot tweet tree status changes. [21:53:06] <rsesek> brb [21:53:08] <mirandac> eglaysher: coming to yr desk [21:53:15] <thakis_> trungl: first and foremost, it needs unicode support. the next priority is html5, and other stuff isn't that important [21:53:16] <rsesek> mirandac: thx [21:53:25] <trungl> thakis_: what about Flash? [21:53:40] <trungl> and Netflix! [21:54:08] <thakis_> trungl: html5 is an open standard [21:54:18] <thakis_> (i think that's the usual answer to all html5-related questions) [21:54:38] <trungl> but html5 isn't there yet [21:54:50] <trungl> (I think that's the other usual answer) [21:55:04] <trungl> I think trungl-bot also deserves its own YouTube channel [21:55:39] <akalin> i think trunGL should be a brand-new openGL implementation [21:55:40] <trungl> and be on chatroulette [21:55:43] <thakis_> trungl: but first things (== utf8) first [21:55:50] <thakis_> akalin++ [21:56:32] <trungl> clearly the top priority for trungl-bot should be 3-d support [21:56:43] *** dale1v is now known as dale1v[away] [21:58:37] <malavv> If we could include html5 video in tree status, would be nice [21:58:37] *** inferno-sec has quit IRC [21:59:39] <eglaysher> any redness after r49440 may be grd related, though mirandac pointed out all the bots that I'm supposed to kick. [21:59:56] *** tittiatcoke has quit IRC [22:00:16] <atwilson> maruel: I ran this command: "git try --webkit webkitFrameName frameName-webkit" but no webkit changes ended up in the final diff, even though I had changes committed to the webkitFrameName branch. Perhaps I've got the syntax wrong? [22:00:42] *** Martijnc has quit IRC [22:00:51] <maruel> atwilson: if you want to use multiple change list, you need to separate them with a coma [22:00:54] <maruel> comma [22:00:56] <jhawkins> eglaysher: how good did it feel to remove all that code? :-) [22:01:03] <maruel> is it a webkit checkout override? [22:01:09] <eglaysher> jhawkins: *very* good [22:01:13] *** thakis__ has joined #chromium [22:01:13] *** ChanServ sets mode: +v thakis__ [22:01:13] <jhawkins> lucky bastard ;) [22:01:25] <eglaysher> I wich it put me into negative lines for the month, but regretfully it didn't. [22:01:51] <mirandac> AFAIK, the bots to kick are XP (the leftmost bot), Win-Release and Win-Debug, for future reference. Unless everything turns red. [22:01:56] <atwilson> maruel: to be clear, I have a single CL in my webkit tree (webkitFrameName), and a single CL in my chromium tree (frameName-webkit). [22:02:07] <jhawkins> there are a few million other lines out there, gotta be something else you can remove [22:02:08] <atwilson> So I think that's the right syntax. [22:02:18] *** thakis_ has quit IRC [22:02:20] *** Illyism has left #chromium [22:04:53] *** glider has joined #chromium [22:07:59] *** zaspire has quit IRC [22:08:49] <jshin> maruel: link failed on 'Google Chrome XP' because the disk is full. what to do? [22:08:54] *** glider has quit IRC [22:09:28] <rsesek> jshin: no, it's probably address space exhaustion [22:10:47] <thakis__> everybody stand back and watch as i break the tree [22:10:56] *** inferno-sec has joined #chromium [22:11:18] <thakis__> if the flaky wwdc network doesn't die while git svn fetch syncs me up with head [22:11:59] <maruel> jshin: it's a flaky build, there's enough space [22:12:24] <thakis__> "Auto packing your repository for optimum performance. " [22:12:31] <thakis__> i really should set up that nightly job [22:12:40] <rsesek> thakis__: it just does it when necessary [22:13:06] <jshin> maruel: ok. thanks [22:13:54] <jshin> rsesek: thank you for the answer [22:13:56] <thakis__> rsesek: yes, and it's always annoying [22:13:58] *** bldld_ has joined #chromium [22:16:35] <thakis__> rsesek: need to switch rooms; revert me if i broke the tree [22:17:02] <rsesek> k [22:17:07] <rsesek> I would anyways :) [22:17:17] <thakis__> should i learn how to futureproof my ipad app or should i learn arcane details about coreanimation next? tought choice [22:17:28] <rsesek> coreanaimation! [22:17:42] *** pathorn has joined #chromium [22:18:05] <thakis__> yes, that's what i figured too [22:18:20] <thakis__> but "future proof your app" might tell me what direction the future's going in [22:20:36] <rsesek> unlikely [22:20:51] <rsesek> but if they do, hint: it'll be more evil [22:21:01] *** thakis__ has quit IRC [22:21:35] <evmar> thakis: you should use git pull, it's much faster [22:22:51] *** GeekShad0w has joined #chromium [22:23:23] *** br-away is now known as bratsche [22:23:34] *** nth_ has quit IRC [22:23:49] *** nth_ has joined #chromium [22:24:11] <maruel> thakis: ^^^^ [22:24:25] <maruel> git overload spoke, listen to git overload. [22:24:36] *** tonikitoo has quit IRC [22:24:39] *** GeekSh4dow has joined #chromium [22:25:53] *** GeekShadow has quit IRC [22:26:15] *** thakis_ has joined #chromium [22:26:15] *** ChanServ sets mode: +v thakis_ [22:27:43] <thakis_> i like how the tree status is happy that we finally disabled brettw [22:28:15] *** bweinstein has joined #chromium [22:28:18] <rsesek> heh [22:28:20] *** GeekShad0w has quit IRC [22:29:16] <jshin> at one point, brettw held a record of never breaking tree :-) [22:31:05] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "unit_tests" on "Vista Tests (dbg)(1)" from 49437: ian at chromium dot org (:ifette)) [22:32:10] <rsesek> eglaysher: ^ looks like grd fallout [22:32:19] <jshin> ian: your merge broke unit_tests on vista [22:32:56] <eglaysher> rsesek: probably not. ian's patch went in well before mine. [22:33:02] <rsesek> oh you're right [22:33:16] <rsesek> actually maybe not [22:33:28] <rsesek> extract build is orange [22:33:38] <rsesek> it could have pulled your build output [22:34:07] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed \u2620 Vista unit_tests \u2192 grd change\u261berg? \u270e ui_test(DeviceContext2D, ImageData) \u261b brettw disabled \u263a [22:34:22] <rsesek> eglaysher: that's what happened [22:34:27] <estade> i no longer like puppies [22:34:38] <eglaysher> wait, that can happen? [22:34:44] <rsesek> eglaysher: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20(dbg)(1)/builds/24674/steps/extract%20build/logs/stdio [22:34:59] <rsesek> it failed to get 437, so it pulled latest, which at the bottom is 440 [22:35:49] <estade> why is the tree status half written in wingdings [22:36:07] <rsesek> estade: it's unicode [22:36:31] <rsesek> as for why? boredom? [22:36:34] <rsesek> and fun [22:36:41] <estade> what is the pencil for [22:36:47] <rsesek> change that's been pending [22:36:52] <rsesek> something to note [22:37:32] <jshin> rsesek: once Emoji characters are finalized, you can use them to have 'animated characters' in the status :-) [22:37:51] <rsesek> jshin: that will be an exciting day. add that to trung's feature list [22:37:56] <estade> rsesek: not enough ?_? [22:38:06] *** mattm_g has joined #chromium [22:38:19] *** duffydack has quit IRC [22:38:25] <jshin> :-) [22:38:32] <evmar> oh snap, we need to add of disapproval to the tree closure regexps [22:39:01] <rsesek> eglaysher: are you kicking them? [22:39:22] <eglaysher> rsesek: I kicked the three windows builders earlier. [22:39:37] <eglaysher> I'm not sure what to do otherwise. [22:39:47] *** thakis_ has quit IRC [22:39:49] <rsesek> they should cycle green [22:39:57] <eglaysher> It's possible that they started building my change before I kicked them. [22:39:58] <rsesek> I think it usually takes 2 runs [22:40:03] <thomasvl> eglaysher: has another cl cycled through yet? that will clear the grd deps issues [22:40:27] *** thakis_ has joined #chromium [22:40:27] *** ChanServ sets mode: +v thakis_ [22:40:46] <eglaysher> there has been two patches after mine committed. [22:41:32] <thomasvl> ok, let that build through also to see [22:41:40] <rsesek> thomasvl: okay to open, though? [22:41:54] <thomasvl> rsesek: probably safer to wait to be sure [22:41:58] *** AaronMT has quit IRC [22:42:09] <rsesek> sure [22:42:19] *** csilv has left #chromium [22:42:21] *** tonikitoo has joined #chromium [22:42:41] *** bldld_ has quit IRC [22:43:14] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed \u2620 grd change \u2192 waiting for cycle \u270e ui_test(DeviceContext2D, ImageData) \u261b brettw disabled \u263a [22:43:41] <thakis_> trungl: is trungl-bot open source? [22:44:01] * rsesek feels like trung-bot could be the source of severe feature creep [22:44:41] <thakis_> like "trungl-bot supports html5, now chrome should be able to do that too"? [22:44:49] <edufelipe> Folks: http://stackoverflow.com/questions/3017910/dom-level-3-customevents-not-bubbling-on-webkit [22:45:04] <thakis_> edufelipe: wrong channel [22:45:29] <edufelipe> thakis_: Thanks! [22:45:29] *** ROBOd has quit IRC [22:45:37] *** edufelipe has left #chromium [22:46:24] *** csilv has joined #chromium [22:47:11] *** AaronMT has joined #chromium [22:55:44] <jcivelli> I talked with Ian, looks like his patch should not have caused any test failure [22:56:10] <jcivelli> Let's wait for the next cycle to see if things get better [22:57:34] *** ananta has quit IRC [22:58:21] *** bweinstein has quit IRC [23:01:40] *** erickt has quit IRC [23:02:53] *** bweinstein has joined #chromium [23:03:54] *** ifette has joined #chromium [23:03:55] *** ChanServ sets mode: +v ifette [23:05:35] <ifette> fyi, I am happy to roll my change back if necessary, but I talked with Jay and neither of us think it caused the breakage (was also fine on trybots). erg mentioned there was some wierdness where his change got pulled by the bots first, not sure what exactly is happening [23:05:52] <rsesek> ifette: it's not your change; it's erg's that had a grd change [23:07:01] *** tedoc2000 has quit IRC [23:07:06] <ifette> thx [23:08:01] *** Kunalagon has quit IRC [23:08:34] <trungl-bot> Tree closed by evan at chromium dot org (:evmar): \u2620 Tree is closed \u0ca0_\u0ca0 grd change \u2192 waiting for cycle \u270e ui_test(DeviceContext2D, ImageData) \u261b brettw disabled \u263a [23:09:11] <rsesek> I wonder if the creators of unicode realized how much joy they could spread with just a few bytes [23:09:13] <jhawkins> woah, whatsup with interactive ui tests? [23:09:34] <trungl-bot> Tree closed by jshin at chromium dot org: \u2620 Tree is closed \u0ca0_\u0ca0 grd change \u2192 waiting for cycle [23:09:52] <rsesek> jhawkins: got 440 (grd change) to test [23:10:22] <jhawkins> rsesek: grd change doesn't usually cause interactive ui test failures.. ? [23:10:58] <rsesek> jhawkins: [2472:776:0610/133809:541385281:FATAL:resource_bundle_win.cc(147)] Check failed: false. unable to find resource: 2937 [23:11:05] <rsesek> that smells like a grd change to me [23:11:08] <thomasvl> yup [23:11:22] <jhawkins> I'm not saying it's not, just that that's unusual [23:11:49] *** tedoc2000 has joined #chromium [23:12:21] *** Martijnc has joined #chromium [23:12:41] <trungl> thakis_: trungl-bot is not open source yet [23:12:54] <trungl> half because the code I wrote is too embarrassing to live [23:13:07] <thakis_> trungl: another reason that it should support html5. html5 is open [23:13:45] <thakis_> trungl: also, open sourcing stuff lets other people unembarrass your code, right? that's why we opensourced chrome after all [23:13:54] <jhawkins> nsylvain: fatal error LNK1106: invalid file or disk full: cannot seek to 0x18FBE60 on Google Chrome XP bot? [23:14:56] *** duffydack has joined #chromium [23:15:14] *** tedoc2000 has quit IRC [23:15:30] <jshin> jhawkins: maruel said that it's just a flaky bot [23:15:50] <jshin> hmm. it happens too often... [23:16:12] *** Kernel-Panic has quit IRC [23:16:25] <thomasvl> jshin / jhawkins : the belief is depending on code layout/etc. it some times runs out of address space linking [23:16:26] *** abarth_ has joined #chromium [23:16:26] *** ChanServ sets mode: +v abarth_ [23:16:39] <thomasvl> so each cl changes things slightly and some times it works, some times it doesn't [23:16:54] <thomasvl> we're just that close to 32bit addr space [23:17:43] *** Mike1 has left #chromium [23:18:31] <jshin> thomasvl: aha... [23:19:30] *** kinnetica has quit IRC [23:21:25] *** duffydack has quit IRC [23:22:40] *** abarth_ has quit IRC [23:25:45] <trungl-bot> Tree opened by rsesek at chromium dot org: \u2600 Open for business \u2600 \u270e grd change \u2192 cycling green [23:28:55] *** thomasvl has quit IRC [23:29:12] *** GeekSh4dow has quit IRC [23:30:06] <thakis_> trungl: STILL NO UNICODE SUPPORT< RAGE [23:30:15] <thakis_> who would've thought that an uppercase , is < [23:30:16] <trungl> thakis_: file a bug [23:30:22] <trungl> (in the circular filer) [23:30:23] <rsesek> seeing Actual: "Could not initialize 3D context" on vista-tests-dbg-3. the bot (codf237) may need to be bounced [23:30:25] <thakis_> trungl-bot: file [23:30:25] <trungl-bot> thakis_: Error: "file" is not a valid command. [23:30:58] <trungl> thakis_: you must provide me with correctly filled-out (paper) forms in triplicate [23:32:07] <thakis_> trungl-bot: submit paperwork [23:32:07] <trungl-bot> thakis_: Error: "submit" is not a valid command. [23:32:13] <thakis_> i can't! [23:32:15] <thakis_> catch 22 [23:33:02] <trungl> thakis_: I'm sure there's a procedure to deal with this; it must be written out somewhere [23:33:15] <thakis_> probably in some pascal code [23:33:49] <trungl> thakis_: if you like, I can help [23:33:58] <trungl> thakis_: just take a number and have a seat [23:34:08] <trungl> (and wait till your number is called) [23:34:13] * thakis_ takes 3 + 5i [23:34:18] <trungl> (or shows up on the display) [23:35:28] <rsesek> maruel: ping [23:37:38] *** _rs has joined #chromium [23:38:05] <rsesek> nsylvain: ping [23:38:51] <trungl> thakis_: 17 + 12i [23:39:27] <thakis_> trungl: at least the right quadrant [23:39:46] <trungl> thakis_: there was a 1 in 4 chance [23:40:19] *** agl has joined #chromium [23:40:20] *** ChanServ sets mode: +v agl [23:41:04] *** BCalvignac has quit IRC [23:41:55] <nsylvain> rsesek: pong [23:42:19] <rsesek> nsylvain: seeing "Could not initialize 3D context" on vista-tests-dbg-3. (codf237) [23:42:24] <rsesek> I think we fixed it last time with a reboot [23:42:33] <nsylvain> ok [23:42:38] <nsylvain> i can reboot it [23:42:41] <rsesek> thanks :) [23:45:00] <trungl-bot> Tree closed by buildbot at chromium dot org: Tree is closed (Automatic: "net_unittests" on "Linux Tests (dbg-shlib)(1)" from 49443: rsesek at chromium dot org) [23:45:08] <rsesek> um lies [23:46:42] <willchan> hm, i just made a net change [23:46:53] <willchan> i don't see any red on the buildbot for it though, where's the error? [23:47:01] <rsesek> willchan: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg-shlib)(1)/builds/2205 [23:47:01] <trungl-bot> Tree closed by rsesek at chromium dot org: Tree is closed \u2620 Linux net_unittests \u261b flake? [23:47:11] <inferno-sec> can anyone help to commit a webkit build fix [23:47:27] <rsesek> willchan: I don't see how it could be yours; it pulled rev 49443 to test [23:48:04] <willchan> ok, not me then, sounds like flake [23:48:20] <agl> inferno-sec: if it's a build fix then I can [23:48:39] <inferno-sec> yes , let me tell yu exactly the small change required [23:49:18] <rsesek> all other net_unittests passed, no clear owner -> reopening [23:49:22] <inferno-sec> do yu have the latest tree > 60973 [23:49:49] <inferno-sec> in WebImageCQ.cpp in WebKit/chromium/src/ [23:50:04] <trungl-bot> Tree opened by rsesek at chromium dot org: \u2600 Open for business \u2600 \u270e Linux net_unittests \u261b flake? [23:50:27] <inferno-sec> in two lines assign(*p) need to be changed to assign(p) [23:50:46] *** dhollowa__ has joined #chromium [23:50:55] <dimich> agl, inferno-sec: I have the up to date tree, doing webkit rolls today. I'll can land it. [23:51:16] <inferno-sec> thanks a lot dimich [23:51:29] <dimich> inferno-sec: thanks for headsup :-) [23:52:28] <inferno-sec> thanks for yu for helping me. hopefully i will be committer after few more webkit patches [23:56:41] *** dhollowa__ has quit IRC [23:56:58] <earyoyo> Exception: Call to 'pkg-config --cflags gnome-keyring-1' returned exit status 1. while loading dependencies of src/base/base.gyp while loading dependencies of src/net/net.gyp while loading dependencies of src/app/app.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp [23:57:03] *** loislo has quit IRC [23:57:08] <earyoyo> anybody seen this? [23:57:16] <agl> earyoyo: you need to install the devel packages for gnome-keyring [23:57:18] <rsesek> earyoyo: see mail on cr-dev [23:58:36] <earyoyo> thx [23:59:04] *** bweinstein has quit IRC