[00:00:18] <stuartmorgan> Mac version landed as well [00:00:45] *** joshia1 has quit IRC [00:02:00] *** ese has joined #chromium [00:02:11] *** miketaylr has quit IRC [00:02:33] *** reiko has quit IRC [00:03:07] *** Kunalagon has quit IRC [00:03:51] *** rbansal has joined #chromium [00:06:23] *** pinkerton has quit IRC [00:08:04] <jshin> jrg: have you seen NPAPTester.ManyPlugins fail on regular bots? [00:08:17] <jshin> regular meaning non-valgrind bot? [00:08:29] *** joshia has joined #chromium [00:08:55] <jshin> stuartmorgan disabled it on mac valgrind bot. if you haven't, i guess we have to remove FLAKY prefix [00:09:36] <stuartmorgan> jshin: I added a non-flaky variant of the name in my CL [00:09:41] *** zaspire has quit IRC [00:09:55] <jshin> stuartmorgan: oh.. sorry i missed it [00:10:45] <jshin> sky: can your CL result in Vista failure (browser test didn't complete)? [00:10:51] *** rohitrao has quit IRC [00:12:30] <jrg> jshin: no [00:12:31] *** kinnetica has joined #chromium [00:13:35] -trungl-bot- Tree status changed: Tree is closed (Automatic: "compile" on "Webkit Builder (dbg)" from 48666: pkasting at chromium dot org) [00:13:45] *** reiko has joined #chromium [00:14:52] *** cmasone has quit IRC [00:14:54] *** ChrisW has joined #chromium [00:15:06] <pkasting__> I am looking at compile fail [00:15:34] <pkasting__> Hmm... this seems to be a broken bot [00:15:58] *** ChrisW has left #chromium [00:17:17] <pkasting__> Trying to kick the bot [00:18:39] -trungl-bot- Tree status changed: Tree closed (WebKit dbg bot being kicked) [00:19:16] *** jweyrich has quit IRC [00:19:39] -trungl-bot- Tree status changed: Tree is closed ("Webkit Builder (dbg)" bot issue: pkasting restarting build bot) [00:21:08] *** cying has quit IRC [00:21:30] *** cying has joined #chromium [00:22:05] <pkasting__> Tree reopened [00:22:42] -trungl-bot- Tree status changed: Tree open [00:24:01] *** cying has quit IRC [00:25:55] *** jweyrich has joined #chromium [00:26:18] *** Venom_X has quit IRC [00:27:07] *** cedricv has quit IRC [00:29:17] *** foo_fighter has quit IRC [00:31:44] *** feldstein has joined #chromium [00:31:50] <jam2> does anyone know if there's a way to get a screenshot of a tab in a browser test? [00:32:48] <feldstein> jam2: would the extension api (Tab.captureVisibleTab) work for you? [00:32:59] <feldstein> http://code.google.com/chrome/extensions/tabs.html [00:34:35] *** elsenorblanco has joined #chromium [00:35:22] <trungl> survey: NOTICE or PRIVMSG? (the argument for the former lies in RFC1459, namely that NOTICEs must not be replied to automatically) [00:35:34] * trungl doesn't care either way [00:36:58] *** senorblanco has quit IRC [00:38:01] *** sshc has joined #chromium [00:38:16] <trungl> results of the survey: no one cares [00:38:30] <rsesek> best. survey. ever. [00:38:39] <jamesr> trungl: conduct the survey as a NOTICE so the beep people show up [00:38:54] <trungl> okay [00:39:13] -trungl- survey: NOTICE or PRIVMSG? (the argument for the former lies in RFC1459, namely that NOTICEs must not be replied to automatically) [00:39:15] <jamesr> the chief complaint seemed to be that people who configured their IRC clients to beep on NOTICE were annoyed that their IRC client was beeping [00:39:20] *** elsenorblanco has quit IRC [00:39:28] <trungl> we'll see how many of them there are [00:39:28] <anders> privmsg please [00:39:37] *** Bleak has quit IRC [00:39:46] <alyxuk> privmsg. [00:40:03] <alyxuk> jamesr: because those people didn't actively configure it to, it just.. happens [00:40:18] <rsesek> I think tree closure is kind of NOTICE worthy though [00:40:53] <alyxuk> for clients that dont beep on notice, what is the difference between a notice and privmsg :|? [00:41:08] <rsesek> color (at least in Adium) [00:41:17] <alyxuk> well, colour isnt that hard to do [00:41:18] <alyxuk> :| [00:41:22] <alyxuk> the bot can privmsg with colour. [00:41:23] <alyxuk> problem solved. [00:41:24] <jamesr> NOTICE shows up a little better in colloquy [00:42:09] *** trungl-bot has quit IRC [00:42:20] * trungl shrugs [00:42:23] <trungl> privmsg it is [00:42:28] *** trungl-bot has joined #chromium [00:42:35] <trungl> until the notice lobby increases in strength [00:42:45] *** markmentovai has quit IRC [00:42:47] <rsesek> what's the best/easiest way to break on a gtest failure in gdb? [00:42:56] <alyxuk> people will adjust [00:43:09] <jshin> pkasting: by any chance, your seemingly unrelated changes can lead to test failures ? [00:44:25] *** jrmuizel has quit IRC [00:49:14] *** thakis has quit IRC [00:53:29] *** _rs has quit IRC [00:54:06] <thakis_afk> trungl: pivmsg as in /msg? [00:54:22] <trungl> as in /privmsg #chromium foo [00:54:27] <trungl> foo [00:54:29] <trungl> or msg [00:54:31] <trungl> or whatever [00:54:35] <trungl> foo [00:54:41] <trungl> well /msg, I cugess [00:54:43] <trungl> guess [00:55:08] *** AaronMT has quit IRC [00:55:11] <jamesr> thakis must be typing with his mind [00:55:12] * trungl should test the change [00:55:19] <thakis_afk> foo [00:55:26] <thakis_afk> foo [00:56:25] <trungl-bot> Tree status changed: Tree open [testing bot] [00:56:45] <trungl> Okay, still works, if less noticeable. [00:57:25] <trungl-bot> Tree status changed: Tree open [00:59:25] *** Kaosevil has joined #chromium [01:00:24] <thakis_afk> does trungl-bot: halp reply if its name appears somewhere in a string? [01:00:32] <thakis_afk> hm, no [01:00:33] <thakis_afk> sadness [01:00:47] <thakis_afk> so i can't put "trungl-bot" in the tree status and let it auto-trigger [01:00:49] *** thakis_afk is now known as thakis [01:01:36] <trungl> it's probably also smart enough not to reply to itself [01:01:49] <trungl> one assumes [01:01:58] <thakis> clearly, lots of sophisticated engineering went into trungl-bot [01:02:09] <thakis> trungl-bot: fib 8 [01:02:09] <trungl-bot> thakis: Error: "fib" is not a valid command. [01:02:12] *** sbyer has joined #chromium [01:02:21] <thakis> but it doesn't do fibonacci numbers :-( [01:02:43] <trungl> one of these days, I'll be brave enough to hook up the revert command for real [01:02:57] <thakis> and then it asks for your password? [01:02:59] *** apatrick_ has joined #chromium [01:03:10] <trungl> no, but it asks for a cookie [01:03:20] <trungl> in fact, you can already get a cookie [01:03:27] <thakis> trungl-bot: cookie [01:03:27] <trungl-bot> thakis: I don't have an edible cookie from you. [01:03:32] <thakis> ! [01:03:35] <thakis> lies [01:03:46] <thakis> trungl-bot: halp [01:03:46] <trungl-bot> thakis: Valid commands (use "halp <command>" for more): bug, commit, commits, fortune, halp, help, lkgr, offices, time, treestatus, webkitbug, webkitcommit, webkitcommits. (If you whisper to me, I'll whisper back.) [01:03:57] <trungl> so it's not listed yet [01:04:06] <thakis> trungl-bot: halp cookie [01:04:06] <trungl-bot> thakis: Valid commands (use "halp <command>" for more): bug, commit, commits, fortune, halp, help, lkgr, offices, time, treestatus, webkitbug, webkitcommit, webkitcommits. (If you whisper to me, I'll whisper back.) [01:04:12] <thakis> doesn't have help either [01:04:22] <trungl> trungl-bot: cookie afsd [01:04:23] <trungl-bot> trungl: Yuck. What was that? [01:04:25] <thakis> what happened to documentation-driven-development? [01:04:28] <trungl> trungl-bot: cookie WRIBVFOB4PWX [01:04:30] <trungl-bot> trungl: Yum. That's a good cookie. [01:04:38] <trungl> trungl-bot: cookie [01:04:38] <trungl-bot> trungl: The cookie you fed me is still good. [01:04:43] <thakis> trungl-bot: cookie WRIBVFOB4PWX [01:04:44] <trungl-bot> thakis: Yuck. What was that? [01:04:44] <trungl> trungl-bot: cookie invalidate [01:04:46] <trungl-bot> trungl: <burp> [01:04:48] <trungl> haha [01:05:13] <thakis> what's that do? [01:05:25] <trungl> what does what do? [01:05:31] <trungl> trungl-bot: revert 12345 [01:05:32] <trungl-bot> trungl: I wanna cookie! (Try "halp cookie".) [01:05:43] <trungl> trungl-bot: cookie WRIBVFOB4PWX [01:05:45] <trungl-bot> trungl: Yum. That's a good cookie. [01:05:50] <trungl> trungl-bot: revert 12345 [01:05:52] <trungl-bot> trungl: [just kidding] Reply with "confirm" within 30 seconds to revert the following commit: r12345 tc at google dot com: Mark mac tests that regressed from the merge. / / TBR=ojan / / Review URL: http://codereview.chromium.org/42552 [01:06:01] <trungl> trungl-bot: commit [01:06:02] <thakis> trungl-bot: confirm [01:06:02] <trungl-bot> trungl: commit takes exactly one argument; try using "halp" [01:06:03] <trungl-bot> thakis: You don't have a pending action. [01:06:07] <trungl> trungl-bot: confirm [01:06:07] <trungl-bot> trungl: [just kidding] Confirming revert of r12345. [01:06:25] <thakis> trungl: how does the cookie stuff work? [01:06:42] <trungl> thakis: you get a cookie for your nick from a super-secret place [01:07:13] <thakis> trungl: and that super-secret place gets my svn pw in return? [01:07:21] <trungl> no [01:07:30] <trungl> reverts would be done by me, I suppose [01:08:10] *** sshc has quit IRC [01:08:15] *** paul_irish has joined #chromium [01:09:44] *** thakis is now known as trungl_notreally [01:09:48] <trungl_notreally> trungl-bot: cookie 43RDTP27HHRX [01:09:50] <trungl-bot> trungl_notreally: Yum. That's a good cookie. [01:10:02] *** trungl_notreally is now known as thakis [01:10:04] <jshin> estade: BrowserCloseTabWhenOtherTabHasListener failed on Linux for no apparent reason. should it be marked as flaky on Linux? [01:10:05] <trungl> that's okay [01:10:09] <thakis> trungl-bot: cookie invalidate [01:10:10] <trungl-bot> thakis: I don't have a cookie from you. [01:10:13] <trungl> you still have to have voice before it'll revert [01:10:18] <estade> jshin: which bot/ [01:10:22] <trungl> and plus I can audit your abuse [01:10:30] <estade> jshin: and sigh, I guess so :[ [01:11:07] *** wtc has quit IRC [01:11:10] <jshin> estade: Linux tests (dbg) [01:11:28] <jshin> Linux tests (dbg (2) [01:12:18] <estade> jshin: yes, I will flaky it [01:12:50] <jshin> estade: thanks [01:16:37] <estade> jshin: http://codereview.chromium.org/2449007/show [01:16:39] *** trungl_ has joined #chromium [01:16:40] *** ChanServ sets mode: +v trungl_ [01:16:44] *** TimothyFitz has joined #chromium [01:16:48] *** trungl_ is now known as trungl_mbp [01:17:24] <jshin> estade: looks good [01:28:03] *** slamm has joined #chromium [01:28:28] *** bent-mozilla has quit IRC [01:32:03] <thakis> any windows folks around? can you open http://sputnik.googlelabs.com/run , click "start", and then check if it's still possible to open new pages? [01:32:07] <thakis> (on the dev channel) [01:34:06] <Waste> I take it the daily builds aren't the same as the dev channel [01:34:16] <rsesek> no [01:34:25] <Waste> ok [01:34:42] <rsesek> dev channel goes through QA, the waterfall builds do not [01:35:17] <Waste> I see [01:36:18] *** rbansal has quit IRC [01:36:28] *** kliegs has quit IRC [01:40:35] *** dev2_ has joined #chromium [01:41:33] *** pdelgallego has quit IRC [01:42:14] *** AaronMT has joined #chromium [01:42:45] *** rbansal has joined #chromium [01:42:51] *** dev2 has quit IRC [01:42:52] *** dev2_ is now known as dev2 [01:43:12] *** Martijnc has quit IRC [01:51:19] <thakis> can ui tests access the html source of the current page? browser tests? [01:51:56] *** slamm has quit IRC [01:52:13] * thakis looks at ExecuteAndExtractString [01:55:08] <jshin> has any ex-sheriffs observed 'browser test didn't complete' often? e.g. http://crbug.com/45595 or http://crbug.com/45594 ? I'll mark them as FLAKY (crash), but the bots will still turn red (see my comment at http://crbug.com/45079) [01:56:58] *** MikeSmithW3C^ has quit IRC [01:57:23] *** lgombos has quit IRC [01:59:28] <jhawkins> jshin: marking a hanging test as FLAKY will not fix the issue, you have to disabled hanging tests [02:00:07] <jhawkins> s/disabled/disable/ [02:00:30] *** Kaosevil has quit IRC [02:01:39] *** MikeSmithW3C^ has joined #chromium [02:02:40] *** paul_irish has quit IRC [02:06:30] <jshin> jhawkins: yeah, but that's what's done in http://crbug.com/45079. if a test always crashes/hangs, it's an easy call, but it only does occasionally. even then, you think it's better to disable it [02:06:47] *** duffydack has quit IRC [02:06:56] <jhawkins> jshin: if a test ever hangs, even flakily, it has to be disabled [02:07:03] <jhawkins> same goes for crashing [02:07:12] <jhawkins> but only for the platform(s) where the test crashes/hangs [02:07:22] <jshin> jhwakins: ok. i'll disable two cases i came across today. [02:07:34] <jshin> jhawkins: yup, i'm aware of MAYBE trick :-) [02:21:02] *** TabAtkins has quit IRC [02:22:42] *** chrisccoulson has quit IRC [02:25:16] *** stuartmorgan has quit IRC [02:25:47] *** rickspencer3 has quit IRC [02:25:49] *** tabatkins has joined #chromium [02:28:24] *** lianj_ has quit IRC [02:28:42] *** tabatkins is now known as TabAtkins [02:29:58] *** lianj has joined #chromium [02:33:12] *** trungl_mbp has quit IRC [02:33:37] *** FullFlannelJacke has quit IRC [02:34:25] *** jshin has quit IRC [02:34:26] *** FullFlannelJacke has joined #chromium [02:35:02] *** jshin has joined #chromium [02:35:22] *** jshin_ has joined #chromium [02:35:22] *** jshin has quit IRC [02:35:23] *** jshin_ is now known as jshin [02:36:04] *** jshin_ has joined #chromium [02:36:04] *** jshin has quit IRC [02:36:05] *** jshin_ is now known as jshin [02:36:41] *** rsesek has quit IRC [02:36:55] *** trungl is now known as trungl_away [02:37:41] *** General13372 has joined #chromium [02:39:00] *** paul_irish has joined #chromium [02:40:36] *** jshin has quit IRC [02:40:56] *** General1337 has quit IRC [02:42:14] *** RT|Chatzilla has joined #chromium [02:44:08] <jrg> jshin: still here? FYI, thanks for keeping the pressure on re: memory bots [02:46:40] *** trungl has joined #chromium [02:46:40] *** ChanServ sets mode: +v trungl [02:51:36] *** rbansal has quit IRC [02:51:55] <trungl> trungl-bot: foo [02:51:56] <trungl-bot> trungl: Error: "foo" is not a valid command. [02:54:50] <akalin> trungl-bot: burn-tree-down [02:54:51] <trungl-bot> akalin: Error: "burn-tree-down" is not a valid command. [02:55:08] <trungl> I'm working on that one. [02:58:19] *** apatrick_ has left #chromium [02:59:48] *** rolandsteiner has joined #chromium [03:00:45] *** Captain-n00dle has quit IRC [03:00:55] *** aroben has quit IRC [03:02:38] <trungl> does anyone know if the information on http://code.google.com/p/chromium/wiki/UserHandleMapping can be obtained in a nicer format from somewhere? (the table doesn't even have an id!) [03:03:15] *** erikkay has quit IRC [03:05:24] * trungl will take that as a no. [03:05:34] <trungl> or perhaps as consent. [03:05:46] *** yutak_home has quit IRC [03:06:51] <estade> trungl: it cannot [03:07:07] * trungl sighs [03:07:16] <estade> why, are you wanting to scrape it? [03:07:19] <trungl> crappy ad-hoc parsing it'll have to be [03:07:46] <trungl> because trungl-bot should be able to nag people on irc when the tree goes on fire [03:09:34] <estade> well if you copy-paste it, it becomes tab separated values [03:09:39] <akalin> being able to query trungl-bot on who's who would be nice [03:10:20] <trungl> akalin: yes, it's on my list of things to do [03:10:51] <estade> trungl: also, I can see at least one instance of a row that doesn't need to be there [03:11:04] <estade> but I feel bad about deleting someone who inserted themselves [03:11:49] <trungl> no harm done, I guess [03:12:01] <estade> clutter considered harmful [03:12:33] <estade> don't you know the primary evil of computer science ?!?! [03:12:33] <trungl> fair enough [03:12:52] <trungl> knuth said it was premature optimization [03:12:58] <trungl> I claim it's overzealous cutting-and-pasting [03:14:13] <akalin> ugh [03:14:22] <akalin> adding a string basically means you have to recompile all of browser/ [03:14:45] *** jrg has quit IRC [03:17:29] <trungl> yeah, basically [03:18:38] <thakis> ffffffffffffffffuuuuuuuuuuuuuuuuuuuu [03:19:01] <thakis> trungl: you're now aware of BeautifulSoup [03:19:23] <trungl> what? [03:19:31] <thakis> trungl: it's a python html scraping lib [03:19:45] <trungl> pshaw [03:19:46] <trungl> overkill [03:19:49] <trungl> I say [03:20:08] <thakis> trungl: naw, it's awesome [03:20:14] <trungl> well, maybe [03:20:28] <trungl> me and my regexes are having a good time though [03:20:33] <thakis> it even has a class called UnicodeDammt [03:20:43] <thakis> trungl: you're learning python, not perl [03:21:03] <trungl> I'm writing the most atrocious python code ever [03:21:11] <trungl> I should have done this in perl instead [03:21:14] <trungl> then it'd be normal [03:21:36] <trungl> maybe I can do it in a combination of python and perl [03:21:40] <trungl> that would make it doubly awesome [03:21:44] <akalin> perlthon [03:25:02] <trungl> biaw [03:25:17] *** trungl has quit IRC [03:25:33] *** rubenbb has quit IRC [03:27:01] <thakis> why oh why is xcode such a joke [03:27:21] <akalin> apple's last laugh [03:28:32] <jamesr> you actually use xcode? [03:28:43] <akalin> well we have to [03:29:33] *** rubenbb has joined #chromium [03:29:39] <jamesr> just to have the 'build' button [03:29:52] <akalin> still pretty terrible [03:29:54] *** rolandsteiner has quit IRC [03:32:28] *** paul_irish has quit IRC [03:32:58] *** hbono has joined #chromium [03:33:25] *** MikeSmithW3C^ has quit IRC [03:33:40] *** skydrome has quit IRC [03:34:07] *** skydrome has joined #chromium [03:37:36] *** jamesr has quit IRC [03:37:47] *** pathorn has joined #chromium [03:38:37] *** howlymowly_ has joined #chromium [03:40:15] *** AaronMT has quit IRC [03:42:34] *** howlymowly has quit IRC [03:44:42] *** fbuilesv has joined #chromium [03:45:07] *** trungl has joined #chromium [03:45:07] *** ChanServ sets mode: +v trungl [03:45:24] <fbuilesv> would this be the correct channel to ask doubts about extension development or is there another one for that? [03:45:55] *** tedoc2000 has quit IRC [03:47:19] <maruel> fbuilesv: you're better on the mailing list [03:47:35] <fbuilesv> maruel: ok, thanks. [03:48:46] <thakis> tony^work: gym for 60 min, will try to get my cl in after that [03:49:21] *** csilv has quit IRC [03:51:10] <tony^work> thakis: sure, no hurry [03:51:20] <trungl> being able to map() a lambda makes me feel warm and fuzzy inside [03:51:26] <tony^work> although I think it would be good to get feedback from jam2 [03:52:10] <thakis> trungl: it shouldn't. use list comprehensions instead [03:52:24] <thakis> tony^work: he more or less lgtmd this approach on the thread on chromium-dev [03:52:25] *** Gabe_G23 has quit IRC [03:53:02] <tony^work> ah, cool [03:53:06] <tony^work> SGTM [03:53:08] <trungl> thakis: fine, be that way [03:54:38] *** Gabe_G23 has joined #chromium [03:57:48] *** mrossetti has quit IRC [03:57:49] <trungl> hrm [03:58:54] <maruel> I still use filter(None, [...]) but rarely map() [03:59:31] <tony^work> you prefer filter to list comprehension with an if? [04:01:15] <maruel> tony^work: it depends on the complexity [04:01:32] <maruel> like [x.strip() for x in foo if x.strip()] [04:01:54] <maruel> it's more efficient to use filter(None, [x.strip() for x in foo]) [04:03:15] * tony^work nods [04:04:03] *** joshdreamland has joined #chromium [04:05:41] <joshdreamland> Hi, I notice that Chrome has checking for if memory limits were exceeded. I'm trying to build a plugin system into Pidgin, here, and it's proving difficult to implement memory checking. I can kill frozen scripts; for instance: [04:05:47] <joshdreamland> js: while (1); [04:05:48] <joshdreamland> null [04:06:13] <maruel> joshdreamland: out-of-process plugins [04:06:15] <joshdreamland> However, I have no way of preventing against attacks such as a="a"; for(;;) a += a; [04:06:18] <maruel> then you kill them all [04:06:20] *** TimothyFitz has quit IRC [04:06:22] <maruel> but it's a bit OT [04:06:27] <joshdreamland> OT? [04:07:00] <maruel> off topic [04:07:55] <joshdreamland> Ah. [04:08:18] *** darwin has quit IRC [04:08:26] <joshdreamland> Well, thank you, I will look into those... [04:09:30] <joshdreamland> Google brings up a thousand Firefox related topics; would you mind clarifying? [04:10:12] *** kinnetica has quit IRC [04:10:43] *** darwin has joined #chromium [04:10:46] <maruel> joshdreamland: I can't help really, I just meant chromium can kill individual plugins since they each run in their own process [04:10:49] <joshdreamland> Ah, I see what you mean. [04:11:08] <joshdreamland> That's not an option here; Pidgin has -zero- threading support [04:12:01] <trungl> If there's no threading at all, then all calls to a plugin are necessarily going to be synchronous. And if the plugin hangs, whatcha gonna do? [04:12:39] <joshdreamland> trungl: Fortunately, I can thread a separate function that makes calls to kill V8, because V8 is relatively thread friendly [04:12:56] <joshdreamland> But new threads can't make any calls to Purple [04:13:19] <tony^work> joshdreamland: can you suspend V8 and check it's memory periodically? [04:13:36] <joshdreamland> Tony: I fear periodically would be too infrequent, but yes, I can [04:14:02] <tony^work> also, doesn't v8 have a heap size that you can set? [04:14:06] <joshdreamland> But I was noticing how Chrome survived the wost of my attacks [04:14:18] <joshdreamland> tony^work: I believe it dies if you exceed that size. [04:14:36] <tony^work> ah, so that should be what happens in chrome [04:14:44] <tony^work> it probably kills a tab [04:15:00] <joshdreamland> Actually, it pops up a notice that says it's been disabled for now, reload to re-enable [04:15:22] <joshdreamland> Which I was thinking may be when it asks isDead(), but there doesn't seem to be a way to revive it once it is dead [04:15:50] <tony^work> I see, that's probably why you have to reload (basically start over) [04:16:02] *** mpcomplete has quit IRC [04:16:05] *** rolandsteiner has joined #chromium [04:16:40] *** wers has joined #chromium [04:16:57] <joshdreamland> That's what I was thinking, but I can't tell how it "reloads" [04:17:10] <joshdreamland> As in, whether it creates a new process, or just somehow revives the current one [04:17:12] *** howlymowly_ has quit IRC [04:17:25] <joshdreamland> It'd help if there was a way to check if a context is dead and re-create it [04:18:31] <tony^work> in chrome, it's probably creating a new context [04:18:37] <joshdreamland> There is a method called AddMessageListener, but it is poorly documented [04:19:12] <joshdreamland> I was hoping AddMessageListener could invoke something to tell me when my context is killed, or about to be [04:19:46] *** fbuilesv has left #chromium [04:20:02] <tony^work> I'm not sure if v8 has a separate IRC channel, but most of the people here probably don't know the details of the v8 api [04:20:26] <tony^work> (which is to say, I'm just making wild guesses) [04:20:57] <joshdreamland> Haha, that's okay [04:21:12] <joshdreamland> I suppose I could check that, too :P [04:21:41] <joshdreamland> Seem to, but there are some dozen people there [04:23:04] *** MikeSmithW3C has joined #chromium [04:23:19] *** zork has left #chromium [04:24:02] *** rh0mbus has joined #chromium [04:26:50] *** wers has quit IRC [04:27:23] *** sshc has joined #chromium [04:38:25] <rh0mbus> Does anyone know where the code is that binds the HTML DOM to V8? [04:44:33] <tkent> pkasting__: I'll handle next WebKit roll. [04:45:11] <pkasting__> tkent: I just got back in the office -- I've been out a lot today (wife having surgery) [04:45:29] <pkasting__> tkent: Two hours ago I gave jamesr a set of rebaselines to do to hopefully make the canaries green [04:45:41] <pkasting__> tkent: But I haven't had time to check what happened since then [04:45:49] <tkent> ok [04:46:45] <pkasting__> tkent: Are you already looking at the tree? Because if not I'm happy to look at things for the next hour or two [04:47:57] <tkent> pkasting__: I'm looking. It's ok that you work on other things :-) [04:49:30] <pkasting__> tkent: Looks at a glance like the canaries are in pretty good shape [04:51:02] *** tonyg-cr has quit IRC [04:52:39] *** darwin has quit IRC [04:54:29] *** jrmuizel has joined #chromium [04:56:42] *** kinnetica has joined #chromium [04:56:54] *** rolandsteiner has quit IRC [05:01:18] *** sshc has quit IRC [05:02:16] *** magn3ts has joined #chromium [05:06:00] *** sshc has joined #chromium [05:06:36] *** leeight has joined #chromium [05:06:43] *** leeight has left #chromium [05:07:12] *** kinnetica has quit IRC [05:11:22] *** sshc_ has joined #chromium [05:12:56] *** sshc has quit IRC [05:15:09] *** rh0mbus has left #chromium [05:16:26] *** sshc_ has quit IRC [05:16:40] *** sshc has joined #chromium [05:20:36] *** fbarchard has joined #chromium [05:20:45] *** kcbanner_ has joined #chromium [05:20:56] <kcbanner_> I know this might not be the right channel for this, but it seems chromium specific. [05:21:03] <kcbanner_> Can anyone tell me why runing 'new MyClass()' in my chrome extension's background page returns MyClass, but 'new chrome.extension.getBackgroundPage().MyClass()' returns undefined in my options page? [05:21:33] <pkasting__> tkent: Do you know why the Mac canary shows 6 tests as unexpected pass, but many of them don't seem to have any failure expectation? [05:22:10] <pkasting__> kcbanner_: http://groups.google.com/a/chromium.org/group/chromium-extensions/topics ? [05:22:34] <pkasting__> tkent: For example, fast/js/kde/function_arguments.html [05:22:46] <pkasting__> tkent: Not listed anywhere in test_expectations.txt [05:22:59] <pkasting__> tkent: Yet it's "unexpected pass" according to the bot [05:23:14] *** sshc has quit IRC [05:23:52] <tkent> pkasting__: I have removed it from test_expectations.txt some revisions ago. It seems Mac bot is just delaying. [05:24:26] <kcbanner_> pkasting__: It seems that it takes multiple days to get messages on that mailing list approvied [05:24:28] <kcbanner_> approved* [05:24:48] <thakis> trungl: hey, dragging bookmarklets to the bookmark bar is broken again [05:24:51] <thakis> ideas who did that? [05:24:53] <tkent> pkasting__: as for backslash-to-yen-sign*.html, test_expectation.txt is wrong. [05:24:59] <tony^work> mac bot is super slow because of the multithreaded python hangs [05:25:00] <trungl> thakis: no? [05:25:44] <pkasting__> tkent: It's weird that backslash-to-yen-sign* are shown on the dashboard as failing 100% but according to the mac canary are passing [05:25:54] <pkasting__> tkent: I cannot figure this out at all [05:26:18] *** FullFlannelJacke has quit IRC [05:26:58] <pkasting__> tkent: When did you remove function_arguments.html? [05:27:35] <pkasting__> ojan: yt? [05:28:43] <tkent> pkasting__: WebKit r60526 [05:29:41] <fbarchard> hey guys... trying a deps change for ffmpeg. [05:29:54] <pkasting__> tkent: Ah I see [05:30:06] <pkasting__> tkent: But why did you add IMAGE+TEXT and PASS for fast/css/input-search-padding.html? [05:30:18] <pkasting__> tkent: According to the dashboard it's very consistent about being IMAGE [05:32:57] *** xenoterracide has joined #chromium [05:33:31] <pkasting__> tkent: Is it OK if I change it back to IMAGE, and add an exclusion for a passing test jamesr just rebaselined? I don't know what needs to be done with backslahs-to-yen-sign* [05:34:02] <xenoterracide> is there a way to have the new tab page open allong with other pages on startup? [05:34:21] <tkent> pkasting__: In canary, input-search-padding.html is flaky. I don't know why dashboard shows no flakiness. [05:34:26] <tkent> http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/20418/steps/webkit_tests/logs/stdio [05:35:13] <pkasting__> tkent: That log backs me up [05:35:24] <pkasting__> tkent: That's not flakiness, that's an IMAGE mismatch [05:36:09] <pkasting__> Wait [05:36:28] *** Buglouse has joined #chromium [05:36:32] *** sshc has joined #chromium [05:36:57] *** darthn8ersf has joined #chromium [05:38:02] *** rafaelw has left #chromium [05:38:08] <darthn8ersf> I know I will probably be told to go to the OS channel but as this comes from the browser source Im gonna ask here. [05:38:25] <pkasting__> This makes no sense [05:38:35] <pkasting__> How could this test be flaky? [05:39:06] <pkasting__> The image differs by virtue of different close button sizes [05:39:37] <darthn8ersf> I am trying to track down what controls the BG color of the login screen. I found /src/chrome/browser.chromeos/login/background_view.cc but ironically those values control the color of the text on the screen [05:39:54] <pkasting__> I want to try marking it IMAGE and having it actually go through a run [05:40:06] <pkasting__> I don't trust any of the tools now :/ [05:40:12] <tkent> pkasting__: ok [05:40:13] <darthn8ersf> can anyone direct me to where I would find reference of the BG color itself? Im thinking in /src/view but not finding it [05:40:33] *** xenoterracide has left #chromium [05:40:36] <pkasting__> I'll sit and watch it after I check in [05:42:21] *** sshc has quit IRC [05:44:29] *** FullFlannelJacke has joined #chromium [05:47:14] *** sshc has joined #chromium [05:48:32] *** TimothyFitz has joined #chromium [05:51:25] *** kcbanner_ has quit IRC [05:52:15] *** sshc_ has joined #chromium [05:52:46] <darthn8ersf> any of your 3 new peeps know the code very well? [05:54:12] *** sshc has quit IRC [05:55:07] <m0> ? [05:57:28] *** sshc has joined #chromium [05:58:33] *** sshc_ has quit IRC [06:05:15] *** rolandsteiner has joined #chromium [06:07:20] *** trungl-bot has quit IRC [06:07:32] *** trungl-bot has joined #chromium [06:08:00] <trungl> trungl-bot: whois trungl [06:08:00] <trungl-bot> trungl: It looks like trungl could be: viettrungluu at chromium dot org / :trungl / vtl at google dot com. [06:08:30] <trungl-bot> Tree status changed: Tree is closed (Automatic: "update" on "Modules Mac10.5") [06:09:02] <trungl> trungl-bot: whois mark [06:09:02] <trungl-bot> trungl: It looks like mark could be: mark at chromium dot org / :markmentovai. [06:09:44] *** jrg has joined #chromium [06:10:20] *** ChanServ sets mode: +v rolandsteiner [06:10:20] *** ChanServ sets mode: +v jrg [06:12:09] *** hagebake has quit IRC [06:14:35] <trungl-bot> Tree status changed: Tree is open (chromium mac kicked but sheriff going home so be nice plz kthxbye) [06:16:40] *** magn3ts has quit IRC [06:17:50] *** jweyrich has quit IRC [06:19:27] *** dev2 has quit IRC [06:29:49] *** bweinstein has joined #chromium [06:30:05] *** jrmuizel has quit IRC [06:31:46] <trungl-bot> Tree status changed: Tree is closed (Automatic: "compile" on "Chromium Mac Builder (dbg)" from 48697: fbarchard at chromium dot org) [06:32:16] <thakis> trungl-bot: halp whois [06:32:16] <trungl-bot> thakis: Usage: whois <name> [06:32:22] <thakis> trungl-bot: whois trungl-bot [06:32:22] <trungl-bot> thakis: No explicit entry for trungl-bot found. Try: trungl-bot at chromium dot org / :trungl-bot / trungl-bot at google dot com. [06:32:28] <thakis> hrm [06:32:28] <trungl> sigh [06:32:38] <thakis> trungl-bot: whois akalin [06:32:38] <trungl-bot> thakis: No explicit entry for akalin found. Try: akalin at chromium dot org / :akalin / akalin at google dot com. [06:32:55] <thakis> trungl-bot: halp halp halp [06:32:56] <trungl-bot> thakis: halp takes at most one argument; try using "halp" [06:33:06] <thakis> trungl-bot: halp halp [06:33:06] <trungl-bot> thakis: Usage: halp [command] [06:35:30] *** trungl-bot has quit IRC [06:35:38] *** trungl-bot has joined #chromium [06:35:51] <trungl> trungl-bot: whois trungl-bot [06:35:52] <trungl-bot> trungl: trungl-bot is a bot operated by trungl. [06:36:00] <trungl> trungl-bot: whois trungl [06:36:01] <trungl-bot> trungl: It looks like trungl could be: viettrungluu at chromium dot org / :trungl / vtl at google dot com. [06:37:31] *** jshin has joined #chromium [06:37:45] *** jshin has quit IRC [06:38:01] *** jshin has joined #chromium [06:40:17] <jshin> fbarchard: are you looking at compile failure on mac builder? [06:42:18] <fbarchard> i just see a sync issue, not on mac specifically [06:44:17] <pkasting__> tkent: Unfortunately I can't sit and watch any longer, I need to go home [06:44:59] *** pathorn has quit IRC [06:45:24] <tkent> pkasting__: I see. I'll take care of WebKit canaries and rolling. [06:47:03] *** TimothyFitz has quit IRC [06:47:28] <jshin> fbarchard: do you think it can be sorted out quickly? [06:52:10] *** joshdreamland has left #chromium [06:55:44] *** Martijnc has joined #chromium [06:56:14] <fbarchard> jshin: not sure what the problem is yet [06:56:47] <trungl-bot> Tree status changed: Tree is closed (compile/update failed ==> fbarchard) [06:58:47] <jshin> fbarchard: i'm afraid reverting won't be easy, either... what you deleted/renamed have all LF EOL set? [07:03:14] *** blah_sphemer has joined #chromium [07:03:34] <blah_sphemer> how can I queue my downloads? [07:03:42] <blah_sphemer> as in one-by-one [07:07:18] *** bsmedberg has quit IRC [07:08:19] *** bsmedberg has joined #chromium [07:12:13] <fbarchard> is there a link to an ffmpeg bug? [07:13:02] <hbono> fbarchard: It seems svn failed synching because of "502 Bad Gateway" errors. [07:13:59] <hbono> fbarchard: this error also happens on my Linux box this morning. Maybe a network problem? [07:15:19] <fbarchard> my change is just a deps roll, but I'm having trouble with signin to do a drover revert [07:17:23] *** bers has joined #chromium [07:21:07] <fbarchard> is there anyone can do drover --revert 48697 [07:23:50] *** fbarchard has left #chromium [07:26:36] *** fbarchard has joined #chromium [07:28:23] *** fbarchard has left #chromium [07:29:40] *** loislo has joined #chromium [07:30:28] <jshin> fbarchard: i can [07:30:40] *** fbarchard has joined #chromium [07:34:12] <jshin> fbarchard: reverted [07:34:43] <fbarchard> jshin: thanks! [07:35:04] <jshin> fbarchard: np [07:35:31] <fbarchard> normally I try to do gcl update before a deps roll, but thats not working? [07:35:41] *** paul_irish has joined #chromium [07:36:58] <jshin> you mean with your local DEPS updated, right? [07:37:20] <trungl-bot> Tree status changed: Tree is closed (ffmpeg roll reverted. waiting for builders to turn green) [07:37:54] <jshin> it should work. i do it often. [07:39:50] <fbarchard> yup... shoulda worked. [07:43:22] *** sshc has quit IRC [07:45:01] <trungl> trungl-bot: fortune [07:45:02] <trungl-bot> trungl: Trust your husband, adore your husband, and get as much as you can in your own name. -- Joan Rivers [07:49:12] *** jschuh has quit IRC [07:54:30] *** eseidel has joined #chromium [07:54:33] *** kamathln has joined #chromium [08:01:57] *** scherkus has joined #chromium [08:02:50] <scherkus> if anyone is wondering what the heck is going on with the tree [08:02:56] <scherkus> I will attempt to fix [08:03:00] *** mfinkle has quit IRC [08:03:51] <jshin> scherkus: thanks. simply reverting fbarchard's cl didn't work as it's obivous from the tree. [08:04:06] <scherkus> jshin: yeah unfortunately you didn't revert the whole thing! [08:04:18] <scherkus> jshin: the revert didn't restore the original src/third_party/ffmpeg [08:04:33] <scherkus> also in this case the bots just need to be manually clobbered [08:04:43] <jshin> jshin: i had a hunch that 'drover --revert' might not work for this, but ... [08:04:43] <scherkus> so that the subversion servers don't start returning 502 [08:04:48] <scherkus> haha [08:04:57] <scherkus> yeah I guess we hit an edge case :\ [08:04:59] *** michaeln has quit IRC [08:05:28] <scherkus> seeing as a few bots did make it through with the change [08:05:35] <scherkus> (ie the full release builders) [08:05:51] <jshin> scherkus: glad that you figured that out ! [08:06:00] <scherkus> I'm going to revert your revert then manually poke the bots to clobber [08:06:11] <scherkus> jshin: I've caused a few of these catastrophies before :( [08:06:36] <jshin> scherkus: thanks tons ! [08:10:47] <trungl-bot> Tree status changed: Tree is closed (bots are overloading svn servers) [08:13:22] <scherkus> ok revert is in... crossing fingers [08:13:37] <scherkus> will take another 30 minutes until it's time to start manually hitting the clobber button [08:14:33] <kamathln> hi .. you guys seem to be devs [08:14:44] <kamathln> can I bother you with a bug report? [08:14:56] <kamathln> http://kamathln.homelinux.net/experiment/html_js/chrome_bug.html#thebookmark [08:15:00] <kamathln> whups [08:15:04] <kamathln> http://kamathln.homelinux.net/experiment/html_js/chrome_bug.html [08:15:25] <kamathln> click on the "goto bookmark" inside the div [08:15:52] <kamathln> why does the body scroll too? [08:17:02] *** shepazu has quit IRC [08:17:30] <kamathln> my chromium is max 3 to 4 days old [ 6.0.421.0 (48560) ] [08:18:28] <kamathln> doesnt happen on firefox if you are wondering [08:18:49] *** Yonn has joined #chromium [08:18:53] <fbarchard> why cant i log into chromium? [08:19:09] *** fqian has joined #chromium [08:19:43] <jshin> scherkus: thanks again. my fingers are crossed, too :-) [08:19:58] <jshin> kamathin: you can report a bug at http://crbug.com [08:20:02] <scherkus> kamathln: not my area of expertise, unfortunately :( [08:21:56] <kamathln> jshin: will do.. reported ehre coz i just created tthe page and hosted it on my lapotp .. [08:24:34] <jshin> kamathin: i c. anyway, reporting at crbug.com is the best way. if your file will not stay there (and you don't have any place to put it up), you can upload a test html file (if it's a single file) to the bug. if not, you can also upload a zip file/tar ball to the bug [08:24:46] *** thakis_ has joined #chromium [08:24:46] *** ChanServ sets mode: +v thakis_ [08:25:10] <jshin> kamathin: btw, i was able to reproduce it [08:26:13] *** Buglouse has quit IRC [08:28:17] <kamathln> jshin: already there .. reporting [08:28:44] <kamathln> hehheh. Opera has the same bug [08:30:12] *** GeekShadow has joined #chromium [08:30:35] *** sshc has joined #chromium [08:32:14] <kamathln> lemme just tell browsershots.org to take screenshots of http://kamathln.homelinux.net/experiment/html_js/chrome_bug.html .. lets see what happens [08:33:37] *** bweinstein has quit IRC [08:34:28] *** abarth has quit IRC [08:35:05] *** darthn8ersf has quit IRC [08:35:36] *** cedricv has joined #chromium [08:36:10] <tkent> jshin: reverting 48697 looks incomplete. We have no src/third_party/ffmpeg now. [08:38:52] <hbono> tkent: scherkus reverted his revert. [08:38:55] *** trungl-bot has quit IRC [08:39:34] *** trungl-bot has joined #chromium [08:39:35] <tkent> hbono: oh, I see. [08:39:41] <scherkus> the bots are getting better [08:39:52] <scherkus> a few of them made it past the update stage and are successfully compiling [08:40:34] *** GeekShadow has quit IRC [08:40:50] *** leeight has joined #chromium [08:40:53] *** leeight has left #chromium [08:42:02] <thakis_> looks like everything's fine? [08:42:54] <kamathln> never mind .. browsershots just stripped the bookmark :-/ [08:43:07] <fbarchard> man svn is giving me grief with this change svn: Error processing command 'modify-entry' in '.' [08:43:23] <scherkus> thakis_: not quite! you can never be too sure when bots start getting 502 during checkout [08:44:11] <scherkus> thakis_: right now I'm worried by all the XP test bots checking out code right now [08:44:40] <thakis_> don't worry, be happy [08:48:52] *** skydrome_ has joined #chromium [08:48:58] *** skydrome_ has quit IRC [08:49:01] *** Erkan_Yilmaz has quit IRC [08:49:05] *** skydrome has quit IRC [08:49:17] <scherkus> a few more bots threw gclient exceptions :'( [08:49:22] *** skydrome has joined #chromium [08:51:23] *** abarth has joined #chromium [08:51:23] *** ChanServ sets mode: +v abarth [08:53:13] *** bers has quit IRC [08:54:37] *** Zucca has quit IRC [09:00:52] *** reggna has quit IRC [09:03:57] *** phajdan-jr has joined #chromium [09:03:58] *** phajdan-jr has joined #chromium [09:03:58] *** ChanServ sets mode: +v phajdan-jr [09:04:33] *** GeekShadow has joined #chromium [09:06:01] *** reggna has joined #chromium [09:08:25] *** bsmedberg has quit IRC [09:08:45] *** trungl has quit IRC [09:09:32] *** RT|Chatzilla has quit IRC [09:11:06] *** rbansal has joined #chromium [09:11:07] *** RT|Chatzilla has joined #chromium [09:11:59] *** bsmedberg has joined #chromium [09:17:55] *** fqian has quit IRC [09:19:12] *** bsmedberg has quit IRC [09:20:07] *** bsmedberg has joined #chromium [09:23:33] <kamathln> never mind .. browsershots just stripped the bookmark :-/ [09:23:38] <kamathln> jshin: http://code.google.com/p/chromium/issues/detail?id=45618 [09:24:23] *** Beetny has joined #chromium [09:25:19] *** fahadsadah has quit IRC [09:32:08] *** tittiatcoke has joined #chromium [09:32:45] *** hamaji has quit IRC [09:32:45] *** tav has quit IRC [09:32:45] *** Caleb has quit IRC [09:32:45] *** jcastro has quit IRC [09:32:45] *** Kovensky has quit IRC [09:32:45] *** nsylvain has quit IRC [09:32:45] *** Greboid has quit IRC [09:32:45] *** deshantm has quit IRC [09:32:45] *** peper has quit IRC [09:32:46] *** pcgod has quit IRC [09:32:46] *** wim has quit IRC [09:36:01] *** bsmedberg has quit IRC [09:36:04] *** fahadsadah has joined #chromium [09:36:17] *** kamathln has quit IRC [09:36:25] *** bsmedberg has joined #chromium [09:38:54] *** hamaji has joined #chromium [09:38:54] *** tav has joined #chromium [09:38:54] *** Caleb has joined #chromium [09:38:54] *** jcastro has joined #chromium [09:38:54] *** Kovensky has joined #chromium [09:38:54] *** nsylvain has joined #chromium [09:38:54] *** Greboid has joined #chromium [09:38:54] *** deshantm has joined #chromium [09:38:54] *** peper has joined #chromium [09:38:54] *** pcgod has joined #chromium [09:38:54] *** wim has joined #chromium [09:44:24] *** hbono has quit IRC [09:44:48] *** hbono has joined #chromium [09:47:44] *** jshin has quit IRC [09:51:26] *** bsmedberg has quit IRC [09:51:54] *** bsmedberg has joined #chromium [09:52:28] *** tittiathome has joined #chromium [09:52:48] *** thakis_ has quit IRC [09:54:22] *** tittiatcoke has quit IRC [09:54:35] *** tittiathome is now known as tittiatcoke [09:54:40] *** MikeSmithW3C has quit IRC [09:56:56] *** Martijnc has quit IRC [09:58:27] *** MikeSmithW3C has joined #chromium [09:59:11] *** shreyas has joined #chromium [10:04:39] *** MikeSmithW3C has quit IRC [10:05:19] *** MikeSmithW3C has joined #chromium [10:10:38] *** jshin has joined #chromium [10:11:49] *** jshin has quit IRC [10:12:34] *** jshin has joined #chromium [10:14:38] *** jshin_ has joined #chromium [10:14:38] *** jshin has quit IRC [10:14:38] *** jshin_ is now known as jshin [10:14:59] *** jshin has quit IRC [10:15:11] *** jshin has joined #chromium [10:17:18] *** jshin has quit IRC [10:20:15] *** afreenode has joined #chromium [10:20:32] <afreenode> make: *** No rule to make target `third_party/yasm/source/patched-yasm/modules/arch/x86/gen_x86_insn.py', needed by `out/Debug/obj/gen/third_party/yasm/x86insns.c'. Stop. [10:20:53] <afreenode> make: *** Waiting for unfinished jobs.... [10:22:34] *** jshin has joined #chromium [10:23:00] *** jshin has quit IRC [10:23:04] *** jshin has joined #chromium [10:23:42] *** jshin_ has joined #chromium [10:23:43] *** jshin has quit IRC [10:23:43] *** jshin_ is now known as jshin [10:24:22] *** jshin has joined #chromium [10:25:00] *** jshin has quit IRC [10:26:05] <phajdan-jr> is there some ETA of tree re-opening? The bots seem to be recovering. [10:26:30] *** jshin has joined #chromium [10:26:46] *** jshin has quit IRC [10:27:00] *** jshin has joined #chromium [10:27:25] *** jshin has quit IRC [10:27:43] *** jshin has joined #chromium [10:28:03] *** jshin has quit IRC [10:28:44] *** jshin has joined #chromium [10:29:24] *** jshin_ has joined #chromium [10:29:24] *** jshin has quit IRC [10:29:24] *** jshin_ is now known as jshin [10:29:48] *** jshin has quit IRC [10:30:05] *** bsmedberg has quit IRC [10:30:29] <phajdan-jr> oops, still some gclient exceptions :( [10:31:05] <phajdan-jr> scherkus: looks like at least some bots need svn cleanup, see the logs [10:31:11] <phajdan-jr> scherkus: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/19417/steps/gclient/logs/stdio [10:31:14] <phajdan-jr> (scroll to bottom) [10:31:20] *** bauerb has joined #chromium [10:31:40] <scherkus> phajdan-jr: yeah noticed that as well but it appears I no longer can log into them :( [10:32:05] <scherkus> phajdan-jr: at this point I might have to pack it in for the night... most of the bots are healthy again [10:33:10] <phajdan-jr> I think the tree should stay closed. It seems too unstable. I can land later. [10:33:37] *** jshin has joined #chromium [10:33:43] *** rbansal has quit IRC [10:33:51] *** jshin has quit IRC [10:38:20] *** Martijnc has joined #chromium [10:38:59] *** bsmedberg has joined #chromium [10:39:33] <trungl-bot> Tree status changed: Tree is closed (some bots require manual cleanup) [10:42:26] *** shenki has quit IRC [10:47:32] *** pdelgallego has joined #chromium [10:59:13] *** cli_ has joined #chromium [11:00:25] *** scherkus has quit IRC [11:00:55] <mnissler> does somebody know what gyp file handles views unittests? I cannot find one. [11:02:57] *** ROBOd has joined #chromium [11:03:34] <bauerb> mnissler: as in views:: ? [11:03:47] <mnissler> bauerb: exactly [11:03:51] *** jshin has joined #chromium [11:04:47] *** jshin has quit IRC [11:08:52] *** FullFlannelJacke has quit IRC [11:13:42] *** afreenode has quit IRC [11:18:25] *** FullFlannelJacke has joined #chromium [11:31:21] *** hbono has quit IRC [17:55:05] *** echelog-1 has joined #chromium [17:55:52] <pinkerton> i can't explain it. [17:56:06] <pinkerton> unless something is eating the key first in the webpage [17:56:13] *** markmentovai has joined #chromium [17:56:13] *** ChanServ sets mode: +v markmentovai [17:56:15] *** blah_sphemer has quit IRC [17:56:15] <pinkerton> but we send that through the menus first. [17:56:51] *** bauerb has quit IRC [17:56:54] <stuartmorgan> maybe some bug in the onunload code path? [17:58:59] <rubenbb> for laughs, a unique criticism of chrome :) - http://forums.freebsd.org/showpost.php?p=85394&postcount=50 [18:00:31] *** bent-mozilla has joined #chromium [18:03:12] *** mrossetti has quit IRC [18:04:54] <sky__> what's the right way to make git ignore ffmpeg? [18:05:47] *** RT|Chatzilla has quit IRC [18:06:25] <stuartmorgan> sky__: you are having problems changing branches? [18:06:32] <sky__> yep [18:07:05] <stuartmorgan> sky__: I don't know if there's a better way, but one thing that works is to move third_party/ffmpeg aside, then change to each branch and rebase to trunk [18:07:13] <stuartmorgan> That will cause that branch not to have ffmpeg any more [18:07:18] <stuartmorgan> Then you can move the folder back [18:07:22] * rohitrao wishes he could get the findbar to disappear in a debug build [18:07:41] <sky__> I'll try that, tx [18:08:43] *** TimothyFitz has joined #chromium [18:09:18] *** Travis-42 has joined #chromium [18:09:31] *** fbarchard has left #chromium [18:10:03] <sky__> when I switch to another branch, rebase, then move ffmpeg back git still shows ffmpeg as untracked. [18:10:56] *** Yonz has quit IRC [18:12:15] *** WePac has quit IRC [18:13:01] *** phajdan-jr|afk is now known as phajdan-jr [18:13:15] *** bweinstein has joined #chromium [18:14:13] <stuartmorgan> sky__: .gitignore probably needs updating; I had only gotten to the point of being able to actually get to my other branches ;) [18:14:24] <sky__> ok [18:16:46] <sky__> .gitignore should have /third_party/ffmpeg now? [18:17:00] <andybons> pinkerton: ping [18:17:33] <pinkerton> pong [18:18:21] <andybons> pinkerton: did http://codereview.chromium.org/2426002/show end up in your mail? sorry if it did. no rush on it [18:18:41] <pinkerton> no, i don't recall seeing it [18:19:04] <pinkerton> i'll look shortly [18:19:09] <mnissler> sky__: yes, it's supposed to have it, but seems nobody cared enough to actually do it :-) [18:19:17] <sky__> I'll add it. [18:19:22] *** trungl has joined #chromium [18:19:22] *** ChanServ sets mode: +v trungl [18:20:25] <andybons> pinkerton: thanks. again, not blocking anything [18:20:41] <sky__> I'll tbr a fix to you stuart. [18:21:44] <stuartmorgan> sky__: I'm not a git expert, so I don't know for sure, but that's my understanding [18:22:40] *** trungl_ has joined #chromium [18:22:41] *** ChanServ sets mode: +v trungl_ [18:22:51] <stuartmorgan> sky__: if that's wrong, I'm sure evan can fix it when he gets back :D [18:24:36] <sky__> bulach has the change too. [18:24:45] <sky__> maruel said it should be good. [18:25:08] *** Aikar has joined #chromium [18:25:11] <mnissler> it's correct, everything that gets pulled in by svn should be masked out so git ignores it. actually somebody wanted to do it earlier today, but apparantly that didn't happen. [18:25:16] *** rsesek has joined #chromium [18:25:16] *** ChanServ sets mode: +v rsesek [18:25:31] <bulach> bulach: landing the .gitignore in a sec.. [18:26:32] <bulach> bulach: landed. [18:26:44] <mnissler> bulach: \o/ [18:26:49] <pinkerton> i'm not sure if the try server is any faster than my dell p390 [18:26:57] <bulach> mnissler: :) [18:27:08] *** trungl has quit IRC [18:27:09] *** trungl_ is now known as trungl [18:27:28] <bulach> btw, if you happen to have a local branch which included ffmpeg, you may need to git checkout -f, rm -rf, then gclient again.. [18:27:47] <maruel> pinkerton: in theory, it should, in practice, it depends [18:28:02] <pinkerton> heh [18:29:28] <BUGabundo_remote> http://code.google.com/p/chromium/issues/detail?id=45625 [18:29:36] <BUGabundo_remote> I filed this bug this morning [18:29:41] <BUGabundo_remote> can someone look at it [18:29:47] <BUGabundo_remote> its a recente regression [18:29:50] <BUGabundo_remote> 48h [18:29:51] <stuartmorgan> bulach: I think my way above is probably easier [18:30:00] *** willchan_ has joined #chromium [18:30:00] *** ChanServ sets mode: +v willchan_ [18:30:18] *** mpcomplete has joined #chromium [18:30:18] *** ChanServ sets mode: +v mpcomplete [18:30:22] *** willchan_ is now known as willchan-mtv [18:31:40] <bulach> stuartmorgan: ahn, right! that would avoid the extra gclient sync :) luckily I had only one branch.. [18:32:03] <mnissler> bulach, stuartmorgan: just do a svn up within the ffmpeg dir. [18:32:26] <stuartmorgan> BUGabundo_remote: if you have information about the regression range, it's best to put it in the bug [18:32:39] <BUGabundo_remote> stuartmorgan: I did [18:32:43] <stuartmorgan> mnissler: huh? [18:32:44] <BUGabundo_remote> _I think_ [18:32:46] *** TimothyFitz has quit IRC [18:33:03] <bulach> mnissler: problem is that using git, I had a local branch that contained ffmpeg, so when changing branches it'd complain that the files would be overriden.. [18:33:46] <maruel> bulach: rebase [18:33:49] *** wagnoid has joined #chromium [18:33:49] <stuartmorgan> BUGabundo_remote: no need to repeat it here then; that's why we have a bug database ;) [18:34:05] <mnissler> oh, right, you need the svn up when switching back. sorry. [18:34:12] *** wagnoid has left #chromium [18:34:49] <mnissler> Oh, just ignore me, it's getting late here... [18:34:51] <stuartmorgan> maruel: is there a way to rebase without doing a checkout first? [18:35:04] <maruel> that's an excellent question [18:35:10] <maruel> to which I don't have an answer [18:35:34] <rsesek> mnissler: in git? [18:35:37] <stuartmorgan> maruel: if not, you need to either nuke the directory (bulach's suggestion) or move it aside (my suggestion) [18:35:37] <bulach> maruel: that's why I went with the rm :) and stuartmorgan with the mv.. [18:35:41] <phajdan-jr> stuartmorgan: I sometimes do git rebase master if I want to do that [18:35:56] <phajdan-jr> (if that's what you meant) [18:36:30] <stuartmorgan> phajdan-jr: the question is whether you can rebase branch-foo to trunk without first checking out branch-foo [18:36:42] <stuartmorgan> Because the collision here prevents checking out branch-foo in the first place [18:36:52] <mnissler> rsesek: no, within the ffmeg dir after switching back to TOT [18:37:02] <rsesek> ah [18:37:12] * rsesek only knows about git [18:37:14] <phajdan-jr> stuartmorgan: ah, I see; I don't know the answer then [18:37:22] <mnissler> rsesek: worked for me today, but YMMV [18:37:27] * phajdan-jr is afraid that you have to do the checkout before rebase [18:38:27] <mnissler> stuartmorgan: actually, you can pass another revision argument to git rebase, but AFAIK it just results in an ordinary checkout operation before rebasing. but you save some typing :) [18:38:53] <stuartmorgan> mnissler: right, I saw that in git help rebase, but since it says it does a checkout that doesn't really help [18:39:19] <trungl> mnissler: I thought that doing so resulted in fewer files being touched (possibly) [18:39:37] * trungl used to know when he built on slow computers more often. [18:39:45] *** loislo has quit IRC [18:40:25] * pinkerton hugs the try server [18:40:54] <mnissler> \me leaves now. good night, chromium! [18:42:20] <trungl> the try server needs all the love it can get [18:42:31] <maruel> yeah [18:42:33] *** tittiatcoke has quit IRC [18:44:10] *** jrmuizel has joined #chromium [18:44:38] <BUGabundo_remote> stuartmorgan: since its such a nasty bug but not critical, I would like to help have it fix asap [18:44:48] *** slavka`1 has quit IRC [18:44:51] <BUGabundo_remote> making my self available to provide needed info [18:47:49] *** tittiatcoke has joined #chromium [18:47:49] *** tittiatcoke has quit IRC [18:47:49] *** tittiatcoke has joined #chromium [18:51:10] *** GeekShadow has joined #chromium [18:51:47] *** inferno-sec has quit IRC [18:55:06] *** maikmerten has joined #chromium [19:00:49] *** cedricv has joined #chromium [19:02:28] *** dave_levin has quit IRC [19:02:46] *** dave_levin has joined #chromium [19:03:49] *** kcbanner has joined #chromium [19:04:22] <thakis> what's up with gmail today? [19:05:18] <selckin> painfully slow [19:05:19] *** bers has joined #chromium [19:06:07] *** jrmuizel has quit IRC [19:06:58] *** BUGabundo_remote is now known as BUGa_at_GYM [19:07:12] <BUGa_at_GYM> its always like that [19:07:20] <BUGa_at_GYM> if you have some old emails in it [19:07:24] <BUGa_at_GYM> I got a 2 yo mail [19:07:28] <BUGa_at_GYM> you can see my pain [19:08:32] *** BUGa_at_GYM has left #chromium [19:13:34] <thakis> hey, evmar_vacation is sheriff [19:14:00] <thakis> that's dedication [19:16:25] *** pathorn has joined #chromium [19:16:45] <trungl> he needs evmar-bot [19:17:37] <trungl> (to take his vacation for him, of course) [19:17:57] *** markusheintz has quit IRC [19:23:19] <thakis> dhg, estade: purple bot [19:23:29] <thakis> maruel, nsylvain: ^ [19:24:11] <nsylvain> thakis: looking [19:24:34] <nsylvain> :( [19:24:37] <nsylvain> ping thomasvl [19:25:37] <thomasvl> pong [19:25:41] <nsylvain> svn: Failed to add directory '/b/slave/chromium-dbg-mac5-tests-3/build/src/chrome/installer/mac': object of the same name already exists [19:26:15] <nsylvain> did not seem to happen everywhere [19:26:17] <nsylvain> do you know why? [19:26:28] <thomasvl> unless src-internal got checked out first [19:26:34] <thomasvl> it shouldn't have happened [19:26:38] <nsylvain> ok [19:26:44] <thomasvl> did the multthreaded checkout stuff go into gclient? [19:26:51] <nsylvain> no idea [19:27:48] <nsylvain> by looking at the log itlooks like the file was there before.. not sure why.. maybe from a long time ago [19:27:48] <thomasvl> nsylvain: is the second checkout self fixing? [19:28:25] <nsylvain> yeah, but it keeps dying on code.google.com checkouts [19:29:53] <bsmedberg> fishd: is there a doc for how your plugin not-responding code/UI works? [19:30:12] <bsmedberg> fishd: I'm specifically interested in how you handle the java signature verifier, which doesn't spin a nested event loop AFAICT [19:30:41] *** jrmuizel has joined #chromium [19:31:34] <thomasvl> the git logs say the dir came about when i just added it. :( [19:32:11] <thomasvl> nsylvain: got it [19:32:25] <thomasvl> the previous build didn't get the change to src, but got the change to src-internal [19:32:32] <nsylvain> oh [19:32:32] <maruel> thakis: it was reverted because it was broken [19:32:32] <nsylvain> wow [19:32:36] <thomasvl> the src-internal/DEPS puts a dir within it. [19:32:55] <thomasvl> i guess i should have waited longer after pushing the src change before pushing the src-internal one [19:33:03] *** alyxuk has quit IRC [19:33:17] <thakis> maruel: what was reverted? [19:33:42] <thomasvl> nsylvain: it happens because the src checkout gets --revision, but then src-internal got top of trunk [19:33:58] <maruel> oops, thomasvl ^^ [19:34:03] <nsylvain> yeah... makes sense.. i wish we could fix that somehow [19:34:14] <maruel> the parallel gclient checkout [19:34:28] <nsylvain> maruel: that's not it [19:34:42] <maruel> nsylvain: I was replying to thomasvl's question [19:35:01] <maruel> it was implemented and later reverted [19:35:03] <thomasvl> maruel: tx. that ended up not being it in this case. [19:37:24] *** jrmuizel has quit IRC [19:39:13] *** jrmuizel has joined #chromium [19:40:42] *** maikmerten is now known as maik|eat [19:42:37] *** jrmuizel has quit IRC [19:43:16] *** Dataforce has joined #chromium [19:46:15] *** alyxuk has joined #chromium [19:47:00] *** Dataforce has quit IRC [19:47:28] *** loislo has joined #chromium [19:47:59] *** Dataforce has joined #chromium [19:48:49] *** wagnoid has joined #chromium [19:49:15] *** johnny_g has joined #chromium [19:50:34] *** arv has joined #chromium [19:51:50] *** alyxuk| has joined #chromium [19:53:07] *** alyxuk has quit IRC [19:54:42] <thakis> never before did i realize that mac pref windows don't usually remember their onscreen position [19:55:13] <estade> haha is evanm on vacation during his sheriff days? [19:55:41] <estade> gotta remember that one [19:55:45] <eglaysher> estade: best time to take a vacation. [19:57:29] <trungl-bot> Tree status changed: Tree is closed (Automatic: "test_shell_tests" on "Webkit Mac10.5" from 48737: avayvod at google dot com, nsylvain at chromium dot org, thakis at chromium dot org) [19:57:39] <thakis> nooooooo [19:58:22] *** Dataforce has quit IRC [19:58:27] *** rsesek has quit IRC [19:58:36] <estade> thakis: is that you claiming responsibility? [19:59:04] <thakis> estade: had it happened on my earlier commit that touched default_plugin (which i though for a second), then yes [19:59:11] <thakis> but it happened on a prefs change, so i'm not sure [19:59:28] *** maik|eat is now known as maikmerten [19:59:31] <thakis> AppCacheUpdateJobTest.ManifestWrongMimeType failed [20:00:02] *** markmentovai_ has joined #chromium [20:00:03] *** ChanServ sets mode: +v markmentovai_ [20:00:08] <thakis> estade: oh wait, that builder was red before for a different reason, so maybe the blame script is just confused [20:00:19] <estade> thakis: yea, after your earlier commit it didn't have a succesful run [20:00:27] <jam2> bsmedberg: check out \src\chrome\browser\hang_monitor\hung_window_detector.h [20:00:31] *** wagnoid has left #chromium [20:02:11] *** rsesek has joined #chromium [20:02:11] *** ChanServ sets mode: +v rsesek [20:02:26] *** markmentovai has quit IRC [20:02:27] *** markmentovai_ is now known as markmentovai [20:02:42] *** blah_sphemer has joined #chromium [20:03:17] *** TabAtkins_ has joined #chromium [20:04:16] <bsmedberg> hrm... that's vastly different from our implementation [20:04:20] <bsmedberg> interesting [20:05:20] <Waste> weeeee, weird bug [20:05:39] *** Caleb has quit IRC [20:06:29] *** phajdan-jr is now known as phajdan-jr|afk [20:06:35] <thakis> estade: i can't see this happening locally [20:06:43] <thakis> what do the webkit builders build? [20:07:36] <estade> nothing? [20:07:39] *** Dataforce has joined #chromium [20:07:45] <estade> don't they just grab the build from the builders [20:07:48] <thakis> i mean, which build do they get [20:08:02] <thakis> webkit-rel-mac-builder [20:09:16] <estade> thakis: ah. this isn't the first time it crashed today [20:09:20] <estade> http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac10.5/builds/14297/steps/test_shell_tests/logs/stdio [20:09:22] <estade> earlier this morning [20:09:33] <estade> I'll disable [20:09:36] *** lgombos has joined #chromium [20:09:47] <thakis> estade: cool [20:09:55] <thakis> it only crashes in release and i tried in debug [20:10:14] <thakis> but it crashes somewhere unrelated to my cl, and it seems it crashed there even before i checked in [20:10:24] <estade> tes [20:10:25] <estade> yes [20:10:43] *** lgombos has quit IRC [20:12:54] <thakis> only once tho, and no obviously related cls [20:15:57] <vandebo> git Q: on a git branch, if I revert a change and then reapply it, when I later git cl dcommit that branch in will it update the blame for the unreverted lines or does dcommit just work with the diff ? [20:16:05] *** bweinstein has quit IRC [20:17:36] <rsesek> vandebo: dcommit will squash; it does the equivalent of |git diff origin/trunk| and commit [20:17:44] <rsesek> assuming you have your upstream refs right [20:17:49] <vandebo> great, thanks [20:18:39] *** rafaelw has joined #chromium [20:19:18] *** eseidel has joined #chromium [20:20:38] <thakis> clobbered the webkit builder [20:23:58] <estade> thakis: thanks http://codereview.chromium.org/2471007/show [20:24:49] *** shreyas has joined #chromium [20:24:51] <trungl-bot> Tree status changed: Tree open (mac webkit should cycle green) [20:24:56] *** fqian has joined #chromium [20:25:19] *** rsesek has quit IRC [20:25:56] *** markmentovai has quit IRC [20:26:06] *** fta is now known as fta_afk [20:26:15] *** markmentovai has joined #chromium [20:26:15] *** ChanServ sets mode: +v markmentovai [20:29:05] *** rsesek has joined #chromium [20:29:05] *** ChanServ sets mode: +v rsesek [20:31:15] <maruel> Ctrl-Shift-w is the worst keybinding ever [20:32:04] *** loislo_ has joined #chromium [20:33:49] <estade> eglaysher: are you working on bug 44502 (omnibox paint issue)? [20:34:03] *** aroben has joined #chromium [20:34:04] *** aroben has joined #chromium [20:34:20] *** tonyg-cr has quit IRC [20:35:29] *** jrmuizel has joined #chromium [20:35:51] *** loislo has quit IRC [20:35:51] *** loislo_ is now known as loislo [20:36:02] *** jrmuizel has left #chromium [20:37:44] *** jrmuizel has joined #chromium [20:42:20] *** jrmuizel has quit IRC [20:42:46] *** shreyas has quit IRC [20:45:29] *** Caleb has joined #chromium [20:46:33] *** alyxuk has joined #chromium [20:46:34] *** alyxuk has quit IRC [20:46:34] *** alyxuk has joined #chromium [20:48:38] *** alyxuk| has quit IRC [20:50:51] *** mpcomplete has quit IRC [20:51:59] *** johnny_g has quit IRC [20:52:20] *** johnny_g has joined #chromium [20:53:13] *** johnny_g has quit IRC [20:53:44] *** johnny_g has joined #chromium [20:54:10] *** mpcomplete has joined #chromium [20:54:10] *** ChanServ sets mode: +v mpcomplete [20:54:45] *** Kunalagon has joined #chromium [20:54:52] *** paul_irish_ has joined #chromium [20:55:35] *** trungl has quit IRC [20:55:50] *** Aikar has left #chromium [20:56:28] *** paul_irish has quit IRC [21:01:42] *** fta_afk is now known as fta [21:03:26] *** eseidel has quit IRC [21:03:27] *** duffydack has joined #chromium [21:04:34] <thakis> maruel: no. cmd-opt-shift-v is [21:04:42] <thakis> (for "paste and match formatting") [21:04:59] *** wjmaclean_ has joined #chromium [21:05:27] <eglaysher> estade: I haven't started yet. [21:05:33] <eglaysher> estade: do you want it? [21:06:36] <eglaysher> estade: I suspect it's a problem in older gtks and that the way to work around it is to have BookmarkBarGtk::AnimationFinished() queue a draw of the toolbar area. [21:06:48] *** senorblanco has joined #chromium [21:06:48] *** ChanServ sets mode: +v senorblanco [21:07:08] *** alyxuk| has joined #chromium [21:07:28] *** phajdan-jr|afk is now known as phajdan-jr [21:07:37] *** tfarina has joined #chromium [21:09:38] *** alyxuk has quit IRC [21:12:25] *** sjohnson has joined #chromium [21:14:17] *** phajdan-jr has quit IRC [21:17:56] *** tonyg-cr has joined #chromium [21:17:57] *** ChanServ sets mode: +v tonyg-cr [21:19:39] *** jrmuizel has joined #chromium [21:19:45] <rohitrao> hey my compile finally finished [21:21:21] *** aroben has quit IRC [21:21:30] *** jamesr has joined #chromium [21:22:55] *** HansInEffect has joined #chromium [21:24:39] *** AaronMT has quit IRC [21:24:39] *** sshc has quit IRC [21:25:49] *** sjohnson has left #chromium [21:26:11] *** aroben has joined #chromium [21:26:46] *** aroben has quit IRC [21:27:21] *** cli_ has quit IRC [21:27:50] <HansInEffect> Hello all. Does anyone know if websockets are somehow throttled in Chrome for Windows? I'm getting a max of 5 messages per second on Chrome for windows and about 450 per second on Chrome for OS X. [21:28:50] *** bweinstein has joined #chromium [21:28:56] *** Bleak has joined #chromium [21:29:14] *** bweinstein has quit IRC [21:32:29] <jamesr> HansInEffect: hmm, i'm not sure if they are intentionally throttled [21:32:39] <jamesr> HansInEffect: i think ukai would be the most likely to know [21:33:37] *** lgombos has joined #chromium [21:33:49] <HansInEffect> jamesr: It looks like they're definitely throttled to 200 milliseconds from the tests I've done. :/ [21:33:53] *** Hexxeh has joined #chromium [21:34:17] <HansInEffect> jamesr: thanks [21:34:33] *** BCalvignac has joined #chromium [21:38:34] <estade> eglaysher: I'd be interested to know what triggered it [21:43:42] *** Beetny has joined #chromium [21:46:45] *** apatrick_ has joined #chromium [21:47:45] *** dpranke has joined #chromium [21:47:45] *** ChanServ sets mode: +v dpranke [21:47:57] *** bevc_work has joined #chromium [21:48:09] *** cli_ has joined #chromium [21:49:33] *** apatrick_ has left #chromium [21:51:58] *** _rs has joined #chromium [21:52:04] *** hitman_ has joined #chromium [21:53:07] *** hitman_ has quit IRC [21:53:28] *** BryanWB has joined #chromium [21:54:40] *** apatrick_ has joined #chromium [21:56:01] *** vladbph has quit IRC [21:56:36] *** vladbph has joined #chromium [21:59:29] *** mrossetti has joined #chromium [22:00:30] <estade> has anyone noticed that pepper3d ui test is failing consistently? [22:01:03] *** zaspire has quit IRC [22:01:52] <estade> also PrintingContextTest.Base [22:01:54] *** taf2_ has joined #chromium [22:02:28] *** apatrick_ has left #chromium [22:03:06] <estade> tkent: do you think your webkit roll could cause PrintingContextTest.Base failure? [22:03:17] <estade> tkent: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/19419/steps/printing_unittests/logs/Base [22:03:41] *** mc__ has joined #chromium [22:04:01] <trungl-bot> Tree status changed: Tree closed (sorting out test redness) [22:04:04] *** taf2 has quit IRC [22:06:06] *** loislo has quit IRC [22:06:46] *** duffydack has quit IRC [22:07:49] *** inferno-sec has joined #chromium [22:10:55] *** abarth has quit IRC [22:12:07] *** rsimha has joined #chromium [22:15:05] *** Caleb has quit IRC [22:16:01] *** michaeln has joined #chromium [22:16:26] *** Caleb has joined #chromium [22:16:58] *** RobWork has quit IRC [22:18:02] *** eseidel has joined #chromium [22:19:28] <estade> nsylvain: ping [22:19:38] <nsylvain> estade: pong [22:19:48] <estade> nsylvain: this failure has been consitent on vista tests: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/19419/steps/printing_unittests/logs/Base [22:19:55] <estade> ever since the bot turned purple a while back [22:20:02] <nsylvain> yeah, just noticed that too. will fix [22:20:08] <estade> nsylvain: thank you [22:20:40] <oshima1> avayvod: ping [22:21:17] <estade> nsylvain: also vista tests dbg has been mysteriously failling pepper3d test [22:21:27] <estade> i don't see any related changes [22:21:27] <nsylvain> [most likely caused because whoever connected to the bot to fix the purple had the 'share printer' option enabled in RDP.. so it cleared up the printers on the machine when rdp was disconnected] [22:21:37] <akalin> greetings chromiumites [22:21:44] <estade> nsylvain: ah. interesting [22:22:04] <nsylvain> as for pepper3d, not sure yet. i can look after [22:22:09] <estade> ok [22:22:50] <oshima1> chromeos bot is failing after r48735 [22:22:54] *** Venom_X is now known as Venom_lnch [22:23:50] <oshima1> i'm going to revert it. any objection? [22:24:53] *** duffydack has joined #chromium [22:25:11] *** bweinstein has joined #chromium [22:25:19] *** howlymowly has joined #chromium [22:27:52] *** frode15243 has joined #chromium [22:28:34] *** AaronMT has joined #chromium [22:29:29] <akalin> ffmpeg more like ffffffmpeg [22:30:28] *** willchan-mtv has quit IRC [22:30:48] <rubenbb> hah, write your own then and make it BSD-licensed :) [22:31:15] <akalin> maybe i will [22:31:33] <thakis> a hollow threat [22:31:46] *** _rs has quit IRC [22:32:19] *** willchan_ has joined #chromium [22:32:19] *** ChanServ sets mode: +v willchan_ [22:34:10] <akalin> i'll name it ffmpeg-nothakisallowed [22:35:21] <rubenbb> wc -l shows 500k lines in patched-ffmpeg-mt, that's compared to 730k in chrome/browser [22:35:52] <akalin> i'll rewrite it in go [22:35:54] <akalin> problem solved [22:36:08] <rubenbb> lol [22:36:38] <akalin> i was just bringing it up because of the third_party/ffmpeg error i ran into (about which there's an e-mail) [22:38:11] *** RobWork has joined #chromium [22:41:23] *** bers has quit IRC [22:42:14] <estade> oshima1: are you reverting 48735, or should I [22:42:27] <oshima1> i just made CL [22:42:28] <oshima1> http://codereview.chromium.org/2498003 [22:42:40] *** trungl has joined #chromium [22:42:40] *** ChanServ sets mode: +v trungl [22:42:47] <oshima1> i tested it locally and tests passed. [22:42:50] <estade> great, thanks. lgtm [22:42:51] <nsylvain> estade: Did anyone else look at Pepper3d ? Not sure what this is.. tempted to just reboot the machine [22:43:00] <estade> nsylvain: no complaint from me [22:43:01] <oshima1> may i check it in? [22:43:07] <estade> oshima1: please do [22:43:35] <oshima1> k. btw, it has change to grd file. just fyi. [22:44:05] <estade> oshima1: is it possible to leave that part out of the change [22:44:14] <oshima1> grd? [22:44:21] <oshima1> estade: let me check... [22:44:22] <estade> you are just deleting stuff right? [22:44:39] <estade> leave it in there, assuming instead of removing and later re-adding [22:44:39] *** BryanWB has quit IRC [22:44:53] <estade> s/assuming// [22:45:12] <nsylvain> the grd change did not break anything when it got introduced, so it might not break anything now... but there is still a chance... excluding it makes sense if it wont break the code [22:45:14] <oshima1> estade: ok, will do. hold on... [22:45:39] *** RobWork has quit IRC [22:46:00] <andybons> rohitrao: ping [22:46:54] <oshima1> estade: done. http://codereview.chromium.org/2498003 [22:47:42] *** RobWork has joined #chromium [22:49:00] *** maikmerten has quit IRC [22:51:06] <oshima1> estade: i'm checking it in. [22:51:25] <estade> nice [22:52:24] <oshima1> done [22:52:33] <rsesek> does anyone know how to use gmock with something that's RefCountedThreadSafe? [22:52:36] *** Martijnc has joined #chromium [22:52:36] *** RobWork has quit IRC [22:53:07] *** RobWork has joined #chromium [22:56:03] *** bent-mozilla has quit IRC [22:56:27] *** BeholdMyGlory has quit IRC [22:56:52] <akalin> rsesek: what do you mean? [22:57:02] <akalin> oh, i see [22:57:11] <akalin> can't you just use a scoped_refptr? [22:59:33] <rsesek> akalin: will try [22:59:35] *** willchan_ has quit IRC [23:00:23] <akalin> gmock is black magic [23:00:52] *** RobWork has quit IRC [23:01:45] *** AaronMT has quit IRC [23:01:57] *** paul_irish_ has quit IRC [23:03:21] <rsesek> akalin: that was the missing piece ? thanks [23:06:23] *** RobWork has joined #chromium [23:06:31] <akalin> rsesek: cool [23:06:33] *** willchan_ has joined #chromium [23:06:34] *** ChanServ sets mode: +v willchan_ [23:07:47] *** Venom_lnch is now known as Venom_X [23:08:03] <trungl-bot> Tree status changed: Tree's open (should be getting greener) [23:08:30] <estade> nsylvain: restarting the bot succesfully fixed pepper3d [23:08:42] <estade> and broken hostnetworkstackunresponsiverenderer >_< [23:08:44] <nsylvain> and caused another problem [23:08:45] <nsylvain> yeah [23:08:46] <nsylvain> :( [23:09:42] *** eseidel has quit IRC [23:12:02] *** antarus has joined #chromium [23:13:16] *** tfarina has quit IRC [23:14:40] *** estade has quit IRC [23:15:06] *** estade has joined #chromium [23:15:06] *** ChanServ sets mode: +v estade [23:15:21] *** frode15243 has quit IRC [23:15:39] *** thomasvl has quit IRC [23:16:32] *** mfinkle has quit IRC [23:17:18] <estade> pkasting__: a lot of mac layout test failures since your roll [23:17:28] *** miketaylr has quit IRC [23:18:14] <pkasting__> Huh, that's weird [23:18:17] <pkasting__> I'll look [23:18:26] <estade> http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Mac10.5%20(dbg)(1) [23:18:30] <pkasting__> Layout test bots seemed clean, maybe I misread them [23:20:42] <andybons> rsesek: INTERN [23:20:50] *** paul_irish has joined #chromium [23:20:54] <rsesek> yes? [23:21:14] <andybons> rsesek: I need coffee and pinned tabs expertise. [23:21:25] <thakis> coffee is an excellent idea [23:21:33] *** thakis is now known as thakis_coffee [23:21:33] <rsesek> andybons: you can get your own coffee, what about pinned tabs? [23:21:53] * andybons prepared his intern lashing stick [23:22:12] <andybons> rsesek: actually let's talk on corp. [23:22:15] <rsesek> sg [23:22:44] <antarus> I wish my intern made me coffee :/ [23:22:49] *** ROBOd has quit IRC [23:22:49] <Waste> you lot are cryptic [23:23:18] <andybons> antarus: well the sad part is that he's not making me coffee [23:23:49] <Waste> get the whip out [23:23:54] *** thakis_coffee is now known as thakis [23:24:08] <rsesek> I'm currently 3000 miles away :) [23:24:09] * antarus should take friday and actually learn about the build process again [23:24:22] <antarus> rsesek: I'm sure it would survive interoffice [23:24:43] *** Martijnc_ has joined #chromium [23:24:58] <thakis> rsesek: maybe you could dehydrate the coffee somehow for transportation [23:25:06] <pkasting__> estade: Wow, that _is_ a lot of test failures. [23:25:06] <thakis> then andybons only needs to add hot water [23:25:11] <rsesek> or he could walk a few feet to the minikitchen [23:25:14] <rsesek> and press 3 buttons [23:25:17] <rsesek> ;) [23:25:24] <antarus> no way [23:25:28] *** Martijnc has quit IRC [23:25:28] <antarus> that coffee is disgusting [23:25:32] <antarus> you need to make your own [23:25:43] <andybons> rsesek: if by few you mean a lot of feet, then i would agree with you [23:25:56] <antarus> I feel I've taken this channel to bad place however [23:26:01] <antarus> return to useful discussion! [23:26:06] <rsesek> distance(CA, NY) < distance(desk, mini_kitchen) [23:26:12] <rsesek> *> [23:26:34] <thakis> this isn't about distance but about time tho [23:26:43] <thakis> you need to take into account just how slowly andybons moves [23:27:00] <andybons> thakis: yes. i suppose i could run like many of my co-workers, which I have NEVER understood [23:27:12] <andybons> markmentovai: ^^^ [23:27:37] <markmentovai> lips flappin' [23:27:38] <rsesek> I think it may take me a few weeks to walk to NY from MTV [23:27:58] <andybons> rsesek: well when you get here my coffee better stiil be hot [23:28:07] <rsesek> I'll throw it in the microwave [23:28:09] <rsesek> when I get there [23:28:19] <rsesek> and leave it in the minikitchen for you [23:28:39] *** apatrick_ has joined #chromium [23:28:40] * andybons boobytraps rsesek's desk [23:29:15] *** apatrick_ has left #chromium [23:30:09] <HansInEffect> Does anyone know if websockets are somehow throttled in Chrome for Windows? I've tested and I'm getting 5 round trips per second on Windows and 450 round trips per second on OS X. I'm running this test: http://gist.github.com/423013 (uses node.js) [23:31:45] <pkasting__> estade: I think this may actually be due to vangelis' change instead of mine. Still looking [23:32:10] <estade> pkasting__: ah ok. I didn't really look at the other cls after i saw a webkit roll [23:32:37] <pkasting__> estade: It could be something in the roll alone, but that's a little strange since the Mac canary was OK. [23:36:37] *** GeekShadow has quit IRC [23:38:44] <rubenbb> I just diffed Iron 4 against the relevant chromium commit: here's the full diff (http://chromium.jaggeri.com/iron4.diff) and here's the ~120 lines of code actually changed, once you exclude comments and s/Chrome/Iron/ - http://chromium.jaggeri.com/iron4-code.diff [23:38:50] *** tittiatcoke has quit IRC [23:39:14] *** cyy has joined #chromium [23:39:45] *** willchan_ has quit IRC [23:39:56] <akalin> rubenbb: naisu [23:40:25] <akalin> what's with the "and menu" appending [23:40:47] <akalin> that seems like a large part of the diff, too [23:41:19] <rubenbb> most likely noise to hide the minimal code changes :) [23:41:40] <rubenbb> there are 5k files that have that same comment changed [23:41:50] <akalin> oh, i see, i didn't see your 2nd link [23:42:54] <akalin> it looks like he modifies only the windows-specific controls [23:42:54] <akalin> lol [23:44:42] *** shepazu has joined #chromium [23:46:33] <rubenbb> that may be because he only releases source for the windows version, you'll see several vcproj files in the first diff. There are Iron versions for linux and mac too though [23:46:49] <akalin> oh [23:47:41] <rubenbb> the best part is that he's compiling 5.0.306 but he relabels the version number as 4.0.280 for whatever reason :) [23:48:10] <akalin> is iron still active? [23:48:17] <akalin> i haven't seen anything about it in forever [23:48:42] <rubenbb> they release sporadically, last release was of this source compiled in january [23:48:47] <akalin> oh [23:48:49] <akalin> 'they' [23:48:51] <akalin> isn't it just one guy [23:49:17] <rubenbb> I checked every couple months to see when he released the source, finally noticed that it was posted recently [23:49:23] <rubenbb> no idea how many people are behind it [23:49:48] *** andybons has quit IRC [23:50:33] <akalin> i think the creator came in here once [23:51:28] *** dglazkov has joined #chromium [23:51:28] *** ChanServ sets mode: +v dglazkov [23:51:32] *** Paradox has joined #chromium [23:52:00] <rubenbb> yeah, evan wrote that up - http://neugierig.org/software/chromium/notes/2009/12/iron.html [23:52:12] <akalin> yeah [23:53:13] <Paradox> can i inquire about this bug and how close it is to being fixed? http://code.google.com/p/chromium/issues/detail?id=25334 [23:53:45] <pkasting__> estade: kbr is going to take a look at what changed to cause these webgl tests to fail [23:53:55] <pkasting__> estade: Since none of us are sure what happened ATM [23:54:07] <estade> pkasting__: kthx [23:54:20] <pkasting__> estade: Hopefully we'll have an answer soon so we don't have to leave the bot red for long [23:54:35] *** huckphin has joined #chromium [23:55:18] <akalin> Paradox: given that it has no owner, probably not soon [23:55:31] <Paradox> :(. Thats a shame, because it really cripples a useful feature [23:55:46] <akalin> seems like a webkit problem [23:55:55] <Paradox> doesn't show up in safari or on mobile... [23:55:58] <akalin> oh [23:56:09] <Paradox> and when i reported it to #webkit [23:56:13] <Paradox> they say its chrome's implementation [23:56:19] <akalin> hunh, weird [23:56:23] <pkasting__> estade: Do you want me to skip all the webgl tests to make the tree green in the meantime, or are you OK waiting a bit? [23:56:45] <akalin> Paradox: you may want to bump that bug with that info [23:57:06] <estade> pkasting__: waiting seems fine. [23:57:52] <pkasting__> estade: OK. I'm going to be AFK for a couple hours, then. [23:58:10] <estade> pkasting__: ok [23:58:23] *** kbr_google has joined #chromium [23:58:34] <trungl-bot> Tree status changed: Tree's open (kbr looking at mac webkit layout tests)