[00:00:12] <stuartmorgan> pinkerton: In as much as I want to do any of it, yes [00:00:18] <pinkerton> hm [00:00:35] <stuartmorgan> pinkerton: The goal here is essentially to pretend that closing the last window is quitting, for users who come from Windows [00:00:50] <rohitrao> wait, closing the last window doesn't remove it from the session, does it? [00:01:11] <pinkerton> yeah, we may just need to trick the session restore into not removing the last window [00:01:23] <pinkerton> but it might get confused when you then create another [00:02:57] *** bweinstein has quit IRC [00:03:27] <sky__> I'm to blame for at least one of the valgrind failures. [00:03:29] <sky__> I'll look into it now. [00:03:50] <pinkerton> ok well enough of this for now, dinner time [00:03:52] *** pinkerton has quit IRC [00:04:49] <akalin> boo closed tree [00:05:03] <akalin> boo valgrind failures [00:06:31] *** thakis_ has joined #chromium [00:06:32] *** ChanServ sets mode: +v thakis_ [00:07:14] <willchan> akailn: i'm hitting CHECKs in syncable.cc, is this a known issue? [00:07:16] *** rohitrao has quit IRC [00:07:17] <willchan> er, akalin [00:07:33] <sky__> All the linux ui valgrind failures are me. [00:07:36] <chronarion> sky__ will you file a fix or suppression, or should we? [00:07:36] <sky__> I'm fixing now. [00:07:38] <chronarion> OK [00:07:39] <willchan> on successor.good() [00:07:43] <willchan> 1370 [00:07:48] <akalin> willchan: i don't think so -- can you file a bug? [00:07:52] <sky__> I'll do it. [00:07:56] <chronarion> gotcha, thanks! [00:08:08] <skrul> sky__: thanks [00:08:10] <sky__> I'm doing it now, but no point in holding the tree closed for it. [00:08:20] *** bweinstein has joined #chromium [00:08:26] <chronarion> open [00:08:42] <chronarion> long as it has an owner [00:08:45] <willchan> akalin: looks like it's something in my profile. --user-data-dir to a new profile fixes it [00:08:46] *** thakis_ has quit IRC [00:08:47] <akalin> yay open tree [00:08:47] <willchan> i'll file a bug [00:09:01] <akalin> willchan: okay, yeah, that sounds like a legit bug [00:09:03] *** sebmarkbage has quit IRC [00:09:13] <akalin> can you keep your old profile dir around in case it's needed for debugging? [00:09:21] <akalin> or just your 'Sync Data' dir [00:09:27] <willchan> akalin: sure, i'll back it up [00:09:30] <akalin> thanks [00:09:46] *** thakis_ has joined #chromium [00:09:46] *** ChanServ sets mode: +v thakis_ [00:09:54] *** beej666 has quit IRC [00:10:13] *** beej666 has joined #chromium [00:10:51] *** roc has joined #chromium [00:12:26] <akalin> willchan: assign the bug to me [00:12:37] <sky__> suppression landed [00:12:40] <willchan> akalin: ok [00:14:31] *** kellegous has quit IRC [00:15:16] *** bent-mozilla has quit IRC [00:18:59] <sky__> my fix is only for the ui tests. the net tests have a bunch of valgrind errors. [00:19:04] <sky__> not sure if it's flake or what. [00:19:26] <sky__> and it won't effect linux unit_tests either. [00:19:29] <sky__> Different flake there. [00:19:32] <sky__> or real bugs. [00:20:31] <skrul> sky__: i'll run them locally and see what's up [00:21:25] *** beej666 has quit IRC [00:22:23] *** smorg has joined #chromium [00:22:52] *** johnny_g has quit IRC [00:22:58] *** johnny_g has joined #chromium [00:24:49] *** darwin_ has quit IRC [00:24:59] *** plafayette has quit IRC [00:27:25] *** tonikitoo has joined #chromium [00:29:20] <akalin> willchan: is this an old profile? [00:29:39] <akalin> i.e., >= 2 months or so [00:30:01] <willchan> akalin: hm...it's old, not sure if it's 2 months old [00:30:04] <willchan> might be [00:30:23] <willchan> i haven't restarted that google-chrome instance in a long time [00:31:42] <akalin> okay [00:32:35] <akalin> willchan: for what it's worth, you don't have to nuke your entire profile, just the sync data dir [00:34:19] <akalin> willchan: do you remember the chrome version before you restarted? [00:34:23] <akalin> i assume you restarted to update [00:35:06] *** ayo is now known as aho [00:35:16] <willchan> akalin: i restarted because i hung my box :) [00:35:22] <akalin> :( [00:35:25] <willchan> akalin: sorry, i don't know the old version [00:35:27] <akalin> okay [00:35:45] <jamesr> we need to make chrome a little bit crashier so this sort of thing doesn't happen [00:36:05] <jamesr> a browser restart a day keeps the profile corruption bugs away :) [00:36:41] <Namegduf> Wow. [00:36:54] <jamesr> note: that was a joke [00:36:57] <Namegduf> I've found Chrome tended to crash if I updated it without restarting, so I've done it much more often. XD [00:37:08] <jamesr> Namegduf: what OS? that should be fixed now [00:37:20] <Namegduf> It might be fixed now, Linux 64bit. [00:37:22] <akalin> the good news is that this profile/sync data corruption bug may already be fixed [00:37:31] <willchan> ok [00:40:12] *** dmazzoni has joined #chromium [00:42:01] *** eseidel has joined #chromium [00:45:29] *** Sarten-X has joined #chromium [00:46:19] *** Waste has left #chromium [00:46:49] *** janm has quit IRC [00:50:48] <skrul> sky__: hey where did you see evidence of the net valgrind failure on the bots? i see it locally but i'm curious how you first saw it [00:54:55] *** beej666 has joined #chromium [00:55:43] <sky__> http://build.chromium.org/buildbot/memory/waterfall?builder=Chromium%20OS%20UI%20(valgrind)(1) [00:56:18] <sky__> I'm wrong, that's just unit. [00:56:44] <sky__> http://build.chromium.org/buildbot/memory/waterfall?builder=Linux%20Heapcheck showed a net failure earlier. [00:56:46] <sky__> looks ok now. [00:57:22] <skrul> ah i see it now [01:03:43] *** smorg has quit IRC [01:03:51] *** _rs has quit IRC [01:05:34] <nshkrob_> skrul: when can I recommit my CL (rev 48061)? I don't think I caused any of those failures [01:06:15] <skrul> nshkrob_: yes i don't think so either :) sorry for the unneeded revert [01:06:22] <skrul> nshkrob_: feel free to commit any time [01:06:31] <nshkrob_> sure, thanks [01:09:41] *** yutak_home has joined #chromium [01:09:41] *** ChanServ sets mode: +v yutak_home [01:12:16] *** FullFlannelJacke has joined #chromium [01:20:28] *** dmazzoni has quit IRC [01:20:28] *** nickcarter has quit IRC [01:21:38] *** thakis_ has quit IRC [01:22:33] *** bweinstein has quit IRC [01:23:25] <jhawkins> satorux, ncarter (nick?), skrul: I'm landing a CL that enables AutomatedUITestBase.ShowBookmarkBar, keeping an eye on it [01:23:51] <skrul> jhawkins: thanks for the warning [01:24:12] <victorw> eseidel: hi [01:24:22] <eseidel> greetings [01:24:51] <victorw> eseidel: looks like your webkit patch 60095 breaks webkit canary bot: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/27391/steps/compile/logs/stdio [01:24:56] <eseidel> victorw: see #webkit [01:24:57] *** eseidel has left #chromium [01:26:09] *** beej666 has quit IRC [01:26:14] *** beej666 has joined #chromium [01:26:55] *** andybons has quit IRC [01:27:56] <sky__> what cups package do I need to apt-get now? [01:28:25] <skrul> sky__: libcupsys2-dev [01:28:38] <sky__> tx [01:28:51] <sky__> I had that, but forgot the 'install' keyword. *SIGH* [01:30:58] *** bweinstein has joined #chromium [01:32:32] *** MikeSmithW3C has quit IRC [01:32:54] *** markmentovai has quit IRC [01:34:13] *** rsesek has quit IRC [01:35:00] *** jparent_ has joined #chromium [01:35:05] *** inferno-sec has left #chromium [01:37:26] *** MikeSmithW3C has joined #chromium [01:38:58] *** bweinstein has quit IRC [01:48:32] *** beej666_ has joined #chromium [01:48:41] *** beej666 has quit IRC [01:48:41] *** beej666_ is now known as beej666 [01:58:37] *** bweinstein has joined #chromium [02:02:20] *** Adys has quit IRC [02:03:40] *** dpranke has joined #chromium [02:03:41] *** ChanServ sets mode: +v dpranke [02:07:26] *** thakis is now known as thakis_afk [02:07:29] *** magn3ts has joined #chromium [02:08:19] *** RT|Chatzilla has joined #chromium [02:08:21] <magn3ts> Is there a native client IRC? [02:09:00] *** fqian has quit IRC [02:09:04] <chronarion> jhawkins: i'm sheriff #2 in place of ncarter [02:09:14] <jhawkins> chronarion: gotcha [02:09:53] <magn3ts> anyone know if the native client api allows for low level packet capture/transmission? [02:11:54] *** leiz has left #chromium [02:13:17] *** reiz has joined #chromium [02:13:25] *** reiz has quit IRC [02:13:35] *** reiz has joined #chromium [02:13:52] *** Adys has joined #chromium [02:13:57] *** reiz has left #chromium [02:15:12] *** reiz has joined #chromium [02:15:15] *** reiz has left #chromium [02:16:36] *** js2 has joined #chromium [02:19:26] *** thakis has joined #chromium [02:19:26] *** ChanServ sets mode: +v thakis [02:20:20] *** dpranke has quit IRC [02:21:36] <js2> maruel: ? [02:22:44] <js2> i notice there's some support in the gyp files for running dump_syms on Mac/Linux, but I can't find similar support for running it (nor symupload) on Windows. Am I missing something or do you not create breakpad symbols during the Windows build process, but rather as some post-build step? [02:23:12] *** jparent_ has quit IRC [02:23:20] *** stuartmorgan has quit IRC [02:23:53] *** dpranke has joined #chromium [02:23:53] *** ChanServ sets mode: +v dpranke [02:24:02] *** lianj has joined #chromium [02:24:08] *** tonyg-cr has quit IRC [02:26:13] *** cying has quit IRC [02:27:38] *** lianj_ has quit IRC [02:28:49] *** bweinstein has quit IRC [02:29:12] *** bweinstein has joined #chromium [02:31:01] *** narsil has quit IRC [02:31:29] <chronarion> tony^work: do we need clobbers or.. [02:31:37] <tony^work> oh, did I break something? [02:31:38] <tony^work> sorry [02:32:02] <tony^work> ARGH, OTP [02:32:09] <skrul> up [02:32:10] <skrul> um [02:32:11] <chronarion> the tree looks a wee bit hosed [02:32:15] <brettw> I haven't been able to upload patches to reitveld from my Linux box lately. I get the error "urllib2.URLError: <urlopen error (-2, 'Name or service not known')>" [02:32:18] <skrul> space bomb? [02:32:19] <brettw> Anybody have any ideas? [02:32:31] <skrul> brettw: check if you have a proxy set [02:32:42] <skrul> brettw: echo $http_proxy [02:32:55] *** js2 has quit IRC [02:32:56] <tony^work> yeah, let's roll back [02:32:59] <tony^work> I'm reverting [02:33:01] <chronarion> k [02:33:10] <brettw> skrul: it's weird, do I need to reboot? [02:33:18] *** Kaosevil has quit IRC [02:33:32] <skrul> brettw: i've been struggling with it as well and have just gotten into the habit of doing "unset http_proxy" [02:33:38] <ojan> brettw: btw, ap was looking for you on #webkit [02:33:51] <brettw> ojan, okay [02:33:53] <skrul> brettw: i suspect it has something to do with the fact that i've configured the gnome level proxy to the new goog proxy [02:33:57] <tony^work> waiting for drover [02:34:03] <ojan> brettw: that was quite a while ago though. [02:34:10] <jamesr> oh right [02:34:14] <jamesr> he said he'd CC you on a bug [02:34:19] <tony^work> revert committed [02:34:44] <chronarion> will it need rebuilds? [02:34:47] <chronarion> or just roll green? [02:36:30] *** General13372 has joined #chromium [02:36:44] <tony^work> I think it will just roll green [02:36:49] <chronarion> k [02:37:08] <tony^work> we might want to let a couple bots compile green= [02:37:11] * tony^work shrugs [02:39:32] *** General1337 has quit IRC [02:40:26] *** mrossetti has quit IRC [02:43:16] *** tfarina has joined #chromium [02:43:30] <nirnimesh> 500 Server Error on codereview [02:43:51] <tfarina> me too [02:43:53] <chronarion> ruh oh [02:43:56] <chronarion> 502 bad gateway [02:44:17] <chronarion> I need to run errands, skrul is sheriff now [02:45:02] <skrul> last one standing [02:46:55] *** Nobu has joined #chromium [02:48:50] <Nobu> Are extension development questions legal here? [02:49:06] <thakis> Nobu: not really. try the chromium-extensions mailing list [02:49:22] <Nobu> thakis: Alright, thanks. [02:49:23] <thakis> Nobu: but if it's a short question, maybe someone will answer it in practice [02:51:31] <Nobu> I'm trying to send sender.tab.id as a response to a request from a content script, but I'm getting undefined instead. Is that not allowed? [02:52:12] *** Caleb is now known as archdemon [02:52:35] *** archdemon is now known as Caleb [02:55:00] <tfarina> still unable to access codereview :/ [02:55:11] *** eseidel_ has joined #chromium [02:55:39] *** bweinstein has quit IRC [02:55:47] *** plops has quit IRC [02:56:37] *** plops has joined #chromium [02:57:33] *** sshc has quit IRC [02:58:49] *** thakis has quit IRC [02:59:41] *** inferno-sec has joined #chromium [02:59:45] *** eseidel_ is now known as eseidel [03:00:18] *** mfinkle has quit IRC [03:00:34] <brettw> HOW COME NOT CODE REVIEW SERVER. ME NOT WANT 500 [03:00:37] *** mfinkle has joined #chromium [03:01:12] *** js2 has joined #chromium [03:02:29] <nirnimesh> appears to be a general appengine problem. I see other 500 on other apps too [03:03:21] *** js2 has quit IRC [03:05:13] <skrul> tony^work: do you think these failures are related to your revert? [03:05:38] <tony^work> it looks like svn up is failing [03:06:27] *** csilv has left #chromium [03:06:28] <skrul> ah yes [03:06:35] <skrul> perhaps related to the other app engine issues? [03:06:55] <akalin> 'epithet that rhymes with app' engine [03:06:58] <tony^work> seems like it's failing in lots of places [03:09:06] <tfarina> big problem? [03:09:20] <skrul> i'll try force building one of the linux builders and see if it goes away [03:11:23] <skrul> seems to be going [03:12:12] *** js2 has joined #chromium [03:12:42] *** MikeSmithW3C has quit IRC [03:13:30] *** tfarina has quit IRC [03:14:39] <skrul> ok all the orange linux builders seem to be working again,they got past gclient [03:14:41] *** yutak_home has quit IRC [03:15:18] *** js2 has quit IRC [03:16:30] *** bweinstein has joined #chromium [03:17:20] <tony^work> yeah, things seem to be going green now [03:17:25] <tony^work> let's wait a bit before reopening [03:17:30] *** bweinstein has joined #chromium [03:17:43] *** johnny_g has quit IRC [03:18:15] <skrul> tony^work: yea lets wait till there is lots of green [03:19:37] *** hbono has joined #chromium [03:20:13] *** dave_levin has quit IRC [03:23:37] *** trungl is now known as trungl_away [03:23:42] *** yuzo has quit IRC [03:26:29] *** ec is now known as HARPOON [03:29:51] *** eroman has quit IRC [03:30:06] *** HARPOON is now known as HARPIE [03:30:34] *** HARPIE is now known as harpfork [03:30:39] *** zyichi has joined #chromium [03:30:50] *** harpfork is now known as elliottcable [03:33:56] *** rafaelw has left #chromium [03:38:12] *** jamesr has quit IRC [03:38:24] *** pathorn has quit IRC [03:39:34] *** tfarina has joined #chromium [03:40:04] *** bauerb has quit IRC [03:42:39] *** rohitrao has joined #chromium [03:42:40] *** ChanServ sets mode: +v rohitrao [03:42:50] *** rohitrao has quit IRC [03:48:55] *** _gschmidt has joined #chromium [03:50:10] <_gschmidt> Hi, I noticed that when running the v8 profiler from the command line, the stack depth that's logged is limited to the most recent 65 frames. What would I change to increase this? [03:52:22] *** beej666 has quit IRC [03:55:33] *** MikeSmithW3C has joined #chromium [03:57:43] <_gschmidt> For the logs: the answer is src/v8/src/platform.h, TickSample::kMaxFramesCount. It's a constant so recompilation will be necessary. [03:59:34] *** skydrome has quit IRC [03:59:54] *** skydrome has joined #chromium [04:04:20] *** js2 has joined #chromium [04:05:40] *** rafaelw has joined #chromium [04:09:46] *** rafaelw has quit IRC [04:10:26] <skrul> i just opened the tree, lets see how things go [04:11:14] *** dave_levin has joined #chromium [04:14:15] *** js2 has quit IRC [04:14:19] *** trungl_mbp has joined #chromium [04:14:46] *** rafaelw has joined #chromium [04:17:07] *** wers has joined #chromium [04:22:51] *** rafaelw has left #chromium [04:24:49] *** tedoc2000 has quit IRC [04:34:39] *** tfarina has quit IRC [04:35:13] *** Beetny has joined #chromium [04:37:55] *** jparent_ has joined #chromium [04:41:05] *** yuzo has joined #chromium [04:41:53] *** masterov has quit IRC [04:42:12] *** masterov has joined #chromium [04:46:47] *** dpranke has quit IRC [04:48:19] *** trungl_mbp has quit IRC [04:52:42] *** yuzo has quit IRC [04:58:11] *** haTem has joined #chromium [04:58:57] *** haTem has left #chromium [04:59:09] *** trungl_mbp has joined #chromium [05:11:59] *** sshc has joined #chromium [05:18:25] *** tedoc2000 has joined #chromium [05:25:26] *** kenneth_reitz|kr has joined #chromium [05:27:55] *** sshc_ has joined #chromium [05:28:43] *** masterov has quit IRC [05:30:36] *** sshc has quit IRC [05:33:03] *** sshc_ has quit IRC [05:34:46] *** magn3ts has quit IRC [05:35:56] <akalin> yay open tree [05:37:56] *** cying has joined #chromium [05:41:14] *** magn3ts has joined #chromium [05:42:33] *** kreitz has joined #chromium [05:45:55] *** kenneth_reitz|kr has quit IRC [05:46:26] *** kreitz has quit IRC [05:48:15] *** Zucca has joined #chromium [05:50:01] <akalin> heading home, if my latest change breaks the tree before i get home (~20 min), feel free to revert [05:51:43] *** sshc has joined #chromium [05:53:32] *** yusukes has quit IRC [05:54:23] *** magn3ts has quit IRC [05:56:50] *** cedricv has quit IRC [05:56:52] *** magn3ts_ has joined #chromium [05:57:52] *** sshc has quit IRC [05:58:00] *** thakis has joined #chromium [05:58:00] *** ChanServ sets mode: +v thakis [05:58:03] *** sshc has joined #chromium [06:05:00] *** echelog-1 has joined #chromium [06:05:35] *** yusukes has joined #chromium [06:07:02] *** magn3ts_ has quit IRC [06:11:31] *** matthew_y has joined #chromium [06:14:16] *** cedricv has joined #chromium [06:19:40] *** kzman has joined #chromium [06:19:44] *** hagabaka has quit IRC [06:20:13] *** trungl_mbp is now known as trungl [06:20:14] *** ChanServ sets mode: +v trungl [06:20:29] *** wers has quit IRC [06:20:31] <trungl> Good evening, Chromium! [06:20:39] <m0> trungl: good evening :) [06:21:03] <trungl> 'evening, m0. :) [06:21:54] *** dave_levin has quit IRC [06:23:06] *** bweinstein has quit IRC [06:23:28] <m0> trungl: did you see feldstein preview extension :) [06:23:34] <m0> trungl: http://codereview.chromium.org/2101019 [06:24:12] <trungl> m0: have you read the description? [06:24:22] <trungl> :P [06:24:30] * m0 slaps trungl with a windows trout, jup [06:24:51] <m0> its cool, you guys using same stuff BMM using [06:24:58] *** jparent_ has quit IRC [06:25:47] <trungl> clearly, we now have a plan of sorts [06:25:54] <trungl> we'll see how it goes [06:27:09] <m0> :) [06:28:11] *** jrforbes has quit IRC [06:28:23] *** yusukes has quit IRC [06:30:07] *** sshc has quit IRC [06:30:23] *** sshc has joined #chromium [06:32:21] *** yusukes has joined #chromium [06:33:47] *** Zucca has quit IRC [06:34:33] *** yuzo has joined #chromium [06:35:53] <m0> gnite chromium! [06:35:58] <m0> 24 > Lost [06:38:24] *** leeight has joined #chromium [06:38:26] *** leeight has left #chromium [06:38:41] <tony^work> hmm, page_cycler_intl1 failing on linux is a bit worrying [06:42:40] *** dave_levin has joined #chromium [06:42:55] <tony^work> oh, it passed on Linux perf(1) [06:43:29] *** dave_levin has quit IRC [06:43:40] *** dave_levin has joined #chromium [06:47:35] <tony^work> looking into failing layout test [06:50:50] <tony^work> I will disable the test for now [06:50:53] *** Beetny has quit IRC [06:51:14] *** kzman has left #chromium [06:55:39] *** yuzo has quit IRC [07:12:20] *** Zaba has quit IRC [07:23:22] *** Zaba has joined #chromium [07:33:13] *** MikeSmithW3C has quit IRC [07:37:45] *** MikeSmithW3C has joined #chromium [07:39:31] *** darwin_ has joined #chromium [07:39:41] *** matthew_y has quit IRC [07:40:02] *** tonikitoo is now known as IRCMonkey [07:40:05] *** matthew_y has joined #chromium [07:42:11] *** sundiamonde has quit IRC [07:50:12] *** tedoc2000 has quit IRC [07:51:16] *** wers has joined #chromium [07:51:46] *** beej666 has joined #chromium [07:52:40] *** beej666 has quit IRC [07:54:19] *** roc has quit IRC [07:54:51] *** roc has joined #chromium [08:02:50] *** trungl has quit IRC [08:03:17] *** trungl_mbp has joined #chromium [08:07:22] *** hbono has left #chromium [08:07:31] *** abarth|parser5 is now known as abarth|entity5 [08:07:43] *** hbono has joined #chromium [08:08:50] *** npm has quit IRC [08:09:56] *** hachque has joined #chromium [08:10:22] <hachque> i'm having an odd issue where Chrome starts up, then freezes for around 10-15 seconds, before coming back and being completely responsive [08:10:37] <hachque> this is part of a wider system problem, .NET applications also take a long time to load [08:10:51] <hachque> i've gone through the usual optimization stuff such as defragging, etc.. [08:11:15] <hachque> i'm wondering what Chrome is doing at startup that could cause it to lock up the main UI [08:12:05] <hachque> it's about 5 seconds after chrome starts [08:12:35] <hachque> it happens only when the first chrome window opens (i.e. if i open another window with one already open, it doesn't happen, but every time it goes from 0 to 1 it freezes) [08:12:58] <hachque> during the time it's frozen, the classic windows title bar also shows on the window [08:13:29] <hachque> i suspect whatever chrome is relying on that's misbehaving and causing it to lock up, .NET applications are also relying on and hence it's causing the issue there as well [08:14:00] <hachque> this issue happens on both the latest dev channel (v6) and on the stable release (i uninstalled and reinstalled stable in case it was a dev issue) [08:18:26] *** eseidel is now known as eseidel|scriptHe [08:18:30] *** eseidel|scriptHe is now known as eseidel|scripts5 [08:19:22] *** Yonn has joined #chromium [08:20:26] *** peterdn has quit IRC [08:22:07] *** peterdn has joined #chromium [08:28:47] *** loislo has joined #chromium [08:28:59] *** yuzo has joined #chromium [08:29:00] *** peterdn has quit IRC [08:29:20] *** shepazu has quit IRC [08:30:40] *** peterdn has joined #chromium [08:33:11] *** satorux has quit IRC [08:34:58] *** yuzo has quit IRC [08:36:15] *** peterdn has quit IRC [08:53:22] *** satorux has joined #chromium [09:00:04] *** GeekShadow has joined #chromium [09:05:19] <hachque> hmm [09:05:23] <hachque> i can clearly see in Process Monitor [09:05:35] <hachque> where Chrome has paused for 9 seconds [09:05:53] <hachque> between fetching the system certificates and the twitter extension doing something [09:06:19] <hachque> after that it pauses for another 15 seconds until it gets an exclusive lock on the Cookies file [09:08:45] <jochen__> good morning chromium [09:08:49] <jochen__> <- back in munich [09:09:02] <Caleb> cool [09:09:09] <Caleb> how was the trip back [09:09:56] <jochen__> they didn't have new movies since my flight to SFO. the guy next to me was disgusting. i couldn't sleep. the food was shit. my back hurts. i'm jet lagged. [09:10:01] <jochen__> does this answer your question? [09:10:24] <Caleb> sounded fun [09:10:25] <Caleb> haha [09:10:30] <Caleb> sorry it was crap [09:12:39] *** mseaborn has quit IRC [09:14:46] *** hachque has quit IRC [09:16:09] <jochen__> it was to be expected :/ [09:16:16] <jochen__> trans atlantic flights are never fun [09:17:55] *** Peter` has quit IRC [09:21:01] <pamg_> yusukes: Hello. Would your change have caused the unit test failures on Vista? [09:21:05] *** pamg_ is now known as pamg [09:24:38] *** Peter` has joined #chromium [09:25:41] *** tedoc2000 has joined #chromium [09:33:05] *** Beetny has joined #chromium [09:33:29] *** yuzo has joined #chromium [09:37:18] *** hbono has quit IRC [09:38:07] <Peter`> Is SXS available yet for stable/beta/dev builds? [09:38:30] *** kcliu_ has quit IRC [09:40:29] *** yuzo has quit IRC [09:44:45] *** tittiatcoke has joined #chromium [09:44:47] *** kcliu has joined #chromium [09:44:52] *** SandGorgon has joined #chromium [09:46:38] *** matthew_y has quit IRC [09:46:41] *** tedoc2000 has quit IRC [09:47:06] *** vitalyr has joined #chromium [09:49:41] <yusukes> pamg_: which one? [09:49:52] <yusukes> (sorry for the delay) [09:50:05] <pamg> yusukes: Never mind; it appears to have cleared on the next run. [09:50:25] <yusukes> oh i see. thanks. [09:51:54] <trungl_mbp> 'night, Chromium. [09:59:51] *** fbarchard has joined #chromium [10:01:10] *** satorux1 has joined #chromium [10:02:50] *** satorux has quit IRC [10:04:03] *** matthew_y has joined #chromium [10:04:04] *** dave_levin has quit IRC [10:14:18] *** trungl_mbp has quit IRC [10:18:17] *** satorux1 has quit IRC [10:18:43] *** xolubi has joined #chromium [10:19:58] <xolubi> is internal-flash enabled by default in chromium 6? [10:29:58] *** ROBOd has joined #chromium [10:30:21] *** RT|Chatzilla_ has joined #chromium [10:32:05] *** RT|Chatzilla has quit IRC [10:32:11] *** RT|Chatzilla_ is now known as RT|Chatzilla [10:33:17] *** satorux has joined #chromium [10:36:52] *** hbono has joined #chromium [10:39:35] *** Nobu has quit IRC [10:40:03] *** narsil has joined #chromium [10:44:22] *** yuzo has joined #chromium [10:49:08] *** MikeSmithW3C has quit IRC [10:53:31] *** yuzo has quit IRC [10:54:04] *** zaheer_ has joined #chromium [10:59:51] *** yuzo has joined #chromium [11:02:07] *** SandGorgon_ has joined #chromium [11:05:19] *** mseaborn has joined #chromium [11:06:01] *** SandGorgon has quit IRC [11:08:09] <hbono> again, valgrind bots started failing compile because of the lack of memory? [11:09:05] *** roc has joined #chromium [11:14:17] *** SandGorgon_ has quit IRC [11:16:04] <Peter`> Could navigation.register(Protocol|Content)Handler perhaps be placed behind a compile-time flag? Chromium and Chrome implement the methods, throw exceptions per the specification but don't show confirmation windows, or actually do anything with the method at all. That's pretty much killing feature-detection techniques [11:19:08] *** zloidemon has joined #chromium [11:32:24] *** jetienne has joined #chromium [11:32:27] *** tittiathome has joined #chromium [11:33:10] *** tittiatcoke has quit IRC [11:33:19] *** vitalyr has quit IRC [11:47:38] *** satorux has quit IRC [11:47:51] *** satorux has joined #chromium [11:50:50] <Peter`> Filed http://crbug.com/44984 following my last message :) [11:53:23] *** ROBOd_ has joined #chromium [11:56:50] *** ROBOd has quit IRC [11:58:26] *** aho has quit IRC [12:04:38] *** faitz has quit IRC [12:04:49] *** faitz has joined #chromium [12:10:16] *** eseidel|scripts5 has quit IRC [12:10:16] *** GeekShadow has quit IRC [12:12:38] *** wers has quit IRC [12:12:49] *** tittiathome is now known as tittiatcoke [12:16:13] *** abarth|entity5 has quit IRC [12:17:07] *** GeekShadow has joined #chromium [12:29:40] *** eseidel has joined #chromium [12:32:22] *** romainhuet has joined #chromium [12:35:01] *** capletonX has joined #chromium [12:37:10] *** Nobu has joined #chromium [12:37:24] <capletonX> Hi everyone. If someone is still up, I'd like to ask, are flash videos on websites playing sound alright? mine is cutting out after a few seconds. Also, could someone tell me how chromium handles flash playing? is there a module i can update like in firefox? [12:38:37] <Ke> afaik crome has bundled flash and chromium uses the same plugin as firefox [12:41:18] *** roc has quit IRC [12:47:55] *** SandGorgon_ has joined #chromium [12:53:51] *** eseidel has quit IRC [12:57:26] *** peterdn has joined #chromium [12:58:24] *** kinuko_ has quit IRC [12:58:31] *** kinuko_ has joined #chromium [12:58:58] <pamg> hbono: Do you know the problem with the Mac valgrind bots? The error implies out of memory during link. [12:59:36] <hbono> pamg: probably it's issue 43791. [13:00:03] <hbono> I'm copying mark's hack to ui_tests. [13:00:25] <pamg> Sounds right. Thanks for the fix. [13:00:50] <hbono> pamg: no problem. [13:01:37] *** janm has joined #chromium [13:05:12] <hbono> landed a copy-and-paste fix. I wish it fixes the bots. [13:07:07] *** gavin has quit IRC [13:14:21] *** gavin has joined #chromium [13:14:21] *** gavin has joined #chromium [13:16:42] <hbono> it seems mac valgrind bots are cycling green. :) [13:16:43] *** ROBOd__ has joined #chromium [13:19:39] *** roc has joined #chromium [13:20:10] *** ROBOd_ has quit IRC [13:20:39] *** zaheer_ has quit IRC [13:21:26] *** Kaosevil has joined #chromium [13:30:16] *** capletonX has quit IRC [13:44:24] *** thomasvl has joined #chromium [13:44:24] *** ChanServ sets mode: +v thomasvl [13:46:54] *** IRCMonkey has quit IRC [13:50:58] *** GeekShadow has quit IRC [13:53:37] *** SandGorgon_ has quit IRC [13:53:51] *** GeekShadow has joined #chromium [13:54:17] *** SandGorgon_ has joined #chromium [13:54:55] *** MikeSmithW3C has joined #chromium [14:00:04] *** hbono has quit IRC [14:02:22] *** SandGorgon has joined #chromium [14:02:25] *** SandGorgon_ has quit IRC [14:10:49] *** Beetny has quit IRC [14:12:14] *** zyichi has left #chromium [14:15:47] *** GeekShadow has quit IRC [14:26:02] *** magn3ts has joined #chromium [14:26:12] *** magn3ts has quit IRC [14:29:47] *** narsil has quit IRC [14:33:01] *** pinkerton has joined #chromium [14:33:01] *** ChanServ sets mode: +v pinkerton [14:36:38] *** General1337 has joined #chromium [14:40:45] *** General13372 has quit IRC [14:42:03] *** IRCMonkey has joined #chromium [14:44:04] *** Zaba has quit IRC [14:44:40] *** xolubi has quit IRC [14:47:34] *** romainhuet has quit IRC [14:49:41] *** Zaba has joined #chromium [14:52:37] *** thomasvl has quit IRC [14:54:36] *** _rs has joined #chromium [14:54:39] *** IRCMonkey is now known as tonikitoo [14:54:53] *** tittiatcoke has quit IRC [15:01:11] *** hagabaka has joined #chromium [15:01:11] *** hagabaka has joined #chromium [15:04:17] *** Chainfire has joined #chromium [15:08:16] *** holdenss has joined #chromium [15:08:19] <Chainfire> it seems in Chrome Browser, clock-skew plays a big role in caching. If both a Date and Expires header is present, the entry isn't cached for the difference between the two, but rather until (expires header converted to your time zone). Due to this, an incorrect clock setting either server- or client- side essentially prevents caching, and in general shortly caching (i.e. a couple of minutes) hardly ever works. [15:08:55] <Chainfire> from the RFC I understand that clock-skew should not be an issue. Other browsers do behave the same, though. Is there anyone here who understands why this is? [15:09:27] *** khamer has joined #chromium [15:10:55] *** kinnetica has joined #chromium [15:11:24] <khamer> I'm trying to find information on making links works in a popup from a browser action, but I'm not exactly sure what section of the docs I should be looking in [15:12:01] <maruel> Chainfire: search the bug tracker [15:12:13] <maruel> khamer: this channel is not about extensions, try the mailing list [15:15:07] <Chainfire> maruel> I didnt locate anything relavant to this. Are you sure there is something in there about this? This seems to work the "wrong" way consistently across all browsers, so I was wondering if perhaps my logic on this matter is flawed [15:16:48] <maruel> Chainfire: file a bug report then [15:17:16] *** glider has joined #chromium [15:19:24] *** mihaip has joined #chromium [15:20:39] *** miketaylr has joined #chromium [15:24:39] *** malavv has joined #chromium [15:31:31] *** dmaclach has joined #chromium [15:34:12] *** jetienne has quit IRC [15:35:54] *** dmaclach_ has joined #chromium [15:39:42] *** dmaclach has quit IRC [15:39:42] *** dmaclach_ is now known as dmaclach [15:39:47] *** ScriptRipper has quit IRC [15:40:23] *** zaspire has joined #chromium [15:43:10] <glider> hi all [15:43:45] <glider> landing tcmalloc r93 again, hope there'll be no regressions [15:44:00] *** rsesek has joined #chromium [15:44:00] *** ChanServ sets mode: +v rsesek [15:44:42] *** dmaclach has quit IRC [15:48:39] *** tittiatcoke has joined #chromium [15:48:40] *** tittiatcoke has quit IRC [15:48:41] *** tittiatcoke has joined #chromium [15:51:47] *** BCalvignac has joined #chromium [15:57:13] *** Ruetobas has quit IRC [15:57:55] *** mrossetti has joined #chromium [15:58:30] <malavv> Good morning everyone, is there something else than (plug-ins/extension/webkit page) that send http/https request? [15:58:49] <maruel> malavv: yes [15:58:58] <maruel> crash dumps, statistics [15:59:10] <maruel> cloud print [15:59:16] <maruel> bookmark sync [15:59:16] <malavv> by stats you mean metrics? [15:59:24] <maruel> yes [15:59:24] *** mrossetti_ has joined #chromium [15:59:26] *** zaheer_ has joined #chromium [15:59:29] *** mrossetti_ has quit IRC [15:59:38] <malavv> And that's situated in the browser process? [15:59:50] *** wjmaclean has joined #chromium [16:00:05] <malavv> thanks maruel [16:00:20] <maruel> not crash dumps, the rest yes [16:00:24] *** leeight has joined #chromium [16:00:28] *** leeight has left #chromium [16:01:56] *** Ruetobas has joined #chromium [16:01:58] *** GeekShadow has joined #chromium [16:02:14] *** mrossetti has quit IRC [16:03:46] *** zyichi has joined #chromium [16:06:06] *** Ruetobas has quit IRC [16:07:48] *** Ke has left #chromium [16:08:24] *** Ruetobas has joined #chromium [16:09:19] *** mrossetti has joined #chromium [16:13:31] *** tedoc2000 has joined #chromium [16:18:00] *** jparent_ has joined #chromium [16:20:24] *** thakis has quit IRC [16:23:18] *** stuartmorgan has joined #chromium [16:23:18] *** ChanServ sets mode: +v stuartmorgan [16:23:38] <maruel> I restarted the memory master, don't panic [16:25:34] *** smorg has joined #chromium [16:26:12] *** lukas___ has joined #chromium [16:34:15] *** rohitrao has joined #chromium [16:34:15] *** ChanServ sets mode: +v rohitrao [16:34:56] <rsesek> maruel: is the GClient class in chromium_commands.py the place where runhooks gets called for all the builders on the waterfall? [16:36:24] *** RT|Chatzilla has quit IRC [16:40:52] *** joelastpass has joined #chromium [16:41:33] *** Limbero is now known as Limbero|AFK [16:42:17] *** RT|Chatzilla has joined #chromium [16:43:01] *** thakis has joined #chromium [16:43:02] *** ChanServ sets mode: +v thakis [16:43:19] *** glider has quit IRC [16:45:37] *** SandGorgon has quit IRC [16:45:44] <joelastpass> Chrome 6 appears to break chrome.tabs.create chrome.windows.getAll and a whole lot more from extensions -- is this known? [16:46:13] <maruel> rsesek: it's called from inside gclient.py [16:46:15] <maruel> automatically [16:46:23] <maruel> the manually call is specifically for the try server [16:46:54] *** WePac has joined #chromium [16:48:07] *** dmaclach has joined #chromium [16:48:30] *** dmaclach_ has joined #chromium [16:48:31] *** dmaclach has quit IRC [16:48:31] *** dmaclach_ is now known as dmaclach [16:48:34] <rsesek> maruel: gclient_factory.py? there's no gclient.py in //trunk/buildbot [16:48:35] <stuartmorgan> joelastpass: check http://crbug.com and if it's not there file a new bug [16:48:47] *** blime has joined #chromium [16:48:55] <maruel> rsesek: depot_tools/gclient.py [16:49:48] <rsesek> maruel: who calls that on the buildbot? I'm looking to set an env variable for the buildbot (CHROMIUM_GYP_SYNTAX_CHECK) [16:50:13] <maruel> rsesek: it's automatic [16:50:20] <maruel> the same way it works on your checkout [16:50:38] *** dmaclach has quit IRC [16:50:50] *** glider has joined #chromium [16:50:51] <rsesek> maruel: okay. but what calls 'gclient sync' then? [16:51:09] <maruel> chromium_commands.py indeed [16:51:17] <rsesek> thanks [16:53:28] <thakis> tony^work (and others): i saw this http://pastebin.com/EveZbCrY go by on #chromium-support. is that interesting? [16:57:27] *** Yonn has quit IRC [16:59:42] *** trungl_mbp has joined #chromium [17:06:02] *** ScriptRipper has joined #chromium [17:09:23] <joelastpass> stuartmorgan: http://code.google.com/p/chromium/issues/detail?id=44993 pretty bad bug in my opinion [17:11:46] <rohitrao> if you've got a few minutes to make a reduced test case, I'm sure they'd love to have one :) [17:13:09] <pamg> maruel: Any reason I shouldn't start kicking memory bots? [17:13:28] *** glider has quit IRC [17:14:34] <pamg> Oh, I see they're going on the waterfall. [17:14:58] <maruel> pamg: yep, I restarted it [17:15:29] <pamg> maruel: Right, but that killed 10 or more builds, which I was going to restart. [17:15:51] <maruel> pamg: I was just waiting for a commit [17:15:55] <maruel> you can force them if you want [17:16:44] * pamg shrugs [17:17:33] <maruel> eh [17:18:06] *** jrmuizel has joined #chromium [17:19:34] *** glider has joined #chromium [17:23:54] *** jschuh has quit IRC [17:25:45] *** thomasvl has joined #chromium [17:25:46] *** ChanServ sets mode: +v thomasvl [17:29:00] *** tonyg-cr has joined #chromium [17:29:01] *** ChanServ sets mode: +v tonyg-cr [17:29:52] *** trungl_mbp has quit IRC [17:30:48] <tonyg-cr> There's a new sheriff in town. [17:31:43] *** jschuh has joined #chromium [17:35:36] *** robarnold has quit IRC [17:36:42] <pinkerton> willchan: ping? [17:38:13] *** Nobu has left #chromium [17:39:43] <tonyg-cr> pamg: ping? [17:39:56] <pamg> tonyg-cr: Pong [17:40:23] *** Venom_X has joined #chromium [17:40:31] <tonyg-cr> The status says you are looking into the browser tests failure... [17:40:48] <tonyg-cr> Do you know the culprit [17:40:49] <pamg> tonyg-cr: Yes, I have a disabling patch in the trybots now. [17:41:06] <pamg> tonyg-cr: Well, not exactly, but it's not a new failure. A day or so anyway. [17:41:35] *** holdenss has quit IRC [17:42:04] <pamg> I sent you the review. [17:42:14] <tonyg-cr> *looks* [17:42:39] *** jschuh has quit IRC [17:43:00] *** AaronMT has joined #chromium [17:43:16] *** wr| has quit IRC [17:44:07] <pamg> tonyg-cr: I also emailed Nik, who added the TaskManagerBrowserTest tests. [17:44:16] *** wr| has joined #chromium [17:45:56] *** lukas___ has quit IRC [17:48:42] *** thakis has quit IRC [17:49:22] *** Greboid has quit IRC [17:49:52] *** loislo has quit IRC [17:49:59] *** Greboid has joined #chromium [17:50:10] *** trungl_away is now known as trungl [17:50:18] <trungl> 'morning, Chromium. [17:50:29] <rsesek> morning, trungl [17:51:56] *** narsil has joined #chromium [17:52:28] <tonikitoo> tonyg-cr, morning. [17:52:29] *** ryaxnbubuntu has joined #chromium [17:52:32] <tonikitoo> tonyg-cr I checked in a change that might affect Chromium tests suite ... [17:52:36] <tonikitoo> please let me know if it breaks stuff on your side. [17:52:40] *** cirwin has joined #chromium [17:52:45] <tonyg-cr> Thanks for the heads-up [17:52:46] <tonikitoo> tonyg-cr, it is r60165 [17:52:49] <tonikitoo> ps: I am poking you because you said you are the sheriff :) [17:53:02] *** zyichi has left #chromium [17:53:08] * tonikitoo would be glad to help if stuff break [17:53:14] <cirwin> my profile just corrupted itself, how do I make it "uncorrupt" again? (and ideally get my search engines back again) [17:53:44] *** jparent_ has quit IRC [17:54:10] *** js2 has joined #chromium [17:54:57] *** bent-mozilla has joined #chromium [17:55:11] *** RT|Chatzilla has quit IRC [17:55:28] *** dmaclach has joined #chromium [18:00:33] <thakis_afk> morning, chromium [18:00:41] *** thakis_afk is now known as thakis [18:00:53] <rsesek> morning, thakis [18:00:59] <malavv> morning thakis [18:02:48] *** GeekShadow has quit IRC [18:02:52] * thakis rants about linkers, global namespaces, the nacl plugin, and internal plugins [18:04:34] <stuartmorgan> thakis: do you know why the plugin is linked in? [18:04:37] *** markmentovai has joined #chromium [18:04:37] *** ChanServ sets mode: +v markmentovai [18:04:55] <pinkerton> we're live: http://chrome.blogspot.com/ [18:05:31] <thakis> stuartmorgan: no. potential reasons might be crash reporting, smaller on-disk size [18:05:49] <stuartmorgan> thakis: we get crashes from the plugin process [18:05:51] <thakis> stuartmorgan: and maaybe it does some communication that doesn't work with npapi [18:05:58] *** ryaxnbubuntu has quit IRC [18:06:09] <thakis> stuartmorgan: it appears that it used to be a normal plugin long ago [18:06:35] <stuartmorgan> thakis: ah... so "hysterical raisins", as awalker would say [18:06:54] <thakis> stuartmorgan: if you think it's useful, i can sift through `git blame`, old changelogs etc to try and find out why it became internal [18:07:03] *** robarnold has joined #chromium [18:07:09] <thakis> pinkerton: huzza! [18:07:14] <stuartmorgan> thakis: just seems so weird, and if it's causing problems I was wondering if we could just not do that [18:07:52] <thakis> stuartmorgan: the real problem is the nacl plugin, which is internal too and which puts symbols like NPP_GetValue etc into the global namespace [18:08:06] <thakis> the internal o3d plugin otoh is pretty well-behaved in that regard [18:08:07] *** dglazkov has joined #chromium [18:08:07] *** ChanServ sets mode: +v dglazkov [18:08:15] <dglazkov> good morning, Chromium! [18:08:33] <thakis> morning, dglazkov! [18:08:38] <stuartmorgan> thakis: Yeah, that does seem bad. Although, aren't we going to have collisions with the entry point and init functions no matter what? [18:09:08] <stuartmorgan> thakis: seems like the way NPAPI is designed, it wouldn't be possible to have two internal plugins (at least on the Mac, and probably Linux) [18:09:10] <thakis> stuartmorgan: no, other internal plugins only define their NPP_ functions in a namespace [18:09:20] <stuartmorgan> Oh, I see [18:09:30] <stuartmorgan> So it's semi-NPAPI [18:09:34] <thakis> stuartmorgan: internal plugins don't use the plugin loading mechanism, they list three (or two on linux) funciton pointers instead [18:09:35] <thakis> yeah [18:10:05] <stuartmorgan> This sounds great. All the ease-of-use of NPAPI, with the decoupling of direct linkage! [18:10:09] <stuartmorgan> What could be better? [18:10:35] <thakis> :-) [18:10:45] <tonyg-cr> pamg: It looks like reliability is failing due to the WebKit roll in r48123 -- if you agree I'm going to open a bug and add it to known crashes [18:10:55] *** paul_irish_ has joined #chromium [18:10:57] <thakis> it makes it very easy to convert a real plugin into an internal plugin at least [18:11:09] *** paul_irish_ has quit IRC [18:11:12] <thakis> not sure what the advantage of this is. trungl or jam2 might know [18:11:29] <pamg> tonyg-cr: Sounds good. [18:11:42] * trungl denies knowing anything whatsoever. [18:11:49] <trungl> too much responsibility [18:13:28] *** paul_irish has quit IRC [18:13:43] *** ryaxnbubuntu has joined #chromium [18:14:30] <thakis> trungl: are you certain that's your answer? [18:14:44] <trungl> thakis: nope [18:14:53] *** janm has quit IRC [18:14:53] <trungl> thakis: what's the advantage of what? [18:14:58] <thakis> of internal plugins [18:15:31] <trungl> which examples do you have in mind? [18:15:54] <thakis> default plugin, nacl, o3d [18:16:38] <trungl> easy access to all the chrome code? [18:17:06] <trungl> access to non-npapi stuff? [18:18:12] <pamg> tonyg-cr: I hand off the sheriff torch to you (and Raf when he gets in). [18:18:31] <tonyg-cr> Have a good night, hopefully we'll leave you with a green tree for the morning :) [18:19:47] *** mseaborn has quit IRC [18:20:24] <trungl> ah, sputnik, I see you're still in fast [18:20:42] <trungl> at least subversion isn't *horrendously* slow on Mac [18:21:49] *** janm has joined #chromium [18:21:59] *** narsil has quit IRC [18:23:18] <trungl> hmmm, sleeping 15 seconds and then retrying probably isn't the proper response to "an unversioned directory of the same name already exists" [18:24:00] *** Bleak has joined #chromium [18:25:55] *** GeekShadow has joined #chromium [18:28:09] *** fqian has joined #chromium [18:28:28] *** thomasvl has quit IRC [18:29:31] *** thomasvl has joined #chromium [18:29:31] *** ChanServ sets mode: +v thomasvl [18:29:40] <maruel> trungl: oh yes it is [18:29:50] <maruel> because you may have time to remove it :) [18:29:56] <rsesek> ha [18:30:52] *** Zucca has joined #chromium [18:31:37] <trungl> maruel: I apparently wasn't that smart [18:31:55] *** zloidemon has quit IRC [18:36:21] <jparent> pamg, tonyg-cr: howdy sheriffs. Webkit Builder just failed (timeout) after my webkit roll. Debug passed, and it has passed on the try servers and canaries, so i'm suspricious this is a real issue. [18:36:46] <jparent> There is a build that should be done really soon right after it, i'd like to see if that succeeds before reverting [18:39:45] <jparent> pamg, tonyg-cr: yup, it went green on the next build [18:39:50] <jparent> i'll re-open [18:40:13] *** johnny_g has joined #chromium [18:40:42] *** Venom_X_ has joined #chromium [18:41:12] *** dev2 has joined #chromium [18:42:07] <tonyg-cr> jparent: thanks :) [18:42:36] <tonyg-cr> btw - would you mind looking at a change to known_crashes, it looks like a roll last night introduced them [18:43:53] *** Venom_X has quit IRC [18:44:55] <tonyg-cr> I believe this should take care of reliability tests: http://codereview.chromium.org/2083025 [18:44:58] <jparent> tonyg-cr: I'll try to take a look. I'm gardening on my own today so not sure how much downtime I'll have. [18:45:04] *** Venom_X_ has quit IRC [18:46:01] <nshkrob_> pamg: Hi, I'm looking into those leaks now [18:46:07] *** Venom_X has joined #chromium [18:50:00] *** mirandac_ has joined #chromium [18:50:51] *** loislo has joined #chromium [18:51:23] <mnissler> nshkrob_: pam is already gone. [18:51:39] <rsesek> maruel: I'm about to submit that CL; I'd like to be around for the next master restart to take care of any fallout. when do you think that would happen? [18:51:53] <maruel> rsesek: early tomorrow morning [18:52:10] <rsesek> maruel: like 8 ET? [18:52:18] <maruel> yep [18:52:22] <rsesek> okay sounds good [18:52:41] <rsesek> I don't think there should be any fallout; I've ran the gyp checker manually, but just in case... [18:54:28] *** loislo_ has joined #chromium [18:56:24] *** WePac has quit IRC [18:56:47] *** khamer has quit IRC [18:57:11] *** loislo has quit IRC [18:57:12] *** loislo_ is now known as loislo [19:00:01] *** WePac has joined #chromium [19:00:56] *** gavin has quit IRC [19:01:20] *** gavin has joined #chromium [19:01:20] *** gavin has joined #chromium [19:02:37] <rohitrao> stuartmorgan: I don't understand any of the responses to this new window bug [19:03:18] <rohitrao> either i'm reading it wrong, or this guy is suggesting we change to do what we're already doing now [19:03:21] <thakis> rohitrao: http://i.imgur.com/ynVss.jpg [19:03:22] <jparent> tonyg-cr: is there a bug filed for the reliabiity crasher? [19:03:47] <tonyg-cr> http://code.google.com/p/chromium/issues/detail?id=45004 [19:04:04] <rohitrao> thakis: I need a bigger version to set as my background [19:04:11] *** glider has quit IRC [19:04:22] *** nshkrob_ has left #chromium [19:04:31] *** gavin has quit IRC [19:04:33] *** nshkrob_ has joined #chromium [19:04:35] <thakis> rohitrao: add borders with the bg color and leave the text in the bottom right corner [19:04:38] <jparent> tonyg-cr: yup, you came to the same conclusion I did about the cause [19:04:50] <stuartmorgan> rohitrao: you are reading it wrong [19:05:01] <rohitrao> stuartmorgan: ok, good [19:05:21] <rohitrao> I think we should just pick something and do it and see if people still complain [19:05:25] <stuartmorgan> rohitrao: he wants the 0->1-while-running transition to open the home page [19:05:30] <rohitrao> otherwise we'll argue about it forever [19:05:43] <rohitrao> ah, always open the homepage, regardless of what the startup pref says? [19:05:50] <stuartmorgan> rohitrao: no [19:06:38] <stuartmorgan> rohitrao: people want clicking the dock icon while it's running to act like startup [19:06:51] <trungl> "people" [19:06:57] <thakis> what's wrong with people [19:06:57] *** gavin has joined #chromium [19:07:05] <trungl> everything [19:07:06] <stuartmorgan> This is basically a proxy for having a pref to control what is opened in any new window [19:07:14] <stuartmorgan> But for people who only use one window [19:07:28] <stuartmorgan> Because they don't use more than one window, they think this case is special [19:07:36] <tonyg-cr> nshkrob_: ping [19:07:48] <trungl> I'm glad I don't know about this new window bug [19:07:50] <nshkrob_> tonyg-cr: pong [19:07:51] <trungl> ignorance is bliss [19:08:05] <tonyg-cr> Did pamg ask you about r48061? [19:08:17] <nshkrob_> yes [19:08:26] <nshkrob_> I'm looking into the leaks [19:08:39] *** mirandac_ has quit IRC [19:08:50] <trungl> uhm, sheriffs: landing .grd change [19:08:57] <trungl> some redness may result [19:08:59] <rohitrao> stop changing grd files [19:08:59] <trungl> not sure about it [19:09:13] <trungl> grd files should be append-only [19:09:21] <trungl> that would be awesome [19:09:37] <tonyg-cr> trungl: thanks for the heads-up [19:09:50] <trungl> np [19:10:01] <nshkrob_> tonyg-cr: which tests are breaking because of this? linux browser_tests? [19:10:26] <thakis> since everyone expects problems when grd changes are landed, you can probably delete a grd file and get away with it for half a day [19:10:32] *** zloidemon has joined #chromium [19:10:53] *** cying has joined #chromium [19:11:13] <nshkrob_> tonyg-cr: also, how do I run the memory tests to verify the fix? [19:13:33] <tonyg-cr> I was more worried about Vista unit_tests: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/19222 [19:13:43] *** csilv has joined #chromium [19:13:43] <tonyg-cr> Could your change have caused that? [19:14:16] *** bweinstein has joined #chromium [19:14:38] *** mirandac_ has joined #chromium [19:14:52] <nshkrob_> those failures continued after my CL was reverted yesterday [19:15:08] <tonyg-cr> okay, I'll dig back further [19:15:08] <nshkrob_> the Persist* ones [19:22:56] *** gavin has quit IRC [19:23:01] *** andybons has joined #chromium [19:23:25] *** gavin has joined #chromium [19:23:25] *** gavin has joined #chromium [19:23:59] *** rohan has joined #chromium [19:24:25] *** gavin has quit IRC [19:25:27] *** gavin has joined #chromium [19:25:27] *** gavin has joined #chromium [19:25:51] *** inferno-sec has quit IRC [19:26:04] <rohan> i have question about today's stable release for linux - does it include flash player and put it behind a flag, or not include at all? and if no, will the stable release be updated to include it when flash 10.1 is released? [19:29:36] <stuartmorgan> trungl: ^^^ is there a flag? [19:29:45] <rohan> btw this page -- http://www.chromium.org/getting-involved/dev-channel -- needs to be updated with link to new google chrome linux beta channel. [19:30:31] <trungl> rohan: it's behind a flag -- you can use --enable-internal-flash if you want it [19:30:43] <rohan> thank you trungl [19:30:45] <trungl> rohan: and we will update the stable channel [19:30:58] <trungl> rohan: (on 32-bit Linux, of course) [19:31:15] <rohan> flash 10.1 won't have a stable 64-bit linux release? [19:31:50] *** thomasvl has quit IRC [19:35:06] <stuartmorgan> rohan: thanks, I'll look into getting the dev channel page updated [19:35:30] *** thomasvl has joined #chromium [19:35:30] *** ChanServ sets mode: +v thomasvl [19:36:23] <mbelshe> hello [19:37:35] *** ryaxnbubuntu has quit IRC [19:39:05] <thakis> trungl: i thought one's supposed to use about:plugins instead? or is that dev-channel only? [19:39:21] *** eseidel has joined #chromium [19:41:53] *** rafaelw has joined #chromium [19:42:08] *** gavin has quit IRC [19:42:26] *** gavin has joined #chromium [19:42:26] *** gavin has joined #chromium [19:42:48] <stuartmorgan> thakis: IIRC from when it used to be behind the flag, the plugin isn't even loaded if the enable flag isn't set [19:42:57] <stuartmorgan> thakis: in which case about:plugins isn't much use [19:43:32] <thakis> i thought i saw a cl go by where jam2 replaced the flag with the about:plugins mechanism for flag, but i'm not sure [19:44:17] *** trungl_mbp has joined #chromium [19:44:34] *** gavin has quit IRC [19:45:58] <stuartmorgan> thakis: wrong internal plugin (and wrong branch) I think [19:46:46] *** solsTiCe has joined #chromium [19:47:07] <solsTiCe> hi. http://vimcolorschemetest.googlecode.com/svn/html/index-c.html is not coreclty rendered here. half of the color scheme are shown [19:47:26] *** gavin has joined #chromium [19:47:27] <thakis> http://codereview.chromium.org/2080016 correct internal plugin at least [19:47:40] <maruel> rsesek: you checked in? That broke the try server [19:47:41] *** Venom_X_ has joined #chromium [19:48:02] <rsesek> maruel: oops [19:48:06] <rsesek> maruel: you have a link/ [19:48:07] <thakis> uh, no [19:48:17] <maruel> http://build.chromium.org/buildbot/try-server/builders/win/builds/32983/steps/gclient/logs/stdio [19:48:39] *** solsTiCe has left #chromium [19:48:40] <rafaelw> tree is now closed. [19:48:50] <rsesek> maruel: that's actually legit failure (what the syntax checker is supposed to catch) [19:49:15] <rsesek> maruel: now it may have already existed, which if so, I can take a look at the file and submit a fix [19:49:45] <rsesek> maruel: actually I already fixed that one; maybe LKGR hasn't caught up? [19:49:53] <maruel> rsesek: probably [19:50:08] <rsesek> maruel: yea I fixed it at r48155 [19:50:34] *** gavin has quit IRC [19:50:38] *** Venom_X has quit IRC [19:50:39] *** Venom_X_ is now known as Venom_X [19:50:52] *** gavin has joined #chromium [19:50:52] *** gavin has joined #chromium [19:51:01] <maruel> fun [19:51:18] <rsesek> the good news is that it doing what it's supposed to :) [19:51:25] <rsesek> I'll send mail to cr-dev about these new types of failures [19:51:54] <maruel> stuartmorgan: ^^^^ [19:52:45] <stuartmorgan> maruel: thanks [19:53:10] *** masterov has joined #chromium [19:53:26] <willchan> um, did we change the throbber color? [19:53:36] <willchan> i'm getting a black throbber on my ToT linux chromium [19:54:21] *** Akiraa has joined #chromium [19:54:46] *** MikeSmithW3C^ has joined #chromium [19:55:10] *** ss has quit IRC [19:55:11] *** ss has joined #chromium [19:56:42] *** cdegough has joined #chromium [19:57:44] *** ryaxnbubuntu has joined #chromium [19:57:45] *** matthew_y has quit IRC [19:58:20] *** tonyg-cr has quit IRC [19:58:32] <Akiraa> What do Googly people use to get Chrome working on dual monitors with Windows? There are some utilities that extend the Windows taskbar to both monitors and also add extra buttons to the title window (next to maximize/minimize). I tried Ultramon and Multimon, but due to the custom UI of Chrome, these programs don't add the extra titlebar buttons (like: 'switch to left/right' or 'maximize to both screens'). The issue is the custom Chrome UI, so is there a [19:58:33] <Akiraa> Chrome build with a standard Windows UI titlebar? Using Windows 7 with Aero and most Windows effects turned off. [19:58:54] *** MikeSmithW3C has quit IRC [19:59:11] *** Chainfire has quit IRC [19:59:59] <malavv> Someone knows, what does the "off_the_record" switch in RessourceMessageFilter means<? [20:00:10] *** trungl_mbp has quit IRC [20:00:13] <rsesek> malavv: otr = incognito [20:00:15] <willchan> malavv: incognito [20:00:24] <malavv> Thanks [20:00:29] *** trungl_mbp has joined #chromium [20:00:32] <maruel> Akiraa: see topic [20:00:44] <ojan> rafaelw, pamg, chase: i think the page_cycler_moz failure is just the perf expectations being wrong. [20:01:02] <ojan> looking at the result page, i don't see a regression. the expected variance just isn't large enough. [20:01:28] <maruel> rsesek: I would have prefered you to wait for lkgr to update, I didn't know you committed fixes at the same time [20:01:40] <maruel> rsesek: a lot of people a left wondering what's happening [20:01:46] <rafaelw> ojan: can you sort it out. [20:01:49] <rsesek> maruel: sorry. I didn't realize lkgr hadn't updated (I waited until most of the bots cycled) [20:01:55] <rafaelw> i'm trying to sort out the unit_test failure right now. [20:02:03] <rsesek> and I also didn't expect the try server to pick up the change [20:02:12] <rsesek> I thought it would have required a restart [20:02:15] <maruel> rsesek: it was in the slave/ side [20:02:19] <rsesek> ah I see [20:02:30] <rsesek> sorry :| [20:05:12] *** GeorgeY has joined #chromium [20:05:12] *** dave_levin has joined #chromium [20:05:17] <ojan> rafaelw: sorry, i can't right now. just letting you know that that one will probably go away in a subsequent run and that it'll be green once someone fixes the variance. [20:05:28] *** Limbero|AFK is now known as Limbero [20:05:47] *** iamben has joined #chromium [20:09:39] <trungl> thakis: the flag controls the "existence" of the bundled flash; having it disabled via about:plugins is hairier (since we'd need to make sure that it gets re-enabled by default once it ships), though that's been done for other things [20:10:33] <willchan> rsesek: oh, you're the one who enabled the AST error thing! [20:10:42] <rsesek> willchan: yes. all my fault [20:10:46] <willchan> rsesek: i sent a cl to a layout try bot and got that error [20:10:53] <willchan> and i didn't change the gyp files [20:11:05] <rsesek> willchan: yea I fail for not waiting enough time for lkgr to update [20:11:21] <rsesek> willchan: I fixed that error a few revs ago but lkgr hasn't pushed past it yet [20:11:32] <willchan> rsesek: i see. lkgr-- is slow. [20:11:44] <rsesek> willchan: I think lkgr is being stuck by the failing tests [20:11:46] <willchan> ok, so if i try again in the future, it should start working? [20:12:08] <rsesek> willchan: yes. if you sync and run ./build/gyp_chromium ?check you will not get errors as of now [20:12:18] <rsesek> as of rhttp://src.chromium.org/viewvc/chrome?view=rev&revision=48155 to be specific [20:13:03] *** mpcomplete has joined #chromium [20:13:03] *** ChanServ sets mode: +v mpcomplete [20:13:13] *** rohan has quit IRC [20:16:12] *** cdegough has left #chromium [20:17:03] *** rickspencer3 has quit IRC [20:17:04] *** rickspencer3_ has joined #chromium [20:17:11] *** paul_irish has joined #chromium [20:17:29] *** gavin has quit IRC [20:17:47] *** rickspencer3_ is now known as rickspencer3 [20:21:03] *** mseaborn has joined #chromium [20:22:23] *** roc has quit IRC [20:22:44] *** roc has joined #chromium [20:23:44] <rsesek> willchan, maruel: tryserver should be fixed; lkgr should be fixed. lkgr just hit 48157. sorry for the trouble [20:26:01] *** cying_ has joined #chromium [20:26:04] *** AaronMT has quit IRC [20:26:25] *** AaronMT has joined #chromium [20:26:38] <willchan> blargh, layout try bots are still timing out for me on syncing. [20:27:32] *** iamben has left #chromium [20:27:40] *** mirandac_ has quit IRC [20:28:44] *** sswigart has joined #chromium [20:28:53] *** cying has quit IRC [20:28:54] *** cying_ is now known as cying [20:31:16] <jhawkins> rafaelw: ping [20:32:41] *** AaronMT has quit IRC [20:32:45] *** bent-mozilla has quit IRC [20:32:59] *** AaronMT has joined #chromium [20:33:03] *** bent-mozilla has joined #chromium [20:34:44] *** vadhor has joined #chromium [20:35:11] <fta> how come http://omahaproxy.appspot.com/ doesn't reflect the new linux/mac stable? [20:36:20] *** roc has quit IRC [20:36:24] <pinkerton> willchan: ping? [20:36:49] *** roc has joined #chromium [20:37:31] <willchan> pinkerton: pong [20:37:46] <pinkerton> willchan: hey, just curious what came out of the socks proxy limit discussion [20:37:47] *** AaronMT has quit IRC [20:37:53] <pinkerton> willchan: should i file a bug? [20:37:58] <willchan> pinkerton: i filed one [20:38:01] <willchan> lemme link you [20:38:03] <pinkerton> ooh :) [20:38:20] <pinkerton> willchan: i'm about to compile my own version and run that instead, does the bug have the line where the constant lives? [20:38:33] <willchan> pinkerton: no, i'll send that to you [20:38:43] <pinkerton> thank you for both :) [20:39:31] <rsesek> fta: maybe they're not pushing it out as an autoupdate yet? [20:39:34] <willchan> pinkerton: http://code.google.com/p/chromium/issues/detail?id=44501 [20:40:39] <willchan> pinkerton: net/http/http_network_session.cc:31 [20:40:48] <willchan> g_max_sockets_per_proxy_server [20:40:57] <pinkerton> thx [20:41:29] *** jrforbes_ has joined #chromium [20:41:35] * pinkerton syncs [20:41:58] *** bent-mozilla has quit IRC [20:42:00] *** AaronMT has joined #chromium [20:42:15] *** bent-mozilla has joined #chromium [20:42:39] <willchan> pinkerton: i'll send out a change now to increase the limit for now (until we implement a final solution), so that you don't have to maintain your own patched chromium. [20:42:54] <pinkerton> ok :) [20:45:12] <rafaelw> opening tree. [20:45:16] *** robarnold has quit IRC [20:45:35] *** robarnold has joined #chromium [20:49:45] *** gavin has joined #chromium [20:49:46] *** gavin has joined #chromium [20:50:53] *** BCalvignac has quit IRC [20:51:33] *** vesa has joined #chromium [20:51:44] *** vesa has left #chromium [20:52:32] *** BCalvignac has joined #chromium [20:53:04] <willchan> eglaysher,estade: did someone change something in theming or something else with the UI color scheme? i have this really ugly black for some icons (doc, wrench, star, throbber, etc)? [20:53:07] *** tonyg-cr has joined #chromium [20:53:07] *** ChanServ sets mode: +v tonyg-cr [20:53:25] *** BCalvignac has left #chromium [20:53:27] *** roc has quit IRC [20:53:58] *** roc has joined #chromium [20:54:08] *** vadhor has left #chromium [20:57:31] *** markmentovai_ has joined #chromium [20:57:31] *** ChanServ sets mode: +v markmentovai_ [21:00:15] *** WePac has quit IRC [21:00:51] *** markmentovai has quit IRC [21:00:51] *** markmentovai_ is now known as markmentovai [21:00:52] *** peterdn_ has joined #chromium [21:02:14] *** peterdn has quit IRC [21:06:35] *** jamesr has joined #chromium [21:06:58] *** WePac has joined #chromium [21:07:38] <tonyg-cr> jhawkins: ping [21:09:25] <tonyg-cr> jhawkins: r48104 re-enabled RestoreOnNewWindowWithNoTabbedBrowsers, but it is still failing on linux views dbg [21:09:40] <tonyg-cr> I'm going to drover it unless you tell me otherwise [21:11:59] <jhawkins> tonyg-cr: here [21:12:15] <jhawkins> tonyg-cr: if it fails, then we just need to mark it as FAILS_ [21:12:21] <jhawkins> no need to make it disabled again [21:12:54] <jhawkins> ftr, it's dmuir's CL. I just landed it for him [21:13:14] <tonyg-cr> Okay, I'll mark it fails and reopen the bug [21:14:55] *** spot has joined #chromium [21:15:05] <spot> kbr_google: good news! [21:15:33] <spot> kbr_google: i figured out what was causing that glXChooseFBConfig failed error [21:16:07] <spot> kbr_google: bad news, fixing it doesn't get working webgl for me [21:16:50] *** shepazu has joined #chromium [21:17:23] *** janm has quit IRC [21:17:35] *** shepazutoo has joined #chromium [21:18:54] <willchan> jamesr: profiling question for you [21:19:18] <jamesr> willchan: profiling is illegal! [21:19:26] *** janm has joined #chromium [21:19:28] <spot> kbr_google: is there a set of webgl tests I should be using? [21:19:32] <willchan> haha [21:19:48] <jamesr> whatup? [21:20:06] <willchan> jamesr: would you rather not have to rebuild with frame pointers enabled (but have a potential to deadlock on signal handling) to profile, or just rebuild with frame pointers? [21:20:47] <jamesr> willchan: i've always rebuilt with frame pointers and been pretty OK with that [21:20:59] *** shepazu has quit IRC [21:21:12] <jamesr> is this about libunwind? [21:21:16] <willchan> jamesr: ok [21:21:23] <willchan> yeah, i'm evaluating the tradeoff [21:21:45] <willchan> one prob is that for perf sensitive code, the register pressure of losing the frame pointer might skew the profile [21:21:48] <jamesr> FPs are slightly irritating [21:21:49] <jamesr> yeah [21:21:54] <jamesr> changes the disasm too [21:21:57] <willchan> yep [21:22:19] <jamesr> also i think in cases where i'm trying to make an inline/don't inline decision the FPs make it hard [21:22:19] <willchan> but libunwind deadlocks (it's not async signal safe, so it can re-enter malloc, which breaks if we're in a signal handler) [21:22:28] <jamesr> since they inflate the preamble/postamble [21:22:31] <jamesr> can libunwind be fixed? [21:22:40] *** AaronMT has quit IRC [21:22:56] <willchan> jamesr: not really [21:23:00] <willchan> unless we can hack libc [21:23:08] <willchan> or rewrite lots of code [21:23:10] <willchan> not worth it [21:23:13] <willchan> gotta run to lunch [21:23:16] <jamesr> the google-perftools profiling uses signals to tick so wouldn't it be pretty likely to hit this? [21:26:24] <jhawkins> tonyg-cr: you said the test is only failing on linux views? [21:26:39] <tonyg-cr> Yes [21:26:51] <jhawkins> jhawkins: then it should only be marked as fails for that platform [21:26:53] <tonyg-cr> I could leave it enabled for mac [21:27:21] <jhawkins> tonyg-cr: and linux gtk [21:28:39] <tonyg-cr> #if defined(OS_LINUX) && defined(TOOLKIT_VIEWS) ? [21:29:07] <jhawkins> tonyg-cr: yea that works [21:34:16] *** loislo has quit IRC [21:41:36] *** Beetny has joined #chromium [21:43:29] *** shepazutoo has quit IRC [21:43:35] <jhawkins> anyone having trouble uploading to codereview? 500 internal error [21:45:43] <thakis> estade, other gtk guys: if i want to draw text, do i just use pango, or lowlevel cairo stuff, or something else alltogether? [21:45:54] * thakis goes to chrome/browser/gtk [21:47:32] <estade> willchan: yea, erg changed the icon color selection [21:47:54] <estade> thakis: we use skia [21:48:20] <thakis> estade: for everything? [21:48:28] <thakis> (i've seen some cairo stuff in c/b/gtk) [21:48:35] <estade> no, but for text if we are free-hand drawing it [21:48:49] <thakis> ok [21:48:56] <estade> all text in chrome's chrome is a gtk widget or skia [21:49:30] *** __rs has joined #chromium [21:49:35] <tonyg-cr> jhawkins: Yes, I'm getting 500s from codereview.chromium.org [21:50:13] *** _rs has quit IRC [21:50:36] *** ryaxnbubuntu has quit IRC [21:50:50] *** BCalvignac1 has joined #chromium [21:52:46] <willchan> jamesr: hmmmm, good point. i need to think about that. i ran with libunwind and it never deadlocked on me, but it did deadlock the bots which use SIGTERM/etc. to shutdown processes. [21:52:48] *** tittiatcoke has quit IRC [21:53:08] <willchan> estade: er, is it supposed to be black? [21:53:26] *** sbyer has quit IRC [21:53:31] *** markmentovai has quit IRC [21:53:38] *** markmentovai has joined #chromium [21:53:38] *** ChanServ sets mode: +v markmentovai [21:53:46] *** eseidel has quit IRC [21:53:59] *** cirwin has left #chromium [21:54:36] <estade> willchan: I think it changed from selection color to label color [21:54:58] *** Venom_X_ has joined #chromium [21:55:05] <estade> so it depends on your theme, but I guess it is supposed to be black sometimes [21:57:15] <willchan> estade: i see. ok. i think it looks horrendous on my theme, but maybe i should change themes. actually, i thought i was on classic, but apparently i'm on some gtk+ theme. [21:58:20] *** BCalvignac has joined #chromium [21:58:50] *** Venom_X has quit IRC [21:58:51] *** Venom_X_ is now known as Venom_X [21:59:14] <estade> willchan: let erg know about it. I'm sure he'd be interested in trying to fix it. [21:59:38] <willchan> eglaysher: ^^^ [22:00:06] *** BCalvignac1 has quit IRC [22:00:17] *** ROBOd__ is now known as ROBOd [22:00:59] *** __rs has quit IRC [22:02:39] *** BCalvignac has quit IRC [22:02:47] *** BCalvignac has joined #chromium [22:04:50] *** rwlbuis has joined #chromium [22:05:46] <earyoyo> code review site is so unstable now [22:06:26] *** jschuh_ has quit IRC [22:07:02] *** Kaosevil has quit IRC [22:07:08] *** Caleb has quit IRC [22:09:13] *** sbyer has joined #chromium [22:10:14] *** SandGorgon has joined #chromium [22:12:29] <willchan> pinkerton: the proxy limit has been upped to 32. let me know if you still see issues. also, do you still want a more complete solution done by M6? [22:18:51] *** Zucca has quit IRC [22:19:04] *** dpranke has joined #chromium [22:19:04] *** ChanServ sets mode: +v dpranke [22:19:43] <pinkerton> willchan: that's probably good enough to make me stop wanting to stab my computer every 12 minutes :) [22:19:50] <jhawkins> tonyg-cr: my change is unrelated [22:21:02] <tonyg-cr> jhawkins: you are talking about net_unittests? [22:21:08] <jhawkins> tonyg-cr: yes [22:21:14] *** SandGorgon has quit IRC [22:22:03] <tonyg-cr> mbelshe was working on something with backup sockets [22:22:45] <willchan> is there a problem with net_unittests? [22:22:46] *** Royall_ has joined #chromium [22:22:54] <tonyg-cr> http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.5%20(dbg)/builds/5117/steps/net_unittests/logs/stdio [22:23:49] <willchan> tonyg-cr: i thought mbelshe fixed this bug. you should let him know. i think there's a bug filed for this. [22:24:12] <willchan> http://code.google.com/p/chromium/issues/detail?id=43919 [22:24:40] *** inferno-sec has joined #chromium [22:24:43] <tonyg-cr> thanks for the pointer, i'll ping that bug [22:25:49] *** Royall_ has left #chromium [22:28:48] *** Kopfgeldjaeger has joined #chromium [22:29:21] *** scherkus has joined #chromium [22:29:24] <Kopfgeldjaeger> hi, I might just be dumb, but where is the user data stored under linux? [22:29:45] *** ChanServ sets mode: +v scherkus [22:30:18] <Kopfgeldjaeger> nvm, .config/google-chrome [22:30:20] *** Kopfgeldjaeger has left #chromium [22:32:17] <jhawkins> tonyg-cr: xp tests dbg(1) looks like grd change failure, oddly enough [22:32:44] <jhawkins> probably safe to re-open [22:32:48] <tonyg-cr> thx [22:33:22] <jparent> jhawkins: I was just looking at that as it blames my webkit roll. Are you saying this wasn't from the roll? [22:33:38] <jhawkins> jparent: pretty sure it can't be, though we should keep an eye on it [22:33:57] <jparent> jhawkins: thanks. i was surprised since i'd seen that test pass on try bots before. [22:33:59] <jhawkins> this usually happens as a result of a grd change and the (IDS <-> strings) get messed up [22:34:18] <tonyg-cr> hopefully they'll pass on the next run [22:34:24] <tonyg-cr> if not, i'll close again [22:34:25] *** cying has quit IRC [22:34:26] *** rwlbuis has quit IRC [22:34:45] *** cying has joined #chromium [22:35:33] *** BCalvignac1 has joined #chromium [22:37:21] *** BCalvignac has quit IRC [22:37:24] <tonyg-cr> Reliability was failing due to a v8 crash in webkit, I blacklisted it, but now it is failing due to increased crash rate of the same crash [22:37:25] <tonyg-cr> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/10093/steps/reliability:%20partial%20result%20of%20current%20build/logs/stdio [22:37:35] <tonyg-cr> What should I do to make it happy again? [22:40:37] *** sundiamonde has joined #chromium [22:41:30] *** sundiamonde_ has joined #chromium [22:41:35] *** WePac has quit IRC [22:44:09] *** alkemann has joined #chromium [22:44:15] <alkemann> hello. [22:44:38] *** sundiamonde has quit IRC [22:44:38] *** sundiamonde_ is now known as sundiamonde [22:45:38] <alkemann> trying to write a simple extension that when I click the button, it forces a css rule of width:350px on all paragraph tags in the active tab. I can not get the "hello world" example of setting the background color on body to be red to work though. [22:47:25] <alkemann> i have set up an extension, I have a button that gives me a javascript alert when i click it, i just can't get this code to work : chrome.tabs.executeScript(null, {code:"document.body.style='background-color:red'"}); [22:48:07] <tonyg-cr> jhawkins: it looks like r48189 doesn't compile on win [22:48:15] <jhawkins> tonyg-cr: looking [22:49:02] <jhawkins> damn FRIEND_TEST!!! [22:49:06] <jhawkins> np [22:49:35] <tonyg-cr> let me know when the fix is in and i'll reopen [22:49:56] *** ishermandom has joined #chromium [22:50:07] *** Kaosevil has joined #chromium [22:50:41] <tonyg-cr> jparent: unit_tests failed a second time [22:51:04] *** mirandac_ has joined #chromium [22:51:30] *** bweinstein has quit IRC [22:52:27] <jhawkins> tonyg-cr: done [22:52:54] <jparent> tonyg-cr, jhawkins: I'm not familiar with grd issues, do we need a full compile or something? [22:53:01] <tonyg-cr> jhawkins: thx, one more question for you, why would a test marked FAILS_ still run? [22:53:11] <jparent> tonyg-cr, jhawkins: regarding the unit_test failure [22:53:15] <jhawkins> jparent: shouldn't if it is a grd issue; however, I have no idea how a WK roll could possibly cause this test to fail [22:53:32] <jhawkins> tonyg-cr: FAILS_ is the same as FLAKY_ [22:53:46] <jhawkins> just lets everyone know that it is failing consistently instead of flakily [22:53:56] <rafaelw> jhawkins, tonyg marked a test as FAILS_, but the bot is still red. [22:54:20] <rafaelw> http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(Views%20dbg)/builds/10659/steps/browser_tests/logs/stdio [22:54:23] <rafaelw> oops. [22:54:42] *** kinnetica has quit IRC [22:54:59] *** Beetny has quit IRC [22:57:32] <tonyg-cr> why does the console sometimes skip revisions? [22:57:34] <alkemann> could anyone help me out on why this does not work? http://pastium.org/view/dbd8736c921687214c5f290c8cdaaece [22:57:58] <tonyg-cr> eg. 48172 is after 48168 [22:58:23] <jparent> tonyg-cr: I think the ones you dont' see are ones that don't effect trunk [22:58:35] <jhawkins> rafaelw, tonyg-cr: so that test apparently needs to be disabled for linux views because it crashed [22:58:56] *** bweinstein has joined #chromium [22:59:01] <jparent> tonyg-cr: aka, 48170 touches a release branch [22:59:06] <tonyg-cr> jhawkins: I'll put together a patch changing it back to disabled [22:59:14] <tonyg-cr> jparent: i see now, thanks [22:59:17] <jhawkins> tonyg-cr: thank you, but only for linux views! [22:59:24] <jhawkins> and make sure to add a comment about it crashing [22:59:24] *** miketaylr has quit IRC [22:59:26] <tonyg-cr> jhawkins: right [23:00:03] <nshkrob_> b [23:00:12] *** ishermandom has quit IRC [23:00:53] <alkemann> is this the wrong channel is there a specific channel for chrome extensions? [23:01:15] *** sundiamonde has quit IRC [23:01:47] <jamesr> alkemann: you will probably have more luck on the chromium extensions mailing list [23:02:00] <jamesr> there's a lot of helpful folks there who might know the answer [23:02:03] *** peratu has joined #chromium [23:02:16] <peratu> Hi. [23:02:29] <alkemann> mailing list? thanks. didnt know people still did that [23:02:56] <jamesr> i know. some people still use IRC too! how archaic [23:02:59] <peratu> The http://build.chromium.org/buildbot/snapshots/chromium-rel-linux-64/LATEST filr contents 48189 , but does't exist a folder for 48189. [23:03:01] *** ROBOd has quit IRC [23:03:07] <peratu> s/filr/file/ [23:03:27] <jamesr> peratu: http://build.chromium.org/buildbot/snapshots/chromium-rel-linux-64/48189/ [23:03:48] *** hclam has joined #chromium [23:03:49] <peratu> jamesr, yes, doesn't exists. [23:03:52] <jamesr> peratu: it's there now, there may be some delay between upading LATEST and uploading the files [23:04:00] <jamesr> yeah it does [23:04:33] <tonyg-cr> jhawkins, rafaelw, jparent: jhawkins' compile fix worked, i'm leaving the tree closed until we figure out what happened with win unit_tests [23:05:22] <peratu> jamesr, ok, I'll wait. [23:05:45] <jparent> tonyg-cr: the tests will be done on Vista Tests in less than a minute, lets wait for that and see if it failed again [23:06:40] <jparent> tonyg-cr: actually, it has already run the unit tests on that bot and passed [23:07:09] <jamesr> peratu: can you still not see it? [23:07:24] <peratu> jamesr, still not working for me. [23:07:30] *** alkemann has left #chromium [23:07:30] <jparent> tonyg-cr: went green for Vista Tests, seems safe to re-open if that ws the only reason tree is closed now [23:07:42] *** trungl_mbp has quit IRC [23:07:46] <jamesr> that is odd. what if you force reload? [23:07:54] <tonyg-cr> opened :) [23:08:10] <peratu> jamesr, I'm going to clean the cache... [23:08:48] <peratu> Nothing. [23:09:08] <jamesr> so you click that link and get the 'Oops' page? [23:09:19] <jamesr> what if you use a different browser? [23:09:41] <peratu> jamesr, I get the 'Oops' page, yes. I'm going to try it with Firefox. [23:10:06] <peratu> The requested URL /buildbot/snapshots/chromium-rel-linux-64/48189/ was not found on this server. [23:10:39] *** bweinstein has quit IRC [23:10:58] <peratu> Does the latest version (48189) will supports webm? I'm on 48020 and it doesn't. [23:11:58] *** jamesr has quit IRC [23:11:59] *** jamesr_ has joined #chromium [23:12:37] <mbelshe> looks like i missed a file in my checkin [23:13:18] *** GeekShadow has quit IRC [23:13:39] <peratu> jamesr_, I have asked in another channel for someone for check the url. It works for him, but not for me. I don't know why. [23:13:56] <jamesr_> peratu: yeah that's really odd. i don't know what could be causing that [23:13:57] <mbelshe> missedfile now checked in. [23:13:59] <jamesr_> peratu: are you using an http proxy? [23:14:03] <peratu> Oh, no! Two people with 404 error. [23:14:50] *** ishermandom has joined #chromium [23:14:52] <jamesr_> i'll bet scherkus knows the answer to the webm question [23:15:57] <scherkus> peratu: I landed webm support last wednesday [23:16:38] <scherkus> peratu: http://src.chromium.org/viewvc/chrome?view=rev&revision=47759 [23:17:00] <scherkus> not sure what problems you're running in to :\ [23:18:33] *** reiko has quit IRC [23:19:28] <jhawkins> mbelshe: looks like the compile failure is yours [23:19:51] *** bauerb has joined #chromium [23:19:58] <jamesr_> looks like our mirroring is a bit slow [23:20:37] *** bweinstein has joined #chromium [23:21:22] <tonyg-cr> mbelshe: does 48196 fix the build? [23:22:54] <mbelshe> @tonyg [23:22:56] <mbelshe> i think so [23:23:02] <mbelshe> so - i did DOZENS of trybot runs [23:23:08] <mbelshe> trybot completely failed me [23:23:10] <tonyg-cr> i see reopened, must be confident [23:23:15] *** rohitrao has quit IRC [23:23:18] <mbelshe> it didn't notice that I didn't have this file in the CL? WTF? [23:23:24] *** ishermandom has quit IRC [23:23:28] <mbelshe> if Trybots don't actually compile the code, what the hell do they do? [23:23:39] *** tonikitoo has quit IRC [23:24:04] <tonyg-cr> it claims that it failed again with 48196, is that just lag? [23:24:40] <willchan> mbelshe: i think there's a section of trybot code, if (user == mbelshe) return kPrecannedOutput; [23:25:27] <tonyg-cr> oh this might be unrelated to your change: C:\b\slave\chromium-rel-xp\build\src\chrome\installer\util\l10n_string_util.cc(45) : error C4389: '==' : signed/unsigned mismatch [23:25:31] <mbelshe> tony - looking [23:26:00] <peratu> scherkus, sorry, it works. I hadn't found the right webm videos :P [23:26:47] <mbelshe> tony - yeah - looks like multiple files don't get compiled [23:26:49] *** BCalvignac1 has quit IRC [23:26:50] <mbelshe> via the bbots [23:26:58] *** computer_ has joined #chromium [23:27:30] *** BCalvignac has joined #chromium [23:27:33] *** thomasvl has quit IRC [23:27:40] *** thomasvl has joined #chromium [23:27:41] *** ChanServ sets mode: +v thomasvl [23:28:12] <pinkerton> thomasvl: ping? [23:29:26] <mbelshe> ok - second missed file patch uploaded. [23:29:33] <tonyg-cr> thx :) [23:29:34] <mbelshe> there might be more.... i don't know how much these bbots missed. [23:29:38] <tonyg-cr> uh oh [23:29:40] <mbelshe> i'm auditing [23:30:38] <scherkus> peratu: awesome!! :D [23:31:06] <peratu> scherkus,in this video -> http://www.youtube.com/watch?v=Z8EA7EbFX4k [23:31:48] *** thomasvl has quit IRC [23:36:09] *** pinkerton has quit IRC [23:37:34] <willchan> anyone on Linux use the --load-extension flag? I'm trying it out and it gives me a dialog box about xdg-open. clicking on the dialog box buttons doesn't seem to do anything. [23:37:51] *** blime has quit IRC [23:37:54] <mbelshe> to all: if we see any warnings on windows builds for signed/unsigned mismatch - it's related to my change. [23:37:59] <mbelshe> I hope we're cycling green right now [23:38:16] <mbelshe> Apparently, change to the build/common.gypi don't trigger a rebuild, so dependencies can be missed [23:40:17] *** tonikitoo has joined #chromium [23:42:10] *** mirandac_ has quit IRC [23:43:33] *** bweinstein has quit IRC [23:45:01] *** klawd has joined #chromium [23:45:19] *** roc has quit IRC [23:45:19] <klawd> hi! is there a way to open a blank popup in chrome? [23:45:53] *** sundiamonde has joined #chromium [23:46:38] *** ishermandom has joined #chromium [23:46:53] *** sundiamonde has quit IRC [23:48:47] *** sundiamonde has joined #chromium [23:53:24] *** dave_levin has quit IRC [23:53:50] *** ishermandom has quit IRC [23:54:46] *** mirandac_ has joined #chromium [23:54:57] *** jcivelli has quit IRC [23:58:31] <tonyg-cr> jhawkins: r48202 looks like it broke the build [23:58:52] <jhawkins> hmm looking [23:59:08] <tonyg-cr> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder/builds/28421/steps/compile/logs/stdio