[00:01:06] *** tonyg-cr has quit IRC [00:01:17] *** dglazkov has quit IRC [00:01:25] *** pinkerton has quit IRC [00:02:15] *** Kunalagon has quit IRC [00:03:03] *** mpcomplete has joined #chromium [00:03:04] *** ChanServ sets mode: +v mpcomplete [00:03:30] <estade> dumi, pong [00:03:57] <dumi> estade: i was told you might know how to build webkit's GTK port [00:04:02] <dumi> estade: i'm running into the glibc version problem [00:04:07] <estade> dumi: lies I'm afraid [00:04:17] <dumi> estade: :( [00:04:26] *** tonyg-cr has joined #chromium [00:04:27] *** ChanServ sets mode: +v tonyg-cr [00:04:35] <dumi> estade: ok, i'll go find somebody else then [00:04:37] <estade> dumi: out of curiosity why are you building webkit gtk [00:04:49] <dumi> estade: because i have a CL that breaks their bot :) [00:04:57] <estade> AH [00:05:00] <estade> oops caps [00:06:49] *** skydrome has quit IRC [00:07:06] *** skydrome has joined #chromium [00:07:46] *** eseidel has joined #chromium [00:09:28] *** jamesr has joined #chromium [00:09:43] *** GabRoyer has joined #chromium [00:09:52] *** skydrome has left #chromium [00:12:53] *** snej has joined #chromium [00:14:08] *** GabRoyer has left #chromium [00:14:27] <trungl> snej: ping? [00:14:42] <snej> trungl: ping [00:14:54] <trungl> snej: do you think the various test failures could be you? [00:15:13] <snej> I was just looking at that. Looks like there were a ton of failures before my checkin, too. [00:15:19] <snej> Do you know which ones only appeared after? [00:15:22] *** tonyg-cr has quit IRC [00:15:55] <trungl> snej: if you look at the merge view, I think all the failures include your change [00:16:11] <trungl> (except linux browser_tests_ [00:16:18] <trungl> (and probably a few other scattered flakes) [00:17:13] <snej> I haven't used the merge view before. What is it saying? [00:17:48] <trungl> the vertical extent indicates which (new) commits it includes [00:18:23] *** zaspire has quit IRC [00:19:09] <trungl> (basically, the bots build/test on a continuous basis, but each run might include more than one commit) [00:20:25] <trungl> another way of putting it is that the vertical extent of each bar indicates the blamelist if it fails [00:21:00] *** peter_12 has quit IRC [00:21:01] <lzheng> So, can we revert 46394? [00:21:04] *** tonyg-cr has joined #chromium [00:21:05] *** ChanServ sets mode: +v tonyg-cr [00:21:22] <snej> The failures I've looked at so far seem totally unrelated, like the Mac compile failure. [00:21:28] *** dglazkov has joined #chromium [00:21:29] *** ChanServ sets mode: +v dglazkov [00:21:54] <trungl> snej: which mac compile failure? [00:22:05] <snej> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/5741/steps/compile/logs/stdio [00:22:05] *** netdur has joined #chromium [00:22:06] <trungl> oh, on the release builder [00:22:18] <snej> something to do with yasm [00:23:01] *** patcito has left #chromium [00:23:03] <trungl> that's a separate issue [00:23:08] <lzheng> snej: if you look at http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg)(2)/builds/12502, you will see that build only includes your change. There are several other similar examples. [00:23:25] <netdur> just updated on ubuntu, chromium loop/load forever on some sites like wikipedia.org and chromium blog then crash tab [00:23:59] <evmar> netdur: what version [00:24:00] <netdur> ah! google front page show up but results page never show up so I can't google it [00:24:06] <lzheng> snej: can you revert your change? [00:24:20] <trungl> lzheng, snej: I think we should revert r46394 [00:24:22] <snej> lzheng: OK. [00:24:26] <netdur> evmar: 5.0.393.0 (46027) Ubuntu [00:24:43] <evmar> netdur: i think that is an old version [00:24:50] *** jrmuizel has quit IRC [00:25:20] <dpranke> nsylvain, maruel: do we know why the mac webkit bot was down for much time last night? [00:26:02] *** jrmuizel has joined #chromium [00:26:11] <trungl> lzheng: msneck reverted 46388 -- what's up with that? [00:26:39] *** jrmuizel has quit IRC [00:26:45] <snej> I'm using git. Is there a shortcut tool for backing out a commit? [00:26:45] <netdur> evmar: what should I do? I got this update today [00:27:32] <trungl> snej: probably the easiest thing is to just use drover to revert [00:27:43] <lzheng> trung1: what does 46388 do? [00:27:59] <trungl> lzheng: it was a nacl deps roll [00:28:52] *** dglazkov has quit IRC [00:28:57] *** dglazkov has joined #chromium [00:28:58] *** ChanServ sets mode: +v dglazkov [00:29:44] <snej> OK, 46394 is backed out. [00:29:59] *** skydrome has joined #chromium [00:30:47] <trungl> thanks [00:31:56] *** Venom_X has quit IRC [00:32:00] <lzheng> trung1: I didn't know that 4388 was causing trouble. Was it because I was in the meeting? [00:32:55] <lzheng> trung1: maybe there were other tests broken by it. [00:33:08] <markmentovai> lzheng: did you mean trungl? [00:33:20] *** Venom_X_ has joined #chromium [00:33:42] <trungl> on old typewriters, we'd be the same person [00:33:54] <lzheng> markmentovai: thanks for pointing out. [00:33:56] <trungl> lzheng: I see no evidence that 46388 caused big trouble [00:34:04] <trungl> (I don't know about little trouble) [00:34:12] <trungl> I don't see any evidence for either, really [00:34:13] <markmentovai> but on this typewriter, you?re the same as trungI [00:34:33] *** netdur has left #chromium [00:34:50] <trungl> lzheng: there wasn't any discussion on irc about this earlier [00:38:33] <lzheng> trungl: I see. I could ping msneck and see. [00:39:00] <trungl> lzheng: that might be a good idea, if only to know what's going on [00:39:20] *** markmentovai has quit IRC [00:39:28] * trungl suspects that he reverted his change unnecessarily (though there's little harm in that). [00:39:56] *** skydrome has quit IRC [00:40:18] *** skydrome has joined #chromium [00:40:54] <snej> OK, I think I see the bug in my commit. I wasn't expecting a method called 'CreateXXX' to return NULL, but apparently it does in some cases. It's a fair cop. [00:41:11] <cmasone> snej: But, society's to blame [00:41:20] <snej> cmasone: Always. [00:41:36] <lzheng> trungl: msnet said he *thought* he caused the problem so he reverted. [00:42:08] <snej> I grew up in a religious sect that didn't believe in the existence of null pointers. [00:42:13] * pcgod still needs to find out whats causing those errors: "[26852:26852:11802230765:FATAL:base/process_util_linux.cc(503)] Check failed: false. Out of memory, size = 7551860816" :/ [00:42:35] *** pax- has joined #chromium [00:42:59] <dumi> estade: the misunderstanding was resolved: it was the other evan :) [00:42:59] <evmar> pcgod: you mean your system doesn't have 7.5gb free for us to allocate? ;) [00:43:13] <pax-> Anyone know if there's a channel for Native Client? [00:43:14] <evmar> dumi: ah, i was sorta wondering that. but i also have no advice for you, it's hard to build [00:43:24] <dumi> evmar: :( [00:43:25] <evmar> dumi: you might try asking #webkit-gtk for help, they are nice people [00:43:26] <lzheng> snej: thanks for pinging it down. [00:43:29] <pcgod> evmar: no, and it's a new brower instance and it happens everytime I try to open the new tab page :) [00:43:52] <evmar> pcgod: did you build it yourself? we dump a stack trace when that happens [00:43:54] <dumi> evmar: my problem is the glibc version... don't know if they can help with that other than "install a newer version" [00:44:03] <pcgod> evmar: yes, but it's a release build... [00:44:17] <evmar> dumi: probably glib, not glibc. you just need to use a computer that's relatively new, unfortunately [00:44:34] <evmar> pcgod: release builds still have symbols in 'em [00:44:39] <dumi> evmar: well, i use a standard google linux machine [00:44:45] <lzheng> I will open the tree once it starts to grow green. [00:44:53] <evmar> pcgod: try "ulimit -c unlimited", run chrome, then "gdb /path/to/chrome/binary core" and then "bt" [00:44:59] <evmar> dumi: yeah, they are hella old [00:45:45] *** cbentzel has quit IRC [00:47:57] *** peter_12 has joined #chromium [00:48:12] <dpranke> lzheng, danno, neb : I just killed and restarted the build on webkit mac dbg(3) [00:49:30] <lzheng> dpranke: k. Just curious, why? [00:49:42] <dpranke> because it had been hung since 8:30 this morning? [00:50:06] <lzheng> dpranke: oh, sorry I did not notice that. How did you find out? [00:50:26] <dpranke> lzheng: looked at the fact that no builds have completed on that bot on the main waterfall :( [00:50:53] <dpranke> lzheng: I'm in the middle of hunting down bot crashes on the other mac layout test bots, but that one was kind of obvious :) [00:51:42] <lzheng> dpranke: thx. [00:51:50] <dpranke> lzheng: yw [00:55:46] *** Bleak has joined #chromium [00:56:19] <pcgod> evmar: http://pastebin.com/0mSGCmQu not really helpful [00:56:36] *** cying has quit IRC [00:57:02] <evmar> pcgod: that is weird looking [00:57:13] <lzheng> Anyone familiar with valgrind build for cros? I suspect 46311, 46312, 46313 broke its compilation with mmap problem during linking time. [00:58:49] <pcgod> and the trace for the other crashing renderer is also strange... http://pastebin.com/saeDXzDw [00:58:53] *** skydrome has quit IRC [00:59:01] *** skydrome has joined #chromium [01:00:52] *** skydrome has quit IRC [01:01:02] *** Guest73072 has joined #chromium [01:01:19] *** skydrome has joined #chromium [01:01:50] <evmar> pcgod: random thought, are you building on a lucid system? [01:02:12] *** tittiatcoke has quit IRC [01:02:17] *** tonikitoo has joined #chromium [01:05:38] <pcgod> evmar: opensuse factory [01:05:55] <evmar> pcgod: with gold or normal ld? [01:06:04] <evmar> pcgod: (this looks like a crash i've been seeing from building with gold) [01:06:15] *** General1337 has quit IRC [01:07:11] *** General1337 has joined #chromium [01:08:11] <pcgod> evmar: afaik gold is the default linker on opensuse [01:09:43] <evmar> huh, i wonder what's gone wrong [01:11:37] *** cbentzel has joined #chromium [01:11:59] <trungl> lzheng: should we reopen the tree? [01:14:28] *** romainhuet has quit IRC [01:17:57] * trungl wonders if silence is consent. [01:18:21] <mrossetti> trungl, +1 [01:19:31] *** rafaelw has left #chromium [01:21:01] <trungl> opened [01:22:01] <lzheng> trung1: sounds good. [01:22:49] *** paul_irish has joined #chromium [01:27:18] *** kwinz2 has quit IRC [01:30:27] *** taf2_ has quit IRC [01:32:22] *** taf2_ has joined #chromium [01:33:24] <jamesr> evmar: i couldn't run any complex binary linked with gold on lucid as of a few weeks ago [01:33:43] <jamesr> i thought they would have fixed gold or changed the version they released before going final [01:33:45] <jamesr> but oh well [01:36:00] *** max109 has joined #chromium [01:36:20] *** dave_levin has quit IRC [01:36:27] *** dglazkov has quit IRC [01:39:33] *** eseidel has quit IRC [01:46:38] <akalin> willchan: ping! [01:49:54] *** fishd has joined #chromium [01:49:54] *** ChanServ sets mode: +v fishd [01:50:01] *** fishd has quit IRC [01:50:02] <willchan> akalin: pong [01:51:25] <akalin> did you get my last reply re. why i want to add a CreateNetworkChangeNotifier() method to IOThread? [01:51:36] <akalin> er, CreateNetworkChangeNotifierForThread() [01:51:46] <akalin> (which would take the global one and wrap a NCNProxy around it) [01:51:50] <willchan> sorry, yes, i did [01:52:02] <akalin> what do you think? [01:52:17] <willchan> i'm trying to think if there is a better way to address it [01:52:28] * willchan summons eroman [01:52:39] <akalin> I'm def. open to suggestions :) [01:52:42] <eroman> willchan: reagent missing -- soulshard [01:53:01] <akalin> i always parse eroman as 'ero man' and not 'e roman' [01:53:02] <eroman> oh wait, this is real life, not wow [01:53:08] <willchan> haha [01:53:13] <willchan> i missed the ref since i don't play WoW :P [01:53:23] <willchan> eroman: did you see akalin's issue above? [01:53:48] <willchan> he needs to access NetworkChangeNotifier from another thread, so he can pass it to a proxy [01:53:57] <willchan> so he can receive notifications in the sync threads [01:54:29] <willchan> NetworkChangeNotifier is in IOThread::globals_ [01:54:39] <willchan> so, only accessible from the io thread [01:55:19] <eroman> trying to page in the data, hang on [01:55:20] <willchan> akalin: i think you need to add the proxy as an observer to the NetworkChangeNotifier on the IO thread [01:55:31] <willchan> which i assume is why you need a method on IOThread [01:55:33] *** max109 has left #chromium [01:55:38] <akalin> willchan: yes [01:55:47] <willchan> since NetworkChangeNotifier::AddObserver() is not threadsafe [01:56:25] <willchan> i'm leaning towards agreeing with your proposal [01:58:18] <akalin> another possibility is that, since the NetworkChangeObserverProxy takes a source thread and a source NCN and posts a task on the source thread to call AddObserver(), it could take a source IOThread and the posted method will simply access globals() for the NCN [01:58:47] <akalin> but that introduces a dependency on chrome/io_thread.h instead of base/thread.h :( [02:00:44] <eroman> just figured i would mention this, there is now a MessageLoopProxy object, which can be used in place of passing around raw MessageLoop* (but when you can't depend on ChromeThread) [02:01:27] <akalin> yeah, i saw that [02:01:30] *** prasadt has quit IRC [02:01:41] <akalin> it's unnecessary since IOThread outlives the sync threads [02:02:00] <akalin> in fact i'm not sure what the use case for that is :| [02:02:55] <akalin> i think sanjeevr wanted to pull a URLsomethingsomething class out? [02:03:48] <akalin> but how can I use that, since I do need to depend on IOThread to access globals()? [02:04:45] <willchan> I think it's probably fine to depend on IOThread [02:04:57] <willchan> it's part of the reason why it's in chrome/ code instead of net/ [02:05:19] <akalin> yeah [02:05:23] <akalin> it makes unittesting harder, though. hmm. [02:05:29] <willchan> that's a good point [02:08:09] <akalin> perhaps make some NetworkChangeObserver's constructor take an interface instead of a (message_loop, NCN) pair [02:08:31] <akalin> this interface would have GetSourceMessageLoop() and GetSourceNCN() (latter only callable on the source thread) [02:08:38] <akalin> er NetworkChangeObserverProxy [02:08:49] *** lilmatt_ has quit IRC [02:08:57] <akalin> and the proxy would post a method on the source thread which would call GetSourceMessageLoop() and add itself to that as an observer [02:09:33] <akalin> then there would be a simple wrapper around IOThread the sync threads could use [02:09:53] <akalin> and unittests would use their own implementation [02:12:03] <akalin> avoids the need to move code and also avoids the need to touch iothread [02:13:19] <akalin> i think i'll try that [02:13:54] <willchan> eroman and i were just chatting offline, helping him page things back to memory [02:15:21] <willchan> so i think what you effectively said was just dependency injection [02:15:29] <willchan> for unittesting [02:15:34] <akalin> yeah pretty uch [02:15:36] <akalin> m [02:15:39] <willchan> sounds fine to me [02:15:48] <akalin> cool [02:17:54] *** RT|Chatzilla has joined #chromium [02:20:13] *** Guest73072 has quit IRC [02:22:06] *** stuartmorgan has quit IRC [02:22:29] *** MikeSmithW3C^ has joined #chromium [02:24:02] <eroman> sounds good to me [02:25:36] *** MikeSmithW3C has quit IRC [02:27:19] *** peloverde has quit IRC [02:28:47] *** MikeSmithW3C^ has quit IRC [02:32:38] *** mpcomplete has quit IRC [02:32:59] *** dmaclach has quit IRC [02:35:19] *** lzheng has quit IRC [02:35:45] *** erikkay has quit IRC [02:36:55] *** lilmatt has joined #chromium [02:37:07] *** peter_12 has quit IRC [02:37:42] *** mpcomplete has joined #chromium [02:37:42] *** ChanServ sets mode: +v mpcomplete [02:42:11] *** sundiamonde has joined #chromium [02:43:09] *** tonyg-cr has quit IRC [02:51:42] *** feldstein has quit IRC [02:56:27] *** tedoc2000 has quit IRC [03:04:27] *** jhawkins has joined #chromium [03:04:50] <eglaysher> dhollowa: I think the compile failure might be your patch. [03:05:05] <dhollowa> eglaysher: looking [03:06:03] <dhollowa> eglaysher: yes, mine, will revert. weird though, it passed the bots originally. [03:10:47] <m0> Is it by design while in Incognito mode, if the user is downloading a file and has an Incognito Window and a Normal Window open, the downloads will cancel if the Incognito window closes? [03:11:37] *** johnny_g has quit IRC [03:12:04] <evmar> that sounds like a bug [03:12:13] <m0> But the other way, if we are downloadinga file in Normal mode, open incognito close normal mode, the file still downloads, and the file only cancels download if all windows are closed. [03:13:07] <m0> It is becaused I am assigned a bug http://crbug.com/42570 [03:13:16] <m0> I will mention that, thanks [03:13:58] <maruel> m0: cute [03:14:41] <m0> :-) [03:15:31] <dhollowa> eglaysher: revert is committed. [03:16:21] <jhawkins> dhollowa: bummer, revert not necessarily needed. just needed to modify one occurrence of ShowAutoFillDialog you missed originally [03:16:51] <m0> evmar: well, if I open Incognito window and Normal window, and download a different file in each window, if I close incognito, it asks me to cancel all the downloads. I choose yes, and all the incognito downloads are cancelled but the normal windows are still active. [03:17:01] <willchan> anyone seeing any issue with git cl upload? i get 404s [03:17:12] *** evmar is now known as evmar_afk [03:18:09] *** zyichi has joined #chromium [03:18:10] *** trungl_mbp has quit IRC [03:19:49] *** taf2_ has quit IRC [03:22:41] <willchan> hrm, nm, works in a diff terminal. [03:22:43] *** trungl is now known as trungl_away [03:23:22] *** csilv has left #chromium [03:25:28] *** jamesr has quit IRC [03:28:35] <dpranke> glargh - are we going to leave the tree closed until the chromium dbg builder completes? [03:30:09] <pkasting> I vote for opening now, so I can check in :D [03:30:21] <willchan> shouldn't we just open it after the compile phase finishes? [03:34:02] <m0> pkasting: I have a question if you don't mind, sorry, you have answers to all chrome questions ever existed :x [03:34:11] <pkasting> OK, I have like 4 minutes [03:34:35] <m0> pkasting: cool! Do incognito downloads differ than normal downloads? [03:34:47] <pkasting> Differ how [03:35:19] <m0> download a file in Incognito and another file in Normal, close Incognito window. The normal one stays downloading. [03:36:01] <m0> Download a file in Normal, open Incognito window, close normal, open normal, close incognito. The download stays. [03:36:25] <pkasting> Why don't you just try downloading in Incognito, close the window, and see if the download gets aborted [03:36:29] <m0> Open normal, open Incognito, download a file in incognito, close incognito, asks if you want to cancel. [03:36:40] <pkasting> OK, well there's your answer [03:36:44] <m0> It does get aborted, I am wondering if thats a bug. [03:36:47] <m0> Or thats the chrome way. [03:36:59] <m0> Cuase I have to fix a bug along those lines for Win7 progress bar. [03:37:54] <pkasting> The current behavior is intentional [03:38:05] <pkasting> You should ask georgey for more info if you want [03:38:12] <m0> Thanks for your time :) [03:38:24] <pkasting> I have no idea what the "Win7 progress bar" is so I can't tell you how to extrapolate this data [03:38:50] <pkasting> willchan, dpranke: compile succeeded [03:38:57] <m0> Hmm, its just the Aero Downoad on the task bar that I did. When you download something, a progress bar shows on the task bar. [03:39:09] *** bent-mozilla has quit IRC [03:39:09] <pkasting> Should I reopen? [03:39:14] <dpranke> okay, I say we open the tree [03:39:37] <dpranke> does being gardener instead of sheriff give me the authority ;) ? [03:39:42] <pkasting> Done [03:39:55] *** abarth has joined #chromium [03:39:55] *** ChanServ sets mode: +v abarth [03:40:35] *** eseidel has joined #chromium [03:54:12] *** rsesek_away has quit IRC [03:54:53] *** eseidel_ has joined #chromium [03:57:17] *** mpcomplete has quit IRC [03:59:13] *** eseidel has quit IRC [03:59:13] *** eseidel_ is now known as eseidel [04:06:02] *** trungl_mbp has joined #chromium [04:10:42] *** snej has quit IRC [04:10:59] *** jmcantrell has joined #chromium [04:11:50] <jmcantrell> it seems like any page with javascript takes forever load (or never does). i keep getting the unresponsive page message [04:12:00] <jmcantrell> i have the latest dev version [04:13:31] *** trungl_mbp is now known as trungl [04:13:33] *** ChanServ sets mode: +v trungl [04:15:13] <jmcantrell> for example, the chrome extensions page or gmail [04:26:10] *** rohitrao has quit IRC [04:26:25] *** dglazkov has joined #chromium [04:26:25] *** ChanServ sets mode: +v dglazkov [04:29:49] *** paul_irish has quit IRC [04:30:57] *** tfarina has joined #chromium [04:36:17] *** trungl has quit IRC [04:42:17] *** dglazkov has quit IRC [05:00:43] *** inferno-sec has quit IRC [05:04:21] *** zyichi has quit IRC [05:04:51] *** mahemoff has joined #chromium [05:04:52] *** zyichi has joined #chromium [05:05:03] *** zyichi has joined #chromium [05:05:59] *** trungl_mbp has joined #chromium [05:07:38] *** trungl_mbp is now known as trungl [05:07:39] *** ChanServ sets mode: +v trungl [05:10:38] <dpranke> chase: ping? [05:16:56] *** mrossetti has quit IRC [05:17:12] *** tfarina has quit IRC [05:19:20] *** mahemoff has quit IRC [05:22:25] *** dmaclach has joined #chromium [05:23:10] *** dmaclach_ has joined #chromium [05:23:11] *** dmaclach has quit IRC [05:23:11] *** dmaclach_ is now known as dmaclach [05:24:46] *** dmaclach_ has joined #chromium [05:24:46] *** dmaclach has quit IRC [05:24:47] *** dmaclach_ is now known as dmaclach [05:25:50] *** cbentzel has quit IRC [05:26:08] *** tmzt_ has joined #chromium [05:26:23] *** dmaclach_ has joined #chromium [05:26:35] <tmzt_> is there are any direct hardware access possible in chromium, not chromium os? [05:26:43] <tmzt_> I mean is there an api planned for that? [05:28:37] <dpranke> tmzt_: what do you mean by "direct hardware access"? [05:28:58] <dpranke> tmzt_: the answer is probably no in the general case [05:29:00] *** bweinstein has quit IRC [05:29:14] *** dmaclach has quit IRC [05:29:14] *** dmaclach_ is now known as dmaclach [05:29:22] <tmzt_> camera, webcam, transferring pictures, maybe mp3 player or phone [05:29:58] <dpranke> tmzt_: we are working on APIs for particular devices as part of the public-device-apis working groups in the W3C [05:30:21] <dpranke> tmzt_ including camera access [05:30:28] <tmzt_> so check the mailing list archives? [05:30:37] <dpranke> tmzt_: yeah [05:30:56] <dpranke> tmzt_: sorry, gotta run. hope that is at least a little helpful [05:30:59] <tmzt_> ok, thanks. I'm just trying to understand what the plugin free world is going to look like [05:31:02] <tmzt_> yeah, thanks [05:31:36] <dpranke> tmzt_: certainly in order to remove plugins, we would need to provide APIs to native features. One won't happen before the other [05:32:05] *** dpranke has quit IRC [05:38:08] *** js2 has joined #chromium [05:41:00] *** rohitrao has joined #chromium [05:41:01] *** ChanServ sets mode: +v rohitrao [05:50:32] *** TabAtkins__ has joined #chromium [05:57:21] *** yutak_home has quit IRC [06:00:55] *** dglazkov has joined #chromium [06:00:56] *** ChanServ sets mode: +v dglazkov [06:04:13] *** zyichi has quit IRC [06:04:25] *** dave_levin has joined #chromium [06:07:57] *** eseidel has quit IRC [06:20:03] *** twanj has joined #chromium [06:36:43] *** jmcantrell has quit IRC [06:41:52] *** abarth has quit IRC [06:45:04] *** dglazkov has quit IRC [06:45:19] *** int3 has quit IRC [06:50:11] *** tedoc2000 has joined #chromium [06:55:22] *** dmaclach has quit IRC [06:56:22] *** tittiatcoke has joined #chromium [07:00:46] *** dave_levin has quit IRC [07:00:58] *** twanj has quit IRC [07:02:11] *** feldstein has joined #chromium [07:06:10] *** cying has joined #chromium [07:11:16] *** twanj has joined #chromium [07:23:41] *** tedoc2000 has quit IRC [07:25:22] *** tedoc2000 has joined #chromium [07:26:26] *** luke has joined #chromium [07:26:32] *** luke is now known as Guest34865 [07:28:06] *** loislo has joined #chromium [07:29:07] *** luke__ has quit IRC [07:32:23] *** steinberg has joined #chromium [07:39:44] *** tedoc2000 has quit IRC [07:42:17] *** TabAtkins__ has quit IRC [07:47:53] *** General13372 has joined #chromium [07:47:58] *** luxigo has joined #chromium [07:48:55] *** dmaclach has joined #chromium [07:51:22] *** tittiatcoke has quit IRC [07:51:51] *** General1337 has quit IRC [07:54:52] *** dmaclach has quit IRC [07:54:55] *** dmaclach has joined #chromium [07:55:41] *** twanj has quit IRC [07:55:52] *** loislo has quit IRC [07:57:32] *** dmaclach has quit IRC [08:04:40] *** luxigo has quit IRC [08:07:17] *** FeasibilityStudy has joined #chromium [08:10:51] *** twanj has joined #chromium [08:11:21] *** zyichi has joined #chromium [08:14:49] *** rohitrao has quit IRC [08:22:03] *** feldstein has quit IRC [08:23:09] *** MetaMucil has joined #chromium [08:24:50] *** feldstein has joined #chromium [08:29:41] *** abarth has joined #chromium [08:29:42] *** ChanServ sets mode: +v abarth [08:29:43] *** brot has quit IRC [08:29:43] *** rellig has quit IRC [08:29:46] *** rellig has joined #chromium [08:29:46] *** brot has joined #chromium [08:32:08] *** twanj has quit IRC [08:34:43] *** enigmus has joined #chromium [08:40:49] *** enigmus has quit IRC [08:41:38] *** coyo has quit IRC [08:42:29] *** loislo has joined #chromium [08:44:48] *** kuchhal has quit IRC [08:46:11] *** steinberg has quit IRC [08:47:56] <trungl> 'night, Chromium. [08:47:59] *** trungl has quit IRC [08:50:29] *** yutak_home has joined #chromium [08:50:29] *** ChanServ sets mode: +v yutak_home [08:53:13] *** steinberg has joined #chromium [09:10:33] *** FeasibilityStudy has quit IRC [09:13:05] *** selckin has quit IRC [09:14:53] *** selckin has joined #chromium [09:15:32] *** chid has joined #chromium [09:16:01] <chid> hey, how does one set a HTTP_PROXY tunneled via ssh [09:16:11] <chid> do you just set socks5 and the http_proxy [09:16:29] *** feldstein has quit IRC [09:17:53] <jochen__> good morning chromium [09:18:06] <chid> hi [09:18:31] <chid> ls [09:18:36] *** chid has quit IRC [09:18:48] *** pamg has quit IRC [09:18:48] *** mnissler has quit IRC [09:18:48] *** danno_ has quit IRC [09:19:01] *** mnissler has joined #chromium [09:19:29] *** jochen__ has quit IRC [09:19:50] *** hosh_office has quit IRC [09:20:34] *** hosh_office has joined #chromium [09:21:48] *** feldstein has joined #chromium [09:23:23] *** Guest34865 has quit IRC [09:23:52] *** danno__ has joined #chromium [09:23:52] *** pamg_ has joined #chromium [09:24:00] *** ChanServ sets mode: +v pamg_ [09:24:32] *** jochen__ has joined #chromium [09:24:33] *** ChanServ sets mode: +v jochen__ [09:25:24] *** sundiamonde has quit IRC [09:25:55] *** sundiamonde has joined #chromium [09:25:59] *** feldstein has quit IRC [09:27:30] *** sundiamonde has quit IRC [09:33:26] *** romainhuet has joined #chromium [09:34:32] *** kandinski has quit IRC [09:34:58] *** Utoxin has quit IRC [09:35:44] *** Beetny has joined #chromium [09:52:30] *** Utoxin has joined #chromium [09:53:38] *** kandinski has joined #chromium [09:56:42] *** mnissler has quit IRC [10:04:26] *** drizzd has quit IRC [10:06:17] *** drizzd has joined #chromium [10:06:41] *** jeremymos has joined #chromium [10:06:41] *** ChanServ sets mode: +v jeremymos [10:08:36] *** oshima_ has joined #chromium [10:09:22] <oshima_> jeremymos: ping [10:09:28] <jeremymos> oshima_: pong [10:10:21] <oshima_> jeremymos: i'd like to check in small change http://codereview.chromium.org/1919003. this is to fix chromeos try bot problem. [10:10:28] *** luxigo has joined #chromium [10:10:34] <jeremymos> oshima_: sgtm, but please be gentle :) [10:10:47] <oshima_> yes, thanks! [10:12:58] <jeremymos> Waiting for builders to cycle green from the v8 checkin, then going to try to roll skia again... :| [10:17:58] *** luxigo has quit IRC [10:19:59] *** FeasibilityStudy has joined #chromium [10:21:24] *** oshima__ has joined #chromium [10:22:22] *** luxigo has joined #chromium [10:25:13] * jochen__ waits for the tree to catch fire [10:25:38] *** oshima_ has quit IRC [10:25:39] *** oshima__ is now known as oshima_ [10:29:05] *** FeasibilityStudy has quit IRC [10:29:50] *** mahemoff has joined #chromium [10:35:32] *** Extrapolation has joined #chromium [10:35:57] <jeremymos> WebKit Windows builders look stuck ? - http://build.chromium.org/buildbot/waterfall/builders/Webkit [10:36:51] <jeremymos> oh wait, they've just started to kick off builds for v8... [10:40:57] *** Extrapolation has left #chromium [10:42:53] *** Hypothesis has joined #chromium [10:44:12] *** wers has joined #chromium [10:45:07] *** fbarchard1 has joined #chromium [10:46:04] *** drizzd has quit IRC [10:46:04] *** jochen__ has quit IRC [10:46:04] *** selckin has quit IRC [10:46:04] *** abarth has quit IRC [10:46:05] *** fbarchard has quit IRC [10:46:05] *** vt100 has quit IRC [10:46:05] *** cleary has quit IRC [10:46:05] *** Dataforce has quit IRC [10:46:06] *** awong_afk has quit IRC [10:46:06] *** Bruners has quit IRC [10:46:06] *** felipe` has quit IRC [10:46:06] *** Docteh has quit IRC [10:46:06] *** MVXA has quit IRC [10:46:06] *** parasight has quit IRC [10:46:06] *** skenmy has quit IRC [10:47:13] *** bauerb has joined #chromium [10:47:25] *** drizzd has joined #chromium [10:47:25] *** jochen__ has joined #chromium [10:47:25] *** selckin has joined #chromium [10:47:25] *** abarth has joined #chromium [10:47:25] *** fbarchard has joined #chromium [10:47:25] *** vt100 has joined #chromium [10:47:25] *** cleary has joined #chromium [10:47:25] *** Bruners has joined #chromium [10:47:25] *** Docteh has joined #chromium [10:47:25] *** Dataforce has joined #chromium [10:47:25] *** awong_afk has joined #chromium [10:47:25] *** MVXA has joined #chromium [10:47:25] *** parasight has joined #chromium [10:47:25] *** skenmy has joined #chromium [10:47:25] *** wolfe.freenode.net sets mode: +vv jochen__ abarth [10:47:25] *** apavlov has joined #chromium [10:47:31] *** fbarchard has quit IRC [10:47:31] *** Dataforce has quit IRC [10:47:31] *** awong_afk has quit IRC [10:47:31] *** Bruners has quit IRC [10:47:35] *** awong_afk has joined #chromium [10:47:43] *** Bruners has joined #chromium [10:53:27] *** Hypothesis has quit IRC [10:55:58] *** mnissler has joined #chromium [10:57:57] *** RT|Chatzilla has quit IRC [10:58:28] *** RT|Chatzilla_ has joined #chromium [10:58:33] *** RT|Chatzilla_ is now known as RT|Chatzilla [10:59:03] <alyxuk|> Are all the performance benefits of this v5 beta release in the dev releases? [10:59:11] <alyxuk|> because the dev releases seem just as slow as normal :| [11:06:11] *** felipe` has joined #chromium [11:15:51] *** ROBOd has joined #chromium [11:15:55] *** RT|Chatzilla has quit IRC [11:16:29] *** RT|Chatzilla has joined #chromium [11:18:14] *** abarth has quit IRC [11:19:45] <jochen__> chrome frame is back onlnie [11:24:54] <jeremymos> jorlow: skia roll is checked in, fingers crossed... [11:25:18] <jeremymos> waiting for archive step of webkit builders to finish, then the rebasing fun begins :) [11:25:38] *** Adys has quit IRC [11:27:50] *** oshima_ has quit IRC [11:28:30] *** Yuvi has joined #chromium [11:29:38] *** reiko has quit IRC [11:39:19] *** Adys has joined #chromium [11:43:16] *** reiko has joined #chromium [11:44:58] *** peterdn has quit IRC [11:46:36] *** mck182 has joined #chromium [11:58:27] *** loislo has quit IRC [11:58:59] *** loislo has joined #chromium [12:08:22] *** luxigo has quit IRC [12:14:36] *** Hypothesis has joined #chromium [12:17:10] *** laranon has joined #chromium [12:19:21] *** laranon has quit IRC [12:19:27] *** laranon has joined #chromium [12:24:54] *** Hypothesis has left #chromium [12:25:04] *** wers has quit IRC [12:47:14] *** wers has joined #chromium [12:49:15] *** bulach has quit IRC [12:54:46] *** bulach has joined #chromium [13:05:06] *** wers has quit IRC [13:06:59] *** laranon has quit IRC [13:07:28] *** laranon has joined #chromium [13:07:59] *** laranon has joined #chromium [13:08:06] <maruel> jeremymos: it looks fine (but red) [13:08:20] <jeremymos> maruel: I need to update baselines now... [13:08:27] *** laranon has quit IRC [13:08:30] <maruel> looks like lot of fun [13:08:38] <jeremymos> maruel: fighting with the rebaseline script, got a while still... [13:08:53] *** laranon has joined #chromium [13:09:43] * maruel is reminded to add download layout tests from try slaves [13:10:03] <jeremymos> yep, that would certainly help :( [13:13:21] *** laranon has quit IRC [13:17:52] *** wx24 has joined #chromium [13:18:07] *** Mavericks has joined #chromium [13:18:25] <wx24> is there a context menu api planned for extensions? [13:19:04] <jeremymos> Do we use Skia for svg on Mac at all? the skia roll broke some mac tests which I wasn't expecting? [13:19:17] <maruel> jeremymos: humm [13:19:28] <maruel> I think it's "slightly" used [13:19:32] <maruel> but I'm not sure [13:23:16] *** FeasibilityStudy has joined #chromium [13:23:36] <jeremymos> maruel: that would match the small number of failures... [13:25:58] <jochen__> i clobbered the chrome frame ie8 bot again [13:26:11] <jochen__> it got stuck somehow [13:27:43] *** laranon has joined #chromium [13:29:13] <jeremymos> OK, starting to check first batch of rebaselines... [13:29:18] <jeremymos> *checkin [13:30:11] *** andrix has joined #chromium [13:41:21] *** tittiatcoke has joined #chromium [13:41:21] *** tittiatcoke has quit IRC [13:41:21] *** tittiatcoke has joined #chromium [13:55:59] *** felipe` has quit IRC [13:59:57] *** tonikitoo has quit IRC [14:03:38] *** thomasvl has joined #chromium [14:03:38] *** ChanServ sets mode: +v thomasvl [14:04:32] *** thomasvl has quit IRC [14:05:49] *** Beetny has quit IRC [14:07:57] *** Mavericks has quit IRC [14:12:51] *** taf2_ has joined #chromium [14:14:24] *** thomasvl has joined #chromium [14:14:25] *** ChanServ sets mode: +v thomasvl [14:21:02] *** FeasibilityStudy has quit IRC [14:22:57] <jeremymos> committing 300 more baselines, I'm hopefully nearly half way through.. :| [14:37:18] *** tonikitoo has joined #chromium [14:39:28] <jeremymos> maruel:ping [14:43:02] <maruel> jeremymos: pongf [14:43:22] <jeremymos> maruel: mac webkit 10.5 builder is stuck, I just asked thomasvl to kick it :) tnx [14:45:19] *** Skippythekangoo has joined #chromium [14:45:27] *** Skippythekangoo has left #chromium [14:46:28] <maruel> ok [14:46:59] *** Kunalagon has joined #chromium [14:47:15] *** pinkerton has joined #chromium [14:47:16] *** ChanServ sets mode: +v pinkerton [14:47:26] <thomasvl> jeremymos: simple cl for keystone brand code bug, ok to land? [14:47:41] <jeremymos> thomasvl: ok [14:48:05] <thomasvl> tx, in. [14:49:34] *** klawd has quit IRC [15:03:34] *** tittiatcoke has quit IRC [15:04:09] *** jchaffraix has joined #chromium [15:05:13] *** zyichi has quit IRC [15:09:21] *** luxigo has joined #chromium [15:14:49] *** cbentzel has joined #chromium [15:18:46] *** klawd has joined #chromium [15:19:37] *** miketaylr has joined #chromium [15:26:42] *** klawd has quit IRC [15:47:31] <pinkerton> earth to planet crbug.com [15:47:35] <pinkerton> come in bug system. [15:48:03] * pinkerton kicks it in the jimmy [15:49:55] * pinkerton discovers how inane our new bookmark manager is [15:50:13] <pinkerton> click the title: launch the url. click the url: select the row. [15:50:14] <pinkerton> wtf!? [15:58:20] *** enigmus has joined #chromium [16:02:37] <motownavi> pinkerton: chromium is an open-source project. feel free to take on any aspect of it that you feel needs improvement [16:02:55] <pinkerton> mmhmm [16:04:38] *** wx24 has quit IRC [16:12:16] *** erikkay has joined #chromium [16:19:33] *** luxigo has quit IRC [16:21:18] *** stuartmorgan has joined #chromium [16:21:18] *** ChanServ sets mode: +v stuartmorgan [16:22:03] *** luxigo has joined #chromium [16:26:23] *** lilmatt has quit IRC [16:26:32] *** mrossetti has joined #chromium [16:35:36] *** iPac has joined #chromium [16:36:02] *** mck182|afk has joined #chromium [16:36:29] *** mck182 has quit IRC [16:38:05] *** enigmus has quit IRC [16:41:00] *** victorw1 has joined #chromium [16:41:22] *** monreal has joined #chromium [16:41:31] *** apavlov has quit IRC [16:41:31] *** robarnold has quit IRC [16:41:32] *** adzuci has quit IRC [16:41:32] *** gavin has quit IRC [16:41:32] *** victorw has quit IRC [16:41:41] *** General13372 has quit IRC [16:42:21] *** gavin has joined #chromium [16:42:22] *** gavin has joined #chromium [16:45:41] *** dmaclach has joined #chromium [16:47:34] <jeremymos> okay, done rebaseling >1000 tests, now rolling webkit deps for cleanup, waiting for tree to cycle (hopefully something closer to green), then we can reopen... [16:48:33] *** cbentzel has quit IRC [16:49:53] *** robarnold has joined #chromium [16:49:54] *** adzuci has joined #chromium [16:52:14] *** Venom_X has joined #chromium [16:54:50] *** wers has joined #chromium [16:55:37] *** dmaclach has quit IRC [16:55:49] *** tedoc2000 has joined #chromium [16:55:55] <jorlow> jeremymos: fun day? [16:57:18] <jeremymos> jorlow: you bet ;) [17:00:26] *** andrix1 has joined #chromium [17:02:03] *** twanj has joined #chromium [17:03:53] *** andrix has quit IRC [17:07:39] *** shepazu has quit IRC [17:08:07] *** felipe` has joined #chromium [17:09:03] *** shepazu has joined #chromium [17:10:57] *** thomasvl has quit IRC [17:11:32] *** thomasvl has joined #chromium [17:11:32] *** ChanServ sets mode: +v thomasvl [17:12:30] *** thewizord has joined #chromium [17:12:45] <thewizord> why does chromium mess up it's windows size in openbox? it appears as just a small cornered box cutting off all screens [17:13:22] *** thomasvl has quit IRC [17:14:27] *** ukai_ has joined #chromium [17:14:49] *** paul_irish has joined #chromium [17:17:21] *** karpar has joined #chromium [17:19:02] *** trungl_mbp has joined #chromium [17:19:35] *** thomasvl has joined #chromium [17:20:10] *** ChanServ sets mode: +v thomasvl [17:24:22] *** jrmuizel has joined #chromium [17:24:25] *** jrforbes has joined #chromium [17:30:27] *** cmasone has quit IRC [17:31:04] <jeremymos> jorlow: ping [17:31:11] <jorlow> jeremymos: pong [17:31:23] <jeremymos> jorlow: any idea why fast/repaint/renderer-destruction-by-invalidateSelection-crash.html is failing on the buildbot? [17:31:28] <jeremymos> It'smarked in test_expectations as: [17:31:35] <jeremymos> BUG32195 : fast/repaint/renderer-destruction-by-invalidateSelection-crash.html = IMAGE+TEXT PASS [17:31:41] <jeremymos> and there's an image mismatch [17:31:58] <jorlow> You need to add IMAGE as an expectation [17:32:04] <jeremymos> ok [17:33:34] *** cmasone has joined #chromium [17:36:31] <bauerb> do the valgrind trybots run ui_tests? [17:36:57] *** wers has quit IRC [17:37:04] <trungl_mbp> 'morning, Chromium. [17:37:08] *** trungl_mbp is now known as trungl [17:37:09] *** loislo has quit IRC [17:37:10] *** ChanServ sets mode: +v trungl [17:37:42] *** jackson has joined #chromium [17:38:06] <dmazzoni> bauerb: i don't think so by default, but you might be able to enable them with flags [17:38:10] *** jackson is now known as Guest25839 [17:38:36] <jeremymos> chrome frame tests bot is borked [17:39:30] *** iPac has quit IRC [17:39:50] <bauerb> dmazzoni: i tried -t ui_tests:<filter>, but that didn't seem to work [17:40:41] *** tonyg-cr has joined #chromium [17:40:41] *** ChanServ sets mode: +v tonyg-cr [17:41:00] <maruel> dmazzoni: no you can only disable tests, not enable them [17:41:10] <maruel> bauerb: they aren't run because they are dead slow [17:41:39] <dmazzoni> ah, ok. [17:42:08] <dmazzoni> i was talking to svandebo about this last week; he intended to make it possible to enable tests [17:42:37] <bauerb> maruel: i know, i'm trying to fix a test that times out :) [17:42:37] <maruel> dmazzoni: it's doable, especially with what vandebo did [17:43:01] *** rohitrao has joined #chromium [17:43:01] *** ChanServ sets mode: +v rohitrao [17:43:03] <dmazzoni> i think it would be useful. running all ui_tests is unreasonable, but running one in particular on the trybot makes sense [17:43:22] *** Guest25839 has quit IRC [17:43:35] *** cbentzel has joined #chromium [17:43:44] <dmazzoni> i'll chat with vandebo when he gets in and see if he's planning to do it. [17:44:21] <jeremymos> jorlow: whats the difference between IMAGE+TEXT & IMAGE ? [17:44:36] <dmazzoni> bauerb: do you have a linux environment? could i help by running your ui_test under valgrind for you in the meantime? [17:44:56] *** dglazkov has joined #chromium [17:44:56] *** ChanServ sets mode: +v dglazkov [17:45:08] *** iPac has joined #chromium [17:45:29] <bauerb> dmazzoni: i have one, thanks :) [17:45:45] <dmazzoni> bauerb: ok [17:45:52] <maruel> jeremymos: fixing [17:46:01] <jeremymos> maruel: tnx [17:46:06] <jorlow> jeremymos: IMAGE means only the image fails [17:46:14] <jorlow> IMAGE+TEXT means both fail [17:46:25] <jeremymos> jorlow: ok [17:49:10] <jeremymos> jorlow: I'm getting image failures on the windows bots, but when I rebaseline I get the same image back? [17:49:17] *** markmentovai has joined #chromium [17:49:17] *** ChanServ sets mode: +v markmentovai [17:49:45] <jorlow> jeremymos: hmmmm....might be a vista/xp specific problem? [17:50:00] <jorlow> beyond that, i'm not sure what could cause it [17:50:05] <jorlow> dglazkov: u here? [17:50:10] *** snej has joined #chromium [17:50:21] <dglazkov> good morning, Chromium and jorlow and jeremymos! [17:50:25] <jeremymos> jorlow: maybe, I think I'll just mark those tests as flaky and then someone else who knows what they're doing can investigate... [17:50:33] <trungl> Good morning, dglazkov! [17:50:37] <jeremymos> dglazkov: good morning, come warm yourself by the burning tree :) [17:51:17] <dglazkov> jeremymos: alrighty, lemme look [17:51:51] *** dmaclach has joined #chromium [17:52:02] <stuartmorgan> Mac peeps: is everyone else getting a bunch of mach-lookup deny logging from the sandbox? [17:52:15] <jeremymos> stuartmorgan: yes, mucho bugs on file... [17:52:26] *** mahemoff has quit IRC [17:52:35] <stuartmorgan> jeremymos: okay, thanks. I tried to look, but code site is out to lunch [17:53:08] <dglazkov> jeremymos: looks like we need a few more baselines? [17:53:09] <jeremymos> stuartmorgan: there are a few underlying reasons - the main culprit is that webkit registers for notifications for when to flush the font cache. [17:53:14] *** trungl has quit IRC [17:53:27] <jeremymos> dglazkov: rebaseline tool is giving me the exact same results. [17:53:32] <jeremymos> xp/vista diffs? [17:53:50] <dglazkov> jeremymos: can't be. You're pulling results from the same bot [17:54:11] <jeremymos> dglazkov: I've done it twice already, never say never... [17:54:20] <dglazkov> jeremymos: are you getting a warning somewhere that an image diff tool is not installed perhaps? [17:54:25] <dglazkov> what diffs are missing? IMAGE? [17:54:37] <jeremymos> dglazkov: I got that one at the start. and compiled the tool.. yes, just IMAGE [17:54:57] <dglazkov> jeremymos: hmm. [17:56:48] *** js2 has quit IRC [18:00:05] *** dmaclach has quit IRC [18:01:40] <fear\phage> is this dog slow for anyone else? http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html down to single digit fps? [18:02:44] *** dmaclach has joined #chromium [18:03:07] *** dmaclach has joined #chromium [18:03:49] *** rohitrao has quit IRC [18:03:57] <jorlow> fear\phage: no [18:04:09] *** luxigo has quit IRC [18:04:18] <jorlow> hm...i guess if i go really crazy, yes [18:05:21] *** johnny_g has joined #chromium [18:06:17] *** skydrome has quit IRC [18:06:29] *** skydrome has joined #chromium [18:06:43] <shess> Go go jeremymos! [18:07:00] <jeremymos> shess: Got another tree you want me to burn? :) [18:07:19] *** bradbook is now known as brad[] [18:07:21] <shess> jeremymos: I've seen redder :-). [18:08:05] <jeremymos> shess: well I did my best ;) [18:08:25] *** kuchhal has joined #chromium [18:08:25] *** ChanServ sets mode: +v kuchhal [18:08:29] *** trungl_away is now known as trungl [18:08:31] *** lilmatt has joined #chromium [18:09:18] *** RT|Chatzilla has quit IRC [18:09:21] *** loislo has joined #chromium [18:10:22] <fear\phage> jorlow: yes, that's what i was doing. trying to flip as many as possible. but just draggin a single line across a wide portion is slow for me [18:12:18] *** zork has joined #chromium [18:13:05] *** Guest25839 has joined #chromium [18:13:12] <trungl> Red (and orange) are so last-year. Mauve is this year's hot colour. [18:17:09] *** Gaap has joined #chromium [18:17:12] <Gaap> hi all [18:17:38] <Gaap> i can't find the chrome os sources, can you help me? [18:17:41] <Gaap> http://src.chromium.org/git/chromiumos.git is not working [18:17:54] <sbyer> same here [18:18:02] <Gaap> :) [18:18:53] <sbyer> actually, for me, just skia.googlecode.com seems to be down [18:19:13] <trungl> sbyer: me too [18:19:15] <trungl> sigh [18:20:47] <maruel> sbyer: I was just seeing that too [18:20:49] <stuartmorgan> code.google.com is down in general [18:21:39] <trungl> this makes getting stuff done hard [18:21:44] * trungl goes to get work done elsewhere [18:21:54] <dmazzoni> gaap: while code.google.com is having issues, i'm able to pull chromiumos sources from http://src.chromium.org/git/chromiumos.git just fine; what happens for you? [18:22:15] *** thomasvl_ has joined #chromium [18:22:16] *** ChanServ sets mode: +v thomasvl_ [18:22:20] <sbyer> @marual Quick review on a depot tools tweak for git? http://codereview.chromium.org/1958002 [18:22:32] *** rafaelw has joined #chromium [18:22:41] <Gaap> dmazzoni, Error: failed to run command: svn checkout http://src.chromium.org/git/chromiumos.git /home/gianluca/chromeOS/chromiumos.git [18:22:41] *** thomasvl_ has quit IRC [18:23:12] <Gaap> path not found [18:23:28] <Gaap> i used gclient config http://src.chromium.org/git/chromiumos.git [18:23:33] <Gaap> and gclient sync [18:23:37] <jeremymos> maruel: tree is really red now... [18:24:02] <sbyer> @maruel ?Quick review on a depot tools tweak for git? http://codereview.chromium.org/1958002 ? (can't type this early) [18:25:08] <evmar_afk> sbyer: lgtm. it is sad that we have to fix all of these bugs twice [18:25:33] *** evmar_afk is now known as evmar [18:25:42] <dmazzoni> Gaap: git --version and svn --version? [18:25:59] <sbyer> @evmar been fixed before, eh? [18:26:13] <Gaap> git version 1.7.1 [18:26:13] <Gaap> svn, versione 1.6.9 (r901367) [18:26:21] <evmar> git-cl has a "diff" and we tried --no-ext-diff and then found an alternative solution when that didn't work [18:26:36] <evmar> (but it didn't work due to old git versions, so i think your fix is the correct one in today's environment) [18:26:55] <sbyer> @evmar yeah, I looked, that flag has been in git for at least two years [18:27:25] <evmar> iirc it existed in some version where it didn't actually prevent the external diff command [18:27:35] <sbyer> ugh [18:27:36] <evmar> # --no-ext-diff is broken in some versions of Git, so try to work around [18:27:36] <evmar> # this by overriding the environment (but there is still a problem if the [18:27:36] <evmar> # git config key "diff.external" is used). [18:27:36] <evmar> env = os.environ.copy() [18:27:36] <evmar> if 'GIT_EXTERNAL_DIFF' in env: del env['GIT_EXTERNAL_DIFF'] [18:28:01] <evmar> hm, and i think we used diff-index as well at one point, looks like it was chagned [18:28:10] <dmazzoni> Gaap: did gclient sync start pulling down stuff from git first before that failed svn command? when i run gclient config and then gclient sync it in a fresh directory, the first command it runs is 'git clone' [18:28:55] <Gaap> dmazzoni, nope, the only thing i suppose is that my git version doesn't use gclient cause i installed it after git [18:29:09] <dmazzoni> Gaap: gclient --version [18:29:20] * trungl was going to update git (on his Mac), but then realized that the installer is also hosted on code.google.com. [18:29:23] <Gaap> 0.3.1 [18:30:01] <dmazzoni> Gaap: the latest gclient is 0.3.4, try installing again [18:30:08] <Gaap> ok ty [18:30:12] <dmazzoni> np [18:31:08] <maruel> dmazzoni: the version number doesn't mean anything :) [18:31:11] *** tonyg-cr1 has joined #chromium [18:32:12] *** andrix1 has quit IRC [18:32:56] *** tonyg-cr has quit IRC [18:33:14] <dmazzoni> maruel: i think you're saying that the version is not updated when people update depot_tools, and that may be true - but if his version is 0.3.1, then it's definitely old, no? [18:33:24] <sbyer> @evmar I'd like to ask for a commit on that. Interesting that upload doesn't go through the same path as trychange/scm [18:33:26] <maruel> oh yes, barely usable [18:33:40] <maruel> sbyer: don't use @ otherwise irssi doesn't highlight [18:34:07] <maruel> sbyer: the reason is simple, git-cl != trychange.py [18:34:34] <maruel> and I see no way to fix that that doesn't involve breaking git-cl into bits [18:35:27] <sbyer> maruel: I see, too much refactoring to save a very small amount of code, not worth it [18:35:37] *** jeremymos has quit IRC [18:36:31] *** abarth has joined #chromium [18:36:31] *** ChanServ sets mode: +v abarth [18:36:40] *** dmaclach_ has joined #chromium [18:37:50] *** dmaclach__ has joined #chromium [18:38:00] *** dmaclach has quit IRC [18:38:00] *** dmaclach__ is now known as dmaclach [18:39:09] *** jchaffraix has quit IRC [18:39:17] *** tafryn has joined #chromium [18:39:24] <tafryn> Has anyone managed to get chromium to both block javascipt and have extensions that work? [18:40:27] <Gaap> is flash integrated in Chromium like in Chrome? [18:40:48] *** rohitrao has joined #chromium [18:40:48] <Gaap> i'm reading about last chrome build [18:40:48] *** ChanServ sets mode: +v rohitrao [18:41:22] *** lianj_ has joined #chromium [18:41:23] *** dmaclach_ has quit IRC [18:41:39] *** Singularity has joined #chromium [18:42:18] *** lianj has quit IRC [18:42:43] *** eduardop has joined #chromium [18:43:02] *** eduardop has left #chromium [18:43:17] *** kuchhal has quit IRC [18:44:18] *** kuchhal has joined #chromium [18:44:18] *** ChanServ sets mode: +v kuchhal [18:45:21] *** loislo has quit IRC [18:45:44] <evmar> Gaap: nope, only chrome [18:45:48] <Gaap> ty [18:46:20] <evmar> for chromium we leave it up to the distributor to figure out what to do with flash [18:46:56] *** luxigo has joined #chromium [18:47:12] *** Singularity has quit IRC [18:47:31] *** tonyg-cr1 has quit IRC [18:48:56] * pinkerton says nothing [18:49:24] <evmar> pinkerton: well, it looks like if you right click the chrome flash the page hangs [18:49:29] *** fear\phage is now known as fearphage [18:49:33] <evmar> pinkerton: so maybe using the adobe one is smarter at this point :( [18:49:52] *** fearphage has quit IRC [18:49:53] *** fearphage has joined #chromium [18:50:13] <pinkerton> hangs? [18:50:22] <pinkerton> like sad tabs? [18:50:29] <evmar> like "tab is not responding" [18:50:31] <evmar> (linux-only, i'm sure) [18:50:46] <evmar> none of the linux devs actually use the chrome flash though because it's 32-bit only [18:50:47] <pinkerton> heh. yeah i don't think i've seen that, but i haven' been testing internal flash [18:50:53] <pinkerton> heh [18:50:58] <pinkerton> linux is the new ipad [18:51:10] <evmar> 64-bit linux is the reverse-ipad, we can't get adobe to care :) [18:51:16] <pinkerton> :D [18:51:48] <evmar> on the other hand, porting to other architectures is exactly the sort of problem leader jobs is worried about [18:53:05] <stuartmorgan> Wow, that's a lot of red [18:53:18] <evmar> update failed (google code) [18:53:19] *** tonyg-cr has joined #chromium [18:53:19] *** ChanServ sets mode: +v tonyg-cr [18:57:02] *** andrix has joined #chromium [18:59:01] *** finnur has quit IRC [19:00:44] *** johnny_g has quit IRC [19:01:19] *** General1337 has joined #chromium [19:01:56] *** johnny_g has joined #chromium [19:02:59] *** dmazzoni_laptop has joined #chromium [19:05:36] <zork> jeremy: Is there a reason 46462 shouldn't be reverted? [19:05:40] <fbarchard1> SVN question - how do you replace a tree with a new tree.. including deletes, adds, updates and files that don't change [19:05:54] *** karpar has quit IRC [19:06:13] *** Gaap has quit IRC [19:08:09] *** bauerb has quit IRC [19:10:37] <dmazzoni_laptop> zork: the problem is a little over my head, but i don't think 46462 itself is the problem [19:10:48] <stuartmorgan> zork: code.google.com choked; nothing to do with the patch [19:10:54] *** bweinstein has joined #chromium [19:12:37] <zork> Fair enough. [19:12:53] <stuartmorgan> Someone should probably land a trivial change to cycle the bots [19:19:20] *** Bleak has quit IRC [19:20:55] *** romainhuet has quit IRC [19:22:19] *** yutak_home has quit IRC [19:23:24] *** rohitrao has quit IRC [19:25:11] <stuartmorgan> zork/dmazzoni: do you need a change landed, or is the tree waiting for dglazkov and dpranke still? [19:25:34] <maruel> fbarchard1: define "replace" [19:25:47] <maruel> fbarchard1: but I'd say: svn rm a; svn cp b a [19:26:01] <dglazkov> stuartmorgan: I don't think I am doing anything at this point -- need to cycle the tree first [19:26:51] <zork> I'm trying to get to the page to cycle the bots, but it seems to be unresponsive. [19:26:51] <stuartmorgan> zork/dmazzoni: I have an NPAPI types change that has passed compile on linux/mac/win try bots; it's not quite trivial but it's pretty close, if you want to land that. [19:27:38] <zork> stuartmorgan: What's the code review URL? [19:27:59] <stuartmorgan> zork: http://codereview.chromium.org/1910004/show [19:28:43] <fbarchard1> maruel: I pull a new folder of files from another svn depot. Some files have been added, some removed. [19:29:08] <zork> stuartmorgan: Go ahead. we can revert if there's an issue. [19:29:28] <stuartmorgan> fbarchard1: AFAIK there's no magic way to handle that :( [19:29:35] <stuartmorgan> fbarchard1: if you find one please let me know ;) [19:29:56] *** johnny_g has quit IRC [19:30:00] <fbarchard1> stuartmorgan: the only fool proof way I know is delete the tree and commit it, then add the new one [19:30:03] *** johnny_g has joined #chromium [19:30:34] <fbarchard1> fbarchard1: but I dont like having our tree committed with missing files, while the new tree of added files gets reviewed [19:30:59] <stuartmorgan> fbarchard1: I've done it with a lot of manual work and diff -rq [19:31:24] <fbarchard1> stuartmorgan: so I do windiff looking for which files are added / removed. Its error prone [19:31:49] <stuartmorgan> zork: pushed [19:31:52] *** feldstein has joined #chromium [19:32:05] *** cbentzel has quit IRC [19:32:23] <stuartmorgan> Not sure what's up with the bots that don't seem to be doing anything though [19:32:55] <fbarchard1> stuartmorgan: for the new files, its safe to say svn add * on each folder [19:33:09] *** Venom_X is now known as Venom_lnch [19:33:32] <fbarchard1> stuartmorgan: so its mainly the deletes I dont know how to do. files that were in the old tree, but got renamed or removed... I just want it clean after the update [19:34:43] <stuartmorgan> fbarchard1: yep; diff -rq until there's nothing in the target tree that's not in the source is the best way I know of [19:34:44] *** csilv has joined #chromium [19:37:23] *** rohitrao has joined #chromium [19:37:23] *** ChanServ sets mode: +v rohitrao [19:38:37] <markmentovai> dglazkov: what are we expecting of the tree? [19:39:24] <dglazkov> markmentovai: webkit things turn green(ish) [19:39:51] <dglazkov> the redness of other things is not related to what jeremymos was doing [19:40:17] <stuartmorgan> markmentovai: do you know why so many bots seem to just be twiddling their thumbs? [19:40:37] <markmentovai> the tree started turning red over an hour and a half ago with no apparent chickens to cure the redness. where's that work being done? [19:40:48] <markmentovai> stuartmorgan: the builders have to compile your change before the testers can pick it up and turn red [19:40:56] <dglazkov> markmentovai: that's because of the codesite fails [19:41:02] <stuartmorgan> markmentovai: ah, right [19:41:21] <markmentovai> oh, so cruddy time to make big changes :( [19:41:29] *** abarth has quit IRC [19:41:36] <markmentovai> codesite's been up for about an hour for me. not the case elsewhere? [19:41:54] <dglazkov> markmentovai: I think it's working now [19:42:08] <dglazkov> we'll see how stuartmorgan's r46463 is going to fare. [19:42:37] *** cbentzel has joined #chromium [19:42:38] <markmentovai> ok. let's update the tree status, then. [19:42:45] <markmentovai> dglazkov: do we still need "webkit greening" listed in the status? [19:42:47] <markmentovai> (i'm guessing we do) [19:43:27] <dglazkov> markmentovai: yeah. we'll need to make sure that the expectation tweak jeremymos landed actually worked. The codesite borkage didn't let us see that. [19:43:36] <markmentovai> got it [19:44:02] <markmentovai> it's all clear now. i'll update the status so that others aren't all like "huh?" [19:44:04] <dglazkov> but I wouldn't close the tree on that [19:44:51] *** feldstein has quit IRC [19:47:43] *** General13372 has joined #chromium [19:49:24] *** sbyer is now known as scottbyer_afk [19:49:31] <zork> Looks like we're getting more update issues. [19:51:31] *** abarth has joined #chromium [19:51:31] *** ChanServ sets mode: +v abarth [19:51:32] *** General1337 has quit IRC [19:53:09] <stuartmorgan> Maybe the trees are damaged, if the previous checkout died in the middle? [19:53:27] <markmentovai> no, it (annoyingly) grabs a new copy of everything [19:53:35] <rohitrao> are we planning to close the tree for appengine downtime? [19:54:47] <markmentovai> i asked the bots that had trouble updating on stuart's change to try again [19:56:22] *** urbanape has quit IRC [19:57:17] <maruel> stuartmorgan: markmentovai: well, the tree is damaged, then it grabs a new copy of everything [19:57:26] *** Singularity has joined #chromium [19:58:04] <markmentovai> right, it's annoying in this case because the working copies weren't damaged, the servers were just screwed [19:58:23] *** cying has joined #chromium [19:58:30] <maruel> yes but we got no way to tell this to buildbot [19:58:37] <markmentovai> right [20:00:46] <maruel> "update failed, build must be canceled but you may reuse it next time". It a recipe for faillure [20:00:58] <maruel> It's such a failure it has 2 l [20:01:25] *** markmentovai_ has joined #chromium [20:01:25] *** ChanServ sets mode: +v markmentovai_ [20:02:44] *** markmentovai has quit IRC [20:02:44] *** markmentovai_ is now known as markmentovai [20:02:45] *** cbentzel has quit IRC [20:02:48] *** zloidemon has quit IRC [20:03:33] *** dave_levin has joined #chromium [20:03:44] *** feldstein has joined #chromium [20:04:58] *** urbanape has joined #chromium [20:05:32] *** dmazzoni_laptop has quit IRC [20:06:06] <stuartmorgan> I have to run an errand; if for some reason my chance kills things when the bots finally deign to build it, feel free to revert without mercy [20:06:29] <pinkerton> by saying that, you're doomed [20:07:50] *** feldstein has quit IRC [20:19:07] *** kwinz2 has joined #chromium [20:19:24] *** Guest25839 has quit IRC [20:21:45] <evmar> http://i.imgur.com/50ohc.png [20:21:46] <evmar> we are awesome. [20:23:12] <maruel> evmar: looks much better with lanczos filter [20:24:41] *** feldstein has joined #chromium [20:24:42] *** AaronMT has joined #chromium [20:26:47] *** tonyg-cr has quit IRC [20:27:52] *** markmentovai has quit IRC [20:27:57] *** markmentovai has joined #chromium [20:27:58] *** ChanServ sets mode: +v markmentovai [20:29:44] *** js2 has joined #chromium [20:30:45] *** callumlinden has joined #chromium [20:30:49] *** callumlinden has left #chromium [20:33:43] *** phajdan-jr has joined #chromium [20:33:43] *** ChanServ sets mode: +v phajdan-jr [20:33:59] *** Ronis_BR has joined #chromium [20:34:05] <Ronis_BR> hi all [20:34:20] <Ronis_BR> how can I enable the plugin npwrapper.nppdf.so to view PDF files using acrobat reader? [20:34:40] <Ronis_BR> the file is on the plugins folder, but about:p?ugins isn't showing it [20:35:21] <evmar> ronis_br: it doesn't work; you can star http://code.google.com/p/chromium/issues/detail?id=19587 [20:36:10] *** bent-mozilla has joined #chromium [20:36:15] <Ronis_BR> evmar: what? [20:36:23] <Ronis_BR> evmar: I don't see anything related with this bug [20:36:37] <evmar> "Chromium Fails to call adobe to open PDFs files" [20:37:14] <Ronis_BR> this is another bug :D [20:37:19] <phajdan-jr> jungshik_: ping [20:41:21] <markmentovai> zork, dmazzoni, dglazkov: i?ve made the tree green. i?m reopening. [20:43:01] <Ronis_BR> evmar: there the plugin is loaded at least [20:43:04] <Ronis_BR> evmar: here it isn't [20:43:13] <evmar> it is the same bug, trust me [20:43:20] *** dmazzoni_laptop has joined #chromium [20:43:40] <zork> markmentovai: Sounds good. [20:43:44] <zork> Thanks! [20:43:54] *** enigmus has joined #chromium [20:47:57] *** jamesr has joined #chromium [20:48:22] <Ronis_BR> evmar: ok so [20:48:23] *** skejoe has joined #chromium [20:48:26] <Ronis_BR> evmar: thanks :D [20:48:50] <markmentovai> nirnimesh: thanks for the zombie pyauto test [20:48:52] <markmentovai> that was really cool :) [20:49:15] <skejoe> Hi. I'm trying to compile chromium, but I get this: http://www.pasteall.org/12940 [20:49:21] <skejoe> Any ideas what to do? [20:49:53] <nirnimesh> markmentovai: you're welcome, but rohitbm wrote it. [20:50:03] <evmar> skejoe: where did you get the code from? [20:50:05] <markmentovai> but he isn't here now [20:50:29] <nirnimesh> will convey your thanks [20:50:45] <skejoe> evmar: svn trunk - http://src.chromium.org/svn [20:51:09] <Ronis_BR> evmar: where can I set the default application so? [20:51:18] <Ronis_BR> evmar: for chromium open adobe externally? [20:51:21] <markmentovai> maruel: what?s ?fatal error RC1109: error creating c:\b\slave\webkit-dbg-builder\build\src\webkit\Debug\obj\test_shell_tests\test_shell_tests.exe.embed.manifest.res? mean? (webkit builder dbg) [20:52:24] <evmar> stuartmorgan: ^^^ see skejoe comments [20:53:48] <jungshik_> phajdan-jr: pong [20:55:00] <phajdan-jr> jungshik_: I've uploaded an updated patchset to http://codereview.chromium.org/1857002/show, but I think it may be more effective to discuss it on irc [20:55:48] *** tonyg-cr has joined #chromium [20:55:49] *** ChanServ sets mode: +v tonyg-cr [20:56:01] <maruel> markmentovai: it means nothing good nor worthwhile [20:56:19] <evmar> skejoe: hm, it seems to include the proper headers here (npapi_extensions.h in that file) [20:56:24] <jungshik_> ok. i've just read your comment. [20:56:28] <evmar> skejoe: oh wait, no, i get it [20:56:31] <phajdan-jr> jungshik_: what do you think about not falling back to the system encoding? What I don't like in it is guessing a lot and trying to reverse it later, which seems error prone to me. [20:56:36] <evmar> skejoe: what compiler are you using? [20:56:37] <Ronis_BR> evmar: isn't it possible? [20:56:44] <maruel> markmentovai: just rebuild another time [20:56:49] <markmentovai> maruel: done and done. [20:56:50] *** Beetny has joined #chromium [20:57:08] <evmar> Ronis_BR: http://www.chromium.org/developers/linux-technical-faq see "Q. How do I control what program Chromium uses to open downloads?" [20:57:14] <jungshik_> i'm not happy about that, either. [20:57:55] <Ronis_BR> evmar: xdg-open never worked here :D [20:58:04] <skejoe> evmar: gcc 4.5.0 I think, although I might have tried to use clang once. [20:58:06] <Ronis_BR> evmar: but thanks [20:58:13] <phajdan-jr> jungshik_: so, I think that what the code is going to do after this patch (an error message + possibility to view raw listing) would be fine. Would you have major comments about that? [20:58:16] <skejoe> evmar: src/Makefile says gcc though. [20:58:42] <evmar> skejoe: gcc --version? [20:59:00] <jungshik_> phajdan-jr: let me digest your latest cl before commenting further [20:59:00] *** taf2 has quit IRC [20:59:00] *** taf2_ is now known as taf2 [20:59:01] <skejoe> evmar: gcc (GCC) 4.5.0 [21:00:52] *** mpcomplete has joined #chromium [21:00:53] *** ChanServ sets mode: +v mpcomplete [21:01:39] <evmar> skejoe: i opened a bug for you http://code.google.com/p/chromium/issues/detail?id=43341 [21:01:51] <evmar> skejoe: looks like a problem (our problem, not yours) with gcc 4.5 [21:02:06] <skejoe> evmar: great. Thanks! [21:02:13] <evmar> sorry for the trouble [21:02:40] <evmar> skejoe: if you're a programmer you can delete all of the problematic cases in the switch statement [21:02:46] <evmar> skejoe: that will almost certainly be harmless [21:02:54] <evmar> or cast to NPNVariable [21:03:02] <skejoe> evmar: okay, thanks, will do. [21:03:06] *** dmazzoni_laptop has quit IRC [21:03:44] *** Guest25839 has joined #chromium [21:04:18] *** enigmus has quit IRC [21:05:11] <pcgod> there will be more "errors" with gcc 4.5 if you compile with -Werror... [21:05:51] <phajdan-jr> pcgod: if you'd like to contribute, this looks like a good source of patches (porting to gcc 4.5) [21:06:01] <pcgod> because it doesn't like passing 0 to functions which expect a pointer or setting int variables to NULL [21:06:11] <pinkerton> markmentovai: is the comment in that method still relevant? [21:06:26] <evmar> pcgod: yeah, i'd happily review patches in this area [21:06:36] <markmentovai> pinkerton: i don't really know [21:07:38] *** dpranke has joined #chromium [21:07:39] *** ChanServ sets mode: +v dpranke [21:07:42] <markmentovai> pinkerton: the views and gtk impls do something [21:08:29] <pinkerton> so maybe that's a long ago forgotten feature that should just be removed outright? [21:08:37] <evmar> pinkerton: what are you talking about? [21:09:47] <pinkerton> evmar: http://codereview.chromium.org/1960002/show [21:10:10] <markmentovai> pinkerton: removed? the views and gtk impls use that call [21:10:12] *** andrix has quit IRC [21:10:21] <markmentovai> it may be the case that we don't need to at all, i'm not sure [21:10:23] <dpranke> chase: ping [21:10:35] <markmentovai> i'm mostly concerned with getting rid of the log spew [21:10:58] <evmar> this is when you hit ctl-shift-b on the NTP i think [21:11:41] <pinkerton> but the comment syas mac doesn't support a bookmark bar at a different size on the ntp. why not? [21:11:52] *** luxigo has quit IRC [21:11:59] <pinkerton> and uses words like "yet" [21:12:08] <pinkerton> which implies one day we will, but clearly we have no plans [21:12:11] <evmar> iirc newer mocks i saw had no bookmark bar on the ntp [21:12:18] <evmar> but i am like three people removed [21:13:11] <markmentovai> pinkerton: 'k, how 'bout i file a bug for it and ref the bug in the comment? [21:13:23] <pinkerton> ok [21:14:06] <pinkerton> this is probably why we never removed the spew in teh first place, because figuring out what to do with the comment was too hard :) [21:14:28] <evmar> i would like to run with sync enabled, because it helps me flush out bugs in that area, [21:14:33] <evmar> but it spews so much crap to the console i always turn it off [21:14:42] <evmar> so now whenever i want to sync, i enable sync, get the update, then turn it off again [21:17:58] <willchan> akalin: are you using gcl or git? whichever it is, your settings are off. you should cc chromium-reviews at chromium dot org instead of @googlegroups.com [21:22:09] *** peterdn has joined #chromium [21:23:30] *** moblin_ has joined #chromium [21:25:31] <moblin_> how do I get off the secret list that makes chromium devs ignore my bug reports? :) or what is the usual timeframe to have bug reports noticed [21:26:10] <evmar> moblin_: we have over 13000 open bugs, if you really want them fixed quickly you probably should write patches :) [21:26:30] <evmar> moblin_: it helps to tag them properly (linux/mac) if they are platform-specific [21:27:18] <moblin_> well my linux bug reports were usually noticed within a day. [21:27:32] <moblin_> i meant like a status update that a googler checked the bug report [21:27:47] <moblin_> not even talking about a patch [21:29:20] <pinkerton> markmentovai: the select bug isn't p0, i'm looking at it now [21:29:36] <pinkerton> markmentovai: should i flip it, or will that only piss off anthony? :) [21:29:39] <markmentovai> we ought to make it p0 [21:29:45] <jorlow> moblin_: if someone takes a serious look at something, they'll generally comment on it [21:29:46] <markmentovai> it shouldn't, it's not 375 [21:29:56] <markmentovai> i think he's 375-focused now [21:29:56] <pinkerton> doing so now [21:31:05] <pinkerton> done [21:31:08] <jungshik_> phajdan-jr: i've added a comment to the cl. looks good except for one issue I wrote about. [21:31:24] <phajdan-jr> jungshik_: thanks, let me comment on irc on those to get a quicker turnaround [21:31:49] <phajdan-jr> jungshik_: so, if DetectEncoding would return ASCII, we would pass the IsStringUTF8 check. [21:32:51] <moblin_> jorlow: just want to make sure they didn't get lost in the system or so. imo there should be some kind of status update that someone from the chromium team read the bug. regardless of how they classify the bug report. just that it was noticed. [21:33:14] <jorlow> moblin_: that takes time :-) [21:33:17] <willchan> moblin_: if it gets triaged, then there will be a status update. [21:36:24] <markmentovai> aboodman: bustage looks like you [21:38:25] *** loislo has joined #chromium [21:39:54] *** bent-mozilla has quit IRC [21:40:21] <markmentovai> zork, dmazzoni: bustage looks like aboodman [21:42:03] *** bent-mozilla has joined #chromium [21:42:17] *** Venom_lnch is now known as Venom_X [21:44:14] <phajdan-jr> jungshik_: what do you think about the above? Would you prefer me to say DCHECK that encoding is not empty (because it really shouldn't at that point)? [21:44:39] *** int3 has joined #chromium [21:44:45] *** kwinz2 has quit IRC [21:49:34] <dmazzoni> markmentovai: will ping, thanks [21:49:39] <markmentovai> dmazzoni: too late, i already fixed it [21:49:56] *** loislo_ has joined #chromium [21:50:12] *** iPac has quit IRC [21:50:30] <dmazzoni> markmentovai: thanks! [21:50:39] <markmentovai> dmazzoni: 45 minutes after the tree closes itself is not an acceptable response time :( [21:51:00] <moblin_> jorolow: what is a reasonable timeframe to complain here that a particular hasn't been noticed yet? :) [21:51:06] *** feldstein has quit IRC [21:51:11] <markmentovai> zork, aboodman too. and i don't even see dpolukhin. [21:53:01] *** loislo__ has joined #chromium [21:53:06] *** feldstein has joined #chromium [21:53:19] *** loislo has quit IRC [21:53:19] *** loislo__ is now known as loislo [21:53:24] *** sebmarkbage has joined #chromium [21:54:19] <dmazzoni> markmentovai: i'm sorry, not trying to ignore my responsibilities. i checked just before i went to get lunch, the timing was really bad. next time i can try to coordinate with other sheriffs to stagger away periods. [21:54:28] <markmentovai> dmazzoni: that's more like it. thanks. [21:55:56] *** loislo_ has quit IRC [21:56:05] <dmazzoni> markmentovai: dpolukhin is in russia, so his hours are totally different. i synced with him when i got in this morning. the tree was closed most of the morning due to jeremy's syncing of skia, and since then i've been on chat with zork. [22:01:01] *** zloidemon has joined #chromium [22:03:35] *** feldstein has quit IRC [22:05:43] <zork> Yeah, looks like we all went to lunch just before it broke... [22:06:01] <markmentovai> zork: gotta coordinate lunches [22:06:28] *** nierob has joined #chromium [22:06:44] <akalin> is there any guidance on whether to use DISALLOW_COPY_AND_ASSIGN on abstract classes? [22:06:50] <akalin> i'm leaning towards 'no' [22:07:24] <markmentovai> akalin: not necessary [22:07:33] *** skejoe has quit IRC [22:08:24] <akalin> markmentovai: okay [22:10:22] *** luxigo has joined #chromium [22:12:15] *** cbentzel has joined #chromium [22:13:54] *** Zedde is now known as Varazir [22:14:14] *** s|k_ has joined #chromium [22:14:15] *** s|k_ has joined #chromium [22:16:03] *** dimich has left #chromium [22:16:48] *** jrforbes has quit IRC [22:17:58] *** nierob has quit IRC [22:18:07] *** nblracer has quit IRC [22:18:38] *** sundiamonde has joined #chromium [22:20:12] <jamesr> the bug tracker is 502'ing on me, known issue? [22:21:16] <willchan> yeah, there's a bug on it, check crbug.com/6742 [22:21:31] <dglazkov> :D [22:21:45] <jamesr> willchan: >< [22:24:08] *** taf2_ has joined #chromium [22:24:08] *** moblin_ has quit IRC [22:25:07] <evmar> willchan++ [22:26:13] *** Zaba has quit IRC [22:27:44] <zork> appengine says we're not allowed to open the tree anymore. [22:27:49] *** inferno-sec has joined #chromium [22:29:27] *** phajdan-jr has quit IRC [22:29:30] *** albertb has joined #chromium [22:29:54] <akalin> ugh, broken win trybots [22:31:23] <akalin> ugh broken everything D: [22:32:45] <zork> Yeah, Appengine breaking hurts us. [22:34:35] <jamesr> the world is down [22:34:52] <aboodman> this is odd. build.chromium.org -> ctrl+f "revert" -> not found !? [22:34:53] <maruel> jamesr: no, just Google infrastructure [22:35:04] <jamesr> isn't that what the world runs on? [22:35:05] <maruel> Google != world [22:35:10] <jamesr> waaaaaaht [22:35:20] <maruel> jamesr: you should take your comm courses again [22:35:56] <maruel> It happens I'd like to check-in too :( [22:39:54] *** happygrue_ has joined #chromium [22:40:18] *** Adys is now known as Shirik [22:40:25] *** Shirik is now known as Adys [22:40:56] *** loislo has quit IRC [22:42:05] *** luxigo has quit IRC [22:42:07] *** skydrome_ has joined #chromium [22:42:11] *** skydrome has quit IRC [22:42:41] *** skydrome_ has quit IRC [22:42:51] <dpranke> guess this is a good way for the builders to catch up ... [22:43:08] <zork> Except that it breaks gclient, too. [22:43:23] <dpranke> so, git cl just worked for me. I think appengine might be back? [22:43:29] <zork> Yup. [22:43:31] *** skydrome has joined #chromium [22:43:49] <dpranke> time to reopen and break things? I've got a webkit roll all lined up ;) [22:44:07] <dmazzoni> Tree is open :) have fun... [22:44:55] <jungshik_> phajdan-jr: sorry i was away. i think DCHECK should suffice. [22:47:41] <markmentovai> zork, dmazzoni: might be a good idea to keep the tree closed while codesite is still down [22:48:05] <markmentovai> or at least say ?don?t roll googlecode DEPS? [22:48:13] <zork> Sure, I'll close it. [22:49:21] *** jcivelli has quit IRC [22:49:47] <rohitrao> how are we opening/closing the tree if appengine is readonly? [22:49:57] <rohitrao> or is appengine back? [22:50:00] <zork> I read-writed [22:50:01] <markmentovai> seems up [22:50:03] <zork> It8 [22:50:07] <zork> ** [22:50:16] *** AaronMT has quit IRC [22:50:37] *** coyo has joined #chromium [22:51:58] *** ROBOd has quit IRC [22:52:53] *** Beetny has quit IRC [22:53:07] *** eseidel has joined #chromium [22:54:32] *** MetaMucil has quit IRC [22:55:44] *** monreal has quit IRC [22:56:26] *** fishd has joined #chromium [22:56:26] *** zloidemon has quit IRC [22:56:41] *** ChanServ sets mode: +v fishd [22:57:12] <dmazzoni> markmentovia, zork: unless there's an ETA on the codesite fix, maybe it'd be better to leave the tree open except for rolling googlecode deps. all of the bots seem to be up-to-date except for Chrome Frame Tests (ie7) [22:57:37] *** miketaylr has quit IRC [22:57:38] <dmazzoni> markmentovai: ^^^ (sorry, typo) [22:58:14] <markmentovai> dmazzoni: that?s fine [22:58:28] <markmentovai> obviously, if things start to fall apart, you can reclose [22:59:33] <dmazzoni> ok, tree is open (we'll see how this goes) [23:02:37] *** lilmatt has quit IRC [23:03:42] *** roc has joined #chromium [23:07:48] <pkasting> Ugh, codesite sooo flaky [23:07:52] *** rbellamy has joined #chromium [23:08:31] <rbellamy> I'm looking for some guidance on google gflags, would this be the place to ask, or is there another channel I should use? [23:09:27] <eglaysher> rbellamy: considering that chrome doesn't use glfags, and most of the google engineers here work only on chrome, no. [23:10:33] <rbellamy> I thought chrome used breakpad?.... must have been mistaken... [23:10:41] *** feldstein has joined #chromium [23:10:53] <eglaysher> rbellamy: it's possible to use breakpad w/o gflags. [23:10:58] <rbellamy> eglaysher, you have a suggestion for where I could go? [23:11:00] <rbellamy> oic [23:11:05] <rbellamy> hmmm [23:11:17] <eglaysher> I have no idea. [23:11:46] <rbellamy> k, thanks anyway, preciate your time [23:12:13] <dmazzoni> rbellamy: google-gflags at googlegroups dot com? [23:12:27] <fta> evmar, do you know if there's already a bug about flash videos (like embedded youtube in blogs) where all controls are unusable? [23:12:58] <rbellamy> dmazzoni, I'm being impatient. hoping for something right now.... :) [23:13:02] <evmar> fta: is this the one where they're not clickable (again)? [23:13:07] <rbellamy> but that's a good suggestion, nonetheless [23:14:47] <stuartmorgan> fta: is the page zoomed? [23:14:58] <fta> stuartmorgan, no [23:16:33] <dmazzoni> looks like the mac builders are having problems? [23:17:20] <evmar> fta: you missed my question i think [23:18:15] <fta> evmar, yes, like the sound slider in youtube, you can't reach it, it disappears when hovered [23:18:45] <pkasting> Fixing compile failure [23:18:48] <pkasting> it is simple [23:19:13] <dmazzoni> pkasting: ok, updating tree status [23:19:58] <evmar> fta: yes, it's nspluginwrapper again :~( [23:20:02] <evmar> fta: i fixed it on the beta branch [23:20:10] <pkasting> Fix is in [23:20:25] <evmar> fta: i noticed that the ubuntu one is obsolete now, i was gonna wait a few more days before asking you about it [23:20:43] <fta> oh [23:23:13] <fta> nspluginwrapper is evil :( [23:24:04] <fta> well, youtube html5 controls are broken too [23:24:09] <evmar> basically we do, when starting up plugins: (1) set the flag that works around flash/gtk bug; (2) init gtk; (3) start plugin. but it turns out (2) clears the flag, which means when nspluginwrapper starts up in (3) it doesn't get the flag [23:25:11] <pkasting> Reopened tree as compile went green [23:25:12] *** thomasvl has quit IRC [23:31:16] *** kinuko has joined #chromium [23:35:08] *** bent-mozilla has quit IRC [23:41:55] *** bent-mozilla has joined #chromium [23:44:05] *** pinkerton has quit IRC [23:44:38] <dmazzoni> codesite seems to be up for me...anyone know if the problems are fixed or if we should expect continued flakiness? [23:44:38] *** lilmatt has joined #chromium [23:46:50] <markmentovai> the flakiness was unexpected to begin with :( [23:48:57] <dmazzoni> markmentovai: they don't seem to have a status page, right? [23:49:09] <markmentovai> not that i know of [23:53:16] *** Kunalagon has quit IRC [23:57:10] *** jamesr has quit IRC [23:57:18] <zork> I can't tell if this red on the tree is real or not... [23:59:47] *** dmazzoni has quit IRC