[00:01:36] *** krisr_mbp has joined #chromium
[00:02:07] *** abarth_ has joined #chromium
[00:02:07] *** ChanServ sets mode: +v abarth_
[00:02:20] *** abarth_ has quit IRC
[00:05:48] *** alyxuk has quit IRC
[00:05:48] *** alyxuk has joined #chromium
[00:06:04] <shess> jrg: I am idiot.
[00:06:22] <jrg> shess: I prefer the term stupidhead, but tomato tomato.
[00:06:26] <shess> [WRT my cl.  inverted test in two seconds.]
[00:06:39] <shess> you say tomato, i say tomato?  Yes, I can see that.
[00:06:49] <jrg> shess: which CL?
[00:07:18] <shess> jrg: the one I sent you.  I threw off the exact inverse of the test I wanted.
[00:08:04] <jrg> shess: looking...
[00:08:18] <shess> jrg: don't look!  I'm not ready!
[00:08:20] <rsesek> arv: ping
[00:08:32] <arv> rsesek, pong
[00:08:36] * jrg peekin...
[00:09:04] *** macaco has joined #chromium
[00:09:04] *** Venom_X is now known as Venom_brb
[00:09:10] <rsesek> arv: neb's CL started causing valgrind failures; suppress or drover? first failing run: http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/3739
[00:09:15] *** jrabbit has left #chromium
[00:09:16] <rsesek> it happens on linux and mac
[00:09:58] <macaco> Is SRWare Iron really as safe as they say? I heard the guy who made it only did it to get internet famous or something.
[00:10:13] <jamesr> there's no famous like internet famous
[00:10:13] <jrg> rsesek: if memory stop, drover.
[00:10:14] <akalin> macaco: iron is a joke, basically
[00:10:24] <rsesek> jrg: it's an unconditional jump
[00:10:34] <akalin> i remember someone diffed with the chromium build and found that most of the changes were replacing 'Chromium' with 'Iron'
[00:10:37] <jrg> rsesek: if dangerous, drover.  (If you can't easily tell, assume dangerous)
[00:10:43] <arv> rsesek, I think reverting is due
[00:10:44] <jrg> rsesek: if looks like quick fix, ping him and say HEY
[00:10:52] <rsesek> jrg: he's not in IRC
[00:10:53] <jrg> is he in channel?
[00:11:05] <akalin> b
[00:11:07] <akalin> oops
[00:11:09] <macaco> wasn't there a story about he came in here asking for legal advice or something?
[00:11:11] <rsesek> drover ? valgrind is just as important as the other bots
[00:11:13] <jrg> rsesek: then revert.  I'll ping him and tell him to go to bed without, uh, go to channel.
[00:11:16] <akalin> macaco: something like that, yeah
[00:11:34] <arv> reverting
[00:11:43] <macaco> Is there a log of it? I'm curious how much a douch he is
[00:11:44] <rsesek> arv: you got it already?
[00:11:50] <arv> yup
[00:11:52] <rsesek> k thanks
[00:12:07] <rsesek> markmentovai: http://neugierig.org/software/chromium/notes/2009/12/iron.html
[00:12:10] <rsesek> damn
[00:12:11] <rsesek> macaco: http://neugierig.org/software/chromium/notes/2009/12/iron.html
[00:12:12] <akalin> macaco: it's on a blog somewhere, lemme find it
[00:12:18] <akalin> yeah there you go
[00:12:19] <jrg> rsesek: thanks for keeping eye on tree.  There is no shame in being reverted from time to time.
[00:12:31] <rubenbb1> macaco: http://neugierig.org/software/chromium/notes/2009/12/iron.html
[00:12:47] <macaco> wow 3 links at once. ya'll must really not like him.
[00:12:48] <rubenbb1> ah man, rsesek beat me :|
[00:12:50] *** kjg has quit IRC
[00:12:58] <akalin> he wasn't even doing it for internet fame
[00:13:04] <akalin> for adsense money, which is pretty ironic if you think about it
[00:13:11] <akalin> haha iron....ic
[00:13:14] <shess> jrg: OK, fixed.  Sigh.
[00:13:37] <rsesek> jrg: yea; though I feel silly for reverting valgrind issues sometimes, so I just suppress instead (if it's just a leak)
[00:14:05] <jrg> rsesek: depends on what it is.  As an example, the one I landed recently was a leak of objects only allocated in the test itself, so safe to revert.
[00:14:17] <jrg> rsesek: but leak of an fd or something is not good.
[00:14:43] <rsesek> jrg: true; though determining if it's leak in test vs. actual code isn't the job of the sheriff/helpers
[00:14:57] <jrg> rsesek: you are right... which is why we chill in channel
[00:15:20] <jrg> shess: ha ha ha I see your funny CL now
[00:15:28] *** tonikitoo has quit IRC
[00:16:52] *** macaco has quit IRC
[00:17:03] <albertb> rsesek: Can I send you a patch for the leak?
[00:17:22] <rsesek> albertb: I'd get the original reviewer if possible, I'm not familiar with the code of your CL
[00:17:35] <rsesek> unless it's like blatantly obvious
[00:18:17] *** General13372 has joined #chromium
[00:20:51] <rsesek> albertb: I'd also suggest running your patch through the linux_valgrind trybot to verify
[00:21:26] <albertb> rsesek: yep, just submitted to the trybot
[00:21:31] <rsesek> cool :)
[00:22:20] *** General1337 has quit IRC
[00:27:17] *** Zuccace has joined #chromium
[00:27:26] *** Zucca has quit IRC
[00:27:28] *** markmentovai has quit IRC
[00:30:41] *** neb_ has joined #chromium
[00:39:13] <shess> do they make ANY attempt to keep xib files stable between saves?  I know it's XML and all, but I'd still like to have some confidence that my trivial change was a trivial change.
[00:39:24] <rsesek> shess: nope!
[00:39:42] <jrg> shess: ha ha ha ha
[00:40:10] <rsesek> shess: I've gotten IB to regenerate new reference IDs for objects between saves where nothing changed. it's like black magic
[00:40:17] <shess> rsesek: favorite switch was changing "13" to "1.300000e+01".  Yum.
[00:40:25] <rsesek> shess: that's a 10.5/10.6 issue
[00:40:34] <shess> rsesek: yeah, and I'm on 10.5...
[00:40:52] <rsesek> yea 10.5 loooovess to do that
[00:40:54] <shess> maybe I should get a 10.6 users to re-save my files to minimize this :-).
[00:41:17] <rsesek> 10.6 also changes the way they store key equivs and nscolors (base64 vs something else I can't remember)
[00:41:51] *** TabAtkins has quit IRC
[00:41:55] *** TabAtkins_ has joined #chromium
[00:42:46] *** kellegous has quit IRC
[00:43:03] *** asargent has left #chromium
[00:53:48] *** Zuccace has quit IRC
[00:53:51] *** Zucca has joined #chromium
[00:57:05] *** Venom_brb is now known as Venom_X
[00:57:06] *** fishd has joined #chromium
[00:57:06] *** ChanServ sets mode: +v fishd
[00:57:18] *** neb_ has quit IRC
[00:58:40] *** slowpoison has joined #chromium
[00:59:09] *** slowpoison has quit IRC
[01:05:19] *** victorw has joined #chromium
[01:05:34] <rohitrao> shess: we keep meaning to make a 10.5-only rules for xib files
[01:05:48] <rsesek> rohitrao: that's no good
[01:06:01] <rohitrao> rsesek: neither is constantly switching back and forth :)
[01:06:22] <rohitrao> we should really pick whichever toolchain most people use and then enforce that, and that only
[01:06:30] *** urbanape has quit IRC
[01:06:49] <rsesek> rohitrao: I for one would then be unable to make changes to XIBs. that seems silly and arbitrary. XIB changes don't make sense anyways, so I don't see why it matters if these values change in between CLs
[01:06:52] <shess> rohitrao: we should file a bug against Apple to fix their darn tools.  if the project is marked 10.5, it shouldn't do 10.6 stuff.  dammit.
[01:06:56] *** tonyg has quit IRC
[01:07:15] *** tonyg_ has joined #chromium
[01:07:39] <rohitrao> rsesek: 1) you edit a xib.  2) I edit the same xib.  3) you check in your changes.  4) I sync, clean merge.  or was it?
[01:08:09] <rohitrao> rsesek: it's totally possible to have a clean sync that leaves you with a corrupted xib file, and svn has no way of knowing
[01:08:10] <rsesek> rohitrao: I don't think XIBs can ever be trusted to merge cleanly
[01:08:46] <rsesek> rohitrao: if two people are editing the same XIB, all the tools in the world won't help them IMHO. that's something that can only be solved by communication or manually reverting and reapplying changes
[01:09:47] <rohitrao> I would also be happy with something that forces you to revert if it sees a xib file merge
[01:09:47] <rohitrao> but we really are getting bitten by the constant back and forth between 10.5 and 10.6
[01:09:48] <rohitrao> and I wouldn't at all be surprised if there are lingering bugs in a bunch of the xib files
[01:09:56] <rsesek> rohitrao: two alternatives to that would be 1) svn lock the XIB you're editing for in-progress CLs or 2) manually only add parts of the diff that are relevant (i.e. git add -p ? staging only specific diff hunks)
[01:10:24] <rohitrao> MainMenu.xib had some weird corruption that only showed up if you clicked on a specific menu entry
[01:10:30] <rohitrao> and the corruption happened so long ago that it was hard to work back and fix it
[01:10:48] <rsesek> rohitrao: that may have been my fault (oops!)
[01:10:56] <rohitrao> :)
[01:11:10] <rsesek> that's what you get for using a beta SDK. shame on me.
[01:11:11] <rohitrao> so I support any rules to minimize the chance of that happening again
[01:12:48] <rsesek> rohitrao: I think the MainMenu.xib issue was caused by me trying to be clever with my diffs (to avoid all the 10.5-10.6 weirdness). I don't think the issue would occur elsewhere because AFAICT, IB loads, reinterprets, and clobbers the file each time you open/save.
[01:13:32] <rohitrao> huh, is that why it's always changing random lines even when I make no changes?
[01:13:36] <rohitrao> i love IB
[01:13:44] <rsesek> rohitrao: yes
[01:13:52] <akalin> lol
[01:13:52] <akalin> IB
[01:14:41] <rsesek> rohitrao: I think a better policy is: 1) if you're making a XIB change, svn lock it. 2) list every single thing you changed in the CL description 3) let IB do whatever the hell it pleases to the file
[01:14:46] *** EGreg_ has quit IRC
[01:15:06] <rohitrao> now we just need to get everyone to follow it :)
[01:15:09] <rsesek> when 10.7 comes around, we may have to re-evaluate, but 10.5-10.6 saving and opening should be compatible, even though stuff changes
[01:15:15] <rsesek> rohitrao: that's the hard part, isn't it? :)
[01:15:51] *** unboxer1900 has joined #chromium
[01:16:21] <unboxer1900> hey i'm running 5.0.367.0 (43259) on OSX 10.6.2 and i'm having some problems
[01:16:54] <rohitrao> hm?
[01:17:13] <unboxer1900> it seems that the apple-shift-b command has at some point recently just stopped working completely
[01:17:27] <rohitrao> does the menu item work?
[01:17:32] <unboxer1900> yep
[01:17:44] <rohitrao> have you tried quitting and restarting chrome?
[01:17:48] <unboxer1900> yep
[01:18:11] <unboxer1900> it's happening to me in chromium and chrome, both updated as much as possible
[01:18:24] <unboxer1900> other shortcuts (apple-shift-f for example) still work the same
[01:18:34] <rohitrao> does it work in safari?
[01:18:47] <rohitrao> maybe something on your system is eating apple-shift-b?
[01:18:54] <rsesek> unboxer1900: I've got no issues on 5.0.367.0 (43205)
[01:18:54] *** eseidel_ has joined #chromium
[01:19:02] <rsesek> or an extension that uses that keyboard shortcut?
[01:19:04] <rohitrao> it doesn't really make sense for it to be failing in both chrome and chromium
[01:19:15] * rsesek is annoyed at AdBlock+ for using Cmd+Option+b
[01:19:15] <unboxer1900> yeah i can't figure this one out at all.
[01:19:26] <unboxer1900> i don't have adblock plus installed
[01:19:48] <unboxer1900> http://grab.by/3s9z
[01:20:02] <rohitrao> unboxer1900: disable them all and see what happens :)
[01:20:15] *** trungl_mbp_ has joined #chromium
[01:20:21] <unboxer1900> just did
[01:20:22] <rohitrao> or launch chromium with a fresh profile
[01:20:24] <unboxer1900> behaves the same
[01:20:32] <unboxer1900> how do i launch with a fresh profile?
[01:21:04] <rsesek> albertb: the trybot is f-ed up right now. the patch LGTM though (simple enough)
[01:21:18] <rohitrao> easiest way is probably to open up terminal, then run "/path/to/Chromium.app/Contents/MacOS/Chromium --user-data-dir=/tmp/chromium"
[01:21:31] <rohitrao> which tells it to use /tmp/chromium as its profile dir
[01:21:47] <rohitrao> (for appropriate values of /path/to, of course)
[01:22:00] <albertb> rsesek: that's what I thought, all the tries have been getting that selinux error
[01:22:34] *** fishd has quit IRC
[01:22:43] <rsesek> albertb: yea. I think that may be because of something evanm changed?
[01:22:57] *** eseidel has quit IRC
[01:22:58] *** eseidel_ is now known as eseidel
[01:23:31] *** unboxer1900 has quit IRC
[01:23:54] *** trungl_mbp has quit IRC
[01:23:59] *** Adys has quit IRC
[01:24:14] <arv> evmar, It looks like 43277 casue linux failures
[01:24:17] *** Adys has joined #chromium
[01:25:38] <arv> evmar is not at his desk... reverting
[01:26:06] *** unboxer1900 has joined #chromium
[01:26:07] <rsesek> arv: did you land the neb's revert?
[01:26:15] <arv> rsesek, yes
[01:27:17] *** unboxer1900 is now known as unboxer
[01:27:21] <rsesek> arv: what rev? I don't see it on the waterfall? [I'm trying to figure out when valgrind should go green]
[01:27:22] <unboxer> sorry about that
[01:27:26] <unboxer> my irc client freaked out
[01:27:37] <unboxer> i launched into a temp profile and it still wouldn't accept apple-shift-b
[01:27:38] *** broofa has left #chromium
[01:27:44] <arv> rsesek, it didn't land
[01:27:54] <rsesek> arv: that would explain it :)
[01:27:57] <arv> rsesek, it was waiting for one more prompt -- sigh
[01:28:03] <unboxer> two other problems include: no favicons showing in the address bar and space is scrolling down the page even when flash is focused
[01:28:14] <arv> rsesek, commited as 43284
[01:28:20] <rsesek> arv: thanks
[01:28:29] <rsesek> unboxer: the first problem is works as designed
[01:28:38] <rohitrao> as is the second, maybe
[01:28:47] <rohitrao> maybe not
[01:28:50] <unboxer> favicons are gone?
[01:28:59] <rsesek> unboxer: favicons don't show up in the omnibox, only on tabs
[01:29:09] <rsesek> it's not like safari
[01:29:16] <unboxer> ah, you're right. that was my mistake.
[01:29:37] <unboxer> but the flash problem is new for me. if i want to play a flash game that includes the space bar, it's impossible because the page will scroll with every space entry
[01:29:51] <unboxer> and the apple-shift-b command is still completely unresponsive
[01:30:07] <akalin> if only we had some sort of tracker for these bugs...
[01:30:21] *** urbanape has joined #chromium
[01:30:24] <akalin> :-)
[01:30:25] <rohitrao> unboxer: the issue tracker is your friend.  http://code.google.com/p/chromium/issues/detail?id=39546
[01:31:09] <unboxer> rohitrao: ok, fair enough. but i still can't seem to figure out why the bookmarks shortcut key is unresponsive
[01:31:14] <stuartmorgan> unboxer: if the spacebar problem is new, finding the regression range and adding it to the bug would help
[01:31:51] <rsesek> stuartmorgan: and there's a tool to help with that //src/build/build-bisect -a mac -g <last revision known good>
[01:32:04] <rohitrao> unboxer: I don't know what's causing the apple-shift-b problem, but if it's really happening in both chrome and chromium, and with a fresh profile, my guess would be something system-specific
[01:32:07] <rsesek> add a .py to build-bisect because I'm stupid
[01:32:24] <rohitrao> unboxer: apple-shift-b still works in safari?
[01:32:35] <unboxer> apple shift b isn't mapped in safari (apple-alt-b is)
[01:32:38] <unboxer> but i was just able to fix it
[01:32:50] <unboxer> by closing a clipboard supplement menubar application
[01:32:51] <dhollowa> any sync folks here?
[01:32:54] <unboxer> which i'm guessing was taking the input
[01:32:56] <akalin> dhollowa: hello
[01:32:57] *** TabAtkins_ has quit IRC
[01:33:07] <rsesek> arv: afacit, after your revert of neb's change, all valgrind should go green
[01:33:08] <akalin> let me guess, notifications don't work?
[01:33:10] <stuartmorgan> unboxer: yes it is; it toggles the bookmark bar
[01:33:20] <rohitrao> unboxer: apple-shift-b should toggle the bookmark bar in safari too, but anyways, I'm glad I'm off the hook now :)
[01:33:38] <unboxer> yeah, i don't use safari so i didn't realize that
[01:33:41] <unboxer> but all is well now
[01:33:41] <arv> rsesek, I thought there was some issue remaining from yesterday that sky___ was looking into
[01:33:43] *** jrmuizel has quit IRC
[01:33:53] <dhollowa> akalin: i'm noticing on Mac prefs dialog that "Set Up Sync..." and "Set up AutoFill..." buttons have mismatched case on the "Up".
[01:33:57] <rsesek> arv: that should be suppressed
[01:34:09] <rsesek> arv: I tried to get the memory bots green this morning
[01:34:26] *** feldstein has joined #chromium
[01:34:28] <rohitrao> dhollowa: this is the sort of bug that makes markmentovai mad :)
[01:34:31] <akalin> dhollowa: ah okay, that must be dantasse's latest UI change
[01:34:34] <evmar> arv: sorry for the trouble, thanks for reverting
[01:34:40] <arv> rsesek, lets hope everything goes green
[01:34:45] <rsesek> arv: seriously
[01:34:49] <akalin> dhollowa: i'll pass it on
[01:34:56] <arv> evmar, that's what sheriffs are for
[01:35:02] <dhollowa> akalin: cool, i'll leave it in your hands then.  thanks.
[01:35:38] <rohitrao> arv, rsesek: please go green, please go green (I am sheriff tomorrow)
[01:36:03] <arv> rohitrao, hehe
[01:36:21] <dhollowa> rohitrao: hopefully we can sneak the fix in before he notices.  :-)
[01:37:09] <rohitrao> hehe
[01:37:20] <akalin> dhollowa: what is the right casing?
[01:37:21] <rohitrao> shess: I feel like I should offer to help, but I suspect I'll just get in your way
[01:37:33] <akalin> dhollowa: all uppercase on macs, right?
[01:37:42] <akalin> i mean all first-letter uppercase
[01:37:57] <rohitrao> title case, yeah
[01:37:59] <shess> rohitrao: help ... which?  I'm beavering away on breaking the omnibox.  If you know an URL to make the crazy ssl-error thing, that would help.
[01:38:04] <unboxer> last question i believe: where did the pop-out bookmark manager go?
[01:38:16] <rsesek> shess: which crazy ssl thing?
[01:38:22] <rohitrao> shess: help with general omnibox rewriting.  which is the ssl-error bug?
[01:38:25] *** paul_irish has quit IRC
[01:39:09] <shess> with my recent changes, the ssl label (say https://www.thawte.com/ ) shows at the same baseline as the url text.  But there's a case which people have posted at me (without an URL to go to) which show it way low.  I suspect someone is drawing from an expected place.
[01:39:44] *** unboxer has quit IRC
[01:40:14] <rsesek> shess: https://www.startssl.com/?app=26 maybe?
[01:40:23] <shess> rohitrao: one of my bugs involves clicking on the tab-to-search field.  I had an idea of having the click turn into start tab-to-search (if you see what I mean).  Glen said it sounds alright.  With the mouse-intercept code in place, it should be pretty easy.
[01:40:31] <rsesek> I'm on 5.0.367.0 (43205) and it appears low
[01:40:50] <shess> rsesek: I don't get any label at all on a trunk build.
[01:41:19] <dhollowa> akalin: yes, verified it was dantasse, rev 43255
[01:41:41] <rsesek> shess: I'm not quite on trunk (too red for me to safely download a new waterfall build right now; that's from this morning pre-your changes to flip everything around), but the EV cert line is low (though this has been removed I think, yes?)
[01:41:48] <shess> rohitrao: http://crbug.com/36838 is that bug.
[01:42:11] <akalin> dhollowa: he's fixing it now
[01:42:42] <shess> rsesek: the ssl label should have been "fixed" a couple days ago, but I "unfixed" it this morning, except that in the cases I saw I think my version was the right version.  So ...
[01:43:13] *** thakis has quit IRC
[01:43:41] <slifin> just finished my first extension :D
[01:43:44] <slifin> https://chrome.google.com/extensions/detail/hiebdcgjcbbgcbdehfddmllhfkmalekj
[01:44:13] *** ace__ has joined #chromium
[01:44:39] <evmar> slifin: cool!
[01:44:57] <slifin> ^^
[01:45:51] *** slightlyoff has joined #chromium
[01:45:52] *** ChanServ sets mode: +v slightlyoff
[01:46:30] *** alyxuk has quit IRC
[01:48:22] *** RT|Chatzilla has joined #chromium
[01:49:38] *** praseodymium has quit IRC
[01:49:43] *** praseodym has joined #chromium
[01:51:29] *** Jon has joined #chromium
[01:51:58] *** Jon is now known as Guest57321
[01:52:26] <rsesek> akalin: how's your make experiment going?
[01:52:38] <akalin> rsesek: i haven't looked at it today :(
[01:52:43] <akalin> but yesterday i got net_unittests working
[01:52:50] <rsesek> akalin: yea I saw that msg
[01:52:50] <akalin> the hacks are getting pretty gross, though
[01:52:52] <rsesek> haha
[01:52:59] *** rohitrao has quit IRC
[01:53:01] *** jparent has joined #chromium
[01:53:07] <akalin> i think i should just sent mmentovai and e-mail and see what he thinks the best way to approach it would be
[01:53:23] <arv> hclam, your webkit roll seems to have caused compile errors on linux
[01:53:30] <akalin> i could whip up a patch if oyu'd like to try it yourself, rsesek
[01:53:36] <hclam> arv: looking
[01:54:10] *** Jonbo has quit IRC
[01:54:11] <rsesek> akalin: I don't have time to do anything about it now, but starting may 17th I'll be working full time :)
[01:54:17] <akalin> nice
[01:54:23] *** sundiamonde has quit IRC
[01:54:41] <rsesek> akalin: if you don't finish by then, I'd be happy to help out; esp. because I'll be Mark's intern
[01:55:04] <akalin> okay
[01:55:08] <akalin> wait so you'll be a full-time...intern?
[01:55:42] <rsesek> akalin: working "full time" as opposed to what I do now; I'll be in the Google NYC office for the summer
[01:55:58] <hclam> arv: looks like it, need me to roll it out?
[01:56:02] <akalin> ah
[01:56:05] *** Deiz has quit IRC
[01:56:05] <estade> full time is a bit of a misnomer imo
[01:56:15] <arv> hclam: I'll do it
[01:56:18] <evmar> akalin: i can review make changes, but no hacks allowed
[01:56:22] <hclam> arv: thanks
[01:56:30] <akalin> evmar: i thought it was no thakis allowed
[01:57:32] <rsesek> estade: I meant the term as a reflection of time commitment rather than pay grade :)
[01:57:56] <estade> rsesek: yea. that's what I mean. You used it the intuitive way, googlers use it the misnomer way
[01:58:36] *** snej has quit IRC
[01:58:49] *** til has joined #chromium
[01:59:58] *** cying has joined #chromium
[02:00:15] <hclam> arv: strange that canary is still green :-/
[02:01:01] <arv> hclam, which builder is the canary?
[02:01:20] <hclam> http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=&builder=Webkit+(webkit.org)&builder=Webkit+Linux+(webkit.org)&builder=Webkit+Mac+(webkit.org)&builder=XP+Perf+(webkit.org)(1)&builder=XP+Perf+(webkit.org)(2)&builder=Linux+Perf+(webkit.org)
[02:01:57] <hclam> i'll fix it upstream and see if we can do another roll
[02:02:01] <arv> hclam, yeah, there were some issues with the dbg-shlib builder before
[02:02:27] <arv> hclam, do you mind doing the DEPS roll again and well let it cycle once?
[02:03:06] <hclam> arv: it was compile failure so I guess it's compiler difference
[02:03:27] <hclam> arv: so cycling once more may not help
[02:04:02] *** slightlyoff has quit IRC
[02:04:08] *** slightlyoff has joined #chromium
[02:04:08] *** ChanServ sets mode: +v slightlyoff
[02:05:22] <andybons> dmaclach: ping
[02:05:31] <dmaclach> andybons: yo
[02:05:55] *** slightlyoff has quit IRC
[02:06:21] <andybons> dmaclach: latest change is crashing with the same nestable_tasks issue within BrowserActionApiTest.BrowserActionAddPopup. mark the test as DISABLED and change the bug to refer to all issues nestable_tests related?
[02:07:13] <dmaclach> yes, that would probably be best. Hopefully we'll figure something out there soon.
[02:07:16] <andybons> http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/1443/steps/browser_tests/logs/stdio
[02:07:58] *** Venom_X_ has joined #chromium
[02:08:27] *** snorp has left #chromium
[02:12:03] *** Venom_X has quit IRC
[02:12:04] *** Venom_X_ is now known as Venom_X
[02:13:24] *** trungl_mbp has joined #chromium
[02:17:34] *** blocky has quit IRC
[02:17:58] <andybons> dmaclach: reverting. it's causing too many other tests to fail based on the same issue
[02:18:12] <dmaclach> k
[02:19:55] *** sswigart has quit IRC
[02:19:56] <rsesek> dmaclach: mac valgrind 2 may need a clobber; it's failed compile the last few runs
[02:20:18] <rsesek> dmaclach: it looks like it's timing out while running a shell script build phase
[02:20:32] *** stuartmorgan has quit IRC
[02:21:17] *** sundiamonde has joined #chromium
[02:22:16] <rsesek> albertb: the valgrind bots liked your patch; thanks for the quick fix
[02:22:53] <andybons> dmaclach: reverted
[02:26:20] *** cying_ has joined #chromium
[02:26:28] <dmaclach> rsesek: clobbered valgrind 2
[02:26:34] <rsesek> thanks
[02:27:42] *** cying has quit IRC
[02:27:43] *** cying_ is now known as cying
[02:28:25] *** victorw has left #chromium
[02:31:59] *** andybons has quit IRC
[02:35:54] *** wers has joined #chromium
[02:36:15] *** trungl_mbp has quit IRC
[02:37:31] *** Bleak has joined #chromium
[02:39:46] *** Spencer_tt has quit IRC
[02:40:10] *** johnny_g has quit IRC
[02:42:39] *** trungl_mbp has joined #chromium
[02:46:41] *** stiwari has joined #chromium
[02:51:50] *** dmaclach has quit IRC
[02:53:09] *** greg_ has joined #chromium
[02:54:53] *** TabAtkins has joined #chromium
[02:57:23] *** cying has quit IRC
[02:58:40] *** TabAtkins_ has joined #chromium
[02:59:02] *** TabAtkins has quit IRC
[03:00:27] *** ananta has quit IRC
[03:01:05] *** hbono has joined #chromium
[03:02:28] *** TabAtkins_ is now known as TabAtkins
[03:04:19] <stiwari> Hi, I am trying to build chrome from source on Debian and I have followed all the instructions correctly. However, I am getting the following error, third_party/WebKit/WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:392: error: ?strstr? is not a member of ?std?
[03:04:46] <stiwari> Is there any way I could get around this?
[03:04:57] <stiwari> Also, is this the right forum to ask such questions?
[03:05:02] <evmar> i looked at that file and see no mention of strstr in my local copy...
[03:05:08] <evmar> what version of hte code do you have?
[03:05:29] <evmar> stiwari: ^^^
[03:05:39] <stiwari> hte?
[03:05:43] <evmar> the
[03:05:55] <jamesr> stiwari: you landed on a bad revision
[03:06:00] <jamesr> stiwari: try updating to ToT
[03:06:11] <stiwari> and what is the way to do that?
[03:06:16] <jamesr> gclient sync should do it
[03:06:25] <stiwari> ok, thank you very much!
[03:06:26] <jamesr> assuming you have a normal SVN checkout
[03:06:46] <jamesr> there's a section in the instructions about how to only sync to the last known good revision (LKGR)
[03:06:51] <jamesr> i think that would also save your bacon
[03:08:21] <stiwari> I think that's where I went wrong.
[03:08:25] <stiwari> Thank you guys!
[03:10:28] <jamesr> np
[03:10:44] *** stiwari has left #chromium
[03:11:28] *** rohitrao has joined #chromium
[03:11:29] *** ChanServ sets mode: +v rohitrao
[03:13:40] *** sig11 has joined #chromium
[03:15:48] *** dmaclach has joined #chromium
[03:19:28] *** mmoss_home has joined #chromium
[03:21:54] *** prasadt has quit IRC
[03:23:23] *** cbentzel has joined #chromium
[03:27:11] *** rafaelw has left #chromium
[03:28:21] *** arv has quit IRC
[03:33:15] *** Adys has quit IRC
[03:34:16] *** Adys has joined #chromium
[03:34:20] *** krisr_mbp has quit IRC
[03:35:08] <jhawkins> reverting, forgot the tests
[03:37:40] *** Adys has quit IRC
[03:37:51] *** TabAtkins has quit IRC
[03:37:56] *** krisr_mbp has joined #chromium
[03:40:02] *** cyber_11 has quit IRC
[03:44:40] <jhawkins> sheriffs: the fix is in, so I opened. feel free to keep it closed until it rolls green
[03:49:29] <kbr_google> hi, i just noticed the build breakage on Linux in WebGraphicsContext3DDefaultImpl
[03:49:34] <kbr_google> sry
[03:49:42] <kbr_google> not sure why that is happening
[03:50:48] <kbr_google> ah whoops -- the original code did incorrectly call std::strstr
[03:50:48] <kbr_google> sorry about that
[03:51:00] *** mpcomplete has quit IRC
[03:56:47] *** holdenss has joined #chromium
[03:57:04] *** Adys has joined #chromium
[03:57:57] <bgmerrell> what is the "floating bookmark bar?"
[03:58:17] *** eseidel has quit IRC
[03:58:18] *** jamesr has quit IRC
[04:00:28] *** Maaka has quit IRC
[04:02:22] <til> rohitrao: i've been noticing that chrome isn't always respecting my preferences for scroll arrow placment
[04:02:42] <rohitrao> til: we don't correctly listen for changes to the preference
[04:02:48] <til> sometimes, they are near the resize corner rather than at the window edges, ala classic mac
[04:03:03] <til> rohitrao: it's sporatic though.  i've never changed my preferences except for on initial mac setup
[04:03:19] <rohitrao> til: probably happens when you open/close the download shelf?
[04:03:36] <rohitrao> and fixes itself if you resize the window?
[04:04:25] <til> rohitrao: refreshing and resizing dont fix it
[04:04:39] <til> but a new tab with the same content is just fine
[04:09:30] *** cbentzel has left #chromium
[04:09:35] *** krisr_mbp has quit IRC
[04:16:31] *** careta has joined #chromium
[04:16:47] <careta> hello all
[04:16:55] <sig11> rohitrao: Hi.  Did you ever have a chance to take a look at that patch?  I've been traveling without internet for almost a week.
[04:17:04] <careta> can anyone please tell me how to remove all the tests from the build tree?
[04:18:08] *** bweinstein has quit IRC
[04:18:23] <akalin> why would you want to do that
[04:19:03] <careta> because im building to use it as regular user
[04:19:46] <mattm_g> finnur: build failure looks like you
[04:19:58] <finnur> on it
[04:20:14] <akalin> careta: why would you want to do that instead of downloading the packages?
[04:20:42] <finnur> working on a fix, should be easy
[04:21:06] <careta> akalin, why not? there are no official packages for debian, and i don't trust anybody else
[04:22:33] <akalin> iirc the dev channel deb works on debian 5
[04:23:43] <finnur> uploading fix
[04:23:57] <careta> like i said, i don't trust anybody else except packages signed by debian developers or built by myself
[04:24:40] <akalin> oh
[04:25:24] <careta> nothing personal, im just paranoid
[04:25:33] <finnur> mattm_g: fix is in
[04:26:55] <careta> so is there a way to remove the unit tests from the build tree? can i just delete them?
[04:27:13] *** til has left #chromium
[04:27:21] <akalin> sure
[04:27:28] <akalin> you may as well just do 'make chrome' and avoid building them at all
[04:28:51] <rubenbb1> careta: if you're paranoid, you should read the millions of source code looking for bugs, good luck ;)
[04:29:21] *** arv has joined #chromium
[04:29:27] <akalin> yeah, i was gonna say, you don't trust google's packages, but you trust their source code :)
[04:30:41] *** Venom_X has quit IRC
[04:31:24] <careta> not that paranoid :)
[04:32:43] <rohitrao> sig11: bah, never sent you comments.  The patch isn't quite right, I don't think.
[04:33:16] <rohitrao> sig11: I think it needs to integrate a bit more with the existing find_bar_controller.cc code, although I need to read up a bit to figure out exactly what I mean by that
[04:33:30] <careta> are the tests scattered or in one dir?
[04:33:46] <akalin> they're all over the place
[04:33:54] <akalin> as i said, you could just go 'make chrome' and not build them at all
[04:35:48] *** eseidel has joined #chromium
[04:36:15] *** greg_ has quit IRC
[04:37:11] *** eseidel_ has joined #chromium
[04:37:21] <sig11> rohitrao: I agree that there is something slightly off, but I am not exactly sure what.
[04:37:39] <careta> akalin, will that build a chrome branded or chromium branded executable?
[04:37:43] <akalin> chromium
[04:38:11] *** mrossetti has quit IRC
[04:38:22] <careta> ok thanks a lot!
[04:38:33] <akalin> sure
[04:39:04] <sig11> rohitrao: I should hopefully have some more free time again late next week.  Work and family have conspired to use up all of my free time
[04:41:30] *** eseidel has quit IRC
[04:41:30] *** eseidel_ is now known as eseidel
[04:42:52] <rohitrao> sig11: ok, i don't feel quite as bad for not sending you comments then :)
[04:44:15] <sig11> :)
[04:47:38] <rsesek> is a sheriff still around?
[04:49:33] <sig11> rohitrao: I'll harass you next week when I get recovered.
[04:49:56] <jrg> rsesek: don't think so.  Why?
[04:50:08] <rsesek> jrg: mac valgrind 2 is sick.
[04:50:19] <jrg> rsesek: how bad?  /me looking
[04:50:21] <rsesek> jrg: it's timing out on a build phase script
[04:50:50] <rsesek> dmaclach clobbered, but I'm thinking the slave may need a clobber of the entire directory and a restart
[04:51:20] <jrg> rsesek: OK: I'll try if you stick around and watch. SG?
[04:51:26] <jrg> rsesek: I might fall asleep for 15min
[04:51:37] <rsesek> jrg: I'll probably fall asleep first; it's 11pm here :p
[04:51:45] <jrg> rsesek: doh!
[04:51:54] <rsesek> they're all being serviced by applewebdata://FE9D86DE-9BF7-4237-AA97-F7D62F150A2E/buildslaves/chromemacbuild4 from what I can tell
[04:52:22] <jrg> rsesek: I'll clean it and rebuild.
[04:52:42] <rsesek> jrg: thanks. i'll probably be around for another hour or so to check in on it
[04:53:12] <bgmerrell> what is the "floating bookmark bar?"  I broke a test and i'm wondering what that refers to.
[04:53:36] <jrg> bgmerrell: on New Tab Page, if bookmark bar is not open, it'll "float" in the content area
[04:56:35] *** dmaclach_ has joined #chromium
[04:57:16] *** kjg has joined #chromium
[04:58:26] *** kenneth_reitz has joined #chromium
[04:58:32] <kjg> I searched the tickets but couldn't find this one, but I couldn't imagine it was unknown. Is it known that in the latest dev channel release for mac that flash 10.1 b3 doesn't seem to recognize drag events?
[04:59:05] <jrg> rsesek: clean build running
[04:59:09] <rsesek> jrg: thanks
[04:59:13] <jrg> rsesek: looks like generate_localizer was hanging.
[04:59:32] <jrg> Not sure why.  The script hasn't changed in months.  Seems odd but bots are difficult to make reliable so who knows.
[04:59:46] <rsesek> jrg: I've had this problem before on my machine once or twice when Xcode lost its mind
[05:00:10] *** dmaclach has quit IRC
[05:00:11] *** dmaclach_ is now known as dmaclach
[05:00:14] <bgmerrell> jrg: thanks, trying to make sure I understand what you're saying, but i'm building right now and everything's slow.  But, I should turn the bookmark bar off then?
[05:01:13] <jrg> bgmerrell: "should I turn the bookmark bar off": I don't know; I don't know your problem.  But the "floating" bar is a case where the preference says "don't show the bookmark bar" but it's there on the screen anyway.  Not sure how that intersects with your CL.
[05:02:32] *** holdenss1 has joined #chromium
[05:03:06] *** arv has quit IRC
[05:03:24] *** holdenss has quit IRC
[05:08:41] <rsesek> brb. installing 10.6.3 / restarting
[05:08:49] <bgmerrell> jrg: right, sorry, i was referring to the show_on_all_tabs bookmark_bar settings in master_preferences.
[05:09:07] *** rsesek has quit IRC
[05:09:08] <bgmerrell> s/settings/setting
[05:10:22] <jrg> bgmerrell: still not sure. Can you rephrase?  E.g. "I added feature/change X.  Intent was Y.  Got backed out befause of failure Z.  What do you think a path to success is"?
[05:10:35] <jrg> I still don't have big picture understanding of what you did or why.
[05:11:54] *** peterdn has quit IRC
[05:15:08] <bgmerrell> jrg: Well, I really just wanted to figure out what the floating bookmar bar referred to.  I didn't mean to drag you in this deep ;).  I had a patch of mine submitted to port --import-from-file to Linux (which allows a bookmark file to be imported from the command-line), but the commit got reverted because it "broke BookmarkBarGtkBrowserTest.ClickOnFloatingTest".
[05:15:13] *** bweinstein has joined #chromium
[05:15:33] <bgmerrell> now I am buildling the tests to see if I can get more info
[05:16:09] <jrg> bhmerrell.  Ah.  Have no idea how that test could have been broken.  I'd guess easy fix (perhaps even visible on the bot which broke).
[05:16:18] <jrg> s/bhmerrell/bgmerrell/g
[05:16:20] *** bweinstein has quit IRC
[05:16:23] *** bweinstein has joined #chromium
[05:17:09] *** dpranke has quit IRC
[05:18:51] *** bweinstein has quit IRC
[05:19:57] <bgmerrell> jrg: ah, cool, how would I know which bot it broke on and how to look at the bot?  I just got a e-mail from a comment on the review url saying that it broke the test
[05:21:14] <jrg> look at waterfall.  See the revision where your CL landed (can also find revision from codereview site).  Now look for red boxes after your name.  One of those is linux unit_tests (or whatever).  CLick it then follow links (e.g. stdio)
[05:22:25] *** tedoc2000 has quit IRC
[05:23:41] *** tedoc2000 has joined #chromium
[05:28:19] *** rsesek has joined #chromium
[05:28:37] *** MikeSmithXX has joined #chromium
[05:30:29] *** bweinstein has joined #chromium
[05:30:37] *** bweinstein has quit IRC
[05:32:10] *** MikeSmithW3C^ has quit IRC
[05:35:40] <bgmerrell> jrg: thanks again, i'll take a look
[05:39:33] *** hwked has joined #chromium
[05:40:07] *** hwked has quit IRC
[05:41:43] *** maro has quit IRC
[05:42:22] <rsesek> lol @ re:javascript, " Since $ has become the coolest way to do completely non-standard lookups in an almost indecipherable way, we thought we?d jump on the bandwagon." : http://cappuccino.org/discuss/2010/04/01/solving-the-javascript-memory-management-problem/
[05:43:18] *** maro has joined #chromium
[05:44:15] <rsesek> jrg: bot is still suck (in same place)
[05:44:17] <rsesek> er stuck
[05:44:19] <rsesek> but suck too
[05:44:28] <jrg> rsesek: let me load shotgun and fix
[05:44:36] <rsesek> jrg: napalm standing by
[05:45:03] <jrg> rsesek: I need to finish some interview feedback but will try and debug in about 20min
[05:45:23] <jrg> rsesek: you know we're headed for a milestone, yes?  So we've got craziness here.
[05:45:40] <rsesek> jrg: yes. milestone craziness indeed
[05:46:14] *** dmazzoni has quit IRC
[05:46:23] <rsesek> jrg: I'll probably be heading out soon, but I'll check on the bot in the EDT AM; I'll poke tvl or anther trooper if we're still having problems then
[05:46:30] <jrg> rsesek: thx
[05:48:04] *** eseidel has quit IRC
[05:50:34] *** appamatto has joined #chromium
[05:55:09] *** dave_levin_ has joined #chromium
[05:57:54] *** cyy has quit IRC
[06:06:48] *** tav has quit IRC
[06:09:41] *** rsesek has quit IRC
[06:16:15] *** leiz has quit IRC
[06:18:56] <rubenbb1> heh, the linux flash guy listed the chrome aw snap translations in every language :) - http://multimedia.cx/eggs/aw-snap-in-every-language/
[06:22:24] <hclam> webkit merge landing
[06:22:51] <akalin> the japanese translation is lacking
[06:23:03] <akalin> it's basically the word 'error' transliterated
[06:23:23] <hclam> hope it works this time.. :-/
[06:26:58] *** hbono has quit IRC
[06:31:48] <rubenbb1> akalin: this patch for make.py has been sitting on codereview for some time - http://codereview.chromium.org/491080/show
[06:32:28] <akalin> is that the right one?
[06:32:32] <akalin> it doesn't touch make.py
[06:32:35] *** hbono has joined #chromium
[06:32:52] <rubenbb1> http://codereview.chromium.org/171086/show
[06:33:36] <akalin> ah
[06:33:39] <rubenbb1> I can understand why most of those patches posted by Ben didn't get committed though, as not all of that stuff is worked out and we didn't want to push it through the review process
[06:33:50] <rubenbb1> you can click on his name if you want to see the other ones
[06:33:55] <akalin> i see
[06:34:24] <rubenbb1> Peter's been breaking that up into pieces and pushing it into the repo - http://codereview.chromium.org/user/Peter%20Valchev
[06:35:16] *** pfeldman has joined #chromium
[06:35:38] <akalin> cool
[06:35:53] *** fishd has joined #chromium
[06:35:53] *** ChanServ sets mode: +v fishd
[06:35:57] <akalin> yeah i'd still need to chat with mmentovai about osx make
[06:36:03] <akalin> i think diff(linux, freebsd) << diff(linux, os x)
[06:36:17] <akalin> but all these changes help
[06:36:21] <akalin> e.g. the sed -i fix
[06:36:42] *** fishd_ has joined #chromium
[06:36:42] *** ChanServ sets mode: +v fishd_
[06:37:05] <rubenbb1> well, macports uses bsd make so it should be doable to get gnu make working on the mac, I'd think
[06:37:21] *** kig_ has quit IRC
[06:37:27] <akalin> well make itself works
[06:37:32] <akalin> like i got it generating makefiles and stuff
[06:37:46] *** Kunalagon has joined #chromium
[06:37:49] <akalin> but there are a bunch of mac-specific and objc-specific switches that need to ride along
[06:38:03] <akalin> i have to figure out (or query mmentovai) which switches are needed, and if I can automatically grab them from somewhere
[06:38:05] *** wingofray has joined #chromium
[06:38:27] *** wingofray has left #chromium
[06:38:31] *** Kunalagon has quit IRC
[06:38:31] <rubenbb1> hmm, ok, getting gyp to generate the mac config for make
[06:38:34] <akalin> right now i've just been tediously running make on bigger and bigger targets and hacking around problems
[06:38:47] <akalin> yeah, that part was pretty easy
[06:39:03] <akalin> actually let me see if i can post a patch of what i have
[06:39:50] <akalin> i'm a bit crippled by not knowing my way around svn or gcl
[06:40:12] *** seventh has quit IRC
[06:40:23] *** fishd has quit IRC
[06:41:05] <rubenbb1> well, I've never built on the mac, but since freebsd is probably the closest platform to the mac, my patches might help you
[06:41:17] <akalin> sure
[06:41:24] <akalin> http://codereview.chromium.org/1609001/show is what i have
[06:42:44] <rubenbb1> lots of mac-specific stuff there, dunno about that.  What is the real solution for the OS flag though?  Get it from os.platform?
[06:43:01] <akalin> yeah, i think so
[06:43:48] <rubenbb1> I just comment it out and pass it in as a gyp_define
[06:43:54] <akalin> ah
[06:43:57] *** dave_levin__ has joined #chromium
[06:44:23] *** roc has quit IRC
[06:44:53] <akalin> do you have a bug to track your freebsd changes?
[06:45:13] <akalin> or is it a skunkworks project since freebsd isn't an official platform :)
[06:45:37] <rubenbb1> no, Ben sprayed codereview with them once - http://codereview.chromium.org/user/Ben%20Laurie%20(Chromium)
[06:45:51] <akalin> ah
[06:46:29] <rubenbb1> and right now, Peter just grabs pieces and pushes them through, Evan wrote about this a couple days ago - http://neugierig.org/software/chromium/notes/2010/03/other-unixes.html
[06:47:34] *** dave_levin_ has quit IRC
[06:47:36] <rubenbb1> but yeah, there's no plan to support anything outside the main 3 OSes, a lot of it is platform-neutral though and adds portability at no cost, so Peter's taken it on himself to push much of it in.  Half of my patch from december has been committed so far and that's all due to Peter :)
[06:48:04] <akalin> nice
[06:48:23] <akalin> yeah i think exposure to other platforms is useful, even without official support
[06:49:34] <bgmerrell> evmar: you around by chance?
[06:50:08] <akalin> wow linux is 1%
[06:51:27] *** wers has quit IRC
[06:51:53] <rubenbb1> I started getting annoyed when he said BSD was 1% of linux then I realized he was right, if anything he was generous :D
[06:52:16] <akalin> windows : linux :: linux : bsd
[06:53:01] <rubenbb1> but a lot of that may be that bsd is not used on the desktop much, the overall penetration may not be that much lower
[06:53:16] <akalin> right
[06:55:26] *** felipe` has quit IRC
[06:55:47] *** reiz has joined #chromium
[06:56:53] *** reiz is now known as leiz
[07:00:09] *** coyo has quit IRC
[07:01:28] *** jtbandes has joined #chromium
[07:02:13] *** jtbandes has left #chromium
[07:02:17] *** coyo has joined #chromium
[07:02:45] *** urbanape has quit IRC
[07:06:53] *** tedoc2000 has quit IRC
[07:09:04] *** coyo has quit IRC
[07:09:54] *** bweinstein has joined #chromium
[07:13:03] *** coyo has joined #chromium
[07:16:19] *** urbanape has joined #chromium
[07:18:43] *** mirandac_ has quit IRC
[07:19:16] *** Peter` has joined #chromium
[07:20:28] *** PRINCESS_FLUFF has joined #chromium
[07:20:42] *** PRINCESS_FLUFF has left #chromium
[07:25:49] *** leeight has joined #chromium
[07:25:54] *** leeight has left #chromium
[07:26:59] *** feldstein has quit IRC
[07:33:42] *** kjg has quit IRC
[07:37:22] *** MikeSmithXX has quit IRC
[07:38:35] *** careta has quit IRC
[07:38:39] *** holdenss1 has quit IRC
[07:41:32] *** careta has joined #chromium
[07:42:46] *** kreitz has joined #chromium
[07:42:52] *** bryeung has quit IRC
[07:43:07] *** bryeung has joined #chromium
[07:43:58] *** sundiamonde has quit IRC
[07:45:15] *** kreitz has quit IRC
[07:45:36] *** kreitz has joined #chromium
[07:45:42] *** greg_ has joined #chromium
[07:46:21] *** kenneth_reitz has quit IRC
[07:52:08] *** zloidemon has joined #chromium
[07:52:24] *** wers has joined #chromium
[07:52:42] *** careta has quit IRC
[07:53:30] *** bweinstein has joined #chromium
[07:56:45] *** mmoss_home has quit IRC
[07:59:06] *** kreitz has quit IRC
[08:02:00] *** twanj has quit IRC
[08:03:28] *** yusukes has joined #chromium
[08:05:11] *** thakis has joined #chromium
[08:05:11] *** ChanServ sets mode: +v thakis
[08:08:03] *** tmzt_ has quit IRC
[08:08:20] *** tmzt_ has joined #chromium
[08:09:53] *** fishd_ is now known as fishd
[08:12:00] <fishd> lots of red for an open tree
[08:12:19] *** bevc_work has joined #chromium
[08:12:52] <pfeldman> fishd: should we just revert things to r43309? :)
[08:13:13] <fishd> i have no idea... i just looked at the tree for the first time this evening
[08:14:30] <pfeldman> fishd: greatest badness is a webkit roll, but that is fine - you are in the TBR list :P
[08:14:58] <fishd> ic
[08:15:37] <fishd> my gardening shift starts tomorrow, but i was thinking of doing some gardening now
[08:15:39] *** Darkhus has quit IRC
[08:19:58] *** Darkhus has joined #chromium
[08:20:13] *** kairu has quit IRC
[08:27:07] *** roc has joined #chromium
[08:30:16] <bevc_work> hi everyone. once the fyi slaves are done updating, i'm going to restart the master. there will be some purple on the fyi waterfall.
[08:31:19] *** Jonbo has joined #chromium
[08:35:16] *** Guest57321 has quit IRC
[08:35:31] <fishd> hclam: yt?
[08:35:56] <fishd> pfeldman: yeah, the last webkit roll seems like it was bad
[08:36:24] <fishd> pfeldman: unless someone is itching to revert, i'm going to look at the failures to see if it isn't something trivial
[08:36:47] *** thakis has quit IRC
[08:36:50] <pfeldman> pfeldman: no hurry from my side
[08:39:27] <pfeldman> dave_levin: yt? latest webkit roll has numerous failures around workers / message port.
[08:39:43] <dave_levin__> I'm here...
[08:39:52] *** holdenss has joined #chromium
[08:40:10] <pfeldman> fishd: wanted to look into it, but i thought you could have a clue
[08:40:27] <pfeldman> i meant "fishd wanted to look". stupid autocomplete.
[08:41:19] <fishd> yeah, i was just chatting with dave over gtalk
[08:41:36] <pfeldman> hah
[08:42:32] <fishd> building...
[08:43:20] <dave_levin__> fishd: pfeldman: http://trac.webkit.org/changeset/56877
[08:43:41] <dave_levin__> fortunately, Alpha only rolled in a few changes. It must be this one.
[08:44:05] <pfeldman> dave_levin__: we were chatting about it with Vitaly yesterday, did not know he landed it already.
[08:44:36] <dave_levin__> pfeldman: He asked me to cq+ it so in a sense he didn't.
[08:44:39] <jochen__> TEST=tree is green
[08:44:44] <jochen__> now that one failed obviously :)
[08:44:48] <jochen__> good morning chromium
[08:46:23] <pfeldman> fishd, dave_levin__: should we revert the roll? it was only rolling 14 revisions
[08:46:32] <pfeldman> or even 12
[08:46:43] <fishd> yes, let's revert the roll
[08:46:45] <dave_levin__> imo, yes.
[08:46:56] <fishd> we should probably revert the webkit commit as well
[08:47:04] <fishd> i can work on verifying that that was the problem
[08:47:18] <fishd> and if so, i'll revert it upstream
[08:47:37] <pfeldman> fishd: once we revert the roll, vitaly will have few hours to fix chromium or revert his change. not much happens to webkit when US is sleeping.
[08:47:55] <fishd> ic
[08:48:12] <fishd> i'm gardener tomorrow, but i'll be in meetings all day, so i was hoping to roll to tip of webkit this evening
[08:48:25] *** wers has quit IRC
[08:48:36] <dave_levin__> We need to roll out that change in webkit
[08:48:42] <dave_levin__> then things should be pretty good.
[08:48:45] <fishd> yeah
[08:48:56] <pfeldman> fishd: you are the boss, reverting Vitay's change upstream is fine. it is just that you'll need to fix something to roll to the tip according to canaries.
[08:49:25] <fishd> there is a ruby issue that roland is working on
[08:49:31] <fishd> just a rebaseline that is needed
[08:49:45] *** fbarchard has joined #chromium
[08:50:12] <dave_levin__> fishd: There are also the mac video test. I think schekus landed a bad baseline on that one.
[08:50:21] <fishd> ic
[08:50:41] <fishd> we need DRT upstream :-P
[08:51:23] <pfeldman> i'll pass the message to Vitaly. no more cq?/+ on changes that touch bindings. I learned that lesson long ago.
[08:51:31] <fishd> unless someone else chimes in, i assume i'm doing both reverts
[08:54:47] *** appamatto has quit IRC
[08:57:12] *** pfeldman has quit IRC
[08:57:43] *** pfeldman has joined #chromium
[08:58:00] *** pfeldman has quit IRC
[08:58:33] *** mtigas has joined #chromium
[09:03:35] *** holdenss has quit IRC
[09:05:10] *** dave_levin__ has quit IRC
[09:11:02] *** bevc_work has quit IRC
[09:11:42] *** Darkhus has quit IRC
[09:22:31] *** slifin has quit IRC
[09:22:47] *** greg_ has quit IRC
[09:23:04] <rsteiner> webkit try bots seem to be pacified now with regards to my layout test (thanks to David Levin for finding my mistake!)
[09:27:29] *** felipe` has joined #chromium
[09:27:37] *** slifin has joined #chromium
[09:34:37] *** theliet has joined #chromium
[09:39:27] *** MikeSmithW3C has joined #chromium
[09:39:29] *** slifin has quit IRC
[09:44:08] <hclam> hmm i'm back
[09:44:13] <hclam> so the roll is bad?
[09:47:58] *** _sid_ has joined #chromium
[09:48:54] <hclam> hmm.. seems like the revert back to 56868 is needed
[09:50:38] <hclam> fishd: ping
[09:51:21] <hclam> fishd: should I roll out 56876 and roll the deps again?
[09:52:22] *** romainhuet has joined #chromium
[09:52:35] <hclam> 56873 seems to be bad too.
[09:54:47] <hclam> i'll fix 56873 first
[09:54:49] *** kochi has quit IRC
[10:02:09] *** eseidel_ has joined #chromium
[10:03:12] *** Sarten-X2 has quit IRC
[10:03:22] *** eseidel__ has joined #chromium
[10:06:01] *** tbassetto has joined #chromium
[10:08:15] *** eseidel_ has quit IRC
[10:11:02] *** Sarten-X has joined #chromium
[10:11:11] *** loislo has joined #chromium
[10:12:49] *** Jonbo has quit IRC
[10:14:51] *** slifin has joined #chromium
[10:19:13] <hclam> fishd: ping
[10:19:21] *** slifin has quit IRC
[10:25:05] *** ROBOd has joined #chromium
[10:31:20] *** fishd_ has joined #chromium
[10:31:20] *** ChanServ sets mode: +v fishd_
[10:32:14] <fbarchard> safe to break the tree yet? :)
[10:32:37] *** Spencer_tt has joined #chromium
[10:34:35] *** fishd has quit IRC
[10:36:20] <hclam> tree is green but it's webkit that is broken
[10:37:20] *** slifin has joined #chromium
[10:38:01] *** pfeldman has joined #chromium
[10:38:25] *** fishd__ has joined #chromium
[10:38:25] *** ChanServ sets mode: +v fishd__
[10:39:50] <hclam> fishd__: ping
[10:39:50] *** rohitrao has quit IRC
[10:39:52] *** rohitrao_ has joined #chromium
[10:39:53] *** ChanServ sets mode: +v rohitrao_
[10:41:52] *** fishd_ has quit IRC
[10:43:02] *** peterdn has joined #chromium
[10:44:48] <pfeldman> mnissler: are you on top of 40090? know how to fix that?
[10:45:10] <mnissler> yes, I have patch.
[10:45:29] <mnissler> pfeldman: I'm just getting it ready for upload
[10:45:40] <pfeldman> mnissler: k
[10:46:04] <mnissler> pfeldman: don't know whether it's good, but I guess you'll be able to help me :-)
[10:46:07] <fishd__> hclam: hi
[10:46:13] *** fishd__ is now known as fishd
[10:47:08] <hclam> fishd: just to let you know i rebaselined for 56873, when the fix is in for worker it should be able to roll again
[10:47:53] *** zloidemon has quit IRC
[11:02:20] *** fishd_ has joined #chromium
[11:02:20] *** ChanServ sets mode: +v fishd_
[11:03:48] *** urbanape has quit IRC
[11:05:38] *** fishd has quit IRC
[11:07:05] *** mtigas has quit IRC
[11:13:32] *** eseidel__ has quit IRC
[11:20:19] *** bauerb has joined #chromium
[11:20:19] *** fbarchard has left #chromium
[11:22:02] *** Zucca has quit IRC
[11:23:30] *** Zucca has joined #chromium
[11:24:25] *** fishd_ has quit IRC
[11:28:44] *** MikeSmithW3C^ has joined #chromium
[11:31:18] *** appamatto has joined #chromium
[11:31:51] *** wers has joined #chromium
[11:32:14] *** MikeSmithW3C has quit IRC
[11:32:39] *** Peter` has quit IRC
[11:33:50] *** Sk4tz has joined #chromium
[11:34:00] *** Sk4tz has left #chromium
[11:34:57] <appamatto> I've been having trouble starting up with recent builds.  I think some of my settings have been corrupted.  Is there an easy way to zap them?
[11:35:29] *** dale1v has joined #chromium
[11:39:58] *** dale1v has quit IRC
[11:40:10] *** glider has joined #chromium
[11:43:50] *** wers has quit IRC
[11:46:29] <appamatto> Can someone help me commit this patch? http://codereview.chromium.org/1084017/show
[11:50:21] *** Peter` has joined #chromium
[11:54:43] <glider> appamatto: is this a Chromium code review?
[11:55:29] *** dale1v has joined #chromium
[11:55:57] <glider> appamatto: I can land it for you then
[11:57:41] <appamatto> glider, yes, it's for Chromium.
[11:58:41] <glider> appamatto: does sehr have a committer status? You need to have an LGTM from a committer
[11:59:49] <appamatto> I'm not sure how to check that information, but I believe he's a committer for nacl and chromium
[12:00:36] <appamatto> Is there a committer list? :)
[12:04:06] <glider> appamatto: ok, folks tell me it's totally ok to commit a CL LGTMed by sehr
[12:04:15] <glider> :)
[12:04:18] *** MikeSmithW3C^ has quit IRC
[12:04:47] *** joth has quit IRC
[12:05:06] *** dale1v has quit IRC
[12:06:04] <appamatto> hehe, thought so. :)
[12:06:45] *** pdelgallego has joined #chromium
[12:08:01] *** hbono has quit IRC
[12:10:15] <glider> appamatto: http://codereview.chromium.org/1562007
[12:10:20] *** Sk4tz has joined #chromium
[12:10:31] <glider> will land it once the compilation passes
[12:11:37] <appamatto> thank you, glider!
[12:12:59] *** dale1v has joined #chromium
[12:14:43] *** Peter` has quit IRC
[12:15:04] *** Maaka has joined #chromium
[12:18:20] *** General1337 has joined #chromium
[12:20:05] *** dale1v has quit IRC
[12:21:24] *** General13372 has quit IRC
[12:24:00] <Zucca> I found a "bug". Not a serious one but rather irritating: I have set my GTK theme so that window backgrounds are black by default and test is white. Chromium works fine with this except at the address bar. The blinking cursor omits my GTK style color (white) and I cannot see it from the white background that chromium has on the address bar.
[12:24:22] *** Sk4tz has quit IRC
[12:24:24] <Zucca> *text
[12:25:07] <Zucca> I wonder if anyone else has stumbled into this...
[12:27:20] <Zucca> Chromium	5.0.342.7 (Developer Build 0)
[12:27:20] <Zucca> WebKit	533.2
[12:27:21] <Zucca> V8	2.1.2.7
[12:27:31] <Zucca> My version.
[12:29:57] <appamatto> Zucca, you could try filing a bug report at: http://code.google.com/p/chromium/issues/entry
[12:30:29] *** dale1v has joined #chromium
[12:32:15] <Zucca> Ok. :)
[12:33:19] *** cbentzel has joined #chromium
[12:33:31] *** seventh has joined #chromium
[12:37:03] *** Zaba has quit IRC
[12:37:47] *** seventh has quit IRC
[12:39:16] *** roc has quit IRC
[12:39:42] *** Zaba has joined #chromium
[12:40:19] *** chenillen has joined #chromium
[12:40:36] *** seventh has joined #chromium
[12:42:48] *** alyxuk has joined #chromium
[12:43:17] *** cbentzel has quit IRC
[12:44:25] <Zucca> http://code.google.com/p/chromium/issues/detail?id=40094 I hope I filled it propely.
[12:48:39] *** lianj__ has joined #chromium
[12:49:26] *** lianj_ has quit IRC
[12:50:16] *** lianj__ is now known as lianj_
[12:50:37] *** zyichi has left #chromium
[12:50:41] <appamatto> Thanks, bugs are much easier to track there.  You might try searching for similar bugs if you're interested in your original question (Does this happen to other people?)
[12:53:15] *** Peter` has joined #chromium
[12:53:40] *** lianj_ is now known as lianj
[12:54:55] *** chenillen has quit IRC
[12:56:18] *** lianj has quit IRC
[12:58:03] *** lianj has joined #chromium
[12:59:35] *** General13372 has joined #chromium
[12:59:58] *** danno_ has joined #chromium
[13:03:14] *** General1337 has quit IRC
[13:05:19] *** andybons has joined #chromium
[13:05:38] *** andybons has quit IRC
[13:12:17] *** dale1v has quit IRC
[13:13:50] *** urbanape has joined #chromium
[13:16:04] *** andybons has joined #chromium
[13:16:12] <andybons> mornin' chromium
[13:17:58] *** dale1v has joined #chromium
[13:19:29] *** _sid_ has quit IRC
[13:23:19] *** dale1v has quit IRC
[13:29:02] *** dhastha has joined #chromium
[13:29:44] *** Adys has quit IRC
[13:30:26] *** Adys has joined #chromium
[13:34:41] <appamatto> morning, andybons
[13:34:45] *** appamatto has quit IRC
[13:35:03] <dhastha>  Marc-Antoine Ruel: are u there?
[13:35:41] *** holdenss has joined #chromium
[13:35:57] *** ivan has quit IRC
[13:43:49] *** kig_ has joined #chromium
[13:45:59] *** yutak has quit IRC
[13:48:21] *** thomasvl has joined #chromium
[13:48:21] *** ChanServ sets mode: +v thomasvl
[13:55:41] *** kenneth_reitz has joined #chromium
[13:59:27] *** flity has quit IRC
[14:07:06] *** tav has joined #chromium
[14:09:34] *** dhastha has quit IRC
[14:11:49] *** tonikitoo has joined #chromium
[14:12:37] *** tav has quit IRC
[14:13:21] *** tav has joined #chromium
[14:13:32] *** yutak has joined #chromium
[14:13:33] *** ChanServ sets mode: +v yutak
[14:27:51] *** Zucca has quit IRC
[14:28:07] *** Zucca has joined #chromium
[14:30:40] *** cbentzel has joined #chromium
[14:30:42] *** kenneth_reitz has quit IRC
[14:30:54] <andybons> thomasvl: ping
[14:31:31] <thomasvl> andybons: pong
[14:31:41] <andybons> three line review comin' atcha
[14:31:49] <thomasvl> the new extension failure?
[14:32:11] <andybons> thomasvl: hm? no
[14:32:13] <andybons> thomasvl: http://codereview.chromium.org/1555004
[14:32:25] <andybons> is there another one causing the browser_tests failures?
[14:32:37] <andybons> i reverted my change last night that was causing all that red
[14:33:30] <thomasvl> i'm crashing on launch again in extension code
[14:34:01] <andybons> sigh
[14:34:05] <andybons> yeah i have no idea what's up with that
[14:34:19] <andybons> aboodman was working on it last i checked
[14:34:37] <andybons> is it still hitting a NOTREACHED?
[14:35:02] <thomasvl> yup, new one
[14:35:09] <thomasvl> trying to find the bug to start dumping more info into it
[14:35:20] <andybons> gotcha
[14:37:53] <thomasvl> andybons: http://crbug.com/40017 updated (if you are curious)
[14:38:06] <andybons> thomasvl: cool. i'll take a look
[14:38:42] <thomasvl> andybons: i'll bet you can recreate with a new profile.  launch and let it sit long enough to do a blacklist update, then quit and launch again.
[14:38:56] <thomasvl> it was something about that state yesterday if I remember the comments right.
[14:39:12] *** artz has joined #chromium
[14:40:35] <rohitrao_> heading in to the office
[14:40:55] *** rohitrao_ has quit IRC
[14:46:25] *** yusukes has quit IRC
[14:52:43] *** sangho has joined #chromium
[14:52:53] *** tonikitoo has quit IRC
[14:53:57] *** Daviey has quit IRC
[14:53:57] *** Daviey has joined #chromium
[14:58:38] *** rsesek has joined #chromium
[14:59:19] <rsesek> thomasvl: ping
[15:03:41] <thomasvl> rsesek: pong
[15:04:47] <rsesek> thomasvl: could you take a look at Mac-Valgrind-UI-2? it's timing out during a build phase script. it was clobbered twice yesterday night to no avail. I'm thinking that the physical slave may need a restart and to have it's entire build directory removed
[15:05:04] <thomasvl> looking
[15:05:18] <rsesek> thanks
[15:05:20] *** zaspire has joined #chromium
[15:11:06] *** EGreg has joined #chromium
[15:12:13] <thomasvl> rsesek: bounced.  looks like the kills were leaving things hanging, we'll see how the next cycle does
[15:12:29] <rsesek> k, thanks
[15:14:22] <thomasvl> rsesek: build forced to also get things going
[15:15:03] *** pdelgallego has quit IRC
[15:18:07] <maruel> I'll commit compile.py, it may break the tree
[15:22:51] <maruel> I'll take a look at reliability update scripts
[15:23:58] *** miketaylr has joined #chromium
[15:25:06] <rsesek> thomasvl: I'm not sure if it matters, but that build is reporting: distcc[6775] (dcc_build_somewhere) Warning: failed to distribute, running locally instead
[15:26:05] <thomasvl> rsesek: looking
[15:26:23] *** artz has quit IRC
[15:30:36] *** Peter` has quit IRC
[15:31:07] *** rohitrao has joined #chromium
[15:31:08] *** ChanServ sets mode: +v rohitrao
[15:31:43] *** dmazzoni has joined #chromium
[15:35:32] *** Peter` has joined #chromium
[15:37:11] *** farda-13-bedare has joined #chromium
[15:39:35] <glider> maruel: could you please update the memory master when possible?
[15:40:12] *** kjg has joined #chromium
[15:41:29] <maruel> glider: I can try a reconfig?
[15:41:39] <glider> maruel: yes, sure
[15:45:32] *** tonikitoo has joined #chromium
[15:52:45] *** kjg has quit IRC
[15:53:16] *** RT|Chatzilla has quit IRC
[15:53:52] *** andybons has quit IRC
[15:54:24] *** RT|Chatzilla has joined #chromium
[15:56:10] *** thakis has joined #chromium
[15:56:10] *** ChanServ sets mode: +v thakis
[15:59:02] *** mrossetti has joined #chromium
[15:59:33] *** luke has joined #chromium
[15:59:51] <rsesek> thomasvl: the bot is healthy again ? thanks!
[16:00:01] *** luke is now known as Guest20365
[16:00:45] *** holdenss has quit IRC
[16:00:50] *** thakis_ has joined #chromium
[16:00:50] *** ChanServ sets mode: +v thakis_
[16:04:41] *** thakis has quit IRC
[16:04:41] *** thakis_ is now known as thakis
[16:12:09] *** Zaba has quit IRC
[16:13:09] *** paul_irish has joined #chromium
[16:14:56] *** Ruetobas has quit IRC
[16:15:42] *** EGreg has quit IRC
[16:15:50] *** Zaba has joined #chromium
[16:17:50] *** Ruetobas has joined #chromium
[16:18:33] *** stuartmorgan has joined #chromium
[16:18:33] *** ChanServ sets mode: +v stuartmorgan
[16:19:28] <rohitrao> is joth in here?
[16:19:35] *** kjg has joined #chromium
[16:20:43] *** thakis has quit IRC
[16:20:43] *** trungl_mbp has quit IRC
[16:20:46] <jorlow> rohitrao: he's on his way
[16:20:59] <rohitrao> extract build is failing on three of the windows bots
[16:23:02] *** joth has joined #chromium
[16:25:31] <joth> jorlow: ping
[16:25:41] <jorlow> rohitrao: ^^
[16:25:56] <rohitrao> joth: mac valgrind (ui) started failing after http://src.chromium.org/viewvc/chrome?view=rev&revision=43339 .  can you take a look?
[16:26:27] <joth> rohitrao: sure, looking now...
[16:27:24] <rohitrao> thanks
[16:27:42] *** farda-13-bedare has quit IRC
[16:28:09] <rohitrao> maruel, nsylvain, thomasvl: can any of you help with failed extract builds?
[16:28:19] <maruel> can look
[16:29:27] *** cleary_ has joined #chromium
[16:29:57] *** kwinz2 has quit IRC
[16:30:24] *** cleary has quit IRC
[16:31:44] *** trungl_mbp has joined #chromium
[16:31:51] *** andybons has joined #chromium
[16:33:27] *** fta has quit IRC
[16:35:52] <maruel> rohitrao: restarted the web serve ron codg26
[16:36:38] <rohitrao> maruel: ah, the testers weren't able to talk to the server which hosts the built files?
[16:36:44] <maruel> yes
[16:36:48] <trungl_mbp> Good morning, Chromium!
[16:36:51] <rohitrao> cool, thanks
[16:37:53] <joth> rohitrao: could you point me to the specific valgrind builder you saw problem in? I'm getting a bit lost in the noise and can't find anything related to my change amongst them
[16:38:17] <rohitrao> joth: Chromium Mac UI 1 and 3
[16:38:23] <rsesek> rohitrao/joth: the mac ui failure looks like a Foundation bug. you may need to suppress it as a category 1
[16:38:45] <rohitrao> joth: the failure doesn't look related to me either, but it happens on two bots and started after your change
[16:38:52] *** MikeSmithW3C has joined #chromium
[16:39:00] <rohitrao> rsesek: I can do that, but it would be nice to understand how we're triggering it first
[16:39:12] <rohitrao> rsesek: especially since the change looks unrelated :)
[16:39:13] <rsesek> rohitrao: agreed. I can't remember if it was this trace or a similar one that I'd seen before
[16:39:26] <maruel> looks better now
[16:39:57] <joth> yes. it's in UI tests, and my changes were to geolocation which isn't touched at all in ui tests (AFAIK)
[16:40:19] <rohitrao> I don't understand the stack traces at all, actually
[16:40:31] <rohitrao> since there isn't even any testing code on the stack
[16:41:11] <rsesek> rohitrao: UI tests launch the browser, don't they?
[16:41:41] <rohitrao> oh, is it in a completely separate process, and they talk through automation
[16:41:42] <rohitrao> ?
[16:41:53] <rsesek> rohitrao: based on this line, I think so:
[16:41:53] <rsesek> Command: /b/slave/chromium-rel-mac-valgrind-ui-3/build/src/xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium --no-first-run --no-default-browser-check --test-type=ui --enable-file-cookies --dom-automation --testing-channel=ChromeTestingInterface:90542.11 --noerrdialogs --homepage=about:blank --disable-web-resources --user-data-dir=/private/var/folders/pA/pAFAklSwHlKv-nkZRJzCU++++TM/-Tmp-/org.chromium.ltfUhb/test_user_data --me
[16:42:09] <rohitrao> ok, makes sense
[16:42:41] *** thakis has joined #chromium
[16:42:41] *** ChanServ sets mode: +v thakis
[16:43:09] *** kwinz2 has joined #chromium
[16:44:04] <rohitrao> maruel: is it safe to click "stop build" on the 10.6 builder to see what happens?  It's been stuck for hours
[16:44:57] <rohitrao> also, the reliability builder seems to have stopped running, although it says it's still connected
[16:48:54] <skerner> Does anyone speak Portuguese?  I am trying to understand crbug.com/34889 ...
[16:52:31] *** fta has joined #chromium
[16:52:50] *** kwinz2 has quit IRC
[16:52:58] <thomasvl> rohitrao: which mac bot?
[16:53:12] <thomasvl> the one way behind has kernel paniced
[16:53:25] <thomasvl> and the method we use to bounce them isn't letting any of us in.  :(
[16:53:29] <rohitrao> thomasvl: ah, i should've known
[16:53:46] <rohitrao> chromium reliability is also looking dead
[16:54:00] <rohitrao> as is linux tests (valgrind)(4)
[16:54:05] *** tedoc2000 has joined #chromium
[16:54:13] <rohitrao> and chromium os ui (valgrind)(4)
[16:57:11] <thakis> rohitrao: joth doesn't usually come here afaik
[16:57:47] <rohitrao> thakis: not true! i saw him!
[16:57:48] <rohitrao> :)
[16:57:49] *** EGreg has joined #chromium
[16:58:15] <rohitrao> I think I might have to let him off the hook for the valgrind failures, though
[16:58:23] <joth> SGTM :)
[16:58:31] <bulach> skerner: let me try that, one sec..
[16:58:54] <joth> I'm still looking at them, but not really making much sense of it
[16:59:33] <jorlow> having a Brazilian on the chrome team is finally paying off!
[16:59:42] <skerner> bulach: I put it through google translate, but I would prefer  human confirmation.
[16:59:50] <rohitrao> joth: valgrind 4 didn't see the failure at all, and valgrind 3 may have been ok on the next run
[17:00:06] <bulach> jorlow: yeah, second step after translating: meat and caipirinhas! :)
[17:01:18] *** jrmuizel has joined #chromium
[17:01:42] <bulach> skerner: the translation is a bit truncated, but I guess the 'core' information is there, that is, the button and the label are misaligned..
[17:02:48] <skerner> bulach: Okay, sounds like a known issue.  Thanks for confirming.
[17:05:14] <bulach> skerner: n.p.! (the translation back to the English label is obviously wrong, "archive private key" should be "private key file"..)
[17:07:46] <jar> Does anyone know what the story is with the Reliability Bot (which seems to be red for quite a while... because it can't get results?)
[17:08:02] *** kwinz2 has joined #chromium
[17:09:56] *** Rostislav has joined #chromium
[17:14:09] <rohitrao> ukai: ping, in case you're around
[17:15:47] <thomasvl> rohitrao: mac back online (don't ask)
[17:16:02] <rohitrao> haha, thanks
[17:17:21] <rohitrao> jar: I think r43331 may have broken chromium arm
[17:18:11] *** pdelgallego has joined #chromium
[17:19:18] <thomasvl> mmoss: yt?
[17:19:58] <rohitrao> jar: think it's fair to roll it out and see what happens? Doesn't look like ukai is around.
[17:20:00] *** vt100 has joined #chromium
[17:20:39] *** trungl_mbp has quit IRC
[17:20:47] *** trungl_mbp has joined #chromium
[17:21:33] <jar> rohitrao: When in doubt, revert....
[17:21:56] <jar> rohitrao: (Especially when you can't contact person who landed)
[17:22:19] <rohitrao> jar: do you see any other, more likely culprits?
[17:22:35] *** cyber_11 has joined #chromium
[17:22:40] <jar> rohitrao: I just came online... and haven't investigated.
[17:23:04] <rohitrao> ok, this is for the chromium arm compile failure
[17:24:09] <rohitrao> jar: many bots were broken earlier, but have come back now.  browser_tests on mac is going through a CHECK(!nestable_tasks_allowed_) phase, and two valgrind bots are still offline
[17:24:35] <rohitrao> jar: I'm sure I've forgotten something, but that;s the situation as I see it :)
[17:24:53] <cyber_11> nirnimesh: is around here?
[17:26:47] <jar> rohitrao: The error in stdio output is strange:  function net::KeygenHandler::GenKeyAndSignChallenge():net/base/keygen_handler_nss.cc:167: error: relocation overflow in relocation 10
[17:27:02] <jar> This looks like linker error of some sort.
[17:27:07] <rohitrao> yeah, I have no idea what that means
[17:27:15] <rohitrao> but it's consistently failing with that error
[17:27:20] <jar> Perhaps we need to clobber.
[17:27:31] <rohitrao> it looks like the bot already does a full build?
[17:27:36] *** MikeSmithW3C has quit IRC
[17:27:37] <rohitrao> worth a try though
[17:27:39] <thakis> rohitrao: indeed, there he is
[17:27:53] <thakis> rohitrao: must be an unusual day ? jar is here too and usually isn't
[17:28:05] <jar> (I assume arm mostly does incremental builds... does it clobber each time?... or did someone try that?)
[17:28:05] <rohitrao> thakis: he's co-sheriff ;)
[17:28:17] *** MikeSmithW3C has joined #chromium
[17:28:27] *** Bleak has quit IRC
[17:28:27] <thakis> oic
[17:28:45] <rsesek> thakis: I completely agree about the search engine editor. that screen shot looks leaps and bounds better.
[17:28:53] <rsesek> I'll throw a CL together sometime today
[17:29:07] <thakis> rsesek: ok, say that on the review please, so that danno doesn't' do it as well
[17:29:16] <rsesek> roger
[17:29:21] *** danno_ has quit IRC
[17:29:24] <thakis> thanks
[17:29:25] *** bauerb has quit IRC
[17:30:22] *** kwinz2 has quit IRC
[17:30:58] <rohitrao> jar: I'll force a clobber build
[17:32:04] *** sangho has quit IRC
[17:32:36] <thomasvl> rohitrao: i asked mmoss to check on the linux bots on memory waterfall
[17:32:39] <mmoss> I just rebooted a couple stuck bots
[17:32:45] <rohitrao> thanks!
[17:32:46] <mmoss> should be back up in a minute
[17:32:48] <thomasvl> right on queue.  :)
[17:32:54] <jar> rohitrao: I did the clobber on arm
[17:33:05] *** jrforbes has joined #chromium
[17:33:07] <rohitrao> jar: ok, let's see what happens
[17:33:35] <rohitrao> jar: the arm bot recompiles more per run than I expected it to, but I still didn't see base/ in the output
[17:33:42] <rohitrao> so clobbering will have some effect
[17:35:54] *** dglazkov has joined #chromium
[17:35:55] *** ChanServ sets mode: +v dglazkov
[17:36:09] <mmoss> is anyone kicking Builder Chromium Reliability? If not, I can
[17:36:48] <mmoss> err, actually maybe I can't
[17:36:52] *** Venom_X has joined #chromium
[17:37:11] <mmoss> that's not on vmware I think
[17:38:16] <jar> rohitrao: ukai with 43331 does indeed seem to be the turning point for Arm.  I'm not really expecting much from the clobber now :-/.   Do you want to set up to revert, or should I?
[17:39:02] <rohitrao> jar: I was about to head to lunch.  Were you going to wait for this build to finish before reverting?
[17:40:53] <jar> rohitrao: I'll revert 43331 (I'm now just too skeptical about the clobber... and we can always revert the revert if it does go green)
[17:41:13] <rohitrao> jar: sgtm
[17:41:47] *** jrforbes has quit IRC
[17:42:55] <jar> rohitrao: 43331 by reverted.
[17:43:55] *** thakis has quit IRC
[17:47:01] *** rafaelw has joined #chromium
[17:48:25] *** Guest20365 is now known as luke___
[17:49:00] *** kyle_ has joined #chromium
[17:49:10] *** urbanape has quit IRC
[17:50:26] <cyber_11> hi! i need to build pyauto but make src/chromium/test/pyautolib doesn't build it
[17:50:59] *** kyle_ is now known as kairu
[17:51:02] <mirandac> sheriffs: I have a grd change CL that will mean I have to clobber the winbuilders; ok if I do that now?
[17:51:52] *** thakis has joined #chromium
[17:51:52] *** ChanServ sets mode: +v thakis
[17:51:59] *** victorw has joined #chromium
[17:52:21] *** pdelgallego has quit IRC
[17:53:00] <cyber_11> are there anyone who is working on pyauto?
[17:54:02] <jar> mirandac: Go ahead and land.... you can try to get a clobber *and* a build of your landing in one cycle for extra points
[17:54:27] <mirandac> jar: :-)  I'll try for the bifecta...
[17:55:17] <jar> mirandac: I usually set up windows, each ready to click "clobber" and then land
[17:55:56] <mirandac> jar: yes, that's how glen taught me in the old days... only 3 to clobber, though, right?
[17:56:27] *** sswigart has joined #chromium
[17:56:35] <jar> jar: I'm not sure of the count... get the ones you can ;-)
[17:57:00] <cyber_11> mmoss: are you using vmware for your builds?
[17:57:20] <jar> mirandac: I would have thought you just had dbg and release on windows though
[17:57:23] *** luke___ has quit IRC
[17:57:58] *** zer0her0 has quit IRC
[17:58:14] <maruel> oh, I'll restart reliability
[17:58:36] *** zer0her0 has joined #chromium
[17:58:49] *** rafaelw has quit IRC
[17:59:19] *** fishd_ has joined #chromium
[17:59:19] *** ChanServ sets mode: +v fishd_
[18:00:54] <mirandac> jar: dbg and release, and then the chromium XP builder, in the very first square ... ?
[18:01:51] *** asac has quit IRC
[18:02:12] *** tfarina has joined #chromium
[18:04:01] *** asac has joined #chromium
[18:04:21] *** urbanape has joined #chromium
[18:05:30] *** mmoss has left #chromium
[18:05:31] *** kellegous has joined #chromium
[18:06:06] *** mmoss has joined #chromium
[18:06:13] *** kenneth_reitz has joined #chromium
[18:06:54] *** kenneth_reitz has joined #chromium
[18:07:13] *** dmaclach has quit IRC
[18:08:03] <cyber_11> how do we build pyauto.target.mk file?
[18:09:47] *** theliet has quit IRC
[18:10:51] *** yurys has quit IRC
[18:11:54] <kjg> I searched the tickets but couldn't find this one, but I couldn't imagine it was unknown. Is it known that in the latest dev channel release for mac that flash 10.1 b3 doesn't seem to recognize drag events?
[18:13:11] <rohitrao> I've heard complaints about that before
[18:13:15] <rohitrao> I suspect it's known :)
[18:13:59] <evmar> cyber_11: i'm not sure why you're having so much trouble.  literally hundreds of people have successfully built chrome by just following the build instructions
[18:15:12] <cyber_11> evmar: i don't know yet, i'm following the instructions as everyone
[18:15:24] <cyber_11> but pyauto doesn't work
[18:15:29] <cyber_11> i can build chromium fine
[18:15:48] *** brettw has quit IRC
[18:15:51] <cyber_11> i couldn't deal with the pyauot yet
[18:15:55] <thomasvl> cyber_11: did you do anything custom to your python setup?
[18:16:02] <evmar> cyber_11: ah, i've never built pyauto
[18:16:03] <cyber_11> no
[18:16:11] <thomasvl> cyber_11: 10.5 or 10.6?
[18:16:23] <thomasvl> all our builders are 10.5 at this piont, so 10.6 may not be tested
[18:16:42] <cyber_11> thomasvl: i'm using ubuntu rigth now not mac yet
[18:16:53] <maruel> fixing a few linux slaves
[18:17:03] <maruel> fixing a few linux /try/ slaves
[18:18:17] *** glider has quit IRC
[18:18:57] <dglazkov> good morning, Chromium!
[18:19:01] <dglazkov> and fellow Topekans
[18:19:20] <thakis> good morning, dglazkov!
[18:19:37] <aboodman> for april fools this year the extensions team decided to only let chrome startup once without crashing.
[18:19:41] <aboodman> ha ha.
[18:19:59] <dglazkov> "I've been to Topeka sir, and it's no Google"
[18:22:47] <rohitrao> trungl: I see you there, trying to break the build
[18:23:07] <thomasvl> rohitrao / jar : on mac may hiccup, trying something
[18:23:08] <rohitrao> at least, that's what I assume you're trying to do
[18:23:09] <trungl> rohitrao: today seems like a good day to break the build
[18:23:25] <trungl> rohitrao: if I don't succeed this time, I'll try again
[18:23:37] * trungl might try again regardless of his success this time.
[18:23:38] <rohitrao> I have this sudden urge to watch a klingon episode
[18:26:05] *** fishd_ has quit IRC
[18:29:03] *** johnny_g has joined #chromium
[18:29:16] *** fqian has joined #chromium
[18:31:55] *** snej has joined #chromium
[18:32:02] *** arv has joined #chromium
[18:32:21] *** markmentovai has joined #chromium
[18:32:21] *** ChanServ sets mode: +v markmentovai
[18:32:44] <cyber_11> thomasvl: yesterday i've built pyauto, but i got segmentation fault for each test file
[18:32:53] *** evmar has quit IRC
[18:33:04] <cyber_11> thomasvl: do you have any idea what could it be?
[18:35:15] <thomasvl> cyber_11: haven't played with it directly.  nirnimesh or jrg might be able to hep when they are around.  having info about what python version, etc will probably help them.
[18:35:47] <jrg> cyber_11: around.  Tell me more; e.g. platform, command you tried, etc.
[18:35:57] <jrg> cyber_11: any info on error other than segv?
[18:36:42] *** dmaclach has joined #chromium
[18:36:44] <maruel> doing a mass cleanup to get rid of the update scripts redness
[18:37:04] <aboodman> andybons: who were you talking to about the startup crash (sorry irc fu failing me)
[18:37:09] <cyber_11> jrg:./base/test/test_suite.h:162: Failure
[18:37:09] <cyber_11> jrg:Backtrace:
[18:37:09] <cyber_11> 	StackTrace::StackTrace() [0xb5770dae]
[18:37:20] <aboodman> whoever they were, i've submitted a new patch for it, i think it should fix it.
[18:37:24] <aboodman> apologies.
[18:37:34] <andybons> aboodman: no worries. it was thomasvl
[18:37:48] *** cying has joined #chromium
[18:38:05] <cyber_11> jrg: there are lots of hex codes and a segmentation fault
[18:38:24] <jrg> cyber_11: platform (be specific)?  Exact command line?
[18:38:30] <andybons> aboodman: wasn't affecting me :D. thanks for the patch, though
[18:38:55] <cyber_11> jrg: i'm using ubuntu on vmware
[18:39:13] <cyber_11> jrg: for running pyauto python2.5 test_auto.py
[18:40:02] <jrg> cyber_11: did you GYP_DEFINES="linux_fpic=1" gclient runhooks?
[18:40:06] <mmoss> who maintains the chromeos valgrind bots?
[18:40:28] <cyber_11> jrg: in which folder?
[18:40:57] <jrg> cyber_11: top level before doing a compile.  See "Linux" on http://dev.chromium.org/developers/pyauto
[18:41:14] *** evmar has joined #chromium
[18:41:14] <cyber_11> jrg:  GYP_DEFINES="linux_fpic=1" i've tried but gclient runhooks i didn't work on it
[18:41:26] <mmoss> or the mac valgrind bots for that matter
[18:41:34] <jrg> cyber_11: not sure I understand that
[18:41:47] <jrg> mmoss: what is problem with mac valgrind?  Hanging?
[18:42:09] <mmoss> jrg: no, just a configuration question
[18:42:43] <jrg> mmoss: nirnimesh markmentovai thomasvl can probably answer
[18:42:52] *** kenneth_reitz has quit IRC
[18:42:53] <mmoss> jrg: any reason there are 4 bots all doing compiles, instead of separate builder/testers like the linux builders
[18:43:06] <thomasvl> mmoss: because the dsym is huge
[18:43:15] <thomasvl> we didn't want to copy that around
[18:43:22] *** pocketprotector has quit IRC
[18:43:33] <thomasvl> when we move to 10.6 for builders, mark and i might revisit it.
[18:44:15] <mmoss> really, that huge? so it takes more than a couple mins to copy?
[18:44:28] *** dave_levin has quit IRC
[18:44:30] <rsesek> is copying the binary less time than compiling?
[18:44:35] *** dave_levin has joined #chromium
[18:45:51] <mmoss> thomasvl: any idea if chromium os is for the same reason? seems that should be more like the regular linux valgrind bots
[18:46:20] <thomasvl> mmoss: don't know there
[18:47:06] *** monreal has joined #chromium
[18:47:34] <cyber_11> jrg: same seg fault again...! what if i update python to 2.6? can i run with 2.6 version of python?
[18:48:30] <jrg> cyber_11: the pyauto is built with specific python headers.  You need to have the cmd-line python you run be the same version as the headers used for pyauto.
[18:49:04] <jrg> cyber_11: see if you can look in the Makefile to identify where the py headers are coming from for pyauto, and be sure your cmd line py is the same one.
[18:49:04] <jrg> c
[18:49:04] <jrg> ybe
[18:49:05] <jrg> r
[18:49:31] *** shreyas has quit IRC
[18:49:34] <jrg> cyber_11: not sure that's your problem but it would be my guess.  /me wishes there was a quick "sanity check" to tell you the answer for this; I'll talk with nirnimesh about it.
[18:50:08] <cyber_11> jrg: ok thanks...
[18:53:38] *** bent-mozilla has joined #chromium
[18:54:30] *** shreyas has joined #chromium
[18:54:39] *** Venom_X has quit IRC
[18:57:57] <thakis> jrg: here's a pyauto problem on the trybots, courtesy of joth: http://build.chromium.org/buildbot/try-server/builders/mac/builds/24939/steps/compile/logs/stdio
[18:58:02] <thakis> did you break something again?
[18:58:18] <jrg> thakis: I break things all the time but not sure this one was me
[18:58:25] <rohitrao> jar: cool, looks like reverting worked
[18:58:49] <jrg> thakis: not it but will help
[18:58:59] <jrg> thakis: I need a few min tho
[19:00:53] *** theliet has joined #chromium
[19:00:58] <rohitrao> ehehehe
[19:01:18] * rohitrao wrote an extension that listens for ctrl-L and pops up a "go to location" javascript prompt
[19:01:44] *** Venom_X has joined #chromium
[19:01:46] *** bweinstein has joined #chromium
[19:01:50] *** MikeSmithW3C has quit IRC
[19:02:24] <rohitrao> andybons: who gets to be the new you for a month?
[19:03:26] <rohitrao> motownavi: I think your change is ok wrt browser_tests
[19:03:30] <thakis> windows folks: what's the irc client of choice on windows?
[19:03:35] <rohitrao> mIRC!
[19:03:44] <rohitrao> I am 14 again
[19:03:55] <sig11> XiRCON was always my favorite
[19:03:58] <jrg> rsesek: http://codereview.chromium.org/1585010  thx for finding it
[19:04:29] *** kwinz2 has joined #chromium
[19:05:52] * trungl didn't have IRC when he was 14.
[19:08:53] <thakis> rohitrao: mIRC seems to be shareware and expires these days. i was told.
[19:08:57] *** glider has joined #chromium
[19:09:18] <rohitrao> sad
[19:09:37] *** glider has quit IRC
[19:10:56] *** kjg has quit IRC
[19:11:36] *** thakis has quit IRC
[19:12:51] *** cyber_11 has quit IRC
[19:15:24] *** RT|Chatzilla has quit IRC
[19:16:35] *** cyber_11 has joined #chromium
[19:19:54] <motownavi> rohitrao: so do I; that's why I committed and walked away from the keyboard :)
[19:21:17] *** loislo has quit IRC
[19:27:43] *** jamesr has joined #chromium
[19:27:51] <jar> rohitrao: I'm not liking how many browser_tests are failing to complete.... I'm wondering if there was a checkin causing problems.
[19:27:58] *** jamesr has quit IRC
[19:28:02] <rohitrao> jar: known awfulness
[19:28:17] <rohitrao> we need to rework how browser_tests are run on the mac, basically :)
[19:28:50] <jar> rohitrao: It is both mac and linux
[19:29:29] <rohitrao> jar: linux failures are unexpected
[19:30:54] <joth> rohitrao: quick heads up, I'm about to land http://codereview.chromium.org/1524006 -- grd change so bots will probably need a clobber.
[19:31:05] *** Kunalagon1 has joined #chromium
[19:31:09] <jar> rohitrao OK... avi's landing (blamed for the linux red) was a mac-only change.... so perchance it is coincidence.
[19:31:30] <rohitrao> joth, jar: ok, who's in charge of clobbering? :)
[19:31:47] <rohitrao> jar: seems coincidental.  I'm trying to hunt down the mac failures email thread for you
[19:35:10] <nirnimesh> cyber_11: hey
[19:35:13] <jar> rohitrao: Do you need stuff clobbered?
[19:35:24] <cyber_11> nirnimesh: hi!
[19:35:29] <rohitrao> jar: joth said he might
[19:36:04] <jar> joth: Please try to land and clobber at same time... or can't you clobber?
[19:36:07] <nirnimesh> cyber_11: any luck with your pyauto problem?
[19:36:25] <cyber_11> nirnimesh: not yet...
[19:36:48] <andybons> rohitrao: hm. maybe mirandac is up for the job?
[19:37:14] <rohitrao> andybons: ok. I told skerner to cc me on all the bugs too
[19:37:32] <andybons> rohitrao: well just make sure mirandac is cool with that :)
[19:37:38] <cyber_11> nirnimesh : i was thinking that it could be swig issue
[19:37:55] <nirnimesh> cyber_11: are you still stuck with the seg fault?
[19:38:05] <cyber_11> nirnimesh: yeap
[19:38:24] *** stevenjb has quit IRC
[19:38:27] <nirnimesh> cyber_11: can you tell me your machine config please?
[19:38:36] *** jamesr has joined #chromium
[19:39:36] <cyber_11> it's vmware virtual machine 30gb hd, 4 proccessors, 1660 mb ram
[19:40:05] <mirandac> rohitrao: andybons: what's the job under consideration?
[19:40:10] <nirnimesh> 64 bit?
[19:40:17] <rohitrao> mirandac: general being-andybons-ness
[19:40:25] <nirnimesh> cyber_11: 64 bit?
[19:40:26] <cyber_11> nirnimesh: no it's 2 bit
[19:40:31] <cyber_11> 32
[19:40:41] <andybons> mirandac: so basically just moving your mouse around for most of hte day
[19:40:44] <nirnimesh> ok. let me look into this problem today
[19:40:56] <mirandac> rohitrao: heh  :-)
[19:41:19] <cyber_11> nirnimesh : ok. What will you check?
[19:41:25] <andybons> mirandac: just finishing up extensions feature parity for now
[19:41:37] <nirnimesh> cyber_11: the locale thingy
[19:41:56] <nirnimesh> cyber_11: I'll see if I can repro on a machine here
[19:42:11] <jar> joth: I've forced a clobber to handle your GRD landings... so it will only (hopefully) go red for one cycle.  It is best to do the clobber and the landing at the same time (you have a 30 second window).
[19:42:11] <mirandac> andybons: ah, I see... working on this windows search engine experiment thingy for the next few days, but I can take stuff on after that...
[19:42:33] *** tbassetto has quit IRC
[19:43:53] *** yurys has joined #chromium
[19:43:58] <Tusk> is there some extension that checks that other extensions are up to date??
[19:44:10] <cyber_11> nirnimesh: ok. i'll be waiting for it, if you have get any solution or something you can pvtmsg me
[19:44:16] <rsesek> jrg: np. thanks for the quick fix
[19:44:41] *** maikmerten has joined #chromium
[19:45:08] <joth> jar: yep I was too slow, not familiar enough with the process for clobbering.... thanks for doing it
[19:46:10] *** feldstein has joined #chromium
[19:46:48] <rohitrao> i never know when grd changes need a clobber
[19:46:55] <rohitrao> this run seems to have survived ok?
[19:47:01] <rsesek> rohitrao: generally when the resource IDS change
[19:47:12] <rsesek> er IDs
[19:47:32] <thomasvl> rsesek: on windows.
[19:47:35] <rsesek> yes
[19:47:39] <thomasvl> other platforms seem to be ok.
[19:47:39] <rsesek> that's key
[19:51:17] *** bent-mozilla has quit IRC
[19:51:20] <jar> joth: As it turns out, the build didn't go red.  It is now doing the clobber builds.
[19:52:47] *** cyber_11 has quit IRC
[19:52:54] *** rafaelw has joined #chromium
[19:53:45] *** bent-moz has joined #chromium
[19:53:52] <joth> jar: spoke to soon? it just auto closed
[19:54:43] *** fishd_ has joined #chromium
[19:54:43] *** ChanServ sets mode: +v fishd_
[19:54:53] <jar> joth: ah... compile works... but unit tests expose problem.
[19:55:10] <joth> jar: yeah that's what i've seen previous times
[19:56:37] <joth> i've got to go offline for a bit but bulach should be back shortly
[19:56:44] <jar> joth: The clobber's were already running... so we'll be back open sooner (at least)
[19:56:45] *** hbridge has joined #chromium
[19:57:44] *** mpcomplete has joined #chromium
[19:57:44] *** ChanServ sets mode: +v mpcomplete
[19:57:48] *** eseidel has joined #chromium
[19:57:55] *** drobbins has quit IRC
[19:57:55] *** drobbins has joined #chromium
[19:57:56] *** cyber_11 has joined #chromium
[20:02:42] *** fishd_ has quit IRC
[20:04:31] *** Kunalagon1 has quit IRC
[20:05:34] *** Kunalagon1 has joined #chromium
[20:06:44] *** pfeldman has quit IRC
[20:12:05] *** Kunalagon1 has quit IRC
[20:12:40] <thomasvl> who knows about page cycler database?
[20:13:33] *** Kunalagon1 has joined #chromium
[20:14:04] *** bevc_work has joined #chromium
[20:15:25] <chase> thomasvl: the page cycler database?  or the database page cycler?
[20:15:35] *** ChanServ sets mode: +v chase
[20:15:41] <thomasvl> chase: page_cycler_database
[20:16:18] <chase> thomasvl: dumi wrote it, i reviewed some of the patches
[20:17:39] <thomasvl> chase: just filed http://crbug.com/40123 (added you as a cc)
[20:18:37] *** mfinkle has quit IRC
[20:18:48] <chase> thomasvl: thanks, not sure if there's a bug on file, dumi's been looking into this
[20:19:06] <thomasvl> ok, i did a quick search and didn't find one
[20:19:27] <thomasvl> chase: know why it's not on all platforms?
[20:24:38] *** loislo has joined #chromium
[20:24:56] *** cira_mac has joined #chromium
[20:28:37] *** kjg has joined #chromium
[20:29:07] *** mfinkle has joined #chromium
[20:29:39] *** mnissler has quit IRC
[20:30:10] <rohitrao> estade: does base/gfx not exist for chromiumos?
[20:30:45] <estade> uh crap, does it?
[20:30:57] <estade> I tried that patch on linux_view but not chromeos
[20:31:34] <rohitrao> did base/gfx move to plain old gfx?
[20:31:43] <estade> yes
[20:32:03] <rohitrao> that would explain it
[20:32:51] *** cbentzel has quit IRC
[20:33:48] *** kellegous_ has joined #chromium
[20:35:10] <jar> estade: rather than a fix... are you just reverting?
[20:35:16] <estade> too late
[20:35:18] *** cying has quit IRC
[20:35:18] <estade> fix in
[20:35:19] <evmar> trungl: infobar looks great on linux, thanks for implementing it
[20:37:02] *** slifin has quit IRC
[20:37:20] *** seventh has quit IRC
[20:38:16] *** kellegous has quit IRC
[20:38:17] *** kellegous_ is now known as kellegous
[20:39:51] *** trungl_phone has joined #chromium
[20:40:02] *** maikmerten_ has joined #chromium
[20:40:11] <estade> jar, rohitrao: think we can open (at least as far as chromeos is concerned)
[20:40:32] <rohitrao> done
[20:40:38] *** BeZerk has quit IRC
[20:41:09] *** kellegous_ has joined #chromium
[20:41:09] *** kellegous has quit IRC
[20:41:10] *** kellegous_ is now known as kellegous
[20:41:14] <chase> thomasvl: no, we're not sure yet, an interesting bug for sure
[20:41:27] *** BeZerk has joined #chromium
[20:43:50] *** maikmerten has quit IRC
[20:43:57] <jar> viettrungluu: are you watching redness in Mac10.6 Perf(1)?
[20:45:02] <trungl_phone> Uh should I?
[20:45:34] <rohitrao> trungl_phone: I knew it!
[20:45:53] <cyber_11> nirnimesh: are there any improvements?
[20:46:06] <trungl_phone> You knew what?
[20:46:16] <rohitrao> you are trying to break the build!
[20:46:18] <nirnimesh> cyber_11: I'll get back to you
[20:49:02] *** taf2 has quit IRC
[20:49:25] <trungl_phone> rohitrao: don't say I didn't warn you
[20:49:42] *** sshc has quit IRC
[20:50:35] *** cbentzel has joined #chromium
[20:54:10] *** bent-moz_ has joined #chromium
[20:54:37] *** kellegous_ has joined #chromium
[20:54:37] *** kellegous has quit IRC
[20:54:38] *** kellegous_ is now known as kellegous
[20:56:03] <rohitrao> can I just disable the most-often-failing browser tests?
[20:56:36] *** jam2 has joined #chromium
[20:56:48] *** bent-moz has quit IRC
[20:56:50] *** bent-moz_ is now known as bent-moz
[20:57:28] *** CosmiChaos has joined #chromium
[20:57:39] *** AndChat| has joined #chromium
[20:57:51] *** trungl_phone has quit IRC
[20:58:40] *** eseidel has quit IRC
[20:58:46] *** hbridge has quit IRC
[20:58:55] *** AndChat| has quit IRC
[20:58:58] *** trungl_phone has joined #chromium
[21:00:15] <jar> rohitrao: The massive number of Mac red bots is REALLY making it hard to tell what is going on... so I'm very in favor of doing something.
[21:00:59] *** trungl_phone has quit IRC
[21:02:00] *** kellegous_ has joined #chromium
[21:02:00] *** kellegous has quit IRC
[21:02:01] *** kellegous_ is now known as kellegous
[21:04:09] *** coachz has joined #chromium
[21:04:27] <coachz> chrome in fedora won't let me print landscape ..... any ideas peoples ?
[21:04:35] <coachz> orientation is grayed out
[21:04:38] *** alokp has joined #chromium
[21:04:58] <jar> rohitrao: Who exactly is working on the Mac redness??  This didn't start the day looking so terrible.
[21:05:25] <rohitrao> jar: it's been flaky for weeks, although not quite this bad
[21:05:45] <rohitrao> a bunch of people are looking at it, although I don't know if there's a concrete solution yet
[21:06:04] <rohitrao> jar: search for an email titled "nestable_tasks_allowed on the Mac issues"
[21:06:48] <jar> rohitrao:  OK... I'm familiar with that thread.  Why is the tre so much more red now than this morning?
[21:06:58] <rohitrao> I don't know
[21:07:09] <rohitrao> something made this much worse in the last few days
[21:07:15] *** fmeyer has joined #chromium
[21:08:03] *** cbentzel has quit IRC
[21:08:08] <trungl> rohitrao: did I manage to break the tree?
[21:08:13] <trungl> rohitrao: or do I have to try again?
[21:08:22] <rohitrao> trungl: it's hard to tell what's real breakage :)
[21:08:38] <trungl> rohitrao: maybe I should make everything go red
[21:08:43] <rohitrao> great
[21:08:49] <rohitrao> was there a perf regression? did you look?
[21:09:44] *** victorw has left #chromium
[21:10:32] <coachz> Is landscape printing broken in Chrome on Fedora ?
[21:10:37] *** oKtosiTe has joined #chromium
[21:10:38] *** oKtosiTe_ has joined #chromium
[21:11:33] *** kellegous has quit IRC
[21:11:39] *** kellegous has joined #chromium
[21:11:45] *** Ryushin has joined #chromium
[21:11:47] *** slightlyoff has joined #chromium
[21:11:48] *** ChanServ sets mode: +v slightlyoff
[21:12:05] *** Ryushin has left #chromium
[21:12:31] <coachz> i just confirmed that landscape printing is broken in fedora and ubuntu.  what a bunch of crap
[21:12:43] <coachz> how retarded
[21:13:07] <selckin> print is obsolete technology
[21:13:12] <coachz> bullshit
[21:13:17] <coachz> total
[21:13:46] <coachz> or have you never been to Barns and Noble
[21:14:13] <selckin> too easy
[21:14:14] *** kellegous has quit IRC
[21:14:14] *** loislo has quit IRC
[21:14:36] *** kellegous has joined #chromium
[21:14:40] <rsesek> where's thakis?
[21:15:29] *** loislo has joined #chromium
[21:18:47] *** pfeldman has joined #chromium
[21:18:55] <rohitrao> jar: looks like there was an attempt to disable these tests yesterday :)
[21:20:38] *** kellegous has quit IRC
[21:20:45] *** kellegous has joined #chromium
[21:25:03] *** stiwari has joined #chromium
[21:25:43] *** coachz has left #chromium
[21:25:44] <rohitrao> alokp: ping
[21:25:46] *** cbentzel has joined #chromium
[21:26:08] <stiwari> Quick Question: What is the best way to build chrome from source? Is it by downloading the tarball or by doing an svn checkout?
[21:28:00] <jamesr> stiwari: follow the build instructions for your OS http://www.chromium.org/developers/how-tos
[21:28:31] *** kwinz2 has quit IRC
[21:29:43] <rohitrao> alokp: I'm reverting your change in ~2min
[21:30:43] *** kellegous has quit IRC
[21:30:44] *** kellegous_ has joined #chromium
[21:30:53] <rohitrao> skerner: http://codereview.chromium.org/1603003/show
[21:31:49] *** kellegous has joined #chromium
[21:31:50] *** kellegous_ has quit IRC
[21:33:47] *** maikmerten_ has quit IRC
[21:34:13] <skerner> rohitrao: lgtm
[21:34:38] <pkasting_> Why has the bookmark bar disappeared on the NTP
[21:34:47] <rohitrao> what OS?
[21:34:53] <pkasting_> Win
[21:34:54] <pkasting_> trunk
[21:35:21] <pkasting_> Glen/Cole say "not intentional, we dunno"
[21:35:29] <stiwari> jamesr: I have followed the instructions on the linux page (I am on Debian). I am having trouble building it (downloaded the tar ball and got build errors). Hence, I was wondering whether the "svn checkout" method was better. I have taken care of the pre-requisites.
[21:35:41] <rohitrao> none of today's CLs sounded like they would've touched any of that code
[21:36:17] <jamesr> stiwari: both methods should work. are you sure you did the gclient sync stuff correctly?
[21:36:43] <jamesr> the tarball is basically a way to jump-start an svn checkout
[21:36:55] <jamesr> the results should be bit-for-bit identical once you do your first gclient sync
[21:37:09] <pkasting_> rohitrao: I think it was a day or two ago
[21:37:31] <pkasting_> Since my yesterday's build shows it too
[21:39:21] <alokp> rohitrao:thanks
[21:39:54] <stiwari> jamesr: Thank you, I must have made a mistake somewhere then, because I seem to have done the gclient sync stuff. I'll try that again. Thanks again!
[21:40:57] <trungl> rohitrao: I'm trying a third time to break everything
[21:41:11] <rsesek> trungl: you're really becoming a bustage expert
[21:41:37] <trungl> rsesek: I wouldn't say *expert*: after all, I haven't (verifiably) succeeded (yet!)
[21:41:43] *** kwinz2 has joined #chromium
[21:41:46] <rsesek> heh
[21:41:54] <rsesek> maybe you'll get lucky with this grd change
[21:43:49] *** ivan has joined #chromium
[21:44:28] *** drobbins has quit IRC
[21:46:27] <rohitrao> closing for backlog
[21:46:28] * trungl knows how to clobber, unfortunately.
[21:46:42] * trungl clobbers rohitrao.
[21:48:06] *** Solar_Flare has joined #chromium
[21:48:20] <Solar_Flare> hi. I have a problem witht he chromium browser, is this the right channel?
[21:48:38] <jamesr> Solar_Flare: check the channel topic
[21:48:42] *** kellegous has quit IRC
[21:48:48] *** kellegous has joined #chromium
[21:49:37] *** Solar_Flare has left #chromium
[21:55:09] *** mpcomplete has quit IRC
[21:57:38] *** urbanape has quit IRC
[21:58:00] *** jlouie has joined #chromium
[21:58:28] <bgmerrell> evmar: hey?
[21:58:32] <evmar> bgmerrell: hi
[21:59:22] <bgmerrell> evmar: i saw that that commit (43277) got reverted but then it got commit again?  I also got an e-mail about a test breaking.. I am so confused :)
[21:59:43] <evmar> bgmerrell: a test failed when i committed, so it was reverted, but it turned out hte test failed for unrelated reasons
[21:59:54] <evmar> so i recommitted it
[21:59:57] <bgmerrell> i was here last night bugging someone about trying to find the test that failed, and then i finally noticed that the code had been re-committed.
[22:00:43] <bgmerrell> okay.. so do you just look at the waterfall to see if it was unrelated or run the tests locally?  I'm just wondering how to better tell if I break something.
[22:01:20] <rohitrao> dglazkov: are layout test expectations totally upstream now?
[22:01:30] <shess> Anyone out there make a Mac change to tracking areas in the past few weeks.  http://crbug.com/38441 would appreciate any suggestions.
[22:01:42] <dglazkov> rohitrao: yes, but I wanna see how you can make it interesting for me
[22:01:48] <evmar> bgmerrell: i looked at the waterfall.  the next few runs of the test (before your commit went through) were green
[22:01:58] <rohitrao> dglazkov: 1) awesome.  2) how do I kill extend_selection on win? :)
[22:02:13] <shess> [I have a post-mstone-5 thing to checkin which will help debug such things, but it's a bit intrusive to consider for now.]
[22:02:28] <bgmerrell> evmar: also, you mentioned there was some out-of-process importing code for Mac.  Do you know where I could find that code?
[22:02:34] <bgmerrell> evmar: ah, okay, thanks.
[22:02:57] <evmar> rohitrao, shess: ^^^ see bgmerrell question
[22:02:59] <dglazkov> rohitrao: there are two ways
[22:03:17] <dglazkov> rohitrao: tell today's gardener so that he marks it as flaky (that's fishd)
[22:03:24] <dglazkov> rohitrao: that was 1)
[22:03:54] <dglazkov> rohitrao: 2) mark it as flaky in src/webkit/tools/layout_tests/test_expectations as flaky and tell Darin you did it, so that he cleans it up for you after roll
[22:04:03] <dglazkov> ^^^ that's an override
[22:04:15] <rohitrao> ah, so there are two places for expectations now?
[22:04:18] <shess> mirandac: if evmar means the importer, does that mean you?
[22:04:33] <rohitrao> dglazkov: thanks
[22:04:36] <rohitrao> bulach: ping
[22:04:55] <evmar> shess: i forget who did the multiproc mac import, was it maybe mark?
[22:05:06] <evmar> i don't even remember why it was done
[22:05:22] <rohitrao> bulach: nevermind, the test i was going to pin on you looks flaky
[22:05:39] <rsesek> evmar: I think it was mirandac
[22:05:44] <shess> evmar: I was going to say playmobil, but I think mirandac has most recently been touching importer.
[22:05:55] <bulach> rohitrao: :)
[22:06:17] <rsesek> bgmerrell, evmar: http://codereview.chromium.org/502045/show
[22:06:48] *** taf2 has joined #chromium
[22:07:11] <rohitrao> finnur: objections to marking ExtensionsApiTest.Infobars as flaky?
[22:08:12] <evmar> bgmerrell: i just wouldn't worry about it for now, i guess
[22:08:30] <evmar> bgmerrell: i'm a little surprised you need the import-file flag given you got the master prefs stuff working...
[22:09:09] *** quma has joined #chromium
[22:09:49] *** seventh has joined #chromium
[22:11:23] *** MissAlyx| has joined #chromium
[22:11:24] *** MissAlyx| has quit IRC
[22:11:24] *** MissAlyx| has joined #chromium
[22:11:28] *** alyxuk has quit IRC
[22:13:45] <bgmerrell> evmar: well, the way that bookmark importing is done in windows is to add the bookmark file path to master_preferences, and then run LaunchApp with the --import-from-file command-line argument.
[22:13:55] <evmar> oh, i see
[22:14:04] <evmar> er, wait, no, i don't see
[22:14:11] <evmar> our bookmark importing works already, doesn't it?
[22:14:14] *** TheEggMan has joined #chromium
[22:14:14] *** TheEggMan has quit IRC
[22:14:40] *** roc has joined #chromium
[22:15:59] <bgmerrell> evmar: Not sure that I understand your question.  Currently, you can do a silent import with --import-from-file in Windows and Linux.  But only Windows supports using the master_preferences file to import bookmarks.
[22:16:43] <bgmerrell> i am now working on a patch to implement the master_preferences bookmark import capability for Linux.
[22:16:45] <evmar> oh, you're saying that master_prefs specifies a file to import, and that import is done via import-from-file?
[22:16:52] <bgmerrell> yes
[22:16:54] <evmar> awesome
[22:17:13] <bgmerrell> i'm running into some weirdness with LaunchApp for linux.  hopefully i'm just passing the wrong arguments.
[22:17:36] <bgmerrell> i'll hopefully be able to hack on it tomorrow
[22:17:52] <evmar> btw, is novell one of the pro-mono or anti-mono companies?
[22:18:02] <evmar> i guess you have that patent grant from ms or whatever, right?
[22:18:47] <bgmerrell> evmar: Novell is very pro-mono
[22:19:04] <bgmerrell> the mono author works here, and we have mono teams that work on mono full time.
[22:19:08] *** roc has quit IRC
[22:19:12] <evmar> bgmerrell: we have a bug complete with a nice reduced test case that is prevent moonlight from working, hadn't have time to look at it yet :(
[22:19:17] <evmar> *preventing
[22:20:49] <bgmerrell> evmar: interesting, i work on the moonlight Firefox plugin here occasionally.  (We develop/support moonlight here.)
[22:21:03] <bgmerrell> i'll search for it
[22:21:19] <evmar> i am really embarrassed i haven't fixed it, the bug report was flawless
[22:21:22] <evmar> just too much stuff to do
[22:21:50] <rohitrao> trungl: redness is grd change?
[22:22:05] <evmar> bgmerrell: http://code.google.com/p/chromium/issues/detail?id=32797 , just in case you didn't see it
[22:22:38] *** urbanape has joined #chromium
[22:22:51] <bgmerrell> thanks, reading now
[22:23:15] <evmar> plugins are super complicated, so it's a bit hard to dive into, but there it is anyway
[22:23:19] <trungl> rohitrao: looking
[22:23:35] *** sshc has joined #chromium
[22:24:21] <bgmerrell> evmar: it will give me something to look at after i finish the bookmark stuff.. i was going to miss working on chromium if I couldn't think of anything else to work on ;)
[22:24:33] <trungl> rohitrao: looks like it, though I did theoretically clobber
[22:24:40] <trungl> rohitrao: (I swear)
[22:24:50] <rohitrao> yeah, the failures are pre-clobber
[22:24:56] <trungl> rohitrao: hrm
[22:24:56] <rohitrao> looks like you succeeded
[22:25:02] <trungl> yay!
[22:25:13] * trungl 's mother would be proud of his success
[22:25:29] *** peterdn has quit IRC
[22:25:43] *** Venom_X_ has joined #chromium
[22:25:54] <jar> rohitrao: Can you clarify in status why you opened with so much red still pending?
[22:26:35] <rohitrao> jar: done
[22:27:30] *** roc has joined #chromium
[22:28:10] <trungl> rohitrao: what's the right way to turn a char* C string to an NSString? is it really [NSString stringWithFormat:@"%s", my_string] ?
[22:28:23] *** romainhuet has quit IRC
[22:28:28] *** fta has quit IRC
[22:28:38] <akalin> isn't there a stringFromUTF8 method somewhere
[22:28:50] <akalin> assuming your char* string is UTF8/ASCII
[22:28:53] <rsesek> trungl: [[NSString alloc] initWithUTF8String:]
[22:29:04] <akalin> yay
[22:29:06] *** Venom_X has quit IRC
[22:29:07] *** Venom_X_ is now known as Venom_X
[22:29:09] <rohitrao> trungl: there should be a base util method to convert from ascii
[22:29:10] <trungl> that's my thought too
[22:29:26] *** fta has joined #chromium
[22:29:28] <rohitrao> oh, maybe not from char* to nsstring
[22:29:32] <akalin> what rsesek said sounds right
[22:29:42] <rohitrao> trungl: clearly you should convert to a wstring and back
[22:29:50] <rsesek> there's no convenience class method, much to my dismay
[22:30:03] <trungl> rsesek: there is so, unless it's 10.6-only
[22:30:10] <rsesek> lies!
[22:30:21] <trungl> I mean, +stringWithCharacters:length:
[22:30:29] <rsesek> oh but then you have to pass a length
[22:30:33] <rsesek> different method :P
[22:30:38] <trungl> that's okay
[22:30:53] <rsesek> oh there is |+stringWithUTF8String:|
[22:30:54] <rohitrao> would base::SysUtf8ToNSString() work?
[22:30:54] <rsesek> I'm the liar
[22:31:00] <finnur> rohitrao: sorry, I was in a meeting. Looking
[22:31:12] <akalin> oh there it is
[22:31:19] <trungl> rohitrao: wouldn't that require going through std::string ?
[22:31:24] <rohitrao> is that bad?
[22:31:33] <trungl> rohitrao: <shrug>
[22:31:45] <rohitrao> yeah
[22:32:02] <trungl> rohitrao: mostly I'm wondering how I should reform the @"about:whatever" URLs hardcoded into our Mac about box code
[22:32:11] <trungl> rohitrao: clearly we should use chrome::k...URL
[22:32:18] <rohitrao> trungl: we use stringWithUTF8String in a few places
[22:32:51] *** mpcomplete has joined #chromium
[22:32:51] *** ChanServ sets mode: +v mpcomplete
[22:32:55] <trungl> rohitrao: good enough for me
[22:32:59] <rohitrao> trungl: although amusingly enough, only in places where the base:: method would suffice
[22:33:00] <mirandac> bgmerrell: ping
[22:33:06] <rohitrao> since we always call it on something.c_str()
[22:33:24] * trungl sighs
[22:33:26] <bgmerrell> mirandac: pong
[22:33:40] <rsesek> I wouldn't roundtrip through std::string unless necessary
[22:33:49] <mirandac> bgmerrell: sorry, was afk -- saw you had oop import q relating to mac?
[22:34:12] *** peterdn has joined #chromium
[22:34:37] <finnur> rohitrao: yeah, I can mark it as flaky on chromeos, that's where it is failing right now
[22:34:41] *** nirnimesh has quit IRC
[22:34:49] <rohitrao> finnur: sounds good, thanks
[22:35:05] *** nirnimesh has joined #chromium
[22:35:37] <bgmerrell> mirandac: i am working on porting the Windows import capabilities (at least importing bookmarks, at this point) to Linux.  evmar suggested looking at the Mac import code as an alternative approach, but I couldn't find it.
[22:35:54] <bgmerrell> rsesek: thanks for the link, btw
[22:35:58] <rsesek> np
[22:36:31] <mirandac> bgmerrell: yes, it's in the link sent by rsesek, but the patch isn't quite finished.  mostly there, though.  the oop structure is all present.  anything specific you were looking for?
[22:37:02] <trungl> rsesek / akalin / rohitrao: +stringWithUTF8String: is surely the right answer -- it doesn't even pretend to take a unichar*
[22:37:22] <akalin> mm
[22:37:24] <rsesek> trungl++
[22:37:53] <akalin> just cast the char* to an NSString*, problem solved
[22:38:06] <akalin> it's Obj-C magic ;)
[22:39:45] <akalin> (april fools!)
[22:40:54] *** quma has quit IRC
[22:40:56] *** nirnimesh has quit IRC
[22:41:22] <bgmerrell> mirandac: nothing specific currently, there isn't really any first run silent import code for Linux.  I'll keep an eye on the Mac patch to see if it would be worth doing the same sort of thing for Linux.
[22:41:48] *** nirnimesh has joined #chromium
[22:41:56] <jar> roharito: Did you do the clobber reqquests?
[22:42:03] <mirandac> bgmerrell: ok.  let me know if you have any specific questions...
[22:42:10] <rohitrao> jar: trungl clobbered after his grd change
[22:42:22] <bgmerrell> at this point, i'm mostly just looking to implement the first run silent importing for Linux.
[22:42:26] <bgmerrell> mirandac: thanks
[22:42:45] <jar> rohitrao: I don't see the clobber requests in the build tree
[22:42:58] *** kwinz2 has quit IRC
[22:43:02] <jar> It looks like ordinary builds
[22:43:18] <rohitrao> jar: hidden behind another build: http://chrome-buildbot.corp.google.com:8010/builders/Chromium%20Builder%20(dbg)/builds/18512
[22:44:37] <willchan_> leiz: ping
[22:46:11] *** hrna has quit IRC
[22:46:49] <jar> rohitrao: Anothre build just started... caused by a checkin.... and now there is nothing pending... and no clobber yet that I could find
[22:47:16] <jar> What am I missing?
[22:47:55] <rohitrao> for "Chromium Builder", build 26515 r43376 was a clobber build
[22:48:05] <rohitrao> for "Chromium Builder (dbg)
[22:48:31] <rohitrao> r43370-r43376 was build 18511
[22:48:46] <rohitrao> r43378-r43381 is build 18513
[22:49:00] <jar> I see the dbg clobber... but not the regular build clobber
[22:49:08] <rohitrao> build 18512 was the clobber build, and rebuilt the same code as 18511, so it doesn't show up separately on the waterfall
[22:50:02] <rohitrao> http://chrome-buildbot.corp.google.com:8010/builders/Chromium%20Builder/builds/25615 was the non-dbg clobber
[22:50:18] *** tfarina has quit IRC
[22:50:23] <finnur> rohitrao: http://codereview.chromium.org/1575015
[22:51:15] <rohitrao> finnur: lgtm, thanks
[22:51:50] *** dpranke has joined #chromium
[22:51:51] *** ChanServ sets mode: +v dpranke
[22:52:30] *** pfeldman_ has joined #chromium
[22:52:49] *** Rostislav has quit IRC
[22:53:22] <akalin> "Your connection to newtab is not encrypted"
[22:53:23] <akalin> lol
[22:53:26] *** andybons_mobile has joined #chromium
[22:53:52] *** rubenbb1 has quit IRC
[22:54:01] <rohitrao> akalin: OH NOES!
[22:54:55] *** loislo has quit IRC
[22:55:42] *** rubenbb has joined #chromium
[22:55:55] <shess> Is label "Decider" still the right way to punt a bug?
[22:56:36] *** pfeldman has quit IRC
[22:56:36] *** pfeldman_ is now known as pfeldman
[22:56:44] *** miketaylr has quit IRC
[22:56:51] *** dmaclach_ has joined #chromium
[22:57:06] *** dmaclach has quit IRC
[22:57:06] *** dmaclach_ is now known as dmaclach
[22:59:38] <leiz> willchan_: pong
[22:59:56] *** ROBOd has quit IRC
[23:00:53] <willchan_> leiz: was just going to ask you if 38972 still occurs on latest chrome/linux releases.  i did a simple search for HandleInitCompletion(), but don't see it anymore.  i closed the bug.
[23:03:11] <gkelly> Anyone know off-hand how to get the absolute position of a TabContents, or a RenderViewHost?
[23:03:32] *** hrna has joined #chromium
[23:04:42] *** bartex has quit IRC
[23:04:45] *** bartex has joined #chromium
[23:06:05] *** oncenull has joined #chromium
[23:07:04] *** MissAlyx| is now known as alyxuk|
[23:07:23] <evmar> gkelly: absolute compared to what?
[23:08:20] <rohitrao> evmar: :)
[23:08:39] <gkelly> evmar: Screen. If I can get the GtkWidget associated with the tab contents then I can use gtk_widget_translate_coordinates, but I was wondering if there was an easier way.
[23:09:11] <evmar> screen or monitor? does xinerama change things?  etc
[23:09:18] <evmar> (what are you trying to do?)
[23:09:29] <evmar> rohitrao: there is no absolute, when it comes to coordinates.  :)
[23:11:14] <gkelly> evmar: Screen, and xinerama isn't an issume.
[23:11:37] <oncenull> Hello, I want to build an extension to open and save mht files. Is it possible to do it as a simple chrome extension? I don't want to create a NPAPI plugin
[23:11:52] <gkelly> evmar: I'm doing some hackiness for a demo that requires having the position of the tab contents, so I can translate some other events by.
[23:12:11] <evmar> you might be able to use widget->window to get GdkWindow, then use a function on it to get its position
[23:12:18] *** Xpistos has joined #chromium
[23:12:44] <Xpistos> oh thank god! Is there anyway to get Chrome to stop closing my tabs when I double click them by accident?
[23:12:51] <Xpistos> This is driving me crazy
[23:13:18] <evmar> Xpistos: please see the channel topic
[23:13:52] *** GeekShadow has joined #chromium
[23:13:55] <akalin> that's weird, tabs don't close when i double click them
[23:14:09] *** andybons has quit IRC
[23:15:22] <Xpistos> sorry
[23:15:24] <rohitrao> shess: did you figure out how to punt a bug?
[23:15:26] *** sundiamonde has joined #chromium
[23:15:51] <rsesek> where is thakis?
[23:15:53] <shess> rohitrao: I think it's "describe reasons and mark Decider".  But if that doesn't work I'll just mark it Mstone-6 :-).
[23:15:54] *** Xpistos has left #chromium
[23:16:03] <rohitrao> k
[23:16:18] <akalin> who is thakis?
[23:16:27] *** tav has quit IRC
[23:16:34] <rsesek> Nico, yaknow?
[23:16:52] *** tav has joined #chromium
[23:17:21] *** tav is now known as ircnotworking
[23:17:45] *** tav has joined #chromium
[23:19:20] *** GeekShadow has quit IRC
[23:21:52] <gkelly> evmar: It looks like TabContents::GetContainerBounds might be the way to go.
[23:23:02] *** theliet has left #chromium
[23:24:04] *** dmaclach has quit IRC
[23:24:39] *** dstozek has joined #chromium
[23:27:13] *** thomasvl has quit IRC
[23:29:23] *** danno_ has joined #chromium
[23:30:14] *** rsesek has quit IRC
[23:30:32] *** rsesek has joined #chromium
[23:30:52] *** cbentzel has quit IRC
[23:31:06] *** dmazzoni has quit IRC
[23:34:25] *** rohitrao_ has joined #chromium
[23:34:25] *** ChanServ sets mode: +v rohitrao_
[23:34:29] *** rohitrao_ has quit IRC
[23:35:29] <jar> rohitrao: Do you know what "Page Cycler Database" redness is all about?
[23:39:20] *** monreal has quit IRC
[23:42:02] <rohitrao> jar: related to http://src.chromium.org/viewvc/chrome?view=rev&revision=43381?
[23:44:52] *** mirandac is now known as mirandac_afk
[23:45:51] <skerner> pinkerton, rohitrao: I think you two were looking at mac quitting issues.  Does the stack in crbug.com/40057 look like it could be related to the issues you saw?
[23:45:56] *** rsesek has quit IRC
[23:52:11] *** Peter` has quit IRC
[23:55:31] *** jrmuizel has quit IRC
[23:55:55] <rohitrao> jar: going to reopen, looks flaky
[23:56:09] *** roc has quit IRC
[23:56:29] <leiz> I was just going to say.... eroman couldn't have broken the tree with his cl
[23:56:42] <jar> rohitrao: ok... but update status with expectations
[23:57:35] *** Peter` has joined #chromium
[23:58:09] <leiz> we can wait and see what the next test run does, I imagine it'll go green.
[23:58:34] *** michaeln has joined #chromium
[23:58:47] <rohitrao> jar: and michaeln's revert should fix the windows failures
[23:59:51] *** EGreg has quit IRC





top