[00:13:54] *** lipsinV2 has joined #chromium-os
[00:28:23] <rsleevi> cmasone: It was likely http://crrev.com/91323 that broke ARM PFQ. It isn't pulled in via DEPS, I don't believe, but pulled in directly
[00:29:11] <cmasone> rsleevi: oh, I assumed it was a DEPS thing, but I forgot that there's third_party stuff right in there too.  Duh.
[00:30:04] <rsleevi> no clue why it would work on x86 though, it looks bad all around for non-OS_WIN
[00:32:05] <cmasone> rsleevi: yeah, I didn't think it was in the std:: namespace anywhere, but...
[00:35:10] <rsleevi> cmasone: Hrm, looking at my GCC 4.2.1 header on my Mac Mini, cstdio pulls in snprintf into std:: via a using
[00:38:46] <rsleevi> cmasone: default_logger.h includes logger.h which includes <cstdio>... So my guess is it works on GCC because of GNU-ism (the snprintf pulled in is from ::__gnu_cxx::snprintf, which may not be matched on the arm toolchain
[00:41:03] <cmasone> rsleevi: would it be "more correct" for that call in default_logger.cc to not include the std:: namespacing?
[00:42:20] <rsleevi> cmasone: I believe so, provided stdio.h was included. AFAICT from some brief searching, the std::snprintf is not part of the spec, but a GCC-ism. MSFT, for example, doesn't make it available (which this file deftly avoids by having the OS_WIN alternative).
[00:43:31] <cmasone> rsleevi: heh.  ok.  I will happily pull the std:: and run some tests, and run it through the trybots.  I can send the Cl to you, but I should probably also send it to georgey
[00:44:27] <rsleevi> sgtm. The upstream is http://code.google.com/p/libphonenumber/ - it appears that we've got it fully replicated in the tree though, rather than DEPS. No clue why.
[00:46:06] <cmasone> rsleevi: there's a nontrivial patch file...I hope I don't have to fix it by adding to that :-)
[00:47:32] <rsleevi> cmasone: Bah, just add an extra patch file imo. Not at all unprecedented in our patched third-party libs, and way easier than dealing with the monolithic patch files
[00:51:27] <cmasone> rsleevi: do you know how patches are usually applied?  There's no mention of the patch file in the libphonenumber.gyp file
[00:52:11] <rsleevi> cmasone: Applied directly to the sources. The patch files just track the diff from upstream, for/if when rolls happen. It's not like an RPM/DEB where the patch is applied prior to building.
[00:52:24] <cmasone> rsleevi: ah!
[00:53:03] <rsleevi> cmasone: Interesting. I rarely look at the CrOS waterfall - I see there are several bots setup to build with gcc 4.6. Is CrOS looking to migrate at some point?
[00:54:08] <cmasone> rsleevi: yes.  Sometime next quarter, I think?  Mabye Q4, not sure.  The toolchain guys have filed bugs on us for our own packages, asking us to fix specific things that make them fail to build with 4.6
[00:54:31] <cmasone> rsleevi: not sure what they're doing with upstream stuff, or with chromium
[00:56:02] <rsleevi> cmasone: http://crbug.com/80071 and http://crbug.com/87490 . Chromium should compile with -Werror off now. I had a patchset to disable -Werror for GCC 4.6 by default, but held off applying because on the Chromium side we already had documentation saying to use includes.gypi. If you guys are looking to test, it should be easy to re-apply and would at least get you past that part
[00:57:23] <cmasone> rsleevi: thanks, I'll tell raymes and ahmad about it!
[01:28:00] *** D|sT has quit IRC
[01:29:52] *** petermayo has joined #chromium-os
[01:29:52] *** ChanServ sets mode: +v petermayo
[01:36:49] *** AndrewN has joined #chromium-os
[01:36:49] *** AndrewN has joined #chromium-os
[01:37:31] *** AndrewN is now known as AndrewN[AFK]
[01:41:53] *** AndrewN[AFK] is now known as AndrewN
[01:52:56] *** Styx has quit IRC
[01:58:16] *** TW1920 has quit IRC
[02:00:29] *** uncola has joined #chromium-os
[02:00:33] <uncola> ok
[02:00:51] <uncola> I'll pay $1000 to anyone who can hack x-chat into a chrome window for my chromebook
[02:00:53] <uncola> dead serious
[02:04:11] *** JasonO has quit IRC
[02:49:37] *** sadrul has quit IRC
[02:52:27] *** lemon has joined #chromium-os
[02:52:33] *** petermayo has quit IRC
[02:52:37] *** petermayo_ has joined #chromium-os
[02:52:37] *** ChanServ sets mode: +v petermayo_
[02:54:48] <lemon> hello! I have a few questions about the dd portion of setting up a dual boot chrome OS. Is there anyone who might be able to answer them around?
[03:00:13] *** lemon is now known as tri
[03:00:17] *** tri is now known as triacle
[03:00:57] *** sadrul has joined #chromium-os
[03:00:58] *** ChanServ sets mode: +v sadrul
[03:02:14] *** AndrewN is now known as AndrewN[AFK]
[03:07:37] *** AndrewN[AFK] is now known as AndrewN
[03:22:52] <rsleevi> cmasone: Not sure what's up with commit-bot rejecting it. The /trunk/src OWNERS should have applied, which is * ....
[03:23:10] <cmasone> rsleevi: yeah, that's waht I thought
[03:23:26] <cmasone> should I git cl push manually, or wait for george, you think?
[03:26:11] <rsleevi> cmasone: My instinct is to blame commit-bot and say git cl dcommit manually . I'm looking through the sources to see if I can find why it doesn't like me. I'm assuming that you CQ-ed post patchset 2?
[03:26:59] <cmasone> rsleevi: I did, so maybe it's confused and the problem is that it hasn't finished trybots for that patch set, yet?  But then it should just go ahead and schedule new try jobs
[03:27:32] <rsleevi> cmasone: The CQ queues up it's own tryjobs and won't try until they finish, so you should be fine.
[03:32:45] *** AndrewN is now known as AndrewN[AFK]
[03:33:46] <rsleevi> cmasone: Possibly check https://chromium-access.appspot.com/auto/mapping - which is where commit-bot gets it's list of committers. I don't think non- at google dot com can access that URL; I certainly can't with my @chromium.org
[03:33:46] *** noahric has left #chromium-os
[03:35:09] <cmasone> rsleevi: "nothing to see here"
[03:37:26] <rsleevi> cmasone: Ah, I fail - just realized it uses a password stored on the buildbot to get the list. So it's even more restrictive than simple AppEngine checks. Yeah, I have no clue why commit-bot doesn't like my LGTM, and I believe maruel is out for a week or two. Up to you whether to push it through, but I promise I can LGTM - just look and the Chromium waterfall, I'm committing ;-)
[03:38:01] <cmasone> rsleevi: oh, I've seen you around the lists and such, I know you're a committer and all.
[03:38:05] <cmasone> ok, I'll dcommit
[03:38:26] <cmasone> if I need to revert later, I can :-)
[03:38:33] <cmasone> thanks for all the help today!
[03:40:05] <rsleevi> n/p
[03:41:08] *** triacle has left #chromium-os
[03:52:15] *** AndrewN[AFK] is now known as AndrewN
[03:56:03] *** sadrul has quit IRC
[04:22:43] *** jep has joined #chromium-os
[04:23:06] *** oc80z has quit IRC
[04:24:34] *** oc80z has joined #chromium-os
[04:30:06] *** sadrul has joined #chromium-os
[04:30:06] *** ChanServ sets mode: +v sadrul
[04:30:13] *** AndrewN has quit IRC
[04:48:00] *** unreal has quit IRC
[04:52:17] *** unreal has joined #chromium-os
[05:10:35] *** e_t_ has quit IRC
[05:18:10] *** varunjain has quit IRC
[05:25:06] *** dtu has left #chromium-os
[05:25:32] *** uncola has left #chromium-os
[05:27:27] *** petermayo_ has quit IRC
[05:46:54] *** oc80z has quit IRC
[05:47:47] *** oc80z has joined #chromium-os
[06:24:56] *** jep has quit IRC
[08:15:03] *** patcito has quit IRC
[08:59:25] *** thebp has joined #chromium-os
[08:59:45] <thebp> helo
[09:00:29] <thebp> anyone home?
[09:01:24] *** thebp is now known as marcos
[09:01:53] *** marcos is now known as Guest33615
[09:02:05] *** Guest33615 has left #chromium-os
[09:24:42] *** MMirabent has joined #chromium-os
[09:27:29] <MMirabent> hello all
[09:29:21] <MMirabent> i need some help building my chromium os image
[09:32:47] <MMirabent> quit
[09:32:49] *** MMirabent has quit IRC
[09:44:42] *** jochen__ has quit IRC
[09:44:49] *** jochen__ has joined #chromium-os
[09:44:49] *** ChanServ sets mode: +v jochen__
[09:51:31] *** TW1920 has joined #chromium-os
[09:53:09] *** Administrator has joined #chromium-os
[09:53:36] *** Administrator is now known as Guest48254
[09:55:28] *** Guest48254 has quit IRC
[09:57:06] *** TW1920 has quit IRC
[10:04:18] *** TW1920 has joined #chromium-os
[10:09:28] *** lipsinV2 has quit IRC
[10:09:32] *** lipsinV21 has joined #chromium-os
[10:15:43] *** lipsinV21 has quit IRC
[10:15:46] *** lipsinV2 has joined #chromium-os
[10:29:04] *** vmil86 has joined #chromium-os
[11:04:54] *** TW1920 has quit IRC
[11:06:12] *** TW1920 has joined #chromium-os
[11:07:36] *** Styx has joined #chromium-os
[11:47:18] *** SoulRaven has joined #chromium-os
[11:48:19] *** McMAGIC--Copy has quit IRC
[11:59:11] *** McMAGIC--Copy has joined #chromium-os
[12:05:39] *** McMAGIC--Copy has quit IRC
[12:08:35] *** McMAGIC--Copy has joined #chromium-os
[12:20:49] *** McMAGIC--Copy has quit IRC
[12:23:12] *** tushar6261 has joined #chromium-os
[12:25:01] *** tushar6261 has quit IRC
[12:25:24] *** tushar6261 has joined #chromium-os
[12:28:34] *** tushar6261 has quit IRC
[12:35:05] *** McMAGIC--Copy has joined #chromium-os
[12:41:44] *** anicolao_ has joined #chromium-os
[12:44:59] *** anicolao has quit IRC
[12:47:24] *** flackr has quit IRC
[12:47:48] *** anicolao_ has quit IRC
[13:14:57] <crosbot> tree became 'Tree is open (sheriffs gone, you break it, you fix it)'
[13:15:47] *** lipsinV2 has quit IRC
[14:11:50] *** Styx has quit IRC
[14:53:41] *** lipsinV2 has joined #chromium-os
[17:22:20] *** Greboid has quit IRC
[17:22:31] *** Greboid has joined #chromium-os
[17:48:19] *** oc80z has quit IRC
[17:48:20] *** oc80z has joined #chromium-os
[17:50:46] *** TW1920_ has joined #chromium-os
[17:53:56] *** TW1920 has quit IRC
[18:08:03] *** magn3ts has quit IRC
[18:11:06] *** lipsinV2 has quit IRC
[18:11:07] *** magn3ts has joined #chromium-os
[18:12:44] *** magn3ts has quit IRC
[18:13:39] *** magn3ts has joined #chromium-os
[18:59:56] *** jep has joined #chromium-os
[19:13:01] *** Sthebig has quit IRC
[19:39:20] *** Sthebig has joined #chromium-os
[20:17:33] *** Styx has joined #chromium-os
[20:40:43] <crosbot> tree became 'Tree is closed (Automatic: "cbuildbot" on "x86-mario-binary" from 9086273a308a90634c8cdafecf87fdb506f72bec: _third_party_ at chromium dot org)'
[20:49:21] *** BladeFreak has joined #chromium-os
[20:54:44] *** jackhammer2022 has joined #chromium-os
[21:02:57] *** patcito has joined #chromium-os
[21:03:12] <crosbot> tree became 'Tree is open (tests timed out only on some bots = Flake?; sheriffs gone, you break it, you fix it)'
[21:30:59] *** jep has quit IRC
[21:43:50] *** SoulRaven has quit IRC
[21:49:16] *** SoulRaven has joined #chromium-os
[21:50:11] *** jackhammer2022 has quit IRC
[22:10:13] *** cooled has quit IRC
[22:11:26] *** SoulRaven has quit IRC
[22:23:42] *** oc80z has quit IRC
[22:25:12] *** oc80z has joined #chromium-os
[22:28:41] *** cooled has joined #chromium-os
[22:39:03] *** jrbarnette has joined #chromium-os
[22:40:39] *** JasonO has joined #chromium-os
[22:41:41] *** jrbarnette_ has joined #chromium-os
[22:41:42] *** ChanServ sets mode: +v jrbarnette_
[22:45:32] *** jrbarnette has quit IRC
[22:45:32] *** jrbarnette_ is now known as jrbarnette
[23:01:55] *** JasonO has quit IRC
[23:02:52] *** cooled has quit IRC
[23:24:31] *** cooled has joined #chromium-os
[23:25:00] *** jrbarnette_ has joined #chromium-os
[23:27:39] *** jrbarnette has quit IRC
[23:27:39] *** jrbarnette_ is now known as jrbarnette
[23:35:54] *** leavittx has joined #chromium-os
[23:39:42] *** jrbarnette has quit IRC
[23:44:06] *** TW1920_ has quit IRC





top